gdb/ChangeLog

   1 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * configure: Regenerate.
   4         * configure.ac: Remove check for strerror_r.
   5         * gdbsupport/common.m4: Check for strerror_r.
   6
   7 2019-11-01  Luis Machado  <luis.machado@linaro.org>
   8
   9         PR gdb/25124
  10
  11         * arm-tdep.c (arm_per_objfile): Rename to ...
  12         (arm_per_bfd): ... this.
  13         (arm_objfile_data_key): Rename to ...
  14         (arm_bfd_data_key): ... this.
  15         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
  16         data.
  17         (arm_record_special_symbol): Likewise.
  18
  19 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  20
  21         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
  22         end.
  23         * c-typeprint.c (c_print_typedef): Likewise.
  24         * f-typeprint.c (f_print_typedef): Likewise.
  25         * m2-typeprint.c (m2_print_typedef): Likewise.
  26         * p-typeprint.c (pascal_print_typedef): Likewise.
  27         * rust-lang.c (rust_print_typedef): Likewise.
  28         * symtab.c (print_symbol_info): Print a newline after calling
  29         typedef_print.
  30
  31 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * symtab.c (info_module_cmdlist): New variable.
  34         (info_module_command): New function.
  35         (search_module_symbols): New function.
  36         (info_module_subcommand): New function.
  37         (struct info_modules_var_func_options): New struct.
  38         (info_modules_var_func_options_defs): New variable.
  39         (make_info_modules_var_func_options_def_group): New function.
  40         (info_module_functions_command): New function.
  41         (info_module_variables_command): New function.
  42         (info_module_var_func_command_completer): New function.
  43         (_initialize_symtab): Register new 'info module functions' and
  44         'info module variables' commands.
  45         * symtab.h (typedef symbol_search_in_module): New typedef.
  46         (search_module_symbols): Declare new function.
  47         * NEWS: Mention new commands.
  48
  49 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  50
  51         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
  52         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
  53         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
  54         MODULES_DOMAIN.
  55         (scan_partial_symbols): Only create partial module symbols for non
  56         declarations.
  57         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
  58         and MODULES_DOMAIN.
  59         * symtab.c (search_domain_name): Likewise.
  60         (search_symbols): Likewise.
  61         (print_symbol_info): Likewise.
  62         (symtab_symbol_info): Likewise.
  63         (info_modules_command): New function.
  64         (_initialize_symtab): Register 'info modules' command.
  65         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
  66         * NEWS: Mention new 'info modules' command.
  67
  68 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  69
  70         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
  71         and $_gdb_maint_setting_str.
  72
  73 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  74
  75         * cli/cli-cmds.c (setting_cmd, value_from_setting)
  76         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
  77         (str_value_from_setting, gdb_setting_str_internal_fn)
  78         (gdb_maint_setting_str_internal_fn): New functions.
  79         (_initialize_cli_cmds): Define the new convenience functions.
  80         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
  81         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  82
  83 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  84
  85         * agent.c (set_can_use_agent): When the setting is turned on,
  86         look up agent symbols if we don't have them yet.
  87         (agent_new_objfile): Don't look up agent symbols when the agent
  88         setting is off.
  89
  90 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * config.in: Regenerate.
  93
  94 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * configure: Regenerate.
  97         * configure.ac: Check for strerror_r.
  98         * gdbsupport/common-utils.h (safe_strerror): Change return value
  99         to const char * and document that this function is now threadsafe.
 100         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 101         thread_local and call strerror_r, if available.
 102         * utils.c (perror_string): Update.
 103         (print_sys_errmsg): Update.
 104
 105 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 106
 107         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 108         objfile_key.
 109         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 110         objfile to fetch per-bfd data.
 111         (arm_find_exidx_entry): Likewise.
 112
 113 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 114
 115         * gdbsupport/agent.c (debug_agent): Change type to bool.
 116         (use_agent): Likewise.
 117         (all_agent_symbols_look_up): Likewise.
 118         (agent_loaded_p): Change return value to bool.
 119         (agent_look_up_symbols): Update.
 120         (agent_capability_check): Change return value to bool.
 121         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 122         (debug_agent): Change type to bool.
 123         (use_agent): Likewise.
 124         (agent_capability_check): Change return value to bool.
 125
 126 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 127
 128         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 129         (build_minimal_symbol_hash_tables): Code to clear the table moved
 130         to clear_minimal_symbol_hash_tables.
 131         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 132         when needed.
 133
 134 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 135
 136         * infcmd.c: Remove includes.
 137         * infrun.c: Remove includes.
 138
 139 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 140
 141         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 142         (grow_vect): Remove declaration.
 143         (ada_type_of_array): Remove declaration.
 144         (ada_update_initial_language): Remove declaration.
 145         (ada_fold_name): Remove declaration.
 146         (ada_fill_in_ada_prototype): Remove declaration.
 147         (user_select_syms): Remove declaration.
 148         (get_selections): Remove declaration.
 149         (ada_tag_type): Remove declaration.
 150         (ada_value_tag): Remove declaration.
 151         (ada_is_others_clause): Remove declaration.
 152         (ada_in_variant): Remove declaration.
 153         (ada_value_struct_elt): Remove declaration.
 154         (ada_attribute_name): Remove declaration.
 155         (ada_system_address_type): Remove declaration.
 156         * ada-lang.c (ada_watch_location_expression): Make static.
 157         (GROW_VECT): Move here from ada-lang.h.
 158         (grow_vect): Make static.
 159         (ada_update_initial_language): Make static.
 160         (ada_fold_name): Make static.
 161         (ada_type_of_array): Make static.
 162         (encoded_ordered_before): Move up.
 163         (sort_choices): Move up.
 164         (print_signatures): Move up.
 165         (ada_print_symbol_signature): Move up.
 166         (get_selections): Move up and make static.
 167         (user_select_syms): Move up and make static.
 168         (ada_value_struct_elt): Move up and make static.
 169         (ada_tag_type): Make static.
 170         (ada_value_tag): Make static.
 171         (ada_is_others_clause): Make static.
 172         (ada_in_variant): Make static.
 173         (ada_attribute_name): Make static.
 174
 175 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 176
 177         * ada-lang.c: Remove includes.
 178         * ada-typeprint.c: Remove includes.
 179         * ada-valprint.c: Remove includes.
 180
 181 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 182
 183         * addrmap.c: Add static assertions of type size, moved from
 184         _initialize_addrmap.
 185         (_initialize_addrmap): Remove.
 186
 187 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 188
 189         * coffread.c (record_minimal_symbol): Update.
 190         (process_coff_symbol): Update.
 191         * dbxread.c (read_dbx_symtab): Update.
 192         * dwarf2read.c (add_partial_symbol): Update.
 193         (fixup_go_packaging): Update.
 194         (load_partial_dies): Update.
 195         (new_symbol): Update.
 196         * elfread.c (record_minimal_symbol): Change signature to use
 197         gdb::string_view instead of name+len.
 198         (elf_symtab_read): Update.
 199         (elf_rel_plt_read): Update.
 200         * mdebugread.c (parse_partial_symbols): Update.
 201         (handle_psymbol_enumerators): Update.
 202         (new_symbol): Update.
 203         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 204         to use gdb::string_view instead of name+len.
 205         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 206         * psympriv.h (add_psymbol_to_list): Likewise.
 207         * psymtab.c (add_psymbol_to_bcache): Likewise.
 208         (add_psymbol_to_list): Likewise.
 209         * stabsread.c (define_symbol): Update.
 210         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 211         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 212         (symbol_set_names): Likewise.
 213         * xcoffread.c (scan_xcoff_symtab): Update.
 214
 215 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 216
 217         * symtab.h (symbol_set_names): Document that copy_name must be
 218         set to true for non-nullterminated strings.
 219         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 220         linkage_name if the entry was not found and we need to demangle.
 221
 222 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 223
 224         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 225         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 226         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 227         * gdbsupport/gdb_binary_search.h: New file.
 228
 229 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 230
 231         * NEWS: Mention new --with-system-gdbinit-dir option.
 232         * config.in: Regenerate.
 233         * configure: Regenerate.
 234         * configure.ac: Add new option --with-system-gdbinit-dir.
 235         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 236         for a ".gdb" suffix.
 237         * main.c (get_init_files): Change system_gdbinit argument to
 238         a vector and return the files in SYSTEM_GDBINIT_DIR in
 239         addition to SYSTEM_GDBINIT.
 240         (captured_main_1): Update.
 241         (print_gdb_help): Update.
 242         * top.c (print_gdb_configuration): Also print the value of
 243         SYSTEM_GDBINIT_DIR.
 244
 245 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 246
 247         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 248         that takes gdb::string_view arguments.
 249
 250 2019-10-26  Tom de Vries  <tdevries@suse.de>
 251
 252         * aarch64-linux-tdep.c: Fix typos in comments.
 253         * aarch64-tdep.c: Same.
 254         * ada-lang.c: Same.
 255         * amd64-nat.c: Same.
 256         * arc-tdep.c: Same.
 257         * arch/aarch64-insn.c: Same.
 258         * block.c: Same.
 259         * breakpoint.h: Same.
 260         * btrace.h: Same.
 261         * c-varobj.c: Same.
 262         * cli/cli-decode.c: Same.
 263         * cli/cli-script.c: Same.
 264         * cli/cli-utils.h: Same.
 265         * coff-pe-read.c: Same.
 266         * coffread.c: Same.
 267         * compile/compile-cplus-symbols.c: Same.
 268         * compile/compile-object-run.c: Same.
 269         * completer.c: Same.
 270         * corelow.c: Same.
 271         * cp-support.c: Same.
 272         * demangle.c: Same.
 273         * dwarf-index-write.c: Same.
 274         * dwarf2-frame.c: Same.
 275         * dwarf2-frame.h: Same.
 276         * eval.c: Same.
 277         * frame-base.h: Same.
 278         * frame.h: Same.
 279         * gdbcmd.h: Same.
 280         * gdbtypes.h: Same.
 281         * gnu-nat.c: Same.
 282         * guile/scm-objfile.c: Same.
 283         * i386-tdep.c: Same.
 284         * i386-tdep.h: Same.
 285         * infcall.c: Same.
 286         * infcall.h: Same.
 287         * linux-nat.c: Same.
 288         * m68k-tdep.c: Same.
 289         * macroexp.c: Same.
 290         * memattr.c: Same.
 291         * mi/mi-cmd-disas.c: Same.
 292         * mi/mi-getopt.h: Same.
 293         * mi/mi-main.c: Same.
 294         * minsyms.c: Same.
 295         * nat/aarch64-sve-linux-sigcontext.h: Same.
 296         * objfiles.h: Same.
 297         * ppc-linux-nat.c: Same.
 298         * ppc-linux-tdep.c: Same.
 299         * ppc-tdep.h: Same.
 300         * progspace.h: Same.
 301         * prologue-value.h: Same.
 302         * python/py-evtregistry.c: Same.
 303         * python/py-instruction.h: Same.
 304         * record-btrace.c: Same.
 305         * record-full.c: Same.
 306         * remote.c: Same.
 307         * rs6000-tdep.c: Same.
 308         * ser-tcp.c: Same.
 309         * sol-thread.c: Same.
 310         * sparc-sol2-tdep.c: Same.
 311         * sparc64-tdep.c: Same.
 312         * stabsread.c: Same.
 313         * symfile.c: Same.
 314         * symtab.h: Same.
 315         * target.c: Same.
 316         * tracepoint.c: Same.
 317         * tui/tui-data.h: Same.
 318         * tui/tui-io.c: Same.
 319         * tui/tui-win.c: Same.
 320         * tui/tui.c: Same.
 321         * unittests/rsp-low-selftests.c: Same.
 322         * user-regs.h: Same.
 323         * utils.c: Same.
 324         * utils.h: Same.
 325         * valarith.c: Same.
 326         * valops.c: Same.
 327         * valprint.c: Same.
 328         * valprint.h: Same.
 329         * value.c: Same.
 330         * value.h: Same.
 331         * varobj.c: Same.
 332         * x86-nat.h: Same.
 333         * xtensa-tdep.c: Same.
 334
 335 2019-10-25  Ali Tamur <tamur@google.com>
 336
 337         * charset.c (find_charset_names): Reflect API change.
 338
 339 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 340
 341         * symtab.c (struct demangled_name_entry): Change demangled name
 342         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 343         part of the struct anymore.
 344         (symbol_set_names): No longer obstack allocate + copy the demangled
 345         name, just store the allocated name from bfd.
 346
 347 2019-10-25  Tom Tromey  <tromey@adacore.com>
 348
 349         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 350         (bsearch_cie_cmp, add_cie): Remove.
 351         (find_cie): Reimplement.
 352         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 353         (dwarf2_build_frame_info): Update.
 354
 355 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 356
 357         PR gdb/25126
 358         * symfile.c (reread_symbols): Call forget_cached_source_info to
 359         clear the stale source cache.
 360
 361 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 362
 363         * configure: Regenerate.
 364         * configure.ac: Remove code that sets python_has_threads.
 365
 366 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 367
 368         * config.in: Regenerate.
 369         * configure: Regenerate.
 370         * configure.ac: Remove the code that uses sed to get the python
 371         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 372
 373 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 376         error paths.
 377
 378 2019-10-23  Tom Tromey  <tom@tromey.com>
 379
 380         * arc-tdep.c: Remove ".." from include.
 381         * frv-tdep.c: Remove ".." from include.
 382         * lm32-tdep.c: Remove ".." from include.
 383         * microblaze-tdep.c: Remove ".." from include.
 384         * or1k-tdep.h: Remove ".." from include.
 385         * s12z-tdep.c: Remove ".." from include.
 386         * Makefile.in (OPCODES_CFLAGS): Add comment.
 387         (TOP_CFLAGS): New variable.
 388         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 389
 390 2019-10-23  Tom Tromey  <tom@tromey.com>
 391
 392         * Makefile.in (READLINE_DIR): Update.
 393
 394 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 395
 396         * infcall.c (call_function_by_hand_dummy): Fix the function
 397         comment.  And extract out a code section into...
 398         (reserve_stack_space): ...this new function.
 399
 400 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 401
 402         * infcall.c (value_arg_coerce): Remove an unused parameter.
 403         (call_function_by_hand_dummy): Update the call to
 404         'value_arg_coerce'.
 405
 406 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 407
 408         * infcall.c (call_function_by_hand_dummy): Refactor.
 409
 410 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 411
 412         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 413
 414 2019-10-23  Tom Tromey  <tom@tromey.com>
 415
 416         * configure: Rebuild.
 417         * configure.ac: Don't check for sigprocmask.
 418         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 419
 420 2019-10-23  Tom Tromey  <tom@tromey.com>
 421
 422         * configure: Rebuild.
 423         * acinclude.m4: Use m4_include, not sinclude.
 424
 425 2019-10-23  Tom de Vries  <tdevries@suse.de>
 426
 427         PR breakpoints/24687
 428         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 429
 430 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 431
 432         * symtab.c (struct demangled_name_entry) <language>: Change from
 433         bitfield to regular variable.
 434
 435 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 436
 437         * symtab.c (struct demangled_name_entry): Add a constructor.
 438         (free_demangled_name_entry): New function to call the destructor
 439         for demangled_name_entry.
 440         (create_demangled_names_hash): Pass free_demangled_name_entry to
 441         htab_create_alloc.
 442         (symbol_set_names): Call placement new for demangled_name_entry.
 443         * utils.c: No longer include xxhash.h here, now that fast_hash
 444         is inlined in the header.
 445         * utils.h: Instead, include it here.
 446
 447 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 448
 449         * Makefile.in: Link with libxxhash.
 450         * config.in: Regenerate.
 451         * configure: Regenerate.
 452         * configure.ac: Search for libxxhash.
 453         * utils.c (fast_hash): Use xxhash if present.
 454
 455 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 456
 457         * utils.h (fast_hash): New function.
 458         * symtab.c (hash_demangled_name_entry): Call new function
 459         fast_hash.
 460
 461 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 462
 463         * symtab.c (struct demangled_name_entry): Change type of mangled
 464         to gdb::string_view. Also adds a constructor that takes the
 465         mangled name.
 466         (hash_demangled_name_entry): Update.
 467         (eq_demangled_name_entry): Update.
 468         (free_demangled_name_entry): New function to call the destructor
 469         now that this is not a POD anymore.
 470         (create_demangled_names_hash): Pass free_demangled_name_entry to
 471         htab_create_alloc.
 472         (symbol_set_names): Update.
 473
 474 2019-10-21  Ali Tamur  <tamu@google.com>
 475
 476         * dwarf2read.c (dir_index): Change type.
 477         (file_name_index): Likewise.
 478         (line_header::include_dir_at): Change comment and implementation on
 479         whether it is DWARF 5.
 480         (line_header::is_valid_file_index): New function.
 481         (line_header::file_name_at): Change comment and implementation on
 482         whether it is DWARF 5.
 483         (line_header::file_names): Change to private field renamed as
 484         m_file_names and introduce a new accessor method.
 485         (line_header::file_names_size): New method.
 486         (line_header::include_dirs): Change to private field and rename as
 487         m_include_dirs.
 488         (dw2_get_file_names_reader): Define local var at a smaller scope and
 489         reflect API change.
 490         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 491         (process_structure_scope): Likewise.
 492         (line_header::add_include_dir): Change message and reflect renaming.
 493         (line_header::add_file_name): Likewise.
 494         (read_formatted_entries): Handle DW_FORM_data16.
 495         (dwarf_decode_line_header): Fix line header length calculation.
 496         (psymtab_include_file_name): Change comment and API.
 497         (lnp_state_machine::m_file): Update comment and reflect type change.
 498         (lnp_state_machine::record_line): Reflect type change.
 499         (dwarf_decode_lines): Reflect API change.
 500         (file_file_name): Likewise.
 501         (file_full_name): Likewise.
 502
 503 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 506
 507 2019-10-21  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 510
 511 2019-10-21  Tom Tromey  <tom@tromey.com>
 512
 513         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 514         NM_H.   Use AC_CONFIG_LINKS.
 515         * configure: Rebuild.
 516         * Makefile.in (NM_H): New variable.
 517         (generated_files): Add NM_H.  Remove gcore.
 518         (nm.h, stamp-nmh): New targets.
 519
 520 2019-10-20  Tom Tromey  <tom@tromey.com>
 521
 522         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 523         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 524         obsolete comment.
 525         (put_objfile_before): Now static.
 526
 527 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 528
 529         * gdbsupport/common-utils.h (startswith): Change return type to
 530         bool.
 531
 532 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 533
 534         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 535         * breakpoint.c (bp_locations_compare): Rename to...
 536         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 537         (update_global_location_list): Use std::sort instead of qsort.
 538         * buildsym.c (compare_line_numbers): Rename to...
 539         (lte_is_less_than): ...this, and change to std::sort semantics.
 540         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 541         instead of qsort.
 542         * disasm.c (compare_lines): Rename to...
 543         (line_is_less_than): ...this, and change to std::sort semantics.
 544         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 545         of qsort.
 546         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 547         (fde_is_less_than): ...this, and change to std::sort semantics.
 548         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 549         * mdebugread.c (compare_blocks):
 550         (block_is_less_than): ...this, and change to std::sort semantics.
 551         (sort_blocks): Call std::sort instead of qsort.
 552         * objfiles.c (qsort_cmp): Rename to...
 553         (sort_cmp): ...this, and change to std::sort semantics.
 554         (update_section_map): Call std::sort instead of qsort.
 555         * remote.c (compare_pnums): Remove.
 556         (map_regcache_remote_table): Call std::sort instead of qsort.
 557         * utils.c (compare_positive_ints): Remove.
 558         * utils.h (compare_positive_ints): Remove.
 559         * xcoffread.c (compare_lte): Remove.
 560         (arrange_linetable): Call std::sort instead of qsort.
 561
 562 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 563
 564         * symfile.c (init_entry_point_info): Fix typo.
 565         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 566
 567 2019-10-18  Tom de Vries  <tdevries@suse.de>
 568
 569         * aarch64-tdep.c: Fix typos in comments.
 570         * ada-lang.c: Same.
 571         * ada-tasks.c: Same.
 572         * alpha-tdep.c: Same.
 573         * alpha-tdep.h: Same.
 574         * amd64-nat.c: Same.
 575         * amd64-windows-tdep.c: Same.
 576         * arc-tdep.c: Same.
 577         * arc-tdep.h: Same.
 578         * arch-utils.c: Same.
 579         * arm-nbsd-tdep.c: Same.
 580         * arm-tdep.c: Same.
 581         * ax-gdb.c: Same.
 582         * blockframe.c: Same.
 583         * btrace.c: Same.
 584         * c-varobj.c: Same.
 585         * coff-pe-read.c: Same.
 586         * coffread.c: Same.
 587         * cris-tdep.c: Same.
 588         * darwin-nat.c: Same.
 589         * dbxread.c: Same.
 590         * dcache.c: Same.
 591         * disasm.c: Same.
 592         * dtrace-probe.c: Same.
 593         * dwarf-index-write.c: Same.
 594         * dwarf2-frame-tailcall.c: Same.
 595         * dwarf2-frame.c: Same.
 596         * dwarf2read.c: Same.
 597         * eval.c: Same.
 598         * exceptions.c: Same.
 599         * fbsd-tdep.c: Same.
 600         * findvar.c: Same.
 601         * frame.c: Same.
 602         * frv-tdep.c: Same.
 603         * gnu-v3-abi.c: Same.
 604         * go32-nat.c: Same.
 605         * h8300-tdep.c: Same.
 606         * hppa-tdep.c: Same.
 607         * i386-linux-tdep.c: Same.
 608         * i386-tdep.c: Same.
 609         * ia64-libunwind-tdep.c: Same.
 610         * ia64-tdep.c: Same.
 611         * infcmd.c: Same.
 612         * infrun.c: Same.
 613         * linespec.c: Same.
 614         * linux-nat.c: Same.
 615         * linux-thread-db.c: Same.
 616         * machoread.c: Same.
 617         * mdebugread.c: Same.
 618         * mep-tdep.c: Same.
 619         * mn10300-tdep.c: Same.
 620         * namespace.c: Same.
 621         * objfiles.c: Same.
 622         * opencl-lang.c: Same.
 623         * or1k-tdep.c: Same.
 624         * osabi.c: Same.
 625         * ppc-linux-nat.c: Same.
 626         * ppc-linux-tdep.c: Same.
 627         * ppc-sysv-tdep.c: Same.
 628         * printcmd.c: Same.
 629         * procfs.c: Same.
 630         * record-btrace.c: Same.
 631         * record-full.c: Same.
 632         * remote-fileio.c: Same.
 633         * remote.c: Same.
 634         * rs6000-tdep.c: Same.
 635         * s12z-tdep.c: Same.
 636         * score-tdep.c: Same.
 637         * ser-base.c: Same.
 638         * ser-go32.c: Same.
 639         * skip.c: Same.
 640         * sol-thread.c: Same.
 641         * solib-svr4.c: Same.
 642         * solib.c: Same.
 643         * source.c: Same.
 644         * sparc-nat.c: Same.
 645         * sparc-sol2-tdep.c: Same.
 646         * sparc-tdep.c: Same.
 647         * sparc64-tdep.c: Same.
 648         * stabsread.c: Same.
 649         * stack.c: Same.
 650         * symfile.c: Same.
 651         * symtab.c: Same.
 652         * target-descriptions.c: Same.
 653         * target-float.c: Same.
 654         * thread.c: Same.
 655         * utils.c: Same.
 656         * valops.c: Same.
 657         * valprint.c: Same.
 658         * value.c: Same.
 659         * varobj.c: Same.
 660         * windows-nat.c: Same.
 661         * xcoffread.c: Same.
 662         * xstormy16-tdep.c: Same.
 663         * xtensa-tdep.c: Same.
 664
 665 2019-10-17  Tom Tromey  <tromey@adacore.com>
 666
 667         * configure: Rebuild.
 668         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 669         in AC_CONFIG_FILES invocation.
 670         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 671         new-style config.status invocation.
 672
 673 2019-10-17  Tom de Vries  <tdevries@suse.de>
 674
 675         * arm-nbsd-nat.c: Fix typos in comments.
 676         * arm-tdep.c: Same.
 677         * darwin-nat-info.c: Same.
 678         * dwarf2read.c: Same.
 679         * elfread.c: Same.
 680         * event-top.c: Same.
 681         * findvar.c: Same.
 682         * gdbtypes.c: Same.
 683         * hppa-tdep.c: Same.
 684         * i386-tdep.c: Same.
 685         * jit.c: Same.
 686         * main.c: Same.
 687         * mdebugread.c: Same.
 688         * moxie-tdep.c: Same.
 689         * nto-procfs.c: Same.
 690         * osabi.c: Same.
 691         * ppc-linux-tdep.c: Same.
 692         * remote.c: Same.
 693         * riscv-tdep.c: Same.
 694         * s390-tdep.c: Same.
 695         * sh-tdep.c: Same.
 696         * sparc-linux-tdep.c: Same.
 697         * sparc-nat.c: Same.
 698         * stack.c: Same.
 699         * target-descriptions.c: Same.
 700         * top.c: Same.
 701         * varobj.c: Same.
 702
 703 2019-10-16  Tom Tromey  <tom@tromey.com>
 704
 705         * objfiles.h (struct objfile) <original_name>: Now const.
 706
 707 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 708
 709         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 710         pass on to sigsetjmp's second argument.
 711         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 712
 713 2019-10-16  Keith Seitz  <keiths@redhat.com>
 714
 715         PR gdb/23567
 716         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 717         sections whose size is greater than the file size.
 718
 719 2019-10-16  Jim Wilson  <jimw@sifive.com>
 720
 721         * riscv-tdep.c (riscv_gcc_target_options): New.
 722         (riscv_gnu_triplet_regexp): New.
 723         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 724         set_gdbarch_gnu_triplet_regexp.
 725
 726 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 727
 728         * Makefile.in: Add xml-builtin.h.
 729         * features/feature_to_c.sh: Add an include for xml-builtin.h
 730         to ensure that the compiler checks that the types match.
 731         * xml-builtin.h: New file.
 732         * xml-support.c (fetch_xml_builtin): Add missing const.
 733         * xml-support.h: Remove declaration of xml_builtins.
 734
 735 2019-10-16  Tom de Vries  <tdevries@suse.de>
 736
 737         PR tdep/25096
 738         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 739         (amd64_classify_aggregate): ... here.
 740         (amd64_classify_aggregate_field): Handled fiels of nested structs
 741         recursively.
 742
 743 2019-10-16  Tom de Vries  <tdevries@suse.de>
 744
 745         PR tdep/24104
 746         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 747         that handles 'theclass'.
 748
 749 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 750
 751         * linespec.c (decode_digits_ordinary): Update comment.
 752         * make-target-delegates: No longer need to handle VEC case.
 753         * memrange.c (normalize_mem_ranges): Update comment.
 754         * namespace.c (add_using_directive): Update comment.
 755         * objc-lang.c (uniquify_strings): Update comment.
 756         * ppc-linux-nat.c (struct thread_points): Update comment.
 757         * probe.h (find_probes_in_objfile): Update comment.
 758         * target.h (enum flash_preserve_mode): Update comment.
 759         * varobj.c (varobj_restrict_range): Update comment.
 760         * varobj.h (varobj_list_children): Update comment.
 761
 762 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * Makefile.in: Remove references to vec.h and vec.c.
 765         * aarch64-tdep.c: No longer include vec.h.
 766         * ada-lang.c: Likewise.
 767         * ada-lang.h: Likewise.
 768         * arm-tdep.c: Likewise.
 769         * ax.h: Likewise.
 770         * breakpoint.h: Likewise.
 771         * charset.c: Likewise.
 772         * cp-support.h: Likewise.
 773         * dtrace-probe.c: Likewise.
 774         * dwarf2read.c: Likewise.
 775         * extension.h: Likewise.
 776         * gdb_bfd.c: Likewise.
 777         * gdbsupport/gdb_vecs.h: Likewise.
 778         * gdbsupport/vec.c: Remove.
 779         * gdbsupport/vec.h: Remove.
 780         * gdbthread.h: Likewise.
 781         * guile/scm-type.c: Likewise.
 782         * inline-frame.c: Likewise.
 783         * machoread.c: Likewise.
 784         * memattr.c: Likewise.
 785         * memrange.h: Likewise.
 786         * namespace.h: Likewise.
 787         * nat/linux-btrace.h: Likewise.
 788         * osdata.c: Likewise.
 789         * parser-defs.h: Likewise.
 790         * progspace.h: Likewise.
 791         * python/py-type.c: Likewise.
 792         * record-btrace.c: Likewise.
 793         * rust-exp.y: Likewise.
 794         * solib-target.c: Likewise.
 795         * stap-probe.c: Likewise.
 796         * target-descriptions.c: Likewise.
 797         * target-memory.c: Likewise.
 798         * target.h: Likewise.
 799         * varobj.c: Likewise.
 800         * varobj.h: Likewise.
 801         * xml-support.h: Likewise.
 802
 803 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 806         Update for new std::vector based implementation.
 807         (process_psymtab_comp_unit_reader): Likewise.
 808         (scan_partial_symbols): Likewise.
 809         (recursively_compute_inclusions): Likewise.
 810         (compute_compunit_symtab_includes): Likewise.
 811         (process_imported_unit_die): Likewise.
 812         (queue_and_load_dwo_tu): Likewise.
 813         (follow_die_sig_1): Likewise.
 814         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 815         (typedef dwarf2_per_cu_ptr): Remove.
 816         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 817         function.
 818         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 819         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 820         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 821         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 822         std::vector.
 823
 824 2019-10-15  Tom Tromey  <tromey@adacore.com>
 825
 826         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 827         TID.
 828
 829 2019-10-15  Tom Tromey  <tromey@adacore.com>
 830
 831         * windows-nat.c (windows_nat_target::fetch_registers)
 832         (windows_nat_target::store_registers): Rename "pid" to "tid".
 833
 834 2019-10-15  Tom Tromey  <tromey@adacore.com>
 835
 836         * gdbarch.h, gdbarch.c: Rebuild.
 837         * gdbarch.sh (gcc_target_options): Change return type to
 838         std::string.
 839         * compile/compile.c (get_args): Update.
 840         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 841         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 842         std::string.
 843         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 844         std::string.
 845         * arch-utils.c (default_gcc_target_options): Return std::string.
 846         * arch-utils.h (default_gcc_target_options): Return std::string.
 847         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 848
 849 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * breakpoint.c (breakpoint_chain): Make static.
 852         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 853         of accessing breakpoint_chain.
 854
 855 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 856
 857         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 858         to a gdb::function_view and return value to bool.
 859         * breakpoint.h (iterate_over_breakpoints): Likewise.
 860         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 861         (pop_dummy_frame): Update.
 862         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 863         (gdbscm_breakpoints): Update.
 864         * python/py-breakpoint.c (build_bp_list): Update.
 865         (gdbpy_breakpoints): Update.
 866         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 867         Update.
 868         (bpfinishpy_handle_stop): Update.
 869         (bpfinishpy_handle_exit): Update.
 870         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 871         (svr4_update_solib_event_breakpoints): Update.
 872
 873 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 874
 875         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 876         when unwrapping single-field structs.
 877
 878 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 879
 880         * dwarf2read.c: Remove includes.
 881
 882 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 883
 884         * ui-out.c (ui_out::call_do_message): Silence
 885         -Wformat-nonliteral warning.
 886
 887 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 888
 889         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 890         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 891         include: readline/tilde.h.
 892
 893 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 894
 895         * remote.c (remote_target::get_trace_status): Remove declaration of
 896         trace_regblock_size.
 897
 898 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 899
 900         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 901         (show_user): Remove declaration of cmdlist.
 902         * cli/cli-cmds.h (max_user_call_depth): Declare.
 903         * cli/cli-script.c (execute_user_command): Remove declaration
 904         of max_user_call_depth.
 905
 906 2019-10-11  Jim Wilson  <jimw@sifive.com>
 907
 908         * gdbsupport/print-utils.h (pulongest): Fix comment.
 909         (plongest): Likewise.
 910         (phex): Add missing comment, mention leading zeros.
 911         (phex_nz): Add mention of no leading zeros to comment.
 912
 913         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 914         plongest instead of unsigned long long cast.
 915
 916 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 917
 918         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 919         for external_editor_command and gdbtk_test.
 920
 921 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 922
 923         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 924         * varobj.c (varobjdebug): Move comment to...
 925         * varobj.h (varobjdebug): ...here, and declare.
 926
 927 2019-10-09  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 930         erase_data_content.
 931
 932 2019-10-09  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 935         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 936         * tui/tui-command.c (tui_cmd_window::resize)
 937         (tui_refresh_cmd_win): Update.
 938         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 939         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 940         * tui/tui-data.c (~tui_gen_win_info): Remove.
 941         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 942         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 943         (tui_redisplay_readline, tui_mld_flush)
 944         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 945         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 946         (tui_data_window::erase_data_content)
 947         (tui_data_item_window::rerender)
 948         (tui_data_item_window::refresh_window): Update.
 949         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 950         (box_win, tui_gen_win_info::make_window)
 951         (tui_gen_win_info::make_visible): Update.
 952         (tui_delete_win): Remove.
 953         * tui/tui-winsource.c
 954         (tui_source_window_base::do_erase_source_content): Update.
 955         (tui_show_source_line, tui_source_window_base::update_tab_width)
 956         (tui_source_window_base::update_exec_info): Update.
 957         * tui/tui-data.h (struct curses_deleter): New.
 958         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 959         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 960
 961 2019-10-09  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 964
 965 2019-10-09  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 968         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 969
 970 2019-10-09  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 973         window height directly.
 974         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 975         declare.
 976         * tui/tui-layout.c (tui_default_win_height): Remove.
 977         (tui_default_win_viewport_height): Remove.
 978
 979 2019-10-09  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui.h: Remove comments.
 982
 983 2019-10-09  Tom de Vries  <tdevries@suse.de>
 984
 985         * python/lib/gdb/printer/bound_registers.py: Use
 986         '^builtin_type_bound128' as regexp argument for
 987         add_builtin_pretty_printer.
 988
 989 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 990
 991         * guile/guile.c (guile_extension_script_ops): Remove forward
 992         declaration and mark as static.
 993         (guile_script_ops): Likewise.
 994         (extension_language_guile): Move further down in the file so
 995         it can reference the definitions for guile_{extension_,}script_ops.
 996
 997 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 998
 999         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1000         except SORTL, DFLTCC, and KDSA.
1001
1002 2019-10-08  Tom Tromey  <tromey@adacore.com>
1003
1004         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1005         (struct safe_symbol_file_add_args): Remove.
1006
1007 2019-10-08  Tom Tromey  <tromey@adacore.com>
1008
1009         * windows-nat.c: Don't include buildsym-legacy.h.
1010
1011 2019-10-08  Tom Tromey  <tromey@adacore.com>
1012
1013         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1014
1015 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * gdbtypes.c (overload_debug): Move comment to header.
1018         * gdbtypes.h (overload_debug): Declare.
1019         * valops.c: Remove declaration of overload_debug, instead
1020         include gdbtypes.h.
1021
1022 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1023
1024         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1025         through _().
1026         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1027         move comment...
1028         * language.h (lang_frame_mismatch_warn): ... here. Also add
1029         declaration.
1030         * top.c (lang_frame_mismatch_warn): Remove declaration.
1031         (check_frame_language_change): Pass lang_frame_mismatch_warn
1032         through _().
1033
1034 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * c-lang.h (vtbl_ptr_name): Declare.
1037         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1038         it from the header.
1039         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1040
1041 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1042
1043         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1044         gdb_static_assert.
1045
1046 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1047
1048         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1049         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1050         * ctfread.c: New file.
1051         * ctfread.h: New file.
1052         * elfread.c: Include ctfread.h.
1053         (struct elfinfo text_p): New member ctfsect.
1054         (elf_locate_sections): Mark CTF section.
1055         (elf_symfile_read): Call elfctf_build_psymtabs.
1056         * Makefile.in (LIBCTF): Add.
1057         (CLIBS): Use it.
1058         (CDEPS): Likewise.
1059         (DIST): Add ctfread.c.
1060
1061 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * ctfread.c (struct nextfield): Renamed to ...
1064         (struct ctf_nextfield): ... this.
1065         (struct field_info): Renamed to ...
1066         (strut ctf_field_info): ... this.
1067         (attach_fields_to_type): Update for renamed structures.
1068         (ctf_add_member_cb): Likewise.
1069         (ctf_add_enum_member_cb): Likewise.
1070         (process_struct_members): Likewise.
1071         (process_enum_type): Likewise.
1072
1073 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1074
1075         * tracectf.h: Rename, was ctf.h.
1076         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1077         * tracefile.c: Likewise.
1078         * tracepoint.c: Remove unused include ctf.h.
1079         * mi/mi-main.c: Likewise.
1080         * Makefile.in Replace ctf.c with tracectf.c.
1081
1082 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1083
1084         * version.in: Change version number to "9.0.50.DATE-git".
1085
1086 2019-10-03  Tom Tromey  <tom@tromey.com>
1087
1088         PR rust/24976:
1089         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1090
1091 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1094         cp_search_name_hash.
1095         * NEWS: Add entry about nested function support.
1096
1097 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1098             Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1101         for nested static variables when searchin VAR_DOMAIN.
1102         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1103         global scope, update comment.
1104         (add_partial_subprogram): Call add_partial_subprogram recursively
1105         for nested subroutines when processinng Fortran.
1106         (load_partial_dies): Process the child entities of a subprogram
1107         when processing Fortran.
1108         (partial_die_parent_scope): Handle building scope
1109         for Fortran nested functions.
1110         (process_die): Record that nested functions have a scope.
1111         (new_symbol): Always record Fortran subprograms on the global
1112         symbol list.
1113         (determine_prefix): How to build the prefix for Fortran
1114         subprograms.
1115
1116 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1119         have just sent the thread a SIGSTOP and are waiting for it to
1120         arrive.
1121
1122 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * btrace.c (btrace_add_pc): Remove whitespace before the template
1125         parameter in 'std::vector <...>'.
1126         (parse_xml_btrace_block): Likewise.
1127         (btrace_maint_decode_pt): Likewise.
1128         (btrace_maint_update_packets): Likewise.
1129         (btrace_maint_print_packets): Likewise.
1130         * btrace.h (struct btrace_maint_info): Likewise.
1131         * dwarf2read.c (struct type_unit_group): Likewise.
1132         (build_type_psymtabs_reader): Likewise.
1133         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1134         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1135         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1136
1137 2019-10-03  Tom de Vries  <tdevries@suse.de>
1138
1139         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1140         the first line of the help text for set/show style metadata.
1141
1142 2019-10-02  Tom Tromey  <tromey@adacore.com>
1143
1144         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1145         * gdbsupport/common-inferior.c: New file.
1146         * infcmd.c (startup_with_shell): Don't define.
1147         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1148         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1149         * inferior.h (startup_with_shell): Don't declare.
1150
1151 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1152
1153         * gdbsupport/gdb_assert.h: Include errors.h.
1154         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1155
1156 2019-10-02  Tom Tromey  <tromey@adacore.com>
1157
1158         * NEWS: Add $_ada_exception entry.
1159         * ada-lang.c (struct ada_catchpoint): Add constructor.
1160         <m_kind>: New member.
1161         (allocate_location_exception, re_set_exception): Remove
1162         "ex" parameter.
1163         (should_stop_exception): Compute $_ada_exception.
1164         (check_status_exception, print_it_exception)
1165         (print_one_exception, print_mention_exception): Remove
1166         "ex" parameter.
1167         (allocate_location_catch_exception, re_set_catch_exception)
1168         (check_status_exception, print_it_catch_exception)
1169         (print_one_catch_exception, print_mention_catch_exception)
1170         (print_recreate_catch_exception)
1171         (allocate_location_catch_exception_unhandled)
1172         (re_set_catch_exception_unhandled)
1173         (check_status_exception, print_it_catch_exception_unhandled)
1174         (print_one_catch_exception_unhandled)
1175         (print_mention_catch_exception_unhandled)
1176         (print_recreate_catch_exception_unhandled)
1177         (allocate_location_catch_assert, re_set_catch_assert)
1178         (check_status_assert, print_it_catch_assert)
1179         (print_one_catch_assert, print_mention_catch_assert)
1180         (print_recreate_catch_assert)
1181         (allocate_location_catch_handlers, re_set_catch_handlers)
1182         (check_status_handlers, print_it_catch_handlers)
1183         (print_one_catch_handlers, print_mention_catch_handlers)
1184         (print_recreate_catch_handlers): Remove.
1185         (create_ada_exception_catchpoint): Update.
1186         (initialize_ada_catchpoint_ops): Update.
1187
1188 2019-10-02  Tom Tromey  <tromey@adacore.com>
1189
1190         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1191         (create_excep_cond_exprs): Simplify exception string computation.
1192         (ada_exception_catchpoint_cond_string): Likewise.
1193
1194 2019-10-02  Tom Tromey  <tromey@adacore.com>
1195
1196         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1197         * ada-lang.c (lesseq_defined_than): Handle
1198         LOC_STATIC.
1199         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1200         parameter.
1201         (dwarf2_has_info): Likewise.
1202         (new_symbol): Set maybe_copied on symbol when
1203         appropriate.
1204         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1205         parameter.
1206         <can_copy>: New member.
1207         * elfread.c (record_minimal_symbol): Set maybe_copied
1208         on symbol when appropriate.
1209         (elf_symfile_read): Update call to dwarf2_has_info.
1210         * minsyms.c (lookup_minimal_symbol_linkage): New
1211         function.
1212         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1213         * symtab.c (get_symbol_address, get_msymbol_address):
1214         New functions.
1215         * symtab.h (get_symbol_address, get_msymbol_address):
1216         Declare.
1217         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1218         maybe_copied.
1219         (struct symbol, struct minimal_symbol) <maybe_copied>:
1220         New member.
1221
1222 2019-10-02  Tom Tromey  <tromey@adacore.com>
1223
1224         * source.c (struct current_source_location): New.
1225         (current_source_key): New global.
1226         (current_source_symtab, current_source_line)
1227         (current_source_pspace): Remove.
1228         (get_source_location): New function.
1229         (get_current_source_symtab_and_line)
1230         (set_default_source_symtab_and_line)
1231         (set_current_source_symtab_and_line)
1232         (clear_current_source_symtab_and_line, select_source_symtab)
1233         (info_source_command, print_source_lines_base)
1234         (info_line_command, search_command_helper, _initialize_source):
1235         Update.
1236
1237 2019-10-02  Tom Tromey  <tromey@adacore.com>
1238
1239         * source.c (select_source_symtab): Don't call
1240         decode_line_with_current_source.
1241
1242 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * symtab.c (lookup_global_symbol): Search global block.
1245
1246 2019-10-02  Tom Tromey  <tromey@adacore.com>
1247
1248         * coffread.c (process_coff_symbol): Update.
1249         * dwarf2read.c (var_decode_location, new_symbol): Update.
1250         * mdebugread.c (parse_symbol): Update.
1251         * objfiles.c (relocate_one_symbol): Update.
1252         * stabsread.c (define_symbol, fix_common_block)
1253         (scan_file_globals): Update.
1254         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1255         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1256         * xcoffread.c (process_xcoff_symbol): Update.
1257
1258 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1259
1260         * MAINTAINERS: Update my email address.
1261
1262 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1265         std::vector.
1266         (build_type_psymtabs_reader): Update for std::vector.
1267         (build_type_psymtab_dependencies): Likewise.
1268         * dwarf2read.h: Remove use of DEF_VEC_P.
1269         (typedef sig_type_ptr): Delete.
1270
1271 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1274         to std::vector.
1275         (btrace_maint_decode_pt): Likewise, and move allocation of the
1276         vector outside of the loop.
1277         (btrace_maint_update_packets): Update to handle change from VEC to
1278         std::vector.
1279         (btrace_maint_print_packets): Likewise.
1280         (maint_info_btrace_cmd): Likewise.
1281         * btrace.h: Remove use of DEF_VEC_O.
1282         (typedef btrace_pt_packet_s): Delete.
1283         (struct btrace_maint_info) <packets>: Change fromm VEC to
1284         std::vector.
1285         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1286
1287 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1290         make accesses into the vector constant references.
1291         (btrace_add_pc): Update for std::vector.
1292         (btrace_stitch_bts): Likewise.
1293         (parse_xml_btrace_block): Likewise.
1294         (btrace_maint_update_packets): Likewise.
1295         (btrace_maint_print_packets): Likewise.
1296         (maint_info_btrace_cmd): Likewise.
1297         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1298         std::vector.
1299         (btrace_data::empty): Likewise.
1300         (btrace_data_append): Likewise.
1301         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1302         (typedef btrace_block_s): Delete.
1303         (struct btrace_block): Add constructor.
1304         (struct btrace_data_bts) <blocks>: Change to std::vector.
1305         * nat/linux-btrace.c (perf_event_read_bts): Update for
1306         std::vector.
1307         (linux_read_bts): Likewise.
1308
1309 2019-10-01  Tom Tromey  <tom@tromey.com>
1310
1311         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1312
1313 2019-10-01  Tom Tromey  <tom@tromey.com>
1314
1315         * stack.c (print_frame, info_frame_command_core): Use
1316         styled_string.
1317         * linux-thread-db.c (try_thread_db_load_1)
1318         (try_thread_db_load_from_pdir_1): Use styled_string.
1319         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1320         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1321         (maybe_print_unsupported_script_warning)
1322         (maybe_print_script_not_found_warning): Use styled_string.
1323         * ada-lang.c (user_select_syms): Use styled_string.
1324
1325 2019-10-01  Tom Tromey  <tom@tromey.com>
1326
1327         * p-lang.c (pascal_printstr): Use metadata style.
1328         * value.c (show_convenience): Use metadata style.
1329         * valprint.c (valprint_check_validity, val_print_optimized_out)
1330         (val_print_not_saved, val_print_unavailable)
1331         (val_print_invalid_address, generic_val_print, val_print)
1332         (value_check_printable, val_print_array_elements): Use metadata
1333         style.
1334         * ui-out.h (class ui_out) <field_fmt>: New overload.
1335         <do_field_fmt>: Add style parameter.
1336         * ui-out.c (ui_out::field_fmt): New overload.
1337         * typeprint.c (type_print_unknown_return_type)
1338         (val_print_not_allocated, val_print_not_associated): Use metadata
1339         style.
1340         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1341         parameter.
1342         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1343         * tracepoint.c (tvariables_info_1): Use metadata style.
1344         * stack.c (print_frame_arg, print_frame_info, print_frame)
1345         (info_frame_command_core): Use metadata style.
1346         * skip.c (info_skip_command): Use metadata style.
1347         * rust-lang.c (rust_print_enum): Use metadata style.
1348         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1349         metadata style.
1350         * python/py-framefilter.c (py_print_single_arg): Use metadata
1351         style.
1352         * printcmd.c (do_one_display, print_variable_and_value): Use
1353         metadata style.
1354         * p-valprint.c (pascal_val_print)
1355         (pascal_object_print_value_fields): Use metadata style.
1356         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1357         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1358         parameter.
1359         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1360         * m2-valprint.c (m2_print_long_set): Use metadata style.
1361         * m2-typeprint.c (m2_print_type): Use metadata style.
1362         * infcmd.c (print_return_value_1): Use metadata style.
1363         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1364         * f-valprint.c (info_common_command_for_block): Use metadata
1365         style.
1366         * f-typeprint.c (f_type_print_base): Use metadata style.
1367         * expprint.c (print_subexp_standard): Use metadata style.
1368         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1369         * cli/cli-style.h (class cli_style_option): Add constructor.
1370         (metadata_style): Declare.
1371         * cli/cli-style.c (metadata_style): New global.
1372         (_initialize_cli_style): Register metadata style.
1373         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1374         parameter.
1375         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1376         * c-typeprint.c (c_type_print_base_struct_union)
1377         (c_type_print_base_1): Use metadata style.
1378         * breakpoint.c (watchpoint_value_print)
1379         (print_one_breakpoint_location): Use metadata style.
1380         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1381         style.
1382         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1383         style.
1384         * ada-valprint.c (val_print_packed_array_elements, printstr)
1385         (print_field_values, ada_val_print_ref, ada_val_print): Use
1386         metadata style.
1387         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1388         style.
1389         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1390         style.
1391         * ada-lang.c (user_select_syms): Use metadata style.
1392
1393 2019-10-01  Tom Tromey  <tom@tromey.com>
1394
1395         * cli/cli-cmds.c (pwd_command): Style output.
1396
1397 2019-10-01  Pedro Alves  <palves@redhat.com>
1398             Tom Tromey  <tom@tromey.com>
1399
1400         * symtab.c (print_symbol_info): Use %ps.
1401         (print_msymbol_info): Use %ps.
1402         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1403         * printcmd.c (print_variable_and_value): Use %ps.
1404         * macrocmd.c (show_pp_source_pos): Use %ps.
1405         * infrun.c (print_exited_reason): Use ui_out::message.
1406         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1407         (describe_other_breakpoints): Use ui_out::message and new
1408         formats.
1409         (say_where): Use new formats.
1410         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1411         and new formats.
1412
1413 2019-10-01  Pedro Alves  <palves@redhat.com>
1414             Tom Tromey  <tom@tromey.com>
1415
1416         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1417         (test_gdb_formats): New function.
1418         (run_tests): Call it.
1419         (test_format_specifier): Update.
1420         * utils.h (fputs_filtered): Update comment.
1421         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1422         (fputs_styled_unfiltered): Declare.
1423         * utils.c (fputs_styled_unfiltered): New function.
1424         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1425         (vfprintf_filtered): Update.
1426         (vfprintf_unfiltered, vprintf_filtered): Update.
1427         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1428         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1429         disallow_ui_out_field>: New constants.
1430         (enum class field_kind): New.
1431         (struct base_field_s, struct signed_field_s): New.
1432         (signed_field): New function.
1433         (struct string_field_s): New.
1434         (string_field): New function.
1435         (struct styled_string_s): New.
1436         (styled_string): New function.
1437         (class ui_out) <message>: Add comment.
1438         <vmessage, call_do_message>: New methods.
1439         <do_message>: Add style parameter.
1440         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1441         methods.
1442         (ui_out::message): Rewrite.
1443         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1444         parameter.
1445         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1446         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1447         gdb_extensions parameter.
1448         (class format_piece): Add parameter to constructor.
1449         (n_int_args): New field.
1450         * gdbsupport/format.c (format_pieces::format_pieces): Add
1451         gdb_extensions parameter.  Handle '*'.
1452         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1453         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1454         vfprintf_styled_no_gdbfmt.
1455         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1456         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1457         unfiltered output.
1458         * ui-style.h (struct ui_file_style) <ptr>: New method.
1459
1460 2019-10-01  Tom Tromey  <tom@tromey.com>
1461
1462         * unittests/format_pieces-selftests.c: Update.  Add final format.
1463         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1464         empty literal pieces.
1465
1466 2019-10-01  Tom Tromey  <tom@tromey.com>
1467
1468         * ui-out.h (enum class ui_out_style_kind): Remove.
1469         (class ui_out) <field_string, field_stsream, do_field_string>:
1470         Change type of "style".
1471         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1472         (ui_out::field_string): Update.
1473         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1474         of "style".
1475         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1476         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1477         * stack.c (print_frame_arg, print_frame_info, print_frame):
1478         Update.
1479         * source.c (print_source_lines_base): Update.
1480         * solib.c (info_sharedlibrary_command): Update.
1481         * skip.c (info_skip_command): Update.
1482         * record-btrace.c (btrace_call_history_src_line)
1483         (btrace_call_history): Update.
1484         * python/py-framefilter.c (py_print_frame): Update.
1485         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1486         "style".
1487         * mi/mi-out.c (mi_ui_out::do_table_header)
1488         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1489         (mi_ui_out::do_field_string): Update.
1490         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1491         Update.
1492         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1493         "style".
1494         * cli-out.c (cli_ui_out::do_table_header)
1495         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1496         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1497         (cli_ui_out::do_field_fmt): Update.
1498         * breakpoint.c (print_breakpoint_location): Update.
1499         (update_static_tracepoint): Update.
1500
1501 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1502
1503         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1504         conversion of gdb_datadir.
1505         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1506         remove not needed c_str ().
1507
1508 2019-09-30  Ali Tamur <tamur@google.com>
1509
1510         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1511         (dwarf2_string_attr): Likewise.
1512
1513 2019-09-30  Ali Tamur <tamur@google.com>
1514
1515         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1516         (process_full_type_unit): Likewise.
1517         (dump_die_shallow): Likewise.
1518         (cu_debug_loc_section): Likewise.
1519
1520 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1521
1522         * minsyms.c (compare_minimal_symbols): Rename to...
1523         (minimal_symbol_is_less_than): ...this, and adjust to STL
1524         conventions (return bool, take arguments as references)
1525         (minimal_symbol_reader::install): Call std::sort instead
1526         of qsort.
1527
1528 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1529
1530         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1531         hash and why.
1532         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1533         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1534
1535 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1536
1537         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1538         * psympriv.h (add_psymbol_to_list): Move comment here and update
1539         it.
1540
1541 2019-09-29  Tom de Vries  <tdevries@suse.de>
1542
1543         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1544         Use $tmpdir/$(basename "$output_file").dwz instead of
1545         "${output_file}.dwz".
1546
1547 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1548
1549         PR gdb/25045
1550         * hppa-linux-nat.c: Include gdbarch.h.
1551
1552 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1553
1554         * blockframe.c (find_pc_partial_function): Change return type to bool.
1555         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1556         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1557         (stub_gnu_ifunc_resolve_name): Likewise.
1558         * symtab.c (compare_filenames_for_search): Likewise.
1559         (compare_glob_filenames_for_search): Likewise.
1560         (matching_obj_sections): Likewise.
1561         (symbol_matches_domain): Likewise.
1562         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1563         (find_line_pc): Change return type to bool.
1564         (find_line_pc_range): Likewise.
1565         (producer_is_realview): Likewise.
1566         * symtab.h (symbol_matches_domain): Likewise.
1567         (find_pc_partial_function): Likewise.
1568         (find_pc_line_pc_range): Likewise.
1569         (in_gnu_ifunc_stub): Likewise.
1570         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1571         (find_line_pc): Likewise.
1572         (find_line_pc_range): Likewise.
1573         (matching_obj_sections): Likewise.
1574         (find_line_symtab): Change out parameter to bool.
1575         (producer_is_realview): Change return type to bool.
1576         (compare_filenames_for_search): Likewise.
1577         (compare_glob_filenames_for_search): Likewise.
1578
1579 2019-09-26  Tom Tromey  <tom@tromey.com>
1580
1581         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1582         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1583         * gdb_usleep.h: Remove.
1584         * gdb_usleep.c: Remove.
1585         * utils.c: Don't include gdb_usleep.h.
1586
1587 2019-09-26  Tom Tromey  <tromey@adacore.com>
1588
1589         * python/py-type.c (type_to_type_object): Call check_typedef
1590         for stub types.
1591
1592 2019-09-26  Tom Tromey  <tom@tromey.com>
1593
1594         * utils.h (initialize_utils): Don't declare.
1595         * top.c (gdb_init): Don't call initialize_utils.
1596         * utils.c (initialize_utils): Remove.  Move contents...
1597         (_initialize_utils): ... here.
1598
1599 2019-09-25  Tom Tromey  <tom@tromey.com>
1600
1601         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1602         * utils.h (make_hex_string): Don't declare.
1603         * utils.c (make_hex_string): Remove.
1604
1605 2019-09-24  Tom de Vries  <tdevries@suse.de>
1606
1607         PR gdb/23815
1608         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1609         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1610
1611 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1612
1613         * NEWS: Mention new simulator port for PRU.
1614
1615 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1616
1617         * ada-exp.y (write_object_remaining): Update.
1618         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1619         and eliminate the static buffer.
1620         (ada_decode_symbol): Update.
1621         (ada_la_decode): Update.
1622         (ada_sniff_from_mangled_name): Update.
1623         (is_valid_name_for_wild_match): Update.
1624         (ada_lookup_name_info::matches): Update and simplify.
1625         (name_matches_regex): Update.
1626         (ada_add_global_exceptions): Update.
1627         * ada-lang.h (ada_decode): Update signature.
1628         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1629         * dwarf-index-write.c (debug_names::insert): Update.
1630
1631 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1632
1633         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1634         formatting.
1635
1636 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1637
1638         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1639         Change "nonzero" to "true" in documentation.
1640
1641 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1642
1643         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1644         (_initialize_darwin_solib): Don't set
1645         darwin_so_ops.lookup_lib_global_symbol.
1646         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1647         set_gdbarch_iterate_over_objfiles_in_search_order.
1648         (elf_lookup_lib_symbol): Rename to...
1649         (svr4_iterate_over_objfiles_in_search_order): this, and update
1650         to iterate semantics.
1651         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1652         * solib.c (solib_global_lookup): Remove.
1653         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1654         (solib_global_lookup): Remove.
1655         * symtab.c (lookup_global_or_static_symbol): Remove call to
1656         solib_global_lookup.
1657
1658 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1659
1660         * NEWS: Move entries about default MI version now being
1661         version 3, and about the GDB/MI fix for multi-location
1662         breakpoints to the "since GDB 8.3" section.
1663
1664 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1665
1666         GDB 8.3.1 released.
1667
1668 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1669
1670         * NEWS: Mention that Cell/B.E. debugging support was removed.
1671         * MAINTAINERS: Remove spu target.
1672
1673         * config/djgpp/fnchange.lst: Remove entries for removed files.
1674
1675         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1676         spu-multiarch.o, and spu-tdep.o.
1677         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1678         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1679         spu-multiarch.c, and spu-tdep.c.
1680         * spu-linux-nat.c: Remove file.
1681         * spu-multiarch.c: Remove file.
1682         * spu-tdep.c: Remove file.
1683         * spu-tdep.h: Remove file.
1684         * solib-spu.c: Remove file.
1685         * solib-spu.h: Remove file.
1686
1687         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1688         * configure.nat (spu-linux): Remove.
1689         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1690         solib-multiarch.o from gdb_target_obs.
1691         (spu*-*-*): Remove.
1692
1693         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1694         feature flag.
1695         (ppc_linux_no_features): Update.
1696         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1697         Cell/B.E. support.
1698         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1699         (tdesc_powerpc_cell64l): Likewise.
1700         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1701         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1702         Cell/B.E. support.
1703         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1704         Do not include "features/rs6000/powerpc-cell32l.c" or
1705         "features/rs6000/powerpc-cell64l.c".
1706         (ppc_linux_spu_section): Remove.
1707         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1708         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1709         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1710         (ppc_linux_spe_context_lookup): Remove.
1711         (ppc_linux_spe_context_inferior_created): Remove.
1712         (ppc_linux_spe_context_solib_loaded): Remove.
1713         (ppc_linux_spe_context_solib_unloaded): Remove.
1714         (ppc_linux_spe_context): Remove.
1715         (struct ppu2spu_cache): Remove.
1716         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1717         (struct ppu2spu_data): Remove.
1718         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1719         ppu2spu_unwind): Remove.
1720         (ppc_linux_init_abi): Remove Cell/B.E. support.
1721         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1722
1723         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1724         (rs6000/powerpc-cell64l-expedite): Likewise
1725         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1726         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1727         rs6000/powerpc-cell64l.xml.
1728         * features/rs6000/powerpc-cell32l.xml: Remove.
1729         * features/rs6000/powerpc-cell64l.xml: Likewise.
1730         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1731         * features/rs6000/powerpc-cell64l.c: Likewise.
1732         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1733         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1734         * regformats/reg-spu.dat: Remove.
1735
1736         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1737         * corelow.c (struct spuid_list): Remove.
1738         (add_to_spuid_list): Remove.
1739         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1740         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1741         (remote_protocol_features): Remove associated entries.
1742         (_initialize_remote): No longer initialize them.
1743         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1744         * linux-nat.c (SPUFS_MAGIC): Remove.
1745         (linux_proc_xfer_spu): Remove.
1746         (spu_enumerate_spu_ids): Remove.
1747         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1748         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1749         (linux_make_corefile_notes): No longer call it.
1750
1751         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1752         (cooked_write_test): Likewise.
1753
1754 2019-09-20  Tom Tromey  <tom@tromey.com>
1755
1756         * NEWS: Mention case-sensitivity of TUI commands.
1757         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1758         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1759         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1760
1761 2019-09-20  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-source.c (tui_source_window::set_contents): Use
1764         make_unique_xstrdup.
1765         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1766         make_unique_xstrdup.
1767
1768 2019-09-20  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-data.c: Remove separator comments.
1771         * tui/tui-layout.c: Remove separator comments.
1772         * tui/tui-win.c: Remove separator comments.
1773         * tui/tui-wingeneral.c: Remove separator comments.
1774
1775 2019-09-20  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui.h (strcat_to_buf): Don't declare.
1778         * tui/tui.c (strcat_to_buf): Remove.
1779
1780 2019-09-20  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1783         from "fullname".
1784         * tui/tui-source.c (tui_source_window::set_contents)
1785         (tui_source_window::location_matches_p)
1786         (tui_source_window::maybe_update): Update.
1787
1788 2019-09-20  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1791         Update.
1792         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1793         prefix.
1794         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1795         (tui_data_window::line_from_reg_element_no)
1796         (tui_data_window::first_reg_element_no_inline)
1797         (tui_data_window::show_registers)
1798         (tui_data_window::show_register_group)
1799         (tui_data_window::display_registers_from)
1800         (tui_data_window::display_registers_from_line)
1801         (tui_data_window::first_data_item_displayed)
1802         (tui_data_window::delete_data_content_windows)
1803         (tui_data_window::erase_data_content)
1804         (tui_data_window::do_scroll_vertical)
1805         (tui_data_window::refresh_window)
1806         (tui_data_window::check_register_values): Update.
1807
1808 2019-09-20  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1811         (struct tui_locator_window) <full_name, proc_name>: Now
1812         std::string.
1813         * tui/tui-stack.c (tui_locator_window::make_status_line)
1814         (tui_locator_window::set_locator_fullname)
1815         (tui_locator_window::set_locator_info): Update.
1816         * tui/tui-source.c (tui_source_window::set_contents)
1817         (tui_source_window::showing_source_p): Update.
1818
1819 2019-09-20  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1822         Don't call tui_locator_win_info_ptr.
1823
1824 2019-09-20  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1827
1828 2019-09-20  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1831         height for locator.
1832         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1833         * tui/tui-layout.c (show_source_disasm_command, show_data)
1834         (show_source_or_disasm_and_command): Use 1 as height for locator.
1835
1836 2019-09-20  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui.c (tui_enable): Update.
1839         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1840         Update.
1841         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1842         Update.
1843         * tui/tui-data.c (win_resized): Now bool.
1844         (tui_win_resized): Return bool.
1845         (tui_set_win_resized_to): Accept a bool.
1846
1847 2019-09-20  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1850         Change type of "refresh_values_only".
1851         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1852         type of "refresh_values_only".
1853
1854 2019-09-20  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1857         std::string.
1858         (tui_disassemble): Add "pos" parameter.
1859         (tui_disasm_window::set_contents): Simplify.
1860
1861 2019-09-20  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-winsource.h (struct tui_source_window_base)
1864         <show_source_content>: Now private.
1865         * tui/tui-winsource.c
1866         (tui_source_window_base::show_source_content): Don't handle empty
1867         content case.
1868
1869 2019-09-20  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-layout.c (show_source_disasm_command)
1872         (show_source_or_disasm_and_command): Don't call
1873         show_source_content.
1874
1875 2019-09-20  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1878         Declare.
1879         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1880         from tui_make_status_line.
1881         (tui_locator_window::rerender): Update.
1882
1883 2019-09-20  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1886         (tui_locator_window::rerender): Update.
1887
1888 2019-09-20  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-winsource.h (struct tui_source_window_base)
1891         <~tui_source_window_base>: Don't declare.
1892         <fullname>: Remove.
1893         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1894         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1895         member.
1896         * tui/tui-source.c (tui_source_window::set_contents): Update.
1897         (tui_source_window::location_matches_p)
1898         (tui_source_window::maybe_update): Update.
1899
1900 2019-09-20  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-winsource.h (~tui_source_element): Remove.
1903         (tui_source_element): Update.
1904         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1905         * tui/tui-winsource.c (tui_show_source_line): Update.
1906         * tui/tui-source.c (tui_source_window::set_contents): Update.
1907         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1908
1909 2019-09-20  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1912         declare.
1913         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1914         tui_clear_source_windows_detail.
1915         * tui/tui-winsource.h (struct tui_source_window_base)
1916         <clear_detail>: Don't declare.
1917         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1918         Remove.
1919         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1920
1921 2019-09-20  Tom Tromey  <tromey@adacore.com>
1922
1923         PR ada/24919:
1924         * block.c (contained_in): Fix final return value.
1925
1926 2019-09-20  Alan Modra  <amodra@gmail.com>
1927
1928         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1929         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1930         (read_indirect_string_from_dwz): Use bfd accessor.
1931         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1932         * machoread.c (macho_symfile_read_all_oso): Likewise.
1933         * solib.c (solib_bfd_open): Likewise.
1934
1935 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1936
1937         * eval.c: Move declaration of overload_resolution to...
1938         * value.h: ...here.
1939
1940 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1941
1942         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1943         * arm-linux-tdep.c: Likewise.
1944         * arm-nbsd-nat.c: Likewise.
1945         * arm-tdep.h: Declare arm_apcs_32.
1946         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1947
1948 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1949
1950         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1951         * dwarf2read.h: Declare dwarf_always_disassemble.
1952
1953 2019-09-19  Tom de Vries  <tdevries@suse.de>
1954
1955         PR gdb/25009
1956         * source-cache.c (source_cache::ensure): Catch exception thrown during
1957         construction of the highlighter.
1958
1959 2019-09-18  Alan Modra  <amodra@gmail.com>
1960
1961         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1962         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1963         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1964         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1965         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1966         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1967         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1968         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1969         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1970         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1971         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1972         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1973         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1974         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1975         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1976         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1977         * mi/mi-interp.c: Update throughout for bfd section macro and
1978         function changes.
1979         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1980         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1981
1982 2019-09-18  Tom Tromey  <tom@tromey.com>
1983
1984         * NEWS: Add entry.
1985         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1986         call rl_initialize.
1987         (tui_enable): Do not call rl_initialize.
1988
1989 2019-09-18  Christian Groessler  <chris@groessler.org>
1990
1991         * alpha-linux-nat.c: Include gdbarch.h.
1992
1993 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1994
1995         * ui-file.c: Include cli/cli-style.h.
1996         (term_cli_styling): Remove cli_styling declaration.
1997
1998 2019-09-18  Alan Modra  <amodra@gmail.com>
1999
2000         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2001         to bfd_asymbol_section.
2002
2003 2019-09-18  Alan Modra  <amodra@gmail.com>
2004
2005         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2006         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2007         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2008
2009 2019-09-18  Alan Modra  <amodra@gmail.com>
2010
2011         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2012         * spu-linux-nat.c (spu_bfd_open): Likewise.
2013
2014 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2015
2016         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2017         to bool to match definition in dwarf2read.c.
2018
2019 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2020
2021         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2022         (print_signatures): Likewise.
2023         (trust_pad_over_xvs): Likewise.
2024         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2025         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2026         * arm-linux-nat.c (arm_apcs_32): Likewise.
2027         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2028         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2029         * arm-tdep.c (arm_debug): Likewise.
2030         (arm_apcs_32): Likewise.
2031         * auto-load.c (debug_auto_load): Likewise.
2032         (auto_load_gdb_scripts): Likewise.
2033         (global_auto_load): Likewise.
2034         (auto_load_local_gdbinit): Likewise.
2035         (auto_load_local_gdbinit_loaded): Likewise.
2036         * auto-load.h (global_auto_load): Likewise.
2037         (auto_load_local_gdbinit): Likewise.
2038         (auto_load_local_gdbinit_loaded): Likewise.
2039         * breakpoint.c (disconnected_dprintf): Likewise.
2040         (breakpoint_proceeded): Likewise.
2041         (automatic_hardware_breakpoints): Likewise.
2042         (always_inserted_mode): Likewise.
2043         (target_exact_watchpoints): Likewise.
2044         (_initialize_breakpoint): Update.
2045         * breakpoint.h (target_exact_watchpoints): Change to bool.
2046         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2047         * cli/cli-cmds.c (trace_commands): Likewise.
2048         * cli/cli-cmds.h (trace_commands): Likewise.
2049         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2050         to bool*.
2051         * cli/cli-logging.c (logging_overwrite): Change to bool.
2052         (logging_redirect): Likewise.
2053         (debug_redirect): Likewise.
2054         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2055         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2056         to bool.
2057         <boolean_option_def>: Update.
2058         (struct flag_option_def): Change default type of Context to bool
2059         from int.
2060         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2061         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2062         (get_setshow_command_value_string): Likewise.
2063         * cli/cli-style.c (cli_styling): Change to bool.
2064         (source_styling): Likewise.
2065         * cli/cli-style.h (source_styling): Likewise.
2066         (cli_styling): Likewise.
2067         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2068         to bool.
2069         * command.h (var_types): Update comment.
2070         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2071         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2072         bool.
2073         (debug_compile_cplus_scopes): Likewise.
2074         * compile/compile-internal.h (compile_debug): Likewise.
2075         * compile/compile.c (compile_debug): Likewise.
2076         (struct compile_options) <raw>: Likewise.
2077         * cp-support.c (catch_demangler_crashes): Likewise.
2078         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2079         (usr_cmd_cris_dwarf2_cfi): Likewise.
2080         * csky-tdep.c (csky_debug): Likewise.
2081         * darwin-nat.c (enable_mach_exceptions): Likewise.
2082         * dcache.c (dcache_enabled_p): Likewise.
2083         * defs.h (info_verbose): Likewise.
2084         * demangle.c (demangle): Likewise.
2085         (asm_demangle): Likewise.
2086         * dwarf-index-cache.c (debug_index_cache): Likewise.
2087         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2088         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2089         * dwarf2read.c (check_physname): Likewise.
2090         (use_deprecated_index_sections): Likewise.
2091         (dwarf_always_disassemble): Likewise.
2092         * eval.c (overload_resolution): Likewise.
2093         * event-top.c (set_editing_cmd_var): Likewise.
2094         (exec_done_display_p): Likewise.
2095         * event-top.h (set_editing_cmd_var): Likewise.
2096         (exec_done_display_p): Likewise.
2097         * exec.c (write_files): Likewise.
2098         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2099         (debug_fbsd_nat): Likewise.
2100         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2101         Likewise.
2102         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2103         <backtrace_past_entry> Likewise.
2104         * gdb-demangle.h (demangle): Likewise.
2105         (asm_demangle): Likewise.
2106         * gdb_bfd.c (bfd_sharing): Likewise.
2107         * gdbcore.h (write_files): Likewise.
2108         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2109         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2110         * gdbthread.h (print_thread_events): Likewise.
2111         * gdbtypes.c (opaque_type_resolution): Likewise.
2112         (strict_type_checking): Likewise.
2113         * gnu-nat.c (gnu_debug_flag): Likewise.
2114         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2115         * guile/scm-param.c (pascm_variable): Add boolval.
2116         (add_setshow_generic): Update.
2117         (pascm_param_value): Update.
2118         (pascm_set_param_value_x): Update.
2119         * hppa-tdep.c (hppa_debug): Change to bool..
2120         * infcall.c (may_call_functions_p): Likewise.
2121         (coerce_float_to_double_p): Likewise.
2122         (unwind_on_signal_p): Likewise.
2123         (unwind_on_terminating_exception_p): Likewise.
2124         * infcmd.c (startup_with_shell): Likewise.
2125         * inferior.c (print_inferior_events): Likewise.
2126         * inferior.h (startup_with_shell): Likewise.
2127         (print_inferior_events): Likewise.
2128         * infrun.c (step_stop_if_no_debug): Likewise.
2129         (detach_fork): Likewise.
2130         (debug_displaced): Likewise.
2131         (disable_randomization): Likewise.
2132         (non_stop): Likewise.
2133         (non_stop_1): Likewise.
2134         (observer_mode): Likewise.
2135         (observer_mode_1): Likewise.
2136         (set_observer_mode): Update.
2137         (sched_multi): Change to bool.
2138         * infrun.h (debug_displaced): Likewise.
2139         (sched_multi): Likewise.
2140         (step_stop_if_no_debug): Likewise.
2141         (non_stop): Likewise.
2142         (disable_randomization): Likewise.
2143         * linux-tdep.c (use_coredump_filter): Likewise.
2144         (dump_excluded_mappings): Likewise.
2145         * linux-thread-db.c (auto_load_thread_db): Likewise.
2146         (check_thread_db_on_load): Likewise.
2147         * main.c (captured_main_1): Update.
2148         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2149         xx2_opt, boolean_opt>: Change to bool.
2150         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2151         * maint.c (maintenance_profile_p): Likewise.
2152         (per_command_time): Likewise.
2153         (per_command_space): Likewise.
2154         (per_command_symtab): Likewise.
2155         * memattr.c (inaccessible_by_default): Likewise.
2156         * mi/mi-main.c (mi_async): Likewise.
2157         (mi_async_1): Likewise.
2158         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2159         * nat/fork-inferior.h (startup_with_shell): Likewise.
2160         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2161         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2162         * nios2-tdep.c (nios2_debug): Likewise.
2163         * or1k-tdep.c (or1k_debug): Likewise.
2164         * parse.c (parser_debug): Likewise.
2165         * parser-defs.h (parser_debug): Likewise.
2166         * printcmd.c (print_symbol_filename): Likewise.
2167         * proc-api.c (procfs_trace): Likewise.
2168         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2169         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2170         (set_parameter_value): Update.
2171         (add_setshow_generic): Update.
2172         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2173         to bool*.
2174         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2175         int*.
2176         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2177         * record-btrace.c (record_btrace_target::store_registers): Update.
2178         * record-full.c (record_full_memory_query): Change to bool.
2179         (record_full_stop_at_limit): Likewise.
2180         * record-full.h (record_full_memory_query): Likewise.
2181         * remote-notif.c (notif_debug): Likewise.
2182         * remote-notif.h (notif_debug): Likewise.
2183         * remote.c (use_range_stepping): Likewise.
2184         (interrupt_on_connect): Likewise.
2185         (remote_break): Likewise.
2186         * ser-tcp.c (tcp_auto_retry): Likewise.
2187         * ser-unix.c (serial_hwflow): Likewise.
2188         * skip.c (debug_skip): Likewise.
2189         * solib-aix.c (solib_aix_debug): Likewise.
2190         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2191         (spu_auto_flush_cache_p): Likewise.
2192         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2193         Likewise.
2194         (struct info_print_options) <quiet>: Likewise.
2195         * symfile-debug.c (debug_symfile): Likewise.
2196         * symfile.c (auto_solib_add): Likewise.
2197         (separate_debug_file_debug): Likewise.
2198         * symfile.h (auto_solib_add): Likewise.
2199         (separate_debug_file_debug): Likewise.
2200         * symtab.c (basenames_may_differ): Likewise.
2201         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2202         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2203         (struct info_types_options) <quiet>: Likewise.
2204         * symtab.h (demangle): Likewise.
2205         (basenames_may_differ): Likewise.
2206         * target-dcache.c (stack_cache_enabled_1): Likewise.
2207         (code_cache_enabled_1): Likewise.
2208         * target.c (trust_readonly): Likewise.
2209         (may_write_registers): Likewise.
2210         (may_write_memory): Likewise.
2211         (may_insert_breakpoints): Likewise.
2212         (may_insert_tracepoints): Likewise.
2213         (may_insert_fast_tracepoints): Likewise.
2214         (may_stop): Likewise.
2215         (auto_connect_native_target): Likewise.
2216         (target_stop_and_wait): Update.
2217         (target_async_permitted): Change to bool.
2218         (target_async_permitted_1): Likewise.
2219         (may_write_registers_1): Likewise.
2220         (may_write_memory_1): Likewise.
2221         (may_insert_breakpoints_1): Likewise.
2222         (may_insert_tracepoints_1): Likewise.
2223         (may_insert_fast_tracepoints_1): Likewise.
2224         (may_stop_1): Likewise.
2225         * target.h (target_async_permitted): Likewise.
2226         (may_write_registers): Likewise.
2227         (may_write_memory): Likewise.
2228         (may_insert_breakpoints): Likewise.
2229         (may_insert_tracepoints): Likewise.
2230         (may_insert_fast_tracepoints): Likewise.
2231         (may_stop): Likewise.
2232         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2233         (make_thread_apply_all_options_def_group): Change argument from int*
2234         to bool*.
2235         (thread_apply_all_command): Update.
2236         (print_thread_events): Change to bool.
2237         * top.c (confirm): Likewise.
2238         (command_editing_p): Likewise.
2239         (history_expansion_p): Likewise.
2240         (write_history_p): Likewise.
2241         (info_verbose): Likewise.
2242         * top.h (confirm): Likewise.
2243         (history_expansion_p): Likewise.
2244         * tracepoint.c (disconnected_tracing): Likewise.
2245         (circular_trace_buffer): Likewise.
2246         * typeprint.c (print_methods): Likewise.
2247         (print_typedefs): Likewise.
2248         * utils.c (debug_timestamp): Likewise.
2249         (sevenbit_strings): Likewise.
2250         (pagination_enabled): Likewise.
2251         * utils.h (sevenbit_strings): Likewise.
2252         (pagination_enabled): Likewise.
2253         * valops.c (overload_resolution): Likewise.
2254         * valprint.h (struct value_print_options) <prettyformat_arrays,
2255         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2256         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2257         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2258         Likewise.
2259         * windows-nat.c (new_console): Likewise.
2260         (cygwin_exceptions): Likewise.
2261         (new_group): Likewise.
2262         (debug_exec): Likewise.
2263         (debug_events): Likewise.
2264         (debug_memory): Likewise.
2265         (debug_exceptions): Likewise.
2266         (useshell): Likewise.
2267         * windows-tdep.c (maint_display_all_tib): Likewise.
2268         * xml-support.c (debug_xml): Likewise.
2269
2270 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2271
2272         * source.c (prepare_path_for_appending): New function.
2273         (openp): Make use of new function.
2274         (find_and_open_source): Search for the compilation directory and
2275         source file as a relative path beneath the directory search path.
2276
2277 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2278
2279         * source-cache.c (source_cache::get_line_charpos): Catch
2280         exceptions and return false, this matches the behaviour documented
2281         in the header file.
2282
2283 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2284
2285         * ada-tasks.c (info_task): Remove quoting of the task's name.
2286
2287 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2288
2289         * symfile.c (auto_solib_add): Replace comment with a reference
2290         to the header file.
2291
2292 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2293
2294         * NEWS: Mention that gdb can now be compiled with Python 3
2295         on Windows.
2296
2297 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * maint.c (maint_print_section_data::maint_print_section_data):
2300         Force use of 'float log10 (float)' by casting the argument to
2301         float.
2302
2303 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * maint.c: Add 'cmath' include.
2306         (struct maint_print_section_data): New structure.
2307         (print_section_index): New function.
2308         (print_bfd_section_info): Add header comment, small whitespace
2309         cleanup, and update to call new print_section_index function.
2310         (print_objfile_section_info): Likewise.
2311         (maint_obj_section_from_bfd_section): New function.
2312         (print_bfd_section_info_maybe_relocated): New function.
2313         (maintenance_info_sections): Add header comment, always use
2314         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2315
2316 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2319         inner scope, add check that the objfile has psymtabs before
2320         checking psymtabs_addrmap.
2321         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2322
2323 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2324
2325         * NEWS: Announce that Ada task names are now shown at more places,
2326         and between quotes (except in info task output).
2327         * gdb/ada-tasks.c (task_to_str): New function.
2328         (display_current_task_id): Call task_to_str.
2329         (task_command_1): Likewise.
2330         (print_ada_task_info): In non-mi mode, Properly align headers and data
2331         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2332
2333 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2334
2335         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2336         prstatus.pr_lwp.pr_info instead of making it up.
2337
2338 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2339
2340         * auto-load.c (auto_load_expand_dir_vars): Update.
2341         * defs.h (gdb_datadir): Change to std::string.
2342         (python_libdir): Likewise.
2343         (relocate_gdb_directory): Change return type to std::string.
2344         * guile/guile.c (gdbscm_data_directory): Update.
2345         (initialize_scheme_side): Update.
2346         * jit.c (jit_reader_dir): Change to std::string.
2347         (jit_reader_load_command): Update.
2348         * main.c (gdb_datadir): Change to std::string.
2349         (python_libdir): Likewise.
2350         (set_gdb_data_directory): Update.
2351         (relocate_path): Change to return std::string.
2352         (relocate_gdb_directory): Change to return std::string.
2353         (relocate_gdbinit_path_maybe_in_datadir): Update.
2354         (captured_main_1): Update.
2355         * python/python.c (do_start_initialization): Update.
2356         * top.c (show_gdb_datadir): Update.
2357         * xml-syscall.c (xml_init_syscalls_info): Update.
2358         (init_syscalls_info): Update.
2359
2360 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2361
2362         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2363         out of get_init_files.
2364         (get_init_files): Update.
2365
2366 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2367
2368         * main.c (get_init_files): Change to use std::string.
2369         (captured_main_1): Update.
2370         (print_gdb_help): Update.
2371
2372 2019-09-11  Ali Tamur  <tamur@google.com>
2373
2374         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2375         implementation.
2376
2377 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * dbxread.c (read_dbx_symtab): Update.
2380         * dwarf2read.c (load_partial_dies): Update.
2381         * mdebugread.c (parse_partial_symbols): Update.
2382         (handle_psymbol_enumerators): Update.
2383         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2384         * psymtab.c (add_psymbol_to_bcache): Likewise.
2385         (add_psymbol_to_list): Likewise.
2386         * symtab.c (symbol_set_names): Likewise.
2387         * symtab.h (symbol_set_names): Likewise.
2388         * xcoffread.c (scan_xcoff_symtab): Update.
2389
2390 2019-09-11  Tom Tromey  <tom@tromey.com>
2391
2392         * symfile-mem.c (symbol_file_add_from_memory): Use
2393         bfd_set_filename.
2394         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2395         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2396
2397 2019-09-10  Tom Tromey  <tromey@adacore.com>
2398
2399         * dwarf-index-write.c (write_psymbols): Extend error message.
2400         (debug_names::insert): Add Ada code.
2401         (debug_names::write_psymbols): Remove Ada check.
2402         (debug_names) <m_string_obstack>: New member.
2403         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2404         (gdb_index_symbol_name_matcher::matches): Remove.
2405         (mapped_index_base::find_name_components_bounds): Add "lang"
2406         parameter.
2407         (mapped_index_base::build_name_components): Also split names
2408         according to Ada syntax.
2409         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2410         type of "match_callback".
2411         (check_match, check_find_bounds_finds)
2412         (dw2_expand_symtabs_matching): Update.
2413         (dw2_debug_names_iterator): Add new constructor.
2414         (dw2_debug_names_map_matching_symbols): New function.
2415         (dw2_debug_names_expand_symtabs_matching): Update.
2416         (dwarf2_debug_names_functions): Use
2417         dw2_debug_names_map_matching_symbols.
2418
2419 2019-09-10  Tom Tromey  <tromey@adacore.com>
2420
2421         * dwarf2read.c (dw2_get_file_names_reader): Add the
2422         CU's file name to the results.
2423
2424 2019-09-10  Tom Tromey  <tromey@adacore.com>
2425
2426         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2427         map_matching_symbols.  Update.
2428         * dwarf2read.c (dw2_map_matching_symbols): Update.
2429         * psymtab.c (match_partial_symbol): Change type; update.
2430         (psym_map_matching_symbols): Likewise.
2431         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2432         type; update.
2433         * symfile.h (struct quick_symbol_functions)
2434         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2435         Remove "match".
2436
2437 2019-09-10  Tom Tromey  <tromey@adacore.com>
2438
2439         * psymtab.c (map_block): Remove.
2440         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2441         * symtab.c (iterate_over_symbols_terminated): New function.
2442         * symtab.c (iterate_over_symbols_terminated): Declare.
2443
2444 2019-09-10  Tom Tromey  <tromey@adacore.com>
2445
2446         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2447         * language.h (struct language_defn) <la_iterate_over_symbols>:
2448         Return bool.
2449         * symtab.c (iterate_over_symbols): Return bool.
2450         * symtab.h (iterate_over_symbols): Return bool.
2451
2452 2019-09-10  Tom Tromey  <tromey@adacore.com>
2453
2454         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2455         (add_nonlocal_symbols): Update.
2456         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2457         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2458         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2459         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2460         Change type of "callback".  Remove "data".
2461
2462
2463 2019-09-09  Ali Tamur  <tamur@google.com>
2464
2465         * dwarf2read.c (comp_unit_head): Update comment.
2466         (dwarf2_dwo_name): New function declaration.
2467         (dwarf_unit_type_name): New function declaration.
2468         (read_comp_unit_head): Add support for new compilation units,
2469         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2470         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2471         (currently named as "signature") in their header. Also clarify error
2472         messages.
2473         (lookup_dwo_id): New function. Returns the dwo id of the given
2474         compile unit.
2475         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2476         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2477         functions.
2478         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2479         (dwarf2_dwo_name): Get the dwo name if present.
2480         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2481         purposes.
2482
2483 2019-09-09  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2486
2487 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2488
2489         * python/python.c (do_start_initialization): Make progname_copy static,
2490         to avoid a leak report.
2491
2492 2019-09-08  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2495
2496 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2497
2498         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2499         Change type to gdb::optional<block_enum>.
2500         (dw2_symtab_iter_init): Change block_index parameter type
2501         to gdb::optional<block_enum>.
2502         (dw2_lookup_symbol): Change block_index parameter
2503         type to block_enum.c
2504         (dw2_debug_names_lookup_symbol): Likewise.
2505         * psymtab.c (psym_lookup_symbol): Likewise.
2506         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2507         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2508         Likewise.
2509
2510 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2511
2512         * defs.h (relocate_gdb_directory): Change int to bool in
2513         signature and rename flag to relocatable.
2514         * main.c (relocate_path): Likewise.
2515         (relocate_gdb_directory): Likewise.
2516
2517 2019-09-06  Alan Modra  <amodra@gmail.com>
2518
2519         * coffread.c (coff_symfile_read): Constify filename variable.
2520         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2521         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2522         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2523         * solib.c (reload_shared_libraries_1): Likewise.
2524         * symfile.c (reread_symbols): Likewise.
2525         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2526         * solib-darwin.c (darwin_bfd_open): Likewise.
2527         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2528
2529 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2532         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2533
2534 2019-09-03  Tom Tromey  <tromey@adacore.com>
2535
2536         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2537         types.
2538         (has_negatives): Unbias a range type bound.
2539         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2540         * gdbtypes.c (operator==): Handle new field.
2541         (create_range_type): Add "bias" parameter.
2542         (create_static_range_type, resolve_dynamic_range): Update.
2543         * gdbtypes.h (struct range_bounds) <bias>: New member.
2544         (create_range_type): Add bias parameter.
2545         * printcmd.c (print_scalar_formatted): Unbias range types.
2546         * value.c (unpack_long): Unbias range types.
2547         (pack_long): Bias range types.
2548
2549 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2550
2551         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2552         probe arguments.
2553
2554 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2555
2556         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2557         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2558         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2559         (compile_probe_arg): Likewise.
2560         * probe.h (get_argument_count): Likewise.
2561         * solib-svr4.c (solib_event_probe_action): Likewise.
2562         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2563
2564 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2565
2566         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2567         code to here...
2568         (svr4_create_solib_event_breakpoints): ...from here.
2569
2570 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2571
2572         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2573         suffix from warning message.
2574
2575 2019-08-30  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-winsource.h (struct tui_source_window_base)
2578         <refresh_all>: Don't declare.
2579         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2580         Remove.
2581         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2582         tui_show_locator_content.
2583         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2584         declare.
2585         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2586         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2587         declare.
2588
2589 2019-08-30  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2592
2593 2019-08-30  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2596         Remove unnecessary forward declarations.
2597
2598 2019-08-30  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2601         rerender.
2602         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2603         tui_show_locator_content.
2604
2605 2019-08-30  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2608         (tui_locator_window::rerender): Rewrite using body of previous
2609         tui_show_locator_content.
2610
2611 2019-08-30  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2614         set_locator_fullname>: New methods.
2615         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2616         Rename from tui_set_locator_fullname.
2617         (tui_locator_window::set_locator_info): Rename from
2618         tui_set_locator_info.  Return bool.
2619         (tui_update_locator_fullname, tui_show_frame_info): Update.
2620
2621 2019-08-30  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2624
2625 2019-08-30  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2628         call touchwin.
2629
2630 2019-08-30  Tom Tromey  <tom@tromey.com>
2631
2632         * tui/tui-wingeneral.c (box_win): Assume win_info and
2633         win_info->handle cannot be NULL.
2634
2635 2019-08-30  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2638         refresh_window>: Declare.
2639         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2640         resize.
2641         (tui_data_item_window::rerender): Rename from
2642         tui_display_register.
2643         (tui_data_item_window::refresh_window): New method.
2644         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2645         no-op.
2646
2647 2019-08-30  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2650         regs_column_count, current_group>: Move later.  Now private.
2651         <get_current_group>: New method.
2652         * tui/tui-regs.c (tui_reg_command): Update.
2653         * tui/tui-layout.c (tui_set_layout): Update.
2654
2655 2019-08-30  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2658         (tui_data_window::rerender): Don't call
2659         check_and_display_highlight_if_needed.
2660         (tui_data_window::refresh_all): Remove call to
2661         erase_data_content.
2662
2663 2019-08-30  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2666         (tui_data_window::display_registers_from)
2667         (tui_data_window::display_reg_element_at_line)
2668         (tui_data_window::display_registers_from_line): Remove checks of
2669         "empty".
2670
2671 2019-08-30  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2674         Don't declare.
2675         * tui/tui-regs.c (tui_data_window::show_registers): Call
2676         rerender.
2677         (tui_data_window::rerender): Rename from display_all_data.
2678         (tui_data_window::rerender): Remove old implementation.
2679
2680 2019-08-30  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2683         text.
2684         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2685
2686 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2687             Sergio Durigan Junior  <sergiodj@redhat.com>
2688
2689         PR win32/24284
2690         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2691
2692 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2695         when searching for types.
2696
2697 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2698
2699         * f-lang.c (f_language_defn): Use f_print_typedef.
2700         * f-lang.h (f_print_typedef): Declare.
2701         * f-typeprint.c (f_print_typedef): Define.
2702
2703 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2704
2705         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2706
2707 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2708
2709         * cli/cli-utils.c (info_print_options_defs): Delete.
2710         (make_info_print_options_def_group): Delete.
2711         (extract_info_print_options): Delete.
2712         (info_print_command_completer): Delete.
2713         (info_print_args_help): Add extra parameter, and optionally
2714         include text about -n flag.
2715         * cli/cli-utils.h (struct info_print_options): Delete.
2716         (extract_info_print_options): Delete declaration.
2717         (info_print_command_completer): Delete declaration.
2718         (info_print_args_help): Add extra parameter, extend header
2719         comment.
2720         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2721         search_symbols.
2722         * stack.c (struct info_print_options): New type.
2723         (info_print_options_defs): New file scoped variable.
2724         (make_info_print_options_def_group): New static function.
2725         (info_print_command_completer): New static function.
2726         (info_locals_command): Update to use new local functions.
2727         (info_args_command): Likewise.
2728         (_initialize_stack): Add extra parameter to calls to
2729         info_print_args_help.
2730         * symtab.c (search_symbols): Add extra parameter, use this to
2731         possibly excluse non-debug symbols.
2732         (symtab_symbol_info): Add extra parameter, which is passed on to
2733         search_symbols.
2734         (struct info_print_options): New type.
2735         (info_print_options_defs): New file scoped variable.
2736         (make_info_print_options_def_group): New static function.
2737         (info_print_command_completer): New static function.
2738         (info_variables_command): Update to use local functions, and pass
2739         extra parameter through to symtab_symbol_info.
2740         (info_functions_command): Likewise.
2741         (info_types_command): Pass additional argument through to
2742         symtab_symbol_info.
2743         (rbreak_command): Pass extra argument to search_symbols.
2744         (_initialize_symtab): Add extra arguments for calls to
2745         info_print_args_help, and update help text for 'info variables',
2746         'whereis', and 'info functions' commands.
2747         * symtab.h (search_symbols): Add extra argument to declaration.
2748         * NEWS: Mention new flags.
2749
2750 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2751
2752         * symtab.c (lookup_static_symbol): Call the new function (and move
2753         it down to be next to lookup_global_symbol).
2754         (struct global_sym_lookup_data): Add block_enum member and rename to...
2755         (struct global_or_static_sym_lookup_data): ...this.
2756         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2757         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2758         (lookup_symbol_global_or_static_iterator_cb): ...this.
2759         (lookup_global_or_static_symbol): New function.
2760         (lookup_global_symbol): Call new function.
2761
2762 2019-08-26  Tom de Vries  <tdevries@suse.de>
2763
2764         PR c++/24852
2765         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2766         when pc_probe.prob == NULL.
2767
2768 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2769
2770         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2771         variable symbol_linkage to symbol_linkage_.
2772
2773 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2774
2775         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2776         represent whether the symbol is static, dynamic, or we don't
2777         know.
2778
2779 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2780
2781         * gdb/rx-tdep.c (rx_register_names): New.
2782         (rx_register_name): Delete.
2783         (rx_psw_type): Delete.
2784         (rx_fpsw_type): Delete.
2785         (rx_register_type): Delete.
2786         (rx_gdbarch_init): Convert target-descriptions.
2787         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2788         * gdb/features/Makefile: Add rx.xml.
2789         * gdb/features/rx.xml: New.
2790         * gdb/features/rx.c: Generated.
2791         * gdb/NEWS: Mention target description support.
2792
2793 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2794
2795         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2796         *slot_ptr.
2797
2798 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2799
2800         * configure.ac: Don't check for 'dlfcn.h' (moved to
2801         gdbsupport/common.m4).
2802         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2803         'gdbsupport/'.
2804         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2805         * compile/compile-c-support.c: Include
2806         'gdbsupport/gdb-dlfcn.h'.
2807         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2808         * gdb-dlfcn.c: Move to...
2809         * gdbsupport/gdb-dlfcn.c: ... here.
2810         * gdb-dlfcn.h: Move to...
2811         * gdbsupport/gdb-dlfcn.h: ... here.
2812
2813 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2814
2815         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2816         the offset field signed.
2817
2818 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2819
2820         * python/lib/gdb/__init__.py (_execute_file): New function.
2821         * python/python.c (python_run_simple_file): Call gdb._execute_file
2822         on Windows.
2823
2824 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2827         all uses as this was never set to anything but a zero value.
2828
2829 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2830
2831         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2832
2833 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2834
2835         * tui/tui-data.h (tui_gen_win_info): Add an =default
2836         move constructor, required by some GCC versions.
2837
2838 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2839
2840         * go32-nat.c (go32_sysinfo): Add hygon_p.
2841
2842 2019-08-20  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2845         line_from_reg_element_no, first_reg_element_no_inline,
2846         display_all_data, delete_data_content_windows,
2847         erase_data_content>: Now private.
2848
2849 2019-08-20  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2852         (tui_unhighlight_win, tui_highlight_win)
2853         (tui_win_info::make_window): Update.
2854         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2855
2856 2019-08-20  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2859         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2860         (MAX_PID_WIDTH): Move to tui-stack.c.
2861         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2862         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2863         (MAX_PID_WIDTH): Move from tui-data.h.
2864
2865 2019-08-20  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2868         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2869         (box_win): Update.
2870         (tui_gen_win_info::make_window): Rename from tui_make_window.
2871         (tui_win_info::make_window): New method.
2872         (tui_gen_win_info::make_visible): Update.
2873         * tui/tui-source.c (tui_source_window::set_contents): Update.
2874         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2875         (tui_data_window::display_registers_from): Update.
2876         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2877         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2878         Declare.
2879         <can_box>: Remove.
2880         <title>: Remove.
2881         (struct tui_win_info) <make_window>: Declare.
2882         <can_box>: Now virtual.
2883         <title>: New member.
2884         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2885         * tui/tui-command.c (tui_cmd_window::resize): Update.
2886
2887 2019-08-20  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2890         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2891         (tui_data_window::check_register_values): Update.
2892
2893 2019-08-20  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-regs.h (struct tui_data_window): Use
2896         DISABLE_COPY_AND_ASSIGN.
2897         <regs_content>: Change type, removing unique_ptr.
2898         <tui_data_window>: Add move constructor.
2899         * tui/tui-regs.c (tui_data_window::show_registers)
2900         (tui_data_window::show_register_group)
2901         (tui_data_window::display_registers_from)
2902         (tui_data_window::display_registers_from)
2903         (tui_data_window::first_data_item_displayed)
2904         (tui_data_window::delete_data_content_windows)
2905         (tui_data_window::rerender, tui_data_window::refresh_window)
2906         (tui_data_window::check_register_values): Update.
2907
2908 2019-08-20  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2911         show_register_group>: Declare.
2912         (tui_show_register_group): Don't declare.
2913         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2914         tui_show_registers.
2915         (tui_data_window::show_register_group): Rename from
2916         tui_show_register_group.
2917         (tui_data_window::check_register_values, tui_reg_command):
2918         Update.
2919         * tui/tui-layout.c (tui_set_layout): Update.
2920
2921 2019-08-20  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2924         Declare.
2925         (tui_check_register_values): Don't declare.
2926         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2927         from tui_check_register_values.
2928         * tui/tui-hooks.c (tui_register_changed): Update.
2929
2930 2019-08-20  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-regs.c (tui_reg_layout): Move later.
2933         (tui_show_registers): Don't enable TUI mode or change layout.
2934
2935 2019-08-20  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-regs.h (struct tui_data_item_window)
2938         <~tui_data_item_window>: Remove.
2939         <content>: Now a unique_xmalloc_ptr.
2940         * tui/tui-regs.c (tui_register_format): Return a
2941         unique_xmalloc_ptr.
2942         (tui_get_register): Update.
2943         (~tui_data_item_window): Remove.
2944         (tui_data_window::display_registers_from, tui_display_register):
2945         Update.
2946         * tui/tui-io.h (tui_expand_tabs): Update.
2947         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2948         Remove "col" parameter.
2949
2950 2019-08-20  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2953         field.
2954         * tui/tui-regs.c (~tui_data_item_window): Update.
2955
2956 2019-08-20  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2959         earlier.
2960
2961 2019-08-20  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2964
2965 2019-08-20  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-source.h (struct tui_source_window): Update.
2968         * tui/tui-regs.c (tui_show_registers): Update.
2969         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2970         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2971         (NO_REGS_STRING): Remove defines.
2972
2973 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2974
2975         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2976         unnecessary thread walk if remote doesn't support the packet.
2977
2978 2019-08-19  Tom Tromey  <tromey@adacore.com>
2979
2980         * python/py-value.c (value_has_field): Fix indentation.
2981
2982 2019-08-19  Tom Tromey  <tromey@adacore.com>
2983
2984         * printcmd.c (do_one_display, info_display_command): Update.
2985         * block.h (contained_in): Return bool.  Add allow_nested
2986         parameter.
2987         * block.c (contained_in): Return bool.  Add allow_nested
2988         parameter.
2989
2990 2019-08-19  Tom Tromey  <tom@tromey.com>
2991
2992         * configure: Rebuild.
2993         * configure.ac: Disallow the combination of -static-libstdc++ and
2994         source highlight.
2995         * source-cache.c (get_language_name): Handle rust.
2996         (source_cache::get_source_lines): Ignore highlighting exceptions.
2997
2998 2019-08-16  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3001         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3002         (struct tui_source_window_base) <make_visible, refresh_window,
3003         resize>: Remove methods.
3004         <execution_info>: Remove field.
3005         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3006         (tui_show_source_line, tui_source_window_base)
3007         (~tui_source_window_base): Update.
3008         (tui_source_window_base::resize)
3009         (tui_source_window_base::make_visible)
3010         (tui_source_window_base::refresh_window): Remove.
3011         (tui_source_window_base::update_exec_info): Update.
3012         * tui/tui-source.c (tui_source_window::set_contents): Update.
3013         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3014
3015 2019-08-16  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3018         deprecated_query_hook.
3019
3020 2019-08-16  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3023         (tui_update_source_windows_with_line): Update.
3024         * tui/tui-source.h (struct tui_source_window)
3025         <show_symtab_source>: Declare.
3026         (tui_show_symtab_source): Don't declare.
3027         * tui/tui-source.c (tui_show_symtab_source): Rename from
3028         tui_show_symtab_source.
3029
3030 2019-08-16  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-winsource.h (struct tui_source_window_base)
3033         <set_contents>: Declare.
3034         * tui/tui-winsource.c
3035         (tui_source_window_base::update_source_window_as_is): Update.
3036         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3037         Declare.
3038         (tui_set_source_content): Don't declare.
3039         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3040         tui_set_source_content.
3041         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3042         Declare.
3043         (tui_set_disassem_content): Don't declare.
3044         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3045         tui_set_disassem_content.
3046
3047 2019-08-16  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-winsource.h (struct tui_source_window_base)
3050         <update_breakpoint_info>: Declare.
3051         (tui_update_breakpoint_info): Don't declare.
3052         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3053         (tui_update_all_breakpoint_info): Update.
3054         (tui_source_window_base::update_breakpoint_info): Rename from
3055         tui_update_breakpoint_info.
3056         (tui_source_window_base::update_exec_info): Update.
3057
3058 2019-08-16  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-winsource.h (struct tui_source_window_base)
3061         <update_source_window>: Declare.
3062         (tui_update_source_window): Don't declare.
3063         * tui/tui-winsource.c
3064         (tui_source_window_base::update_source_window): Rename from
3065         tui_update_source_window.
3066         (tui_source_window_base::rerender): Update.
3067         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3068         * tui/tui-disasm.c (tui_show_disassem)
3069         (tui_show_disassem_and_update_source)
3070         (tui_disasm_window::maybe_update): Update.
3071
3072 2019-08-16  Tom Tromey  <tom@tromey.com>
3073
3074         * tui/tui-winsource.h (struct tui_source_window_base)
3075         <update_source_window_as_is>: Declare.
3076         (tui_update_source_window_as_is): Don't declare.
3077         * tui/tui-winsource.c (tui_update_source_window): Update
3078         (tui_source_window_base::update_source_window_as_is): Rename from
3079         tui_update_source_window_as_is.
3080         (tui_source_window_base::refill): Update.
3081         * tui/tui-source.c (tui_show_symtab_source): Update.
3082         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3083         Update.
3084
3085 2019-08-16  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-winsource.h (tui_update_source_window)
3088         (tui_update_source_window_as_is): Remove "noerror" parameter.
3089         * tui/tui-winsource.c (tui_update_source_window)
3090         (tui_update_source_window_as_is): Remove "noerror" parameter.
3091         (tui_update_source_windows_with_addr)
3092         (tui_update_source_windows_with_line)
3093         (tui_source_window_base::rerender)
3094         (tui_source_window_base::refill): Update.
3095         * tui/tui-source.h (tui_set_source_content)
3096         (tui_show_symtab_source): Remove "noerror" parameter.
3097         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3098         parameter.
3099         (tui_show_symtab_source): Likewise.
3100         (tui_source_window::maybe_update): Update.
3101         * tui/tui-disasm.c (tui_show_disassem)
3102         (tui_show_disassem_and_update_source)
3103         (tui_disasm_window::do_scroll_vertical)
3104         (tui_disasm_window::maybe_update): Update.
3105
3106 2019-08-16  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui.c (tui_is_window_visible): Update.
3109         * tui/tui-wingeneral.c (tui_make_window)
3110         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3111         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3112         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3113         (tui_set_win_height_command, parse_scrolling_args): Update.
3114         * tui/tui-source.c (tui_source_window::style_changed): Update.
3115         * tui/tui-regs.c (tui_show_registers)
3116         (tui_data_window::first_data_item_displayed)
3117         (tui_data_window::delete_data_content_windows)
3118         (tui_check_register_values, tui_reg_command): Update.
3119         * tui/tui-disasm.c (tui_show_disassem): Update.
3120         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3121         method.
3122         <is_visible>: Remove field.
3123         * tui/tui-data.c (tui_next_win, tui_prev_win)
3124         (tui_delete_invisible_windows): Update.
3125
3126 2019-08-16  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-winsource.h (struct tui_source_window_base)
3129         <m_has_locator>: Remove.
3130         * tui/tui-layout.c (show_source_disasm_command, show_data)
3131         (show_source_or_disasm_and_command): Update.
3132
3133 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3134
3135         * NEWS (Other MI changes): New subsection.
3136         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3137         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3138         * arch-utils.c (default_get_pc_address_flags): New function.
3139         * arch-utils.h (default_get_pc_address_flags): New declaration.
3140         * gdbarch.sh: Add get_pc_address_flags.
3141         * gdbarch.c: Regenerate.
3142         * gdbarch.h: Likewise.
3143         * stack.c (print_pc): New function.
3144         (print_frame_info) (print_frame): Call print_pc.
3145
3146 2019-08-16  Tom de Vries  <tdevries@suse.de>
3147
3148         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3149         print_objfile_section_info.
3150
3151 2019-08-15  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3154         calling update_cmdwin_start_line.
3155         * tui/tui-winsource.h (struct tui_source_window_base)
3156         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3157         <rerender>: Declare.
3158         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3159         Call rerender.
3160         (tui_source_window_base::set_new_height): Remove.
3161         (tui_source_window_base::rerender): Rename from
3162         do_make_visible_with_new_height.
3163         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3164         resize method.
3165         (tui_win_info::make_invisible_and_set_new_height)
3166         (tui_win_info::make_visible_with_new_height): Remove.
3167         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3168         Declare.
3169         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3170         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3171         do_make_visible_with_new_height>: Don't declare.
3172         <rerender>: Declare.
3173         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3174         set_new_height.
3175         (tui_data_window::do_make_visible_with_new_height): Remove.
3176         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3177         call tui_show_locator_content.
3178         (tui_gen_win_info::resize): Call rerender.
3179         (show_source_or_disasm_and_command): Don't call
3180         tui_show_locator_content.
3181         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3182         method.
3183         (struct tui_win_info) <rerender>: Declare.
3184         <set_new_height, make_invisible_and_set_new_height,
3185         make_visible_with_new_height>: Don't declare.
3186         * tui/tui-data.c (tui_win_list::rerender): New method.
3187         * tui/tui-command.h (struct tui_cmd_window)
3188         <do_make_visible_with_new_height>: Don't declare.
3189         * tui/tui-command.c
3190         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3191
3192 2019-08-15  Tom Tromey  <tromey@adacore.com>
3193
3194         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3195         * ada-lang.c (ada_enum_name): Likewise.
3196
3197 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3198
3199         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3200         leading underscore.
3201         (GdbOutputErrorFile): Likewise.
3202         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3203         accordingly.
3204         (execute_unwinders): Rename to have a leading underscore.
3205         (auto_load_packages): Likewise.
3206         (global scope): Adjust call to auto_load_packages accordingly.
3207         (GdbSetPythonDirectory): Likewise.
3208         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3209         instead of execute_unwinders.
3210
3211 2019-08-15  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3214         (show_data): Don't change window visibility.
3215         (tui_gen_win_info::resize): Remove special case for command
3216         window.  Use wresize, when available.
3217         (show_source_or_disasm_and_command): Don't change window
3218         visibility.
3219         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3220         <make_visible>: New method.
3221         * tui/tui-command.c (tui_cmd_window::resize): New method.
3222
3223 2019-08-15  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3226         (struct tui_source_windows): New.
3227         * tui/tui-winsource.c (tui_display_main): Update.
3228         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3229         (new_height_ok, parse_scrolling_args): Update.
3230         * tui/tui-layout.c (show_layout, show_data): Update.
3231         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3232         (tui_add_to_source_windows): Don't declare.
3233         * tui/tui-data.c (source_windows, tui_source_windows)
3234         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3235
3236 2019-08-15  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3239         Rename from reset.
3240         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3241         * tui/tui-layout.c (show_source_disasm_command, show_data):
3242         Update.
3243         (tui_gen_win_info::resize): Rename.
3244         (show_source_or_disasm_and_command): Update.
3245         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3246         reset.
3247
3248 2019-08-15  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3251         * tui/tui-interp.c (tui_interp::init): Don't call
3252         tui_initialize_static_data.
3253         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3254
3255 2019-08-15  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3258         examine tui_win_list.
3259
3260 2019-08-15  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3263         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3264         tui_clear_source_content.
3265         (tui_clear_source_content): Remove.
3266         (tui_source_window_base::do_erase_source_content): Hoist call to
3267         content.clear().
3268         * tui/tui-stack.c (tui_show_frame_info): Don't call
3269         tui_clear_source_content.
3270
3271 2019-08-15  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-winsource.h (struct tui_source_window_base)
3274         <do_erase_source_content>: New method.
3275         <erase_source_content>: New method.
3276         (tui_erase_source_content): Don't declare.
3277         * tui/tui-winsource.c (tui_clear_source_content): Update.
3278         (tui_source_window_base::do_erase_source_content): Rename from
3279         tui_erase_source_content.
3280         (tui_source_window_base::show_source_content): Update.
3281         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3282         * tui/tui-source.h (struct tui_source_window)
3283         <erase_source_content>: New method.
3284         * tui/tui-disasm.h (struct tui_disasm_window)
3285         <erase_source_content>: New method.
3286
3287 2019-08-15  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3290         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3291         constructor.
3292         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3293         * tui/tui-source.c (tui_set_source_content): Update.
3294         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3295
3296 2019-08-15  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3299         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3300         tui-source.c.
3301         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3302         Declare.
3303         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3304         method.
3305         (tui_source_window::maybe_update): Update.
3306
3307 2019-08-15  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3310         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3311         tui-disasm.c.
3312         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3313         Declare.
3314         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3315         method.
3316         (tui_disasm_window::maybe_update): Update.
3317
3318 2019-08-15  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-winsource.h (struct tui_source_window_base)
3321         <maybe_update>: Declare.
3322         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3323         method.
3324         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3325         Declare.
3326         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3327         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3328         Declare.
3329         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3330
3331 2019-08-15  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3334
3335 2019-08-15  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-wingeneral.c: Include tui-stack.h.
3338         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3339         (struct tui_locator_window): Move from tui-data.h.
3340         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3341         (tui_initialize_static_data): Move from tui-data.c.
3342         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3343         (struct tui_locator_window): Move to tui-stack.c.
3344         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3345         (tui_initialize_static_data): Move to tui-stack.c.
3346
3347 2019-08-15  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-layout.c (show_source_disasm_command)
3350         (show_source_or_disasm_and_command): Use make_visible method, not
3351         tui_make_window.
3352         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3353         Remove.
3354
3355 2019-08-15  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-wingeneral.h (tui_make_window): Update.
3358         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3359         parameter.
3360         (tui_gen_win_info::make_visible): Update.
3361         * tui/tui-regs.c (tui_data_window::display_registers_from):
3362         Update.
3363         * tui/tui-layout.c (show_source_disasm_command)
3364         (show_source_or_disasm_and_command): Update.
3365         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3366         (enum tui_box): Remove.
3367         (struct tui_win_info) <can_box>: New method.
3368         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3369         method.
3370
3371 2019-08-15  Tom de Vries  <tdevries@suse.de>
3372
3373         * linux-nat-trad.c: Include gdbarch.h.
3374
3375 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3376
3377         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3378         register sizes.
3379
3380 2019-08-14  Tom Tromey  <tromey@adacore.com>
3381
3382         * darwin-nat.c: Include gdbarch.h.
3383         * darwin-nat-info.c: Include gdbarch.h.
3384
3385 2019-08-13  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3388         Remove.
3389         * tui/tui-data.c (tui_initialize_static_data): Update.
3390
3391 2019-08-13  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-winsource.h (struct tui_exec_info_window)
3394         <~tui_exec_info_window, maybe_allocate_content, get_content,
3395         m_content>: Remove.
3396         (struct tui_source_window_base) <set_exec_info_content,
3397         show_exec_info_content>: Don't declare.
3398         * tui/tui-winsource.c
3399         (tui_exec_info_window::maybe_allocate_content): Remove.
3400         (tui_source_window_base::update_exec_info): Rename from
3401         set_exec_info_content.
3402         (tui_source_window_base::show_exec_info_content)
3403         (tui_source_window_base::update_exec_info): Remove.
3404
3405 2019-08-13  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3408         declare.
3409         * tui/tui-winsource.c (tui_update_source_window_as_is)
3410         (tui_update_source_windows_with_addr, tui_erase_source_content):
3411         Update.
3412         (tui_clear_exec_info_content): Remove.
3413
3414 2019-08-13  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3417         declare.
3418         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3419         call tui_erase_exec_info_content.
3420         (tui_clear_exec_info_content): Rename from
3421         tui_erase_exec_info_content.
3422         (tui_clear_exec_info_content): Delete.
3423
3424 2019-08-13  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-winsource.h (struct tui_source_window_base)
3427         <show_exec_info_content>: Declare.
3428         (tui_show_exec_info_content): Don't declare.
3429         * tui/tui-winsource.c
3430         (tui_source_window_base::show_exec_info_content): Rename from
3431         tui_show_exec_info_content.
3432         (tui_source_window_base::update_exec_info): Update.
3433
3434 2019-08-13  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3437         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3438         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3439         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3440         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3441         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3442         ... here.
3443
3444 2019-08-13  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-winsource.h (struct tui_source_window_base)
3447         <update_exec_info>: Declare.
3448         (tui_update_exec_info): Don't declare.
3449         * tui/tui-winsource.c (tui_update_source_window_as_is)
3450         (tui_source_window_base::refresh_all)
3451         (tui_update_all_breakpoint_info): Update.
3452         (tui_source_window_base::update_exec_info): Rename from
3453         tui_update_exec_info.
3454         * tui/tui-stack.c (tui_show_frame_info): Update.
3455
3456 2019-08-13  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-winsource.h (struct tui_source_window_base)
3459         <set_exec_info_content>: Declare.
3460         (tui_set_exec_info_content): Don't declare.
3461         * tui/tui-winsource.c
3462         (tui_source_window_base::set_exec_info_content): Rename from
3463         tui_set_exec_info_content.
3464         (tui_update_exec_info): Update.
3465
3466 2019-08-13  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-winsource.h (struct tui_source_window_base)
3469         <show_source_content>: Declare.
3470         (tui_show_source_content): Don't declare.
3471         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3472         (tui_source_window_base::show_source_content): Rename from
3473         tui_show_source_content.
3474         (tui_source_window_base::refresh_all): Update.
3475         * tui/tui-layout.c (show_source_disasm_command)
3476         (show_source_or_disasm_and_command): Update.
3477
3478 2019-08-13  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-winsource.c (tui_erase_source_content)
3481         (tui_show_source_content, tui_source_window_base::refresh_all):
3482         Update.
3483         * tui/tui-wingeneral.h
3484         (tui_check_and_display_highlight_if_needed): Don't declare.
3485         * tui/tui-wingeneral.c
3486         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3487         check_and_display_highlight_if_needed.
3488         * tui/tui-win.c (tui_rehighlight_all)
3489         (tui_win_info::make_visible_with_new_height): Update.
3490         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3491         (tui_data_window::erase_data_content)
3492         (tui_data_window::display_all_data): Update.
3493         * tui/tui-data.h (struct tui_win_info)
3494         <check_and_display_highlight_if_needed>: Declare.
3495
3496 2019-08-13  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-win.c (tui_resize_all): Call
3499         tui_delete_invisible_windows.
3500         * tui/tui-layout.c (show_layout): Call
3501         tui_delete_invisible_windows.
3502         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3503         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3504
3505 2019-08-13  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3508         tui_add_win_to_layout.
3509
3510 2019-08-13  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3513         * tui/tui-layout.c (tui_default_win_height): Now static.
3514
3515 2019-08-13  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3518         single switch.
3519         (show_source_disasm_command, show_source_or_disasm_and_command):
3520         Don't check current layout.
3521
3522 2019-08-13  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-wingeneral.c (make_all_visible): Remove.
3525         (tui_make_all_invisible): Simplify.
3526         * tui/tui-layout.c (tui_make_all_invisible): Move from
3527         tui-wingeneral.c; simplify.
3528         (show_layout): Hoist call to tui_make_all_invisible.
3529         (show_data): Don't call tui_make_all_invisible.
3530
3531 2019-08-13  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3534         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3535
3536 2019-08-13  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3539         tui-data.c.
3540         (show_source_disasm_command, show_data)
3541         (show_source_or_disasm_and_command): Don't use
3542         tui_set_current_layout_to.
3543         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3544         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3545         tui-layout.c.
3546         (tui_set_current_layout_to): Remove.
3547
3548 2019-08-13  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-layout.c (tui_set_layout): Update.
3551         * tui/tui-data.h (struct tui_layout_def): Remove.
3552         (tui_layout_def): Don't declare.
3553         * tui/tui-data.c (layout_def): Remove.
3554         (tui_layout_def): Remove.
3555
3556 2019-08-13  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-winsource.h (struct tui_source_window_base)
3559         <clear_detail>: No longer "override".
3560         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3561         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3562         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3563         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3564         Remove.
3565         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3566
3567 2019-08-13  Tom Tromey  <tromey@adacore.com>
3568
3569         * tracepoint.c: Don't include readline.h or history.h.
3570
3571 2019-08-12  Tom Tromey  <tom@tromey.com>
3572
3573         * configure: Rebuild.
3574         * configure.ac: Check for readline 7.
3575         * NEWS: Mention readline 7 requirement.
3576         * README: Update.
3577
3578 2019-08-12  Tom Tromey  <tom@tromey.com>
3579
3580         * mingw-hdep.c (gdb_select): Remove readline hack.
3581
3582 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3583
3584         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3585         when the function fails.
3586
3587 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3588
3589         * s390-tdep.c (s390_type_align): New function.
3590         (s390_gdbarch_init): Set it as type_align gdbarch method.
3591
3592 2019-08-09  Tom de Vries  <tdevries@suse.de>
3593
3594         PR gdb/24591
3595         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3596         pc_low with relocation offset.
3597
3598 2019-08-07  Tom Tromey  <tromey@adacore.com>
3599
3600         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3601         (print_frame_args): Update.
3602         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3603         Update.
3604         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3605         * frame.h (struct frame_arg): Add initializers.
3606         <error>: Now a unique_xmalloc_ptr.
3607
3608 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3609
3610         * NEWS: Expand the Pointer Authentication entry.
3611         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3612         (aarch64_frame_unmask_lr): ... to this.
3613         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3614         Call aarch64_frame_unmask_lr.
3615         * frame.c (struct frame_info): Add "masked" variable.
3616         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3617         (fprint_frame): Check for masked pc.
3618         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3619         declarations.
3620         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3621         * stack.c (print_frame): Check for masked pc.
3622
3623 2019-08-06  Tom Tromey  <tom@tromey.com>
3624
3625         * stabsread.c (patch_block_stabs, read_one_struct_field)
3626         (read_enum_type): Use obstack_strndup.
3627         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3628         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3629         * dwarf2read.c (guess_full_die_structure_name)
3630         (anonymous_struct_prefix): Use obstack_strndup.
3631         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3632         * c-exp.y (yylex): Use obstack_strndup.
3633         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3634         (write_var_or_type): Use obstack_strndup.
3635
3636 2019-08-06  Tom Tromey  <tom@tromey.com>
3637
3638         * symfile.c (reread_symbols): Use obstack_strdup.
3639         * stabsread.c (read_type): Use obstack_strdup.
3640         * gdb_obstack.h (obstack_strdup): New overload.
3641         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3642         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3643         (dwarf2_canonicalize_name): Use obstack_strdup.
3644         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3645         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3646         Use obstack_strdup.
3647
3648 2019-08-06  Tom Tromey  <tom@tromey.com>
3649
3650         * gdb_obstack.h (obstack_strdup): Define.
3651         * gdb_obstack.c (obstack_strdup): Don't define.
3652
3653 2019-08-06  Tom Tromey  <tom@tromey.com>
3654
3655         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3656         obstack_strdup.
3657         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3658         obstack_strdup.
3659         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3660         * stabsread.c (common_block_start): Use obstack_strdup.
3661         * objfiles.c (set_objfile_main_name, objfile): Use
3662         obstack_strdup.
3663         * namespace.c (add_using_directive): Use obstack_strdup.
3664         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3665         * jit.c (finalize_symtab): Use obstack_strdup.
3666         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3667         (guess_partial_die_structure_name, partial_die_info::fixup)
3668         (dwarf2_name): Use obstack_strdup.
3669         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3670         obstack_strdup.
3671         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3672         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3673         obstack_strdup.
3674         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3675
3676 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3677
3678         * unittests/help-doc-selftests.c: New file.
3679         * Makefile.in: Add the new file.
3680
3681 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3682
3683         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3684         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3685         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3686         the trailing '.' is not output, and the first character is uppercased.
3687         (print_help_for_command): Update call to print_doc_line.
3688         (print_doc_of_command): Likewise.
3689         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3690         * cli/cli-option.c (append_indented_doc): Do not append newline.
3691         (build_help_option): Append newline after first appended_indented_doc
3692         only if a second call is done.
3693         (build_help): Append 2 new lines before each option, except the first
3694         one.
3695         * compile/compile.c (_initialize_compile): Add new lines after
3696         %OPTIONS%, when not at the end of the help.
3697         Change help doc or code
3698         producing the help doc to respect the invariants.
3699         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3700         Also removed the new line after 'Options:', as all other commands
3701         do not put an empty line between 'Options:' and the first option.
3702         * printcmd.c (_initialize_printcmd): Likewise.
3703         * stack.c (_initialize_stack): Likewise.
3704         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3705         incorrectly telling COMMAND is optional.
3706         * ada-lang.c (_initialize_ada_language): Change help doc or code
3707         producing the help doc to respect the invariants.
3708         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3709         * breakpoint.c (_initialize_breakpoint): Likewise.
3710         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3711         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3712         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3713         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3714         _initialize_cli_style): Likewise.
3715         * corelow.c (core_target_info): Likewise.
3716         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3717         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3718         * filesystem.c (_initialize_filesystem): Likewise.
3719         * frame.c (_initialize_frame): Likewise.
3720         * gnu-nat.c (add_task_commands): Likewise.
3721         * infcall.c (_initialize_infcall): Likewise.
3722         * infcmd.c (_initialize_infcmd): Likewise.
3723         * interps.c (_initialize_interpreter): Likewise.
3724         * language.c (_initialize_language): Likewise.
3725         * linux-fork.c (_initialize_linux_fork): Likewise.
3726         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3727         * maint.c (_initialize_maint_cmds): Likewise.
3728         * memattr.c (_initialize_mem): Likewise.
3729         * printcmd.c (_initialize_printcmd): Likewise.
3730         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3731         _RegEx): Likewise.
3732         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3733         * record-btrace.c (_initialize_record_btrace): Likewise.
3734         * record-full.c (_initialize_record_full): Likewise.
3735         * record.c (_initialize_record): Likewise.
3736         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3737         * regcache.c (_initialize_regcache): Likewise.
3738         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3739         _initialize_remote): Likewise.
3740         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3741         * serial.c (_initialize_serial): Likewise.
3742         * skip.c (_initialize_step_skip): Likewise.
3743         * source.c (_initialize_source): Likewise.
3744         * stack.c (_initialize_stack): Likewise.
3745         * symfile.c (_initialize_symfile): Likewise.
3746         * symtab.c (_initialize_symtab): Likewise.
3747         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3748         * top.c (init_main): Likewise.
3749         * tracefile-tfile.c (tfile_target_info): Likewise.
3750         * tracepoint.c (_initialize_tracepoint): Likewise.
3751         * tui/tui-win.c (_initialize_tui_win): Likewise.
3752         * utils.c (add_internal_problem_command): Likewise.
3753         * valprint.c (value_print_option_defs): Likewise.
3754
3755 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3756
3757         PR build/24886
3758         * configure.ac: Drop enable-libmcheck support.
3759         * configure, config.in: Rebuild.
3760         * libmcheck.m4: Remove.
3761         * acinclude.m4: Don't include it.
3762         * Makefile.in: Don't distribute it.
3763         * top.c (print_gdb_configuration): Don't mention it.
3764
3765 2019-08-06  Tom Tromey  <tom@tromey.com>
3766
3767         * utils.c (set_output_style): Sometimes pass stream to
3768         emit_style_escape.
3769         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3770         * record-btrace.c (btrace_insn_history): Update.
3771         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3772         method.
3773         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3774         Update initializers.
3775         <m_uiout>: New field.
3776         <m_di>: Move lower.
3777         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3778         Remove "uiout" parameter.
3779         (dump_insns): Update.
3780         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3781         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3782
3783 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3784
3785         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3786         (error_in_psymtab_expansion): Likewise.
3787         (lookup_symbol_via_quick_fns): Likewise.
3788         (basic_lookup_transparent_type_quick): Likewise.
3789         (basic_lookup_transparent_type_1): Likewise.
3790
3791 2019-08-06  Tom Tromey  <tromey@adacore.com>
3792
3793         * source.c (last_source_error): Now bool.
3794         (print_source_lines_base): Make "noprint" bool.  Only open
3795         source file when last_source_visited changes.
3796
3797 2019-08-06  Tom Tromey  <tromey@adacore.com>
3798
3799         * annotate.c (annotate_source_line): Use g_source_cache.
3800         * source-cache.c (source_cache::get_plain_source_lines): Change
3801         parameters.  Populate m_offset_cache.
3802         (source_cache::ensure): New method.
3803         (source_cache::get_line_charpos): New method.
3804         (extract_lines): Move lower.  Change parameters.
3805         (source_cache::get_source_lines): Move lower.
3806         * source-cache.h (class source_cache): Update comment.
3807         <get_line_charpos>: New method.
3808         <get_source_lines>: Update comment.
3809         <clear>: Clear m_offset_cache.
3810         <get_plain_source_lines>: Change parameters.
3811         <ensure>: New method
3812         <m_offset_cache>: New member.
3813         * source.c (forget_cached_source_info_for_objfile): Update.
3814         (info_source_command): Use g_source_cache.
3815         (find_source_lines, open_source_file_with_line_charpos): Remove.
3816         (print_source_lines_base, search_command_helper): Use g_source_cache.
3817         * source.h (open_source_file_with_line_charpos): Don't declare.
3818         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3819         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3820         Use g_source_cache.
3821
3822 2019-08-06  Tom Tromey  <tromey@adacore.com>
3823
3824         * source-cache.c (source_cache::get_plain_source_lines):
3825         Remove "first_line" and "last_line" parameters.
3826         (source_cache::get_source_lines): Cache plain text.
3827         * source-cache.h (class source_cache)
3828         <get_plain_source_lines>: Update.
3829
3830 2019-08-06  Tom Tromey  <tromey@adacore.com>
3831
3832         * source-cache.c (extract_lines): No longer a method.
3833         Changed type of parameter.  Include final newline.
3834         (selftests::extract_lines_test): New function.
3835         (_initialize_source_cache): Likewise.
3836         * source-cache.h (class source_cache)
3837         <extract_lines>: Don't declare.
3838
3839 2019-08-06  Tom Tromey  <tromey@adacore.com>
3840
3841         * breakpoint.c (init_breakpoint_sal): Update.
3842         (breakpoint): Update.
3843         * breakpoint.h (struct breakpoint) <filter>: Now a
3844         unique_xmalloc_ptr.
3845
3846 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3847
3848         * NEWS: Mention dictionary access on blocks.
3849         * python/py-block.c (blpy_getitem): New function.
3850         (block_object_as_mapping): New struct.
3851         (block_object_type): Use new struct for tp_as_mapping field.
3852
3853 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3854
3855         * objfiles.h (objfile): Add a comment describing partial symbols.
3856
3857 2019-08-05  Tom Tromey  <tromey@adacore.com>
3858
3859         * compile/compile.c (_initialize_compile): Use _(), not N_().
3860         * thread.c (_initialize_thread): Use _(), not N_().
3861         * stack.c (_initialize_stack): Use _(), not N_().
3862         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3863
3864 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3865
3866         * dwarf2read.c (struct dw2_symtab_iterator):
3867         <want_specific_block>: Remove.
3868         <block_index>: Change type to gdb::optional.
3869         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3870         change type of BLOCK_INDEX parameter to gdb::optional.
3871         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3872         (dw2_lookup_symbol): Don't pass argument for
3873         WANT_SPECIFIC_BLOCK.
3874         (dw2_expand_symtabs_for_function): Don't pass argument for
3875         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3876         (class dw2_debug_names_iterator)
3877         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3878         parameter, change BLOCK_INDEX type to gdb::optional.
3879         <m_want_specific_block>: Remove.
3880         <m_block_index>: Change type to gdb::optional.
3881         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3882         gdb::optional.  Re-write in function of gdb::optional.
3883         (dw2_debug_names_lookup_symbol): Don't pass argument for
3884         WANT_SPECIFIC_BLOCK.
3885         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3886         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3887         BLOCK_INDEX.
3888
3889 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3890
3891         * NEWS: Mention changes to "info sources" command.
3892
3893 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3894
3895         * symtab.c (filename_partial_match_opts): New struct type.
3896         (struct output_source_filename_data): New members
3897         regexp, c_regexp, partial_match.
3898         (output_source_filename): Use new members to decide to print file.
3899         (info_sources_option_defs): New variable.
3900         (make_info_sources_options_def_group, print_info_sources_header,
3901         info_sources_command_completer):
3902         New functions.
3903         (info_sources_command): Read new optional arguments.
3904         (_initialize_symtab): Update info sources help.
3905
3906 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3907
3908         * ada-lang.c (exception_support_info_v0): Renamed from...
3909         (default_exception_support_info): ... this.  Create new
3910         definition for v1.
3911         (ada_has_this_exception_support): Look up catch_handlers_sym.
3912         (ada_exception_support_info_sniffer): Try v0 after default.
3913
3914 2019-08-01  Tom Tromey  <tromey@adacore.com>
3915
3916         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3917         gdbarch.h.
3918
3919 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3920
3921         * s12z-tdep.c: Fix include path for s12z-opc.h.
3922
3923 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3924
3925         * NEWS: Require GNU make 3.82.
3926
3927 2019-07-16  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3930         declare.
3931
3932 2019-07-30  Tom Tromey  <tromey@adacore.com>
3933
3934         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3935
3936 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3937
3938         * printcmd.c (print_address_symbolic): Print negative offsets.
3939         (build_address_symbolic): Force signed arithmetic when computing
3940         offset.
3941
3942 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3943
3944         PR/24474: Add a function to lookup static variables.
3945         * NEWS: Mention this new function.
3946         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3947         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3948         * python/python.c (python_GdbMethods): Add new function.
3949
3950 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3951
3952         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3953         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3954         (objfpy_lookup_static_symbol): New function.
3955         (objfile_object_methods): Add new functions.
3956
3957 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3958
3959         * NEWS: Mention 'set|show print frame-info'.  Mention new
3960         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3961         backtrace argument.  Mention that python frame filtering code
3962         is now consistent with what 'backtrace' command prints.
3963
3964 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3965
3966         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3967         comments.
3968         (print_frame_info_auto, print_frame_info_source_line,
3969         print_frame_info_location, print_frame_info_source_and_location,
3970         print_frame_info_location_and_address, print_frame_info_short_location):
3971         New declarations.
3972         (struct frame_print_options): New member print_frame_info.
3973         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3974         * stack.h (get_user_print_what_frame_info): New declaration.
3975         (frame_show_address): New declaration.
3976         * stack.c (print_frame_arguments_choices): New value 'presence'.
3977         (print_frame_info_auto, print_frame_info_source_line,
3978         print_frame_info_location, print_frame_info_source_and_location,
3979         print_frame_info_location_and_address, print_frame_info_short_location,
3980         print_frame_info_choices, print_frame_info_print_what): New definitions.
3981         (print_frame_args): Only print dots for args if print frame-arguments
3982         is 'presence'.
3983         (frame_print_option_defs): New element for "frame-info".
3984         (get_user_print_what_frame_info): New function.
3985         (frame_show_address): Make non static.  Move comment to stack.h.
3986         (print_frame_info_to_print_what): New function.
3987         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3988         to decide what to print.
3989         (backtrace_command_1): Handle the new print_frame_arguments_presence
3990         value.
3991         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3992         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3993         (py_print_frame): In non-mi mode, use LOCATION as default for
3994         print_what, similarly to frame information printed directly by
3995         backtrace command. Handle frame-info user option in non MI mode.
3996
3997 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3998
3999         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4000         Add case for debugging 32-bit target on 64-bit host.  Revise
4001         comment.
4002
4003 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4004
4005         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4006         instead of find_function_entry_range_from_pc.
4007
4008 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4009
4010         * stack.c (find_frame_funname): Remove code which preferred
4011         minsym over symtab sym in "certain pathological cases".
4012
4013         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4014         parameter.  Change type of "do_demangle" to bool.
4015         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4016         Pass suitable "prefer_sym_over_minsym" flag to
4017         build_address_symbolic().  Don't output "+" for negative offsets.
4018         * printcmd.c (print_address_symbolic): Update invocation of
4019         build_address_symbolic to include a "prefer_sym_over_minsym"
4020         flag.
4021         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4022         Restrict cases in which use of minimal symbol is preferred to that
4023         of a found symbol.  Update comments.
4024
4025         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4026         for entry pc when entry pc is out of range for that FDE.
4027
4028 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4029
4030         PR gdb/24839:
4031         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4032         type.
4033
4034 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4035
4036         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4037         this function's Python signature.
4038
4039
4040 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4041
4042         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4043         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4044         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4045         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4046         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4047
4048
4049 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4050
4051         * h8300-tdep.c (h8300_register_name_common): New.
4052         h8300_register_name): Use h8300_register_name_common.
4053         (h8300s_register_name): Likewise.
4054         (h8300sx_register_name): Likewise.
4055         (h8300h_register_nam): New.
4056         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4057
4058
4059 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4060
4061         * arm-tdep.c (arm_skip_cmse_entry): New function.
4062         (arm_is_sgstubs_section): New function.
4063         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4064
4065 2019-07-22  Tom Tromey  <tom@tromey.com>
4066
4067         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4068         Don't self-assign.
4069
4070 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4073         type_print.
4074
4075 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4078         so that GDB doesn't match any msymbols when searching in the
4079         TYPES_DOMAIN.
4080         (print_symbol_info): Print using typedef_print or type_print based
4081         on the type of the symbol.  Add updated FIXME comment moved from...
4082         (_initialize_symtab): ... move and update FIXME comment to above.
4083
4084 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * NEWS: Mention adding -q option to "info types".
4087         * symtab.c (struct info_types_options): New struct.
4088         (info_types_options_defs): New variable.
4089         (make_info_types_options_def_group): New function.
4090         (info_types_command): Use gdb::option framework to parse options.
4091         (info_types_command_completer): New function.
4092         (_initialize_symtab): Extend the help text on "info types" and
4093         register command completer.
4094
4095 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4096
4097         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4098         (lookup_symbol_in_objfile): Change int to block_enum and add a
4099         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4100
4101 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4102
4103         * MAINTAINERS (Write After Approval): Add self.
4104
4105 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4108         instruction to the dummy code region.
4109
4110 2019-07-19  Tom Tromey  <tromey@adacore.com>
4111
4112         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4113         (ARGSUSED, PARAMS, __func__): Remove rules.
4114
4115 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4116
4117         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4118         * features/arm/arm-with-iwmmxt.c: Remove.
4119         * features/arm/arm-with-iwmmxt.xml: Remove.
4120         * features/arm/arm-with-m-fpa-layout.c: Remove.
4121         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4122         * features/arm/arm-with-m-vfp-d16.c: Remove.
4123         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4124         * features/arm/arm-with-m.c: Remove.
4125         * features/arm/arm-with-m.xml: Remove.
4126         * features/arm/arm-with-neon.c: Remove.
4127         * features/arm/arm-with-neon.xml: Remove.
4128         * features/arm/arm-with-vfpv2.c: Remove.
4129         * features/arm/arm-with-vfpv2.xml: Remove.
4130         * features/arm/arm-with-vfpv3.c: Remove.
4131         * features/arm/arm-with-vfpv3.xml: Remove.
4132
4133 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4134
4135         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4136
4137 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4138
4139         * arch/aarch32.c (aarch32_create_target_description): Create
4140         target descriptions using features.
4141         * arch/arm.c (arm_create_target_description)
4142         (arm_create_mprofile_target_description): Likewise.
4143         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4144
4145 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4146
4147         * Makefile.in: Add new files.
4148         * aarch32-tdep.c: New file.
4149         * aarch32-tdep.h: New file.
4150         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4151         Call aarch32_read_description.
4152         * arch/aarch32.c: New file.
4153         * arch/aarch32.h: New file.
4154         * arch/arm.c (arm_create_target_description)
4155         (arm_create_mprofile_target_description): New function.
4156         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4157         (arm_create_target_description)
4158         (arm_create_mprofile_target_description): New declaration.
4159         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4160         read_description functions.
4161         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4162         Likewise.
4163         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4164         * arm-tdep.c (tdesc_arm_list): New variable.
4165         (arm_register_g_packet_guesses): Call create description functions.
4166         (arm_read_description) (arm_read_mprofile_description): New
4167         function.
4168         * arm-tdep.h (arm_read_description)
4169         (arm_read_mprofile_description): Add declaration.
4170         * configure.tgt: Add new files.
4171
4172 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4173
4174         * top.c (new_ui_command): Open specified terminal just once.
4175
4176 2019-07-18  Tom Tromey  <tromey@adacore.com>
4177
4178         * symtab.c (main_name): Constify return type.
4179         * symfile.c (set_initial_language): Update.
4180         * symtab.h (main_name): Constify return type.
4181
4182 2019-07-17  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui-winsource.c (tui_update_source_window)
4185         (tui_update_source_window_as_is)
4186         (tui_update_source_windows_with_line): Remove return.
4187         * tui/tui-disasm.c (tui_show_disassem)
4188         (tui_show_disassem_and_update_source): Remove return.
4189         * tui/tui.c (tui_reset): Remove return.
4190         * tui/tui-wingeneral.c
4191         (tui_check_and_display_highlight_if_needed): Remove return.
4192
4193 2019-07-17  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4196
4197 2019-07-17  Tom Tromey  <tom@tromey.com>
4198
4199         * tui/tui-winsource.h (struct tui_exec_info_window)
4200         (struct tui_source_window_base): Move from tui-data.h.
4201         * tui/tui-winsource.c: Move many method definitions from
4202         elsewhere.  Remove "structuring" comments.
4203         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4204         (tui_source_window_base::refresh_window): Move to
4205         tui-winsource.c.
4206         * tui/tui-win.c (tui_source_window_base::refresh_all)
4207         (tui_source_window_base::update_tab_width)
4208         (tui_source_window_base::set_new_height)
4209         (tui_source_window_base::do_make_visible_with_new_height): Move to
4210         tui-winsource.c.
4211         * tui/tui-source.h: Update.
4212         * tui/tui-source.c (tui_source_window_base::reset): Move to
4213         tui-winsource.c.
4214         * tui/tui-disasm.h: Update.
4215         * tui/tui-data.h (struct tui_exec_info_window): Move to
4216         tui-winsource.h.
4217         (struct tui_source_window_base): Likewise.
4218         * tui/tui-data.c (tui_source_window_base::clear_detail)
4219         (tui_source_window_base, ~tui_source_window_base): Move to
4220         tui-winsource.c.
4221
4222 2019-07-17  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-win.c (tui_resize_all)
4225         (tui_source_window_base::update_tab_width)
4226         (tui_adjust_win_heights): Update.
4227         (tui_win_info::make_invisible_and_set_new_height): Rename from
4228         make_invisible_and_set_new_height.
4229         * tui/tui-data.h (struct tui_win_info)
4230         <make_invisible_and_set_new_height>: New method.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui.c: Update.
4235         * tui/tui-source.h (struct tui_source_window): Move from
4236         tui-data.h.
4237         * tui/tui-layout.c: Update.
4238         * tui/tui-disasm.c: Update.
4239         * tui/tui-data.h (struct tui_source_window): Move to
4240         tui-source.h.
4241
4242 2019-07-17  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4245         tui-data.h.
4246         * tui/tui-data.h (struct tui_disasm_window): Move to
4247         tui-disasm.h.
4248
4249 2019-07-17  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui-regs.h (struct tui_data_item_window): Move from
4252         tui-data.h.
4253         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4254         * tui/tui-data.h (struct tui_data_item_window): Move to
4255         tui-regs.h.
4256         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui.c: Update.
4261         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4262         (tui_cmd_window::max_height): Move to tui-command.c.
4263         * tui/tui-layout.c: Update.
4264         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4265         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4266         tui-command.c.
4267         * tui/tui-command.h (struct tui_cmd_window): Move from
4268         tui-data.h.
4269         * tui/tui-command.c: Remove "structuring" comments.
4270         (tui_cmd_window::clear_detail)
4271         (tui_cmd_window::do_make_visible_with_new_height)
4272         (tui_cmd_window::max_height): Move from elsewhere.
4273
4274 2019-07-17  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4277         Now static.
4278         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4279         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4280
4281 2019-07-17  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui.c: Update.
4284         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4285         tui-regs.c.
4286         * tui/tui-windata.h: Remove file.
4287         * tui/tui-windata.c: Remove file.
4288         * tui/tui-win.c (tui_data_window::set_new_height)
4289         (tui_data_window::do_make_visible_with_new_height): Move to
4290         tui-regs.c.
4291         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4292         * tui/tui-regs.c: Remove "structuring" comments.
4293         (tui_data_window::first_data_item_displayed)
4294         (tui_data_window::delete_data_content_windows)
4295         (tui_data_window::erase_data_content)
4296         (tui_data_window::display_all_data)
4297         (tui_data_window::refresh_all)
4298         (tui_data_window::do_scroll_vertical)
4299         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4300         (tui_data_window::do_make_visible_with_new_height)
4301         (tui_data_window::refresh_window): Move from elsewhere.
4302         (_initialize_tui_regs): Move to end of file.
4303         * tui/tui-layout.c: Update.
4304         * tui/tui-hooks.c: Update.
4305         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4306         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4307         tui-regs.c.
4308         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4309
4310 2019-07-17  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4313         seen.
4314
4315 2019-07-17  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-win.c (tui_source_window_base::set_new_height)
4318         (tui_source_window_base::do_make_visible_with_new_height): Use
4319         m_has_locator field directly.
4320         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4321         method.
4322         (struct tui_source_window_base) <has_locator>: Likewise.
4323
4324 2019-07-17  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4327         Don't declare.
4328         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4329         Remove.
4330         * tui/tui-win.c (tui_source_window_base::set_new_height)
4331         (tui_source_window_base::set_new_height)
4332         (make_invisible_and_set_new_height)
4333         (tui_source_window_base::do_make_visible_with_new_height)
4334         (tui_source_window_base::do_make_visible_with_new_height):
4335         Update.
4336         * tui/tui-layout.c (show_source_disasm_command, show_data)
4337         (show_source_or_disasm_and_command): Update.
4338         * tui/tui-layout.c (show_layout): Update.
4339
4340 2019-07-17  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-layout.c (make_data_window): Remove.
4343         (show_data): Unify creation and re-initialization cases.
4344
4345 2019-07-17  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-layout.c (make_source_window, make_disasm_window):
4348         Remove.
4349         (show_data): Unify creation and re-initialization cases.
4350
4351 2019-07-17  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-layout.c (make_command_window): Remove.
4354         (show_source_disasm_command, show_source_or_disasm_and_command):
4355         Unify creation and re-initialization cases.
4356
4357 2019-07-17  Tom Tromey  <tom@tromey.com>
4358
4359         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4360         creation and re-initialization cases.
4361
4362 2019-07-17  Tom Tromey  <tom@tromey.com>
4363
4364         * tui/tui-regs.c (tui_get_register): Return void.
4365
4366 2019-07-17  Tom Tromey  <tom@tromey.com>
4367
4368         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4369         Simplify.
4370
4371 2019-07-17  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4374         resetting.
4375
4376 2019-07-17  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4379         * tui/tui-regs.c (tui_reg_layout): New function.
4380         (tui_show_registers, tui_reg_command): Use it.
4381         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4382         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4383         parameters.
4384         (tui_layout_command): Remove.
4385
4386 2019-07-17  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-layout.h (tui/tui-layout): Return void.
4389         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4390
4391 2019-07-17  Tom Tromey  <tom@tromey.com>
4392
4393         * tui/tui-layout.c (show_source_disasm_command, show_data):
4394         Update.
4395         (reset_locator): Remove.
4396         (show_source_or_disasm_and_command): Update.
4397
4398 2019-07-17  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-source.c (tui_source_window_base::reset): Remove
4401         win_type parameter.
4402         * tui/tui-layout.c (make_command_window, make_source_window)
4403         (make_disasm_window, make_data_window)
4404         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4405         (reset_locator, show_source_or_disasm_and_command): Update.
4406         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4407         win_type parameter.
4408         (struct tui_source_window_base) <reset>: Likewise.
4409
4410 2019-07-17  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-layout.c (show_source_disasm_command): Use
4413         reset_locator.
4414         (reset_locator): New function.
4415         (init_and_make_win): Remove.
4416         (show_source_or_disasm_and_command): Use reset_locator.
4417
4418 2019-07-17  Tom Tromey  <tom@tromey.com>
4419
4420         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4421         condition.
4422         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4423         Remove condition.
4424         * tui/tui-source.c (tui_source_window_base::reset): New method.
4425         * tui/tui-layout.c (make_command_window): Don't call
4426         init_and_make_win.
4427         (make_source_window, make_disasm_window): Don't call
4428         make_source_or_disasm_window.
4429         (make_data_window): Don't call init_and_make_win.  Change calling
4430         convention.
4431         (show_source_disasm_command, show_data): Simplify.
4432         (make_source_or_disasm_window): Remove.
4433         (show_source_or_disasm_and_command): Simplify.
4434         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4435         (struct tui_source_window_base) <reset>: Likewise.
4436         <execution_info>: Remove initializer.
4437         * tui/tui-data.c (tui_source_window_base): Initialize
4438         execution_info.
4439
4440 2019-07-17  Tom Tromey  <tom@tromey.com>
4441
4442         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4443         variable.
4444
4445 2019-07-17  Tom Tromey  <tom@tromey.com>
4446
4447         * tui/tui.c (tui_rl_other_window): Update.
4448         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4449         superclass method first.  Always iterate over regs_content.
4450         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4451         method.
4452         * tui/tui-win.c (tui_set_focus_command): Update.
4453
4454 2019-07-17  Tom Tromey  <tom@tromey.com>
4455
4456         * tui/tui-win.c (tui_set_focus_command): Rename from
4457         tui_set_focus.  Call tui_enable.
4458         (tui_set_focus_command): Remove.
4459
4460 2019-07-17  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4463         refresh_window.
4464         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4465         touchwin.
4466         (tui_data_window::refresh_window): Call refresh_window on data
4467         items.  Always call superclass refresh_window.
4468         (tui_win_info::refresh): Remove.
4469         (tui_source_window_base::refresh_window): Update.
4470         (tui_refresh_all): Update.
4471         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4472         refresh_window.
4473         (show_source_or_disasm_and_command): Likewise.
4474         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4475         (struct tui_source_window_base) <refresh>: Likewise.
4476
4477 2019-07-17  Tom Tromey  <tom@tromey.com>
4478
4479         * tui/tui-winsource.c (tui_clear_source_content)
4480         (tui_show_source_content): Update.
4481         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4482         whether content is empty.
4483         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4484         Remove.
4485
4486 2019-07-17  Tom Tromey  <tom@tromey.com>
4487
4488         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4489         window's contents.
4490         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4491         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4492
4493 2019-07-17  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4496         (struct tui_data_item_window): Update.
4497
4498 2019-07-17  Tom Tromey  <tom@tromey.com>
4499
4500         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4501         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4502         defines.
4503
4504 2019-07-17  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-winsource.h (tui_erase_source_content)
4507         (tui_clear_source_content): Remove "display_prompt" parameter.
4508         * tui/tui-winsource.c (tui_update_source_window_as_is)
4509         (tui_update_source_windows_with_addr): Update.
4510         (tui_clear_source_content): Remove "display_prompt" parameter.
4511         (tui_erase_source_content): Likewise.  Simplify.
4512         (tui_show_source_content): Update.
4513         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4514         * tui/tui-stack.c (tui_show_frame_info): Update.
4515         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4516         Remove defines.
4517
4518 2019-07-17  Tom Tromey  <tom@tromey.com>
4519
4520         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4521         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4522         parameter.
4523         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4524         parameter.
4525
4526 2019-07-17  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui-winsource.c (tui_clear_source_content)
4529         (tui_show_source_content, tui_show_exec_info_content)
4530         (tui_clear_exec_info_content): Update.
4531         * tui/tui-stack.c (tui_show_locator_content): Update.
4532         (tui_show_frame_info): Update.
4533         * tui/tui-source.h (tui_source_window): Don't declare.
4534         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4535         from tui_source_is_displayed.
4536         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4537         Remove field.
4538         (struct tui_source_window_base) <content_in_use>: New field.  Now
4539         bool.
4540         (struct tui_source_window) <showing_source_p>: New method.
4541         (TUI_SRC_WIN): Change cast.
4542         * tui/tui-data.c (tui_initialize_static_data): Update.
4543
4544 2019-07-17  Tom Tromey  <tom@tromey.com>
4545
4546         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4547         location_matches_p.
4548         * tui/tui-source.c (tui_source_window::location_matches_p): New
4549         method.
4550         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4551         method.
4552         * tui/tui-data.h (struct tui_source_window_base)
4553         <location_matches_p>: New method.
4554         (struct tui_source_window, struct tui_disasm_window)
4555         <location_matches_p>: Likewise.
4556
4557 2019-07-17  Tom Tromey  <tom@tromey.com>
4558
4559         * tui/tui-win.c (tui_set_win_height_command): Rename from
4560         tui_set_win_height.
4561         (tui_set_win_height_command): Remove.
4562
4563 2019-07-17  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-source.c (tui_source_window): New constructor.  Add
4566         observer.
4567         (~tui_source_window): New destructor.
4568         (tui_source_window::style_changed): New method.
4569         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4570         (tui_attach_detach_observers): Update.
4571         * tui/tui-data.h (struct tui_source_window): Make constructor not
4572         inline.  Add destructor.
4573         (struct tui_source_window) <style_changed>: New method.
4574         <m_observable>: New member.
4575
4576 2019-07-17  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4579         * tui/tui-win.c (tui_resize_all): Fix typo.
4580
4581 2019-07-17  Tom Tromey  <tom@tromey.com>
4582
4583         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4584         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4585         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4586         * tui/tui-win.c (window_name_completer): Use foreach.
4587         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4588         (update_tab_width): Likewise.
4589         * tui/tui-layout.c (show_layout): Update.
4590         * tui/tui-data.h (class tui_window_iterator): New.
4591         (struct all_tui_windows): New.
4592         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4593
4594 2019-07-17  Tom Tromey  <tom@tromey.com>
4595
4596         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4597         parameter.  Don't reference globals.
4598         (tui_reg_command): Update.
4599
4600 2019-07-17  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-regs.c (tui_show_registers): Simplify.
4603
4604 2019-07-17  Tom Tromey  <tom@tromey.com>
4605
4606         * tui/tui-regs.c (tui_show_registers): Update.
4607         (tui_show_register_group): Add win_info parameter.
4608
4609 2019-07-17  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4612         Rename from tui_display_reg_element_at_line.
4613         (tui_data_window::display_registers_from_line): Update.
4614         * tui/tui-data.h (struct tui_data_window)
4615         <display_reg_element_at_line>: New method.
4616
4617 2019-07-17  Tom Tromey  <tom@tromey.com>
4618
4619         * tui/tui-regs.h (tui_display_registers_from)
4620         (tui_display_registers_from_line): Don't declare.
4621         * tui/tui-windata.c (tui_data_window::display_all_data)
4622         (tui_data_window::refresh_all)
4623         (tui_data_window::do_scroll_vertical): Update.
4624         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4625         from tui_display_registers_from.
4626         (tui_display_reg_element_at_line): Update.
4627         (tui_data_window::display_registers_from_line): Rename from
4628         tui_display_registers_from_line.
4629         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4630         display_registers_from_line>: New methods.
4631
4632 2019-07-17  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4635         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4636         from tui_erase_data_content.
4637         (tui_data_window::display_all_data)
4638         (tui_data_window::refresh_all)
4639         (tui_data_window::do_scroll_vertical): Update.
4640         * tui/tui-regs.c (tui_show_registers): Update.
4641         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4642         New method.
4643
4644 2019-07-17  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4647         declare.
4648         * tui/tui-windata.c
4649         (tui_data_window::delete_data_content_windows): Rename from
4650         tui_delete_data_content_windows.
4651         (tui_data_window::display_all_data)
4652         (tui_data_window::do_scroll_vertical): Update.
4653         * tui/tui-data.h (struct tui_data_window)
4654         <delete_data_content_windows>: New method.
4655
4656 2019-07-17  Tom Tromey  <tom@tromey.com>
4657
4658         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4659         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4660
4661 2019-07-17  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4664         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4665         from tui_display_all_data.
4666         * tui/tui-win.c
4667         (tui_data_window::do_make_visible_with_new_height): Update.
4668         * tui/tui-regs.c (tui_show_registers): Update.
4669         * tui/tui-layout.c (tui_set_layout): Update.
4670         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4671         method.
4672
4673 2019-07-17  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4676         * tui/tui-windata.c (tui_display_data_from): Remove.
4677         (tui_data_window::refresh_all): Update.
4678
4679 2019-07-17  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4682         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4683         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4684         tui_display_registers_from_line.
4685         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4686         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4687         "force_display" parameter.
4688
4689 2019-07-17  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4692         declare.
4693         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4694         Rename from tui_first_reg_element_no_inline.
4695         (tui_display_reg_element_at_line)
4696         (tui_display_registers_from_line): Update.
4697         * tui/tui-data.h (struct tui_data_window)
4698         <first_reg_element_no_inline>: New method.
4699
4700 2019-07-17  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-windata.c (tui_display_data_from)
4703         (tui_data_window::do_scroll_vertical): Update.
4704         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4705         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4706         Rename from tui_line_from_reg_element_no.
4707         (tui_display_registers_from_line): Update.
4708         * tui/tui-data.h (struct tui_data_window)
4709         <line_from_reg_element_no>: New method.
4710
4711 2019-07-17  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4714         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4715         tui_last_regs_line_no.
4716         (tui_display_reg_element_at_line)
4717         (tui_display_registers_from_line): Update.
4718         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4719         method.
4720
4721 2019-07-17  Tom Tromey  <tom@tromey.com>
4722
4723         PR tui/24722:
4724         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4725         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4726         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4727         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4728         (tui_update_breakpoint_info): Likewise.
4729         * tui/tui-hooks.c (tui_event_create_breakpoint)
4730         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4731         Update.
4732
4733 2019-07-17  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4736
4737 2019-07-17  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-winsource.c (tui_update_source_window_as_is)
4740         (tui_update_source_windows_with_addr): Update.
4741         * tui/tui-source.h (tui_set_source_content)
4742         (tui_show_symtab_source): Add "win_info" parameter.
4743         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4744         parameter.
4745         (tui_show_symtab_source): Likewise.
4746
4747 2019-07-17  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-wingeneral.c
4750         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4751
4752 2019-07-17  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4755         (struct tui_cmd_window) <can_scroll>: New method.
4756         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4757         method.
4758
4759 2019-07-17  Tom Tromey  <tromey@adacore.com>
4760
4761         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4762         do_field_signed>: Rename.  Change type of "value".
4763         * ui-out.c (ui_out::field_signed): Rename from field_int.
4764         Change type of "value".
4765         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4766         type of "value".
4767         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4768         do_field_int.  Change type of "value".
4769         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4770         do_field_int.  Change type of "value".
4771         * tracepoint.c (trace_status_mi, tfind_1)
4772         (print_one_static_tracepoint_marker): Update.
4773         * thread.c (print_thread_info_1, print_selected_thread_frame):
4774         Update.
4775         * stack.c (print_frame, print_frame_info): Update.
4776         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4777         Update.
4778         * source.c (print_source_lines_base): Update.
4779         * skip.c (info_skip_command): Update.
4780         * record-btrace.c (btrace_ui_out_decode_error)
4781         (btrace_call_history_src_line): Update.
4782         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4783         Update.
4784         * progspace.c (print_program_space): Update.
4785         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4786         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4787         do_field_int.  Change type of "value".
4788         * mi/mi-out.c (mi_ui_out::do_table_begin)
4789         (mi_ui_out::do_table_header): Update.
4790         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4791         type of "value".
4792         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4793         (mi_cmd_data_list_changed_registers, output_register)
4794         (mi_cmd_data_read_memory, mi_load_progress)
4795         (mi_cmd_trace_frame_collected): Update.
4796         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4797         Update.
4798         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4799         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4800         (mi_cmd_var_list_children, varobj_update_one): Update.
4801         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4802         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4803         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4804         * inferior.c (print_inferior): Update.
4805         * gdb_bfd.c (print_one_bfd): Update.
4806         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4807         Update.
4808         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4809         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4810         do_field_int.  Change type of "value".
4811         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4812         do_field_int.  Change type of "value".
4813         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4814         (print_one_breakpoint_location, print_it_catch_fork)
4815         (print_one_catch_fork, print_it_catch_vfork)
4816         (print_one_catch_vfork, print_it_catch_solib)
4817         (print_it_catch_exec, print_it_ranged_breakpoint)
4818         (print_mention_watchpoint, print_mention_masked_watchpoint)
4819         (bkpt_print_it, update_static_tracepoint): Update.
4820         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4821         * break-catch-syscall.c (print_it_catch_syscall): Update.
4822         * ada-tasks.c (print_ada_task_info): Update.
4823         * ada-lang.c (print_it_exception, print_mention_exception):
4824         Update.
4825
4826 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         PR breakpoints/24541
4829         * gdbarch.c: Regenerate.
4830         * gdbarch.h: Regenerate.
4831         * gdbarch.sh: Adjust return type and parameter types for
4832         'stap_adjust_register'.
4833         (i386_stap_adjust_register): Adjust signature and return new
4834         register name.
4835         * stap-probe.c (stap_parse_register_operand): Adjust use of
4836         'gdbarch_stap_adjust_register'.
4837
4838 2019-07-17  Tom Tromey  <tromey@adacore.com>
4839
4840         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4841         declare VEC.
4842         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4843         std::vector.
4844         (struct s390_process_info): Add initializers.
4845         (s390_add_process): Use new.
4846         (s390_linux_nat_target::low_forget_process): Use delete.
4847         (s390_linux_nat_target::low_new_fork)
4848         (s390_linux_nat_target::stopped_by_watchpoint)
4849         (s390_linux_nat_target::low_prepare_to_resume)
4850         (s390_linux_nat_target::insert_watchpoint)
4851         (s390_linux_nat_target::insert_hw_breakpoint)
4852         (s390_linux_nat_target::remove_watchpoint)
4853         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4854
4855 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4856
4857         * aarch64-fbsd-nat.c: Include regcache.h.
4858         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4859         argument.
4860         (aarch64_fbsd_nat_target::fetch_registers)
4861         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4862         variable.
4863         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4864
4865 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4866
4867         * fbsd-nat.c: Include gdbarch.h.
4868
4869 2019-07-15  Tom Tromey  <tromey@adacore.com>
4870
4871         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4872
4873 2019-07-15  Tom Tromey  <tromey@adacore.com>
4874
4875         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4876         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4877         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4878         * cli-out.c (cli_ui_out::do_field_int): New method.
4879         * ui-out.c (ui_out::field_unsigned): New method.
4880         * symfile.c (generic_load): Use field_unsigned.
4881         (print_transfer_performance): Likewise.
4882         * record-btrace.c (ui_out_field_uint): Remove.
4883         (btrace_call_history_insn_range, btrace_call_history): Use
4884         field_unsigned.
4885         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4886         field_unsigned.
4887         * ui-out.h (class ui_out) <field_unsigned>: New method.
4888         <do_field_unsigned>: Likewise.
4889
4890 2019-07-15  Tom Tromey  <tromey@adacore.com>
4891
4892         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4893         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4894         * target.c (flash_erase_command): Use field_string.
4895         * infrun.c (print_signal_received_reason): Use field_string.
4896         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4897         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4898         field_string.
4899         * ada-tasks.c (print_ada_task_info): Use field_string.
4900
4901 2019-07-15  Tom Tromey  <tromey@adacore.com>
4902
4903         * target.c (flash_erase_command): Use field_core_addr.
4904         * symfile.c (generic_load): Use field_core_addr.
4905         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4906         Use field_core_addr.
4907         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4908         field_core_addr.
4909
4910 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4913         value if its desired type is smaller than a CORE_ADDR and signed.
4914
4915 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4918         of changes to field names, and use new is_reference field to
4919         decide if a property is a reference or not.
4920         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4921         field.
4922         (struct dwarf2_property_baton): Update header comment, rename
4923         'referenced_type' to 'property_type' and update comments.
4924         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4925         default property type, store in property baton, update to take
4926         accound of renamed field.
4927         (read_func_scope): Update call to attr_to_dynamic_prop.
4928         (read_array_type): Likewise.
4929         (dwarf2_per_cu_addr_sized_int_type): New function.
4930         (read_subrange_index_type): Move type finding code to
4931         dwarf2_per_cu_addr_sized_int_type.
4932         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4933         (dwarf2_per_cu_addr_type): New function.
4934         (set_die_type): Update calls to attr_to_dynamic_prop.
4935
4936 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * dwarf2read.c (read_subrange_index_type): New function.
4939         (read_subrange_type): Move code into new function and call it.
4940         * gdbtypes.c (create_range_type): Add some asserts.
4941
4942 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4945         update return statements.
4946         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4947         declaration, and update comment to match.
4948         * gdbtypes.c (resolve_dynamic_array): Update call to
4949         dwarf2_evaluate_property to match new return type.
4950
4951 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * valarith.c (value_subscripted_rvalue): Change lowerbound
4954         parameter type from int to LONGEST.
4955         * value.h (value_subscripted_rvalue): Likewise in declaration.
4956
4957 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * cli/cli-utils.c (info_print_command_completer): New function.
4960         * cli/cli-utils.h: Add 'completer.h' include, and forward
4961         declaration for 'struct cmd_list_element'.
4962         (info_print_command_completer): Declare.
4963         * stack.c (_initialize_stack): Add completer for 'info locals' and
4964         'info args'.
4965         * symtab.c (_initialize_symtab): Add completer for 'info
4966         variables' and 'info functions'.
4967         * NEWS: Mention completion for additional info commands.
4968
4969 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4970
4971         * cli/cli-utils.c (extract_info_print_args): Delete.
4972         (extract_arg_maybe_quoted): Delete.
4973         (info_print_options_defs): New variable.
4974         (make_info_print_options_def_group): New function.
4975         (extract_info_print_options): Define new function.
4976         * cli/cli-utils.h (extract_info_print_args): Delete.
4977         (struct info_print_options): New structure.
4978         (extract_info_print_options): Declare new function.
4979         * stack.c (info_locals_command): Update to use new
4980         extract_info_print_options, also add a header comment.
4981         (info_args_command): Likewise.
4982         * symtab.c (info_variables_command): Likewise.
4983         (info_functions_command): Likewise.
4984
4985 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4988         to extract string arguments.
4989         * common/common-utils.c (extract_string_maybe_quoted): New function.
4990         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4991
4992 2019-07-11  Tom Tromey  <tromey@adacore.com>
4993
4994         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4995         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4996         * top.h (gdbinit): Don't declare.
4997         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4998         into...
4999         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5000         * top.c (gdb_init): Don't call init_cli_cmds.
5001         (gdbinit): Remove.
5002         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5003
5004 2019-07-11  Tom Tromey  <tromey@adacore.com>
5005
5006         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5007         after it has been moved.
5008
5009 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5010
5011         * valops.c (value_must_coerce_to_target): Change return type to
5012         bool.
5013         * value.h (value_must_coerce_to_target): Likewise.
5014
5015 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5016
5017         * breakpoint.c (is_hardware_watchpoint): Remove
5018         forward-declaration.
5019         (is_masked_watchpoint): Change return type to bool.
5020         (is_tracepoint): Likewise.
5021         (is_breakpoint): Likewise.
5022         (is_hardware_watchpoint): Likewise.
5023         (is_watchpoint): Likewise.
5024         (is_no_memory_software_watchpoint): Likewise.
5025         (is_catchpoint): Likewise.
5026         (breakpoint_1): Make FILTER parameter's return type bool.
5027         is_masked_watchpoint): Change return type to bool.
5028         (save_breakpoints): Make FILTER parameter's return type bool.
5029         * breakpoint.h (is_breakpoint): Change return type to bool.
5030         (is_watchpoint): Likewise.
5031         (is_catchpoint): Likewise.
5032         (is_tracepoint): Likewise.
5033
5034 2019-07-10  Tom Tromey  <tom@tromey.com>
5035
5036         * defs.h: Don't include gdbarch.h.
5037         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5038         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5039         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5040         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5041         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5042         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5043         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5044         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5045         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5046         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5047         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5048         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5049         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5050         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5051         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5052         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5053         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5054         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5055         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5056         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5057         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5058         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5059         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5060         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5061         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5062         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5063         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5064
5065 2019-07-10  Tom Tromey  <tromey@adacore.com>
5066
5067         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5068         * breakpoint.c (init_ada_exception_breakpoint): Register as
5069         bp_catchpoint.
5070         (print_one_breakpoint_location, print_one_breakpoint): Use
5071         is_ada_exception_catchpoint.
5072         * ada-lang.c (class ada_catchpoint_location): Pass
5073         bp_loc_software_breakpoint to bp_location constructor.
5074         (is_ada_exception_catchpoint): New function.
5075
5076 2019-07-10  Tom Tromey  <tromey@adacore.com>
5077
5078         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5079         VEC.
5080         (struct arm_exidx_entry): New method operator<.
5081         (struct arm_exidx_data) <section_maps>: Change type.
5082         (arm_exidx_data_free): Remove.
5083         (arm_exidx_data_key): Change type.  Move lower.
5084         (arm_exidx_new_objfile): Update.
5085         (arm_compare_exidx_entries): Remove.
5086         (arm_find_exidx_entry, _initialize_arm_tdep)
5087
5088 2019-07-10  Tom Tromey  <tromey@adacore.com>
5089
5090         * solib-spu.c (ocl_program_data_key): Change type.
5091         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5092         Update.
5093
5094 2019-07-10  Tom Tromey  <tromey@adacore.com>
5095
5096         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5097         (struct solib_aix_inferior_data) <library_list>: Change type.
5098         (solib_aix_inferior_data_handle): Change type.
5099         (get_solib_aix_inferior_data): Update.
5100         (solib_aix_free_library_list): Remove.
5101         (library_list_start_library): Update.
5102         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5103         return type.
5104         (solib_aix_get_library_list)
5105         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5106         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5107
5108 2019-07-10  Tom Tromey  <tromey@adacore.com>
5109
5110         * solib-dsbt.c (struct dsbt_info): Add initializers.
5111         (solib_dsbt_pspace_data): Change type.
5112         (dsbt_pspace_data_cleanup): Remove.
5113         (get_dsbt_info, _initialize_dsbt_solib): Update.
5114
5115 2019-07-10  Tom Tromey  <tromey@adacore.com>
5116
5117         * spu-tdep.c (spu_overlay_data): Change type.
5118         (spu_get_overlay_table, spu_overlay_new_objfile)
5119         (_initialize_spu_tdep): Update.
5120
5121 2019-07-10  Tom Tromey  <tromey@adacore.com>
5122
5123         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5124         destructor.
5125         (dbx_objfile_data_key): Change type and declare later.
5126         (DBX_SYMFILE_INFO): Rewrite.
5127         * dbxread.c (dbx_objfile_data_key): Change type.
5128         (dbx_symfile_init): Update.
5129         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5130         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5131         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5132
5133 2019-07-10  Tom Tromey  <tromey@adacore.com>
5134
5135         * jit.c (jit_program_space_key): Change type.  Move lower.
5136         (get_jit_program_space_data): Update.
5137         (jit_program_space_data_cleanup): Remove.
5138         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5139         Update.
5140         (struct jit_program_space_data): Add initializers.
5141
5142 2019-07-10  Tom Tromey  <tromey@adacore.com>
5143
5144         * solib-darwin.c (struct darwin_info): Add initializers.
5145         (solib_darwin_pspace_data): Change type.
5146         (darwin_pspace_data_cleanup): Remove.
5147         (get_darwin_info, _initialize_darwin_solib): Update.
5148
5149 2019-07-10  Tom Tromey  <tromey@adacore.com>
5150
5151         * remote-sim.c (struct sim_inferior_data): Add initializers,
5152         constructor, and destructor.
5153         (sim_inferior_data_key): Change type.  Move lower.
5154         (check_for_duplicate_sim_descriptor): Update.
5155         (get_sim_inferior_data): Use new.  Update.
5156         (~sim_inferior_data_cleanup): Rename from
5157         sim_inferior_data_cleanup.  Simplify.
5158         (gdbsim_close_inferior, simulator_command)
5159         (sim_command_completer, _initialize_remote_sim): Update.
5160         (next_pid, INITIAL_PID): Move earlier.
5161
5162 2019-07-10  Tom Tromey  <tromey@adacore.com>
5163
5164         * python/python-internal.h (create_thread_object): Return
5165         gdbpy_ref.
5166         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5167         * python/py-inferior.c (struct threadlist_entry): Add
5168         constructor.
5169         <thread_obj>: Now a gdbpy_ref.
5170         (thread_to_thread_object): Update.
5171         (add_thread_object): Use new.
5172         (delete_thread_object): Use delete.
5173         (infpy_threads): Update.
5174         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5175         GIL.
5176
5177 2019-07-10  Tom Tromey  <tromey@adacore.com>
5178
5179         * valops.c (value_cast): Specialize error message for Ada.
5180
5181 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5182
5183         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5184
5185 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5186
5187         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5188         bpstat_should_step): Return bool, adjust comments.
5189         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5190         bpstat_should_step): Likewise.
5191
5192 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5193
5194         * features/Makefile: Use feature target descriptions for Arm.
5195         * features/arm/arm-core.c: Generate new file.
5196         * features/arm/arm-fpa.c: Likewise.
5197         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5198         * features/arm/arm-m-profile.c: Likewise.
5199         * features/arm/arm-vfpv2.c: Likewise.
5200         * features/arm/arm-vfpv3.c: Likewise.
5201         * features/arm/xscale-iwmmxt.c: Likewise.
5202         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5203
5204 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5205
5206         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5207         ptrace earlier.
5208
5209 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5210
5211         * features/aarch64-pauth.c: Regenerate.
5212
5213 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5214
5215         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5216         bool.
5217         (bpstat_what): Use false instead of 0.
5218
5219 2019-07-09  Pedro Alves  <palves@redhat.com>
5220
5221         * break-catch-throw.c (is_exception_catchpoint): New.
5222         * breakpoint.c (print_one_breakpoint_location): New parameter
5223         'raw_loc'.  Handle it.  Use
5224         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5225         looking at the breakpoint's type.
5226         (print_one_breakpoint): If handling "maint info breakpoints", also
5227         print locations of exception catchpoints.
5228         * breakpoint.h (is_exception_catchpoint): Declare.
5229
5230 2019-07-09  Pedro Alves  <palves@redhat.com>
5231
5232         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5233         "addr" field.
5234         (allocate_location_exception_catchpoint): New.
5235         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5236         (initialize_throw_catchpoint_ops): Install
5237         allocate_location_exception_catchpoint as allocate_location
5238         method.
5239         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5240         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5241         bp_loc_other.
5242         (breakpoint_address_is_meaningful): Delete.
5243         (bl_address_is_meaningful): New.
5244         (breakpoint_locations_match): Adjust comment.
5245         (bp_location_from_bp_type): New, factored out of...
5246         (bp_location::bp_location(breakpoint *)): ... this.
5247         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5248         factored out of...
5249         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5250         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5251         breakpoint_address_is_meaningful.
5252         (bp_locations_compare): Adjust comment.
5253         (update_global_location_list): Use bl_address_is_meaningful
5254         instead of breakpoint_address_is_meaningful.
5255         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5256         explicit.
5257         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5258         * python/py-breakpoint.c (bppy_get_location): No longer check
5259         whether location is null.
5260
5261 2019-07-09  Pedro Alves  <palves@redhat.com>
5262
5263         PR c++/15468
5264         * breakpoint.c (print_one_breakpoint_location): Remove
5265         single-location assert.
5266
5267 2019-07-09  Tom Tromey  <tom@tromey.com>
5268
5269         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5270         * configure: Rebuild.
5271         * configure.ac: Change common to gdbsupport.
5272         * gdbsupport: Rename from common.
5273         * acinclude.m4: Change common to gdbsupport.
5274         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5275         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5276         gdbsupport.
5277         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5278         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5279         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5280         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5281         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5282         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5283         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5284         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5285         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5286         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5287         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5288         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5289         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5290         coff-pe-read.c, command.h, compile/compile-c-support.c,
5291         compile/compile-c.h, compile/compile-cplus-symbols.c,
5292         compile/compile-cplus-types.c, compile/compile-cplus.h,
5293         compile/compile-loc2c.c, compile/compile.c, completer.c,
5294         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5295         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5296         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5297         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5298         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5299         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5300         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5301         features/aarch64-core.c, features/aarch64-fpu.c,
5302         features/aarch64-pauth.c, features/aarch64-sve.c,
5303         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5304         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5305         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5306         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5307         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5308         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5309         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5310         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5311         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5312         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5313         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5314         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5315         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5316         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5317         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5318         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5319         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5320         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5321         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5322         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5323         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5324         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5325         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5326         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5327         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5328         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5329         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5330         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5331         minsyms.c, mips-linux-tdep.c, namespace.h,
5332         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5333         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5334         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5335         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5336         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5337         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5338         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5339         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5340         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5341         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5342         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5343         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5344         procfs.c, producer.c, progspace.h, psymtab.h,
5345         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5346         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5347         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5348         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5349         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5350         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5351         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5352         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5353         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5354         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5355         target-memory.c, target.c, target.h, target/waitstatus.c,
5356         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5357         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5358         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5359         unittests/array-view-selftests.c,
5360         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5361         unittests/common-utils-selftests.c,
5362         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5363         unittests/format_pieces-selftests.c,
5364         unittests/function-view-selftests.c,
5365         unittests/lookup_name_info-selftests.c,
5366         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5367         unittests/mkdir-recursive-selftests.c,
5368         unittests/observable-selftests.c,
5369         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5370         unittests/parse-connection-spec-selftests.c,
5371         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5372         unittests/scoped_fd-selftests.c,
5373         unittests/scoped_mmap-selftests.c,
5374         unittests/scoped_restore-selftests.c,
5375         unittests/string_view-selftests.c, unittests/style-selftests.c,
5376         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5377         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5378         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5379         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5380         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5381         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5382
5383 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5386         bool value.
5387         (decode_digits_ordinary): Set explicit_line field in sal.
5388         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5389         symtab_and_line that was set on an explicit line number in
5390         assembler code.  Do always update the recorded symtab and line if
5391         we do skip the prologue.
5392
5393 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5394
5395         * breakpoint.c (set_breakpoint_location_function): Remove
5396         explicit_loc parameter.
5397         (momentary_breakpoint_from_master): Update call to
5398         set_breakpoint_location_function.
5399         (add_location_to_breakpoint): Likewise.
5400
5401 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5404         required features based on default bfd type when no specific bfd
5405         is present.
5406
5407 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5408
5409         * NEWS: Mention that GDB printf and eval commands can now print
5410         C-style and Ada-style convenience var strings without
5411         calling the inferior.
5412         * printcmd.c (printf_c_string): Locally print GDB internal var
5413         instead of transiting via the inferior.
5414         (printf_wide_c_string): Likewise.
5415
5416 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5417
5418         PR breakpoints/25011
5419         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5420
5421 2019-07-04  Tom Tromey  <tom@tromey.com>
5422
5423         PR tui/24724:
5424         * tui/tui-winsource.c (tui_clear_source_content): Update.
5425         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5426         (tui_update_breakpoint_info): Update.
5427         (tui_set_exec_info_content): Update.
5428         * tui/tui-source.c (tui_set_source_content_nil): Update.
5429         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5430         has_break.
5431         * tui/tui-data.h (enum tui_bp_flag): New.
5432         (tui_bp_flags): New enum flags type.
5433         (struct tui_source_element) <break_mode>: Change type.  Rename
5434         from has_break.
5435         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5436         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5437         constants.
5438         * tui/tui-winsource.h: Fix comment.
5439
5440 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5441
5442         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5443         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5444         (store_fpregs_to_thread)
5445         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5446         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5447         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5448         (IWMMXT_REGS_SIZE): Add define.
5449         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5450         (fetch_vfp_regs, store_vfp_regs)
5451         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5452         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5453
5454 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5455
5456         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5457         defines.
5458         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5459         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5460         (ARM_INT_REGISTER_SIZE): ...to this.
5461         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5462         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5463         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5464         (arm_linux_collect_gregset, supply_nwfpe_register)
5465         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5466         defines.
5467         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5468         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5469         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5470         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5471         (arm_return_in_memory, arm_store_return_value)
5472         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5473         (arm_record_ld_st_multiple): Likewise.
5474         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5475         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5476
5477 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5478
5479         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5480         AARCH64_DISPLACED_MODIFIED_INSNS.
5481         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5482         (aarch64_displaced_step_copy_insn): Likewise.
5483         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5484         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5485         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5486         ARM_DISPLACED_MODIFIED_INSNS.
5487         * arm-tdep.c (arm_gdbarch_init): Likewise.
5488         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5489         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5490         (struct arm_displaced_step_closure): Use
5491         ARM_DISPLACED_MODIFIED_INSNS.
5492
5493 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5494
5495         * features/Makefile: Remove unused xml files.
5496         * features/aarch64.xml: Remove.
5497         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5498         * features/i386/amd64-avx-avx512.xml: Remove.
5499         * features/i386/amd64-avx-linux.xml: Remove.
5500         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5501         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5502         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5503         * features/i386/amd64-avx-mpx.xml: Remove.
5504         * features/i386/amd64-avx.xml: Remove.
5505         * features/i386/amd64-linux.xml: Remove.
5506         * features/i386/amd64-mpx-linux.xml: Remove.
5507         * features/i386/amd64-mpx.xml: Remove.
5508         * features/i386/amd64.xml: Remove.
5509         * features/i386/i386-avx-avx512-linux.xml: Remove.
5510         * features/i386/i386-avx-avx512.xml: Remove.
5511         * features/i386/i386-avx-linux.xml: Remove.
5512         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5513         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5514         * features/i386/i386-avx-mpx-linux.xml: Remove.
5515         * features/i386/i386-avx-mpx.xml: Remove.
5516         * features/i386/i386-avx.xml: Remove.
5517         * features/i386/i386-linux.xml: Remove.
5518         * features/i386/i386-mmx-linux.xml: Remove.
5519         * features/i386/i386-mmx.xml: Remove.
5520         * features/i386/i386-mpx-linux.xml: Remove.
5521         * features/i386/i386-mpx.xml: Remove.
5522         * features/i386/i386.xml: Remove.
5523         * features/i386/x32-avx-avx512-linux.xml: Remove.
5524         * features/i386/x32-avx-linux.xml: Remove.
5525         * features/i386/x32-linux.xml: Remove.
5526
5527 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5528
5529         * regformats/aarch64.dat: Remove.
5530         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5531         * regformats/i386/amd64-avx-linux.dat: Remove.
5532         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5533         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5534         * regformats/i386/amd64-linux.dat: Remove.
5535         * regformats/i386/amd64-mpx-linux.dat: Remove.
5536         * regformats/i386/amd64.dat: Remove.
5537         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5538         * regformats/i386/i386-avx-linux.dat: Remove.
5539         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5540         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5541         * regformats/i386/i386-linux.dat: Remove.
5542         * regformats/i386/i386-mmx-linux.dat: Remove.
5543         * regformats/i386/i386-mpx-linux.dat: Remove.
5544         * regformats/i386/i386.dat: Remove.
5545         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5546         * regformats/i386/x32-avx-linux.dat: Remove.
5547         * regformats/i386/x32-linux.dat: Remove.
5548
5549 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5550
5551         * aarch64-tdep.c: Remove xml self tests.
5552         * amd64-linux-tdep.c: Likewise.
5553         * amd64-tdep.c: Likewise.
5554         * i386-linux-tdep.c: Likewise.
5555         * i386-tdep.c: Likewise.
5556
5557 2019-07-03  Pedro Alves  <palves@redhat.com>
5558
5559         PR cli/24732
5560         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5561         (pipe_cmd_option_defs): New.
5562         (make_pipe_cmd_options_def_group): New.
5563         (pipe_command): Use gdb::option::process_options.
5564         (pipe_command_completer): New function.
5565         (_initialize_cli_cmds): Install completer for "pipe" command.
5566
5567 2019-07-03  Pedro Alves  <palves@redhat.com>
5568
5569         * cli/cli-option.c (union option_value) <string>: New field.
5570         (struct option_def_and_value): Add ctor, move ctor, dtor and
5571         use DISABLE_COPY_AND_ASSIGN.
5572         (option_def_and_value::clear_value): New.
5573         (parse_option, save_option_value_in_ctx, get_val_type_str)
5574         (add_setshow_cmds_for_options): Handle var_string.
5575         * cli-option.h (union option_def::var_address) <string>: New
5576         field.
5577         (struct string_option_def): New.
5578         * maint-test-options.c (struct test_options_opts): Add default
5579         ctor and use DISABLE_COPY_AND_ASSIGN.
5580         <string_opt>: New field.
5581         (test_options_opts::~test_options_opts): New.
5582         (test_options_opts::dump): Also dump "-string".
5583         (test_options_option_defs): Install "string.
5584
5585 2019-07-03  Pedro Alves  <palves@redhat.com>
5586
5587         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5588         option_value with a null enumeration.
5589         (complete_options): Save the option values in the context.
5590         (save_option_value_in_ctx): New, factored out from ...
5591         (process_options): ... here.
5592         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5593         of the function.
5594         * maint-test-options.c (test_options_opts::dump): New, factored
5595         out from ...
5596         (maintenance_test_options_command_mode): ... here.
5597         (maintenance_test_options_command_completion_result): Delete.
5598         (maintenance_test_options_command_completion_text): Update
5599         comment.
5600         (maintenance_show_test_options_completion_result): Change
5601         prototype.  Just print
5602         maintenance_test_options_command_completion_text.
5603         (save_completion_result): New.
5604         (maintenance_test_options_completer_mode): Pass options context to
5605         complete_options, and then save a dump.
5606         (_initialize_maint_test_options): Use add_cmd to install "maint
5607         show test-options-completion-result".
5608
5609 2019-07-03  Pedro Alves  <palves@redhat.com>
5610
5611         * NEWS (New commands): Mention "with" and "maint with".
5612         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5613         (with_command, with_command_completer): New.
5614         (pipe_command): Adjust to new repeat_previous
5615         interface.
5616         (_initialize_cli_cmds): Install the "with" command and its "w"
5617         alias.
5618         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5619         declarations.
5620         * cli/cli-setshow.c (parse_cli_var_uinteger)
5621         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5622         argument strings for all var_types.
5623         (get_setshow_command_value_string): New, factored out from ...
5624         (do_show_command): ... this.
5625         * cli/cli-setshow.h: Include <string>.
5626         (get_setshow_command_value_string): Declare.
5627         * command.h (repeat_previous): Now returns const char *.  Adjust
5628         comment.
5629         * maint.c: Include "cli/cli-cmds.h".
5630         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5631         (_initialize_maint_cmds): Register the "maintenance with" command.
5632         * top.c (repeat_previous): Move bits from pipe_command here:
5633         Return the saved command line, if any; error out if there's no
5634         command to relaunch.
5635
5636 2019-07-03  Pedro Alves  <palves@redhat.com>
5637
5638         * NEWS (New commands): Mention "maint set/show test-settings"
5639         instead of "maint test-settings".
5640         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5641         (maintenance_test_settings_set_list): Rename to ...
5642         (maintenance_set_test_settings_list): ... this.
5643         (maintenance_test_settings_show_list): Rename to  ...
5644         (maintenance_show_test_settings_list): ... this.
5645         (maintenance_test_settings_cmd): Delete.
5646         (maintenance_test_settings_set_cmd): ...
5647         (maintenance_set_test_settings_cmd): ... this.
5648         (maintenance_test_settings_show_cmd): ...
5649         (maintenance_show_test_settings_cmd): ... this.
5650         (maintenance_test_settings_show_value_cmd):
5651         (maintenance_show_test_settings_value_cmd): ... this.
5652         (_initialize_maint_test_settings): No longer install the "maint
5653         test-settings" prefix command.  Rename "maint test-settings set"
5654         to "maint set test-settings", and "maint test-settings show" to
5655         "maint show test-settings".  Adjust all subcommands.
5656
5657 2019-07-03  Pedro Alves  <palves@redhat.com>
5658
5659         * maint-test-settings.c: Fix file's intro comment.  Replace all
5660         references to "test-options" with references to "test-settings",
5661         in comments.
5662
5663 2019-07-03  Pedro Alves  <palves@redhat.com>
5664
5665         * maint-test-settings.c (maintenance_test_settings_xxx)
5666         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5667         New.
5668         (maintenance_test_settings_enums): Use them.
5669         (maintenance_test_settings_enum): Default to
5670         maintenance_test_settings_xxx.
5671         (_initialize_maint_test_settings): Initialize
5672         MAINTENANCE_TEST_SETTINGS_FILENAME.
5673
5674 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5675
5676         * breakpoint.h (remove_breakpoints_inf): Change return type to
5677         void, move function documentation here.
5678         * breakpoint.c (remove_breakpoints_inf): Change return type to
5679         void, move function documentation to header.
5680
5681 2019-07-02  Pedro Alves  <palves@redhat.com>
5682
5683         * NEWS (Completion improvements): Mention "info threads".
5684         * thread.c (struct info_threads_opts, info_threads_option_defs)
5685         (make_info_threads_options_def_group): New.
5686         (info_threads_command): Use gdb::option::process_options.
5687         (info_threads_command_completer): New.
5688         (_initialize_thread): Use gdb::option::build_help to build the
5689         help text for "info threads".
5690
5691 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5692
5693         * defs.h (generic_load): Move from here...
5694         * symfile.h (generic_load): ... to here.  Rename name parameter
5695         to args.
5696         * symfile.c (generic_load): Add comment.
5697
5698 2019-07-01  Tom Tromey  <tromey@adacore.com>
5699
5700         * dwarf2read.c
5701         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5702         declaration of without_params.  Fix formatting.
5703
5704 2019-07-01  Tom Tromey  <tromey@adacore.com>
5705
5706         * ada-exp.y (find_primitive_type): Update.
5707         * ada-lang.h (ada_lookup_symbol): Update.
5708         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5709         parameter.
5710         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5711
5712 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5713
5714         PR breakpoints/24541
5715         * gdbarch.c: Regenerate.
5716         * gdbarch.h: Regenerate.
5717         * gdbarch.sh: Add 'stap_adjust_register'.
5718         * i386-tdep.c: Include '<unordered_set>'.
5719         (i386_stap_adjust_register): New function.
5720         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5721         * stap-probe.c (stap_parse_register_operand): Call
5722         'gdbarch_stap_adjust_register'.
5723
5724 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5725
5726         PR python/24742
5727         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5728         * python/python.c (do_start_initialization): Use 'xmalloc'
5729         instead of 'PyMem_Malloc'.
5730
5731 2019-06-28  Tom Tromey  <tromey@adacore.com>
5732
5733         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5734         for Ada.
5735
5736 2019-06-27  Tom Tromey  <tromey@adacore.com>
5737
5738         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5739         objfile_key.
5740         (arm_find_mapping_symbol, arm_record_special_symbol)
5741         (_initialize_arm_tdep): Update.
5742         (arm_objfile_data_free): Remove.
5743
5744 2019-06-27  Tom Tromey  <tromey@adacore.com>
5745
5746         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5747         to cp_print_static_field.
5748
5749 2019-06-26  Tom Tromey  <tromey@adacore.com>
5750
5751         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5752         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5753         declare.
5754
5755 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5756
5757         * features/aarch64-core.c (create_feature_aarch64_core):
5758         Regenerate.
5759         * features/aarch64-core.xml: Add cpsr flags.
5760
5761 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5762
5763         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5764         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5765
5766 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5767
5768         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5769         field.
5770         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5771         use.
5772         (arm_record_special_symbol): Don't insert new symbol in sorted
5773         position, push it at the end.
5774
5775 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5776
5777         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5778         (arm_mapping_symbol_s): Remove.
5779         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5780         (arm_mapping_symbol_vec): New typedef.
5781         (struct arm_per_objfile): Add constructor.
5782         <section_maps>: Change type to
5783         std::unique_ptr<arm_mapping_symbol_vec[]>.
5784         (arm_compare_mapping_symbols): Remove.
5785         (arm_find_mapping_symbol): Adjust to section_maps type change.
5786         (arm_objfile_data_free): Call delete on arm_per_objfile.
5787         (arm_record_special_symbol): Adjust to section_maps type change.
5788         Allocate arm_per_objfile with new.
5789
5790 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5791
5792         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5793         with the command prefix.
5794
5795 2019-06-25  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5798         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5799
5800 2019-06-25  Tom Tromey  <tom@tromey.com>
5801
5802         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5803         type.
5804         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5805         protected.
5806
5807 2019-06-25  Tom Tromey  <tom@tromey.com>
5808
5809         * tui/tui-winsource.c
5810         (tui_source_window_base::set_is_exec_point_at): Add check against
5811         LOA_ADDRESS.
5812
5813 2019-06-25  Tom Tromey  <tom@tromey.com>
5814
5815         * tui/tui-source.c (tui_set_source_content): Don't check before
5816         xfree.
5817         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5818
5819 2019-06-25  Tom Tromey  <tom@tromey.com>
5820
5821         * tui/tui-winsource.h (tui_update_source_window_as_is)
5822         (tui_alloc_source_buffer, tui_line_is_displayed)
5823         (tui_addr_is_displayed): Change type of win_info.
5824         * tui/tui-winsource.c (tui_update_source_window_as_is)
5825         (tui_clear_source_content, tui_show_source_line)
5826         (tui_show_source_content, tui_source_window_base::refill)
5827         (tui_source_window_base::set_is_exec_point_at)
5828         (tui_source_window_base::set_is_exec_point_at)
5829         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5830         (tui_alloc_source_buffer, tui_line_is_displayed)
5831         (tui_addr_is_displayed): Change type of win_info.  Update.
5832         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5833         (tui_source_window_base::do_make_visible_with_new_height):
5834         Update.
5835         * tui/tui-source.c (tui_set_source_content)
5836         (tui_set_source_content_nil)
5837         (tui_source_window::do_scroll_vertical): Update.
5838         * tui/tui-layout.c (show_layout): Update.
5839         * tui/tui-disasm.c (tui_set_disassem_content)
5840         (tui_disasm_window::do_scroll_vertical): Update.
5841         * tui/tui-data.h (tui_win_content): Remove.
5842         (struct tui_gen_win_info) <content, content_size>: Remove.
5843         (struct tui_source_element): Add initializers and destructor.
5844         (union tui_which_element, struct tui_win_element): Remove.
5845         (struct tui_source_window_base) <content>: New field.
5846         (struct tui_data_window): Remove destructor.
5847         (tui_alloc_content, tui_free_win_content)
5848         (tui_free_all_source_wins_content): Don't declare.
5849         * tui/tui-data.c (tui_initialize_static_data): Update.
5850         (init_content_element, tui_alloc_content): Remove.
5851         (~tui_gen_win_info): Update.
5852         (~tui_data_window, tui_free_all_source_wins_content)
5853         (tui_free_win_content, free_content, free_content_elements):
5854         Remove.
5855
5856 2019-06-25  Tom Tromey  <tom@tromey.com>
5857
5858         * tui/tui-winsource.h (tui_clear_source_content)
5859         (tui_erase_source_content, tui_show_source_content): Change type
5860         of win_info.
5861         * tui/tui-winsource.c (tui_clear_source_content)
5862         (tui_erase_source_content, tui_show_source_content): Change type
5863         of win_info.
5864         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5865         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5866         win_info.
5867         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5868         win_info.
5869         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5870
5871 2019-06-25  Tom Tromey  <tom@tromey.com>
5872
5873         * tui/tui-winsource.c (tui_clear_source_content)
5874         (tui_source_window_base::set_is_exec_point_at): Update.
5875         * tui/tui-source.c (tui_set_source_content_nil): Update.
5876         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5877         a bool.
5878         * tui/tui-data.c (init_content_element): Update.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5883         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5884         * tui/tui-layout.c (init_and_make_win): Update.
5885         * tui/tui.h (enum tui_win_type): Update.
5886         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5887         tui_win_is_auxillary.
5888         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5889         tui_win_is_auxillary.
5890
5891 2019-06-25  Tom Tromey  <tom@tromey.com>
5892
5893         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5894         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5895         (tui_delete_data_content_windows, tui_display_all_data)
5896         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5897         Update.
5898         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5899         * tui/tui-regs.c (tui_last_regs_line_no)
5900         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5901         (tui_show_registers): Update.
5902         (tui_show_register_group): Return void.  Update.
5903         (tui_display_registers_from, tui_display_reg_element_at_line)
5904         (tui_display_registers_from_line, tui_check_register_values):
5905         Update.
5906         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5907         member.
5908         (struct tui_data_window) <regs_content>: Now a std::vector.
5909         <regs_content_count>: Remove.
5910         (tui_add_content_elements, tui_free_data_content): Don't declare.
5911         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5912         (init_content_element): Remove DATA_WIN case.  Add assert.
5913         (tui_add_content_elements): Remove.
5914         (tui_data_window): Update.
5915         (tui_free_data_content): Remove.
5916         (free_content_elements): Remove DATA_WIN case.
5917
5918 2019-06-25  Tom Tromey  <tom@tromey.com>
5919
5920         * tui/tui-data.c (tui_data_item_window): Update.
5921         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5922         * tui/tui-windata.c (tui_display_all_data)
5923         (tui_display_data_from_line): Update.
5924         (tui_check_data_values): Remove.
5925         * tui/tui-regs.c (tui_show_register_group)
5926         (tui_display_reg_element_at_line): Update.
5927         * tui/tui-hooks.c (tui_register_changed)
5928         (tui_refresh_frame_and_register_information): Call
5929         tui_check_register_values.
5930         * tui/tui-data.h (struct tui_data_window) <data_content,
5931         data_content_count, data_type>: Remove.
5932         (enum tui_data_type): Remove.
5933
5934         * tui/tui-data.c (tui_data_window::clear_detail)
5935         (~tui_data_window): Update.
5936
5937 2019-06-25  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5940         declare.
5941         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5942         Rename from tui_first_data_item_displayed.  Update.
5943         (tui_data_window::refresh_all)
5944         (tui_data_window::do_scroll_vertical): Update.
5945         * tui/tui-data.h (struct tui_data_window)
5946         <first_data_item_displayed>: Declare new method.
5947
5948 2019-06-25  Tom Tromey  <tom@tromey.com>
5949
5950         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5951         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5952         contents...
5953         (tui_initialize_static_data): ...here.
5954
5955 2019-06-25  Tom Tromey  <tom@tromey.com>
5956
5957         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5958         (tui_display_registers_from, tui_check_register_values): Update.
5959         (tui_display_register): Remove win_info parameter; update.
5960         (tui_get_register): Change type of parameters.
5961         * tui/tui-data.h (struct tui_data_element): Remove.
5962         (union tui_which_element) <data>: Remove.
5963         <data_window>: Change type.
5964         (struct tui_data_item_window): New.
5965         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5966         case.  Add assert.
5967         (~tui_data_item_window): New destructor.
5968         (free_content_elements): Remove DATA_ITEM_WIN case.
5969
5970 2019-06-25  Tom Tromey  <tom@tromey.com>
5971
5972         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5973         Remove.
5974
5975 2019-06-25  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-data.h (struct tui_command_element): Remove.
5978         (union tui_which_element) <command>: Remove.
5979         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5980         assert.
5981         (free_content_elements): Remove CMD_WIN case.
5982
5983 2019-06-25  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-layout.c (tui_set_layout): Update.
5986         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5987         * tui/tui-data.c (layout_def): Update.
5988
5989 2019-06-25  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5992         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5993         (tui_source_window_base::set_new_height): Update.
5994         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5995         Update.
5996         (tui_set_locator_fullname, tui_set_locator_info)
5997         (tui_show_frame_info): Update.
5998         * tui/tui-source.c (tui_set_source_content)
5999         (tui_source_is_displayed): Update.
6000         * tui/tui-layout.c (show_source_disasm_command, show_data)
6001         (show_source_or_disasm_and_command): Update.
6002         * tui/tui-disasm.c (tui_set_disassem_content)
6003         (tui_get_begin_asm_address): Update.
6004         * tui/tui-data.h (struct tui_locator_element): Remove.
6005         (union tui_which_element) <locator>: Remove.
6006         (struct tui_locator_window): New.
6007         (tui_locator_win_info_ptr): Change return type.
6008         * tui/tui-data.c (_locator): Change type.
6009         (tui_locator_win_info_ptr): Change return type.
6010         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6011         (tui_alloc_content): Add assert.
6012
6013 2019-06-25  Tom Tromey  <tom@tromey.com>
6014
6015         * tui/tui-winsource.c
6016         (tui_exec_info_window::maybe_allocate_content): New method.
6017         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6018         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6019         (make_source_or_disasm_window): Add cast.
6020         * tui/tui-data.h (union tui_which_element) <simple_string>:
6021         Remove.
6022         (struct tui_source_info): New.
6023         (struct tui_source_window_base) <execution_info>: Change type.
6024         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6025         case, and add assert.
6026         (tui_alloc_content): Add assert.
6027
6028 2019-06-25  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6031         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6032         * tui/tui-data.c (tui_alloc_win_info): Remove.
6033
6034 2019-06-25  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6037         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6038         can_highlight.
6039
6040 2019-06-25  Tom Tromey  <tom@tromey.com>
6041
6042         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6043         make_visible_with_new_height method.
6044         (tui_win_info::make_visible_with_new_height): New method.
6045         (tui_source_window_base::do_make_visible_with_new_height)
6046         (tui_data_window::do_make_visible_with_new_height)
6047         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6048         (make_visible_with_new_height): Remove.
6049         (tui_resize_all, tui_adjust_win_heights): Use
6050         make_visible_with_new_height method.
6051         * tui/tui-data.h (struct tui_win_info)
6052         <do_make_visible_with_new_height, make_visible_with_new_height>:
6053         New methods.
6054         (struct tui_source_window_base, struct tui_data_window)
6055         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6056         methods.
6057
6058 2019-06-25  Tom Tromey  <tom@tromey.com>
6059
6060         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6061         method.
6062         (update_tab_width): Call update_tab_width method.
6063         * tui/tui-data.h (struct tui_win_info)
6064         (struct tui_source_window_base) <update_tab_width>: New methods.
6065
6066 2019-06-25  Tom Tromey  <tom@tromey.com>
6067
6068         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6069         parameter.
6070         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6071         parameter.
6072         (tui_gen_win_info::make_visible): Update.
6073         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6074         parameter.
6075         * tui/tui-data.h (enum tui_box): New enum.
6076         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6077
6078 2019-06-25  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6081         init_and_make_win for EXEC_INFO_WIN.
6082         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6083         longer inline.
6084         (struct tui_win_info) <~tui_win_info>: Inline.
6085         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6086         Don't declare.
6087         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6088         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6089         Remove.
6090         (tui_initialize_static_data): Update.
6091         (~tui_gen_win_info): Handle more cleanup here.
6092         (~tui_source_window_base): Delete "execution_info".
6093         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6094
6095 2019-06-25  Tom Tromey  <tom@tromey.com>
6096
6097         * tui/tui-layout.c (make_command_window): Don't set
6098         can_highlight.
6099         (show_source_disasm_command): Call the reset method.
6100         (show_data): Don't set can_highlight.  Call the reset method.
6101         (tui_gen_win_info::reset): Rename from init_gen_win_info
6102         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6103         (show_source_or_disasm_and_command): Call the reset method.
6104         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6105         (struct tui_cmd_window): Set can_highlight.
6106
6107 2019-06-25  Tom Tromey  <tom@tromey.com>
6108
6109         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6110         from make_visible.
6111         (tui_make_visible, tui_make_invisible): Rewrite.
6112         (tui_win_info::make_visible): Remove.
6113         (tui_source_window_base::make_visible): Update.
6114         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6115         method.  Moved from...
6116         (struct tui_win_info) <make_visible>: ...here.
6117
6118 2019-06-25  Tom Tromey  <tom@tromey.com>
6119
6120         * tui/tui-winsource.c
6121         (tui_source_window_base::do_scroll_horizontal): Remove direction
6122         parameter.
6123         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6124         direction parameter.
6125         * tui/tui-win.c (tui_win_info::forward_scroll)
6126         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6127         (tui_win_info::right_scroll): Update.
6128         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6129         direction parameter.
6130         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6131         direction parameter.
6132         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6133         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6134         Remove direction parameter.
6135         (struct tui_source_window_base, struct tui_source_window)
6136         (struct tui_disasm_window, struct tui_data_window)
6137         (struct tui_cmd_window): Update.
6138
6139 2019-06-25  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui-winsource.h (tui_set_exec_info_content)
6142         (tui_show_exec_info_content, tui_erase_exec_info_content)
6143         (tui_clear_exec_info_content, tui_update_exec_info): Change
6144         argument to tui_source_window_base.
6145         * tui/tui-winsource.c (tui_set_exec_info_content)
6146         (tui_show_exec_info_content, tui_erase_exec_info_content)
6147         (tui_clear_exec_info_content, tui_update_exec_info): Change
6148         argument to tui_source_window_base.
6149
6150 2019-06-25  Tom Tromey  <tom@tromey.com>
6151
6152         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6153         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6158         check.
6159
6160 2019-06-25  Tom Tromey  <tom@tromey.com>
6161
6162         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6163         type to void.
6164         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6165         type to void.
6166         * tui/tui-source.c (tui_set_source_content): Update.
6167         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6168
6169 2019-06-25  Tom Tromey  <tom@tromey.com>
6170
6171         * tui/tui-win.c (window_name_completer, tui_set_focus)
6172         (tui_all_windows_info): Use name method.
6173         * tui/tui-data.h (struct tui_gen_win_info)
6174         (struct tui_source_window, struct tui_disasm_window)
6175         (struct tui_data_window, struct tui_cmd_window) <name>: New
6176         method.
6177         (tui_win_name): Don't declare.
6178         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6179         (tui_win_name): Remove.
6180
6181 2019-06-25  Tom Tromey  <tom@tromey.com>
6182
6183         * tui/tui-winsource.h (tui_update_source_window)
6184         (tui_update_source_window_as_is): Change parameter type.
6185         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6186         to be a tui_source_window_base.
6187         (tui_update_source_window_as_is): Likewise.
6188         * tui/tui-win.c (make_visible_with_new_height): Update.
6189
6190 2019-06-25  Tom Tromey  <tom@tromey.com>
6191
6192         * tui/tui-winsource.c (tui_erase_source_content)
6193         (tui_show_source_content, tui_show_exec_info_content)
6194         (tui_erase_exec_info_content): Use refresh_window method.
6195         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6196         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6197         from tui_refresh_win.
6198         (tui_data_window::refresh_window): New method.
6199         (tui_win_info::refresh, tui_source_window_base::refresh)
6200         (tui_refresh_all): Use refresh_window method.
6201         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6202         method.
6203         * tui/tui-regs.c (tui_display_register): Call refresh_window
6204         method.
6205         * tui/tui-layout.c (show_source_disasm_command)
6206         (show_source_or_disasm_and_command): Call refresh_window method.
6207         * tui/tui-data.h (struct tui_gen_win_info)
6208         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6209         New method.
6210
6211 2019-06-25  Tom Tromey  <tom@tromey.com>
6212
6213         * tui/tui.c (tui_rl_other_window, tui_enable)
6214         (tui_is_window_visible, tui_get_command_dimension): Update.
6215         * tui/tui-winsource.c (tui_update_source_window_as_is)
6216         (tui_clear_source_content, tui_erase_source_content)
6217         (tui_show_source_line, tui_source_window_base::refill)
6218         (tui_source_window_base::do_scroll_horizontal)
6219         (tui_source_window_base::set_is_exec_point_at)
6220         (tui_update_breakpoint_info, tui_set_exec_info_content)
6221         (tui_alloc_source_buffer, tui_line_is_displayed)
6222         (tui_addr_is_displayed): Update.
6223         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6224         (tui_check_and_display_highlight_if_needed)
6225         (tui_win_info::make_visible, tui_win_info::refresh)
6226         (tui_refresh_all): Update.
6227         * tui/tui-windata.c (tui_first_data_item_displayed)
6228         (tui_delete_data_content_windows, tui_erase_data_content)
6229         (tui_display_all_data, tui_data_window::refresh_all)
6230         (tui_check_data_values): Update.
6231         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6232         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6233         (tui_win_info::backward_scroll, tui_refresh_all_win)
6234         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6235         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6236         (tui_source_window_base::set_new_height)
6237         (tui_data_window::set_new_height)
6238         (make_invisible_and_set_new_height)
6239         (make_visible_with_new_height, new_height_ok)
6240         (parse_scrolling_args): Update.
6241         * tui/tui-stack.c (tui_show_frame_info): Update.
6242         * tui/tui-source.c (tui_set_source_content)
6243         (tui_set_source_content_nil, tui_source_is_displayed)
6244         (tui_source_window::do_scroll_vertical): Update.
6245         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6246         (tui_display_registers_from, tui_display_reg_element_at_line)
6247         (tui_check_register_values, tui_reg_command): Update.
6248         * tui/tui-layout.c (tui_default_win_height)
6249         (show_source_disasm_command, show_data, init_and_make_win)
6250         (show_source_or_disasm_and_command): Update.
6251         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6252         (tui_redisplay_readline, tui_mld_flush)
6253         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6254         (tui_getc): Update.
6255         * tui/tui-disasm.c (tui_set_disassem_content)
6256         (tui_disasm_window::do_scroll_vertical): Update.
6257         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6258         Now virtual.
6259         (struct tui_win_info): Derive from tui_gen_win_info.
6260         <~tui_win_info>: Mark as override.
6261         <generic>: Remove member.
6262         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6263         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6264         (~tui_data_window, ~tui_win_info)
6265         (tui_free_all_source_wins_content): Update.
6266         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6267
6268 2019-06-25  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-layout.c (init_and_make_win): Use new.
6271         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6272         destructor, initializers.
6273         (tui_alloc_generic_win_info): Don't declare.
6274         * tui/tui-data.c (_locator): Add argument to constructor.
6275         (source_win, disasm_win): New globals.
6276         (exec_info): Remove.
6277         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6278         Update.
6279         (tui_alloc_generic_win_info): Remove.
6280         (init_content_element): Use new.
6281         (tui_win_info::tui_win_info): Update.
6282         (free_content_elements) <case DATA_WIN>: Use delete.
6283
6284 2019-06-25  Tom Tromey  <tom@tromey.com>
6285
6286         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6287         * tui/tui-windata.c (tui_first_data_item_displayed)
6288         (tui_delete_data_content_windows): Update.
6289         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6290         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6291         (tui_display_registers_from, tui_check_register_values): Update.
6292         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6293         pointer.
6294         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6295         window.
6296         (tui_free_data_content): Update.
6297         (free_content_elements) <case DATA_WIN>: Free the window.
6298
6299 2019-06-25  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6302         Update.
6303         * tui/tui-layout.c (make_command_window)
6304         (show_source_disasm_command, show_data, init_and_make_win)
6305         (show_source_or_disasm_and_command): Update.
6306         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6307         method.
6308         <can_highight, is_highlighted>: Now bool.
6309         (tui_set_win_highlight): Don't declare.
6310         * tui/tui-data.c (tui_set_win_highlight): Remove.
6311
6312 2019-06-25  Tom Tromey  <tom@tromey.com>
6313
6314         * tui/tui-wingeneral.c (make_visible): Remove check of window
6315         type.
6316
6317 2019-06-25  Tom Tromey  <tom@tromey.com>
6318
6319         * tui/tui-win.c (tui_win_info::max_height)
6320         (tui_cmd_window::max_height): New methods.
6321         (new_height_ok): Call max_height.
6322         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6323         <max_height>: New method.
6324
6325 2019-06-25  Tom Tromey  <tom@tromey.com>
6326
6327         * tui/tui-win.c (tui_source_window_base::set_new_height)
6328         (tui_data_window::set_new_height): New methods.
6329         (make_invisible_and_set_new_height): Call set_new_height method.
6330         * tui/tui-data.h (struct tui_win_info)
6331         (struct tui_source_window_base, struct tui_data_window)
6332         <set_new_height>: New method.
6333
6334 2019-06-25  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6337         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6338         tui_refresh_data_win.
6339         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6340         method.
6341         (tui_refresh_all_win): Call the refresh_all method.
6342         (tui_set_focus): Likewise.
6343         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6344         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6345         Likewise.
6346
6347 2019-06-25  Tom Tromey  <tom@tromey.com>
6348
6349         * tui/tui-winsource.h (tui_refill_source_window)
6350         (tui_set_is_exec_point_at): Don't declare.
6351         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6352         (tui_source_window_base::refill): Rename from
6353         tui_refill_source_window.
6354         (tui_source_window_base::do_scroll_horizontal): Update.
6355         (tui_source_window_base::set_is_exec_point_at): Rename from
6356         tui_set_is_exec_point_at.
6357         (tui_update_all_breakpoint_info): Update.
6358         * tui/tui-stack.c (tui_show_frame_info): Update.
6359         * tui/tui-layout.c (show_data): Add cast.
6360         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6361         * tui/tui-data.h (struct tui_source_window_base) <refill,
6362         set_is_exec_point_at>: New methods.
6363         (tui_source_windows, tui_add_to_source_windows): Update types.
6364         (tui_add_to_source_windows): Remove redundant declaration.
6365         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6366         (tui_source_windows): Change return type.
6367         (tui_clear_source_windows_detail): Update.
6368         (tui_add_to_source_windows): Change type of parameter.
6369         (tui_free_all_source_wins_content): Update.
6370
6371 2019-06-25  Tom Tromey  <tom@tromey.com>
6372
6373         * tui/tui-wingeneral.c (tui_win_info::refresh)
6374         (tui_source_window_base::refresh): New methods.
6375         (tui_refresh_all): Call the refresh method.
6376         * tui/tui-data.h (struct tui_win_info)
6377         (struct tui_source_window_base) <refresh>: New method.
6378
6379 2019-06-25  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui.h (tui_is_window_visible): Return bool.
6382         * tui/tui.c (tui_is_window_visible): Return bool.
6383         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6384         (tui_make_visible, tui_make_invisible)
6385         (tui_win_info::make_visible)
6386         (tui_source_window_base::make_visible, make_all_visible)
6387         (tui_make_all_visible, tui_make_all_invisible): Update.
6388         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6389         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6390         bool.
6391         (struct tui_win_info, struct tui_source_window_base)
6392         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6393         * tui/tui-data.c (tui_init_generic_part): Update.
6394
6395 2019-06-25  Tom Tromey  <tom@tromey.com>
6396
6397         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6398         (tui_source_window_base::make_visible): New methods.
6399         (make_all_visible): Make method call.
6400         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6401         (struct tui_source_window_base, struct tui_cmd_window): Override
6402         make_visible.
6403         (tui_win_is_source_type): Don't declare.
6404         * tui/tui-data.c (tui_win_is_source_type): Remove.
6405
6406 2019-06-25  Tom Tromey  <tom@tromey.com>
6407
6408         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6409         NULL check.
6410
6411 2019-06-25  Tom Tromey  <tom@tromey.com>
6412
6413         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6414         Inline constructor.  Add initializers for members.
6415         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6416         constructors; now inline in class.
6417
6418 2019-06-25  Tom Tromey  <tom@tromey.com>
6419
6420         * tui/tui-regs.c (tui_show_registers): Update.
6421         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6422         bool.
6423         * tui/tui-data.c (tui_data_window::clear_detail)
6424         (tui_data_window): Update.
6425
6426 2019-06-25  Tom Tromey  <tom@tromey.com>
6427
6428         * tui/tui-windata.c (tui_display_all_data)
6429         (tui_display_data_from_line, tui_display_data_from)
6430         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6431         Update.
6432         * tui/tui-regs.c (tui_last_regs_line_no)
6433         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6434         (tui_show_registers, tui_show_register_group)
6435         (tui_display_registers_from, tui_display_reg_element_at_line)
6436         (tui_display_registers_from_line, tui_check_register_values)
6437         (tui_reg_next, tui_reg_prev): Update.
6438         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6439         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6440         tui_data_window.
6441         (struct tui_win_info) <detail>: Remove.  Add new fields from
6442         tui_data_info.
6443         (TUI_DATA_WIN): Add cast.
6444         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6445         (~tui_data_window): Simplify.
6446
6447 2019-06-25  Tom Tromey  <tom@tromey.com>
6448
6449         * tui/tui-layout.c (show_source_disasm_command)
6450         (show_source_or_disasm_and_command): Update.
6451         * tui/tui-io.c (update_cmdwin_start_line)
6452         (tui_redisplay_readline): Update.
6453         * tui/tui-data.h (struct tui_command_info): Remove.
6454         (struct tui_win_info) <detail>: Remove command_info member.
6455         (struct tui_data_window) <start_line>: New member, from
6456         tui_command_info.
6457         (TUI_CMD_WIN): Add casts.
6458
6459 2019-06-25  Tom Tromey  <tom@tromey.com>
6460
6461         * tui/tui-winsource.c (tui_update_source_window)
6462         (tui_refill_source_window)
6463         (tui_source_window_base::do_scroll_horizontal)
6464         (tui_update_breakpoint_info, tui_set_exec_info_content)
6465         (tui_show_exec_info_content, tui_erase_exec_info_content)
6466         (tui_clear_exec_info_content): Update.
6467         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6468         Update.
6469         * tui/tui-win.c (make_invisible_and_set_new_height)
6470         (make_visible_with_new_height): Update.
6471         * tui/tui-source.c (tui_set_source_content)
6472         (tui_show_symtab_source): Update.
6473         * tui/tui-layout.c (extract_display_start_addr)
6474         (show_source_disasm_command, show_data)
6475         (make_source_or_disasm_window)
6476         (show_source_or_disasm_and_command): Update.
6477         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6478         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6479         "gdbarch".
6480         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6481         to tui_source_window_base.
6482         (struct tui_win_info) <detail>: Remove source_info member.
6483         (struct tui_source_window_base) <has_locator>: Inline.
6484         Move contents from tui_source_info; rename has_locator member to
6485         m_has_locator.
6486         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6487         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6488         header file.
6489         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6490         Simplify.
6491         (tui_free_all_source_wins_content): Cast to
6492         tui_source_window_base.
6493
6494 2019-06-25  Tom Tromey  <tom@tromey.com>
6495
6496         * tui/tui-win.c (make_invisible_and_set_new_height)
6497         (make_visible_with_new_height): Call has_locator method.
6498         * tui/tui-layout.c (show_source_disasm_command, show_data)
6499         (show_source_or_disasm_and_command): Update for bool change.
6500         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6501         (tui_win_info) <has_locator>: New method.
6502         (struct tui_source_window_base) <has_locator>: New method.
6503         (tui_win_has_locator): Don't declare.
6504         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6505         from tui_win_has_locator.
6506         (tui_source_window_base): Use false, not FALSE.
6507
6508 2019-06-25  Tom Tromey  <tom@tromey.com>
6509
6510         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6511         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6512         clear_detail method directly.
6513         (tui_clear_win_detail): Remove.
6514
6515 2019-06-25  Tom Tromey  <tom@tromey.com>
6516
6517         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6518         "this", not TUI_DISASM_WIN.
6519
6520 2019-06-25  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6523         declare.
6524         * tui/tui-winsource.c
6525         (tui_source_window_base::do_scroll_horizontal): Rename from
6526         tui_horizontal_source_scroll.
6527         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6528         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6529         from tui_vertical_data_scroll.
6530         * tui/tui-win.h (tui_scroll): Don't declare.
6531         * tui/tui-win.c (tui_win_info::forward_scroll)
6532         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6533         (tui_win_info::right_scroll): Rename and update.
6534         (tui_scroll_forward_command, tui_scroll_backward_command)
6535         (tui_scroll_left_command, tui_scroll_right_command): Update.
6536         (tui_scroll): Remove.
6537         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6538         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6539         from tui_vertical_source_scroll.
6540         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6541         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6542         from tui_vertical_disassem_scroll.
6543         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6544         do_scroll_horizontal>: New methods.
6545         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6546         Likewise.
6547         (struct tui_source_window_base): Add do_scroll_horizontal.
6548         (struct tui_source_window, struct tui_disasm_window): Add
6549         do_scroll_vertical.
6550         (struct tui_data_window, struct tui_cmd_window): Add
6551         do_scroll_horizontal and do_scroll_vertical.
6552         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6553
6554 2019-06-25  Tom Tromey  <tom@tromey.com>
6555
6556         * tui/tui-data.h (struct tui_source_window_base): New struct.
6557         (struct tui_source_window): Derive from tui_source_window_base.
6558         (struct tui_disasm_window): New struct.
6559         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6560         from tui_source_window::clear_detail.
6561         (tui_source_window_base): Rename from tui_source_window.
6562         (~tui_source_window_base): Rename from ~tui_source_window.
6563         (tui_alloc_win_info): Create a tui_disasm_window.
6564
6565 2019-06-25  Tom Tromey  <tom@tromey.com>
6566
6567         * tui/tui-data.h (struct tui_source_window)
6568         (struct tui_data_window): Declare destructors.
6569         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6570         destructors.
6571         (tui_win_info): Simplify.
6572
6573 2019-06-25  Tom Tromey  <tom@tromey.com>
6574
6575         * tui/tui-winsource.c (tui_display_main)
6576         (tui_update_source_windows_with_addr)
6577         (tui_update_all_breakpoint_info): Update.
6578         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6579         (new_height_ok, parse_scrolling_args): Update.
6580         * tui/tui-stack.c (tui_show_frame_info): Update.
6581         * tui/tui-data.h (struct tui_list): Remove.
6582         (tui_source_windows): Return a reference to a std::vector.
6583         * tui/tui-data.c (source_windows): Now a std::vector.
6584         (tui_source_windows): Change return type.
6585         (tui_clear_source_windows): Rewrite.
6586         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6587         (tui_free_all_source_wins_content): Rewrite.
6588
6589 2019-06-25  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6592         (struct tui_data_window, struct tui_cmd_window): Declare
6593         clear_detail method.
6594         * tui/tui-data.c (tui_source_window::clear_detail)
6595         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6596         methods.
6597         (tui_clear_win_detail): Simplify.
6598
6599 2019-06-25  Tom Tromey  <tom@tromey.com>
6600
6601         * tui/tui-layout.c (make_source_window, make_disasm_window)
6602         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6603         Return the new window.
6604         (show_source_disasm_command, show_data)
6605         (show_source_or_disasm_and_command): Update.
6606
6607 2019-06-25  Tom Tromey  <tom@tromey.com>
6608
6609         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6610         parameter.  Return the new window.
6611         (show_source_disasm_command): Update and remove NULL check.
6612         (show_source_or_disasm_and_command): Update.
6613
6614 2019-06-25  Tom Tromey  <tom@tromey.com>
6615
6616         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6617
6618 2019-06-25  Tom Tromey  <tom@tromey.com>
6619
6620         * tui/tui-data.h (struct tui_win_info): Make constructor
6621         protected.  Make destructor virtual.  Add initializers.
6622         (tui_source_window, tui_data_window, tui_cmd_window): New
6623         classes.
6624         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6625         constructor.  Add "type" parameter.
6626         (tui_source_window, tui_data_window, tui_cmd_window): New
6627         constructors.
6628         (tui_alloc_win_info): Instantiate the appropriate subclass.
6629
6630 2019-06-25  Tom Tromey  <tom@tromey.com>
6631
6632         * tui/tui-win.c (tui_resize_all): Use delete.
6633         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6634         destructor.
6635         (tui_free_window): Don't declare.
6636         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6637         Update.
6638
6639 2019-06-25  Tom Tromey  <tom@tromey.com>
6640
6641         * tui/tui-data.h (struct tui_win_info): Add constructor.
6642         * tui/tui-data.c (tui_alloc_win_info): Use new.
6643         (tui_free_window): Use delete.
6644
6645 2019-06-22  Tom Tromey  <tom@tromey.com>
6646
6647         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6648         declare.
6649         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6650
6651 2019-06-22  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6654         declare.
6655         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6656
6657 2019-06-22  Tom de Vries  <tdevries@suse.de>
6658
6659         * dwarf2read.c (create_addrmap_from_aranges)
6660         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6661         instead of '%zu'.
6662
6663 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6664
6665         * dwarf2read.h (dwarf2_section_info_def): Remove.
6666         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6667         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6668         std::vector<dwarf2_section_info>.
6669         (struct dwo_file) <~dwo_file>: Remove.
6670         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6671         types field.
6672         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6673         (dwarf2_read_debug_names): Likewise.
6674         (create_debug_types_hash_table): Change parameter type to
6675         array_view, adjust code accordingly.
6676         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6677         (partial_die_info::fixup): Likewise.
6678         (determine_prefix): Likewise.
6679         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6680
6681 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6682
6683         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6684         gdb_bfd_ref_ptr.
6685         <~dwo_file>: Remove call to gdb_bfd_unref.
6686         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6687         gdb_bfd_ref_ptr::get.
6688
6689 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6690
6691         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6692         type to htab_up.
6693         * dwarf2read.c (struct dwo_file): Initialize fields.
6694         <~dwo_file>: New.
6695         (free_dwo_file): Remove, move content to ~dwo_file.
6696         (struct dwo_file_deleter): Remove.
6697         (dwo_file_up>: Remove custom deleter.
6698         (free_dwo_files): Remove.
6699         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6700         dwo_files.
6701         (process_skeletonless_type_units): Call unique_ptr::get.
6702         (allocate_dwo_file_hash_table): Add deleter to created hash
6703         table.  Change return type to htab_up.
6704         (lookup_dwo_file_slot): Don't memset dwo_file, call
6705         unique_ptr::get.
6706         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6707         (create_dwo_unit_in_dwp_v2): Likewise.
6708         (open_and_init_dwo_file): Likewise.
6709         (free_dwo_file_from_slot): Remove.
6710
6711 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6712
6713         * dwarf2read.h (struct dwarf2_section_info) <readin,
6714         is_virtual>: Change type to bool.
6715         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6716         true instead of 1.
6717
6718 2019-06-19  Tom Tromey  <tom@tromey.com>
6719
6720         * tui/tui-data.h (tui_init_content_element): Don't declare.
6721
6722 2019-06-19  Tom Tromey  <tom@tromey.com>
6723
6724         * tui/tui-data.h (tui_init_win_info): Don't declare.
6725
6726 2019-06-19  Tom de Vries  <tdevries@suse.de>
6727
6728         * dwarf2read.h (abstract_to_concrete): Change type to
6729         std::unordered_map<sect_offset, std::vector<sect_offset>,
6730         gdb::hash_enum<sect_offset>>.
6731
6732 2019-06-19  Tom Tromey  <tromey@adacore.com>
6733
6734         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6735         EVAL_AVOID_SIDE_EFFECTS specially.
6736
6737 2019-06-19  Tom Tromey  <tromey@adacore.com>
6738
6739         * source-cache.c (highlighter): New global.
6740         (source_cache::get_source_lines): Create a highlighter on demand.
6741
6742 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6743
6744         * defs.h (deprecated_interactive_hook): Delete declaration.
6745         * interps.c (clear_interpreter_hooks): Remove use of
6746         deprecated_interactive_hook.
6747         * top.c (deprecated_interactive_hook): Delete definition.
6748         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6749
6750 2019-06-18  Tom de Vries  <tdevries@suse.de>
6751
6752         PR gdb/24515
6753         * dwarf2read.h (abstract_to_concrete): Change type from
6754         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6755         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6756         * dwarf2read.c (read_variable): Update.
6757         (dwarf2_fetch_die_loc_sect_off): Update.
6758
6759 2019-06-17  Tom de Vries  <tdevries@suse.de>
6760
6761         PR gdb/24617
6762         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6763         accessing parent[parent_len - 1].
6764
6765 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6766
6767         PR gdb/24364
6768         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6769         call dtrace_process_dof with NULL dof.
6770
6771 2019-06-16  Tom de Vries  <tdevries@suse.de>
6772
6773         PR gdb/24445
6774         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6775
6776 2019-06-16  Tom Tromey  <tom@tromey.com>
6777
6778         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6779         (make_all_visible): Use address of member.
6780
6781 2019-06-16  Tom Tromey  <tom@tromey.com>
6782
6783         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6784         (tui_free_window, free_content, free_content_elements): Remove
6785         unnecessary cast.
6786         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6787         cast.
6788         * tui/tui-regs.c (tui_show_register_group)
6789         (tui_display_registers_from, tui_display_reg_element_at_line):
6790         Remove unnecessary cast.
6791
6792 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6793
6794         * linux-nat.c (normal_mask): Delete.
6795         (_initialize_linux_nat): Don't initialise normal_mask.
6796
6797 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6798
6799         PR gdb/24445
6800         * dwarf-index-write.h (write_psymtabs_to_index): Add
6801         dwz_basename parameter.
6802         * dwarf-index-write.c (write_gdbindex): Move file writing to
6803         write_gdbindex_1.  Change return type void.
6804         (assert_file_size): Move up, remove filename parameter.
6805         (write_gdbindex_1): New function.
6806         (write_debug_names): Change return type to void, call
6807         assert_file_size.
6808         (struct index_wip_file): New struct.
6809         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6810         file logic to index_wip_file.  Write index for dwz file if
6811         needed.
6812         (save_gdb_index_command): Pass basename of dwz file, if present.
6813         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6814         build-id of dwz file, if present.
6815         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6816         (dwarf2_get_dwz_file): Likewise.
6817         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6818         (dwarf2_get_dwz_file): Likewise.
6819
6820 2019-06-16  Tom Tromey  <tom@tromey.com>
6821
6822         * coffread.c (process_coff_symbol): Use xstrdup.
6823         * value.c (create_internalvar): Use xstrdup.
6824
6825 2019-06-16  Tom Tromey  <tom@tromey.com>
6826
6827         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6828         * breakpoint.c (stopin_command, stopat_command)
6829         (until_break_command, decode_location_default): Remove unnecessary
6830         cast.
6831         * utils.c (subset_compare): Remove unnecessary cast.
6832         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6833         cast.
6834         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6835         cast.
6836         * infcmd.c (path_command): Remove unnecessary cast.
6837         * coffread.c (decode_type): Remove unnecessary cast.
6838         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6839         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6840         * tui/tui-stack.c (tui_show_locator_content)
6841         (tui_show_frame_info): Remove unnecessary cast.
6842         * tui/tui-win.c (tui_scroll_forward_command)
6843         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6844         (parse_scrolling_args): Remove unnecessary cast.
6845         * tui/tui-data.c (init_win_info, tui_del_window)
6846         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6847         (free_content_elements): Remove unnecessary cast.
6848         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6849         unnecessary cast.
6850         * tui/tui-source.c (tui_set_source_content)
6851         (tui_vertical_source_scroll): Remove unnecessary cast.
6852         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6853         cast.
6854         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6855         * tui/tui-regs.c (tui_display_registers_from)
6856         (tui_display_register): Remove unnecessary cast.
6857         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6858         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6859         (make_visible): Remove unnecessary cast.
6860         * tui/tui-winsource.c (tui_erase_source_content)
6861         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6862         unnecessary cast.
6863         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6864         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6865         * stabsread.c (read_type, read_array_type, read_range_type):
6866         Remove unnecessary cast.
6867         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6868         (parse_symbol, parse_type, upgrade_type, parse_external)
6869         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6870         unnecessary cast.
6871         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6872
6873 2019-06-16  Tom Tromey  <tom@tromey.com>
6874
6875         * tui/tui-data.c (tui_alloc_generic_win_info)
6876         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6877         checks.
6878
6879 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6880             Andrew Burgess  <andrew.burgess@embecosm.com>
6881
6882         * f-typeprint.c (f_print_type): Don't return early for not
6883         associated or not allocated types.
6884         (f_type_print_varspec_suffix): Add print_rank parameter and print
6885         ranks of array types in case they dangling.
6886         (f_type_print_base): Add print_rank parameter.
6887
6888 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6889
6890         * NEWS: Mention new MI commands.
6891         * break-catch-throw.c (enum exception_event_kind): Move to
6892         breakpoint.h.
6893         (print_mention_exception_catchpoint): Output text as a single
6894         message.
6895         (catch_exception_command_1): Rename to...
6896         (catch_exception_event): ...this, make non-static, update header
6897         command, and change some parameter types.
6898         (catch_catch_command): Update for changes to
6899         catch_exception_command_1.
6900         (catch_throw_command): Likewise.
6901         (catch_rethrow_command): Likewise.
6902         * breakpoint.c (enum exception_event_kind): Delete.
6903         * breakpoint.h (enum exception_event_kind): Moved here from
6904         break-catch-throw.c.
6905         (catch_exception_event): Declare.
6906         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6907         (mi_cmd_catch_throw): New function.
6908         (mi_cmd_catch_rethrow): New function.
6909         (mi_cmd_catch_catch): New function.
6910         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6911         'catch-catch' entries.
6912         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6913         (mi_cmd_catch_rethrow): Declare.
6914         (mi_cmd_catch_catch): Declare.
6915
6916 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6917
6918         * annotate.c (annotate_source_line): Change return type to void,
6919         update implementation to match.
6920         * annotate.h (annotate_source_line): Change return type to void,
6921         update header comment.
6922         * stack.c (print_frame_info): Don't change what frame information
6923         is printed based on whether annotations are on or not.
6924
6925 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6928         (annotate_source): Make static.
6929         (annotate_source_line): Moved from source.c and renamed from
6930         identify_source_line.  Update the return type.
6931         * annotate.h (annotate_source): Delete declaration.
6932         (annotate_source_line): Declaration moved from source.h, and
6933         renamed from identify_source_line.  Return type updated.
6934         * source.c (identify_source_line): Moved to annotate.c and renamed
6935         to annotate_source_line.
6936         (info_line_command): Remove check of annotation_level.
6937         * source.h (identify_source_line): Move declaration to annotate.h
6938         and rename to annotate_source_line.
6939         * stack.c: Add 'annotate.h' include.
6940         (print_frame_info): Remove check of annotation_level before
6941         calling annotate_source_line.
6942
6943 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6944
6945         * source-cache.c (source_cache::get_plain_source_lines): Use
6946         open_source_file_with_line_charpos instead of just
6947         open_source_file, remove call to find_source_lines.
6948         (source_cache::get_source_lines): Likewise.
6949         * source.c (find_source_lines): Make static.
6950         (get_filename_and_charpos): Renamed into...
6951         (open_source_file_with_line_charpos): ..this along with changes to
6952         return a scoped_fd, and some other minor clean ups.
6953         (identify_source_line): Use open_source_file_with_line_charpos.
6954         (search_command_helper): Use open_source_file_with_line_charpos
6955         instead of just open_source_file, remove call to
6956         find_source_lines.
6957         * source.h (open_source_file_with_line_charpos): Declare new
6958         function.
6959         (find_source_lines): Delete declaration.
6960
6961 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6962
6963         * source.c (get_filename_and_charpos): Remove fullname
6964         parameter.
6965         (identify_source_line): Update call to get_filename_and_charpos.
6966
6967 2019-06-14  Tom Tromey  <tromey@adacore.com>
6968
6969         PR gdb/24502:
6970         * ui-style.h (skip_ansi_escape): Update comment.
6971         * ui-file.h (class no_terminal_escape_file): New class.
6972         * ui-file.c (no_terminal_escape_file::write)
6973         (no_terminal_escape_file::puts): New methods.
6974         * cli/cli-logging.c (handle_redirections): Use
6975         no_terminal_escape_file.
6976
6977 2019-06-14  Tom Tromey  <tromey@adacore.com>
6978
6979         * NEWS: Move convenience variable news above Python news.
6980
6981 2019-06-14  Tom Tromey  <tom@tromey.com>
6982
6983         * gnulib: Move directory to top-level.
6984         * configure.ac: Don't configure gnulib.
6985         * configure: Rebuild.
6986         * common/common-defs.h: Use new path to gnulib.
6987         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6988         (GNULIB_H): Remove.
6989         (INCGNU): Look in new gnulib location.
6990         (HFILES_NO_SRCDIR): Remove gnulib files.
6991         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6992         (generated_files): Remove GNULIB_H.
6993         ($(LIBGNU), all-lib): Remove targets.
6994         (distclean): Don't mention GNULIB_BUILDDIR.
6995         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6996
6997 2019-06-14  Tom Tromey  <tromey@adacore.com>
6998
6999         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7000         Warn if symbol file does not provide any symbols.
7001
7002 2019-06-14  Tom Tromey  <tromey@adacore.com>
7003
7004         * source.c (find_and_open_source): Respect basenames_may_differ.
7005
7006 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7007
7008         * annotate.c (annotate_breakpoints_invalid): Make use of
7009         scoped_restore_terminal_state.
7010         (annotate_frames_invalid): Likewise.
7011
7012 2019-06-14  Tom Tromey  <tromey@adacore.com>
7013
7014         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7015         allow assignment to an internalvar.
7016
7017 2019-06-14  Tom Tromey  <tromey@adacore.com>
7018
7019         * ada-lex.l: Allow "_" in attribute names.
7020
7021 2019-06-14  Tom Tromey  <tromey@adacore.com>
7022
7023         PR gdb/24653:
7024         * regcache.c (registers_changed): Don't call alloca.
7025         * top.c (execute_command): Don't call alloca.
7026
7027 2019-06-13  Pedro Alves  <palves@redhat.com>
7028
7029         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7030         'expression'.  When parsing an expression, error out if there's
7031         junk after "unlimited".
7032         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7033         (do_set_command): Adjust calls to is_unlimited_literal.
7034
7035 2019-06-13  Pedro Alves  <palves@redhat.com>
7036
7037         * compile/compile.c (make_compile_options_def_group): Add braces
7038         around array_view initializer.
7039         * thread.c (make_thread_apply_all_options_def_group)
7040         (make_thread_apply_all_options_def_group): Likewise.
7041
7042 2019-06-13  Pedro Alves  <palves@redhat.com>
7043
7044         * NEWS (New commands): Mention "maint test-options
7045         require-delimiter", "maint test-options unknown-is-error", "maint
7046         test-options unknown-is-operand" and "maint show
7047         test-options-completion-result".
7048         (New command options, command completion): New section.
7049         (Completion improvements): New section.
7050         Mention that you can abbreviate "unlimited".
7051
7052 2019-06-13  Pedro Alves  <palves@redhat.com>
7053
7054         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7055         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7056         * unittests/cli-utils-selftests.c (test_parse_flags)
7057         (test_parse_flags_qcs): Delete.
7058         (test_cli_utils): Don't call deleted functions.
7059
7060 2019-06-13  Pedro Alves  <palves@redhat.com>
7061
7062         * thread.c: Include "cli/cli-option.h".
7063         (tp_array_compar_ascending): Global.
7064         (tp_array_compar): Delete function.
7065         (tp_array_compar_ascending, tp_array_compar_descending): New
7066         functions.
7067         (ascending_option_def, qcs_flag_option_def)
7068         (thr_qcs_flags_option_defs)
7069         (make_thread_apply_all_options_def_group)
7070         (make_thread_apply_options_def_group): New.
7071         (thread_apply_all_command): Use gdb::option::process_options.
7072         (thread_apply_command_completer)
7073         (thread_apply_all_command_completer): New.
7074         (thread_apply_command): Use gdb::option::process_options.
7075         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7076         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7077         to generate help text of "thread apply".  Adjust "taas"'s help.
7078         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7079         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7080
7081 2019-06-13  Pedro Alves  <palves@redhat.com>
7082
7083         * thread.c (thread_apply_command): Check for invalid TID with
7084         isdigit instead of !isalpha.
7085
7086 2019-06-13  Pedro Alves  <palves@redhat.com>
7087
7088         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7089         (validate_flags_qcs): New.
7090         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7091         (validate_flags_qcs): Declare.
7092         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7093         (make_frame_apply_options_def_group): New.
7094         (frame_apply_command_count): Process options with
7095         gdb::option::process_options.
7096         (frame_apply_completer): New.
7097         (frame_apply_level_completer, frame_apply_all_completer)
7098         (frame_apply_completer): New.
7099         (_initialize_stack): Update help of "frame apply", "frame apply
7100         level", "frame apply all" and "faas" to mention supported options
7101         and install command completers.
7102         * stack.h (frame_apply_all_completer): Declare.
7103         * thread.c: Include "stack.h".
7104         (tfaas_command): Add "--".
7105         (_initialize_thread): Update help "tfaas" to mention supported
7106         options and install command completer.
7107
7108 2019-06-13  Pedro Alves  <palves@redhat.com>
7109
7110         * completer.c (complete_nested_command_line): New.
7111         (gdb_completion_word_break_characters_throw): Add assertion.
7112         * completer.h (complete_nested_command_line): Declare.
7113
7114 2019-06-13  Pedro Alves  <palves@redhat.com>
7115
7116         * stack.c (parse_backtrace_qualifiers): New.
7117         (backtrace_command): Use it.
7118         (backtrace_command_completer): Complete on qualifiers.
7119
7120 2019-06-13  Pedro Alves  <palves@redhat.com>
7121
7122         * frame.c: Include "cli/cli-option.h.
7123         (user_set_backtrace_options): New.
7124         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7125         Delete.
7126         (get_prev_frame): Adjust.
7127         (boolean_option_def, uinteger_option_def)
7128         (set_backtrace_option_defs): New.
7129         (_initialize_frame): Adjust and use
7130         gdb::option::add_setshow_cmds_for_options to install "set
7131         backtrace past-main" and "set backtrace past-entry".
7132         * frame.h: Include "cli/cli-option.h".
7133         (struct frame_print_options): Forward declare.
7134         (print_frame_arguments_all, print_frame_arguments_scalars)
7135         (print_frame_arguments_none): Declare.
7136         (print_entry_values): Delete declaration.
7137         (struct frame_print_options, user_frame_print_options): New.
7138         (struct set_backtrace_options): New.
7139         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7140         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7141         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7142         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7143         (list_args_or_locals): Add frame_print_options parameter.
7144         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7145         * python/py-framefilter.c (enumerate_args): Pass down
7146         USER_FRAME_PRINT_OPTIONS.
7147         * stack.c: Include "cli/cli-option.h".
7148         (print_frame_arguments_all, print_frame_arguments_scalars)
7149         (print_frame_arguments_none): Declare.
7150         (print_raw_frame_arguments, print_entry_values): Delete.
7151         (user_frame_print_options): New.
7152         (boolean_option_def, enum_option_def, frame_print_option_defs):
7153         New.
7154         (struct backtrace_cmd_options): New.
7155         (bt_flag_option_def): New.
7156         (backtrace_command_option_defs): New.
7157         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7158         (print_frame_arg, read_frame_arg, print_frame_args)
7159         (print_frame_info, print_frame): Add frame_print_options parameter
7160         and use it.
7161         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7162         (backtrace_command_1): Add frame_print_options and
7163         backtrace_cmd_options parameters and use them.
7164         (make_backtrace_options_def_group): New.
7165         (backtrace_command): Process command options with
7166         gdb::option::process_options.
7167         (backtrace_command_completer): New.
7168         (_initialize_stack): Extend "backtrace"'s help to mention
7169         supported options.  Install completer for "backtrace".
7170         Install some settings commands with add_setshow_cmds_for_options.
7171
7172 2019-06-13  Pedro Alves  <palves@redhat.com>
7173
7174         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7175         and that "set/show print raw frame-arguments" are now deprecated.
7176
7177         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7178         command.
7179         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7180         * stack.c (_initialize_stack): Install "set/show print
7181         raw-frame-arguments", and deprecate "set/show print raw
7182         frame-arguments".
7183         * valprint.c (_initialize_valprint): Deprecate "set/show print
7184         raw".
7185
7186 2019-06-13  Pedro Alves  <palves@redhat.com>
7187
7188         * compile/compile.c (struct compile_options): New.
7189         (compile_flag_option_def, compile_command_option_defs)
7190         (make_compile_options_def_group): New.
7191         (compile_file_command): Handle options with
7192         gdb::option::process_options.
7193         (compile_file_command_completer): New function.
7194         (compile_code_command): Handle options with
7195         gdb::option::process_options.
7196         (compile_code_command_completer): New function.
7197         (_initialize_compiler): Install completers for "compile code" and
7198         "compile file".  Mention available options in "compile code" and
7199         "compile code"'s help.
7200         * completer.c (advance_to_completion_word): New, factored out from
7201         ...
7202         (advance_to_expression_complete_word_point): ... this.
7203         (advance_to_filename_complete_word_point): New.
7204         * completer.h (advance_to_filename_complete_word_point): New
7205         declaration.
7206
7207 2019-06-13  Pedro Alves  <palves@redhat.com>
7208
7209         * compile/compile.c: Include "cli/cli-option.h".
7210         (compile_print_value): Scope data pointer is now a
7211         value_print_options pointer; adjust.
7212         (compile_print_command): Process options.  Scope data pointer is
7213         now a value_print_options pointer; adjust.
7214         (_initialize_compile): Update "compile print"'s help to include
7215         supported options.  Install a completer for "compile print".
7216         * cp-valprint.c (show_vtblprint, show_objectprint)
7217         (show_static_field_print): Delete.
7218         (_initialize_cp_valprint): Don't install "set print
7219         static-members", "set print vtbl", "set print object" here.
7220         * printcmd.c: Include "cli/cli-option.h" and
7221         "common/gdb_optional.h".
7222         (print_command_parse_format): Rework to fill in a
7223         value_print_options instead of a format_data.
7224         (print_value): Change parameter type from format_data pointer to
7225         value_print_options reference.  Adjust.
7226         (print_command_1): Process options.  Adjust to pass down a
7227         value_print_options.
7228         (print_command_completer): New.
7229         (_initialize_printcmd): Install print_command_completer as
7230         handle_brkchars completer for the "print" command.  Update
7231         "print"'s help to include supported options.
7232         * valprint.c: Include "cli/cli-option.h".
7233         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7234         here from cp-valprint.c.
7235         (boolean_option_def, uinteger_option_def)
7236         (value_print_option_defs, make_value_print_options_def_group):
7237         New.  Use gdb::option::add_setshow_cmds_for_options to install
7238         "set print elements", "set print null-stop", "set print repeats",
7239         "set print pretty", "set print union", "set print array", "set
7240         print address", "set print symbol", "set print array-indexes".
7241         * valprint.h: Include <string> and "cli/cli-option.h".
7242         (make_value_print_options_def_group): Declare.
7243         (print_value): Change parameter type from format_data pointer to
7244         value_print_options reference.
7245         (print_command_completer): Declare.
7246
7247 2019-06-13  Pedro Alves  <palves@redhat.com>
7248
7249         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7250         (COMMON_SFILES): Add maint-test-settings.c.
7251         * cli/cli-decode.c (boolean_enums): New global, factored out from
7252         ...
7253         (add_setshow_boolean_cmd): ... here.
7254         * cli/cli-decode.h (boolean_enums): Declare.
7255         * cli/cli-option.c: New file.
7256         * cli/cli-option.h: New file.
7257         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7258         factored out from ...
7259         (parse_cli_boolean_value(const char *)): ... this.
7260         (is_unlimited_literal): Change parameter type to pointer to
7261         pointer.  Adjust and advance ARG pointer.
7262         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7263         (parse_cli_var_enum): New, factored out from ...
7264         (do_set_command): ... this.  Adjust.
7265         * cli/cli-setshow.h (parse_cli_boolean_value)
7266         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7267         (parse_cli_var_enum): Declare.
7268         * cli/cli-utils.c: Include "cli/cli-option.h".
7269         (get_ulongest): New.
7270         * cli/cli-utils.h (get_ulongest): Declare.
7271         (check_for_argument): New overloads.
7272         * maint-test-options.c: New file.
7273
7274 2019-06-13  Pedro Alves  <palves@redhat.com>
7275
7276         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7277         parse a range if "-" is at the end of the string.
7278
7279 2019-06-13  Pedro Alves  <palves@redhat.com>
7280
7281         * cli/cli-setshow.c (parse_auto_binary_operation)
7282         (parse_cli_boolean_value): Don't allow "o".
7283
7284 2019-06-13  Pedro Alves  <palves@redhat.com>
7285
7286         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7287         * NEWS: Mention maint test-settings KIND.
7288         * maint-test-settings.c: New file.
7289
7290 2019-06-13  Pedro Alves  <palves@redhat.com>
7291
7292         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7293         completer.
7294         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7295         "set" completers.
7296
7297 2019-06-13  Pedro Alves  <palves@redhat.com>
7298
7299         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7300         after item.
7301
7302 2019-06-13  Pedro Alves  <palves@redhat.com>
7303
7304         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7305
7306 2019-06-13  Pedro Alves <palves@redhat.com>
7307
7308         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7309         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7310         call.
7311         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7312         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7313         calls.
7314         (check_for_argument): Skip spaces after argument.
7315
7316 2019-06-13  Pedro Alves  <palves@redhat.com>
7317
7318         * thread.c (thread_apply_command): Adjust TID parsing.
7319         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7320         detected before end of string.
7321         (tid_is_in_list): Error out if LIST is invalid.
7322
7323 2019-06-13  Pedro Alves  <palves@redhat.com>
7324
7325         * completer.c (complete_line_internal_1): Rewind completion word
7326         point.
7327         (completion_tracker::advance_custom_word_point_by): Change
7328         parameter type to int.
7329         * completer.h (completion_tracker::advance_custom_word_point_by):
7330         Likewise.
7331
7332 2019-06-13  Pedro Alves  <palves@redhat.com>
7333
7334         * completer.c (advance_to_completion_word): Handle delimiters.
7335
7336 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7337
7338         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7339
7340 2019-06-11  Tom Tromey  <tom@tromey.com>
7341
7342         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7343         (xmalloc_failed): Move to alloc.c.
7344         * alloc.c: New file.
7345         * Makefile.in (COMMON_SFILES): Add alloc.c.
7346
7347 2019-06-11  Tom Tromey  <tom@tromey.com>
7348
7349         * nat/linux-waitpid.c: Don't include server.h.
7350         (linux_debug): Remove.
7351         (my_waitpid): Update.
7352
7353 2019-06-11  Tom Tromey  <tromey@adacore.com>
7354
7355         * infcall.c (_initialize_infcall): Remove trailing newline from
7356         help.
7357         * user-regs.c (_initialize_user_regs): Remove trailing newline
7358         from help.
7359         * typeprint.c (_initialize_typeprint): Remove trailing newline
7360         from help.
7361         * reverse.c (_initialize_reverse): Remove trailing newlines from
7362         help.
7363         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7364         from help.
7365         * language.c (add_set_language_command): Remove trailing newline
7366         from help.
7367         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7368         help.
7369         * disasm.c (_initialize_disasm): Remove trailing newline from
7370         help.
7371         * top.c (init_main): Remove trailing newline from help.
7372         * interps.c (_initialize_interpreter): Remove trailing newline
7373         from help.
7374         * btrace.c (_initialize_btrace): Remove trailing newlines from
7375         help.
7376         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7377         from help.
7378         * python/python.c (_initialize_python): Remove trailing newline
7379         from help.
7380         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7381         help.
7382         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7383         from help.  Reformat some text.
7384         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7385         from help.
7386         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7387         newline from help.
7388
7389 2019-06-11  Tom Tromey  <tromey@adacore.com>
7390
7391         * darwin-nat.c (darwin_decode_exception_message)
7392         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7393
7394 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7395
7396         * valops.c (value_slice): Check for not allocated or not
7397         associated values.
7398
7399 2019-06-10  Tom de Vries  <tdevries@suse.de>
7400
7401         PR gdb/24618
7402         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7403         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7404         invalid.
7405
7406 2019-06-10  Tom de Vries  <tdevries@suse.de>
7407
7408         PR gdb/24611
7409         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7410         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7411
7412 2019-06-10  Tom de Vries  <tdevries@suse.de>
7413
7414         PR symtab/24545
7415         * symtab.c (struct demangled_name_entry): Add language field.
7416         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7417         static minimal symbol".  Set and use language field.
7418
7419 2019-06-10  Tom Tromey  <tromey@adacore.com>
7420
7421         * ada-lang.c (_initialize_ada_language): Update help text.
7422
7423 2019-06-10  Tom Tromey  <tromey@adacore.com>
7424
7425         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7426         with a newline.
7427         * guile/guile.c (handle_boot_error): Don't end warning with a
7428         newline.
7429         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7430         warning with a newline.
7431         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7432         newline.
7433         (s12z_frame_cache): Likewise.
7434         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7435         a newline.
7436         * solib-svr4.c (disable_probes_interface): Don't end warning with
7437         a newline.
7438         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7439         newline.
7440         * python/python.c (do_finish_initialization): Don't end warning
7441         with a newline.
7442
7443 2019-06-10  Tom Tromey  <tom@tromey.com>
7444
7445         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7446         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7447         gdbpy_enter.
7448
7449 2019-06-10  Tom Tromey  <tromey@adacore.com>
7450
7451         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7452         data.
7453         (elf_new_init): Don't call stabsread_new_init.
7454         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7455         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7456         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7457
7458 2019-06-10  Tom de Vries  <tdevries@suse.de>
7459
7460         PR symtab/16264
7461         PR symtab/24517
7462         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7463
7464 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7465
7466         * source.c (find_and_open_source): Also rewrite relative file
7467         names.
7468
7469 2019-04-26  Amos Bird  <amosbird@gmail.com>
7470
7471         * annotate.c (annotate_thread_exited): Add "thread-exited"
7472         annotation.
7473
7474 2019-06-06  Tom Tromey  <tromey@adacore.com>
7475
7476         * maint.h (class scoped_command_stats): Use
7477         DISABLE_COPY_AND_ASSIGN.
7478         <print_time>: New method.
7479         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7480         print_time.
7481         (scoped_command_stats::print_time): New method.
7482
7483 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7486         instructions of lengths 6 or 8 bytes.
7487
7488 2019-06-04  Pedro Alves  <palves@redhat.com>
7489
7490         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7491
7492         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7493         * breakpoint.c (condition_completer): Likewise.
7494         * cli/cli-dump.c (scan_expression): Likewise.
7495         * common/filestuff.c (mkdir_recursive): Likewise.
7496         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7497         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7498         (gdb_abspath): Likewise.
7499         * compile/compile-cplus-types.c
7500         (compile_cplus_instance::decl_name): Likewise.
7501         * completer.c (complete_explicit_location):
7502         (signal_completer, reg_or_group_completer_1): Likewise.
7503         * cp-support.c (cp_remove_params_if_any): Likewise.
7504         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7505         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7506         * infcmd.c (strip_bg_char): Likewise.
7507         * linespec.c (copy_token_string): Likewise.
7508         * mi/mi-main.c (output_cores): Likewise.
7509         * psymtab.c (psymtab_search_name):
7510         * symfile.c (test_set_ext_lang_command): Likewise.
7511         * target.c (target_fileio_read_stralloc): Likewise.
7512         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7513         * value.c (complete_internalvar): Likewise.
7514
7515 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7516
7517         Add objfile property to gdb.Type.
7518         * NEWS: Mention Python API addition.
7519         * python/py-type.c (typy_get_objfile): New method.
7520
7521 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7522
7523         * NEWS: Mention the new set|show style [title|highlight].
7524         Mention changes to "show style", "help" and "apropos".
7525
7526 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7527
7528         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7529         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7530         instead of print_help_for_command.
7531         (print_doc_of_command): New function.
7532         (help_list): Add 'apropos -v word' suggestion.
7533         (print_help_for_command): Style the command name using title style.
7534         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7535         (_initialize_cli_cmds): Describe -v in apropos_command help.
7536
7537 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7538
7539         * cli/cli-style.h (cli_style_option): Add name in constructor,
7540         add m_name class member, add constructor with intensity,
7541         add name class function.
7542         (cli_style_option::add_setshow_commands): Remove name argument.
7543         (highlight_style, title_style): New styles.
7544         * cli/cli-style.c (do_show): New function that shows a style
7545         characteristic styling the style name with itself.
7546         (set_style_name): New function.
7547         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7548         Update all callers according to the changes in cli/cli-style.h.
7549         * utils.h (fputs_highlighted): New function.
7550         * utils.c (fputs_highlighted): Likewise.
7551
7552 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7553
7554         * NEWS: Mention new pipe command and new convenience variables.
7555
7556 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7557
7558         * cli/cli-cmds.c (pipe_command): New function.
7559         (_initialize_cli_cmds): Call add_com for pipe_command.
7560         Define | as an alias for pipe.
7561         (exit_status_set_internal_vars): New function.
7562         (shell_escape): Call exit_status_set_internal_vars.
7563         cli/cli-decode.c (find_command_name_length): Recognize | as
7564         a single character command.
7565
7566 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7567
7568         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7569         top.c (execute_command_to_ui_file): New function, mostly a copy
7570         of execute_command_to_string.
7571         (execute_command_to_string): Implement by calling
7572         execute_command_to_ui_file.
7573
7574 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7575
7576         * top.h (saved_command_line): Remove declaration.
7577         * top.c (previous_saved_command_line, previous_repeat_arguments):
7578         New variables.
7579         (saved_command_line): Make static, define together with other
7580         'repeat variables'.
7581         (dont_repeat): Clear repeat_arguments.
7582         (repeat_previous, get_saved_command_line, save_command_line):
7583         New functions.
7584         (gdb_init): Initialize saved_command_line
7585         and previous_saved_command_line.
7586         * main.c (captured_main_1): Remove saved_command_line initialization.
7587         * event-top.c (handle_line_of_input): Update to use
7588         the new 'repeat' related functions instead of direct access to
7589         saved_command_line.
7590         * command.h (repeat_previous, get_saved_command_line,
7591         save_command_line): New declarations.
7592         (dont_repeat): Add comment.
7593
7594 2019-05-30  Tom Tromey  <tromey@adacore.com>
7595
7596         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7597         Fix comment.
7598         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7599
7600 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7601
7602         PR cli/24587
7603         * completer.c (complete): Initialize variable word.
7604
7605 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7606
7607         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7608         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7609         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7610         'body' is NULL to the outter 'if', protecting the '!is_define'
7611         situation as well.
7612
7613 2019-05-29  Tom Tromey  <tromey@adacore.com>
7614
7615         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7616         (dwarf_unknown): New function.
7617         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7618         (dwarf_type_encoding_name): Use dwarf_unknown.
7619
7620 2019-05-29  Tom Tromey  <tromey@adacore.com>
7621
7622         PR c++/20020:
7623         * cp-valprint.c (cp_print_value_fields): Call
7624         cp_print_static_field inside "try".
7625
7626 2019-05-29  Tom Tromey  <tromey@adacore.com>
7627
7628         * inflow.c (struct terminal_info): Add default operator=.
7629         * configure: Rebuild.
7630         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7631         -Wdeprecated-copy-dtor, -Wredundant-move.
7632
7633 2019-05-29  Tom Tromey  <tromey@adacore.com>
7634
7635         * NEWS: Add entry.
7636         * infcmd.c (print_return_value_1): Handle finish_print
7637         option.
7638         (show_print_finish): New function.
7639         (_initialize_infcmd): Add "set/show print finish" commands.
7640         * valprint.c (user_print_options): Initialize new member.
7641         * valprint.h (struct value_print_options) <finish_print>: New
7642         member.
7643
7644 2019-05-28  Tom Tromey  <tromey@adacore.com>
7645
7646         * ada-lang.c (ada_remove_Xbn_suffix)
7647         (find_old_style_renaming_symbol)
7648         (parse_old_style_renaming): Remove.
7649         (ada_find_renaming_symbol): Don't call
7650         find_old_style_renaming_symbol.
7651         (ada_is_renaming_symbol): Rename from
7652         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7653         bool.  Now static.
7654         (ada_read_var_value): Update and simplify.
7655         * ada-exp.y (write_var_or_type): Remove old code.
7656
7657 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7658
7659         PR gdb/25010
7660         * event-top.c: Remove include comment.
7661         * inflow.c (class scoped_ignore_sigttou): Move from here...
7662         * inflow.h (class scoped_ignore_sigttou): ...to here.
7663         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7664         * top.c:  Remove include comment.
7665
7666 2019-05-27  Tom Tromey  <tom@tromey.com>
7667
7668         * NEWS: Fix typo.
7669
7670 2019-05-22  Tom Tromey  <tromey@adacore.com>
7671
7672         * target.c (target_follow_exec): Constify parameter.
7673         * target-delegates.c: Rebuild.
7674         * remote.c (remote_target::follow_exec): Constify parameter.
7675         * infrun.c (follow_exec): Constify parameter.
7676         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7677         (target_follow_exec): Likewise.
7678
7679 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7680
7681         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7682         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7683
7684 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7685
7686         * NEWS: Add debugredirect and testsuite sections.
7687
7688 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7689
7690         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7691         target descriptions using exclusively floating point register name
7692         aliases.
7693
7694 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         PR gdb/18644:
7697         * f-lang.c (build_fortran_types): Handle the case where
7698         gdbarch_floatformat_for_type returns a nullptr.
7699
7700 2019-05-21  Tom de Vries  <tdevries@suse.de>
7701
7702         PR cli/24587
7703         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7704
7705 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7706
7707         PR gdb/18644:
7708         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7709         16-byte floats.
7710         * i386-tdep.c (i386_floatformat_for_type): Use
7711         floatformats_ia64_quad for the 16-byte floating point component
7712         within a fortran 32-byte complex number.
7713
7714 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7715
7716         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7717         delete default constructor.
7718         (find_partial_die): Update to return const struct.
7719         (partial_die_parent_scope): Move variable declaration into scope
7720         of its use and change its type to auto.
7721         (guess_partial_die_structure_name): Likewise.
7722         (partial_die_info::fixup): Likewise.
7723
7724 2019-05-17  Tom Tromey  <tromey@adacore.com>
7725
7726         * source.c (find_and_open_source): Remove cast.
7727
7728 2019-05-17  Tom Tromey  <tromey@adacore.com>
7729
7730         * annotate.c (annotate_source): Make "filename" const.
7731         * annotate.h (annotate_source): Use const.
7732
7733 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7734
7735         * disasm.c (set_disassembler_options): Send errors to stderr.
7736
7737 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7738
7739         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7740         (cli_interp_base::set_logging): Check debug_redirect.
7741         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7742         * cli/cli-logging.c (debug_redirect): Add static variable.
7743         (pop_output_files): Add default param.
7744         (handle_redirections): Print debug setting.
7745         (show_logging_command): Likewise.
7746         (_initialize_cli_logging): Add debugredirect command.
7747         * interps.c (current_interp_set_logging): Add debug_redirect
7748         parameter.
7749         * interps.h (set_logging): Add debug_redirect parameter.
7750         (current_interp_set_logging): Likewise.
7751         * mi/mi-common.h: Likewise.
7752         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7753
7754 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7755             Tom Tromey  <tromey@adacore.com>
7756
7757         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7758         directly.
7759         * cli/cli-interp.h (make_logging_output): Remove declaration.
7760         * cli/cli-logging.c (make_logging_output): Remove function.
7761         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7762         directly.
7763         * ui-file.c (tee_file::tee_file): Remove bools.
7764         (tee_file::~tee_file): Remove deletes.
7765         * ui-file.h (tee_file): Remove bools.
7766
7767 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7768
7769         * mi/mi-cmds.h (mi_cmd_complete): New function.
7770         * mi/mi-main.c (mi_cmd_complete): Likewise.
7771         * mi/mi-cmds.c: Define new MI command -complete.
7772         * NEWS: Mention new -complete command.
7773
7774 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7775
7776         * completer.h (complete): New function.
7777         * completer.c (complete): Likewise.
7778         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7779         function defined in completer.h.
7780
7781 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7782
7783         * MAINTAINERS (Write After Approval): Add myself.
7784
7785 2019-05-17  Tom de Vries  <tdevries@suse.de>
7786
7787         PR gdb/24094
7788         * dwarf2read.c (struct cu_partial_die_info): New struct.
7789         (find_partial_die): Return cu_partial_die_info.
7790         (partial_die_parent_scope, guess_partial_die_structure_name)
7791         (partial_die_info::fixup): Handle new return type of find_partial_die.
7792
7793 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7794
7795         PR breakpoints/24541
7796         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7797         "std::string", simplifying the algorithm.
7798
7799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7800
7801         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7802         (stap_static_probe_ops::get_probes): Likewise.
7803
7804 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7805
7806         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7807         '-')" and "else if".
7808         (stap_parse_single_operand): Join checks for
7809         "gdbarch_stap_parse_special_token_p" and
7810         "gdbarch_stap_parse_special_token" in the same "if" statement.
7811         Invert check when verifying for operation on register
7812         displacement.
7813
7814 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7815
7816         * stap-probe.c (stap_get_opcode): Update comment.
7817         (stap_get_expected_argument_type): Likewise.
7818         (handle_stap_probe): Likewise.
7819
7820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7821
7822         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7823         return type to 'bool'.  Adjust comment.  Use 'bool' when
7824         appropriate.
7825         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7826         * stap-probe.c (stap_parse_argument_1): Likewise.
7827         (stap_is_operator): Likewise.
7828         (stap_is_generic_prefix): Likewise.
7829         (stap_is_register_prefix): Likewise.
7830         (stap_is_register_indirection_prefix): Likewise.
7831         (stap_is_integer_prefix): Likewise.
7832         (stap_generic_check_suffix): Likewise.
7833         (stap_check_integer_suffix): Likewise.
7834         (stap_check_register_suffix): Likewise.
7835         (stap_check_register_indirection_suffix): Likewise.
7836         (stap_parse_register_operand): Likewise.
7837         (stap_parse_single_operand): Likewise.
7838         (stap_parse_argument_1): Likewise.
7839         (stap_probe::get_argument_count): Likewise.
7840         (stap_is_operator): Likewise.
7841
7842 2019-05-16  Tom Tromey  <tromey@adacore.com>
7843
7844         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7845         keyword to foreach.
7846
7847 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7848
7849         * linux-thread-db.c (try_thread_db_load_1): Change return type
7850         to bool.
7851         (try_thread_db_load): Likewise.
7852         (try_thread_db_load_from_pdir_1): Likewise.
7853         (try_thread_db_load_from_pdir): Likewise.
7854         (try_thread_db_load_from_sdir): Likewise.
7855         (try_thread_db_load_from_dir): Likewise.
7856         (thread_db_load_search): Likewise.
7857         (has_libpthread): Likewise.
7858         (thread_db_load): Likewise.
7859
7860 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7861
7862         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7863         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7864         NULL, and complain/return if that's the case.
7865
7866 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7867
7868         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7869         (advance, posn, abstract_read_memory): New functions.
7870         [struct mem_read_abstraction]: New struct.
7871         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7872
7873 2019-05-14  Tom Tromey  <tromey@adacore.com>
7874
7875         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7876         value is not lval_memory.
7877
7878 2019-05-14  Tom Tromey  <tromey@adacore.com>
7879
7880         * solib.c (info_sharedlibrary_command): Style the file name.
7881
7882 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7883
7884         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7885         (aarch64_vnv_type): Likewise.
7886         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7887         * common/tdesc.c: Likewise.
7888         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7889         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7890         * features/aarch64-fpu.xml: Add ieee half view.
7891         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7892         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7893         * gdbtypes.h (struct builtin_type): Likewise.
7894         (struct objfile_type): Likewise.
7895
7896 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7897
7898         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7899         typo.
7900         * location.h (string_to_event_location): Likewise.
7901
7902 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7903
7904         GDB 8.3 released.
7905
7906 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7907
7908         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7909         New variable declaration.
7910         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7911         New variable.
7912         (print_one_breakpoint): Use ui_out::test_flags and new global
7913         variable to compute use_fixed_output.
7914         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7915         Remove.
7916         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7917         (mi_multi_location_breakpoint_output_fixed): Remove.
7918         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7919         new variable.
7920         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7921         fix_multi_location_breakpoint_output flag if version >= 3.
7922         * ui-out.h (enum ui_out_flag)
7923         <fix_multi_location_breakpoint_output>: New enumerator.
7924
7925 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7926
7927         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7928
7929 2019-05-10  Tom Tromey  <tromey@adacore.com>
7930
7931         * ada-lang.c (catch_ada_completer): New function.
7932         (_initialize_ada_language): Use it.
7933
7934 2019-05-10  Tom Tromey  <tromey@adacore.com>
7935
7936         * thread.c (print_thread_info): Make "requested_threads" const.
7937         * gdbthread.h (print_thread_info): Make "requested_threads"
7938         const.
7939         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7940         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7941
7942 2019-05-08  Tom Tromey  <tom@tromey.com>
7943
7944         * gdbtypes.c (objfile_type_data): Change type.
7945         (objfile_type, _initialize_gdbtypes): Update.
7946
7947 2019-05-08  Tom Tromey  <tom@tromey.com>
7948
7949         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7950         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7951         (_initialize_dwarf2_frame): Update.
7952
7953 2019-05-08  Tom Tromey  <tom@tromey.com>
7954
7955         * objc-lang.c (objc_objfile_data): Change type.
7956         (find_methods): Update.
7957         (_initialize_objc_lang): Remove.
7958
7959 2019-05-08  Tom Tromey  <tom@tromey.com>
7960
7961         * stabsread.c (rs6000_builtin_type_data): Change type.
7962         (rs6000_builtin_type, _initialize_stabsread): Update.
7963
7964 2019-05-08  Tom Tromey  <tom@tromey.com>
7965
7966         * mips-tdep.c (mips_pdr_data): Remove.
7967         (_initialize_mips_tdep): Update.
7968
7969 2019-05-08  Tom Tromey  <tom@tromey.com>
7970
7971         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7972         (hppa_init_objfile_priv_data, read_unwind_info)
7973         (find_unwind_entry, _initialize_hppa_tdep): Update.
7974
7975 2019-05-08  Tom Tromey  <tom@tromey.com>
7976
7977         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7978         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7979         on obstack.
7980         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7981
7982 2019-05-08  Tom Tromey  <tom@tromey.com>
7983
7984         * mdebugread.c (basic_type_data): Change type.
7985         (basic_type, _initialize_mdebugread): Update.
7986
7987 2019-05-08  Tom Tromey  <tom@tromey.com>
7988
7989         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7990
7991 2019-05-08  Tom Tromey  <tom@tromey.com>
7992
7993         * nto-tdep.c (nto_inferior_data_reg): Change type.
7994         (nto_inferior_data): Update.
7995         (nto_inferior_data_cleanup, nto_new_inferior_data)
7996         (_initialize_nto_tdep): Remove.
7997         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7998
7999 2019-05-08  Tom Tromey  <tom@tromey.com>
8000
8001         * ada-lang.c (struct ada_inferior_data): Add initializers.
8002         (ada_inferior_data): Change type.
8003         (ada_inferior_data_cleanup): Remove.
8004         (get_ada_inferior_data, ada_inferior_exit)
8005         (struct ada_pspace_data): Add initializers, destructor.
8006         (ada_pspace_data_handle): Change type.
8007         (get_ada_pspace_data): Update.
8008         (ada_pspace_data_cleanup): Remove.
8009
8010 2019-05-08  Tom Tromey  <tom@tromey.com>
8011
8012         * coffread.c (struct coff_symfile_info): Add initializers.
8013         (coff_objfile_data_key): Move lower.  Change type.
8014         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8015         Update.
8016         (coff_free_info): Remove.
8017
8018 2019-05-08  Tom Tromey  <tom@tromey.com>
8019
8020         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8021         (fbsd_pspace_data_handle): Move lower.  Change type.
8022         (get_fbsd_pspace_data): Update.
8023         (fbsd_pspace_data_cleanup): Remove.
8024         (_initialize_fbsd_tdep): Update.
8025
8026 2019-05-08  Tom Tromey  <tom@tromey.com>
8027
8028         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8029         (get_ada_tasks_pspace_data): Update.
8030         (ada_tasks_pspace_data_cleanup): Remove.
8031         (_initialize_tasks): Update.
8032         (ada_tasks_inferior_data_handle): Change type.
8033         (get_ada_tasks_inferior_data): Update.
8034         (ada_tasks_inferior_data_cleanup): Remove.
8035         (struct ada_tasks_pspace_data): Add initializers.
8036
8037 2019-05-08  Tom Tromey  <tom@tromey.com>
8038
8039         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8040         * symfile-debug.c (debug_sym_get_probes): Change type.
8041         * stap-probe.c (handle_stap_probe):
8042         (stap_static_probe_ops::get_probes): Change type.
8043         * probe.h (class static_probe_ops) <get_probes>: Change type.
8044         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8045         (parse_probes_in_pspace): Update.
8046         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8047         Update.
8048         (any_static_probe_ops::get_probes): Change type.
8049         * elfread.c (elfread_data): New typedef.
8050         (probe_key): Change type.
8051         (elf_get_probes): Likewise.  Update.
8052         (probe_key_free): Remove.
8053         (_initialize_elfread): Update.
8054         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8055         Change type.
8056         (dtrace_process_dof_probe, dtrace_process_dof)
8057         (dtrace_static_probe_ops::get_probe): Change type.
8058
8059 2019-05-08  Tom Tromey  <tom@tromey.com>
8060
8061         * xcoffread.c (struct xcoff_symfile_info): Rename from
8062         coff_symfile_info.  Add initializers.
8063         (xcoff_objfile_data_key): Move lower.  Change type.
8064         (XCOFF_DATA): Rewrite.
8065         (xcoff_free_info): Remove.
8066         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8067         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8068         (xcoff_initial_scan): Update.
8069
8070 2019-05-08  Tom Tromey  <tom@tromey.com>
8071
8072         * solib-svr4.c (struct svr4_info): Add initializers and
8073         destructor.
8074         <probes_table>: Now an htab_up.
8075         (solib_svr4_pspace_data): Change type.
8076         (free_probes_table): Simplify.
8077         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8078         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8079         (probes_table_remove_objfile_probes, register_solib_event_probe)
8080         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8081         (_initialize_svr4_solib): Update.
8082
8083 2019-05-08  Tom Tromey  <tom@tromey.com>
8084
8085         * remote.c (remote_pspace_data): Change type.
8086         (remote_pspace_data_cleanup): Remove.
8087         (get_remote_exec_file, set_pspace_remote_exec_file)
8088         (_initialize_remote): Update.
8089
8090 2019-05-08  Tom Tromey  <tom@tromey.com>
8091
8092         * breakpoint.c (breakpoint_objfile_key): Change type.
8093         (get_breakpoint_objfile_data): Update.
8094         (free_breakpoint_objfile_data): Remove.
8095         (_initialize_breakpoint): Update.
8096
8097 2019-05-08  Tom Tromey  <tom@tromey.com>
8098
8099         * linux-tdep.c (struct linux_info): Add initializers.
8100         (linux_inferior_data): Move.  Change type.
8101         (invalidate_linux_cache_inf): Update.
8102         (linux_inferior_data_cleanup): Remove.
8103         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8104
8105 2019-05-08  Tom Tromey  <tom@tromey.com>
8106
8107         * auxv.c (auxv_inferior_data): Move.  Change type.
8108         (auxv_inferior_data_cleanup): Remove.
8109         (invalidate_auxv_cache_inf): Rewrite.
8110         (get_auxv_inferior_data, _initialize_auxv): Update.
8111
8112 2019-05-08  Tom Tromey  <tom@tromey.com>
8113
8114         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8115         (symfile_debug_objfile_data_key): Change type.
8116         (symfile_debug_installed, debug_qf_has_symbols)
8117         (debug_qf_find_last_source_symtab)
8118         (debug_qf_forget_cached_source_info)
8119         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8120         (debug_qf_print_stats, debug_qf_dump)
8121         (debug_qf_expand_symtabs_for_function)
8122         (debug_qf_expand_all_symtabs)
8123         (debug_qf_expand_symtabs_with_fullname)
8124         (debug_qf_map_matching_symbols)
8125         (debug_qf_expand_symtabs_matching)
8126         (debug_qf_find_pc_sect_compunit_symtab)
8127         (debug_qf_map_symbol_filenames)
8128         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8129         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8130         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8131         (debug_sym_read_linetable, debug_sym_relocate): Update.
8132         (symfile_debug_free_objfile): Remove.
8133         (install_symfile_debug_logging, _initialize_symfile_debug):
8134         Update.
8135
8136 2019-05-08  Tom Tromey  <tom@tromey.com>
8137
8138         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8139         allocate_on_obstack.
8140         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8141         (get_dwarf2_per_objfile): Update.
8142         (set_dwarf2_per_objfile): Remove.
8143         (dwarf2_has_info, dwarf2_get_section_info): Update.
8144         (dwarf2_free_objfile): Remove.
8145         (_initialize_dwarf2_read): Update.
8146
8147 2019-05-08  Tom Tromey  <tom@tromey.com>
8148
8149         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8150         initializers.
8151         <unsupported_script_warning_printed,
8152         script_not_found_warning_printed>: Now bool.
8153         (auto_load_pspace_data): Change type.
8154         (~auto_load_pspace_info): Rename from
8155         auto_load_pspace_data_cleanup.
8156         (get_auto_load_pspace_data, init_loaded_scripts_info)
8157         (clear_section_scripts, maybe_print_unsupported_script_warning)
8158         (maybe_print_script_not_found_warning, _initialize_auto_load):
8159         Update.
8160
8161 2019-05-08  Tom Tromey  <tom@tromey.com>
8162
8163         * objfiles.c (objfile_pspace_info): Add destructor and
8164         initializers.
8165         (objfiles_pspace_data): Change type.
8166         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8167         (get_objfile_pspace_data): Update.
8168         (objfiles_bfd_data): Change type.
8169         (get_objfile_bfd_data): Update.
8170         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8171
8172 2019-05-08  Tom Tromey  <tom@tromey.com>
8173
8174         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8175         Change type.
8176         (get_catch_syscall_inferior_data): Update.
8177         (catch_syscall_inferior_data_cleanup): Remove.
8178         (_initialize_break_catch_syscall): Update.
8179
8180 2019-05-08  Tom Tromey  <tom@tromey.com>
8181
8182         * inflow.c (struct terminal_info): Add destructor and
8183         initializers.
8184         (inflow_inferior_data): Change type.
8185         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8186         (get_inflow_inferior_data, inflow_inferior_exit)
8187         (swap_terminal_info, _initialize_inflow): Update.
8188
8189 2019-05-08  Tom Tromey  <tom@tromey.com>
8190
8191         * target-dcache.c (target_dcache_cleanup): Remove.
8192         (target_dcache_aspace_key): Change type.
8193         (target_dcache_init_p, target_dcache_invalidate)
8194         (target_dcache_get, target_dcache_get_or_init)
8195         (_initialize_target_dcache): Update.
8196         * dcache.h (struct dcache_deleter): New.
8197
8198 2019-05-08  Tom Tromey  <tom@tromey.com>
8199
8200         * symtab.c (struct symbol_cache): Add destructor and
8201         initializers.
8202         (symbol_cache_key): Move.  Change type.
8203         (make_symbol_cache, free_symbol_cache): Remove.
8204         (get_symbol_cache): Update.
8205         (symbol_cache_cleanup): Remove.
8206         (ALL_PSPACES, symbol_cache_flush)
8207         (maintenance_print_symbol_cache)
8208         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8209         Update.
8210
8211 2019-05-08  Tom Tromey  <tom@tromey.com>
8212
8213         * symtab.c (struct main_info): Add destructor and initializers.
8214         (main_progspace_key): Move.  Change type.
8215         (get_main_info): Update.
8216         (main_info_cleanup): Remove.
8217         (_initialize_symtab): Update.
8218
8219 2019-05-08  Tom Tromey  <tom@tromey.com>
8220
8221         * registry.h (DECLARE_REGISTRY): Define the _key class.
8222
8223 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8224
8225         * NEWS: Merge two 'New commands' sections.
8226
8227 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8228
8229         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8230         parameter and use Ada language definition instead.
8231         (ada_val_print_ptr): Remove unused language parameter.
8232         (ada_val_print_num): Remove language parameter and use Ada language
8233         definition instead.
8234         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8235         parameter.
8236         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8237         parameter and use Ada language definition instead.
8238         (ada_val_print_1): Update all ada_val_print_xxx calls.
8239         Remove language parameter.
8240         (ada_val_print): Update ada_val_print_1 call.
8241
8242 2019-05-08  Tom Tromey  <tromey@adacore.com>
8243
8244         * remote.c (remote_hw_watchpoint_limit)
8245         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8246         Now static.
8247
8248 2019-05-08  Tom Tromey  <tromey@adacore.com>
8249
8250         * maint.c (_initialize_maint_cmds): Move initialization code to
8251         remote.c.
8252         (watchdog, show_watchdog): Move to remote.c.
8253         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8254         "watchdog" static.
8255         (_initialize_remote): Move initialization code from maint.c.
8256         * defs.h (watchdog): Don't declare.
8257
8258 2019-05-08  Tom Tromey  <tromey@adacore.com>
8259
8260         * tui/tui-interp.c: Include main.h.
8261         * interps.c: Include main.h.
8262         * main.h (interpreter_p): Declare.
8263         * defs.h (interpreter_p): Don't declare.
8264
8265 2019-05-08  Tom Tromey  <tromey@adacore.com>
8266
8267         * dwarf2loc.c: Include dwarf2read.h.
8268         * defs.h (read_unsigned_leb128): Don't declare.
8269         * dwarf2read.h (read_unsigned_leb128): Declare.
8270
8271 2019-05-08  Tom Tromey  <tromey@adacore.com>
8272
8273         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8274         method.
8275
8276 2019-05-08  Tom Tromey  <tromey@adacore.com>
8277
8278         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8279         when no wrap column is set.
8280
8281 2019-05-08  Tom Tromey  <tromey@adacore.com>
8282
8283         * c-lang.c (c_get_string): Handle non-C-style arrays.
8284
8285 2019-05-08  Tom Tromey  <tromey@adacore.com>
8286
8287         * typeprint.c (print_offset_data::update): Print the bit offset,
8288         not the number of bits remaining.
8289
8290 2019-05-08  Tom Tromey  <tromey@adacore.com>
8291
8292         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8293         padding at end of comment.
8294
8295 2019-05-08  Tom Tromey  <tromey@adacore.com>
8296
8297         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8298         Compare main types.
8299
8300 2019-05-06  Tom Tromey  <tom@tromey.com>
8301
8302         * common/scoped_mmap.c: Include common-defs.h.
8303         * common/scoped_mmap.h: Don't include config.h.
8304
8305 2019-05-04  Tom Tromey  <tom@tromey.com>
8306
8307         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8308         (struct aarch64_call_info): Add initializers.
8309         <si>: Now a std::vector.
8310         (pass_on_stack, aarch64_push_dummy_call): Update.
8311
8312 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8313             Tom Tromey  <tom@tromey.com>
8314
8315         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8316         (ppc_threads): Now a std::vector.  Now static.
8317         (hwdebug_find_thread_points_by_tid)
8318         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8319         Update.
8320
8321 2019-05-04  Tom Tromey  <tom@tromey.com>
8322
8323         * arc-tdep.c (arc_tdesc_init): Return bool.
8324
8325 2019-05-04  Tom Tromey  <tom@tromey.com>
8326
8327         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8328         Use gdb_assert_not_reached.
8329
8330 2019-05-04  Tom Tromey  <tom@tromey.com>
8331
8332         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8333         "false".
8334
8335 2019-05-04  Tom Tromey  <tom@tromey.com>
8336
8337         * arc-tdep.c (arc_tdesc_init): Use bool.
8338
8339 2019-05-04  Tom Tromey  <tom@tromey.com>
8340
8341         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8342
8343 2019-05-04  Tom Tromey  <tom@tromey.com>
8344
8345         * cli/cli-cmds.c (valid_command_p): Return bool.
8346
8347 2019-05-04  Tom Tromey  <tom@tromey.com>
8348
8349         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8350         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8351
8352 2019-05-04  Raul Tambre  <raul@tambre.ee>
8353
8354         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8355         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8356         operator for comparison.
8357
8358 2019-05-04  Tom Tromey  <tom@tromey.com>
8359
8360         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8361         (lookup_partial_symbol, print_partial_symbols)
8362         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8363         (psymbol_compare): Update.
8364         (add_psymbol_to_bcache): Clear the entire psymbol.
8365         (maintenance_check_psymtabs): Update.
8366         * psympriv.h (struct partial_symbol): Don't derive from
8367         general_symbol_info.
8368         <obj_section, unrelocated_address, address,
8369         set_unrelocated_address>: Update.
8370         <ginfo>: New member.
8371         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8372         (debug_names::write_psymbols): Update.
8373
8374 2019-05-04  Tom de Vries  <tdevries@suse.de>
8375
8376         * contrib/cc-with-tweaks.sh: Support -n arg.
8377
8378 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8379
8380         * corelow.c (core_target::detach): Ensure frame cache and
8381         register caches are cleared.
8382         inferior.c (exit_inferior_1): Likewise.
8383
8384 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8385             Tom Tromey  <tom@tromey.com>
8386
8387         * dictionary.c (collate_pending_symbols_by_language): Remove
8388         "struct" from foreach.
8389         * symtab.c (lookup_global_symbol_from_objfile)
8390         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8391         foreach.
8392         * ser-tcp.c (net_open): Remove "struct" from foreach.
8393         * objfiles.c (objfile_relocate, objfile_rebase)
8394         (objfile_has_symbols): Remove "struct" from foreach.
8395         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8396         from foreach.
8397         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8398         foreach.
8399         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8400         "struct" from foreach.
8401         * ada-lang.c (create_excep_cond_exprs)
8402         (ada_exception_catchpoint_cond_string): Remove "struct" from
8403         foreach.
8404
8405 2019-05-03  Tom Tromey  <tromey@adacore.com>
8406
8407         * ada-exp.y (convert_char_literal): Check suffix of each
8408         enumerator.
8409
8410 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8411
8412         PR ada/21406:
8413         * ada-exp.y (yywrap): Don't define.
8414         * ada-lex.l (%option): Add noyywrap
8415         (yywrap): Remove.
8416
8417 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8418
8419         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8420         _WIN32_WINNT to the XP level, unless already defined to a higher
8421         level.
8422
8423         * unittests/parse-connection-spec-selftests.c:
8424         * ser-tcp.c:
8425         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8426         override.
8427
8428         * symfile.c (find_separate_debug_file): Remove colon from the
8429         drive spec of DOS/Windows file names of the target, so that the
8430         file name produced from DEBUGDIR and the target's directory will
8431         be valid on DOS/Windows systems.
8432
8433 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8434
8435         * rust-lang.c (val_print_struct): Handle printing structures
8436         containing strings.
8437
8438 2019-05-02  Tom Tromey  <tromey@adacore.com>
8439
8440         * valarith.c (_initialize_valarith): Remove.
8441
8442 2019-05-01  Tom Tromey  <tromey@adacore.com>
8443
8444         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8445         bitfields.
8446
8447 2019-05-01  Tom Tromey  <tromey@adacore.com>
8448
8449         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8450         for big-endian copies.
8451
8452 2019-04-30  Ali Tamur  <tamur@google.com>
8453         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8454         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8455         (read_3_bytes): New function.
8456
8457 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8458
8459         * windows-nat.c (main_thread_id): Delete.
8460         (handle_output_debug_string): Replace main_thread_id by
8461         current_event.dwThreadId.
8462         (fake_create_process): Likewise.
8463         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8464         Do not set main_thread_id.
8465         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8466         current_event.dwThreadId.
8467         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8468
8469 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8470
8471         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8472         Use current_event.dwThreadId instead of main_thread_id.
8473
8474 2019-04-30  Tom Tromey  <tromey@adacore.com>
8475
8476         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8477         (create_excep_cond_exprs): Iterate over program spaces.
8478         (ada_exception_catchpoint_cond_string): Examine all minimal
8479         symbols for exception types.
8480
8481 2019-04-30  Tom Tromey  <tromey@adacore.com>
8482
8483         PR c++/24470:
8484         * dwarf2read.c (process_structure_scope): Handle case where type
8485         has template parameters but no symbol was created.
8486
8487 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8488             Chris January  <chris.january@arm.com>
8489
8490         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8491         qualifier.
8492         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8493
8494 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8495
8496         * f-typeprint.c (f_print_type): Update rules for printing
8497         whitespace.
8498         (f_type_print_varspec_suffix): Likewise.
8499
8500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8501             Chris January  <chris.january@arm.com>
8502
8503         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8504         function arguments.
8505
8506 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * f-lang.c (build_fortran_types): Change name of void type to
8509         lower case.
8510         * f-typeprint.c (f_type_print_base): Print the name of the void
8511         type, rather than a fixed string.
8512         * f-valprint.c (f_decorations): Use lower case void string.
8513
8514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8515             Chris January  <chris.january@arm.com>
8516
8517         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8518         types for Fortran.
8519
8520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8521             Chris January  <chris.january@arm.com>
8522             David Lecomber  <david.lecomber@arm.com>
8523
8524         * f-exp.y (BINOP_INTRINSIC): New token.
8525         (exp): New parser rule handling BINOP_INTRINSIC.
8526         (f77_keywords): Add new builtin procedures.
8527         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8528         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8529         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8530         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8531         (print_unop_subexp_f): New function.
8532         (print_binop_subexp_f): New function.
8533         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8534         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8535         (dump_subexp_body_f): Likewise.
8536         (operator_check_f): Likewise.
8537         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8538         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8539
8540 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8543         UNOP_KIND.
8544         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8545         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8546         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8547         (operator_length_f): New fuction.
8548         (print_subexp_f): New function.
8549         (op_name_f): New function.
8550         (dump_subexp_body_f): New function.
8551         (operator_check_f): New function.
8552         (exp_descriptor_f): Replace standard expression handling functions
8553         with new functions.
8554         * gdb/fortran-operator.def: New file.
8555         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8556         * gdb/std-operator.def: Remove UNOP_KIND.
8557
8558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8559
8560         * std-operator.def: Remove unbalanced, stray double quote
8561         character.
8562
8563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8564             Chris January  <chris.january@arm.com>
8565             Daniel Everett  <daniel.everett@arm.com>
8566             Nick Forrington  <nick.forrington@arm.com>
8567             Richard Bunt  <richard.bunt@arm.com>
8568
8569         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8570         of depth when printing anonymous structs or unions.
8571         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8572         Don't print either the top-level value, or the children if the
8573         max-depth is exceeded.
8574         (ppscm_print_children): When printing the key of a map, allow one
8575         extra level of depth.
8576         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8577         print either the top-level value, or the children if the max-depth
8578         is exceeded.
8579         (print_children): When printing the key of a map, allow one extra
8580         level of depth.
8581         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8582         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8583         (user_print_options): Initialise max_depth field.
8584         (val_print_scalar_or_string_type_p): New function.
8585         (val_print): Check to see if the max depth has been reached.
8586         (val_print_check_max_depth): Define new function.
8587         (show_print_max_depth): New function.
8588         (_initialize_valprint): Add 'print max-depth' option.
8589         * valprint.h (struct value_print_options) <max_depth>: New field.
8590         (val_print_check_max_depth): Declare new function.
8591         * NEWS: Document new feature.
8592
8593 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8594
8595         * ada-lang.c (ada_language_defn): Initialise new field.
8596         * c-lang.c (c_is_string_type_p): New function.
8597         (c_language_defn): Initialise new field.
8598         (cplus_language_defn): Initialise new field.
8599         (asm_language_defn): Initialise new field.
8600         (minimal_language_defn): Initialise new field.
8601         * c-lang.h (c_is_string_type_p): Declare new function.
8602         * d-lang.c (d_language_defn): Initialise new field.
8603         * f-lang.c (f_is_string_type_p): New function.
8604         (f_language_defn): Initialise new field.
8605         * go-lang.c (go_is_string_type_p): New function.
8606         (go_language_defn): Initialise new field.
8607         * language.c (default_is_string_type_p): New function.
8608         (unknown_language_defn): Initialise new field.
8609         (auto_language_defn): Initialise new field.
8610         * language.h (struct language_defn) <la_is_string_type_p>: New
8611         member variable.
8612         (default_is_string_type_p): Declare new function.
8613         * m2-lang.c (m2_language_defn): Initialise new field.
8614         * objc-lang.c (objc_language_defn): Initialise new field.
8615         * opencl-lang.c (opencl_language_defn): Initialise new field.
8616         * p-lang.c (pascal_is_string_type_p): New function.
8617         (pascal_language_defn): Initialise new field.
8618         * rust-lang.c (rust_is_string_type_p): New function.
8619         (rust_language_defn): Initialise new field.
8620
8621 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8622
8623         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8624         New field.
8625         * ada-lang.c (ada_language_defn): Initialise new field.
8626         * c-lang.c (c_language_defn): Likewise.
8627         (cplus_language_defn): Likewise.
8628         (asm_language_defn): Likewise.
8629         (minimal_language_defn): Likewise.
8630         * d-lang.c (d_language_defn): Likewise.
8631         * f-lang.c (f_language_defn): Likewise.
8632         * go-lang.c (go_language_defn): Likewise.
8633         * language.c (unknown_language_defn): Likewise.
8634         (auto_language_defn): Likewise.
8635         * m2-lang.c (m2_language_defn): Likewise.
8636         * objc-lang.c (objc_language_defn): Likewise.
8637         * opencl-lang.c (opencl_language_defn): Likewise.
8638         * p-lang.c (pascal_language_defn): Likewise.
8639         * rust-lang.c (rust_language_defn): Likewise.
8640
8641 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8642
8643         * ada-lang.c (ada_is_character_type): Change return type to bool.
8644         (ada_is_string_type): Likewise.
8645         * ada-lang.h (ada_is_character_type): Update declaration
8646         (ada_is_string_type): Likewise.
8647
8648 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8649
8650         Support style in 'frame|thread apply'
8651
8652         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8653         * record.c (record_start, record_stop): Update callers of
8654         execute_command_to_string with false.
8655         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8656         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8657         methods.
8658         (class string_file): New constructor with term_out parameter.
8659         Override methods term_out and can_emit_style_escape.  New member
8660         term_out.
8661         (class stdio_file): Override can_emit_style_escape.
8662         (class tee_file): Override term_out and can_emit_style_escape.
8663         * utils.h (can_emit_style_escape): Remove.
8664         * utils.c (can_emit_style_escape): Likewise.
8665         Update all callers of can_emit_style_escape (SOMESTREAM) to
8666         SOMESTREAM->can_emit_style_escape.
8667         * source-cache.c (source_cache::get_source_lines): Likewise.
8668         * stack.c (frame_apply_command_count): Call execute_command_to_string
8669         passing the term_out characteristic of the current gdb_stdout.
8670         * thread.c (thr_try_catch_cmd): Likewise.
8671         * top.c (execute_command_to_string): pass term_out parameter
8672         to construct the string_file for the command output.
8673         * ui-file.c (term_cli_styling): New function (most code moved
8674         from utils.c can_emit_style_escape).
8675         (string_file::string_file, string_file::can_emit_style_escape,
8676         stdio_file::can_emit_style_escape, tee_file::term_out,
8677         tee_file::can_emit_style_escape): New functions.
8678
8679 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8680
8681         * NEWS: Mention the new set|show may-call-functions.
8682         * infcall.c (may_call_functions_p): New variable.
8683         (show_may_call_functions_p): New function.
8684         (call_function_by_hand_dummy): Throws an error if not
8685         may-call-functions.
8686         (_initialize_infcall): Call add_setshow_boolean_cmd for
8687         may-call-functions.
8688
8689 2019-04-25  Keith Seitz  <keiths@redhat.com>
8690
8691         PR c++/24367
8692         * cp-support.c (inspect_type): Don't attempt substitutions
8693         of symbol with the same name.
8694
8695 2019-04-25  Tom Tromey  <tromey@adacore.com>
8696
8697         PR gdb/24475:
8698         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8699         static.
8700
8701 2019-04-25  Tom Tromey  <tromey@adacore.com>
8702
8703         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8704         rvalue reference.
8705         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8706         (gdb_xml_parser::parse): Use std::move.
8707         * python/python-internal.h (gdbpy_convert_exception): Take a const
8708         reference.
8709         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8710         std::move.
8711         * python/py-utils.c (gdbpy_convert_exception): Take a const
8712         reference.
8713         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8714         Use std::move.
8715         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8716         Use std::move.
8717         * mi/mi-main.c (mi_print_exception): Take a const reference.
8718         * main.c (handle_command_errors): Take a const reference.
8719         * linespec.c (parse_linespec): Use std::move.
8720         * infcall.c (run_inferior_call): Use std::move.
8721         (call_function_by_hand_dummy): Use std::move.
8722         * exec.c (try_open_exec_file): Use std::move.
8723         * exceptions.h (exception_print, exception_fprintf)
8724         (exception_print_same): Update.
8725         * exceptions.c (print_exception, exception_print)
8726         (exception_fprintf, exception_print_same): Change parameters to
8727         const reference.
8728         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8729         * common/new-op.c: Use std::move.
8730         * common/common-exceptions.h (struct gdb_exception): Add move
8731         constructor.
8732         (struct gdb_exception_error, struct gdb_exception_quit, struct
8733         gdb_quit_bad_alloc): Change constructor to move constructor.
8734         (throw_exception): Change parameter to rvalue reference.
8735         * common/common-exceptions.c (throw_exception): Take rvalue
8736         reference.
8737         * cli/cli-interp.c (safe_execute_command): Use std::move.
8738         * breakpoint.c (insert_bp_location, location_to_sals): Use
8739         std::move.
8740
8741 2019-04-25  Tom Tromey  <tromey@adacore.com>
8742
8743         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8744         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8745         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8746         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8747         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8748         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8749         guile/scm-value.c: Use unpack.
8750         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8751         gdbscm_gdb_exception.
8752         (gdbscm_throw_gdb_exception): Likewise.
8753         (struct gdbscm_gdb_exception): New.
8754         (unpack): New function.
8755         (gdbscm_wrap): Use unpack.
8756
8757 2019-04-25  Tom Tromey  <tromey@adacore.com>
8758
8759         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8760         (gdb_rl_callback_handler): Use std::move.
8761         * common/common-exceptions.h (struct gdb_exception): Add move
8762         assignment operator.
8763         (throw_exception_sjlj): Change "exception" to const reference.
8764         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8765         (throw_exception_sjlj): Change "exception" to const reference.
8766
8767 2019-04-25  Tom Tromey  <tromey@adacore.com>
8768
8769         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8770         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8771         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8772         Update.
8773         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8774         Update.
8775         * mi/mi-interp.c (mi_interp::exec): Update.
8776         * linespec.c (parse_linespec): Update.
8777         * infcall.c (run_inferior_call): Update.
8778         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8779         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8780         (gdbscm_lookup_global_symbol): Update.
8781         * guile/scm-param.c (gdbscm_parameter_value): Update.
8782         * guile/scm-frame.c (gdbscm_frame_read_register)
8783         (gdbscm_frame_read_var): Update.
8784         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8785         * exec.c (try_open_exec_file): Update.
8786         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8787         (gdb_rl_callback_handler): Update.
8788         * common/common-exceptions.h (exception_none): Don't declare.
8789         * common/common-exceptions.c (exception_none): Don't define.
8790         (struct catcher) <exception>: Update.
8791         * cli/cli-interp.c (safe_execute_command): Update.
8792         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8793
8794 2019-04-25  Ali Tamur  <tamur@google.com>
8795
8796         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8797         (read_attribute_value): Likewise.
8798         (dwarf2_read_addr_index): Update comment.
8799         (read_str_index): Add DW_FORM_strx.
8800         (dwarf2_string_attr): Likewise.
8801         (dwarf2_const_value_attr): Likewise.
8802         (dump_die_shallow): Likewise.
8803         (dwarf2_fetch_constant_bytes): Likewise.
8804         (skip_form_bytes): Likewise.
8805         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8806
8807 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8808
8809         PR corefiles/11608
8810         PR corefiles/18187
8811         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8812         OFFSET.  Verify if current mapping contains an ELF header.
8813         (linux_find_memory_regions_full): Adjust call to
8814         dump_mapping_p.
8815
8816 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8817             Kang Li <kanglictf@gmail.com>
8818
8819         PR gdb/21600
8820
8821         * dwarf2-frame.c (read_initial_length): Be consistent about using
8822         unsigned representation of length.
8823         (decode_frame_entry_1): Likewise.  Check for wraparound of
8824         end pointer as well as buffer overflow.
8825
8826 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8827
8828         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8829         "vq".
8830
8831 2019-04-24  Tom Tromey  <tromey@adacore.com>
8832
8833         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8834
8835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8836
8837         * s12z-tdep.c (s12z_unwind_pc): Delete.
8838         (s12z_unwind_sp): Delete.
8839         (s12z_gdbarch_init): Don't register deleted functions with
8840         gdbarch.
8841
8842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * rl78-tdep.c (rl78_unwind_sp): Delete.
8845         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8846
8847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8848
8849         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8850         (xstormy16_unwind_pc): Delete.
8851         (xstormy16_dummy_id): Delete.
8852         (xstormy16_gdbarch_init): Don't register deleted functions with
8853         gdbarch.
8854
8855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * vax-tdep.c (vax_unwind_pc): Delete.
8858         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8859
8860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8861
8862         * v850-tdep.c (v850_unwind_sp): Delete.
8863         (v850_unwind_pc): Delete.
8864         (v850_dummy_id): Delete.
8865         (v850_gdbarch_init): Don't register deleted functions with
8866         gdbarch.
8867
8868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8869
8870         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8871         (tilegx_unwind_pc): Delete.
8872         (tilegx_unwind_dummy_id): Delete.
8873         (tilegx_gdbarch_init): Don't register deleted functions with
8874         gdbarch.
8875
8876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8877
8878         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8879         (tic6x_dummy_id): Delete.
8880         (tic6x_gdbarch_init): Don't register deleted functions with
8881         gdbarch.
8882
8883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8884
8885         * sparc-tdep.c (sparc_unwind_pc): Delete.
8886         (sparc32_gdbarch_init): Don't register deleted function with
8887         gdbarch.
8888
8889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * sh-tdep.c (sh_unwind_sp): Delete.
8892         (sh_unwind_pc): Delete.
8893         (sh_dummy_id): Delete.
8894         (sh_gdbarch_init): Don't register deleted functions with
8895         gdbarch.
8896
8897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * score-tdep.c (score_unwind_sp): Delete.
8900         (score_unwind_pc): Delete.
8901         (score_dummy_id): Delete.
8902         (score_gdbarch_init): Don't register deleted functions with
8903         gdbarch.
8904
8905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8906
8907         * rx-tdep.c (rx_unwind_pc): Delete.
8908         (rx_unwind_sp): Delete.
8909         (rx_dummy_id): Delete.
8910         (rx_gdbarch_init): Don't register deleted functions with
8911         gdbarch.  Update comment.
8912
8913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8916         (rs6000_dummy_id): Delete.
8917         (rs6000_gdbarch_init): Don't register deleted functions with
8918         gdbarch.
8919
8920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8921
8922         * or1k-tdep.c (or1k_dummy_id): Delete.
8923         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8924
8925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8926
8927         * nios2-tdep.c (nios2_dummy_id): Delete.
8928         (nios2_unwind_sp): Delete.
8929         (nios2_gdbarch_init): Don't register deleted functions with
8930         gdbarch.
8931
8932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * nds32-tdep.c (nds32_dummy_id): Delete.
8935         (nds32_unwind_pc): Delete.
8936         (nds32_unwind_sp): Delete.
8937         (nds32_gdbarch_init): Don't register deleted functions with
8938         gdbarch.
8939
8940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8941
8942         * msp430-tdep.c (msp430_unwind_pc): Delete.
8943         (msp430_unwind_sp): Delete.
8944         (msp430_dummy_id): Delete.
8945         (msp430_gdbarch_init): Don't register deleted functions with
8946         gdbarch.
8947
8948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * moxie-tdep.c (moxie_unwind_sp): Delete.
8951         (moxie_unwind_pc): Delete.
8952         (moxie_dummy_id): Delete.
8953         (moxie_gdbarch_init): Don't register deleted functions with
8954         gdbarch.
8955
8956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8959         (mn10300_unwind_pc): Delete.
8960         (mn10300_unwind_sp): Delete.
8961         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8962         mn10300_unwind_sp.
8963         (mn10300_frame_unwind_init): Don't register deleted functions with
8964         gdbarch.
8965
8966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8967
8968         * mep-tdep.c (mep_unwind_pc): Delete.
8969         (mep_unwind_sp): Delete.
8970         (mep_dummy_id): Delete.
8971         (mep_gdbarch_init): Don't register deleted functions with
8972         gdbarch.
8973
8974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8975
8976         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8977         (m68hc11_unwind_sp): Delete.
8978         (m68hc11_gdbarch_init): Don't register deleted functions with
8979         gdbarch.
8980
8981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8982
8983         * m32r-tdep.c (m32r_unwind_sp): Delete.
8984         (m32r_unwind_pc): Delete.
8985         (m32r_dummy_id): Delete.
8986         (m32r_gdbarch_init): Don't register deleted functions with
8987         gdbarch.
8988
8989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8990
8991         * m32c-tdep.c (m32c_unwind_pc): Delete.
8992         (m32c_unwind_sp): Delete.
8993         (m32c_dummy_id): Delete.
8994         (m32c_gdbarch_init): Don't register deleted functions with
8995         gdbarch.
8996
8997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9000         (lm32_unwind_pc): Delete.
9001         (lm32_dummy_id): Delete.
9002         (lm32_gdbarch_init): Don't register deleted functions with
9003         gdbarch.
9004
9005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9008         (iq2000_unwind_pc): Delete.
9009         (iq2000_dummy_id): Delete.
9010         (iq2000_gdbarch_init): Don't register deleted functions with
9011         gdbarch.
9012
9013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * nds32-tdep.c (nds32_type_align): Delete.
9016         (nds32_push_dummy_call): Use type_align instead.
9017
9018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9019
9020         * arm-tdep.c (arm_type_align): Only handle vector override case.
9021         (arm_push_dummy_call): Use type_align.
9022         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9023
9024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9025
9026         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9027         case.
9028         (pass_on_stack): Use type_align.
9029         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9030         function.
9031
9032 2019-04-23  Tom Tromey  <tromey@adacore.com>
9033
9034         * dwarf2read.c (line_header::file_name_at): Remove unused
9035         overload.
9036
9037 2019-04-23  Tom de Vries  <tdevries@suse.de>
9038
9039         PR gdb/24438
9040         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9041         invocation.
9042
9043
9044 2019-03-27  Ali Tamur  <tamur@google.com>
9045
9046         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9047         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9048         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9049         (dwarf_expr_context::get_addr_index): Likewise
9050         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9051         (symbol_needs_eval_context::get_addr_index): Likewise
9052         (disassemble_dwarf_expression): Add DW_OP_addrx
9053         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9054         (read_cutu_die_from_dwo): Update comment
9055         (skip_one_die): Add DW_FORM_addrx
9056         (read_attribute_value): Likewise
9057         (var_decode_location): Add DW_OP_addrx
9058         (dwarf2_const_value_attr): Add DW_FORM_addrx
9059         (dump_die_shallow): Likewise
9060         (dwarf2_fetch_constant_bytes): Likewise
9061         (decode_locdesc): Add DW_OP_addrx
9062         (skip_form_bytes): Add DW_FORM_addrx
9063
9064 2019-04-22  Ali Tamur  <tamur@google.com>
9065
9066         * MAINTAINERS (Write After Approval): Add self.
9067
9068 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9069
9070         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9071         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9072         (open_symbol_file_object): Likewise.
9073         (svr4_default_sos): Add info parameter.
9074         (svr4_read_so_list): Likewise.
9075         (svr4_current_sos_direct): Adjust functions calls to pass down
9076         info.
9077         (svr4_current_sos_1): Add info parameter.
9078         (svr4_current_sos): Call get_svr4_info, pass info down to
9079         svr4_current_sos_1.
9080         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9081         get_svr4_info.
9082         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9083         get_svr4_info.
9084         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9085         to get_svr4_info.
9086         (probes_table_remove_objfile_probes): Likewise.
9087         (register_solib_event_probe): Add info parameter.
9088         (solist_update_incremental): Pass info parameter down to
9089         svr4_read_so_list.
9090         (disable_probes_interface): Add info parameter.
9091         (svr4_handle_solib_event): Pass current_program_space to
9092         get_svr4_info.  Adjust disable_probes_interface cleanup.
9093         (svr4_create_probe_breakpoints): Add info parameter, pass it
9094         down to register_solib_event_probe.
9095         (svr4_create_solib_event_breakpoints): Add info parameter,
9096         pass it down to svr4_create_probe_breakpoints.
9097         (enable_break): Pass info down to
9098         svr4_create_solib_event_breakpoints.
9099         (svr4_solib_create_inferior_hook): Pass current_program_space to
9100         get_svr4_info.
9101         (svr4_clear_solib): Likewise.
9102
9103 2019-04-22  Pedro Alves  <palves@redhat.com>
9104
9105         * solib-svr4.c (svr4_free_objfile_observer): New.
9106         (probe_and_action::objfile): New field.
9107         (probes_table_htab_remove_objfile_probes)
9108         (probes_table_remove_objfile_probes): New functions.
9109         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9110         in the new probe_and_action.  Don't store the probe in 'lookup'.
9111         (svr4_create_probe_breakpoints): Pass objfile to
9112         register_solib_event_probe.
9113         (_initialize_svr4_solib): Register a free_objfile observer.
9114
9115 2019-04-19  Tom Tromey  <tom@tromey.com>
9116
9117         * common/queue.h: Remove.
9118
9119 2019-04-19  Tom Tromey  <tom@tromey.com>
9120
9121         * event-loop.c: Don't include "common/queue.h".
9122
9123 2019-04-19  Tom Tromey  <tom@tromey.com>
9124
9125         * remote.c (remote_target): Use delete.
9126         * remote-notif.h: Include <list>, not "common/queue.h".
9127         (notif_client_p): Remove typedef.
9128         (remote_notif_state): Add constructor, destructor, initializer.
9129         <notif_queue>: Now a std::list.
9130         (remote_notif_state_xfree): Don't declare.
9131         * remote-notif.c (remote_notif_process, handle_notification)
9132         (remote_notif_state_allocate): Update.
9133         (~remote_notif_state): Rename from remote_notif_state_xfree.
9134
9135 2019-04-19  Tom Tromey  <tom@tromey.com>
9136
9137         * symfile.c (reread_symbols): Update.
9138         * objfiles.c (objfile_register_static_link)
9139         (objfile_lookup_static_link): Update
9140         (~objfile) Don't delete static_links.
9141         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9142
9143 2019-04-19  Tom Tromey  <tom@tromey.com>
9144
9145         * type-stack.h (struct type_stack) <insert>: Constify string.
9146         * type-stack.c (type_stack::insert): Constify string.
9147         * gdbtypes.h (lookup_template_type): Update.
9148         (address_space_name_to_int): Update.
9149         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9150         const.
9151         (lookup_template_type): Make name const.
9152         * c-exp.y: Update rules.
9153         (lex_one_token, classify_name, classify_inner_name)
9154         (c_print_token): Update.
9155         * p-exp.y: Update rules.
9156         (yylex): Update.
9157         * f-exp.y: Update rules.
9158         (yylex): Update.
9159         * d-exp.y: Update rules.
9160         (lex_one_token, classify_name, classify_inner_name): Update.
9161         * parse.c (write_dollar_variable, copy_name): Return std::string.
9162         * parser-defs.h (copy_name): Change return type.
9163         * m2-exp.y: Update rules.
9164         (yylex): Update.
9165         * go-exp.y (lex_one_token): Update.
9166         Update rules.
9167         (classify_unsafe_function, classify_packaged_name)
9168         (classify_name, yylex): Update.
9169
9170 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9171
9172         * configure.ac: add --enable-source-highlight switch.
9173         * configure: Regenerate.
9174         * top.c (print_gdb_version): plumb --enable-source-highlight
9175         status to "show configuration".
9176
9177 2019-04-19  Tom Tromey  <tromey@adacore.com>
9178
9179         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9180         Check ADA_TYPE_P.
9181         (empty_record, ada_template_to_fixed_record_type_1)
9182         (template_to_static_fixed_type)
9183         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9184         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9185         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9186         macros.
9187
9188 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9189
9190         PR symtab/24423:
9191         * source.c (print_source_lines_base): Advance "iter" when a
9192         control character is seen.
9193
9194 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9195
9196         * inferior.h (struct infcall_suspend_state_deleter):
9197         Catch exception in destructor to avoid crash.
9198
9199 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9200
9201         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9202         close to the add_com "shell".
9203
9204 2019-04-18  Tom Tromey  <tromey@adacore.com>
9205
9206         * process-stratum-target.h (class process_stratum_target)
9207         <stratum>: Add "final".
9208
9209 2019-04-17  Tom Tromey  <tromey@adacore.com>
9210
9211         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9212         against nullptr before use.
9213
9214 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9215
9216         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9217
9218 2019-04-17  Jim Wilson  <jimw@sifive.com>
9219             Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9222         code read might fail, assume 4-byte breakpoint in that case.
9223
9224 2019-04-15  Leszek Swirski  <leszeks@google.com>
9225
9226         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9227         rather than a hand-rolled POD check when checking for forced MEMORY
9228         classification.
9229
9230 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9231
9232         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9233         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9234         function.
9235         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9236         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9237         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9238         declaration.
9239
9240 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9241
9242         * aarch64-linux-nat.c
9243         (aarch64_linux_nat_target::thread_architecture): Add override.
9244         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9245         each VQ.
9246
9247 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9248
9249         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9250
9251 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9254         target types of size 96-bits, add some additional comments, and
9255         check that the builtin type we found was the correct size.
9256
9257 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9258
9259         * utils.c (prompt_for_continue): Don't restore the styling at the
9260         end, as applied_style has the wrong value.  This fixes styling in
9261         long lists of file names that are interrupted by the "Continue?"
9262         prompt.
9263
9264 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9267         * c-lang.c (c_language_defn): Likewise.
9268         (cplus_language_defn): Likewise.
9269         (asm_language_defn): Likewise.
9270         (minimal_language_defn): Likewise.
9271         * d-lang.c (d_language_defn): Likewise.
9272         * f-lang.c (f_language_defn): Likewise.
9273         * go-lang.c (go_language_defn): Likewise.
9274         * language.c (unknown_language_defn): Likewise.
9275         (auto_language_defn): Likewise.
9276         * language.h (struct language_defn): Remove la_magic field.
9277         (LANG_MAGIC): Delete.
9278         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9279         * objc-lang.c (objc_language_defn): Likewise.
9280         * opencl-lang.c (opencl_language_defn): Likewise.
9281         * p-lang.c (pascal_language_defn): Likewise.
9282         * rust-lang.c (rust_language_defn): Likewise.
9283
9284 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * riscv-tdep.c (riscv_type_align): New function.
9287         (riscv_type_alignment): Delete.
9288         (riscv_arg_location): Use 'type_align'.
9289         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9290
9291 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9292
9293         * gdbtypes.c (type_align): A struct with no non-static fields also
9294         has alignment of 1.
9295
9296 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9299         component to 0.
9300         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9301         member.
9302         (riscv_struct_info::analyse): New implementation using new
9303         analyse_inner member function.
9304         (riscv_struct_info::field_offset): New member function.
9305         (riscv_struct_info::m_offsets): New member variable.
9306         (riscv_struct_info::analyse_inner): New private member function,
9307         takes the old implementation of riscv_struct_info::analyse but
9308         extended to track field offsets.
9309         (riscv_call_arg_struct): Update the struct folding special cases
9310         to handle cases where empty C++ structs, which are non-zero
9311         length, are found.
9312         (riscv_arg_location): Initialise the length of each location, a
9313         non-zero length now indicates the location is in use.
9314         (riscv_push_dummy_call): Allow for the first location having a
9315         non-zero offset when setting up arguments.
9316         (riscv_return_value): Likewise, but for return values.
9317
9318 2019-04-11  Tom Tromey  <tromey@adacore.com>
9319
9320         * utils.c (internal_vproblem): Make "msg" const.
9321
9322 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9323
9324         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9325         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9326         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9327         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9328
9329 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9330
9331         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9332         function.
9333         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9334         of amd64_collect_native_gregset.
9335         (amd64_linux_nat_target::store_registers): Likewise.
9336
9337 2019-04-10  Tom Tromey  <tom@tromey.com>
9338
9339         * symtab.c (lookup_global_symbol_from_objfile)
9340         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9341         * objfiles.h (class separate_debug_iterator): New.
9342         (class separate_debug_range): New.
9343         (struct objfile) <separate_debug_objfiles>: New method.
9344         (objfile_separate_debug_iterate): Don't declare.
9345         * objfiles.c (separate_debug_iterator::operator++): Rename from
9346         objfile_separate_debug_iterate.
9347         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9348         iterator.
9349         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9350         iterator.
9351
9352 2019-04-10  Tom Tromey  <tom@tromey.com>
9353
9354         * symfile.c (reread_symbols): Remove old comment.
9355         * objfiles.c (free_all_objfiles): Fix a typo.
9356
9357 2019-04-10  Tom Tromey  <tom@tromey.com>
9358
9359         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9360         * minsyms.c (lookup_minimal_symbol): Use foreach.
9361         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9362         (lookup_minimal_symbol_solib_trampoline): Likewise.
9363         * symfile.c (reread_symbols): Use foreach.
9364
9365 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9366             Tom Tromey  <tromey@adacore.com>
9367
9368         PR rust/24414:
9369         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9370         (rust_lex_int_test): Change "value" to be LONGEST.
9371         (rust_lex_tests): Add test for long integer literal.
9372
9373 2019-04-09  Tom Tromey  <tromey@adacore.com>
9374
9375         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9376         to bool.
9377         (extended_remote_target::attach): Update.
9378         (remote_target::remote_notice_new_inferior): Update.
9379         (remote_target::add_current_inferior_and_thread): Update.
9380         * inferior.c (exit_inferior_1): Use "false".
9381         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9382
9383 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9384
9385         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9386         the "start" command.
9387
9388 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9389
9390         * python/py-inferior.c (infpy_thread_from_thread_handle):
9391         Adjust comments to reflect renaming of thread_from_thread_handle
9392         to thread_from_handle.  Adjust keywords.  Fix type error message.
9393         (inferior_object_methods): Add thread_from_handle.  Retain
9394         thread_from_thread_handle, but mark it as deprecated.
9395
9396 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9397
9398         * gdbthread.h (find_thread_by_handle): Revise declaration.
9399         * thread.c (find_thread_by_handle): Likewise.  Adjust
9400         implementation too.
9401         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9402         support for buffer objects as handles.
9403
9404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9405
9406         * python/py-infthread.c (thpy_thread_handle): New function.
9407         (thread_object_methods): Register thpy_thread_handle.
9408
9409 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9410
9411         * gdbthread.h (thread_to_thread_handle): Declare.
9412         * thread.c (gdbtypes.h): Include.
9413         (thread_to_thread_handle): New function.
9414
9415         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9416         (target_thread_info_to_thread_handle): Declare.
9417         * target.c (target_thread_info_to_thread_handle): New function.
9418         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9419         * target-delegates.c: Regenerate.
9420
9421         * linux-thread-db.c (class thread_db_target): Add method
9422         thread_info_to_thread_handle.
9423         (thread_db_target::thread_info_to_thread_handle): Define.
9424         * remote.c (class remote_target): Add new method
9425         thread_info_to_thread_handle.
9426         (remote_target::thread_info_to_thread_handle): Define.
9427
9428 2019-04-08  Pedro Alves  <palves@redhat.com>
9429
9430         * common/common-exceptions.c (throw_exception): Don't create
9431         named object to throw; throw directly.
9432         (throw_it): Likewise.  Don't initialize gdb_exception::message
9433         here, with new; pass FMT and AP to the ctor instead.
9434         * common/common-exceptions.h: Include <string>.
9435         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9436         const char *, va_list)): New ctor.  Use std::make_shared.
9437         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9438         errors)): Delete.
9439         (gdb_exception_error::gdb_exception_error(enum errors, const char
9440         *, va_list)): New.
9441         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9442         Add assertion.
9443         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9444         errors)): Delete.
9445         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9446         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9447         Add assertion.
9448
9449 2019-04-08  Tom Tromey  <tom@tromey.com>
9450
9451         * valops.c (value_rtti_indirect_type): Replace throw_exception
9452         with throw.
9453         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9454         with throw.
9455         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9456         throw.
9457         * target.c (target_translate_tls_address): Replace throw_exception
9458         with throw.
9459         * stack.c (frame_apply_command_count): Replace throw_exception
9460         with throw.
9461         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9462         throw.
9463         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9464         with throw.
9465         * rs6000-tdep.c (rs6000_frame_cache)
9466         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9467         * remote.c: Replace throw_exception with throw.
9468         * record-full.c (record_full_message, record_full_wait_1)
9469         (record_full_restore): Replace throw_exception with throw.
9470         * record-btrace.c:
9471         (get_thread_current_frame_id, record_btrace_start_replaying)
9472         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9473         (cmd_record_btrace_start): Replace throw_exception with throw.
9474         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9475         throw.
9476         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9477         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9478         * linespec.c:
9479         (find_linespec_symbols): Replace throw_exception with throw.
9480         * infrun.c (displaced_step_prepare, resume): Replace
9481         throw_exception with throw.
9482         * infcmd.c (post_create_inferior): Replace throw_exception with
9483         throw.
9484         * inf-loop.c (inferior_event_handler): Replace throw_exception
9485         with throw.
9486         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9487         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9488         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9489         (get_prev_frame_always, get_frame_pc_if_available)
9490         (get_frame_address_in_block_if_available, get_frame_language):
9491         Replace throw_exception with throw.
9492         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9493         throw_exception with throw.
9494         * eval.c (fetch_subexp_value, evaluate_var_value)
9495         (evaluate_funcall, evaluate_subexp_standard): Replace
9496         throw_exception with throw.
9497         * dwarf2loc.c (call_site_find_chain)
9498         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9499         Replace throw_exception with throw.
9500         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9501         with throw.
9502         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9503         throw.
9504         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9505         * completer.c (complete_line_internal): Replace throw_exception
9506         with throw.
9507         * compile/compile-object-run.c (compile_object_run): Replace
9508         throw_exception with throw.
9509         * cli/cli-script.c (process_next_line): Replace throw_exception
9510         with throw.
9511         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9512         (btrace_enable, btrace_maint_update_pt_packets): Replace
9513         throw_exception with throw.
9514         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9515         throw_exception with throw.
9516         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9517         throw_exception with throw.
9518         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9519         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9520         * aarch64-tdep.c (aarch64_make_prologue_cache)
9521         (aarch64_make_stub_cache): Replace throw_exception with throw.
9522
9523 2019-04-08  Tom Tromey  <tom@tromey.com>
9524
9525         * common/common-exceptions.c (throw_exception): Rename from
9526         throw_exception_cxx.  Remove old copy.  Make argument const.
9527         (throw_it): Create and throw exception objects directly.
9528         * common/common-exceptions.h (throw_exception): Make argument
9529         const.
9530         (struct gdb_exception_error): Add constructor.
9531         (struct gdb_exception_quit): Add constructor.
9532
9533 2019-04-08  Tom Tromey  <tom@tromey.com>
9534
9535         * common/common-exceptions.h (exception_rethrow): Don't declare.
9536         (TRY_SJLJ): Update comment.
9537         (TRY, CATCH, END_CATCH): Remove.
9538         * common/common-exceptions.c (exception_rethrow): Remove.
9539
9540 2019-04-08  Tom Tromey  <tom@tromey.com>
9541
9542         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9543         Remove.
9544         (gdb_exception_error): Rename from
9545         gdb_exception_RETURN_MASK_ERROR.
9546         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9547         (gdb_quit_bad_alloc): Update.
9548         * aarch64-tdep.c: Update.
9549         * ada-lang.c: Update.
9550         * ada-typeprint.c: Update.
9551         * ada-valprint.c: Update.
9552         * amd64-tdep.c: Update.
9553         * arch-utils.c: Update.
9554         * break-catch-throw.c: Update.
9555         * breakpoint.c: Update.
9556         * btrace.c: Update.
9557         * c-varobj.c: Update.
9558         * cli/cli-cmds.c: Update.
9559         * cli/cli-interp.c: Update.
9560         * cli/cli-script.c: Update.
9561         * common/common-exceptions.c: Update.
9562         * common/new-op.c: Update.
9563         * common/selftest.c: Update.
9564         * compile/compile-c-symbols.c: Update.
9565         * compile/compile-cplus-symbols.c: Update.
9566         * compile/compile-object-load.c: Update.
9567         * compile/compile-object-run.c: Update.
9568         * completer.c: Update.
9569         * corelow.c: Update.
9570         * cp-abi.c: Update.
9571         * cp-support.c: Update.
9572         * cp-valprint.c: Update.
9573         * darwin-nat.c: Update.
9574         * disasm-selftests.c: Update.
9575         * dtrace-probe.c: Update.
9576         * dwarf-index-cache.c: Update.
9577         * dwarf-index-write.c: Update.
9578         * dwarf2-frame-tailcall.c: Update.
9579         * dwarf2-frame.c: Update.
9580         * dwarf2loc.c: Update.
9581         * dwarf2read.c: Update.
9582         * eval.c: Update.
9583         * event-loop.c: Update.
9584         * event-top.c: Update.
9585         * exec.c: Update.
9586         * f-valprint.c: Update.
9587         * fbsd-tdep.c: Update.
9588         * frame-unwind.c: Update.
9589         * frame.c: Update.
9590         * gdbtypes.c: Update.
9591         * gnu-v3-abi.c: Update.
9592         * guile/guile-internal.h: Update.
9593         * guile/scm-block.c: Update.
9594         * guile/scm-breakpoint.c: Update.
9595         * guile/scm-cmd.c: Update.
9596         * guile/scm-disasm.c: Update.
9597         * guile/scm-frame.c: Update.
9598         * guile/scm-lazy-string.c: Update.
9599         * guile/scm-math.c: Update.
9600         * guile/scm-param.c: Update.
9601         * guile/scm-ports.c: Update.
9602         * guile/scm-pretty-print.c: Update.
9603         * guile/scm-symbol.c: Update.
9604         * guile/scm-symtab.c: Update.
9605         * guile/scm-type.c: Update.
9606         * guile/scm-value.c: Update.
9607         * i386-linux-tdep.c: Update.
9608         * i386-tdep.c: Update.
9609         * inf-loop.c: Update.
9610         * infcall.c: Update.
9611         * infcmd.c: Update.
9612         * infrun.c: Update.
9613         * jit.c: Update.
9614         * language.c: Update.
9615         * linespec.c: Update.
9616         * linux-fork.c: Update.
9617         * linux-nat.c: Update.
9618         * linux-tdep.c: Update.
9619         * linux-thread-db.c: Update.
9620         * main.c: Update.
9621         * mi/mi-cmd-break.c: Update.
9622         * mi/mi-cmd-stack.c: Update.
9623         * mi/mi-interp.c: Update.
9624         * mi/mi-main.c: Update.
9625         * objc-lang.c: Update.
9626         * p-valprint.c: Update.
9627         * parse.c: Update.
9628         * ppc-linux-tdep.c: Update.
9629         * printcmd.c: Update.
9630         * python/py-arch.c: Update.
9631         * python/py-breakpoint.c: Update.
9632         * python/py-cmd.c: Update.
9633         * python/py-finishbreakpoint.c: Update.
9634         * python/py-frame.c: Update.
9635         * python/py-framefilter.c: Update.
9636         * python/py-gdb-readline.c: Update.
9637         * python/py-inferior.c: Update.
9638         * python/py-infthread.c: Update.
9639         * python/py-lazy-string.c: Update.
9640         * python/py-linetable.c: Update.
9641         * python/py-objfile.c: Update.
9642         * python/py-param.c: Update.
9643         * python/py-prettyprint.c: Update.
9644         * python/py-progspace.c: Update.
9645         * python/py-record-btrace.c: Update.
9646         * python/py-record.c: Update.
9647         * python/py-symbol.c: Update.
9648         * python/py-type.c: Update.
9649         * python/py-unwind.c: Update.
9650         * python/py-utils.c: Update.
9651         * python/py-value.c: Update.
9652         * python/python.c: Update.
9653         * record-btrace.c: Update.
9654         * record-full.c: Update.
9655         * remote-fileio.c: Update.
9656         * remote.c: Update.
9657         * riscv-tdep.c: Update.
9658         * rs6000-aix-tdep.c: Update.
9659         * rs6000-tdep.c: Update.
9660         * rust-exp.y: Update.
9661         * rust-lang.c: Update.
9662         * s390-tdep.c: Update.
9663         * selftest-arch.c: Update.
9664         * solib-dsbt.c: Update.
9665         * solib-frv.c: Update.
9666         * solib-spu.c: Update.
9667         * solib-svr4.c: Update.
9668         * solib.c: Update.
9669         * sparc64-linux-tdep.c: Update.
9670         * stack.c: Update.
9671         * symfile-mem.c: Update.
9672         * symmisc.c: Update.
9673         * target.c: Update.
9674         * thread.c: Update.
9675         * top.c: Update.
9676         * tracefile-tfile.c: Update.
9677         * tui/tui.c: Update.
9678         * typeprint.c: Update.
9679         * unittests/cli-utils-selftests.c: Update.
9680         * unittests/parse-connection-spec-selftests.c: Update.
9681         * valops.c: Update.
9682         * valprint.c: Update.
9683         * value.c: Update.
9684         * varobj.c: Update.
9685         * windows-nat.c: Update.
9686         * x86-linux-nat.c: Update.
9687         * xml-support.c: Update.
9688
9689 2019-04-08  Tom Tromey  <tom@tromey.com>
9690
9691         * xml-support.c: Use C++ exception handling.
9692         * x86-linux-nat.c: Use C++ exception handling.
9693         * windows-nat.c: Use C++ exception handling.
9694         * varobj.c: Use C++ exception handling.
9695         * value.c: Use C++ exception handling.
9696         * valprint.c: Use C++ exception handling.
9697         * valops.c: Use C++ exception handling.
9698         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9699         handling.
9700         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9701         * typeprint.c: Use C++ exception handling.
9702         * tui/tui.c: Use C++ exception handling.
9703         * tracefile-tfile.c: Use C++ exception handling.
9704         * top.c: Use C++ exception handling.
9705         * thread.c: Use C++ exception handling.
9706         * target.c: Use C++ exception handling.
9707         * symmisc.c: Use C++ exception handling.
9708         * symfile-mem.c: Use C++ exception handling.
9709         * stack.c: Use C++ exception handling.
9710         * sparc64-linux-tdep.c: Use C++ exception handling.
9711         * solib.c: Use C++ exception handling.
9712         * solib-svr4.c: Use C++ exception handling.
9713         * solib-spu.c: Use C++ exception handling.
9714         * solib-frv.c: Use C++ exception handling.
9715         * solib-dsbt.c: Use C++ exception handling.
9716         * selftest-arch.c: Use C++ exception handling.
9717         * s390-tdep.c: Use C++ exception handling.
9718         * rust-lang.c: Use C++ exception handling.
9719         * rust-exp.y: Use C++ exception handling.
9720         * rs6000-tdep.c: Use C++ exception handling.
9721         * rs6000-aix-tdep.c: Use C++ exception handling.
9722         * riscv-tdep.c: Use C++ exception handling.
9723         * remote.c: Use C++ exception handling.
9724         * remote-fileio.c: Use C++ exception handling.
9725         * record-full.c: Use C++ exception handling.
9726         * record-btrace.c: Use C++ exception handling.
9727         * python/python.c: Use C++ exception handling.
9728         * python/py-value.c: Use C++ exception handling.
9729         * python/py-utils.c: Use C++ exception handling.
9730         * python/py-unwind.c: Use C++ exception handling.
9731         * python/py-type.c: Use C++ exception handling.
9732         * python/py-symbol.c: Use C++ exception handling.
9733         * python/py-record.c: Use C++ exception handling.
9734         * python/py-record-btrace.c: Use C++ exception handling.
9735         * python/py-progspace.c: Use C++ exception handling.
9736         * python/py-prettyprint.c: Use C++ exception handling.
9737         * python/py-param.c: Use C++ exception handling.
9738         * python/py-objfile.c: Use C++ exception handling.
9739         * python/py-linetable.c: Use C++ exception handling.
9740         * python/py-lazy-string.c: Use C++ exception handling.
9741         * python/py-infthread.c: Use C++ exception handling.
9742         * python/py-inferior.c: Use C++ exception handling.
9743         * python/py-gdb-readline.c: Use C++ exception handling.
9744         * python/py-framefilter.c: Use C++ exception handling.
9745         * python/py-frame.c: Use C++ exception handling.
9746         * python/py-finishbreakpoint.c: Use C++ exception handling.
9747         * python/py-cmd.c: Use C++ exception handling.
9748         * python/py-breakpoint.c: Use C++ exception handling.
9749         * python/py-arch.c: Use C++ exception handling.
9750         * printcmd.c: Use C++ exception handling.
9751         * ppc-linux-tdep.c: Use C++ exception handling.
9752         * parse.c: Use C++ exception handling.
9753         * p-valprint.c: Use C++ exception handling.
9754         * objc-lang.c: Use C++ exception handling.
9755         * mi/mi-main.c: Use C++ exception handling.
9756         * mi/mi-interp.c: Use C++ exception handling.
9757         * mi/mi-cmd-stack.c: Use C++ exception handling.
9758         * mi/mi-cmd-break.c: Use C++ exception handling.
9759         * main.c: Use C++ exception handling.
9760         * linux-thread-db.c: Use C++ exception handling.
9761         * linux-tdep.c: Use C++ exception handling.
9762         * linux-nat.c: Use C++ exception handling.
9763         * linux-fork.c: Use C++ exception handling.
9764         * linespec.c: Use C++ exception handling.
9765         * language.c: Use C++ exception handling.
9766         * jit.c: Use C++ exception handling.
9767         * infrun.c: Use C++ exception handling.
9768         * infcmd.c: Use C++ exception handling.
9769         * infcall.c: Use C++ exception handling.
9770         * inf-loop.c: Use C++ exception handling.
9771         * i386-tdep.c: Use C++ exception handling.
9772         * i386-linux-tdep.c: Use C++ exception handling.
9773         * guile/scm-value.c: Use C++ exception handling.
9774         * guile/scm-type.c: Use C++ exception handling.
9775         * guile/scm-symtab.c: Use C++ exception handling.
9776         * guile/scm-symbol.c: Use C++ exception handling.
9777         * guile/scm-pretty-print.c: Use C++ exception handling.
9778         * guile/scm-ports.c: Use C++ exception handling.
9779         * guile/scm-param.c: Use C++ exception handling.
9780         * guile/scm-math.c: Use C++ exception handling.
9781         * guile/scm-lazy-string.c: Use C++ exception handling.
9782         * guile/scm-frame.c: Use C++ exception handling.
9783         * guile/scm-disasm.c: Use C++ exception handling.
9784         * guile/scm-cmd.c: Use C++ exception handling.
9785         * guile/scm-breakpoint.c: Use C++ exception handling.
9786         * guile/scm-block.c: Use C++ exception handling.
9787         * guile/guile-internal.h: Use C++ exception handling.
9788         * gnu-v3-abi.c: Use C++ exception handling.
9789         * gdbtypes.c: Use C++ exception handling.
9790         * frame.c: Use C++ exception handling.
9791         * frame-unwind.c: Use C++ exception handling.
9792         * fbsd-tdep.c: Use C++ exception handling.
9793         * f-valprint.c: Use C++ exception handling.
9794         * exec.c: Use C++ exception handling.
9795         * event-top.c: Use C++ exception handling.
9796         * event-loop.c: Use C++ exception handling.
9797         * eval.c: Use C++ exception handling.
9798         * dwarf2read.c: Use C++ exception handling.
9799         * dwarf2loc.c: Use C++ exception handling.
9800         * dwarf2-frame.c: Use C++ exception handling.
9801         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9802         * dwarf-index-write.c: Use C++ exception handling.
9803         * dwarf-index-cache.c: Use C++ exception handling.
9804         * dtrace-probe.c: Use C++ exception handling.
9805         * disasm-selftests.c: Use C++ exception handling.
9806         * darwin-nat.c: Use C++ exception handling.
9807         * cp-valprint.c: Use C++ exception handling.
9808         * cp-support.c: Use C++ exception handling.
9809         * cp-abi.c: Use C++ exception handling.
9810         * corelow.c: Use C++ exception handling.
9811         * completer.c: Use C++ exception handling.
9812         * compile/compile-object-run.c: Use C++ exception handling.
9813         * compile/compile-object-load.c: Use C++ exception handling.
9814         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9815         * compile/compile-c-symbols.c: Use C++ exception handling.
9816         * common/selftest.c: Use C++ exception handling.
9817         * common/new-op.c: Use C++ exception handling.
9818         * cli/cli-script.c: Use C++ exception handling.
9819         * cli/cli-interp.c: Use C++ exception handling.
9820         * cli/cli-cmds.c: Use C++ exception handling.
9821         * c-varobj.c: Use C++ exception handling.
9822         * btrace.c: Use C++ exception handling.
9823         * breakpoint.c: Use C++ exception handling.
9824         * break-catch-throw.c: Use C++ exception handling.
9825         * arch-utils.c: Use C++ exception handling.
9826         * amd64-tdep.c: Use C++ exception handling.
9827         * ada-valprint.c: Use C++ exception handling.
9828         * ada-typeprint.c: Use C++ exception handling.
9829         * ada-lang.c: Use C++ exception handling.
9830         * aarch64-tdep.c: Use C++ exception handling.
9831
9832 2019-04-08  Tom Tromey  <tom@tromey.com>
9833
9834         * xml-support.c (gdb_xml_parser::parse): Update.
9835         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9836         * value.c (show_convenience): Update.
9837         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9838         (test_parse_flags_qcs): Update.
9839         * thread.c (thr_try_catch_cmd): Update.
9840         * target.c (target_translate_tls_address): Update.
9841         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9842         (info_frame_command_core, frame_apply_command_count): Update.
9843         * rust-exp.y (rust_lex_exception_test): Update.
9844         * riscv-tdep.c (riscv_print_one_register_info): Update.
9845         * remote.c (remote_target::enable_btrace): Update.
9846         * record-btrace.c (record_btrace_enable_warn): Update.
9847         * python/py-utils.c (gdbpy_convert_exception): Update.
9848         * printcmd.c (do_one_display, print_variable_and_value): Update.
9849         * mi/mi-main.c (mi_print_exception): Update.
9850         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9851         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9852         * linux-nat.c (linux_nat_target::attach): Update.
9853         * linux-fork.c (class scoped_switch_fork_info): Update.
9854         * infrun.c (displaced_step_prepare): Update.
9855         * infcall.c (call_function_by_hand_dummy): Update.
9856         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9857         * gnu-v3-abi.c (print_one_vtable): Update.
9858         * frame.c (get_prev_frame_always): Update.
9859         * f-valprint.c (info_common_command_for_block): Update.
9860         * exec.c (try_open_exec_file): Update.
9861         * exceptions.c (print_exception, exception_print)
9862         (exception_fprintf, exception_print_same): Update.
9863         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9864         * dwarf-index-cache.c (index_cache::store)
9865         (index_cache::lookup_gdb_index): Update.
9866         * darwin-nat.c (maybe_cache_shell): Update.
9867         * cp-valprint.c (cp_print_value_fields): Update.
9868         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9869         (gcc_cplus_symbol_address): Update.
9870         * compile/compile-c-symbols.c (gcc_convert_symbol)
9871         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9872         * common/selftest.c: Update.
9873         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9874         a std::string.
9875         (exception_try_scope_entry, exception_try_scope_exit): Don't
9876         declare.
9877         (struct exception_try_scope): Remove.
9878         (TRY): Don't use exception_try_scope.
9879         (struct gdb_exception): Add constructor, operator=.
9880         <what>: New method.
9881         (struct gdb_exception_RETURN_MASK_ALL)
9882         (struct gdb_exception_RETURN_MASK_ERROR)
9883         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9884         (struct gdb_quit_bad_alloc): Update.
9885         * common/common-exceptions.c (exception_none): Change
9886         initializer.
9887         (struct catcher) <state, exception>: Initialize inline.
9888         <prev>: Remove member.
9889         (current_catcher): Remove.
9890         (catchers): New global.
9891         (exceptions_state_mc_init): Simplify.
9892         (catcher_pop): Remove.
9893         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9894         (try_scope_depth, exception_try_scope_entry)
9895         (exception_try_scope_exit): Remove.
9896         (throw_exception_sjlj): Update.
9897         (exception_messages, exception_messages_size): Remove.
9898         (throw_it): Simplify.
9899         (gdb_exception_sliced_copy): Remove.
9900         (throw_exception_cxx): Update.
9901         * cli/cli-script.c (script_from_file): Update.
9902         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9903         Update.
9904         * ada-valprint.c (ada_val_print): Update.
9905         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9906         (create_excep_cond_exprs): Update.
9907
9908 2019-04-08  Tom Tromey  <tom@tromey.com>
9909
9910         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9911         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9912         (TRY, CATCH, END_CATCH): Remove some definitions.
9913         * common/common-exceptions.c: Don't use GDB_XCPT.
9914         (catcher_list_size): Remove.
9915         (throw_exception, throw_it): Simplify.
9916
9917 2019-04-05  Tom Tromey  <tom@tromey.com>
9918
9919         Revert the header-sorting patch.
9920         * ft32-tdep.c: Revert.
9921         * frv-tdep.c: Revert.
9922         * frv-linux-tdep.c: Revert.
9923         * frame.c: Revert.
9924         * frame-unwind.c: Revert.
9925         * frame-base.c: Revert.
9926         * fork-child.c: Revert.
9927         * findvar.c: Revert.
9928         * findcmd.c: Revert.
9929         * filesystem.c: Revert.
9930         * filename-seen-cache.h: Revert.
9931         * filename-seen-cache.c: Revert.
9932         * fbsd-tdep.c: Revert.
9933         * fbsd-nat.h: Revert.
9934         * fbsd-nat.c: Revert.
9935         * f-valprint.c: Revert.
9936         * f-typeprint.c: Revert.
9937         * f-lang.c: Revert.
9938         * extension.h: Revert.
9939         * extension.c: Revert.
9940         * extension-priv.h: Revert.
9941         * expprint.c: Revert.
9942         * exec.h: Revert.
9943         * exec.c: Revert.
9944         * exceptions.c: Revert.
9945         * event-top.c: Revert.
9946         * event-loop.c: Revert.
9947         * eval.c: Revert.
9948         * elfread.c: Revert.
9949         * dwarf2read.h: Revert.
9950         * dwarf2read.c: Revert.
9951         * dwarf2loc.c: Revert.
9952         * dwarf2expr.h: Revert.
9953         * dwarf2expr.c: Revert.
9954         * dwarf2-frame.c: Revert.
9955         * dwarf2-frame-tailcall.c: Revert.
9956         * dwarf-index-write.h: Revert.
9957         * dwarf-index-write.c: Revert.
9958         * dwarf-index-common.c: Revert.
9959         * dwarf-index-cache.h: Revert.
9960         * dwarf-index-cache.c: Revert.
9961         * dummy-frame.c: Revert.
9962         * dtrace-probe.c: Revert.
9963         * disasm.h: Revert.
9964         * disasm.c: Revert.
9965         * disasm-selftests.c: Revert.
9966         * dictionary.c: Revert.
9967         * dicos-tdep.c: Revert.
9968         * demangle.c: Revert.
9969         * dcache.h: Revert.
9970         * dcache.c: Revert.
9971         * darwin-nat.h: Revert.
9972         * darwin-nat.c: Revert.
9973         * darwin-nat-info.c: Revert.
9974         * d-valprint.c: Revert.
9975         * d-namespace.c: Revert.
9976         * d-lang.c: Revert.
9977         * ctf.c: Revert.
9978         * csky-tdep.c: Revert.
9979         * csky-linux-tdep.c: Revert.
9980         * cris-tdep.c: Revert.
9981         * cris-linux-tdep.c: Revert.
9982         * cp-valprint.c: Revert.
9983         * cp-support.c: Revert.
9984         * cp-namespace.c: Revert.
9985         * cp-abi.c: Revert.
9986         * corelow.c: Revert.
9987         * corefile.c: Revert.
9988         * continuations.c: Revert.
9989         * completer.h: Revert.
9990         * completer.c: Revert.
9991         * complaints.c: Revert.
9992         * coffread.c: Revert.
9993         * coff-pe-read.c: Revert.
9994         * cli-out.h: Revert.
9995         * cli-out.c: Revert.
9996         * charset.c: Revert.
9997         * c-varobj.c: Revert.
9998         * c-valprint.c: Revert.
9999         * c-typeprint.c: Revert.
10000         * c-lang.c: Revert.
10001         * buildsym.c: Revert.
10002         * buildsym-legacy.c: Revert.
10003         * build-id.h: Revert.
10004         * build-id.c: Revert.
10005         * btrace.c: Revert.
10006         * bsd-uthread.c: Revert.
10007         * breakpoint.h: Revert.
10008         * breakpoint.c: Revert.
10009         * break-catch-throw.c: Revert.
10010         * break-catch-syscall.c: Revert.
10011         * break-catch-sig.c: Revert.
10012         * blockframe.c: Revert.
10013         * block.c: Revert.
10014         * bfin-tdep.c: Revert.
10015         * bfin-linux-tdep.c: Revert.
10016         * bfd-target.c: Revert.
10017         * bcache.c: Revert.
10018         * ax-general.c: Revert.
10019         * ax-gdb.h: Revert.
10020         * ax-gdb.c: Revert.
10021         * avr-tdep.c: Revert.
10022         * auxv.c: Revert.
10023         * auto-load.c: Revert.
10024         * arm-wince-tdep.c: Revert.
10025         * arm-tdep.c: Revert.
10026         * arm-symbian-tdep.c: Revert.
10027         * arm-pikeos-tdep.c: Revert.
10028         * arm-obsd-tdep.c: Revert.
10029         * arm-nbsd-tdep.c: Revert.
10030         * arm-nbsd-nat.c: Revert.
10031         * arm-linux-tdep.c: Revert.
10032         * arm-linux-nat.c: Revert.
10033         * arm-fbsd-tdep.c: Revert.
10034         * arm-fbsd-nat.c: Revert.
10035         * arm-bsd-tdep.c: Revert.
10036         * arch-utils.c: Revert.
10037         * arc-tdep.c: Revert.
10038         * arc-newlib-tdep.c: Revert.
10039         * annotate.h: Revert.
10040         * annotate.c: Revert.
10041         * amd64-windows-tdep.c: Revert.
10042         * amd64-windows-nat.c: Revert.
10043         * amd64-tdep.c: Revert.
10044         * amd64-sol2-tdep.c: Revert.
10045         * amd64-obsd-tdep.c: Revert.
10046         * amd64-obsd-nat.c: Revert.
10047         * amd64-nbsd-tdep.c: Revert.
10048         * amd64-nbsd-nat.c: Revert.
10049         * amd64-nat.c: Revert.
10050         * amd64-linux-tdep.c: Revert.
10051         * amd64-linux-nat.c: Revert.
10052         * amd64-fbsd-tdep.c: Revert.
10053         * amd64-fbsd-nat.c: Revert.
10054         * amd64-dicos-tdep.c: Revert.
10055         * amd64-darwin-tdep.c: Revert.
10056         * amd64-bsd-nat.c: Revert.
10057         * alpha-tdep.c: Revert.
10058         * alpha-obsd-tdep.c: Revert.
10059         * alpha-nbsd-tdep.c: Revert.
10060         * alpha-mdebug-tdep.c: Revert.
10061         * alpha-linux-tdep.c: Revert.
10062         * alpha-linux-nat.c: Revert.
10063         * alpha-bsd-tdep.c: Revert.
10064         * alpha-bsd-nat.c: Revert.
10065         * aix-thread.c: Revert.
10066         * agent.c: Revert.
10067         * addrmap.c: Revert.
10068         * ada-varobj.c: Revert.
10069         * ada-valprint.c: Revert.
10070         * ada-typeprint.c: Revert.
10071         * ada-tasks.c: Revert.
10072         * ada-lang.c: Revert.
10073         * aarch64-tdep.c: Revert.
10074         * aarch64-ravenscar-thread.c: Revert.
10075         * aarch64-newlib-tdep.c: Revert.
10076         * aarch64-linux-tdep.c: Revert.
10077         * aarch64-linux-nat.c: Revert.
10078         * aarch64-fbsd-tdep.c: Revert.
10079         * aarch64-fbsd-nat.c: Revert.
10080         * aarch32-linux-nat.c: Revert.
10081
10082 2019-04-05  Tom Tromey  <tom@tromey.com>
10083
10084         * ft32-tdep.c: Sort headers.
10085         * frv-tdep.c: Sort headers.
10086         * frv-linux-tdep.c: Sort headers.
10087         * frame.c: Sort headers.
10088         * frame-unwind.c: Sort headers.
10089         * frame-base.c: Sort headers.
10090         * fork-child.c: Sort headers.
10091         * findvar.c: Sort headers.
10092         * findcmd.c: Sort headers.
10093         * filesystem.c: Sort headers.
10094         * filename-seen-cache.h: Sort headers.
10095         * filename-seen-cache.c: Sort headers.
10096         * fbsd-tdep.c: Sort headers.
10097         * fbsd-nat.h: Sort headers.
10098         * fbsd-nat.c: Sort headers.
10099         * f-valprint.c: Sort headers.
10100         * f-typeprint.c: Sort headers.
10101         * f-lang.c: Sort headers.
10102         * extension.h: Sort headers.
10103         * extension.c: Sort headers.
10104         * extension-priv.h: Sort headers.
10105         * expprint.c: Sort headers.
10106         * exec.h: Sort headers.
10107         * exec.c: Sort headers.
10108         * exceptions.c: Sort headers.
10109         * event-top.c: Sort headers.
10110         * event-loop.c: Sort headers.
10111         * eval.c: Sort headers.
10112         * elfread.c: Sort headers.
10113         * dwarf2read.h: Sort headers.
10114         * dwarf2read.c: Sort headers.
10115         * dwarf2loc.c: Sort headers.
10116         * dwarf2expr.h: Sort headers.
10117         * dwarf2expr.c: Sort headers.
10118         * dwarf2-frame.c: Sort headers.
10119         * dwarf2-frame-tailcall.c: Sort headers.
10120         * dwarf-index-write.h: Sort headers.
10121         * dwarf-index-write.c: Sort headers.
10122         * dwarf-index-common.c: Sort headers.
10123         * dwarf-index-cache.h: Sort headers.
10124         * dwarf-index-cache.c: Sort headers.
10125         * dummy-frame.c: Sort headers.
10126         * dtrace-probe.c: Sort headers.
10127         * disasm.h: Sort headers.
10128         * disasm.c: Sort headers.
10129         * disasm-selftests.c: Sort headers.
10130         * dictionary.c: Sort headers.
10131         * dicos-tdep.c: Sort headers.
10132         * demangle.c: Sort headers.
10133         * dcache.h: Sort headers.
10134         * dcache.c: Sort headers.
10135         * darwin-nat.h: Sort headers.
10136         * darwin-nat.c: Sort headers.
10137         * darwin-nat-info.c: Sort headers.
10138         * d-valprint.c: Sort headers.
10139         * d-namespace.c: Sort headers.
10140         * d-lang.c: Sort headers.
10141         * ctf.c: Sort headers.
10142         * csky-tdep.c: Sort headers.
10143         * csky-linux-tdep.c: Sort headers.
10144         * cris-tdep.c: Sort headers.
10145         * cris-linux-tdep.c: Sort headers.
10146         * cp-valprint.c: Sort headers.
10147         * cp-support.c: Sort headers.
10148         * cp-namespace.c: Sort headers.
10149         * cp-abi.c: Sort headers.
10150         * corelow.c: Sort headers.
10151         * corefile.c: Sort headers.
10152         * continuations.c: Sort headers.
10153         * completer.h: Sort headers.
10154         * completer.c: Sort headers.
10155         * complaints.c: Sort headers.
10156         * coffread.c: Sort headers.
10157         * coff-pe-read.c: Sort headers.
10158         * cli-out.h: Sort headers.
10159         * cli-out.c: Sort headers.
10160         * charset.c: Sort headers.
10161         * c-varobj.c: Sort headers.
10162         * c-valprint.c: Sort headers.
10163         * c-typeprint.c: Sort headers.
10164         * c-lang.c: Sort headers.
10165         * buildsym.c: Sort headers.
10166         * buildsym-legacy.c: Sort headers.
10167         * build-id.h: Sort headers.
10168         * build-id.c: Sort headers.
10169         * btrace.c: Sort headers.
10170         * bsd-uthread.c: Sort headers.
10171         * breakpoint.h: Sort headers.
10172         * breakpoint.c: Sort headers.
10173         * break-catch-throw.c: Sort headers.
10174         * break-catch-syscall.c: Sort headers.
10175         * break-catch-sig.c: Sort headers.
10176         * blockframe.c: Sort headers.
10177         * block.c: Sort headers.
10178         * bfin-tdep.c: Sort headers.
10179         * bfin-linux-tdep.c: Sort headers.
10180         * bfd-target.c: Sort headers.
10181         * bcache.c: Sort headers.
10182         * ax-general.c: Sort headers.
10183         * ax-gdb.h: Sort headers.
10184         * ax-gdb.c: Sort headers.
10185         * avr-tdep.c: Sort headers.
10186         * auxv.c: Sort headers.
10187         * auto-load.c: Sort headers.
10188         * arm-wince-tdep.c: Sort headers.
10189         * arm-tdep.c: Sort headers.
10190         * arm-symbian-tdep.c: Sort headers.
10191         * arm-pikeos-tdep.c: Sort headers.
10192         * arm-obsd-tdep.c: Sort headers.
10193         * arm-nbsd-tdep.c: Sort headers.
10194         * arm-nbsd-nat.c: Sort headers.
10195         * arm-linux-tdep.c: Sort headers.
10196         * arm-linux-nat.c: Sort headers.
10197         * arm-fbsd-tdep.c: Sort headers.
10198         * arm-fbsd-nat.c: Sort headers.
10199         * arm-bsd-tdep.c: Sort headers.
10200         * arch-utils.c: Sort headers.
10201         * arc-tdep.c: Sort headers.
10202         * arc-newlib-tdep.c: Sort headers.
10203         * annotate.h: Sort headers.
10204         * annotate.c: Sort headers.
10205         * amd64-windows-tdep.c: Sort headers.
10206         * amd64-windows-nat.c: Sort headers.
10207         * amd64-tdep.c: Sort headers.
10208         * amd64-sol2-tdep.c: Sort headers.
10209         * amd64-obsd-tdep.c: Sort headers.
10210         * amd64-obsd-nat.c: Sort headers.
10211         * amd64-nbsd-tdep.c: Sort headers.
10212         * amd64-nbsd-nat.c: Sort headers.
10213         * amd64-nat.c: Sort headers.
10214         * amd64-linux-tdep.c: Sort headers.
10215         * amd64-linux-nat.c: Sort headers.
10216         * amd64-fbsd-tdep.c: Sort headers.
10217         * amd64-fbsd-nat.c: Sort headers.
10218         * amd64-dicos-tdep.c: Sort headers.
10219         * amd64-darwin-tdep.c: Sort headers.
10220         * amd64-bsd-nat.c: Sort headers.
10221         * alpha-tdep.c: Sort headers.
10222         * alpha-obsd-tdep.c: Sort headers.
10223         * alpha-nbsd-tdep.c: Sort headers.
10224         * alpha-mdebug-tdep.c: Sort headers.
10225         * alpha-linux-tdep.c: Sort headers.
10226         * alpha-linux-nat.c: Sort headers.
10227         * alpha-bsd-tdep.c: Sort headers.
10228         * alpha-bsd-nat.c: Sort headers.
10229         * aix-thread.c: Sort headers.
10230         * agent.c: Sort headers.
10231         * addrmap.c: Sort headers.
10232         * ada-varobj.c: Sort headers.
10233         * ada-valprint.c: Sort headers.
10234         * ada-typeprint.c: Sort headers.
10235         * ada-tasks.c: Sort headers.
10236         * ada-lang.c: Sort headers.
10237         * aarch64-tdep.c: Sort headers.
10238         * aarch64-ravenscar-thread.c: Sort headers.
10239         * aarch64-newlib-tdep.c: Sort headers.
10240         * aarch64-linux-tdep.c: Sort headers.
10241         * aarch64-linux-nat.c: Sort headers.
10242         * aarch64-fbsd-tdep.c: Sort headers.
10243         * aarch64-fbsd-nat.c: Sort headers.
10244         * aarch32-linux-nat.c: Sort headers.
10245
10246 2019-04-04  Tom Tromey  <tom@tromey.com>
10247
10248         * varobj.c (varobj_create): Update.
10249         * rust-exp.y (struct rust_parser) <update_innermost_block,
10250         lookup_symbol>: New methods.
10251         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10252         Rename.
10253         (rust_parser::rust_lookup_type)
10254         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10255         * printcmd.c (display_command, do_one_display): Update.
10256         * parser-defs.h (struct parser_state) <parser_state>: Add
10257         "tracker" parameter.
10258         (block_tracker): New member.
10259         (class innermost_block_tracker) <innermost_block_tracker>: Add
10260         "types" parameter.
10261         <reset>: Remove method.
10262         (innermost_block): Don't declare.
10263         (null_post_parser): Update.
10264         * parse.c (innermost_block): Remove global.
10265         (write_dollar_variable): Update.
10266         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10267         Remove "tracker_types" parameter.
10268         (parse_expression): Add "tracker" parameter.
10269         (parse_expression_for_completion): Update.
10270         (null_post_parser): Add "tracker" parameter.
10271         * p-exp.y: Update rules.
10272         * m2-exp.y: Update rules.
10273         * language.h (struct language_defn) <la_post_parser>: Add
10274         "tracker" parameter.
10275         * go-exp.y: Update rules.
10276         * f-exp.y: Update rules.
10277         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10278         parameter.
10279         * d-exp.y: Update rules.
10280         * c-exp.y: Update rules.
10281         * breakpoint.c (set_breakpoint_condition): Create an
10282         innermost_block_tracker.
10283         (watch_command_1): Likewise.
10284         * ada-lang.c (resolve): Add "tracker" parameter.
10285         (resolve_subexp): Likewise.
10286         * ada-exp.y (write_var_from_sym): Update.
10287
10288 2019-04-04  Tom Tromey  <tom@tromey.com>
10289
10290         * type-stack.h: New file.
10291         * type-stack.c: New file.
10292         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10293         type-stack.h.
10294         (insert_into_type_stack, insert_type, push_type, push_type_int)
10295         (insert_type_address_space, pop_type, pop_type_int)
10296         (pop_typelist, pop_type_stack, append_type_stack)
10297         (push_type_stack, get_type_stack, push_typelist)
10298         (follow_type_instance_flags, follow_types): Don't declare.
10299         * parse.c (type_stack): Remove global.
10300         (parse_exp_in_context): Update.
10301         (insert_into_type_stack, insert_type, push_type, push_type_int)
10302         (insert_type_address_space, pop_type, pop_type_int)
10303         (pop_typelist, pop_type_stack, append_type_stack)
10304         (push_type_stack, get_type_stack, push_typelist)
10305         (follow_type_instance_flags, follow_types): Remove (moved to
10306         type-stack.c).
10307         * f-exp.y (type_stack): New global.
10308         Update rules.
10309         (push_kind_type, f_parse): Update.
10310         * d-exp.y (type_stack): New global.
10311         Update rules.
10312         (d_parse): Update.
10313         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10314         Update rules.
10315         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10316         (HFILES_NO_SRCDIR): Add type-stack.h.
10317
10318 2019-04-04  Tom Tromey  <tom@tromey.com>
10319
10320         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10321         (rust_parser::convert_ast_to_expression, rust_parse)
10322         (rust_lex_test_completion, rust_lex_tests): Update.
10323         * parser-defs.h (struct expr_completion_state): New.
10324         (struct parser_state) <parser_state>: Add completion parameter.
10325         <mark_struct_expression, mark_completion_tag>: New methods.
10326         <parse_completion, m_completion_state>: New members.
10327         (prefixify_expression, null_post_parser): Update.
10328         (mark_struct_expression, mark_completion_tag): Don't declare.
10329         * parse.c (parse_completion, expout_last_struct)
10330         (expout_tag_completion_type, expout_completion_name): Remove
10331         globals.
10332         (parser_state::mark_struct_expression)
10333         (parser_state::mark_completion_tag): Now methods.
10334         (prefixify_expression): Add last_struct parameter.
10335         (prefixify_subexp): Likewise.
10336         (parse_exp_1): Update.
10337         (parse_exp_in_context): Add cstate parameter.  Update.
10338         (parse_expression_for_completion): Create an
10339         expr_completion_state.
10340         (null_post_parser): Add "completion" parameter.
10341         * p-exp.y: Update rules.
10342         (yylex): Update.
10343         * language.h (struct language_defn) <la_post_parser>: Add
10344         "completing" parameter.
10345         * go-exp.y: Update rules.
10346         (lex_one_token): Update.
10347         * expression.h (parse_completion): Don't declare.
10348         * d-exp.y: Update rules.
10349         (lex_one_token): Update rules.
10350         * c-exp.y: Update rules.
10351         (lex_one_token): Update.
10352         * ada-lang.c (resolve): Add "parse_completion" parameter.
10353         (resolve_subexp): Likewise.
10354         (ada_resolve_function): Likewise.
10355
10356 2019-04-04  Tom Tromey  <tom@tromey.com>
10357
10358         * parser-defs.h (struct parser_state) <start_arglist,
10359         end_arglist>: New methods.
10360         <arglist_len, m_funcall_chain>: New members.
10361         (arglist_len, start_arglist, end_arglist): Don't declare.
10362         * parse.c (arglist_len, funcall_chain): Remove global.
10363         (start_arglist, end_arglist): Remove functions.
10364         (parse_exp_in_context): Update.
10365         * p-exp.y: Update rules.
10366         * m2-exp.y: Update rules.
10367         * go-exp.y: Update rules.
10368         * f-exp.y: Update rules.
10369         * d-exp.y: Update rules.
10370         * c-exp.y: Update rules.
10371
10372 2019-04-04  Tom Tromey  <tom@tromey.com>
10373
10374         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10375         lex_operator, push_back>: New methods.
10376         Update all rules.
10377         (rust_parser::lex_hex, lex_escape): Rename and update.
10378         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10379         (rust_parser::lex_operator): Rename and update.
10380         (rust_parser::lex_number, rustyylex, rustyyerror)
10381         (rust_lex_test_init, rust_lex_test_sequence)
10382         (rust_lex_test_push_back, rust_lex_tests): Update.
10383         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10384         parameter.
10385         <lexptr, prev_lexptr>: New members.
10386         (lexptr, prev_lexptr): Don't declare.
10387         * parse.c (lexptr, prev_lexptr): Remove globals.
10388         (parse_exp_in_context): Update.
10389         * p-exp.y (yylex, yyerror): Update.
10390         * m2-exp.y (parse_number, yylex, yyerror): Update.
10391         * go-exp.y (lex_one_token, yyerror): Update.
10392         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10393         * d-exp.y (lex_one_token, yyerror): Update.
10394         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10395         (lex_one_token, yyerror): Update.
10396         * ada-lex.l (YY_INPUT): Update.
10397         (rewind_to_char): Update.
10398         * ada-exp.y (yyerror): Update.
10399
10400 2019-04-04  Tom Tromey  <tom@tromey.com>
10401
10402         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10403         * parser-defs.h (struct parser_state) <parser_state>: Add new
10404         parameter.
10405         <comma_terminates>: New member.
10406         (comma_terminates): Don't declare global.
10407         * parse.c (comma_terminates): Remove global.
10408         (parse_exp_in_context): Update.
10409         * p-exp.y (yylex): Update.
10410         * m2-exp.y (yylex): Update.
10411         * go-exp.y (lex_one_token): Update.
10412         * f-exp.y (yylex): Update.
10413         * d-exp.y (lex_one_token): Update.
10414         * c-exp.y (lex_one_token): Update.
10415         * ada-lex.l: Update.
10416
10417 2019-04-04  Tom Tromey  <tom@tromey.com>
10418
10419         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10420         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10421         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10422         * parser-defs.h (paren_depth): Don't declare.
10423         * parse.c (paren_depth): Remove global.
10424         (parse_exp_in_context): Update.
10425         * p-exp.y (paren_depth): New global.
10426         (pascal_parse): Initialize it.
10427         * m2-exp.y (paren_depth): New global.
10428         (m2_parse): Initialize it.
10429         * go-exp.y (paren_depth): New global.
10430         (go_parse): Initialize it.
10431         * f-exp.y (paren_depth): New global.
10432         (f_parse): Initialize it.
10433         * d-exp.y (paren_depth): New global.
10434         (d_parse): Initialize it.
10435         * c-exp.y (paren_depth): New global.
10436         (c_parse): Initialize it.
10437         * ada-lex.l (paren_depth): New global.
10438         (lexer_init): Initialize it.
10439
10440 2019-04-04  Tom Tromey  <tom@tromey.com>
10441
10442         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10443         (rust_parser::convert_ast_to_type)
10444         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10445         * parser-defs.h (struct parser_state) <parser_state>: Add
10446         parameters.  Initialize new members.
10447         <expression_context_block, expression_context_pc>: New members.
10448         * parse.c (expression_context_block, expression_context_pc):
10449         Remove globals.
10450         (parse_exp_in_context): Update.
10451         * p-exp.y: Update all rules.
10452         (yylex): Update.
10453         * m2-exp.y: Update all rules.
10454         (yylex): Update.
10455         * go-exp.y (yylex): Update.
10456         * f-exp.y (yylex): Update.
10457         * d-exp.y: Update all rules.
10458         (yylex): Update.
10459         * c-exp.y: Update all rules.
10460         (lex_one_token, classify_name, yylex, c_parse): Update.
10461         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10462
10463 2019-04-04  Tom Tromey  <tom@tromey.com>
10464
10465         * gdbarch.h, gdbarch.c: Rebuild.
10466         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10467         * stap-probe.h:
10468         (struct stap_parse_info): Replace "parser_state" with
10469         "expr_builder".
10470         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10471         (parser_state): New class.
10472         * parse.c (expr_builder): Rename.
10473         (expr_builder::release): Rename.
10474         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10475         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10476         (write_exp_elt_longcst, write_exp_elt_floatcst)
10477         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10478         (write_exp_string_vector, write_exp_bitstring)
10479         (write_exp_msymbol, mark_struct_expression)
10480         (write_dollar_variable)
10481         (insert_type_address_space, increase_expout_size): Replace
10482         "parser_state" with "expr_builder".
10483         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10484         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10485         "parser_state" with "expr_builder".
10486
10487 2019-04-04  Tom Tromey  <tom@tromey.com>
10488
10489         * rust-exp.y: Replace "parse_language" with method call.
10490         * p-exp.y:
10491         (yylex): Replace "parse_language" with method call.
10492         * m2-exp.y:
10493         (yylex): Replace "parse_language" with method call.
10494         * go-exp.y (classify_name): Replace "parse_language" with method
10495         call.
10496         * f-exp.y (yylex): Replace "parse_language" with method call.
10497         * d-exp.y (lex_one_token): Replace "parse_language" with method
10498         call.
10499         * c-exp.y:
10500         (lex_one_token, classify_name, yylex): Replace "parse_language"
10501         with method call.
10502         * ada-exp.y (find_primitive_type, type_char)
10503         (type_system_address): Replace "parse_language" with method call.
10504
10505 2019-04-04  Tom Tromey  <tom@tromey.com>
10506
10507         * rust-exp.y: Replace "parse_gdbarch" with method call.
10508         * parse.c (write_dollar_variable, insert_type_address_space):
10509         Replace "parse_gdbarch" with method call.
10510         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10511         call.
10512         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10513         call.
10514         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10515         "parse_gdbarch" with method call.
10516         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10517         with method call.
10518         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10519         "parse_gdbarch" with method call.
10520         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10521         "parse_gdbarch" with method call.
10522         * c-exp.y (parse_type, parse_number, classify_name): Replace
10523         "parse_gdbarch" with method call.
10524         * ada-lex.l: Replace "parse_gdbarch" with method call.
10525         * ada-exp.y (parse_type, find_primitive_type, type_char)
10526         (type_system_address): Replace "parse_gdbarch" with method call.
10527
10528 2019-04-04  Tom Tromey  <tom@tromey.com>
10529
10530         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10531         * stap-probe.c (stap_parse_argument): Update.
10532         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10533         initial_size parameter.
10534         * rust-exp.y (rust_lex_tests): Update.
10535         * parse.c (parser_state): Update.
10536         (parse_exp_in_context): Update.
10537         * parser-defs.h (struct parser_state) <parser_state>: Remove
10538         "initial_size" parameter.
10539
10540 2019-04-04  Tom Tromey  <tom@tromey.com>
10541
10542         * parser-defs.h (increase_expout_size): Don't declare.
10543         * parse.c (increase_expout_size): Now static.
10544
10545 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10546
10547         * gnu-nat.c (gnu_nat_target::wait): Fix
10548         target_waitstatus_to_string call.
10549
10550 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10551
10552         * eval.c (evaluate_subexp_standard): Handle internal functions
10553         during Fortran function call handling.
10554
10555 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * NEWS: Mention new internal functions.
10558         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10559         (read_base_type): Use dwarf2_init_complex_target_type.
10560         * value.c (creal_internal_fn): New function.
10561         (cimag_internal_fn): New function.
10562         (_initialize_values): Register new internal functions.
10563
10564 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10565
10566         * infrun.c (stop_all_threads): If debug_infrun, always
10567         trace the wait status after wait_one, using
10568         target_waitstatus_to_string and target_pid_to_str.
10569         (handle_inferior_event): Replace various trace of
10570         wait status kind by a single trace.
10571         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10572         wait status kind image by target_waitstatus_to_string.
10573         * target/waitstatus.c (target_waitstatus_to_string): Fix
10574         obsolete comment.
10575
10576 2019-04-01  Tom Tromey  <tromey@adacore.com>
10577
10578         PR symtab/23331:
10579         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10580
10581 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10582             Pedro Alves  <palves@redhat.com>
10583
10584         * top.c (quit_force): Call 'finalize_values'.
10585         * value.c (finalize_values): New function.
10586         * value.h (finalize_values): Declare.
10587
10588 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10589
10590         * NEWS: Announce $_gdb_major and $_gdb_minor.
10591
10592         * top.c (init_gdb_version_vars): New function.
10593         (gdb_init): Call init_gdb_version_vars.
10594
10595 2019-03-29  Tom Tromey  <tromey@adacore.com>
10596
10597         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10598         help text.  Remove dead code.
10599
10600 2019-03-29  Keith Seitz  <keiths@redhat.com>
10601
10602         From Siddhesh Poyarekar:
10603         * f-lang.h (f77_get_upperbound): Return LONGEST.
10604         (f77_get_lowerbound): Likewise.
10605         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10606         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10607         print them.
10608         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10609         plongest to format print it.
10610         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10611         (f77_get_upperbound): Likewise.
10612         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10613         LOWER_BOUND to LONGEST.
10614         (f77_create_arrayprint_offset_tbl): Likewise.
10615
10616 2019-03-29  Keith Seitz  <keiths@redhat.com>
10617
10618         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10619         %s/pulongest for TYPE_LENGTH instead of %d in format
10620         strings.
10621         * ada-typerint.c (ada_print_type): Likewise.
10622         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10623         * compile/compile-c-support.c (generate_register_struct): Likewise.
10624         * gdbtypes.c (recursive_dump_type): Likewise.
10625         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10626         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10627         instead of %d in format strings.
10628         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10629         to std::min to ULONGEST.
10630         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10631         instead of %d in format strings.
10632         * tracepoint.c (info_scope_command): Likewise.
10633         * typeprint.c (print_offset_data::update)
10634         (print_offset_data::finish): Likewise.
10635         * xtensa-tdep.c (xtensa_store_return_value)
10636         (xtensa_push_dummy_call): Likewise.
10637
10638 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10639
10640         * windows-nat.c (display_selector): Fixed format specifications
10641         for 64-bit Cygwin.
10642
10643 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10644
10645         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10646
10647 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10648
10649         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10650         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10651         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10652         (nios2_linux_init_abi): Install it.
10653
10654 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10655
10656         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10657
10658 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10659
10660         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10661
10662 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10663             Tom Tromey  <tromey@adacore.com>
10664
10665         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10666
10667 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10668
10669         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10670         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10671         method to compute the bounds of range types. Also print "[evaluated]"
10672         if the bounds' values come from a dynamic evaluation.
10673
10674 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10675
10676         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10677         whitespace when pretty printing is on.
10678
10679 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10680
10681         * ppc-linux-nat.c: Add include.
10682
10683 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10684
10685         * NEWS: Mention AArch64 Pointer Authentication.
10686
10687 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10688
10689         * arm-linux-nat.c: Add include.
10690
10691 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10692
10693         * source-cache.c (source_cache::get_source_lines): Re-read
10694         fullname after calling open_source_file.
10695
10696 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10697
10698         * NEWS: Mention TLS support for FreeBSD.
10699
10700 2019-03-25  Tom Tromey  <tromey@adacore.com>
10701
10702         * minsyms.c (BUNCH_SIZE): Update comment.
10703         (~minimal_symbol_reader): Remove old comment.
10704         (compact_minimal_symbols): Update comment.
10705         (minimal_symbol_reader::install): Remove old comment.  Update
10706         other comments.
10707
10708 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10709
10710         * s390-linux-nat.c: Add include.
10711
10712 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10713
10714         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10715         Call linux_get_hwcap.
10716         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10717         Likewise.
10718         (aarch64_linux_get_hwcap): Remove function.
10719         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10720         declaration.
10721         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10722         linux_get_hwcap.
10723         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10724         * linux-tdep.c (linux_get_hwcap): Add function.
10725         (linux_get_hwcap2): Likewise.
10726         * linux-tdep.h (linux_get_hwcap): Add declaration.
10727         (linux_get_hwcap2): Likewise.
10728         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10729         (ppc_linux_get_hwcap2): Likewise.
10730         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10731         linux_get_hwcap.
10732         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10733         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10734         (ppc_linux_nat_target::read_description): Likewise.
10735         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10736         * s390-linux-nat.c: Likewise.
10737         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10738
10739 2019-03-24  Tom Tromey  <tom@tromey.com>
10740
10741         * ada-lang.c (standard_lookup): Simplify initialization.
10742         (ada_lookup_symbol_nonlocal): Simplify return.
10743         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10744         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10745         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10746         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10747         initialization.
10748         * solib.c (solib_global_lookup): Simplify.
10749         * symtab.c (null_block_symbol): Remove.
10750         (symbol_cache_lookup): Simplify returns.
10751         (lookup_language_this): Simplify returns.
10752         (lookup_symbol_aux): Simplify return.
10753         (lookup_local_symbol): Simplify returns.
10754         (lookup_global_symbol_from_objfile): Simplify return.
10755         (lookup_symbol_in_objfile_symtabs)
10756         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10757         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10758         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10759         * cp-namespace.c (cp_lookup_bare_symbol)
10760         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10761         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10762         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10763         (cp_lookup_symbol_via_imports): Simplify initialization.
10764         (find_symbol_in_baseclass): Likewise.
10765         * symtab.h (null_block_symbol): Remove.
10766         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10767         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10768         (d_lookup_symbol_module): Likewise.
10769         (find_symbol_in_baseclass): Simplify initialization.
10770
10771 2019-03-24  Tom Tromey  <tom@tromey.com>
10772
10773         * expression.h: Don't include symtab.h.
10774         (struct block): Forward declare.
10775
10776 2019-03-24  Tom Tromey  <tom@tromey.com>
10777
10778         * c-exp.y (typebase): Remove casts.
10779         * gdbtypes.c (lookup_unsigned_typename, )
10780         (lookup_signed_typename): Remove cast.
10781         * eval.c (parse_to_comma_and_eval): Remove cast.
10782         * parse.c (write_dollar_variable): Remove cast.
10783         * block.h (struct block) <superblock>: Now const.
10784         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10785         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10786         (map_block): Make "block" const.
10787         * symfile.h (struct quick_symbol_functions)
10788         <map_matching_symbols>: Constify block argument to "callback".
10789         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10790         const.
10791         (find_pc_sect_compunit_symtab): Make "b" const.
10792         (find_symbol_at_address): Likewise.
10793         (search_symbols): Likewise.
10794         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10795         (dw2_debug_names_lookup_symbol): Likewise.
10796         (dw2_map_matching_symbols): Update.
10797         * p-valprint.c (pascal_val_print): Remove "block".
10798         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10799         (aux_add_nonlocal_symbols): Make "block" const.
10800         (resolve_subexp): Remove cast.
10801         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10802         const.
10803         (iterate_over_file_blocks): Likewise.
10804         * f-exp.y (%union) <bval>: Remove.
10805         * coffread.c (patch_opaque_types): Make "b" const.
10806         * spu-tdep.c (spu_catch_start): Make "block" const.
10807         * c-valprint.c (print_unpacked_pointer): Remove "block".
10808         * symmisc.c (dump_symtab_1): Make "b" const.
10809         (block_depth): Make "block" const.
10810         * d-exp.y (%union) <bval>: Remove.
10811         * cp-support.h (cp_lookup_rtti_type): Update.
10812         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10813         * psymtab.c (psym_lookup_symbol): Make "block" const.
10814         (maintenance_check_psymtabs): Make "b" const.
10815         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10816         (enumerate_locals, enumerate_args): Update.
10817         * python/py-symtab.c (stpy_global_block): Make "block" const.
10818         (stpy_static_block): Likewise.
10819         * inline-frame.c (block_starting_point_at): Make "new_block"
10820         const.
10821         * block.c (find_block_in_blockvector): Make return type const.
10822         (blockvector_for_pc_sect): Make "b" const.
10823         (find_block_in_blockvector): Make "b" const.
10824
10825 2019-03-23  Tom Tromey  <tom@tromey.com>
10826
10827         * varobj.c (varobj_create): Update.
10828         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10829         * printcmd.c (display_command, do_one_display): Don't reset
10830         innermost_block.
10831         * parser-defs.h (enum innermost_block_tracker_type): Move to
10832         expression.h.
10833         (innermost_block): Update comment.
10834         * parse.c (parse_exp_1): Add tracker_types parameter.
10835         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10836         tracker_types parameter.  Reset innermost_block.
10837         (parse_exp_in_context): Remove.
10838         (parse_expression_for_completion): Update.
10839         * objfiles.c (~objfile): Don't reset expression_context_block or
10840         innermost_block.
10841         * expression.h (enum innermost_block_tracker_type): Move from
10842         parser-defs.h.
10843         (parse_exp_1): Add tracker_types parameter.
10844         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10845         reset innermost_block.
10846
10847 2019-03-23  Tom Tromey  <tom@tromey.com>
10848
10849         * objfiles.h: Include bcache.h.
10850
10851 2019-03-23  Tom Tromey  <tom@tromey.com>
10852
10853         * linespec.c (get_current_search_block): Use
10854         scoped_restore_current_language.
10855         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10856
10857 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10858             Jiong Wang  <jiong.wang@arm.com>
10859
10860         * aarch64-linux-tdep.c
10861         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10862         section.
10863         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10864
10865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10866             Jiong Wang  <jiong.wang@arm.com>
10867
10868         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10869         instructions.
10870         (aarch64_analyze_prologue_test): Add PACIASP test.
10871         (aarch64_prologue_prev_register): Unmask PC value.
10872
10873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10874             Jiong Wang  <jiong.wang@arm.com>
10875
10876         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10877         (aarch64_dwarf2_prev_register): Unmask PC value.
10878         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10879         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10880         DW_CFA_AARCH64_negate_ra_state.
10881         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10882
10883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10884             Jiong Wang  <jiong.wang@arm.com>
10885
10886         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10887         registers.
10888         (aarch64_pseudo_register_name): Likewise.
10889         (aarch64_pseudo_register_type): Likewise.
10890         (aarch64_pseudo_register_reggroup_p): Likewise.
10891         (aarch64_gdbarch_init): Add pauth registers.
10892         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10893         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10894         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10895         (struct gdbarch_tdep): Add regnum for ra_state.
10896
10897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10898             Jiong Wang  <jiong.wang@arm.com>
10899
10900         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10901
10902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10903             Jiong Wang  <jiong.wang@arm.com>
10904
10905         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10906         function.
10907         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10908         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10909         (aarch64_gdbarch_init): Add puth registers.
10910         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10911         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10912         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10913
10914 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10915             Jiong Wang  <jiong.wang@arm.com>
10916
10917         * aarch64-linux-nat.c
10918         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10919         * aarch64-linux-tdep.c
10920         (aarch64_linux_core_read_description): Likewise.
10921         (aarch64_linux_get_hwcap): New function.
10922         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10923         (aarch64_linux_get_hwcap): New declaration.
10924
10925 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10926             Jiong Wang  <jiong.wang@arm.com>
10927
10928         * aarch64-linux-nat.c
10929         (aarch64_linux_nat_target::read_description): Add pauth param.
10930         * aarch64-linux-tdep.c
10931         (aarch64_linux_core_read_description): Likewise.
10932         * aarch64-tdep.c (struct target_desc): Add in pauth.
10933         (aarch64_read_description): Add pauth param.
10934         (aarch64_gdbarch_init): Likewise.
10935         * aarch64-tdep.h (aarch64_read_description): Likewise.
10936         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10937         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10938         * features/Makefile: Add new files.
10939         * features/aarch64-pauth.c: New file.
10940         * features/aarch64-pauth.xml: New file.
10941
10942 2019-03-20  Tom Tromey  <tromey@adacore.com>
10943
10944         * infrun.c (handle_inferior_event): Rename from
10945         handle_inferior_event_1.  Create a scoped_value_mark.
10946         (handle_inferior_event): Remove.
10947
10948 2019-03-19  Tom Tromey  <tromey@adacore.com>
10949
10950         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10951         * infrun.h (print_stop_event): Add "displays" parameter.
10952         * infrun.c (print_stop_event): Add "displays" parameter.
10953
10954 2019-03-19  Pedro Alves  <palves@redhat.com>
10955
10956         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10957         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10958         to -1.  Fix TABs vs spaces.
10959         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10960         * tui/tui-out.h (tui_ui_out) Add intro comments.
10961         <m_line, m_start_of_line>: In-class initialize, and add describing
10962         comment.
10963
10964 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10965
10966         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10967         variable names.
10968         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10969
10970 2019-03-18  Pedro Alves  <palves@redhat.com>
10971             Eli Zaretskii <eliz@gnu.org>
10972
10973         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10974         m_line and m_start_of_line.
10975
10976 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10977
10978         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10979         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10980         it returns a newline.  This fixes a regression in TU mode, whereby
10981         the next line is output on the same screen line as the user input.
10982
10983 2019-03-18  Tom Tromey  <tromey@adacore.com>
10984
10985         * minsyms.c (minimal_symbol_reader::install): Remove call to
10986         obstack_blank.
10987
10988 2019-03-18  Pedro Alves  <palves@redhat.com>
10989
10990         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10991         New globals.
10992         (apply_style): New, factored out from ...
10993         (apply_ansi_escape): ... this.  Handle reverse video mode.
10994         (tui_set_reverse_mode): New function.
10995         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10996         * tui/tui-winsource.c (tui_show_source_line): Use
10997         tui_set_reverse_mode instead of setting A_STANDOUT.
10998         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10999         New setter methods.
11000
11001 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11002
11003         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11004         Handle tabs.
11005
11006 2019-03-18  Tom Tromey  <tromey@adacore.com>
11007
11008         * ada-lang.c (empty_array): Add "high" parameter.
11009         (ada_evaluate_subexp): Update.
11010
11011 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11012
11013         * unittests/string_view-selftests.c: Define
11014         _initialize_string_view_selftests unconditionally.
11015
11016 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11017
11018         PR gdb/24350
11019         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11020
11021 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11022
11023         PR gdb/24351
11024         * windows-nat.c (display_selector): Fix format specifiers.
11025
11026 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11027
11028         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11029         tui_refill_source_window instead of tui_refresh_win, to update the
11030         current execution line.  This fixes redisplay of the current line
11031         when stepping through the code with "next" or "step".
11032
11033 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11034
11035         * source-cache.c (source_cache::get_source_lines): Call
11036         find_source_lines to initialize s->nlines.  This fixes vertical
11037         scrolling of TUI source window when the DOWN arrow is pressed.
11038
11039 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11040
11041         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11042         linux-thread-db.c (_initialize_thread_db): Likewise.
11043
11044 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11045
11046         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11047         wclrtoeol in tui_show_source_line".  This reverts changes made in
11048         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11049
11050 2019-03-15  Tom Tromey  <tom@tromey.com>
11051
11052         * symtab.h (struct minimal_symbol): Derive from
11053         general_symbol_info.
11054         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11055         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11056         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11057         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11058         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11059         (MSYMBOL_SEARCH_NAME): Update.
11060         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11061         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11062         * minsyms.c (minimal_symbol_reader::record_full): Update.
11063
11064 2019-03-15  Tom Tromey  <tom@tromey.com>
11065
11066         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11067
11068 2019-03-15  Tom Tromey  <tom@tromey.com>
11069
11070         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11071         unique_xmalloc_ptr.
11072         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11073         Update.
11074         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11075         (build_minimal_symbol_hash_tables)
11076         (minimal_symbol_reader::install): Update.
11077
11078 2019-03-15  Tom Tromey  <tom@tromey.com>
11079
11080         * symtab.c (create_demangled_names_hash): Update.
11081         (symbol_set_names): Update.
11082         * objfiles.h (struct objfile_per_bfd_storage)
11083         <demangled_names_hash>: Now an htab_up.
11084         * objfiles.c (objfile_per_bfd_storage): Simplify.
11085
11086 2019-03-15  Tom Tromey  <tom@tromey.com>
11087
11088         * objfiles.h (struct objfile_per_bfd_storage): Declare
11089         destructor.
11090         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11091         New.
11092         (get_objfile_bfd_data): Use new.  Don't initialize
11093         language_of_main.
11094         (free_objfile_per_bfd_storage): Remove.
11095         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11096
11097 2019-03-15  Tom Tromey  <tom@tromey.com>
11098
11099         * symfile.c (reread_symbols): Update.
11100         * objfiles.c (objfile::objfile): Update.
11101         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11102         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11103         comment.
11104         (minimal_symbol_reader::install): Update.
11105         (terminate_minimal_symbol_table): Remove.
11106         * jit.c (jit_object_close_impl): Update.
11107
11108 2019-03-15  Tom Tromey  <tom@tromey.com>
11109
11110         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11111         initializations.
11112
11113 2019-03-15  Tom Tromey  <tom@tromey.com>
11114
11115         * objfiles.h (struct objfile_per_bfd_storage)
11116         <demangled_hash_languages>: Now a bitset.
11117         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11118         (lookup_minimal_symbol): Update.
11119
11120 2019-03-15  Tom Tromey  <tom@tromey.com>
11121
11122         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11123         Don't return the symbol.
11124         * coffread.c (record_minimal_symbol): Use record_full.
11125
11126 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11127
11128         The MS-Windows port of ncurses fails to switch to a color pair if
11129         one or both of the colors are the implicit default colors.  This
11130         change records the default colors when TUI is initialized, and
11131         then specifies them explicitly when a color pair uses the default
11132         colors.  This allows color styling in TUI mode on MS-Windows.
11133
11134         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11135         ncurses_norm_attr.
11136         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11137         colors in ncurses_norm_attr.
11138         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11139         "none", replace it with the default color recorded in
11140         ncurses_norm_attr.
11141
11142 2019-03-14  Tom Tromey  <tromey@adacore.com>
11143
11144         * source-cache.h (class source_cache) <get_source_lines>: Return
11145         std::string.
11146         * source-cache.c (source_cache::extract_lines): Handle case where
11147         first_pos==npos.  Return std::string.
11148         (source_cache::get_source_lines): Update.
11149
11150 2019-03-14  Tom Tromey  <tromey@adacore.com>
11151
11152         * NEWS: Add item for "style sources" commands.
11153         * source-cache.c (source_cache::get_source_lines): Check
11154         source_styling.
11155         * cli/cli-style.c (source_styling): New global.
11156         (_initialize_cli_style): Add "style sources" commands.
11157         (show_style_sources): New function.
11158         * cli/cli-style.h (source_styling): Declare.
11159
11160 2019-03-14  Pedro Alves  <palves@redhat.com>
11161             Tom Tromey  <tromey@adacore.com>
11162
11163         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11164         * tui/tui-winsource.c (tui_refill_source_window): New function,
11165         from...
11166         (tui_horizontal_source_scroll): ... here.  Move some logic.
11167         * cli/cli-style.c (set_style_enabled): Notify new observable.
11168         * tui/tui-hooks.c (tui_redisplay_source): New function.
11169         (tui_attach_detach_observers): Attach or detach
11170         tui_redisplay_source.
11171         * observable.h (source_styling_changed): New observable.
11172         * observable.c: Define source_styling_changed observable.
11173
11174 2019-03-13  Tom Tromey  <tromey@adacore.com>
11175
11176         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11177         (i386_gnu_nat_target::store_registers): Update.
11178         * target-debug.h (target_debug_print_std_string): New macro.
11179         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11180         * windows-tdep.c (display_one_tib): Update.
11181         * tui/tui-stack.c (tui_make_status_line): Update.
11182         * top.c (print_inferior_quit_action): Update.
11183         * thread.c (thr_try_catch_cmd): Update.
11184         (add_thread_with_info): Update.
11185         (thread_target_id_str): Update.
11186         (thr_try_catch_cmd): Update.
11187         (thread_command): Update.
11188         (thread_find_command): Update.
11189         * record-btrace.c (record_btrace_target::info_record)
11190         (record_btrace_resume_thread, record_btrace_target::resume)
11191         (record_btrace_cancel_resume, record_btrace_step_thread)
11192         (record_btrace_target::wait, record_btrace_target::wait)
11193         (record_btrace_target::wait, record_btrace_target::stop): Update.
11194         * progspace.c (print_program_space): Update.
11195         * process-stratum-target.c
11196         (process_stratum_target::thread_address_space): Update.
11197         * linux-fork.c (linux_fork_mourn_inferior)
11198         (detach_checkpoint_command, info_checkpoints_command)
11199         (linux_fork_context): Update.
11200         (linux_fork_detach): Update.
11201         (class scoped_switch_fork_info): Update.
11202         (delete_checkpoint_command): Update.
11203         * infrun.c (follow_fork_inferior): Update.
11204         (follow_fork_inferior): Update.
11205         (proceed_after_vfork_done): Update.
11206         (handle_vfork_child_exec_or_exit): Update.
11207         (follow_exec): Update.
11208         (displaced_step_prepare_throw): Update.
11209         (displaced_step_restore): Update.
11210         (start_step_over): Update.
11211         (resume_1): Update.
11212         (clear_proceed_status_thread): Update.
11213         (proceed): Update.
11214         (print_target_wait_results): Update.
11215         (do_target_wait): Update.
11216         (context_switch): Update.
11217         (stop_all_threads): Update.
11218         (restart_threads): Update.
11219         (finish_step_over): Update.
11220         (handle_signal_stop): Update.
11221         (switch_back_to_stepped_thread): Update.
11222         (keep_going_pass_signal): Update.
11223         (print_exited_reason): Update.
11224         (normal_stop): Update.
11225         * inferior.c (inferior_pid_to_str): Change return type.
11226         (print_selected_inferior): Update.
11227         (add_inferior): Update.
11228         (detach_inferior): Update.
11229         * dummy-frame.c (fprint_dummy_frames): Update.
11230         * dcache.c (dcache_info_1): Update.
11231         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11232         (btrace_fetch, btrace_clear): Update.
11233         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11234         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11235         type.
11236         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11237         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11238         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11239         * gdbarch.c, gdbarch.h: Rebuild.
11240         * gdbarch.sh (core_pid_to_str): Change return type.
11241         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11242         return type.
11243         (windows_nat_target::pid_to_str): Change return type.
11244         (windows_delete_thread): Update.
11245         (windows_nat_target::attach): Update.
11246         (windows_nat_target::files_info): Update.
11247         * target-delegates.c: Rebuild.
11248         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11249         return type.
11250         (sol_thread_target::pid_to_str): Change return type.
11251         * remote.c (class remote_target) <pid_to_str>: Change return
11252         type.
11253         (remote_target::pid_to_str): Change return type.
11254         (extended_remote_target::attach, remote_target::remote_stop_ns)
11255         (remote_target::remote_notif_remove_queued_reply)
11256         (remote_target::push_stop_reply, remote_target::disable_btrace):
11257         Update.
11258         (extended_remote_target::attach): Update.
11259         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11260         type.
11261         (gdbsim_target::pid_to_str): Change return type.
11262         * ravenscar-thread.c (struct ravenscar_thread_target)
11263         <pid_to_str>: Change return type.
11264         (ravenscar_thread_target::pid_to_str): Change return type.
11265         * procfs.c (class procfs_target) <pid_to_str>: Change return
11266         type.
11267         (procfs_target::pid_to_str): Change return type.
11268         (procfs_target::attach): Update.
11269         (procfs_target::detach): Update.
11270         (procfs_target::fetch_registers): Update.
11271         (procfs_target::store_registers): Update.
11272         (procfs_target::wait): Update.
11273         (procfs_target::files_info): Update.
11274         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11275         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11276         return type.
11277         (nto_procfs_target::pid_to_str): Change return type.
11278         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11279         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11280         return type.
11281         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11282         (exit_lwp): Update.
11283         (attach_proc_task_lwp_callback, get_detach_signal)
11284         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11285         (linux_nat_target::resume, wait_lwp, stop_callback)
11286         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11287         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11288         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11289         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11290         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11291         type.
11292         (inf_ptrace_target::attach): Update.
11293         (inf_ptrace_target::files_info): Update.
11294         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11295         type.
11296         (go32_nat_target::pid_to_str): Change return type.
11297         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11298         (gnu_nat_target::wait): Update.
11299         (gnu_nat_target::wait): Update.
11300         (gnu_nat_target::resume): Update.
11301         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11302         (fbsd_nat_target::wait): Update.
11303         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11304         type.
11305         (darwin_nat_target::attach): Update.
11306         * corelow.c (class core_target) <pid_to_str>: Change return type.
11307         (core_target::pid_to_str): Change return type.
11308         * target.c (normal_pid_to_str): Change return type.
11309         (default_pid_to_str): Likewise.
11310         (target_pid_to_str): Change return type.
11311         (target_translate_tls_address): Update.
11312         (target_announce_detach): Update.
11313         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11314         return type.
11315         (bsd_uthread_target::pid_to_str): Change return type.
11316         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11317         type.
11318         (bsd_kvm_target::pid_to_str): Change return type.
11319         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11320         return type.
11321         (aix_thread_target::pid_to_str): Change return type.
11322         * target.h (struct target_ops) <pid_to_str>: Change return type.
11323         (target_pid_to_str, normal_pid_to_str): Likewise.
11324         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11325         type.
11326         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11327         type.
11328         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11329         return type.
11330         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11331         type.
11332         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11333         type.
11334         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11335         return type.
11336
11337 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11338
11339         * NEWS: Mention that the new default MI version is 3.  Mention
11340         changes to the output of commands and events that deal with
11341         multi-location breakpoints.
11342         * breakpoint.c: Include "mi/mi-out.h".
11343         (print_one_breakpoint): Change output syntax if using MI version
11344         >= 3.
11345         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11346         New.
11347         (mi_multi_location_breakpoint_output_fixed): New.
11348         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11349         (mi_cmd_fix_multi_location_breakpoint_output): New.
11350         (mi_multi_location_breakpoint_output_fixed): New.
11351         * mi/mi-cmds.c (mi_cmds): Register command
11352         -fix-multi-location-breakpoint-output.
11353         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11354         interpreter "mi".
11355
11356 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11357
11358         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11359         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11360         instantiate mi_ui_out based on interpreter name.
11361         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11362         * mi/mi-main.c (mi_load_progress): Likewise.
11363
11364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11365
11366         * NEWS: Combine separate "New targets" sections for 8.3.
11367
11368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11369
11370         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11371         (ppcfbsd_init_abi): Install gdbarch
11372         "fetch_tls_load_module_address" and "get_thread_local_address"
11373         methods.
11374
11375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11376
11377         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11378         (riscv_fbsd_init_abi): Install gdbarch
11379         "fetch_tls_load_module_address" and "get_thread_local_address"
11380         methods.
11381
11382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11383
11384         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11385         (i386fbsd_init_abi): Install gdbarch
11386         "fetch_tls_load_module_address" and "get_thread_local_address"
11387         methods.
11388
11389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11390
11391         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11392         (amd64fbsd_init_abi): Install gdbarch
11393         "fetch_tls_load_module_address" and "get_thread_local_address"
11394         methods.
11395
11396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11397
11398         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11399         (struct fbsd_pspace_data): New type.
11400         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11401         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11402         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11403         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11404         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11405
11406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11407
11408         * gdbtypes.c (lookup_struct_elt): New function.
11409         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11410         * gdbtypes.h (struct struct_elt): New type.
11411         (lookup_struct_elt): New prototype.
11412
11413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11414
11415         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11416         remove disabled code block.
11417
11418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11419
11420         * gdbarch.sh (get_thread_local_address): New method.
11421         * gdbarch.h, gdbarch.c: Regenerate.
11422         * target.c (target_translate_tls_address): Use
11423         gdbarch_get_thread_local_address if present instead of
11424         target::get_thread_local_address.
11425
11426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11427
11428         * target.h (target::get_thread_local_address): Update comment.
11429
11430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11431
11432         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11433         objfile->separate_debug_objfile_backlink if not NULL.
11434
11435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11436
11437         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11438         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11439         (amd64bsd_store_inferior_registers): Likewise.
11440         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11441         Enable segment base registers.
11442         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11443         PT_GETFSBASE and PT_GETGSBASE.
11444         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11445         PT_SETGSBASE.
11446         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11447         segment base registers.
11448         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11449
11450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11451
11452         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11453         Update calls to i386_target_description to add 'segments'
11454         parameter.
11455         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11456         add segment base registers.
11457         * arch/i386.c (i386_create_target_description): Add 'segments'
11458         parameter to enable segment base registers.
11459         * arch/i386.h (i386_create_target_description): Likewise.
11460         * features/i386/32bit-segments.xml: New file.
11461         * features/i386/32bit-segments.c: Generate.
11462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11463         call to i386_target_description to add 'segments' parameter.
11464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11465         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11466         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11467         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11468         if feature is present.
11469         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11470         Add 'segments' parameter to call to i386_target_description.
11471         (i386_target_description): Add 'segments' parameter to enable
11472         segment base registers.
11473         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11474         to call to i386_target_description.
11475         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11476         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11477         Define I386_NUM_REGS.
11478         (i386_target_description): Add 'segments' parameter to enable
11479         segment base registers.
11480
11481 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11482
11483         PR/24325
11484         * source-cache.c: #undef open and close, to avoid unresolved
11485         externals during linking.
11486
11487 2019-03-12  Tom Tromey  <tromey@adacore.com>
11488
11489         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11490         const.  Add initializers.
11491         (_initialize_remote): Don't initialize ptid globals.
11492
11493 2019-03-12  Pedro Alves  <palves@redhat.com>
11494
11495         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11496
11497 2019-03-12  Pedro Alves  <palves@redhat.com>
11498
11499         * cp-name-parser.y (main): Remove unused 'len' variable.
11500
11501 2019-03-12  Tom Tromey  <tromey@adacore.com>
11502
11503         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11504         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11505
11506 2019-03-12  Tom Tromey  <tromey@adacore.com>
11507
11508         * linux-nat.c (iterate_over_lwps): Update.
11509         (stop_callback): Remove parameter.
11510         (stop_wait_callback, detach_callback, resume_set_callback)
11511         (select_singlestep_lwp_callback, set_ignore_sigint)
11512         (status_callback, resumed_callback, resume_clear_callback)
11513         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11514         data parameter.
11515         (linux_nat_target::detach, linux_nat_target::resume)
11516         (linux_stop_and_wait_all_lwps, select_event_lwp)
11517         (linux_nat_filter_event, linux_nat_wait_1)
11518         (linux_nat_target::kill, linux_nat_target::stop)
11519         (linux_nat_target::stop): Update.
11520         (linux_nat_resume_callback): Change type.
11521         (resume_stopped_resumed_lwps, count_events_callback)
11522         (select_event_lwp_callback): Likewise.
11523         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11524         * arm-linux-nat.c (struct update_registers_data): Remove.
11525         (update_registers_callback): Change type.
11526         (arm_linux_insert_hw_breakpoint1): Update.
11527         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11528         parameter.
11529         (x86_linux_dr_set_addr): Update.
11530         (x86_linux_dr_set_control): Update.
11531         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11532         (iterate_over_lwps): Use gdb::function_view.
11533         * nat/aarch64-linux-hw-point.c (struct
11534         aarch64_dr_update_callback_param): Remove.
11535         (debug_reg_change_callback): Change type.
11536         (aarch64_notify_debug_reg_change): Update.
11537         * s390-linux-nat.c (s390_refresh_per_info): Update.
11538
11539 2019-03-11  Tom Tromey  <tromey@adacore.com>
11540
11541         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11542         redundant assignment to "this_cu".
11543
11544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11545
11546         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11547
11548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11549
11550         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11551         from...
11552         (rank_one_type): ... this.
11553
11554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11555
11556         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11557         from...
11558         (rank_one_type): ... this.
11559
11560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11561
11562         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11563         from...
11564         (rank_one_type): ... this.
11565
11566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11567
11568         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11569         from...
11570         (rank_one_type): ... this.
11571
11572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11573
11574         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11575         from...
11576         (rank_one_type): ... this.
11577
11578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11579
11580         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11581         from...
11582         (rank_one_type): ... this.
11583
11584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11585
11586         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11587         from...
11588         (rank_one_type): ... this.
11589
11590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11591
11592         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11593         from...
11594         (rank_one_type): ... this.
11595
11596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11597
11598         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11599         from...
11600         (rank_one_type): ... this.
11601
11602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11603
11604         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11605         from...
11606         (rank_one_type): ... this.
11607
11608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11609
11610         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11611         from...
11612         (rank_one_type): ... this.
11613
11614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11615
11616         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11617         from...
11618         (rank_one_type): ... this.
11619
11620 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11621
11622         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11623         inferior-events' shows the example events.
11624
11625 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11626
11627         Support styling on native MS-Windows console
11628
11629         PR/24315
11630         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11631         on MS-Windows if $TERM is not defined.
11632
11633         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11634
11635         * posix-hdep.c (gdb_console_fputs):
11636         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11637         functions.
11638         * ui-file.h (gdb_console_fputs): Add prototype.
11639
11640         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11641         back to fputs only if the former returns zero.
11642
11643 2019-03-07  Tom Tromey  <tom@tromey.com>
11644
11645         * symmisc.c (print_symbol_bcache_statistics): Update.
11646         (print_objfile_statistics): Update.
11647         * symfile.c (allocate_symtab): Update.
11648         * stabsread.c: Don't include bcache.h.
11649         * psymtab.h (struct psymbol_bcache): Don't declare.
11650         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11651         (psymbol_bcache_init, psymbol_bcache_free)
11652         (psymbol_bcache_get_bcache): Don't declare.
11653         * psymtab.c (struct psymbol_bcache): Remove.
11654         (psymtab_storage::psymtab_storage): Update.
11655         (psymtab_storage::~psymtab_storage): Update.
11656         (psymbol_bcache_init, psymbol_bcache_free)
11657         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11658         (add_psymbol_to_bcache): Update.
11659         (allocate_psymtab): Update.
11660         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11661         macro_cache>: No longer pointers.
11662         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11663         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11664         * macrotab.c (macro_bcache): Update.
11665         * macroexp.c: Don't include bcache.h.
11666         * gdbtypes.c (check_types_worklist): Update.
11667         (types_deeply_equal): Remove TRY/CATCH.  Update.
11668         * elfread.c (elf_symtab_read): Update.
11669         * dwarf2read.c: Don't include bcache.h.
11670         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11671         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11672         (print_bcache_statistics, bcache_memory_used): Don't declare.
11673         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11674         methods.  Rename all data members.
11675         * bcache.c (struct bcache): Move to bcache.h.
11676         (bcache::expand_hash_table): Rename from expand_hash_table.
11677         (bcache): Remove.
11678         (bcache::insert): Rename from bcache_full.
11679         (bcache::compare): Rename from bcache_compare.
11680         (bcache_xmalloc): Remove.
11681         (bcache::~bcache): Rename from bcache_xfree.
11682         (bcache::print_statistics): Rename from print_bcache_statistics.
11683         (bcache::memory_used): Rename from bcache_memory_used.
11684
11685 2019-03-07  Pedro Alves  <palves@redhat.com>
11686
11687         * infrun.c (normal_stop): Also check for
11688         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11689
11690 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11691
11692         * f-lang.c (value_from_host_double): Moved to...
11693         * value.c (value_from_host_double): ...here.
11694         * value.h (value_from_host_double): Declare.
11695         * guile/scm-math.c (vlscm_convert_typed_number): Use
11696         value_from_host_double.
11697         (vlscm_convert_number): Likewise.
11698         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11699         * python/py-value.c (convert_value_from_python): Likewise.
11700
11701 2019-03-06  Tom Tromey  <tom@tromey.com>
11702
11703         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11704
11705 2019-03-06  Tom Tromey  <tom@tromey.com>
11706
11707         * utils.h (free_current_contents): Don't declare.
11708         * utils.c (free_current_contents): Remove.
11709
11710 2019-03-06  Tom Tromey  <tom@tromey.com>
11711
11712         * top.c (quit_force): Update.
11713         * main.c (captured_command_loop): Update.
11714         * common/new-op.c (operator new): Update.
11715         * common/common-exceptions.c (struct catcher)
11716         <save_cleanup_chain>: Remove member.
11717         (exceptions_state_mc_init): Update.
11718         (exception_try_scope_entry): Return nullptr.
11719         (exception_try_scope_exit, exception_rethrow)
11720         (throw_exception_sjlj, throw_exception_cxx): Update.
11721         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11722         (all_cleanups, do_cleanups, discard_cleanups)
11723         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11724         (restore_cleanups, restore_final_cleanups): Don't declare.
11725         (do_final_cleanups): Remove parameter.
11726         * common/cleanups.c (cleanup_chain, make_cleanup)
11727         (make_cleanup_dtor, all_cleanups, do_cleanups)
11728         (discard_my_cleanups, discard_cleanups)
11729         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11730         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11731         (null_cleanup): Remove.
11732         (do_final_cleanups): Remove parameter.
11733
11734 2019-03-06  Tom Tromey  <tom@tromey.com>
11735
11736         * remote.c (remote_target::remote_parse_stop_reply): Use
11737         unique_xmalloc_ptr.
11738
11739 2019-03-06  Tom Tromey  <tom@tromey.com>
11740
11741         * stabsread.c (struct stabs_field_info): Rename from field_info.
11742         <list, fnlist>: Add initializers.
11743         <obstack>: New member.
11744         (read_member_functions, read_struct_fields, read_baseclasses):
11745         Allocate on obstack.  Don't use cleanups.
11746         (read_one_struct_field, read_member_functions, read_struct_fields)
11747         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11748         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11749         (read_struct_type): Update.
11750
11751 2019-03-06  Tom Tromey  <tom@tromey.com>
11752
11753         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11754         * common/filestuff.h (make_cleanup_close): Don't declare.
11755         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11756         Remove.
11757
11758 2019-03-06  Tom Tromey  <tom@tromey.com>
11759
11760         * solib-aix.c: Use make_scope_exit.
11761
11762 2019-03-06  Tom Tromey  <tom@tromey.com>
11763
11764         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11765         Use make_scope_exit.
11766
11767 2019-03-06  Tom Tromey  <tom@tromey.com>
11768
11769         * solib-svr4.c (disable_probes_interface): Remove parameter.
11770         (svr4_handle_solib_event): Use make_scope_exit.
11771
11772 2019-03-06  Tom Tromey  <tom@tromey.com>
11773
11774         * remote.c (struct stop_reply_deleter): Remove.
11775         (stop_reply_up): Update.
11776         (struct stop_reply): Derive from notif_event.  Don't typedef.
11777         <regcache>: Now a std::vector.
11778         (stop_reply_xfree): Remove.
11779         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11780         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11781         (remote_target::discard_pending_stop_replies): Use delete.
11782         (remote_target::remote_parse_stop_reply): Update.
11783         (remote_target::process_stop_reply): Update.
11784         * remote-notif.h (struct notif_event): Add virtual destructor.
11785         Remove "dtr" member.
11786         (struct notif_client) <alloc_event>: Return a unique_ptr.
11787         (notif_event_xfree): Don't declare.
11788         (notif_event_up): New typedef.
11789         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11790         (notif_event_xfree, do_notif_event_xfree): Remove.
11791         (remote_notif_state_xfree): Update.
11792
11793 2019-03-06  Tom Tromey  <tom@tromey.com>
11794
11795         * infrun.c (displaced_step_clear_cleanup): Now a
11796         forward_scope_exit type.
11797         (displaced_step_prepare_throw): Update.
11798         (displaced_step_fixup): Update.
11799
11800 2019-03-06  Tom Tromey  <tom@tromey.com>
11801
11802         * inferior.h (class inferior): Update comment.
11803         * gdbthread.h (class thread_info): Update comment.
11804
11805 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11806             Tom Tromey  <tom@tromey.com>
11807
11808         * stabsread.h (struct stab_section_list): Remove.
11809         (coffstab_build_psymtabs): Update.
11810         * dbxread.c (symbuf_sections): Now a std::vector.
11811         (sect_idx): New global.
11812         (fill_symbuf): Update.
11813         (coffstab_build_psymtabs): Change type of stabsects parameter.
11814         Update.
11815         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11816         std::vector.
11817         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11818         (coff_locate_sections): Update.
11819         (coff_symfile_read): Remove cleanups.  Update.
11820         (init_stringtab): Add storage parameter.
11821         (free_stringtab, free_stringtab_cleanup): Remove.
11822         (init_lineno): Add storage parameter.
11823         (free_linetab, free_linetab_cleanup): Remove.
11824
11825 2019-03-06  Pedro Alves  <palves@redhat.com>
11826
11827         * linux-fork.c (fork_info::clobber_regs): Delete.
11828         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11829         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11830         comment.  Adjust.
11831         (scoped_switch_fork_info::scoped_switch_fork_info)
11832         (checkpoint_command, linux_fork_context): Adjust
11833         fork_save_infrun_state calls.
11834
11835 2019-03-06  Pedro Alves  <palves@redhat.com>
11836
11837         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11838         (inf_has_multiple_threads): Return 'bool' and rewrite using
11839         inferior_info::threads().
11840
11841 2019-03-06  Pedro Alves  <palves@redhat.com>
11842
11843         * linux-fork.c: Include <list>.
11844         (fork_list): Now a std::list instance.
11845         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11846         (forks_exist_p, find_last_fork): Adjust.
11847         (new_fork): Delete.
11848         (one_fork_p): New.
11849         (add_fork): Adjust.
11850         (free_fork): Delete, folded into fork_info::~fork_info().
11851         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11852         Adjust.
11853         (init_fork_list): Delete.
11854         (linux_fork_killall, linux_fork_mourn_inferior)
11855         (linux_fork_detach, info_checkpoints_command): Adjust.
11856         (_initialize_linux_fork): No longer call init_fork_list.
11857
11858 2019-03-06  Pedro Alves  <palves@redhat.com>
11859
11860         * linux-fork.c (new_fork): New, split out of ...
11861         (add_fork): ... this.  Return void.  Move "first fork" special
11862         case from here, to ...
11863         (checkpoint_command): ... here.
11864         * linux-linux.h (add_fork): Return void.
11865
11866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11867
11868         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11869
11870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11871             Chris January  <chris.january@arm.com>
11872             David Lecomber  <david.lecomber@arm.com>
11873
11874         * f-exp.y: New token, UNOP_INTRINSIC.
11875         (exp): New pattern using UNOP_INTRINSIC token.
11876         (f77_keywords): Add 'abs' keyword.
11877         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11878         (value_from_host_double): New function.
11879         (evaluate_subexp_f): Support UNOP_ABS.
11880
11881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11882
11883         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11884         types.
11885
11886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11887
11888         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11889         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11890         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11891
11892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11893
11894         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11895
11896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11897             Chris January  <chris.january@arm.com>
11898
11899         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11900         * f-exp.y: Define 'KIND' token.
11901         (exp): New pattern for KIND expressions.
11902         (ptype): Handle types with a kind extension.
11903         (direct_abs_decl): Extend to spot kind extensions.
11904         (f77_keywords): Add 'kind' to the list.
11905         (push_kind_type): New function.
11906         (convert_to_kind_type): New function.
11907         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11908         * parse.c (operator_length_standard): Likewise.
11909         * parser-defs.h (enum type_pieces): Add tp_kind.
11910         * std-operator.def: Add UNOP_KIND.
11911
11912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11913
11914         * f-exp.y (f_parse): Set yydebug.
11915
11916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11917
11918         * f-lang.c (evaluate_subexp_f): New function.
11919         (exp_descriptor_f): New global.
11920         (f_language_defn): Use exp_descriptor_f instead of
11921         exp_descriptor_standard.
11922
11923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11924
11925         * f-exp.y (struct token): Add comments.
11926         (dot_ops): Remove uppercase versions and the end marker.
11927         (f77_keywords): Likewise.
11928         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11929         entries in the dot_ops array are case insensitive, and use
11930         strncasecmp to compare strings.  Also some whitespace cleanup in
11931         this area.  Similar for the f77_keywords array, except entries in
11932         this list might be case sensitive.
11933
11934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11935
11936         * f-exp.y (struct f77_boolean_val): Add comments.
11937         (boolean_values): Remove uppercase versions, and end marker.
11938         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11939         and use strncasecmp to achieve case insensitivity.  Additionally,
11940         perform whitespace cleanup around this code.
11941
11942 2019-03-06  Tom Tromey  <tromey@adacore.com>
11943
11944         * remote-sim.c (gdbsim_target_open): Use result of
11945         gdb_argv::release.
11946
11947 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11948         Dirk Schubert  <dirk.schubert@arm.com>
11949         Chris January  <chris.january@arm.com>
11950
11951         * eval.c (evaluate_subexp_standard): Call Fortran argument
11952         wrapping logic.
11953         * f-lang.c (struct value): A value which can be passed into a
11954         Fortran function call.
11955         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11956         where appropriate.
11957         (struct type): Value ready for a Fortran function call.
11958         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11959         is needed.
11960         * f-lang.h (fortran_argument_convert): Declaration.
11961         (fortran_preserve_arg_pointer): Declaration.
11962         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11963
11964 2019-03-05  Tom Tromey  <tromey@adacore.com>
11965
11966         * python/py-prettyprint.c (print_string_repr): Remove #if.
11967         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11968
11969 2019-03-05  Tom Tromey  <tromey@adacore.com>
11970
11971         * target.c (the_dummy_target): Move later.  Change type to
11972         "dummy_target".
11973         (initialize_targets): Don't initialize the_dummy_target.
11974
11975 2019-03-05  Tom Tromey  <tromey@adacore.com>
11976
11977         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11978         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11979
11980 2019-03-05  Tom Tromey  <tromey@adacore.com>
11981
11982         * windows-nat.c (windows_nat_target::attach)
11983         (windows_nat_target::detach): Don't call gdb_flush.
11984         * valprint.c (generic_val_print, val_print, val_print_string):
11985         Don't call gdb_flush.
11986         * utils.c (defaulted_query): Don't call gdb_flush.
11987         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11988         * target.c (target_announce_detach): Don't call gdb_flush.
11989         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11990         * remote.c (extended_remote_target::attach): Don't call
11991         gdb_flush.
11992         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11993         * printcmd.c (do_examine): Don't call gdb_flush.
11994         (info_display_command): Don't call gdb_flush.
11995         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11996         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11997         * memattr.c (info_mem_command): Don't call gdb_flush.
11998         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11999         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12000         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12001         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12002         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12003         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12004         (gnu_nat_target::detach): Don't call gdb_flush.
12005         * f-valprint.c (f_val_print): Don't call gdb_flush.
12006         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12007         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12008         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12009         gdb_flush.
12010         * c-valprint.c (c_val_print): Don't call gdb_flush.
12011         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12012
12013 2019-03-05  Tom Tromey  <tromey@adacore.com>
12014
12015         * varobj.c (update_dynamic_varobj_children): Update.
12016         (install_default_visualizer): Use reset, not release.
12017         * value.c (set_internalvar): Update.
12018         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12019         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12020         ATTRIBUTE_UNUSED_RESULT.
12021
12022 2019-03-05  Tom Tromey  <tromey@adacore.com>
12023
12024         * remote.c (class scoped_remote_fd) <release>: Add
12025         ATTRIBUTE_UNUSED_RESULT.
12026
12027 2019-03-05  Tom Tromey  <tromey@adacore.com>
12028
12029         * macroexp.c (struct macro_buffer) <release>: Add
12030         ATTRIBUTE_UNUSED_RESULT.
12031
12032 2019-03-05  Tom Tromey  <tromey@adacore.com>
12033
12034         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12035         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12036         ATTRIBUTE_UNUSED_RESULT.
12037
12038 2019-03-05  Tom Tromey  <tromey@adacore.com>
12039
12040         * common/scoped_fd.h (class scoped_fd) <release>: Add
12041         ATTRIBUTE_UNUSED_RESULT.
12042
12043 2019-03-05  Tom Tromey  <tromey@adacore.com>
12044
12045         * parser-defs.h (struct parser_state) <release>: Add
12046         ATTRIBUTE_UNUSED_RESULT.
12047
12048 2019-03-05  Tom Tromey  <tromey@adacore.com>
12049
12050         * utils.h (class gdb_argv) <release>: Add
12051         ATTRIBUTE_UNUSED_RESULT.
12052         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12053
12054 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12055
12056         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12057         for-loop range, to avoid compiler warnings.
12058
12059         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12060         avoid compiler warnings about unused variables.
12061
12062         * NEWS: Mention end of support for native debugging on MS-Windows
12063         before XP.
12064
12065         PR gdb/24292
12066         * common/netstuff.c:
12067         * gdbserver/gdbreplay.c
12068         * gdbserver/remote-utils.c:
12069         * ser-tcp.c:
12070         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12071         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12072         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12073         'getaddrinfo' and 'freeaddrinfo' were not available before
12074         Windows XP, and mingw.org's MinGW headers by default define
12075         _WIN32_WINNT to 0x500.
12076
12077 2019-03-01  Gary Benson <gbenson@redhat.com>
12078
12079         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12080
12081 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12082             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12083
12084         PR gdb/8527
12085         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12086         set_sigint_trap, clear_sigint_trap.
12087
12088 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12089
12090         * target.c (target_detach): Clear the regcache and the
12091         frame cache.
12092
12093 2019-02-27  Pedro Alves  <palves@redhat.com>
12094
12095         * utils.c (set_screen_size): When we cap the height/width sizes,
12096         tweak the corresponding command variable to show "unlimited":
12097
12098 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12099             Pedro Alves  <palves@redhat.com>
12100
12101         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12102         before calling rl_set_screen_size.
12103
12104 2019-02-27  Tom Tromey  <tromey@adacore.com>
12105
12106         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12107         define.
12108         * python/py-value.c: Remove Python 2.4 workaround.
12109         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12110         workaround.
12111         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12112         Python 2.4 workaround.
12113         * python/python-internal.h: Remove Python 2.4 comment.
12114         (Py_ssize_t): Don't define.
12115         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12116         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12117         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12118         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12119         * python/python.c (do_start_initialization): Remove Python 2.4
12120         workaround.
12121         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12122         (print_children): Remove Python 2.4 workaround.
12123         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12124         workaround.
12125         (CHARBUFFERPROC_NAME): Remove.
12126         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12127         Python 2.4 workaround.
12128
12129 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12130
12131         * NEWS: Note minimum Python version.
12132
12133 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12134
12135         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12136         code from these functions.  Remove corresponding ifdefs.  Use
12137         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12138         Remove gotos and target of gotos.
12139         (infpy_search_memory): Likewise.
12140
12141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12142
12143         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12144         (hppa_gdbarch_init): Don't register deleted functions with
12145         gdbarch.
12146
12147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12148
12149         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12150         (h8300_unwind_sp): Delete.
12151         (h8300_dummy_id): Delete.
12152         (h8300_gdbarch_init): Don't register deleted functions with
12153         gdbarch.
12154
12155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12156
12157         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12158         (ft32_unwind_pc): Delete.
12159         (ft32_unwind_sp): Delete.
12160         (ft32_gdbarch_init): Don't register deleted functions with
12161         gdbarch.
12162
12163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12164
12165         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12166         (frv_unwind_pc): Delete.
12167         (frv_unwind_sp): Delete.
12168         (frv_gdbarch_init): Don't register deleted functions with
12169         gdbarch.
12170
12171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12172
12173         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12174         (riscv_unwind_pc): Delete.
12175         (riscv_unwind_sp): Delete.
12176         (riscv_gdbarch_init): Don't register deleted functions with
12177         gdbarch.
12178
12179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12180
12181         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12182         (csky_unwind_pc): Delete.
12183         (csky_unwind_sp): Delete.
12184         (csky_gdbarch_init): Don't register deleted functions with
12185         gdbarch.
12186
12187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12188
12189         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12190         (cris_unwind_pc): Delete.
12191         (cris_unwind_sp): Delete.
12192         (cris_gdbarch_init): Don't register deleted functions with
12193         gdbarch.
12194
12195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12196
12197         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12198         (bfin_unwind_pc): Delete.
12199         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12200
12201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12202
12203         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12204         (arm_unwind_pc): Delete.
12205         (arm_unwind_sp): Delete.
12206         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12207
12208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12209
12210         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12211         (arc_unwind_pc): Delete.
12212         (arc_unwind_sp): Delete.
12213         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12214
12215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12216
12217         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12218         (alpha_unwind_pc): Delete.
12219         (alpha_gdbarch_init): Don't register deleted functions with
12220         gdbarch.
12221
12222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12223
12224         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12225         (aarch64_unwind_pc): Delete.
12226         (aarch64_unwind_sp): Delete.
12227         (aarch64_gdbarch_init): Don't register deleted functions with
12228         gdbarch.
12229
12230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12231
12232         * gdbtypes.c (type_align): Don't consider static members when
12233         computing structure alignment.
12234
12235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12236
12237         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12238         return 0 for other types.
12239         * arch-utils.c (default_type_align): Always return 0.
12240         * gdbarch.h: Regenerate.
12241         * gdbarch.sh (type_align): Extend comment.
12242         * gdbtypes.c (type_align): Add additional comments, always call
12243         gdbarch_type_align before applying the default rules.
12244         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12245         generic code will then apply a suitable default.
12246         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12247         types, return 0 for other types.
12248
12249 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12250
12251         * NEWS: Create a new section for the next release branch.
12252         Rename the section of the current branch, now that it has
12253         been cut.
12254
12255 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12256
12257         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12258         * version.in: Bump version to 8.3.50.DATE-git.
12259
12260 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12261
12262         * aix-thread.c (ptid_cmp): Remove unused variable.
12263         (get_signaled_thread): Likewise.
12264         (store_regs_user_thread): Likewise.
12265         (store_regs_kernel_thread): Likewise.
12266         (fetch_regs_kernel_thread): Remove shadowed variable.
12267
12268 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12269
12270         * features/riscv/32bit-cpu.xml: Add register numbers.
12271         * features/riscv/32bit-fpu.c: Regenerate.
12272         * features/riscv/32bit-fpu.xml: Add register numbers.
12273         * features/riscv/64bit-cpu.xml: Add register numbers.
12274         * features/riscv/64bit-fpu.c: Regenerate.
12275         * features/riscv/64bit-fpu.xml: Add register numbers.
12276
12277 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12278
12279         * NEWS: Mention two argument form of gdb.Value constructor.
12280         * python/py-value.c (convert_buffer_and_type_to_value): New
12281         function.
12282         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12283         Add support for handling an optional second argument.  Call
12284         convert_buffer_and_type_to_value as appropriate.
12285         * python/python-internal.h (Py_buffer_deleter): New struct.
12286         (Py_buffer_up): New typedef.
12287
12288 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12289
12290         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12291         instead of releasing ownership.
12292
12293 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12294
12295         * dwarf2read.c (open_and_init_dwp_file): Call
12296         elf_numsections instead of bfd_count_sections to initialize
12297         dwp_file->num_sections.
12298
12299 2019-02-25  Tom Tromey  <tromey@adacore.com>
12300
12301         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12302
12303 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12304
12305         * gcore.in: Add '--readnever' option when invoking GDB.
12306
12307 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12308
12309         * MAINTAINERS: Update my email address.
12310
12311 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12312
12313         * build-id.c (build_id_to_debug_bfd_1): New function.
12314         (build_id_to_debug_bfd): Look for separate debug file in
12315         sysroot.
12316
12317 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12318
12319         * gdbarch.sh: Update the copyright year range that is placed into
12320         generated files.
12321
12322 2019-02-22  Keith Seitz  <keiths@redhat.com>
12323
12324         PR symtab/23853
12325         * linespec.c (create_sals_line_offset): Search for the default
12326         symtab's filename instead of its fullname.
12327
12328 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12329
12330         * NEWS: Update style defaults.
12331
12332 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12333
12334         * main.c (captured_main_1): Disable styling in batch mode.
12335
12336 2019-02-20  Tom Tromey  <tom@tromey.com>
12337
12338         * symtab.c (symtab_symbol_info): Fix typos.
12339
12340 2019-02-20  Tom Tromey  <tromey@adacore.com>
12341
12342         * findcmd.c (_initialize_mem_search): Use upper case for
12343         metasyntactic variables.
12344
12345 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12346
12347         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12348         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12349
12350 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12351
12352         * top.h (source_file_name): Change to std::string.
12353         * top.c (source_file_name): Likewise.
12354         (command_line_input): Adjust.
12355         * cli/cli-script.c (script_from_file): Adjust.
12356
12357 2019-02-19  Tom Tromey  <tromey@adacore.com>
12358
12359         * ravenscar-thread.c
12360         (ravenscar_thread_target::update_thread_list): Don't call
12361         ada_build_task_list.
12362         * ada-lang.h (ada_build_task_list): Don't declare.
12363         * ada-tasks.c (struct ada_tasks_inferior_data)
12364         <task_list_valid_p>: Now bool.
12365         (read_known_tasks, ada_task_list_changed)
12366         (ada_tasks_invalidate_inferior_data): Update.
12367         (read_known_tasks_array): Return bool.
12368         (read_known_tasks_list): Likewise.
12369         (read_known_tasks): Return void.
12370         (ada_build_task_list): Now static.
12371
12372 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12373
12374         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12375         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12376
12377 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12378
12379         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12380         variant for ada_tasks_pspace_data_handle and
12381         ada_tasks_inferior_data_handle.
12382         (ada_tasks_pspace_data_cleanup): New function.
12383         (ada_tasks_inferior_data_cleanup): New function.
12384
12385 2019-02-17  Tom Tromey  <tom@tromey.com>
12386
12387         * macrotab.h (macro_source_fullname): Return a std::string.
12388         * macrotab.c (macro_include, check_for_redefinition)
12389         (macro_undef, macro_lookup_definition, foreach_macro)
12390         (foreach_macro_in_scope): Update.
12391         (macro_source_fullname): Return a std::string.
12392         * macrocmd.c (show_pp_source_pos): Update.
12393
12394 2019-02-17  Tom Tromey  <tom@tromey.com>
12395
12396         * macrocmd.c (show_pp_source_pos): Style the file names.
12397
12398 2019-02-17  Tom Tromey  <tom@tromey.com>
12399
12400         PR tui/24197:
12401         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12402
12403 2019-02-17  Tom Tromey  <tom@tromey.com>
12404
12405         * ada-lang.c (user_select_syms): Use filtered printing.
12406         * utils.c (wrap_style): New global.
12407         (desired_style): Remove.
12408         (emit_style_escape): Add stream parameter.
12409         (set_output_style, reset_terminal_style, prompt_for_continue):
12410         Update.
12411         (flush_wrap_buffer): Only flush gdb_stdout.
12412         (wrap_here): Set wrap_style.
12413         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12414         treat escape sequences as a character.  Change when wrap buffer is
12415         flushed.
12416         (fputs_styled): Do not set the output style when the default is
12417         requested.
12418         * ui-style.h (struct ui_file_style) <is_default>: New method.
12419         * source.c (print_source_lines_base): Emit escape sequences in one
12420         piece.
12421
12422 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12423
12424         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12425         integers and enumeration types.
12426
12427 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12428
12429         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12430         instead of lookup_symbol_in_language
12431         (do_exact_match): New function.
12432         (ada_get_symbol_name_matcher): Return do_exact_match when
12433         doing a verbatim match.
12434
12435 2019-02-15  Tom Tromey  <tromey@adacore.com>
12436
12437         * ravenscar-thread.c (ravenscar_thread_target::resume)
12438         (ravenscar_thread_target::wait): Special case wildcard requests.
12439
12440 2019-02-15  Tom Tromey  <tromey@adacore.com>
12441
12442         * ravenscar-thread.c (base_ptid): Remove.
12443         (struct ravenscar_thread_target) <close>: New method.
12444         <m_base_ptid>: New member.
12445         <update_inferior_ptid, active_task, task_is_currently_active,
12446         runtime_initialized>: Declare methods.
12447         <ravenscar_thread_target>: Add constructor.
12448         (ravenscar_thread_target::task_is_currently_active)
12449         (ravenscar_thread_target::update_inferior_ptid)
12450         (ravenscar_runtime_initialized): Rename.  Now methods.
12451         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12452         (ravenscar_thread_target::update_thread_list): Update.
12453         (ravenscar_thread_target::active_task): Now method.
12454         (ravenscar_thread_target::store_registers)
12455         (ravenscar_thread_target::prepare_to_store)
12456         (ravenscar_thread_target::prepare_to_store)
12457         (ravenscar_thread_target::mourn_inferior): Update.
12458         (ravenscar_inferior_created): Use "new" to create target.
12459         (ravenscar_thread_target::get_ada_task_ptid): Update.
12460         (_initialize_ravenscar): Don't initialize base_ptid.
12461         (ravenscar_ops): Remove global.
12462
12463 2019-02-15  Tom Tromey  <tromey@adacore.com>
12464
12465         * target.h (push_target): Declare new overload.
12466         * target.c (push_target): New overload, taking an rvalue reference.
12467         * remote.c (remote_target::open_1): Use push_target overload.
12468         * corelow.c (core_target_open): Use push_target overload.
12469
12470 2019-02-15  Tom Tromey  <tromey@adacore.com>
12471
12472         * ravenscar-thread.c (is_ravenscar_task)
12473         (ravenscar_task_is_currently_active): Return bool.
12474         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12475         (_initialize_ravenscar): Remove "(void)".
12476         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12477         Return bool.
12478
12479 2019-02-15  Tom Tromey  <tromey@adacore.com>
12480
12481         * ravenscar-thread.c (ravenscar_runtime_initializer)
12482         (has_ravenscar_runtime, get_running_thread_id)
12483         (ravenscar_thread_target::resume): Fix indentation.
12484
12485 2019-02-15  Tom Tromey  <tromey@adacore.com>
12486
12487         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12488         from ravenscar_arch_ops.
12489         (sparc_ravenscar_ops::fetch_registers)
12490         (sparc_ravenscar_ops::store_registers): Now methods.
12491         (sparc_ravenscar_prepare_to_store): Remove.
12492         (sparc_ravenscar_ops): Redefine.
12493         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12494         methods and destructor.  Remove members.
12495         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12496         (ravenscar_thread_target::store_registers)
12497         (ravenscar_thread_target::prepare_to_store): Update.
12498         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12499         Remove.
12500         (struct ppc_ravenscar_powerpc_ops): Derive from
12501         ravenscar_arch_ops.
12502         (ppc_ravenscar_powerpc_ops::fetch_registers)
12503         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12504         (ppc_ravenscar_powerpc_ops): Redefine.
12505         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12506         (ppc_ravenscar_e500_ops::fetch_registers)
12507         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12508         (ppc_ravenscar_e500_ops): Redefine.
12509         * aarch64-ravenscar-thread.c
12510         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12511         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12512         (aarch64_ravenscar_fetch_registers)
12513         (aarch64_ravenscar_store_registers): Now methods.
12514         (aarch64_ravenscar_ops): Redefine.
12515
12516 2019-02-15  Tom Tromey  <tromey@adacore.com>
12517
12518         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12519         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12520         (ravenscar_thread_target::stopped_by_watchpoint)
12521         (ravenscar_thread_target::stopped_data_address)
12522         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12523
12524 2019-02-15  Tom Tromey  <tromey@adacore.com>
12525
12526         * ravenscar-thread.c: Fix some typos.
12527
12528 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12529             Tom Tromey  <tromey@adacore.com>
12530
12531         * ada-lang.c (ada_exception_sal): Change addr_string to a
12532         std::string.
12533         (create_ada_exception_catchpoint): Update.
12534
12535 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12536             Tom Tromey  <tromey@adacore.com>
12537
12538         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12539         (bp_location_ops): Remove.
12540         (base_breakpoint_allocate_location): Update.
12541         (free_bp_location): Update.
12542         * ada-lang.c (class ada_catchpoint_location)
12543         <ada_catchpoint_location>: Remove ops parameter.
12544         (ada_catchpoint_location_dtor): Remove.
12545         (ada_catchpoint_location_ops): Remove.
12546         (allocate_location_exception): Update.
12547         * breakpoint.h (struct bp_location_ops): Remove.
12548         (class bp_location) <bp_location>: Remove bp_location_ops
12549         parameter.
12550         <~bp_location>: Add destructor.
12551         <ops>: Remove.
12552
12553 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12554             Pedro Alves  <palves@redhat.com>
12555
12556         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12557         'PATH_MAX'.
12558
12559 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12560             Samuel Thibault  <samuel.thibault@gnu.org>
12561             Thomas Schwinge  <thomas@codesourcery.com>
12562
12563         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12564         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12565
12566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12567
12568         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12569         (check_empty): Use "const char *".
12570
12571         * gnu-nat.c (gnu_nat_target::detach): Instead of
12572         'detach_inferior (pid)' call
12573         'detach_inferior (find_inferior_pid (pid))'.
12574
12575         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12576         'nat/fork-inferior.o'.
12577         * gnu-nat.c: #include "nat/fork-inferior.h".
12578
12579         * gnu-nat.c (gnu_nat_target::detach): Instead of
12580         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12581         * gnu-nat.h: #include "inf-child.h".
12582         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12583         'i386_gnu_nat_target::fetch_registers'.
12584         (gnu_store_registers): Rename/move to
12585         'i386_gnu_nat_target::store_registers'.
12586
12587         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12588         * gnu-nat.h (mach_thread_info): New function.
12589         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12590
12591         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12592
12593 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12594
12595         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12596
12597 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12598
12599         * windows-nat.c (windows_add_thread): Add new parameter
12600         "main_thread_p" with default value set to false.  Update
12601         function documentation as well as all callers.
12602         (windows_delete_thread): Likewise.
12603         (fake_create_process): Update call to windows_add_thread.
12604         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12605         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12606         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12607         call to windows_delete_thread.
12608
12609 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12610
12611         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12612
12613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12614
12615         * symfile.c (find_separate_debug_file): Use canonical path of
12616         sysroot with child_path instead of gdb_sysroot if it is valid.
12617
12618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12619
12620         * symfile.c (find_separate_debug_file): Use child_path to
12621         determine if an object file is under a sysroot.
12622
12623 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12624
12625         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12626         unittests/child-path-selftests.c.
12627         * common/pathstuff.c (child_path): New function.
12628         * common/pathstuff.h (child_path): New prototype.
12629         * unittests/child-path-selftests.c: New file.
12630
12631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12632
12633         * symfile.c (find_separate_debug_file): Look for separate debug
12634         files in debug directories under the sysroot.
12635
12636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12637
12638         * symtab.h (struct minimal_symbol data_p): New const method.
12639         (struct minimal_symbol text_p): Likewise.
12640         * symtab.c (output_source_filename): Use file name style
12641         to print file name.
12642         (print_symbol_info): Likewise.
12643         (print_msymbol_info): Use address style to print addresses.
12644         Use function name style to print executable text symbols.
12645         (expand_symtab_containing_pc): Use data_p.
12646         (find_pc_sect_compunit_symtab): Likewise.
12647
12648 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12649
12650         * breakpoint.c (describe_other_breakpoints): Use address style
12651         to print addresses.
12652         (say_where): Likewise.
12653
12654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12655
12656         * ada-typeprint.c (print_func_type): Print function name
12657         style to print function name.
12658         * c-typeprint.c (c_print_type_1): Likewise.
12659
12660 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12661
12662         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12663         for execve.
12664
12665 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12666
12667         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12668         type_stack.
12669
12670 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12671
12672         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12673         TYPE_CODE_REF types.
12674
12675 2019-02-08  Jim Wilson  <jimw@sifive.com>
12676
12677         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12678         (riscv_linux_fregset): New.
12679         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12680
12681 2019-02-07  Tom Tromey  <tom@tromey.com>
12682
12683         * thread.c (thread_cancel_execution_command): Update.
12684         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12685         methods.
12686         (struct thread_fsm_ops): Remove.
12687         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12688         (thread_fsm_should_stop, thread_fsm_return_value)
12689         (thread_fsm_set_finished, thread_fsm_finished_p)
12690         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12691         Don't declare.
12692         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12693         * infrun.c (clear_proceed_status_thread)
12694         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12695         (print_stop_event): Update.
12696         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12697         Add constructor.
12698         (step_command_fsm_ops): Remove.
12699         (new_step_command_fsm): Remove.
12700         (step_1): Update.
12701         (step_command_fsm::should_stop): Rename from
12702         step_command_fsm_should_stop.
12703         (step_command_fsm::clean_up): Rename from
12704         step_command_fsm_clean_up.
12705         (step_command_fsm::do_async_reply_reason): Rename from
12706         step_command_fsm_async_reply_reason.
12707         (struct until_next_fsm): Inherit from thread_fsm.  Add
12708         constructor.
12709         (until_next_fsm_ops): Remove.
12710         (new_until_next_fsm): Remove.
12711         (until_next_fsm::should_stop): Rename from
12712         until_next_fsm_should_stop.
12713         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12714         (until_next_fsm::do_async_reply_reason): Rename from
12715         until_next_fsm_async_reply_reason.
12716         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12717         constructor.  Change type of breakpoint.
12718         (finish_command_fsm_ops): Remove.
12719         (new_finish_command_fsm): Remove.
12720         (finish_command_fsm::should_stop): Rename from
12721         finish_command_fsm_should_stop.
12722         (finish_command_fsm::clean_up): Rename from
12723         finish_command_fsm_clean_up.
12724         (finish_command_fsm::return_value): Rename from
12725         finish_command_fsm_return_value.
12726         (finish_command_fsm::do_async_reply_reason): Rename from
12727         finish_command_fsm_async_reply_reason.
12728         (finish_command): Update.
12729         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12730         Add constructor.
12731         (call_thread_fsm_ops): Remove.
12732         (call_thread_fsm::call_thread_fsm): Rename from
12733         new_call_thread_fsm.
12734         (call_thread_fsm::should_stop): Rename from
12735         call_thread_fsm_should_stop.
12736         (call_thread_fsm::should_notify_stop): Rename from
12737         call_thread_fsm_should_notify_stop.
12738         (run_inferior_call, call_function_by_hand_dummy): Update.
12739         * cli/cli-interp.c (should_print_stop_to_console): Update.
12740         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12741         Add constructor.  Change type of location_breakpoint,
12742         caller_breakpoint.
12743         (until_break_fsm_ops): Remove.
12744         (new_until_break_fsm): Remove.
12745         (until_break_fsm::should_stop): Rename from
12746         until_break_fsm_should_stop.
12747         (until_break_fsm::clean_up): Rename from
12748         until_break_fsm_clean_up.
12749         (until_break_fsm::do_async_reply_reason): Rename from
12750         until_break_fsm_async_reply_reason.
12751         (until_break_command): Update.
12752         * thread-fsm.c: Remove.
12753         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12754
12755 2019-02-07  Tom Tromey  <tom@tromey.com>
12756
12757         * yy-remap.h: Add include guard.
12758         * xtensa-tdep.h: Add include guard.
12759         * xcoffread.h: Rename include guard.
12760         * varobj-iter.h: Add include guard.
12761         * tui/tui.h: Rename include guard.
12762         * tui/tui-winsource.h: Rename include guard.
12763         * tui/tui-wingeneral.h: Rename include guard.
12764         * tui/tui-windata.h: Rename include guard.
12765         * tui/tui-win.h: Rename include guard.
12766         * tui/tui-stack.h: Rename include guard.
12767         * tui/tui-source.h: Rename include guard.
12768         * tui/tui-regs.h: Rename include guard.
12769         * tui/tui-out.h: Rename include guard.
12770         * tui/tui-layout.h: Rename include guard.
12771         * tui/tui-io.h: Rename include guard.
12772         * tui/tui-hooks.h: Rename include guard.
12773         * tui/tui-file.h: Rename include guard.
12774         * tui/tui-disasm.h: Rename include guard.
12775         * tui/tui-data.h: Rename include guard.
12776         * tui/tui-command.h: Rename include guard.
12777         * tic6x-tdep.h: Add include guard.
12778         * target/waitstatus.h: Rename include guard.
12779         * target/wait.h: Rename include guard.
12780         * target/target.h: Rename include guard.
12781         * target/resume.h: Rename include guard.
12782         * target-float.h: Rename include guard.
12783         * stabsread.h: Add include guard.
12784         * rs6000-tdep.h: Add include guard.
12785         * riscv-fbsd-tdep.h: Add include guard.
12786         * regformats/regdef.h: Rename include guard.
12787         * record.h: Rename include guard.
12788         * python/python.h: Rename include guard.
12789         * python/python-internal.h: Rename include guard.
12790         * python/py-stopevent.h: Rename include guard.
12791         * python/py-ref.h: Rename include guard.
12792         * python/py-record.h: Rename include guard.
12793         * python/py-record-full.h: Rename include guard.
12794         * python/py-record-btrace.h: Rename include guard.
12795         * python/py-instruction.h: Rename include guard.
12796         * python/py-events.h: Rename include guard.
12797         * python/py-event.h: Rename include guard.
12798         * procfs.h: Add include guard.
12799         * proc-utils.h: Add include guard.
12800         * p-lang.h: Add include guard.
12801         * or1k-tdep.h: Rename include guard.
12802         * observable.h: Rename include guard.
12803         * nto-tdep.h: Rename include guard.
12804         * nat/x86-linux.h: Rename include guard.
12805         * nat/x86-linux-dregs.h: Rename include guard.
12806         * nat/x86-gcc-cpuid.h: Add include guard.
12807         * nat/x86-dregs.h: Rename include guard.
12808         * nat/x86-cpuid.h: Rename include guard.
12809         * nat/ppc-linux.h: Rename include guard.
12810         * nat/mips-linux-watch.h: Rename include guard.
12811         * nat/linux-waitpid.h: Rename include guard.
12812         * nat/linux-ptrace.h: Rename include guard.
12813         * nat/linux-procfs.h: Rename include guard.
12814         * nat/linux-osdata.h: Rename include guard.
12815         * nat/linux-nat.h: Rename include guard.
12816         * nat/linux-namespaces.h: Rename include guard.
12817         * nat/linux-btrace.h: Rename include guard.
12818         * nat/glibc_thread_db.h: Rename include guard.
12819         * nat/gdb_thread_db.h: Rename include guard.
12820         * nat/gdb_ptrace.h: Rename include guard.
12821         * nat/fork-inferior.h: Rename include guard.
12822         * nat/amd64-linux-siginfo.h: Rename include guard.
12823         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12824         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12825         * nat/aarch64-linux.h: Rename include guard.
12826         * nat/aarch64-linux-hw-point.h: Rename include guard.
12827         * mn10300-tdep.h: Add include guard.
12828         * mips-linux-tdep.h: Add include guard.
12829         * mi/mi-parse.h: Rename include guard.
12830         * mi/mi-out.h: Rename include guard.
12831         * mi/mi-main.h: Rename include guard.
12832         * mi/mi-interp.h: Rename include guard.
12833         * mi/mi-getopt.h: Rename include guard.
12834         * mi/mi-console.h: Rename include guard.
12835         * mi/mi-common.h: Rename include guard.
12836         * mi/mi-cmds.h: Rename include guard.
12837         * mi/mi-cmd-break.h: Rename include guard.
12838         * m2-lang.h: Add include guard.
12839         * location.h: Rename include guard.
12840         * linux-record.h: Rename include guard.
12841         * linux-nat.h: Add include guard.
12842         * linux-fork.h: Add include guard.
12843         * i386-darwin-tdep.h: Rename include guard.
12844         * hppa-linux-offsets.h: Add include guard.
12845         * guile/guile.h: Rename include guard.
12846         * guile/guile-internal.h: Rename include guard.
12847         * gnu-nat.h: Rename include guard.
12848         * gdb-stabs.h: Rename include guard.
12849         * frv-tdep.h: Add include guard.
12850         * f-lang.h: Add include guard.
12851         * event-loop.h: Add include guard.
12852         * darwin-nat.h: Rename include guard.
12853         * cp-abi.h: Rename include guard.
12854         * config/sparc/nm-sol2.h: Rename include guard.
12855         * config/nm-nto.h: Rename include guard.
12856         * config/nm-linux.h: Add include guard.
12857         * config/i386/nm-i386gnu.h: Rename include guard.
12858         * config/djgpp/nl_types.h: Rename include guard.
12859         * config/djgpp/langinfo.h: Rename include guard.
12860         * compile/gcc-cp-plugin.h: Add include guard.
12861         * compile/gcc-c-plugin.h: Add include guard.
12862         * compile/compile.h: Rename include guard.
12863         * compile/compile-object-run.h: Rename include guard.
12864         * compile/compile-object-load.h: Rename include guard.
12865         * compile/compile-internal.h: Rename include guard.
12866         * compile/compile-cplus.h: Rename include guard.
12867         * compile/compile-c.h: Rename include guard.
12868         * common/xml-utils.h: Rename include guard.
12869         * common/x86-xstate.h: Rename include guard.
12870         * common/version.h: Rename include guard.
12871         * common/vec.h: Rename include guard.
12872         * common/tdesc.h: Rename include guard.
12873         * common/selftest.h: Rename include guard.
12874         * common/scoped_restore.h: Rename include guard.
12875         * common/scoped_mmap.h: Rename include guard.
12876         * common/scoped_fd.h: Rename include guard.
12877         * common/safe-iterator.h: Rename include guard.
12878         * common/run-time-clock.h: Rename include guard.
12879         * common/refcounted-object.h: Rename include guard.
12880         * common/queue.h: Rename include guard.
12881         * common/ptid.h: Rename include guard.
12882         * common/print-utils.h: Rename include guard.
12883         * common/preprocessor.h: Rename include guard.
12884         * common/pathstuff.h: Rename include guard.
12885         * common/observable.h: Rename include guard.
12886         * common/netstuff.h: Rename include guard.
12887         * common/job-control.h: Rename include guard.
12888         * common/host-defs.h: Rename include guard.
12889         * common/gdb_wait.h: Rename include guard.
12890         * common/gdb_vecs.h: Rename include guard.
12891         * common/gdb_unlinker.h: Rename include guard.
12892         * common/gdb_unique_ptr.h: Rename include guard.
12893         * common/gdb_tilde_expand.h: Rename include guard.
12894         * common/gdb_sys_time.h: Rename include guard.
12895         * common/gdb_string_view.h: Rename include guard.
12896         * common/gdb_splay_tree.h: Rename include guard.
12897         * common/gdb_setjmp.h: Rename include guard.
12898         * common/gdb_ref_ptr.h: Rename include guard.
12899         * common/gdb_optional.h: Rename include guard.
12900         * common/gdb_locale.h: Rename include guard.
12901         * common/gdb_assert.h: Rename include guard.
12902         * common/filtered-iterator.h: Rename include guard.
12903         * common/filestuff.h: Rename include guard.
12904         * common/fileio.h: Rename include guard.
12905         * common/environ.h: Rename include guard.
12906         * common/common-utils.h: Rename include guard.
12907         * common/common-types.h: Rename include guard.
12908         * common/common-regcache.h: Rename include guard.
12909         * common/common-inferior.h: Rename include guard.
12910         * common/common-gdbthread.h: Rename include guard.
12911         * common/common-exceptions.h: Rename include guard.
12912         * common/common-defs.h: Rename include guard.
12913         * common/common-debug.h: Rename include guard.
12914         * common/cleanups.h: Rename include guard.
12915         * common/buffer.h: Rename include guard.
12916         * common/btrace-common.h: Rename include guard.
12917         * common/break-common.h: Rename include guard.
12918         * cli/cli-utils.h: Rename include guard.
12919         * cli/cli-style.h: Rename include guard.
12920         * cli/cli-setshow.h: Rename include guard.
12921         * cli/cli-script.h: Rename include guard.
12922         * cli/cli-interp.h: Rename include guard.
12923         * cli/cli-decode.h: Rename include guard.
12924         * cli/cli-cmds.h: Rename include guard.
12925         * charset-list.h: Add include guard.
12926         * buildsym-legacy.h: Rename include guard.
12927         * bfin-tdep.h: Add include guard.
12928         * ax.h: Rename include guard.
12929         * arm-linux-tdep.h: Add include guard.
12930         * arm-fbsd-tdep.h: Add include guard.
12931         * arch/xtensa.h: Rename include guard.
12932         * arch/tic6x.h: Add include guard.
12933         * arch/i386.h: Add include guard.
12934         * arch/arm.h: Rename include guard.
12935         * arch/arm-linux.h: Rename include guard.
12936         * arch/arm-get-next-pcs.h: Rename include guard.
12937         * arch/amd64.h: Add include guard.
12938         * arch/aarch64-insn.h: Rename include guard.
12939         * arch-utils.h: Rename include guard.
12940         * annotate.h: Add include guard.
12941         * amd64-darwin-tdep.h: Rename include guard.
12942         * aarch64-linux-tdep.h: Add include guard.
12943         * aarch64-fbsd-tdep.h: Add include guard.
12944         * aarch32-linux-nat.h: Add include guard.
12945
12946 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12947
12948         * macrotab.c (macro_define_internal): New function that
12949         factorizes macro_define_object_internal and macro_define_function
12950         code.
12951         (macro_define_object_internal): Use macro_define_internal.
12952         (macro_define_function): Likewise.
12953
12954 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12955
12956         * macrocmd.c (extract_identifier): Return
12957         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12958         callers.
12959
12960 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12961
12962         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12963
12964 2019-02-05  Tom Tromey  <tom@tromey.com>
12965
12966         * target.c (target_stack::unpush): Move assertion earlier.
12967
12968 2019-01-30  Tom Tromey  <tom@tromey.com>
12969
12970         PR python/23615:
12971         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12972         (gdbpy_parse_and_eval): Likewise.
12973         * python/python-internal.h (gdbpy_allow_threads): New class.
12974
12975 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12976
12977         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12978         (aarch64_fbsd_fpregmap): Move earlier.
12979         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12980         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12981         instead of individual calls to trad_frame_set_reg_addr.
12982         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12983         earlier.
12984         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12985         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12986         instead of individual calls to trad_frame_set_reg_addr.
12987
12988 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12989
12990         * CONTRIBUTE: Replace contribution list with wiki link.
12991
12992 2019-01-25  Tom Tromey  <tom@tromey.com>
12993
12994         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12995
12996 2019-01-25  Tom Tromey  <tom@tromey.com>
12997
12998         * xtensa-linux-nat.c: Fix common/ includes.
12999         * xml-support.h: Fix common/ includes.
13000         * xml-support.c: Fix common/ includes.
13001         * x86-linux-nat.c: Fix common/ includes.
13002         * windows-nat.c: Fix common/ includes.
13003         * varobj.h: Fix common/ includes.
13004         * varobj.c: Fix common/ includes.
13005         * value.c: Fix common/ includes.
13006         * valops.c: Fix common/ includes.
13007         * utils.c: Fix common/ includes.
13008         * unittests/xml-utils-selftests.c: Fix common/ includes.
13009         * unittests/utils-selftests.c: Fix common/ includes.
13010         * unittests/unpack-selftests.c: Fix common/ includes.
13011         * unittests/tracepoint-selftests.c: Fix common/ includes.
13012         * unittests/style-selftests.c: Fix common/ includes.
13013         * unittests/string_view-selftests.c: Fix common/ includes.
13014         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13015         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13016         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13017         * unittests/rsp-low-selftests.c: Fix common/ includes.
13018         * unittests/parse-connection-spec-selftests.c: Fix common/
13019         includes.
13020         * unittests/optional-selftests.c: Fix common/ includes.
13021         * unittests/offset-type-selftests.c: Fix common/ includes.
13022         * unittests/observable-selftests.c: Fix common/ includes.
13023         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13024         * unittests/memrange-selftests.c: Fix common/ includes.
13025         * unittests/memory-map-selftests.c: Fix common/ includes.
13026         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13027         * unittests/function-view-selftests.c: Fix common/ includes.
13028         * unittests/environ-selftests.c: Fix common/ includes.
13029         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13030         * unittests/common-utils-selftests.c: Fix common/ includes.
13031         * unittests/cli-utils-selftests.c: Fix common/ includes.
13032         * unittests/array-view-selftests.c: Fix common/ includes.
13033         * ui-file.c: Fix common/ includes.
13034         * tui/tui-io.c: Fix common/ includes.
13035         * tracepoint.h: Fix common/ includes.
13036         * tracepoint.c: Fix common/ includes.
13037         * tracefile-tfile.c: Fix common/ includes.
13038         * top.h: Fix common/ includes.
13039         * top.c: Fix common/ includes.
13040         * thread.c: Fix common/ includes.
13041         * target/waitstatus.h: Fix common/ includes.
13042         * target/waitstatus.c: Fix common/ includes.
13043         * target.h: Fix common/ includes.
13044         * target.c: Fix common/ includes.
13045         * target-memory.c: Fix common/ includes.
13046         * target-descriptions.c: Fix common/ includes.
13047         * symtab.h: Fix common/ includes.
13048         * symfile.c: Fix common/ includes.
13049         * stap-probe.c: Fix common/ includes.
13050         * spu-linux-nat.c: Fix common/ includes.
13051         * sparc-nat.c: Fix common/ includes.
13052         * source.c: Fix common/ includes.
13053         * solib.c: Fix common/ includes.
13054         * solib-target.c: Fix common/ includes.
13055         * ser-unix.c: Fix common/ includes.
13056         * ser-tcp.c: Fix common/ includes.
13057         * ser-pipe.c: Fix common/ includes.
13058         * ser-base.c: Fix common/ includes.
13059         * selftest-arch.c: Fix common/ includes.
13060         * s12z-tdep.c: Fix common/ includes.
13061         * rust-exp.y: Fix common/ includes.
13062         * rs6000-aix-tdep.c: Fix common/ includes.
13063         * riscv-tdep.c: Fix common/ includes.
13064         * remote.c: Fix common/ includes.
13065         * remote-notif.h: Fix common/ includes.
13066         * remote-fileio.h: Fix common/ includes.
13067         * remote-fileio.c: Fix common/ includes.
13068         * regcache.h: Fix common/ includes.
13069         * regcache.c: Fix common/ includes.
13070         * record-btrace.c: Fix common/ includes.
13071         * python/python.c: Fix common/ includes.
13072         * python/py-type.c: Fix common/ includes.
13073         * python/py-inferior.c: Fix common/ includes.
13074         * progspace.h: Fix common/ includes.
13075         * producer.c: Fix common/ includes.
13076         * procfs.c: Fix common/ includes.
13077         * proc-api.c: Fix common/ includes.
13078         * printcmd.c: Fix common/ includes.
13079         * ppc-linux-nat.c: Fix common/ includes.
13080         * parser-defs.h: Fix common/ includes.
13081         * osdata.c: Fix common/ includes.
13082         * obsd-nat.c: Fix common/ includes.
13083         * nat/x86-linux.c: Fix common/ includes.
13084         * nat/x86-linux-dregs.c: Fix common/ includes.
13085         * nat/x86-dregs.h: Fix common/ includes.
13086         * nat/x86-dregs.c: Fix common/ includes.
13087         * nat/ppc-linux.c: Fix common/ includes.
13088         * nat/mips-linux-watch.h: Fix common/ includes.
13089         * nat/mips-linux-watch.c: Fix common/ includes.
13090         * nat/linux-waitpid.c: Fix common/ includes.
13091         * nat/linux-ptrace.h: Fix common/ includes.
13092         * nat/linux-ptrace.c: Fix common/ includes.
13093         * nat/linux-procfs.c: Fix common/ includes.
13094         * nat/linux-personality.c: Fix common/ includes.
13095         * nat/linux-osdata.c: Fix common/ includes.
13096         * nat/linux-namespaces.c: Fix common/ includes.
13097         * nat/linux-btrace.h: Fix common/ includes.
13098         * nat/linux-btrace.c: Fix common/ includes.
13099         * nat/fork-inferior.c: Fix common/ includes.
13100         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13101         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13102         * nat/aarch64-linux.c: Fix common/ includes.
13103         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13104         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13105         * namespace.h: Fix common/ includes.
13106         * mips-linux-tdep.c: Fix common/ includes.
13107         * minsyms.c: Fix common/ includes.
13108         * mi/mi-parse.h: Fix common/ includes.
13109         * mi/mi-main.c: Fix common/ includes.
13110         * mi/mi-cmd-env.c: Fix common/ includes.
13111         * memrange.h: Fix common/ includes.
13112         * memattr.c: Fix common/ includes.
13113         * maint.h: Fix common/ includes.
13114         * maint.c: Fix common/ includes.
13115         * main.c: Fix common/ includes.
13116         * machoread.c: Fix common/ includes.
13117         * location.c: Fix common/ includes.
13118         * linux-thread-db.c: Fix common/ includes.
13119         * linux-nat.c: Fix common/ includes.
13120         * linux-fork.c: Fix common/ includes.
13121         * inline-frame.c: Fix common/ includes.
13122         * infrun.c: Fix common/ includes.
13123         * inflow.c: Fix common/ includes.
13124         * inferior.h: Fix common/ includes.
13125         * inferior.c: Fix common/ includes.
13126         * infcmd.c: Fix common/ includes.
13127         * inf-ptrace.c: Fix common/ includes.
13128         * inf-child.c: Fix common/ includes.
13129         * ia64-linux-nat.c: Fix common/ includes.
13130         * i387-tdep.c: Fix common/ includes.
13131         * i386-tdep.c: Fix common/ includes.
13132         * i386-linux-tdep.c: Fix common/ includes.
13133         * i386-linux-nat.c: Fix common/ includes.
13134         * i386-go32-tdep.c: Fix common/ includes.
13135         * i386-fbsd-tdep.c: Fix common/ includes.
13136         * i386-fbsd-nat.c: Fix common/ includes.
13137         * guile/scm-type.c: Fix common/ includes.
13138         * guile/guile.c: Fix common/ includes.
13139         * go32-nat.c: Fix common/ includes.
13140         * gnu-nat.c: Fix common/ includes.
13141         * gdbthread.h: Fix common/ includes.
13142         * gdbarch-selftests.c: Fix common/ includes.
13143         * gdb_usleep.c: Fix common/ includes.
13144         * gdb_select.h: Fix common/ includes.
13145         * gdb_bfd.c: Fix common/ includes.
13146         * gcore.c: Fix common/ includes.
13147         * fork-child.c: Fix common/ includes.
13148         * findvar.c: Fix common/ includes.
13149         * fbsd-nat.c: Fix common/ includes.
13150         * event-top.c: Fix common/ includes.
13151         * event-loop.c: Fix common/ includes.
13152         * dwarf2read.c: Fix common/ includes.
13153         * dwarf2loc.c: Fix common/ includes.
13154         * dwarf2-frame.c: Fix common/ includes.
13155         * dwarf-index-cache.c: Fix common/ includes.
13156         * dtrace-probe.c: Fix common/ includes.
13157         * disasm-selftests.c: Fix common/ includes.
13158         * defs.h: Fix common/ includes.
13159         * csky-tdep.c: Fix common/ includes.
13160         * cp-valprint.c: Fix common/ includes.
13161         * cp-support.h: Fix common/ includes.
13162         * cp-support.c: Fix common/ includes.
13163         * corelow.c: Fix common/ includes.
13164         * completer.h: Fix common/ includes.
13165         * completer.c: Fix common/ includes.
13166         * compile/compile.c: Fix common/ includes.
13167         * compile/compile-loc2c.c: Fix common/ includes.
13168         * compile/compile-cplus-types.c: Fix common/ includes.
13169         * compile/compile-cplus-symbols.c: Fix common/ includes.
13170         * command.h: Fix common/ includes.
13171         * cli/cli-dump.c: Fix common/ includes.
13172         * cli/cli-cmds.c: Fix common/ includes.
13173         * charset.c: Fix common/ includes.
13174         * build-id.c: Fix common/ includes.
13175         * btrace.h: Fix common/ includes.
13176         * btrace.c: Fix common/ includes.
13177         * breakpoint.h: Fix common/ includes.
13178         * breakpoint.c: Fix common/ includes.
13179         * ax.h:
13180         (enum agent_op): Fix common/ includes.
13181         * ax-general.c (struct aop_map): Fix common/ includes.
13182         * ax-gdb.c: Fix common/ includes.
13183         * auxv.c: Fix common/ includes.
13184         * auto-load.c: Fix common/ includes.
13185         * arm-tdep.c: Fix common/ includes.
13186         * arch/riscv.c: Fix common/ includes.
13187         * arch/ppc-linux-common.c: Fix common/ includes.
13188         * arch/i386.c: Fix common/ includes.
13189         * arch/arm.c: Fix common/ includes.
13190         * arch/arm-linux.c: Fix common/ includes.
13191         * arch/arm-get-next-pcs.c: Fix common/ includes.
13192         * arch/amd64.c: Fix common/ includes.
13193         * arch/aarch64.c: Fix common/ includes.
13194         * arch/aarch64-insn.c: Fix common/ includes.
13195         * arch-utils.c: Fix common/ includes.
13196         * amd64-windows-tdep.c: Fix common/ includes.
13197         * amd64-tdep.c: Fix common/ includes.
13198         * amd64-sol2-tdep.c: Fix common/ includes.
13199         * amd64-obsd-tdep.c: Fix common/ includes.
13200         * amd64-nbsd-tdep.c: Fix common/ includes.
13201         * amd64-linux-tdep.c: Fix common/ includes.
13202         * amd64-linux-nat.c: Fix common/ includes.
13203         * amd64-fbsd-tdep.c: Fix common/ includes.
13204         * amd64-fbsd-nat.c: Fix common/ includes.
13205         * amd64-dicos-tdep.c: Fix common/ includes.
13206         * amd64-darwin-tdep.c: Fix common/ includes.
13207         * agent.c: Fix common/ includes.
13208         * ada-lang.h: Fix common/ includes.
13209         * ada-lang.c: Fix common/ includes.
13210         * aarch64-tdep.c: Fix common/ includes.
13211
13212 2019-01-25  Tom Tromey  <tom@tromey.com>
13213
13214         * common/create-version.sh: Use common/version.h.
13215
13216 2019-01-24  Pedro Alves  <palves@redhat.com>
13217
13218         * infrun.c (signal_stop, signal_print, signal_program)
13219         (signal_catch, signal_pass): Now arrays instead of pointers.
13220         (update_signals_program_target, do_target_resume)
13221         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13222         * linux-nat.c (linux_nat_target::pass_signals)
13223         (linux_nat_target::create_inferior, linux_nat_target::attach):
13224         Adjust.
13225         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13226         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13227         * procfs.c (procfs_target::pass_signals): Adjust.
13228         * record-full.c (record_full_target::resume): Adjust.
13229         * remote.c (remote_target::pass_signals)
13230         (remote_target::program_signals): Adjust.
13231         * target-debug.h (target_debug_print_signals): Now takes a
13232         gdb::array_view as parameter.  Adjust.
13233         * target.h (target_ops) <pass_signals, program_signals>: Replace
13234         pointer and length parameters with gdb::array_view.
13235         (target_pass_signals, target_program_signals): Likewise.
13236         * target-delegates.c: Regenerate.
13237
13238 2019-01-24  Pedro Alves  <palves@redhat.com>
13239
13240         * common/forward-scope-exit.h
13241         (forward_scope_exit::forward_scope_exit): Pass arguments to
13242         m_bind_function directly, instead of creating a std::bind and
13243         copying that.
13244
13245 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13246
13247         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13248         for static members.
13249         (pass_in_v_vfp_candidate): Likewise.
13250
13251 2019-01-23  Tom Tromey  <tom@tromey.com>
13252             Pedro Alves  <palves@redhat.com>
13253
13254         * regcache.c (class regcache_invalidator): Remove.
13255         (regcache::raw_write): Use make_scope_exit.
13256
13257 2019-01-23  Tom Tromey  <tom@tromey.com>
13258
13259         * ui-out.h (class ui_out_emit_type): Update comment.
13260
13261 2019-01-23  Tom Tromey  <tom@tromey.com>
13262
13263         * infrun.c (fetch_inferior_event): Update comment.
13264
13265 2019-01-23  Tom Tromey  <tom@tromey.com>
13266             Pedro Alves  <palves@redhat.com>
13267
13268         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13269         parameter.
13270         (fetch_inferior_event): Use SCOPE_EXIT.
13271
13272
13273 2019-01-23  Tom Tromey  <tom@tromey.com>
13274             Pedro Alves  <palves@redhat.com>
13275
13276         * infrun.c (disable_thread_events): Delete.
13277         (stop_all_threads): Use SCOPE_EXIT.
13278
13279 2019-01-23  Tom Tromey  <tom@tromey.com>
13280             Pedro Alves  <palves@redhat.com>
13281
13282         * symfile.c: Include forward-scope-exit.h.
13283         (clear_symtab_users_cleanup): Replace forward declaration with
13284         a FORWARD_SCOPE_EXIT.
13285         (syms_from_objfile_1): Use the forward_scope_exit and
13286         gdb::optional instead of cleanup_function.
13287         (reread_symbols): Use the forward_scope_exit instead of
13288         cleanup_function.
13289         (clear_symtab_users_cleanup): Remove function.
13290
13291 2019-01-23  Tom Tromey  <tom@tromey.com>
13292             Pedro Alves  <palves@redhat.com>
13293
13294         * linux-nat.c: Include scope-exit.h.
13295         (cleanup_target_stop): Remove.
13296         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13297         SCOPE_EXIT.
13298
13299 2019-01-23  Tom Tromey  <tom@tromey.com>
13300             Pedro Alves  <palves@redhat.com>
13301
13302         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13303         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13304
13305 2019-01-23  Tom Tromey  <tom@tromey.com>
13306             Andrew Burgess  <andrew.burgess@embecosm.com>
13307             Pedro Alves  <palves@redhat.com>
13308
13309         * infrun.c (fetch_inferior_event): Use scope_exit.
13310         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13311         * top.c (execute_command): Use scope_exit.
13312         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13313         * utils.c (do_bpstat_clear_actions_cleanup)
13314         (make_bpstat_clear_actions_cleanup): Remove.
13315
13316 2019-01-23  Tom Tromey  <tom@tromey.com>
13317             Pedro Alves  <palves@redhat.com>
13318
13319         * infrun.c: Include "common/scope-exit.h"
13320         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13321         (wait_for_inferior): Use SCOPE_EXIT.
13322         (fetch_inferior_event): Use scope_exit.
13323
13324 2019-01-23  Tom Tromey  <tom@tromey.com>
13325             Pedro Alves  <palves@redhat.com>
13326
13327         * breakpoint.c (create_breakpoint): Remove cleanup.
13328
13329 2019-01-23  Tom Tromey  <tom@tromey.com>
13330             Andrew Burgess  <andrew.burgess@embecosm.com>
13331             Pedro Alves  <palves@redhat.com>
13332
13333 2019-01-23  Pedro Alves  <palves@redhat.com>
13334
13335         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13336
13337 2019-01-23  Pedro Alves  <palves@redhat.com>
13338             Andrew Burgess  <andrew.burgess@embecosm.com>
13339
13340         * gdbthread.h: Include "common/forward-scope-exit.h".
13341         (scoped_finish_thread_state): Redefine custom class in terms of
13342         forward_scope_exit.
13343
13344 2019-01-23  Pedro Alves  <palves@redhat.com>
13345             Andrew Burgess  <andrew.burgess@embecosm.com>
13346
13347         * common/forward-scope-exit.h: New file.
13348
13349 2019-01-23  Pedro Alves  <palves@redhat.com>
13350             Andrew Burgess  <andrew.burgess@embecosm.com>
13351             Tom Tromey  <tom@tromey.com>
13352
13353         * common/scope-exit.h: New file.
13354
13355 2019-01-23  Pedro Alves  <palves@redhat.com>
13356
13357         * common/preprocessor.h (ESC): Rename to ...
13358         (ESC_PARENS): ... this.
13359         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13360         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13361
13362 2019-01-23  Tom Tromey  <tom@tromey.com>
13363
13364         * language.h (class scoped_switch_to_sym_language_if_auto):
13365         Initialize m_lang in both cases.
13366
13367 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13368
13369         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13370         with XCNEW.
13371
13372 2019-01-22  Tom Tromey  <tom@tromey.com>
13373
13374         * corelow.c: Do not include sys/file.h.
13375
13376 2019-01-22  Tom Tromey  <tom@tromey.com>
13377
13378         * tui/tui-wingeneral.h: Include gdb_curses.h.
13379
13380 2019-01-22  Tom Tromey  <tom@tromey.com>
13381
13382         * source-cache.h (class source_cache) <get_source_lines,
13383         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13384
13385 2019-01-22  Tom Tromey  <tom@tromey.com>
13386
13387         * remote-fileio.h (struct remote_target): Declare.
13388
13389 2019-01-22  Tom Tromey  <tom@tromey.com>
13390
13391         * python/py-arch.c: Do not include py-ref.h.
13392         * python/py-bpevent.c: Do not include py-ref.h.
13393         * python/py-cmd.c: Do not include py-ref.h.
13394         * python/py-continueevent.c: Do not include py-ref.h.
13395         * python/py-event.h: Do not include py-ref.h.
13396         * python/py-evtregistry.c: Do not include py-ref.h.
13397         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13398         * python/py-frame.c: Do not include py-ref.h.
13399         * python/py-framefilter.c: Do not include py-ref.h.
13400         * python/py-function.c: Do not include py-ref.h.
13401         * python/py-infevents.c: Do not include py-ref.h.
13402         * python/py-linetable.c: Do not include py-ref.h.
13403         * python/py-objfile.c: Do not include py-ref.h.
13404         * python/py-param.c: Do not include py-ref.h.
13405         * python/py-prettyprint.c: Do not include py-ref.h.
13406         * python/py-progspace.c: Do not include py-ref.h.
13407         * python/py-symbol.c: Do not include py-ref.h.
13408         * python/py-symtab.c: Do not include py-ref.h.
13409         * python/py-type.c: Do not include py-ref.h.
13410         * python/py-unwind.c: Do not include py-ref.h.
13411         * python/py-utils.c: Do not include py-ref.h.
13412         * python/py-value.c: Do not include py-ref.h.
13413         * python/py-varobj.c: Do not include py-ref.h.
13414         * python/py-xmethods.c: Do not include py-ref.h.
13415         * python/python.c: Do not include py-ref.h.
13416         * varobj.c: Do not include py-ref.h.
13417
13418 2019-01-22  Tom Tromey  <tom@tromey.com>
13419
13420         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13421         keyword for bcache.
13422
13423 2019-01-22  Tom Tromey  <tom@tromey.com>
13424
13425         * compile/compile-cplus-types.c: Remove a comment by #include.
13426
13427 2019-01-22  Tom Tromey  <tom@tromey.com>
13428
13429         * compile/gcc-c-plugin.h: Include compile-internal.h.
13430
13431 2019-01-22  Tom Tromey  <tom@tromey.com>
13432
13433         * stabsread.c (EXTERN): Do not define.
13434         (symnum, next_symbol_text_func, processing_gcc_compilation)
13435         (within_function, global_sym_chain, global_stabs)
13436         (previous_stab_code, this_object_header_files)
13437         (n_this_object_header_files)
13438         (n_allocated_this_object_header_files): Define.
13439         * stabsread.h (EXTERN): Never define.  Use "extern".
13440
13441 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13442
13443         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13444         history_value.
13445
13446 2019-01-21  Tom Tromey  <tom@tromey.com>
13447
13448         * ui-out.c: Fix includes.
13449         * tui/tui-source.c: Fix includes.
13450         * target.c: Fix includes.
13451         * remote.c: Fix includes.
13452         * regcache.c: Fix includes.
13453         * python/py-block.c: Fix includes.
13454         * printcmd.c: Fix includes.
13455         * or1k-tdep.c: Fix includes.
13456         * mi/mi-main.c: Fix includes.
13457         * m32r-tdep.c: Fix includes.
13458         * csky-tdep.c: Fix includes.
13459         * compile/compile-cplus-types.c: Fix includes.
13460         * cli/cli-interp.c: Fix includes.
13461
13462 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13463
13464         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13465         for padding.
13466
13467 2019-01-16  Tom Tromey  <tom@tromey.com>
13468
13469         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13470         earlier.
13471         (struct objfile) <msymbols_range>: Move from top level.
13472         <msymbols>: New method.
13473         (class objfile_msymbols): Remove.
13474         * symtab.c (default_collect_symbol_completion_matches_break_on):
13475         Update.
13476         * symmisc.c (dump_msymbols): Update.
13477         * stabsread.c (scan_file_globals): Update.
13478         * objc-lang.c (info_selectors_command, info_classes_command)
13479         (find_methods): Update.
13480         * minsyms.c (find_solib_trampoline_target): Update.
13481         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13482         * coffread.c (coff_symfile_read): Update.
13483         * ada-lang.c (ada_lookup_simple_minsym)
13484         (ada_collect_symbol_completion_matches): Update.
13485
13486 2019-01-16  Tom Tromey  <tom@tromey.com>
13487
13488         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13489         type.  Remove no-argument constructor.
13490         <iterator::operator++>: Simplify.
13491         <begin>: Update.
13492         <end>: Use minimal_symbol_count.
13493
13494 2019-01-16  Tom Tromey  <tom@tromey.com>
13495
13496         * objfiles.h (struct objfile) <psymtabs>: New method.
13497         (class objfile_psymtabs): Remove.
13498         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13499         typedef.
13500         <range>: New method.
13501         (require_partial_symbols): Change return type.
13502         * psymtab.c (require_partial_symbols)
13503         (psym_expand_symtabs_matching): Update.
13504         * mdebugread.c (parse_partial_symbols): Update.
13505         * dbxread.c (dbx_end_psymtab): Update.
13506
13507 2019-01-15  Tom Tromey  <tom@tromey.com>
13508
13509         * symtab.c (lookup_objfile_from_block)
13510         (lookup_symbol_in_objfile_symtabs)
13511         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13512         (find_line_symtab, info_sources_command)
13513         (default_collect_symbol_completion_matches_break_on)
13514         (make_source_files_completion_list): Update.
13515         * symmisc.c (print_objfile_statistics, dump_objfile)
13516         (maintenance_print_symbols, maintenance_info_symtabs)
13517         (maintenance_check_symtabs, maintenance_info_line_tables):
13518         Update.
13519         * source.c (select_source_symtab)
13520         (forget_cached_source_info_for_objfile): Update.
13521         * objfiles.h (class objfile_compunits): Remove.
13522         (struct objfile) <compunits_range>: New typedef.
13523         (compunits): New method.
13524         * objfiles.c (objfile_relocate1): Update.
13525         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13526         * maint.c (count_symtabs_and_blocks): Update.
13527         * linespec.c (iterate_over_all_matching_symtabs): Update.
13528         * cp-support.c (add_symbol_overload_list_qualified): Update.
13529         * coffread.c (coff_symtab_read): Update.
13530         * ada-lang.c (add_nonlocal_symbols)
13531         (ada_collect_symbol_completion_matches)
13532         (ada_add_global_exceptions): Update.
13533
13534 2019-01-15  Tom Tromey  <tom@tromey.com>
13535
13536         * progspace.h (program_space) <objfiles_safe_range>: New
13537         typedef.
13538         <objfiles_safe>: New method.
13539         * objfiles.h (class all_objfiles_safe): Remove.
13540         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13541         * jit.c (jit_inferior_exit_hook): Update.
13542
13543 2019-01-17  Tom Tromey  <tom@tromey.com>
13544
13545         * progspace.h (program_space) <objfiles_range>: New typedef.
13546         <objfiles>: New method.
13547         <objfiles_head>: Rename from objfiles.
13548         (object_files): Update.
13549         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13550         * guile/scm-pretty-print.c
13551         (ppscm_find_pretty_printer_from_objfiles): Update.
13552         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13553         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13554         Update.
13555         * python/py-progspace.c (pspy_get_objfiles): Update.
13556         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13557         Update.
13558         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13559         (objfpy_lookup_objfile_by_build_id): Update.
13560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13562         Update.
13563         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13564         (expand_symtab_containing_pc, lookup_objfile_from_block)
13565         (lookup_static_symbol, basic_lookup_transparent_type)
13566         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13567         (find_line_symtab, info_sources_command)
13568         (default_collect_symbol_completion_matches_break_on)
13569         (make_source_files_completion_list, find_main_name): Update.
13570         * symmisc.c (print_symbol_bcache_statistics)
13571         (print_objfile_statistics, maintenance_print_symbols)
13572         (maintenance_print_msymbols, maintenance_print_objfiles)
13573         (maintenance_info_symtabs, maintenance_check_symtabs)
13574         (maintenance_expand_symtabs, maintenance_info_line_tables):
13575         Update.
13576         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13577         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13578         (map_overlay_command, unmap_overlay_command)
13579         (simple_overlay_update, expand_symtabs_matching)
13580         (map_symbol_filenames): Update.
13581         * symfile-debug.c (set_debug_symfile): Update.
13582         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13583         Update.
13584         * source.c (select_source_symtab, forget_cached_source_info):
13585         Update.
13586         * solib.c (solib_read_symbols): Update.
13587         * solib-spu.c (append_ocl_sos): Update.
13588         * psymtab.c (maintenance_print_psymbols)
13589         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13590         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13591         * printcmd.c (info_symbol_command): Update.
13592         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13593         Update.
13594         * objfiles.h (class all_objfiles): Remove.
13595         * objfiles.c (have_partial_symbols, have_full_symbols)
13596         (have_minimal_symbols, qsort_cmp, update_section_map)
13597         (shared_objfile_contains_address_p)
13598         (default_iterate_over_objfiles_in_search_order): Update.
13599         * objc-lang.c (info_selectors_command, info_classes_command)
13600         (find_methods): Update.
13601         * minsyms.c (find_solib_trampoline_target): Update.
13602         * maint.c (maintenance_info_sections)
13603         (maintenance_translate_address, count_symtabs_and_blocks):
13604         Update.
13605         * main.c (captured_main_1): Update.
13606         * linux-thread-db.c (try_thread_db_load_from_pdir)
13607         (has_libpthread): Update.
13608         * linespec.c (iterate_over_all_matching_symtabs)
13609         (search_minsyms_for_name): Update.
13610         * jit.c (jit_find_objf_with_entry_addr): Update.
13611         * hppa-tdep.c (find_unwind_entry)
13612         (hppa_lookup_stub_minimal_symbol): Update.
13613         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13614         Update.
13615         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13616         (elf_gnu_ifunc_resolve_by_got): Update.
13617         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13618         * dwarf-index-write.c (save_gdb_index_command): Update.
13619         * cp-support.c (add_symbol_overload_list_qualified): Update.
13620         * breakpoint.c (create_overlay_event_breakpoint)
13621         (create_longjmp_master_breakpoint)
13622         (create_std_terminate_master_breakpoint)
13623         (create_exception_master_breakpoint): Update.
13624         * blockframe.c (find_pc_partial_function): Update.
13625         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13626         (ada_collect_symbol_completion_matches)
13627         (ada_add_global_exceptions): Update.
13628
13629 2019-01-17  Tom Tromey  <tom@tromey.com>
13630
13631         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13632         declare VEC.
13633         (solib_target_parse_libraries): Change return type.
13634         (library_list_start_segment, library_list_start_section)
13635         (library_list_end_library, library_list_start_library); Update.
13636         (solib_target_free_library_list): Remove.
13637         (solib_target_parse_libraries): Remove cleanup.  Change return
13638         type.
13639         (solib_target_current_sos): Update.
13640
13641 2019-01-17  Tom Tromey  <tromey@bapiya>
13642
13643         * valprint.c: Replace "the the" with "the".
13644         * symtab.c: Replace "the the" with "the".
13645         * solib.c: Replace "the the" with "the".
13646         * solib-dsbt.c: Replace "the the" with "the".
13647         * linespec.c: Replace "the the" with "the".
13648         * dwarf2loc.h: Replace "the the" with "the".
13649         * amd64-windows-tdep.c: Replace "the the" with "the".
13650         * aarch64-tdep.c: Replace "the the" with "the".
13651
13652 2019-01-16  Keith Seitz  <keiths@redhat.com>
13653
13654         PR gdb/23773
13655         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13656         <builder>: Rename to ..
13657         <m_builder>: ... this and make private.
13658         (dwarf2_cu::get_builder): New method.  Change all users of
13659         `builder' to use this method.
13660         (dwarf2_start_symtab): Move to ...
13661         (dwarf2_cu::start_symtab): ... here.  Update all callers
13662         (setup_type_unit_groups): Move to ...
13663         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13664         callers.
13665         (dwarf2_cu::reset_builder): New method.
13666         (process_full_compunit, process_full_type_unit): Use
13667         dwarf2_cu::reset_builder.
13668         (follow_die_offset): Record the ancestor CU if it is different
13669         from the followed DIE's CU.
13670         (follow_die_sig_1): Likewise.
13671
13672 2019-01-15  Tom Tromey  <tom@tromey.com>
13673
13674         * remote.c (class remote_state) <buf>: Now a char_vector.
13675         <buf_size>: Remove.
13676         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13677         parameter.
13678         (remote_target::getpkt_or_notif_sane_1)
13679         (remote_target::getpkt_sane)
13680         (remote_target::getpkt_or_notif_sane): Likewise.
13681         (class remote_target) <putpkt>: New overload.
13682         (remote_target::read_frame): Change type of "buf_p".  Remove
13683         sizeof_p parameter.
13684         (packet_ok): New overload.
13685         (packet_check_result): New overload.
13686         Update all uses.
13687
13688 2019-01-14  Tom Tromey  <tom@tromey.com>
13689
13690         * remote-notif.c (handle_notification, remote_notif_ack)
13691         (remote_notif_parse): Make "buf" const.
13692         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13693         const.
13694         (remote_notif_parse, remote_notif_ack, handle_notification):
13695         Likewise.
13696         * remote.c (remote_notif_stop_parse): Make "buf" const.
13697         (remote_target::remote_parse_stop_reply): Make "buf" const.
13698         (remote_notif_stop_ack): Make "buf" const.
13699
13700 2019-01-14  Tom Tromey  <tom@tromey.com>
13701
13702         * remote.c (remote_console_output): Make parameter const.
13703
13704 2019-01-14  Tom Tromey  <tom@tromey.com>
13705
13706         * target-debug.h (target_debug_print_signals): Constify.
13707         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13708         * procfs.c (procfs_target::pass_signals): Update.
13709         * linux-nat.c (linux_nat_target::pass_signals): Update.
13710         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13711         * target-delegates.c: Rebuild.
13712         * remote.c (remote_target::program_signals): Update.
13713         (remote_target::pass_signals): Update.
13714         * target.c (target_pass_signals): Constify argument.
13715         (target_program_signals): Likewise.
13716         * target.h (struct target_ops) <pass_signals, program_signals>:
13717         Constify argument.
13718         (target_pass_signals, target_program_signals): Constify argument.
13719
13720 2019-01-14  Tom Tromey  <tom@tromey.com>
13721
13722         PR tui/28819:
13723         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13724
13725 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13726
13727         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13728         field.
13729         * rs6000-tdep.c: Include reggroups.h.
13730         (IS_V_ALIAS_PSEUDOREG): Define.
13731         (rs6000_register_name): Return names for the "vX" aliases.
13732         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13733         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13734         aliases.  Call default_register_reggroup_p for all other
13735         pseudo-registers.
13736         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13737         New functions.
13738         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13739         Handle "vX" aliases.
13740         (v_alias_pseudo_register_collect): New function.
13741         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13742         (rs6000_gdbarch_init): Initialize "vX" aliases as
13743         pseudo-registers.  Restore registration of
13744         rs6000_pseudo_register_reggroup_p with
13745         set_tdesc_pseudo_register_reggroup_p.
13746
13747 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13748
13749         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13750         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13751         set_gdbarch_num_pseudo_regs.
13752
13753 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13754
13755         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13756         Remove arg prefixname, add do_set and do_show.
13757         Add member functions set_list and show_list.
13758         * cli/cli-style.c (class cli_style_option): Update accordingly.
13759         (style_set_list): Move to file scope.
13760         (style_show_list): Likewise.
13761         (set_style): Call help_list.
13762         (show_style): Call cmd_show_list.
13763         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13764         Update to use the new macro.
13765
13766 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13767
13768         * ada-lang.c (_initialize_ada_language): Expand the help text
13769         for the "catch exception" command.
13770
13771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13772
13773         * symtab.c (matching_obj_sections): Initialize obj,
13774         declare it closer to its usage.
13775
13776 2019-01-10  Tom Tromey  <tom@tromey.com>
13777
13778         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13779         (basic_inf_threads_range): Remove.
13780         (inf_threads_range, inf_non_exited_threads_range)
13781         (safe_inf_threads_range): Use next_adapter.
13782
13783 2019-01-10  Keith Seitz  <keiths@redhat.com>
13784
13785         PR gdb/23712
13786         PR symtab/23010
13787         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13788         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13789
13790 2019-01-10  Keith Seitz  <keiths@redhat.com>
13791
13792         PR gdb/23712
13793         PR symtab/23010
13794         * dictionary.c (pending_to_vector): Remove.
13795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13796         Remove _1 suffix, replacing functions of the same name.  Update
13797         all callers.
13798         (dict_create_hashed, dict_create_hashed_expandable)
13799         (dict_create_linear, dict_create_linear_expandable, dict_free)
13800         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13801         Make functions static.
13802
13803 2019-01-10  Keith Seitz  <keiths@redhat.com>
13804
13805         PR gdb/23712
13806         PR symtab/23010
13807         * dictionary.h (struct dictionary): Replace declaration with
13808         multidictionary.
13809         (dict_create_hashed, dict_create_hashed_expandable)
13810         (dict_create_linear, dict_create_linear_expandable)
13811         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13812         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13813         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13814         taking multidictionary argument.
13815         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13816         * block.h (struct block) <dict>: Change to multidictionary
13817         and rename `multidict'.
13818         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13819         symmisc.c: Update all dictionary references to multidictionary.
13820
13821 2019-01-10  Keith Seitz  <keiths@redhat.com>
13822
13823         PR gdb/23712
13824         PR symtab/23010
13825         * dictionary.c: Include unordered_map.
13826         (pending_to_vector): New function.
13827         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13828         Rewrite the non-"_1" functions to take vector instead
13829         of linked list.
13830         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13831         "new" _1 versions of the same name.
13832         (multidictionary): Define.
13833         (std::hash<enum language): New definition.
13834         (collate_pending_symbols_by_language, mdict_create_hashed)
13835         (mdict_create_hashed_expandable, mdict_create_linear)
13836         (mdict_create_linear_expandable, mdict_free)
13837         (find_language_dictionary, create_new_language_dictionary)
13838         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13839         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13840         (mdict_size, mdict_empty): New functions.
13841         * dictionary.h (mdict_iterator): Define.
13842
13843 2019-01-10  Pedro Alves  <palves@redhat.com>
13844
13845         * breakpoint.c (read_uploaded_action)
13846         (create_tracepoint_from_upload): Adjust to use
13847         gdb::unique_xmalloc_ptr.
13848         * ctf.c (ctf_write_uploaded_tp):
13849         (SET_ARRAY_FIELD): Use emplace_back.
13850         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13851         * tracefile-tfile.c (tfile_write_uploaded_tp):
13852         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13853         gdb::unique_xmalloc_ptr.
13854         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13855         at_string, cond_string, cmd_strings>: Replace char pointers
13856         with gdb::unique_xmalloc_ptr.
13857
13858 2019-01-10  Pedro Alves  <palves@redhat.com>
13859
13860         * solib-target.c (library_list_start_library): Don't xstrdup name.
13861
13862 2019-01-10  Pedro Alves  <palves@redhat.com>
13863
13864         * mdebugread.c (parse_partial_symbols): Use
13865         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13866
13867 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13868
13869         * linux-fork.c (scoped_switch_fork_info)
13870         <~scoped_switch_fork_info>: Fix incorrect variable name.
13871
13872 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13873
13874         * linux-fork.c (scoped_switch_fork_info)
13875         <scoped_switch_fork_info>: Make explicit.
13876         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13877
13878 2019-01-10  Tom Tromey  <tom@tromey.com>
13879
13880         * objfiles.h (objfile::reset_psymtabs): Update.
13881         * objfiles.c (objfile::objfile): Update.
13882         * psymtab.h (psymtab_storage::obstack): Update.
13883         (psymtab_storage::m_obstack): Use gdb::optional.
13884         (class psymtab_storage): Update comment.  Remove objfile
13885         parameter.
13886         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13887
13888 2019-01-10  Tom Tromey  <tom@tromey.com>
13889
13890         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13891         <free_psymtabs>: Now private.
13892         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13893         (allocate_psymtab): Use new method.
13894
13895 2019-01-10  Tom Tromey  <tom@tromey.com>
13896
13897         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13898         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13899         * mdebugread.c (parse_partial_symbols): Use
13900         allocate_dependencies.
13901         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13902         allocate_dependencies.
13903         (process_psymtab_comp_unit_reader)
13904         (build_type_psymtab_dependencies): Likewise.
13905         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13906
13907 2019-01-10  Tom Tromey  <tom@tromey.com>
13908
13909         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13910         PSYMBOL_SET_LANGUAGE.
13911         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13912
13913 2019-01-10  Tom Tromey  <tom@tromey.com>
13914
13915         * psymtab.h (psymtab_storage::obstack): New method.
13916         <m_obstack>: Rename from obstack; now private.
13917         * psymtab.c (psymtab_storage): Update.
13918         * dwarf2read.c (create_addrmap_from_index)
13919         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13920         Update.
13921
13922 2019-01-10  Tom Tromey  <tom@tromey.com>
13923
13924         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13925         * objfiles.h (objfile::reset_psymtabs): New method.
13926
13927 2019-01-10  Tom Tromey  <tom@tromey.com>
13928
13929         * symmisc.c (print_symbol_bcache_statistics): Update.
13930         (print_objfile_statistics): Update.
13931         * symfile.c (reread_symbols): Update.
13932         * psymtab.h (class psymtab_storage): New.
13933         * psymtab.c (psymtab_storage): New constructor.
13934         (~psymtab_storage): New destructor.
13935         (require_partial_symbols): Update.
13936         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13937         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13938         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13939         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13940         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13941         (start_psymtab_common, end_psymtab_common)
13942         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13943         (allocate_psymtab): Update.
13944         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13945         Update.
13946         (dump_psymtab_addrmap, maintenance_print_psymbols)
13947         (maintenance_check_psymtabs): Update.
13948         (class objfile_psymtabs): Move to objfiles.h.
13949         * psympriv.h (discard_psymtab): Now inline.
13950         (psymtab_discarder::psymtab_discarder): Update.
13951         (psymtab_discarder::~psymtab_discarder): Update.
13952         (ALL_OBJFILE_PSYMTABS): Rewrite.
13953         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13954         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13955         Remove fields.
13956         <partial_symtabs>: New field.
13957         (class objfile_psymtabs): Move from psymtab.h.  Update.
13958         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13959         psymbol_cache.
13960         (objfile::~objfile): Don't destroy psymbol_cache.
13961         * mdebugread.c (parse_partial_symbols): Update.
13962         * dwarf2read.c (create_addrmap_from_index)
13963         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13964         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13965         (add_partial_subprogram, dwarf2_ranges_read): Update.
13966         * dwarf-index-write.c (write_address_map)
13967         (write_one_signatured_type, recursively_write_psymbols)
13968         (class debug_names, class debug_names, write_psymtabs_to_index):
13969         Update.
13970
13971 2019-01-10  Tom Tromey  <tom@tromey.com>
13972
13973         * symtab.h (SYMBOL_SET_NAMES): Update.
13974         (symbol_set_names): Update.
13975         (MSYMBOL_SET_NAMES): Update.
13976         * symtab.c (symbol_set_names): Change argument to be an
13977         objfile_per_bfd_storage.
13978         * psymtab.c (add_psymbol_to_bcache): Update.
13979         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13980
13981 2019-01-10  Tom Tromey  <tom@tromey.com>
13982
13983         * symtab.c (create_demangled_names_hash): Change argument to be an
13984         objfile_per_bfd_storage.
13985         (symbol_set_names): Update.
13986
13987 2019-01-10  Tom Tromey  <tom@tromey.com>
13988
13989         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13990         init_psymbol_list.
13991         * psymtab.c (init_psymbol_list): Do nothing if already called.
13992         * psympriv.h (init_psymbol_list): Add comment.
13993         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13994         init_psymbol_list.
13995         * dbxread.c (dbx_symfile_read): Unconditionally call
13996         init_psymbol_list.
13997
13998 2019-01-10  Tom Tromey  <tom@tromey.com>
13999
14000         * xcoffread.c (scan_xcoff_symtab): Update.
14001         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14002         "where".
14003         * mdebugread.c (parse_partial_symbols)
14004         (handle_psymbol_enumerators): Update.
14005         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14006         * dbxread.c (read_dbx_symtab): Update.
14007         * psympriv.h (psymbol_placement): New enum.
14008         (add_psymbol_to_list): Update.
14009
14010 2019-01-10  Tom Tromey  <tom@tromey.com>
14011
14012         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14013         static_psymbols parameters.
14014         (scan_xcoff_symtab): Update.
14015         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14016         static_psymbols parameters.
14017         * psympriv.h (start_psymtab_common): Update.
14018         * mdebugread.c (parse_partial_symbols): Update.
14019         * dwarf2read.c (create_partial_symtab): Update.
14020         * dbxread.c (read_dbx_symtab): Update.
14021         (start_psymtab): Remove global_psymbols and static_psymbols
14022         parameters.
14023
14024 2019-01-10  Tom Tromey  <tom@tromey.com>
14025
14026         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14027         * psymtab.c (allocate_psymtab): Add comment.
14028         * psympriv.h (allocate_psymtab): Add comment.
14029         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14030         initializations.
14031         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14032
14033 2019-01-10  Tom Tromey  <tom@tromey.com>
14034
14035         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14036         Don't declare.
14037         * mipsread.c: Include mdebugread.h.
14038         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14039         Declare.
14040         * elfread.c: Include mdebugread.h.
14041
14042 2019-01-09  Tom Tromey  <tom@tromey.com>
14043
14044         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14045         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14046         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14047         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14048         (psym_lookup_symbol, psym_find_last_source_symtab)
14049         (psym_forget_cached_source_info, psym_print_stats)
14050         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14051         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14052         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14053         (psym_find_compunit_symtab_by_address)
14054         (maintenance_print_psymbols, maintenance_info_psymtabs)
14055         (maintenance_check_psymtabs): Use ranged for.
14056         * psymtab.h (class objfile_psymtabs): New.
14057         (require_partial_symbols): Return objfile_psymtabs.
14058         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14059
14060 2019-01-09  Tom Tromey  <tom@tromey.com>
14061
14062         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14063         (find_pc_mapped_section, list_overlays_command)
14064         (map_overlay_command, unmap_overlay_command)
14065         (simple_overlay_update): Use all_objfiles.
14066         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14067         * printcmd.c (info_symbol_command): Use all_objfiles.
14068         * objfiles.h (ALL_OBJSECTIONS): Remove.
14069         * maint.c (maintenance_translate_address): Use all_objfiles.
14070         * gcore.c (gcore_create_callback): Use all_objfiles.
14071         (objfile_find_memory_regions): Likewise.
14072
14073 2019-01-09  Tom Tromey  <tom@tromey.com>
14074
14075         * symtab.c (find_line_symtab, info_sources_command)
14076         (make_source_files_completion_list): Use objfile_compunits.
14077         * source.c (select_source_symtab): Use objfile_compunits.
14078         * objfiles.h (struct objfile): Update comment.
14079         (ALL_OBJFILES): Remove.
14080         (ALL_FILETABS): Remove.
14081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14082         objfile_compunits.
14083
14084 2019-01-09  Tom Tromey  <tom@tromey.com>
14085
14086         * symmisc.c (print_objfile_statistics, dump_objfile)
14087         (maintenance_print_symbols): Use compunit_filetabs.
14088         * source.c (forget_cached_source_info_for_objfile): Use
14089         compunit_filetabs.
14090         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14091         (ALL_FILETABS): Use compunit_filetabs.
14092         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14093         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14094
14095 2019-01-09  Tom Tromey  <tom@tromey.com>
14096
14097         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14098         (compunit_filetabs): New.
14099         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14100         compunit_filetabs.
14101         (info_sources_command, make_source_files_completion_list): Remove
14102         declaration.
14103         * symmisc.c (print_objfile_statistics, dump_objfile)
14104         (maintenance_print_symbols): Remove declaration.
14105         (maintenance_info_symtabs): Use compunit_filetabs.
14106         (maintenance_info_line_tables): Likewise.
14107         * source.c (select_source_symtab): Change local variable name.
14108         (forget_cached_source_info_for_objfile): Remove declaration.
14109         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14110         * objfiles.c (objfile_relocate1): Remove declaration.
14111         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14112         declaration.
14113         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14114         * coffread.c (coff_symtab_read): Remove declaration.
14115         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14116         compunit_filetabs.
14117
14118 2019-01-09  Tom Tromey  <tom@tromey.com>
14119
14120         * symtab.c (lookup_objfile_from_block)
14121         (find_pc_sect_compunit_symtab, search_symbols)
14122         (default_collect_symbol_completion_matches_break_on): Use
14123         objfile_compunits.
14124         * objfiles.h (ALL_COMPUNITS): Remove.
14125         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14126         * cp-support.c (add_symbol_overload_list_qualified): Use
14127         objfile_compunits.
14128         * ada-lang.c (ada_collect_symbol_completion_matches)
14129         (ada_add_global_exceptions): Use objfile_compunits.
14130
14131 2019-01-09  Tom Tromey  <tom@tromey.com>
14132
14133         * source.c (select_source_symtab)
14134         (forget_cached_source_info_for_objfile): Remove declaration.
14135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14136         declaration.
14137         * maint.c (count_symtabs_and_blocks): Remove declaration.
14138         * cp-support.c (add_symbol_overload_list_qualified): Remove
14139         declaration.
14140         * coffread.c (coff_symtab_read): Remove declaration.
14141         * symtab.c (lookup_symbol_in_objfile_symtabs)
14142         (basic_lookup_transparent_type_1): Use objfile_compunits.
14143         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14144         (info_sources_command, search_symbols)
14145         (default_collect_symbol_completion_matches_break_on)
14146         (make_source_files_completion_list): Remove declaration.
14147         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14148         (ada_collect_symbol_completion_matches)
14149         (ada_add_global_exceptions): Remove declaration.
14150         * linespec.c (iterate_over_all_matching_symtabs): Use
14151         objfile_compunits.
14152         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14153         (class objfile_compunits): New.
14154         (ALL_COMPUNITS): Use objfile_compunits.
14155         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14156         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14157         objfile_compunits.
14158         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14159
14160 2019-01-09  Tom Tromey  <tom@tromey.com>
14161
14162         * symtab.c (search_symbols)
14163         (default_collect_symbol_completion_matches_break_on): Use
14164         objfile_msymbols.
14165         * ada-lang.c (ada_lookup_simple_minsym)
14166         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14167         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14168         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14169         objfile_msymbols.
14170         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14171         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14172         * objc-lang.c (find_methods): Use objfile_msymbols.
14173         (info_selectors_command, info_classes_command): Likewise.
14174         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14175         * objfiles.h (class objfile_msymbols): New.
14176         (ALL_OBJFILE_MSYMBOLS): Remove.
14177         (ALL_MSYMBOLS): Remove.
14178
14179 2019-01-09  Tom Tromey  <tom@tromey.com>
14180
14181         * common/next-iterator.h (next_adapter): Add Iterator template
14182         parameter.
14183         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14184         (class all_objfiles_safe): New.
14185         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14186         * objfiles.c (put_objfile_before): Update comment.
14187         (add_separate_debug_objfile): Likewise.
14188         (free_all_objfiles): Use all_objfiles_safe.
14189         (objfile_purge_solibs): Likewise.
14190
14191 2019-01-09  Tom Tromey  <tom@tromey.com>
14192
14193         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14194         (expand_symtab_containing_pc, lookup_static_symbol)
14195         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14196         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14197         all_objfiles.
14198         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14199         * breakpoint.c (create_overlay_event_breakpoint)
14200         (create_longjmp_master_breakpoint)
14201         (create_std_terminate_master_breakpoint)
14202         (create_exception_master_breakpoint): Use all_objfiles.
14203         * linux-thread-db.c (try_thread_db_load_from_pdir)
14204         (has_libpthread): Use all_objfiles.
14205         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14206         * linespec.c (iterate_over_all_matching_symtabs)
14207         (search_minsyms_for_name): Use all_objfiles.
14208         * maint.c (maintenance_info_sections): Use all_objfiles.
14209         * main.c (captured_main_1): Use all_objfiles.
14210         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14211         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14212         * guile/scm-pretty-print.c
14213         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14214         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14215         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14216         (maintenance_print_msymbols): Use all_objfiles.
14217         * source.c (select_source_symtab): Use all_objfiles.
14218         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14219         * symfile.c (remove_symbol_file_command)
14220         (expand_symtabs_matching, map_symbol_filenames): Use
14221         all_objfiles.
14222         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14223         all_objfiles.
14224         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14225         * objc-lang.c (find_methods): Use all_objfiles.
14226         * objfiles.c (have_partial_symbols, have_full_symbols)
14227         (have_minimal_symbols, qsort_cmp)
14228         (default_iterate_over_objfiles_in_search_order): Use
14229         all_objfiles.
14230         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14231         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14232         (maintenance_check_psymtabs): Use all_objfiles.
14233         (ALL_PSYMTABS): Remove.
14234         * compile/compile-object-run.c (do_module_cleanup): Use
14235         all_objfiles.
14236         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14237         * cp-support.c (add_symbol_overload_list_qualified): Use
14238         all_objfiles.
14239         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14240         Use all_objfiles.
14241         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14242         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14243         all_objfiles.
14244         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14245         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14246         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14247         Uses all_objfiles.
14248         * solib.c (solib_read_symbols): Use all_objfiles
14249
14250 2019-01-09  Tom Tromey  <tom@tromey.com>
14251
14252         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14253         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14254         all_objfiles.
14255         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14256         * symmisc.c (print_symbol_bcache_statistics)
14257         (print_objfile_statistics, maintenance_print_objfiles)
14258         (maintenance_info_symtabs, maintenance_check_symtabs)
14259         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14260         all_objfiles.
14261         * source.c (forget_cached_source_info): Use all_objfiles.
14262         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14263         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14264         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14265         * objfiles.c (update_section_map): Use all_objfiles.
14266         (shared_objfile_contains_address_p): Likewise.
14267         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14268         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14269
14270 2019-01-09  Tom Tromey  <tom@tromey.com>
14271
14272         * common/next-iterator.h: New file.
14273         * objfiles.h (class all_objfiles): New.
14274         (struct objfile_iterator): New.
14275
14276 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14277
14278         * NEWS: Move the description of the changed "frame", "select-frame",
14279          and "info frame" commands to the Changed commands section.
14280
14281 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14282
14283         * gdbtypes.c (check_stub_method_group): Remove handling of old
14284         mangling schemes.
14285         * linespec.c (find_methods): Likewise.
14286         * stabsread.c (read_member_functions): Likewise.
14287         * valops.c (search_struct_method): Likewise.
14288         (value_struct_elt_for_reference): Likewise.
14289         * NEWS: Mention this change.
14290
14291 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14292
14293         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14294         print_source_lines.
14295         * source.c (print_source_lines_base): Update line number check.
14296         (print_source_lines): New function.
14297         (source_lines_range::source_lines_range): New function.
14298         * source.h (class source_lines_range): New class.
14299         (print_source_lines): New declaration.
14300
14301 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14302
14303         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14304
14305 2019-01-08  Tom Tromey  <tom@tromey.com>
14306             Simon Marchi  <simon.marchi@ericsson.com>
14307
14308         PR gdb/24060
14309         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14310         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14311         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14312         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14313         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14314         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14315
14316 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14317
14318         * source.c (select_source_symtab): Move header comment to
14319         declaration in source.h.
14320         (forget_cached_source_info_for_objfile): Likewise.
14321         (forget_cached_source_info): Likewise.
14322         (identify_source_line): Likewise.
14323         * source.h (identify_source_line): Move declaration from symtab.h
14324         and add comment from source.c
14325         (print_source_lines): Likewise.
14326         (forget_cached_source_info_for_objfile): Likewise.
14327         (forget_cached_source_info): Likewise.
14328         (select_source_symtab): Likewise.
14329         (enum print_source_lines_flag): Move definition from symtab.h.
14330         * symtab.h (identify_source_line): Move declaration to source.h.
14331         (print_source_lines): Likewise.
14332         (forget_cached_source_info_for_objfile): Likewise.
14333         (forget_cached_source_info): Likewise.
14334         (select_source_symtab): Likewise.
14335         (enum print_source_lines_flag): Move definition to source.h.
14336         * tui/tui-hooks.c: Add 'source.h' include.
14337
14338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14339
14340         * source.c (print_source_lines_base): Handle requests to print
14341         reverse line number sequences, and guard against empty lines
14342         string.
14343
14344 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14345
14346         * source.c (print_source_lines_base): Fix skip of '\r' if next
14347         character is '\n'.
14348
14349 2019-01-06  Tom Tromey  <tom@tromey.com>
14350
14351         * c-exp.y (struct c_parse_state) <macro_original_text,
14352         expansion_obstack>: New member.
14353         (macro_original_text, expansion_obstack): Remove globals.
14354         (scan_macro_expansion, scanning_macro_expansion)
14355         (finished_macro_expansion): Update.
14356         (scan_macro_cleanup): Remove.
14357         (yylex, c_parse): Update.
14358
14359 2019-01-06  Tom Tromey  <tom@tromey.com>
14360
14361         * c-exp.y (struct c_parse_state) <strings>: New member.
14362         (operator_stoken): Update.
14363
14364 2019-01-06  Tom Tromey  <tom@tromey.com>
14365
14366         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14367         (union type_stack_elt) <typelist_val>: Now a pointer to
14368         std::vector.
14369         (type_stack_cleanup): Don't declare.
14370         (push_typelist): Update.
14371         * parse.c (pop_typelist): Return a std::vector.
14372         (push_typelist): Take a std::vector.
14373         (follow_types): Update.  Do not free args.
14374         (type_stack_cleanup): Remove.
14375         * c-exp.y (struct c_parse_state): New.
14376         (cpstate): New global.
14377         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14378         (nonempty_typelist): Update.
14379         (func_mod): Create a new vector.
14380         (c_parse): Create a c_parse_state.
14381         (check_parameter_typelist): Do not delete params.
14382         (function_method): Update.  Do not delete type_list.
14383
14384 2019-01-06  Tom Tromey  <tom@tromey.com>
14385
14386         PR gdb/28155:
14387         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14388         check_typedef.
14389         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14390         (print_return_value): Likewise.
14391
14392 2019-01-05  Tom Tromey  <tom@tromey.com>
14393
14394         * contrib/cleanup_check.py: Remove.
14395         * contrib/gcc-with-excheck: Remove.
14396         * contrib/exsummary.py: Remove.
14397         * contrib/excheck.py: Remove.
14398
14399 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14400
14401         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14402         NULL. Initialize tpprev to NULL instead of assigning it
14403         to NULL on the next statement.
14404         * windows-nat.c (windows_delete_thread): Remove check for
14405         main_thread_id before printing thread exit notifications.
14406         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14407         Remove thread ID check against main_thread_id.
14408         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14409         windows_delete_thread.
14410         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14411
14412 2019-01-04  Tom Tromey  <tom@tromey.com>
14413
14414         * compile/compile.c (_initialize_compile): Use upper case for
14415         metasyntactic variables.
14416         * symmisc.c (_initialize_symmisc): Use upper case for
14417         metasyntactic variables.
14418         * psymtab.c (_initialize_psymtab): Use upper case for
14419         metasyntactic variables.
14420         * demangle.c (demangle_command): Use upper case for metasyntactic
14421         variables.
14422         (_initialize_demangler): Likewise.
14423         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14424         variables.
14425
14426 2019-01-03  Tom Tromey  <tom@tromey.com>
14427
14428         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14429
14430 2019-01-03  Tom Tromey  <tom@tromey.com>
14431
14432         * python/py-symtab.c (salpy_str): Update.
14433         (struct salpy_sal_object) <symtab>: Now a PyObject.
14434         (salpy_dealloc): Update.
14435         (del_objfile_sal): Use gdbpy_ref.
14436
14437 2019-01-03  Tom Tromey  <tom@tromey.com>
14438
14439         * python/py-type.c (convert_field): Use new_reference.  Return
14440         gdbpy_ref.
14441         (make_fielditem): Return gdbpy_ref.
14442         (typy_fields): Update.
14443         (typy_getitem): Update.
14444         (field_name): Return gdbpy_ref.  Use new_reference.
14445         (typy_iterator_iternext): Update.
14446
14447 2019-01-03  Tom Tromey  <tom@tromey.com>
14448
14449         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14450
14451 2019-01-03  Tom Tromey  <tom@tromey.com>
14452
14453         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14454         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14455         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14456         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14457         (pspy_set_type_printers): Likewise.
14458         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14459         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14460         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14461         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14462         (objfpy_set_type_printers): Likewise.
14463
14464 2019-01-03  Tom Tromey  <tom@tromey.com>
14465
14466         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14467         (gdbpy_print_stack): Use gdbpy_err_fetch.
14468         * python/python-internal.h (class gdbpy_err_fetch): New class.
14469         (class gdbpy_enter) <m_error_type, m_error_value,
14470         m_error_traceback>: Remove.
14471         <m_error>: New member.
14472         (gdbpy_exception_to_string): Don't declare.
14473         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14474         * python/py-value.c (convert_value_from_python): Use
14475         gdbpy_err_fetch.
14476         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14477         gdbpy_exception_to_string.
14478         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14479         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14480         gdbpy_err_fetch.
14481
14482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14483
14484         * linux-nat.c (delete_lwp_cleanup): Delete.
14485         (struct lwp_deleter): New struct.
14486         (lwp_info_up): New typedef.
14487         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14488         lwp_info_up.
14489
14490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14491
14492         * linux-fork.c (class scoped_switch_fork_info): New class.
14493         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14494
14495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14496
14497         * valops.c (find_overload_match): Remove use of null_cleanup, and
14498         calls to do_cleanups.
14499
14500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14501
14502         * compile/compile-cplus-types.c
14503         (compile_cplus_instance::decl_name): Handle changes to
14504         cp_func_name.
14505         * cp-support.c (cp_func_name): Update header comment, update
14506         return type.
14507         * cp-support.h (cp_func_name): Update return type in declaration.
14508         * valops.c (find_overload_match): Move temp_func local to top
14509         level of function and change its type.  Use temp_func to hold and
14510         delete temporary string obtained from cp_func_name.
14511
14512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14513
14514         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14515         gdb::char_vector, remove cleanup, and update uses of `msg`.
14516
14517 2019-01-03  Jim Wilson  <jimw@sifive.com>
14518
14519         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14520
14521 2019-01-02  Tom Tromey  <tom@tromey.com>
14522
14523         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14524         (tdesc_parse_xml): Remove cleanups.
14525         * target-descriptions.h (make_cleanup_free_target_description):
14526         Don't declare.
14527         (target_desc_deleter): New struct.
14528         (target_desc_up): New typedef.
14529         * target-descriptions.c (target_desc_deleter::operator()): Rename
14530         from free_target_description.
14531         (make_cleanup_free_target_description): Remove.
14532
14533 2019-01-02  Tom Tromey  <tom@tromey.com>
14534
14535         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14536         constructor, destructor.
14537         (linespec_parser): Remove typedef.
14538         (~linespec_parser): Rename from linespec_parser_delete.
14539         (linespec_lex_to_end, linespec_complete_label)
14540         (linespec_complete): Update.
14541         (decode_line_full): Remove cleanups.
14542         (decode_line_1): Update.
14543
14544 2019-01-02  Tom Tromey  <tom@tromey.com>
14545
14546         * python/python-internal.h (inferior_to_inferior_object): Change
14547         return type.
14548         * python/py-exitedevent.c (create_exited_event_object): Update.
14549         * python/py-inferior.c (inferior_to_inferior_object): Return
14550         gdbpy_ref.
14551         (python_new_inferior, python_inferior_deleted)
14552         (thread_to_thread_object, delete_thread_object)
14553         (build_inferior_list, gdbpy_selected_inferior): Update.
14554         * python/py-infthread.c (create_thread_object): Update.  Also fail
14555         if inferior_to_inferior_object fails.
14556
14557 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14558
14559         * inferior.h (class inferior) <displaced_step_state>: New field.
14560         * infrun.h (struct displaced_step_state): Move here from
14561         infrun.c.  Initialize fields, add constructor.
14562         <inf>: Remove field.
14563         <reset>: New method.
14564         * infrun.c (struct displaced_step_inferior_state): Move to
14565         infrun.h.
14566         (displaced_step_inferior_states): Remove.
14567         (get_displaced_stepping_state): Adust.
14568         (displaced_step_in_progress_any_inferior): Adjust.
14569         (displaced_step_in_progress_thread): Adjust.
14570         (displaced_step_in_progress): Adjust.
14571         (add_displaced_stepping_state): Remove.
14572         (get_displaced_step_closure_by_addr): Adjust.
14573         (remove_displaced_stepping_state): Remove.
14574         (infrun_inferior_exit): Call displaced_step_state.reset.
14575         (use_displaced_stepping): Don't check for NULL.
14576         (displaced_step_prepare_throw): Call
14577         get_displaced_stepping_state.
14578         (displaced_step_fixup): Don't check for NULL.
14579         (prepare_for_detach): Don't check for NULL.
14580
14581 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14582
14583         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14584          in case of call that did not complete.
14585
14586 2019-01-02  Andrey Utkin  <autkin@undo.io>
14587
14588         * symfile.c (find_separate_debug_file): Fix search of debug files for
14589         remote debuggee.
14590
14591 2019-01-02  Tom Tromey  <tom@tromey.com>
14592
14593         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14594         indentation.
14595         * python/py-frame.c (frapy_older): Remove cast.
14596         (frapy_newer): Likewise.
14597         * python/py-breakpoint.c (local_setattro): Remove cast.
14598         * python/py-arch.c (archpy_name): Remove local variable.
14599         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14600
14601 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14602
14603         * unittests/basic_string_view/element_access/char/empty.cc:
14604         Fix year range in copyright header.
14605
14606 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14607
14608         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14609         Delete.
14610         <operator==>: Update with for removed field.
14611         <hash>: Likewise.
14612         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14613         <isa_features>: ...this.
14614         <abi_features>: New field.
14615         (riscv_isa_flen): Update comment.
14616         (riscv_abi_xlen): New declaration.
14617         (riscv_abi_flen): New declaration.
14618         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14619         isa_features.
14620         (riscv_abi_xlen): New function.
14621         (riscv_isa_flen): Update to get answer from isa_features.
14622         (riscv_abi_flen): New function.
14623         (riscv_has_fp_abi): Update to get answer from abi_features.
14624         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14625         xlen and flen.
14626         (riscv_call_info) <xlen, flen>: Update comment.
14627         (riscv_call_arg_struct): Remove invalid assertions
14628         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14629         is removed.
14630         (riscv_gdbarch_init): Gather isa features and abi features
14631         separately, ensure both match on the gdbarch when reusing an old
14632         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14633         a target with 64-bit float hardware.
14634
14635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14636
14637         * source.c (search_command_helper): Stop reverse search
14638         when line 1 has been searched.
14639
14640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14641
14642         * record-full.c (record_full_base_target::close): Rewrite
14643         record_full_core_buf_list free logic.
14644
14645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14646
14647         * break-catch-syscall.c (print_one_catch_syscall): xfree
14648         the last text.
14649
14650 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14651
14652         * top.c (print_gdb_version): Update Copyright year in version
14653         message.
14654
14655 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14656
14657         Update copyright year range in all GDB files.
14658
14659 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14660
14661         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14662
14663 For older changes see ChangeLog-2018.
14664 \f
14665 Local Variables:
14666 mode: change-log
14667 left-margin: 8
14668 fill-column: 74
14669 version-control: never
14670 coding: utf-8
14671 End:
14672