gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_erase_source_content): Clear the
   4         window's contents.
   5         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
   6         * tui/tui-source.c (tui_set_source_content_nil): Remove.
   7
   8 2019-07-17  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  11         (struct tui_data_item_window): Update.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  16         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  17         defines.
  18
  19 2019-07-17  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-winsource.h (tui_erase_source_content)
  22         (tui_clear_source_content): Remove "display_prompt" parameter.
  23         * tui/tui-winsource.c (tui_update_source_window_as_is)
  24         (tui_update_source_windows_with_addr): Update.
  25         (tui_clear_source_content): Remove "display_prompt" parameter.
  26         (tui_erase_source_content): Likewise.  Simplify.
  27         (tui_show_source_content): Update.
  28         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  29         * tui/tui-stack.c (tui_show_frame_info): Update.
  30         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  31         Remove defines.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  36         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  37         parameter.
  38         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  39         parameter.
  40
  41 2019-07-17  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-winsource.c (tui_clear_source_content)
  44         (tui_show_source_content, tui_show_exec_info_content)
  45         (tui_clear_exec_info_content): Update.
  46         * tui/tui-stack.c (tui_show_locator_content): Update.
  47         (tui_show_frame_info): Update.
  48         * tui/tui-source.h (tui_source_window): Don't declare.
  49         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  50         from tui_source_is_displayed.
  51         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  52         Remove field.
  53         (struct tui_source_window_base) <content_in_use>: New field.  Now
  54         bool.
  55         (struct tui_source_window) <showing_source_p>: New method.
  56         (TUI_SRC_WIN): Change cast.
  57         * tui/tui-data.c (tui_initialize_static_data): Update.
  58
  59 2019-07-17  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  62         location_matches_p.
  63         * tui/tui-source.c (tui_source_window::location_matches_p): New
  64         method.
  65         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  66         method.
  67         * tui/tui-data.h (struct tui_source_window_base)
  68         <location_matches_p>: New method.
  69         (struct tui_source_window, struct tui_disasm_window)
  70         <location_matches_p>: Likewise.
  71
  72 2019-07-17  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-win.c (tui_set_win_height_command): Rename from
  75         tui_set_win_height.
  76         (tui_set_win_height_command): Remove.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-source.c (tui_source_window): New constructor.  Add
  81         observer.
  82         (~tui_source_window): New destructor.
  83         (tui_source_window::style_changed): New method.
  84         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  85         (tui_attach_detach_observers): Update.
  86         * tui/tui-data.h (struct tui_source_window): Make constructor not
  87         inline.  Add destructor.
  88         (struct tui_source_window) <style_changed>: New method.
  89         <m_observable>: New member.
  90
  91 2019-07-17  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  94         * tui/tui-win.c (tui_resize_all): Fix typo.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  99         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 100         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 101         * tui/tui-win.c (window_name_completer): Use foreach.
 102         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 103         (update_tab_width): Likewise.
 104         * tui/tui-layout.c (show_layout): Update.
 105         * tui/tui-data.h (class tui_window_iterator): New.
 106         (struct all_tui_windows): New.
 107         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 112         parameter.  Don't reference globals.
 113         (tui_reg_command): Update.
 114
 115 2019-07-17  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-regs.c (tui_show_registers): Simplify.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-regs.c (tui_show_registers): Update.
 122         (tui_show_register_group): Add win_info parameter.
 123
 124 2019-07-17  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 127         Rename from tui_display_reg_element_at_line.
 128         (tui_data_window::display_registers_from_line): Update.
 129         * tui/tui-data.h (struct tui_data_window)
 130         <display_reg_element_at_line>: New method.
 131
 132 2019-07-17  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-regs.h (tui_display_registers_from)
 135         (tui_display_registers_from_line): Don't declare.
 136         * tui/tui-windata.c (tui_data_window::display_all_data)
 137         (tui_data_window::refresh_all)
 138         (tui_data_window::do_scroll_vertical): Update.
 139         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 140         from tui_display_registers_from.
 141         (tui_display_reg_element_at_line): Update.
 142         (tui_data_window::display_registers_from_line): Rename from
 143         tui_display_registers_from_line.
 144         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 145         display_registers_from_line>: New methods.
 146
 147 2019-07-17  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 150         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 151         from tui_erase_data_content.
 152         (tui_data_window::display_all_data)
 153         (tui_data_window::refresh_all)
 154         (tui_data_window::do_scroll_vertical): Update.
 155         * tui/tui-regs.c (tui_show_registers): Update.
 156         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 157         New method.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 162         declare.
 163         * tui/tui-windata.c
 164         (tui_data_window::delete_data_content_windows): Rename from
 165         tui_delete_data_content_windows.
 166         (tui_data_window::display_all_data)
 167         (tui_data_window::do_scroll_vertical): Update.
 168         * tui/tui-data.h (struct tui_data_window)
 169         <delete_data_content_windows>: New method.
 170
 171 2019-07-17  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 174         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 175
 176 2019-07-17  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 179         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 180         from tui_display_all_data.
 181         * tui/tui-win.c
 182         (tui_data_window::do_make_visible_with_new_height): Update.
 183         * tui/tui-regs.c (tui_show_registers): Update.
 184         * tui/tui-layout.c (tui_set_layout): Update.
 185         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 186         method.
 187
 188 2019-07-17  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 191         * tui/tui-windata.c (tui_display_data_from): Remove.
 192         (tui_data_window::refresh_all): Update.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 197         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 198         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 199         tui_display_registers_from_line.
 200         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 201         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 202         "force_display" parameter.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 207         declare.
 208         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 209         Rename from tui_first_reg_element_no_inline.
 210         (tui_display_reg_element_at_line)
 211         (tui_display_registers_from_line): Update.
 212         * tui/tui-data.h (struct tui_data_window)
 213         <first_reg_element_no_inline>: New method.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-windata.c (tui_display_data_from)
 218         (tui_data_window::do_scroll_vertical): Update.
 219         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 220         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 221         Rename from tui_line_from_reg_element_no.
 222         (tui_display_registers_from_line): Update.
 223         * tui/tui-data.h (struct tui_data_window)
 224         <line_from_reg_element_no>: New method.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 229         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 230         tui_last_regs_line_no.
 231         (tui_display_reg_element_at_line)
 232         (tui_display_registers_from_line): Update.
 233         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 234         method.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         PR tui/24722:
 239         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 240         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 241         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 242         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 243         (tui_update_breakpoint_info): Likewise.
 244         * tui/tui-hooks.c (tui_event_create_breakpoint)
 245         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 246         Update.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-winsource.c (tui_update_source_window_as_is)
 255         (tui_update_source_windows_with_addr): Update.
 256         * tui/tui-source.h (tui_set_source_content)
 257         (tui_show_symtab_source): Add "win_info" parameter.
 258         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 259         parameter.
 260         (tui_show_symtab_source): Likewise.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-wingeneral.c
 265         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 270         (struct tui_cmd_window) <can_scroll>: New method.
 271         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 272         method.
 273
 274 2019-07-17  Tom Tromey  <tromey@adacore.com>
 275
 276         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 277         do_field_signed>: Rename.  Change type of "value".
 278         * ui-out.c (ui_out::field_signed): Rename from field_int.
 279         Change type of "value".
 280         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 281         type of "value".
 282         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 283         do_field_int.  Change type of "value".
 284         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 285         do_field_int.  Change type of "value".
 286         * tracepoint.c (trace_status_mi, tfind_1)
 287         (print_one_static_tracepoint_marker): Update.
 288         * thread.c (print_thread_info_1, print_selected_thread_frame):
 289         Update.
 290         * stack.c (print_frame, print_frame_info): Update.
 291         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 292         Update.
 293         * source.c (print_source_lines_base): Update.
 294         * skip.c (info_skip_command): Update.
 295         * record-btrace.c (btrace_ui_out_decode_error)
 296         (btrace_call_history_src_line): Update.
 297         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 298         Update.
 299         * progspace.c (print_program_space): Update.
 300         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 301         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 302         do_field_int.  Change type of "value".
 303         * mi/mi-out.c (mi_ui_out::do_table_begin)
 304         (mi_ui_out::do_table_header): Update.
 305         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 306         type of "value".
 307         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 308         (mi_cmd_data_list_changed_registers, output_register)
 309         (mi_cmd_data_read_memory, mi_load_progress)
 310         (mi_cmd_trace_frame_collected): Update.
 311         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 312         Update.
 313         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 314         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 315         (mi_cmd_var_list_children, varobj_update_one): Update.
 316         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 317         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 318         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 319         * inferior.c (print_inferior): Update.
 320         * gdb_bfd.c (print_one_bfd): Update.
 321         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 322         Update.
 323         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 324         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 325         do_field_int.  Change type of "value".
 326         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 327         do_field_int.  Change type of "value".
 328         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 329         (print_one_breakpoint_location, print_it_catch_fork)
 330         (print_one_catch_fork, print_it_catch_vfork)
 331         (print_one_catch_vfork, print_it_catch_solib)
 332         (print_it_catch_exec, print_it_ranged_breakpoint)
 333         (print_mention_watchpoint, print_mention_masked_watchpoint)
 334         (bkpt_print_it, update_static_tracepoint): Update.
 335         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 336         * break-catch-syscall.c (print_it_catch_syscall): Update.
 337         * ada-tasks.c (print_ada_task_info): Update.
 338         * ada-lang.c (print_it_exception, print_mention_exception):
 339         Update.
 340
 341 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 342
 343         PR breakpoints/24541
 344         * gdbarch.c: Regenerate.
 345         * gdbarch.h: Regenerate.
 346         * gdbarch.sh: Adjust return type and parameter types for
 347         'stap_adjust_register'.
 348         (i386_stap_adjust_register): Adjust signature and return new
 349         register name.
 350         * stap-probe.c (stap_parse_register_operand): Adjust use of
 351         'gdbarch_stap_adjust_register'.
 352
 353 2019-07-17  Tom Tromey  <tromey@adacore.com>
 354
 355         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 356         declare VEC.
 357         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 358         std::vector.
 359         (struct s390_process_info): Add initializers.
 360         (s390_add_process): Use new.
 361         (s390_linux_nat_target::low_forget_process): Use delete.
 362         (s390_linux_nat_target::low_new_fork)
 363         (s390_linux_nat_target::stopped_by_watchpoint)
 364         (s390_linux_nat_target::low_prepare_to_resume)
 365         (s390_linux_nat_target::insert_watchpoint)
 366         (s390_linux_nat_target::insert_hw_breakpoint)
 367         (s390_linux_nat_target::remove_watchpoint)
 368         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 369
 370 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 371
 372         * aarch64-fbsd-nat.c: Include regcache.h.
 373         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 374         argument.
 375         (aarch64_fbsd_nat_target::fetch_registers)
 376         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 377         variable.
 378         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 379
 380 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 381
 382         * fbsd-nat.c: Include gdbarch.h.
 383
 384 2019-07-15  Tom Tromey  <tromey@adacore.com>
 385
 386         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 387
 388 2019-07-15  Tom Tromey  <tromey@adacore.com>
 389
 390         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 391         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 392         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 393         * cli-out.c (cli_ui_out::do_field_int): New method.
 394         * ui-out.c (ui_out::field_unsigned): New method.
 395         * symfile.c (generic_load): Use field_unsigned.
 396         (print_transfer_performance): Likewise.
 397         * record-btrace.c (ui_out_field_uint): Remove.
 398         (btrace_call_history_insn_range, btrace_call_history): Use
 399         field_unsigned.
 400         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 401         field_unsigned.
 402         * ui-out.h (class ui_out) <field_unsigned>: New method.
 403         <do_field_unsigned>: Likewise.
 404
 405 2019-07-15  Tom Tromey  <tromey@adacore.com>
 406
 407         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 408         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 409         * target.c (flash_erase_command): Use field_string.
 410         * infrun.c (print_signal_received_reason): Use field_string.
 411         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 412         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 413         field_string.
 414         * ada-tasks.c (print_ada_task_info): Use field_string.
 415
 416 2019-07-15  Tom Tromey  <tromey@adacore.com>
 417
 418         * target.c (flash_erase_command): Use field_core_addr.
 419         * symfile.c (generic_load): Use field_core_addr.
 420         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 421         Use field_core_addr.
 422         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 423         field_core_addr.
 424
 425 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 426
 427         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 428         value if its desired type is smaller than a CORE_ADDR and signed.
 429
 430 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 431
 432         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 433         of changes to field names, and use new is_reference field to
 434         decide if a property is a reference or not.
 435         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 436         field.
 437         (struct dwarf2_property_baton): Update header comment, rename
 438         'referenced_type' to 'property_type' and update comments.
 439         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 440         default property type, store in property baton, update to take
 441         accound of renamed field.
 442         (read_func_scope): Update call to attr_to_dynamic_prop.
 443         (read_array_type): Likewise.
 444         (dwarf2_per_cu_addr_sized_int_type): New function.
 445         (read_subrange_index_type): Move type finding code to
 446         dwarf2_per_cu_addr_sized_int_type.
 447         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 448         (dwarf2_per_cu_addr_type): New function.
 449         (set_die_type): Update calls to attr_to_dynamic_prop.
 450
 451 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * dwarf2read.c (read_subrange_index_type): New function.
 454         (read_subrange_type): Move code into new function and call it.
 455         * gdbtypes.c (create_range_type): Add some asserts.
 456
 457 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 460         update return statements.
 461         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 462         declaration, and update comment to match.
 463         * gdbtypes.c (resolve_dynamic_array): Update call to
 464         dwarf2_evaluate_property to match new return type.
 465
 466 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 467
 468         * valarith.c (value_subscripted_rvalue): Change lowerbound
 469         parameter type from int to LONGEST.
 470         * value.h (value_subscripted_rvalue): Likewise in declaration.
 471
 472 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * cli/cli-utils.c (info_print_command_completer): New function.
 475         * cli/cli-utils.h: Add 'completer.h' include, and forward
 476         declaration for 'struct cmd_list_element'.
 477         (info_print_command_completer): Declare.
 478         * stack.c (_initialize_stack): Add completer for 'info locals' and
 479         'info args'.
 480         * symtab.c (_initialize_symtab): Add completer for 'info
 481         variables' and 'info functions'.
 482         * NEWS: Mention completion for additional info commands.
 483
 484 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * cli/cli-utils.c (extract_info_print_args): Delete.
 487         (extract_arg_maybe_quoted): Delete.
 488         (info_print_options_defs): New variable.
 489         (make_info_print_options_def_group): New function.
 490         (extract_info_print_options): Define new function.
 491         * cli/cli-utils.h (extract_info_print_args): Delete.
 492         (struct info_print_options): New structure.
 493         (extract_info_print_options): Declare new function.
 494         * stack.c (info_locals_command): Update to use new
 495         extract_info_print_options, also add a header comment.
 496         (info_args_command): Likewise.
 497         * symtab.c (info_variables_command): Likewise.
 498         (info_functions_command): Likewise.
 499
 500 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 503         to extract string arguments.
 504         * common/common-utils.c (extract_string_maybe_quoted): New function.
 505         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 506
 507 2019-07-11  Tom Tromey  <tromey@adacore.com>
 508
 509         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 510         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 511         * top.h (gdbinit): Don't declare.
 512         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 513         into...
 514         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 515         * top.c (gdb_init): Don't call init_cli_cmds.
 516         (gdbinit): Remove.
 517         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 518
 519 2019-07-11  Tom Tromey  <tromey@adacore.com>
 520
 521         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 522         after it has been moved.
 523
 524 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 525
 526         * valops.c (value_must_coerce_to_target): Change return type to
 527         bool.
 528         * value.h (value_must_coerce_to_target): Likewise.
 529
 530 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 531
 532         * breakpoint.c (is_hardware_watchpoint): Remove
 533         forward-declaration.
 534         (is_masked_watchpoint): Change return type to bool.
 535         (is_tracepoint): Likewise.
 536         (is_breakpoint): Likewise.
 537         (is_hardware_watchpoint): Likewise.
 538         (is_watchpoint): Likewise.
 539         (is_no_memory_software_watchpoint): Likewise.
 540         (is_catchpoint): Likewise.
 541         (breakpoint_1): Make FILTER parameter's return type bool.
 542         is_masked_watchpoint): Change return type to bool.
 543         (save_breakpoints): Make FILTER parameter's return type bool.
 544         * breakpoint.h (is_breakpoint): Change return type to bool.
 545         (is_watchpoint): Likewise.
 546         (is_catchpoint): Likewise.
 547         (is_tracepoint): Likewise.
 548
 549 2019-07-10  Tom Tromey  <tom@tromey.com>
 550
 551         * defs.h: Don't include gdbarch.h.
 552         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 553         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 554         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 555         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 556         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 557         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 558         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 559         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 560         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 561         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 562         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 563         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 564         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 565         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 566         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 567         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 568         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 569         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 570         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 571         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 572         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 573         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 574         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 575         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 576         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 577         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 578         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 579
 580 2019-07-10  Tom Tromey  <tromey@adacore.com>
 581
 582         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 583         * breakpoint.c (init_ada_exception_breakpoint): Register as
 584         bp_catchpoint.
 585         (print_one_breakpoint_location, print_one_breakpoint): Use
 586         is_ada_exception_catchpoint.
 587         * ada-lang.c (class ada_catchpoint_location): Pass
 588         bp_loc_software_breakpoint to bp_location constructor.
 589         (is_ada_exception_catchpoint): New function.
 590
 591 2019-07-10  Tom Tromey  <tromey@adacore.com>
 592
 593         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 594         VEC.
 595         (struct arm_exidx_entry): New method operator<.
 596         (struct arm_exidx_data) <section_maps>: Change type.
 597         (arm_exidx_data_free): Remove.
 598         (arm_exidx_data_key): Change type.  Move lower.
 599         (arm_exidx_new_objfile): Update.
 600         (arm_compare_exidx_entries): Remove.
 601         (arm_find_exidx_entry, _initialize_arm_tdep)
 602
 603 2019-07-10  Tom Tromey  <tromey@adacore.com>
 604
 605         * solib-spu.c (ocl_program_data_key): Change type.
 606         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 607         Update.
 608
 609 2019-07-10  Tom Tromey  <tromey@adacore.com>
 610
 611         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 612         (struct solib_aix_inferior_data) <library_list>: Change type.
 613         (solib_aix_inferior_data_handle): Change type.
 614         (get_solib_aix_inferior_data): Update.
 615         (solib_aix_free_library_list): Remove.
 616         (library_list_start_library): Update.
 617         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 618         return type.
 619         (solib_aix_get_library_list)
 620         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 621         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 622
 623 2019-07-10  Tom Tromey  <tromey@adacore.com>
 624
 625         * solib-dsbt.c (struct dsbt_info): Add initializers.
 626         (solib_dsbt_pspace_data): Change type.
 627         (dsbt_pspace_data_cleanup): Remove.
 628         (get_dsbt_info, _initialize_dsbt_solib): Update.
 629
 630 2019-07-10  Tom Tromey  <tromey@adacore.com>
 631
 632         * spu-tdep.c (spu_overlay_data): Change type.
 633         (spu_get_overlay_table, spu_overlay_new_objfile)
 634         (_initialize_spu_tdep): Update.
 635
 636 2019-07-10  Tom Tromey  <tromey@adacore.com>
 637
 638         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 639         destructor.
 640         (dbx_objfile_data_key): Change type and declare later.
 641         (DBX_SYMFILE_INFO): Rewrite.
 642         * dbxread.c (dbx_objfile_data_key): Change type.
 643         (dbx_symfile_init): Update.
 644         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 645         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 646         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 647
 648 2019-07-10  Tom Tromey  <tromey@adacore.com>
 649
 650         * jit.c (jit_program_space_key): Change type.  Move lower.
 651         (get_jit_program_space_data): Update.
 652         (jit_program_space_data_cleanup): Remove.
 653         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 654         Update.
 655         (struct jit_program_space_data): Add initializers.
 656
 657 2019-07-10  Tom Tromey  <tromey@adacore.com>
 658
 659         * solib-darwin.c (struct darwin_info): Add initializers.
 660         (solib_darwin_pspace_data): Change type.
 661         (darwin_pspace_data_cleanup): Remove.
 662         (get_darwin_info, _initialize_darwin_solib): Update.
 663
 664 2019-07-10  Tom Tromey  <tromey@adacore.com>
 665
 666         * remote-sim.c (struct sim_inferior_data): Add initializers,
 667         constructor, and destructor.
 668         (sim_inferior_data_key): Change type.  Move lower.
 669         (check_for_duplicate_sim_descriptor): Update.
 670         (get_sim_inferior_data): Use new.  Update.
 671         (~sim_inferior_data_cleanup): Rename from
 672         sim_inferior_data_cleanup.  Simplify.
 673         (gdbsim_close_inferior, simulator_command)
 674         (sim_command_completer, _initialize_remote_sim): Update.
 675         (next_pid, INITIAL_PID): Move earlier.
 676
 677 2019-07-10  Tom Tromey  <tromey@adacore.com>
 678
 679         * python/python-internal.h (create_thread_object): Return
 680         gdbpy_ref.
 681         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 682         * python/py-inferior.c (struct threadlist_entry): Add
 683         constructor.
 684         <thread_obj>: Now a gdbpy_ref.
 685         (thread_to_thread_object): Update.
 686         (add_thread_object): Use new.
 687         (delete_thread_object): Use delete.
 688         (infpy_threads): Update.
 689         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 690         GIL.
 691
 692 2019-07-10  Tom Tromey  <tromey@adacore.com>
 693
 694         * valops.c (value_cast): Specialize error message for Ada.
 695
 696 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 697
 698         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 699
 700 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 701
 702         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 703         bpstat_should_step): Return bool, adjust comments.
 704         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 705         bpstat_should_step): Likewise.
 706
 707 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 708
 709         * features/Makefile: Use feature target descriptions for Arm.
 710         * features/arm/arm-core.c: Generate new file.
 711         * features/arm/arm-fpa.c: Likewise.
 712         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 713         * features/arm/arm-m-profile.c: Likewise.
 714         * features/arm/arm-vfpv2.c: Likewise.
 715         * features/arm/arm-vfpv3.c: Likewise.
 716         * features/arm/xscale-iwmmxt.c: Likewise.
 717         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 718
 719 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 720
 721         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 722         ptrace earlier.
 723
 724 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 725
 726         * features/aarch64-pauth.c: Regenerate.
 727
 728 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 729
 730         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 731         bool.
 732         (bpstat_what): Use false instead of 0.
 733
 734 2019-07-09  Pedro Alves  <palves@redhat.com>
 735
 736         * break-catch-throw.c (is_exception_catchpoint): New.
 737         * breakpoint.c (print_one_breakpoint_location): New parameter
 738         'raw_loc'.  Handle it.  Use
 739         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 740         looking at the breakpoint's type.
 741         (print_one_breakpoint): If handling "maint info breakpoints", also
 742         print locations of exception catchpoints.
 743         * breakpoint.h (is_exception_catchpoint): Declare.
 744
 745 2019-07-09  Pedro Alves  <palves@redhat.com>
 746
 747         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 748         "addr" field.
 749         (allocate_location_exception_catchpoint): New.
 750         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 751         (initialize_throw_catchpoint_ops): Install
 752         allocate_location_exception_catchpoint as allocate_location
 753         method.
 754         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 755         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 756         bp_loc_other.
 757         (breakpoint_address_is_meaningful): Delete.
 758         (bl_address_is_meaningful): New.
 759         (breakpoint_locations_match): Adjust comment.
 760         (bp_location_from_bp_type): New, factored out of...
 761         (bp_location::bp_location(breakpoint *)): ... this.
 762         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 763         factored out of...
 764         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 765         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 766         breakpoint_address_is_meaningful.
 767         (bp_locations_compare): Adjust comment.
 768         (update_global_location_list): Use bl_address_is_meaningful
 769         instead of breakpoint_address_is_meaningful.
 770         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 771         explicit.
 772         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 773         * python/py-breakpoint.c (bppy_get_location): No longer check
 774         whether location is null.
 775
 776 2019-07-09  Pedro Alves  <palves@redhat.com>
 777
 778         PR c++/15468
 779         * breakpoint.c (print_one_breakpoint_location): Remove
 780         single-location assert.
 781
 782 2019-07-09  Tom Tromey  <tom@tromey.com>
 783
 784         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 785         * configure: Rebuild.
 786         * configure.ac: Change common to gdbsupport.
 787         * gdbsupport: Rename from common.
 788         * acinclude.m4: Change common to gdbsupport.
 789         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 790         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 791         gdbsupport.
 792         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 793         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 794         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 795         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 796         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 797         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 798         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 799         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 800         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 801         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 802         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 803         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 804         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 805         coff-pe-read.c, command.h, compile/compile-c-support.c,
 806         compile/compile-c.h, compile/compile-cplus-symbols.c,
 807         compile/compile-cplus-types.c, compile/compile-cplus.h,
 808         compile/compile-loc2c.c, compile/compile.c, completer.c,
 809         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 810         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 811         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 812         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 813         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 814         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 815         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 816         features/aarch64-core.c, features/aarch64-fpu.c,
 817         features/aarch64-pauth.c, features/aarch64-sve.c,
 818         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 819         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 820         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 821         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 822         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 823         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 824         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 825         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 826         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 827         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 828         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 829         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 830         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 831         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 832         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 833         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 834         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 835         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 836         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 837         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 838         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 839         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 840         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 841         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 842         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 843         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 844         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 845         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 846         minsyms.c, mips-linux-tdep.c, namespace.h,
 847         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 848         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 849         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 850         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 851         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 852         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 853         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 854         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 855         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 856         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 857         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 858         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 859         procfs.c, producer.c, progspace.h, psymtab.h,
 860         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 861         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 862         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 863         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 864         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 865         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 866         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 867         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 868         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 869         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 870         target-memory.c, target.c, target.h, target/waitstatus.c,
 871         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 872         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 873         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 874         unittests/array-view-selftests.c,
 875         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 876         unittests/common-utils-selftests.c,
 877         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 878         unittests/format_pieces-selftests.c,
 879         unittests/function-view-selftests.c,
 880         unittests/lookup_name_info-selftests.c,
 881         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 882         unittests/mkdir-recursive-selftests.c,
 883         unittests/observable-selftests.c,
 884         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 885         unittests/parse-connection-spec-selftests.c,
 886         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 887         unittests/scoped_fd-selftests.c,
 888         unittests/scoped_mmap-selftests.c,
 889         unittests/scoped_restore-selftests.c,
 890         unittests/string_view-selftests.c, unittests/style-selftests.c,
 891         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 892         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 893         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 894         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 895         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 896         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 897
 898 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 901         bool value.
 902         (decode_digits_ordinary): Set explicit_line field in sal.
 903         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 904         symtab_and_line that was set on an explicit line number in
 905         assembler code.  Do always update the recorded symtab and line if
 906         we do skip the prologue.
 907
 908 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * breakpoint.c (set_breakpoint_location_function): Remove
 911         explicit_loc parameter.
 912         (momentary_breakpoint_from_master): Update call to
 913         set_breakpoint_location_function.
 914         (add_location_to_breakpoint): Likewise.
 915
 916 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 919         required features based on default bfd type when no specific bfd
 920         is present.
 921
 922 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 923
 924         * NEWS: Mention that GDB printf and eval commands can now print
 925         C-style and Ada-style convenience var strings without
 926         calling the inferior.
 927         * printcmd.c (printf_c_string): Locally print GDB internal var
 928         instead of transiting via the inferior.
 929         (printf_wide_c_string): Likewise.
 930
 931 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 932
 933         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 934
 935 2019-07-04  Tom Tromey  <tom@tromey.com>
 936
 937         PR tui/24724:
 938         * tui/tui-winsource.c (tui_clear_source_content): Update.
 939         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 940         (tui_update_breakpoint_info): Update.
 941         (tui_set_exec_info_content): Update.
 942         * tui/tui-source.c (tui_set_source_content_nil): Update.
 943         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 944         has_break.
 945         * tui/tui-data.h (enum tui_bp_flag): New.
 946         (tui_bp_flags): New enum flags type.
 947         (struct tui_source_element) <break_mode>: Change type.  Rename
 948         from has_break.
 949         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 950         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 951         constants.
 952         * tui/tui-winsource.h: Fix comment.
 953
 954 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 955
 956         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 957         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 958         (store_fpregs_to_thread)
 959         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 960         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 961         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 962         (IWMMXT_REGS_SIZE): Add define.
 963         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 964         (fetch_vfp_regs, store_vfp_regs)
 965         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 966         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 967
 968 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 969
 970         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 971         defines.
 972         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 973         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 974         (ARM_INT_REGISTER_SIZE): ...to this.
 975         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 976         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 977         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 978         (arm_linux_collect_gregset, supply_nwfpe_register)
 979         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 980         defines.
 981         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 982         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 983         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 984         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 985         (arm_return_in_memory, arm_store_return_value)
 986         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 987         (arm_record_ld_st_multiple): Likewise.
 988         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 989         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 990
 991 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 992
 993         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 994         AARCH64_DISPLACED_MODIFIED_INSNS.
 995         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 996         (aarch64_displaced_step_copy_insn): Likewise.
 997         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 998         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 999         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1000         ARM_DISPLACED_MODIFIED_INSNS.
1001         * arm-tdep.c (arm_gdbarch_init): Likewise.
1002         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1003         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1004         (struct arm_displaced_step_closure): Use
1005         ARM_DISPLACED_MODIFIED_INSNS.
1006
1007 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1008
1009         * features/Makefile: Remove unused xml files.
1010         * features/aarch64.xml: Remove.
1011         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1012         * features/i386/amd64-avx-avx512.xml: Remove.
1013         * features/i386/amd64-avx-linux.xml: Remove.
1014         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1015         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1016         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1017         * features/i386/amd64-avx-mpx.xml: Remove.
1018         * features/i386/amd64-avx.xml: Remove.
1019         * features/i386/amd64-linux.xml: Remove.
1020         * features/i386/amd64-mpx-linux.xml: Remove.
1021         * features/i386/amd64-mpx.xml: Remove.
1022         * features/i386/amd64.xml: Remove.
1023         * features/i386/i386-avx-avx512-linux.xml: Remove.
1024         * features/i386/i386-avx-avx512.xml: Remove.
1025         * features/i386/i386-avx-linux.xml: Remove.
1026         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1027         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1028         * features/i386/i386-avx-mpx-linux.xml: Remove.
1029         * features/i386/i386-avx-mpx.xml: Remove.
1030         * features/i386/i386-avx.xml: Remove.
1031         * features/i386/i386-linux.xml: Remove.
1032         * features/i386/i386-mmx-linux.xml: Remove.
1033         * features/i386/i386-mmx.xml: Remove.
1034         * features/i386/i386-mpx-linux.xml: Remove.
1035         * features/i386/i386-mpx.xml: Remove.
1036         * features/i386/i386.xml: Remove.
1037         * features/i386/x32-avx-avx512-linux.xml: Remove.
1038         * features/i386/x32-avx-linux.xml: Remove.
1039         * features/i386/x32-linux.xml: Remove.
1040
1041 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1042
1043         * regformats/aarch64.dat: Remove.
1044         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1045         * regformats/i386/amd64-avx-linux.dat: Remove.
1046         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1047         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1048         * regformats/i386/amd64-linux.dat: Remove.
1049         * regformats/i386/amd64-mpx-linux.dat: Remove.
1050         * regformats/i386/amd64.dat: Remove.
1051         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1052         * regformats/i386/i386-avx-linux.dat: Remove.
1053         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1054         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1055         * regformats/i386/i386-linux.dat: Remove.
1056         * regformats/i386/i386-mmx-linux.dat: Remove.
1057         * regformats/i386/i386-mpx-linux.dat: Remove.
1058         * regformats/i386/i386.dat: Remove.
1059         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1060         * regformats/i386/x32-avx-linux.dat: Remove.
1061         * regformats/i386/x32-linux.dat: Remove.
1062
1063 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1064
1065         * aarch64-tdep.c: Remove xml self tests.
1066         * amd64-linux-tdep.c: Likewise.
1067         * amd64-tdep.c: Likewise.
1068         * i386-linux-tdep.c: Likewise.
1069         * i386-tdep.c: Likewise.
1070
1071 2019-07-03  Pedro Alves  <palves@redhat.com>
1072
1073         PR cli/24732
1074         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1075         (pipe_cmd_option_defs): New.
1076         (make_pipe_cmd_options_def_group): New.
1077         (pipe_command): Use gdb::option::process_options.
1078         (pipe_command_completer): New function.
1079         (_initialize_cli_cmds): Install completer for "pipe" command.
1080
1081 2019-07-03  Pedro Alves  <palves@redhat.com>
1082
1083         * cli/cli-option.c (union option_value) <string>: New field.
1084         (struct option_def_and_value): Add ctor, move ctor, dtor and
1085         use DISABLE_COPY_AND_ASSIGN.
1086         (option_def_and_value::clear_value): New.
1087         (parse_option, save_option_value_in_ctx, get_val_type_str)
1088         (add_setshow_cmds_for_options): Handle var_string.
1089         * cli-option.h (union option_def::var_address) <string>: New
1090         field.
1091         (struct string_option_def): New.
1092         * maint-test-options.c (struct test_options_opts): Add default
1093         ctor and use DISABLE_COPY_AND_ASSIGN.
1094         <string_opt>: New field.
1095         (test_options_opts::~test_options_opts): New.
1096         (test_options_opts::dump): Also dump "-string".
1097         (test_options_option_defs): Install "string.
1098
1099 2019-07-03  Pedro Alves  <palves@redhat.com>
1100
1101         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1102         option_value with a null enumeration.
1103         (complete_options): Save the option values in the context.
1104         (save_option_value_in_ctx): New, factored out from ...
1105         (process_options): ... here.
1106         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1107         of the function.
1108         * maint-test-options.c (test_options_opts::dump): New, factored
1109         out from ...
1110         (maintenance_test_options_command_mode): ... here.
1111         (maintenance_test_options_command_completion_result): Delete.
1112         (maintenance_test_options_command_completion_text): Update
1113         comment.
1114         (maintenance_show_test_options_completion_result): Change
1115         prototype.  Just print
1116         maintenance_test_options_command_completion_text.
1117         (save_completion_result): New.
1118         (maintenance_test_options_completer_mode): Pass options context to
1119         complete_options, and then save a dump.
1120         (_initialize_maint_test_options): Use add_cmd to install "maint
1121         show test-options-completion-result".
1122
1123 2019-07-03  Pedro Alves  <palves@redhat.com>
1124
1125         * NEWS (New commands): Mention "with" and "maint with".
1126         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1127         (with_command, with_command_completer): New.
1128         (pipe_command): Adjust to new repeat_previous
1129         interface.
1130         (_initialize_cli_cmds): Install the "with" command and its "w"
1131         alias.
1132         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1133         declarations.
1134         * cli/cli-setshow.c (parse_cli_var_uinteger)
1135         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1136         argument strings for all var_types.
1137         (get_setshow_command_value_string): New, factored out from ...
1138         (do_show_command): ... this.
1139         * cli/cli-setshow.h: Include <string>.
1140         (get_setshow_command_value_string): Declare.
1141         * command.h (repeat_previous): Now returns const char *.  Adjust
1142         comment.
1143         * maint.c: Include "cli/cli-cmds.h".
1144         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1145         (_initialize_maint_cmds): Register the "maintenance with" command.
1146         * top.c (repeat_previous): Move bits from pipe_command here:
1147         Return the saved command line, if any; error out if there's no
1148         command to relaunch.
1149
1150 2019-07-03  Pedro Alves  <palves@redhat.com>
1151
1152         * NEWS (New commands): Mention "maint set/show test-settings"
1153         instead of "maint test-settings".
1154         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1155         (maintenance_test_settings_set_list): Rename to ...
1156         (maintenance_set_test_settings_list): ... this.
1157         (maintenance_test_settings_show_list): Rename to  ...
1158         (maintenance_show_test_settings_list): ... this.
1159         (maintenance_test_settings_cmd): Delete.
1160         (maintenance_test_settings_set_cmd): ...
1161         (maintenance_set_test_settings_cmd): ... this.
1162         (maintenance_test_settings_show_cmd): ...
1163         (maintenance_show_test_settings_cmd): ... this.
1164         (maintenance_test_settings_show_value_cmd):
1165         (maintenance_show_test_settings_value_cmd): ... this.
1166         (_initialize_maint_test_settings): No longer install the "maint
1167         test-settings" prefix command.  Rename "maint test-settings set"
1168         to "maint set test-settings", and "maint test-settings show" to
1169         "maint show test-settings".  Adjust all subcommands.
1170
1171 2019-07-03  Pedro Alves  <palves@redhat.com>
1172
1173         * maint-test-settings.c: Fix file's intro comment.  Replace all
1174         references to "test-options" with references to "test-settings",
1175         in comments.
1176
1177 2019-07-03  Pedro Alves  <palves@redhat.com>
1178
1179         * maint-test-settings.c (maintenance_test_settings_xxx)
1180         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1181         New.
1182         (maintenance_test_settings_enums): Use them.
1183         (maintenance_test_settings_enum): Default to
1184         maintenance_test_settings_xxx.
1185         (_initialize_maint_test_settings): Initialize
1186         MAINTENANCE_TEST_SETTINGS_FILENAME.
1187
1188 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1189
1190         * breakpoint.h (remove_breakpoints_inf): Change return type to
1191         void, move function documentation here.
1192         * breakpoint.c (remove_breakpoints_inf): Change return type to
1193         void, move function documentation to header.
1194
1195 2019-07-02  Pedro Alves  <palves@redhat.com>
1196
1197         * NEWS (Completion improvements): Mention "info threads".
1198         * thread.c (struct info_threads_opts, info_threads_option_defs)
1199         (make_info_threads_options_def_group): New.
1200         (info_threads_command): Use gdb::option::process_options.
1201         (info_threads_command_completer): New.
1202         (_initialize_thread): Use gdb::option::build_help to build the
1203         help text for "info threads".
1204
1205 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1206
1207         * defs.h (generic_load): Move from here...
1208         * symfile.h (generic_load): ... to here.  Rename name parameter
1209         to args.
1210         * symfile.c (generic_load): Add comment.
1211
1212 2019-07-01  Tom Tromey  <tromey@adacore.com>
1213
1214         * dwarf2read.c
1215         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1216         declaration of without_params.  Fix formatting.
1217
1218 2019-07-01  Tom Tromey  <tromey@adacore.com>
1219
1220         * ada-exp.y (find_primitive_type): Update.
1221         * ada-lang.h (ada_lookup_symbol): Update.
1222         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1223         parameter.
1224         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1225
1226 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1227
1228         PR breakpoints/24541
1229         * gdbarch.c: Regenerate.
1230         * gdbarch.h: Regenerate.
1231         * gdbarch.sh: Add 'stap_adjust_register'.
1232         * i386-tdep.c: Include '<unordered_set>'.
1233         (i386_stap_adjust_register): New function.
1234         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1235         * stap-probe.c (stap_parse_register_operand): Call
1236         'gdbarch_stap_adjust_register'.
1237
1238 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1239
1240         PR python/24742
1241         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1242         * python/python.c (do_start_initialization): Use 'xmalloc'
1243         instead of 'PyMem_Malloc'.
1244
1245 2019-06-28  Tom Tromey  <tromey@adacore.com>
1246
1247         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1248         for Ada.
1249
1250 2019-06-27  Tom Tromey  <tromey@adacore.com>
1251
1252         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1253         objfile_key.
1254         (arm_find_mapping_symbol, arm_record_special_symbol)
1255         (_initialize_arm_tdep): Update.
1256         (arm_objfile_data_free): Remove.
1257
1258 2019-06-27  Tom Tromey  <tromey@adacore.com>
1259
1260         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1261         to cp_print_static_field.
1262
1263 2019-06-26  Tom Tromey  <tromey@adacore.com>
1264
1265         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1266         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1267         declare.
1268
1269 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1270
1271         * features/aarch64-core.c (create_feature_aarch64_core):
1272         Regenerate.
1273         * features/aarch64-core.xml: Add cpsr flags.
1274
1275 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1276
1277         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1278         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1279
1280 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1281
1282         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1283         field.
1284         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1285         use.
1286         (arm_record_special_symbol): Don't insert new symbol in sorted
1287         position, push it at the end.
1288
1289 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1290
1291         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1292         (arm_mapping_symbol_s): Remove.
1293         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1294         (arm_mapping_symbol_vec): New typedef.
1295         (struct arm_per_objfile): Add constructor.
1296         <section_maps>: Change type to
1297         std::unique_ptr<arm_mapping_symbol_vec[]>.
1298         (arm_compare_mapping_symbols): Remove.
1299         (arm_find_mapping_symbol): Adjust to section_maps type change.
1300         (arm_objfile_data_free): Call delete on arm_per_objfile.
1301         (arm_record_special_symbol): Adjust to section_maps type change.
1302         Allocate arm_per_objfile with new.
1303
1304 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1305
1306         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1307         with the command prefix.
1308
1309 2019-06-25  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1312         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1317         type.
1318         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1319         protected.
1320
1321 2019-06-25  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-winsource.c
1324         (tui_source_window_base::set_is_exec_point_at): Add check against
1325         LOA_ADDRESS.
1326
1327 2019-06-25  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-source.c (tui_set_source_content): Don't check before
1330         xfree.
1331         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1332
1333 2019-06-25  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-winsource.h (tui_update_source_window_as_is)
1336         (tui_alloc_source_buffer, tui_line_is_displayed)
1337         (tui_addr_is_displayed): Change type of win_info.
1338         * tui/tui-winsource.c (tui_update_source_window_as_is)
1339         (tui_clear_source_content, tui_show_source_line)
1340         (tui_show_source_content, tui_source_window_base::refill)
1341         (tui_source_window_base::set_is_exec_point_at)
1342         (tui_source_window_base::set_is_exec_point_at)
1343         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1344         (tui_alloc_source_buffer, tui_line_is_displayed)
1345         (tui_addr_is_displayed): Change type of win_info.  Update.
1346         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1347         (tui_source_window_base::do_make_visible_with_new_height):
1348         Update.
1349         * tui/tui-source.c (tui_set_source_content)
1350         (tui_set_source_content_nil)
1351         (tui_source_window::do_scroll_vertical): Update.
1352         * tui/tui-layout.c (show_layout): Update.
1353         * tui/tui-disasm.c (tui_set_disassem_content)
1354         (tui_disasm_window::do_scroll_vertical): Update.
1355         * tui/tui-data.h (tui_win_content): Remove.
1356         (struct tui_gen_win_info) <content, content_size>: Remove.
1357         (struct tui_source_element): Add initializers and destructor.
1358         (union tui_which_element, struct tui_win_element): Remove.
1359         (struct tui_source_window_base) <content>: New field.
1360         (struct tui_data_window): Remove destructor.
1361         (tui_alloc_content, tui_free_win_content)
1362         (tui_free_all_source_wins_content): Don't declare.
1363         * tui/tui-data.c (tui_initialize_static_data): Update.
1364         (init_content_element, tui_alloc_content): Remove.
1365         (~tui_gen_win_info): Update.
1366         (~tui_data_window, tui_free_all_source_wins_content)
1367         (tui_free_win_content, free_content, free_content_elements):
1368         Remove.
1369
1370 2019-06-25  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-winsource.h (tui_clear_source_content)
1373         (tui_erase_source_content, tui_show_source_content): Change type
1374         of win_info.
1375         * tui/tui-winsource.c (tui_clear_source_content)
1376         (tui_erase_source_content, tui_show_source_content): Change type
1377         of win_info.
1378         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1379         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1380         win_info.
1381         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1382         win_info.
1383         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-winsource.c (tui_clear_source_content)
1388         (tui_source_window_base::set_is_exec_point_at): Update.
1389         * tui/tui-source.c (tui_set_source_content_nil): Update.
1390         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1391         a bool.
1392         * tui/tui-data.c (init_content_element): Update.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1397         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1398         * tui/tui-layout.c (init_and_make_win): Update.
1399         * tui/tui.h (enum tui_win_type): Update.
1400         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1401         tui_win_is_auxillary.
1402         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1403         tui_win_is_auxillary.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1408         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1409         (tui_delete_data_content_windows, tui_display_all_data)
1410         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1411         Update.
1412         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1413         * tui/tui-regs.c (tui_last_regs_line_no)
1414         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1415         (tui_show_registers): Update.
1416         (tui_show_register_group): Return void.  Update.
1417         (tui_display_registers_from, tui_display_reg_element_at_line)
1418         (tui_display_registers_from_line, tui_check_register_values):
1419         Update.
1420         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1421         member.
1422         (struct tui_data_window) <regs_content>: Now a std::vector.
1423         <regs_content_count>: Remove.
1424         (tui_add_content_elements, tui_free_data_content): Don't declare.
1425         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1426         (init_content_element): Remove DATA_WIN case.  Add assert.
1427         (tui_add_content_elements): Remove.
1428         (tui_data_window): Update.
1429         (tui_free_data_content): Remove.
1430         (free_content_elements): Remove DATA_WIN case.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-data.c (tui_data_item_window): Update.
1435         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1436         * tui/tui-windata.c (tui_display_all_data)
1437         (tui_display_data_from_line): Update.
1438         (tui_check_data_values): Remove.
1439         * tui/tui-regs.c (tui_show_register_group)
1440         (tui_display_reg_element_at_line): Update.
1441         * tui/tui-hooks.c (tui_register_changed)
1442         (tui_refresh_frame_and_register_information): Call
1443         tui_check_register_values.
1444         * tui/tui-data.h (struct tui_data_window) <data_content,
1445         data_content_count, data_type>: Remove.
1446         (enum tui_data_type): Remove.
1447
1448         * tui/tui-data.c (tui_data_window::clear_detail)
1449         (~tui_data_window): Update.
1450
1451 2019-06-25  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1454         declare.
1455         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1456         Rename from tui_first_data_item_displayed.  Update.
1457         (tui_data_window::refresh_all)
1458         (tui_data_window::do_scroll_vertical): Update.
1459         * tui/tui-data.h (struct tui_data_window)
1460         <first_data_item_displayed>: Declare new method.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1465         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1466         contents...
1467         (tui_initialize_static_data): ...here.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1472         (tui_display_registers_from, tui_check_register_values): Update.
1473         (tui_display_register): Remove win_info parameter; update.
1474         (tui_get_register): Change type of parameters.
1475         * tui/tui-data.h (struct tui_data_element): Remove.
1476         (union tui_which_element) <data>: Remove.
1477         <data_window>: Change type.
1478         (struct tui_data_item_window): New.
1479         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1480         case.  Add assert.
1481         (~tui_data_item_window): New destructor.
1482         (free_content_elements): Remove DATA_ITEM_WIN case.
1483
1484 2019-06-25  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1487         Remove.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-data.h (struct tui_command_element): Remove.
1492         (union tui_which_element) <command>: Remove.
1493         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1494         assert.
1495         (free_content_elements): Remove CMD_WIN case.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-layout.c (tui_set_layout): Update.
1500         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1501         * tui/tui-data.c (layout_def): Update.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1506         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1507         (tui_source_window_base::set_new_height): Update.
1508         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1509         Update.
1510         (tui_set_locator_fullname, tui_set_locator_info)
1511         (tui_show_frame_info): Update.
1512         * tui/tui-source.c (tui_set_source_content)
1513         (tui_source_is_displayed): Update.
1514         * tui/tui-layout.c (show_source_disasm_command, show_data)
1515         (show_source_or_disasm_and_command): Update.
1516         * tui/tui-disasm.c (tui_set_disassem_content)
1517         (tui_get_begin_asm_address): Update.
1518         * tui/tui-data.h (struct tui_locator_element): Remove.
1519         (union tui_which_element) <locator>: Remove.
1520         (struct tui_locator_window): New.
1521         (tui_locator_win_info_ptr): Change return type.
1522         * tui/tui-data.c (_locator): Change type.
1523         (tui_locator_win_info_ptr): Change return type.
1524         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1525         (tui_alloc_content): Add assert.
1526
1527 2019-06-25  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-winsource.c
1530         (tui_exec_info_window::maybe_allocate_content): New method.
1531         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1532         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1533         (make_source_or_disasm_window): Add cast.
1534         * tui/tui-data.h (union tui_which_element) <simple_string>:
1535         Remove.
1536         (struct tui_source_info): New.
1537         (struct tui_source_window_base) <execution_info>: Change type.
1538         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1539         case, and add assert.
1540         (tui_alloc_content): Add assert.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1545         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1546         * tui/tui-data.c (tui_alloc_win_info): Remove.
1547
1548 2019-06-25  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1551         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1552         can_highlight.
1553
1554 2019-06-25  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1557         make_visible_with_new_height method.
1558         (tui_win_info::make_visible_with_new_height): New method.
1559         (tui_source_window_base::do_make_visible_with_new_height)
1560         (tui_data_window::do_make_visible_with_new_height)
1561         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1562         (make_visible_with_new_height): Remove.
1563         (tui_resize_all, tui_adjust_win_heights): Use
1564         make_visible_with_new_height method.
1565         * tui/tui-data.h (struct tui_win_info)
1566         <do_make_visible_with_new_height, make_visible_with_new_height>:
1567         New methods.
1568         (struct tui_source_window_base, struct tui_data_window)
1569         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1570         methods.
1571
1572 2019-06-25  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1575         method.
1576         (update_tab_width): Call update_tab_width method.
1577         * tui/tui-data.h (struct tui_win_info)
1578         (struct tui_source_window_base) <update_tab_width>: New methods.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1583         parameter.
1584         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1585         parameter.
1586         (tui_gen_win_info::make_visible): Update.
1587         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1588         parameter.
1589         * tui/tui-data.h (enum tui_box): New enum.
1590         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1595         init_and_make_win for EXEC_INFO_WIN.
1596         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1597         longer inline.
1598         (struct tui_win_info) <~tui_win_info>: Inline.
1599         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1600         Don't declare.
1601         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1602         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1603         Remove.
1604         (tui_initialize_static_data): Update.
1605         (~tui_gen_win_info): Handle more cleanup here.
1606         (~tui_source_window_base): Delete "execution_info".
1607         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1608
1609 2019-06-25  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-layout.c (make_command_window): Don't set
1612         can_highlight.
1613         (show_source_disasm_command): Call the reset method.
1614         (show_data): Don't set can_highlight.  Call the reset method.
1615         (tui_gen_win_info::reset): Rename from init_gen_win_info
1616         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1617         (show_source_or_disasm_and_command): Call the reset method.
1618         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1619         (struct tui_cmd_window): Set can_highlight.
1620
1621 2019-06-25  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1624         from make_visible.
1625         (tui_make_visible, tui_make_invisible): Rewrite.
1626         (tui_win_info::make_visible): Remove.
1627         (tui_source_window_base::make_visible): Update.
1628         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1629         method.  Moved from...
1630         (struct tui_win_info) <make_visible>: ...here.
1631
1632 2019-06-25  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-winsource.c
1635         (tui_source_window_base::do_scroll_horizontal): Remove direction
1636         parameter.
1637         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1638         direction parameter.
1639         * tui/tui-win.c (tui_win_info::forward_scroll)
1640         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1641         (tui_win_info::right_scroll): Update.
1642         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1643         direction parameter.
1644         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1645         direction parameter.
1646         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1647         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1648         Remove direction parameter.
1649         (struct tui_source_window_base, struct tui_source_window)
1650         (struct tui_disasm_window, struct tui_data_window)
1651         (struct tui_cmd_window): Update.
1652
1653 2019-06-25  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-winsource.h (tui_set_exec_info_content)
1656         (tui_show_exec_info_content, tui_erase_exec_info_content)
1657         (tui_clear_exec_info_content, tui_update_exec_info): Change
1658         argument to tui_source_window_base.
1659         * tui/tui-winsource.c (tui_set_exec_info_content)
1660         (tui_show_exec_info_content, tui_erase_exec_info_content)
1661         (tui_clear_exec_info_content, tui_update_exec_info): Change
1662         argument to tui_source_window_base.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1667         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1668
1669 2019-06-25  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1672         check.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1677         type to void.
1678         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1679         type to void.
1680         * tui/tui-source.c (tui_set_source_content): Update.
1681         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-win.c (window_name_completer, tui_set_focus)
1686         (tui_all_windows_info): Use name method.
1687         * tui/tui-data.h (struct tui_gen_win_info)
1688         (struct tui_source_window, struct tui_disasm_window)
1689         (struct tui_data_window, struct tui_cmd_window) <name>: New
1690         method.
1691         (tui_win_name): Don't declare.
1692         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1693         (tui_win_name): Remove.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-winsource.h (tui_update_source_window)
1698         (tui_update_source_window_as_is): Change parameter type.
1699         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1700         to be a tui_source_window_base.
1701         (tui_update_source_window_as_is): Likewise.
1702         * tui/tui-win.c (make_visible_with_new_height): Update.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-winsource.c (tui_erase_source_content)
1707         (tui_show_source_content, tui_show_exec_info_content)
1708         (tui_erase_exec_info_content): Use refresh_window method.
1709         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1710         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1711         from tui_refresh_win.
1712         (tui_data_window::refresh_window): New method.
1713         (tui_win_info::refresh, tui_source_window_base::refresh)
1714         (tui_refresh_all): Use refresh_window method.
1715         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1716         method.
1717         * tui/tui-regs.c (tui_display_register): Call refresh_window
1718         method.
1719         * tui/tui-layout.c (show_source_disasm_command)
1720         (show_source_or_disasm_and_command): Call refresh_window method.
1721         * tui/tui-data.h (struct tui_gen_win_info)
1722         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1723         New method.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui.c (tui_rl_other_window, tui_enable)
1728         (tui_is_window_visible, tui_get_command_dimension): Update.
1729         * tui/tui-winsource.c (tui_update_source_window_as_is)
1730         (tui_clear_source_content, tui_erase_source_content)
1731         (tui_show_source_line, tui_source_window_base::refill)
1732         (tui_source_window_base::do_scroll_horizontal)
1733         (tui_source_window_base::set_is_exec_point_at)
1734         (tui_update_breakpoint_info, tui_set_exec_info_content)
1735         (tui_alloc_source_buffer, tui_line_is_displayed)
1736         (tui_addr_is_displayed): Update.
1737         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1738         (tui_check_and_display_highlight_if_needed)
1739         (tui_win_info::make_visible, tui_win_info::refresh)
1740         (tui_refresh_all): Update.
1741         * tui/tui-windata.c (tui_first_data_item_displayed)
1742         (tui_delete_data_content_windows, tui_erase_data_content)
1743         (tui_display_all_data, tui_data_window::refresh_all)
1744         (tui_check_data_values): Update.
1745         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1746         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1747         (tui_win_info::backward_scroll, tui_refresh_all_win)
1748         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1749         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1750         (tui_source_window_base::set_new_height)
1751         (tui_data_window::set_new_height)
1752         (make_invisible_and_set_new_height)
1753         (make_visible_with_new_height, new_height_ok)
1754         (parse_scrolling_args): Update.
1755         * tui/tui-stack.c (tui_show_frame_info): Update.
1756         * tui/tui-source.c (tui_set_source_content)
1757         (tui_set_source_content_nil, tui_source_is_displayed)
1758         (tui_source_window::do_scroll_vertical): Update.
1759         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1760         (tui_display_registers_from, tui_display_reg_element_at_line)
1761         (tui_check_register_values, tui_reg_command): Update.
1762         * tui/tui-layout.c (tui_default_win_height)
1763         (show_source_disasm_command, show_data, init_and_make_win)
1764         (show_source_or_disasm_and_command): Update.
1765         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1766         (tui_redisplay_readline, tui_mld_flush)
1767         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1768         (tui_getc): Update.
1769         * tui/tui-disasm.c (tui_set_disassem_content)
1770         (tui_disasm_window::do_scroll_vertical): Update.
1771         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1772         Now virtual.
1773         (struct tui_win_info): Derive from tui_gen_win_info.
1774         <~tui_win_info>: Mark as override.
1775         <generic>: Remove member.
1776         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1777         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1778         (~tui_data_window, ~tui_win_info)
1779         (tui_free_all_source_wins_content): Update.
1780         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1781
1782 2019-06-25  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-layout.c (init_and_make_win): Use new.
1785         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1786         destructor, initializers.
1787         (tui_alloc_generic_win_info): Don't declare.
1788         * tui/tui-data.c (_locator): Add argument to constructor.
1789         (source_win, disasm_win): New globals.
1790         (exec_info): Remove.
1791         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1792         Update.
1793         (tui_alloc_generic_win_info): Remove.
1794         (init_content_element): Use new.
1795         (tui_win_info::tui_win_info): Update.
1796         (free_content_elements) <case DATA_WIN>: Use delete.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1801         * tui/tui-windata.c (tui_first_data_item_displayed)
1802         (tui_delete_data_content_windows): Update.
1803         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1804         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1805         (tui_display_registers_from, tui_check_register_values): Update.
1806         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1807         pointer.
1808         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1809         window.
1810         (tui_free_data_content): Update.
1811         (free_content_elements) <case DATA_WIN>: Free the window.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1816         Update.
1817         * tui/tui-layout.c (make_command_window)
1818         (show_source_disasm_command, show_data, init_and_make_win)
1819         (show_source_or_disasm_and_command): Update.
1820         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1821         method.
1822         <can_highight, is_highlighted>: Now bool.
1823         (tui_set_win_highlight): Don't declare.
1824         * tui/tui-data.c (tui_set_win_highlight): Remove.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-wingeneral.c (make_visible): Remove check of window
1829         type.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-win.c (tui_win_info::max_height)
1834         (tui_cmd_window::max_height): New methods.
1835         (new_height_ok): Call max_height.
1836         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1837         <max_height>: New method.
1838
1839 2019-06-25  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-win.c (tui_source_window_base::set_new_height)
1842         (tui_data_window::set_new_height): New methods.
1843         (make_invisible_and_set_new_height): Call set_new_height method.
1844         * tui/tui-data.h (struct tui_win_info)
1845         (struct tui_source_window_base, struct tui_data_window)
1846         <set_new_height>: New method.
1847
1848 2019-06-25  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1851         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1852         tui_refresh_data_win.
1853         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1854         method.
1855         (tui_refresh_all_win): Call the refresh_all method.
1856         (tui_set_focus): Likewise.
1857         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1858         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1859         Likewise.
1860
1861 2019-06-25  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-winsource.h (tui_refill_source_window)
1864         (tui_set_is_exec_point_at): Don't declare.
1865         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1866         (tui_source_window_base::refill): Rename from
1867         tui_refill_source_window.
1868         (tui_source_window_base::do_scroll_horizontal): Update.
1869         (tui_source_window_base::set_is_exec_point_at): Rename from
1870         tui_set_is_exec_point_at.
1871         (tui_update_all_breakpoint_info): Update.
1872         * tui/tui-stack.c (tui_show_frame_info): Update.
1873         * tui/tui-layout.c (show_data): Add cast.
1874         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1875         * tui/tui-data.h (struct tui_source_window_base) <refill,
1876         set_is_exec_point_at>: New methods.
1877         (tui_source_windows, tui_add_to_source_windows): Update types.
1878         (tui_add_to_source_windows): Remove redundant declaration.
1879         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1880         (tui_source_windows): Change return type.
1881         (tui_clear_source_windows_detail): Update.
1882         (tui_add_to_source_windows): Change type of parameter.
1883         (tui_free_all_source_wins_content): Update.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-wingeneral.c (tui_win_info::refresh)
1888         (tui_source_window_base::refresh): New methods.
1889         (tui_refresh_all): Call the refresh method.
1890         * tui/tui-data.h (struct tui_win_info)
1891         (struct tui_source_window_base) <refresh>: New method.
1892
1893 2019-06-25  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui.h (tui_is_window_visible): Return bool.
1896         * tui/tui.c (tui_is_window_visible): Return bool.
1897         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1898         (tui_make_visible, tui_make_invisible)
1899         (tui_win_info::make_visible)
1900         (tui_source_window_base::make_visible, make_all_visible)
1901         (tui_make_all_visible, tui_make_all_invisible): Update.
1902         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1903         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1904         bool.
1905         (struct tui_win_info, struct tui_source_window_base)
1906         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1907         * tui/tui-data.c (tui_init_generic_part): Update.
1908
1909 2019-06-25  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1912         (tui_source_window_base::make_visible): New methods.
1913         (make_all_visible): Make method call.
1914         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1915         (struct tui_source_window_base, struct tui_cmd_window): Override
1916         make_visible.
1917         (tui_win_is_source_type): Don't declare.
1918         * tui/tui-data.c (tui_win_is_source_type): Remove.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1923         NULL check.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1928         Inline constructor.  Add initializers for members.
1929         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1930         constructors; now inline in class.
1931
1932 2019-06-25  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-regs.c (tui_show_registers): Update.
1935         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1936         bool.
1937         * tui/tui-data.c (tui_data_window::clear_detail)
1938         (tui_data_window): Update.
1939
1940 2019-06-25  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-windata.c (tui_display_all_data)
1943         (tui_display_data_from_line, tui_display_data_from)
1944         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1945         Update.
1946         * tui/tui-regs.c (tui_last_regs_line_no)
1947         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1948         (tui_show_registers, tui_show_register_group)
1949         (tui_display_registers_from, tui_display_reg_element_at_line)
1950         (tui_display_registers_from_line, tui_check_register_values)
1951         (tui_reg_next, tui_reg_prev): Update.
1952         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1953         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1954         tui_data_window.
1955         (struct tui_win_info) <detail>: Remove.  Add new fields from
1956         tui_data_info.
1957         (TUI_DATA_WIN): Add cast.
1958         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1959         (~tui_data_window): Simplify.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-layout.c (show_source_disasm_command)
1964         (show_source_or_disasm_and_command): Update.
1965         * tui/tui-io.c (update_cmdwin_start_line)
1966         (tui_redisplay_readline): Update.
1967         * tui/tui-data.h (struct tui_command_info): Remove.
1968         (struct tui_win_info) <detail>: Remove command_info member.
1969         (struct tui_data_window) <start_line>: New member, from
1970         tui_command_info.
1971         (TUI_CMD_WIN): Add casts.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.c (tui_update_source_window)
1976         (tui_refill_source_window)
1977         (tui_source_window_base::do_scroll_horizontal)
1978         (tui_update_breakpoint_info, tui_set_exec_info_content)
1979         (tui_show_exec_info_content, tui_erase_exec_info_content)
1980         (tui_clear_exec_info_content): Update.
1981         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1982         Update.
1983         * tui/tui-win.c (make_invisible_and_set_new_height)
1984         (make_visible_with_new_height): Update.
1985         * tui/tui-source.c (tui_set_source_content)
1986         (tui_show_symtab_source): Update.
1987         * tui/tui-layout.c (extract_display_start_addr)
1988         (show_source_disasm_command, show_data)
1989         (make_source_or_disasm_window)
1990         (show_source_or_disasm_and_command): Update.
1991         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1992         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1993         "gdbarch".
1994         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1995         to tui_source_window_base.
1996         (struct tui_win_info) <detail>: Remove source_info member.
1997         (struct tui_source_window_base) <has_locator>: Inline.
1998         Move contents from tui_source_info; rename has_locator member to
1999         m_has_locator.
2000         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2001         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2002         header file.
2003         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2004         Simplify.
2005         (tui_free_all_source_wins_content): Cast to
2006         tui_source_window_base.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-win.c (make_invisible_and_set_new_height)
2011         (make_visible_with_new_height): Call has_locator method.
2012         * tui/tui-layout.c (show_source_disasm_command, show_data)
2013         (show_source_or_disasm_and_command): Update for bool change.
2014         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2015         (tui_win_info) <has_locator>: New method.
2016         (struct tui_source_window_base) <has_locator>: New method.
2017         (tui_win_has_locator): Don't declare.
2018         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2019         from tui_win_has_locator.
2020         (tui_source_window_base): Use false, not FALSE.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2025         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2026         clear_detail method directly.
2027         (tui_clear_win_detail): Remove.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2032         "this", not TUI_DISASM_WIN.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2037         declare.
2038         * tui/tui-winsource.c
2039         (tui_source_window_base::do_scroll_horizontal): Rename from
2040         tui_horizontal_source_scroll.
2041         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2042         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2043         from tui_vertical_data_scroll.
2044         * tui/tui-win.h (tui_scroll): Don't declare.
2045         * tui/tui-win.c (tui_win_info::forward_scroll)
2046         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2047         (tui_win_info::right_scroll): Rename and update.
2048         (tui_scroll_forward_command, tui_scroll_backward_command)
2049         (tui_scroll_left_command, tui_scroll_right_command): Update.
2050         (tui_scroll): Remove.
2051         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2052         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2053         from tui_vertical_source_scroll.
2054         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2055         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2056         from tui_vertical_disassem_scroll.
2057         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2058         do_scroll_horizontal>: New methods.
2059         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2060         Likewise.
2061         (struct tui_source_window_base): Add do_scroll_horizontal.
2062         (struct tui_source_window, struct tui_disasm_window): Add
2063         do_scroll_vertical.
2064         (struct tui_data_window, struct tui_cmd_window): Add
2065         do_scroll_horizontal and do_scroll_vertical.
2066         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2067
2068 2019-06-25  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-data.h (struct tui_source_window_base): New struct.
2071         (struct tui_source_window): Derive from tui_source_window_base.
2072         (struct tui_disasm_window): New struct.
2073         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2074         from tui_source_window::clear_detail.
2075         (tui_source_window_base): Rename from tui_source_window.
2076         (~tui_source_window_base): Rename from ~tui_source_window.
2077         (tui_alloc_win_info): Create a tui_disasm_window.
2078
2079 2019-06-25  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-data.h (struct tui_source_window)
2082         (struct tui_data_window): Declare destructors.
2083         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2084         destructors.
2085         (tui_win_info): Simplify.
2086
2087 2019-06-25  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-winsource.c (tui_display_main)
2090         (tui_update_source_windows_with_addr)
2091         (tui_update_all_breakpoint_info): Update.
2092         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2093         (new_height_ok, parse_scrolling_args): Update.
2094         * tui/tui-stack.c (tui_show_frame_info): Update.
2095         * tui/tui-data.h (struct tui_list): Remove.
2096         (tui_source_windows): Return a reference to a std::vector.
2097         * tui/tui-data.c (source_windows): Now a std::vector.
2098         (tui_source_windows): Change return type.
2099         (tui_clear_source_windows): Rewrite.
2100         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2101         (tui_free_all_source_wins_content): Rewrite.
2102
2103 2019-06-25  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2106         (struct tui_data_window, struct tui_cmd_window): Declare
2107         clear_detail method.
2108         * tui/tui-data.c (tui_source_window::clear_detail)
2109         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2110         methods.
2111         (tui_clear_win_detail): Simplify.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-layout.c (make_source_window, make_disasm_window)
2116         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2117         Return the new window.
2118         (show_source_disasm_command, show_data)
2119         (show_source_or_disasm_and_command): Update.
2120
2121 2019-06-25  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2124         parameter.  Return the new window.
2125         (show_source_disasm_command): Update and remove NULL check.
2126         (show_source_or_disasm_and_command): Update.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-data.h (struct tui_win_info): Make constructor
2135         protected.  Make destructor virtual.  Add initializers.
2136         (tui_source_window, tui_data_window, tui_cmd_window): New
2137         classes.
2138         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2139         constructor.  Add "type" parameter.
2140         (tui_source_window, tui_data_window, tui_cmd_window): New
2141         constructors.
2142         (tui_alloc_win_info): Instantiate the appropriate subclass.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-win.c (tui_resize_all): Use delete.
2147         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2148         destructor.
2149         (tui_free_window): Don't declare.
2150         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2151         Update.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-data.h (struct tui_win_info): Add constructor.
2156         * tui/tui-data.c (tui_alloc_win_info): Use new.
2157         (tui_free_window): Use delete.
2158
2159 2019-06-22  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2162         declare.
2163         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2164
2165 2019-06-22  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2168         declare.
2169         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2170
2171 2019-06-22  Tom de Vries  <tdevries@suse.de>
2172
2173         * dwarf2read.c (create_addrmap_from_aranges)
2174         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2175         instead of '%zu'.
2176
2177 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2178
2179         * dwarf2read.h (dwarf2_section_info_def): Remove.
2180         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2181         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2182         std::vector<dwarf2_section_info>.
2183         (struct dwo_file) <~dwo_file>: Remove.
2184         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2185         types field.
2186         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2187         (dwarf2_read_debug_names): Likewise.
2188         (create_debug_types_hash_table): Change parameter type to
2189         array_view, adjust code accordingly.
2190         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2191         (partial_die_info::fixup): Likewise.
2192         (determine_prefix): Likewise.
2193         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2194
2195 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2196
2197         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2198         gdb_bfd_ref_ptr.
2199         <~dwo_file>: Remove call to gdb_bfd_unref.
2200         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2201         gdb_bfd_ref_ptr::get.
2202
2203 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2204
2205         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2206         type to htab_up.
2207         * dwarf2read.c (struct dwo_file): Initialize fields.
2208         <~dwo_file>: New.
2209         (free_dwo_file): Remove, move content to ~dwo_file.
2210         (struct dwo_file_deleter): Remove.
2211         (dwo_file_up>: Remove custom deleter.
2212         (free_dwo_files): Remove.
2213         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2214         dwo_files.
2215         (process_skeletonless_type_units): Call unique_ptr::get.
2216         (allocate_dwo_file_hash_table): Add deleter to created hash
2217         table.  Change return type to htab_up.
2218         (lookup_dwo_file_slot): Don't memset dwo_file, call
2219         unique_ptr::get.
2220         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2221         (create_dwo_unit_in_dwp_v2): Likewise.
2222         (open_and_init_dwo_file): Likewise.
2223         (free_dwo_file_from_slot): Remove.
2224
2225 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2226
2227         * dwarf2read.h (struct dwarf2_section_info) <readin,
2228         is_virtual>: Change type to bool.
2229         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2230         true instead of 1.
2231
2232 2019-06-19  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-data.h (tui_init_content_element): Don't declare.
2235
2236 2019-06-19  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-data.h (tui_init_win_info): Don't declare.
2239
2240 2019-06-19  Tom de Vries  <tdevries@suse.de>
2241
2242         * dwarf2read.h (abstract_to_concrete): Change type to
2243         std::unordered_map<sect_offset, std::vector<sect_offset>,
2244         gdb::hash_enum<sect_offset>>.
2245
2246 2019-06-19  Tom Tromey  <tromey@adacore.com>
2247
2248         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2249         EVAL_AVOID_SIDE_EFFECTS specially.
2250
2251 2019-06-19  Tom Tromey  <tromey@adacore.com>
2252
2253         * source-cache.c (highlighter): New global.
2254         (source_cache::get_source_lines): Create a highlighter on demand.
2255
2256 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * defs.h (deprecated_interactive_hook): Delete declaration.
2259         * interps.c (clear_interpreter_hooks): Remove use of
2260         deprecated_interactive_hook.
2261         * top.c (deprecated_interactive_hook): Delete definition.
2262         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2263
2264 2019-06-18  Tom de Vries  <tdevries@suse.de>
2265
2266         PR gdb/24515
2267         * dwarf2read.h (abstract_to_concrete): Change type from
2268         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2269         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2270         * dwarf2read.c (read_variable): Update.
2271         (dwarf2_fetch_die_loc_sect_off): Update.
2272
2273 2019-06-17  Tom de Vries  <tdevries@suse.de>
2274
2275         PR gdb/24617
2276         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2277         accessing parent[parent_len - 1].
2278
2279 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2280
2281         PR gdb/24364
2282         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2283         call dtrace_process_dof with NULL dof.
2284
2285 2019-06-16  Tom de Vries  <tdevries@suse.de>
2286
2287         PR gdb/24445
2288         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2289
2290 2019-06-16  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2293         (make_all_visible): Use address of member.
2294
2295 2019-06-16  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2298         (tui_free_window, free_content, free_content_elements): Remove
2299         unnecessary cast.
2300         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2301         cast.
2302         * tui/tui-regs.c (tui_show_register_group)
2303         (tui_display_registers_from, tui_display_reg_element_at_line):
2304         Remove unnecessary cast.
2305
2306 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * linux-nat.c (normal_mask): Delete.
2309         (_initialize_linux_nat): Don't initialise normal_mask.
2310
2311 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2312
2313         PR gdb/24445
2314         * dwarf-index-write.h (write_psymtabs_to_index): Add
2315         dwz_basename parameter.
2316         * dwarf-index-write.c (write_gdbindex): Move file writing to
2317         write_gdbindex_1.  Change return type void.
2318         (assert_file_size): Move up, remove filename parameter.
2319         (write_gdbindex_1): New function.
2320         (write_debug_names): Change return type to void, call
2321         assert_file_size.
2322         (struct index_wip_file): New struct.
2323         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2324         file logic to index_wip_file.  Write index for dwz file if
2325         needed.
2326         (save_gdb_index_command): Pass basename of dwz file, if present.
2327         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2328         build-id of dwz file, if present.
2329         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2330         (dwarf2_get_dwz_file): Likewise.
2331         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2332         (dwarf2_get_dwz_file): Likewise.
2333
2334 2019-06-16  Tom Tromey  <tom@tromey.com>
2335
2336         * coffread.c (process_coff_symbol): Use xstrdup.
2337         * value.c (create_internalvar): Use xstrdup.
2338
2339 2019-06-16  Tom Tromey  <tom@tromey.com>
2340
2341         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2342         * breakpoint.c (stopin_command, stopat_command)
2343         (until_break_command, decode_location_default): Remove unnecessary
2344         cast.
2345         * utils.c (subset_compare): Remove unnecessary cast.
2346         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2347         cast.
2348         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2349         cast.
2350         * infcmd.c (path_command): Remove unnecessary cast.
2351         * coffread.c (decode_type): Remove unnecessary cast.
2352         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2353         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2354         * tui/tui-stack.c (tui_show_locator_content)
2355         (tui_show_frame_info): Remove unnecessary cast.
2356         * tui/tui-win.c (tui_scroll_forward_command)
2357         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2358         (parse_scrolling_args): Remove unnecessary cast.
2359         * tui/tui-data.c (init_win_info, tui_del_window)
2360         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2361         (free_content_elements): Remove unnecessary cast.
2362         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2363         unnecessary cast.
2364         * tui/tui-source.c (tui_set_source_content)
2365         (tui_vertical_source_scroll): Remove unnecessary cast.
2366         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2367         cast.
2368         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2369         * tui/tui-regs.c (tui_display_registers_from)
2370         (tui_display_register): Remove unnecessary cast.
2371         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2372         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2373         (make_visible): Remove unnecessary cast.
2374         * tui/tui-winsource.c (tui_erase_source_content)
2375         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2376         unnecessary cast.
2377         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2378         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2379         * stabsread.c (read_type, read_array_type, read_range_type):
2380         Remove unnecessary cast.
2381         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2382         (parse_symbol, parse_type, upgrade_type, parse_external)
2383         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2384         unnecessary cast.
2385         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2386
2387 2019-06-16  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-data.c (tui_alloc_generic_win_info)
2390         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2391         checks.
2392
2393 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2394             Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * f-typeprint.c (f_print_type): Don't return early for not
2397         associated or not allocated types.
2398         (f_type_print_varspec_suffix): Add print_rank parameter and print
2399         ranks of array types in case they dangling.
2400         (f_type_print_base): Add print_rank parameter.
2401
2402 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * NEWS: Mention new MI commands.
2405         * break-catch-throw.c (enum exception_event_kind): Move to
2406         breakpoint.h.
2407         (print_mention_exception_catchpoint): Output text as a single
2408         message.
2409         (catch_exception_command_1): Rename to...
2410         (catch_exception_event): ...this, make non-static, update header
2411         command, and change some parameter types.
2412         (catch_catch_command): Update for changes to
2413         catch_exception_command_1.
2414         (catch_throw_command): Likewise.
2415         (catch_rethrow_command): Likewise.
2416         * breakpoint.c (enum exception_event_kind): Delete.
2417         * breakpoint.h (enum exception_event_kind): Moved here from
2418         break-catch-throw.c.
2419         (catch_exception_event): Declare.
2420         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2421         (mi_cmd_catch_throw): New function.
2422         (mi_cmd_catch_rethrow): New function.
2423         (mi_cmd_catch_catch): New function.
2424         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2425         'catch-catch' entries.
2426         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2427         (mi_cmd_catch_rethrow): Declare.
2428         (mi_cmd_catch_catch): Declare.
2429
2430 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * annotate.c (annotate_source_line): Change return type to void,
2433         update implementation to match.
2434         * annotate.h (annotate_source_line): Change return type to void,
2435         update header comment.
2436         * stack.c (print_frame_info): Don't change what frame information
2437         is printed based on whether annotations are on or not.
2438
2439 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2442         (annotate_source): Make static.
2443         (annotate_source_line): Moved from source.c and renamed from
2444         identify_source_line.  Update the return type.
2445         * annotate.h (annotate_source): Delete declaration.
2446         (annotate_source_line): Declaration moved from source.h, and
2447         renamed from identify_source_line.  Return type updated.
2448         * source.c (identify_source_line): Moved to annotate.c and renamed
2449         to annotate_source_line.
2450         (info_line_command): Remove check of annotation_level.
2451         * source.h (identify_source_line): Move declaration to annotate.h
2452         and rename to annotate_source_line.
2453         * stack.c: Add 'annotate.h' include.
2454         (print_frame_info): Remove check of annotation_level before
2455         calling annotate_source_line.
2456
2457 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * source-cache.c (source_cache::get_plain_source_lines): Use
2460         open_source_file_with_line_charpos instead of just
2461         open_source_file, remove call to find_source_lines.
2462         (source_cache::get_source_lines): Likewise.
2463         * source.c (find_source_lines): Make static.
2464         (get_filename_and_charpos): Renamed into...
2465         (open_source_file_with_line_charpos): ..this along with changes to
2466         return a scoped_fd, and some other minor clean ups.
2467         (identify_source_line): Use open_source_file_with_line_charpos.
2468         (search_command_helper): Use open_source_file_with_line_charpos
2469         instead of just open_source_file, remove call to
2470         find_source_lines.
2471         * source.h (open_source_file_with_line_charpos): Declare new
2472         function.
2473         (find_source_lines): Delete declaration.
2474
2475 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * source.c (get_filename_and_charpos): Remove fullname
2478         parameter.
2479         (identify_source_line): Update call to get_filename_and_charpos.
2480
2481 2019-06-14  Tom Tromey  <tromey@adacore.com>
2482
2483         PR gdb/24502:
2484         * ui-style.h (skip_ansi_escape): Update comment.
2485         * ui-file.h (class no_terminal_escape_file): New class.
2486         * ui-file.c (no_terminal_escape_file::write)
2487         (no_terminal_escape_file::puts): New methods.
2488         * cli/cli-logging.c (handle_redirections): Use
2489         no_terminal_escape_file.
2490
2491 2019-06-14  Tom Tromey  <tromey@adacore.com>
2492
2493         * NEWS: Move convenience variable news above Python news.
2494
2495 2019-06-14  Tom Tromey  <tom@tromey.com>
2496
2497         * gnulib: Move directory to top-level.
2498         * configure.ac: Don't configure gnulib.
2499         * configure: Rebuild.
2500         * common/common-defs.h: Use new path to gnulib.
2501         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2502         (GNULIB_H): Remove.
2503         (INCGNU): Look in new gnulib location.
2504         (HFILES_NO_SRCDIR): Remove gnulib files.
2505         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2506         (generated_files): Remove GNULIB_H.
2507         ($(LIBGNU), all-lib): Remove targets.
2508         (distclean): Don't mention GNULIB_BUILDDIR.
2509         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2510
2511 2019-06-14  Tom Tromey  <tromey@adacore.com>
2512
2513         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2514         Warn if symbol file does not provide any symbols.
2515
2516 2019-06-14  Tom Tromey  <tromey@adacore.com>
2517
2518         * source.c (find_and_open_source): Respect basenames_may_differ.
2519
2520 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * annotate.c (annotate_breakpoints_invalid): Make use of
2523         scoped_restore_terminal_state.
2524         (annotate_frames_invalid): Likewise.
2525
2526 2019-06-14  Tom Tromey  <tromey@adacore.com>
2527
2528         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2529         allow assignment to an internalvar.
2530
2531 2019-06-14  Tom Tromey  <tromey@adacore.com>
2532
2533         * ada-lex.l: Allow "_" in attribute names.
2534
2535 2019-06-14  Tom Tromey  <tromey@adacore.com>
2536
2537         PR gdb/24653:
2538         * regcache.c (registers_changed): Don't call alloca.
2539         * top.c (execute_command): Don't call alloca.
2540
2541 2019-06-13  Pedro Alves  <palves@redhat.com>
2542
2543         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2544         'expression'.  When parsing an expression, error out if there's
2545         junk after "unlimited".
2546         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2547         (do_set_command): Adjust calls to is_unlimited_literal.
2548
2549 2019-06-13  Pedro Alves  <palves@redhat.com>
2550
2551         * compile/compile.c (make_compile_options_def_group): Add braces
2552         around array_view initializer.
2553         * thread.c (make_thread_apply_all_options_def_group)
2554         (make_thread_apply_all_options_def_group): Likewise.
2555
2556 2019-06-13  Pedro Alves  <palves@redhat.com>
2557
2558         * NEWS (New commands): Mention "maint test-options
2559         require-delimiter", "maint test-options unknown-is-error", "maint
2560         test-options unknown-is-operand" and "maint show
2561         test-options-completion-result".
2562         (New command options, command completion): New section.
2563         (Completion improvements): New section.
2564         Mention that you can abbreviate "unlimited".
2565
2566 2019-06-13  Pedro Alves  <palves@redhat.com>
2567
2568         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2569         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2570         * unittests/cli-utils-selftests.c (test_parse_flags)
2571         (test_parse_flags_qcs): Delete.
2572         (test_cli_utils): Don't call deleted functions.
2573
2574 2019-06-13  Pedro Alves  <palves@redhat.com>
2575
2576         * thread.c: Include "cli/cli-option.h".
2577         (tp_array_compar_ascending): Global.
2578         (tp_array_compar): Delete function.
2579         (tp_array_compar_ascending, tp_array_compar_descending): New
2580         functions.
2581         (ascending_option_def, qcs_flag_option_def)
2582         (thr_qcs_flags_option_defs)
2583         (make_thread_apply_all_options_def_group)
2584         (make_thread_apply_options_def_group): New.
2585         (thread_apply_all_command): Use gdb::option::process_options.
2586         (thread_apply_command_completer)
2587         (thread_apply_all_command_completer): New.
2588         (thread_apply_command): Use gdb::option::process_options.
2589         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2590         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2591         to generate help text of "thread apply".  Adjust "taas"'s help.
2592         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2593         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2594
2595 2019-06-13  Pedro Alves  <palves@redhat.com>
2596
2597         * thread.c (thread_apply_command): Check for invalid TID with
2598         isdigit instead of !isalpha.
2599
2600 2019-06-13  Pedro Alves  <palves@redhat.com>
2601
2602         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2603         (validate_flags_qcs): New.
2604         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2605         (validate_flags_qcs): Declare.
2606         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2607         (make_frame_apply_options_def_group): New.
2608         (frame_apply_command_count): Process options with
2609         gdb::option::process_options.
2610         (frame_apply_completer): New.
2611         (frame_apply_level_completer, frame_apply_all_completer)
2612         (frame_apply_completer): New.
2613         (_initialize_stack): Update help of "frame apply", "frame apply
2614         level", "frame apply all" and "faas" to mention supported options
2615         and install command completers.
2616         * stack.h (frame_apply_all_completer): Declare.
2617         * thread.c: Include "stack.h".
2618         (tfaas_command): Add "--".
2619         (_initialize_thread): Update help "tfaas" to mention supported
2620         options and install command completer.
2621
2622 2019-06-13  Pedro Alves  <palves@redhat.com>
2623
2624         * completer.c (complete_nested_command_line): New.
2625         (gdb_completion_word_break_characters_throw): Add assertion.
2626         * completer.h (complete_nested_command_line): Declare.
2627
2628 2019-06-13  Pedro Alves  <palves@redhat.com>
2629
2630         * stack.c (parse_backtrace_qualifiers): New.
2631         (backtrace_command): Use it.
2632         (backtrace_command_completer): Complete on qualifiers.
2633
2634 2019-06-13  Pedro Alves  <palves@redhat.com>
2635
2636         * frame.c: Include "cli/cli-option.h.
2637         (user_set_backtrace_options): New.
2638         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2639         Delete.
2640         (get_prev_frame): Adjust.
2641         (boolean_option_def, uinteger_option_def)
2642         (set_backtrace_option_defs): New.
2643         (_initialize_frame): Adjust and use
2644         gdb::option::add_setshow_cmds_for_options to install "set
2645         backtrace past-main" and "set backtrace past-entry".
2646         * frame.h: Include "cli/cli-option.h".
2647         (struct frame_print_options): Forward declare.
2648         (print_frame_arguments_all, print_frame_arguments_scalars)
2649         (print_frame_arguments_none): Declare.
2650         (print_entry_values): Delete declaration.
2651         (struct frame_print_options, user_frame_print_options): New.
2652         (struct set_backtrace_options): New.
2653         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2654         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2655         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2656         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2657         (list_args_or_locals): Add frame_print_options parameter.
2658         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2659         * python/py-framefilter.c (enumerate_args): Pass down
2660         USER_FRAME_PRINT_OPTIONS.
2661         * stack.c: Include "cli/cli-option.h".
2662         (print_frame_arguments_all, print_frame_arguments_scalars)
2663         (print_frame_arguments_none): Declare.
2664         (print_raw_frame_arguments, print_entry_values): Delete.
2665         (user_frame_print_options): New.
2666         (boolean_option_def, enum_option_def, frame_print_option_defs):
2667         New.
2668         (struct backtrace_cmd_options): New.
2669         (bt_flag_option_def): New.
2670         (backtrace_command_option_defs): New.
2671         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2672         (print_frame_arg, read_frame_arg, print_frame_args)
2673         (print_frame_info, print_frame): Add frame_print_options parameter
2674         and use it.
2675         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2676         (backtrace_command_1): Add frame_print_options and
2677         backtrace_cmd_options parameters and use them.
2678         (make_backtrace_options_def_group): New.
2679         (backtrace_command): Process command options with
2680         gdb::option::process_options.
2681         (backtrace_command_completer): New.
2682         (_initialize_stack): Extend "backtrace"'s help to mention
2683         supported options.  Install completer for "backtrace".
2684         Install some settings commands with add_setshow_cmds_for_options.
2685
2686 2019-06-13  Pedro Alves  <palves@redhat.com>
2687
2688         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2689         and that "set/show print raw frame-arguments" are now deprecated.
2690
2691         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2692         command.
2693         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2694         * stack.c (_initialize_stack): Install "set/show print
2695         raw-frame-arguments", and deprecate "set/show print raw
2696         frame-arguments".
2697         * valprint.c (_initialize_valprint): Deprecate "set/show print
2698         raw".
2699
2700 2019-06-13  Pedro Alves  <palves@redhat.com>
2701
2702         * compile/compile.c (struct compile_options): New.
2703         (compile_flag_option_def, compile_command_option_defs)
2704         (make_compile_options_def_group): New.
2705         (compile_file_command): Handle options with
2706         gdb::option::process_options.
2707         (compile_file_command_completer): New function.
2708         (compile_code_command): Handle options with
2709         gdb::option::process_options.
2710         (compile_code_command_completer): New function.
2711         (_initialize_compiler): Install completers for "compile code" and
2712         "compile file".  Mention available options in "compile code" and
2713         "compile code"'s help.
2714         * completer.c (advance_to_completion_word): New, factored out from
2715         ...
2716         (advance_to_expression_complete_word_point): ... this.
2717         (advance_to_filename_complete_word_point): New.
2718         * completer.h (advance_to_filename_complete_word_point): New
2719         declaration.
2720
2721 2019-06-13  Pedro Alves  <palves@redhat.com>
2722
2723         * compile/compile.c: Include "cli/cli-option.h".
2724         (compile_print_value): Scope data pointer is now a
2725         value_print_options pointer; adjust.
2726         (compile_print_command): Process options.  Scope data pointer is
2727         now a value_print_options pointer; adjust.
2728         (_initialize_compile): Update "compile print"'s help to include
2729         supported options.  Install a completer for "compile print".
2730         * cp-valprint.c (show_vtblprint, show_objectprint)
2731         (show_static_field_print): Delete.
2732         (_initialize_cp_valprint): Don't install "set print
2733         static-members", "set print vtbl", "set print object" here.
2734         * printcmd.c: Include "cli/cli-option.h" and
2735         "common/gdb_optional.h".
2736         (print_command_parse_format): Rework to fill in a
2737         value_print_options instead of a format_data.
2738         (print_value): Change parameter type from format_data pointer to
2739         value_print_options reference.  Adjust.
2740         (print_command_1): Process options.  Adjust to pass down a
2741         value_print_options.
2742         (print_command_completer): New.
2743         (_initialize_printcmd): Install print_command_completer as
2744         handle_brkchars completer for the "print" command.  Update
2745         "print"'s help to include supported options.
2746         * valprint.c: Include "cli/cli-option.h".
2747         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2748         here from cp-valprint.c.
2749         (boolean_option_def, uinteger_option_def)
2750         (value_print_option_defs, make_value_print_options_def_group):
2751         New.  Use gdb::option::add_setshow_cmds_for_options to install
2752         "set print elements", "set print null-stop", "set print repeats",
2753         "set print pretty", "set print union", "set print array", "set
2754         print address", "set print symbol", "set print array-indexes".
2755         * valprint.h: Include <string> and "cli/cli-option.h".
2756         (make_value_print_options_def_group): Declare.
2757         (print_value): Change parameter type from format_data pointer to
2758         value_print_options reference.
2759         (print_command_completer): Declare.
2760
2761 2019-06-13  Pedro Alves  <palves@redhat.com>
2762
2763         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2764         (COMMON_SFILES): Add maint-test-settings.c.
2765         * cli/cli-decode.c (boolean_enums): New global, factored out from
2766         ...
2767         (add_setshow_boolean_cmd): ... here.
2768         * cli/cli-decode.h (boolean_enums): Declare.
2769         * cli/cli-option.c: New file.
2770         * cli/cli-option.h: New file.
2771         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2772         factored out from ...
2773         (parse_cli_boolean_value(const char *)): ... this.
2774         (is_unlimited_literal): Change parameter type to pointer to
2775         pointer.  Adjust and advance ARG pointer.
2776         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2777         (parse_cli_var_enum): New, factored out from ...
2778         (do_set_command): ... this.  Adjust.
2779         * cli/cli-setshow.h (parse_cli_boolean_value)
2780         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2781         (parse_cli_var_enum): Declare.
2782         * cli/cli-utils.c: Include "cli/cli-option.h".
2783         (get_ulongest): New.
2784         * cli/cli-utils.h (get_ulongest): Declare.
2785         (check_for_argument): New overloads.
2786         * maint-test-options.c: New file.
2787
2788 2019-06-13  Pedro Alves  <palves@redhat.com>
2789
2790         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2791         parse a range if "-" is at the end of the string.
2792
2793 2019-06-13  Pedro Alves  <palves@redhat.com>
2794
2795         * cli/cli-setshow.c (parse_auto_binary_operation)
2796         (parse_cli_boolean_value): Don't allow "o".
2797
2798 2019-06-13  Pedro Alves  <palves@redhat.com>
2799
2800         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2801         * NEWS: Mention maint test-settings KIND.
2802         * maint-test-settings.c: New file.
2803
2804 2019-06-13  Pedro Alves  <palves@redhat.com>
2805
2806         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2807         completer.
2808         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2809         "set" completers.
2810
2811 2019-06-13  Pedro Alves  <palves@redhat.com>
2812
2813         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2814         after item.
2815
2816 2019-06-13  Pedro Alves  <palves@redhat.com>
2817
2818         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2819
2820 2019-06-13  Pedro Alves <palves@redhat.com>
2821
2822         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2823         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2824         call.
2825         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2826         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2827         calls.
2828         (check_for_argument): Skip spaces after argument.
2829
2830 2019-06-13  Pedro Alves  <palves@redhat.com>
2831
2832         * thread.c (thread_apply_command): Adjust TID parsing.
2833         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2834         detected before end of string.
2835         (tid_is_in_list): Error out if LIST is invalid.
2836
2837 2019-06-13  Pedro Alves  <palves@redhat.com>
2838
2839         * completer.c (complete_line_internal_1): Rewind completion word
2840         point.
2841         (completion_tracker::advance_custom_word_point_by): Change
2842         parameter type to int.
2843         * completer.h (completion_tracker::advance_custom_word_point_by):
2844         Likewise.
2845
2846 2019-06-13  Pedro Alves  <palves@redhat.com>
2847
2848         * completer.c (advance_to_completion_word): Handle delimiters.
2849
2850 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2851
2852         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2853
2854 2019-06-11  Tom Tromey  <tom@tromey.com>
2855
2856         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2857         (xmalloc_failed): Move to alloc.c.
2858         * alloc.c: New file.
2859         * Makefile.in (COMMON_SFILES): Add alloc.c.
2860
2861 2019-06-11  Tom Tromey  <tom@tromey.com>
2862
2863         * nat/linux-waitpid.c: Don't include server.h.
2864         (linux_debug): Remove.
2865         (my_waitpid): Update.
2866
2867 2019-06-11  Tom Tromey  <tromey@adacore.com>
2868
2869         * infcall.c (_initialize_infcall): Remove trailing newline from
2870         help.
2871         * user-regs.c (_initialize_user_regs): Remove trailing newline
2872         from help.
2873         * typeprint.c (_initialize_typeprint): Remove trailing newline
2874         from help.
2875         * reverse.c (_initialize_reverse): Remove trailing newlines from
2876         help.
2877         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2878         from help.
2879         * language.c (add_set_language_command): Remove trailing newline
2880         from help.
2881         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2882         help.
2883         * disasm.c (_initialize_disasm): Remove trailing newline from
2884         help.
2885         * top.c (init_main): Remove trailing newline from help.
2886         * interps.c (_initialize_interpreter): Remove trailing newline
2887         from help.
2888         * btrace.c (_initialize_btrace): Remove trailing newlines from
2889         help.
2890         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2891         from help.
2892         * python/python.c (_initialize_python): Remove trailing newline
2893         from help.
2894         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2895         help.
2896         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2897         from help.  Reformat some text.
2898         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2899         from help.
2900         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2901         newline from help.
2902
2903 2019-06-11  Tom Tromey  <tromey@adacore.com>
2904
2905         * darwin-nat.c (darwin_decode_exception_message)
2906         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2907
2908 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2909
2910         * valops.c (value_slice): Check for not allocated or not
2911         associated values.
2912
2913 2019-06-10  Tom de Vries  <tdevries@suse.de>
2914
2915         PR gdb/24618
2916         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2917         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2918         invalid.
2919
2920 2019-06-10  Tom de Vries  <tdevries@suse.de>
2921
2922         PR gdb/24611
2923         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2924         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2925
2926 2019-06-10  Tom de Vries  <tdevries@suse.de>
2927
2928         PR symtab/24545
2929         * symtab.c (struct demangled_name_entry): Add language field.
2930         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2931         static minimal symbol".  Set and use language field.
2932
2933 2019-06-10  Tom Tromey  <tromey@adacore.com>
2934
2935         * ada-lang.c (_initialize_ada_language): Update help text.
2936
2937 2019-06-10  Tom Tromey  <tromey@adacore.com>
2938
2939         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2940         with a newline.
2941         * guile/guile.c (handle_boot_error): Don't end warning with a
2942         newline.
2943         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2944         warning with a newline.
2945         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2946         newline.
2947         (s12z_frame_cache): Likewise.
2948         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2949         a newline.
2950         * solib-svr4.c (disable_probes_interface): Don't end warning with
2951         a newline.
2952         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2953         newline.
2954         * python/python.c (do_finish_initialization): Don't end warning
2955         with a newline.
2956
2957 2019-06-10  Tom Tromey  <tom@tromey.com>
2958
2959         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2960         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2961         gdbpy_enter.
2962
2963 2019-06-10  Tom Tromey  <tromey@adacore.com>
2964
2965         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2966         data.
2967         (elf_new_init): Don't call stabsread_new_init.
2968         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2969         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2970         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2971
2972 2019-06-10  Tom de Vries  <tdevries@suse.de>
2973
2974         PR symtab/16264
2975         PR symtab/24517
2976         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2977
2978 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2979
2980         * source.c (find_and_open_source): Also rewrite relative file
2981         names.
2982
2983 2019-04-26  Amos Bird  <amosbird@gmail.com>
2984
2985         * annotate.c (annotate_thread_exited): Add "thread-exited"
2986         annotation.
2987
2988 2019-06-06  Tom Tromey  <tromey@adacore.com>
2989
2990         * maint.h (class scoped_command_stats): Use
2991         DISABLE_COPY_AND_ASSIGN.
2992         <print_time>: New method.
2993         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2994         print_time.
2995         (scoped_command_stats::print_time): New method.
2996
2997 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3000         instructions of lengths 6 or 8 bytes.
3001
3002 2019-06-04  Pedro Alves  <palves@redhat.com>
3003
3004         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3005
3006         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3007         * breakpoint.c (condition_completer): Likewise.
3008         * cli/cli-dump.c (scan_expression): Likewise.
3009         * common/filestuff.c (mkdir_recursive): Likewise.
3010         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3011         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3012         (gdb_abspath): Likewise.
3013         * compile/compile-cplus-types.c
3014         (compile_cplus_instance::decl_name): Likewise.
3015         * completer.c (complete_explicit_location):
3016         (signal_completer, reg_or_group_completer_1): Likewise.
3017         * cp-support.c (cp_remove_params_if_any): Likewise.
3018         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3019         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3020         * infcmd.c (strip_bg_char): Likewise.
3021         * linespec.c (copy_token_string): Likewise.
3022         * mi/mi-main.c (output_cores): Likewise.
3023         * psymtab.c (psymtab_search_name):
3024         * symfile.c (test_set_ext_lang_command): Likewise.
3025         * target.c (target_fileio_read_stralloc): Likewise.
3026         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3027         * value.c (complete_internalvar): Likewise.
3028
3029 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3030
3031         Add objfile property to gdb.Type.
3032         * NEWS: Mention Python API addition.
3033         * python/py-type.c (typy_get_objfile): New method.
3034
3035 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3036
3037         * NEWS: Mention the new set|show style [title|highlight].
3038         Mention changes to "show style", "help" and "apropos".
3039
3040 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3041
3042         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3043         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3044         instead of print_help_for_command.
3045         (print_doc_of_command): New function.
3046         (help_list): Add 'apropos -v word' suggestion.
3047         (print_help_for_command): Style the command name using title style.
3048         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3049         (_initialize_cli_cmds): Describe -v in apropos_command help.
3050
3051 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3052
3053         * cli/cli-style.h (cli_style_option): Add name in constructor,
3054         add m_name class member, add constructor with intensity,
3055         add name class function.
3056         (cli_style_option::add_setshow_commands): Remove name argument.
3057         (highlight_style, title_style): New styles.
3058         * cli/cli-style.c (do_show): New function that shows a style
3059         characteristic styling the style name with itself.
3060         (set_style_name): New function.
3061         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3062         Update all callers according to the changes in cli/cli-style.h.
3063         * utils.h (fputs_highlighted): New function.
3064         * utils.c (fputs_highlighted): Likewise.
3065
3066 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3067
3068         * NEWS: Mention new pipe command and new convenience variables.
3069
3070 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3071
3072         * cli/cli-cmds.c (pipe_command): New function.
3073         (_initialize_cli_cmds): Call add_com for pipe_command.
3074         Define | as an alias for pipe.
3075         (exit_status_set_internal_vars): New function.
3076         (shell_escape): Call exit_status_set_internal_vars.
3077         cli/cli-decode.c (find_command_name_length): Recognize | as
3078         a single character command.
3079
3080 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3081
3082         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3083         top.c (execute_command_to_ui_file): New function, mostly a copy
3084         of execute_command_to_string.
3085         (execute_command_to_string): Implement by calling
3086         execute_command_to_ui_file.
3087
3088 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3089
3090         * top.h (saved_command_line): Remove declaration.
3091         * top.c (previous_saved_command_line, previous_repeat_arguments):
3092         New variables.
3093         (saved_command_line): Make static, define together with other
3094         'repeat variables'.
3095         (dont_repeat): Clear repeat_arguments.
3096         (repeat_previous, get_saved_command_line, save_command_line):
3097         New functions.
3098         (gdb_init): Initialize saved_command_line
3099         and previous_saved_command_line.
3100         * main.c (captured_main_1): Remove saved_command_line initialization.
3101         * event-top.c (handle_line_of_input): Update to use
3102         the new 'repeat' related functions instead of direct access to
3103         saved_command_line.
3104         * command.h (repeat_previous, get_saved_command_line,
3105         save_command_line): New declarations.
3106         (dont_repeat): Add comment.
3107
3108 2019-05-30  Tom Tromey  <tromey@adacore.com>
3109
3110         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3111         Fix comment.
3112         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3113
3114 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3115
3116         PR cli/24587
3117         * completer.c (complete): Initialize variable word.
3118
3119 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3120
3121         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3122         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3123         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3124         'body' is NULL to the outter 'if', protecting the '!is_define'
3125         situation as well.
3126
3127 2019-05-29  Tom Tromey  <tromey@adacore.com>
3128
3129         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3130         (dwarf_unknown): New function.
3131         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3132         (dwarf_type_encoding_name): Use dwarf_unknown.
3133
3134 2019-05-29  Tom Tromey  <tromey@adacore.com>
3135
3136         PR c++/20020:
3137         * cp-valprint.c (cp_print_value_fields): Call
3138         cp_print_static_field inside "try".
3139
3140 2019-05-29  Tom Tromey  <tromey@adacore.com>
3141
3142         * inflow.c (struct terminal_info): Add default operator=.
3143         * configure: Rebuild.
3144         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3145         -Wdeprecated-copy-dtor, -Wredundant-move.
3146
3147 2019-05-29  Tom Tromey  <tromey@adacore.com>
3148
3149         * NEWS: Add entry.
3150         * infcmd.c (print_return_value_1): Handle finish_print
3151         option.
3152         (show_print_finish): New function.
3153         (_initialize_infcmd): Add "set/show print finish" commands.
3154         * valprint.c (user_print_options): Initialize new member.
3155         * valprint.h (struct value_print_options) <finish_print>: New
3156         member.
3157
3158 2019-05-28  Tom Tromey  <tromey@adacore.com>
3159
3160         * ada-lang.c (ada_remove_Xbn_suffix)
3161         (find_old_style_renaming_symbol)
3162         (parse_old_style_renaming): Remove.
3163         (ada_find_renaming_symbol): Don't call
3164         find_old_style_renaming_symbol.
3165         (ada_is_renaming_symbol): Rename from
3166         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3167         bool.  Now static.
3168         (ada_read_var_value): Update and simplify.
3169         * ada-exp.y (write_var_or_type): Remove old code.
3170
3171 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3172
3173         * event-top.c: Remove include comment.
3174         * inflow.c (class scoped_ignore_sigttou): Move from here...
3175         * inflow.h (class scoped_ignore_sigttou): ...to here.
3176         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3177         * top.c:  Remove include comment.
3178
3179 2019-05-27  Tom Tromey  <tom@tromey.com>
3180
3181         * NEWS: Fix typo.
3182
3183 2019-05-22  Tom Tromey  <tromey@adacore.com>
3184
3185         * target.c (target_follow_exec): Constify parameter.
3186         * target-delegates.c: Rebuild.
3187         * remote.c (remote_target::follow_exec): Constify parameter.
3188         * infrun.c (follow_exec): Constify parameter.
3189         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3190         (target_follow_exec): Likewise.
3191
3192 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3193
3194         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3195         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3196
3197 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3198
3199         * NEWS: Add debugredirect and testsuite sections.
3200
3201 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3202
3203         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3204         target descriptions using exclusively floating point register name
3205         aliases.
3206
3207 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         PR gdb/18644:
3210         * f-lang.c (build_fortran_types): Handle the case where
3211         gdbarch_floatformat_for_type returns a nullptr.
3212
3213 2019-05-21  Tom de Vries  <tdevries@suse.de>
3214
3215         PR cli/24587
3216         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3217
3218 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         PR gdb/18644:
3221         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3222         16-byte floats.
3223         * i386-tdep.c (i386_floatformat_for_type): Use
3224         floatformats_ia64_quad for the 16-byte floating point component
3225         within a fortran 32-byte complex number.
3226
3227 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3228
3229         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3230         delete default constructor.
3231         (find_partial_die): Update to return const struct.
3232         (partial_die_parent_scope): Move variable declaration into scope
3233         of its use and change its type to auto.
3234         (guess_partial_die_structure_name): Likewise.
3235         (partial_die_info::fixup): Likewise.
3236
3237 2019-05-17  Tom Tromey  <tromey@adacore.com>
3238
3239         * source.c (find_and_open_source): Remove cast.
3240
3241 2019-05-17  Tom Tromey  <tromey@adacore.com>
3242
3243         * annotate.c (annotate_source): Make "filename" const.
3244         * annotate.h (annotate_source): Use const.
3245
3246 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3247
3248         * disasm.c (set_disassembler_options): Send errors to stderr.
3249
3250 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3251
3252         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3253         (cli_interp_base::set_logging): Check debug_redirect.
3254         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3255         * cli/cli-logging.c (debug_redirect): Add static variable.
3256         (pop_output_files): Add default param.
3257         (handle_redirections): Print debug setting.
3258         (show_logging_command): Likewise.
3259         (_initialize_cli_logging): Add debugredirect command.
3260         * interps.c (current_interp_set_logging): Add debug_redirect
3261         parameter.
3262         * interps.h (set_logging): Add debug_redirect parameter.
3263         (current_interp_set_logging): Likewise.
3264         * mi/mi-common.h: Likewise.
3265         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3266
3267 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3268             Tom Tromey  <tromey@adacore.com>
3269
3270         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3271         directly.
3272         * cli/cli-interp.h (make_logging_output): Remove declaration.
3273         * cli/cli-logging.c (make_logging_output): Remove function.
3274         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3275         directly.
3276         * ui-file.c (tee_file::tee_file): Remove bools.
3277         (tee_file::~tee_file): Remove deletes.
3278         * ui-file.h (tee_file): Remove bools.
3279
3280 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3281
3282         * mi/mi-cmds.h (mi_cmd_complete): New function.
3283         * mi/mi-main.c (mi_cmd_complete): Likewise.
3284         * mi/mi-cmds.c: Define new MI command -complete.
3285         * NEWS: Mention new -complete command.
3286
3287 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3288
3289         * completer.h (complete): New function.
3290         * completer.c (complete): Likewise.
3291         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3292         function defined in completer.h.
3293
3294 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3295
3296         * MAINTAINERS (Write After Approval): Add myself.
3297
3298 2019-05-17  Tom de Vries  <tdevries@suse.de>
3299
3300         PR gdb/24094
3301         * dwarf2read.c (struct cu_partial_die_info): New struct.
3302         (find_partial_die): Return cu_partial_die_info.
3303         (partial_die_parent_scope, guess_partial_die_structure_name)
3304         (partial_die_info::fixup): Handle new return type of find_partial_die.
3305
3306 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3307
3308         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3309         "std::string", simplifying the algorithm.
3310
3311 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3312
3313         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3314         (stap_static_probe_ops::get_probes): Likewise.
3315
3316 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3317
3318         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3319         '-')" and "else if".
3320         (stap_parse_single_operand): Join checks for
3321         "gdbarch_stap_parse_special_token_p" and
3322         "gdbarch_stap_parse_special_token" in the same "if" statement.
3323         Invert check when verifying for operation on register
3324         displacement.
3325
3326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3327
3328         * stap-probe.c (stap_get_opcode): Update comment.
3329         (stap_get_expected_argument_type): Likewise.
3330         (handle_stap_probe): Likewise.
3331
3332 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3333
3334         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3335         return type to 'bool'.  Adjust comment.  Use 'bool' when
3336         appropriate.
3337         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3338         * stap-probe.c (stap_parse_argument_1): Likewise.
3339         (stap_is_operator): Likewise.
3340         (stap_is_generic_prefix): Likewise.
3341         (stap_is_register_prefix): Likewise.
3342         (stap_is_register_indirection_prefix): Likewise.
3343         (stap_is_integer_prefix): Likewise.
3344         (stap_generic_check_suffix): Likewise.
3345         (stap_check_integer_suffix): Likewise.
3346         (stap_check_register_suffix): Likewise.
3347         (stap_check_register_indirection_suffix): Likewise.
3348         (stap_parse_register_operand): Likewise.
3349         (stap_parse_single_operand): Likewise.
3350         (stap_parse_argument_1): Likewise.
3351         (stap_probe::get_argument_count): Likewise.
3352         (stap_is_operator): Likewise.
3353
3354 2019-05-16  Tom Tromey  <tromey@adacore.com>
3355
3356         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3357         keyword to foreach.
3358
3359 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3360
3361         * linux-thread-db.c (try_thread_db_load_1): Change return type
3362         to bool.
3363         (try_thread_db_load): Likewise.
3364         (try_thread_db_load_from_pdir_1): Likewise.
3365         (try_thread_db_load_from_pdir): Likewise.
3366         (try_thread_db_load_from_sdir): Likewise.
3367         (try_thread_db_load_from_dir): Likewise.
3368         (thread_db_load_search): Likewise.
3369         (has_libpthread): Likewise.
3370         (thread_db_load): Likewise.
3371
3372 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3373
3374         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3375         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3376         NULL, and complain/return if that's the case.
3377
3378 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3379
3380         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3381         (advance, posn, abstract_read_memory): New functions.
3382         [struct mem_read_abstraction]: New struct.
3383         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3384
3385 2019-05-14  Tom Tromey  <tromey@adacore.com>
3386
3387         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3388         value is not lval_memory.
3389
3390 2019-05-14  Tom Tromey  <tromey@adacore.com>
3391
3392         * solib.c (info_sharedlibrary_command): Style the file name.
3393
3394 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3395
3396         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3397         (aarch64_vnv_type): Likewise.
3398         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3399         * common/tdesc.c: Likewise.
3400         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3401         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3402         * features/aarch64-fpu.xml: Add ieee half view.
3403         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3404         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3405         * gdbtypes.h (struct builtin_type): Likewise.
3406         (struct objfile_type): Likewise.
3407
3408 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3409
3410         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3411         typo.
3412         * location.h (string_to_event_location): Likewise.
3413
3414 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3415
3416         GDB 8.3 released.
3417
3418 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3419
3420         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3421         New variable declaration.
3422         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3423         New variable.
3424         (print_one_breakpoint): Use ui_out::test_flags and new global
3425         variable to compute use_fixed_output.
3426         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3427         Remove.
3428         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3429         (mi_multi_location_breakpoint_output_fixed): Remove.
3430         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3431         new variable.
3432         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3433         fix_multi_location_breakpoint_output flag if version >= 3.
3434         * ui-out.h (enum ui_out_flag)
3435         <fix_multi_location_breakpoint_output>: New enumerator.
3436
3437 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3438
3439         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3440
3441 2019-05-10  Tom Tromey  <tromey@adacore.com>
3442
3443         * ada-lang.c (catch_ada_completer): New function.
3444         (_initialize_ada_language): Use it.
3445
3446 2019-05-10  Tom Tromey  <tromey@adacore.com>
3447
3448         * thread.c (print_thread_info): Make "requested_threads" const.
3449         * gdbthread.h (print_thread_info): Make "requested_threads"
3450         const.
3451         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3452         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3453
3454 2019-05-08  Tom Tromey  <tom@tromey.com>
3455
3456         * gdbtypes.c (objfile_type_data): Change type.
3457         (objfile_type, _initialize_gdbtypes): Update.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3462         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3463         (_initialize_dwarf2_frame): Update.
3464
3465 2019-05-08  Tom Tromey  <tom@tromey.com>
3466
3467         * objc-lang.c (objc_objfile_data): Change type.
3468         (find_methods): Update.
3469         (_initialize_objc_lang): Remove.
3470
3471 2019-05-08  Tom Tromey  <tom@tromey.com>
3472
3473         * stabsread.c (rs6000_builtin_type_data): Change type.
3474         (rs6000_builtin_type, _initialize_stabsread): Update.
3475
3476 2019-05-08  Tom Tromey  <tom@tromey.com>
3477
3478         * mips-tdep.c (mips_pdr_data): Remove.
3479         (_initialize_mips_tdep): Update.
3480
3481 2019-05-08  Tom Tromey  <tom@tromey.com>
3482
3483         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3484         (hppa_init_objfile_priv_data, read_unwind_info)
3485         (find_unwind_entry, _initialize_hppa_tdep): Update.
3486
3487 2019-05-08  Tom Tromey  <tom@tromey.com>
3488
3489         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3490         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3491         on obstack.
3492         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3493
3494 2019-05-08  Tom Tromey  <tom@tromey.com>
3495
3496         * mdebugread.c (basic_type_data): Change type.
3497         (basic_type, _initialize_mdebugread): Update.
3498
3499 2019-05-08  Tom Tromey  <tom@tromey.com>
3500
3501         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3502
3503 2019-05-08  Tom Tromey  <tom@tromey.com>
3504
3505         * nto-tdep.c (nto_inferior_data_reg): Change type.
3506         (nto_inferior_data): Update.
3507         (nto_inferior_data_cleanup, nto_new_inferior_data)
3508         (_initialize_nto_tdep): Remove.
3509         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3510
3511 2019-05-08  Tom Tromey  <tom@tromey.com>
3512
3513         * ada-lang.c (struct ada_inferior_data): Add initializers.
3514         (ada_inferior_data): Change type.
3515         (ada_inferior_data_cleanup): Remove.
3516         (get_ada_inferior_data, ada_inferior_exit)
3517         (struct ada_pspace_data): Add initializers, destructor.
3518         (ada_pspace_data_handle): Change type.
3519         (get_ada_pspace_data): Update.
3520         (ada_pspace_data_cleanup): Remove.
3521
3522 2019-05-08  Tom Tromey  <tom@tromey.com>
3523
3524         * coffread.c (struct coff_symfile_info): Add initializers.
3525         (coff_objfile_data_key): Move lower.  Change type.
3526         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3527         Update.
3528         (coff_free_info): Remove.
3529
3530 2019-05-08  Tom Tromey  <tom@tromey.com>
3531
3532         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3533         (fbsd_pspace_data_handle): Move lower.  Change type.
3534         (get_fbsd_pspace_data): Update.
3535         (fbsd_pspace_data_cleanup): Remove.
3536         (_initialize_fbsd_tdep): Update.
3537
3538 2019-05-08  Tom Tromey  <tom@tromey.com>
3539
3540         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3541         (get_ada_tasks_pspace_data): Update.
3542         (ada_tasks_pspace_data_cleanup): Remove.
3543         (_initialize_tasks): Update.
3544         (ada_tasks_inferior_data_handle): Change type.
3545         (get_ada_tasks_inferior_data): Update.
3546         (ada_tasks_inferior_data_cleanup): Remove.
3547         (struct ada_tasks_pspace_data): Add initializers.
3548
3549 2019-05-08  Tom Tromey  <tom@tromey.com>
3550
3551         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3552         * symfile-debug.c (debug_sym_get_probes): Change type.
3553         * stap-probe.c (handle_stap_probe):
3554         (stap_static_probe_ops::get_probes): Change type.
3555         * probe.h (class static_probe_ops) <get_probes>: Change type.
3556         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3557         (parse_probes_in_pspace): Update.
3558         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3559         Update.
3560         (any_static_probe_ops::get_probes): Change type.
3561         * elfread.c (elfread_data): New typedef.
3562         (probe_key): Change type.
3563         (elf_get_probes): Likewise.  Update.
3564         (probe_key_free): Remove.
3565         (_initialize_elfread): Update.
3566         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3567         Change type.
3568         (dtrace_process_dof_probe, dtrace_process_dof)
3569         (dtrace_static_probe_ops::get_probe): Change type.
3570
3571 2019-05-08  Tom Tromey  <tom@tromey.com>
3572
3573         * xcoffread.c (struct xcoff_symfile_info): Rename from
3574         coff_symfile_info.  Add initializers.
3575         (xcoff_objfile_data_key): Move lower.  Change type.
3576         (XCOFF_DATA): Rewrite.
3577         (xcoff_free_info): Remove.
3578         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3579         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3580         (xcoff_initial_scan): Update.
3581
3582 2019-05-08  Tom Tromey  <tom@tromey.com>
3583
3584         * solib-svr4.c (struct svr4_info): Add initializers and
3585         destructor.
3586         <probes_table>: Now an htab_up.
3587         (solib_svr4_pspace_data): Change type.
3588         (free_probes_table): Simplify.
3589         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3590         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3591         (probes_table_remove_objfile_probes, register_solib_event_probe)
3592         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3593         (_initialize_svr4_solib): Update.
3594
3595 2019-05-08  Tom Tromey  <tom@tromey.com>
3596
3597         * remote.c (remote_pspace_data): Change type.
3598         (remote_pspace_data_cleanup): Remove.
3599         (get_remote_exec_file, set_pspace_remote_exec_file)
3600         (_initialize_remote): Update.
3601
3602 2019-05-08  Tom Tromey  <tom@tromey.com>
3603
3604         * breakpoint.c (breakpoint_objfile_key): Change type.
3605         (get_breakpoint_objfile_data): Update.
3606         (free_breakpoint_objfile_data): Remove.
3607         (_initialize_breakpoint): Update.
3608
3609 2019-05-08  Tom Tromey  <tom@tromey.com>
3610
3611         * linux-tdep.c (struct linux_info): Add initializers.
3612         (linux_inferior_data): Move.  Change type.
3613         (invalidate_linux_cache_inf): Update.
3614         (linux_inferior_data_cleanup): Remove.
3615         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * auxv.c (auxv_inferior_data): Move.  Change type.
3620         (auxv_inferior_data_cleanup): Remove.
3621         (invalidate_auxv_cache_inf): Rewrite.
3622         (get_auxv_inferior_data, _initialize_auxv): Update.
3623
3624 2019-05-08  Tom Tromey  <tom@tromey.com>
3625
3626         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3627         (symfile_debug_objfile_data_key): Change type.
3628         (symfile_debug_installed, debug_qf_has_symbols)
3629         (debug_qf_find_last_source_symtab)
3630         (debug_qf_forget_cached_source_info)
3631         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3632         (debug_qf_print_stats, debug_qf_dump)
3633         (debug_qf_expand_symtabs_for_function)
3634         (debug_qf_expand_all_symtabs)
3635         (debug_qf_expand_symtabs_with_fullname)
3636         (debug_qf_map_matching_symbols)
3637         (debug_qf_expand_symtabs_matching)
3638         (debug_qf_find_pc_sect_compunit_symtab)
3639         (debug_qf_map_symbol_filenames)
3640         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3641         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3642         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3643         (debug_sym_read_linetable, debug_sym_relocate): Update.
3644         (symfile_debug_free_objfile): Remove.
3645         (install_symfile_debug_logging, _initialize_symfile_debug):
3646         Update.
3647
3648 2019-05-08  Tom Tromey  <tom@tromey.com>
3649
3650         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3651         allocate_on_obstack.
3652         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3653         (get_dwarf2_per_objfile): Update.
3654         (set_dwarf2_per_objfile): Remove.
3655         (dwarf2_has_info, dwarf2_get_section_info): Update.
3656         (dwarf2_free_objfile): Remove.
3657         (_initialize_dwarf2_read): Update.
3658
3659 2019-05-08  Tom Tromey  <tom@tromey.com>
3660
3661         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3662         initializers.
3663         <unsupported_script_warning_printed,
3664         script_not_found_warning_printed>: Now bool.
3665         (auto_load_pspace_data): Change type.
3666         (~auto_load_pspace_info): Rename from
3667         auto_load_pspace_data_cleanup.
3668         (get_auto_load_pspace_data, init_loaded_scripts_info)
3669         (clear_section_scripts, maybe_print_unsupported_script_warning)
3670         (maybe_print_script_not_found_warning, _initialize_auto_load):
3671         Update.
3672
3673 2019-05-08  Tom Tromey  <tom@tromey.com>
3674
3675         * objfiles.c (objfile_pspace_info): Add destructor and
3676         initializers.
3677         (objfiles_pspace_data): Change type.
3678         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3679         (get_objfile_pspace_data): Update.
3680         (objfiles_bfd_data): Change type.
3681         (get_objfile_bfd_data): Update.
3682         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3683
3684 2019-05-08  Tom Tromey  <tom@tromey.com>
3685
3686         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3687         Change type.
3688         (get_catch_syscall_inferior_data): Update.
3689         (catch_syscall_inferior_data_cleanup): Remove.
3690         (_initialize_break_catch_syscall): Update.
3691
3692 2019-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * inflow.c (struct terminal_info): Add destructor and
3695         initializers.
3696         (inflow_inferior_data): Change type.
3697         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3698         (get_inflow_inferior_data, inflow_inferior_exit)
3699         (swap_terminal_info, _initialize_inflow): Update.
3700
3701 2019-05-08  Tom Tromey  <tom@tromey.com>
3702
3703         * target-dcache.c (target_dcache_cleanup): Remove.
3704         (target_dcache_aspace_key): Change type.
3705         (target_dcache_init_p, target_dcache_invalidate)
3706         (target_dcache_get, target_dcache_get_or_init)
3707         (_initialize_target_dcache): Update.
3708         * dcache.h (struct dcache_deleter): New.
3709
3710 2019-05-08  Tom Tromey  <tom@tromey.com>
3711
3712         * symtab.c (struct symbol_cache): Add destructor and
3713         initializers.
3714         (symbol_cache_key): Move.  Change type.
3715         (make_symbol_cache, free_symbol_cache): Remove.
3716         (get_symbol_cache): Update.
3717         (symbol_cache_cleanup): Remove.
3718         (ALL_PSPACES, symbol_cache_flush)
3719         (maintenance_print_symbol_cache)
3720         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3721         Update.
3722
3723 2019-05-08  Tom Tromey  <tom@tromey.com>
3724
3725         * symtab.c (struct main_info): Add destructor and initializers.
3726         (main_progspace_key): Move.  Change type.
3727         (get_main_info): Update.
3728         (main_info_cleanup): Remove.
3729         (_initialize_symtab): Update.
3730
3731 2019-05-08  Tom Tromey  <tom@tromey.com>
3732
3733         * registry.h (DECLARE_REGISTRY): Define the _key class.
3734
3735 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3736
3737         * NEWS: Merge two 'New commands' sections.
3738
3739 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3740
3741         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3742         parameter and use Ada language definition instead.
3743         (ada_val_print_ptr): Remove unused language parameter.
3744         (ada_val_print_num): Remove language parameter and use Ada language
3745         definition instead.
3746         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3747         parameter.
3748         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3749         parameter and use Ada language definition instead.
3750         (ada_val_print_1): Update all ada_val_print_xxx calls.
3751         Remove language parameter.
3752         (ada_val_print): Update ada_val_print_1 call.
3753
3754 2019-05-08  Tom Tromey  <tromey@adacore.com>
3755
3756         * remote.c (remote_hw_watchpoint_limit)
3757         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3758         Now static.
3759
3760 2019-05-08  Tom Tromey  <tromey@adacore.com>
3761
3762         * maint.c (_initialize_maint_cmds): Move initialization code to
3763         remote.c.
3764         (watchdog, show_watchdog): Move to remote.c.
3765         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3766         "watchdog" static.
3767         (_initialize_remote): Move initialization code from maint.c.
3768         * defs.h (watchdog): Don't declare.
3769
3770 2019-05-08  Tom Tromey  <tromey@adacore.com>
3771
3772         * tui/tui-interp.c: Include main.h.
3773         * interps.c: Include main.h.
3774         * main.h (interpreter_p): Declare.
3775         * defs.h (interpreter_p): Don't declare.
3776
3777 2019-05-08  Tom Tromey  <tromey@adacore.com>
3778
3779         * dwarf2loc.c: Include dwarf2read.h.
3780         * defs.h (read_unsigned_leb128): Don't declare.
3781         * dwarf2read.h (read_unsigned_leb128): Declare.
3782
3783 2019-05-08  Tom Tromey  <tromey@adacore.com>
3784
3785         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3786         method.
3787
3788 2019-05-08  Tom Tromey  <tromey@adacore.com>
3789
3790         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3791         when no wrap column is set.
3792
3793 2019-05-08  Tom Tromey  <tromey@adacore.com>
3794
3795         * c-lang.c (c_get_string): Handle non-C-style arrays.
3796
3797 2019-05-08  Tom Tromey  <tromey@adacore.com>
3798
3799         * typeprint.c (print_offset_data::update): Print the bit offset,
3800         not the number of bits remaining.
3801
3802 2019-05-08  Tom Tromey  <tromey@adacore.com>
3803
3804         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3805         padding at end of comment.
3806
3807 2019-05-08  Tom Tromey  <tromey@adacore.com>
3808
3809         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3810         Compare main types.
3811
3812 2019-05-06  Tom Tromey  <tom@tromey.com>
3813
3814         * common/scoped_mmap.c: Include common-defs.h.
3815         * common/scoped_mmap.h: Don't include config.h.
3816
3817 2019-05-04  Tom Tromey  <tom@tromey.com>
3818
3819         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3820         (struct aarch64_call_info): Add initializers.
3821         <si>: Now a std::vector.
3822         (pass_on_stack, aarch64_push_dummy_call): Update.
3823
3824 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3825             Tom Tromey  <tom@tromey.com>
3826
3827         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3828         (ppc_threads): Now a std::vector.  Now static.
3829         (hwdebug_find_thread_points_by_tid)
3830         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3831         Update.
3832
3833 2019-05-04  Tom Tromey  <tom@tromey.com>
3834
3835         * arc-tdep.c (arc_tdesc_init): Return bool.
3836
3837 2019-05-04  Tom Tromey  <tom@tromey.com>
3838
3839         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3840         Use gdb_assert_not_reached.
3841
3842 2019-05-04  Tom Tromey  <tom@tromey.com>
3843
3844         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3845         "false".
3846
3847 2019-05-04  Tom Tromey  <tom@tromey.com>
3848
3849         * arc-tdep.c (arc_tdesc_init): Use bool.
3850
3851 2019-05-04  Tom Tromey  <tom@tromey.com>
3852
3853         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3854
3855 2019-05-04  Tom Tromey  <tom@tromey.com>
3856
3857         * cli/cli-cmds.c (valid_command_p): Return bool.
3858
3859 2019-05-04  Tom Tromey  <tom@tromey.com>
3860
3861         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3862         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3863
3864 2019-05-04  Raul Tambre  <raul@tambre.ee>
3865
3866         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3867         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3868         operator for comparison.
3869
3870 2019-05-04  Tom Tromey  <tom@tromey.com>
3871
3872         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3873         (lookup_partial_symbol, print_partial_symbols)
3874         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3875         (psymbol_compare): Update.
3876         (add_psymbol_to_bcache): Clear the entire psymbol.
3877         (maintenance_check_psymtabs): Update.
3878         * psympriv.h (struct partial_symbol): Don't derive from
3879         general_symbol_info.
3880         <obj_section, unrelocated_address, address,
3881         set_unrelocated_address>: Update.
3882         <ginfo>: New member.
3883         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3884         (debug_names::write_psymbols): Update.
3885
3886 2019-05-04  Tom de Vries  <tdevries@suse.de>
3887
3888         * contrib/cc-with-tweaks.sh: Support -n arg.
3889
3890 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3891
3892         * corelow.c (core_target::detach): Ensure frame cache and
3893         register caches are cleared.
3894         inferior.c (exit_inferior_1): Likewise.
3895
3896 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3897             Tom Tromey  <tom@tromey.com>
3898
3899         * dictionary.c (collate_pending_symbols_by_language): Remove
3900         "struct" from foreach.
3901         * symtab.c (lookup_global_symbol_from_objfile)
3902         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3903         foreach.
3904         * ser-tcp.c (net_open): Remove "struct" from foreach.
3905         * objfiles.c (objfile_relocate, objfile_rebase)
3906         (objfile_has_symbols): Remove "struct" from foreach.
3907         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3908         from foreach.
3909         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3910         foreach.
3911         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3912         "struct" from foreach.
3913         * ada-lang.c (create_excep_cond_exprs)
3914         (ada_exception_catchpoint_cond_string): Remove "struct" from
3915         foreach.
3916
3917 2019-05-03  Tom Tromey  <tromey@adacore.com>
3918
3919         * ada-exp.y (convert_char_literal): Check suffix of each
3920         enumerator.
3921
3922 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3923
3924         PR ada/21406:
3925         * ada-exp.y (yywrap): Don't define.
3926         * ada-lex.l (%option): Add noyywrap
3927         (yywrap): Remove.
3928
3929 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3930
3931         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3932         _WIN32_WINNT to the XP level, unless already defined to a higher
3933         level.
3934
3935         * unittests/parse-connection-spec-selftests.c:
3936         * ser-tcp.c:
3937         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3938         override.
3939
3940         * symfile.c (find_separate_debug_file): Remove colon from the
3941         drive spec of DOS/Windows file names of the target, so that the
3942         file name produced from DEBUGDIR and the target's directory will
3943         be valid on DOS/Windows systems.
3944
3945 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * rust-lang.c (val_print_struct): Handle printing structures
3948         containing strings.
3949
3950 2019-05-02  Tom Tromey  <tromey@adacore.com>
3951
3952         * valarith.c (_initialize_valarith): Remove.
3953
3954 2019-05-01  Tom Tromey  <tromey@adacore.com>
3955
3956         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3957         bitfields.
3958
3959 2019-05-01  Tom Tromey  <tromey@adacore.com>
3960
3961         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3962         for big-endian copies.
3963
3964 2019-04-30  Ali Tamur  <tamur@google.com>
3965         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3966         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3967         (read_3_bytes): New function.
3968
3969 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3970
3971         * windows-nat.c (main_thread_id): Delete.
3972         (handle_output_debug_string): Replace main_thread_id by
3973         current_event.dwThreadId.
3974         (fake_create_process): Likewise.
3975         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3976         Do not set main_thread_id.
3977         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3978         current_event.dwThreadId.
3979         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3980
3981 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3982
3983         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3984         Use current_event.dwThreadId instead of main_thread_id.
3985
3986 2019-04-30  Tom Tromey  <tromey@adacore.com>
3987
3988         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3989         (create_excep_cond_exprs): Iterate over program spaces.
3990         (ada_exception_catchpoint_cond_string): Examine all minimal
3991         symbols for exception types.
3992
3993 2019-04-30  Tom Tromey  <tromey@adacore.com>
3994
3995         PR c++/24470:
3996         * dwarf2read.c (process_structure_scope): Handle case where type
3997         has template parameters but no symbol was created.
3998
3999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4000             Chris January  <chris.january@arm.com>
4001
4002         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4003         qualifier.
4004         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4005
4006 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4007
4008         * f-typeprint.c (f_print_type): Update rules for printing
4009         whitespace.
4010         (f_type_print_varspec_suffix): Likewise.
4011
4012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4013             Chris January  <chris.january@arm.com>
4014
4015         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4016         function arguments.
4017
4018 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4019
4020         * f-lang.c (build_fortran_types): Change name of void type to
4021         lower case.
4022         * f-typeprint.c (f_type_print_base): Print the name of the void
4023         type, rather than a fixed string.
4024         * f-valprint.c (f_decorations): Use lower case void string.
4025
4026 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4027             Chris January  <chris.january@arm.com>
4028
4029         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4030         types for Fortran.
4031
4032 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4033             Chris January  <chris.january@arm.com>
4034             David Lecomber  <david.lecomber@arm.com>
4035
4036         * f-exp.y (BINOP_INTRINSIC): New token.
4037         (exp): New parser rule handling BINOP_INTRINSIC.
4038         (f77_keywords): Add new builtin procedures.
4039         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4040         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4041         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4042         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4043         (print_unop_subexp_f): New function.
4044         (print_binop_subexp_f): New function.
4045         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4046         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4047         (dump_subexp_body_f): Likewise.
4048         (operator_check_f): Likewise.
4049         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4050         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4051
4052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4055         UNOP_KIND.
4056         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4057         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4058         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4059         (operator_length_f): New fuction.
4060         (print_subexp_f): New function.
4061         (op_name_f): New function.
4062         (dump_subexp_body_f): New function.
4063         (operator_check_f): New function.
4064         (exp_descriptor_f): Replace standard expression handling functions
4065         with new functions.
4066         * gdb/fortran-operator.def: New file.
4067         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4068         * gdb/std-operator.def: Remove UNOP_KIND.
4069
4070 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * std-operator.def: Remove unbalanced, stray double quote
4073         character.
4074
4075 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4076             Chris January  <chris.january@arm.com>
4077             Daniel Everett  <daniel.everett@arm.com>
4078             Nick Forrington  <nick.forrington@arm.com>
4079             Richard Bunt  <richard.bunt@arm.com>
4080
4081         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4082         of depth when printing anonymous structs or unions.
4083         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4084         Don't print either the top-level value, or the children if the
4085         max-depth is exceeded.
4086         (ppscm_print_children): When printing the key of a map, allow one
4087         extra level of depth.
4088         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4089         print either the top-level value, or the children if the max-depth
4090         is exceeded.
4091         (print_children): When printing the key of a map, allow one extra
4092         level of depth.
4093         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4094         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4095         (user_print_options): Initialise max_depth field.
4096         (val_print_scalar_or_string_type_p): New function.
4097         (val_print): Check to see if the max depth has been reached.
4098         (val_print_check_max_depth): Define new function.
4099         (show_print_max_depth): New function.
4100         (_initialize_valprint): Add 'print max-depth' option.
4101         * valprint.h (struct value_print_options) <max_depth>: New field.
4102         (val_print_check_max_depth): Declare new function.
4103         * NEWS: Document new feature.
4104
4105 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * ada-lang.c (ada_language_defn): Initialise new field.
4108         * c-lang.c (c_is_string_type_p): New function.
4109         (c_language_defn): Initialise new field.
4110         (cplus_language_defn): Initialise new field.
4111         (asm_language_defn): Initialise new field.
4112         (minimal_language_defn): Initialise new field.
4113         * c-lang.h (c_is_string_type_p): Declare new function.
4114         * d-lang.c (d_language_defn): Initialise new field.
4115         * f-lang.c (f_is_string_type_p): New function.
4116         (f_language_defn): Initialise new field.
4117         * go-lang.c (go_is_string_type_p): New function.
4118         (go_language_defn): Initialise new field.
4119         * language.c (default_is_string_type_p): New function.
4120         (unknown_language_defn): Initialise new field.
4121         (auto_language_defn): Initialise new field.
4122         * language.h (struct language_defn) <la_is_string_type_p>: New
4123         member variable.
4124         (default_is_string_type_p): Declare new function.
4125         * m2-lang.c (m2_language_defn): Initialise new field.
4126         * objc-lang.c (objc_language_defn): Initialise new field.
4127         * opencl-lang.c (opencl_language_defn): Initialise new field.
4128         * p-lang.c (pascal_is_string_type_p): New function.
4129         (pascal_language_defn): Initialise new field.
4130         * rust-lang.c (rust_is_string_type_p): New function.
4131         (rust_language_defn): Initialise new field.
4132
4133 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4136         New field.
4137         * ada-lang.c (ada_language_defn): Initialise new field.
4138         * c-lang.c (c_language_defn): Likewise.
4139         (cplus_language_defn): Likewise.
4140         (asm_language_defn): Likewise.
4141         (minimal_language_defn): Likewise.
4142         * d-lang.c (d_language_defn): Likewise.
4143         * f-lang.c (f_language_defn): Likewise.
4144         * go-lang.c (go_language_defn): Likewise.
4145         * language.c (unknown_language_defn): Likewise.
4146         (auto_language_defn): Likewise.
4147         * m2-lang.c (m2_language_defn): Likewise.
4148         * objc-lang.c (objc_language_defn): Likewise.
4149         * opencl-lang.c (opencl_language_defn): Likewise.
4150         * p-lang.c (pascal_language_defn): Likewise.
4151         * rust-lang.c (rust_language_defn): Likewise.
4152
4153 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * ada-lang.c (ada_is_character_type): Change return type to bool.
4156         (ada_is_string_type): Likewise.
4157         * ada-lang.h (ada_is_character_type): Update declaration
4158         (ada_is_string_type): Likewise.
4159
4160 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4161
4162         Support style in 'frame|thread apply'
4163
4164         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4165         * record.c (record_start, record_stop): Update callers of
4166         execute_command_to_string with false.
4167         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4168         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4169         methods.
4170         (class string_file): New constructor with term_out parameter.
4171         Override methods term_out and can_emit_style_escape.  New member
4172         term_out.
4173         (class stdio_file): Override can_emit_style_escape.
4174         (class tee_file): Override term_out and can_emit_style_escape.
4175         * utils.h (can_emit_style_escape): Remove.
4176         * utils.c (can_emit_style_escape): Likewise.
4177         Update all callers of can_emit_style_escape (SOMESTREAM) to
4178         SOMESTREAM->can_emit_style_escape.
4179         * source-cache.c (source_cache::get_source_lines): Likewise.
4180         * stack.c (frame_apply_command_count): Call execute_command_to_string
4181         passing the term_out characteristic of the current gdb_stdout.
4182         * thread.c (thr_try_catch_cmd): Likewise.
4183         * top.c (execute_command_to_string): pass term_out parameter
4184         to construct the string_file for the command output.
4185         * ui-file.c (term_cli_styling): New function (most code moved
4186         from utils.c can_emit_style_escape).
4187         (string_file::string_file, string_file::can_emit_style_escape,
4188         stdio_file::can_emit_style_escape, tee_file::term_out,
4189         tee_file::can_emit_style_escape): New functions.
4190
4191 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4192
4193         * NEWS: Mention the new set|show may-call-functions.
4194         * infcall.c (may_call_functions_p): New variable.
4195         (show_may_call_functions_p): New function.
4196         (call_function_by_hand_dummy): Throws an error if not
4197         may-call-functions.
4198         (_initialize_infcall): Call add_setshow_boolean_cmd for
4199         may-call-functions.
4200
4201 2019-04-25  Keith Seitz  <keiths@redhat.com>
4202
4203         PR c++/24367
4204         * cp-support.c (inspect_type): Don't attempt substitutions
4205         of symbol with the same name.
4206
4207 2019-04-25  Tom Tromey  <tromey@adacore.com>
4208
4209         PR gdb/24475:
4210         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4211         static.
4212
4213 2019-04-25  Tom Tromey  <tromey@adacore.com>
4214
4215         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4216         rvalue reference.
4217         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4218         (gdb_xml_parser::parse): Use std::move.
4219         * python/python-internal.h (gdbpy_convert_exception): Take a const
4220         reference.
4221         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4222         std::move.
4223         * python/py-utils.c (gdbpy_convert_exception): Take a const
4224         reference.
4225         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4226         Use std::move.
4227         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4228         Use std::move.
4229         * mi/mi-main.c (mi_print_exception): Take a const reference.
4230         * main.c (handle_command_errors): Take a const reference.
4231         * linespec.c (parse_linespec): Use std::move.
4232         * infcall.c (run_inferior_call): Use std::move.
4233         (call_function_by_hand_dummy): Use std::move.
4234         * exec.c (try_open_exec_file): Use std::move.
4235         * exceptions.h (exception_print, exception_fprintf)
4236         (exception_print_same): Update.
4237         * exceptions.c (print_exception, exception_print)
4238         (exception_fprintf, exception_print_same): Change parameters to
4239         const reference.
4240         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4241         * common/new-op.c: Use std::move.
4242         * common/common-exceptions.h (struct gdb_exception): Add move
4243         constructor.
4244         (struct gdb_exception_error, struct gdb_exception_quit, struct
4245         gdb_quit_bad_alloc): Change constructor to move constructor.
4246         (throw_exception): Change parameter to rvalue reference.
4247         * common/common-exceptions.c (throw_exception): Take rvalue
4248         reference.
4249         * cli/cli-interp.c (safe_execute_command): Use std::move.
4250         * breakpoint.c (insert_bp_location, location_to_sals): Use
4251         std::move.
4252
4253 2019-04-25  Tom Tromey  <tromey@adacore.com>
4254
4255         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4256         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4257         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4258         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4259         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4260         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4261         guile/scm-value.c: Use unpack.
4262         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4263         gdbscm_gdb_exception.
4264         (gdbscm_throw_gdb_exception): Likewise.
4265         (struct gdbscm_gdb_exception): New.
4266         (unpack): New function.
4267         (gdbscm_wrap): Use unpack.
4268
4269 2019-04-25  Tom Tromey  <tromey@adacore.com>
4270
4271         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4272         (gdb_rl_callback_handler): Use std::move.
4273         * common/common-exceptions.h (struct gdb_exception): Add move
4274         assignment operator.
4275         (throw_exception_sjlj): Change "exception" to const reference.
4276         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4277         (throw_exception_sjlj): Change "exception" to const reference.
4278
4279 2019-04-25  Tom Tromey  <tromey@adacore.com>
4280
4281         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4282         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4283         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4284         Update.
4285         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4286         Update.
4287         * mi/mi-interp.c (mi_interp::exec): Update.
4288         * linespec.c (parse_linespec): Update.
4289         * infcall.c (run_inferior_call): Update.
4290         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4291         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4292         (gdbscm_lookup_global_symbol): Update.
4293         * guile/scm-param.c (gdbscm_parameter_value): Update.
4294         * guile/scm-frame.c (gdbscm_frame_read_register)
4295         (gdbscm_frame_read_var): Update.
4296         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4297         * exec.c (try_open_exec_file): Update.
4298         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4299         (gdb_rl_callback_handler): Update.
4300         * common/common-exceptions.h (exception_none): Don't declare.
4301         * common/common-exceptions.c (exception_none): Don't define.
4302         (struct catcher) <exception>: Update.
4303         * cli/cli-interp.c (safe_execute_command): Update.
4304         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4305
4306 2019-04-25  Ali Tamur  <tamur@google.com>
4307
4308         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4309         (read_attribute_value): Likewise.
4310         (dwarf2_read_addr_index): Update comment.
4311         (read_str_index): Add DW_FORM_strx.
4312         (dwarf2_string_attr): Likewise.
4313         (dwarf2_const_value_attr): Likewise.
4314         (dump_die_shallow): Likewise.
4315         (dwarf2_fetch_constant_bytes): Likewise.
4316         (skip_form_bytes): Likewise.
4317         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4318
4319 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4320
4321         PR corefiles/11608
4322         PR corefiles/18187
4323         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4324         OFFSET.  Verify if current mapping contains an ELF header.
4325         (linux_find_memory_regions_full): Adjust call to
4326         dump_mapping_p.
4327
4328 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4329             Kang Li <kanglictf@gmail.com>
4330
4331         PR gdb/21600
4332
4333         * dwarf2-frame.c (read_initial_length): Be consistent about using
4334         unsigned representation of length.
4335         (decode_frame_entry_1): Likewise.  Check for wraparound of
4336         end pointer as well as buffer overflow.
4337
4338 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4339
4340         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4341         "vq".
4342
4343 2019-04-24  Tom Tromey  <tromey@adacore.com>
4344
4345         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * s12z-tdep.c (s12z_unwind_pc): Delete.
4350         (s12z_unwind_sp): Delete.
4351         (s12z_gdbarch_init): Don't register deleted functions with
4352         gdbarch.
4353
4354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * rl78-tdep.c (rl78_unwind_sp): Delete.
4357         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4358
4359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4362         (xstormy16_unwind_pc): Delete.
4363         (xstormy16_dummy_id): Delete.
4364         (xstormy16_gdbarch_init): Don't register deleted functions with
4365         gdbarch.
4366
4367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * vax-tdep.c (vax_unwind_pc): Delete.
4370         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4371
4372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         * v850-tdep.c (v850_unwind_sp): Delete.
4375         (v850_unwind_pc): Delete.
4376         (v850_dummy_id): Delete.
4377         (v850_gdbarch_init): Don't register deleted functions with
4378         gdbarch.
4379
4380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4381
4382         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4383         (tilegx_unwind_pc): Delete.
4384         (tilegx_unwind_dummy_id): Delete.
4385         (tilegx_gdbarch_init): Don't register deleted functions with
4386         gdbarch.
4387
4388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4391         (tic6x_dummy_id): Delete.
4392         (tic6x_gdbarch_init): Don't register deleted functions with
4393         gdbarch.
4394
4395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4396
4397         * sparc-tdep.c (sparc_unwind_pc): Delete.
4398         (sparc32_gdbarch_init): Don't register deleted function with
4399         gdbarch.
4400
4401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * sh-tdep.c (sh_unwind_sp): Delete.
4404         (sh_unwind_pc): Delete.
4405         (sh_dummy_id): Delete.
4406         (sh_gdbarch_init): Don't register deleted functions with
4407         gdbarch.
4408
4409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * score-tdep.c (score_unwind_sp): Delete.
4412         (score_unwind_pc): Delete.
4413         (score_dummy_id): Delete.
4414         (score_gdbarch_init): Don't register deleted functions with
4415         gdbarch.
4416
4417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * rx-tdep.c (rx_unwind_pc): Delete.
4420         (rx_unwind_sp): Delete.
4421         (rx_dummy_id): Delete.
4422         (rx_gdbarch_init): Don't register deleted functions with
4423         gdbarch.  Update comment.
4424
4425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4426
4427         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4428         (rs6000_dummy_id): Delete.
4429         (rs6000_gdbarch_init): Don't register deleted functions with
4430         gdbarch.
4431
4432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * or1k-tdep.c (or1k_dummy_id): Delete.
4435         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4436
4437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * nios2-tdep.c (nios2_dummy_id): Delete.
4440         (nios2_unwind_sp): Delete.
4441         (nios2_gdbarch_init): Don't register deleted functions with
4442         gdbarch.
4443
4444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4445
4446         * nds32-tdep.c (nds32_dummy_id): Delete.
4447         (nds32_unwind_pc): Delete.
4448         (nds32_unwind_sp): Delete.
4449         (nds32_gdbarch_init): Don't register deleted functions with
4450         gdbarch.
4451
4452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4453
4454         * msp430-tdep.c (msp430_unwind_pc): Delete.
4455         (msp430_unwind_sp): Delete.
4456         (msp430_dummy_id): Delete.
4457         (msp430_gdbarch_init): Don't register deleted functions with
4458         gdbarch.
4459
4460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4461
4462         * moxie-tdep.c (moxie_unwind_sp): Delete.
4463         (moxie_unwind_pc): Delete.
4464         (moxie_dummy_id): Delete.
4465         (moxie_gdbarch_init): Don't register deleted functions with
4466         gdbarch.
4467
4468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4471         (mn10300_unwind_pc): Delete.
4472         (mn10300_unwind_sp): Delete.
4473         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4474         mn10300_unwind_sp.
4475         (mn10300_frame_unwind_init): Don't register deleted functions with
4476         gdbarch.
4477
4478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * mep-tdep.c (mep_unwind_pc): Delete.
4481         (mep_unwind_sp): Delete.
4482         (mep_dummy_id): Delete.
4483         (mep_gdbarch_init): Don't register deleted functions with
4484         gdbarch.
4485
4486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4489         (m68hc11_unwind_sp): Delete.
4490         (m68hc11_gdbarch_init): Don't register deleted functions with
4491         gdbarch.
4492
4493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * m32r-tdep.c (m32r_unwind_sp): Delete.
4496         (m32r_unwind_pc): Delete.
4497         (m32r_dummy_id): Delete.
4498         (m32r_gdbarch_init): Don't register deleted functions with
4499         gdbarch.
4500
4501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * m32c-tdep.c (m32c_unwind_pc): Delete.
4504         (m32c_unwind_sp): Delete.
4505         (m32c_dummy_id): Delete.
4506         (m32c_gdbarch_init): Don't register deleted functions with
4507         gdbarch.
4508
4509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4512         (lm32_unwind_pc): Delete.
4513         (lm32_dummy_id): Delete.
4514         (lm32_gdbarch_init): Don't register deleted functions with
4515         gdbarch.
4516
4517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4520         (iq2000_unwind_pc): Delete.
4521         (iq2000_dummy_id): Delete.
4522         (iq2000_gdbarch_init): Don't register deleted functions with
4523         gdbarch.
4524
4525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * nds32-tdep.c (nds32_type_align): Delete.
4528         (nds32_push_dummy_call): Use type_align instead.
4529
4530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * arm-tdep.c (arm_type_align): Only handle vector override case.
4533         (arm_push_dummy_call): Use type_align.
4534         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4535
4536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4539         case.
4540         (pass_on_stack): Use type_align.
4541         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4542         function.
4543
4544 2019-04-23  Tom Tromey  <tromey@adacore.com>
4545
4546         * dwarf2read.c (line_header::file_name_at): Remove unused
4547         overload.
4548
4549 2019-04-23  Tom de Vries  <tdevries@suse.de>
4550
4551         PR gdb/24438
4552         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4553         invocation.
4554
4555
4556 2019-03-27  Ali Tamur  <tamur@google.com>
4557
4558         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4559         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4560         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4561         (dwarf_expr_context::get_addr_index): Likewise
4562         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4563         (symbol_needs_eval_context::get_addr_index): Likewise
4564         (disassemble_dwarf_expression): Add DW_OP_addrx
4565         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4566         (read_cutu_die_from_dwo): Update comment
4567         (skip_one_die): Add DW_FORM_addrx
4568         (read_attribute_value): Likewise
4569         (var_decode_location): Add DW_OP_addrx
4570         (dwarf2_const_value_attr): Add DW_FORM_addrx
4571         (dump_die_shallow): Likewise
4572         (dwarf2_fetch_constant_bytes): Likewise
4573         (decode_locdesc): Add DW_OP_addrx
4574         (skip_form_bytes): Add DW_FORM_addrx
4575
4576 2019-04-22  Ali Tamur  <tamur@google.com>
4577
4578         * MAINTAINERS (Write After Approval): Add self.
4579
4580 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4581
4582         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4583         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4584         (open_symbol_file_object): Likewise.
4585         (svr4_default_sos): Add info parameter.
4586         (svr4_read_so_list): Likewise.
4587         (svr4_current_sos_direct): Adjust functions calls to pass down
4588         info.
4589         (svr4_current_sos_1): Add info parameter.
4590         (svr4_current_sos): Call get_svr4_info, pass info down to
4591         svr4_current_sos_1.
4592         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4593         get_svr4_info.
4594         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4595         get_svr4_info.
4596         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4597         to get_svr4_info.
4598         (probes_table_remove_objfile_probes): Likewise.
4599         (register_solib_event_probe): Add info parameter.
4600         (solist_update_incremental): Pass info parameter down to
4601         svr4_read_so_list.
4602         (disable_probes_interface): Add info parameter.
4603         (svr4_handle_solib_event): Pass current_program_space to
4604         get_svr4_info.  Adjust disable_probes_interface cleanup.
4605         (svr4_create_probe_breakpoints): Add info parameter, pass it
4606         down to register_solib_event_probe.
4607         (svr4_create_solib_event_breakpoints): Add info parameter,
4608         pass it down to svr4_create_probe_breakpoints.
4609         (enable_break): Pass info down to
4610         svr4_create_solib_event_breakpoints.
4611         (svr4_solib_create_inferior_hook): Pass current_program_space to
4612         get_svr4_info.
4613         (svr4_clear_solib): Likewise.
4614
4615 2019-04-22  Pedro Alves  <palves@redhat.com>
4616
4617         * solib-svr4.c (svr4_free_objfile_observer): New.
4618         (probe_and_action::objfile): New field.
4619         (probes_table_htab_remove_objfile_probes)
4620         (probes_table_remove_objfile_probes): New functions.
4621         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4622         in the new probe_and_action.  Don't store the probe in 'lookup'.
4623         (svr4_create_probe_breakpoints): Pass objfile to
4624         register_solib_event_probe.
4625         (_initialize_svr4_solib): Register a free_objfile observer.
4626
4627 2019-04-19  Tom Tromey  <tom@tromey.com>
4628
4629         * common/queue.h: Remove.
4630
4631 2019-04-19  Tom Tromey  <tom@tromey.com>
4632
4633         * event-loop.c: Don't include "common/queue.h".
4634
4635 2019-04-19  Tom Tromey  <tom@tromey.com>
4636
4637         * remote.c (remote_target): Use delete.
4638         * remote-notif.h: Include <list>, not "common/queue.h".
4639         (notif_client_p): Remove typedef.
4640         (remote_notif_state): Add constructor, destructor, initializer.
4641         <notif_queue>: Now a std::list.
4642         (remote_notif_state_xfree): Don't declare.
4643         * remote-notif.c (remote_notif_process, handle_notification)
4644         (remote_notif_state_allocate): Update.
4645         (~remote_notif_state): Rename from remote_notif_state_xfree.
4646
4647 2019-04-19  Tom Tromey  <tom@tromey.com>
4648
4649         * symfile.c (reread_symbols): Update.
4650         * objfiles.c (objfile_register_static_link)
4651         (objfile_lookup_static_link): Update
4652         (~objfile) Don't delete static_links.
4653         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4654
4655 2019-04-19  Tom Tromey  <tom@tromey.com>
4656
4657         * type-stack.h (struct type_stack) <insert>: Constify string.
4658         * type-stack.c (type_stack::insert): Constify string.
4659         * gdbtypes.h (lookup_template_type): Update.
4660         (address_space_name_to_int): Update.
4661         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4662         const.
4663         (lookup_template_type): Make name const.
4664         * c-exp.y: Update rules.
4665         (lex_one_token, classify_name, classify_inner_name)
4666         (c_print_token): Update.
4667         * p-exp.y: Update rules.
4668         (yylex): Update.
4669         * f-exp.y: Update rules.
4670         (yylex): Update.
4671         * d-exp.y: Update rules.
4672         (lex_one_token, classify_name, classify_inner_name): Update.
4673         * parse.c (write_dollar_variable, copy_name): Return std::string.
4674         * parser-defs.h (copy_name): Change return type.
4675         * m2-exp.y: Update rules.
4676         (yylex): Update.
4677         * go-exp.y (lex_one_token): Update.
4678         Update rules.
4679         (classify_unsafe_function, classify_packaged_name)
4680         (classify_name, yylex): Update.
4681
4682 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4683
4684         * configure.ac: add --enable-source-highlight switch.
4685         * configure: Regenerate.
4686         * top.c (print_gdb_version): plumb --enable-source-highlight
4687         status to "show configuration".
4688
4689 2019-04-19  Tom Tromey  <tromey@adacore.com>
4690
4691         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4692         Check ADA_TYPE_P.
4693         (empty_record, ada_template_to_fixed_record_type_1)
4694         (template_to_static_fixed_type)
4695         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4696         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4697         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4698         macros.
4699
4700 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4701
4702         PR symtab/24423:
4703         * source.c (print_source_lines_base): Advance "iter" when a
4704         control character is seen.
4705
4706 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4707
4708         * inferior.h (struct infcall_suspend_state_deleter):
4709         Catch exception in destructor to avoid crash.
4710
4711 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4712
4713         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4714         close to the add_com "shell".
4715
4716 2019-04-18  Tom Tromey  <tromey@adacore.com>
4717
4718         * process-stratum-target.h (class process_stratum_target)
4719         <stratum>: Add "final".
4720
4721 2019-04-17  Tom Tromey  <tromey@adacore.com>
4722
4723         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4724         against nullptr before use.
4725
4726 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4727
4728         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4729
4730 2019-04-17  Jim Wilson  <jimw@sifive.com>
4731             Andrew Burgess  <andrew.burgess@embecosm.com>
4732
4733         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4734         code read might fail, assume 4-byte breakpoint in that case.
4735
4736 2019-04-15  Leszek Swirski  <leszeks@google.com>
4737
4738         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4739         rather than a hand-rolled POD check when checking for forced MEMORY
4740         classification.
4741
4742 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4743
4744         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4745         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4746         function.
4747         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4748         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4749         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4750         declaration.
4751
4752 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4753
4754         * aarch64-linux-nat.c
4755         (aarch64_linux_nat_target::thread_architecture): Add override.
4756         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4757         each VQ.
4758
4759 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4760
4761         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4762
4763 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4766         target types of size 96-bits, add some additional comments, and
4767         check that the builtin type we found was the correct size.
4768
4769 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4770
4771         * utils.c (prompt_for_continue): Don't restore the styling at the
4772         end, as applied_style has the wrong value.  This fixes styling in
4773         long lists of file names that are interrupted by the "Continue?"
4774         prompt.
4775
4776 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4777
4778         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4779         * c-lang.c (c_language_defn): Likewise.
4780         (cplus_language_defn): Likewise.
4781         (asm_language_defn): Likewise.
4782         (minimal_language_defn): Likewise.
4783         * d-lang.c (d_language_defn): Likewise.
4784         * f-lang.c (f_language_defn): Likewise.
4785         * go-lang.c (go_language_defn): Likewise.
4786         * language.c (unknown_language_defn): Likewise.
4787         (auto_language_defn): Likewise.
4788         * language.h (struct language_defn): Remove la_magic field.
4789         (LANG_MAGIC): Delete.
4790         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4791         * objc-lang.c (objc_language_defn): Likewise.
4792         * opencl-lang.c (opencl_language_defn): Likewise.
4793         * p-lang.c (pascal_language_defn): Likewise.
4794         * rust-lang.c (rust_language_defn): Likewise.
4795
4796 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * riscv-tdep.c (riscv_type_align): New function.
4799         (riscv_type_alignment): Delete.
4800         (riscv_arg_location): Use 'type_align'.
4801         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4802
4803 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * gdbtypes.c (type_align): A struct with no non-static fields also
4806         has alignment of 1.
4807
4808 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4811         component to 0.
4812         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4813         member.
4814         (riscv_struct_info::analyse): New implementation using new
4815         analyse_inner member function.
4816         (riscv_struct_info::field_offset): New member function.
4817         (riscv_struct_info::m_offsets): New member variable.
4818         (riscv_struct_info::analyse_inner): New private member function,
4819         takes the old implementation of riscv_struct_info::analyse but
4820         extended to track field offsets.
4821         (riscv_call_arg_struct): Update the struct folding special cases
4822         to handle cases where empty C++ structs, which are non-zero
4823         length, are found.
4824         (riscv_arg_location): Initialise the length of each location, a
4825         non-zero length now indicates the location is in use.
4826         (riscv_push_dummy_call): Allow for the first location having a
4827         non-zero offset when setting up arguments.
4828         (riscv_return_value): Likewise, but for return values.
4829
4830 2019-04-11  Tom Tromey  <tromey@adacore.com>
4831
4832         * utils.c (internal_vproblem): Make "msg" const.
4833
4834 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4835
4836         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4837         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4838         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4839         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4840
4841 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4842
4843         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4844         function.
4845         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4846         of amd64_collect_native_gregset.
4847         (amd64_linux_nat_target::store_registers): Likewise.
4848
4849 2019-04-10  Tom Tromey  <tom@tromey.com>
4850
4851         * symtab.c (lookup_global_symbol_from_objfile)
4852         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4853         * objfiles.h (class separate_debug_iterator): New.
4854         (class separate_debug_range): New.
4855         (struct objfile) <separate_debug_objfiles>: New method.
4856         (objfile_separate_debug_iterate): Don't declare.
4857         * objfiles.c (separate_debug_iterator::operator++): Rename from
4858         objfile_separate_debug_iterate.
4859         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4860         iterator.
4861         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4862         iterator.
4863
4864 2019-04-10  Tom Tromey  <tom@tromey.com>
4865
4866         * symfile.c (reread_symbols): Remove old comment.
4867         * objfiles.c (free_all_objfiles): Fix a typo.
4868
4869 2019-04-10  Tom Tromey  <tom@tromey.com>
4870
4871         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4872         * minsyms.c (lookup_minimal_symbol): Use foreach.
4873         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4874         (lookup_minimal_symbol_solib_trampoline): Likewise.
4875         * symfile.c (reread_symbols): Use foreach.
4876
4877 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4878             Tom Tromey  <tromey@adacore.com>
4879
4880         PR rust/24414:
4881         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4882         (rust_lex_int_test): Change "value" to be LONGEST.
4883         (rust_lex_tests): Add test for long integer literal.
4884
4885 2019-04-09  Tom Tromey  <tromey@adacore.com>
4886
4887         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4888         to bool.
4889         (extended_remote_target::attach): Update.
4890         (remote_target::remote_notice_new_inferior): Update.
4891         (remote_target::add_current_inferior_and_thread): Update.
4892         * inferior.c (exit_inferior_1): Use "false".
4893         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4894
4895 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4896
4897         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4898         the "start" command.
4899
4900 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4901
4902         * python/py-inferior.c (infpy_thread_from_thread_handle):
4903         Adjust comments to reflect renaming of thread_from_thread_handle
4904         to thread_from_handle.  Adjust keywords.  Fix type error message.
4905         (inferior_object_methods): Add thread_from_handle.  Retain
4906         thread_from_thread_handle, but mark it as deprecated.
4907
4908 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4909
4910         * gdbthread.h (find_thread_by_handle): Revise declaration.
4911         * thread.c (find_thread_by_handle): Likewise.  Adjust
4912         implementation too.
4913         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4914         support for buffer objects as handles.
4915
4916 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4917
4918         * python/py-infthread.c (thpy_thread_handle): New function.
4919         (thread_object_methods): Register thpy_thread_handle.
4920
4921 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4922
4923         * gdbthread.h (thread_to_thread_handle): Declare.
4924         * thread.c (gdbtypes.h): Include.
4925         (thread_to_thread_handle): New function.
4926
4927         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4928         (target_thread_info_to_thread_handle): Declare.
4929         * target.c (target_thread_info_to_thread_handle): New function.
4930         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4931         * target-delegates.c: Regenerate.
4932
4933         * linux-thread-db.c (class thread_db_target): Add method
4934         thread_info_to_thread_handle.
4935         (thread_db_target::thread_info_to_thread_handle): Define.
4936         * remote.c (class remote_target): Add new method
4937         thread_info_to_thread_handle.
4938         (remote_target::thread_info_to_thread_handle): Define.
4939
4940 2019-04-08  Pedro Alves  <palves@redhat.com>
4941
4942         * common/common-exceptions.c (throw_exception): Don't create
4943         named object to throw; throw directly.
4944         (throw_it): Likewise.  Don't initialize gdb_exception::message
4945         here, with new; pass FMT and AP to the ctor instead.
4946         * common/common-exceptions.h: Include <string>.
4947         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4948         const char *, va_list)): New ctor.  Use std::make_shared.
4949         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4950         errors)): Delete.
4951         (gdb_exception_error::gdb_exception_error(enum errors, const char
4952         *, va_list)): New.
4953         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4954         Add assertion.
4955         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4956         errors)): Delete.
4957         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4958         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4959         Add assertion.
4960
4961 2019-04-08  Tom Tromey  <tom@tromey.com>
4962
4963         * valops.c (value_rtti_indirect_type): Replace throw_exception
4964         with throw.
4965         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4966         with throw.
4967         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4968         throw.
4969         * target.c (target_translate_tls_address): Replace throw_exception
4970         with throw.
4971         * stack.c (frame_apply_command_count): Replace throw_exception
4972         with throw.
4973         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4974         throw.
4975         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4976         with throw.
4977         * rs6000-tdep.c (rs6000_frame_cache)
4978         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4979         * remote.c: Replace throw_exception with throw.
4980         * record-full.c (record_full_message, record_full_wait_1)
4981         (record_full_restore): Replace throw_exception with throw.
4982         * record-btrace.c:
4983         (get_thread_current_frame_id, record_btrace_start_replaying)
4984         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4985         (cmd_record_btrace_start): Replace throw_exception with throw.
4986         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4987         throw.
4988         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4989         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4990         * linespec.c:
4991         (find_linespec_symbols): Replace throw_exception with throw.
4992         * infrun.c (displaced_step_prepare, resume): Replace
4993         throw_exception with throw.
4994         * infcmd.c (post_create_inferior): Replace throw_exception with
4995         throw.
4996         * inf-loop.c (inferior_event_handler): Replace throw_exception
4997         with throw.
4998         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4999         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5000         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5001         (get_prev_frame_always, get_frame_pc_if_available)
5002         (get_frame_address_in_block_if_available, get_frame_language):
5003         Replace throw_exception with throw.
5004         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5005         throw_exception with throw.
5006         * eval.c (fetch_subexp_value, evaluate_var_value)
5007         (evaluate_funcall, evaluate_subexp_standard): Replace
5008         throw_exception with throw.
5009         * dwarf2loc.c (call_site_find_chain)
5010         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5011         Replace throw_exception with throw.
5012         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5013         with throw.
5014         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5015         throw.
5016         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5017         * completer.c (complete_line_internal): Replace throw_exception
5018         with throw.
5019         * compile/compile-object-run.c (compile_object_run): Replace
5020         throw_exception with throw.
5021         * cli/cli-script.c (process_next_line): Replace throw_exception
5022         with throw.
5023         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5024         (btrace_enable, btrace_maint_update_pt_packets): Replace
5025         throw_exception with throw.
5026         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5027         throw_exception with throw.
5028         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5029         throw_exception with throw.
5030         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5031         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5032         * aarch64-tdep.c (aarch64_make_prologue_cache)
5033         (aarch64_make_stub_cache): Replace throw_exception with throw.
5034
5035 2019-04-08  Tom Tromey  <tom@tromey.com>
5036
5037         * common/common-exceptions.c (throw_exception): Rename from
5038         throw_exception_cxx.  Remove old copy.  Make argument const.
5039         (throw_it): Create and throw exception objects directly.
5040         * common/common-exceptions.h (throw_exception): Make argument
5041         const.
5042         (struct gdb_exception_error): Add constructor.
5043         (struct gdb_exception_quit): Add constructor.
5044
5045 2019-04-08  Tom Tromey  <tom@tromey.com>
5046
5047         * common/common-exceptions.h (exception_rethrow): Don't declare.
5048         (TRY_SJLJ): Update comment.
5049         (TRY, CATCH, END_CATCH): Remove.
5050         * common/common-exceptions.c (exception_rethrow): Remove.
5051
5052 2019-04-08  Tom Tromey  <tom@tromey.com>
5053
5054         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5055         Remove.
5056         (gdb_exception_error): Rename from
5057         gdb_exception_RETURN_MASK_ERROR.
5058         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5059         (gdb_quit_bad_alloc): Update.
5060         * aarch64-tdep.c: Update.
5061         * ada-lang.c: Update.
5062         * ada-typeprint.c: Update.
5063         * ada-valprint.c: Update.
5064         * amd64-tdep.c: Update.
5065         * arch-utils.c: Update.
5066         * break-catch-throw.c: Update.
5067         * breakpoint.c: Update.
5068         * btrace.c: Update.
5069         * c-varobj.c: Update.
5070         * cli/cli-cmds.c: Update.
5071         * cli/cli-interp.c: Update.
5072         * cli/cli-script.c: Update.
5073         * common/common-exceptions.c: Update.
5074         * common/new-op.c: Update.
5075         * common/selftest.c: Update.
5076         * compile/compile-c-symbols.c: Update.
5077         * compile/compile-cplus-symbols.c: Update.
5078         * compile/compile-object-load.c: Update.
5079         * compile/compile-object-run.c: Update.
5080         * completer.c: Update.
5081         * corelow.c: Update.
5082         * cp-abi.c: Update.
5083         * cp-support.c: Update.
5084         * cp-valprint.c: Update.
5085         * darwin-nat.c: Update.
5086         * disasm-selftests.c: Update.
5087         * dtrace-probe.c: Update.
5088         * dwarf-index-cache.c: Update.
5089         * dwarf-index-write.c: Update.
5090         * dwarf2-frame-tailcall.c: Update.
5091         * dwarf2-frame.c: Update.
5092         * dwarf2loc.c: Update.
5093         * dwarf2read.c: Update.
5094         * eval.c: Update.
5095         * event-loop.c: Update.
5096         * event-top.c: Update.
5097         * exec.c: Update.
5098         * f-valprint.c: Update.
5099         * fbsd-tdep.c: Update.
5100         * frame-unwind.c: Update.
5101         * frame.c: Update.
5102         * gdbtypes.c: Update.
5103         * gnu-v3-abi.c: Update.
5104         * guile/guile-internal.h: Update.
5105         * guile/scm-block.c: Update.
5106         * guile/scm-breakpoint.c: Update.
5107         * guile/scm-cmd.c: Update.
5108         * guile/scm-disasm.c: Update.
5109         * guile/scm-frame.c: Update.
5110         * guile/scm-lazy-string.c: Update.
5111         * guile/scm-math.c: Update.
5112         * guile/scm-param.c: Update.
5113         * guile/scm-ports.c: Update.
5114         * guile/scm-pretty-print.c: Update.
5115         * guile/scm-symbol.c: Update.
5116         * guile/scm-symtab.c: Update.
5117         * guile/scm-type.c: Update.
5118         * guile/scm-value.c: Update.
5119         * i386-linux-tdep.c: Update.
5120         * i386-tdep.c: Update.
5121         * inf-loop.c: Update.
5122         * infcall.c: Update.
5123         * infcmd.c: Update.
5124         * infrun.c: Update.
5125         * jit.c: Update.
5126         * language.c: Update.
5127         * linespec.c: Update.
5128         * linux-fork.c: Update.
5129         * linux-nat.c: Update.
5130         * linux-tdep.c: Update.
5131         * linux-thread-db.c: Update.
5132         * main.c: Update.
5133         * mi/mi-cmd-break.c: Update.
5134         * mi/mi-cmd-stack.c: Update.
5135         * mi/mi-interp.c: Update.
5136         * mi/mi-main.c: Update.
5137         * objc-lang.c: Update.
5138         * p-valprint.c: Update.
5139         * parse.c: Update.
5140         * ppc-linux-tdep.c: Update.
5141         * printcmd.c: Update.
5142         * python/py-arch.c: Update.
5143         * python/py-breakpoint.c: Update.
5144         * python/py-cmd.c: Update.
5145         * python/py-finishbreakpoint.c: Update.
5146         * python/py-frame.c: Update.
5147         * python/py-framefilter.c: Update.
5148         * python/py-gdb-readline.c: Update.
5149         * python/py-inferior.c: Update.
5150         * python/py-infthread.c: Update.
5151         * python/py-lazy-string.c: Update.
5152         * python/py-linetable.c: Update.
5153         * python/py-objfile.c: Update.
5154         * python/py-param.c: Update.
5155         * python/py-prettyprint.c: Update.
5156         * python/py-progspace.c: Update.
5157         * python/py-record-btrace.c: Update.
5158         * python/py-record.c: Update.
5159         * python/py-symbol.c: Update.
5160         * python/py-type.c: Update.
5161         * python/py-unwind.c: Update.
5162         * python/py-utils.c: Update.
5163         * python/py-value.c: Update.
5164         * python/python.c: Update.
5165         * record-btrace.c: Update.
5166         * record-full.c: Update.
5167         * remote-fileio.c: Update.
5168         * remote.c: Update.
5169         * riscv-tdep.c: Update.
5170         * rs6000-aix-tdep.c: Update.
5171         * rs6000-tdep.c: Update.
5172         * rust-exp.y: Update.
5173         * rust-lang.c: Update.
5174         * s390-tdep.c: Update.
5175         * selftest-arch.c: Update.
5176         * solib-dsbt.c: Update.
5177         * solib-frv.c: Update.
5178         * solib-spu.c: Update.
5179         * solib-svr4.c: Update.
5180         * solib.c: Update.
5181         * sparc64-linux-tdep.c: Update.
5182         * stack.c: Update.
5183         * symfile-mem.c: Update.
5184         * symmisc.c: Update.
5185         * target.c: Update.
5186         * thread.c: Update.
5187         * top.c: Update.
5188         * tracefile-tfile.c: Update.
5189         * tui/tui.c: Update.
5190         * typeprint.c: Update.
5191         * unittests/cli-utils-selftests.c: Update.
5192         * unittests/parse-connection-spec-selftests.c: Update.
5193         * valops.c: Update.
5194         * valprint.c: Update.
5195         * value.c: Update.
5196         * varobj.c: Update.
5197         * windows-nat.c: Update.
5198         * x86-linux-nat.c: Update.
5199         * xml-support.c: Update.
5200
5201 2019-04-08  Tom Tromey  <tom@tromey.com>
5202
5203         * xml-support.c: Use C++ exception handling.
5204         * x86-linux-nat.c: Use C++ exception handling.
5205         * windows-nat.c: Use C++ exception handling.
5206         * varobj.c: Use C++ exception handling.
5207         * value.c: Use C++ exception handling.
5208         * valprint.c: Use C++ exception handling.
5209         * valops.c: Use C++ exception handling.
5210         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5211         handling.
5212         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5213         * typeprint.c: Use C++ exception handling.
5214         * tui/tui.c: Use C++ exception handling.
5215         * tracefile-tfile.c: Use C++ exception handling.
5216         * top.c: Use C++ exception handling.
5217         * thread.c: Use C++ exception handling.
5218         * target.c: Use C++ exception handling.
5219         * symmisc.c: Use C++ exception handling.
5220         * symfile-mem.c: Use C++ exception handling.
5221         * stack.c: Use C++ exception handling.
5222         * sparc64-linux-tdep.c: Use C++ exception handling.
5223         * solib.c: Use C++ exception handling.
5224         * solib-svr4.c: Use C++ exception handling.
5225         * solib-spu.c: Use C++ exception handling.
5226         * solib-frv.c: Use C++ exception handling.
5227         * solib-dsbt.c: Use C++ exception handling.
5228         * selftest-arch.c: Use C++ exception handling.
5229         * s390-tdep.c: Use C++ exception handling.
5230         * rust-lang.c: Use C++ exception handling.
5231         * rust-exp.y: Use C++ exception handling.
5232         * rs6000-tdep.c: Use C++ exception handling.
5233         * rs6000-aix-tdep.c: Use C++ exception handling.
5234         * riscv-tdep.c: Use C++ exception handling.
5235         * remote.c: Use C++ exception handling.
5236         * remote-fileio.c: Use C++ exception handling.
5237         * record-full.c: Use C++ exception handling.
5238         * record-btrace.c: Use C++ exception handling.
5239         * python/python.c: Use C++ exception handling.
5240         * python/py-value.c: Use C++ exception handling.
5241         * python/py-utils.c: Use C++ exception handling.
5242         * python/py-unwind.c: Use C++ exception handling.
5243         * python/py-type.c: Use C++ exception handling.
5244         * python/py-symbol.c: Use C++ exception handling.
5245         * python/py-record.c: Use C++ exception handling.
5246         * python/py-record-btrace.c: Use C++ exception handling.
5247         * python/py-progspace.c: Use C++ exception handling.
5248         * python/py-prettyprint.c: Use C++ exception handling.
5249         * python/py-param.c: Use C++ exception handling.
5250         * python/py-objfile.c: Use C++ exception handling.
5251         * python/py-linetable.c: Use C++ exception handling.
5252         * python/py-lazy-string.c: Use C++ exception handling.
5253         * python/py-infthread.c: Use C++ exception handling.
5254         * python/py-inferior.c: Use C++ exception handling.
5255         * python/py-gdb-readline.c: Use C++ exception handling.
5256         * python/py-framefilter.c: Use C++ exception handling.
5257         * python/py-frame.c: Use C++ exception handling.
5258         * python/py-finishbreakpoint.c: Use C++ exception handling.
5259         * python/py-cmd.c: Use C++ exception handling.
5260         * python/py-breakpoint.c: Use C++ exception handling.
5261         * python/py-arch.c: Use C++ exception handling.
5262         * printcmd.c: Use C++ exception handling.
5263         * ppc-linux-tdep.c: Use C++ exception handling.
5264         * parse.c: Use C++ exception handling.
5265         * p-valprint.c: Use C++ exception handling.
5266         * objc-lang.c: Use C++ exception handling.
5267         * mi/mi-main.c: Use C++ exception handling.
5268         * mi/mi-interp.c: Use C++ exception handling.
5269         * mi/mi-cmd-stack.c: Use C++ exception handling.
5270         * mi/mi-cmd-break.c: Use C++ exception handling.
5271         * main.c: Use C++ exception handling.
5272         * linux-thread-db.c: Use C++ exception handling.
5273         * linux-tdep.c: Use C++ exception handling.
5274         * linux-nat.c: Use C++ exception handling.
5275         * linux-fork.c: Use C++ exception handling.
5276         * linespec.c: Use C++ exception handling.
5277         * language.c: Use C++ exception handling.
5278         * jit.c: Use C++ exception handling.
5279         * infrun.c: Use C++ exception handling.
5280         * infcmd.c: Use C++ exception handling.
5281         * infcall.c: Use C++ exception handling.
5282         * inf-loop.c: Use C++ exception handling.
5283         * i386-tdep.c: Use C++ exception handling.
5284         * i386-linux-tdep.c: Use C++ exception handling.
5285         * guile/scm-value.c: Use C++ exception handling.
5286         * guile/scm-type.c: Use C++ exception handling.
5287         * guile/scm-symtab.c: Use C++ exception handling.
5288         * guile/scm-symbol.c: Use C++ exception handling.
5289         * guile/scm-pretty-print.c: Use C++ exception handling.
5290         * guile/scm-ports.c: Use C++ exception handling.
5291         * guile/scm-param.c: Use C++ exception handling.
5292         * guile/scm-math.c: Use C++ exception handling.
5293         * guile/scm-lazy-string.c: Use C++ exception handling.
5294         * guile/scm-frame.c: Use C++ exception handling.
5295         * guile/scm-disasm.c: Use C++ exception handling.
5296         * guile/scm-cmd.c: Use C++ exception handling.
5297         * guile/scm-breakpoint.c: Use C++ exception handling.
5298         * guile/scm-block.c: Use C++ exception handling.
5299         * guile/guile-internal.h: Use C++ exception handling.
5300         * gnu-v3-abi.c: Use C++ exception handling.
5301         * gdbtypes.c: Use C++ exception handling.
5302         * frame.c: Use C++ exception handling.
5303         * frame-unwind.c: Use C++ exception handling.
5304         * fbsd-tdep.c: Use C++ exception handling.
5305         * f-valprint.c: Use C++ exception handling.
5306         * exec.c: Use C++ exception handling.
5307         * event-top.c: Use C++ exception handling.
5308         * event-loop.c: Use C++ exception handling.
5309         * eval.c: Use C++ exception handling.
5310         * dwarf2read.c: Use C++ exception handling.
5311         * dwarf2loc.c: Use C++ exception handling.
5312         * dwarf2-frame.c: Use C++ exception handling.
5313         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5314         * dwarf-index-write.c: Use C++ exception handling.
5315         * dwarf-index-cache.c: Use C++ exception handling.
5316         * dtrace-probe.c: Use C++ exception handling.
5317         * disasm-selftests.c: Use C++ exception handling.
5318         * darwin-nat.c: Use C++ exception handling.
5319         * cp-valprint.c: Use C++ exception handling.
5320         * cp-support.c: Use C++ exception handling.
5321         * cp-abi.c: Use C++ exception handling.
5322         * corelow.c: Use C++ exception handling.
5323         * completer.c: Use C++ exception handling.
5324         * compile/compile-object-run.c: Use C++ exception handling.
5325         * compile/compile-object-load.c: Use C++ exception handling.
5326         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5327         * compile/compile-c-symbols.c: Use C++ exception handling.
5328         * common/selftest.c: Use C++ exception handling.
5329         * common/new-op.c: Use C++ exception handling.
5330         * cli/cli-script.c: Use C++ exception handling.
5331         * cli/cli-interp.c: Use C++ exception handling.
5332         * cli/cli-cmds.c: Use C++ exception handling.
5333         * c-varobj.c: Use C++ exception handling.
5334         * btrace.c: Use C++ exception handling.
5335         * breakpoint.c: Use C++ exception handling.
5336         * break-catch-throw.c: Use C++ exception handling.
5337         * arch-utils.c: Use C++ exception handling.
5338         * amd64-tdep.c: Use C++ exception handling.
5339         * ada-valprint.c: Use C++ exception handling.
5340         * ada-typeprint.c: Use C++ exception handling.
5341         * ada-lang.c: Use C++ exception handling.
5342         * aarch64-tdep.c: Use C++ exception handling.
5343
5344 2019-04-08  Tom Tromey  <tom@tromey.com>
5345
5346         * xml-support.c (gdb_xml_parser::parse): Update.
5347         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5348         * value.c (show_convenience): Update.
5349         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5350         (test_parse_flags_qcs): Update.
5351         * thread.c (thr_try_catch_cmd): Update.
5352         * target.c (target_translate_tls_address): Update.
5353         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5354         (info_frame_command_core, frame_apply_command_count): Update.
5355         * rust-exp.y (rust_lex_exception_test): Update.
5356         * riscv-tdep.c (riscv_print_one_register_info): Update.
5357         * remote.c (remote_target::enable_btrace): Update.
5358         * record-btrace.c (record_btrace_enable_warn): Update.
5359         * python/py-utils.c (gdbpy_convert_exception): Update.
5360         * printcmd.c (do_one_display, print_variable_and_value): Update.
5361         * mi/mi-main.c (mi_print_exception): Update.
5362         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5363         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5364         * linux-nat.c (linux_nat_target::attach): Update.
5365         * linux-fork.c (class scoped_switch_fork_info): Update.
5366         * infrun.c (displaced_step_prepare): Update.
5367         * infcall.c (call_function_by_hand_dummy): Update.
5368         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5369         * gnu-v3-abi.c (print_one_vtable): Update.
5370         * frame.c (get_prev_frame_always): Update.
5371         * f-valprint.c (info_common_command_for_block): Update.
5372         * exec.c (try_open_exec_file): Update.
5373         * exceptions.c (print_exception, exception_print)
5374         (exception_fprintf, exception_print_same): Update.
5375         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5376         * dwarf-index-cache.c (index_cache::store)
5377         (index_cache::lookup_gdb_index): Update.
5378         * darwin-nat.c (maybe_cache_shell): Update.
5379         * cp-valprint.c (cp_print_value_fields): Update.
5380         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5381         (gcc_cplus_symbol_address): Update.
5382         * compile/compile-c-symbols.c (gcc_convert_symbol)
5383         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5384         * common/selftest.c: Update.
5385         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5386         a std::string.
5387         (exception_try_scope_entry, exception_try_scope_exit): Don't
5388         declare.
5389         (struct exception_try_scope): Remove.
5390         (TRY): Don't use exception_try_scope.
5391         (struct gdb_exception): Add constructor, operator=.
5392         <what>: New method.
5393         (struct gdb_exception_RETURN_MASK_ALL)
5394         (struct gdb_exception_RETURN_MASK_ERROR)
5395         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5396         (struct gdb_quit_bad_alloc): Update.
5397         * common/common-exceptions.c (exception_none): Change
5398         initializer.
5399         (struct catcher) <state, exception>: Initialize inline.
5400         <prev>: Remove member.
5401         (current_catcher): Remove.
5402         (catchers): New global.
5403         (exceptions_state_mc_init): Simplify.
5404         (catcher_pop): Remove.
5405         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5406         (try_scope_depth, exception_try_scope_entry)
5407         (exception_try_scope_exit): Remove.
5408         (throw_exception_sjlj): Update.
5409         (exception_messages, exception_messages_size): Remove.
5410         (throw_it): Simplify.
5411         (gdb_exception_sliced_copy): Remove.
5412         (throw_exception_cxx): Update.
5413         * cli/cli-script.c (script_from_file): Update.
5414         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5415         Update.
5416         * ada-valprint.c (ada_val_print): Update.
5417         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5418         (create_excep_cond_exprs): Update.
5419
5420 2019-04-08  Tom Tromey  <tom@tromey.com>
5421
5422         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5423         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5424         (TRY, CATCH, END_CATCH): Remove some definitions.
5425         * common/common-exceptions.c: Don't use GDB_XCPT.
5426         (catcher_list_size): Remove.
5427         (throw_exception, throw_it): Simplify.
5428
5429 2019-04-05  Tom Tromey  <tom@tromey.com>
5430
5431         Revert the header-sorting patch.
5432         * ft32-tdep.c: Revert.
5433         * frv-tdep.c: Revert.
5434         * frv-linux-tdep.c: Revert.
5435         * frame.c: Revert.
5436         * frame-unwind.c: Revert.
5437         * frame-base.c: Revert.
5438         * fork-child.c: Revert.
5439         * findvar.c: Revert.
5440         * findcmd.c: Revert.
5441         * filesystem.c: Revert.
5442         * filename-seen-cache.h: Revert.
5443         * filename-seen-cache.c: Revert.
5444         * fbsd-tdep.c: Revert.
5445         * fbsd-nat.h: Revert.
5446         * fbsd-nat.c: Revert.
5447         * f-valprint.c: Revert.
5448         * f-typeprint.c: Revert.
5449         * f-lang.c: Revert.
5450         * extension.h: Revert.
5451         * extension.c: Revert.
5452         * extension-priv.h: Revert.
5453         * expprint.c: Revert.
5454         * exec.h: Revert.
5455         * exec.c: Revert.
5456         * exceptions.c: Revert.
5457         * event-top.c: Revert.
5458         * event-loop.c: Revert.
5459         * eval.c: Revert.
5460         * elfread.c: Revert.
5461         * dwarf2read.h: Revert.
5462         * dwarf2read.c: Revert.
5463         * dwarf2loc.c: Revert.
5464         * dwarf2expr.h: Revert.
5465         * dwarf2expr.c: Revert.
5466         * dwarf2-frame.c: Revert.
5467         * dwarf2-frame-tailcall.c: Revert.
5468         * dwarf-index-write.h: Revert.
5469         * dwarf-index-write.c: Revert.
5470         * dwarf-index-common.c: Revert.
5471         * dwarf-index-cache.h: Revert.
5472         * dwarf-index-cache.c: Revert.
5473         * dummy-frame.c: Revert.
5474         * dtrace-probe.c: Revert.
5475         * disasm.h: Revert.
5476         * disasm.c: Revert.
5477         * disasm-selftests.c: Revert.
5478         * dictionary.c: Revert.
5479         * dicos-tdep.c: Revert.
5480         * demangle.c: Revert.
5481         * dcache.h: Revert.
5482         * dcache.c: Revert.
5483         * darwin-nat.h: Revert.
5484         * darwin-nat.c: Revert.
5485         * darwin-nat-info.c: Revert.
5486         * d-valprint.c: Revert.
5487         * d-namespace.c: Revert.
5488         * d-lang.c: Revert.
5489         * ctf.c: Revert.
5490         * csky-tdep.c: Revert.
5491         * csky-linux-tdep.c: Revert.
5492         * cris-tdep.c: Revert.
5493         * cris-linux-tdep.c: Revert.
5494         * cp-valprint.c: Revert.
5495         * cp-support.c: Revert.
5496         * cp-namespace.c: Revert.
5497         * cp-abi.c: Revert.
5498         * corelow.c: Revert.
5499         * corefile.c: Revert.
5500         * continuations.c: Revert.
5501         * completer.h: Revert.
5502         * completer.c: Revert.
5503         * complaints.c: Revert.
5504         * coffread.c: Revert.
5505         * coff-pe-read.c: Revert.
5506         * cli-out.h: Revert.
5507         * cli-out.c: Revert.
5508         * charset.c: Revert.
5509         * c-varobj.c: Revert.
5510         * c-valprint.c: Revert.
5511         * c-typeprint.c: Revert.
5512         * c-lang.c: Revert.
5513         * buildsym.c: Revert.
5514         * buildsym-legacy.c: Revert.
5515         * build-id.h: Revert.
5516         * build-id.c: Revert.
5517         * btrace.c: Revert.
5518         * bsd-uthread.c: Revert.
5519         * breakpoint.h: Revert.
5520         * breakpoint.c: Revert.
5521         * break-catch-throw.c: Revert.
5522         * break-catch-syscall.c: Revert.
5523         * break-catch-sig.c: Revert.
5524         * blockframe.c: Revert.
5525         * block.c: Revert.
5526         * bfin-tdep.c: Revert.
5527         * bfin-linux-tdep.c: Revert.
5528         * bfd-target.c: Revert.
5529         * bcache.c: Revert.
5530         * ax-general.c: Revert.
5531         * ax-gdb.h: Revert.
5532         * ax-gdb.c: Revert.
5533         * avr-tdep.c: Revert.
5534         * auxv.c: Revert.
5535         * auto-load.c: Revert.
5536         * arm-wince-tdep.c: Revert.
5537         * arm-tdep.c: Revert.
5538         * arm-symbian-tdep.c: Revert.
5539         * arm-pikeos-tdep.c: Revert.
5540         * arm-obsd-tdep.c: Revert.
5541         * arm-nbsd-tdep.c: Revert.
5542         * arm-nbsd-nat.c: Revert.
5543         * arm-linux-tdep.c: Revert.
5544         * arm-linux-nat.c: Revert.
5545         * arm-fbsd-tdep.c: Revert.
5546         * arm-fbsd-nat.c: Revert.
5547         * arm-bsd-tdep.c: Revert.
5548         * arch-utils.c: Revert.
5549         * arc-tdep.c: Revert.
5550         * arc-newlib-tdep.c: Revert.
5551         * annotate.h: Revert.
5552         * annotate.c: Revert.
5553         * amd64-windows-tdep.c: Revert.
5554         * amd64-windows-nat.c: Revert.
5555         * amd64-tdep.c: Revert.
5556         * amd64-sol2-tdep.c: Revert.
5557         * amd64-obsd-tdep.c: Revert.
5558         * amd64-obsd-nat.c: Revert.
5559         * amd64-nbsd-tdep.c: Revert.
5560         * amd64-nbsd-nat.c: Revert.
5561         * amd64-nat.c: Revert.
5562         * amd64-linux-tdep.c: Revert.
5563         * amd64-linux-nat.c: Revert.
5564         * amd64-fbsd-tdep.c: Revert.
5565         * amd64-fbsd-nat.c: Revert.
5566         * amd64-dicos-tdep.c: Revert.
5567         * amd64-darwin-tdep.c: Revert.
5568         * amd64-bsd-nat.c: Revert.
5569         * alpha-tdep.c: Revert.
5570         * alpha-obsd-tdep.c: Revert.
5571         * alpha-nbsd-tdep.c: Revert.
5572         * alpha-mdebug-tdep.c: Revert.
5573         * alpha-linux-tdep.c: Revert.
5574         * alpha-linux-nat.c: Revert.
5575         * alpha-bsd-tdep.c: Revert.
5576         * alpha-bsd-nat.c: Revert.
5577         * aix-thread.c: Revert.
5578         * agent.c: Revert.
5579         * addrmap.c: Revert.
5580         * ada-varobj.c: Revert.
5581         * ada-valprint.c: Revert.
5582         * ada-typeprint.c: Revert.
5583         * ada-tasks.c: Revert.
5584         * ada-lang.c: Revert.
5585         * aarch64-tdep.c: Revert.
5586         * aarch64-ravenscar-thread.c: Revert.
5587         * aarch64-newlib-tdep.c: Revert.
5588         * aarch64-linux-tdep.c: Revert.
5589         * aarch64-linux-nat.c: Revert.
5590         * aarch64-fbsd-tdep.c: Revert.
5591         * aarch64-fbsd-nat.c: Revert.
5592         * aarch32-linux-nat.c: Revert.
5593
5594 2019-04-05  Tom Tromey  <tom@tromey.com>
5595
5596         * ft32-tdep.c: Sort headers.
5597         * frv-tdep.c: Sort headers.
5598         * frv-linux-tdep.c: Sort headers.
5599         * frame.c: Sort headers.
5600         * frame-unwind.c: Sort headers.
5601         * frame-base.c: Sort headers.
5602         * fork-child.c: Sort headers.
5603         * findvar.c: Sort headers.
5604         * findcmd.c: Sort headers.
5605         * filesystem.c: Sort headers.
5606         * filename-seen-cache.h: Sort headers.
5607         * filename-seen-cache.c: Sort headers.
5608         * fbsd-tdep.c: Sort headers.
5609         * fbsd-nat.h: Sort headers.
5610         * fbsd-nat.c: Sort headers.
5611         * f-valprint.c: Sort headers.
5612         * f-typeprint.c: Sort headers.
5613         * f-lang.c: Sort headers.
5614         * extension.h: Sort headers.
5615         * extension.c: Sort headers.
5616         * extension-priv.h: Sort headers.
5617         * expprint.c: Sort headers.
5618         * exec.h: Sort headers.
5619         * exec.c: Sort headers.
5620         * exceptions.c: Sort headers.
5621         * event-top.c: Sort headers.
5622         * event-loop.c: Sort headers.
5623         * eval.c: Sort headers.
5624         * elfread.c: Sort headers.
5625         * dwarf2read.h: Sort headers.
5626         * dwarf2read.c: Sort headers.
5627         * dwarf2loc.c: Sort headers.
5628         * dwarf2expr.h: Sort headers.
5629         * dwarf2expr.c: Sort headers.
5630         * dwarf2-frame.c: Sort headers.
5631         * dwarf2-frame-tailcall.c: Sort headers.
5632         * dwarf-index-write.h: Sort headers.
5633         * dwarf-index-write.c: Sort headers.
5634         * dwarf-index-common.c: Sort headers.
5635         * dwarf-index-cache.h: Sort headers.
5636         * dwarf-index-cache.c: Sort headers.
5637         * dummy-frame.c: Sort headers.
5638         * dtrace-probe.c: Sort headers.
5639         * disasm.h: Sort headers.
5640         * disasm.c: Sort headers.
5641         * disasm-selftests.c: Sort headers.
5642         * dictionary.c: Sort headers.
5643         * dicos-tdep.c: Sort headers.
5644         * demangle.c: Sort headers.
5645         * dcache.h: Sort headers.
5646         * dcache.c: Sort headers.
5647         * darwin-nat.h: Sort headers.
5648         * darwin-nat.c: Sort headers.
5649         * darwin-nat-info.c: Sort headers.
5650         * d-valprint.c: Sort headers.
5651         * d-namespace.c: Sort headers.
5652         * d-lang.c: Sort headers.
5653         * ctf.c: Sort headers.
5654         * csky-tdep.c: Sort headers.
5655         * csky-linux-tdep.c: Sort headers.
5656         * cris-tdep.c: Sort headers.
5657         * cris-linux-tdep.c: Sort headers.
5658         * cp-valprint.c: Sort headers.
5659         * cp-support.c: Sort headers.
5660         * cp-namespace.c: Sort headers.
5661         * cp-abi.c: Sort headers.
5662         * corelow.c: Sort headers.
5663         * corefile.c: Sort headers.
5664         * continuations.c: Sort headers.
5665         * completer.h: Sort headers.
5666         * completer.c: Sort headers.
5667         * complaints.c: Sort headers.
5668         * coffread.c: Sort headers.
5669         * coff-pe-read.c: Sort headers.
5670         * cli-out.h: Sort headers.
5671         * cli-out.c: Sort headers.
5672         * charset.c: Sort headers.
5673         * c-varobj.c: Sort headers.
5674         * c-valprint.c: Sort headers.
5675         * c-typeprint.c: Sort headers.
5676         * c-lang.c: Sort headers.
5677         * buildsym.c: Sort headers.
5678         * buildsym-legacy.c: Sort headers.
5679         * build-id.h: Sort headers.
5680         * build-id.c: Sort headers.
5681         * btrace.c: Sort headers.
5682         * bsd-uthread.c: Sort headers.
5683         * breakpoint.h: Sort headers.
5684         * breakpoint.c: Sort headers.
5685         * break-catch-throw.c: Sort headers.
5686         * break-catch-syscall.c: Sort headers.
5687         * break-catch-sig.c: Sort headers.
5688         * blockframe.c: Sort headers.
5689         * block.c: Sort headers.
5690         * bfin-tdep.c: Sort headers.
5691         * bfin-linux-tdep.c: Sort headers.
5692         * bfd-target.c: Sort headers.
5693         * bcache.c: Sort headers.
5694         * ax-general.c: Sort headers.
5695         * ax-gdb.h: Sort headers.
5696         * ax-gdb.c: Sort headers.
5697         * avr-tdep.c: Sort headers.
5698         * auxv.c: Sort headers.
5699         * auto-load.c: Sort headers.
5700         * arm-wince-tdep.c: Sort headers.
5701         * arm-tdep.c: Sort headers.
5702         * arm-symbian-tdep.c: Sort headers.
5703         * arm-pikeos-tdep.c: Sort headers.
5704         * arm-obsd-tdep.c: Sort headers.
5705         * arm-nbsd-tdep.c: Sort headers.
5706         * arm-nbsd-nat.c: Sort headers.
5707         * arm-linux-tdep.c: Sort headers.
5708         * arm-linux-nat.c: Sort headers.
5709         * arm-fbsd-tdep.c: Sort headers.
5710         * arm-fbsd-nat.c: Sort headers.
5711         * arm-bsd-tdep.c: Sort headers.
5712         * arch-utils.c: Sort headers.
5713         * arc-tdep.c: Sort headers.
5714         * arc-newlib-tdep.c: Sort headers.
5715         * annotate.h: Sort headers.
5716         * annotate.c: Sort headers.
5717         * amd64-windows-tdep.c: Sort headers.
5718         * amd64-windows-nat.c: Sort headers.
5719         * amd64-tdep.c: Sort headers.
5720         * amd64-sol2-tdep.c: Sort headers.
5721         * amd64-obsd-tdep.c: Sort headers.
5722         * amd64-obsd-nat.c: Sort headers.
5723         * amd64-nbsd-tdep.c: Sort headers.
5724         * amd64-nbsd-nat.c: Sort headers.
5725         * amd64-nat.c: Sort headers.
5726         * amd64-linux-tdep.c: Sort headers.
5727         * amd64-linux-nat.c: Sort headers.
5728         * amd64-fbsd-tdep.c: Sort headers.
5729         * amd64-fbsd-nat.c: Sort headers.
5730         * amd64-dicos-tdep.c: Sort headers.
5731         * amd64-darwin-tdep.c: Sort headers.
5732         * amd64-bsd-nat.c: Sort headers.
5733         * alpha-tdep.c: Sort headers.
5734         * alpha-obsd-tdep.c: Sort headers.
5735         * alpha-nbsd-tdep.c: Sort headers.
5736         * alpha-mdebug-tdep.c: Sort headers.
5737         * alpha-linux-tdep.c: Sort headers.
5738         * alpha-linux-nat.c: Sort headers.
5739         * alpha-bsd-tdep.c: Sort headers.
5740         * alpha-bsd-nat.c: Sort headers.
5741         * aix-thread.c: Sort headers.
5742         * agent.c: Sort headers.
5743         * addrmap.c: Sort headers.
5744         * ada-varobj.c: Sort headers.
5745         * ada-valprint.c: Sort headers.
5746         * ada-typeprint.c: Sort headers.
5747         * ada-tasks.c: Sort headers.
5748         * ada-lang.c: Sort headers.
5749         * aarch64-tdep.c: Sort headers.
5750         * aarch64-ravenscar-thread.c: Sort headers.
5751         * aarch64-newlib-tdep.c: Sort headers.
5752         * aarch64-linux-tdep.c: Sort headers.
5753         * aarch64-linux-nat.c: Sort headers.
5754         * aarch64-fbsd-tdep.c: Sort headers.
5755         * aarch64-fbsd-nat.c: Sort headers.
5756         * aarch32-linux-nat.c: Sort headers.
5757
5758 2019-04-04  Tom Tromey  <tom@tromey.com>
5759
5760         * varobj.c (varobj_create): Update.
5761         * rust-exp.y (struct rust_parser) <update_innermost_block,
5762         lookup_symbol>: New methods.
5763         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5764         Rename.
5765         (rust_parser::rust_lookup_type)
5766         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5767         * printcmd.c (display_command, do_one_display): Update.
5768         * parser-defs.h (struct parser_state) <parser_state>: Add
5769         "tracker" parameter.
5770         (block_tracker): New member.
5771         (class innermost_block_tracker) <innermost_block_tracker>: Add
5772         "types" parameter.
5773         <reset>: Remove method.
5774         (innermost_block): Don't declare.
5775         (null_post_parser): Update.
5776         * parse.c (innermost_block): Remove global.
5777         (write_dollar_variable): Update.
5778         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5779         Remove "tracker_types" parameter.
5780         (parse_expression): Add "tracker" parameter.
5781         (parse_expression_for_completion): Update.
5782         (null_post_parser): Add "tracker" parameter.
5783         * p-exp.y: Update rules.
5784         * m2-exp.y: Update rules.
5785         * language.h (struct language_defn) <la_post_parser>: Add
5786         "tracker" parameter.
5787         * go-exp.y: Update rules.
5788         * f-exp.y: Update rules.
5789         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5790         parameter.
5791         * d-exp.y: Update rules.
5792         * c-exp.y: Update rules.
5793         * breakpoint.c (set_breakpoint_condition): Create an
5794         innermost_block_tracker.
5795         (watch_command_1): Likewise.
5796         * ada-lang.c (resolve): Add "tracker" parameter.
5797         (resolve_subexp): Likewise.
5798         * ada-exp.y (write_var_from_sym): Update.
5799
5800 2019-04-04  Tom Tromey  <tom@tromey.com>
5801
5802         * type-stack.h: New file.
5803         * type-stack.c: New file.
5804         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5805         type-stack.h.
5806         (insert_into_type_stack, insert_type, push_type, push_type_int)
5807         (insert_type_address_space, pop_type, pop_type_int)
5808         (pop_typelist, pop_type_stack, append_type_stack)
5809         (push_type_stack, get_type_stack, push_typelist)
5810         (follow_type_instance_flags, follow_types): Don't declare.
5811         * parse.c (type_stack): Remove global.
5812         (parse_exp_in_context): Update.
5813         (insert_into_type_stack, insert_type, push_type, push_type_int)
5814         (insert_type_address_space, pop_type, pop_type_int)
5815         (pop_typelist, pop_type_stack, append_type_stack)
5816         (push_type_stack, get_type_stack, push_typelist)
5817         (follow_type_instance_flags, follow_types): Remove (moved to
5818         type-stack.c).
5819         * f-exp.y (type_stack): New global.
5820         Update rules.
5821         (push_kind_type, f_parse): Update.
5822         * d-exp.y (type_stack): New global.
5823         Update rules.
5824         (d_parse): Update.
5825         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5826         Update rules.
5827         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5828         (HFILES_NO_SRCDIR): Add type-stack.h.
5829
5830 2019-04-04  Tom Tromey  <tom@tromey.com>
5831
5832         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5833         (rust_parser::convert_ast_to_expression, rust_parse)
5834         (rust_lex_test_completion, rust_lex_tests): Update.
5835         * parser-defs.h (struct expr_completion_state): New.
5836         (struct parser_state) <parser_state>: Add completion parameter.
5837         <mark_struct_expression, mark_completion_tag>: New methods.
5838         <parse_completion, m_completion_state>: New members.
5839         (prefixify_expression, null_post_parser): Update.
5840         (mark_struct_expression, mark_completion_tag): Don't declare.
5841         * parse.c (parse_completion, expout_last_struct)
5842         (expout_tag_completion_type, expout_completion_name): Remove
5843         globals.
5844         (parser_state::mark_struct_expression)
5845         (parser_state::mark_completion_tag): Now methods.
5846         (prefixify_expression): Add last_struct parameter.
5847         (prefixify_subexp): Likewise.
5848         (parse_exp_1): Update.
5849         (parse_exp_in_context): Add cstate parameter.  Update.
5850         (parse_expression_for_completion): Create an
5851         expr_completion_state.
5852         (null_post_parser): Add "completion" parameter.
5853         * p-exp.y: Update rules.
5854         (yylex): Update.
5855         * language.h (struct language_defn) <la_post_parser>: Add
5856         "completing" parameter.
5857         * go-exp.y: Update rules.
5858         (lex_one_token): Update.
5859         * expression.h (parse_completion): Don't declare.
5860         * d-exp.y: Update rules.
5861         (lex_one_token): Update rules.
5862         * c-exp.y: Update rules.
5863         (lex_one_token): Update.
5864         * ada-lang.c (resolve): Add "parse_completion" parameter.
5865         (resolve_subexp): Likewise.
5866         (ada_resolve_function): Likewise.
5867
5868 2019-04-04  Tom Tromey  <tom@tromey.com>
5869
5870         * parser-defs.h (struct parser_state) <start_arglist,
5871         end_arglist>: New methods.
5872         <arglist_len, m_funcall_chain>: New members.
5873         (arglist_len, start_arglist, end_arglist): Don't declare.
5874         * parse.c (arglist_len, funcall_chain): Remove global.
5875         (start_arglist, end_arglist): Remove functions.
5876         (parse_exp_in_context): Update.
5877         * p-exp.y: Update rules.
5878         * m2-exp.y: Update rules.
5879         * go-exp.y: Update rules.
5880         * f-exp.y: Update rules.
5881         * d-exp.y: Update rules.
5882         * c-exp.y: Update rules.
5883
5884 2019-04-04  Tom Tromey  <tom@tromey.com>
5885
5886         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5887         lex_operator, push_back>: New methods.
5888         Update all rules.
5889         (rust_parser::lex_hex, lex_escape): Rename and update.
5890         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5891         (rust_parser::lex_operator): Rename and update.
5892         (rust_parser::lex_number, rustyylex, rustyyerror)
5893         (rust_lex_test_init, rust_lex_test_sequence)
5894         (rust_lex_test_push_back, rust_lex_tests): Update.
5895         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5896         parameter.
5897         <lexptr, prev_lexptr>: New members.
5898         (lexptr, prev_lexptr): Don't declare.
5899         * parse.c (lexptr, prev_lexptr): Remove globals.
5900         (parse_exp_in_context): Update.
5901         * p-exp.y (yylex, yyerror): Update.
5902         * m2-exp.y (parse_number, yylex, yyerror): Update.
5903         * go-exp.y (lex_one_token, yyerror): Update.
5904         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5905         * d-exp.y (lex_one_token, yyerror): Update.
5906         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5907         (lex_one_token, yyerror): Update.
5908         * ada-lex.l (YY_INPUT): Update.
5909         (rewind_to_char): Update.
5910         * ada-exp.y (yyerror): Update.
5911
5912 2019-04-04  Tom Tromey  <tom@tromey.com>
5913
5914         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5915         * parser-defs.h (struct parser_state) <parser_state>: Add new
5916         parameter.
5917         <comma_terminates>: New member.
5918         (comma_terminates): Don't declare global.
5919         * parse.c (comma_terminates): Remove global.
5920         (parse_exp_in_context): Update.
5921         * p-exp.y (yylex): Update.
5922         * m2-exp.y (yylex): Update.
5923         * go-exp.y (lex_one_token): Update.
5924         * f-exp.y (yylex): Update.
5925         * d-exp.y (lex_one_token): Update.
5926         * c-exp.y (lex_one_token): Update.
5927         * ada-lex.l: Update.
5928
5929 2019-04-04  Tom Tromey  <tom@tromey.com>
5930
5931         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5932         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5933         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5934         * parser-defs.h (paren_depth): Don't declare.
5935         * parse.c (paren_depth): Remove global.
5936         (parse_exp_in_context): Update.
5937         * p-exp.y (paren_depth): New global.
5938         (pascal_parse): Initialize it.
5939         * m2-exp.y (paren_depth): New global.
5940         (m2_parse): Initialize it.
5941         * go-exp.y (paren_depth): New global.
5942         (go_parse): Initialize it.
5943         * f-exp.y (paren_depth): New global.
5944         (f_parse): Initialize it.
5945         * d-exp.y (paren_depth): New global.
5946         (d_parse): Initialize it.
5947         * c-exp.y (paren_depth): New global.
5948         (c_parse): Initialize it.
5949         * ada-lex.l (paren_depth): New global.
5950         (lexer_init): Initialize it.
5951
5952 2019-04-04  Tom Tromey  <tom@tromey.com>
5953
5954         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5955         (rust_parser::convert_ast_to_type)
5956         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5957         * parser-defs.h (struct parser_state) <parser_state>: Add
5958         parameters.  Initialize new members.
5959         <expression_context_block, expression_context_pc>: New members.
5960         * parse.c (expression_context_block, expression_context_pc):
5961         Remove globals.
5962         (parse_exp_in_context): Update.
5963         * p-exp.y: Update all rules.
5964         (yylex): Update.
5965         * m2-exp.y: Update all rules.
5966         (yylex): Update.
5967         * go-exp.y (yylex): Update.
5968         * f-exp.y (yylex): Update.
5969         * d-exp.y: Update all rules.
5970         (yylex): Update.
5971         * c-exp.y: Update all rules.
5972         (lex_one_token, classify_name, yylex, c_parse): Update.
5973         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5974
5975 2019-04-04  Tom Tromey  <tom@tromey.com>
5976
5977         * gdbarch.h, gdbarch.c: Rebuild.
5978         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5979         * stap-probe.h:
5980         (struct stap_parse_info): Replace "parser_state" with
5981         "expr_builder".
5982         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5983         (parser_state): New class.
5984         * parse.c (expr_builder): Rename.
5985         (expr_builder::release): Rename.
5986         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5987         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5988         (write_exp_elt_longcst, write_exp_elt_floatcst)
5989         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5990         (write_exp_string_vector, write_exp_bitstring)
5991         (write_exp_msymbol, mark_struct_expression)
5992         (write_dollar_variable)
5993         (insert_type_address_space, increase_expout_size): Replace
5994         "parser_state" with "expr_builder".
5995         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5996         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5997         "parser_state" with "expr_builder".
5998
5999 2019-04-04  Tom Tromey  <tom@tromey.com>
6000
6001         * rust-exp.y: Replace "parse_language" with method call.
6002         * p-exp.y:
6003         (yylex): Replace "parse_language" with method call.
6004         * m2-exp.y:
6005         (yylex): Replace "parse_language" with method call.
6006         * go-exp.y (classify_name): Replace "parse_language" with method
6007         call.
6008         * f-exp.y (yylex): Replace "parse_language" with method call.
6009         * d-exp.y (lex_one_token): Replace "parse_language" with method
6010         call.
6011         * c-exp.y:
6012         (lex_one_token, classify_name, yylex): Replace "parse_language"
6013         with method call.
6014         * ada-exp.y (find_primitive_type, type_char)
6015         (type_system_address): Replace "parse_language" with method call.
6016
6017 2019-04-04  Tom Tromey  <tom@tromey.com>
6018
6019         * rust-exp.y: Replace "parse_gdbarch" with method call.
6020         * parse.c (write_dollar_variable, insert_type_address_space):
6021         Replace "parse_gdbarch" with method call.
6022         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6023         call.
6024         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6025         call.
6026         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6027         "parse_gdbarch" with method call.
6028         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6029         with method call.
6030         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6031         "parse_gdbarch" with method call.
6032         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6033         "parse_gdbarch" with method call.
6034         * c-exp.y (parse_type, parse_number, classify_name): Replace
6035         "parse_gdbarch" with method call.
6036         * ada-lex.l: Replace "parse_gdbarch" with method call.
6037         * ada-exp.y (parse_type, find_primitive_type, type_char)
6038         (type_system_address): Replace "parse_gdbarch" with method call.
6039
6040 2019-04-04  Tom Tromey  <tom@tromey.com>
6041
6042         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6043         * stap-probe.c (stap_parse_argument): Update.
6044         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6045         initial_size parameter.
6046         * rust-exp.y (rust_lex_tests): Update.
6047         * parse.c (parser_state): Update.
6048         (parse_exp_in_context): Update.
6049         * parser-defs.h (struct parser_state) <parser_state>: Remove
6050         "initial_size" parameter.
6051
6052 2019-04-04  Tom Tromey  <tom@tromey.com>
6053
6054         * parser-defs.h (increase_expout_size): Don't declare.
6055         * parse.c (increase_expout_size): Now static.
6056
6057 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6058
6059         * gnu-nat.c (gnu_nat_target::wait): Fix
6060         target_waitstatus_to_string call.
6061
6062 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * eval.c (evaluate_subexp_standard): Handle internal functions
6065         during Fortran function call handling.
6066
6067 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6068
6069         * NEWS: Mention new internal functions.
6070         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6071         (read_base_type): Use dwarf2_init_complex_target_type.
6072         * value.c (creal_internal_fn): New function.
6073         (cimag_internal_fn): New function.
6074         (_initialize_values): Register new internal functions.
6075
6076 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6077
6078         * infrun.c (stop_all_threads): If debug_infrun, always
6079         trace the wait status after wait_one, using
6080         target_waitstatus_to_string and target_pid_to_str.
6081         (handle_inferior_event): Replace various trace of
6082         wait status kind by a single trace.
6083         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6084         wait status kind image by target_waitstatus_to_string.
6085         * target/waitstatus.c (target_waitstatus_to_string): Fix
6086         obsolete comment.
6087
6088 2019-04-01  Tom Tromey  <tromey@adacore.com>
6089
6090         PR symtab/23331:
6091         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6092
6093 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6094             Pedro Alves  <palves@redhat.com>
6095
6096         * top.c (quit_force): Call 'finalize_values'.
6097         * value.c (finalize_values): New function.
6098         * value.h (finalize_values): Declare.
6099
6100 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6101
6102         * NEWS: Announce $_gdb_major and $_gdb_minor.
6103
6104         * top.c (init_gdb_version_vars): New function.
6105         (gdb_init): Call init_gdb_version_vars.
6106
6107 2019-03-29  Tom Tromey  <tromey@adacore.com>
6108
6109         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6110         help text.  Remove dead code.
6111
6112 2019-03-29  Keith Seitz  <keiths@redhat.com>
6113
6114         From Siddhesh Poyarekar:
6115         * f-lang.h (f77_get_upperbound): Return LONGEST.
6116         (f77_get_lowerbound): Likewise.
6117         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6118         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6119         print them.
6120         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6121         plongest to format print it.
6122         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6123         (f77_get_upperbound): Likewise.
6124         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6125         LOWER_BOUND to LONGEST.
6126         (f77_create_arrayprint_offset_tbl): Likewise.
6127
6128 2019-03-29  Keith Seitz  <keiths@redhat.com>
6129
6130         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6131         %s/pulongest for TYPE_LENGTH instead of %d in format
6132         strings.
6133         * ada-typerint.c (ada_print_type): Likewise.
6134         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6135         * compile/compile-c-support.c (generate_register_struct): Likewise.
6136         * gdbtypes.c (recursive_dump_type): Likewise.
6137         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6138         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6139         instead of %d in format strings.
6140         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6141         to std::min to ULONGEST.
6142         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6143         instead of %d in format strings.
6144         * tracepoint.c (info_scope_command): Likewise.
6145         * typeprint.c (print_offset_data::update)
6146         (print_offset_data::finish): Likewise.
6147         * xtensa-tdep.c (xtensa_store_return_value)
6148         (xtensa_push_dummy_call): Likewise.
6149
6150 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6151
6152         * windows-nat.c (display_selector): Fixed format specifications
6153         for 64-bit Cygwin.
6154
6155 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6156
6157         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6158
6159 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6160
6161         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6162         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6163         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6164         (nios2_linux_init_abi): Install it.
6165
6166 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6167
6168         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6169
6170 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6171
6172         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6173
6174 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6175             Tom Tromey  <tromey@adacore.com>
6176
6177         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6178
6179 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6180
6181         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6182         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6183         method to compute the bounds of range types. Also print "[evaluated]"
6184         if the bounds' values come from a dynamic evaluation.
6185
6186 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6189         whitespace when pretty printing is on.
6190
6191 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6192
6193         * ppc-linux-nat.c: Add include.
6194
6195 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6196
6197         * NEWS: Mention AArch64 Pointer Authentication.
6198
6199 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6200
6201         * arm-linux-nat.c: Add include.
6202
6203 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6204
6205         * source-cache.c (source_cache::get_source_lines): Re-read
6206         fullname after calling open_source_file.
6207
6208 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6209
6210         * NEWS: Mention TLS support for FreeBSD.
6211
6212 2019-03-25  Tom Tromey  <tromey@adacore.com>
6213
6214         * minsyms.c (BUNCH_SIZE): Update comment.
6215         (~minimal_symbol_reader): Remove old comment.
6216         (compact_minimal_symbols): Update comment.
6217         (minimal_symbol_reader::install): Remove old comment.  Update
6218         other comments.
6219
6220 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6221
6222         * s390-linux-nat.c: Add include.
6223
6224 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6225
6226         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6227         Call linux_get_hwcap.
6228         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6229         Likewise.
6230         (aarch64_linux_get_hwcap): Remove function.
6231         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6232         declaration.
6233         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6234         linux_get_hwcap.
6235         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6236         * linux-tdep.c (linux_get_hwcap): Add function.
6237         (linux_get_hwcap2): Likewise.
6238         * linux-tdep.h (linux_get_hwcap): Add declaration.
6239         (linux_get_hwcap2): Likewise.
6240         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6241         (ppc_linux_get_hwcap2): Likewise.
6242         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6243         linux_get_hwcap.
6244         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6245         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6246         (ppc_linux_nat_target::read_description): Likewise.
6247         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6248         * s390-linux-nat.c: Likewise.
6249         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6250
6251 2019-03-24  Tom Tromey  <tom@tromey.com>
6252
6253         * ada-lang.c (standard_lookup): Simplify initialization.
6254         (ada_lookup_symbol_nonlocal): Simplify return.
6255         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6256         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6257         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6258         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6259         initialization.
6260         * solib.c (solib_global_lookup): Simplify.
6261         * symtab.c (null_block_symbol): Remove.
6262         (symbol_cache_lookup): Simplify returns.
6263         (lookup_language_this): Simplify returns.
6264         (lookup_symbol_aux): Simplify return.
6265         (lookup_local_symbol): Simplify returns.
6266         (lookup_global_symbol_from_objfile): Simplify return.
6267         (lookup_symbol_in_objfile_symtabs)
6268         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6269         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6270         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6271         * cp-namespace.c (cp_lookup_bare_symbol)
6272         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6273         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6274         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6275         (cp_lookup_symbol_via_imports): Simplify initialization.
6276         (find_symbol_in_baseclass): Likewise.
6277         * symtab.h (null_block_symbol): Remove.
6278         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6279         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6280         (d_lookup_symbol_module): Likewise.
6281         (find_symbol_in_baseclass): Simplify initialization.
6282
6283 2019-03-24  Tom Tromey  <tom@tromey.com>
6284
6285         * expression.h: Don't include symtab.h.
6286         (struct block): Forward declare.
6287
6288 2019-03-24  Tom Tromey  <tom@tromey.com>
6289
6290         * c-exp.y (typebase): Remove casts.
6291         * gdbtypes.c (lookup_unsigned_typename, )
6292         (lookup_signed_typename): Remove cast.
6293         * eval.c (parse_to_comma_and_eval): Remove cast.
6294         * parse.c (write_dollar_variable): Remove cast.
6295         * block.h (struct block) <superblock>: Now const.
6296         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6297         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6298         (map_block): Make "block" const.
6299         * symfile.h (struct quick_symbol_functions)
6300         <map_matching_symbols>: Constify block argument to "callback".
6301         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6302         const.
6303         (find_pc_sect_compunit_symtab): Make "b" const.
6304         (find_symbol_at_address): Likewise.
6305         (search_symbols): Likewise.
6306         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6307         (dw2_debug_names_lookup_symbol): Likewise.
6308         (dw2_map_matching_symbols): Update.
6309         * p-valprint.c (pascal_val_print): Remove "block".
6310         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6311         (aux_add_nonlocal_symbols): Make "block" const.
6312         (resolve_subexp): Remove cast.
6313         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6314         const.
6315         (iterate_over_file_blocks): Likewise.
6316         * f-exp.y (%union) <bval>: Remove.
6317         * coffread.c (patch_opaque_types): Make "b" const.
6318         * spu-tdep.c (spu_catch_start): Make "block" const.
6319         * c-valprint.c (print_unpacked_pointer): Remove "block".
6320         * symmisc.c (dump_symtab_1): Make "b" const.
6321         (block_depth): Make "block" const.
6322         * d-exp.y (%union) <bval>: Remove.
6323         * cp-support.h (cp_lookup_rtti_type): Update.
6324         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6325         * psymtab.c (psym_lookup_symbol): Make "block" const.
6326         (maintenance_check_psymtabs): Make "b" const.
6327         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6328         (enumerate_locals, enumerate_args): Update.
6329         * python/py-symtab.c (stpy_global_block): Make "block" const.
6330         (stpy_static_block): Likewise.
6331         * inline-frame.c (block_starting_point_at): Make "new_block"
6332         const.
6333         * block.c (find_block_in_blockvector): Make return type const.
6334         (blockvector_for_pc_sect): Make "b" const.
6335         (find_block_in_blockvector): Make "b" const.
6336
6337 2019-03-23  Tom Tromey  <tom@tromey.com>
6338
6339         * varobj.c (varobj_create): Update.
6340         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6341         * printcmd.c (display_command, do_one_display): Don't reset
6342         innermost_block.
6343         * parser-defs.h (enum innermost_block_tracker_type): Move to
6344         expression.h.
6345         (innermost_block): Update comment.
6346         * parse.c (parse_exp_1): Add tracker_types parameter.
6347         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6348         tracker_types parameter.  Reset innermost_block.
6349         (parse_exp_in_context): Remove.
6350         (parse_expression_for_completion): Update.
6351         * objfiles.c (~objfile): Don't reset expression_context_block or
6352         innermost_block.
6353         * expression.h (enum innermost_block_tracker_type): Move from
6354         parser-defs.h.
6355         (parse_exp_1): Add tracker_types parameter.
6356         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6357         reset innermost_block.
6358
6359 2019-03-23  Tom Tromey  <tom@tromey.com>
6360
6361         * objfiles.h: Include bcache.h.
6362
6363 2019-03-23  Tom Tromey  <tom@tromey.com>
6364
6365         * linespec.c (get_current_search_block): Use
6366         scoped_restore_current_language.
6367         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6368
6369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6370             Jiong Wang  <jiong.wang@arm.com>
6371
6372         * aarch64-linux-tdep.c
6373         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6374         section.
6375         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6376
6377 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6378             Jiong Wang  <jiong.wang@arm.com>
6379
6380         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6381         instructions.
6382         (aarch64_analyze_prologue_test): Add PACIASP test.
6383         (aarch64_prologue_prev_register): Unmask PC value.
6384
6385 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6386             Jiong Wang  <jiong.wang@arm.com>
6387
6388         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6389         (aarch64_dwarf2_prev_register): Unmask PC value.
6390         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6391         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6392         DW_CFA_AARCH64_negate_ra_state.
6393         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6394
6395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6396             Jiong Wang  <jiong.wang@arm.com>
6397
6398         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6399         registers.
6400         (aarch64_pseudo_register_name): Likewise.
6401         (aarch64_pseudo_register_type): Likewise.
6402         (aarch64_pseudo_register_reggroup_p): Likewise.
6403         (aarch64_gdbarch_init): Add pauth registers.
6404         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6405         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6406         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6407         (struct gdbarch_tdep): Add regnum for ra_state.
6408
6409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6410             Jiong Wang  <jiong.wang@arm.com>
6411
6412         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6413
6414 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6415             Jiong Wang  <jiong.wang@arm.com>
6416
6417         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6418         function.
6419         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6420         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6421         (aarch64_gdbarch_init): Add puth registers.
6422         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6423         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6424         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6425
6426 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6427             Jiong Wang  <jiong.wang@arm.com>
6428
6429         * aarch64-linux-nat.c
6430         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6431         * aarch64-linux-tdep.c
6432         (aarch64_linux_core_read_description): Likewise.
6433         (aarch64_linux_get_hwcap): New function.
6434         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6435         (aarch64_linux_get_hwcap): New declaration.
6436
6437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6438             Jiong Wang  <jiong.wang@arm.com>
6439
6440         * aarch64-linux-nat.c
6441         (aarch64_linux_nat_target::read_description): Add pauth param.
6442         * aarch64-linux-tdep.c
6443         (aarch64_linux_core_read_description): Likewise.
6444         * aarch64-tdep.c (struct target_desc): Add in pauth.
6445         (aarch64_read_description): Add pauth param.
6446         (aarch64_gdbarch_init): Likewise.
6447         * aarch64-tdep.h (aarch64_read_description): Likewise.
6448         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6449         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6450         * features/Makefile: Add new files.
6451         * features/aarch64-pauth.c: New file.
6452         * features/aarch64-pauth.xml: New file.
6453
6454 2019-03-20  Tom Tromey  <tromey@adacore.com>
6455
6456         * infrun.c (handle_inferior_event): Rename from
6457         handle_inferior_event_1.  Create a scoped_value_mark.
6458         (handle_inferior_event): Remove.
6459
6460 2019-03-19  Tom Tromey  <tromey@adacore.com>
6461
6462         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6463         * infrun.h (print_stop_event): Add "displays" parameter.
6464         * infrun.c (print_stop_event): Add "displays" parameter.
6465
6466 2019-03-19  Pedro Alves  <palves@redhat.com>
6467
6468         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6469         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6470         to -1.  Fix TABs vs spaces.
6471         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6472         * tui/tui-out.h (tui_ui_out) Add intro comments.
6473         <m_line, m_start_of_line>: In-class initialize, and add describing
6474         comment.
6475
6476 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6477
6478         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6479         variable names.
6480         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6481
6482 2019-03-18  Pedro Alves  <palves@redhat.com>
6483             Eli Zaretskii <eliz@gnu.org>
6484
6485         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6486         m_line and m_start_of_line.
6487
6488 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6489
6490         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6491         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6492         it returns a newline.  This fixes a regression in TU mode, whereby
6493         the next line is output on the same screen line as the user input.
6494
6495 2019-03-18  Tom Tromey  <tromey@adacore.com>
6496
6497         * minsyms.c (minimal_symbol_reader::install): Remove call to
6498         obstack_blank.
6499
6500 2019-03-18  Pedro Alves  <palves@redhat.com>
6501
6502         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6503         New globals.
6504         (apply_style): New, factored out from ...
6505         (apply_ansi_escape): ... this.  Handle reverse video mode.
6506         (tui_set_reverse_mode): New function.
6507         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6508         * tui/tui-winsource.c (tui_show_source_line): Use
6509         tui_set_reverse_mode instead of setting A_STANDOUT.
6510         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6511         New setter methods.
6512
6513 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6514
6515         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6516         Handle tabs.
6517
6518 2019-03-18  Tom Tromey  <tromey@adacore.com>
6519
6520         * ada-lang.c (empty_array): Add "high" parameter.
6521         (ada_evaluate_subexp): Update.
6522
6523 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6524
6525         * unittests/string_view-selftests.c: Define
6526         _initialize_string_view_selftests unconditionally.
6527
6528 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6529
6530         PR gdb/24350
6531         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6532
6533 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6534
6535         PR gdb/24351
6536         * windows-nat.c (display_selector): Fix format specifiers.
6537
6538 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6539
6540         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6541         tui_refill_source_window instead of tui_refresh_win, to update the
6542         current execution line.  This fixes redisplay of the current line
6543         when stepping through the code with "next" or "step".
6544
6545 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6546
6547         * source-cache.c (source_cache::get_source_lines): Call
6548         find_source_lines to initialize s->nlines.  This fixes vertical
6549         scrolling of TUI source window when the DOWN arrow is pressed.
6550
6551 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6552
6553         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6554         linux-thread-db.c (_initialize_thread_db): Likewise.
6555
6556 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6557
6558         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6559         wclrtoeol in tui_show_source_line".  This reverts changes made in
6560         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6561
6562 2019-03-15  Tom Tromey  <tom@tromey.com>
6563
6564         * symtab.h (struct minimal_symbol): Derive from
6565         general_symbol_info.
6566         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6567         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6568         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6569         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6570         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6571         (MSYMBOL_SEARCH_NAME): Update.
6572         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6573         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6574         * minsyms.c (minimal_symbol_reader::record_full): Update.
6575
6576 2019-03-15  Tom Tromey  <tom@tromey.com>
6577
6578         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6579
6580 2019-03-15  Tom Tromey  <tom@tromey.com>
6581
6582         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6583         unique_xmalloc_ptr.
6584         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6585         Update.
6586         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6587         (build_minimal_symbol_hash_tables)
6588         (minimal_symbol_reader::install): Update.
6589
6590 2019-03-15  Tom Tromey  <tom@tromey.com>
6591
6592         * symtab.c (create_demangled_names_hash): Update.
6593         (symbol_set_names): Update.
6594         * objfiles.h (struct objfile_per_bfd_storage)
6595         <demangled_names_hash>: Now an htab_up.
6596         * objfiles.c (objfile_per_bfd_storage): Simplify.
6597
6598 2019-03-15  Tom Tromey  <tom@tromey.com>
6599
6600         * objfiles.h (struct objfile_per_bfd_storage): Declare
6601         destructor.
6602         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6603         New.
6604         (get_objfile_bfd_data): Use new.  Don't initialize
6605         language_of_main.
6606         (free_objfile_per_bfd_storage): Remove.
6607         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6608
6609 2019-03-15  Tom Tromey  <tom@tromey.com>
6610
6611         * symfile.c (reread_symbols): Update.
6612         * objfiles.c (objfile::objfile): Update.
6613         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6614         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6615         comment.
6616         (minimal_symbol_reader::install): Update.
6617         (terminate_minimal_symbol_table): Remove.
6618         * jit.c (jit_object_close_impl): Update.
6619
6620 2019-03-15  Tom Tromey  <tom@tromey.com>
6621
6622         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6623         initializations.
6624
6625 2019-03-15  Tom Tromey  <tom@tromey.com>
6626
6627         * objfiles.h (struct objfile_per_bfd_storage)
6628         <demangled_hash_languages>: Now a bitset.
6629         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6630         (lookup_minimal_symbol): Update.
6631
6632 2019-03-15  Tom Tromey  <tom@tromey.com>
6633
6634         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6635         Don't return the symbol.
6636         * coffread.c (record_minimal_symbol): Use record_full.
6637
6638 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6639
6640         The MS-Windows port of ncurses fails to switch to a color pair if
6641         one or both of the colors are the implicit default colors.  This
6642         change records the default colors when TUI is initialized, and
6643         then specifies them explicitly when a color pair uses the default
6644         colors.  This allows color styling in TUI mode on MS-Windows.
6645
6646         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6647         ncurses_norm_attr.
6648         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6649         colors in ncurses_norm_attr.
6650         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6651         "none", replace it with the default color recorded in
6652         ncurses_norm_attr.
6653
6654 2019-03-14  Tom Tromey  <tromey@adacore.com>
6655
6656         * source-cache.h (class source_cache) <get_source_lines>: Return
6657         std::string.
6658         * source-cache.c (source_cache::extract_lines): Handle case where
6659         first_pos==npos.  Return std::string.
6660         (source_cache::get_source_lines): Update.
6661
6662 2019-03-14  Tom Tromey  <tromey@adacore.com>
6663
6664         * NEWS: Add item for "style sources" commands.
6665         * source-cache.c (source_cache::get_source_lines): Check
6666         source_styling.
6667         * cli/cli-style.c (source_styling): New global.
6668         (_initialize_cli_style): Add "style sources" commands.
6669         (show_style_sources): New function.
6670         * cli/cli-style.h (source_styling): Declare.
6671
6672 2019-03-14  Pedro Alves  <palves@redhat.com>
6673             Tom Tromey  <tromey@adacore.com>
6674
6675         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6676         * tui/tui-winsource.c (tui_refill_source_window): New function,
6677         from...
6678         (tui_horizontal_source_scroll): ... here.  Move some logic.
6679         * cli/cli-style.c (set_style_enabled): Notify new observable.
6680         * tui/tui-hooks.c (tui_redisplay_source): New function.
6681         (tui_attach_detach_observers): Attach or detach
6682         tui_redisplay_source.
6683         * observable.h (source_styling_changed): New observable.
6684         * observable.c: Define source_styling_changed observable.
6685
6686 2019-03-13  Tom Tromey  <tromey@adacore.com>
6687
6688         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6689         (i386_gnu_nat_target::store_registers): Update.
6690         * target-debug.h (target_debug_print_std_string): New macro.
6691         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6692         * windows-tdep.c (display_one_tib): Update.
6693         * tui/tui-stack.c (tui_make_status_line): Update.
6694         * top.c (print_inferior_quit_action): Update.
6695         * thread.c (thr_try_catch_cmd): Update.
6696         (add_thread_with_info): Update.
6697         (thread_target_id_str): Update.
6698         (thr_try_catch_cmd): Update.
6699         (thread_command): Update.
6700         (thread_find_command): Update.
6701         * record-btrace.c (record_btrace_target::info_record)
6702         (record_btrace_resume_thread, record_btrace_target::resume)
6703         (record_btrace_cancel_resume, record_btrace_step_thread)
6704         (record_btrace_target::wait, record_btrace_target::wait)
6705         (record_btrace_target::wait, record_btrace_target::stop): Update.
6706         * progspace.c (print_program_space): Update.
6707         * process-stratum-target.c
6708         (process_stratum_target::thread_address_space): Update.
6709         * linux-fork.c (linux_fork_mourn_inferior)
6710         (detach_checkpoint_command, info_checkpoints_command)
6711         (linux_fork_context): Update.
6712         (linux_fork_detach): Update.
6713         (class scoped_switch_fork_info): Update.
6714         (delete_checkpoint_command): Update.
6715         * infrun.c (follow_fork_inferior): Update.
6716         (follow_fork_inferior): Update.
6717         (proceed_after_vfork_done): Update.
6718         (handle_vfork_child_exec_or_exit): Update.
6719         (follow_exec): Update.
6720         (displaced_step_prepare_throw): Update.
6721         (displaced_step_restore): Update.
6722         (start_step_over): Update.
6723         (resume_1): Update.
6724         (clear_proceed_status_thread): Update.
6725         (proceed): Update.
6726         (print_target_wait_results): Update.
6727         (do_target_wait): Update.
6728         (context_switch): Update.
6729         (stop_all_threads): Update.
6730         (restart_threads): Update.
6731         (finish_step_over): Update.
6732         (handle_signal_stop): Update.
6733         (switch_back_to_stepped_thread): Update.
6734         (keep_going_pass_signal): Update.
6735         (print_exited_reason): Update.
6736         (normal_stop): Update.
6737         * inferior.c (inferior_pid_to_str): Change return type.
6738         (print_selected_inferior): Update.
6739         (add_inferior): Update.
6740         (detach_inferior): Update.
6741         * dummy-frame.c (fprint_dummy_frames): Update.
6742         * dcache.c (dcache_info_1): Update.
6743         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6744         (btrace_fetch, btrace_clear): Update.
6745         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6746         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6747         type.
6748         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6749         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6750         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6751         * gdbarch.c, gdbarch.h: Rebuild.
6752         * gdbarch.sh (core_pid_to_str): Change return type.
6753         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6754         return type.
6755         (windows_nat_target::pid_to_str): Change return type.
6756         (windows_delete_thread): Update.
6757         (windows_nat_target::attach): Update.
6758         (windows_nat_target::files_info): Update.
6759         * target-delegates.c: Rebuild.
6760         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6761         return type.
6762         (sol_thread_target::pid_to_str): Change return type.
6763         * remote.c (class remote_target) <pid_to_str>: Change return
6764         type.
6765         (remote_target::pid_to_str): Change return type.
6766         (extended_remote_target::attach, remote_target::remote_stop_ns)
6767         (remote_target::remote_notif_remove_queued_reply)
6768         (remote_target::push_stop_reply, remote_target::disable_btrace):
6769         Update.
6770         (extended_remote_target::attach): Update.
6771         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6772         type.
6773         (gdbsim_target::pid_to_str): Change return type.
6774         * ravenscar-thread.c (struct ravenscar_thread_target)
6775         <pid_to_str>: Change return type.
6776         (ravenscar_thread_target::pid_to_str): Change return type.
6777         * procfs.c (class procfs_target) <pid_to_str>: Change return
6778         type.
6779         (procfs_target::pid_to_str): Change return type.
6780         (procfs_target::attach): Update.
6781         (procfs_target::detach): Update.
6782         (procfs_target::fetch_registers): Update.
6783         (procfs_target::store_registers): Update.
6784         (procfs_target::wait): Update.
6785         (procfs_target::files_info): Update.
6786         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6787         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6788         return type.
6789         (nto_procfs_target::pid_to_str): Change return type.
6790         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6791         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6792         return type.
6793         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6794         (exit_lwp): Update.
6795         (attach_proc_task_lwp_callback, get_detach_signal)
6796         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6797         (linux_nat_target::resume, wait_lwp, stop_callback)
6798         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6799         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6800         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6801         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6802         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6803         type.
6804         (inf_ptrace_target::attach): Update.
6805         (inf_ptrace_target::files_info): Update.
6806         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6807         type.
6808         (go32_nat_target::pid_to_str): Change return type.
6809         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6810         (gnu_nat_target::wait): Update.
6811         (gnu_nat_target::wait): Update.
6812         (gnu_nat_target::resume): Update.
6813         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6814         (fbsd_nat_target::wait): Update.
6815         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6816         type.
6817         (darwin_nat_target::attach): Update.
6818         * corelow.c (class core_target) <pid_to_str>: Change return type.
6819         (core_target::pid_to_str): Change return type.
6820         * target.c (normal_pid_to_str): Change return type.
6821         (default_pid_to_str): Likewise.
6822         (target_pid_to_str): Change return type.
6823         (target_translate_tls_address): Update.
6824         (target_announce_detach): Update.
6825         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6826         return type.
6827         (bsd_uthread_target::pid_to_str): Change return type.
6828         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6829         type.
6830         (bsd_kvm_target::pid_to_str): Change return type.
6831         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6832         return type.
6833         (aix_thread_target::pid_to_str): Change return type.
6834         * target.h (struct target_ops) <pid_to_str>: Change return type.
6835         (target_pid_to_str, normal_pid_to_str): Likewise.
6836         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6837         type.
6838         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6839         type.
6840         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6841         return type.
6842         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6843         type.
6844         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6845         type.
6846         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6847         return type.
6848
6849 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6850
6851         * NEWS: Mention that the new default MI version is 3.  Mention
6852         changes to the output of commands and events that deal with
6853         multi-location breakpoints.
6854         * breakpoint.c: Include "mi/mi-out.h".
6855         (print_one_breakpoint): Change output syntax if using MI version
6856         >= 3.
6857         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6858         New.
6859         (mi_multi_location_breakpoint_output_fixed): New.
6860         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6861         (mi_cmd_fix_multi_location_breakpoint_output): New.
6862         (mi_multi_location_breakpoint_output_fixed): New.
6863         * mi/mi-cmds.c (mi_cmds): Register command
6864         -fix-multi-location-breakpoint-output.
6865         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6866         interpreter "mi".
6867
6868 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6869
6870         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6871         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6872         instantiate mi_ui_out based on interpreter name.
6873         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6874         * mi/mi-main.c (mi_load_progress): Likewise.
6875
6876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6877
6878         * NEWS: Combine separate "New targets" sections for 8.3.
6879
6880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6881
6882         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6883         (ppcfbsd_init_abi): Install gdbarch
6884         "fetch_tls_load_module_address" and "get_thread_local_address"
6885         methods.
6886
6887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6888
6889         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6890         (riscv_fbsd_init_abi): Install gdbarch
6891         "fetch_tls_load_module_address" and "get_thread_local_address"
6892         methods.
6893
6894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6895
6896         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6897         (i386fbsd_init_abi): Install gdbarch
6898         "fetch_tls_load_module_address" and "get_thread_local_address"
6899         methods.
6900
6901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6902
6903         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6904         (amd64fbsd_init_abi): Install gdbarch
6905         "fetch_tls_load_module_address" and "get_thread_local_address"
6906         methods.
6907
6908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6909
6910         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6911         (struct fbsd_pspace_data): New type.
6912         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6913         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6914         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6915         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6916         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6917
6918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6919
6920         * gdbtypes.c (lookup_struct_elt): New function.
6921         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6922         * gdbtypes.h (struct struct_elt): New type.
6923         (lookup_struct_elt): New prototype.
6924
6925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6926
6927         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6928         remove disabled code block.
6929
6930 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6931
6932         * gdbarch.sh (get_thread_local_address): New method.
6933         * gdbarch.h, gdbarch.c: Regenerate.
6934         * target.c (target_translate_tls_address): Use
6935         gdbarch_get_thread_local_address if present instead of
6936         target::get_thread_local_address.
6937
6938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6939
6940         * target.h (target::get_thread_local_address): Update comment.
6941
6942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6943
6944         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6945         objfile->separate_debug_objfile_backlink if not NULL.
6946
6947 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6948
6949         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6950         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6951         (amd64bsd_store_inferior_registers): Likewise.
6952         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6953         Enable segment base registers.
6954         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6955         PT_GETFSBASE and PT_GETGSBASE.
6956         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6957         PT_SETGSBASE.
6958         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6959         segment base registers.
6960         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6961
6962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6963
6964         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6965         Update calls to i386_target_description to add 'segments'
6966         parameter.
6967         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6968         add segment base registers.
6969         * arch/i386.c (i386_create_target_description): Add 'segments'
6970         parameter to enable segment base registers.
6971         * arch/i386.h (i386_create_target_description): Likewise.
6972         * features/i386/32bit-segments.xml: New file.
6973         * features/i386/32bit-segments.c: Generate.
6974         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6975         call to i386_target_description to add 'segments' parameter.
6976         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6977         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6978         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6979         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6980         if feature is present.
6981         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6982         Add 'segments' parameter to call to i386_target_description.
6983         (i386_target_description): Add 'segments' parameter to enable
6984         segment base registers.
6985         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6986         to call to i386_target_description.
6987         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6988         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6989         Define I386_NUM_REGS.
6990         (i386_target_description): Add 'segments' parameter to enable
6991         segment base registers.
6992
6993 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6994
6995         PR/24325
6996         * source-cache.c: #undef open and close, to avoid unresolved
6997         externals during linking.
6998
6999 2019-03-12  Tom Tromey  <tromey@adacore.com>
7000
7001         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7002         const.  Add initializers.
7003         (_initialize_remote): Don't initialize ptid globals.
7004
7005 2019-03-12  Pedro Alves  <palves@redhat.com>
7006
7007         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7008
7009 2019-03-12  Pedro Alves  <palves@redhat.com>
7010
7011         * cp-name-parser.y (main): Remove unused 'len' variable.
7012
7013 2019-03-12  Tom Tromey  <tromey@adacore.com>
7014
7015         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7016         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7017
7018 2019-03-12  Tom Tromey  <tromey@adacore.com>
7019
7020         * linux-nat.c (iterate_over_lwps): Update.
7021         (stop_callback): Remove parameter.
7022         (stop_wait_callback, detach_callback, resume_set_callback)
7023         (select_singlestep_lwp_callback, set_ignore_sigint)
7024         (status_callback, resumed_callback, resume_clear_callback)
7025         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7026         data parameter.
7027         (linux_nat_target::detach, linux_nat_target::resume)
7028         (linux_stop_and_wait_all_lwps, select_event_lwp)
7029         (linux_nat_filter_event, linux_nat_wait_1)
7030         (linux_nat_target::kill, linux_nat_target::stop)
7031         (linux_nat_target::stop): Update.
7032         (linux_nat_resume_callback): Change type.
7033         (resume_stopped_resumed_lwps, count_events_callback)
7034         (select_event_lwp_callback): Likewise.
7035         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7036         * arm-linux-nat.c (struct update_registers_data): Remove.
7037         (update_registers_callback): Change type.
7038         (arm_linux_insert_hw_breakpoint1): Update.
7039         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7040         parameter.
7041         (x86_linux_dr_set_addr): Update.
7042         (x86_linux_dr_set_control): Update.
7043         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7044         (iterate_over_lwps): Use gdb::function_view.
7045         * nat/aarch64-linux-hw-point.c (struct
7046         aarch64_dr_update_callback_param): Remove.
7047         (debug_reg_change_callback): Change type.
7048         (aarch64_notify_debug_reg_change): Update.
7049         * s390-linux-nat.c (s390_refresh_per_info): Update.
7050
7051 2019-03-11  Tom Tromey  <tromey@adacore.com>
7052
7053         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7054         redundant assignment to "this_cu".
7055
7056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7057
7058         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7059
7060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7061
7062         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7063         from...
7064         (rank_one_type): ... this.
7065
7066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7067
7068         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7069         from...
7070         (rank_one_type): ... this.
7071
7072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7073
7074         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7075         from...
7076         (rank_one_type): ... this.
7077
7078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7079
7080         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7081         from...
7082         (rank_one_type): ... this.
7083
7084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7085
7086         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7087         from...
7088         (rank_one_type): ... this.
7089
7090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7091
7092         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7093         from...
7094         (rank_one_type): ... this.
7095
7096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7097
7098         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7099         from...
7100         (rank_one_type): ... this.
7101
7102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7103
7104         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7105         from...
7106         (rank_one_type): ... this.
7107
7108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7109
7110         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7111         from...
7112         (rank_one_type): ... this.
7113
7114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7115
7116         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7117         from...
7118         (rank_one_type): ... this.
7119
7120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7121
7122         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7123         from...
7124         (rank_one_type): ... this.
7125
7126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7127
7128         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7129         from...
7130         (rank_one_type): ... this.
7131
7132 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7133
7134         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7135         inferior-events' shows the example events.
7136
7137 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7138
7139         Support styling on native MS-Windows console
7140
7141         PR/24315
7142         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7143         on MS-Windows if $TERM is not defined.
7144
7145         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7146
7147         * posix-hdep.c (gdb_console_fputs):
7148         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7149         functions.
7150         * ui-file.h (gdb_console_fputs): Add prototype.
7151
7152         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7153         back to fputs only if the former returns zero.
7154
7155 2019-03-07  Tom Tromey  <tom@tromey.com>
7156
7157         * symmisc.c (print_symbol_bcache_statistics): Update.
7158         (print_objfile_statistics): Update.
7159         * symfile.c (allocate_symtab): Update.
7160         * stabsread.c: Don't include bcache.h.
7161         * psymtab.h (struct psymbol_bcache): Don't declare.
7162         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7163         (psymbol_bcache_init, psymbol_bcache_free)
7164         (psymbol_bcache_get_bcache): Don't declare.
7165         * psymtab.c (struct psymbol_bcache): Remove.
7166         (psymtab_storage::psymtab_storage): Update.
7167         (psymtab_storage::~psymtab_storage): Update.
7168         (psymbol_bcache_init, psymbol_bcache_free)
7169         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7170         (add_psymbol_to_bcache): Update.
7171         (allocate_psymtab): Update.
7172         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7173         macro_cache>: No longer pointers.
7174         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7175         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7176         * macrotab.c (macro_bcache): Update.
7177         * macroexp.c: Don't include bcache.h.
7178         * gdbtypes.c (check_types_worklist): Update.
7179         (types_deeply_equal): Remove TRY/CATCH.  Update.
7180         * elfread.c (elf_symtab_read): Update.
7181         * dwarf2read.c: Don't include bcache.h.
7182         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7183         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7184         (print_bcache_statistics, bcache_memory_used): Don't declare.
7185         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7186         methods.  Rename all data members.
7187         * bcache.c (struct bcache): Move to bcache.h.
7188         (bcache::expand_hash_table): Rename from expand_hash_table.
7189         (bcache): Remove.
7190         (bcache::insert): Rename from bcache_full.
7191         (bcache::compare): Rename from bcache_compare.
7192         (bcache_xmalloc): Remove.
7193         (bcache::~bcache): Rename from bcache_xfree.
7194         (bcache::print_statistics): Rename from print_bcache_statistics.
7195         (bcache::memory_used): Rename from bcache_memory_used.
7196
7197 2019-03-07  Pedro Alves  <palves@redhat.com>
7198
7199         * infrun.c (normal_stop): Also check for
7200         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7201
7202 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7203
7204         * f-lang.c (value_from_host_double): Moved to...
7205         * value.c (value_from_host_double): ...here.
7206         * value.h (value_from_host_double): Declare.
7207         * guile/scm-math.c (vlscm_convert_typed_number): Use
7208         value_from_host_double.
7209         (vlscm_convert_number): Likewise.
7210         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7211         * python/py-value.c (convert_value_from_python): Likewise.
7212
7213 2019-03-06  Tom Tromey  <tom@tromey.com>
7214
7215         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7216
7217 2019-03-06  Tom Tromey  <tom@tromey.com>
7218
7219         * utils.h (free_current_contents): Don't declare.
7220         * utils.c (free_current_contents): Remove.
7221
7222 2019-03-06  Tom Tromey  <tom@tromey.com>
7223
7224         * top.c (quit_force): Update.
7225         * main.c (captured_command_loop): Update.
7226         * common/new-op.c (operator new): Update.
7227         * common/common-exceptions.c (struct catcher)
7228         <save_cleanup_chain>: Remove member.
7229         (exceptions_state_mc_init): Update.
7230         (exception_try_scope_entry): Return nullptr.
7231         (exception_try_scope_exit, exception_rethrow)
7232         (throw_exception_sjlj, throw_exception_cxx): Update.
7233         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7234         (all_cleanups, do_cleanups, discard_cleanups)
7235         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7236         (restore_cleanups, restore_final_cleanups): Don't declare.
7237         (do_final_cleanups): Remove parameter.
7238         * common/cleanups.c (cleanup_chain, make_cleanup)
7239         (make_cleanup_dtor, all_cleanups, do_cleanups)
7240         (discard_my_cleanups, discard_cleanups)
7241         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7242         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7243         (null_cleanup): Remove.
7244         (do_final_cleanups): Remove parameter.
7245
7246 2019-03-06  Tom Tromey  <tom@tromey.com>
7247
7248         * remote.c (remote_target::remote_parse_stop_reply): Use
7249         unique_xmalloc_ptr.
7250
7251 2019-03-06  Tom Tromey  <tom@tromey.com>
7252
7253         * stabsread.c (struct stabs_field_info): Rename from field_info.
7254         <list, fnlist>: Add initializers.
7255         <obstack>: New member.
7256         (read_member_functions, read_struct_fields, read_baseclasses):
7257         Allocate on obstack.  Don't use cleanups.
7258         (read_one_struct_field, read_member_functions, read_struct_fields)
7259         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7260         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7261         (read_struct_type): Update.
7262
7263 2019-03-06  Tom Tromey  <tom@tromey.com>
7264
7265         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7266         * common/filestuff.h (make_cleanup_close): Don't declare.
7267         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7268         Remove.
7269
7270 2019-03-06  Tom Tromey  <tom@tromey.com>
7271
7272         * solib-aix.c: Use make_scope_exit.
7273
7274 2019-03-06  Tom Tromey  <tom@tromey.com>
7275
7276         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7277         Use make_scope_exit.
7278
7279 2019-03-06  Tom Tromey  <tom@tromey.com>
7280
7281         * solib-svr4.c (disable_probes_interface): Remove parameter.
7282         (svr4_handle_solib_event): Use make_scope_exit.
7283
7284 2019-03-06  Tom Tromey  <tom@tromey.com>
7285
7286         * remote.c (struct stop_reply_deleter): Remove.
7287         (stop_reply_up): Update.
7288         (struct stop_reply): Derive from notif_event.  Don't typedef.
7289         <regcache>: Now a std::vector.
7290         (stop_reply_xfree): Remove.
7291         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7292         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7293         (remote_target::discard_pending_stop_replies): Use delete.
7294         (remote_target::remote_parse_stop_reply): Update.
7295         (remote_target::process_stop_reply): Update.
7296         * remote-notif.h (struct notif_event): Add virtual destructor.
7297         Remove "dtr" member.
7298         (struct notif_client) <alloc_event>: Return a unique_ptr.
7299         (notif_event_xfree): Don't declare.
7300         (notif_event_up): New typedef.
7301         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7302         (notif_event_xfree, do_notif_event_xfree): Remove.
7303         (remote_notif_state_xfree): Update.
7304
7305 2019-03-06  Tom Tromey  <tom@tromey.com>
7306
7307         * infrun.c (displaced_step_clear_cleanup): Now a
7308         forward_scope_exit type.
7309         (displaced_step_prepare_throw): Update.
7310         (displaced_step_fixup): Update.
7311
7312 2019-03-06  Tom Tromey  <tom@tromey.com>
7313
7314         * inferior.h (class inferior): Update comment.
7315         * gdbthread.h (class thread_info): Update comment.
7316
7317 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7318             Tom Tromey  <tom@tromey.com>
7319
7320         * stabsread.h (struct stab_section_list): Remove.
7321         (coffstab_build_psymtabs): Update.
7322         * dbxread.c (symbuf_sections): Now a std::vector.
7323         (sect_idx): New global.
7324         (fill_symbuf): Update.
7325         (coffstab_build_psymtabs): Change type of stabsects parameter.
7326         Update.
7327         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7328         std::vector.
7329         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7330         (coff_locate_sections): Update.
7331         (coff_symfile_read): Remove cleanups.  Update.
7332         (init_stringtab): Add storage parameter.
7333         (free_stringtab, free_stringtab_cleanup): Remove.
7334         (init_lineno): Add storage parameter.
7335         (free_linetab, free_linetab_cleanup): Remove.
7336
7337 2019-03-06  Pedro Alves  <palves@redhat.com>
7338
7339         * linux-fork.c (fork_info::clobber_regs): Delete.
7340         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7341         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7342         comment.  Adjust.
7343         (scoped_switch_fork_info::scoped_switch_fork_info)
7344         (checkpoint_command, linux_fork_context): Adjust
7345         fork_save_infrun_state calls.
7346
7347 2019-03-06  Pedro Alves  <palves@redhat.com>
7348
7349         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7350         (inf_has_multiple_threads): Return 'bool' and rewrite using
7351         inferior_info::threads().
7352
7353 2019-03-06  Pedro Alves  <palves@redhat.com>
7354
7355         * linux-fork.c: Include <list>.
7356         (fork_list): Now a std::list instance.
7357         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7358         (forks_exist_p, find_last_fork): Adjust.
7359         (new_fork): Delete.
7360         (one_fork_p): New.
7361         (add_fork): Adjust.
7362         (free_fork): Delete, folded into fork_info::~fork_info().
7363         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7364         Adjust.
7365         (init_fork_list): Delete.
7366         (linux_fork_killall, linux_fork_mourn_inferior)
7367         (linux_fork_detach, info_checkpoints_command): Adjust.
7368         (_initialize_linux_fork): No longer call init_fork_list.
7369
7370 2019-03-06  Pedro Alves  <palves@redhat.com>
7371
7372         * linux-fork.c (new_fork): New, split out of ...
7373         (add_fork): ... this.  Return void.  Move "first fork" special
7374         case from here, to ...
7375         (checkpoint_command): ... here.
7376         * linux-linux.h (add_fork): Return void.
7377
7378 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7381
7382 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7383             Chris January  <chris.january@arm.com>
7384             David Lecomber  <david.lecomber@arm.com>
7385
7386         * f-exp.y: New token, UNOP_INTRINSIC.
7387         (exp): New pattern using UNOP_INTRINSIC token.
7388         (f77_keywords): Add 'abs' keyword.
7389         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7390         (value_from_host_double): New function.
7391         (evaluate_subexp_f): Support UNOP_ABS.
7392
7393 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7394
7395         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7396         types.
7397
7398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7401         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7402         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7403
7404 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7405
7406         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7407
7408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7409             Chris January  <chris.january@arm.com>
7410
7411         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7412         * f-exp.y: Define 'KIND' token.
7413         (exp): New pattern for KIND expressions.
7414         (ptype): Handle types with a kind extension.
7415         (direct_abs_decl): Extend to spot kind extensions.
7416         (f77_keywords): Add 'kind' to the list.
7417         (push_kind_type): New function.
7418         (convert_to_kind_type): New function.
7419         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7420         * parse.c (operator_length_standard): Likewise.
7421         * parser-defs.h (enum type_pieces): Add tp_kind.
7422         * std-operator.def: Add UNOP_KIND.
7423
7424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * f-exp.y (f_parse): Set yydebug.
7427
7428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * f-lang.c (evaluate_subexp_f): New function.
7431         (exp_descriptor_f): New global.
7432         (f_language_defn): Use exp_descriptor_f instead of
7433         exp_descriptor_standard.
7434
7435 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7436
7437         * f-exp.y (struct token): Add comments.
7438         (dot_ops): Remove uppercase versions and the end marker.
7439         (f77_keywords): Likewise.
7440         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7441         entries in the dot_ops array are case insensitive, and use
7442         strncasecmp to compare strings.  Also some whitespace cleanup in
7443         this area.  Similar for the f77_keywords array, except entries in
7444         this list might be case sensitive.
7445
7446 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * f-exp.y (struct f77_boolean_val): Add comments.
7449         (boolean_values): Remove uppercase versions, and end marker.
7450         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7451         and use strncasecmp to achieve case insensitivity.  Additionally,
7452         perform whitespace cleanup around this code.
7453
7454 2019-03-06  Tom Tromey  <tromey@adacore.com>
7455
7456         * remote-sim.c (gdbsim_target_open): Use result of
7457         gdb_argv::release.
7458
7459 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7460         Dirk Schubert  <dirk.schubert@arm.com>
7461         Chris January  <chris.january@arm.com>
7462
7463         * eval.c (evaluate_subexp_standard): Call Fortran argument
7464         wrapping logic.
7465         * f-lang.c (struct value): A value which can be passed into a
7466         Fortran function call.
7467         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7468         where appropriate.
7469         (struct type): Value ready for a Fortran function call.
7470         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7471         is needed.
7472         * f-lang.h (fortran_argument_convert): Declaration.
7473         (fortran_preserve_arg_pointer): Declaration.
7474         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7475
7476 2019-03-05  Tom Tromey  <tromey@adacore.com>
7477
7478         * python/py-prettyprint.c (print_string_repr): Remove #if.
7479         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7480
7481 2019-03-05  Tom Tromey  <tromey@adacore.com>
7482
7483         * target.c (the_dummy_target): Move later.  Change type to
7484         "dummy_target".
7485         (initialize_targets): Don't initialize the_dummy_target.
7486
7487 2019-03-05  Tom Tromey  <tromey@adacore.com>
7488
7489         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7490         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7491
7492 2019-03-05  Tom Tromey  <tromey@adacore.com>
7493
7494         * windows-nat.c (windows_nat_target::attach)
7495         (windows_nat_target::detach): Don't call gdb_flush.
7496         * valprint.c (generic_val_print, val_print, val_print_string):
7497         Don't call gdb_flush.
7498         * utils.c (defaulted_query): Don't call gdb_flush.
7499         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7500         * target.c (target_announce_detach): Don't call gdb_flush.
7501         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7502         * remote.c (extended_remote_target::attach): Don't call
7503         gdb_flush.
7504         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7505         * printcmd.c (do_examine): Don't call gdb_flush.
7506         (info_display_command): Don't call gdb_flush.
7507         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7508         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7509         * memattr.c (info_mem_command): Don't call gdb_flush.
7510         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7511         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7512         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7513         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7514         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7515         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7516         (gnu_nat_target::detach): Don't call gdb_flush.
7517         * f-valprint.c (f_val_print): Don't call gdb_flush.
7518         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7519         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7520         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7521         gdb_flush.
7522         * c-valprint.c (c_val_print): Don't call gdb_flush.
7523         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7524
7525 2019-03-05  Tom Tromey  <tromey@adacore.com>
7526
7527         * varobj.c (update_dynamic_varobj_children): Update.
7528         (install_default_visualizer): Use reset, not release.
7529         * value.c (set_internalvar): Update.
7530         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7531         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7532         ATTRIBUTE_UNUSED_RESULT.
7533
7534 2019-03-05  Tom Tromey  <tromey@adacore.com>
7535
7536         * remote.c (class scoped_remote_fd) <release>: Add
7537         ATTRIBUTE_UNUSED_RESULT.
7538
7539 2019-03-05  Tom Tromey  <tromey@adacore.com>
7540
7541         * macroexp.c (struct macro_buffer) <release>: Add
7542         ATTRIBUTE_UNUSED_RESULT.
7543
7544 2019-03-05  Tom Tromey  <tromey@adacore.com>
7545
7546         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7547         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7548         ATTRIBUTE_UNUSED_RESULT.
7549
7550 2019-03-05  Tom Tromey  <tromey@adacore.com>
7551
7552         * common/scoped_fd.h (class scoped_fd) <release>: Add
7553         ATTRIBUTE_UNUSED_RESULT.
7554
7555 2019-03-05  Tom Tromey  <tromey@adacore.com>
7556
7557         * parser-defs.h (struct parser_state) <release>: Add
7558         ATTRIBUTE_UNUSED_RESULT.
7559
7560 2019-03-05  Tom Tromey  <tromey@adacore.com>
7561
7562         * utils.h (class gdb_argv) <release>: Add
7563         ATTRIBUTE_UNUSED_RESULT.
7564         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7565
7566 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7567
7568         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7569         for-loop range, to avoid compiler warnings.
7570
7571         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7572         avoid compiler warnings about unused variables.
7573
7574         * NEWS: Mention end of support for native debugging on MS-Windows
7575         before XP.
7576
7577         PR gdb/24292
7578         * common/netstuff.c:
7579         * gdbserver/gdbreplay.c
7580         * gdbserver/remote-utils.c:
7581         * ser-tcp.c:
7582         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7583         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7584         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7585         'getaddrinfo' and 'freeaddrinfo' were not available before
7586         Windows XP, and mingw.org's MinGW headers by default define
7587         _WIN32_WINNT to 0x500.
7588
7589 2019-03-01  Gary Benson <gbenson@redhat.com>
7590
7591         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7592
7593 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7594             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7595
7596         PR gdb/8527
7597         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7598         set_sigint_trap, clear_sigint_trap.
7599
7600 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7601
7602         * target.c (target_detach): Clear the regcache and the
7603         frame cache.
7604
7605 2019-02-27  Pedro Alves  <palves@redhat.com>
7606
7607         * utils.c (set_screen_size): When we cap the height/width sizes,
7608         tweak the corresponding command variable to show "unlimited":
7609
7610 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7611             Pedro Alves  <palves@redhat.com>
7612
7613         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7614         before calling rl_set_screen_size.
7615
7616 2019-02-27  Tom Tromey  <tromey@adacore.com>
7617
7618         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7619         define.
7620         * python/py-value.c: Remove Python 2.4 workaround.
7621         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7622         workaround.
7623         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7624         Python 2.4 workaround.
7625         * python/python-internal.h: Remove Python 2.4 comment.
7626         (Py_ssize_t): Don't define.
7627         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7628         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7629         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7630         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7631         * python/python.c (do_start_initialization): Remove Python 2.4
7632         workaround.
7633         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7634         (print_children): Remove Python 2.4 workaround.
7635         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7636         workaround.
7637         (CHARBUFFERPROC_NAME): Remove.
7638         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7639         Python 2.4 workaround.
7640
7641 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7642
7643         * NEWS: Note minimum Python version.
7644
7645 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7646
7647         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7648         code from these functions.  Remove corresponding ifdefs.  Use
7649         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7650         Remove gotos and target of gotos.
7651         (infpy_search_memory): Likewise.
7652
7653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7654
7655         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7656         (hppa_gdbarch_init): Don't register deleted functions with
7657         gdbarch.
7658
7659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7660
7661         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7662         (h8300_unwind_sp): Delete.
7663         (h8300_dummy_id): Delete.
7664         (h8300_gdbarch_init): Don't register deleted functions with
7665         gdbarch.
7666
7667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7668
7669         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7670         (ft32_unwind_pc): Delete.
7671         (ft32_unwind_sp): Delete.
7672         (ft32_gdbarch_init): Don't register deleted functions with
7673         gdbarch.
7674
7675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7676
7677         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7678         (frv_unwind_pc): Delete.
7679         (frv_unwind_sp): Delete.
7680         (frv_gdbarch_init): Don't register deleted functions with
7681         gdbarch.
7682
7683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7684
7685         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7686         (riscv_unwind_pc): Delete.
7687         (riscv_unwind_sp): Delete.
7688         (riscv_gdbarch_init): Don't register deleted functions with
7689         gdbarch.
7690
7691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7694         (csky_unwind_pc): Delete.
7695         (csky_unwind_sp): Delete.
7696         (csky_gdbarch_init): Don't register deleted functions with
7697         gdbarch.
7698
7699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7702         (cris_unwind_pc): Delete.
7703         (cris_unwind_sp): Delete.
7704         (cris_gdbarch_init): Don't register deleted functions with
7705         gdbarch.
7706
7707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7708
7709         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7710         (bfin_unwind_pc): Delete.
7711         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7712
7713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7716         (arm_unwind_pc): Delete.
7717         (arm_unwind_sp): Delete.
7718         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7719
7720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7721
7722         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7723         (arc_unwind_pc): Delete.
7724         (arc_unwind_sp): Delete.
7725         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7726
7727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7728
7729         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7730         (alpha_unwind_pc): Delete.
7731         (alpha_gdbarch_init): Don't register deleted functions with
7732         gdbarch.
7733
7734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7735
7736         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7737         (aarch64_unwind_pc): Delete.
7738         (aarch64_unwind_sp): Delete.
7739         (aarch64_gdbarch_init): Don't register deleted functions with
7740         gdbarch.
7741
7742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * gdbtypes.c (type_align): Don't consider static members when
7745         computing structure alignment.
7746
7747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7748
7749         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7750         return 0 for other types.
7751         * arch-utils.c (default_type_align): Always return 0.
7752         * gdbarch.h: Regenerate.
7753         * gdbarch.sh (type_align): Extend comment.
7754         * gdbtypes.c (type_align): Add additional comments, always call
7755         gdbarch_type_align before applying the default rules.
7756         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7757         generic code will then apply a suitable default.
7758         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7759         types, return 0 for other types.
7760
7761 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7762
7763         * NEWS: Create a new section for the next release branch.
7764         Rename the section of the current branch, now that it has
7765         been cut.
7766
7767 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7768
7769         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7770         * version.in: Bump version to 8.3.50.DATE-git.
7771
7772 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7773
7774         * aix-thread.c (ptid_cmp): Remove unused variable.
7775         (get_signaled_thread): Likewise.
7776         (store_regs_user_thread): Likewise.
7777         (store_regs_kernel_thread): Likewise.
7778         (fetch_regs_kernel_thread): Remove shadowed variable.
7779
7780 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * features/riscv/32bit-cpu.xml: Add register numbers.
7783         * features/riscv/32bit-fpu.c: Regenerate.
7784         * features/riscv/32bit-fpu.xml: Add register numbers.
7785         * features/riscv/64bit-cpu.xml: Add register numbers.
7786         * features/riscv/64bit-fpu.c: Regenerate.
7787         * features/riscv/64bit-fpu.xml: Add register numbers.
7788
7789 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7790
7791         * NEWS: Mention two argument form of gdb.Value constructor.
7792         * python/py-value.c (convert_buffer_and_type_to_value): New
7793         function.
7794         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7795         Add support for handling an optional second argument.  Call
7796         convert_buffer_and_type_to_value as appropriate.
7797         * python/python-internal.h (Py_buffer_deleter): New struct.
7798         (Py_buffer_up): New typedef.
7799
7800 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7801
7802         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7803         instead of releasing ownership.
7804
7805 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7806
7807         * dwarf2read.c (open_and_init_dwp_file): Call
7808         elf_numsections instead of bfd_count_sections to initialize
7809         dwp_file->num_sections.
7810
7811 2019-02-25  Tom Tromey  <tromey@adacore.com>
7812
7813         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7814
7815 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7816
7817         * gcore.in: Add '--readnever' option when invoking GDB.
7818
7819 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7820
7821         * MAINTAINERS: Update my email address.
7822
7823 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7824
7825         * build-id.c (build_id_to_debug_bfd_1): New function.
7826         (build_id_to_debug_bfd): Look for separate debug file in
7827         sysroot.
7828
7829 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * gdbarch.sh: Update the copyright year range that is placed into
7832         generated files.
7833
7834 2019-02-22  Keith Seitz  <keiths@redhat.com>
7835
7836         PR symtab/23853
7837         * linespec.c (create_sals_line_offset): Search for the default
7838         symtab's filename instead of its fullname.
7839
7840 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7841
7842         * NEWS: Update style defaults.
7843
7844 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7845
7846         * main.c (captured_main_1): Disable styling in batch mode.
7847
7848 2019-02-20  Tom Tromey  <tom@tromey.com>
7849
7850         * symtab.c (symtab_symbol_info): Fix typos.
7851
7852 2019-02-20  Tom Tromey  <tromey@adacore.com>
7853
7854         * findcmd.c (_initialize_mem_search): Use upper case for
7855         metasyntactic variables.
7856
7857 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7858
7859         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7860         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7861
7862 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7863
7864         * top.h (source_file_name): Change to std::string.
7865         * top.c (source_file_name): Likewise.
7866         (command_line_input): Adjust.
7867         * cli/cli-script.c (script_from_file): Adjust.
7868
7869 2019-02-19  Tom Tromey  <tromey@adacore.com>
7870
7871         * ravenscar-thread.c
7872         (ravenscar_thread_target::update_thread_list): Don't call
7873         ada_build_task_list.
7874         * ada-lang.h (ada_build_task_list): Don't declare.
7875         * ada-tasks.c (struct ada_tasks_inferior_data)
7876         <task_list_valid_p>: Now bool.
7877         (read_known_tasks, ada_task_list_changed)
7878         (ada_tasks_invalidate_inferior_data): Update.
7879         (read_known_tasks_array): Return bool.
7880         (read_known_tasks_list): Likewise.
7881         (read_known_tasks): Return void.
7882         (ada_build_task_list): Now static.
7883
7884 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7885
7886         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7887         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7888
7889 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890
7891         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7892         variant for ada_tasks_pspace_data_handle and
7893         ada_tasks_inferior_data_handle.
7894         (ada_tasks_pspace_data_cleanup): New function.
7895         (ada_tasks_inferior_data_cleanup): New function.
7896
7897 2019-02-17  Tom Tromey  <tom@tromey.com>
7898
7899         * macrotab.h (macro_source_fullname): Return a std::string.
7900         * macrotab.c (macro_include, check_for_redefinition)
7901         (macro_undef, macro_lookup_definition, foreach_macro)
7902         (foreach_macro_in_scope): Update.
7903         (macro_source_fullname): Return a std::string.
7904         * macrocmd.c (show_pp_source_pos): Update.
7905
7906 2019-02-17  Tom Tromey  <tom@tromey.com>
7907
7908         * macrocmd.c (show_pp_source_pos): Style the file names.
7909
7910 2019-02-17  Tom Tromey  <tom@tromey.com>
7911
7912         PR tui/24197:
7913         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7914
7915 2019-02-17  Tom Tromey  <tom@tromey.com>
7916
7917         * ada-lang.c (user_select_syms): Use filtered printing.
7918         * utils.c (wrap_style): New global.
7919         (desired_style): Remove.
7920         (emit_style_escape): Add stream parameter.
7921         (set_output_style, reset_terminal_style, prompt_for_continue):
7922         Update.
7923         (flush_wrap_buffer): Only flush gdb_stdout.
7924         (wrap_here): Set wrap_style.
7925         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7926         treat escape sequences as a character.  Change when wrap buffer is
7927         flushed.
7928         (fputs_styled): Do not set the output style when the default is
7929         requested.
7930         * ui-style.h (struct ui_file_style) <is_default>: New method.
7931         * source.c (print_source_lines_base): Emit escape sequences in one
7932         piece.
7933
7934 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7935
7936         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7937         integers and enumeration types.
7938
7939 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7940
7941         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7942         instead of lookup_symbol_in_language
7943         (do_exact_match): New function.
7944         (ada_get_symbol_name_matcher): Return do_exact_match when
7945         doing a verbatim match.
7946
7947 2019-02-15  Tom Tromey  <tromey@adacore.com>
7948
7949         * ravenscar-thread.c (ravenscar_thread_target::resume)
7950         (ravenscar_thread_target::wait): Special case wildcard requests.
7951
7952 2019-02-15  Tom Tromey  <tromey@adacore.com>
7953
7954         * ravenscar-thread.c (base_ptid): Remove.
7955         (struct ravenscar_thread_target) <close>: New method.
7956         <m_base_ptid>: New member.
7957         <update_inferior_ptid, active_task, task_is_currently_active,
7958         runtime_initialized>: Declare methods.
7959         <ravenscar_thread_target>: Add constructor.
7960         (ravenscar_thread_target::task_is_currently_active)
7961         (ravenscar_thread_target::update_inferior_ptid)
7962         (ravenscar_runtime_initialized): Rename.  Now methods.
7963         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7964         (ravenscar_thread_target::update_thread_list): Update.
7965         (ravenscar_thread_target::active_task): Now method.
7966         (ravenscar_thread_target::store_registers)
7967         (ravenscar_thread_target::prepare_to_store)
7968         (ravenscar_thread_target::prepare_to_store)
7969         (ravenscar_thread_target::mourn_inferior): Update.
7970         (ravenscar_inferior_created): Use "new" to create target.
7971         (ravenscar_thread_target::get_ada_task_ptid): Update.
7972         (_initialize_ravenscar): Don't initialize base_ptid.
7973         (ravenscar_ops): Remove global.
7974
7975 2019-02-15  Tom Tromey  <tromey@adacore.com>
7976
7977         * target.h (push_target): Declare new overload.
7978         * target.c (push_target): New overload, taking an rvalue reference.
7979         * remote.c (remote_target::open_1): Use push_target overload.
7980         * corelow.c (core_target_open): Use push_target overload.
7981
7982 2019-02-15  Tom Tromey  <tromey@adacore.com>
7983
7984         * ravenscar-thread.c (is_ravenscar_task)
7985         (ravenscar_task_is_currently_active): Return bool.
7986         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7987         (_initialize_ravenscar): Remove "(void)".
7988         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7989         Return bool.
7990
7991 2019-02-15  Tom Tromey  <tromey@adacore.com>
7992
7993         * ravenscar-thread.c (ravenscar_runtime_initializer)
7994         (has_ravenscar_runtime, get_running_thread_id)
7995         (ravenscar_thread_target::resume): Fix indentation.
7996
7997 2019-02-15  Tom Tromey  <tromey@adacore.com>
7998
7999         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8000         from ravenscar_arch_ops.
8001         (sparc_ravenscar_ops::fetch_registers)
8002         (sparc_ravenscar_ops::store_registers): Now methods.
8003         (sparc_ravenscar_prepare_to_store): Remove.
8004         (sparc_ravenscar_ops): Redefine.
8005         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8006         methods and destructor.  Remove members.
8007         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8008         (ravenscar_thread_target::store_registers)
8009         (ravenscar_thread_target::prepare_to_store): Update.
8010         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8011         Remove.
8012         (struct ppc_ravenscar_powerpc_ops): Derive from
8013         ravenscar_arch_ops.
8014         (ppc_ravenscar_powerpc_ops::fetch_registers)
8015         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8016         (ppc_ravenscar_powerpc_ops): Redefine.
8017         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8018         (ppc_ravenscar_e500_ops::fetch_registers)
8019         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8020         (ppc_ravenscar_e500_ops): Redefine.
8021         * aarch64-ravenscar-thread.c
8022         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8023         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8024         (aarch64_ravenscar_fetch_registers)
8025         (aarch64_ravenscar_store_registers): Now methods.
8026         (aarch64_ravenscar_ops): Redefine.
8027
8028 2019-02-15  Tom Tromey  <tromey@adacore.com>
8029
8030         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8031         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8032         (ravenscar_thread_target::stopped_by_watchpoint)
8033         (ravenscar_thread_target::stopped_data_address)
8034         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8035
8036 2019-02-15  Tom Tromey  <tromey@adacore.com>
8037
8038         * ravenscar-thread.c: Fix some typos.
8039
8040 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041             Tom Tromey  <tromey@adacore.com>
8042
8043         * ada-lang.c (ada_exception_sal): Change addr_string to a
8044         std::string.
8045         (create_ada_exception_catchpoint): Update.
8046
8047 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8048             Tom Tromey  <tromey@adacore.com>
8049
8050         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8051         (bp_location_ops): Remove.
8052         (base_breakpoint_allocate_location): Update.
8053         (free_bp_location): Update.
8054         * ada-lang.c (class ada_catchpoint_location)
8055         <ada_catchpoint_location>: Remove ops parameter.
8056         (ada_catchpoint_location_dtor): Remove.
8057         (ada_catchpoint_location_ops): Remove.
8058         (allocate_location_exception): Update.
8059         * breakpoint.h (struct bp_location_ops): Remove.
8060         (class bp_location) <bp_location>: Remove bp_location_ops
8061         parameter.
8062         <~bp_location>: Add destructor.
8063         <ops>: Remove.
8064
8065 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8066             Pedro Alves  <palves@redhat.com>
8067
8068         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8069         'PATH_MAX'.
8070
8071 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8072             Samuel Thibault  <samuel.thibault@gnu.org>
8073             Thomas Schwinge  <thomas@codesourcery.com>
8074
8075         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8076         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8077
8078 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8079
8080         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8081         (check_empty): Use "const char *".
8082
8083         * gnu-nat.c (gnu_nat_target::detach): Instead of
8084         'detach_inferior (pid)' call
8085         'detach_inferior (find_inferior_pid (pid))'.
8086
8087         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8088         'nat/fork-inferior.o'.
8089         * gnu-nat.c: #include "nat/fork-inferior.h".
8090
8091         * gnu-nat.c (gnu_nat_target::detach): Instead of
8092         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8093         * gnu-nat.h: #include "inf-child.h".
8094         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8095         'i386_gnu_nat_target::fetch_registers'.
8096         (gnu_store_registers): Rename/move to
8097         'i386_gnu_nat_target::store_registers'.
8098
8099         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8100         * gnu-nat.h (mach_thread_info): New function.
8101         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8102
8103         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8104
8105 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8106
8107         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8108
8109 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8110
8111         * windows-nat.c (windows_add_thread): Add new parameter
8112         "main_thread_p" with default value set to false.  Update
8113         function documentation as well as all callers.
8114         (windows_delete_thread): Likewise.
8115         (fake_create_process): Update call to windows_add_thread.
8116         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8117         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8118         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8119         call to windows_delete_thread.
8120
8121 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8122
8123         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8124
8125 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8126
8127         * symfile.c (find_separate_debug_file): Use canonical path of
8128         sysroot with child_path instead of gdb_sysroot if it is valid.
8129
8130 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8131
8132         * symfile.c (find_separate_debug_file): Use child_path to
8133         determine if an object file is under a sysroot.
8134
8135 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8136
8137         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8138         unittests/child-path-selftests.c.
8139         * common/pathstuff.c (child_path): New function.
8140         * common/pathstuff.h (child_path): New prototype.
8141         * unittests/child-path-selftests.c: New file.
8142
8143 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8144
8145         * symfile.c (find_separate_debug_file): Look for separate debug
8146         files in debug directories under the sysroot.
8147
8148 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8149
8150         * symtab.h (struct minimal_symbol data_p): New const method.
8151         (struct minimal_symbol text_p): Likewise.
8152         * symtab.c (output_source_filename): Use file name style
8153         to print file name.
8154         (print_symbol_info): Likewise.
8155         (print_msymbol_info): Use address style to print addresses.
8156         Use function name style to print executable text symbols.
8157         (expand_symtab_containing_pc): Use data_p.
8158         (find_pc_sect_compunit_symtab): Likewise.
8159
8160 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8161
8162         * breakpoint.c (describe_other_breakpoints): Use address style
8163         to print addresses.
8164         (say_where): Likewise.
8165
8166 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8167
8168         * ada-typeprint.c (print_func_type): Print function name
8169         style to print function name.
8170         * c-typeprint.c (c_print_type_1): Likewise.
8171
8172 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8173
8174         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8175         for execve.
8176
8177 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8178
8179         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8180         type_stack.
8181
8182 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8183
8184         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8185         TYPE_CODE_REF types.
8186
8187 2019-02-08  Jim Wilson  <jimw@sifive.com>
8188
8189         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8190         (riscv_linux_fregset): New.
8191         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8192
8193 2019-02-07  Tom Tromey  <tom@tromey.com>
8194
8195         * thread.c (thread_cancel_execution_command): Update.
8196         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8197         methods.
8198         (struct thread_fsm_ops): Remove.
8199         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8200         (thread_fsm_should_stop, thread_fsm_return_value)
8201         (thread_fsm_set_finished, thread_fsm_finished_p)
8202         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8203         Don't declare.
8204         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8205         * infrun.c (clear_proceed_status_thread)
8206         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8207         (print_stop_event): Update.
8208         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8209         Add constructor.
8210         (step_command_fsm_ops): Remove.
8211         (new_step_command_fsm): Remove.
8212         (step_1): Update.
8213         (step_command_fsm::should_stop): Rename from
8214         step_command_fsm_should_stop.
8215         (step_command_fsm::clean_up): Rename from
8216         step_command_fsm_clean_up.
8217         (step_command_fsm::do_async_reply_reason): Rename from
8218         step_command_fsm_async_reply_reason.
8219         (struct until_next_fsm): Inherit from thread_fsm.  Add
8220         constructor.
8221         (until_next_fsm_ops): Remove.
8222         (new_until_next_fsm): Remove.
8223         (until_next_fsm::should_stop): Rename from
8224         until_next_fsm_should_stop.
8225         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8226         (until_next_fsm::do_async_reply_reason): Rename from
8227         until_next_fsm_async_reply_reason.
8228         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8229         constructor.  Change type of breakpoint.
8230         (finish_command_fsm_ops): Remove.
8231         (new_finish_command_fsm): Remove.
8232         (finish_command_fsm::should_stop): Rename from
8233         finish_command_fsm_should_stop.
8234         (finish_command_fsm::clean_up): Rename from
8235         finish_command_fsm_clean_up.
8236         (finish_command_fsm::return_value): Rename from
8237         finish_command_fsm_return_value.
8238         (finish_command_fsm::do_async_reply_reason): Rename from
8239         finish_command_fsm_async_reply_reason.
8240         (finish_command): Update.
8241         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8242         Add constructor.
8243         (call_thread_fsm_ops): Remove.
8244         (call_thread_fsm::call_thread_fsm): Rename from
8245         new_call_thread_fsm.
8246         (call_thread_fsm::should_stop): Rename from
8247         call_thread_fsm_should_stop.
8248         (call_thread_fsm::should_notify_stop): Rename from
8249         call_thread_fsm_should_notify_stop.
8250         (run_inferior_call, call_function_by_hand_dummy): Update.
8251         * cli/cli-interp.c (should_print_stop_to_console): Update.
8252         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8253         Add constructor.  Change type of location_breakpoint,
8254         caller_breakpoint.
8255         (until_break_fsm_ops): Remove.
8256         (new_until_break_fsm): Remove.
8257         (until_break_fsm::should_stop): Rename from
8258         until_break_fsm_should_stop.
8259         (until_break_fsm::clean_up): Rename from
8260         until_break_fsm_clean_up.
8261         (until_break_fsm::do_async_reply_reason): Rename from
8262         until_break_fsm_async_reply_reason.
8263         (until_break_command): Update.
8264         * thread-fsm.c: Remove.
8265         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8266
8267 2019-02-07  Tom Tromey  <tom@tromey.com>
8268
8269         * yy-remap.h: Add include guard.
8270         * xtensa-tdep.h: Add include guard.
8271         * xcoffread.h: Rename include guard.
8272         * varobj-iter.h: Add include guard.
8273         * tui/tui.h: Rename include guard.
8274         * tui/tui-winsource.h: Rename include guard.
8275         * tui/tui-wingeneral.h: Rename include guard.
8276         * tui/tui-windata.h: Rename include guard.
8277         * tui/tui-win.h: Rename include guard.
8278         * tui/tui-stack.h: Rename include guard.
8279         * tui/tui-source.h: Rename include guard.
8280         * tui/tui-regs.h: Rename include guard.
8281         * tui/tui-out.h: Rename include guard.
8282         * tui/tui-layout.h: Rename include guard.
8283         * tui/tui-io.h: Rename include guard.
8284         * tui/tui-hooks.h: Rename include guard.
8285         * tui/tui-file.h: Rename include guard.
8286         * tui/tui-disasm.h: Rename include guard.
8287         * tui/tui-data.h: Rename include guard.
8288         * tui/tui-command.h: Rename include guard.
8289         * tic6x-tdep.h: Add include guard.
8290         * target/waitstatus.h: Rename include guard.
8291         * target/wait.h: Rename include guard.
8292         * target/target.h: Rename include guard.
8293         * target/resume.h: Rename include guard.
8294         * target-float.h: Rename include guard.
8295         * stabsread.h: Add include guard.
8296         * rs6000-tdep.h: Add include guard.
8297         * riscv-fbsd-tdep.h: Add include guard.
8298         * regformats/regdef.h: Rename include guard.
8299         * record.h: Rename include guard.
8300         * python/python.h: Rename include guard.
8301         * python/python-internal.h: Rename include guard.
8302         * python/py-stopevent.h: Rename include guard.
8303         * python/py-ref.h: Rename include guard.
8304         * python/py-record.h: Rename include guard.
8305         * python/py-record-full.h: Rename include guard.
8306         * python/py-record-btrace.h: Rename include guard.
8307         * python/py-instruction.h: Rename include guard.
8308         * python/py-events.h: Rename include guard.
8309         * python/py-event.h: Rename include guard.
8310         * procfs.h: Add include guard.
8311         * proc-utils.h: Add include guard.
8312         * p-lang.h: Add include guard.
8313         * or1k-tdep.h: Rename include guard.
8314         * observable.h: Rename include guard.
8315         * nto-tdep.h: Rename include guard.
8316         * nat/x86-linux.h: Rename include guard.
8317         * nat/x86-linux-dregs.h: Rename include guard.
8318         * nat/x86-gcc-cpuid.h: Add include guard.
8319         * nat/x86-dregs.h: Rename include guard.
8320         * nat/x86-cpuid.h: Rename include guard.
8321         * nat/ppc-linux.h: Rename include guard.
8322         * nat/mips-linux-watch.h: Rename include guard.
8323         * nat/linux-waitpid.h: Rename include guard.
8324         * nat/linux-ptrace.h: Rename include guard.
8325         * nat/linux-procfs.h: Rename include guard.
8326         * nat/linux-osdata.h: Rename include guard.
8327         * nat/linux-nat.h: Rename include guard.
8328         * nat/linux-namespaces.h: Rename include guard.
8329         * nat/linux-btrace.h: Rename include guard.
8330         * nat/glibc_thread_db.h: Rename include guard.
8331         * nat/gdb_thread_db.h: Rename include guard.
8332         * nat/gdb_ptrace.h: Rename include guard.
8333         * nat/fork-inferior.h: Rename include guard.
8334         * nat/amd64-linux-siginfo.h: Rename include guard.
8335         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8336         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8337         * nat/aarch64-linux.h: Rename include guard.
8338         * nat/aarch64-linux-hw-point.h: Rename include guard.
8339         * mn10300-tdep.h: Add include guard.
8340         * mips-linux-tdep.h: Add include guard.
8341         * mi/mi-parse.h: Rename include guard.
8342         * mi/mi-out.h: Rename include guard.
8343         * mi/mi-main.h: Rename include guard.
8344         * mi/mi-interp.h: Rename include guard.
8345         * mi/mi-getopt.h: Rename include guard.
8346         * mi/mi-console.h: Rename include guard.
8347         * mi/mi-common.h: Rename include guard.
8348         * mi/mi-cmds.h: Rename include guard.
8349         * mi/mi-cmd-break.h: Rename include guard.
8350         * m2-lang.h: Add include guard.
8351         * location.h: Rename include guard.
8352         * linux-record.h: Rename include guard.
8353         * linux-nat.h: Add include guard.
8354         * linux-fork.h: Add include guard.
8355         * i386-darwin-tdep.h: Rename include guard.
8356         * hppa-linux-offsets.h: Add include guard.
8357         * guile/guile.h: Rename include guard.
8358         * guile/guile-internal.h: Rename include guard.
8359         * gnu-nat.h: Rename include guard.
8360         * gdb-stabs.h: Rename include guard.
8361         * frv-tdep.h: Add include guard.
8362         * f-lang.h: Add include guard.
8363         * event-loop.h: Add include guard.
8364         * darwin-nat.h: Rename include guard.
8365         * cp-abi.h: Rename include guard.
8366         * config/sparc/nm-sol2.h: Rename include guard.
8367         * config/nm-nto.h: Rename include guard.
8368         * config/nm-linux.h: Add include guard.
8369         * config/i386/nm-i386gnu.h: Rename include guard.
8370         * config/djgpp/nl_types.h: Rename include guard.
8371         * config/djgpp/langinfo.h: Rename include guard.
8372         * compile/gcc-cp-plugin.h: Add include guard.
8373         * compile/gcc-c-plugin.h: Add include guard.
8374         * compile/compile.h: Rename include guard.
8375         * compile/compile-object-run.h: Rename include guard.
8376         * compile/compile-object-load.h: Rename include guard.
8377         * compile/compile-internal.h: Rename include guard.
8378         * compile/compile-cplus.h: Rename include guard.
8379         * compile/compile-c.h: Rename include guard.
8380         * common/xml-utils.h: Rename include guard.
8381         * common/x86-xstate.h: Rename include guard.
8382         * common/version.h: Rename include guard.
8383         * common/vec.h: Rename include guard.
8384         * common/tdesc.h: Rename include guard.
8385         * common/selftest.h: Rename include guard.
8386         * common/scoped_restore.h: Rename include guard.
8387         * common/scoped_mmap.h: Rename include guard.
8388         * common/scoped_fd.h: Rename include guard.
8389         * common/safe-iterator.h: Rename include guard.
8390         * common/run-time-clock.h: Rename include guard.
8391         * common/refcounted-object.h: Rename include guard.
8392         * common/queue.h: Rename include guard.
8393         * common/ptid.h: Rename include guard.
8394         * common/print-utils.h: Rename include guard.
8395         * common/preprocessor.h: Rename include guard.
8396         * common/pathstuff.h: Rename include guard.
8397         * common/observable.h: Rename include guard.
8398         * common/netstuff.h: Rename include guard.
8399         * common/job-control.h: Rename include guard.
8400         * common/host-defs.h: Rename include guard.
8401         * common/gdb_wait.h: Rename include guard.
8402         * common/gdb_vecs.h: Rename include guard.
8403         * common/gdb_unlinker.h: Rename include guard.
8404         * common/gdb_unique_ptr.h: Rename include guard.
8405         * common/gdb_tilde_expand.h: Rename include guard.
8406         * common/gdb_sys_time.h: Rename include guard.
8407         * common/gdb_string_view.h: Rename include guard.
8408         * common/gdb_splay_tree.h: Rename include guard.
8409         * common/gdb_setjmp.h: Rename include guard.
8410         * common/gdb_ref_ptr.h: Rename include guard.
8411         * common/gdb_optional.h: Rename include guard.
8412         * common/gdb_locale.h: Rename include guard.
8413         * common/gdb_assert.h: Rename include guard.
8414         * common/filtered-iterator.h: Rename include guard.
8415         * common/filestuff.h: Rename include guard.
8416         * common/fileio.h: Rename include guard.
8417         * common/environ.h: Rename include guard.
8418         * common/common-utils.h: Rename include guard.
8419         * common/common-types.h: Rename include guard.
8420         * common/common-regcache.h: Rename include guard.
8421         * common/common-inferior.h: Rename include guard.
8422         * common/common-gdbthread.h: Rename include guard.
8423         * common/common-exceptions.h: Rename include guard.
8424         * common/common-defs.h: Rename include guard.
8425         * common/common-debug.h: Rename include guard.
8426         * common/cleanups.h: Rename include guard.
8427         * common/buffer.h: Rename include guard.
8428         * common/btrace-common.h: Rename include guard.
8429         * common/break-common.h: Rename include guard.
8430         * cli/cli-utils.h: Rename include guard.
8431         * cli/cli-style.h: Rename include guard.
8432         * cli/cli-setshow.h: Rename include guard.
8433         * cli/cli-script.h: Rename include guard.
8434         * cli/cli-interp.h: Rename include guard.
8435         * cli/cli-decode.h: Rename include guard.
8436         * cli/cli-cmds.h: Rename include guard.
8437         * charset-list.h: Add include guard.
8438         * buildsym-legacy.h: Rename include guard.
8439         * bfin-tdep.h: Add include guard.
8440         * ax.h: Rename include guard.
8441         * arm-linux-tdep.h: Add include guard.
8442         * arm-fbsd-tdep.h: Add include guard.
8443         * arch/xtensa.h: Rename include guard.
8444         * arch/tic6x.h: Add include guard.
8445         * arch/i386.h: Add include guard.
8446         * arch/arm.h: Rename include guard.
8447         * arch/arm-linux.h: Rename include guard.
8448         * arch/arm-get-next-pcs.h: Rename include guard.
8449         * arch/amd64.h: Add include guard.
8450         * arch/aarch64-insn.h: Rename include guard.
8451         * arch-utils.h: Rename include guard.
8452         * annotate.h: Add include guard.
8453         * amd64-darwin-tdep.h: Rename include guard.
8454         * aarch64-linux-tdep.h: Add include guard.
8455         * aarch64-fbsd-tdep.h: Add include guard.
8456         * aarch32-linux-nat.h: Add include guard.
8457
8458 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8459
8460         * macrotab.c (macro_define_internal): New function that
8461         factorizes macro_define_object_internal and macro_define_function
8462         code.
8463         (macro_define_object_internal): Use macro_define_internal.
8464         (macro_define_function): Likewise.
8465
8466 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8467
8468         * macrocmd.c (extract_identifier): Return
8469         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8470         callers.
8471
8472 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8473
8474         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8475
8476 2019-02-05  Tom Tromey  <tom@tromey.com>
8477
8478         * target.c (target_stack::unpush): Move assertion earlier.
8479
8480 2019-01-30  Tom Tromey  <tom@tromey.com>
8481
8482         PR python/23615:
8483         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8484         (gdbpy_parse_and_eval): Likewise.
8485         * python/python-internal.h (gdbpy_allow_threads): New class.
8486
8487 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8488
8489         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8490         (aarch64_fbsd_fpregmap): Move earlier.
8491         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8492         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8493         instead of individual calls to trad_frame_set_reg_addr.
8494         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8495         earlier.
8496         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8497         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8498         instead of individual calls to trad_frame_set_reg_addr.
8499
8500 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8501
8502         * CONTRIBUTE: Replace contribution list with wiki link.
8503
8504 2019-01-25  Tom Tromey  <tom@tromey.com>
8505
8506         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8507
8508 2019-01-25  Tom Tromey  <tom@tromey.com>
8509
8510         * xtensa-linux-nat.c: Fix common/ includes.
8511         * xml-support.h: Fix common/ includes.
8512         * xml-support.c: Fix common/ includes.
8513         * x86-linux-nat.c: Fix common/ includes.
8514         * windows-nat.c: Fix common/ includes.
8515         * varobj.h: Fix common/ includes.
8516         * varobj.c: Fix common/ includes.
8517         * value.c: Fix common/ includes.
8518         * valops.c: Fix common/ includes.
8519         * utils.c: Fix common/ includes.
8520         * unittests/xml-utils-selftests.c: Fix common/ includes.
8521         * unittests/utils-selftests.c: Fix common/ includes.
8522         * unittests/unpack-selftests.c: Fix common/ includes.
8523         * unittests/tracepoint-selftests.c: Fix common/ includes.
8524         * unittests/style-selftests.c: Fix common/ includes.
8525         * unittests/string_view-selftests.c: Fix common/ includes.
8526         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8527         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8528         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8529         * unittests/rsp-low-selftests.c: Fix common/ includes.
8530         * unittests/parse-connection-spec-selftests.c: Fix common/
8531         includes.
8532         * unittests/optional-selftests.c: Fix common/ includes.
8533         * unittests/offset-type-selftests.c: Fix common/ includes.
8534         * unittests/observable-selftests.c: Fix common/ includes.
8535         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8536         * unittests/memrange-selftests.c: Fix common/ includes.
8537         * unittests/memory-map-selftests.c: Fix common/ includes.
8538         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8539         * unittests/function-view-selftests.c: Fix common/ includes.
8540         * unittests/environ-selftests.c: Fix common/ includes.
8541         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8542         * unittests/common-utils-selftests.c: Fix common/ includes.
8543         * unittests/cli-utils-selftests.c: Fix common/ includes.
8544         * unittests/array-view-selftests.c: Fix common/ includes.
8545         * ui-file.c: Fix common/ includes.
8546         * tui/tui-io.c: Fix common/ includes.
8547         * tracepoint.h: Fix common/ includes.
8548         * tracepoint.c: Fix common/ includes.
8549         * tracefile-tfile.c: Fix common/ includes.
8550         * top.h: Fix common/ includes.
8551         * top.c: Fix common/ includes.
8552         * thread.c: Fix common/ includes.
8553         * target/waitstatus.h: Fix common/ includes.
8554         * target/waitstatus.c: Fix common/ includes.
8555         * target.h: Fix common/ includes.
8556         * target.c: Fix common/ includes.
8557         * target-memory.c: Fix common/ includes.
8558         * target-descriptions.c: Fix common/ includes.
8559         * symtab.h: Fix common/ includes.
8560         * symfile.c: Fix common/ includes.
8561         * stap-probe.c: Fix common/ includes.
8562         * spu-linux-nat.c: Fix common/ includes.
8563         * sparc-nat.c: Fix common/ includes.
8564         * source.c: Fix common/ includes.
8565         * solib.c: Fix common/ includes.
8566         * solib-target.c: Fix common/ includes.
8567         * ser-unix.c: Fix common/ includes.
8568         * ser-tcp.c: Fix common/ includes.
8569         * ser-pipe.c: Fix common/ includes.
8570         * ser-base.c: Fix common/ includes.
8571         * selftest-arch.c: Fix common/ includes.
8572         * s12z-tdep.c: Fix common/ includes.
8573         * rust-exp.y: Fix common/ includes.
8574         * rs6000-aix-tdep.c: Fix common/ includes.
8575         * riscv-tdep.c: Fix common/ includes.
8576         * remote.c: Fix common/ includes.
8577         * remote-notif.h: Fix common/ includes.
8578         * remote-fileio.h: Fix common/ includes.
8579         * remote-fileio.c: Fix common/ includes.
8580         * regcache.h: Fix common/ includes.
8581         * regcache.c: Fix common/ includes.
8582         * record-btrace.c: Fix common/ includes.
8583         * python/python.c: Fix common/ includes.
8584         * python/py-type.c: Fix common/ includes.
8585         * python/py-inferior.c: Fix common/ includes.
8586         * progspace.h: Fix common/ includes.
8587         * producer.c: Fix common/ includes.
8588         * procfs.c: Fix common/ includes.
8589         * proc-api.c: Fix common/ includes.
8590         * printcmd.c: Fix common/ includes.
8591         * ppc-linux-nat.c: Fix common/ includes.
8592         * parser-defs.h: Fix common/ includes.
8593         * osdata.c: Fix common/ includes.
8594         * obsd-nat.c: Fix common/ includes.
8595         * nat/x86-linux.c: Fix common/ includes.
8596         * nat/x86-linux-dregs.c: Fix common/ includes.
8597         * nat/x86-dregs.h: Fix common/ includes.
8598         * nat/x86-dregs.c: Fix common/ includes.
8599         * nat/ppc-linux.c: Fix common/ includes.
8600         * nat/mips-linux-watch.h: Fix common/ includes.
8601         * nat/mips-linux-watch.c: Fix common/ includes.
8602         * nat/linux-waitpid.c: Fix common/ includes.
8603         * nat/linux-ptrace.h: Fix common/ includes.
8604         * nat/linux-ptrace.c: Fix common/ includes.
8605         * nat/linux-procfs.c: Fix common/ includes.
8606         * nat/linux-personality.c: Fix common/ includes.
8607         * nat/linux-osdata.c: Fix common/ includes.
8608         * nat/linux-namespaces.c: Fix common/ includes.
8609         * nat/linux-btrace.h: Fix common/ includes.
8610         * nat/linux-btrace.c: Fix common/ includes.
8611         * nat/fork-inferior.c: Fix common/ includes.
8612         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8613         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8614         * nat/aarch64-linux.c: Fix common/ includes.
8615         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8616         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8617         * namespace.h: Fix common/ includes.
8618         * mips-linux-tdep.c: Fix common/ includes.
8619         * minsyms.c: Fix common/ includes.
8620         * mi/mi-parse.h: Fix common/ includes.
8621         * mi/mi-main.c: Fix common/ includes.
8622         * mi/mi-cmd-env.c: Fix common/ includes.
8623         * memrange.h: Fix common/ includes.
8624         * memattr.c: Fix common/ includes.
8625         * maint.h: Fix common/ includes.
8626         * maint.c: Fix common/ includes.
8627         * main.c: Fix common/ includes.
8628         * machoread.c: Fix common/ includes.
8629         * location.c: Fix common/ includes.
8630         * linux-thread-db.c: Fix common/ includes.
8631         * linux-nat.c: Fix common/ includes.
8632         * linux-fork.c: Fix common/ includes.
8633         * inline-frame.c: Fix common/ includes.
8634         * infrun.c: Fix common/ includes.
8635         * inflow.c: Fix common/ includes.
8636         * inferior.h: Fix common/ includes.
8637         * inferior.c: Fix common/ includes.
8638         * infcmd.c: Fix common/ includes.
8639         * inf-ptrace.c: Fix common/ includes.
8640         * inf-child.c: Fix common/ includes.
8641         * ia64-linux-nat.c: Fix common/ includes.
8642         * i387-tdep.c: Fix common/ includes.
8643         * i386-tdep.c: Fix common/ includes.
8644         * i386-linux-tdep.c: Fix common/ includes.
8645         * i386-linux-nat.c: Fix common/ includes.
8646         * i386-go32-tdep.c: Fix common/ includes.
8647         * i386-fbsd-tdep.c: Fix common/ includes.
8648         * i386-fbsd-nat.c: Fix common/ includes.
8649         * guile/scm-type.c: Fix common/ includes.
8650         * guile/guile.c: Fix common/ includes.
8651         * go32-nat.c: Fix common/ includes.
8652         * gnu-nat.c: Fix common/ includes.
8653         * gdbthread.h: Fix common/ includes.
8654         * gdbarch-selftests.c: Fix common/ includes.
8655         * gdb_usleep.c: Fix common/ includes.
8656         * gdb_select.h: Fix common/ includes.
8657         * gdb_bfd.c: Fix common/ includes.
8658         * gcore.c: Fix common/ includes.
8659         * fork-child.c: Fix common/ includes.
8660         * findvar.c: Fix common/ includes.
8661         * fbsd-nat.c: Fix common/ includes.
8662         * event-top.c: Fix common/ includes.
8663         * event-loop.c: Fix common/ includes.
8664         * dwarf2read.c: Fix common/ includes.
8665         * dwarf2loc.c: Fix common/ includes.
8666         * dwarf2-frame.c: Fix common/ includes.
8667         * dwarf-index-cache.c: Fix common/ includes.
8668         * dtrace-probe.c: Fix common/ includes.
8669         * disasm-selftests.c: Fix common/ includes.
8670         * defs.h: Fix common/ includes.
8671         * csky-tdep.c: Fix common/ includes.
8672         * cp-valprint.c: Fix common/ includes.
8673         * cp-support.h: Fix common/ includes.
8674         * cp-support.c: Fix common/ includes.
8675         * corelow.c: Fix common/ includes.
8676         * completer.h: Fix common/ includes.
8677         * completer.c: Fix common/ includes.
8678         * compile/compile.c: Fix common/ includes.
8679         * compile/compile-loc2c.c: Fix common/ includes.
8680         * compile/compile-cplus-types.c: Fix common/ includes.
8681         * compile/compile-cplus-symbols.c: Fix common/ includes.
8682         * command.h: Fix common/ includes.
8683         * cli/cli-dump.c: Fix common/ includes.
8684         * cli/cli-cmds.c: Fix common/ includes.
8685         * charset.c: Fix common/ includes.
8686         * build-id.c: Fix common/ includes.
8687         * btrace.h: Fix common/ includes.
8688         * btrace.c: Fix common/ includes.
8689         * breakpoint.h: Fix common/ includes.
8690         * breakpoint.c: Fix common/ includes.
8691         * ax.h:
8692         (enum agent_op): Fix common/ includes.
8693         * ax-general.c (struct aop_map): Fix common/ includes.
8694         * ax-gdb.c: Fix common/ includes.
8695         * auxv.c: Fix common/ includes.
8696         * auto-load.c: Fix common/ includes.
8697         * arm-tdep.c: Fix common/ includes.
8698         * arch/riscv.c: Fix common/ includes.
8699         * arch/ppc-linux-common.c: Fix common/ includes.
8700         * arch/i386.c: Fix common/ includes.
8701         * arch/arm.c: Fix common/ includes.
8702         * arch/arm-linux.c: Fix common/ includes.
8703         * arch/arm-get-next-pcs.c: Fix common/ includes.
8704         * arch/amd64.c: Fix common/ includes.
8705         * arch/aarch64.c: Fix common/ includes.
8706         * arch/aarch64-insn.c: Fix common/ includes.
8707         * arch-utils.c: Fix common/ includes.
8708         * amd64-windows-tdep.c: Fix common/ includes.
8709         * amd64-tdep.c: Fix common/ includes.
8710         * amd64-sol2-tdep.c: Fix common/ includes.
8711         * amd64-obsd-tdep.c: Fix common/ includes.
8712         * amd64-nbsd-tdep.c: Fix common/ includes.
8713         * amd64-linux-tdep.c: Fix common/ includes.
8714         * amd64-linux-nat.c: Fix common/ includes.
8715         * amd64-fbsd-tdep.c: Fix common/ includes.
8716         * amd64-fbsd-nat.c: Fix common/ includes.
8717         * amd64-dicos-tdep.c: Fix common/ includes.
8718         * amd64-darwin-tdep.c: Fix common/ includes.
8719         * agent.c: Fix common/ includes.
8720         * ada-lang.h: Fix common/ includes.
8721         * ada-lang.c: Fix common/ includes.
8722         * aarch64-tdep.c: Fix common/ includes.
8723
8724 2019-01-25  Tom Tromey  <tom@tromey.com>
8725
8726         * common/create-version.sh: Use common/version.h.
8727
8728 2019-01-24  Pedro Alves  <palves@redhat.com>
8729
8730         * infrun.c (signal_stop, signal_print, signal_program)
8731         (signal_catch, signal_pass): Now arrays instead of pointers.
8732         (update_signals_program_target, do_target_resume)
8733         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8734         * linux-nat.c (linux_nat_target::pass_signals)
8735         (linux_nat_target::create_inferior, linux_nat_target::attach):
8736         Adjust.
8737         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8738         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8739         * procfs.c (procfs_target::pass_signals): Adjust.
8740         * record-full.c (record_full_target::resume): Adjust.
8741         * remote.c (remote_target::pass_signals)
8742         (remote_target::program_signals): Adjust.
8743         * target-debug.h (target_debug_print_signals): Now takes a
8744         gdb::array_view as parameter.  Adjust.
8745         * target.h (target_ops) <pass_signals, program_signals>: Replace
8746         pointer and length parameters with gdb::array_view.
8747         (target_pass_signals, target_program_signals): Likewise.
8748         * target-delegates.c: Regenerate.
8749
8750 2019-01-24  Pedro Alves  <palves@redhat.com>
8751
8752         * common/forward-scope-exit.h
8753         (forward_scope_exit::forward_scope_exit): Pass arguments to
8754         m_bind_function directly, instead of creating a std::bind and
8755         copying that.
8756
8757 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8758
8759         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8760         for static members.
8761         (pass_in_v_vfp_candidate): Likewise.
8762
8763 2019-01-23  Tom Tromey  <tom@tromey.com>
8764             Pedro Alves  <palves@redhat.com>
8765
8766         * regcache.c (class regcache_invalidator): Remove.
8767         (regcache::raw_write): Use make_scope_exit.
8768
8769 2019-01-23  Tom Tromey  <tom@tromey.com>
8770
8771         * ui-out.h (class ui_out_emit_type): Update comment.
8772
8773 2019-01-23  Tom Tromey  <tom@tromey.com>
8774
8775         * infrun.c (fetch_inferior_event): Update comment.
8776
8777 2019-01-23  Tom Tromey  <tom@tromey.com>
8778             Pedro Alves  <palves@redhat.com>
8779
8780         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8781         parameter.
8782         (fetch_inferior_event): Use SCOPE_EXIT.
8783
8784
8785 2019-01-23  Tom Tromey  <tom@tromey.com>
8786             Pedro Alves  <palves@redhat.com>
8787
8788         * infrun.c (disable_thread_events): Delete.
8789         (stop_all_threads): Use SCOPE_EXIT.
8790
8791 2019-01-23  Tom Tromey  <tom@tromey.com>
8792             Pedro Alves  <palves@redhat.com>
8793
8794         * symfile.c: Include forward-scope-exit.h.
8795         (clear_symtab_users_cleanup): Replace forward declaration with
8796         a FORWARD_SCOPE_EXIT.
8797         (syms_from_objfile_1): Use the forward_scope_exit and
8798         gdb::optional instead of cleanup_function.
8799         (reread_symbols): Use the forward_scope_exit instead of
8800         cleanup_function.
8801         (clear_symtab_users_cleanup): Remove function.
8802
8803 2019-01-23  Tom Tromey  <tom@tromey.com>
8804             Pedro Alves  <palves@redhat.com>
8805
8806         * linux-nat.c: Include scope-exit.h.
8807         (cleanup_target_stop): Remove.
8808         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8809         SCOPE_EXIT.
8810
8811 2019-01-23  Tom Tromey  <tom@tromey.com>
8812             Pedro Alves  <palves@redhat.com>
8813
8814         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8815         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8816
8817 2019-01-23  Tom Tromey  <tom@tromey.com>
8818             Andrew Burgess  <andrew.burgess@embecosm.com>
8819             Pedro Alves  <palves@redhat.com>
8820
8821         * infrun.c (fetch_inferior_event): Use scope_exit.
8822         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8823         * top.c (execute_command): Use scope_exit.
8824         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8825         * utils.c (do_bpstat_clear_actions_cleanup)
8826         (make_bpstat_clear_actions_cleanup): Remove.
8827
8828 2019-01-23  Tom Tromey  <tom@tromey.com>
8829             Pedro Alves  <palves@redhat.com>
8830
8831         * infrun.c: Include "common/scope-exit.h"
8832         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8833         (wait_for_inferior): Use SCOPE_EXIT.
8834         (fetch_inferior_event): Use scope_exit.
8835
8836 2019-01-23  Tom Tromey  <tom@tromey.com>
8837             Pedro Alves  <palves@redhat.com>
8838
8839         * breakpoint.c (create_breakpoint): Remove cleanup.
8840
8841 2019-01-23  Tom Tromey  <tom@tromey.com>
8842             Andrew Burgess  <andrew.burgess@embecosm.com>
8843             Pedro Alves  <palves@redhat.com>
8844
8845 2019-01-23  Pedro Alves  <palves@redhat.com>
8846
8847         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8848
8849 2019-01-23  Pedro Alves  <palves@redhat.com>
8850             Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * gdbthread.h: Include "common/forward-scope-exit.h".
8853         (scoped_finish_thread_state): Redefine custom class in terms of
8854         forward_scope_exit.
8855
8856 2019-01-23  Pedro Alves  <palves@redhat.com>
8857             Andrew Burgess  <andrew.burgess@embecosm.com>
8858
8859         * common/forward-scope-exit.h: New file.
8860
8861 2019-01-23  Pedro Alves  <palves@redhat.com>
8862             Andrew Burgess  <andrew.burgess@embecosm.com>
8863             Tom Tromey  <tom@tromey.com>
8864
8865         * common/scope-exit.h: New file.
8866
8867 2019-01-23  Pedro Alves  <palves@redhat.com>
8868
8869         * common/preprocessor.h (ESC): Rename to ...
8870         (ESC_PARENS): ... this.
8871         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8872         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8873
8874 2019-01-23  Tom Tromey  <tom@tromey.com>
8875
8876         * language.h (class scoped_switch_to_sym_language_if_auto):
8877         Initialize m_lang in both cases.
8878
8879 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8880
8881         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8882         with XCNEW.
8883
8884 2019-01-22  Tom Tromey  <tom@tromey.com>
8885
8886         * corelow.c: Do not include sys/file.h.
8887
8888 2019-01-22  Tom Tromey  <tom@tromey.com>
8889
8890         * tui/tui-wingeneral.h: Include gdb_curses.h.
8891
8892 2019-01-22  Tom Tromey  <tom@tromey.com>
8893
8894         * source-cache.h (class source_cache) <get_source_lines,
8895         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8896
8897 2019-01-22  Tom Tromey  <tom@tromey.com>
8898
8899         * remote-fileio.h (struct remote_target): Declare.
8900
8901 2019-01-22  Tom Tromey  <tom@tromey.com>
8902
8903         * python/py-arch.c: Do not include py-ref.h.
8904         * python/py-bpevent.c: Do not include py-ref.h.
8905         * python/py-cmd.c: Do not include py-ref.h.
8906         * python/py-continueevent.c: Do not include py-ref.h.
8907         * python/py-event.h: Do not include py-ref.h.
8908         * python/py-evtregistry.c: Do not include py-ref.h.
8909         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8910         * python/py-frame.c: Do not include py-ref.h.
8911         * python/py-framefilter.c: Do not include py-ref.h.
8912         * python/py-function.c: Do not include py-ref.h.
8913         * python/py-infevents.c: Do not include py-ref.h.
8914         * python/py-linetable.c: Do not include py-ref.h.
8915         * python/py-objfile.c: Do not include py-ref.h.
8916         * python/py-param.c: Do not include py-ref.h.
8917         * python/py-prettyprint.c: Do not include py-ref.h.
8918         * python/py-progspace.c: Do not include py-ref.h.
8919         * python/py-symbol.c: Do not include py-ref.h.
8920         * python/py-symtab.c: Do not include py-ref.h.
8921         * python/py-type.c: Do not include py-ref.h.
8922         * python/py-unwind.c: Do not include py-ref.h.
8923         * python/py-utils.c: Do not include py-ref.h.
8924         * python/py-value.c: Do not include py-ref.h.
8925         * python/py-varobj.c: Do not include py-ref.h.
8926         * python/py-xmethods.c: Do not include py-ref.h.
8927         * python/python.c: Do not include py-ref.h.
8928         * varobj.c: Do not include py-ref.h.
8929
8930 2019-01-22  Tom Tromey  <tom@tromey.com>
8931
8932         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8933         keyword for bcache.
8934
8935 2019-01-22  Tom Tromey  <tom@tromey.com>
8936
8937         * compile/compile-cplus-types.c: Remove a comment by #include.
8938
8939 2019-01-22  Tom Tromey  <tom@tromey.com>
8940
8941         * compile/gcc-c-plugin.h: Include compile-internal.h.
8942
8943 2019-01-22  Tom Tromey  <tom@tromey.com>
8944
8945         * stabsread.c (EXTERN): Do not define.
8946         (symnum, next_symbol_text_func, processing_gcc_compilation)
8947         (within_function, global_sym_chain, global_stabs)
8948         (previous_stab_code, this_object_header_files)
8949         (n_this_object_header_files)
8950         (n_allocated_this_object_header_files): Define.
8951         * stabsread.h (EXTERN): Never define.  Use "extern".
8952
8953 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8954
8955         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8956         history_value.
8957
8958 2019-01-21  Tom Tromey  <tom@tromey.com>
8959
8960         * ui-out.c: Fix includes.
8961         * tui/tui-source.c: Fix includes.
8962         * target.c: Fix includes.
8963         * remote.c: Fix includes.
8964         * regcache.c: Fix includes.
8965         * python/py-block.c: Fix includes.
8966         * printcmd.c: Fix includes.
8967         * or1k-tdep.c: Fix includes.
8968         * mi/mi-main.c: Fix includes.
8969         * m32r-tdep.c: Fix includes.
8970         * csky-tdep.c: Fix includes.
8971         * compile/compile-cplus-types.c: Fix includes.
8972         * cli/cli-interp.c: Fix includes.
8973
8974 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8975
8976         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8977         for padding.
8978
8979 2019-01-16  Tom Tromey  <tom@tromey.com>
8980
8981         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8982         earlier.
8983         (struct objfile) <msymbols_range>: Move from top level.
8984         <msymbols>: New method.
8985         (class objfile_msymbols): Remove.
8986         * symtab.c (default_collect_symbol_completion_matches_break_on):
8987         Update.
8988         * symmisc.c (dump_msymbols): Update.
8989         * stabsread.c (scan_file_globals): Update.
8990         * objc-lang.c (info_selectors_command, info_classes_command)
8991         (find_methods): Update.
8992         * minsyms.c (find_solib_trampoline_target): Update.
8993         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8994         * coffread.c (coff_symfile_read): Update.
8995         * ada-lang.c (ada_lookup_simple_minsym)
8996         (ada_collect_symbol_completion_matches): Update.
8997
8998 2019-01-16  Tom Tromey  <tom@tromey.com>
8999
9000         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9001         type.  Remove no-argument constructor.
9002         <iterator::operator++>: Simplify.
9003         <begin>: Update.
9004         <end>: Use minimal_symbol_count.
9005
9006 2019-01-16  Tom Tromey  <tom@tromey.com>
9007
9008         * objfiles.h (struct objfile) <psymtabs>: New method.
9009         (class objfile_psymtabs): Remove.
9010         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9011         typedef.
9012         <range>: New method.
9013         (require_partial_symbols): Change return type.
9014         * psymtab.c (require_partial_symbols)
9015         (psym_expand_symtabs_matching): Update.
9016         * mdebugread.c (parse_partial_symbols): Update.
9017         * dbxread.c (dbx_end_psymtab): Update.
9018
9019 2019-01-15  Tom Tromey  <tom@tromey.com>
9020
9021         * symtab.c (lookup_objfile_from_block)
9022         (lookup_symbol_in_objfile_symtabs)
9023         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9024         (find_line_symtab, info_sources_command)
9025         (default_collect_symbol_completion_matches_break_on)
9026         (make_source_files_completion_list): Update.
9027         * symmisc.c (print_objfile_statistics, dump_objfile)
9028         (maintenance_print_symbols, maintenance_info_symtabs)
9029         (maintenance_check_symtabs, maintenance_info_line_tables):
9030         Update.
9031         * source.c (select_source_symtab)
9032         (forget_cached_source_info_for_objfile): Update.
9033         * objfiles.h (class objfile_compunits): Remove.
9034         (struct objfile) <compunits_range>: New typedef.
9035         (compunits): New method.
9036         * objfiles.c (objfile_relocate1): Update.
9037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9038         * maint.c (count_symtabs_and_blocks): Update.
9039         * linespec.c (iterate_over_all_matching_symtabs): Update.
9040         * cp-support.c (add_symbol_overload_list_qualified): Update.
9041         * coffread.c (coff_symtab_read): Update.
9042         * ada-lang.c (add_nonlocal_symbols)
9043         (ada_collect_symbol_completion_matches)
9044         (ada_add_global_exceptions): Update.
9045
9046 2019-01-15  Tom Tromey  <tom@tromey.com>
9047
9048         * progspace.h (program_space) <objfiles_safe_range>: New
9049         typedef.
9050         <objfiles_safe>: New method.
9051         * objfiles.h (class all_objfiles_safe): Remove.
9052         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9053         * jit.c (jit_inferior_exit_hook): Update.
9054
9055 2019-01-17  Tom Tromey  <tom@tromey.com>
9056
9057         * progspace.h (program_space) <objfiles_range>: New typedef.
9058         <objfiles>: New method.
9059         <objfiles_head>: Rename from objfiles.
9060         (object_files): Update.
9061         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9062         * guile/scm-pretty-print.c
9063         (ppscm_find_pretty_printer_from_objfiles): Update.
9064         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9065         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9066         Update.
9067         * python/py-progspace.c (pspy_get_objfiles): Update.
9068         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9069         Update.
9070         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9071         (objfpy_lookup_objfile_by_build_id): Update.
9072         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9073         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9074         Update.
9075         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9076         (expand_symtab_containing_pc, lookup_objfile_from_block)
9077         (lookup_static_symbol, basic_lookup_transparent_type)
9078         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9079         (find_line_symtab, info_sources_command)
9080         (default_collect_symbol_completion_matches_break_on)
9081         (make_source_files_completion_list, find_main_name): Update.
9082         * symmisc.c (print_symbol_bcache_statistics)
9083         (print_objfile_statistics, maintenance_print_symbols)
9084         (maintenance_print_msymbols, maintenance_print_objfiles)
9085         (maintenance_info_symtabs, maintenance_check_symtabs)
9086         (maintenance_expand_symtabs, maintenance_info_line_tables):
9087         Update.
9088         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9089         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9090         (map_overlay_command, unmap_overlay_command)
9091         (simple_overlay_update, expand_symtabs_matching)
9092         (map_symbol_filenames): Update.
9093         * symfile-debug.c (set_debug_symfile): Update.
9094         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9095         Update.
9096         * source.c (select_source_symtab, forget_cached_source_info):
9097         Update.
9098         * solib.c (solib_read_symbols): Update.
9099         * solib-spu.c (append_ocl_sos): Update.
9100         * psymtab.c (maintenance_print_psymbols)
9101         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9102         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9103         * printcmd.c (info_symbol_command): Update.
9104         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9105         Update.
9106         * objfiles.h (class all_objfiles): Remove.
9107         * objfiles.c (have_partial_symbols, have_full_symbols)
9108         (have_minimal_symbols, qsort_cmp, update_section_map)
9109         (shared_objfile_contains_address_p)
9110         (default_iterate_over_objfiles_in_search_order): Update.
9111         * objc-lang.c (info_selectors_command, info_classes_command)
9112         (find_methods): Update.
9113         * minsyms.c (find_solib_trampoline_target): Update.
9114         * maint.c (maintenance_info_sections)
9115         (maintenance_translate_address, count_symtabs_and_blocks):
9116         Update.
9117         * main.c (captured_main_1): Update.
9118         * linux-thread-db.c (try_thread_db_load_from_pdir)
9119         (has_libpthread): Update.
9120         * linespec.c (iterate_over_all_matching_symtabs)
9121         (search_minsyms_for_name): Update.
9122         * jit.c (jit_find_objf_with_entry_addr): Update.
9123         * hppa-tdep.c (find_unwind_entry)
9124         (hppa_lookup_stub_minimal_symbol): Update.
9125         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9126         Update.
9127         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9128         (elf_gnu_ifunc_resolve_by_got): Update.
9129         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9130         * dwarf-index-write.c (save_gdb_index_command): Update.
9131         * cp-support.c (add_symbol_overload_list_qualified): Update.
9132         * breakpoint.c (create_overlay_event_breakpoint)
9133         (create_longjmp_master_breakpoint)
9134         (create_std_terminate_master_breakpoint)
9135         (create_exception_master_breakpoint): Update.
9136         * blockframe.c (find_pc_partial_function): Update.
9137         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9138         (ada_collect_symbol_completion_matches)
9139         (ada_add_global_exceptions): Update.
9140
9141 2019-01-17  Tom Tromey  <tom@tromey.com>
9142
9143         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9144         declare VEC.
9145         (solib_target_parse_libraries): Change return type.
9146         (library_list_start_segment, library_list_start_section)
9147         (library_list_end_library, library_list_start_library); Update.
9148         (solib_target_free_library_list): Remove.
9149         (solib_target_parse_libraries): Remove cleanup.  Change return
9150         type.
9151         (solib_target_current_sos): Update.
9152
9153 2019-01-17  Tom Tromey  <tromey@bapiya>
9154
9155         * valprint.c: Replace "the the" with "the".
9156         * symtab.c: Replace "the the" with "the".
9157         * solib.c: Replace "the the" with "the".
9158         * solib-dsbt.c: Replace "the the" with "the".
9159         * linespec.c: Replace "the the" with "the".
9160         * dwarf2loc.h: Replace "the the" with "the".
9161         * amd64-windows-tdep.c: Replace "the the" with "the".
9162         * aarch64-tdep.c: Replace "the the" with "the".
9163
9164 2019-01-16  Keith Seitz  <keiths@redhat.com>
9165
9166         PR gdb/23773
9167         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9168         <builder>: Rename to ..
9169         <m_builder>: ... this and make private.
9170         (dwarf2_cu::get_builder): New method.  Change all users of
9171         `builder' to use this method.
9172         (dwarf2_start_symtab): Move to ...
9173         (dwarf2_cu::start_symtab): ... here.  Update all callers
9174         (setup_type_unit_groups): Move to ...
9175         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9176         callers.
9177         (dwarf2_cu::reset_builder): New method.
9178         (process_full_compunit, process_full_type_unit): Use
9179         dwarf2_cu::reset_builder.
9180         (follow_die_offset): Record the ancestor CU if it is different
9181         from the followed DIE's CU.
9182         (follow_die_sig_1): Likewise.
9183
9184 2019-01-15  Tom Tromey  <tom@tromey.com>
9185
9186         * remote.c (class remote_state) <buf>: Now a char_vector.
9187         <buf_size>: Remove.
9188         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9189         parameter.
9190         (remote_target::getpkt_or_notif_sane_1)
9191         (remote_target::getpkt_sane)
9192         (remote_target::getpkt_or_notif_sane): Likewise.
9193         (class remote_target) <putpkt>: New overload.
9194         (remote_target::read_frame): Change type of "buf_p".  Remove
9195         sizeof_p parameter.
9196         (packet_ok): New overload.
9197         (packet_check_result): New overload.
9198         Update all uses.
9199
9200 2019-01-14  Tom Tromey  <tom@tromey.com>
9201
9202         * remote-notif.c (handle_notification, remote_notif_ack)
9203         (remote_notif_parse): Make "buf" const.
9204         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9205         const.
9206         (remote_notif_parse, remote_notif_ack, handle_notification):
9207         Likewise.
9208         * remote.c (remote_notif_stop_parse): Make "buf" const.
9209         (remote_target::remote_parse_stop_reply): Make "buf" const.
9210         (remote_notif_stop_ack): Make "buf" const.
9211
9212 2019-01-14  Tom Tromey  <tom@tromey.com>
9213
9214         * remote.c (remote_console_output): Make parameter const.
9215
9216 2019-01-14  Tom Tromey  <tom@tromey.com>
9217
9218         * target-debug.h (target_debug_print_signals): Constify.
9219         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9220         * procfs.c (procfs_target::pass_signals): Update.
9221         * linux-nat.c (linux_nat_target::pass_signals): Update.
9222         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9223         * target-delegates.c: Rebuild.
9224         * remote.c (remote_target::program_signals): Update.
9225         (remote_target::pass_signals): Update.
9226         * target.c (target_pass_signals): Constify argument.
9227         (target_program_signals): Likewise.
9228         * target.h (struct target_ops) <pass_signals, program_signals>:
9229         Constify argument.
9230         (target_pass_signals, target_program_signals): Constify argument.
9231
9232 2019-01-14  Tom Tromey  <tom@tromey.com>
9233
9234         PR tui/28819:
9235         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9236
9237 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9238
9239         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9240         field.
9241         * rs6000-tdep.c: Include reggroups.h.
9242         (IS_V_ALIAS_PSEUDOREG): Define.
9243         (rs6000_register_name): Return names for the "vX" aliases.
9244         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9245         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9246         aliases.  Call default_register_reggroup_p for all other
9247         pseudo-registers.
9248         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9249         New functions.
9250         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9251         Handle "vX" aliases.
9252         (v_alias_pseudo_register_collect): New function.
9253         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9254         (rs6000_gdbarch_init): Initialize "vX" aliases as
9255         pseudo-registers.  Restore registration of
9256         rs6000_pseudo_register_reggroup_p with
9257         set_tdesc_pseudo_register_reggroup_p.
9258
9259 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9260
9261         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9262         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9263         set_gdbarch_num_pseudo_regs.
9264
9265 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9266
9267         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9268         Remove arg prefixname, add do_set and do_show.
9269         Add member functions set_list and show_list.
9270         * cli/cli-style.c (class cli_style_option): Update accordingly.
9271         (style_set_list): Move to file scope.
9272         (style_show_list): Likewise.
9273         (set_style): Call help_list.
9274         (show_style): Call cmd_show_list.
9275         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9276         Update to use the new macro.
9277
9278 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9279
9280         * ada-lang.c (_initialize_ada_language): Expand the help text
9281         for the "catch exception" command.
9282
9283 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9284
9285         * symtab.c (matching_obj_sections): Initialize obj,
9286         declare it closer to its usage.
9287
9288 2019-01-10  Tom Tromey  <tom@tromey.com>
9289
9290         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9291         (basic_inf_threads_range): Remove.
9292         (inf_threads_range, inf_non_exited_threads_range)
9293         (safe_inf_threads_range): Use next_adapter.
9294
9295 2019-01-10  Keith Seitz  <keiths@redhat.com>
9296
9297         PR gdb/23712
9298         PR symtab/23010
9299         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9300         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9301
9302 2019-01-10  Keith Seitz  <keiths@redhat.com>
9303
9304         PR gdb/23712
9305         PR symtab/23010
9306         * dictionary.c (pending_to_vector): Remove.
9307         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9308         Remove _1 suffix, replacing functions of the same name.  Update
9309         all callers.
9310         (dict_create_hashed, dict_create_hashed_expandable)
9311         (dict_create_linear, dict_create_linear_expandable, dict_free)
9312         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9313         Make functions static.
9314
9315 2019-01-10  Keith Seitz  <keiths@redhat.com>
9316
9317         PR gdb/23712
9318         PR symtab/23010
9319         * dictionary.h (struct dictionary): Replace declaration with
9320         multidictionary.
9321         (dict_create_hashed, dict_create_hashed_expandable)
9322         (dict_create_linear, dict_create_linear_expandable)
9323         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9324         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9325         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9326         taking multidictionary argument.
9327         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9328         * block.h (struct block) <dict>: Change to multidictionary
9329         and rename `multidict'.
9330         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9331         symmisc.c: Update all dictionary references to multidictionary.
9332
9333 2019-01-10  Keith Seitz  <keiths@redhat.com>
9334
9335         PR gdb/23712
9336         PR symtab/23010
9337         * dictionary.c: Include unordered_map.
9338         (pending_to_vector): New function.
9339         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9340         Rewrite the non-"_1" functions to take vector instead
9341         of linked list.
9342         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9343         "new" _1 versions of the same name.
9344         (multidictionary): Define.
9345         (std::hash<enum language): New definition.
9346         (collate_pending_symbols_by_language, mdict_create_hashed)
9347         (mdict_create_hashed_expandable, mdict_create_linear)
9348         (mdict_create_linear_expandable, mdict_free)
9349         (find_language_dictionary, create_new_language_dictionary)
9350         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9351         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9352         (mdict_size, mdict_empty): New functions.
9353         * dictionary.h (mdict_iterator): Define.
9354
9355 2019-01-10  Pedro Alves  <palves@redhat.com>
9356
9357         * breakpoint.c (read_uploaded_action)
9358         (create_tracepoint_from_upload): Adjust to use
9359         gdb::unique_xmalloc_ptr.
9360         * ctf.c (ctf_write_uploaded_tp):
9361         (SET_ARRAY_FIELD): Use emplace_back.
9362         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9363         * tracefile-tfile.c (tfile_write_uploaded_tp):
9364         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9365         gdb::unique_xmalloc_ptr.
9366         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9367         at_string, cond_string, cmd_strings>: Replace char pointers
9368         with gdb::unique_xmalloc_ptr.
9369
9370 2019-01-10  Pedro Alves  <palves@redhat.com>
9371
9372         * solib-target.c (library_list_start_library): Don't xstrdup name.
9373
9374 2019-01-10  Pedro Alves  <palves@redhat.com>
9375
9376         * mdebugread.c (parse_partial_symbols): Use
9377         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9378
9379 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9380
9381         * linux-fork.c (scoped_switch_fork_info)
9382         <~scoped_switch_fork_info>: Fix incorrect variable name.
9383
9384 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9385
9386         * linux-fork.c (scoped_switch_fork_info)
9387         <scoped_switch_fork_info>: Make explicit.
9388         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9389
9390 2019-01-10  Tom Tromey  <tom@tromey.com>
9391
9392         * objfiles.h (objfile::reset_psymtabs): Update.
9393         * objfiles.c (objfile::objfile): Update.
9394         * psymtab.h (psymtab_storage::obstack): Update.
9395         (psymtab_storage::m_obstack): Use gdb::optional.
9396         (class psymtab_storage): Update comment.  Remove objfile
9397         parameter.
9398         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9399
9400 2019-01-10  Tom Tromey  <tom@tromey.com>
9401
9402         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9403         <free_psymtabs>: Now private.
9404         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9405         (allocate_psymtab): Use new method.
9406
9407 2019-01-10  Tom Tromey  <tom@tromey.com>
9408
9409         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9410         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9411         * mdebugread.c (parse_partial_symbols): Use
9412         allocate_dependencies.
9413         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9414         allocate_dependencies.
9415         (process_psymtab_comp_unit_reader)
9416         (build_type_psymtab_dependencies): Likewise.
9417         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9418
9419 2019-01-10  Tom Tromey  <tom@tromey.com>
9420
9421         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9422         PSYMBOL_SET_LANGUAGE.
9423         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9424
9425 2019-01-10  Tom Tromey  <tom@tromey.com>
9426
9427         * psymtab.h (psymtab_storage::obstack): New method.
9428         <m_obstack>: Rename from obstack; now private.
9429         * psymtab.c (psymtab_storage): Update.
9430         * dwarf2read.c (create_addrmap_from_index)
9431         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9432         Update.
9433
9434 2019-01-10  Tom Tromey  <tom@tromey.com>
9435
9436         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9437         * objfiles.h (objfile::reset_psymtabs): New method.
9438
9439 2019-01-10  Tom Tromey  <tom@tromey.com>
9440
9441         * symmisc.c (print_symbol_bcache_statistics): Update.
9442         (print_objfile_statistics): Update.
9443         * symfile.c (reread_symbols): Update.
9444         * psymtab.h (class psymtab_storage): New.
9445         * psymtab.c (psymtab_storage): New constructor.
9446         (~psymtab_storage): New destructor.
9447         (require_partial_symbols): Update.
9448         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9449         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9450         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9451         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9452         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9453         (start_psymtab_common, end_psymtab_common)
9454         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9455         (allocate_psymtab): Update.
9456         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9457         Update.
9458         (dump_psymtab_addrmap, maintenance_print_psymbols)
9459         (maintenance_check_psymtabs): Update.
9460         (class objfile_psymtabs): Move to objfiles.h.
9461         * psympriv.h (discard_psymtab): Now inline.
9462         (psymtab_discarder::psymtab_discarder): Update.
9463         (psymtab_discarder::~psymtab_discarder): Update.
9464         (ALL_OBJFILE_PSYMTABS): Rewrite.
9465         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9466         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9467         Remove fields.
9468         <partial_symtabs>: New field.
9469         (class objfile_psymtabs): Move from psymtab.h.  Update.
9470         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9471         psymbol_cache.
9472         (objfile::~objfile): Don't destroy psymbol_cache.
9473         * mdebugread.c (parse_partial_symbols): Update.
9474         * dwarf2read.c (create_addrmap_from_index)
9475         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9476         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9477         (add_partial_subprogram, dwarf2_ranges_read): Update.
9478         * dwarf-index-write.c (write_address_map)
9479         (write_one_signatured_type, recursively_write_psymbols)
9480         (class debug_names, class debug_names, write_psymtabs_to_index):
9481         Update.
9482
9483 2019-01-10  Tom Tromey  <tom@tromey.com>
9484
9485         * symtab.h (SYMBOL_SET_NAMES): Update.
9486         (symbol_set_names): Update.
9487         (MSYMBOL_SET_NAMES): Update.
9488         * symtab.c (symbol_set_names): Change argument to be an
9489         objfile_per_bfd_storage.
9490         * psymtab.c (add_psymbol_to_bcache): Update.
9491         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9492
9493 2019-01-10  Tom Tromey  <tom@tromey.com>
9494
9495         * symtab.c (create_demangled_names_hash): Change argument to be an
9496         objfile_per_bfd_storage.
9497         (symbol_set_names): Update.
9498
9499 2019-01-10  Tom Tromey  <tom@tromey.com>
9500
9501         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9502         init_psymbol_list.
9503         * psymtab.c (init_psymbol_list): Do nothing if already called.
9504         * psympriv.h (init_psymbol_list): Add comment.
9505         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9506         init_psymbol_list.
9507         * dbxread.c (dbx_symfile_read): Unconditionally call
9508         init_psymbol_list.
9509
9510 2019-01-10  Tom Tromey  <tom@tromey.com>
9511
9512         * xcoffread.c (scan_xcoff_symtab): Update.
9513         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9514         "where".
9515         * mdebugread.c (parse_partial_symbols)
9516         (handle_psymbol_enumerators): Update.
9517         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9518         * dbxread.c (read_dbx_symtab): Update.
9519         * psympriv.h (psymbol_placement): New enum.
9520         (add_psymbol_to_list): Update.
9521
9522 2019-01-10  Tom Tromey  <tom@tromey.com>
9523
9524         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9525         static_psymbols parameters.
9526         (scan_xcoff_symtab): Update.
9527         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9528         static_psymbols parameters.
9529         * psympriv.h (start_psymtab_common): Update.
9530         * mdebugread.c (parse_partial_symbols): Update.
9531         * dwarf2read.c (create_partial_symtab): Update.
9532         * dbxread.c (read_dbx_symtab): Update.
9533         (start_psymtab): Remove global_psymbols and static_psymbols
9534         parameters.
9535
9536 2019-01-10  Tom Tromey  <tom@tromey.com>
9537
9538         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9539         * psymtab.c (allocate_psymtab): Add comment.
9540         * psympriv.h (allocate_psymtab): Add comment.
9541         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9542         initializations.
9543         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9544
9545 2019-01-10  Tom Tromey  <tom@tromey.com>
9546
9547         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9548         Don't declare.
9549         * mipsread.c: Include mdebugread.h.
9550         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9551         Declare.
9552         * elfread.c: Include mdebugread.h.
9553
9554 2019-01-09  Tom Tromey  <tom@tromey.com>
9555
9556         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9557         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9558         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9559         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9560         (psym_lookup_symbol, psym_find_last_source_symtab)
9561         (psym_forget_cached_source_info, psym_print_stats)
9562         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9563         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9564         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9565         (psym_find_compunit_symtab_by_address)
9566         (maintenance_print_psymbols, maintenance_info_psymtabs)
9567         (maintenance_check_psymtabs): Use ranged for.
9568         * psymtab.h (class objfile_psymtabs): New.
9569         (require_partial_symbols): Return objfile_psymtabs.
9570         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9571
9572 2019-01-09  Tom Tromey  <tom@tromey.com>
9573
9574         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9575         (find_pc_mapped_section, list_overlays_command)
9576         (map_overlay_command, unmap_overlay_command)
9577         (simple_overlay_update): Use all_objfiles.
9578         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9579         * printcmd.c (info_symbol_command): Use all_objfiles.
9580         * objfiles.h (ALL_OBJSECTIONS): Remove.
9581         * maint.c (maintenance_translate_address): Use all_objfiles.
9582         * gcore.c (gcore_create_callback): Use all_objfiles.
9583         (objfile_find_memory_regions): Likewise.
9584
9585 2019-01-09  Tom Tromey  <tom@tromey.com>
9586
9587         * symtab.c (find_line_symtab, info_sources_command)
9588         (make_source_files_completion_list): Use objfile_compunits.
9589         * source.c (select_source_symtab): Use objfile_compunits.
9590         * objfiles.h (struct objfile): Update comment.
9591         (ALL_OBJFILES): Remove.
9592         (ALL_FILETABS): Remove.
9593         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9594         objfile_compunits.
9595
9596 2019-01-09  Tom Tromey  <tom@tromey.com>
9597
9598         * symmisc.c (print_objfile_statistics, dump_objfile)
9599         (maintenance_print_symbols): Use compunit_filetabs.
9600         * source.c (forget_cached_source_info_for_objfile): Use
9601         compunit_filetabs.
9602         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9603         (ALL_FILETABS): Use compunit_filetabs.
9604         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9605         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9606
9607 2019-01-09  Tom Tromey  <tom@tromey.com>
9608
9609         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9610         (compunit_filetabs): New.
9611         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9612         compunit_filetabs.
9613         (info_sources_command, make_source_files_completion_list): Remove
9614         declaration.
9615         * symmisc.c (print_objfile_statistics, dump_objfile)
9616         (maintenance_print_symbols): Remove declaration.
9617         (maintenance_info_symtabs): Use compunit_filetabs.
9618         (maintenance_info_line_tables): Likewise.
9619         * source.c (select_source_symtab): Change local variable name.
9620         (forget_cached_source_info_for_objfile): Remove declaration.
9621         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9622         * objfiles.c (objfile_relocate1): Remove declaration.
9623         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9624         declaration.
9625         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9626         * coffread.c (coff_symtab_read): Remove declaration.
9627         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9628         compunit_filetabs.
9629
9630 2019-01-09  Tom Tromey  <tom@tromey.com>
9631
9632         * symtab.c (lookup_objfile_from_block)
9633         (find_pc_sect_compunit_symtab, search_symbols)
9634         (default_collect_symbol_completion_matches_break_on): Use
9635         objfile_compunits.
9636         * objfiles.h (ALL_COMPUNITS): Remove.
9637         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9638         * cp-support.c (add_symbol_overload_list_qualified): Use
9639         objfile_compunits.
9640         * ada-lang.c (ada_collect_symbol_completion_matches)
9641         (ada_add_global_exceptions): Use objfile_compunits.
9642
9643 2019-01-09  Tom Tromey  <tom@tromey.com>
9644
9645         * source.c (select_source_symtab)
9646         (forget_cached_source_info_for_objfile): Remove declaration.
9647         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9648         declaration.
9649         * maint.c (count_symtabs_and_blocks): Remove declaration.
9650         * cp-support.c (add_symbol_overload_list_qualified): Remove
9651         declaration.
9652         * coffread.c (coff_symtab_read): Remove declaration.
9653         * symtab.c (lookup_symbol_in_objfile_symtabs)
9654         (basic_lookup_transparent_type_1): Use objfile_compunits.
9655         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9656         (info_sources_command, search_symbols)
9657         (default_collect_symbol_completion_matches_break_on)
9658         (make_source_files_completion_list): Remove declaration.
9659         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9660         (ada_collect_symbol_completion_matches)
9661         (ada_add_global_exceptions): Remove declaration.
9662         * linespec.c (iterate_over_all_matching_symtabs): Use
9663         objfile_compunits.
9664         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9665         (class objfile_compunits): New.
9666         (ALL_COMPUNITS): Use objfile_compunits.
9667         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9668         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9669         objfile_compunits.
9670         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9671
9672 2019-01-09  Tom Tromey  <tom@tromey.com>
9673
9674         * symtab.c (search_symbols)
9675         (default_collect_symbol_completion_matches_break_on): Use
9676         objfile_msymbols.
9677         * ada-lang.c (ada_lookup_simple_minsym)
9678         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9679         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9680         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9681         objfile_msymbols.
9682         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9683         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9684         * objc-lang.c (find_methods): Use objfile_msymbols.
9685         (info_selectors_command, info_classes_command): Likewise.
9686         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9687         * objfiles.h (class objfile_msymbols): New.
9688         (ALL_OBJFILE_MSYMBOLS): Remove.
9689         (ALL_MSYMBOLS): Remove.
9690
9691 2019-01-09  Tom Tromey  <tom@tromey.com>
9692
9693         * common/next-iterator.h (next_adapter): Add Iterator template
9694         parameter.
9695         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9696         (class all_objfiles_safe): New.
9697         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9698         * objfiles.c (put_objfile_before): Update comment.
9699         (add_separate_debug_objfile): Likewise.
9700         (free_all_objfiles): Use all_objfiles_safe.
9701         (objfile_purge_solibs): Likewise.
9702
9703 2019-01-09  Tom Tromey  <tom@tromey.com>
9704
9705         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9706         (expand_symtab_containing_pc, lookup_static_symbol)
9707         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9708         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9709         all_objfiles.
9710         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9711         * breakpoint.c (create_overlay_event_breakpoint)
9712         (create_longjmp_master_breakpoint)
9713         (create_std_terminate_master_breakpoint)
9714         (create_exception_master_breakpoint): Use all_objfiles.
9715         * linux-thread-db.c (try_thread_db_load_from_pdir)
9716         (has_libpthread): Use all_objfiles.
9717         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9718         * linespec.c (iterate_over_all_matching_symtabs)
9719         (search_minsyms_for_name): Use all_objfiles.
9720         * maint.c (maintenance_info_sections): Use all_objfiles.
9721         * main.c (captured_main_1): Use all_objfiles.
9722         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9723         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9724         * guile/scm-pretty-print.c
9725         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9726         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9727         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9728         (maintenance_print_msymbols): Use all_objfiles.
9729         * source.c (select_source_symtab): Use all_objfiles.
9730         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9731         * symfile.c (remove_symbol_file_command)
9732         (expand_symtabs_matching, map_symbol_filenames): Use
9733         all_objfiles.
9734         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9735         all_objfiles.
9736         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9737         * objc-lang.c (find_methods): Use all_objfiles.
9738         * objfiles.c (have_partial_symbols, have_full_symbols)
9739         (have_minimal_symbols, qsort_cmp)
9740         (default_iterate_over_objfiles_in_search_order): Use
9741         all_objfiles.
9742         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9743         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9744         (maintenance_check_psymtabs): Use all_objfiles.
9745         (ALL_PSYMTABS): Remove.
9746         * compile/compile-object-run.c (do_module_cleanup): Use
9747         all_objfiles.
9748         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9749         * cp-support.c (add_symbol_overload_list_qualified): Use
9750         all_objfiles.
9751         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9752         Use all_objfiles.
9753         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9754         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9755         all_objfiles.
9756         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9757         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9758         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9759         Uses all_objfiles.
9760         * solib.c (solib_read_symbols): Use all_objfiles
9761
9762 2019-01-09  Tom Tromey  <tom@tromey.com>
9763
9764         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9765         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9766         all_objfiles.
9767         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9768         * symmisc.c (print_symbol_bcache_statistics)
9769         (print_objfile_statistics, maintenance_print_objfiles)
9770         (maintenance_info_symtabs, maintenance_check_symtabs)
9771         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9772         all_objfiles.
9773         * source.c (forget_cached_source_info): Use all_objfiles.
9774         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9775         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9776         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9777         * objfiles.c (update_section_map): Use all_objfiles.
9778         (shared_objfile_contains_address_p): Likewise.
9779         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9780         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9781
9782 2019-01-09  Tom Tromey  <tom@tromey.com>
9783
9784         * common/next-iterator.h: New file.
9785         * objfiles.h (class all_objfiles): New.
9786         (struct objfile_iterator): New.
9787
9788 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9789
9790         * NEWS: Move the description of the changed "frame", "select-frame",
9791          and "info frame" commands to the Changed commands section.
9792
9793 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9794
9795         * gdbtypes.c (check_stub_method_group): Remove handling of old
9796         mangling schemes.
9797         * linespec.c (find_methods): Likewise.
9798         * stabsread.c (read_member_functions): Likewise.
9799         * valops.c (search_struct_method): Likewise.
9800         (value_struct_elt_for_reference): Likewise.
9801         * NEWS: Mention this change.
9802
9803 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9804
9805         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9806         print_source_lines.
9807         * source.c (print_source_lines_base): Update line number check.
9808         (print_source_lines): New function.
9809         (source_lines_range::source_lines_range): New function.
9810         * source.h (class source_lines_range): New class.
9811         (print_source_lines): New declaration.
9812
9813 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9814
9815         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9816
9817 2019-01-08  Tom Tromey  <tom@tromey.com>
9818             Simon Marchi  <simon.marchi@ericsson.com>
9819
9820         PR gdb/24060
9821         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9822         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9823         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9824         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9825         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9826         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9827
9828 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9829
9830         * source.c (select_source_symtab): Move header comment to
9831         declaration in source.h.
9832         (forget_cached_source_info_for_objfile): Likewise.
9833         (forget_cached_source_info): Likewise.
9834         (identify_source_line): Likewise.
9835         * source.h (identify_source_line): Move declaration from symtab.h
9836         and add comment from source.c
9837         (print_source_lines): Likewise.
9838         (forget_cached_source_info_for_objfile): Likewise.
9839         (forget_cached_source_info): Likewise.
9840         (select_source_symtab): Likewise.
9841         (enum print_source_lines_flag): Move definition from symtab.h.
9842         * symtab.h (identify_source_line): Move declaration to source.h.
9843         (print_source_lines): Likewise.
9844         (forget_cached_source_info_for_objfile): Likewise.
9845         (forget_cached_source_info): Likewise.
9846         (select_source_symtab): Likewise.
9847         (enum print_source_lines_flag): Move definition to source.h.
9848         * tui/tui-hooks.c: Add 'source.h' include.
9849
9850 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9851
9852         * source.c (print_source_lines_base): Handle requests to print
9853         reverse line number sequences, and guard against empty lines
9854         string.
9855
9856 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9857
9858         * source.c (print_source_lines_base): Fix skip of '\r' if next
9859         character is '\n'.
9860
9861 2019-01-06  Tom Tromey  <tom@tromey.com>
9862
9863         * c-exp.y (struct c_parse_state) <macro_original_text,
9864         expansion_obstack>: New member.
9865         (macro_original_text, expansion_obstack): Remove globals.
9866         (scan_macro_expansion, scanning_macro_expansion)
9867         (finished_macro_expansion): Update.
9868         (scan_macro_cleanup): Remove.
9869         (yylex, c_parse): Update.
9870
9871 2019-01-06  Tom Tromey  <tom@tromey.com>
9872
9873         * c-exp.y (struct c_parse_state) <strings>: New member.
9874         (operator_stoken): Update.
9875
9876 2019-01-06  Tom Tromey  <tom@tromey.com>
9877
9878         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9879         (union type_stack_elt) <typelist_val>: Now a pointer to
9880         std::vector.
9881         (type_stack_cleanup): Don't declare.
9882         (push_typelist): Update.
9883         * parse.c (pop_typelist): Return a std::vector.
9884         (push_typelist): Take a std::vector.
9885         (follow_types): Update.  Do not free args.
9886         (type_stack_cleanup): Remove.
9887         * c-exp.y (struct c_parse_state): New.
9888         (cpstate): New global.
9889         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9890         (nonempty_typelist): Update.
9891         (func_mod): Create a new vector.
9892         (c_parse): Create a c_parse_state.
9893         (check_parameter_typelist): Do not delete params.
9894         (function_method): Update.  Do not delete type_list.
9895
9896 2019-01-06  Tom Tromey  <tom@tromey.com>
9897
9898         PR gdb/28155:
9899         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9900         check_typedef.
9901         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9902         (print_return_value): Likewise.
9903
9904 2019-01-05  Tom Tromey  <tom@tromey.com>
9905
9906         * contrib/cleanup_check.py: Remove.
9907         * contrib/gcc-with-excheck: Remove.
9908         * contrib/exsummary.py: Remove.
9909         * contrib/excheck.py: Remove.
9910
9911 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9912
9913         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9914         NULL. Initialize tpprev to NULL instead of assigning it
9915         to NULL on the next statement.
9916         * windows-nat.c (windows_delete_thread): Remove check for
9917         main_thread_id before printing thread exit notifications.
9918         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9919         Remove thread ID check against main_thread_id.
9920         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9921         windows_delete_thread.
9922         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9923
9924 2019-01-04  Tom Tromey  <tom@tromey.com>
9925
9926         * compile/compile.c (_initialize_compile): Use upper case for
9927         metasyntactic variables.
9928         * symmisc.c (_initialize_symmisc): Use upper case for
9929         metasyntactic variables.
9930         * psymtab.c (_initialize_psymtab): Use upper case for
9931         metasyntactic variables.
9932         * demangle.c (demangle_command): Use upper case for metasyntactic
9933         variables.
9934         (_initialize_demangler): Likewise.
9935         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9936         variables.
9937
9938 2019-01-03  Tom Tromey  <tom@tromey.com>
9939
9940         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9941
9942 2019-01-03  Tom Tromey  <tom@tromey.com>
9943
9944         * python/py-symtab.c (salpy_str): Update.
9945         (struct salpy_sal_object) <symtab>: Now a PyObject.
9946         (salpy_dealloc): Update.
9947         (del_objfile_sal): Use gdbpy_ref.
9948
9949 2019-01-03  Tom Tromey  <tom@tromey.com>
9950
9951         * python/py-type.c (convert_field): Use new_reference.  Return
9952         gdbpy_ref.
9953         (make_fielditem): Return gdbpy_ref.
9954         (typy_fields): Update.
9955         (typy_getitem): Update.
9956         (field_name): Return gdbpy_ref.  Use new_reference.
9957         (typy_iterator_iternext): Update.
9958
9959 2019-01-03  Tom Tromey  <tom@tromey.com>
9960
9961         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9962
9963 2019-01-03  Tom Tromey  <tom@tromey.com>
9964
9965         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9966         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9967         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9968         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9969         (pspy_set_type_printers): Likewise.
9970         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9971         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9972         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9973         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9974         (objfpy_set_type_printers): Likewise.
9975
9976 2019-01-03  Tom Tromey  <tom@tromey.com>
9977
9978         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9979         (gdbpy_print_stack): Use gdbpy_err_fetch.
9980         * python/python-internal.h (class gdbpy_err_fetch): New class.
9981         (class gdbpy_enter) <m_error_type, m_error_value,
9982         m_error_traceback>: Remove.
9983         <m_error>: New member.
9984         (gdbpy_exception_to_string): Don't declare.
9985         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9986         * python/py-value.c (convert_value_from_python): Use
9987         gdbpy_err_fetch.
9988         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9989         gdbpy_exception_to_string.
9990         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9991         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9992         gdbpy_err_fetch.
9993
9994 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9995
9996         * linux-nat.c (delete_lwp_cleanup): Delete.
9997         (struct lwp_deleter): New struct.
9998         (lwp_info_up): New typedef.
9999         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10000         lwp_info_up.
10001
10002 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10003
10004         * linux-fork.c (class scoped_switch_fork_info): New class.
10005         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10006
10007 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10008
10009         * valops.c (find_overload_match): Remove use of null_cleanup, and
10010         calls to do_cleanups.
10011
10012 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * compile/compile-cplus-types.c
10015         (compile_cplus_instance::decl_name): Handle changes to
10016         cp_func_name.
10017         * cp-support.c (cp_func_name): Update header comment, update
10018         return type.
10019         * cp-support.h (cp_func_name): Update return type in declaration.
10020         * valops.c (find_overload_match): Move temp_func local to top
10021         level of function and change its type.  Use temp_func to hold and
10022         delete temporary string obtained from cp_func_name.
10023
10024 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10025
10026         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10027         gdb::char_vector, remove cleanup, and update uses of `msg`.
10028
10029 2019-01-03  Jim Wilson  <jimw@sifive.com>
10030
10031         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10032
10033 2019-01-02  Tom Tromey  <tom@tromey.com>
10034
10035         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10036         (tdesc_parse_xml): Remove cleanups.
10037         * target-descriptions.h (make_cleanup_free_target_description):
10038         Don't declare.
10039         (target_desc_deleter): New struct.
10040         (target_desc_up): New typedef.
10041         * target-descriptions.c (target_desc_deleter::operator()): Rename
10042         from free_target_description.
10043         (make_cleanup_free_target_description): Remove.
10044
10045 2019-01-02  Tom Tromey  <tom@tromey.com>
10046
10047         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10048         constructor, destructor.
10049         (linespec_parser): Remove typedef.
10050         (~linespec_parser): Rename from linespec_parser_delete.
10051         (linespec_lex_to_end, linespec_complete_label)
10052         (linespec_complete): Update.
10053         (decode_line_full): Remove cleanups.
10054         (decode_line_1): Update.
10055
10056 2019-01-02  Tom Tromey  <tom@tromey.com>
10057
10058         * python/python-internal.h (inferior_to_inferior_object): Change
10059         return type.
10060         * python/py-exitedevent.c (create_exited_event_object): Update.
10061         * python/py-inferior.c (inferior_to_inferior_object): Return
10062         gdbpy_ref.
10063         (python_new_inferior, python_inferior_deleted)
10064         (thread_to_thread_object, delete_thread_object)
10065         (build_inferior_list, gdbpy_selected_inferior): Update.
10066         * python/py-infthread.c (create_thread_object): Update.  Also fail
10067         if inferior_to_inferior_object fails.
10068
10069 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10070
10071         * inferior.h (class inferior) <displaced_step_state>: New field.
10072         * infrun.h (struct displaced_step_state): Move here from
10073         infrun.c.  Initialize fields, add constructor.
10074         <inf>: Remove field.
10075         <reset>: New method.
10076         * infrun.c (struct displaced_step_inferior_state): Move to
10077         infrun.h.
10078         (displaced_step_inferior_states): Remove.
10079         (get_displaced_stepping_state): Adust.
10080         (displaced_step_in_progress_any_inferior): Adjust.
10081         (displaced_step_in_progress_thread): Adjust.
10082         (displaced_step_in_progress): Adjust.
10083         (add_displaced_stepping_state): Remove.
10084         (get_displaced_step_closure_by_addr): Adjust.
10085         (remove_displaced_stepping_state): Remove.
10086         (infrun_inferior_exit): Call displaced_step_state.reset.
10087         (use_displaced_stepping): Don't check for NULL.
10088         (displaced_step_prepare_throw): Call
10089         get_displaced_stepping_state.
10090         (displaced_step_fixup): Don't check for NULL.
10091         (prepare_for_detach): Don't check for NULL.
10092
10093 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10094
10095         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10096          in case of call that did not complete.
10097
10098 2019-01-02  Andrey Utkin  <autkin@undo.io>
10099
10100         * symfile.c (find_separate_debug_file): Fix search of debug files for
10101         remote debuggee.
10102
10103 2019-01-02  Tom Tromey  <tom@tromey.com>
10104
10105         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10106         indentation.
10107         * python/py-frame.c (frapy_older): Remove cast.
10108         (frapy_newer): Likewise.
10109         * python/py-breakpoint.c (local_setattro): Remove cast.
10110         * python/py-arch.c (archpy_name): Remove local variable.
10111         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10112
10113 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10114
10115         * unittests/basic_string_view/element_access/char/empty.cc:
10116         Fix year range in copyright header.
10117
10118 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10119
10120         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10121         Delete.
10122         <operator==>: Update with for removed field.
10123         <hash>: Likewise.
10124         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10125         <isa_features>: ...this.
10126         <abi_features>: New field.
10127         (riscv_isa_flen): Update comment.
10128         (riscv_abi_xlen): New declaration.
10129         (riscv_abi_flen): New declaration.
10130         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10131         isa_features.
10132         (riscv_abi_xlen): New function.
10133         (riscv_isa_flen): Update to get answer from isa_features.
10134         (riscv_abi_flen): New function.
10135         (riscv_has_fp_abi): Update to get answer from abi_features.
10136         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10137         xlen and flen.
10138         (riscv_call_info) <xlen, flen>: Update comment.
10139         (riscv_call_arg_struct): Remove invalid assertions
10140         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10141         is removed.
10142         (riscv_gdbarch_init): Gather isa features and abi features
10143         separately, ensure both match on the gdbarch when reusing an old
10144         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10145         a target with 64-bit float hardware.
10146
10147 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10148
10149         * source.c (search_command_helper): Stop reverse search
10150         when line 1 has been searched.
10151
10152 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10153
10154         * record-full.c (record_full_base_target::close): Rewrite
10155         record_full_core_buf_list free logic.
10156
10157 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10158
10159         * break-catch-syscall.c (print_one_catch_syscall): xfree
10160         the last text.
10161
10162 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10163
10164         * top.c (print_gdb_version): Update Copyright year in version
10165         message.
10166
10167 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10168
10169         Update copyright year range in all GDB files.
10170
10171 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10172
10173         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10174
10175 For older changes see ChangeLog-2018.
10176 \f
10177 Local Variables:
10178 mode: change-log
10179 left-margin: 8
10180 fill-column: 74
10181 version-control: never
10182 coding: utf-8
10183 End:
10184