gdb/ChangeLog

   1 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
   2
   3         PR gdb/25190:
   4         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
   5         * gdb/remote.c (remote_console_output): Update.
   6         * gdb/ui-file.c (fputs_unfiltered): Rename to...
   7         (ui_file_puts): ...this.
   8         * gdb/ui-file.h (ui_file_puts): Add declaration.
   9         * gdb/utils.c (emit_style_escape): Update.
  10         (flush_wrap_buffer): Update.
  11         (fputs_maybe_filtered): Update.
  12         (fputs_unfiltered): Add function.
  13
  14 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
  15
  16         * gdb/event-loop.c (gdb_wait_for_event): Update.
  17         * gdb/printcmd.c (printf_command): Update.
  18         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
  19         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
  20         (gdb_os_flush_stderr): Update.
  21         * gdb/remote.c (remote_console_output): Update.
  22         * gdb/ui-file.c (gdb_flush): Rename to...
  23         (ui_file_flush): ...this.
  24         (stderr_file::write): Update.
  25         (stderr_file::puts): Update.
  26         * gdb/ui-file.h (gdb_flush): Rename to...
  27         (ui_file_flush): ...this.
  28         * gdb/utils.c (gdb_flush): Add function.
  29         * gdb/utils.h (gdb_flush): Add declaration.
  30
  31 2020-02-07  Tom Tromey  <tromey@adacore.com>
  32
  33         PR breakpoints/24915:
  34         * source.c (find_and_open_source): Do not check basenames_may_differ.
  35
  36 2020-01-10  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
  39
  40 2020-01-07  Tom Tromey  <tromey@adacore.com>
  41
  42         PR build/24937:
  43         * stap-probe.c (class stap_static_probe_ops): Add constructor.
  44
  45 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * stack.c (print_frame_info): Move disassemble_next_line code
  48         inside source_print block.
  49
  50 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  51
  52         * gdbarch.sh: Update copyright year range of generated files.
  53
  54 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  55
  56         Update copyright year range in all the GDB files automatically
  57         handled by our copyright.py script.
  58
  59 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  60
  61         * copyright.py: Convert to Python 3.
  62
  63 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  64
  65         * copyright.py: Adapt after move of gnulib directory from gdb
  66         directory to toplevel directory.
  67
  68 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  69
  70         * copyright.py (main): Exit if run from the wrong directory.
  71
  72 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  73
  74         * top.c (print_gdb_version): Change copyright year to 2020.
  75
  76 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
  77
  78         * configure: Regenerate.
  79         * configure.ac: Quote variable arguments of test.
  80         * gdbsupport/common.m4: Likewise.
  81
  82 2019-12-21  Eli Zaretskii  <eliz@gnu.org>
  83
  84         * top.c (print_gdb_configuration): Print "--with-xxhash" or
  85         "--without-xxhash" according to HAVE_LIBXXHASH.
  86
  87 2019-12-18  Tom Tromey  <tromey@adacore.com>
  88
  89         PR build/25268:
  90         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  91         type on macOS.  Add comment.
  92
  93 2019-12-18  Tom Tromey  <tromey@adacore.com>
  94
  95         PR build/25250:
  96         * ui-out.c (ui_out::vmessage): Update.
  97         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  98         Rename.
  99         (string_field): Update.
 100         (signed_field): Update.
 101
 102 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 103
 104         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 105
 106 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 107
 108         * version.in: Set GDB version number to 9.0.90.DATE-git.
 109
 110 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 111
 112         GDB 9.0.90 released.
 113
 114 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 115
 116         * version.in: Set GDB version number to 9.0.90.
 117
 118 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 119
 120         * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
 121
 122 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 123
 124         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 125         * version.in: Bump version to 9.0.90.DATE-git.
 126
 127 2019-12-11  Tom Tromey  <tromey@adacore.com>
 128
 129         PR build/25268:
 130         * gdbsupport/thread-pool.c (set_thread_name): New function.
 131         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 132         (thread_pool::thread_function): Call set_thread_name.
 133
 134 2019-12-11  Tom Tromey  <tromey@adacore.com>
 135
 136         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 137         bfd_get_signed_8.
 138
 139 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 140
 141         * NEWS: Document -raw-values option and the related setting commands.
 142         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 143         only set it on when /r is given.
 144         * valprint.c (value_print_option_defs): New element raw-values.
 145         * Makefile.in: Add the new file.
 146
 147 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 148
 149         * gdbsupport/safe-strerror.c: Supress the unused function warning
 150         for select_strerror_r.
 151
 152 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 153
 154         * config.in: Regenerate.
 155         * configure: Regenerate.
 156         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 157         safe_strerror instead of strerror.
 158         * gdbsupport/common.m4: Don't check for strerror.
 159         * gdbsupport/safe-strerror.c: Support both the glibc version
 160         of strerror_r and the XSI version.
 161
 162 2019-12-10  Tom Tromey  <tromey@adacore.com>
 163
 164         * ada-typeprint.c (print_choices): Use a single "?".
 165         (print_variant_part): Print "?" if the discriminant name
 166         is not known.
 167
 168 2019-12-10  George Barrett  <bob@bob131.so>
 169
 170         Fix scripted probe breakpoints.
 171         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 172         declaration forward.
 173         (breakpoint_ops_for_event_location_type)
 174         (breakpoint_ops_for_event_location): Add function definitions.
 175         (break_command_1, trace_command): Use
 176         breakpoint_ops_for_event_location.
 177         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 178         declarations.
 179         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 180         breakpoint_ops_for_event_location.
 181         * python/py-breakpoint.c (bppy_init): Use
 182         breakpoint_ops_for_event_location.
 183
 184 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 185
 186         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 187         when ranking an lvalue argument for an rvalue parameter.
 188
 189 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 190
 191         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 192         template argument for scoped_restore_tmpl from bool to int.
 193
 194 2019-12-07  Keith Seitz  <keiths@redhat.com>
 195
 196         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 197         (build_id_to_debug_bfd): Make static, rewriting to use
 198         build_id_to_bfd_suffix.
 199         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 200         adding `suffix' parameter. Append SUFFIX to file names
 201         when searching for matching files.
 202         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 203         (build_id_to_exec_bfd): Likewise.
 204         * build-id.h (build_id_to_debug_bfd): Clarify that function
 205         searches for BFD of debug info file.
 206         (build_id_to_exec_bfd): Declare.
 207         * corelow.c: Include build-id.h.
 208         (locate_exec_from_corefile_build_id): New function.
 209         (core_target_open): If no executable BFD is found,
 210         search for a core file BFD using build-id.
 211
 212 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 213
 214         * bcache.c: Put in namespace gdb.
 215         * bcache.h: Likewise.
 216         * gdbtypes.c (check_types_worklist): Update.
 217         (types_deeply_equal): Update.
 218         * macrotab.c (struct macro_table) <bcache>: Update.
 219         (new_macro_table): Update.
 220         * macrotab.h (struct bcache): Put this forward declaration
 221         inside namespace gdb.
 222         (new_macro_table): Update.
 223         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 224         Update.
 225         <macro_cache>: Update.
 226         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 227
 228 2019-12-06  Tom de Vries  <tdevries@suse.de>
 229
 230         PR symtab/24971
 231         * block.c (best_symbol, better_symbol): New function.
 232         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 233         decl.
 234
 235 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 236
 237         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 238         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 239         for ranking see-through reference cases.
 240
 241 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 242         * stack.c (faas_command): Check a command is provided.
 243         * thread.c (taas_command, tfaas_command): Likewise.
 244
 245 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 246         * inferior.c (prune_inferiors):  Only call delete_inferior,
 247         Do not modify the inferior list.
 248
 249 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 250
 251         * c-exp.y: Update calls to lookup_typename,
 252         lookup_signed_typename and lookup_unsigned_typename.
 253         * c-lang.c (evaluate_subexp_c): Likewise.
 254         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 255         Likewise.
 256         * eval.c (binop_promote): Likewise.
 257         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 258         (lookup_unsigned_typename): Likewise.
 259         (lookup_signed_typename): Likewise.
 260         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 261         (lookup_signed_typename): Likewise.
 262         (lookup_typename): Likewise.
 263         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 264         lookup_typename, lookup_signed_typename,
 265         lookup_unsigned_typename.
 266         * m2-exp.y: Likewise.
 267         * printcmd.c (printf_wide_c_string): Likewise.
 268         (ui_printf): Likewise.
 269         * python/py-type.c (typy_lookup_typename): Likewise.
 270         * python/py-xmethods.c (python_xmethod_worker::invoke):
 271         Likewise.
 272         * rust-exp.y: Likewise.
 273
 274 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 275
 276         * configure.nat (obsd64): Add missing files x86-nat.o and
 277         nat/x86-dregs.o.
 278
 279 2019-12-04  Tom Tromey  <tom@tromey.com>
 280
 281         * valprint.c (val_print_string): Use metadata_style.
 282         * go-valprint.c (print_go_string): Use metadata style.
 283         * p-valprint.c (pascal_object_print_static_field): Use metadata
 284         style.
 285         * cp-valprint.c (cp_print_static_field): Use metadata style.
 286
 287 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 288             Chris January  <chris.january@arm.com>
 289
 290         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 291         tokens.
 292         (typebase): New patterns for complex, single/double precision, and
 293         single/double complex.
 294         (f77_keywords): Change token for complex keyword, and add single,
 295         double, and precision keywords.
 296
 297 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 298
 299         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 300         "info io_registers".
 301
 302 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 303
 304         * regcache.c (cooked_read_test): Initialize thread list of
 305         mock_inferior.
 306
 307 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 308
 309         * aarch64-linux-tdep.c: Remove includes.
 310
 311 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 312
 313         * aarch64-tdep.c: Remove includes.
 314
 315 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 316
 317         * filtered-iterator.h (filtered_iterator) <operator==,
 318         operator!=>: Compare wrapped iterators, not wrapped pointers.
 319         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 320         unittests/filtered_iterator-selftests.c.
 321         * unittests/filtered_iterator-selftests.c: New file.
 322
 323 2019-12-04  Tom Tromey  <tromey@adacore.com>
 324
 325         * gdbtypes.c (create_range_type): Inherit endianity
 326         from base type.
 327
 328 2019-12-04  Tom Tromey  <tromey@adacore.com>
 329
 330         * ada-lang.c (decode_constrained_packed_array)
 331         (ada_value_assign, value_assign_to_component): Update.
 332         * dwarf2loc.c (rw_pieced_value, access_memory)
 333         (dwarf2_compile_expr_to_ax): Update.
 334         * dwarf2read.c (dwarf2_add_field): Update.
 335         * eval.c (evaluate_subexp_standard): Update.
 336         * gdbarch.c, gdbarch.h: Rebuild.
 337         * gdbarch.sh (bits_big_endian): Remove.
 338         * gdbtypes.h (union field_location): Update comment.
 339         * target-descriptions.c (make_gdb_type): Update.
 340         * valarith.c (value_bit_index): Update.
 341         * value.c (struct value) <bitpos>: Update comment.
 342         (unpack_bits_as_long, modify_field): Update.
 343         * value.h (value_bitpos): Update comment.
 344
 345 2019-12-04  Tom Tromey  <tromey@adacore.com>
 346
 347         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 348         endian-ness.
 349
 350 2019-12-04  Tom Tromey  <tromey@adacore.com>
 351
 352         * dwarf2read.c (dwarf2_init_float_type)
 353         (dwarf2_init_complex_target_type): Add byte_order parameter.
 354         (read_base_type): Compute byte order earlier.
 355         * gdbtypes.c (init_float_type): Add byte_order parameter.
 356         * gdbtypes.h (init_float_type): Add byte_order parameter.
 357
 358 2019-12-04  Tom Tromey  <tromey@adacore.com>
 359
 360         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 361
 362 2019-12-04  Tom Tromey  <tromey@adacore.com>
 363
 364         * dwarf2read.c (process_structure_scope): Initialize
 365         "discr_offset".
 366
 367 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 370         add it into the search spec.
 371         (parse_max_results_option): New function.
 372         (mi_info_functions_or_variables): Parse -max-results flag and pass
 373         it to mi_symbol_info.
 374         (mi_cmd_symbol_info_modules): Likewise.
 375         (mi_cmd_symbol_info_types): Likewise.
 376         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 377         return type to bool, change result container into a set, and don't
 378         add new results if we have enough already.
 379         (global_symbol_searcher::add_matching_msymbols): Change return
 380         type to bool, and don't add new results if we have enough already.
 381         (sort_search_symbols_remove_dups): Delete.
 382         (global_symbol_searcher::search): Early exit from search loop when
 383         we have enough results.  Use a std::set to collect the results
 384         from calling add_matching_symbols.
 385         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 386         member function.
 387         (global_symbol_searcher) <m_max_search_results>: New member
 388         variable.
 389         (global_symbol_searcher) <add_matching_symbols>: Update header
 390         comment and change return type to bool.
 391         (global_symbol_searcher) <add_matching_msymbols>: Update header
 392         comment and change return type to bool.
 393
 394 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * symtab.c (symbol_search::compare_search_syms): Update header
 397         comment.
 398         (global_symbol_searcher::is_suitable_msymbol): New function.
 399         (global_symbol_searcher::expand_symtabs): New function.
 400         (global_symbol_searcher::add_matching_symbols): New function.
 401         (global_symbol_searcher::add_matching_msymbols): New function.
 402         (global_symbol_searcher::search): Move most of the content
 403         into the new functions above, and call them as needed.
 404         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 405         function.
 406         (global_symbol_searcher) <add_matching_symbols>: New member
 407         function.
 408         (global_symbol_searcher) <add_matching_msymbols>: New member
 409         function.
 410         (global_symbol_searcher) <is_suitable_msymbol>: New member
 411         function.
 412
 413 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 414
 415         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 416         -symbol-info-module-variables entries.
 417         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 418         (mi_cmd_symbol_info_module_variables): Declare.
 419         * mi/mi-symbol-cmds.c
 420         (module_symbol_search_iterator): New typedef.
 421         (output_module_symbols_in_single_module_and_file): New function.
 422         (output_module_symbols_in_single_module): New function.
 423         (mi_info_module_functions_or_variables): New function.
 424         (mi_cmd_symbol_info_module_functions): New function.
 425         (mi_cmd_symbol_info_module_variables): New function.
 426         * NEWS: Mention new MI command.
 427
 428 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * bcache.c (hash): Remove.
 431         (hash_continue): Remove.
 432         * bcache.h (hash): Remove.
 433         (hash_continue): Remove.
 434         (struct bcache) <ctor>: Update.
 435         * psymtab.c (psymbol_hash): Update.
 436         * stabsread.c (hashname): Update.
 437         * utils.h (fast_hash): Add an argument for a start value,
 438         defaulting to zero.
 439
 440 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 441         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 442         (destroy_block_symbol_cache): New function.
 443         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 444         (resize_symbol_cache): Likewise.
 445
 446 2019-12-02  Tom Tromey  <tom@tromey.com>
 447
 448         * unittests/tui-selftests.c (run_tests): Make conditional.
 449         (_initialize_tui_selftest): Make conditional.
 450
 451 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 452
 453         * aix-thread.c (debug_aix_thread): Change type to bool.
 454
 455 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 456
 457         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 458
 459 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * dwarf2read.c (read_tag_string_type): Read the fields required to
 462         make a dynamic string, and possibly create a dynamic range for the
 463         string.
 464         (attr_to_dynamic_prop): Setup is_reference based on the type of
 465         attribute being processed.
 466         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 467         (resolve_dynamic_array): Rename to...
 468         (resolve_dynamic_array_or_string): ...this, update header comment,
 469         and accept TYPE_CODE_STRING.
 470         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 471
 472 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 475         of its implementation from...
 476         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 477         the new function.
 478
 479 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 482         create a range with stride where appropriate.
 483         * f-valprint.c: Include 'gdbarch.h'.
 484         (f77_print_array_1): Take the stride into account when walking the
 485         array.  Also convert the stride into addressable units.
 486         * gdbtypes.c (create_range_type): Initialise the stride to
 487         constant zero.
 488         (create_range_type_with_stride): New function, initialise the
 489         range as normal, and then setup the stride.
 490         (has_static_range): Include the stride here.  Also change the
 491         return type to bool.
 492         (create_array_type_with_stride): Consider the range stride if the
 493         array isn't given its own stride.
 494         (resolve_dynamic_range): Resolve the stride if needed.
 495         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 496         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 497         (TYPE_BIT_STRIDE): Define.
 498         (TYPE_ARRAY_BIT_STRIDE): Define.
 499         (create_range_type_with_stride): Declare.
 500         * valarith.c (value_subscripted_rvalue): Take range stride into
 501         account when walking the array.
 502
 503 2019-12-01  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 506         specially.
 507
 508 2019-12-01  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 511         \0.
 512         * unittests/tui-selftests.c: New file.
 513         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 514
 515 2019-12-01  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 518
 519 2019-12-01  Tom Tromey  <tom@tromey.com>
 520
 521         * NEWS: Document new settings.
 522         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 523         * tui/tui-win.c (_initialize_tui_win): Add border style
 524         observers.
 525         * tui/tui-io.h (tui_apply_style): Declare.
 526         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 527         longer static.
 528         (apply_ansi_escape, tui_set_reverse_mode): Update.
 529         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 530         Add "skip_intensity" parameter.
 531         <changed>: New member.
 532         <do_set_value>: Declare.
 533         (tui_border_style, tui_active_border_style): Declare.
 534         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 535         globals.
 536         (cli_style_option): Initialize "changed".
 537         (cli_style_option::do_set_value): New function.
 538         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 539         parameter.  Update.
 540         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 541         (_initialize_cli_style): Update.  Create TUI border style
 542         commands.
 543
 544 2019-12-01  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 547         parameter.
 548         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 549         parameter.
 550         * tui/tui-win.h (compact_source): Declare.
 551         * tui/tui-win.c (compact_source): New global.
 552         (tui_set_compact_source, tui_show_compact_source): New functions.
 553         (_initialize_tui_win): Add "compact-source" setting.
 554         * tui/tui-source.c (tui_source_window::set_contents): Handle
 555         compact_source setting.
 556         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 557         * NEWS: Document new setting.
 558
 559 2019-11-30  Tom Tromey  <tom@tromey.com>
 560
 561         * dwarf2read.c (dwarf2_add_field): Include field offset when
 562         computing variant part length.
 563
 564 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 565         * NEWS:  Mention define-prefix.  Tell that command names can now
 566         contain a . character.
 567
 568 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 569
 570         * command.h (valid_cmd_char_p): Declare.
 571         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 572         the check of valid command char.
 573         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 574         valid_cmd_char_p.
 575         * cli/cli-script.c (validate_comname): Likewise.
 576         * completer.c (gdb_completer_command_word_break_characters):
 577         Do not remove . from the word break char, update comments.
 578         (complete_line_internal_1): Use valid_cmd_char_p.
 579         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 580         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 581
 582 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 583
 584         * cli/cli-script.c (do_define_command): Ensure a redefined
 585         prefix command is kept as a prefix command.
 586         (define_prefix_command): New function.
 587         (show_user_1): Report user defined prefixes.
 588         (_initialize_cli_script):  Create the new 'define-prefix' command.
 589         Add completers for 'define' and 'document'.
 590         * top.c (execute_command):  If command is a user-defined prefix only
 591         command, report the list of commands for this prefix command.
 592
 593 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 594
 595         * valops.c (find_oload_champ): Improve debug output.
 596
 597 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 598
 599         * valops.c (find_oload_champ): Print part of debug messages
 600         before the badness vector is std::move'd.
 601
 602 2019-11-28  Tom Tromey  <tom@tromey.com>
 603
 604         * value.c (creal_internal_fn): Fix comment.
 605
 606 2019-11-28  Tom Tromey  <tom@tromey.com>
 607
 608         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 609         flag_bound_evaluated>: Now unsigned.
 610
 611 2019-11-28  Tom Tromey  <tom@tromey.com>
 612
 613         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 614         declare.
 615
 616 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 617
 618         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 619         debug output.
 620         * jit.c (jit_unregister_code): Add debug print to match
 621         `jit_register_code`.
 622
 623 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 624
 625         * NEWS: Mention the new multithreaded symbol loading.
 626
 627 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 628
 629         * maint.c (n_worker_threads): Default to 0.
 630         (worker_threads_disabled): New function.
 631         * maint.h (worker_threads_disabled): New function.
 632         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 633         here if worker_threads_disabled () is true.
 634         (minimal_symbol_reader::install): Skip all threading if
 635         worker_threads_disabled () is true.
 636
 637 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 638
 639         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 640         hash code if possible.
 641         (add_minsym_to_demangled_hash_table): Likewise.
 642         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 643         on the background thread.
 644         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 645         Add these fields.
 646
 647 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 648
 649         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 650         of the mangled name on the background thread.
 651         * symtab.c (symbol_set_names): Allow passing in the hash of the
 652         linkage_name.
 653         * symtab.h (symbol_set_names): Likewise.
 654
 655 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 656
 657         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 658         physnames are computed for inherited DIEs.
 659
 660 2019-11-27  Tom Tromey  <tromey@adacore.com>
 661
 662         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 663         backslashes.
 664         * cp-support.c: Remove unnecessary backslashes.
 665
 666 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 667
 668         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 669         with sym->set_linkage_name.
 670         * coffread.c (coff_read_enum_type): Likewise.
 671         * mdebugread.c (parse_symbol): Likewise.
 672         * stabsread.c (patch_block_stabs): Likewise.
 673         (define_symbol): Likewise.
 674         (read_enum_type): Likewise.
 675         (common_block_end): Likewise.
 676         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 677         function.
 678         (SYMBOL_SET_LINKAGE_NAME): Remove.
 679         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 680         with sym->set_linkage_name.
 681
 682 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 685         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 686         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 687         * NEWS: Mention new MI command.
 688
 689 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 692         '-symbol-info-types', and '-symbol-info-variables'.
 693         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 694         (mi_cmd_symbol_info_types): Declare.
 695         (mi_cmd_symbol_info_variables): Declare.
 696         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 697         (output_debug_symbol): New function.
 698         (output_nondebug_symbol): New function.
 699         (mi_symbol_info): New function.
 700         (mi_info_functions_or_variables): New function.
 701         (mi_cmd_symbol_info_functions): New function.
 702         (mi_cmd_symbol_info_types): New function.
 703         (mi_cmd_symbol_info_variables): New function.
 704         * NEWS: Mention new commands.
 705
 706 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * symtab.c (symbol_to_info_string): New function, most content
 709         moved from print_symbol_info, but updated to return a std::string.
 710         (print_symbol_info): Update to use symbol_to_info_string and print
 711         returned string.
 712         * symtab.h (symbol_to_info_string): Declare new function.
 713
 714 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * python/python.c (gdbpy_rbreak): Convert to using
 717         global_symbol_searcher.
 718         * symtab.c (file_matches): Convert return type to bool, change
 719         file list to std::vector, update header comment.
 720         (search_symbols): Rename to...
 721         (global_symbol_searcher::search): ...this and update now its
 722         a member function of global_symbol_searcher.  Take account of the
 723         changes to file_matches.
 724         (symtab_symbol_info): Convert to using global_symbol_searcher.
 725         (rbreak_command): Likewise.
 726         (search_module_symbols): Likewise.
 727         * symtab.h (enum symbol_search): Update comment.
 728         (search_symbols): Remove declaration.
 729         (class global_symbol_searcher): New class.
 730
 731 2019-11-26  Tom Tromey  <tromey@adacore.com>
 732
 733         * cp-support.c (_initialize_cp_support): Conditionally initialize
 734         gdb_demangle_attempt_core_dump.
 735
 736 2019-11-26  Tom Tromey  <tom@tromey.com>
 737
 738         * python/py-function.c (fnpy_init): Update.
 739         * value.h (add_internal_function): Adjust declaration.
 740         * value.c (function_destroyer): Remove.
 741         (do_add_internal_function): Don't set destroyer or copy name.
 742         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 743         Set name_allocated.
 744         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 745         (cmdpy_init): Set name_allocated.
 746         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 747         member.
 748         (~cmd_list_element): Free "name" if needed.
 749
 750 2019-11-26  Tom Tromey  <tom@tromey.com>
 751
 752         * value.h (add_internal_function): Add new overload.  Move
 753         documentation from value.h.
 754         * value.c (do_add_internal_function): New function.
 755         (add_internal_function): Use it.  Add new overload.
 756         (function_destroyer): Don't free doc.
 757         * python/py-function.c (fnpy_init): Update.
 758
 759 2019-11-26  Tom Tromey  <tom@tromey.com>
 760
 761         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 762         (cmdpy_init): Set "doc_allocated".
 763
 764 2019-11-26  Tom Tromey  <tom@tromey.com>
 765
 766         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 767         name of worker thread.
 768         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 769         pthread_setname_np.
 770         * configure, config.in: Rebuild.
 771
 772 2019-11-26  Tom Tromey  <tom@tromey.com>
 773
 774         * python/python.c (class gdbpy_gil): New.
 775         (struct gdbpy_event): Add constructor, destructor, operator().
 776         (gdbpy_post_event): Use run_on_main_thread.
 777         (gdbpy_initialize_events): Remove.
 778         (do_start_initialization): Update.
 779
 780 2019-11-26  Tom Tromey  <tom@tromey.com>
 781
 782         * NEWS: Add entry.
 783         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 784         commands.  Call update_thread_pool_size.
 785         (update_thread_pool_size, maintenance_set_worker_threads): New
 786         functions.
 787         (n_worker_threads): New global.
 788
 789 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 790             Tom Tromey  <tom@tromey.com>
 791
 792         * minsyms.c (minimal_symbol_reader::install): Use
 793         parallel_for_each.
 794         * gdbsupport/parallel-for.h: New file.
 795         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 796
 797 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 798             Tom Tromey  <tom@tromey.com>
 799
 800         * gdbsupport/thread-pool.h: New file.
 801         * gdbsupport/thread-pool.c: New file.
 802         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 803         (HFILES_NO_SRCDIR): Add thread-pool.h.
 804
 805 2019-11-26  Tom Tromey  <tom@tromey.com>
 806
 807         * event-top.h (thread_local_segv_handler): Declare.
 808         * event-top.c (thread_local_segv_handler): New global.
 809         (install_handle_sigsegv, handle_sigsegv): New functions.
 810         (async_init_signals): Install SIGSEGV handler.
 811         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 812         thread-local.
 813         (report_failed_demangle): New function.
 814         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 815         handler-setting code, instead use segv_handler.  Run warning code
 816         on main thread.
 817
 818 2019-11-26  Tom Tromey  <tom@tromey.com>
 819
 820         * run-on-main-thread.c: New file.
 821         * run-on-main-thread.h: New file.
 822         * unittests/main-thread-selftests.c: New file.
 823         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 824         main-thread-selftests.c.
 825         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 826         (COMMON_SFILES): Add run-on-main-thread.c.
 827
 828 2019-11-26  Tom Tromey  <tom@tromey.com>
 829
 830         * main.c (setup_alternate_signal_stack): Remove.
 831         (captured_main_1): Use gdb::alternate_signal_stack.
 832         * gdbsupport/alt-stack.h: New file.
 833
 834 2019-11-26  Tom Tromey  <tom@tromey.com>
 835
 836         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 837         Remove comment.
 838         (save_original_signals_state, restore_original_signals_state): Use
 839         gdb_sigmask.
 840         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 841         (_initialize_linux_nat): Use gdb_sigmask.
 842         * guile/guile.c (_initialize_guile): Use block_signals.
 843         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 844         * gdbsupport/gdb-sigmask.h: New file.
 845         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 846         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 847         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 848         pthread_sigmask.
 849         * configure, config.in: Rebuild.
 850         * gdbsupport/block-signals.h: New file.
 851
 852 2019-11-26  Tom Tromey  <tom@tromey.com>
 853
 854         * acinclude.m4: Include ax_pthread.m4.
 855         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 856         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 857         (CLIBS): Use PTHREAD_LIBS.
 858         (aclocal_m4_deps): Add ax_pthread.m4.
 859         * config.in, configure: Rebuild.
 860         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 861
 862 2019-11-26  Tom Tromey  <tom@tromey.com>
 863
 864         * symtab.h (struct minimal_symbol) <name_set>: New member.
 865         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 866         Don't call symbol_set_names.
 867         (minimal_symbol_reader::install): Call symbol_set_names.
 868
 869 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 870
 871         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 872         restore_active_ext_lang, as GIL is needed for (indirectly)
 873         called PyOS_InterruptOccurred.
 874
 875 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 876
 877         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 878         definition.
 879
 880 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 881
 882         * remote-sim.c (simulator_command): Make static, remove
 883         declaration.
 884
 885 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 886
 887         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 888         static.
 889         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 890         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 891         (main): Likewise.
 892         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 893         (main): Likewise.
 894         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 895         (main): Likewise.
 896         * unittests/basic_string_view/element_access/char/1.cc (test01):
 897         Likewise.
 898         (main): Likewise.
 899         * unittests/basic_string_view/element_access/char/empty.cc (main):
 900         Likewise.
 901         * unittests/basic_string_view/element_access/char/front_back.cc
 902         (test01): Likewise.
 903         (main): Likewise.
 904         * unittests/basic_string_view/inserters/char/2.cc (test05):
 905         Likewise.
 906         (main): Likewise.
 907         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 908         (test01): Likewise.
 909         (main): Likewise.
 910         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 911         (test01): Likewise.
 912         (main): Likewise.
 913         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 914         Likewise.
 915         * unittests/basic_string_view/operations/compare/char/1.cc
 916         (test01): Likewise.
 917         (main): Likewise.
 918         * unittests/basic_string_view/operations/compare/char/13650.cc
 919         (test01): Likewise.
 920         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 921         Likewise.
 922         (main): Likewise.
 923         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 924         Likewise.
 925         (main): Likewise.
 926         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 927         Likewise.
 928         (main): Likewise.
 929         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 930         Likewise.
 931         (main): Likewise.
 932         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 933         Likewise.
 934         (main): Likewise.
 935         * unittests/basic_string_view/operations/find/char/4.cc (main):
 936         Likewise.
 937         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 938         Likewise.
 939         (main): Likewise.
 940         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 941         Likewise.
 942         (main): Likewise.
 943         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 944         Likewise.
 945         (main): Likewise.
 946         * unittests/basic_string_view/operations/substr/char/1.cc
 947         (test01): Likewise.
 948         (main): Likewise.
 949         * unittests/basic_string_view/operators/char/2.cc (main):
 950         Likewise.
 951         * unittests/optional/assignment/1.cc (test): Likewise.
 952         * unittests/optional/assignment/2.cc (test): Likewise.
 953         * unittests/optional/assignment/3.cc (test): Likewise.
 954         * unittests/optional/assignment/4.cc (test): Likewise.
 955         * unittests/optional/assignment/5.cc (test): Likewise.
 956         * unittests/optional/assignment/6.cc (test): Likewise.
 957         * unittests/optional/assignment/7.cc (test): Likewise.
 958         * unittests/optional/cons/copy.cc (test): Likewise.
 959         * unittests/optional/cons/default.cc (test): Likewise.
 960         * unittests/optional/cons/move.cc (test): Likewise.
 961         * unittests/optional/cons/value.cc (test): Likewise.
 962         * unittests/optional/in_place.cc (test): Likewise.
 963         * unittests/optional/observers/1.cc (test): Likewise.
 964         * unittests/optional/observers/2.cc (test): Likewise.
 965
 966 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 967
 968         * tui-win.h (tui_set_var_cmd): Remove.
 969         * tui-win.c (tui_set_var_cmd): Make static.
 970
 971 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 972
 973         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 974         rbreak_command_wrapper): Remove.
 975         * symtab.c (rbreak_command_wrapper): Remove.
 976
 977 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 978
 979         * inferior.h (info_terminal_command): Remove declaration.
 980         * inflow.c (info_terminal_command): Make static.
 981
 982 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 983
 984         * inferior.c (exit_inferior_silent): Remove.
 985
 986 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 987
 988         * dictionary.c (dict_empty, mdict_empty): Remove.
 989         * dictionary.c (mdict_empty): Remove.
 990
 991 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 992
 993          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 994          (arc_insn_get_memory_offset): Likewise.
 995          (arc_insn_dump): Likewise.
 996          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 997          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 998          * dictionary.c (dict_iterator_next): Likewise.
 999          (dict_iter_match_first): Likewise.
1000          (dict_iter_match_next): Likewise.
1001          * f-lang.c (evaluate_subexp_f): Likewise.
1002          * hppa-tdep.c (hppa_read_pc): Likewise.
1003          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1004          * parse.c (write_exp_elt_msym): Likewise.
1005          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1006          * remote.c (remote_packet_size): Likewise.
1007          (remote_notif_stop_parse): Likewise.
1008          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1009          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1010          * source.c (prepare_path_for_appending): Likewise.
1011          * sparc64-linux-tdep.c
1012          (sparc64_linux_handle_segmentation_fault); Likewise.
1013          * stack.c (frame_selection_by_function_completer): Likewise.
1014
1015 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * completer.c (set_gdb_completion_word_break_characters):
1018         Remove.
1019
1020 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1021
1022         * dwarf-index-write.c: Include dwarf-index-write.h.
1023         * mi/mi-interp.c: Include mi/mi-interp.h.
1024
1025 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1026
1027         * aarch32-tdep.c: Include aarch32-tdep.h.
1028         * aarch32-tdep.h: Forward-declare struct target_desc.
1029
1030 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1031
1032         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1033         strerror.
1034         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1035         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1036
1037 2019-11-25  Tom de Vries  <tdevries@suse.de>
1038
1039         * contrib/words.sh: Add -c option.
1040
1041 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1042
1043         * solib.c (solib_find_1): Change int to bool.
1044         (exec_file_find): Change int to bool.
1045         (solib_find): Change int to bool.
1046         (solib_read_symbols): Change int to bool.
1047         (solib_used): Change int to bool.
1048         (solib_add): Change int to bool.
1049         (info_sharedlibrary_command): Change int to bool.
1050         (solib_contains_address_p): Change int to bool.
1051         (solib_keep_data_in_core): Change int to bool.
1052         (in_solib_dynsym_resolve_code): Change int to bool.
1053         (reload_shared_libraries_1): Change int to bool.
1054         (gdb_sysroot_changed): Change int to bool.
1055         * solib.h (solib_read_symbols): Change int to bool.
1056         (solib_contains_address_p): Change int to bool.
1057         (solib_keep_data_in_core): Change int to bool.
1058         (in_solib_dynsym_resolve_code): Change int to bool.
1059         (libpthread_name_p): Change int to bool.
1060
1061 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1062
1063         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1064         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1065         (remote_packet_max_chars): New static global.
1066         (show_remote_packet_max_chars): New function.
1067         (remote_target::putpkt_binary): Adjust to use new
1068         remote_packet_max_chars option.
1069         (remote_target::getpkt_or_notif_sane_1): Likewise.
1070         (_initialize_remote): Register new remote-packet-max-chars option.
1071
1072 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1073
1074         * m68k-linux-nat.c: Include gdbarch.h.
1075
1076 2019-11-24  Tom Tromey  <tom@tromey.com>
1077
1078         * symfile.c (read_symbols): Update.
1079         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1080         bool.
1081         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1082         (psym_lookup_symbol, psym_find_last_source_symtab)
1083         (psym_forget_cached_source_info, psym_print_stats)
1084         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1085         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1086         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1087         (psym_find_compunit_symtab_by_address)
1088         (maintenance_print_psymbols, maintenance_info_psymtabs)
1089         (maintenance_check_psymtabs): Update.
1090         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1091         bool.
1092
1093 2019-11-22  Tom Tromey  <tom@tromey.com>
1094
1095         * observable.h: Update comments.
1096
1097 2019-11-22  Tom Tromey  <tromey@adacore.com>
1098
1099         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1100         (print_ada_task_info): Don't try to fetch thread id if task is not
1101         alive.
1102
1103 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1104
1105         * ada-exp.y: Update.
1106         * ada-lang.c (sort_choices): Update.
1107         (ada_print_symbol_signature): Update.
1108         (resolve_subexp): Update.
1109         (ada_parse_renaming): Update.
1110         (ada_read_renaming_var_value): Update.
1111         (lesseq_defined_than): Update.
1112         (remove_extra_symbols): Update.
1113         (remove_irrelevant_renamings): Update.
1114         (ada_add_block_symbols): Update.
1115         (ada_collect_symbol_completion_matches): Update.
1116         (ada_is_renaming_symbol): Update.
1117         (aggregate_assign_from_choices): Update.
1118         (ada_evaluate_subexp): Update.
1119         (ada_has_this_exception_support): Update.
1120         (ada_is_non_standard_exception_sym): Update.
1121         (ada_add_exceptions_from_frame): Update.
1122         (ada_add_global_exceptions): Update.
1123         (ada_print_subexp): Update.
1124         * ax-gdb.c (gen_var_ref): Update.
1125         (gen_maybe_namespace_elt): Update.
1126         (gen_expr_for_cast): Update.
1127         (gen_expr): Update.
1128         * block.h: Update.
1129         * blockframe.c (find_pc_partial_function): Update.
1130         * breakpoint.c (print_breakpoint_location): Update.
1131         (update_static_tracepoint): Update.
1132         * btrace.c (ftrace_print_function_name): Update.
1133         (ftrace_function_switched): Update.
1134         * buildsym.c (find_symbol_in_list): Update.
1135         * c-exp.y: Update.
1136         * c-typeprint.c (c_print_typedef): Update.
1137         (c_type_print_template_args): Update.
1138         * cli/cli-cmds.c (edit_command): Update.
1139         (list_command): Update.
1140         (print_sal_location): Update.
1141         * coffread.c (patch_opaque_types): Update.
1142         (process_coff_symbol): Update.
1143         (coff_read_enum_type): Update.
1144         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1145         (convert_one_symbol): Update.
1146         (hash_symname): Update.
1147         (eq_symname): Update.
1148         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1149         * compile/compile-cplus-types.c (debug_print_scope): Update.
1150         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1151         * compile/compile-object-load.c (get_out_value_type): Update.
1152         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1153         (search_symbol_list): Update.
1154         (cp_lookup_symbol_imports_or_template): Update.
1155         * cp-support.c (overload_list_add_symbol): Update.
1156         * ctfread.c (psymtab_to_symtab): Update.
1157         * dbxread.c (cp_set_block_scope): Update.
1158         * dictionary.c (iter_match_first_hashed): Update.
1159         (iter_match_next_hashed): Update.
1160         (insert_symbol_hashed): Update.
1161         (iter_match_next_linear): Update.
1162         * dictionary.h: Update.
1163         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1164         (locexpr_describe_location_piece): Update.
1165         (locexpr_describe_location_1): Update.
1166         (locexpr_generate_c_location): Update.
1167         (loclist_describe_location): Update.
1168         (loclist_generate_c_location): Update.
1169         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1170         (read_func_scope): Update.
1171         (process_enumeration_scope): Update.
1172         (new_symbol): Update.
1173         (dwarf2_const_value): Update.
1174         (dwarf2_symbol_mark_computed): Update.
1175         * eval.c (evaluate_funcall): Update.
1176         (evaluate_subexp_standard): Update.
1177         * expprint.c (print_subexp_standard): Update.
1178         (dump_subexp_body_standard): Update.
1179         * f-valprint.c (info_common_command_for_block): Update.
1180         * findvar.c (get_hosting_frame): Update.
1181         (default_read_var_value): Update.
1182         * go-lang.c (go_symbol_package_name): Update.
1183         * guile/scm-block.c (bkscm_print_block_smob): Update.
1184         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1185         (gdbscm_symbol_name): Update.
1186         (gdbscm_symbol_linkage_name): Update.
1187         (gdbscm_symbol_print_name): Update.
1188         * infcall.c (get_function_name): Update.
1189         * infcmd.c (jump_command): Update.
1190         (finish_command): Update.
1191         * infrun.c (insert_exception_resume_breakpoint): Update.
1192         * linespec.c (canonicalize_linespec): Update.
1193         (create_sals_line_offset): Update.
1194         (convert_linespec_to_sals): Update.
1195         (complete_label): Update.
1196         (find_label_symbols_in_block): Update.
1197         * m2-typeprint.c (m2_print_typedef): Update.
1198         * mdebugread.c (mdebug_reg_to_regnum): Update.
1199         (parse_symbol): Update.
1200         (mylookup_symbol): Update.
1201         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1202         (list_args_or_locals): Update.
1203         * objc-lang.c (compare_selectors): Update.
1204         (info_selectors_command): Update.
1205         (compare_classes): Update.
1206         (info_classes_command): Update.
1207         (find_imps): Update.
1208         * p-typeprint.c (pascal_print_typedef): Update.
1209         * printcmd.c (build_address_symbolic): Update.
1210         (info_address_command): Update.
1211         (print_variable_and_value): Update.
1212         * python/py-framefilter.c (extract_sym): Update.
1213         (py_print_single_arg): Update.
1214         * python/py-symbol.c (sympy_str): Update.
1215         (sympy_get_name): Update.
1216         (sympy_get_linkage_name): Update.
1217         * python/python.c (gdbpy_rbreak): Update.
1218         * record-btrace.c (btrace_get_bfun_name): Update.
1219         (btrace_call_history): Update.
1220         * rust-lang.c (rust_print_typedef): Update.
1221         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1222         * stabsread.c (stab_reg_to_regnum): Update.
1223         (define_symbol): Update.
1224         (read_enum_type): Update.
1225         (common_block_end): Update.
1226         (cleanup_undefined_types_1): Update.
1227         (scan_file_globals): Update.
1228         * stack.c (print_frame_arg): Update.
1229         (print_frame_args): Update.
1230         (find_frame_funname): Update.
1231         (info_frame_command_core): Update.
1232         (iterate_over_block_locals): Update.
1233         (print_block_frame_labels): Update.
1234         (do_print_variable_and_value): Update.
1235         (iterate_over_block_arg_vars): Update.
1236         (return_command): Update.
1237         * symmisc.c (dump_symtab_1): Update.
1238         (print_symbol): Update.
1239         * symtab.c (eq_symbol_entry): Update.
1240         (symbol_cache_dump): Update.
1241         (lookup_language_this): Update.
1242         (find_pc_sect_line): Update.
1243         (skip_prologue_sal): Update.
1244         (symbol_search::compare_search_syms): Update.
1245         (treg_matches_sym_type_name): Update.
1246         (search_symbols): Update.
1247         (print_symbol_info): Update.
1248         (rbreak_command): Update.
1249         (completion_list_add_symbol): Update.
1250         (find_gnu_ifunc): Update.
1251         (get_symbol_address): Update.
1252         (search_module_symbols): Update.
1253         (info_module_subcommand): Update.
1254         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1255         (SYMBOL_LINKAGE_NAME): Remove.
1256         (SYMBOL_DEMANGLED_NAME): Remove.
1257         (SYMBOL_PRINT_NAME): Remove.
1258         (SYMBOL_SEARCH_NAME): Remove.
1259         * tracepoint.c (set_traceframe_context): Update.
1260         (validate_actionline): Update.
1261         (collection_list::collect_symbol): Update.
1262         (encode_actions_1): Update.
1263         (info_scope_command): Update.
1264         (print_one_static_tracepoint_marker): Update.
1265         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1266         * valops.c (address_of_variable): Update.
1267         (find_overload_match): Update.
1268         (find_oload_champ): Update.
1269
1270 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * ada-lang.c (ada_lookup_simple_minsym): Update.
1273         (ada_collect_symbol_completion_matches): Update.
1274         * ada-tasks.c (read_atcb): Update.
1275         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1276         (amd64_windows_skip_trampoline_code): Update.
1277         * arm-tdep.c (skip_prologue_function): Update.
1278         (arm_skip_stack_protector): Update.
1279         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1280         (arm_wince_skip_main_prologue): Update.
1281         * ax-gdb.c (gen_expr): Update.
1282         * block.c (call_site_for_pc): Update.
1283         * blockframe.c (find_pc_partial_function): Update.
1284         * breakpoint.c (set_breakpoint_location_function): Update.
1285         * btrace.c (ftrace_print_function_name): Update.
1286         (ftrace_function_switched): Update.
1287         * c-valprint.c (print_unpacked_pointer): Update.
1288         * coffread.c (coff_symfile_read): Update.
1289         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1290         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1291         * dwarf-index-write.c (write_psymbols): Update.
1292         * dwarf2loc.c (call_site_to_target_addr): Update.
1293         (func_verify_no_selftailcall): Update.
1294         (tailcall_dump): Update.
1295         (call_site_find_chain_1): Update.
1296         (dwarf_expr_reg_to_entry_parameter): Update.
1297         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1298         * eval.c (evaluate_funcall): Update.
1299         (evaluate_subexp_standard): Update.
1300         (evaluate_subexp_for_sizeof): Update.
1301         * expprint.c (print_subexp_standard): Update.
1302         (dump_subexp_body_standard): Update.
1303         * frame.c (get_prev_frame_always_1): Update.
1304         * frv-tdep.c (frv_skip_main_prologue): Update.
1305         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1306         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1307         (gnuv3_get_typename_from_type_info): Update.
1308         (gnuv3_skip_trampoline): Update.
1309         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1310         * i386-tdep.c (i386_skip_main_prologue): Update.
1311         (i386_pe_skip_trampoline_code): Update.
1312         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1313         * infcall.c (get_function_name): Update.
1314         * linespec.c (minsym_found): Update.
1315         * linux-fork.c (info_checkpoints_command): Update.
1316         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1317         (m32c_m16c_pointer_to_address): Update.
1318         * maint.c (maintenance_translate_address): Update.
1319         * minsyms.c (add_minsym_to_hash_table): Update.
1320         (add_minsym_to_demangled_hash_table): Update.
1321         (lookup_minimal_symbol_mangled): Update.
1322         (lookup_minimal_symbol_demangled): Update.
1323         (lookup_minimal_symbol_linkage): Update.
1324         (lookup_minimal_symbol_text): Update.
1325         (lookup_minimal_symbol_by_pc_name): Update.
1326         (minimal_symbol_is_less_than): Update.
1327         (compact_minimal_symbols): Update.
1328         (build_minimal_symbol_hash_tables): Update.
1329         (find_solib_trampoline_target): Update.
1330         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1331         (mips_skip_pic_trampoline_code): Update.
1332         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1333         * objc-lang.c (info_selectors_command): Update.
1334         (info_classes_command): Update.
1335         (find_methods): Update.
1336         (find_imps): Update.
1337         * p-valprint.c (pascal_val_print): Update.
1338         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1339         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1340         * printcmd.c (build_address_symbolic): Update.
1341         (info_symbol_command): Update.
1342         * psymtab.c (psymbol_name_matches): Update.
1343         (match_partial_symbol): Update.
1344         (lookup_partial_symbol): Update.
1345         (print_partial_symbols): Update.
1346         (sort_pst_symbols): Update.
1347         (maintenance_check_psymtabs): Update.
1348         * python/py-framefilter.c (py_print_frame): Update.
1349         * python/python.c (gdbpy_rbreak): Update.
1350         * record-btrace.c (btrace_get_bfun_name): Update.
1351         (btrace_call_history): Update.
1352         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1353         (rs6000_skip_trampoline_code): Update.
1354         * sol-thread.c (info_cb): Update.
1355         * stabsread.c (scan_file_globals): Update.
1356         * stack.c (find_frame_funname): Update.
1357         (info_frame_command_core): Update.
1358         * symmisc.c (dump_msymbols): Update.
1359         * symtab.c (symbol_natural_name): Rename to..,
1360         (general_symbol_info::natural_name): ...this.
1361         (symbol_demangled_name): Rename to...
1362         (general_symbol_info::demangled_name): ...this.
1363         (symbol_search_name): Rename to...
1364         (general_symbol_info::search_name): ...this.
1365         (symbol_matches_search_name): Update.
1366         (find_pc_sect_line): Update.
1367         (skip_prologue_sal): Update.
1368         (search_symbols): Update.
1369         (print_msymbol_info): Update.
1370         (rbreak_command): Update.
1371         (completion_list_add_msymbol): Update.
1372         (completion_list_objc_symbol): Update.
1373         (get_msymbol_address): Update.
1374         * symtab.h (struct general_symbol_info): Add member functions
1375         natural_name (), linkage_name (), print_name (), demangled_name (),
1376         and search_name ().
1377         (SYMBOL_NATURAL_NAME): Update.
1378         (symbol_natural_name): Move to a member function on general_symbol_info.
1379         (SYMBOL_DEMANGLED_NAME): Update.
1380         (symbol_demangled_name): Move to a member function on
1381         general_symbol_info.
1382         (SYMBOL_SEARCH_NAME): Update.
1383         (symbol_search_name): Move to a member function on general_symbol_info.
1384         (MSYMBOL_NATURAL_NAME): Remove.
1385         (MSYMBOL_LINKAGE_NAME): Remove.
1386         (MSYMBOL_PRINT_NAME): Remove.
1387         (MSYMBOL_DEMANGLED_NAME): Remove.
1388         (MSYMBOL_SEARCH_NAME): Remove.
1389         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1390
1391 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1392
1393         * symtab.c (create_demangled_names_hash): Use per_bfd->
1394         minimal_symbol_count for computing the initial size, if greater
1395         than our default size.
1396
1397 2019-11-22  Tom de Vries  <tdevries@suse.de>
1398
1399         * contrib/words.sh: Improve words extraction.
1400
1401 2019-11-22  Tom de Vries  <tdevries@suse.de>
1402
1403         * contrib/words.sh: Combine sed invocations.
1404
1405 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1406
1407         * Makefile.in: Update.
1408         * demangle.c: Rename to...
1409         * gdb-demangle.c: ..this.
1410         (is_cplus_marker): Change return type to bool.
1411         (_initialize_demangler): Rename to...
1412         (_initialize_gdb_demangle): ...this.
1413         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1414         * symtab.h (demangle): Remove declaration; instead include
1415         gdb-demangle.h.
1416
1417 2019-11-21  Tom Tromey  <tromey@adacore.com>
1418
1419         * gdbsupport/format.c (format_pieces): Parse %I64d.
1420         * unittests/format_pieces-selftests.c (test_windows_formats): New
1421         function.
1422         (run_tests): Call it.
1423
1424 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1425
1426         Byte reverse display of variables with DW_END_big, DW_END_little
1427         (DW_AT_endianity) dwarf attributes if different than the native
1428         byte order.
1429         * ada-lang.c (ada_value_binop):
1430         Use type_byte_order instead of gdbarch_byte_order.
1431         * ada-valprint.c (printstr):
1432         (ada_val_print_string):
1433         * ada-lang.c (value_pointer):
1434         (ada_value_binop):
1435         Use type_byte_order instead of gdbarch_byte_order.
1436         * c-lang.c (c_get_string):
1437         Use type_byte_order instead of gdbarch_byte_order.
1438         * c-valprint.c (c_val_print_array):
1439         Use type_byte_order instead of gdbarch_byte_order.
1440         * cp-valprint.c (cp_print_class_member):
1441         Use type_byte_order instead of gdbarch_byte_order.
1442         * dwarf2loc.c (rw_pieced_value):
1443         Use type_byte_order instead of gdbarch_byte_order.
1444         * dwarf2read.c (read_base_type): Handle DW_END_big,
1445         DW_END_little
1446         * f-lang.c (f_get_encoding):
1447         Use type_byte_order instead of gdbarch_byte_order.
1448         * findvar.c (default_read_var_value):
1449         Use type_byte_order instead of gdbarch_byte_order.
1450         * gdbtypes.c (check_types_equal):
1451         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1452         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1453         and TYPE_ENDIANITY_LITTLE if set.
1454         (type_byte_order): new function.
1455         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1456         (struct main_type) <flag_endianity_not_default>:
1457         New field.
1458         (type_byte_order): New function.
1459         * infcmd.c (default_print_one_register_info):
1460         Use type_byte_order instead of gdbarch_byte_order.
1461         * p-lang.c (pascal_printstr):
1462         Use type_byte_order instead of gdbarch_byte_order.
1463         * p-valprint.c (pascal_val_print):
1464         Use type_byte_order instead of gdbarch_byte_order.
1465         * printcmd.c (print_scalar_formatted):
1466         Use type_byte_order instead of gdbarch_byte_order.
1467         * solib-darwin.c (darwin_current_sos):
1468         Use type_byte_order instead of gdbarch_byte_order.
1469         * solib-svr4.c (solib_svr4_r_ldsomap):
1470         Use type_byte_order instead of gdbarch_byte_order.
1471         * stap-probe.c (stap_modify_semaphore):
1472         Use type_byte_order instead of gdbarch_byte_order.
1473         * target-float.c (target_float_same_format_p):
1474         Use type_byte_order instead of gdbarch_byte_order.
1475         * valarith.c (scalar_binop):
1476         (value_bit_index):
1477         Use type_byte_order instead of gdbarch_byte_order.
1478         * valops.c (value_cast):
1479         Use type_byte_order instead of gdbarch_byte_order.
1480         * valprint.c (generic_emit_char):
1481         (generic_printstr):
1482         (val_print_string):
1483         Use type_byte_order instead of gdbarch_byte_order.
1484         * value.c (unpack_long):
1485         (unpack_bits_as_long):
1486         (unpack_value_bitfield):
1487         (modify_field):
1488         (pack_long):
1489         (pack_unsigned_long):
1490         Use type_byte_order instead of gdbarch_byte_order.
1491         * findvar.c (unsigned_pointer_to_address):
1492         (signed_pointer_to_address):
1493         (unsigned_address_to_pointer):
1494         (address_to_signed_pointer):
1495         (default_read_var_value):
1496         (default_value_from_register):
1497         Use type_byte_order instead of gdbarch_byte_order.
1498         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1499         Use type_byte_order instead of gdbarch_byte_order.
1500         * riscv-tdep.c (riscv_print_one_register_info):
1501         Use type_byte_order instead of gdbarch_byte_order.
1502
1503 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1504
1505         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1506         (current_ui_gdb_stdin_ptr): Likewise.
1507         (current_ui_gdb_stderr_ptr): Likewise.
1508         (current_ui_gdb_stdlog_ptr): Likewise.
1509         (current_ui_current_uiout_ptr): Likewise.
1510         (gen_ret_current_ui_field_ptr): Remove.
1511
1512 2019-11-21  Tom de Vries  <tdevries@suse.de>
1513
1514         PR gdb/24956
1515         * cli/cli-script.c (execute_control_command): Only switch to
1516         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1517
1518 2019-11-19  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1521         Now static.  Change type of "name".
1522         (tui_set_win_height_command): Don't copy "arg".
1523         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1524         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1525
1526 2019-11-19  Ali Tamur <tamur@google.com>
1527
1528         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1529         "if (attr != nullptr)".
1530         (dwarf2_find_base_address): Likewise.
1531         (dwarf2_build_include_psymtabs): Likewise.
1532         (read_cutu_die_from_dwo): Likewise.
1533         (read_func_scope): Likewise.
1534         (read_call_site_scope): Likewise.
1535         (dwarf2_get_pc_bounds): Likewise.
1536         (dwarf2_record_block_ranges): Likewise.
1537         (dwarf2_add_field): Likewise.
1538         (dwarf2_add_member_fn): Likewise.
1539         (read_structure_type): Likewise.
1540         (read_enumeration_type): Likewise.
1541         (read_array_type): Likewise.
1542         (read_array_order): Likewise.
1543         (read_set_type): Likewise.
1544         (read_common_block): Likewise.
1545         (read_tag_reference_type): Likewise.
1546         (read_tag_string_type): Likewise.
1547         (read_subroutine_type): Likewise.
1548         (read_base_type): Likewise.
1549         (read_subrange_type): Likewise.
1550         (new_symbol): Likewise.
1551         (prepare_one_comp_unit): Likewise.
1552
1553 2019-11-19  Tom Tromey  <tromey@adacore.com>
1554
1555         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1556         result in error when DebugActiveProcess fails.
1557
1558 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1559             Pedro Alves  <palves@redhat.com>
1560
1561         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1562         * target.c (target_stack::push): Call 'unpush' if there's a
1563         target on top of the stack.
1564
1565 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1566
1567         * python/py-block.c (blpy_dealloc): Call tp_free.
1568         (blpy_block_syms_dealloc): Likewise.
1569         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1570         * python/py-inferior.c (infpy_dealloc): Likewise.
1571         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1572         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1573         * python/py-symbol.c (sympy_dealloc): Likewise.
1574         * python/py-symtab.c (stpy_dealloc): Likewise.
1575         * python/py-type.c (typy_iterator_dealloc): Likewise.
1576
1577 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1578
1579         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1580         constructor instead of using a class initializer.
1581
1582 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1583
1584         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1585         * configure: Regenerate.
1586         * configure.ac: Don't source common.host.
1587         * gdbsupport/common.host: Remove.
1588         * gdbsupport/mingw-strerror.c: Remove.
1589         * gdbsupport/posix-strerror.c: Rename to...
1590         * gdbsupport/safe-strerror.c: ...this.
1591
1592 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1593
1594         * maint.c (scoped_command_stats::print_time): Use localtime_r
1595         instead of localtime (provided through gnulib if necessary).
1596         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1597         of ctime.
1598
1599 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1600
1601         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1602         avoid compile errors.
1603
1604 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1605
1606         * config.in: Regenerate.
1607         * configure: Regenerate.
1608         * gdbsupport/common.m4: No longer check for strerror_r.
1609         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1610         POSIX version of strerror_r, now that gnulib provides it if
1611         necessary.
1612
1613 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1614
1615         * README (`configure' options): Update.
1616
1617 2019-11-14  Tom Tromey  <tromey@adacore.com>
1618
1619         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1620         expected type for the RHS if the LHS is a convenience variable.
1621
1622 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1623
1624         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1625         Provide explicit default and copy constructor.
1626
1627 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1628
1629         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1630         only call Py_INCREF (newbp) in the bppy_pending_object case.
1631
1632 2019-11-13  Tom Tromey  <tromey@adacore.com>
1633
1634         PR build/25182:
1635         * psympriv.h (partial_symbol): Remove static assert.
1636         * symtab.h (general_symbol_info, symbol): Remove static assert.
1637
1638 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * gdbsupport/format.c (format_pieces::format_pieces): Support
1641         printf 'z' size modifier.
1642         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1643         * printcmd.c (ui_printf):  Handle size_t_arg.
1644         * ui-out.c (ui_out::vmessage): Likewise.
1645         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1646         function.
1647         (run_tests): Call test_format_int_sizes.
1648
1649 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1650
1651         * ada-exp.y (write_ambiguous_var): Update.
1652         * buildsym.c (add_symbol_to_list): Update.
1653         * dwarf2read.c (read_variable): Update.
1654         (new_symbol): Update.
1655         * jit.c (finalize_symtab): Update.
1656         * language.c (language_alloc_type_symbol): Update.
1657         * symtab.c (fixup_symbol_section): Update.
1658         (initialize_objfile_symbol_1): Move code to...
1659         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1660         (allocate_symbol): Update.
1661         (allocate_template_symbol): Update.
1662         (get_symbol_address): Update.
1663         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1664         of having as a field, and add a constructor.
1665         (SYMBOL_VALUE): Update.
1666         (SYMBOL_VALUE_ADDRESS): Update.
1667         (SET_SYMBOL_VALUE_ADDRESS): Update.
1668         (SYMBOL_VALUE_BYTES): Update.
1669         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1670         (SYMBOL_BLOCK_VALUE): Update.
1671         (SYMBOL_VALUE_CHAIN): Update.
1672         (SYMBOL_LANGUAGE): Update.
1673         (SYMBOL_SECTION): Update.
1674         (SYMBOL_OBJ_SECTION): Update.
1675         (SYMBOL_SET_LANGUAGE): Update.
1676         (SYMBOL_SET_LINKAGE_NAME): Update.
1677         (SYMBOL_SET_NAMES): Update.
1678         (SYMBOL_NATURAL_NAME): Update.
1679         (SYMBOL_LINKAGE_NAME): Update.
1680         (SYMBOL_DEMANGLED_NAME): Update.
1681         (SYMBOL_SEARCH_NAME): Update.
1682         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1683         (struct symbol): Update.
1684         (struct template_symbol): Update.
1685         (struct rust_vtable_symbol): Update.
1686         * xcoffread.c (SYMBOL_DUP): Update.
1687
1688 2019-11-12  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-layout.c (show_layout): Set current_layout.
1691         (show_source_disasm_command, show_data)
1692         (show_source_or_disasm_and_command): Don't set current_layout.
1693
1694 2019-11-12  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1697
1698 2019-11-12  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-win.c (resize_message): New global.
1701         (show_tui_resize_message): New function.
1702         (tui_async_resize_screen): Print message if requested.
1703         (_initialize_tui_win): Add tui-resize-message setting.
1704         * NEWS: Add entry for new commands.
1705
1706 2019-11-11  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1709         functions.
1710
1711 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1712
1713         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1714
1715 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1718         function.
1719         * python/python-internal.h (gdbpy_lookup_static_symbols):
1720         Declare new function.
1721         * python/python.c (python_GdbMethods): Add
1722         gdb.lookup_static_symbols method.
1723         * NEWS: Mention gdb.lookup_static_symbols.
1724
1725 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1726
1727         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1728         static block of current object file first.  Also fix typo in
1729         header comment.
1730
1731 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * stack.c (set_last_displayed_sal): Delete.
1734         (last_displayed_sal_valid): Delete.
1735         (last_displayed_pspace): Delete.
1736         (last_displayed_addr): Delete.
1737         (last_displayed_symtab): Delete.
1738         (last_displayed_line): Delete.
1739         (class last_displayed_symtab_info_type): New.
1740         (last_displayed_symtab_info): New static global variable.
1741         (print_frame_info): Call methods on last_displayed_symtab_info.
1742         (clear_last_displayed_sal): Update header comment, and make use of
1743         last_displayed_symtab_info.
1744         (last_displayed_sal_is_valid): Likewise.
1745         (get_last_displayed_pspace): Likewise.
1746         (get_last_displayed_addr): Likewise.
1747         (get_last_displayed_symtab): Likewise.
1748         (get_last_displayed_line): Likewise.
1749         (get_last_displayed_sal): Likewise.
1750         * stack.h (clear_last_displayed_sal): Update header comment.
1751         (last_displayed_sal_is_valid): Likewise.
1752         (get_last_displayed_pspace): Likewise.
1753         (get_last_displayed_addr): Likewise.
1754         (get_last_displayed_symtab): Likewise.
1755         (get_last_displayed_line): Likewise.
1756         (get_last_displayed_sal): Likewise.
1757
1758 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * stack.c (frame_show_address): Convert return type to bool.
1761         * stack.h (frame_show_address): Likewise, and update header
1762         comment.
1763
1764 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1765
1766         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1767         * unittests/vec-utils-selftests.c: New file.
1768         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1769
1770 2019-11-10  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1773         (tui_highlight_win): Likewise.
1774         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1775         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1776         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1777         Don't set can_highlight.
1778
1779 2019-11-10  Tom Tromey  <tom@tromey.com>
1780
1781         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1782         Remove unused declaration.
1783
1784 2019-11-08  Tom Tromey  <tromey@adacore.com>
1785
1786         * top.c (read_command_file): Update.
1787         (command_line_input): Make return type const.
1788         * python/py-gdb-readline.c: Update.
1789         * linespec.c (decode_line_2): Update.
1790         * defs.h (command_line_input): Make return type const.
1791         * cli/cli-script.c (read_next_line): Make return type const.
1792         * ada-lang.c (get_selections): Update.
1793
1794 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1795
1796         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1797         * mi/mi-main.c (output_cores): Likewise.
1798         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1799         (linux_xfer_osdata_modules): Likewise.
1800         * remote.c (register_remote_support_xml): Likewise.
1801         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1802         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1803
1804 2019-11-06  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-interp.c: Don't include readline.h.
1807         * tui/tui-hooks.c: Don't include readline.h.
1808         * symmisc.c: Include tilde.h, not readline.h.
1809         * symfile.c: Include tilde.h, not readline.h.
1810         * source.c: Include tilde.h, not readline.h.
1811         * solib.c: Include tilde.h, not readline.h.
1812         * psymtab.c: Include tilde.h, not readline.h.
1813         * exec.c: Include tilde.h, not readline.h.
1814         * corelow.c: Include tilde.h, not readline.h.
1815         * cli/cli-dump.c: Include tilde.h, not readline.h.
1816         * cli/cli-cmds.c: Don't include readline.h.
1817
1818 2019-11-05  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1821         (tui_disassemble): Set addr_size.
1822         (tui_disasm_window::set_contents): Use addr_size.
1823
1824 2019-11-05  Tom Tromey  <tom@tromey.com>
1825
1826         * rust-lang.c (rust_language_defn): Update.
1827         * python/py-value.c (valpy_string): Call c_get_string.
1828         * p-lang.c (pascal_language_defn): Update.
1829         * opencl-lang.c (opencl_language_defn): Update.
1830         * objc-lang.c (objc_language_defn): Update.
1831         * m2-lang.c (m2_language_defn): Update.
1832         * language.c (unknown_language_defn, auto_language_defn): Update.
1833         (default_get_string): Remove.
1834         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1835         * go-lang.c (go_language_defn): Update.
1836         * f-lang.c (f_language_defn): Update.
1837         * d-lang.c (d_language_defn): Update.
1838         * c-lang.c (c_language_defn, cplus_language_defn)
1839         (asm_language_defn, minimal_language_defn): Update.
1840         * ada-lang.c (ada_language_defn): Update.
1841         * language.h (struct language_defn) <la_get_string>: Remove.
1842         (LA_GET_STRING): Remove.
1843         (default_get_string): Don't declare.
1844
1845 2019-11-05  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-source.h (struct tui_source_window): Inline
1848         constructor.  Remove destructor.
1849         <style_changed, m_observable>: Move to superclass.
1850         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1851         (struct tui_source_window_base): Move private members to end.
1852         <style_changed, m_observable>: Move from tui_source_window.
1853         * tui/tui-winsource.c (tui_copy_source_line): Move from
1854         tui-source.c.  Rename from copy_source_line.  Add special handling
1855         for negative line number.
1856         (tui_source_window_base::style_changed): Move from
1857         tui_source_window.
1858         (tui_source_window_base): Register observer.
1859         (~tui_source_window_base): New.
1860         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1861         rename.
1862         (tui_source_window::set_contents): Use tui_copy_source_line.
1863         (tui_source_window::tui_source_window): Move to tui-source.h.
1864         (tui_source_window::~tui_source_window): Remove.
1865         (tui_source_window::style_changed): Move to superclass.
1866         * tui/tui-disasm.c (tui_disassemble): Create string file with
1867         styling, when possible.  Add "addr_size" parameter.
1868         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1869         Don't compute maximum size.
1870         (len_without_escapes): New function
1871
1872 2019-11-05  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1875         std::string.
1876         * tui/tui-winsource.c (tui_show_source_line): Update.
1877         * tui/tui-source.c (tui_source_window::set_contents): Update.
1878         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1879
1880 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1881
1882         * symtab.h (gdb_static_assert): Put && operator at the beginning
1883         of the line instead of the end.
1884
1885 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1886
1887         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1888         and sizeof (symbol).
1889         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1890
1891 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1892
1893         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1894         * configure.host: Mark *-*-solaris2.10* obsolete.
1895         * configure.tgt: Mark Solaris < 11 obsolete.
1896         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1897         Update target triplet.
1898
1899 2019-11-01  Tom Tromey  <tromey@adacore.com>
1900
1901         * utils.c (print_sys_errmsg): Simplify.
1902
1903 2019-11-01  Tom Tromey  <tromey@adacore.com>
1904
1905         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1906
1907 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1908
1909         * configure: Regenerate.
1910         * configure.ac: Remove check for strerror_r.
1911         * gdbsupport/common.m4: Check for strerror_r.
1912
1913 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1914
1915         PR gdb/25124
1916
1917         * arm-tdep.c (arm_per_objfile): Rename to ...
1918         (arm_per_bfd): ... this.
1919         (arm_objfile_data_key): Rename to ...
1920         (arm_bfd_data_key): ... this.
1921         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1922         data.
1923         (arm_record_special_symbol): Likewise.
1924
1925 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1926
1927         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1928         end.
1929         * c-typeprint.c (c_print_typedef): Likewise.
1930         * f-typeprint.c (f_print_typedef): Likewise.
1931         * m2-typeprint.c (m2_print_typedef): Likewise.
1932         * p-typeprint.c (pascal_print_typedef): Likewise.
1933         * rust-lang.c (rust_print_typedef): Likewise.
1934         * symtab.c (print_symbol_info): Print a newline after calling
1935         typedef_print.
1936
1937 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * symtab.c (info_module_cmdlist): New variable.
1940         (info_module_command): New function.
1941         (search_module_symbols): New function.
1942         (info_module_subcommand): New function.
1943         (struct info_modules_var_func_options): New struct.
1944         (info_modules_var_func_options_defs): New variable.
1945         (make_info_modules_var_func_options_def_group): New function.
1946         (info_module_functions_command): New function.
1947         (info_module_variables_command): New function.
1948         (info_module_var_func_command_completer): New function.
1949         (_initialize_symtab): Register new 'info module functions' and
1950         'info module variables' commands.
1951         * symtab.h (typedef symbol_search_in_module): New typedef.
1952         (search_module_symbols): Declare new function.
1953         * NEWS: Mention new commands.
1954
1955 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1958         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1959         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1960         MODULES_DOMAIN.
1961         (scan_partial_symbols): Only create partial module symbols for non
1962         declarations.
1963         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1964         and MODULES_DOMAIN.
1965         * symtab.c (search_domain_name): Likewise.
1966         (search_symbols): Likewise.
1967         (print_symbol_info): Likewise.
1968         (symtab_symbol_info): Likewise.
1969         (info_modules_command): New function.
1970         (_initialize_symtab): Register 'info modules' command.
1971         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1972         * NEWS: Mention new 'info modules' command.
1973
1974 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1975
1976         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1977         and $_gdb_maint_setting_str.
1978
1979 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1980
1981         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1982         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1983         (str_value_from_setting, gdb_setting_str_internal_fn)
1984         (gdb_maint_setting_str_internal_fn): New functions.
1985         (_initialize_cli_cmds): Define the new convenience functions.
1986         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1987         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1988
1989 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1990
1991         * agent.c (set_can_use_agent): When the setting is turned on,
1992         look up agent symbols if we don't have them yet.
1993         (agent_new_objfile): Don't look up agent symbols when the agent
1994         setting is off.
1995
1996 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * config.in: Regenerate.
1999
2000 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2001
2002         * configure: Regenerate.
2003         * configure.ac: Check for strerror_r.
2004         * gdbsupport/common-utils.h (safe_strerror): Change return value
2005         to const char * and document that this function is now threadsafe.
2006         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2007         thread_local and call strerror_r, if available.
2008         * utils.c (perror_string): Update.
2009         (print_sys_errmsg): Update.
2010
2011 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2012
2013         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2014         objfile_key.
2015         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2016         objfile to fetch per-bfd data.
2017         (arm_find_exidx_entry): Likewise.
2018
2019 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2020
2021         * gdbsupport/agent.c (debug_agent): Change type to bool.
2022         (use_agent): Likewise.
2023         (all_agent_symbols_look_up): Likewise.
2024         (agent_loaded_p): Change return value to bool.
2025         (agent_look_up_symbols): Update.
2026         (agent_capability_check): Change return value to bool.
2027         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2028         (debug_agent): Change type to bool.
2029         (use_agent): Likewise.
2030         (agent_capability_check): Change return value to bool.
2031
2032 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2033
2034         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2035         (build_minimal_symbol_hash_tables): Code to clear the table moved
2036         to clear_minimal_symbol_hash_tables.
2037         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2038         when needed.
2039
2040 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2041
2042         * infcmd.c: Remove includes.
2043         * infrun.c: Remove includes.
2044
2045 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2046
2047         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2048         (grow_vect): Remove declaration.
2049         (ada_type_of_array): Remove declaration.
2050         (ada_update_initial_language): Remove declaration.
2051         (ada_fold_name): Remove declaration.
2052         (ada_fill_in_ada_prototype): Remove declaration.
2053         (user_select_syms): Remove declaration.
2054         (get_selections): Remove declaration.
2055         (ada_tag_type): Remove declaration.
2056         (ada_value_tag): Remove declaration.
2057         (ada_is_others_clause): Remove declaration.
2058         (ada_in_variant): Remove declaration.
2059         (ada_value_struct_elt): Remove declaration.
2060         (ada_attribute_name): Remove declaration.
2061         (ada_system_address_type): Remove declaration.
2062         * ada-lang.c (ada_watch_location_expression): Make static.
2063         (GROW_VECT): Move here from ada-lang.h.
2064         (grow_vect): Make static.
2065         (ada_update_initial_language): Make static.
2066         (ada_fold_name): Make static.
2067         (ada_type_of_array): Make static.
2068         (encoded_ordered_before): Move up.
2069         (sort_choices): Move up.
2070         (print_signatures): Move up.
2071         (ada_print_symbol_signature): Move up.
2072         (get_selections): Move up and make static.
2073         (user_select_syms): Move up and make static.
2074         (ada_value_struct_elt): Move up and make static.
2075         (ada_tag_type): Make static.
2076         (ada_value_tag): Make static.
2077         (ada_is_others_clause): Make static.
2078         (ada_in_variant): Make static.
2079         (ada_attribute_name): Make static.
2080
2081 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2082
2083         * ada-lang.c: Remove includes.
2084         * ada-typeprint.c: Remove includes.
2085         * ada-valprint.c: Remove includes.
2086
2087 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2088
2089         * addrmap.c: Add static assertions of type size, moved from
2090         _initialize_addrmap.
2091         (_initialize_addrmap): Remove.
2092
2093 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2094
2095         * coffread.c (record_minimal_symbol): Update.
2096         (process_coff_symbol): Update.
2097         * dbxread.c (read_dbx_symtab): Update.
2098         * dwarf2read.c (add_partial_symbol): Update.
2099         (fixup_go_packaging): Update.
2100         (load_partial_dies): Update.
2101         (new_symbol): Update.
2102         * elfread.c (record_minimal_symbol): Change signature to use
2103         gdb::string_view instead of name+len.
2104         (elf_symtab_read): Update.
2105         (elf_rel_plt_read): Update.
2106         * mdebugread.c (parse_partial_symbols): Update.
2107         (handle_psymbol_enumerators): Update.
2108         (new_symbol): Update.
2109         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2110         to use gdb::string_view instead of name+len.
2111         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2112         * psympriv.h (add_psymbol_to_list): Likewise.
2113         * psymtab.c (add_psymbol_to_bcache): Likewise.
2114         (add_psymbol_to_list): Likewise.
2115         * stabsread.c (define_symbol): Update.
2116         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2117         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2118         (symbol_set_names): Likewise.
2119         * xcoffread.c (scan_xcoff_symtab): Update.
2120
2121 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2122
2123         * symtab.h (symbol_set_names): Document that copy_name must be
2124         set to true for non-nullterminated strings.
2125         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2126         linkage_name if the entry was not found and we need to demangle.
2127
2128 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2129
2130         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2131         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2132         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2133         * gdbsupport/gdb_binary_search.h: New file.
2134
2135 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2136
2137         * NEWS: Mention new --with-system-gdbinit-dir option.
2138         * config.in: Regenerate.
2139         * configure: Regenerate.
2140         * configure.ac: Add new option --with-system-gdbinit-dir.
2141         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2142         for a ".gdb" suffix.
2143         * main.c (get_init_files): Change system_gdbinit argument to
2144         a vector and return the files in SYSTEM_GDBINIT_DIR in
2145         addition to SYSTEM_GDBINIT.
2146         (captured_main_1): Update.
2147         (print_gdb_help): Update.
2148         * top.c (print_gdb_configuration): Also print the value of
2149         SYSTEM_GDBINIT_DIR.
2150
2151 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2152
2153         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2154         that takes gdb::string_view arguments.
2155
2156 2019-10-26  Tom de Vries  <tdevries@suse.de>
2157
2158         * aarch64-linux-tdep.c: Fix typos in comments.
2159         * aarch64-tdep.c: Same.
2160         * ada-lang.c: Same.
2161         * amd64-nat.c: Same.
2162         * arc-tdep.c: Same.
2163         * arch/aarch64-insn.c: Same.
2164         * block.c: Same.
2165         * breakpoint.h: Same.
2166         * btrace.h: Same.
2167         * c-varobj.c: Same.
2168         * cli/cli-decode.c: Same.
2169         * cli/cli-script.c: Same.
2170         * cli/cli-utils.h: Same.
2171         * coff-pe-read.c: Same.
2172         * coffread.c: Same.
2173         * compile/compile-cplus-symbols.c: Same.
2174         * compile/compile-object-run.c: Same.
2175         * completer.c: Same.
2176         * corelow.c: Same.
2177         * cp-support.c: Same.
2178         * demangle.c: Same.
2179         * dwarf-index-write.c: Same.
2180         * dwarf2-frame.c: Same.
2181         * dwarf2-frame.h: Same.
2182         * eval.c: Same.
2183         * frame-base.h: Same.
2184         * frame.h: Same.
2185         * gdbcmd.h: Same.
2186         * gdbtypes.h: Same.
2187         * gnu-nat.c: Same.
2188         * guile/scm-objfile.c: Same.
2189         * i386-tdep.c: Same.
2190         * i386-tdep.h: Same.
2191         * infcall.c: Same.
2192         * infcall.h: Same.
2193         * linux-nat.c: Same.
2194         * m68k-tdep.c: Same.
2195         * macroexp.c: Same.
2196         * memattr.c: Same.
2197         * mi/mi-cmd-disas.c: Same.
2198         * mi/mi-getopt.h: Same.
2199         * mi/mi-main.c: Same.
2200         * minsyms.c: Same.
2201         * nat/aarch64-sve-linux-sigcontext.h: Same.
2202         * objfiles.h: Same.
2203         * ppc-linux-nat.c: Same.
2204         * ppc-linux-tdep.c: Same.
2205         * ppc-tdep.h: Same.
2206         * progspace.h: Same.
2207         * prologue-value.h: Same.
2208         * python/py-evtregistry.c: Same.
2209         * python/py-instruction.h: Same.
2210         * record-btrace.c: Same.
2211         * record-full.c: Same.
2212         * remote.c: Same.
2213         * rs6000-tdep.c: Same.
2214         * ser-tcp.c: Same.
2215         * sol-thread.c: Same.
2216         * sparc-sol2-tdep.c: Same.
2217         * sparc64-tdep.c: Same.
2218         * stabsread.c: Same.
2219         * symfile.c: Same.
2220         * symtab.h: Same.
2221         * target.c: Same.
2222         * tracepoint.c: Same.
2223         * tui/tui-data.h: Same.
2224         * tui/tui-io.c: Same.
2225         * tui/tui-win.c: Same.
2226         * tui/tui.c: Same.
2227         * unittests/rsp-low-selftests.c: Same.
2228         * user-regs.h: Same.
2229         * utils.c: Same.
2230         * utils.h: Same.
2231         * valarith.c: Same.
2232         * valops.c: Same.
2233         * valprint.c: Same.
2234         * valprint.h: Same.
2235         * value.c: Same.
2236         * value.h: Same.
2237         * varobj.c: Same.
2238         * x86-nat.h: Same.
2239         * xtensa-tdep.c: Same.
2240
2241 2019-10-25  Ali Tamur <tamur@google.com>
2242
2243         * charset.c (find_charset_names): Reflect API change.
2244
2245 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2246
2247         * symtab.c (struct demangled_name_entry): Change demangled name
2248         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2249         part of the struct anymore.
2250         (symbol_set_names): No longer obstack allocate + copy the demangled
2251         name, just store the allocated name from bfd.
2252
2253 2019-10-25  Tom Tromey  <tromey@adacore.com>
2254
2255         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2256         (bsearch_cie_cmp, add_cie): Remove.
2257         (find_cie): Reimplement.
2258         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2259         (dwarf2_build_frame_info): Update.
2260
2261 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2262
2263         PR gdb/25126
2264         * symfile.c (reread_symbols): Call forget_cached_source_info to
2265         clear the stale source cache.
2266
2267 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2268
2269         * configure: Regenerate.
2270         * configure.ac: Remove code that sets python_has_threads.
2271
2272 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2273
2274         * config.in: Regenerate.
2275         * configure: Regenerate.
2276         * configure.ac: Remove the code that uses sed to get the python
2277         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2278
2279 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2282         error paths.
2283
2284 2019-10-23  Tom Tromey  <tom@tromey.com>
2285
2286         * arc-tdep.c: Remove ".." from include.
2287         * frv-tdep.c: Remove ".." from include.
2288         * lm32-tdep.c: Remove ".." from include.
2289         * microblaze-tdep.c: Remove ".." from include.
2290         * or1k-tdep.h: Remove ".." from include.
2291         * s12z-tdep.c: Remove ".." from include.
2292         * Makefile.in (OPCODES_CFLAGS): Add comment.
2293         (TOP_CFLAGS): New variable.
2294         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2295
2296 2019-10-23  Tom Tromey  <tom@tromey.com>
2297
2298         * Makefile.in (READLINE_DIR): Update.
2299
2300 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2301
2302         * infcall.c (call_function_by_hand_dummy): Fix the function
2303         comment.  And extract out a code section into...
2304         (reserve_stack_space): ...this new function.
2305
2306 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2307
2308         * infcall.c (value_arg_coerce): Remove an unused parameter.
2309         (call_function_by_hand_dummy): Update the call to
2310         'value_arg_coerce'.
2311
2312 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2313
2314         * infcall.c (call_function_by_hand_dummy): Refactor.
2315
2316 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2317
2318         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2319
2320 2019-10-23  Tom Tromey  <tom@tromey.com>
2321
2322         * configure: Rebuild.
2323         * configure.ac: Don't check for sigprocmask.
2324         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2325
2326 2019-10-23  Tom Tromey  <tom@tromey.com>
2327
2328         * configure: Rebuild.
2329         * acinclude.m4: Use m4_include, not sinclude.
2330
2331 2019-10-23  Tom de Vries  <tdevries@suse.de>
2332
2333         PR breakpoints/24687
2334         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2335
2336 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2337
2338         * symtab.c (struct demangled_name_entry) <language>: Change from
2339         bitfield to regular variable.
2340
2341 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2342
2343         * symtab.c (struct demangled_name_entry): Add a constructor.
2344         (free_demangled_name_entry): New function to call the destructor
2345         for demangled_name_entry.
2346         (create_demangled_names_hash): Pass free_demangled_name_entry to
2347         htab_create_alloc.
2348         (symbol_set_names): Call placement new for demangled_name_entry.
2349         * utils.c: No longer include xxhash.h here, now that fast_hash
2350         is inlined in the header.
2351         * utils.h: Instead, include it here.
2352
2353 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2354
2355         * Makefile.in: Link with libxxhash.
2356         * config.in: Regenerate.
2357         * configure: Regenerate.
2358         * configure.ac: Search for libxxhash.
2359         * utils.c (fast_hash): Use xxhash if present.
2360
2361 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2362
2363         * utils.h (fast_hash): New function.
2364         * symtab.c (hash_demangled_name_entry): Call new function
2365         fast_hash.
2366
2367 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2368
2369         * symtab.c (struct demangled_name_entry): Change type of mangled
2370         to gdb::string_view. Also adds a constructor that takes the
2371         mangled name.
2372         (hash_demangled_name_entry): Update.
2373         (eq_demangled_name_entry): Update.
2374         (free_demangled_name_entry): New function to call the destructor
2375         now that this is not a POD anymore.
2376         (create_demangled_names_hash): Pass free_demangled_name_entry to
2377         htab_create_alloc.
2378         (symbol_set_names): Update.
2379
2380 2019-10-21  Ali Tamur  <tamu@google.com>
2381
2382         * dwarf2read.c (dir_index): Change type.
2383         (file_name_index): Likewise.
2384         (line_header::include_dir_at): Change comment and implementation on
2385         whether it is DWARF 5.
2386         (line_header::is_valid_file_index): New function.
2387         (line_header::file_name_at): Change comment and implementation on
2388         whether it is DWARF 5.
2389         (line_header::file_names): Change to private field renamed as
2390         m_file_names and introduce a new accessor method.
2391         (line_header::file_names_size): New method.
2392         (line_header::include_dirs): Change to private field and rename as
2393         m_include_dirs.
2394         (dw2_get_file_names_reader): Define local var at a smaller scope and
2395         reflect API change.
2396         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2397         (process_structure_scope): Likewise.
2398         (line_header::add_include_dir): Change message and reflect renaming.
2399         (line_header::add_file_name): Likewise.
2400         (read_formatted_entries): Handle DW_FORM_data16.
2401         (dwarf_decode_line_header): Fix line header length calculation.
2402         (psymtab_include_file_name): Change comment and API.
2403         (lnp_state_machine::m_file): Update comment and reflect type change.
2404         (lnp_state_machine::record_line): Reflect type change.
2405         (dwarf_decode_lines): Reflect API change.
2406         (file_file_name): Likewise.
2407         (file_full_name): Likewise.
2408
2409 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2412
2413 2019-10-21  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2416
2417 2019-10-21  Tom Tromey  <tom@tromey.com>
2418
2419         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2420         NM_H.   Use AC_CONFIG_LINKS.
2421         * configure: Rebuild.
2422         * Makefile.in (NM_H): New variable.
2423         (generated_files): Add NM_H.  Remove gcore.
2424         (nm.h, stamp-nmh): New targets.
2425
2426 2019-10-20  Tom Tromey  <tom@tromey.com>
2427
2428         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2429         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2430         obsolete comment.
2431         (put_objfile_before): Now static.
2432
2433 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2434
2435         * gdbsupport/common-utils.h (startswith): Change return type to
2436         bool.
2437
2438 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2441         * breakpoint.c (bp_locations_compare): Rename to...
2442         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2443         (update_global_location_list): Use std::sort instead of qsort.
2444         * buildsym.c (compare_line_numbers): Rename to...
2445         (lte_is_less_than): ...this, and change to std::sort semantics.
2446         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2447         instead of qsort.
2448         * disasm.c (compare_lines): Rename to...
2449         (line_is_less_than): ...this, and change to std::sort semantics.
2450         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2451         of qsort.
2452         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2453         (fde_is_less_than): ...this, and change to std::sort semantics.
2454         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2455         * mdebugread.c (compare_blocks):
2456         (block_is_less_than): ...this, and change to std::sort semantics.
2457         (sort_blocks): Call std::sort instead of qsort.
2458         * objfiles.c (qsort_cmp): Rename to...
2459         (sort_cmp): ...this, and change to std::sort semantics.
2460         (update_section_map): Call std::sort instead of qsort.
2461         * remote.c (compare_pnums): Remove.
2462         (map_regcache_remote_table): Call std::sort instead of qsort.
2463         * utils.c (compare_positive_ints): Remove.
2464         * utils.h (compare_positive_ints): Remove.
2465         * xcoffread.c (compare_lte): Remove.
2466         (arrange_linetable): Call std::sort instead of qsort.
2467
2468 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2469
2470         * symfile.c (init_entry_point_info): Fix typo.
2471         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2472
2473 2019-10-18  Tom de Vries  <tdevries@suse.de>
2474
2475         * aarch64-tdep.c: Fix typos in comments.
2476         * ada-lang.c: Same.
2477         * ada-tasks.c: Same.
2478         * alpha-tdep.c: Same.
2479         * alpha-tdep.h: Same.
2480         * amd64-nat.c: Same.
2481         * amd64-windows-tdep.c: Same.
2482         * arc-tdep.c: Same.
2483         * arc-tdep.h: Same.
2484         * arch-utils.c: Same.
2485         * arm-nbsd-tdep.c: Same.
2486         * arm-tdep.c: Same.
2487         * ax-gdb.c: Same.
2488         * blockframe.c: Same.
2489         * btrace.c: Same.
2490         * c-varobj.c: Same.
2491         * coff-pe-read.c: Same.
2492         * coffread.c: Same.
2493         * cris-tdep.c: Same.
2494         * darwin-nat.c: Same.
2495         * dbxread.c: Same.
2496         * dcache.c: Same.
2497         * disasm.c: Same.
2498         * dtrace-probe.c: Same.
2499         * dwarf-index-write.c: Same.
2500         * dwarf2-frame-tailcall.c: Same.
2501         * dwarf2-frame.c: Same.
2502         * dwarf2read.c: Same.
2503         * eval.c: Same.
2504         * exceptions.c: Same.
2505         * fbsd-tdep.c: Same.
2506         * findvar.c: Same.
2507         * frame.c: Same.
2508         * frv-tdep.c: Same.
2509         * gnu-v3-abi.c: Same.
2510         * go32-nat.c: Same.
2511         * h8300-tdep.c: Same.
2512         * hppa-tdep.c: Same.
2513         * i386-linux-tdep.c: Same.
2514         * i386-tdep.c: Same.
2515         * ia64-libunwind-tdep.c: Same.
2516         * ia64-tdep.c: Same.
2517         * infcmd.c: Same.
2518         * infrun.c: Same.
2519         * linespec.c: Same.
2520         * linux-nat.c: Same.
2521         * linux-thread-db.c: Same.
2522         * machoread.c: Same.
2523         * mdebugread.c: Same.
2524         * mep-tdep.c: Same.
2525         * mn10300-tdep.c: Same.
2526         * namespace.c: Same.
2527         * objfiles.c: Same.
2528         * opencl-lang.c: Same.
2529         * or1k-tdep.c: Same.
2530         * osabi.c: Same.
2531         * ppc-linux-nat.c: Same.
2532         * ppc-linux-tdep.c: Same.
2533         * ppc-sysv-tdep.c: Same.
2534         * printcmd.c: Same.
2535         * procfs.c: Same.
2536         * record-btrace.c: Same.
2537         * record-full.c: Same.
2538         * remote-fileio.c: Same.
2539         * remote.c: Same.
2540         * rs6000-tdep.c: Same.
2541         * s12z-tdep.c: Same.
2542         * score-tdep.c: Same.
2543         * ser-base.c: Same.
2544         * ser-go32.c: Same.
2545         * skip.c: Same.
2546         * sol-thread.c: Same.
2547         * solib-svr4.c: Same.
2548         * solib.c: Same.
2549         * source.c: Same.
2550         * sparc-nat.c: Same.
2551         * sparc-sol2-tdep.c: Same.
2552         * sparc-tdep.c: Same.
2553         * sparc64-tdep.c: Same.
2554         * stabsread.c: Same.
2555         * stack.c: Same.
2556         * symfile.c: Same.
2557         * symtab.c: Same.
2558         * target-descriptions.c: Same.
2559         * target-float.c: Same.
2560         * thread.c: Same.
2561         * utils.c: Same.
2562         * valops.c: Same.
2563         * valprint.c: Same.
2564         * value.c: Same.
2565         * varobj.c: Same.
2566         * windows-nat.c: Same.
2567         * xcoffread.c: Same.
2568         * xstormy16-tdep.c: Same.
2569         * xtensa-tdep.c: Same.
2570
2571 2019-10-17  Tom Tromey  <tromey@adacore.com>
2572
2573         * configure: Rebuild.
2574         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2575         in AC_CONFIG_FILES invocation.
2576         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2577         new-style config.status invocation.
2578
2579 2019-10-17  Tom de Vries  <tdevries@suse.de>
2580
2581         * arm-nbsd-nat.c: Fix typos in comments.
2582         * arm-tdep.c: Same.
2583         * darwin-nat-info.c: Same.
2584         * dwarf2read.c: Same.
2585         * elfread.c: Same.
2586         * event-top.c: Same.
2587         * findvar.c: Same.
2588         * gdbtypes.c: Same.
2589         * hppa-tdep.c: Same.
2590         * i386-tdep.c: Same.
2591         * jit.c: Same.
2592         * main.c: Same.
2593         * mdebugread.c: Same.
2594         * moxie-tdep.c: Same.
2595         * nto-procfs.c: Same.
2596         * osabi.c: Same.
2597         * ppc-linux-tdep.c: Same.
2598         * remote.c: Same.
2599         * riscv-tdep.c: Same.
2600         * s390-tdep.c: Same.
2601         * sh-tdep.c: Same.
2602         * sparc-linux-tdep.c: Same.
2603         * sparc-nat.c: Same.
2604         * stack.c: Same.
2605         * target-descriptions.c: Same.
2606         * top.c: Same.
2607         * varobj.c: Same.
2608
2609 2019-10-16  Tom Tromey  <tom@tromey.com>
2610
2611         * objfiles.h (struct objfile) <original_name>: Now const.
2612
2613 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2614
2615         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2616         pass on to sigsetjmp's second argument.
2617         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2618
2619 2019-10-16  Keith Seitz  <keiths@redhat.com>
2620
2621         PR gdb/23567
2622         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2623         sections whose size is greater than the file size.
2624
2625 2019-10-16  Jim Wilson  <jimw@sifive.com>
2626
2627         * riscv-tdep.c (riscv_gcc_target_options): New.
2628         (riscv_gnu_triplet_regexp): New.
2629         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2630         set_gdbarch_gnu_triplet_regexp.
2631
2632 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2633
2634         * Makefile.in: Add xml-builtin.h.
2635         * features/feature_to_c.sh: Add an include for xml-builtin.h
2636         to ensure that the compiler checks that the types match.
2637         * xml-builtin.h: New file.
2638         * xml-support.c (fetch_xml_builtin): Add missing const.
2639         * xml-support.h: Remove declaration of xml_builtins.
2640
2641 2019-10-16  Tom de Vries  <tdevries@suse.de>
2642
2643         PR tdep/25096
2644         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2645         (amd64_classify_aggregate): ... here.
2646         (amd64_classify_aggregate_field): Handled fiels of nested structs
2647         recursively.
2648
2649 2019-10-16  Tom de Vries  <tdevries@suse.de>
2650
2651         PR tdep/24104
2652         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2653         that handles 'theclass'.
2654
2655 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * linespec.c (decode_digits_ordinary): Update comment.
2658         * make-target-delegates: No longer need to handle VEC case.
2659         * memrange.c (normalize_mem_ranges): Update comment.
2660         * namespace.c (add_using_directive): Update comment.
2661         * objc-lang.c (uniquify_strings): Update comment.
2662         * ppc-linux-nat.c (struct thread_points): Update comment.
2663         * probe.h (find_probes_in_objfile): Update comment.
2664         * target.h (enum flash_preserve_mode): Update comment.
2665         * varobj.c (varobj_restrict_range): Update comment.
2666         * varobj.h (varobj_list_children): Update comment.
2667
2668 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2669
2670         * Makefile.in: Remove references to vec.h and vec.c.
2671         * aarch64-tdep.c: No longer include vec.h.
2672         * ada-lang.c: Likewise.
2673         * ada-lang.h: Likewise.
2674         * arm-tdep.c: Likewise.
2675         * ax.h: Likewise.
2676         * breakpoint.h: Likewise.
2677         * charset.c: Likewise.
2678         * cp-support.h: Likewise.
2679         * dtrace-probe.c: Likewise.
2680         * dwarf2read.c: Likewise.
2681         * extension.h: Likewise.
2682         * gdb_bfd.c: Likewise.
2683         * gdbsupport/gdb_vecs.h: Likewise.
2684         * gdbsupport/vec.c: Remove.
2685         * gdbsupport/vec.h: Remove.
2686         * gdbthread.h: Likewise.
2687         * guile/scm-type.c: Likewise.
2688         * inline-frame.c: Likewise.
2689         * machoread.c: Likewise.
2690         * memattr.c: Likewise.
2691         * memrange.h: Likewise.
2692         * namespace.h: Likewise.
2693         * nat/linux-btrace.h: Likewise.
2694         * osdata.c: Likewise.
2695         * parser-defs.h: Likewise.
2696         * progspace.h: Likewise.
2697         * python/py-type.c: Likewise.
2698         * record-btrace.c: Likewise.
2699         * rust-exp.y: Likewise.
2700         * solib-target.c: Likewise.
2701         * stap-probe.c: Likewise.
2702         * target-descriptions.c: Likewise.
2703         * target-memory.c: Likewise.
2704         * target.h: Likewise.
2705         * varobj.c: Likewise.
2706         * varobj.h: Likewise.
2707         * xml-support.h: Likewise.
2708
2709 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2712         Update for new std::vector based implementation.
2713         (process_psymtab_comp_unit_reader): Likewise.
2714         (scan_partial_symbols): Likewise.
2715         (recursively_compute_inclusions): Likewise.
2716         (compute_compunit_symtab_includes): Likewise.
2717         (process_imported_unit_die): Likewise.
2718         (queue_and_load_dwo_tu): Likewise.
2719         (follow_die_sig_1): Likewise.
2720         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2721         (typedef dwarf2_per_cu_ptr): Remove.
2722         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2723         function.
2724         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2725         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2726         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2727         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2728         std::vector.
2729
2730 2019-10-15  Tom Tromey  <tromey@adacore.com>
2731
2732         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2733         TID.
2734
2735 2019-10-15  Tom Tromey  <tromey@adacore.com>
2736
2737         * windows-nat.c (windows_nat_target::fetch_registers)
2738         (windows_nat_target::store_registers): Rename "pid" to "tid".
2739
2740 2019-10-15  Tom Tromey  <tromey@adacore.com>
2741
2742         * gdbarch.h, gdbarch.c: Rebuild.
2743         * gdbarch.sh (gcc_target_options): Change return type to
2744         std::string.
2745         * compile/compile.c (get_args): Update.
2746         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2747         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2748         std::string.
2749         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2750         std::string.
2751         * arch-utils.c (default_gcc_target_options): Return std::string.
2752         * arch-utils.h (default_gcc_target_options): Return std::string.
2753         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2754
2755 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2756
2757         * breakpoint.c (breakpoint_chain): Make static.
2758         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2759         of accessing breakpoint_chain.
2760
2761 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2762
2763         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2764         to a gdb::function_view and return value to bool.
2765         * breakpoint.h (iterate_over_breakpoints): Likewise.
2766         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2767         (pop_dummy_frame): Update.
2768         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2769         (gdbscm_breakpoints): Update.
2770         * python/py-breakpoint.c (build_bp_list): Update.
2771         (gdbpy_breakpoints): Update.
2772         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2773         Update.
2774         (bpfinishpy_handle_stop): Update.
2775         (bpfinishpy_handle_exit): Update.
2776         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2777         (svr4_update_solib_event_breakpoints): Update.
2778
2779 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2780
2781         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2782         when unwrapping single-field structs.
2783
2784 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2785
2786         * dwarf2read.c: Remove includes.
2787
2788 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2789
2790         * ui-out.c (ui_out::call_do_message): Silence
2791         -Wformat-nonliteral warning.
2792
2793 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2794
2795         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2796         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2797         include: readline/tilde.h.
2798
2799 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2800
2801         * remote.c (remote_target::get_trace_status): Remove declaration of
2802         trace_regblock_size.
2803
2804 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2805
2806         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2807         (show_user): Remove declaration of cmdlist.
2808         * cli/cli-cmds.h (max_user_call_depth): Declare.
2809         * cli/cli-script.c (execute_user_command): Remove declaration
2810         of max_user_call_depth.
2811
2812 2019-10-11  Jim Wilson  <jimw@sifive.com>
2813
2814         * gdbsupport/print-utils.h (pulongest): Fix comment.
2815         (plongest): Likewise.
2816         (phex): Add missing comment, mention leading zeros.
2817         (phex_nz): Add mention of no leading zeros to comment.
2818
2819         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2820         plongest instead of unsigned long long cast.
2821
2822 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2823
2824         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2825         for external_editor_command and gdbtk_test.
2826
2827 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2828
2829         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2830         * varobj.c (varobjdebug): Move comment to...
2831         * varobj.h (varobjdebug): ...here, and declare.
2832
2833 2019-10-09  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2836         erase_data_content.
2837
2838 2019-10-09  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2841         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2842         * tui/tui-command.c (tui_cmd_window::resize)
2843         (tui_refresh_cmd_win): Update.
2844         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2845         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2846         * tui/tui-data.c (~tui_gen_win_info): Remove.
2847         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2848         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2849         (tui_redisplay_readline, tui_mld_flush)
2850         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2851         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2852         (tui_data_window::erase_data_content)
2853         (tui_data_item_window::rerender)
2854         (tui_data_item_window::refresh_window): Update.
2855         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2856         (box_win, tui_gen_win_info::make_window)
2857         (tui_gen_win_info::make_visible): Update.
2858         (tui_delete_win): Remove.
2859         * tui/tui-winsource.c
2860         (tui_source_window_base::do_erase_source_content): Update.
2861         (tui_show_source_line, tui_source_window_base::update_tab_width)
2862         (tui_source_window_base::update_exec_info): Update.
2863         * tui/tui-data.h (struct curses_deleter): New.
2864         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2865         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2866
2867 2019-10-09  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2870
2871 2019-10-09  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2874         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2875
2876 2019-10-09  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2879         window height directly.
2880         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2881         declare.
2882         * tui/tui-layout.c (tui_default_win_height): Remove.
2883         (tui_default_win_viewport_height): Remove.
2884
2885 2019-10-09  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui.h: Remove comments.
2888
2889 2019-10-09  Tom de Vries  <tdevries@suse.de>
2890
2891         * python/lib/gdb/printer/bound_registers.py: Use
2892         '^builtin_type_bound128' as regexp argument for
2893         add_builtin_pretty_printer.
2894
2895 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2896
2897         * guile/guile.c (guile_extension_script_ops): Remove forward
2898         declaration and mark as static.
2899         (guile_script_ops): Likewise.
2900         (extension_language_guile): Move further down in the file so
2901         it can reference the definitions for guile_{extension_,}script_ops.
2902
2903 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2904
2905         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2906         except SORTL, DFLTCC, and KDSA.
2907
2908 2019-10-08  Tom Tromey  <tromey@adacore.com>
2909
2910         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2911         (struct safe_symbol_file_add_args): Remove.
2912
2913 2019-10-08  Tom Tromey  <tromey@adacore.com>
2914
2915         * windows-nat.c: Don't include buildsym-legacy.h.
2916
2917 2019-10-08  Tom Tromey  <tromey@adacore.com>
2918
2919         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2920
2921 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2922
2923         * gdbtypes.c (overload_debug): Move comment to header.
2924         * gdbtypes.h (overload_debug): Declare.
2925         * valops.c: Remove declaration of overload_debug, instead
2926         include gdbtypes.h.
2927
2928 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2929
2930         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2931         through _().
2932         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2933         move comment...
2934         * language.h (lang_frame_mismatch_warn): ... here. Also add
2935         declaration.
2936         * top.c (lang_frame_mismatch_warn): Remove declaration.
2937         (check_frame_language_change): Pass lang_frame_mismatch_warn
2938         through _().
2939
2940 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2941
2942         * c-lang.h (vtbl_ptr_name): Declare.
2943         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2944         it from the header.
2945         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2946
2947 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2948
2949         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2950         gdb_static_assert.
2951
2952 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2953
2954         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2955         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2956         * ctfread.c: New file.
2957         * ctfread.h: New file.
2958         * elfread.c: Include ctfread.h.
2959         (struct elfinfo text_p): New member ctfsect.
2960         (elf_locate_sections): Mark CTF section.
2961         (elf_symfile_read): Call elfctf_build_psymtabs.
2962         * Makefile.in (LIBCTF): Add.
2963         (CLIBS): Use it.
2964         (CDEPS): Likewise.
2965         (DIST): Add ctfread.c.
2966
2967 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * ctfread.c (struct nextfield): Renamed to ...
2970         (struct ctf_nextfield): ... this.
2971         (struct field_info): Renamed to ...
2972         (strut ctf_field_info): ... this.
2973         (attach_fields_to_type): Update for renamed structures.
2974         (ctf_add_member_cb): Likewise.
2975         (ctf_add_enum_member_cb): Likewise.
2976         (process_struct_members): Likewise.
2977         (process_enum_type): Likewise.
2978
2979 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2980
2981         * tracectf.h: Rename, was ctf.h.
2982         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2983         * tracefile.c: Likewise.
2984         * tracepoint.c: Remove unused include ctf.h.
2985         * mi/mi-main.c: Likewise.
2986         * Makefile.in Replace ctf.c with tracectf.c.
2987
2988 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2989
2990         * version.in: Change version number to "9.0.50.DATE-git".
2991
2992 2019-10-03  Tom Tromey  <tom@tromey.com>
2993
2994         PR rust/24976:
2995         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2996
2997 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3000         cp_search_name_hash.
3001         * NEWS: Add entry about nested function support.
3002
3003 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3004             Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3007         for nested static variables when searchin VAR_DOMAIN.
3008         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3009         global scope, update comment.
3010         (add_partial_subprogram): Call add_partial_subprogram recursively
3011         for nested subroutines when processinng Fortran.
3012         (load_partial_dies): Process the child entities of a subprogram
3013         when processing Fortran.
3014         (partial_die_parent_scope): Handle building scope
3015         for Fortran nested functions.
3016         (process_die): Record that nested functions have a scope.
3017         (new_symbol): Always record Fortran subprograms on the global
3018         symbol list.
3019         (determine_prefix): How to build the prefix for Fortran
3020         subprograms.
3021
3022 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3025         have just sent the thread a SIGSTOP and are waiting for it to
3026         arrive.
3027
3028 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * btrace.c (btrace_add_pc): Remove whitespace before the template
3031         parameter in 'std::vector <...>'.
3032         (parse_xml_btrace_block): Likewise.
3033         (btrace_maint_decode_pt): Likewise.
3034         (btrace_maint_update_packets): Likewise.
3035         (btrace_maint_print_packets): Likewise.
3036         * btrace.h (struct btrace_maint_info): Likewise.
3037         * dwarf2read.c (struct type_unit_group): Likewise.
3038         (build_type_psymtabs_reader): Likewise.
3039         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3040         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3041         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3042
3043 2019-10-03  Tom de Vries  <tdevries@suse.de>
3044
3045         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3046         the first line of the help text for set/show style metadata.
3047
3048 2019-10-02  Tom Tromey  <tromey@adacore.com>
3049
3050         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3051         * gdbsupport/common-inferior.c: New file.
3052         * infcmd.c (startup_with_shell): Don't define.
3053         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3054         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3055         * inferior.h (startup_with_shell): Don't declare.
3056
3057 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3058
3059         * gdbsupport/gdb_assert.h: Include errors.h.
3060         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3061
3062 2019-10-02  Tom Tromey  <tromey@adacore.com>
3063
3064         * NEWS: Add $_ada_exception entry.
3065         * ada-lang.c (struct ada_catchpoint): Add constructor.
3066         <m_kind>: New member.
3067         (allocate_location_exception, re_set_exception): Remove
3068         "ex" parameter.
3069         (should_stop_exception): Compute $_ada_exception.
3070         (check_status_exception, print_it_exception)
3071         (print_one_exception, print_mention_exception): Remove
3072         "ex" parameter.
3073         (allocate_location_catch_exception, re_set_catch_exception)
3074         (check_status_exception, print_it_catch_exception)
3075         (print_one_catch_exception, print_mention_catch_exception)
3076         (print_recreate_catch_exception)
3077         (allocate_location_catch_exception_unhandled)
3078         (re_set_catch_exception_unhandled)
3079         (check_status_exception, print_it_catch_exception_unhandled)
3080         (print_one_catch_exception_unhandled)
3081         (print_mention_catch_exception_unhandled)
3082         (print_recreate_catch_exception_unhandled)
3083         (allocate_location_catch_assert, re_set_catch_assert)
3084         (check_status_assert, print_it_catch_assert)
3085         (print_one_catch_assert, print_mention_catch_assert)
3086         (print_recreate_catch_assert)
3087         (allocate_location_catch_handlers, re_set_catch_handlers)
3088         (check_status_handlers, print_it_catch_handlers)
3089         (print_one_catch_handlers, print_mention_catch_handlers)
3090         (print_recreate_catch_handlers): Remove.
3091         (create_ada_exception_catchpoint): Update.
3092         (initialize_ada_catchpoint_ops): Update.
3093
3094 2019-10-02  Tom Tromey  <tromey@adacore.com>
3095
3096         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3097         (create_excep_cond_exprs): Simplify exception string computation.
3098         (ada_exception_catchpoint_cond_string): Likewise.
3099
3100 2019-10-02  Tom Tromey  <tromey@adacore.com>
3101
3102         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3103         * ada-lang.c (lesseq_defined_than): Handle
3104         LOC_STATIC.
3105         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3106         parameter.
3107         (dwarf2_has_info): Likewise.
3108         (new_symbol): Set maybe_copied on symbol when
3109         appropriate.
3110         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3111         parameter.
3112         <can_copy>: New member.
3113         * elfread.c (record_minimal_symbol): Set maybe_copied
3114         on symbol when appropriate.
3115         (elf_symfile_read): Update call to dwarf2_has_info.
3116         * minsyms.c (lookup_minimal_symbol_linkage): New
3117         function.
3118         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3119         * symtab.c (get_symbol_address, get_msymbol_address):
3120         New functions.
3121         * symtab.h (get_symbol_address, get_msymbol_address):
3122         Declare.
3123         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3124         maybe_copied.
3125         (struct symbol, struct minimal_symbol) <maybe_copied>:
3126         New member.
3127
3128 2019-10-02  Tom Tromey  <tromey@adacore.com>
3129
3130         * source.c (struct current_source_location): New.
3131         (current_source_key): New global.
3132         (current_source_symtab, current_source_line)
3133         (current_source_pspace): Remove.
3134         (get_source_location): New function.
3135         (get_current_source_symtab_and_line)
3136         (set_default_source_symtab_and_line)
3137         (set_current_source_symtab_and_line)
3138         (clear_current_source_symtab_and_line, select_source_symtab)
3139         (info_source_command, print_source_lines_base)
3140         (info_line_command, search_command_helper, _initialize_source):
3141         Update.
3142
3143 2019-10-02  Tom Tromey  <tromey@adacore.com>
3144
3145         * source.c (select_source_symtab): Don't call
3146         decode_line_with_current_source.
3147
3148 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3149
3150         * symtab.c (lookup_global_symbol): Search global block.
3151
3152 2019-10-02  Tom Tromey  <tromey@adacore.com>
3153
3154         * coffread.c (process_coff_symbol): Update.
3155         * dwarf2read.c (var_decode_location, new_symbol): Update.
3156         * mdebugread.c (parse_symbol): Update.
3157         * objfiles.c (relocate_one_symbol): Update.
3158         * stabsread.c (define_symbol, fix_common_block)
3159         (scan_file_globals): Update.
3160         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3161         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3162         * xcoffread.c (process_xcoff_symbol): Update.
3163
3164 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3165
3166         * MAINTAINERS: Update my email address.
3167
3168 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3171         std::vector.
3172         (build_type_psymtabs_reader): Update for std::vector.
3173         (build_type_psymtab_dependencies): Likewise.
3174         * dwarf2read.h: Remove use of DEF_VEC_P.
3175         (typedef sig_type_ptr): Delete.
3176
3177 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3178
3179         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3180         to std::vector.
3181         (btrace_maint_decode_pt): Likewise, and move allocation of the
3182         vector outside of the loop.
3183         (btrace_maint_update_packets): Update to handle change from VEC to
3184         std::vector.
3185         (btrace_maint_print_packets): Likewise.
3186         (maint_info_btrace_cmd): Likewise.
3187         * btrace.h: Remove use of DEF_VEC_O.
3188         (typedef btrace_pt_packet_s): Delete.
3189         (struct btrace_maint_info) <packets>: Change fromm VEC to
3190         std::vector.
3191         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3192
3193 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3194
3195         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3196         make accesses into the vector constant references.
3197         (btrace_add_pc): Update for std::vector.
3198         (btrace_stitch_bts): Likewise.
3199         (parse_xml_btrace_block): Likewise.
3200         (btrace_maint_update_packets): Likewise.
3201         (btrace_maint_print_packets): Likewise.
3202         (maint_info_btrace_cmd): Likewise.
3203         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3204         std::vector.
3205         (btrace_data::empty): Likewise.
3206         (btrace_data_append): Likewise.
3207         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3208         (typedef btrace_block_s): Delete.
3209         (struct btrace_block): Add constructor.
3210         (struct btrace_data_bts) <blocks>: Change to std::vector.
3211         * nat/linux-btrace.c (perf_event_read_bts): Update for
3212         std::vector.
3213         (linux_read_bts): Likewise.
3214
3215 2019-10-01  Tom Tromey  <tom@tromey.com>
3216
3217         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3218
3219 2019-10-01  Tom Tromey  <tom@tromey.com>
3220
3221         * stack.c (print_frame, info_frame_command_core): Use
3222         styled_string.
3223         * linux-thread-db.c (try_thread_db_load_1)
3224         (try_thread_db_load_from_pdir_1): Use styled_string.
3225         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3226         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3227         (maybe_print_unsupported_script_warning)
3228         (maybe_print_script_not_found_warning): Use styled_string.
3229         * ada-lang.c (user_select_syms): Use styled_string.
3230
3231 2019-10-01  Tom Tromey  <tom@tromey.com>
3232
3233         * p-lang.c (pascal_printstr): Use metadata style.
3234         * value.c (show_convenience): Use metadata style.
3235         * valprint.c (valprint_check_validity, val_print_optimized_out)
3236         (val_print_not_saved, val_print_unavailable)
3237         (val_print_invalid_address, generic_val_print, val_print)
3238         (value_check_printable, val_print_array_elements): Use metadata
3239         style.
3240         * ui-out.h (class ui_out) <field_fmt>: New overload.
3241         <do_field_fmt>: Add style parameter.
3242         * ui-out.c (ui_out::field_fmt): New overload.
3243         * typeprint.c (type_print_unknown_return_type)
3244         (val_print_not_allocated, val_print_not_associated): Use metadata
3245         style.
3246         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3247         parameter.
3248         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3249         * tracepoint.c (tvariables_info_1): Use metadata style.
3250         * stack.c (print_frame_arg, print_frame_info, print_frame)
3251         (info_frame_command_core): Use metadata style.
3252         * skip.c (info_skip_command): Use metadata style.
3253         * rust-lang.c (rust_print_enum): Use metadata style.
3254         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3255         metadata style.
3256         * python/py-framefilter.c (py_print_single_arg): Use metadata
3257         style.
3258         * printcmd.c (do_one_display, print_variable_and_value): Use
3259         metadata style.
3260         * p-valprint.c (pascal_val_print)
3261         (pascal_object_print_value_fields): Use metadata style.
3262         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3263         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3264         parameter.
3265         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3266         * m2-valprint.c (m2_print_long_set): Use metadata style.
3267         * m2-typeprint.c (m2_print_type): Use metadata style.
3268         * infcmd.c (print_return_value_1): Use metadata style.
3269         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3270         * f-valprint.c (info_common_command_for_block): Use metadata
3271         style.
3272         * f-typeprint.c (f_type_print_base): Use metadata style.
3273         * expprint.c (print_subexp_standard): Use metadata style.
3274         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3275         * cli/cli-style.h (class cli_style_option): Add constructor.
3276         (metadata_style): Declare.
3277         * cli/cli-style.c (metadata_style): New global.
3278         (_initialize_cli_style): Register metadata style.
3279         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3280         parameter.
3281         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3282         * c-typeprint.c (c_type_print_base_struct_union)
3283         (c_type_print_base_1): Use metadata style.
3284         * breakpoint.c (watchpoint_value_print)
3285         (print_one_breakpoint_location): Use metadata style.
3286         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3287         style.
3288         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3289         style.
3290         * ada-valprint.c (val_print_packed_array_elements, printstr)
3291         (print_field_values, ada_val_print_ref, ada_val_print): Use
3292         metadata style.
3293         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3294         style.
3295         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3296         style.
3297         * ada-lang.c (user_select_syms): Use metadata style.
3298
3299 2019-10-01  Tom Tromey  <tom@tromey.com>
3300
3301         * cli/cli-cmds.c (pwd_command): Style output.
3302
3303 2019-10-01  Pedro Alves  <palves@redhat.com>
3304             Tom Tromey  <tom@tromey.com>
3305
3306         * symtab.c (print_symbol_info): Use %ps.
3307         (print_msymbol_info): Use %ps.
3308         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3309         * printcmd.c (print_variable_and_value): Use %ps.
3310         * macrocmd.c (show_pp_source_pos): Use %ps.
3311         * infrun.c (print_exited_reason): Use ui_out::message.
3312         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3313         (describe_other_breakpoints): Use ui_out::message and new
3314         formats.
3315         (say_where): Use new formats.
3316         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3317         and new formats.
3318
3319 2019-10-01  Pedro Alves  <palves@redhat.com>
3320             Tom Tromey  <tom@tromey.com>
3321
3322         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3323         (test_gdb_formats): New function.
3324         (run_tests): Call it.
3325         (test_format_specifier): Update.
3326         * utils.h (fputs_filtered): Update comment.
3327         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3328         (fputs_styled_unfiltered): Declare.
3329         * utils.c (fputs_styled_unfiltered): New function.
3330         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3331         (vfprintf_filtered): Update.
3332         (vfprintf_unfiltered, vprintf_filtered): Update.
3333         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3334         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3335         disallow_ui_out_field>: New constants.
3336         (enum class field_kind): New.
3337         (struct base_field_s, struct signed_field_s): New.
3338         (signed_field): New function.
3339         (struct string_field_s): New.
3340         (string_field): New function.
3341         (struct styled_string_s): New.
3342         (styled_string): New function.
3343         (class ui_out) <message>: Add comment.
3344         <vmessage, call_do_message>: New methods.
3345         <do_message>: Add style parameter.
3346         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3347         methods.
3348         (ui_out::message): Rewrite.
3349         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3350         parameter.
3351         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3352         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3353         gdb_extensions parameter.
3354         (class format_piece): Add parameter to constructor.
3355         (n_int_args): New field.
3356         * gdbsupport/format.c (format_pieces::format_pieces): Add
3357         gdb_extensions parameter.  Handle '*'.
3358         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3359         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3360         vfprintf_styled_no_gdbfmt.
3361         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3362         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3363         unfiltered output.
3364         * ui-style.h (struct ui_file_style) <ptr>: New method.
3365
3366 2019-10-01  Tom Tromey  <tom@tromey.com>
3367
3368         * unittests/format_pieces-selftests.c: Update.  Add final format.
3369         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3370         empty literal pieces.
3371
3372 2019-10-01  Tom Tromey  <tom@tromey.com>
3373
3374         * ui-out.h (enum class ui_out_style_kind): Remove.
3375         (class ui_out) <field_string, field_stsream, do_field_string>:
3376         Change type of "style".
3377         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3378         (ui_out::field_string): Update.
3379         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3380         of "style".
3381         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3382         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3383         * stack.c (print_frame_arg, print_frame_info, print_frame):
3384         Update.
3385         * source.c (print_source_lines_base): Update.
3386         * solib.c (info_sharedlibrary_command): Update.
3387         * skip.c (info_skip_command): Update.
3388         * record-btrace.c (btrace_call_history_src_line)
3389         (btrace_call_history): Update.
3390         * python/py-framefilter.c (py_print_frame): Update.
3391         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3392         "style".
3393         * mi/mi-out.c (mi_ui_out::do_table_header)
3394         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3395         (mi_ui_out::do_field_string): Update.
3396         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3397         Update.
3398         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3399         "style".
3400         * cli-out.c (cli_ui_out::do_table_header)
3401         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3402         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3403         (cli_ui_out::do_field_fmt): Update.
3404         * breakpoint.c (print_breakpoint_location): Update.
3405         (update_static_tracepoint): Update.
3406
3407 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3408
3409         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3410         conversion of gdb_datadir.
3411         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3412         remove not needed c_str ().
3413
3414 2019-09-30  Ali Tamur <tamur@google.com>
3415
3416         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3417         (dwarf2_string_attr): Likewise.
3418
3419 2019-09-30  Ali Tamur <tamur@google.com>
3420
3421         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3422         (process_full_type_unit): Likewise.
3423         (dump_die_shallow): Likewise.
3424         (cu_debug_loc_section): Likewise.
3425
3426 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3427
3428         * minsyms.c (compare_minimal_symbols): Rename to...
3429         (minimal_symbol_is_less_than): ...this, and adjust to STL
3430         conventions (return bool, take arguments as references)
3431         (minimal_symbol_reader::install): Call std::sort instead
3432         of qsort.
3433
3434 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3435
3436         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3437         hash and why.
3438         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3439         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3440
3441 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3442
3443         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3444         * psympriv.h (add_psymbol_to_list): Move comment here and update
3445         it.
3446
3447 2019-09-29  Tom de Vries  <tdevries@suse.de>
3448
3449         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3450         Use $tmpdir/$(basename "$output_file").dwz instead of
3451         "${output_file}.dwz".
3452
3453 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3454
3455         PR gdb/25045
3456         * hppa-linux-nat.c: Include gdbarch.h.
3457
3458 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3459
3460         * blockframe.c (find_pc_partial_function): Change return type to bool.
3461         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3462         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3463         (stub_gnu_ifunc_resolve_name): Likewise.
3464         * symtab.c (compare_filenames_for_search): Likewise.
3465         (compare_glob_filenames_for_search): Likewise.
3466         (matching_obj_sections): Likewise.
3467         (symbol_matches_domain): Likewise.
3468         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3469         (find_line_pc): Change return type to bool.
3470         (find_line_pc_range): Likewise.
3471         (producer_is_realview): Likewise.
3472         * symtab.h (symbol_matches_domain): Likewise.
3473         (find_pc_partial_function): Likewise.
3474         (find_pc_line_pc_range): Likewise.
3475         (in_gnu_ifunc_stub): Likewise.
3476         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3477         (find_line_pc): Likewise.
3478         (find_line_pc_range): Likewise.
3479         (matching_obj_sections): Likewise.
3480         (find_line_symtab): Change out parameter to bool.
3481         (producer_is_realview): Change return type to bool.
3482         (compare_filenames_for_search): Likewise.
3483         (compare_glob_filenames_for_search): Likewise.
3484
3485 2019-09-26  Tom Tromey  <tom@tromey.com>
3486
3487         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3488         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3489         * gdb_usleep.h: Remove.
3490         * gdb_usleep.c: Remove.
3491         * utils.c: Don't include gdb_usleep.h.
3492
3493 2019-09-26  Tom Tromey  <tromey@adacore.com>
3494
3495         * python/py-type.c (type_to_type_object): Call check_typedef
3496         for stub types.
3497
3498 2019-09-26  Tom Tromey  <tom@tromey.com>
3499
3500         * utils.h (initialize_utils): Don't declare.
3501         * top.c (gdb_init): Don't call initialize_utils.
3502         * utils.c (initialize_utils): Remove.  Move contents...
3503         (_initialize_utils): ... here.
3504
3505 2019-09-25  Tom Tromey  <tom@tromey.com>
3506
3507         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3508         * utils.h (make_hex_string): Don't declare.
3509         * utils.c (make_hex_string): Remove.
3510
3511 2019-09-24  Tom de Vries  <tdevries@suse.de>
3512
3513         PR gdb/23815
3514         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3515         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3516
3517 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3518
3519         * NEWS: Mention new simulator port for PRU.
3520
3521 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3522
3523         * ada-exp.y (write_object_remaining): Update.
3524         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3525         and eliminate the static buffer.
3526         (ada_decode_symbol): Update.
3527         (ada_la_decode): Update.
3528         (ada_sniff_from_mangled_name): Update.
3529         (is_valid_name_for_wild_match): Update.
3530         (ada_lookup_name_info::matches): Update and simplify.
3531         (name_matches_regex): Update.
3532         (ada_add_global_exceptions): Update.
3533         * ada-lang.h (ada_decode): Update signature.
3534         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3535         * dwarf-index-write.c (debug_names::insert): Update.
3536
3537 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3538
3539         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3540         formatting.
3541
3542 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3543
3544         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3545         Change "nonzero" to "true" in documentation.
3546
3547 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3548
3549         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3550         (_initialize_darwin_solib): Don't set
3551         darwin_so_ops.lookup_lib_global_symbol.
3552         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3553         set_gdbarch_iterate_over_objfiles_in_search_order.
3554         (elf_lookup_lib_symbol): Rename to...
3555         (svr4_iterate_over_objfiles_in_search_order): this, and update
3556         to iterate semantics.
3557         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3558         * solib.c (solib_global_lookup): Remove.
3559         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3560         (solib_global_lookup): Remove.
3561         * symtab.c (lookup_global_or_static_symbol): Remove call to
3562         solib_global_lookup.
3563
3564 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3565
3566         * NEWS: Move entries about default MI version now being
3567         version 3, and about the GDB/MI fix for multi-location
3568         breakpoints to the "since GDB 8.3" section.
3569
3570 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3571
3572         GDB 8.3.1 released.
3573
3574 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3575
3576         * NEWS: Mention that Cell/B.E. debugging support was removed.
3577         * MAINTAINERS: Remove spu target.
3578
3579         * config/djgpp/fnchange.lst: Remove entries for removed files.
3580
3581         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3582         spu-multiarch.o, and spu-tdep.o.
3583         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3584         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3585         spu-multiarch.c, and spu-tdep.c.
3586         * spu-linux-nat.c: Remove file.
3587         * spu-multiarch.c: Remove file.
3588         * spu-tdep.c: Remove file.
3589         * spu-tdep.h: Remove file.
3590         * solib-spu.c: Remove file.
3591         * solib-spu.h: Remove file.
3592
3593         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3594         * configure.nat (spu-linux): Remove.
3595         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3596         solib-multiarch.o from gdb_target_obs.
3597         (spu*-*-*): Remove.
3598
3599         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3600         feature flag.
3601         (ppc_linux_no_features): Update.
3602         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3603         Cell/B.E. support.
3604         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3605         (tdesc_powerpc_cell64l): Likewise.
3606         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3607         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3608         Cell/B.E. support.
3609         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3610         Do not include "features/rs6000/powerpc-cell32l.c" or
3611         "features/rs6000/powerpc-cell64l.c".
3612         (ppc_linux_spu_section): Remove.
3613         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3614         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3615         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3616         (ppc_linux_spe_context_lookup): Remove.
3617         (ppc_linux_spe_context_inferior_created): Remove.
3618         (ppc_linux_spe_context_solib_loaded): Remove.
3619         (ppc_linux_spe_context_solib_unloaded): Remove.
3620         (ppc_linux_spe_context): Remove.
3621         (struct ppu2spu_cache): Remove.
3622         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3623         (struct ppu2spu_data): Remove.
3624         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3625         ppu2spu_unwind): Remove.
3626         (ppc_linux_init_abi): Remove Cell/B.E. support.
3627         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3628
3629         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3630         (rs6000/powerpc-cell64l-expedite): Likewise
3631         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3632         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3633         rs6000/powerpc-cell64l.xml.
3634         * features/rs6000/powerpc-cell32l.xml: Remove.
3635         * features/rs6000/powerpc-cell64l.xml: Likewise.
3636         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3637         * features/rs6000/powerpc-cell64l.c: Likewise.
3638         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3639         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3640         * regformats/reg-spu.dat: Remove.
3641
3642         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3643         * corelow.c (struct spuid_list): Remove.
3644         (add_to_spuid_list): Remove.
3645         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3646         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3647         (remote_protocol_features): Remove associated entries.
3648         (_initialize_remote): No longer initialize them.
3649         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3650         * linux-nat.c (SPUFS_MAGIC): Remove.
3651         (linux_proc_xfer_spu): Remove.
3652         (spu_enumerate_spu_ids): Remove.
3653         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3654         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3655         (linux_make_corefile_notes): No longer call it.
3656
3657         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3658         (cooked_write_test): Likewise.
3659
3660 2019-09-20  Tom Tromey  <tom@tromey.com>
3661
3662         * NEWS: Mention case-sensitivity of TUI commands.
3663         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3664         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3665         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3666
3667 2019-09-20  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-source.c (tui_source_window::set_contents): Use
3670         make_unique_xstrdup.
3671         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3672         make_unique_xstrdup.
3673
3674 2019-09-20  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-data.c: Remove separator comments.
3677         * tui/tui-layout.c: Remove separator comments.
3678         * tui/tui-win.c: Remove separator comments.
3679         * tui/tui-wingeneral.c: Remove separator comments.
3680
3681 2019-09-20  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui.h (strcat_to_buf): Don't declare.
3684         * tui/tui.c (strcat_to_buf): Remove.
3685
3686 2019-09-20  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3689         from "fullname".
3690         * tui/tui-source.c (tui_source_window::set_contents)
3691         (tui_source_window::location_matches_p)
3692         (tui_source_window::maybe_update): Update.
3693
3694 2019-09-20  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3697         Update.
3698         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3699         prefix.
3700         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3701         (tui_data_window::line_from_reg_element_no)
3702         (tui_data_window::first_reg_element_no_inline)
3703         (tui_data_window::show_registers)
3704         (tui_data_window::show_register_group)
3705         (tui_data_window::display_registers_from)
3706         (tui_data_window::display_registers_from_line)
3707         (tui_data_window::first_data_item_displayed)
3708         (tui_data_window::delete_data_content_windows)
3709         (tui_data_window::erase_data_content)
3710         (tui_data_window::do_scroll_vertical)
3711         (tui_data_window::refresh_window)
3712         (tui_data_window::check_register_values): Update.
3713
3714 2019-09-20  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3717         (struct tui_locator_window) <full_name, proc_name>: Now
3718         std::string.
3719         * tui/tui-stack.c (tui_locator_window::make_status_line)
3720         (tui_locator_window::set_locator_fullname)
3721         (tui_locator_window::set_locator_info): Update.
3722         * tui/tui-source.c (tui_source_window::set_contents)
3723         (tui_source_window::showing_source_p): Update.
3724
3725 2019-09-20  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3728         Don't call tui_locator_win_info_ptr.
3729
3730 2019-09-20  Tom Tromey  <tom@tromey.com>
3731
3732         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3733
3734 2019-09-20  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3737         height for locator.
3738         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3739         * tui/tui-layout.c (show_source_disasm_command, show_data)
3740         (show_source_or_disasm_and_command): Use 1 as height for locator.
3741
3742 2019-09-20  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui.c (tui_enable): Update.
3745         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3746         Update.
3747         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3748         Update.
3749         * tui/tui-data.c (win_resized): Now bool.
3750         (tui_win_resized): Return bool.
3751         (tui_set_win_resized_to): Accept a bool.
3752
3753 2019-09-20  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3756         Change type of "refresh_values_only".
3757         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3758         type of "refresh_values_only".
3759
3760 2019-09-20  Tom Tromey  <tom@tromey.com>
3761
3762         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3763         std::string.
3764         (tui_disassemble): Add "pos" parameter.
3765         (tui_disasm_window::set_contents): Simplify.
3766
3767 2019-09-20  Tom Tromey  <tom@tromey.com>
3768
3769         * tui/tui-winsource.h (struct tui_source_window_base)
3770         <show_source_content>: Now private.
3771         * tui/tui-winsource.c
3772         (tui_source_window_base::show_source_content): Don't handle empty
3773         content case.
3774
3775 2019-09-20  Tom Tromey  <tom@tromey.com>
3776
3777         * tui/tui-layout.c (show_source_disasm_command)
3778         (show_source_or_disasm_and_command): Don't call
3779         show_source_content.
3780
3781 2019-09-20  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3784         Declare.
3785         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3786         from tui_make_status_line.
3787         (tui_locator_window::rerender): Update.
3788
3789 2019-09-20  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3792         (tui_locator_window::rerender): Update.
3793
3794 2019-09-20  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-winsource.h (struct tui_source_window_base)
3797         <~tui_source_window_base>: Don't declare.
3798         <fullname>: Remove.
3799         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3800         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3801         member.
3802         * tui/tui-source.c (tui_source_window::set_contents): Update.
3803         (tui_source_window::location_matches_p)
3804         (tui_source_window::maybe_update): Update.
3805
3806 2019-09-20  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-winsource.h (~tui_source_element): Remove.
3809         (tui_source_element): Update.
3810         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3811         * tui/tui-winsource.c (tui_show_source_line): Update.
3812         * tui/tui-source.c (tui_source_window::set_contents): Update.
3813         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3814
3815 2019-09-20  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3818         declare.
3819         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3820         tui_clear_source_windows_detail.
3821         * tui/tui-winsource.h (struct tui_source_window_base)
3822         <clear_detail>: Don't declare.
3823         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3824         Remove.
3825         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3826
3827 2019-09-20  Tom Tromey  <tromey@adacore.com>
3828
3829         PR ada/24919:
3830         * block.c (contained_in): Fix final return value.
3831
3832 2019-09-20  Alan Modra  <amodra@gmail.com>
3833
3834         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3835         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3836         (read_indirect_string_from_dwz): Use bfd accessor.
3837         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3838         * machoread.c (macho_symfile_read_all_oso): Likewise.
3839         * solib.c (solib_bfd_open): Likewise.
3840
3841 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3842
3843         * eval.c: Move declaration of overload_resolution to...
3844         * value.h: ...here.
3845
3846 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3847
3848         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3849         * arm-linux-tdep.c: Likewise.
3850         * arm-nbsd-nat.c: Likewise.
3851         * arm-tdep.h: Declare arm_apcs_32.
3852         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3853
3854 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3855
3856         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3857         * dwarf2read.h: Declare dwarf_always_disassemble.
3858
3859 2019-09-19  Tom de Vries  <tdevries@suse.de>
3860
3861         PR gdb/25009
3862         * source-cache.c (source_cache::ensure): Catch exception thrown during
3863         construction of the highlighter.
3864
3865 2019-09-18  Alan Modra  <amodra@gmail.com>
3866
3867         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3868         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3869         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3870         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3871         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3872         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3873         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3874         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3875         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3876         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3877         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3878         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3879         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3880         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3881         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3882         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3883         * mi/mi-interp.c: Update throughout for bfd section macro and
3884         function changes.
3885         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3886         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3887
3888 2019-09-18  Tom Tromey  <tom@tromey.com>
3889
3890         * NEWS: Add entry.
3891         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3892         call rl_initialize.
3893         (tui_enable): Do not call rl_initialize.
3894
3895 2019-09-18  Christian Groessler  <chris@groessler.org>
3896
3897         * alpha-linux-nat.c: Include gdbarch.h.
3898
3899 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3900
3901         * ui-file.c: Include cli/cli-style.h.
3902         (term_cli_styling): Remove cli_styling declaration.
3903
3904 2019-09-18  Alan Modra  <amodra@gmail.com>
3905
3906         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3907         to bfd_asymbol_section.
3908
3909 2019-09-18  Alan Modra  <amodra@gmail.com>
3910
3911         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3912         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3913         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3914
3915 2019-09-18  Alan Modra  <amodra@gmail.com>
3916
3917         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3918         * spu-linux-nat.c (spu_bfd_open): Likewise.
3919
3920 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3921
3922         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3923         to bool to match definition in dwarf2read.c.
3924
3925 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3926
3927         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3928         (print_signatures): Likewise.
3929         (trust_pad_over_xvs): Likewise.
3930         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3931         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3932         * arm-linux-nat.c (arm_apcs_32): Likewise.
3933         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3934         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3935         * arm-tdep.c (arm_debug): Likewise.
3936         (arm_apcs_32): Likewise.
3937         * auto-load.c (debug_auto_load): Likewise.
3938         (auto_load_gdb_scripts): Likewise.
3939         (global_auto_load): Likewise.
3940         (auto_load_local_gdbinit): Likewise.
3941         (auto_load_local_gdbinit_loaded): Likewise.
3942         * auto-load.h (global_auto_load): Likewise.
3943         (auto_load_local_gdbinit): Likewise.
3944         (auto_load_local_gdbinit_loaded): Likewise.
3945         * breakpoint.c (disconnected_dprintf): Likewise.
3946         (breakpoint_proceeded): Likewise.
3947         (automatic_hardware_breakpoints): Likewise.
3948         (always_inserted_mode): Likewise.
3949         (target_exact_watchpoints): Likewise.
3950         (_initialize_breakpoint): Update.
3951         * breakpoint.h (target_exact_watchpoints): Change to bool.
3952         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3953         * cli/cli-cmds.c (trace_commands): Likewise.
3954         * cli/cli-cmds.h (trace_commands): Likewise.
3955         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3956         to bool*.
3957         * cli/cli-logging.c (logging_overwrite): Change to bool.
3958         (logging_redirect): Likewise.
3959         (debug_redirect): Likewise.
3960         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3961         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3962         to bool.
3963         <boolean_option_def>: Update.
3964         (struct flag_option_def): Change default type of Context to bool
3965         from int.
3966         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3967         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3968         (get_setshow_command_value_string): Likewise.
3969         * cli/cli-style.c (cli_styling): Change to bool.
3970         (source_styling): Likewise.
3971         * cli/cli-style.h (source_styling): Likewise.
3972         (cli_styling): Likewise.
3973         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3974         to bool.
3975         * command.h (var_types): Update comment.
3976         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3977         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3978         bool.
3979         (debug_compile_cplus_scopes): Likewise.
3980         * compile/compile-internal.h (compile_debug): Likewise.
3981         * compile/compile.c (compile_debug): Likewise.
3982         (struct compile_options) <raw>: Likewise.
3983         * cp-support.c (catch_demangler_crashes): Likewise.
3984         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3985         (usr_cmd_cris_dwarf2_cfi): Likewise.
3986         * csky-tdep.c (csky_debug): Likewise.
3987         * darwin-nat.c (enable_mach_exceptions): Likewise.
3988         * dcache.c (dcache_enabled_p): Likewise.
3989         * defs.h (info_verbose): Likewise.
3990         * demangle.c (demangle): Likewise.
3991         (asm_demangle): Likewise.
3992         * dwarf-index-cache.c (debug_index_cache): Likewise.
3993         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3994         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3995         * dwarf2read.c (check_physname): Likewise.
3996         (use_deprecated_index_sections): Likewise.
3997         (dwarf_always_disassemble): Likewise.
3998         * eval.c (overload_resolution): Likewise.
3999         * event-top.c (set_editing_cmd_var): Likewise.
4000         (exec_done_display_p): Likewise.
4001         * event-top.h (set_editing_cmd_var): Likewise.
4002         (exec_done_display_p): Likewise.
4003         * exec.c (write_files): Likewise.
4004         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4005         (debug_fbsd_nat): Likewise.
4006         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4007         Likewise.
4008         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4009         <backtrace_past_entry> Likewise.
4010         * gdb-demangle.h (demangle): Likewise.
4011         (asm_demangle): Likewise.
4012         * gdb_bfd.c (bfd_sharing): Likewise.
4013         * gdbcore.h (write_files): Likewise.
4014         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4015         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4016         * gdbthread.h (print_thread_events): Likewise.
4017         * gdbtypes.c (opaque_type_resolution): Likewise.
4018         (strict_type_checking): Likewise.
4019         * gnu-nat.c (gnu_debug_flag): Likewise.
4020         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4021         * guile/scm-param.c (pascm_variable): Add boolval.
4022         (add_setshow_generic): Update.
4023         (pascm_param_value): Update.
4024         (pascm_set_param_value_x): Update.
4025         * hppa-tdep.c (hppa_debug): Change to bool..
4026         * infcall.c (may_call_functions_p): Likewise.
4027         (coerce_float_to_double_p): Likewise.
4028         (unwind_on_signal_p): Likewise.
4029         (unwind_on_terminating_exception_p): Likewise.
4030         * infcmd.c (startup_with_shell): Likewise.
4031         * inferior.c (print_inferior_events): Likewise.
4032         * inferior.h (startup_with_shell): Likewise.
4033         (print_inferior_events): Likewise.
4034         * infrun.c (step_stop_if_no_debug): Likewise.
4035         (detach_fork): Likewise.
4036         (debug_displaced): Likewise.
4037         (disable_randomization): Likewise.
4038         (non_stop): Likewise.
4039         (non_stop_1): Likewise.
4040         (observer_mode): Likewise.
4041         (observer_mode_1): Likewise.
4042         (set_observer_mode): Update.
4043         (sched_multi): Change to bool.
4044         * infrun.h (debug_displaced): Likewise.
4045         (sched_multi): Likewise.
4046         (step_stop_if_no_debug): Likewise.
4047         (non_stop): Likewise.
4048         (disable_randomization): Likewise.
4049         * linux-tdep.c (use_coredump_filter): Likewise.
4050         (dump_excluded_mappings): Likewise.
4051         * linux-thread-db.c (auto_load_thread_db): Likewise.
4052         (check_thread_db_on_load): Likewise.
4053         * main.c (captured_main_1): Update.
4054         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4055         xx2_opt, boolean_opt>: Change to bool.
4056         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4057         * maint.c (maintenance_profile_p): Likewise.
4058         (per_command_time): Likewise.
4059         (per_command_space): Likewise.
4060         (per_command_symtab): Likewise.
4061         * memattr.c (inaccessible_by_default): Likewise.
4062         * mi/mi-main.c (mi_async): Likewise.
4063         (mi_async_1): Likewise.
4064         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4065         * nat/fork-inferior.h (startup_with_shell): Likewise.
4066         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4067         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4068         * nios2-tdep.c (nios2_debug): Likewise.
4069         * or1k-tdep.c (or1k_debug): Likewise.
4070         * parse.c (parser_debug): Likewise.
4071         * parser-defs.h (parser_debug): Likewise.
4072         * printcmd.c (print_symbol_filename): Likewise.
4073         * proc-api.c (procfs_trace): Likewise.
4074         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4075         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4076         (set_parameter_value): Update.
4077         (add_setshow_generic): Update.
4078         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4079         to bool*.
4080         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4081         int*.
4082         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4083         * record-btrace.c (record_btrace_target::store_registers): Update.
4084         * record-full.c (record_full_memory_query): Change to bool.
4085         (record_full_stop_at_limit): Likewise.
4086         * record-full.h (record_full_memory_query): Likewise.
4087         * remote-notif.c (notif_debug): Likewise.
4088         * remote-notif.h (notif_debug): Likewise.
4089         * remote.c (use_range_stepping): Likewise.
4090         (interrupt_on_connect): Likewise.
4091         (remote_break): Likewise.
4092         * ser-tcp.c (tcp_auto_retry): Likewise.
4093         * ser-unix.c (serial_hwflow): Likewise.
4094         * skip.c (debug_skip): Likewise.
4095         * solib-aix.c (solib_aix_debug): Likewise.
4096         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4097         (spu_auto_flush_cache_p): Likewise.
4098         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4099         Likewise.
4100         (struct info_print_options) <quiet>: Likewise.
4101         * symfile-debug.c (debug_symfile): Likewise.
4102         * symfile.c (auto_solib_add): Likewise.
4103         (separate_debug_file_debug): Likewise.
4104         * symfile.h (auto_solib_add): Likewise.
4105         (separate_debug_file_debug): Likewise.
4106         * symtab.c (basenames_may_differ): Likewise.
4107         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4108         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4109         (struct info_types_options) <quiet>: Likewise.
4110         * symtab.h (demangle): Likewise.
4111         (basenames_may_differ): Likewise.
4112         * target-dcache.c (stack_cache_enabled_1): Likewise.
4113         (code_cache_enabled_1): Likewise.
4114         * target.c (trust_readonly): Likewise.
4115         (may_write_registers): Likewise.
4116         (may_write_memory): Likewise.
4117         (may_insert_breakpoints): Likewise.
4118         (may_insert_tracepoints): Likewise.
4119         (may_insert_fast_tracepoints): Likewise.
4120         (may_stop): Likewise.
4121         (auto_connect_native_target): Likewise.
4122         (target_stop_and_wait): Update.
4123         (target_async_permitted): Change to bool.
4124         (target_async_permitted_1): Likewise.
4125         (may_write_registers_1): Likewise.
4126         (may_write_memory_1): Likewise.
4127         (may_insert_breakpoints_1): Likewise.
4128         (may_insert_tracepoints_1): Likewise.
4129         (may_insert_fast_tracepoints_1): Likewise.
4130         (may_stop_1): Likewise.
4131         * target.h (target_async_permitted): Likewise.
4132         (may_write_registers): Likewise.
4133         (may_write_memory): Likewise.
4134         (may_insert_breakpoints): Likewise.
4135         (may_insert_tracepoints): Likewise.
4136         (may_insert_fast_tracepoints): Likewise.
4137         (may_stop): Likewise.
4138         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4139         (make_thread_apply_all_options_def_group): Change argument from int*
4140         to bool*.
4141         (thread_apply_all_command): Update.
4142         (print_thread_events): Change to bool.
4143         * top.c (confirm): Likewise.
4144         (command_editing_p): Likewise.
4145         (history_expansion_p): Likewise.
4146         (write_history_p): Likewise.
4147         (info_verbose): Likewise.
4148         * top.h (confirm): Likewise.
4149         (history_expansion_p): Likewise.
4150         * tracepoint.c (disconnected_tracing): Likewise.
4151         (circular_trace_buffer): Likewise.
4152         * typeprint.c (print_methods): Likewise.
4153         (print_typedefs): Likewise.
4154         * utils.c (debug_timestamp): Likewise.
4155         (sevenbit_strings): Likewise.
4156         (pagination_enabled): Likewise.
4157         * utils.h (sevenbit_strings): Likewise.
4158         (pagination_enabled): Likewise.
4159         * valops.c (overload_resolution): Likewise.
4160         * valprint.h (struct value_print_options) <prettyformat_arrays,
4161         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4162         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4163         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4164         Likewise.
4165         * windows-nat.c (new_console): Likewise.
4166         (cygwin_exceptions): Likewise.
4167         (new_group): Likewise.
4168         (debug_exec): Likewise.
4169         (debug_events): Likewise.
4170         (debug_memory): Likewise.
4171         (debug_exceptions): Likewise.
4172         (useshell): Likewise.
4173         * windows-tdep.c (maint_display_all_tib): Likewise.
4174         * xml-support.c (debug_xml): Likewise.
4175
4176 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4177
4178         * source.c (prepare_path_for_appending): New function.
4179         (openp): Make use of new function.
4180         (find_and_open_source): Search for the compilation directory and
4181         source file as a relative path beneath the directory search path.
4182
4183 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4184
4185         * source-cache.c (source_cache::get_line_charpos): Catch
4186         exceptions and return false, this matches the behaviour documented
4187         in the header file.
4188
4189 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4190
4191         * ada-tasks.c (info_task): Remove quoting of the task's name.
4192
4193 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4194
4195         * symfile.c (auto_solib_add): Replace comment with a reference
4196         to the header file.
4197
4198 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4199
4200         * NEWS: Mention that gdb can now be compiled with Python 3
4201         on Windows.
4202
4203 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * maint.c (maint_print_section_data::maint_print_section_data):
4206         Force use of 'float log10 (float)' by casting the argument to
4207         float.
4208
4209 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * maint.c: Add 'cmath' include.
4212         (struct maint_print_section_data): New structure.
4213         (print_section_index): New function.
4214         (print_bfd_section_info): Add header comment, small whitespace
4215         cleanup, and update to call new print_section_index function.
4216         (print_objfile_section_info): Likewise.
4217         (maint_obj_section_from_bfd_section): New function.
4218         (print_bfd_section_info_maybe_relocated): New function.
4219         (maintenance_info_sections): Add header comment, always use
4220         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4221
4222 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4225         inner scope, add check that the objfile has psymtabs before
4226         checking psymtabs_addrmap.
4227         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4228
4229 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4230
4231         * NEWS: Announce that Ada task names are now shown at more places,
4232         and between quotes (except in info task output).
4233         * gdb/ada-tasks.c (task_to_str): New function.
4234         (display_current_task_id): Call task_to_str.
4235         (task_command_1): Likewise.
4236         (print_ada_task_info): In non-mi mode, Properly align headers and data
4237         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4238
4239 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4240
4241         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4242         prstatus.pr_lwp.pr_info instead of making it up.
4243
4244 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4245
4246         * auto-load.c (auto_load_expand_dir_vars): Update.
4247         * defs.h (gdb_datadir): Change to std::string.
4248         (python_libdir): Likewise.
4249         (relocate_gdb_directory): Change return type to std::string.
4250         * guile/guile.c (gdbscm_data_directory): Update.
4251         (initialize_scheme_side): Update.
4252         * jit.c (jit_reader_dir): Change to std::string.
4253         (jit_reader_load_command): Update.
4254         * main.c (gdb_datadir): Change to std::string.
4255         (python_libdir): Likewise.
4256         (set_gdb_data_directory): Update.
4257         (relocate_path): Change to return std::string.
4258         (relocate_gdb_directory): Change to return std::string.
4259         (relocate_gdbinit_path_maybe_in_datadir): Update.
4260         (captured_main_1): Update.
4261         * python/python.c (do_start_initialization): Update.
4262         * top.c (show_gdb_datadir): Update.
4263         * xml-syscall.c (xml_init_syscalls_info): Update.
4264         (init_syscalls_info): Update.
4265
4266 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4267
4268         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4269         out of get_init_files.
4270         (get_init_files): Update.
4271
4272 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4273
4274         * main.c (get_init_files): Change to use std::string.
4275         (captured_main_1): Update.
4276         (print_gdb_help): Update.
4277
4278 2019-09-11  Ali Tamur  <tamur@google.com>
4279
4280         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4281         implementation.
4282
4283 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4284
4285         * dbxread.c (read_dbx_symtab): Update.
4286         * dwarf2read.c (load_partial_dies): Update.
4287         * mdebugread.c (parse_partial_symbols): Update.
4288         (handle_psymbol_enumerators): Update.
4289         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4290         * psymtab.c (add_psymbol_to_bcache): Likewise.
4291         (add_psymbol_to_list): Likewise.
4292         * symtab.c (symbol_set_names): Likewise.
4293         * symtab.h (symbol_set_names): Likewise.
4294         * xcoffread.c (scan_xcoff_symtab): Update.
4295
4296 2019-09-11  Tom Tromey  <tom@tromey.com>
4297
4298         * symfile-mem.c (symbol_file_add_from_memory): Use
4299         bfd_set_filename.
4300         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4301         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4302
4303 2019-09-10  Tom Tromey  <tromey@adacore.com>
4304
4305         * dwarf-index-write.c (write_psymbols): Extend error message.
4306         (debug_names::insert): Add Ada code.
4307         (debug_names::write_psymbols): Remove Ada check.
4308         (debug_names) <m_string_obstack>: New member.
4309         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4310         (gdb_index_symbol_name_matcher::matches): Remove.
4311         (mapped_index_base::find_name_components_bounds): Add "lang"
4312         parameter.
4313         (mapped_index_base::build_name_components): Also split names
4314         according to Ada syntax.
4315         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4316         type of "match_callback".
4317         (check_match, check_find_bounds_finds)
4318         (dw2_expand_symtabs_matching): Update.
4319         (dw2_debug_names_iterator): Add new constructor.
4320         (dw2_debug_names_map_matching_symbols): New function.
4321         (dw2_debug_names_expand_symtabs_matching): Update.
4322         (dwarf2_debug_names_functions): Use
4323         dw2_debug_names_map_matching_symbols.
4324
4325 2019-09-10  Tom Tromey  <tromey@adacore.com>
4326
4327         * dwarf2read.c (dw2_get_file_names_reader): Add the
4328         CU's file name to the results.
4329
4330 2019-09-10  Tom Tromey  <tromey@adacore.com>
4331
4332         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4333         map_matching_symbols.  Update.
4334         * dwarf2read.c (dw2_map_matching_symbols): Update.
4335         * psymtab.c (match_partial_symbol): Change type; update.
4336         (psym_map_matching_symbols): Likewise.
4337         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4338         type; update.
4339         * symfile.h (struct quick_symbol_functions)
4340         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4341         Remove "match".
4342
4343 2019-09-10  Tom Tromey  <tromey@adacore.com>
4344
4345         * psymtab.c (map_block): Remove.
4346         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4347         * symtab.c (iterate_over_symbols_terminated): New function.
4348         * symtab.c (iterate_over_symbols_terminated): Declare.
4349
4350 2019-09-10  Tom Tromey  <tromey@adacore.com>
4351
4352         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4353         * language.h (struct language_defn) <la_iterate_over_symbols>:
4354         Return bool.
4355         * symtab.c (iterate_over_symbols): Return bool.
4356         * symtab.h (iterate_over_symbols): Return bool.
4357
4358 2019-09-10  Tom Tromey  <tromey@adacore.com>
4359
4360         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4361         (add_nonlocal_symbols): Update.
4362         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4363         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4364         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4365         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4366         Change type of "callback".  Remove "data".
4367
4368
4369 2019-09-09  Ali Tamur  <tamur@google.com>
4370
4371         * dwarf2read.c (comp_unit_head): Update comment.
4372         (dwarf2_dwo_name): New function declaration.
4373         (dwarf_unit_type_name): New function declaration.
4374         (read_comp_unit_head): Add support for new compilation units,
4375         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4376         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4377         (currently named as "signature") in their header. Also clarify error
4378         messages.
4379         (lookup_dwo_id): New function. Returns the dwo id of the given
4380         compile unit.
4381         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4382         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4383         functions.
4384         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4385         (dwarf2_dwo_name): Get the dwo name if present.
4386         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4387         purposes.
4388
4389 2019-09-09  Tom Tromey  <tom@tromey.com>
4390
4391         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4392
4393 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4394
4395         * python/python.c (do_start_initialization): Make progname_copy static,
4396         to avoid a leak report.
4397
4398 2019-09-08  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4401
4402 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4403
4404         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4405         Change type to gdb::optional<block_enum>.
4406         (dw2_symtab_iter_init): Change block_index parameter type
4407         to gdb::optional<block_enum>.
4408         (dw2_lookup_symbol): Change block_index parameter
4409         type to block_enum.c
4410         (dw2_debug_names_lookup_symbol): Likewise.
4411         * psymtab.c (psym_lookup_symbol): Likewise.
4412         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4413         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4414         Likewise.
4415
4416 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4417
4418         * defs.h (relocate_gdb_directory): Change int to bool in
4419         signature and rename flag to relocatable.
4420         * main.c (relocate_path): Likewise.
4421         (relocate_gdb_directory): Likewise.
4422
4423 2019-09-06  Alan Modra  <amodra@gmail.com>
4424
4425         * coffread.c (coff_symfile_read): Constify filename variable.
4426         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4427         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4428         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4429         * solib.c (reload_shared_libraries_1): Likewise.
4430         * symfile.c (reread_symbols): Likewise.
4431         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4432         * solib-darwin.c (darwin_bfd_open): Likewise.
4433         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4434
4435 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4438         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4439
4440 2019-09-03  Tom Tromey  <tromey@adacore.com>
4441
4442         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4443         types.
4444         (has_negatives): Unbias a range type bound.
4445         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4446         * gdbtypes.c (operator==): Handle new field.
4447         (create_range_type): Add "bias" parameter.
4448         (create_static_range_type, resolve_dynamic_range): Update.
4449         * gdbtypes.h (struct range_bounds) <bias>: New member.
4450         (create_range_type): Add bias parameter.
4451         * printcmd.c (print_scalar_formatted): Unbias range types.
4452         * value.c (unpack_long): Unbias range types.
4453         (pack_long): Bias range types.
4454
4455 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4456
4457         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4458         probe arguments.
4459
4460 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4461
4462         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4463         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4464         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4465         (compile_probe_arg): Likewise.
4466         * probe.h (get_argument_count): Likewise.
4467         * solib-svr4.c (solib_event_probe_action): Likewise.
4468         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4469
4470 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4471
4472         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4473         code to here...
4474         (svr4_create_solib_event_breakpoints): ...from here.
4475
4476 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4477
4478         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4479         suffix from warning message.
4480
4481 2019-08-30  Tom Tromey  <tom@tromey.com>
4482
4483         * tui/tui-winsource.h (struct tui_source_window_base)
4484         <refresh_all>: Don't declare.
4485         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4486         Remove.
4487         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4488         tui_show_locator_content.
4489         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4490         declare.
4491         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4492         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4493         declare.
4494
4495 2019-08-30  Tom Tromey  <tom@tromey.com>
4496
4497         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4498
4499 2019-08-30  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4502         Remove unnecessary forward declarations.
4503
4504 2019-08-30  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4507         rerender.
4508         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4509         tui_show_locator_content.
4510
4511 2019-08-30  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4514         (tui_locator_window::rerender): Rewrite using body of previous
4515         tui_show_locator_content.
4516
4517 2019-08-30  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4520         set_locator_fullname>: New methods.
4521         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4522         Rename from tui_set_locator_fullname.
4523         (tui_locator_window::set_locator_info): Rename from
4524         tui_set_locator_info.  Return bool.
4525         (tui_update_locator_fullname, tui_show_frame_info): Update.
4526
4527 2019-08-30  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4530
4531 2019-08-30  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4534         call touchwin.
4535
4536 2019-08-30  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-wingeneral.c (box_win): Assume win_info and
4539         win_info->handle cannot be NULL.
4540
4541 2019-08-30  Tom Tromey  <tom@tromey.com>
4542
4543         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4544         refresh_window>: Declare.
4545         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4546         resize.
4547         (tui_data_item_window::rerender): Rename from
4548         tui_display_register.
4549         (tui_data_item_window::refresh_window): New method.
4550         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4551         no-op.
4552
4553 2019-08-30  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4556         regs_column_count, current_group>: Move later.  Now private.
4557         <get_current_group>: New method.
4558         * tui/tui-regs.c (tui_reg_command): Update.
4559         * tui/tui-layout.c (tui_set_layout): Update.
4560
4561 2019-08-30  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4564         (tui_data_window::rerender): Don't call
4565         check_and_display_highlight_if_needed.
4566         (tui_data_window::refresh_all): Remove call to
4567         erase_data_content.
4568
4569 2019-08-30  Tom Tromey  <tom@tromey.com>
4570
4571         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4572         (tui_data_window::display_registers_from)
4573         (tui_data_window::display_reg_element_at_line)
4574         (tui_data_window::display_registers_from_line): Remove checks of
4575         "empty".
4576
4577 2019-08-30  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4580         Don't declare.
4581         * tui/tui-regs.c (tui_data_window::show_registers): Call
4582         rerender.
4583         (tui_data_window::rerender): Rename from display_all_data.
4584         (tui_data_window::rerender): Remove old implementation.
4585
4586 2019-08-30  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4589         text.
4590         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4591
4592 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4593             Sergio Durigan Junior  <sergiodj@redhat.com>
4594
4595         PR win32/24284
4596         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4597
4598 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4601         when searching for types.
4602
4603 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * f-lang.c (f_language_defn): Use f_print_typedef.
4606         * f-lang.h (f_print_typedef): Declare.
4607         * f-typeprint.c (f_print_typedef): Define.
4608
4609 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4610
4611         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4612
4613 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * cli/cli-utils.c (info_print_options_defs): Delete.
4616         (make_info_print_options_def_group): Delete.
4617         (extract_info_print_options): Delete.
4618         (info_print_command_completer): Delete.
4619         (info_print_args_help): Add extra parameter, and optionally
4620         include text about -n flag.
4621         * cli/cli-utils.h (struct info_print_options): Delete.
4622         (extract_info_print_options): Delete declaration.
4623         (info_print_command_completer): Delete declaration.
4624         (info_print_args_help): Add extra parameter, extend header
4625         comment.
4626         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4627         search_symbols.
4628         * stack.c (struct info_print_options): New type.
4629         (info_print_options_defs): New file scoped variable.
4630         (make_info_print_options_def_group): New static function.
4631         (info_print_command_completer): New static function.
4632         (info_locals_command): Update to use new local functions.
4633         (info_args_command): Likewise.
4634         (_initialize_stack): Add extra parameter to calls to
4635         info_print_args_help.
4636         * symtab.c (search_symbols): Add extra parameter, use this to
4637         possibly excluse non-debug symbols.
4638         (symtab_symbol_info): Add extra parameter, which is passed on to
4639         search_symbols.
4640         (struct info_print_options): New type.
4641         (info_print_options_defs): New file scoped variable.
4642         (make_info_print_options_def_group): New static function.
4643         (info_print_command_completer): New static function.
4644         (info_variables_command): Update to use local functions, and pass
4645         extra parameter through to symtab_symbol_info.
4646         (info_functions_command): Likewise.
4647         (info_types_command): Pass additional argument through to
4648         symtab_symbol_info.
4649         (rbreak_command): Pass extra argument to search_symbols.
4650         (_initialize_symtab): Add extra arguments for calls to
4651         info_print_args_help, and update help text for 'info variables',
4652         'whereis', and 'info functions' commands.
4653         * symtab.h (search_symbols): Add extra argument to declaration.
4654         * NEWS: Mention new flags.
4655
4656 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4657
4658         * symtab.c (lookup_static_symbol): Call the new function (and move
4659         it down to be next to lookup_global_symbol).
4660         (struct global_sym_lookup_data): Add block_enum member and rename to...
4661         (struct global_or_static_sym_lookup_data): ...this.
4662         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4663         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4664         (lookup_symbol_global_or_static_iterator_cb): ...this.
4665         (lookup_global_or_static_symbol): New function.
4666         (lookup_global_symbol): Call new function.
4667
4668 2019-08-26  Tom de Vries  <tdevries@suse.de>
4669
4670         PR c++/24852
4671         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4672         when pc_probe.prob == NULL.
4673
4674 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4675
4676         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4677         variable symbol_linkage to symbol_linkage_.
4678
4679 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4680
4681         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4682         represent whether the symbol is static, dynamic, or we don't
4683         know.
4684
4685 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4686
4687         * gdb/rx-tdep.c (rx_register_names): New.
4688         (rx_register_name): Delete.
4689         (rx_psw_type): Delete.
4690         (rx_fpsw_type): Delete.
4691         (rx_register_type): Delete.
4692         (rx_gdbarch_init): Convert target-descriptions.
4693         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4694         * gdb/features/Makefile: Add rx.xml.
4695         * gdb/features/rx.xml: New.
4696         * gdb/features/rx.c: Generated.
4697         * gdb/NEWS: Mention target description support.
4698
4699 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4700
4701         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4702         *slot_ptr.
4703
4704 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4705
4706         * configure.ac: Don't check for 'dlfcn.h' (moved to
4707         gdbsupport/common.m4).
4708         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4709         'gdbsupport/'.
4710         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4711         * compile/compile-c-support.c: Include
4712         'gdbsupport/gdb-dlfcn.h'.
4713         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4714         * gdb-dlfcn.c: Move to...
4715         * gdbsupport/gdb-dlfcn.c: ... here.
4716         * gdb-dlfcn.h: Move to...
4717         * gdbsupport/gdb-dlfcn.h: ... here.
4718
4719 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4720
4721         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4722         the offset field signed.
4723
4724 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4725
4726         * python/lib/gdb/__init__.py (_execute_file): New function.
4727         * python/python.c (python_run_simple_file): Call gdb._execute_file
4728         on Windows.
4729
4730 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4733         all uses as this was never set to anything but a zero value.
4734
4735 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4736
4737         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4738
4739 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4740
4741         * tui/tui-data.h (tui_gen_win_info): Add an =default
4742         move constructor, required by some GCC versions.
4743
4744 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4745
4746         * go32-nat.c (go32_sysinfo): Add hygon_p.
4747
4748 2019-08-20  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4751         line_from_reg_element_no, first_reg_element_no_inline,
4752         display_all_data, delete_data_content_windows,
4753         erase_data_content>: Now private.
4754
4755 2019-08-20  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4758         (tui_unhighlight_win, tui_highlight_win)
4759         (tui_win_info::make_window): Update.
4760         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4761
4762 2019-08-20  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4765         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4766         (MAX_PID_WIDTH): Move to tui-stack.c.
4767         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4768         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4769         (MAX_PID_WIDTH): Move from tui-data.h.
4770
4771 2019-08-20  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4774         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4775         (box_win): Update.
4776         (tui_gen_win_info::make_window): Rename from tui_make_window.
4777         (tui_win_info::make_window): New method.
4778         (tui_gen_win_info::make_visible): Update.
4779         * tui/tui-source.c (tui_source_window::set_contents): Update.
4780         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4781         (tui_data_window::display_registers_from): Update.
4782         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4783         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4784         Declare.
4785         <can_box>: Remove.
4786         <title>: Remove.
4787         (struct tui_win_info) <make_window>: Declare.
4788         <can_box>: Now virtual.
4789         <title>: New member.
4790         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4791         * tui/tui-command.c (tui_cmd_window::resize): Update.
4792
4793 2019-08-20  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4796         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4797         (tui_data_window::check_register_values): Update.
4798
4799 2019-08-20  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-regs.h (struct tui_data_window): Use
4802         DISABLE_COPY_AND_ASSIGN.
4803         <regs_content>: Change type, removing unique_ptr.
4804         <tui_data_window>: Add move constructor.
4805         * tui/tui-regs.c (tui_data_window::show_registers)
4806         (tui_data_window::show_register_group)
4807         (tui_data_window::display_registers_from)
4808         (tui_data_window::display_registers_from)
4809         (tui_data_window::first_data_item_displayed)
4810         (tui_data_window::delete_data_content_windows)
4811         (tui_data_window::rerender, tui_data_window::refresh_window)
4812         (tui_data_window::check_register_values): Update.
4813
4814 2019-08-20  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4817         show_register_group>: Declare.
4818         (tui_show_register_group): Don't declare.
4819         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4820         tui_show_registers.
4821         (tui_data_window::show_register_group): Rename from
4822         tui_show_register_group.
4823         (tui_data_window::check_register_values, tui_reg_command):
4824         Update.
4825         * tui/tui-layout.c (tui_set_layout): Update.
4826
4827 2019-08-20  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4830         Declare.
4831         (tui_check_register_values): Don't declare.
4832         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4833         from tui_check_register_values.
4834         * tui/tui-hooks.c (tui_register_changed): Update.
4835
4836 2019-08-20  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-regs.c (tui_reg_layout): Move later.
4839         (tui_show_registers): Don't enable TUI mode or change layout.
4840
4841 2019-08-20  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-regs.h (struct tui_data_item_window)
4844         <~tui_data_item_window>: Remove.
4845         <content>: Now a unique_xmalloc_ptr.
4846         * tui/tui-regs.c (tui_register_format): Return a
4847         unique_xmalloc_ptr.
4848         (tui_get_register): Update.
4849         (~tui_data_item_window): Remove.
4850         (tui_data_window::display_registers_from, tui_display_register):
4851         Update.
4852         * tui/tui-io.h (tui_expand_tabs): Update.
4853         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4854         Remove "col" parameter.
4855
4856 2019-08-20  Tom Tromey  <tom@tromey.com>
4857
4858         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4859         field.
4860         * tui/tui-regs.c (~tui_data_item_window): Update.
4861
4862 2019-08-20  Tom Tromey  <tom@tromey.com>
4863
4864         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4865         earlier.
4866
4867 2019-08-20  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4870
4871 2019-08-20  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-source.h (struct tui_source_window): Update.
4874         * tui/tui-regs.c (tui_show_registers): Update.
4875         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4876         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4877         (NO_REGS_STRING): Remove defines.
4878
4879 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4880
4881         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4882         unnecessary thread walk if remote doesn't support the packet.
4883
4884 2019-08-19  Tom Tromey  <tromey@adacore.com>
4885
4886         * python/py-value.c (value_has_field): Fix indentation.
4887
4888 2019-08-19  Tom Tromey  <tromey@adacore.com>
4889
4890         * printcmd.c (do_one_display, info_display_command): Update.
4891         * block.h (contained_in): Return bool.  Add allow_nested
4892         parameter.
4893         * block.c (contained_in): Return bool.  Add allow_nested
4894         parameter.
4895
4896 2019-08-19  Tom Tromey  <tom@tromey.com>
4897
4898         * configure: Rebuild.
4899         * configure.ac: Disallow the combination of -static-libstdc++ and
4900         source highlight.
4901         * source-cache.c (get_language_name): Handle rust.
4902         (source_cache::get_source_lines): Ignore highlighting exceptions.
4903
4904 2019-08-16  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4907         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4908         (struct tui_source_window_base) <make_visible, refresh_window,
4909         resize>: Remove methods.
4910         <execution_info>: Remove field.
4911         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4912         (tui_show_source_line, tui_source_window_base)
4913         (~tui_source_window_base): Update.
4914         (tui_source_window_base::resize)
4915         (tui_source_window_base::make_visible)
4916         (tui_source_window_base::refresh_window): Remove.
4917         (tui_source_window_base::update_exec_info): Update.
4918         * tui/tui-source.c (tui_source_window::set_contents): Update.
4919         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4920
4921 2019-08-16  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4924         deprecated_query_hook.
4925
4926 2019-08-16  Tom Tromey  <tom@tromey.com>
4927
4928         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4929         (tui_update_source_windows_with_line): Update.
4930         * tui/tui-source.h (struct tui_source_window)
4931         <show_symtab_source>: Declare.
4932         (tui_show_symtab_source): Don't declare.
4933         * tui/tui-source.c (tui_show_symtab_source): Rename from
4934         tui_show_symtab_source.
4935
4936 2019-08-16  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-winsource.h (struct tui_source_window_base)
4939         <set_contents>: Declare.
4940         * tui/tui-winsource.c
4941         (tui_source_window_base::update_source_window_as_is): Update.
4942         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4943         Declare.
4944         (tui_set_source_content): Don't declare.
4945         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4946         tui_set_source_content.
4947         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4948         Declare.
4949         (tui_set_disassem_content): Don't declare.
4950         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4951         tui_set_disassem_content.
4952
4953 2019-08-16  Tom Tromey  <tom@tromey.com>
4954
4955         * tui/tui-winsource.h (struct tui_source_window_base)
4956         <update_breakpoint_info>: Declare.
4957         (tui_update_breakpoint_info): Don't declare.
4958         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4959         (tui_update_all_breakpoint_info): Update.
4960         (tui_source_window_base::update_breakpoint_info): Rename from
4961         tui_update_breakpoint_info.
4962         (tui_source_window_base::update_exec_info): Update.
4963
4964 2019-08-16  Tom Tromey  <tom@tromey.com>
4965
4966         * tui/tui-winsource.h (struct tui_source_window_base)
4967         <update_source_window>: Declare.
4968         (tui_update_source_window): Don't declare.
4969         * tui/tui-winsource.c
4970         (tui_source_window_base::update_source_window): Rename from
4971         tui_update_source_window.
4972         (tui_source_window_base::rerender): Update.
4973         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4974         * tui/tui-disasm.c (tui_show_disassem)
4975         (tui_show_disassem_and_update_source)
4976         (tui_disasm_window::maybe_update): Update.
4977
4978 2019-08-16  Tom Tromey  <tom@tromey.com>
4979
4980         * tui/tui-winsource.h (struct tui_source_window_base)
4981         <update_source_window_as_is>: Declare.
4982         (tui_update_source_window_as_is): Don't declare.
4983         * tui/tui-winsource.c (tui_update_source_window): Update
4984         (tui_source_window_base::update_source_window_as_is): Rename from
4985         tui_update_source_window_as_is.
4986         (tui_source_window_base::refill): Update.
4987         * tui/tui-source.c (tui_show_symtab_source): Update.
4988         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4989         Update.
4990
4991 2019-08-16  Tom Tromey  <tom@tromey.com>
4992
4993         * tui/tui-winsource.h (tui_update_source_window)
4994         (tui_update_source_window_as_is): Remove "noerror" parameter.
4995         * tui/tui-winsource.c (tui_update_source_window)
4996         (tui_update_source_window_as_is): Remove "noerror" parameter.
4997         (tui_update_source_windows_with_addr)
4998         (tui_update_source_windows_with_line)
4999         (tui_source_window_base::rerender)
5000         (tui_source_window_base::refill): Update.
5001         * tui/tui-source.h (tui_set_source_content)
5002         (tui_show_symtab_source): Remove "noerror" parameter.
5003         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5004         parameter.
5005         (tui_show_symtab_source): Likewise.
5006         (tui_source_window::maybe_update): Update.
5007         * tui/tui-disasm.c (tui_show_disassem)
5008         (tui_show_disassem_and_update_source)
5009         (tui_disasm_window::do_scroll_vertical)
5010         (tui_disasm_window::maybe_update): Update.
5011
5012 2019-08-16  Tom Tromey  <tom@tromey.com>
5013
5014         * tui/tui.c (tui_is_window_visible): Update.
5015         * tui/tui-wingeneral.c (tui_make_window)
5016         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5017         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5018         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5019         (tui_set_win_height_command, parse_scrolling_args): Update.
5020         * tui/tui-source.c (tui_source_window::style_changed): Update.
5021         * tui/tui-regs.c (tui_show_registers)
5022         (tui_data_window::first_data_item_displayed)
5023         (tui_data_window::delete_data_content_windows)
5024         (tui_check_register_values, tui_reg_command): Update.
5025         * tui/tui-disasm.c (tui_show_disassem): Update.
5026         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5027         method.
5028         <is_visible>: Remove field.
5029         * tui/tui-data.c (tui_next_win, tui_prev_win)
5030         (tui_delete_invisible_windows): Update.
5031
5032 2019-08-16  Tom Tromey  <tom@tromey.com>
5033
5034         * tui/tui-winsource.h (struct tui_source_window_base)
5035         <m_has_locator>: Remove.
5036         * tui/tui-layout.c (show_source_disasm_command, show_data)
5037         (show_source_or_disasm_and_command): Update.
5038
5039 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5040
5041         * NEWS (Other MI changes): New subsection.
5042         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5043         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5044         * arch-utils.c (default_get_pc_address_flags): New function.
5045         * arch-utils.h (default_get_pc_address_flags): New declaration.
5046         * gdbarch.sh: Add get_pc_address_flags.
5047         * gdbarch.c: Regenerate.
5048         * gdbarch.h: Likewise.
5049         * stack.c (print_pc): New function.
5050         (print_frame_info) (print_frame): Call print_pc.
5051
5052 2019-08-16  Tom de Vries  <tdevries@suse.de>
5053
5054         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5055         print_objfile_section_info.
5056
5057 2019-08-15  Tom Tromey  <tom@tromey.com>
5058
5059         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5060         calling update_cmdwin_start_line.
5061         * tui/tui-winsource.h (struct tui_source_window_base)
5062         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5063         <rerender>: Declare.
5064         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5065         Call rerender.
5066         (tui_source_window_base::set_new_height): Remove.
5067         (tui_source_window_base::rerender): Rename from
5068         do_make_visible_with_new_height.
5069         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5070         resize method.
5071         (tui_win_info::make_invisible_and_set_new_height)
5072         (tui_win_info::make_visible_with_new_height): Remove.
5073         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5074         Declare.
5075         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5076         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5077         do_make_visible_with_new_height>: Don't declare.
5078         <rerender>: Declare.
5079         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5080         set_new_height.
5081         (tui_data_window::do_make_visible_with_new_height): Remove.
5082         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5083         call tui_show_locator_content.
5084         (tui_gen_win_info::resize): Call rerender.
5085         (show_source_or_disasm_and_command): Don't call
5086         tui_show_locator_content.
5087         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5088         method.
5089         (struct tui_win_info) <rerender>: Declare.
5090         <set_new_height, make_invisible_and_set_new_height,
5091         make_visible_with_new_height>: Don't declare.
5092         * tui/tui-data.c (tui_win_list::rerender): New method.
5093         * tui/tui-command.h (struct tui_cmd_window)
5094         <do_make_visible_with_new_height>: Don't declare.
5095         * tui/tui-command.c
5096         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5097
5098 2019-08-15  Tom Tromey  <tromey@adacore.com>
5099
5100         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5101         * ada-lang.c (ada_enum_name): Likewise.
5102
5103 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5104
5105         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5106         leading underscore.
5107         (GdbOutputErrorFile): Likewise.
5108         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5109         accordingly.
5110         (execute_unwinders): Rename to have a leading underscore.
5111         (auto_load_packages): Likewise.
5112         (global scope): Adjust call to auto_load_packages accordingly.
5113         (GdbSetPythonDirectory): Likewise.
5114         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5115         instead of execute_unwinders.
5116
5117 2019-08-15  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5120         (show_data): Don't change window visibility.
5121         (tui_gen_win_info::resize): Remove special case for command
5122         window.  Use wresize, when available.
5123         (show_source_or_disasm_and_command): Don't change window
5124         visibility.
5125         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5126         <make_visible>: New method.
5127         * tui/tui-command.c (tui_cmd_window::resize): New method.
5128
5129 2019-08-15  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5132         (struct tui_source_windows): New.
5133         * tui/tui-winsource.c (tui_display_main): Update.
5134         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5135         (new_height_ok, parse_scrolling_args): Update.
5136         * tui/tui-layout.c (show_layout, show_data): Update.
5137         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5138         (tui_add_to_source_windows): Don't declare.
5139         * tui/tui-data.c (source_windows, tui_source_windows)
5140         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5141
5142 2019-08-15  Tom Tromey  <tom@tromey.com>
5143
5144         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5145         Rename from reset.
5146         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5147         * tui/tui-layout.c (show_source_disasm_command, show_data):
5148         Update.
5149         (tui_gen_win_info::resize): Rename.
5150         (show_source_or_disasm_and_command): Update.
5151         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5152         reset.
5153
5154 2019-08-15  Tom Tromey  <tom@tromey.com>
5155
5156         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5157         * tui/tui-interp.c (tui_interp::init): Don't call
5158         tui_initialize_static_data.
5159         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5160
5161 2019-08-15  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5164         examine tui_win_list.
5165
5166 2019-08-15  Tom Tromey  <tom@tromey.com>
5167
5168         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5169         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5170         tui_clear_source_content.
5171         (tui_clear_source_content): Remove.
5172         (tui_source_window_base::do_erase_source_content): Hoist call to
5173         content.clear().
5174         * tui/tui-stack.c (tui_show_frame_info): Don't call
5175         tui_clear_source_content.
5176
5177 2019-08-15  Tom Tromey  <tom@tromey.com>
5178
5179         * tui/tui-winsource.h (struct tui_source_window_base)
5180         <do_erase_source_content>: New method.
5181         <erase_source_content>: New method.
5182         (tui_erase_source_content): Don't declare.
5183         * tui/tui-winsource.c (tui_clear_source_content): Update.
5184         (tui_source_window_base::do_erase_source_content): Rename from
5185         tui_erase_source_content.
5186         (tui_source_window_base::show_source_content): Update.
5187         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5188         * tui/tui-source.h (struct tui_source_window)
5189         <erase_source_content>: New method.
5190         * tui/tui-disasm.h (struct tui_disasm_window)
5191         <erase_source_content>: New method.
5192
5193 2019-08-15  Tom Tromey  <tom@tromey.com>
5194
5195         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5196         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5197         constructor.
5198         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5199         * tui/tui-source.c (tui_set_source_content): Update.
5200         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5201
5202 2019-08-15  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5205         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5206         tui-source.c.
5207         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5208         Declare.
5209         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5210         method.
5211         (tui_source_window::maybe_update): Update.
5212
5213 2019-08-15  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5216         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5217         tui-disasm.c.
5218         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5219         Declare.
5220         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5221         method.
5222         (tui_disasm_window::maybe_update): Update.
5223
5224 2019-08-15  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-winsource.h (struct tui_source_window_base)
5227         <maybe_update>: Declare.
5228         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5229         method.
5230         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5231         Declare.
5232         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5233         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5234         Declare.
5235         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5236
5237 2019-08-15  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5240
5241 2019-08-15  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-wingeneral.c: Include tui-stack.h.
5244         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5245         (struct tui_locator_window): Move from tui-data.h.
5246         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5247         (tui_initialize_static_data): Move from tui-data.c.
5248         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5249         (struct tui_locator_window): Move to tui-stack.c.
5250         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5251         (tui_initialize_static_data): Move to tui-stack.c.
5252
5253 2019-08-15  Tom Tromey  <tom@tromey.com>
5254
5255         * tui/tui-layout.c (show_source_disasm_command)
5256         (show_source_or_disasm_and_command): Use make_visible method, not
5257         tui_make_window.
5258         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5259         Remove.
5260
5261 2019-08-15  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-wingeneral.h (tui_make_window): Update.
5264         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5265         parameter.
5266         (tui_gen_win_info::make_visible): Update.
5267         * tui/tui-regs.c (tui_data_window::display_registers_from):
5268         Update.
5269         * tui/tui-layout.c (show_source_disasm_command)
5270         (show_source_or_disasm_and_command): Update.
5271         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5272         (enum tui_box): Remove.
5273         (struct tui_win_info) <can_box>: New method.
5274         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5275         method.
5276
5277 2019-08-15  Tom de Vries  <tdevries@suse.de>
5278
5279         * linux-nat-trad.c: Include gdbarch.h.
5280
5281 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5282
5283         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5284         register sizes.
5285
5286 2019-08-14  Tom Tromey  <tromey@adacore.com>
5287
5288         * darwin-nat.c: Include gdbarch.h.
5289         * darwin-nat-info.c: Include gdbarch.h.
5290
5291 2019-08-13  Tom Tromey  <tom@tromey.com>
5292
5293         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5294         Remove.
5295         * tui/tui-data.c (tui_initialize_static_data): Update.
5296
5297 2019-08-13  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui-winsource.h (struct tui_exec_info_window)
5300         <~tui_exec_info_window, maybe_allocate_content, get_content,
5301         m_content>: Remove.
5302         (struct tui_source_window_base) <set_exec_info_content,
5303         show_exec_info_content>: Don't declare.
5304         * tui/tui-winsource.c
5305         (tui_exec_info_window::maybe_allocate_content): Remove.
5306         (tui_source_window_base::update_exec_info): Rename from
5307         set_exec_info_content.
5308         (tui_source_window_base::show_exec_info_content)
5309         (tui_source_window_base::update_exec_info): Remove.
5310
5311 2019-08-13  Tom Tromey  <tom@tromey.com>
5312
5313         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5314         declare.
5315         * tui/tui-winsource.c (tui_update_source_window_as_is)
5316         (tui_update_source_windows_with_addr, tui_erase_source_content):
5317         Update.
5318         (tui_clear_exec_info_content): Remove.
5319
5320 2019-08-13  Tom Tromey  <tom@tromey.com>
5321
5322         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5323         declare.
5324         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5325         call tui_erase_exec_info_content.
5326         (tui_clear_exec_info_content): Rename from
5327         tui_erase_exec_info_content.
5328         (tui_clear_exec_info_content): Delete.
5329
5330 2019-08-13  Tom Tromey  <tom@tromey.com>
5331
5332         * tui/tui-winsource.h (struct tui_source_window_base)
5333         <show_exec_info_content>: Declare.
5334         (tui_show_exec_info_content): Don't declare.
5335         * tui/tui-winsource.c
5336         (tui_source_window_base::show_exec_info_content): Rename from
5337         tui_show_exec_info_content.
5338         (tui_source_window_base::update_exec_info): Update.
5339
5340 2019-08-13  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5343         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5344         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5345         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5346         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5347         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5348         ... here.
5349
5350 2019-08-13  Tom Tromey  <tom@tromey.com>
5351
5352         * tui/tui-winsource.h (struct tui_source_window_base)
5353         <update_exec_info>: Declare.
5354         (tui_update_exec_info): Don't declare.
5355         * tui/tui-winsource.c (tui_update_source_window_as_is)
5356         (tui_source_window_base::refresh_all)
5357         (tui_update_all_breakpoint_info): Update.
5358         (tui_source_window_base::update_exec_info): Rename from
5359         tui_update_exec_info.
5360         * tui/tui-stack.c (tui_show_frame_info): Update.
5361
5362 2019-08-13  Tom Tromey  <tom@tromey.com>
5363
5364         * tui/tui-winsource.h (struct tui_source_window_base)
5365         <set_exec_info_content>: Declare.
5366         (tui_set_exec_info_content): Don't declare.
5367         * tui/tui-winsource.c
5368         (tui_source_window_base::set_exec_info_content): Rename from
5369         tui_set_exec_info_content.
5370         (tui_update_exec_info): Update.
5371
5372 2019-08-13  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-winsource.h (struct tui_source_window_base)
5375         <show_source_content>: Declare.
5376         (tui_show_source_content): Don't declare.
5377         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5378         (tui_source_window_base::show_source_content): Rename from
5379         tui_show_source_content.
5380         (tui_source_window_base::refresh_all): Update.
5381         * tui/tui-layout.c (show_source_disasm_command)
5382         (show_source_or_disasm_and_command): Update.
5383
5384 2019-08-13  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-winsource.c (tui_erase_source_content)
5387         (tui_show_source_content, tui_source_window_base::refresh_all):
5388         Update.
5389         * tui/tui-wingeneral.h
5390         (tui_check_and_display_highlight_if_needed): Don't declare.
5391         * tui/tui-wingeneral.c
5392         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5393         check_and_display_highlight_if_needed.
5394         * tui/tui-win.c (tui_rehighlight_all)
5395         (tui_win_info::make_visible_with_new_height): Update.
5396         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5397         (tui_data_window::erase_data_content)
5398         (tui_data_window::display_all_data): Update.
5399         * tui/tui-data.h (struct tui_win_info)
5400         <check_and_display_highlight_if_needed>: Declare.
5401
5402 2019-08-13  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui-win.c (tui_resize_all): Call
5405         tui_delete_invisible_windows.
5406         * tui/tui-layout.c (show_layout): Call
5407         tui_delete_invisible_windows.
5408         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5409         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5410
5411 2019-08-13  Tom Tromey  <tom@tromey.com>
5412
5413         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5414         tui_add_win_to_layout.
5415
5416 2019-08-13  Tom Tromey  <tom@tromey.com>
5417
5418         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5419         * tui/tui-layout.c (tui_default_win_height): Now static.
5420
5421 2019-08-13  Tom Tromey  <tom@tromey.com>
5422
5423         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5424         single switch.
5425         (show_source_disasm_command, show_source_or_disasm_and_command):
5426         Don't check current layout.
5427
5428 2019-08-13  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-wingeneral.c (make_all_visible): Remove.
5431         (tui_make_all_invisible): Simplify.
5432         * tui/tui-layout.c (tui_make_all_invisible): Move from
5433         tui-wingeneral.c; simplify.
5434         (show_layout): Hoist call to tui_make_all_invisible.
5435         (show_data): Don't call tui_make_all_invisible.
5436
5437 2019-08-13  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5440         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5441
5442 2019-08-13  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5445         tui-data.c.
5446         (show_source_disasm_command, show_data)
5447         (show_source_or_disasm_and_command): Don't use
5448         tui_set_current_layout_to.
5449         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5450         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5451         tui-layout.c.
5452         (tui_set_current_layout_to): Remove.
5453
5454 2019-08-13  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui-layout.c (tui_set_layout): Update.
5457         * tui/tui-data.h (struct tui_layout_def): Remove.
5458         (tui_layout_def): Don't declare.
5459         * tui/tui-data.c (layout_def): Remove.
5460         (tui_layout_def): Remove.
5461
5462 2019-08-13  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-winsource.h (struct tui_source_window_base)
5465         <clear_detail>: No longer "override".
5466         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5467         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5468         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5469         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5470         Remove.
5471         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5472
5473 2019-08-13  Tom Tromey  <tromey@adacore.com>
5474
5475         * tracepoint.c: Don't include readline.h or history.h.
5476
5477 2019-08-12  Tom Tromey  <tom@tromey.com>
5478
5479         * configure: Rebuild.
5480         * configure.ac: Check for readline 7.
5481         * NEWS: Mention readline 7 requirement.
5482         * README: Update.
5483
5484 2019-08-12  Tom Tromey  <tom@tromey.com>
5485
5486         * mingw-hdep.c (gdb_select): Remove readline hack.
5487
5488 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5489
5490         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5491         when the function fails.
5492
5493 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5494
5495         * s390-tdep.c (s390_type_align): New function.
5496         (s390_gdbarch_init): Set it as type_align gdbarch method.
5497
5498 2019-08-09  Tom de Vries  <tdevries@suse.de>
5499
5500         PR gdb/24591
5501         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5502         pc_low with relocation offset.
5503
5504 2019-08-07  Tom Tromey  <tromey@adacore.com>
5505
5506         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5507         (print_frame_args): Update.
5508         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5509         Update.
5510         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5511         * frame.h (struct frame_arg): Add initializers.
5512         <error>: Now a unique_xmalloc_ptr.
5513
5514 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5515
5516         * NEWS: Expand the Pointer Authentication entry.
5517         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5518         (aarch64_frame_unmask_lr): ... to this.
5519         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5520         Call aarch64_frame_unmask_lr.
5521         * frame.c (struct frame_info): Add "masked" variable.
5522         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5523         (fprint_frame): Check for masked pc.
5524         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5525         declarations.
5526         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5527         * stack.c (print_frame): Check for masked pc.
5528
5529 2019-08-06  Tom Tromey  <tom@tromey.com>
5530
5531         * stabsread.c (patch_block_stabs, read_one_struct_field)
5532         (read_enum_type): Use obstack_strndup.
5533         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5534         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5535         * dwarf2read.c (guess_full_die_structure_name)
5536         (anonymous_struct_prefix): Use obstack_strndup.
5537         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5538         * c-exp.y (yylex): Use obstack_strndup.
5539         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5540         (write_var_or_type): Use obstack_strndup.
5541
5542 2019-08-06  Tom Tromey  <tom@tromey.com>
5543
5544         * symfile.c (reread_symbols): Use obstack_strdup.
5545         * stabsread.c (read_type): Use obstack_strdup.
5546         * gdb_obstack.h (obstack_strdup): New overload.
5547         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5548         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5549         (dwarf2_canonicalize_name): Use obstack_strdup.
5550         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5551         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5552         Use obstack_strdup.
5553
5554 2019-08-06  Tom Tromey  <tom@tromey.com>
5555
5556         * gdb_obstack.h (obstack_strdup): Define.
5557         * gdb_obstack.c (obstack_strdup): Don't define.
5558
5559 2019-08-06  Tom Tromey  <tom@tromey.com>
5560
5561         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5562         obstack_strdup.
5563         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5564         obstack_strdup.
5565         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5566         * stabsread.c (common_block_start): Use obstack_strdup.
5567         * objfiles.c (set_objfile_main_name, objfile): Use
5568         obstack_strdup.
5569         * namespace.c (add_using_directive): Use obstack_strdup.
5570         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5571         * jit.c (finalize_symtab): Use obstack_strdup.
5572         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5573         (guess_partial_die_structure_name, partial_die_info::fixup)
5574         (dwarf2_name): Use obstack_strdup.
5575         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5576         obstack_strdup.
5577         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5578         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5579         obstack_strdup.
5580         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5581
5582 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5583
5584         * unittests/help-doc-selftests.c: New file.
5585         * Makefile.in: Add the new file.
5586
5587 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5588
5589         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5590         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5591         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5592         the trailing '.' is not output, and the first character is uppercased.
5593         (print_help_for_command): Update call to print_doc_line.
5594         (print_doc_of_command): Likewise.
5595         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5596         * cli/cli-option.c (append_indented_doc): Do not append newline.
5597         (build_help_option): Append newline after first appended_indented_doc
5598         only if a second call is done.
5599         (build_help): Append 2 new lines before each option, except the first
5600         one.
5601         * compile/compile.c (_initialize_compile): Add new lines after
5602         %OPTIONS%, when not at the end of the help.
5603         Change help doc or code
5604         producing the help doc to respect the invariants.
5605         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5606         Also removed the new line after 'Options:', as all other commands
5607         do not put an empty line between 'Options:' and the first option.
5608         * printcmd.c (_initialize_printcmd): Likewise.
5609         * stack.c (_initialize_stack): Likewise.
5610         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5611         incorrectly telling COMMAND is optional.
5612         * ada-lang.c (_initialize_ada_language): Change help doc or code
5613         producing the help doc to respect the invariants.
5614         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5615         * breakpoint.c (_initialize_breakpoint): Likewise.
5616         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5617         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5618         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5619         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5620         _initialize_cli_style): Likewise.
5621         * corelow.c (core_target_info): Likewise.
5622         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5623         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5624         * filesystem.c (_initialize_filesystem): Likewise.
5625         * frame.c (_initialize_frame): Likewise.
5626         * gnu-nat.c (add_task_commands): Likewise.
5627         * infcall.c (_initialize_infcall): Likewise.
5628         * infcmd.c (_initialize_infcmd): Likewise.
5629         * interps.c (_initialize_interpreter): Likewise.
5630         * language.c (_initialize_language): Likewise.
5631         * linux-fork.c (_initialize_linux_fork): Likewise.
5632         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5633         * maint.c (_initialize_maint_cmds): Likewise.
5634         * memattr.c (_initialize_mem): Likewise.
5635         * printcmd.c (_initialize_printcmd): Likewise.
5636         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5637         _RegEx): Likewise.
5638         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5639         * record-btrace.c (_initialize_record_btrace): Likewise.
5640         * record-full.c (_initialize_record_full): Likewise.
5641         * record.c (_initialize_record): Likewise.
5642         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5643         * regcache.c (_initialize_regcache): Likewise.
5644         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5645         _initialize_remote): Likewise.
5646         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5647         * serial.c (_initialize_serial): Likewise.
5648         * skip.c (_initialize_step_skip): Likewise.
5649         * source.c (_initialize_source): Likewise.
5650         * stack.c (_initialize_stack): Likewise.
5651         * symfile.c (_initialize_symfile): Likewise.
5652         * symtab.c (_initialize_symtab): Likewise.
5653         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5654         * top.c (init_main): Likewise.
5655         * tracefile-tfile.c (tfile_target_info): Likewise.
5656         * tracepoint.c (_initialize_tracepoint): Likewise.
5657         * tui/tui-win.c (_initialize_tui_win): Likewise.
5658         * utils.c (add_internal_problem_command): Likewise.
5659         * valprint.c (value_print_option_defs): Likewise.
5660
5661 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5662
5663         PR build/24886
5664         * configure.ac: Drop enable-libmcheck support.
5665         * configure, config.in: Rebuild.
5666         * libmcheck.m4: Remove.
5667         * acinclude.m4: Don't include it.
5668         * Makefile.in: Don't distribute it.
5669         * top.c (print_gdb_configuration): Don't mention it.
5670
5671 2019-08-06  Tom Tromey  <tom@tromey.com>
5672
5673         * utils.c (set_output_style): Sometimes pass stream to
5674         emit_style_escape.
5675         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5676         * record-btrace.c (btrace_insn_history): Update.
5677         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5678         method.
5679         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5680         Update initializers.
5681         <m_uiout>: New field.
5682         <m_di>: Move lower.
5683         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5684         Remove "uiout" parameter.
5685         (dump_insns): Update.
5686         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5687         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5688
5689 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5690
5691         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5692         (error_in_psymtab_expansion): Likewise.
5693         (lookup_symbol_via_quick_fns): Likewise.
5694         (basic_lookup_transparent_type_quick): Likewise.
5695         (basic_lookup_transparent_type_1): Likewise.
5696
5697 2019-08-06  Tom Tromey  <tromey@adacore.com>
5698
5699         * source.c (last_source_error): Now bool.
5700         (print_source_lines_base): Make "noprint" bool.  Only open
5701         source file when last_source_visited changes.
5702
5703 2019-08-06  Tom Tromey  <tromey@adacore.com>
5704
5705         * annotate.c (annotate_source_line): Use g_source_cache.
5706         * source-cache.c (source_cache::get_plain_source_lines): Change
5707         parameters.  Populate m_offset_cache.
5708         (source_cache::ensure): New method.
5709         (source_cache::get_line_charpos): New method.
5710         (extract_lines): Move lower.  Change parameters.
5711         (source_cache::get_source_lines): Move lower.
5712         * source-cache.h (class source_cache): Update comment.
5713         <get_line_charpos>: New method.
5714         <get_source_lines>: Update comment.
5715         <clear>: Clear m_offset_cache.
5716         <get_plain_source_lines>: Change parameters.
5717         <ensure>: New method
5718         <m_offset_cache>: New member.
5719         * source.c (forget_cached_source_info_for_objfile): Update.
5720         (info_source_command): Use g_source_cache.
5721         (find_source_lines, open_source_file_with_line_charpos): Remove.
5722         (print_source_lines_base, search_command_helper): Use g_source_cache.
5723         * source.h (open_source_file_with_line_charpos): Don't declare.
5724         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5725         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5726         Use g_source_cache.
5727
5728 2019-08-06  Tom Tromey  <tromey@adacore.com>
5729
5730         * source-cache.c (source_cache::get_plain_source_lines):
5731         Remove "first_line" and "last_line" parameters.
5732         (source_cache::get_source_lines): Cache plain text.
5733         * source-cache.h (class source_cache)
5734         <get_plain_source_lines>: Update.
5735
5736 2019-08-06  Tom Tromey  <tromey@adacore.com>
5737
5738         * source-cache.c (extract_lines): No longer a method.
5739         Changed type of parameter.  Include final newline.
5740         (selftests::extract_lines_test): New function.
5741         (_initialize_source_cache): Likewise.
5742         * source-cache.h (class source_cache)
5743         <extract_lines>: Don't declare.
5744
5745 2019-08-06  Tom Tromey  <tromey@adacore.com>
5746
5747         * breakpoint.c (init_breakpoint_sal): Update.
5748         (breakpoint): Update.
5749         * breakpoint.h (struct breakpoint) <filter>: Now a
5750         unique_xmalloc_ptr.
5751
5752 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5753
5754         * NEWS: Mention dictionary access on blocks.
5755         * python/py-block.c (blpy_getitem): New function.
5756         (block_object_as_mapping): New struct.
5757         (block_object_type): Use new struct for tp_as_mapping field.
5758
5759 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5760
5761         * objfiles.h (objfile): Add a comment describing partial symbols.
5762
5763 2019-08-05  Tom Tromey  <tromey@adacore.com>
5764
5765         * compile/compile.c (_initialize_compile): Use _(), not N_().
5766         * thread.c (_initialize_thread): Use _(), not N_().
5767         * stack.c (_initialize_stack): Use _(), not N_().
5768         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5769
5770 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5771
5772         * dwarf2read.c (struct dw2_symtab_iterator):
5773         <want_specific_block>: Remove.
5774         <block_index>: Change type to gdb::optional.
5775         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5776         change type of BLOCK_INDEX parameter to gdb::optional.
5777         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5778         (dw2_lookup_symbol): Don't pass argument for
5779         WANT_SPECIFIC_BLOCK.
5780         (dw2_expand_symtabs_for_function): Don't pass argument for
5781         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5782         (class dw2_debug_names_iterator)
5783         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5784         parameter, change BLOCK_INDEX type to gdb::optional.
5785         <m_want_specific_block>: Remove.
5786         <m_block_index>: Change type to gdb::optional.
5787         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5788         gdb::optional.  Re-write in function of gdb::optional.
5789         (dw2_debug_names_lookup_symbol): Don't pass argument for
5790         WANT_SPECIFIC_BLOCK.
5791         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5792         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5793         BLOCK_INDEX.
5794
5795 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5796
5797         * NEWS: Mention changes to "info sources" command.
5798
5799 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5800
5801         * symtab.c (filename_partial_match_opts): New struct type.
5802         (struct output_source_filename_data): New members
5803         regexp, c_regexp, partial_match.
5804         (output_source_filename): Use new members to decide to print file.
5805         (info_sources_option_defs): New variable.
5806         (make_info_sources_options_def_group, print_info_sources_header,
5807         info_sources_command_completer):
5808         New functions.
5809         (info_sources_command): Read new optional arguments.
5810         (_initialize_symtab): Update info sources help.
5811
5812 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5813
5814         * ada-lang.c (exception_support_info_v0): Renamed from...
5815         (default_exception_support_info): ... this.  Create new
5816         definition for v1.
5817         (ada_has_this_exception_support): Look up catch_handlers_sym.
5818         (ada_exception_support_info_sniffer): Try v0 after default.
5819
5820 2019-08-01  Tom Tromey  <tromey@adacore.com>
5821
5822         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5823         gdbarch.h.
5824
5825 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5826
5827         * s12z-tdep.c: Fix include path for s12z-opc.h.
5828
5829 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5830
5831         * NEWS: Require GNU make 3.82.
5832
5833 2019-07-16  Tom Tromey  <tom@tromey.com>
5834
5835         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5836         declare.
5837
5838 2019-07-30  Tom Tromey  <tromey@adacore.com>
5839
5840         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5841
5842 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5843
5844         * printcmd.c (print_address_symbolic): Print negative offsets.
5845         (build_address_symbolic): Force signed arithmetic when computing
5846         offset.
5847
5848 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5849
5850         PR/24474: Add a function to lookup static variables.
5851         * NEWS: Mention this new function.
5852         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5853         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5854         * python/python.c (python_GdbMethods): Add new function.
5855
5856 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5857
5858         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5859         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5860         (objfpy_lookup_static_symbol): New function.
5861         (objfile_object_methods): Add new functions.
5862
5863 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5864
5865         * NEWS: Mention 'set|show print frame-info'.  Mention new
5866         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5867         backtrace argument.  Mention that python frame filtering code
5868         is now consistent with what 'backtrace' command prints.
5869
5870 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5871
5872         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5873         comments.
5874         (print_frame_info_auto, print_frame_info_source_line,
5875         print_frame_info_location, print_frame_info_source_and_location,
5876         print_frame_info_location_and_address, print_frame_info_short_location):
5877         New declarations.
5878         (struct frame_print_options): New member print_frame_info.
5879         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5880         * stack.h (get_user_print_what_frame_info): New declaration.
5881         (frame_show_address): New declaration.
5882         * stack.c (print_frame_arguments_choices): New value 'presence'.
5883         (print_frame_info_auto, print_frame_info_source_line,
5884         print_frame_info_location, print_frame_info_source_and_location,
5885         print_frame_info_location_and_address, print_frame_info_short_location,
5886         print_frame_info_choices, print_frame_info_print_what): New definitions.
5887         (print_frame_args): Only print dots for args if print frame-arguments
5888         is 'presence'.
5889         (frame_print_option_defs): New element for "frame-info".
5890         (get_user_print_what_frame_info): New function.
5891         (frame_show_address): Make non static.  Move comment to stack.h.
5892         (print_frame_info_to_print_what): New function.
5893         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5894         to decide what to print.
5895         (backtrace_command_1): Handle the new print_frame_arguments_presence
5896         value.
5897         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5898         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5899         (py_print_frame): In non-mi mode, use LOCATION as default for
5900         print_what, similarly to frame information printed directly by
5901         backtrace command. Handle frame-info user option in non MI mode.
5902
5903 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5904
5905         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5906         Add case for debugging 32-bit target on 64-bit host.  Revise
5907         comment.
5908
5909 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5910
5911         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5912         instead of find_function_entry_range_from_pc.
5913
5914 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5915
5916         * stack.c (find_frame_funname): Remove code which preferred
5917         minsym over symtab sym in "certain pathological cases".
5918
5919         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5920         parameter.  Change type of "do_demangle" to bool.
5921         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5922         Pass suitable "prefer_sym_over_minsym" flag to
5923         build_address_symbolic().  Don't output "+" for negative offsets.
5924         * printcmd.c (print_address_symbolic): Update invocation of
5925         build_address_symbolic to include a "prefer_sym_over_minsym"
5926         flag.
5927         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5928         Restrict cases in which use of minimal symbol is preferred to that
5929         of a found symbol.  Update comments.
5930
5931         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5932         for entry pc when entry pc is out of range for that FDE.
5933
5934 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5935
5936         PR gdb/24839:
5937         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5938         type.
5939
5940 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5941
5942         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5943         this function's Python signature.
5944
5945
5946 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5947
5948         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5949         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5950         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5951         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5952         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5953
5954
5955 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5956
5957         * h8300-tdep.c (h8300_register_name_common): New.
5958         h8300_register_name): Use h8300_register_name_common.
5959         (h8300s_register_name): Likewise.
5960         (h8300sx_register_name): Likewise.
5961         (h8300h_register_nam): New.
5962         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5963
5964
5965 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5966
5967         * arm-tdep.c (arm_skip_cmse_entry): New function.
5968         (arm_is_sgstubs_section): New function.
5969         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5970
5971 2019-07-22  Tom Tromey  <tom@tromey.com>
5972
5973         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5974         Don't self-assign.
5975
5976 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5977
5978         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5979         type_print.
5980
5981 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5984         so that GDB doesn't match any msymbols when searching in the
5985         TYPES_DOMAIN.
5986         (print_symbol_info): Print using typedef_print or type_print based
5987         on the type of the symbol.  Add updated FIXME comment moved from...
5988         (_initialize_symtab): ... move and update FIXME comment to above.
5989
5990 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * NEWS: Mention adding -q option to "info types".
5993         * symtab.c (struct info_types_options): New struct.
5994         (info_types_options_defs): New variable.
5995         (make_info_types_options_def_group): New function.
5996         (info_types_command): Use gdb::option framework to parse options.
5997         (info_types_command_completer): New function.
5998         (_initialize_symtab): Extend the help text on "info types" and
5999         register command completer.
6000
6001 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6002
6003         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6004         (lookup_symbol_in_objfile): Change int to block_enum and add a
6005         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6006
6007 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6008
6009         * MAINTAINERS (Write After Approval): Add self.
6010
6011 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6014         instruction to the dummy code region.
6015
6016 2019-07-19  Tom Tromey  <tromey@adacore.com>
6017
6018         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6019         (ARGSUSED, PARAMS, __func__): Remove rules.
6020
6021 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6022
6023         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6024         * features/arm/arm-with-iwmmxt.c: Remove.
6025         * features/arm/arm-with-iwmmxt.xml: Remove.
6026         * features/arm/arm-with-m-fpa-layout.c: Remove.
6027         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6028         * features/arm/arm-with-m-vfp-d16.c: Remove.
6029         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6030         * features/arm/arm-with-m.c: Remove.
6031         * features/arm/arm-with-m.xml: Remove.
6032         * features/arm/arm-with-neon.c: Remove.
6033         * features/arm/arm-with-neon.xml: Remove.
6034         * features/arm/arm-with-vfpv2.c: Remove.
6035         * features/arm/arm-with-vfpv2.xml: Remove.
6036         * features/arm/arm-with-vfpv3.c: Remove.
6037         * features/arm/arm-with-vfpv3.xml: Remove.
6038
6039 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6040
6041         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6042
6043 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6044
6045         * arch/aarch32.c (aarch32_create_target_description): Create
6046         target descriptions using features.
6047         * arch/arm.c (arm_create_target_description)
6048         (arm_create_mprofile_target_description): Likewise.
6049         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6050
6051 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6052
6053         * Makefile.in: Add new files.
6054         * aarch32-tdep.c: New file.
6055         * aarch32-tdep.h: New file.
6056         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6057         Call aarch32_read_description.
6058         * arch/aarch32.c: New file.
6059         * arch/aarch32.h: New file.
6060         * arch/arm.c (arm_create_target_description)
6061         (arm_create_mprofile_target_description): New function.
6062         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6063         (arm_create_target_description)
6064         (arm_create_mprofile_target_description): New declaration.
6065         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6066         read_description functions.
6067         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6068         Likewise.
6069         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6070         * arm-tdep.c (tdesc_arm_list): New variable.
6071         (arm_register_g_packet_guesses): Call create description functions.
6072         (arm_read_description) (arm_read_mprofile_description): New
6073         function.
6074         * arm-tdep.h (arm_read_description)
6075         (arm_read_mprofile_description): Add declaration.
6076         * configure.tgt: Add new files.
6077
6078 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6079
6080         * top.c (new_ui_command): Open specified terminal just once.
6081
6082 2019-07-18  Tom Tromey  <tromey@adacore.com>
6083
6084         * symtab.c (main_name): Constify return type.
6085         * symfile.c (set_initial_language): Update.
6086         * symtab.h (main_name): Constify return type.
6087
6088 2019-07-17  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-winsource.c (tui_update_source_window)
6091         (tui_update_source_window_as_is)
6092         (tui_update_source_windows_with_line): Remove return.
6093         * tui/tui-disasm.c (tui_show_disassem)
6094         (tui_show_disassem_and_update_source): Remove return.
6095         * tui/tui.c (tui_reset): Remove return.
6096         * tui/tui-wingeneral.c
6097         (tui_check_and_display_highlight_if_needed): Remove return.
6098
6099 2019-07-17  Tom Tromey  <tom@tromey.com>
6100
6101         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6102
6103 2019-07-17  Tom Tromey  <tom@tromey.com>
6104
6105         * tui/tui-winsource.h (struct tui_exec_info_window)
6106         (struct tui_source_window_base): Move from tui-data.h.
6107         * tui/tui-winsource.c: Move many method definitions from
6108         elsewhere.  Remove "structuring" comments.
6109         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6110         (tui_source_window_base::refresh_window): Move to
6111         tui-winsource.c.
6112         * tui/tui-win.c (tui_source_window_base::refresh_all)
6113         (tui_source_window_base::update_tab_width)
6114         (tui_source_window_base::set_new_height)
6115         (tui_source_window_base::do_make_visible_with_new_height): Move to
6116         tui-winsource.c.
6117         * tui/tui-source.h: Update.
6118         * tui/tui-source.c (tui_source_window_base::reset): Move to
6119         tui-winsource.c.
6120         * tui/tui-disasm.h: Update.
6121         * tui/tui-data.h (struct tui_exec_info_window): Move to
6122         tui-winsource.h.
6123         (struct tui_source_window_base): Likewise.
6124         * tui/tui-data.c (tui_source_window_base::clear_detail)
6125         (tui_source_window_base, ~tui_source_window_base): Move to
6126         tui-winsource.c.
6127
6128 2019-07-17  Tom Tromey  <tom@tromey.com>
6129
6130         * tui/tui-win.c (tui_resize_all)
6131         (tui_source_window_base::update_tab_width)
6132         (tui_adjust_win_heights): Update.
6133         (tui_win_info::make_invisible_and_set_new_height): Rename from
6134         make_invisible_and_set_new_height.
6135         * tui/tui-data.h (struct tui_win_info)
6136         <make_invisible_and_set_new_height>: New method.
6137
6138 2019-07-17  Tom Tromey  <tom@tromey.com>
6139
6140         * tui/tui.c: Update.
6141         * tui/tui-source.h (struct tui_source_window): Move from
6142         tui-data.h.
6143         * tui/tui-layout.c: Update.
6144         * tui/tui-disasm.c: Update.
6145         * tui/tui-data.h (struct tui_source_window): Move to
6146         tui-source.h.
6147
6148 2019-07-17  Tom Tromey  <tom@tromey.com>
6149
6150         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6151         tui-data.h.
6152         * tui/tui-data.h (struct tui_disasm_window): Move to
6153         tui-disasm.h.
6154
6155 2019-07-17  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-regs.h (struct tui_data_item_window): Move from
6158         tui-data.h.
6159         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6160         * tui/tui-data.h (struct tui_data_item_window): Move to
6161         tui-regs.h.
6162         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6163
6164 2019-07-17  Tom Tromey  <tom@tromey.com>
6165
6166         * tui/tui.c: Update.
6167         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6168         (tui_cmd_window::max_height): Move to tui-command.c.
6169         * tui/tui-layout.c: Update.
6170         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6171         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6172         tui-command.c.
6173         * tui/tui-command.h (struct tui_cmd_window): Move from
6174         tui-data.h.
6175         * tui/tui-command.c: Remove "structuring" comments.
6176         (tui_cmd_window::clear_detail)
6177         (tui_cmd_window::do_make_visible_with_new_height)
6178         (tui_cmd_window::max_height): Move from elsewhere.
6179
6180 2019-07-17  Tom Tromey  <tom@tromey.com>
6181
6182         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6183         Now static.
6184         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6185         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6186
6187 2019-07-17  Tom Tromey  <tom@tromey.com>
6188
6189         * tui/tui.c: Update.
6190         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6191         tui-regs.c.
6192         * tui/tui-windata.h: Remove file.
6193         * tui/tui-windata.c: Remove file.
6194         * tui/tui-win.c (tui_data_window::set_new_height)
6195         (tui_data_window::do_make_visible_with_new_height): Move to
6196         tui-regs.c.
6197         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6198         * tui/tui-regs.c: Remove "structuring" comments.
6199         (tui_data_window::first_data_item_displayed)
6200         (tui_data_window::delete_data_content_windows)
6201         (tui_data_window::erase_data_content)
6202         (tui_data_window::display_all_data)
6203         (tui_data_window::refresh_all)
6204         (tui_data_window::do_scroll_vertical)
6205         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6206         (tui_data_window::do_make_visible_with_new_height)
6207         (tui_data_window::refresh_window): Move from elsewhere.
6208         (_initialize_tui_regs): Move to end of file.
6209         * tui/tui-layout.c: Update.
6210         * tui/tui-hooks.c: Update.
6211         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6212         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6213         tui-regs.c.
6214         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6215
6216 2019-07-17  Tom Tromey  <tom@tromey.com>
6217
6218         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6219         seen.
6220
6221 2019-07-17  Tom Tromey  <tom@tromey.com>
6222
6223         * tui/tui-win.c (tui_source_window_base::set_new_height)
6224         (tui_source_window_base::do_make_visible_with_new_height): Use
6225         m_has_locator field directly.
6226         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6227         method.
6228         (struct tui_source_window_base) <has_locator>: Likewise.
6229
6230 2019-07-17  Tom Tromey  <tom@tromey.com>
6231
6232         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6233         Don't declare.
6234         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6235         Remove.
6236         * tui/tui-win.c (tui_source_window_base::set_new_height)
6237         (tui_source_window_base::set_new_height)
6238         (make_invisible_and_set_new_height)
6239         (tui_source_window_base::do_make_visible_with_new_height)
6240         (tui_source_window_base::do_make_visible_with_new_height):
6241         Update.
6242         * tui/tui-layout.c (show_source_disasm_command, show_data)
6243         (show_source_or_disasm_and_command): Update.
6244         * tui/tui-layout.c (show_layout): Update.
6245
6246 2019-07-17  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui-layout.c (make_data_window): Remove.
6249         (show_data): Unify creation and re-initialization cases.
6250
6251 2019-07-17  Tom Tromey  <tom@tromey.com>
6252
6253         * tui/tui-layout.c (make_source_window, make_disasm_window):
6254         Remove.
6255         (show_data): Unify creation and re-initialization cases.
6256
6257 2019-07-17  Tom Tromey  <tom@tromey.com>
6258
6259         * tui/tui-layout.c (make_command_window): Remove.
6260         (show_source_disasm_command, show_source_or_disasm_and_command):
6261         Unify creation and re-initialization cases.
6262
6263 2019-07-17  Tom Tromey  <tom@tromey.com>
6264
6265         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6266         creation and re-initialization cases.
6267
6268 2019-07-17  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-regs.c (tui_get_register): Return void.
6271
6272 2019-07-17  Tom Tromey  <tom@tromey.com>
6273
6274         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6275         Simplify.
6276
6277 2019-07-17  Tom Tromey  <tom@tromey.com>
6278
6279         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6280         resetting.
6281
6282 2019-07-17  Tom Tromey  <tom@tromey.com>
6283
6284         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6285         * tui/tui-regs.c (tui_reg_layout): New function.
6286         (tui_show_registers, tui_reg_command): Use it.
6287         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6288         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6289         parameters.
6290         (tui_layout_command): Remove.
6291
6292 2019-07-17  Tom Tromey  <tom@tromey.com>
6293
6294         * tui/tui-layout.h (tui/tui-layout): Return void.
6295         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6296
6297 2019-07-17  Tom Tromey  <tom@tromey.com>
6298
6299         * tui/tui-layout.c (show_source_disasm_command, show_data):
6300         Update.
6301         (reset_locator): Remove.
6302         (show_source_or_disasm_and_command): Update.
6303
6304 2019-07-17  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui-source.c (tui_source_window_base::reset): Remove
6307         win_type parameter.
6308         * tui/tui-layout.c (make_command_window, make_source_window)
6309         (make_disasm_window, make_data_window)
6310         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6311         (reset_locator, show_source_or_disasm_and_command): Update.
6312         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6313         win_type parameter.
6314         (struct tui_source_window_base) <reset>: Likewise.
6315
6316 2019-07-17  Tom Tromey  <tom@tromey.com>
6317
6318         * tui/tui-layout.c (show_source_disasm_command): Use
6319         reset_locator.
6320         (reset_locator): New function.
6321         (init_and_make_win): Remove.
6322         (show_source_or_disasm_and_command): Use reset_locator.
6323
6324 2019-07-17  Tom Tromey  <tom@tromey.com>
6325
6326         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6327         condition.
6328         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6329         Remove condition.
6330         * tui/tui-source.c (tui_source_window_base::reset): New method.
6331         * tui/tui-layout.c (make_command_window): Don't call
6332         init_and_make_win.
6333         (make_source_window, make_disasm_window): Don't call
6334         make_source_or_disasm_window.
6335         (make_data_window): Don't call init_and_make_win.  Change calling
6336         convention.
6337         (show_source_disasm_command, show_data): Simplify.
6338         (make_source_or_disasm_window): Remove.
6339         (show_source_or_disasm_and_command): Simplify.
6340         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6341         (struct tui_source_window_base) <reset>: Likewise.
6342         <execution_info>: Remove initializer.
6343         * tui/tui-data.c (tui_source_window_base): Initialize
6344         execution_info.
6345
6346 2019-07-17  Tom Tromey  <tom@tromey.com>
6347
6348         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6349         variable.
6350
6351 2019-07-17  Tom Tromey  <tom@tromey.com>
6352
6353         * tui/tui.c (tui_rl_other_window): Update.
6354         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6355         superclass method first.  Always iterate over regs_content.
6356         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6357         method.
6358         * tui/tui-win.c (tui_set_focus_command): Update.
6359
6360 2019-07-17  Tom Tromey  <tom@tromey.com>
6361
6362         * tui/tui-win.c (tui_set_focus_command): Rename from
6363         tui_set_focus.  Call tui_enable.
6364         (tui_set_focus_command): Remove.
6365
6366 2019-07-17  Tom Tromey  <tom@tromey.com>
6367
6368         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6369         refresh_window.
6370         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6371         touchwin.
6372         (tui_data_window::refresh_window): Call refresh_window on data
6373         items.  Always call superclass refresh_window.
6374         (tui_win_info::refresh): Remove.
6375         (tui_source_window_base::refresh_window): Update.
6376         (tui_refresh_all): Update.
6377         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6378         refresh_window.
6379         (show_source_or_disasm_and_command): Likewise.
6380         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6381         (struct tui_source_window_base) <refresh>: Likewise.
6382
6383 2019-07-17  Tom Tromey  <tom@tromey.com>
6384
6385         * tui/tui-winsource.c (tui_clear_source_content)
6386         (tui_show_source_content): Update.
6387         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6388         whether content is empty.
6389         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6390         Remove.
6391
6392 2019-07-17  Tom Tromey  <tom@tromey.com>
6393
6394         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6395         window's contents.
6396         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6397         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6398
6399 2019-07-17  Tom Tromey  <tom@tromey.com>
6400
6401         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6402         (struct tui_data_item_window): Update.
6403
6404 2019-07-17  Tom Tromey  <tom@tromey.com>
6405
6406         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6407         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6408         defines.
6409
6410 2019-07-17  Tom Tromey  <tom@tromey.com>
6411
6412         * tui/tui-winsource.h (tui_erase_source_content)
6413         (tui_clear_source_content): Remove "display_prompt" parameter.
6414         * tui/tui-winsource.c (tui_update_source_window_as_is)
6415         (tui_update_source_windows_with_addr): Update.
6416         (tui_clear_source_content): Remove "display_prompt" parameter.
6417         (tui_erase_source_content): Likewise.  Simplify.
6418         (tui_show_source_content): Update.
6419         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6420         * tui/tui-stack.c (tui_show_frame_info): Update.
6421         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6422         Remove defines.
6423
6424 2019-07-17  Tom Tromey  <tom@tromey.com>
6425
6426         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6427         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6428         parameter.
6429         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6430         parameter.
6431
6432 2019-07-17  Tom Tromey  <tom@tromey.com>
6433
6434         * tui/tui-winsource.c (tui_clear_source_content)
6435         (tui_show_source_content, tui_show_exec_info_content)
6436         (tui_clear_exec_info_content): Update.
6437         * tui/tui-stack.c (tui_show_locator_content): Update.
6438         (tui_show_frame_info): Update.
6439         * tui/tui-source.h (tui_source_window): Don't declare.
6440         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6441         from tui_source_is_displayed.
6442         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6443         Remove field.
6444         (struct tui_source_window_base) <content_in_use>: New field.  Now
6445         bool.
6446         (struct tui_source_window) <showing_source_p>: New method.
6447         (TUI_SRC_WIN): Change cast.
6448         * tui/tui-data.c (tui_initialize_static_data): Update.
6449
6450 2019-07-17  Tom Tromey  <tom@tromey.com>
6451
6452         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6453         location_matches_p.
6454         * tui/tui-source.c (tui_source_window::location_matches_p): New
6455         method.
6456         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6457         method.
6458         * tui/tui-data.h (struct tui_source_window_base)
6459         <location_matches_p>: New method.
6460         (struct tui_source_window, struct tui_disasm_window)
6461         <location_matches_p>: Likewise.
6462
6463 2019-07-17  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui-win.c (tui_set_win_height_command): Rename from
6466         tui_set_win_height.
6467         (tui_set_win_height_command): Remove.
6468
6469 2019-07-17  Tom Tromey  <tom@tromey.com>
6470
6471         * tui/tui-source.c (tui_source_window): New constructor.  Add
6472         observer.
6473         (~tui_source_window): New destructor.
6474         (tui_source_window::style_changed): New method.
6475         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6476         (tui_attach_detach_observers): Update.
6477         * tui/tui-data.h (struct tui_source_window): Make constructor not
6478         inline.  Add destructor.
6479         (struct tui_source_window) <style_changed>: New method.
6480         <m_observable>: New member.
6481
6482 2019-07-17  Tom Tromey  <tom@tromey.com>
6483
6484         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6485         * tui/tui-win.c (tui_resize_all): Fix typo.
6486
6487 2019-07-17  Tom Tromey  <tom@tromey.com>
6488
6489         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6490         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6491         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6492         * tui/tui-win.c (window_name_completer): Use foreach.
6493         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6494         (update_tab_width): Likewise.
6495         * tui/tui-layout.c (show_layout): Update.
6496         * tui/tui-data.h (class tui_window_iterator): New.
6497         (struct all_tui_windows): New.
6498         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6499
6500 2019-07-17  Tom Tromey  <tom@tromey.com>
6501
6502         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6503         parameter.  Don't reference globals.
6504         (tui_reg_command): Update.
6505
6506 2019-07-17  Tom Tromey  <tom@tromey.com>
6507
6508         * tui/tui-regs.c (tui_show_registers): Simplify.
6509
6510 2019-07-17  Tom Tromey  <tom@tromey.com>
6511
6512         * tui/tui-regs.c (tui_show_registers): Update.
6513         (tui_show_register_group): Add win_info parameter.
6514
6515 2019-07-17  Tom Tromey  <tom@tromey.com>
6516
6517         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6518         Rename from tui_display_reg_element_at_line.
6519         (tui_data_window::display_registers_from_line): Update.
6520         * tui/tui-data.h (struct tui_data_window)
6521         <display_reg_element_at_line>: New method.
6522
6523 2019-07-17  Tom Tromey  <tom@tromey.com>
6524
6525         * tui/tui-regs.h (tui_display_registers_from)
6526         (tui_display_registers_from_line): Don't declare.
6527         * tui/tui-windata.c (tui_data_window::display_all_data)
6528         (tui_data_window::refresh_all)
6529         (tui_data_window::do_scroll_vertical): Update.
6530         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6531         from tui_display_registers_from.
6532         (tui_display_reg_element_at_line): Update.
6533         (tui_data_window::display_registers_from_line): Rename from
6534         tui_display_registers_from_line.
6535         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6536         display_registers_from_line>: New methods.
6537
6538 2019-07-17  Tom Tromey  <tom@tromey.com>
6539
6540         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6541         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6542         from tui_erase_data_content.
6543         (tui_data_window::display_all_data)
6544         (tui_data_window::refresh_all)
6545         (tui_data_window::do_scroll_vertical): Update.
6546         * tui/tui-regs.c (tui_show_registers): Update.
6547         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6548         New method.
6549
6550 2019-07-17  Tom Tromey  <tom@tromey.com>
6551
6552         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6553         declare.
6554         * tui/tui-windata.c
6555         (tui_data_window::delete_data_content_windows): Rename from
6556         tui_delete_data_content_windows.
6557         (tui_data_window::display_all_data)
6558         (tui_data_window::do_scroll_vertical): Update.
6559         * tui/tui-data.h (struct tui_data_window)
6560         <delete_data_content_windows>: New method.
6561
6562 2019-07-17  Tom Tromey  <tom@tromey.com>
6563
6564         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6565         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6566
6567 2019-07-17  Tom Tromey  <tom@tromey.com>
6568
6569         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6570         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6571         from tui_display_all_data.
6572         * tui/tui-win.c
6573         (tui_data_window::do_make_visible_with_new_height): Update.
6574         * tui/tui-regs.c (tui_show_registers): Update.
6575         * tui/tui-layout.c (tui_set_layout): Update.
6576         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6577         method.
6578
6579 2019-07-17  Tom Tromey  <tom@tromey.com>
6580
6581         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6582         * tui/tui-windata.c (tui_display_data_from): Remove.
6583         (tui_data_window::refresh_all): Update.
6584
6585 2019-07-17  Tom Tromey  <tom@tromey.com>
6586
6587         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6588         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6589         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6590         tui_display_registers_from_line.
6591         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6592         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6593         "force_display" parameter.
6594
6595 2019-07-17  Tom Tromey  <tom@tromey.com>
6596
6597         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6598         declare.
6599         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6600         Rename from tui_first_reg_element_no_inline.
6601         (tui_display_reg_element_at_line)
6602         (tui_display_registers_from_line): Update.
6603         * tui/tui-data.h (struct tui_data_window)
6604         <first_reg_element_no_inline>: New method.
6605
6606 2019-07-17  Tom Tromey  <tom@tromey.com>
6607
6608         * tui/tui-windata.c (tui_display_data_from)
6609         (tui_data_window::do_scroll_vertical): Update.
6610         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6611         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6612         Rename from tui_line_from_reg_element_no.
6613         (tui_display_registers_from_line): Update.
6614         * tui/tui-data.h (struct tui_data_window)
6615         <line_from_reg_element_no>: New method.
6616
6617 2019-07-17  Tom Tromey  <tom@tromey.com>
6618
6619         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6620         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6621         tui_last_regs_line_no.
6622         (tui_display_reg_element_at_line)
6623         (tui_display_registers_from_line): Update.
6624         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6625         method.
6626
6627 2019-07-17  Tom Tromey  <tom@tromey.com>
6628
6629         PR tui/24722:
6630         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6631         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6632         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6633         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6634         (tui_update_breakpoint_info): Likewise.
6635         * tui/tui-hooks.c (tui_event_create_breakpoint)
6636         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6637         Update.
6638
6639 2019-07-17  Tom Tromey  <tom@tromey.com>
6640
6641         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6642
6643 2019-07-17  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-winsource.c (tui_update_source_window_as_is)
6646         (tui_update_source_windows_with_addr): Update.
6647         * tui/tui-source.h (tui_set_source_content)
6648         (tui_show_symtab_source): Add "win_info" parameter.
6649         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6650         parameter.
6651         (tui_show_symtab_source): Likewise.
6652
6653 2019-07-17  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-wingeneral.c
6656         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6657
6658 2019-07-17  Tom Tromey  <tom@tromey.com>
6659
6660         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6661         (struct tui_cmd_window) <can_scroll>: New method.
6662         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6663         method.
6664
6665 2019-07-17  Tom Tromey  <tromey@adacore.com>
6666
6667         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6668         do_field_signed>: Rename.  Change type of "value".
6669         * ui-out.c (ui_out::field_signed): Rename from field_int.
6670         Change type of "value".
6671         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6672         type of "value".
6673         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6674         do_field_int.  Change type of "value".
6675         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6676         do_field_int.  Change type of "value".
6677         * tracepoint.c (trace_status_mi, tfind_1)
6678         (print_one_static_tracepoint_marker): Update.
6679         * thread.c (print_thread_info_1, print_selected_thread_frame):
6680         Update.
6681         * stack.c (print_frame, print_frame_info): Update.
6682         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6683         Update.
6684         * source.c (print_source_lines_base): Update.
6685         * skip.c (info_skip_command): Update.
6686         * record-btrace.c (btrace_ui_out_decode_error)
6687         (btrace_call_history_src_line): Update.
6688         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6689         Update.
6690         * progspace.c (print_program_space): Update.
6691         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6692         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6693         do_field_int.  Change type of "value".
6694         * mi/mi-out.c (mi_ui_out::do_table_begin)
6695         (mi_ui_out::do_table_header): Update.
6696         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6697         type of "value".
6698         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6699         (mi_cmd_data_list_changed_registers, output_register)
6700         (mi_cmd_data_read_memory, mi_load_progress)
6701         (mi_cmd_trace_frame_collected): Update.
6702         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6703         Update.
6704         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6705         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6706         (mi_cmd_var_list_children, varobj_update_one): Update.
6707         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6708         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6710         * inferior.c (print_inferior): Update.
6711         * gdb_bfd.c (print_one_bfd): Update.
6712         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6713         Update.
6714         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6715         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6716         do_field_int.  Change type of "value".
6717         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6718         do_field_int.  Change type of "value".
6719         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6720         (print_one_breakpoint_location, print_it_catch_fork)
6721         (print_one_catch_fork, print_it_catch_vfork)
6722         (print_one_catch_vfork, print_it_catch_solib)
6723         (print_it_catch_exec, print_it_ranged_breakpoint)
6724         (print_mention_watchpoint, print_mention_masked_watchpoint)
6725         (bkpt_print_it, update_static_tracepoint): Update.
6726         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6727         * break-catch-syscall.c (print_it_catch_syscall): Update.
6728         * ada-tasks.c (print_ada_task_info): Update.
6729         * ada-lang.c (print_it_exception, print_mention_exception):
6730         Update.
6731
6732 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6733
6734         PR breakpoints/24541
6735         * gdbarch.c: Regenerate.
6736         * gdbarch.h: Regenerate.
6737         * gdbarch.sh: Adjust return type and parameter types for
6738         'stap_adjust_register'.
6739         (i386_stap_adjust_register): Adjust signature and return new
6740         register name.
6741         * stap-probe.c (stap_parse_register_operand): Adjust use of
6742         'gdbarch_stap_adjust_register'.
6743
6744 2019-07-17  Tom Tromey  <tromey@adacore.com>
6745
6746         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6747         declare VEC.
6748         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6749         std::vector.
6750         (struct s390_process_info): Add initializers.
6751         (s390_add_process): Use new.
6752         (s390_linux_nat_target::low_forget_process): Use delete.
6753         (s390_linux_nat_target::low_new_fork)
6754         (s390_linux_nat_target::stopped_by_watchpoint)
6755         (s390_linux_nat_target::low_prepare_to_resume)
6756         (s390_linux_nat_target::insert_watchpoint)
6757         (s390_linux_nat_target::insert_hw_breakpoint)
6758         (s390_linux_nat_target::remove_watchpoint)
6759         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6760
6761 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6762
6763         * aarch64-fbsd-nat.c: Include regcache.h.
6764         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6765         argument.
6766         (aarch64_fbsd_nat_target::fetch_registers)
6767         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6768         variable.
6769         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6770
6771 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6772
6773         * fbsd-nat.c: Include gdbarch.h.
6774
6775 2019-07-15  Tom Tromey  <tromey@adacore.com>
6776
6777         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6778
6779 2019-07-15  Tom Tromey  <tromey@adacore.com>
6780
6781         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6782         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6783         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6784         * cli-out.c (cli_ui_out::do_field_int): New method.
6785         * ui-out.c (ui_out::field_unsigned): New method.
6786         * symfile.c (generic_load): Use field_unsigned.
6787         (print_transfer_performance): Likewise.
6788         * record-btrace.c (ui_out_field_uint): Remove.
6789         (btrace_call_history_insn_range, btrace_call_history): Use
6790         field_unsigned.
6791         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6792         field_unsigned.
6793         * ui-out.h (class ui_out) <field_unsigned>: New method.
6794         <do_field_unsigned>: Likewise.
6795
6796 2019-07-15  Tom Tromey  <tromey@adacore.com>
6797
6798         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6799         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6800         * target.c (flash_erase_command): Use field_string.
6801         * infrun.c (print_signal_received_reason): Use field_string.
6802         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6803         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6804         field_string.
6805         * ada-tasks.c (print_ada_task_info): Use field_string.
6806
6807 2019-07-15  Tom Tromey  <tromey@adacore.com>
6808
6809         * target.c (flash_erase_command): Use field_core_addr.
6810         * symfile.c (generic_load): Use field_core_addr.
6811         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6812         Use field_core_addr.
6813         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6814         field_core_addr.
6815
6816 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6819         value if its desired type is smaller than a CORE_ADDR and signed.
6820
6821 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6824         of changes to field names, and use new is_reference field to
6825         decide if a property is a reference or not.
6826         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6827         field.
6828         (struct dwarf2_property_baton): Update header comment, rename
6829         'referenced_type' to 'property_type' and update comments.
6830         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6831         default property type, store in property baton, update to take
6832         accound of renamed field.
6833         (read_func_scope): Update call to attr_to_dynamic_prop.
6834         (read_array_type): Likewise.
6835         (dwarf2_per_cu_addr_sized_int_type): New function.
6836         (read_subrange_index_type): Move type finding code to
6837         dwarf2_per_cu_addr_sized_int_type.
6838         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6839         (dwarf2_per_cu_addr_type): New function.
6840         (set_die_type): Update calls to attr_to_dynamic_prop.
6841
6842 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * dwarf2read.c (read_subrange_index_type): New function.
6845         (read_subrange_type): Move code into new function and call it.
6846         * gdbtypes.c (create_range_type): Add some asserts.
6847
6848 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6849
6850         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6851         update return statements.
6852         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6853         declaration, and update comment to match.
6854         * gdbtypes.c (resolve_dynamic_array): Update call to
6855         dwarf2_evaluate_property to match new return type.
6856
6857 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6858
6859         * valarith.c (value_subscripted_rvalue): Change lowerbound
6860         parameter type from int to LONGEST.
6861         * value.h (value_subscripted_rvalue): Likewise in declaration.
6862
6863 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * cli/cli-utils.c (info_print_command_completer): New function.
6866         * cli/cli-utils.h: Add 'completer.h' include, and forward
6867         declaration for 'struct cmd_list_element'.
6868         (info_print_command_completer): Declare.
6869         * stack.c (_initialize_stack): Add completer for 'info locals' and
6870         'info args'.
6871         * symtab.c (_initialize_symtab): Add completer for 'info
6872         variables' and 'info functions'.
6873         * NEWS: Mention completion for additional info commands.
6874
6875 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6876
6877         * cli/cli-utils.c (extract_info_print_args): Delete.
6878         (extract_arg_maybe_quoted): Delete.
6879         (info_print_options_defs): New variable.
6880         (make_info_print_options_def_group): New function.
6881         (extract_info_print_options): Define new function.
6882         * cli/cli-utils.h (extract_info_print_args): Delete.
6883         (struct info_print_options): New structure.
6884         (extract_info_print_options): Declare new function.
6885         * stack.c (info_locals_command): Update to use new
6886         extract_info_print_options, also add a header comment.
6887         (info_args_command): Likewise.
6888         * symtab.c (info_variables_command): Likewise.
6889         (info_functions_command): Likewise.
6890
6891 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6892
6893         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6894         to extract string arguments.
6895         * common/common-utils.c (extract_string_maybe_quoted): New function.
6896         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6897
6898 2019-07-11  Tom Tromey  <tromey@adacore.com>
6899
6900         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6901         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6902         * top.h (gdbinit): Don't declare.
6903         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6904         into...
6905         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6906         * top.c (gdb_init): Don't call init_cli_cmds.
6907         (gdbinit): Remove.
6908         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6909
6910 2019-07-11  Tom Tromey  <tromey@adacore.com>
6911
6912         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6913         after it has been moved.
6914
6915 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6916
6917         * valops.c (value_must_coerce_to_target): Change return type to
6918         bool.
6919         * value.h (value_must_coerce_to_target): Likewise.
6920
6921 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6922
6923         * breakpoint.c (is_hardware_watchpoint): Remove
6924         forward-declaration.
6925         (is_masked_watchpoint): Change return type to bool.
6926         (is_tracepoint): Likewise.
6927         (is_breakpoint): Likewise.
6928         (is_hardware_watchpoint): Likewise.
6929         (is_watchpoint): Likewise.
6930         (is_no_memory_software_watchpoint): Likewise.
6931         (is_catchpoint): Likewise.
6932         (breakpoint_1): Make FILTER parameter's return type bool.
6933         is_masked_watchpoint): Change return type to bool.
6934         (save_breakpoints): Make FILTER parameter's return type bool.
6935         * breakpoint.h (is_breakpoint): Change return type to bool.
6936         (is_watchpoint): Likewise.
6937         (is_catchpoint): Likewise.
6938         (is_tracepoint): Likewise.
6939
6940 2019-07-10  Tom Tromey  <tom@tromey.com>
6941
6942         * defs.h: Don't include gdbarch.h.
6943         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6944         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6945         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6946         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6947         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6948         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6949         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6950         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6951         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6952         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6953         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6954         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6955         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6956         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6957         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6958         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6959         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6960         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6961         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6962         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6963         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6964         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6965         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6966         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6967         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6968         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6969         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6970
6971 2019-07-10  Tom Tromey  <tromey@adacore.com>
6972
6973         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6974         * breakpoint.c (init_ada_exception_breakpoint): Register as
6975         bp_catchpoint.
6976         (print_one_breakpoint_location, print_one_breakpoint): Use
6977         is_ada_exception_catchpoint.
6978         * ada-lang.c (class ada_catchpoint_location): Pass
6979         bp_loc_software_breakpoint to bp_location constructor.
6980         (is_ada_exception_catchpoint): New function.
6981
6982 2019-07-10  Tom Tromey  <tromey@adacore.com>
6983
6984         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6985         VEC.
6986         (struct arm_exidx_entry): New method operator<.
6987         (struct arm_exidx_data) <section_maps>: Change type.
6988         (arm_exidx_data_free): Remove.
6989         (arm_exidx_data_key): Change type.  Move lower.
6990         (arm_exidx_new_objfile): Update.
6991         (arm_compare_exidx_entries): Remove.
6992         (arm_find_exidx_entry, _initialize_arm_tdep)
6993
6994 2019-07-10  Tom Tromey  <tromey@adacore.com>
6995
6996         * solib-spu.c (ocl_program_data_key): Change type.
6997         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6998         Update.
6999
7000 2019-07-10  Tom Tromey  <tromey@adacore.com>
7001
7002         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7003         (struct solib_aix_inferior_data) <library_list>: Change type.
7004         (solib_aix_inferior_data_handle): Change type.
7005         (get_solib_aix_inferior_data): Update.
7006         (solib_aix_free_library_list): Remove.
7007         (library_list_start_library): Update.
7008         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7009         return type.
7010         (solib_aix_get_library_list)
7011         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7012         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7013
7014 2019-07-10  Tom Tromey  <tromey@adacore.com>
7015
7016         * solib-dsbt.c (struct dsbt_info): Add initializers.
7017         (solib_dsbt_pspace_data): Change type.
7018         (dsbt_pspace_data_cleanup): Remove.
7019         (get_dsbt_info, _initialize_dsbt_solib): Update.
7020
7021 2019-07-10  Tom Tromey  <tromey@adacore.com>
7022
7023         * spu-tdep.c (spu_overlay_data): Change type.
7024         (spu_get_overlay_table, spu_overlay_new_objfile)
7025         (_initialize_spu_tdep): Update.
7026
7027 2019-07-10  Tom Tromey  <tromey@adacore.com>
7028
7029         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7030         destructor.
7031         (dbx_objfile_data_key): Change type and declare later.
7032         (DBX_SYMFILE_INFO): Rewrite.
7033         * dbxread.c (dbx_objfile_data_key): Change type.
7034         (dbx_symfile_init): Update.
7035         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7036         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7037         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7038
7039 2019-07-10  Tom Tromey  <tromey@adacore.com>
7040
7041         * jit.c (jit_program_space_key): Change type.  Move lower.
7042         (get_jit_program_space_data): Update.
7043         (jit_program_space_data_cleanup): Remove.
7044         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7045         Update.
7046         (struct jit_program_space_data): Add initializers.
7047
7048 2019-07-10  Tom Tromey  <tromey@adacore.com>
7049
7050         * solib-darwin.c (struct darwin_info): Add initializers.
7051         (solib_darwin_pspace_data): Change type.
7052         (darwin_pspace_data_cleanup): Remove.
7053         (get_darwin_info, _initialize_darwin_solib): Update.
7054
7055 2019-07-10  Tom Tromey  <tromey@adacore.com>
7056
7057         * remote-sim.c (struct sim_inferior_data): Add initializers,
7058         constructor, and destructor.
7059         (sim_inferior_data_key): Change type.  Move lower.
7060         (check_for_duplicate_sim_descriptor): Update.
7061         (get_sim_inferior_data): Use new.  Update.
7062         (~sim_inferior_data_cleanup): Rename from
7063         sim_inferior_data_cleanup.  Simplify.
7064         (gdbsim_close_inferior, simulator_command)
7065         (sim_command_completer, _initialize_remote_sim): Update.
7066         (next_pid, INITIAL_PID): Move earlier.
7067
7068 2019-07-10  Tom Tromey  <tromey@adacore.com>
7069
7070         * python/python-internal.h (create_thread_object): Return
7071         gdbpy_ref.
7072         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7073         * python/py-inferior.c (struct threadlist_entry): Add
7074         constructor.
7075         <thread_obj>: Now a gdbpy_ref.
7076         (thread_to_thread_object): Update.
7077         (add_thread_object): Use new.
7078         (delete_thread_object): Use delete.
7079         (infpy_threads): Update.
7080         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7081         GIL.
7082
7083 2019-07-10  Tom Tromey  <tromey@adacore.com>
7084
7085         * valops.c (value_cast): Specialize error message for Ada.
7086
7087 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7088
7089         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7090
7091 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7092
7093         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7094         bpstat_should_step): Return bool, adjust comments.
7095         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7096         bpstat_should_step): Likewise.
7097
7098 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7099
7100         * features/Makefile: Use feature target descriptions for Arm.
7101         * features/arm/arm-core.c: Generate new file.
7102         * features/arm/arm-fpa.c: Likewise.
7103         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7104         * features/arm/arm-m-profile.c: Likewise.
7105         * features/arm/arm-vfpv2.c: Likewise.
7106         * features/arm/arm-vfpv3.c: Likewise.
7107         * features/arm/xscale-iwmmxt.c: Likewise.
7108         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7109
7110 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7111
7112         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7113         ptrace earlier.
7114
7115 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7116
7117         * features/aarch64-pauth.c: Regenerate.
7118
7119 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7120
7121         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7122         bool.
7123         (bpstat_what): Use false instead of 0.
7124
7125 2019-07-09  Pedro Alves  <palves@redhat.com>
7126
7127         * break-catch-throw.c (is_exception_catchpoint): New.
7128         * breakpoint.c (print_one_breakpoint_location): New parameter
7129         'raw_loc'.  Handle it.  Use
7130         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7131         looking at the breakpoint's type.
7132         (print_one_breakpoint): If handling "maint info breakpoints", also
7133         print locations of exception catchpoints.
7134         * breakpoint.h (is_exception_catchpoint): Declare.
7135
7136 2019-07-09  Pedro Alves  <palves@redhat.com>
7137
7138         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7139         "addr" field.
7140         (allocate_location_exception_catchpoint): New.
7141         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7142         (initialize_throw_catchpoint_ops): Install
7143         allocate_location_exception_catchpoint as allocate_location
7144         method.
7145         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7146         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7147         bp_loc_other.
7148         (breakpoint_address_is_meaningful): Delete.
7149         (bl_address_is_meaningful): New.
7150         (breakpoint_locations_match): Adjust comment.
7151         (bp_location_from_bp_type): New, factored out of...
7152         (bp_location::bp_location(breakpoint *)): ... this.
7153         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7154         factored out of...
7155         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7156         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7157         breakpoint_address_is_meaningful.
7158         (bp_locations_compare): Adjust comment.
7159         (update_global_location_list): Use bl_address_is_meaningful
7160         instead of breakpoint_address_is_meaningful.
7161         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7162         explicit.
7163         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7164         * python/py-breakpoint.c (bppy_get_location): No longer check
7165         whether location is null.
7166
7167 2019-07-09  Pedro Alves  <palves@redhat.com>
7168
7169         PR c++/15468
7170         * breakpoint.c (print_one_breakpoint_location): Remove
7171         single-location assert.
7172
7173 2019-07-09  Tom Tromey  <tom@tromey.com>
7174
7175         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7176         * configure: Rebuild.
7177         * configure.ac: Change common to gdbsupport.
7178         * gdbsupport: Rename from common.
7179         * acinclude.m4: Change common to gdbsupport.
7180         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7181         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7182         gdbsupport.
7183         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7184         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7185         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7186         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7187         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7188         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7189         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7190         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7191         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7192         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7193         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7194         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7195         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7196         coff-pe-read.c, command.h, compile/compile-c-support.c,
7197         compile/compile-c.h, compile/compile-cplus-symbols.c,
7198         compile/compile-cplus-types.c, compile/compile-cplus.h,
7199         compile/compile-loc2c.c, compile/compile.c, completer.c,
7200         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7201         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7202         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7203         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7204         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7205         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7206         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7207         features/aarch64-core.c, features/aarch64-fpu.c,
7208         features/aarch64-pauth.c, features/aarch64-sve.c,
7209         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7210         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7211         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7212         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7213         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7214         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7215         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7216         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7217         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7218         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7219         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7220         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7221         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7222         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7223         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7224         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7225         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7226         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7227         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7228         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7229         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7230         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7231         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7232         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7233         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7234         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7235         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7236         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7237         minsyms.c, mips-linux-tdep.c, namespace.h,
7238         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7239         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7240         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7241         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7242         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7243         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7244         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7245         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7246         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7247         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7248         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7249         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7250         procfs.c, producer.c, progspace.h, psymtab.h,
7251         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7252         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7253         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7254         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7255         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7256         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7257         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7258         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7259         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7260         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7261         target-memory.c, target.c, target.h, target/waitstatus.c,
7262         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7263         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7264         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7265         unittests/array-view-selftests.c,
7266         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7267         unittests/common-utils-selftests.c,
7268         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7269         unittests/format_pieces-selftests.c,
7270         unittests/function-view-selftests.c,
7271         unittests/lookup_name_info-selftests.c,
7272         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7273         unittests/mkdir-recursive-selftests.c,
7274         unittests/observable-selftests.c,
7275         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7276         unittests/parse-connection-spec-selftests.c,
7277         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7278         unittests/scoped_fd-selftests.c,
7279         unittests/scoped_mmap-selftests.c,
7280         unittests/scoped_restore-selftests.c,
7281         unittests/string_view-selftests.c, unittests/style-selftests.c,
7282         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7283         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7284         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7285         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7286         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7287         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7288
7289 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7292         bool value.
7293         (decode_digits_ordinary): Set explicit_line field in sal.
7294         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7295         symtab_and_line that was set on an explicit line number in
7296         assembler code.  Do always update the recorded symtab and line if
7297         we do skip the prologue.
7298
7299 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7300
7301         * breakpoint.c (set_breakpoint_location_function): Remove
7302         explicit_loc parameter.
7303         (momentary_breakpoint_from_master): Update call to
7304         set_breakpoint_location_function.
7305         (add_location_to_breakpoint): Likewise.
7306
7307 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7308
7309         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7310         required features based on default bfd type when no specific bfd
7311         is present.
7312
7313 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7314
7315         * NEWS: Mention that GDB printf and eval commands can now print
7316         C-style and Ada-style convenience var strings without
7317         calling the inferior.
7318         * printcmd.c (printf_c_string): Locally print GDB internal var
7319         instead of transiting via the inferior.
7320         (printf_wide_c_string): Likewise.
7321
7322 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7323
7324         PR breakpoints/25011
7325         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7326
7327 2019-07-04  Tom Tromey  <tom@tromey.com>
7328
7329         PR tui/24724:
7330         * tui/tui-winsource.c (tui_clear_source_content): Update.
7331         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7332         (tui_update_breakpoint_info): Update.
7333         (tui_set_exec_info_content): Update.
7334         * tui/tui-source.c (tui_set_source_content_nil): Update.
7335         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7336         has_break.
7337         * tui/tui-data.h (enum tui_bp_flag): New.
7338         (tui_bp_flags): New enum flags type.
7339         (struct tui_source_element) <break_mode>: Change type.  Rename
7340         from has_break.
7341         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7342         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7343         constants.
7344         * tui/tui-winsource.h: Fix comment.
7345
7346 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7347
7348         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7349         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7350         (store_fpregs_to_thread)
7351         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7352         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7353         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7354         (IWMMXT_REGS_SIZE): Add define.
7355         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7356         (fetch_vfp_regs, store_vfp_regs)
7357         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7358         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7359
7360 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7361
7362         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7363         defines.
7364         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7365         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7366         (ARM_INT_REGISTER_SIZE): ...to this.
7367         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7368         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7369         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7370         (arm_linux_collect_gregset, supply_nwfpe_register)
7371         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7372         defines.
7373         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7374         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7375         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7376         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7377         (arm_return_in_memory, arm_store_return_value)
7378         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7379         (arm_record_ld_st_multiple): Likewise.
7380         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7381         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7382
7383 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7384
7385         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7386         AARCH64_DISPLACED_MODIFIED_INSNS.
7387         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7388         (aarch64_displaced_step_copy_insn): Likewise.
7389         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7390         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7391         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7392         ARM_DISPLACED_MODIFIED_INSNS.
7393         * arm-tdep.c (arm_gdbarch_init): Likewise.
7394         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7395         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7396         (struct arm_displaced_step_closure): Use
7397         ARM_DISPLACED_MODIFIED_INSNS.
7398
7399 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7400
7401         * features/Makefile: Remove unused xml files.
7402         * features/aarch64.xml: Remove.
7403         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7404         * features/i386/amd64-avx-avx512.xml: Remove.
7405         * features/i386/amd64-avx-linux.xml: Remove.
7406         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7407         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7408         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7409         * features/i386/amd64-avx-mpx.xml: Remove.
7410         * features/i386/amd64-avx.xml: Remove.
7411         * features/i386/amd64-linux.xml: Remove.
7412         * features/i386/amd64-mpx-linux.xml: Remove.
7413         * features/i386/amd64-mpx.xml: Remove.
7414         * features/i386/amd64.xml: Remove.
7415         * features/i386/i386-avx-avx512-linux.xml: Remove.
7416         * features/i386/i386-avx-avx512.xml: Remove.
7417         * features/i386/i386-avx-linux.xml: Remove.
7418         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7419         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7420         * features/i386/i386-avx-mpx-linux.xml: Remove.
7421         * features/i386/i386-avx-mpx.xml: Remove.
7422         * features/i386/i386-avx.xml: Remove.
7423         * features/i386/i386-linux.xml: Remove.
7424         * features/i386/i386-mmx-linux.xml: Remove.
7425         * features/i386/i386-mmx.xml: Remove.
7426         * features/i386/i386-mpx-linux.xml: Remove.
7427         * features/i386/i386-mpx.xml: Remove.
7428         * features/i386/i386.xml: Remove.
7429         * features/i386/x32-avx-avx512-linux.xml: Remove.
7430         * features/i386/x32-avx-linux.xml: Remove.
7431         * features/i386/x32-linux.xml: Remove.
7432
7433 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7434
7435         * regformats/aarch64.dat: Remove.
7436         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7437         * regformats/i386/amd64-avx-linux.dat: Remove.
7438         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7439         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7440         * regformats/i386/amd64-linux.dat: Remove.
7441         * regformats/i386/amd64-mpx-linux.dat: Remove.
7442         * regformats/i386/amd64.dat: Remove.
7443         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7444         * regformats/i386/i386-avx-linux.dat: Remove.
7445         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7446         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7447         * regformats/i386/i386-linux.dat: Remove.
7448         * regformats/i386/i386-mmx-linux.dat: Remove.
7449         * regformats/i386/i386-mpx-linux.dat: Remove.
7450         * regformats/i386/i386.dat: Remove.
7451         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7452         * regformats/i386/x32-avx-linux.dat: Remove.
7453         * regformats/i386/x32-linux.dat: Remove.
7454
7455 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7456
7457         * aarch64-tdep.c: Remove xml self tests.
7458         * amd64-linux-tdep.c: Likewise.
7459         * amd64-tdep.c: Likewise.
7460         * i386-linux-tdep.c: Likewise.
7461         * i386-tdep.c: Likewise.
7462
7463 2019-07-03  Pedro Alves  <palves@redhat.com>
7464
7465         PR cli/24732
7466         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7467         (pipe_cmd_option_defs): New.
7468         (make_pipe_cmd_options_def_group): New.
7469         (pipe_command): Use gdb::option::process_options.
7470         (pipe_command_completer): New function.
7471         (_initialize_cli_cmds): Install completer for "pipe" command.
7472
7473 2019-07-03  Pedro Alves  <palves@redhat.com>
7474
7475         * cli/cli-option.c (union option_value) <string>: New field.
7476         (struct option_def_and_value): Add ctor, move ctor, dtor and
7477         use DISABLE_COPY_AND_ASSIGN.
7478         (option_def_and_value::clear_value): New.
7479         (parse_option, save_option_value_in_ctx, get_val_type_str)
7480         (add_setshow_cmds_for_options): Handle var_string.
7481         * cli-option.h (union option_def::var_address) <string>: New
7482         field.
7483         (struct string_option_def): New.
7484         * maint-test-options.c (struct test_options_opts): Add default
7485         ctor and use DISABLE_COPY_AND_ASSIGN.
7486         <string_opt>: New field.
7487         (test_options_opts::~test_options_opts): New.
7488         (test_options_opts::dump): Also dump "-string".
7489         (test_options_option_defs): Install "string.
7490
7491 2019-07-03  Pedro Alves  <palves@redhat.com>
7492
7493         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7494         option_value with a null enumeration.
7495         (complete_options): Save the option values in the context.
7496         (save_option_value_in_ctx): New, factored out from ...
7497         (process_options): ... here.
7498         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7499         of the function.
7500         * maint-test-options.c (test_options_opts::dump): New, factored
7501         out from ...
7502         (maintenance_test_options_command_mode): ... here.
7503         (maintenance_test_options_command_completion_result): Delete.
7504         (maintenance_test_options_command_completion_text): Update
7505         comment.
7506         (maintenance_show_test_options_completion_result): Change
7507         prototype.  Just print
7508         maintenance_test_options_command_completion_text.
7509         (save_completion_result): New.
7510         (maintenance_test_options_completer_mode): Pass options context to
7511         complete_options, and then save a dump.
7512         (_initialize_maint_test_options): Use add_cmd to install "maint
7513         show test-options-completion-result".
7514
7515 2019-07-03  Pedro Alves  <palves@redhat.com>
7516
7517         * NEWS (New commands): Mention "with" and "maint with".
7518         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7519         (with_command, with_command_completer): New.
7520         (pipe_command): Adjust to new repeat_previous
7521         interface.
7522         (_initialize_cli_cmds): Install the "with" command and its "w"
7523         alias.
7524         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7525         declarations.
7526         * cli/cli-setshow.c (parse_cli_var_uinteger)
7527         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7528         argument strings for all var_types.
7529         (get_setshow_command_value_string): New, factored out from ...
7530         (do_show_command): ... this.
7531         * cli/cli-setshow.h: Include <string>.
7532         (get_setshow_command_value_string): Declare.
7533         * command.h (repeat_previous): Now returns const char *.  Adjust
7534         comment.
7535         * maint.c: Include "cli/cli-cmds.h".
7536         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7537         (_initialize_maint_cmds): Register the "maintenance with" command.
7538         * top.c (repeat_previous): Move bits from pipe_command here:
7539         Return the saved command line, if any; error out if there's no
7540         command to relaunch.
7541
7542 2019-07-03  Pedro Alves  <palves@redhat.com>
7543
7544         * NEWS (New commands): Mention "maint set/show test-settings"
7545         instead of "maint test-settings".
7546         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7547         (maintenance_test_settings_set_list): Rename to ...
7548         (maintenance_set_test_settings_list): ... this.
7549         (maintenance_test_settings_show_list): Rename to  ...
7550         (maintenance_show_test_settings_list): ... this.
7551         (maintenance_test_settings_cmd): Delete.
7552         (maintenance_test_settings_set_cmd): ...
7553         (maintenance_set_test_settings_cmd): ... this.
7554         (maintenance_test_settings_show_cmd): ...
7555         (maintenance_show_test_settings_cmd): ... this.
7556         (maintenance_test_settings_show_value_cmd):
7557         (maintenance_show_test_settings_value_cmd): ... this.
7558         (_initialize_maint_test_settings): No longer install the "maint
7559         test-settings" prefix command.  Rename "maint test-settings set"
7560         to "maint set test-settings", and "maint test-settings show" to
7561         "maint show test-settings".  Adjust all subcommands.
7562
7563 2019-07-03  Pedro Alves  <palves@redhat.com>
7564
7565         * maint-test-settings.c: Fix file's intro comment.  Replace all
7566         references to "test-options" with references to "test-settings",
7567         in comments.
7568
7569 2019-07-03  Pedro Alves  <palves@redhat.com>
7570
7571         * maint-test-settings.c (maintenance_test_settings_xxx)
7572         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7573         New.
7574         (maintenance_test_settings_enums): Use them.
7575         (maintenance_test_settings_enum): Default to
7576         maintenance_test_settings_xxx.
7577         (_initialize_maint_test_settings): Initialize
7578         MAINTENANCE_TEST_SETTINGS_FILENAME.
7579
7580 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7581
7582         * breakpoint.h (remove_breakpoints_inf): Change return type to
7583         void, move function documentation here.
7584         * breakpoint.c (remove_breakpoints_inf): Change return type to
7585         void, move function documentation to header.
7586
7587 2019-07-02  Pedro Alves  <palves@redhat.com>
7588
7589         * NEWS (Completion improvements): Mention "info threads".
7590         * thread.c (struct info_threads_opts, info_threads_option_defs)
7591         (make_info_threads_options_def_group): New.
7592         (info_threads_command): Use gdb::option::process_options.
7593         (info_threads_command_completer): New.
7594         (_initialize_thread): Use gdb::option::build_help to build the
7595         help text for "info threads".
7596
7597 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7598
7599         * defs.h (generic_load): Move from here...
7600         * symfile.h (generic_load): ... to here.  Rename name parameter
7601         to args.
7602         * symfile.c (generic_load): Add comment.
7603
7604 2019-07-01  Tom Tromey  <tromey@adacore.com>
7605
7606         * dwarf2read.c
7607         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7608         declaration of without_params.  Fix formatting.
7609
7610 2019-07-01  Tom Tromey  <tromey@adacore.com>
7611
7612         * ada-exp.y (find_primitive_type): Update.
7613         * ada-lang.h (ada_lookup_symbol): Update.
7614         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7615         parameter.
7616         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7617
7618 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7619
7620         PR breakpoints/24541
7621         * gdbarch.c: Regenerate.
7622         * gdbarch.h: Regenerate.
7623         * gdbarch.sh: Add 'stap_adjust_register'.
7624         * i386-tdep.c: Include '<unordered_set>'.
7625         (i386_stap_adjust_register): New function.
7626         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7627         * stap-probe.c (stap_parse_register_operand): Call
7628         'gdbarch_stap_adjust_register'.
7629
7630 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7631
7632         PR python/24742
7633         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7634         * python/python.c (do_start_initialization): Use 'xmalloc'
7635         instead of 'PyMem_Malloc'.
7636
7637 2019-06-28  Tom Tromey  <tromey@adacore.com>
7638
7639         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7640         for Ada.
7641
7642 2019-06-27  Tom Tromey  <tromey@adacore.com>
7643
7644         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7645         objfile_key.
7646         (arm_find_mapping_symbol, arm_record_special_symbol)
7647         (_initialize_arm_tdep): Update.
7648         (arm_objfile_data_free): Remove.
7649
7650 2019-06-27  Tom Tromey  <tromey@adacore.com>
7651
7652         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7653         to cp_print_static_field.
7654
7655 2019-06-26  Tom Tromey  <tromey@adacore.com>
7656
7657         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7658         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7659         declare.
7660
7661 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7662
7663         * features/aarch64-core.c (create_feature_aarch64_core):
7664         Regenerate.
7665         * features/aarch64-core.xml: Add cpsr flags.
7666
7667 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7668
7669         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7670         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7671
7672 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7673
7674         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7675         field.
7676         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7677         use.
7678         (arm_record_special_symbol): Don't insert new symbol in sorted
7679         position, push it at the end.
7680
7681 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7682
7683         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7684         (arm_mapping_symbol_s): Remove.
7685         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7686         (arm_mapping_symbol_vec): New typedef.
7687         (struct arm_per_objfile): Add constructor.
7688         <section_maps>: Change type to
7689         std::unique_ptr<arm_mapping_symbol_vec[]>.
7690         (arm_compare_mapping_symbols): Remove.
7691         (arm_find_mapping_symbol): Adjust to section_maps type change.
7692         (arm_objfile_data_free): Call delete on arm_per_objfile.
7693         (arm_record_special_symbol): Adjust to section_maps type change.
7694         Allocate arm_per_objfile with new.
7695
7696 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7697
7698         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7699         with the command prefix.
7700
7701 2019-06-25  Tom Tromey  <tom@tromey.com>
7702
7703         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7704         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7705
7706 2019-06-25  Tom Tromey  <tom@tromey.com>
7707
7708         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7709         type.
7710         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7711         protected.
7712
7713 2019-06-25  Tom Tromey  <tom@tromey.com>
7714
7715         * tui/tui-winsource.c
7716         (tui_source_window_base::set_is_exec_point_at): Add check against
7717         LOA_ADDRESS.
7718
7719 2019-06-25  Tom Tromey  <tom@tromey.com>
7720
7721         * tui/tui-source.c (tui_set_source_content): Don't check before
7722         xfree.
7723         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7724
7725 2019-06-25  Tom Tromey  <tom@tromey.com>
7726
7727         * tui/tui-winsource.h (tui_update_source_window_as_is)
7728         (tui_alloc_source_buffer, tui_line_is_displayed)
7729         (tui_addr_is_displayed): Change type of win_info.
7730         * tui/tui-winsource.c (tui_update_source_window_as_is)
7731         (tui_clear_source_content, tui_show_source_line)
7732         (tui_show_source_content, tui_source_window_base::refill)
7733         (tui_source_window_base::set_is_exec_point_at)
7734         (tui_source_window_base::set_is_exec_point_at)
7735         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7736         (tui_alloc_source_buffer, tui_line_is_displayed)
7737         (tui_addr_is_displayed): Change type of win_info.  Update.
7738         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7739         (tui_source_window_base::do_make_visible_with_new_height):
7740         Update.
7741         * tui/tui-source.c (tui_set_source_content)
7742         (tui_set_source_content_nil)
7743         (tui_source_window::do_scroll_vertical): Update.
7744         * tui/tui-layout.c (show_layout): Update.
7745         * tui/tui-disasm.c (tui_set_disassem_content)
7746         (tui_disasm_window::do_scroll_vertical): Update.
7747         * tui/tui-data.h (tui_win_content): Remove.
7748         (struct tui_gen_win_info) <content, content_size>: Remove.
7749         (struct tui_source_element): Add initializers and destructor.
7750         (union tui_which_element, struct tui_win_element): Remove.
7751         (struct tui_source_window_base) <content>: New field.
7752         (struct tui_data_window): Remove destructor.
7753         (tui_alloc_content, tui_free_win_content)
7754         (tui_free_all_source_wins_content): Don't declare.
7755         * tui/tui-data.c (tui_initialize_static_data): Update.
7756         (init_content_element, tui_alloc_content): Remove.
7757         (~tui_gen_win_info): Update.
7758         (~tui_data_window, tui_free_all_source_wins_content)
7759         (tui_free_win_content, free_content, free_content_elements):
7760         Remove.
7761
7762 2019-06-25  Tom Tromey  <tom@tromey.com>
7763
7764         * tui/tui-winsource.h (tui_clear_source_content)
7765         (tui_erase_source_content, tui_show_source_content): Change type
7766         of win_info.
7767         * tui/tui-winsource.c (tui_clear_source_content)
7768         (tui_erase_source_content, tui_show_source_content): Change type
7769         of win_info.
7770         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7771         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7772         win_info.
7773         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7774         win_info.
7775         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7776
7777 2019-06-25  Tom Tromey  <tom@tromey.com>
7778
7779         * tui/tui-winsource.c (tui_clear_source_content)
7780         (tui_source_window_base::set_is_exec_point_at): Update.
7781         * tui/tui-source.c (tui_set_source_content_nil): Update.
7782         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7783         a bool.
7784         * tui/tui-data.c (init_content_element): Update.
7785
7786 2019-06-25  Tom Tromey  <tom@tromey.com>
7787
7788         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7789         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7790         * tui/tui-layout.c (init_and_make_win): Update.
7791         * tui/tui.h (enum tui_win_type): Update.
7792         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7793         tui_win_is_auxillary.
7794         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7795         tui_win_is_auxillary.
7796
7797 2019-06-25  Tom Tromey  <tom@tromey.com>
7798
7799         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7800         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7801         (tui_delete_data_content_windows, tui_display_all_data)
7802         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7803         Update.
7804         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7805         * tui/tui-regs.c (tui_last_regs_line_no)
7806         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7807         (tui_show_registers): Update.
7808         (tui_show_register_group): Return void.  Update.
7809         (tui_display_registers_from, tui_display_reg_element_at_line)
7810         (tui_display_registers_from_line, tui_check_register_values):
7811         Update.
7812         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7813         member.
7814         (struct tui_data_window) <regs_content>: Now a std::vector.
7815         <regs_content_count>: Remove.
7816         (tui_add_content_elements, tui_free_data_content): Don't declare.
7817         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7818         (init_content_element): Remove DATA_WIN case.  Add assert.
7819         (tui_add_content_elements): Remove.
7820         (tui_data_window): Update.
7821         (tui_free_data_content): Remove.
7822         (free_content_elements): Remove DATA_WIN case.
7823
7824 2019-06-25  Tom Tromey  <tom@tromey.com>
7825
7826         * tui/tui-data.c (tui_data_item_window): Update.
7827         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7828         * tui/tui-windata.c (tui_display_all_data)
7829         (tui_display_data_from_line): Update.
7830         (tui_check_data_values): Remove.
7831         * tui/tui-regs.c (tui_show_register_group)
7832         (tui_display_reg_element_at_line): Update.
7833         * tui/tui-hooks.c (tui_register_changed)
7834         (tui_refresh_frame_and_register_information): Call
7835         tui_check_register_values.
7836         * tui/tui-data.h (struct tui_data_window) <data_content,
7837         data_content_count, data_type>: Remove.
7838         (enum tui_data_type): Remove.
7839
7840         * tui/tui-data.c (tui_data_window::clear_detail)
7841         (~tui_data_window): Update.
7842
7843 2019-06-25  Tom Tromey  <tom@tromey.com>
7844
7845         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7846         declare.
7847         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7848         Rename from tui_first_data_item_displayed.  Update.
7849         (tui_data_window::refresh_all)
7850         (tui_data_window::do_scroll_vertical): Update.
7851         * tui/tui-data.h (struct tui_data_window)
7852         <first_data_item_displayed>: Declare new method.
7853
7854 2019-06-25  Tom Tromey  <tom@tromey.com>
7855
7856         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7857         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7858         contents...
7859         (tui_initialize_static_data): ...here.
7860
7861 2019-06-25  Tom Tromey  <tom@tromey.com>
7862
7863         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7864         (tui_display_registers_from, tui_check_register_values): Update.
7865         (tui_display_register): Remove win_info parameter; update.
7866         (tui_get_register): Change type of parameters.
7867         * tui/tui-data.h (struct tui_data_element): Remove.
7868         (union tui_which_element) <data>: Remove.
7869         <data_window>: Change type.
7870         (struct tui_data_item_window): New.
7871         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7872         case.  Add assert.
7873         (~tui_data_item_window): New destructor.
7874         (free_content_elements): Remove DATA_ITEM_WIN case.
7875
7876 2019-06-25  Tom Tromey  <tom@tromey.com>
7877
7878         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7879         Remove.
7880
7881 2019-06-25  Tom Tromey  <tom@tromey.com>
7882
7883         * tui/tui-data.h (struct tui_command_element): Remove.
7884         (union tui_which_element) <command>: Remove.
7885         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7886         assert.
7887         (free_content_elements): Remove CMD_WIN case.
7888
7889 2019-06-25  Tom Tromey  <tom@tromey.com>
7890
7891         * tui/tui-layout.c (tui_set_layout): Update.
7892         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7893         * tui/tui-data.c (layout_def): Update.
7894
7895 2019-06-25  Tom Tromey  <tom@tromey.com>
7896
7897         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7898         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7899         (tui_source_window_base::set_new_height): Update.
7900         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7901         Update.
7902         (tui_set_locator_fullname, tui_set_locator_info)
7903         (tui_show_frame_info): Update.
7904         * tui/tui-source.c (tui_set_source_content)
7905         (tui_source_is_displayed): Update.
7906         * tui/tui-layout.c (show_source_disasm_command, show_data)
7907         (show_source_or_disasm_and_command): Update.
7908         * tui/tui-disasm.c (tui_set_disassem_content)
7909         (tui_get_begin_asm_address): Update.
7910         * tui/tui-data.h (struct tui_locator_element): Remove.
7911         (union tui_which_element) <locator>: Remove.
7912         (struct tui_locator_window): New.
7913         (tui_locator_win_info_ptr): Change return type.
7914         * tui/tui-data.c (_locator): Change type.
7915         (tui_locator_win_info_ptr): Change return type.
7916         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7917         (tui_alloc_content): Add assert.
7918
7919 2019-06-25  Tom Tromey  <tom@tromey.com>
7920
7921         * tui/tui-winsource.c
7922         (tui_exec_info_window::maybe_allocate_content): New method.
7923         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7924         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7925         (make_source_or_disasm_window): Add cast.
7926         * tui/tui-data.h (union tui_which_element) <simple_string>:
7927         Remove.
7928         (struct tui_source_info): New.
7929         (struct tui_source_window_base) <execution_info>: Change type.
7930         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7931         case, and add assert.
7932         (tui_alloc_content): Add assert.
7933
7934 2019-06-25  Tom Tromey  <tom@tromey.com>
7935
7936         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7937         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7938         * tui/tui-data.c (tui_alloc_win_info): Remove.
7939
7940 2019-06-25  Tom Tromey  <tom@tromey.com>
7941
7942         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7943         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7944         can_highlight.
7945
7946 2019-06-25  Tom Tromey  <tom@tromey.com>
7947
7948         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7949         make_visible_with_new_height method.
7950         (tui_win_info::make_visible_with_new_height): New method.
7951         (tui_source_window_base::do_make_visible_with_new_height)
7952         (tui_data_window::do_make_visible_with_new_height)
7953         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7954         (make_visible_with_new_height): Remove.
7955         (tui_resize_all, tui_adjust_win_heights): Use
7956         make_visible_with_new_height method.
7957         * tui/tui-data.h (struct tui_win_info)
7958         <do_make_visible_with_new_height, make_visible_with_new_height>:
7959         New methods.
7960         (struct tui_source_window_base, struct tui_data_window)
7961         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7962         methods.
7963
7964 2019-06-25  Tom Tromey  <tom@tromey.com>
7965
7966         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7967         method.
7968         (update_tab_width): Call update_tab_width method.
7969         * tui/tui-data.h (struct tui_win_info)
7970         (struct tui_source_window_base) <update_tab_width>: New methods.
7971
7972 2019-06-25  Tom Tromey  <tom@tromey.com>
7973
7974         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7975         parameter.
7976         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7977         parameter.
7978         (tui_gen_win_info::make_visible): Update.
7979         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7980         parameter.
7981         * tui/tui-data.h (enum tui_box): New enum.
7982         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7983
7984 2019-06-25  Tom Tromey  <tom@tromey.com>
7985
7986         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7987         init_and_make_win for EXEC_INFO_WIN.
7988         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7989         longer inline.
7990         (struct tui_win_info) <~tui_win_info>: Inline.
7991         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7992         Don't declare.
7993         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7994         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7995         Remove.
7996         (tui_initialize_static_data): Update.
7997         (~tui_gen_win_info): Handle more cleanup here.
7998         (~tui_source_window_base): Delete "execution_info".
7999         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8000
8001 2019-06-25  Tom Tromey  <tom@tromey.com>
8002
8003         * tui/tui-layout.c (make_command_window): Don't set
8004         can_highlight.
8005         (show_source_disasm_command): Call the reset method.
8006         (show_data): Don't set can_highlight.  Call the reset method.
8007         (tui_gen_win_info::reset): Rename from init_gen_win_info
8008         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8009         (show_source_or_disasm_and_command): Call the reset method.
8010         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8011         (struct tui_cmd_window): Set can_highlight.
8012
8013 2019-06-25  Tom Tromey  <tom@tromey.com>
8014
8015         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8016         from make_visible.
8017         (tui_make_visible, tui_make_invisible): Rewrite.
8018         (tui_win_info::make_visible): Remove.
8019         (tui_source_window_base::make_visible): Update.
8020         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8021         method.  Moved from...
8022         (struct tui_win_info) <make_visible>: ...here.
8023
8024 2019-06-25  Tom Tromey  <tom@tromey.com>
8025
8026         * tui/tui-winsource.c
8027         (tui_source_window_base::do_scroll_horizontal): Remove direction
8028         parameter.
8029         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8030         direction parameter.
8031         * tui/tui-win.c (tui_win_info::forward_scroll)
8032         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8033         (tui_win_info::right_scroll): Update.
8034         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8035         direction parameter.
8036         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8037         direction parameter.
8038         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8039         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8040         Remove direction parameter.
8041         (struct tui_source_window_base, struct tui_source_window)
8042         (struct tui_disasm_window, struct tui_data_window)
8043         (struct tui_cmd_window): Update.
8044
8045 2019-06-25  Tom Tromey  <tom@tromey.com>
8046
8047         * tui/tui-winsource.h (tui_set_exec_info_content)
8048         (tui_show_exec_info_content, tui_erase_exec_info_content)
8049         (tui_clear_exec_info_content, tui_update_exec_info): Change
8050         argument to tui_source_window_base.
8051         * tui/tui-winsource.c (tui_set_exec_info_content)
8052         (tui_show_exec_info_content, tui_erase_exec_info_content)
8053         (tui_clear_exec_info_content, tui_update_exec_info): Change
8054         argument to tui_source_window_base.
8055
8056 2019-06-25  Tom Tromey  <tom@tromey.com>
8057
8058         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8059         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8060
8061 2019-06-25  Tom Tromey  <tom@tromey.com>
8062
8063         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8064         check.
8065
8066 2019-06-25  Tom Tromey  <tom@tromey.com>
8067
8068         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8069         type to void.
8070         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8071         type to void.
8072         * tui/tui-source.c (tui_set_source_content): Update.
8073         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8074
8075 2019-06-25  Tom Tromey  <tom@tromey.com>
8076
8077         * tui/tui-win.c (window_name_completer, tui_set_focus)
8078         (tui_all_windows_info): Use name method.
8079         * tui/tui-data.h (struct tui_gen_win_info)
8080         (struct tui_source_window, struct tui_disasm_window)
8081         (struct tui_data_window, struct tui_cmd_window) <name>: New
8082         method.
8083         (tui_win_name): Don't declare.
8084         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8085         (tui_win_name): Remove.
8086
8087 2019-06-25  Tom Tromey  <tom@tromey.com>
8088
8089         * tui/tui-winsource.h (tui_update_source_window)
8090         (tui_update_source_window_as_is): Change parameter type.
8091         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8092         to be a tui_source_window_base.
8093         (tui_update_source_window_as_is): Likewise.
8094         * tui/tui-win.c (make_visible_with_new_height): Update.
8095
8096 2019-06-25  Tom Tromey  <tom@tromey.com>
8097
8098         * tui/tui-winsource.c (tui_erase_source_content)
8099         (tui_show_source_content, tui_show_exec_info_content)
8100         (tui_erase_exec_info_content): Use refresh_window method.
8101         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8102         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8103         from tui_refresh_win.
8104         (tui_data_window::refresh_window): New method.
8105         (tui_win_info::refresh, tui_source_window_base::refresh)
8106         (tui_refresh_all): Use refresh_window method.
8107         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8108         method.
8109         * tui/tui-regs.c (tui_display_register): Call refresh_window
8110         method.
8111         * tui/tui-layout.c (show_source_disasm_command)
8112         (show_source_or_disasm_and_command): Call refresh_window method.
8113         * tui/tui-data.h (struct tui_gen_win_info)
8114         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8115         New method.
8116
8117 2019-06-25  Tom Tromey  <tom@tromey.com>
8118
8119         * tui/tui.c (tui_rl_other_window, tui_enable)
8120         (tui_is_window_visible, tui_get_command_dimension): Update.
8121         * tui/tui-winsource.c (tui_update_source_window_as_is)
8122         (tui_clear_source_content, tui_erase_source_content)
8123         (tui_show_source_line, tui_source_window_base::refill)
8124         (tui_source_window_base::do_scroll_horizontal)
8125         (tui_source_window_base::set_is_exec_point_at)
8126         (tui_update_breakpoint_info, tui_set_exec_info_content)
8127         (tui_alloc_source_buffer, tui_line_is_displayed)
8128         (tui_addr_is_displayed): Update.
8129         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8130         (tui_check_and_display_highlight_if_needed)
8131         (tui_win_info::make_visible, tui_win_info::refresh)
8132         (tui_refresh_all): Update.
8133         * tui/tui-windata.c (tui_first_data_item_displayed)
8134         (tui_delete_data_content_windows, tui_erase_data_content)
8135         (tui_display_all_data, tui_data_window::refresh_all)
8136         (tui_check_data_values): Update.
8137         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8138         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8139         (tui_win_info::backward_scroll, tui_refresh_all_win)
8140         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8141         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8142         (tui_source_window_base::set_new_height)
8143         (tui_data_window::set_new_height)
8144         (make_invisible_and_set_new_height)
8145         (make_visible_with_new_height, new_height_ok)
8146         (parse_scrolling_args): Update.
8147         * tui/tui-stack.c (tui_show_frame_info): Update.
8148         * tui/tui-source.c (tui_set_source_content)
8149         (tui_set_source_content_nil, tui_source_is_displayed)
8150         (tui_source_window::do_scroll_vertical): Update.
8151         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8152         (tui_display_registers_from, tui_display_reg_element_at_line)
8153         (tui_check_register_values, tui_reg_command): Update.
8154         * tui/tui-layout.c (tui_default_win_height)
8155         (show_source_disasm_command, show_data, init_and_make_win)
8156         (show_source_or_disasm_and_command): Update.
8157         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8158         (tui_redisplay_readline, tui_mld_flush)
8159         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8160         (tui_getc): Update.
8161         * tui/tui-disasm.c (tui_set_disassem_content)
8162         (tui_disasm_window::do_scroll_vertical): Update.
8163         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8164         Now virtual.
8165         (struct tui_win_info): Derive from tui_gen_win_info.
8166         <~tui_win_info>: Mark as override.
8167         <generic>: Remove member.
8168         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8169         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8170         (~tui_data_window, ~tui_win_info)
8171         (tui_free_all_source_wins_content): Update.
8172         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8173
8174 2019-06-25  Tom Tromey  <tom@tromey.com>
8175
8176         * tui/tui-layout.c (init_and_make_win): Use new.
8177         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8178         destructor, initializers.
8179         (tui_alloc_generic_win_info): Don't declare.
8180         * tui/tui-data.c (_locator): Add argument to constructor.
8181         (source_win, disasm_win): New globals.
8182         (exec_info): Remove.
8183         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8184         Update.
8185         (tui_alloc_generic_win_info): Remove.
8186         (init_content_element): Use new.
8187         (tui_win_info::tui_win_info): Update.
8188         (free_content_elements) <case DATA_WIN>: Use delete.
8189
8190 2019-06-25  Tom Tromey  <tom@tromey.com>
8191
8192         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8193         * tui/tui-windata.c (tui_first_data_item_displayed)
8194         (tui_delete_data_content_windows): Update.
8195         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8196         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8197         (tui_display_registers_from, tui_check_register_values): Update.
8198         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8199         pointer.
8200         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8201         window.
8202         (tui_free_data_content): Update.
8203         (free_content_elements) <case DATA_WIN>: Free the window.
8204
8205 2019-06-25  Tom Tromey  <tom@tromey.com>
8206
8207         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8208         Update.
8209         * tui/tui-layout.c (make_command_window)
8210         (show_source_disasm_command, show_data, init_and_make_win)
8211         (show_source_or_disasm_and_command): Update.
8212         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8213         method.
8214         <can_highight, is_highlighted>: Now bool.
8215         (tui_set_win_highlight): Don't declare.
8216         * tui/tui-data.c (tui_set_win_highlight): Remove.
8217
8218 2019-06-25  Tom Tromey  <tom@tromey.com>
8219
8220         * tui/tui-wingeneral.c (make_visible): Remove check of window
8221         type.
8222
8223 2019-06-25  Tom Tromey  <tom@tromey.com>
8224
8225         * tui/tui-win.c (tui_win_info::max_height)
8226         (tui_cmd_window::max_height): New methods.
8227         (new_height_ok): Call max_height.
8228         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8229         <max_height>: New method.
8230
8231 2019-06-25  Tom Tromey  <tom@tromey.com>
8232
8233         * tui/tui-win.c (tui_source_window_base::set_new_height)
8234         (tui_data_window::set_new_height): New methods.
8235         (make_invisible_and_set_new_height): Call set_new_height method.
8236         * tui/tui-data.h (struct tui_win_info)
8237         (struct tui_source_window_base, struct tui_data_window)
8238         <set_new_height>: New method.
8239
8240 2019-06-25  Tom Tromey  <tom@tromey.com>
8241
8242         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8243         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8244         tui_refresh_data_win.
8245         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8246         method.
8247         (tui_refresh_all_win): Call the refresh_all method.
8248         (tui_set_focus): Likewise.
8249         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8250         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8251         Likewise.
8252
8253 2019-06-25  Tom Tromey  <tom@tromey.com>
8254
8255         * tui/tui-winsource.h (tui_refill_source_window)
8256         (tui_set_is_exec_point_at): Don't declare.
8257         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8258         (tui_source_window_base::refill): Rename from
8259         tui_refill_source_window.
8260         (tui_source_window_base::do_scroll_horizontal): Update.
8261         (tui_source_window_base::set_is_exec_point_at): Rename from
8262         tui_set_is_exec_point_at.
8263         (tui_update_all_breakpoint_info): Update.
8264         * tui/tui-stack.c (tui_show_frame_info): Update.
8265         * tui/tui-layout.c (show_data): Add cast.
8266         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8267         * tui/tui-data.h (struct tui_source_window_base) <refill,
8268         set_is_exec_point_at>: New methods.
8269         (tui_source_windows, tui_add_to_source_windows): Update types.
8270         (tui_add_to_source_windows): Remove redundant declaration.
8271         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8272         (tui_source_windows): Change return type.
8273         (tui_clear_source_windows_detail): Update.
8274         (tui_add_to_source_windows): Change type of parameter.
8275         (tui_free_all_source_wins_content): Update.
8276
8277 2019-06-25  Tom Tromey  <tom@tromey.com>
8278
8279         * tui/tui-wingeneral.c (tui_win_info::refresh)
8280         (tui_source_window_base::refresh): New methods.
8281         (tui_refresh_all): Call the refresh method.
8282         * tui/tui-data.h (struct tui_win_info)
8283         (struct tui_source_window_base) <refresh>: New method.
8284
8285 2019-06-25  Tom Tromey  <tom@tromey.com>
8286
8287         * tui/tui.h (tui_is_window_visible): Return bool.
8288         * tui/tui.c (tui_is_window_visible): Return bool.
8289         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8290         (tui_make_visible, tui_make_invisible)
8291         (tui_win_info::make_visible)
8292         (tui_source_window_base::make_visible, make_all_visible)
8293         (tui_make_all_visible, tui_make_all_invisible): Update.
8294         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8295         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8296         bool.
8297         (struct tui_win_info, struct tui_source_window_base)
8298         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8299         * tui/tui-data.c (tui_init_generic_part): Update.
8300
8301 2019-06-25  Tom Tromey  <tom@tromey.com>
8302
8303         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8304         (tui_source_window_base::make_visible): New methods.
8305         (make_all_visible): Make method call.
8306         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8307         (struct tui_source_window_base, struct tui_cmd_window): Override
8308         make_visible.
8309         (tui_win_is_source_type): Don't declare.
8310         * tui/tui-data.c (tui_win_is_source_type): Remove.
8311
8312 2019-06-25  Tom Tromey  <tom@tromey.com>
8313
8314         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8315         NULL check.
8316
8317 2019-06-25  Tom Tromey  <tom@tromey.com>
8318
8319         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8320         Inline constructor.  Add initializers for members.
8321         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8322         constructors; now inline in class.
8323
8324 2019-06-25  Tom Tromey  <tom@tromey.com>
8325
8326         * tui/tui-regs.c (tui_show_registers): Update.
8327         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8328         bool.
8329         * tui/tui-data.c (tui_data_window::clear_detail)
8330         (tui_data_window): Update.
8331
8332 2019-06-25  Tom Tromey  <tom@tromey.com>
8333
8334         * tui/tui-windata.c (tui_display_all_data)
8335         (tui_display_data_from_line, tui_display_data_from)
8336         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8337         Update.
8338         * tui/tui-regs.c (tui_last_regs_line_no)
8339         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8340         (tui_show_registers, tui_show_register_group)
8341         (tui_display_registers_from, tui_display_reg_element_at_line)
8342         (tui_display_registers_from_line, tui_check_register_values)
8343         (tui_reg_next, tui_reg_prev): Update.
8344         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8345         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8346         tui_data_window.
8347         (struct tui_win_info) <detail>: Remove.  Add new fields from
8348         tui_data_info.
8349         (TUI_DATA_WIN): Add cast.
8350         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8351         (~tui_data_window): Simplify.
8352
8353 2019-06-25  Tom Tromey  <tom@tromey.com>
8354
8355         * tui/tui-layout.c (show_source_disasm_command)
8356         (show_source_or_disasm_and_command): Update.
8357         * tui/tui-io.c (update_cmdwin_start_line)
8358         (tui_redisplay_readline): Update.
8359         * tui/tui-data.h (struct tui_command_info): Remove.
8360         (struct tui_win_info) <detail>: Remove command_info member.
8361         (struct tui_data_window) <start_line>: New member, from
8362         tui_command_info.
8363         (TUI_CMD_WIN): Add casts.
8364
8365 2019-06-25  Tom Tromey  <tom@tromey.com>
8366
8367         * tui/tui-winsource.c (tui_update_source_window)
8368         (tui_refill_source_window)
8369         (tui_source_window_base::do_scroll_horizontal)
8370         (tui_update_breakpoint_info, tui_set_exec_info_content)
8371         (tui_show_exec_info_content, tui_erase_exec_info_content)
8372         (tui_clear_exec_info_content): Update.
8373         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8374         Update.
8375         * tui/tui-win.c (make_invisible_and_set_new_height)
8376         (make_visible_with_new_height): Update.
8377         * tui/tui-source.c (tui_set_source_content)
8378         (tui_show_symtab_source): Update.
8379         * tui/tui-layout.c (extract_display_start_addr)
8380         (show_source_disasm_command, show_data)
8381         (make_source_or_disasm_window)
8382         (show_source_or_disasm_and_command): Update.
8383         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8384         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8385         "gdbarch".
8386         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8387         to tui_source_window_base.
8388         (struct tui_win_info) <detail>: Remove source_info member.
8389         (struct tui_source_window_base) <has_locator>: Inline.
8390         Move contents from tui_source_info; rename has_locator member to
8391         m_has_locator.
8392         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8393         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8394         header file.
8395         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8396         Simplify.
8397         (tui_free_all_source_wins_content): Cast to
8398         tui_source_window_base.
8399
8400 2019-06-25  Tom Tromey  <tom@tromey.com>
8401
8402         * tui/tui-win.c (make_invisible_and_set_new_height)
8403         (make_visible_with_new_height): Call has_locator method.
8404         * tui/tui-layout.c (show_source_disasm_command, show_data)
8405         (show_source_or_disasm_and_command): Update for bool change.
8406         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8407         (tui_win_info) <has_locator>: New method.
8408         (struct tui_source_window_base) <has_locator>: New method.
8409         (tui_win_has_locator): Don't declare.
8410         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8411         from tui_win_has_locator.
8412         (tui_source_window_base): Use false, not FALSE.
8413
8414 2019-06-25  Tom Tromey  <tom@tromey.com>
8415
8416         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8417         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8418         clear_detail method directly.
8419         (tui_clear_win_detail): Remove.
8420
8421 2019-06-25  Tom Tromey  <tom@tromey.com>
8422
8423         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8424         "this", not TUI_DISASM_WIN.
8425
8426 2019-06-25  Tom Tromey  <tom@tromey.com>
8427
8428         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8429         declare.
8430         * tui/tui-winsource.c
8431         (tui_source_window_base::do_scroll_horizontal): Rename from
8432         tui_horizontal_source_scroll.
8433         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8434         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8435         from tui_vertical_data_scroll.
8436         * tui/tui-win.h (tui_scroll): Don't declare.
8437         * tui/tui-win.c (tui_win_info::forward_scroll)
8438         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8439         (tui_win_info::right_scroll): Rename and update.
8440         (tui_scroll_forward_command, tui_scroll_backward_command)
8441         (tui_scroll_left_command, tui_scroll_right_command): Update.
8442         (tui_scroll): Remove.
8443         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8444         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8445         from tui_vertical_source_scroll.
8446         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8447         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8448         from tui_vertical_disassem_scroll.
8449         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8450         do_scroll_horizontal>: New methods.
8451         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8452         Likewise.
8453         (struct tui_source_window_base): Add do_scroll_horizontal.
8454         (struct tui_source_window, struct tui_disasm_window): Add
8455         do_scroll_vertical.
8456         (struct tui_data_window, struct tui_cmd_window): Add
8457         do_scroll_horizontal and do_scroll_vertical.
8458         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8459
8460 2019-06-25  Tom Tromey  <tom@tromey.com>
8461
8462         * tui/tui-data.h (struct tui_source_window_base): New struct.
8463         (struct tui_source_window): Derive from tui_source_window_base.
8464         (struct tui_disasm_window): New struct.
8465         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8466         from tui_source_window::clear_detail.
8467         (tui_source_window_base): Rename from tui_source_window.
8468         (~tui_source_window_base): Rename from ~tui_source_window.
8469         (tui_alloc_win_info): Create a tui_disasm_window.
8470
8471 2019-06-25  Tom Tromey  <tom@tromey.com>
8472
8473         * tui/tui-data.h (struct tui_source_window)
8474         (struct tui_data_window): Declare destructors.
8475         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8476         destructors.
8477         (tui_win_info): Simplify.
8478
8479 2019-06-25  Tom Tromey  <tom@tromey.com>
8480
8481         * tui/tui-winsource.c (tui_display_main)
8482         (tui_update_source_windows_with_addr)
8483         (tui_update_all_breakpoint_info): Update.
8484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8485         (new_height_ok, parse_scrolling_args): Update.
8486         * tui/tui-stack.c (tui_show_frame_info): Update.
8487         * tui/tui-data.h (struct tui_list): Remove.
8488         (tui_source_windows): Return a reference to a std::vector.
8489         * tui/tui-data.c (source_windows): Now a std::vector.
8490         (tui_source_windows): Change return type.
8491         (tui_clear_source_windows): Rewrite.
8492         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8493         (tui_free_all_source_wins_content): Rewrite.
8494
8495 2019-06-25  Tom Tromey  <tom@tromey.com>
8496
8497         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8498         (struct tui_data_window, struct tui_cmd_window): Declare
8499         clear_detail method.
8500         * tui/tui-data.c (tui_source_window::clear_detail)
8501         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8502         methods.
8503         (tui_clear_win_detail): Simplify.
8504
8505 2019-06-25  Tom Tromey  <tom@tromey.com>
8506
8507         * tui/tui-layout.c (make_source_window, make_disasm_window)
8508         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8509         Return the new window.
8510         (show_source_disasm_command, show_data)
8511         (show_source_or_disasm_and_command): Update.
8512
8513 2019-06-25  Tom Tromey  <tom@tromey.com>
8514
8515         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8516         parameter.  Return the new window.
8517         (show_source_disasm_command): Update and remove NULL check.
8518         (show_source_or_disasm_and_command): Update.
8519
8520 2019-06-25  Tom Tromey  <tom@tromey.com>
8521
8522         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8523
8524 2019-06-25  Tom Tromey  <tom@tromey.com>
8525
8526         * tui/tui-data.h (struct tui_win_info): Make constructor
8527         protected.  Make destructor virtual.  Add initializers.
8528         (tui_source_window, tui_data_window, tui_cmd_window): New
8529         classes.
8530         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8531         constructor.  Add "type" parameter.
8532         (tui_source_window, tui_data_window, tui_cmd_window): New
8533         constructors.
8534         (tui_alloc_win_info): Instantiate the appropriate subclass.
8535
8536 2019-06-25  Tom Tromey  <tom@tromey.com>
8537
8538         * tui/tui-win.c (tui_resize_all): Use delete.
8539         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8540         destructor.
8541         (tui_free_window): Don't declare.
8542         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8543         Update.
8544
8545 2019-06-25  Tom Tromey  <tom@tromey.com>
8546
8547         * tui/tui-data.h (struct tui_win_info): Add constructor.
8548         * tui/tui-data.c (tui_alloc_win_info): Use new.
8549         (tui_free_window): Use delete.
8550
8551 2019-06-22  Tom Tromey  <tom@tromey.com>
8552
8553         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8554         declare.
8555         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8556
8557 2019-06-22  Tom Tromey  <tom@tromey.com>
8558
8559         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8560         declare.
8561         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8562
8563 2019-06-22  Tom de Vries  <tdevries@suse.de>
8564
8565         * dwarf2read.c (create_addrmap_from_aranges)
8566         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8567         instead of '%zu'.
8568
8569 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8570
8571         * dwarf2read.h (dwarf2_section_info_def): Remove.
8572         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8573         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8574         std::vector<dwarf2_section_info>.
8575         (struct dwo_file) <~dwo_file>: Remove.
8576         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8577         types field.
8578         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8579         (dwarf2_read_debug_names): Likewise.
8580         (create_debug_types_hash_table): Change parameter type to
8581         array_view, adjust code accordingly.
8582         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8583         (partial_die_info::fixup): Likewise.
8584         (determine_prefix): Likewise.
8585         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8586
8587 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8588
8589         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8590         gdb_bfd_ref_ptr.
8591         <~dwo_file>: Remove call to gdb_bfd_unref.
8592         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8593         gdb_bfd_ref_ptr::get.
8594
8595 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8596
8597         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8598         type to htab_up.
8599         * dwarf2read.c (struct dwo_file): Initialize fields.
8600         <~dwo_file>: New.
8601         (free_dwo_file): Remove, move content to ~dwo_file.
8602         (struct dwo_file_deleter): Remove.
8603         (dwo_file_up>: Remove custom deleter.
8604         (free_dwo_files): Remove.
8605         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8606         dwo_files.
8607         (process_skeletonless_type_units): Call unique_ptr::get.
8608         (allocate_dwo_file_hash_table): Add deleter to created hash
8609         table.  Change return type to htab_up.
8610         (lookup_dwo_file_slot): Don't memset dwo_file, call
8611         unique_ptr::get.
8612         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8613         (create_dwo_unit_in_dwp_v2): Likewise.
8614         (open_and_init_dwo_file): Likewise.
8615         (free_dwo_file_from_slot): Remove.
8616
8617 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8618
8619         * dwarf2read.h (struct dwarf2_section_info) <readin,
8620         is_virtual>: Change type to bool.
8621         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8622         true instead of 1.
8623
8624 2019-06-19  Tom Tromey  <tom@tromey.com>
8625
8626         * tui/tui-data.h (tui_init_content_element): Don't declare.
8627
8628 2019-06-19  Tom Tromey  <tom@tromey.com>
8629
8630         * tui/tui-data.h (tui_init_win_info): Don't declare.
8631
8632 2019-06-19  Tom de Vries  <tdevries@suse.de>
8633
8634         * dwarf2read.h (abstract_to_concrete): Change type to
8635         std::unordered_map<sect_offset, std::vector<sect_offset>,
8636         gdb::hash_enum<sect_offset>>.
8637
8638 2019-06-19  Tom Tromey  <tromey@adacore.com>
8639
8640         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8641         EVAL_AVOID_SIDE_EFFECTS specially.
8642
8643 2019-06-19  Tom Tromey  <tromey@adacore.com>
8644
8645         * source-cache.c (highlighter): New global.
8646         (source_cache::get_source_lines): Create a highlighter on demand.
8647
8648 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8649
8650         * defs.h (deprecated_interactive_hook): Delete declaration.
8651         * interps.c (clear_interpreter_hooks): Remove use of
8652         deprecated_interactive_hook.
8653         * top.c (deprecated_interactive_hook): Delete definition.
8654         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8655
8656 2019-06-18  Tom de Vries  <tdevries@suse.de>
8657
8658         PR gdb/24515
8659         * dwarf2read.h (abstract_to_concrete): Change type from
8660         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8661         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8662         * dwarf2read.c (read_variable): Update.
8663         (dwarf2_fetch_die_loc_sect_off): Update.
8664
8665 2019-06-17  Tom de Vries  <tdevries@suse.de>
8666
8667         PR gdb/24617
8668         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8669         accessing parent[parent_len - 1].
8670
8671 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8672
8673         PR gdb/24364
8674         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8675         call dtrace_process_dof with NULL dof.
8676
8677 2019-06-16  Tom de Vries  <tdevries@suse.de>
8678
8679         PR gdb/24445
8680         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8681
8682 2019-06-16  Tom Tromey  <tom@tromey.com>
8683
8684         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8685         (make_all_visible): Use address of member.
8686
8687 2019-06-16  Tom Tromey  <tom@tromey.com>
8688
8689         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8690         (tui_free_window, free_content, free_content_elements): Remove
8691         unnecessary cast.
8692         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8693         cast.
8694         * tui/tui-regs.c (tui_show_register_group)
8695         (tui_display_registers_from, tui_display_reg_element_at_line):
8696         Remove unnecessary cast.
8697
8698 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8699
8700         * linux-nat.c (normal_mask): Delete.
8701         (_initialize_linux_nat): Don't initialise normal_mask.
8702
8703 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8704
8705         PR gdb/24445
8706         * dwarf-index-write.h (write_psymtabs_to_index): Add
8707         dwz_basename parameter.
8708         * dwarf-index-write.c (write_gdbindex): Move file writing to
8709         write_gdbindex_1.  Change return type void.
8710         (assert_file_size): Move up, remove filename parameter.
8711         (write_gdbindex_1): New function.
8712         (write_debug_names): Change return type to void, call
8713         assert_file_size.
8714         (struct index_wip_file): New struct.
8715         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8716         file logic to index_wip_file.  Write index for dwz file if
8717         needed.
8718         (save_gdb_index_command): Pass basename of dwz file, if present.
8719         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8720         build-id of dwz file, if present.
8721         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8722         (dwarf2_get_dwz_file): Likewise.
8723         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8724         (dwarf2_get_dwz_file): Likewise.
8725
8726 2019-06-16  Tom Tromey  <tom@tromey.com>
8727
8728         * coffread.c (process_coff_symbol): Use xstrdup.
8729         * value.c (create_internalvar): Use xstrdup.
8730
8731 2019-06-16  Tom Tromey  <tom@tromey.com>
8732
8733         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8734         * breakpoint.c (stopin_command, stopat_command)
8735         (until_break_command, decode_location_default): Remove unnecessary
8736         cast.
8737         * utils.c (subset_compare): Remove unnecessary cast.
8738         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8739         cast.
8740         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8741         cast.
8742         * infcmd.c (path_command): Remove unnecessary cast.
8743         * coffread.c (decode_type): Remove unnecessary cast.
8744         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8745         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8746         * tui/tui-stack.c (tui_show_locator_content)
8747         (tui_show_frame_info): Remove unnecessary cast.
8748         * tui/tui-win.c (tui_scroll_forward_command)
8749         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8750         (parse_scrolling_args): Remove unnecessary cast.
8751         * tui/tui-data.c (init_win_info, tui_del_window)
8752         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8753         (free_content_elements): Remove unnecessary cast.
8754         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8755         unnecessary cast.
8756         * tui/tui-source.c (tui_set_source_content)
8757         (tui_vertical_source_scroll): Remove unnecessary cast.
8758         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8759         cast.
8760         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8761         * tui/tui-regs.c (tui_display_registers_from)
8762         (tui_display_register): Remove unnecessary cast.
8763         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8764         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8765         (make_visible): Remove unnecessary cast.
8766         * tui/tui-winsource.c (tui_erase_source_content)
8767         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8768         unnecessary cast.
8769         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8770         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8771         * stabsread.c (read_type, read_array_type, read_range_type):
8772         Remove unnecessary cast.
8773         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8774         (parse_symbol, parse_type, upgrade_type, parse_external)
8775         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8776         unnecessary cast.
8777         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8778
8779 2019-06-16  Tom Tromey  <tom@tromey.com>
8780
8781         * tui/tui-data.c (tui_alloc_generic_win_info)
8782         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8783         checks.
8784
8785 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8786             Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * f-typeprint.c (f_print_type): Don't return early for not
8789         associated or not allocated types.
8790         (f_type_print_varspec_suffix): Add print_rank parameter and print
8791         ranks of array types in case they dangling.
8792         (f_type_print_base): Add print_rank parameter.
8793
8794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * NEWS: Mention new MI commands.
8797         * break-catch-throw.c (enum exception_event_kind): Move to
8798         breakpoint.h.
8799         (print_mention_exception_catchpoint): Output text as a single
8800         message.
8801         (catch_exception_command_1): Rename to...
8802         (catch_exception_event): ...this, make non-static, update header
8803         command, and change some parameter types.
8804         (catch_catch_command): Update for changes to
8805         catch_exception_command_1.
8806         (catch_throw_command): Likewise.
8807         (catch_rethrow_command): Likewise.
8808         * breakpoint.c (enum exception_event_kind): Delete.
8809         * breakpoint.h (enum exception_event_kind): Moved here from
8810         break-catch-throw.c.
8811         (catch_exception_event): Declare.
8812         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8813         (mi_cmd_catch_throw): New function.
8814         (mi_cmd_catch_rethrow): New function.
8815         (mi_cmd_catch_catch): New function.
8816         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8817         'catch-catch' entries.
8818         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8819         (mi_cmd_catch_rethrow): Declare.
8820         (mi_cmd_catch_catch): Declare.
8821
8822 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * annotate.c (annotate_source_line): Change return type to void,
8825         update implementation to match.
8826         * annotate.h (annotate_source_line): Change return type to void,
8827         update header comment.
8828         * stack.c (print_frame_info): Don't change what frame information
8829         is printed based on whether annotations are on or not.
8830
8831 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8834         (annotate_source): Make static.
8835         (annotate_source_line): Moved from source.c and renamed from
8836         identify_source_line.  Update the return type.
8837         * annotate.h (annotate_source): Delete declaration.
8838         (annotate_source_line): Declaration moved from source.h, and
8839         renamed from identify_source_line.  Return type updated.
8840         * source.c (identify_source_line): Moved to annotate.c and renamed
8841         to annotate_source_line.
8842         (info_line_command): Remove check of annotation_level.
8843         * source.h (identify_source_line): Move declaration to annotate.h
8844         and rename to annotate_source_line.
8845         * stack.c: Add 'annotate.h' include.
8846         (print_frame_info): Remove check of annotation_level before
8847         calling annotate_source_line.
8848
8849 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * source-cache.c (source_cache::get_plain_source_lines): Use
8852         open_source_file_with_line_charpos instead of just
8853         open_source_file, remove call to find_source_lines.
8854         (source_cache::get_source_lines): Likewise.
8855         * source.c (find_source_lines): Make static.
8856         (get_filename_and_charpos): Renamed into...
8857         (open_source_file_with_line_charpos): ..this along with changes to
8858         return a scoped_fd, and some other minor clean ups.
8859         (identify_source_line): Use open_source_file_with_line_charpos.
8860         (search_command_helper): Use open_source_file_with_line_charpos
8861         instead of just open_source_file, remove call to
8862         find_source_lines.
8863         * source.h (open_source_file_with_line_charpos): Declare new
8864         function.
8865         (find_source_lines): Delete declaration.
8866
8867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8868
8869         * source.c (get_filename_and_charpos): Remove fullname
8870         parameter.
8871         (identify_source_line): Update call to get_filename_and_charpos.
8872
8873 2019-06-14  Tom Tromey  <tromey@adacore.com>
8874
8875         PR gdb/24502:
8876         * ui-style.h (skip_ansi_escape): Update comment.
8877         * ui-file.h (class no_terminal_escape_file): New class.
8878         * ui-file.c (no_terminal_escape_file::write)
8879         (no_terminal_escape_file::puts): New methods.
8880         * cli/cli-logging.c (handle_redirections): Use
8881         no_terminal_escape_file.
8882
8883 2019-06-14  Tom Tromey  <tromey@adacore.com>
8884
8885         * NEWS: Move convenience variable news above Python news.
8886
8887 2019-06-14  Tom Tromey  <tom@tromey.com>
8888
8889         * gnulib: Move directory to top-level.
8890         * configure.ac: Don't configure gnulib.
8891         * configure: Rebuild.
8892         * common/common-defs.h: Use new path to gnulib.
8893         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8894         (GNULIB_H): Remove.
8895         (INCGNU): Look in new gnulib location.
8896         (HFILES_NO_SRCDIR): Remove gnulib files.
8897         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8898         (generated_files): Remove GNULIB_H.
8899         ($(LIBGNU), all-lib): Remove targets.
8900         (distclean): Don't mention GNULIB_BUILDDIR.
8901         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8902
8903 2019-06-14  Tom Tromey  <tromey@adacore.com>
8904
8905         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8906         Warn if symbol file does not provide any symbols.
8907
8908 2019-06-14  Tom Tromey  <tromey@adacore.com>
8909
8910         * source.c (find_and_open_source): Respect basenames_may_differ.
8911
8912 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * annotate.c (annotate_breakpoints_invalid): Make use of
8915         scoped_restore_terminal_state.
8916         (annotate_frames_invalid): Likewise.
8917
8918 2019-06-14  Tom Tromey  <tromey@adacore.com>
8919
8920         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8921         allow assignment to an internalvar.
8922
8923 2019-06-14  Tom Tromey  <tromey@adacore.com>
8924
8925         * ada-lex.l: Allow "_" in attribute names.
8926
8927 2019-06-14  Tom Tromey  <tromey@adacore.com>
8928
8929         PR gdb/24653:
8930         * regcache.c (registers_changed): Don't call alloca.
8931         * top.c (execute_command): Don't call alloca.
8932
8933 2019-06-13  Pedro Alves  <palves@redhat.com>
8934
8935         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8936         'expression'.  When parsing an expression, error out if there's
8937         junk after "unlimited".
8938         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8939         (do_set_command): Adjust calls to is_unlimited_literal.
8940
8941 2019-06-13  Pedro Alves  <palves@redhat.com>
8942
8943         * compile/compile.c (make_compile_options_def_group): Add braces
8944         around array_view initializer.
8945         * thread.c (make_thread_apply_all_options_def_group)
8946         (make_thread_apply_all_options_def_group): Likewise.
8947
8948 2019-06-13  Pedro Alves  <palves@redhat.com>
8949
8950         * NEWS (New commands): Mention "maint test-options
8951         require-delimiter", "maint test-options unknown-is-error", "maint
8952         test-options unknown-is-operand" and "maint show
8953         test-options-completion-result".
8954         (New command options, command completion): New section.
8955         (Completion improvements): New section.
8956         Mention that you can abbreviate "unlimited".
8957
8958 2019-06-13  Pedro Alves  <palves@redhat.com>
8959
8960         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8961         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8962         * unittests/cli-utils-selftests.c (test_parse_flags)
8963         (test_parse_flags_qcs): Delete.
8964         (test_cli_utils): Don't call deleted functions.
8965
8966 2019-06-13  Pedro Alves  <palves@redhat.com>
8967
8968         * thread.c: Include "cli/cli-option.h".
8969         (tp_array_compar_ascending): Global.
8970         (tp_array_compar): Delete function.
8971         (tp_array_compar_ascending, tp_array_compar_descending): New
8972         functions.
8973         (ascending_option_def, qcs_flag_option_def)
8974         (thr_qcs_flags_option_defs)
8975         (make_thread_apply_all_options_def_group)
8976         (make_thread_apply_options_def_group): New.
8977         (thread_apply_all_command): Use gdb::option::process_options.
8978         (thread_apply_command_completer)
8979         (thread_apply_all_command_completer): New.
8980         (thread_apply_command): Use gdb::option::process_options.
8981         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8982         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8983         to generate help text of "thread apply".  Adjust "taas"'s help.
8984         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8985         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8986
8987 2019-06-13  Pedro Alves  <palves@redhat.com>
8988
8989         * thread.c (thread_apply_command): Check for invalid TID with
8990         isdigit instead of !isalpha.
8991
8992 2019-06-13  Pedro Alves  <palves@redhat.com>
8993
8994         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8995         (validate_flags_qcs): New.
8996         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8997         (validate_flags_qcs): Declare.
8998         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8999         (make_frame_apply_options_def_group): New.
9000         (frame_apply_command_count): Process options with
9001         gdb::option::process_options.
9002         (frame_apply_completer): New.
9003         (frame_apply_level_completer, frame_apply_all_completer)
9004         (frame_apply_completer): New.
9005         (_initialize_stack): Update help of "frame apply", "frame apply
9006         level", "frame apply all" and "faas" to mention supported options
9007         and install command completers.
9008         * stack.h (frame_apply_all_completer): Declare.
9009         * thread.c: Include "stack.h".
9010         (tfaas_command): Add "--".
9011         (_initialize_thread): Update help "tfaas" to mention supported
9012         options and install command completer.
9013
9014 2019-06-13  Pedro Alves  <palves@redhat.com>
9015
9016         * completer.c (complete_nested_command_line): New.
9017         (gdb_completion_word_break_characters_throw): Add assertion.
9018         * completer.h (complete_nested_command_line): Declare.
9019
9020 2019-06-13  Pedro Alves  <palves@redhat.com>
9021
9022         * stack.c (parse_backtrace_qualifiers): New.
9023         (backtrace_command): Use it.
9024         (backtrace_command_completer): Complete on qualifiers.
9025
9026 2019-06-13  Pedro Alves  <palves@redhat.com>
9027
9028         * frame.c: Include "cli/cli-option.h.
9029         (user_set_backtrace_options): New.
9030         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9031         Delete.
9032         (get_prev_frame): Adjust.
9033         (boolean_option_def, uinteger_option_def)
9034         (set_backtrace_option_defs): New.
9035         (_initialize_frame): Adjust and use
9036         gdb::option::add_setshow_cmds_for_options to install "set
9037         backtrace past-main" and "set backtrace past-entry".
9038         * frame.h: Include "cli/cli-option.h".
9039         (struct frame_print_options): Forward declare.
9040         (print_frame_arguments_all, print_frame_arguments_scalars)
9041         (print_frame_arguments_none): Declare.
9042         (print_entry_values): Delete declaration.
9043         (struct frame_print_options, user_frame_print_options): New.
9044         (struct set_backtrace_options): New.
9045         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9046         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9047         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9048         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9049         (list_args_or_locals): Add frame_print_options parameter.
9050         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9051         * python/py-framefilter.c (enumerate_args): Pass down
9052         USER_FRAME_PRINT_OPTIONS.
9053         * stack.c: Include "cli/cli-option.h".
9054         (print_frame_arguments_all, print_frame_arguments_scalars)
9055         (print_frame_arguments_none): Declare.
9056         (print_raw_frame_arguments, print_entry_values): Delete.
9057         (user_frame_print_options): New.
9058         (boolean_option_def, enum_option_def, frame_print_option_defs):
9059         New.
9060         (struct backtrace_cmd_options): New.
9061         (bt_flag_option_def): New.
9062         (backtrace_command_option_defs): New.
9063         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9064         (print_frame_arg, read_frame_arg, print_frame_args)
9065         (print_frame_info, print_frame): Add frame_print_options parameter
9066         and use it.
9067         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9068         (backtrace_command_1): Add frame_print_options and
9069         backtrace_cmd_options parameters and use them.
9070         (make_backtrace_options_def_group): New.
9071         (backtrace_command): Process command options with
9072         gdb::option::process_options.
9073         (backtrace_command_completer): New.
9074         (_initialize_stack): Extend "backtrace"'s help to mention
9075         supported options.  Install completer for "backtrace".
9076         Install some settings commands with add_setshow_cmds_for_options.
9077
9078 2019-06-13  Pedro Alves  <palves@redhat.com>
9079
9080         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9081         and that "set/show print raw frame-arguments" are now deprecated.
9082
9083         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9084         command.
9085         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9086         * stack.c (_initialize_stack): Install "set/show print
9087         raw-frame-arguments", and deprecate "set/show print raw
9088         frame-arguments".
9089         * valprint.c (_initialize_valprint): Deprecate "set/show print
9090         raw".
9091
9092 2019-06-13  Pedro Alves  <palves@redhat.com>
9093
9094         * compile/compile.c (struct compile_options): New.
9095         (compile_flag_option_def, compile_command_option_defs)
9096         (make_compile_options_def_group): New.
9097         (compile_file_command): Handle options with
9098         gdb::option::process_options.
9099         (compile_file_command_completer): New function.
9100         (compile_code_command): Handle options with
9101         gdb::option::process_options.
9102         (compile_code_command_completer): New function.
9103         (_initialize_compiler): Install completers for "compile code" and
9104         "compile file".  Mention available options in "compile code" and
9105         "compile code"'s help.
9106         * completer.c (advance_to_completion_word): New, factored out from
9107         ...
9108         (advance_to_expression_complete_word_point): ... this.
9109         (advance_to_filename_complete_word_point): New.
9110         * completer.h (advance_to_filename_complete_word_point): New
9111         declaration.
9112
9113 2019-06-13  Pedro Alves  <palves@redhat.com>
9114
9115         * compile/compile.c: Include "cli/cli-option.h".
9116         (compile_print_value): Scope data pointer is now a
9117         value_print_options pointer; adjust.
9118         (compile_print_command): Process options.  Scope data pointer is
9119         now a value_print_options pointer; adjust.
9120         (_initialize_compile): Update "compile print"'s help to include
9121         supported options.  Install a completer for "compile print".
9122         * cp-valprint.c (show_vtblprint, show_objectprint)
9123         (show_static_field_print): Delete.
9124         (_initialize_cp_valprint): Don't install "set print
9125         static-members", "set print vtbl", "set print object" here.
9126         * printcmd.c: Include "cli/cli-option.h" and
9127         "common/gdb_optional.h".
9128         (print_command_parse_format): Rework to fill in a
9129         value_print_options instead of a format_data.
9130         (print_value): Change parameter type from format_data pointer to
9131         value_print_options reference.  Adjust.
9132         (print_command_1): Process options.  Adjust to pass down a
9133         value_print_options.
9134         (print_command_completer): New.
9135         (_initialize_printcmd): Install print_command_completer as
9136         handle_brkchars completer for the "print" command.  Update
9137         "print"'s help to include supported options.
9138         * valprint.c: Include "cli/cli-option.h".
9139         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9140         here from cp-valprint.c.
9141         (boolean_option_def, uinteger_option_def)
9142         (value_print_option_defs, make_value_print_options_def_group):
9143         New.  Use gdb::option::add_setshow_cmds_for_options to install
9144         "set print elements", "set print null-stop", "set print repeats",
9145         "set print pretty", "set print union", "set print array", "set
9146         print address", "set print symbol", "set print array-indexes".
9147         * valprint.h: Include <string> and "cli/cli-option.h".
9148         (make_value_print_options_def_group): Declare.
9149         (print_value): Change parameter type from format_data pointer to
9150         value_print_options reference.
9151         (print_command_completer): Declare.
9152
9153 2019-06-13  Pedro Alves  <palves@redhat.com>
9154
9155         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9156         (COMMON_SFILES): Add maint-test-settings.c.
9157         * cli/cli-decode.c (boolean_enums): New global, factored out from
9158         ...
9159         (add_setshow_boolean_cmd): ... here.
9160         * cli/cli-decode.h (boolean_enums): Declare.
9161         * cli/cli-option.c: New file.
9162         * cli/cli-option.h: New file.
9163         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9164         factored out from ...
9165         (parse_cli_boolean_value(const char *)): ... this.
9166         (is_unlimited_literal): Change parameter type to pointer to
9167         pointer.  Adjust and advance ARG pointer.
9168         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9169         (parse_cli_var_enum): New, factored out from ...
9170         (do_set_command): ... this.  Adjust.
9171         * cli/cli-setshow.h (parse_cli_boolean_value)
9172         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9173         (parse_cli_var_enum): Declare.
9174         * cli/cli-utils.c: Include "cli/cli-option.h".
9175         (get_ulongest): New.
9176         * cli/cli-utils.h (get_ulongest): Declare.
9177         (check_for_argument): New overloads.
9178         * maint-test-options.c: New file.
9179
9180 2019-06-13  Pedro Alves  <palves@redhat.com>
9181
9182         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9183         parse a range if "-" is at the end of the string.
9184
9185 2019-06-13  Pedro Alves  <palves@redhat.com>
9186
9187         * cli/cli-setshow.c (parse_auto_binary_operation)
9188         (parse_cli_boolean_value): Don't allow "o".
9189
9190 2019-06-13  Pedro Alves  <palves@redhat.com>
9191
9192         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9193         * NEWS: Mention maint test-settings KIND.
9194         * maint-test-settings.c: New file.
9195
9196 2019-06-13  Pedro Alves  <palves@redhat.com>
9197
9198         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9199         completer.
9200         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9201         "set" completers.
9202
9203 2019-06-13  Pedro Alves  <palves@redhat.com>
9204
9205         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9206         after item.
9207
9208 2019-06-13  Pedro Alves  <palves@redhat.com>
9209
9210         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9211
9212 2019-06-13  Pedro Alves <palves@redhat.com>
9213
9214         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9215         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9216         call.
9217         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9218         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9219         calls.
9220         (check_for_argument): Skip spaces after argument.
9221
9222 2019-06-13  Pedro Alves  <palves@redhat.com>
9223
9224         * thread.c (thread_apply_command): Adjust TID parsing.
9225         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9226         detected before end of string.
9227         (tid_is_in_list): Error out if LIST is invalid.
9228
9229 2019-06-13  Pedro Alves  <palves@redhat.com>
9230
9231         * completer.c (complete_line_internal_1): Rewind completion word
9232         point.
9233         (completion_tracker::advance_custom_word_point_by): Change
9234         parameter type to int.
9235         * completer.h (completion_tracker::advance_custom_word_point_by):
9236         Likewise.
9237
9238 2019-06-13  Pedro Alves  <palves@redhat.com>
9239
9240         * completer.c (advance_to_completion_word): Handle delimiters.
9241
9242 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9243
9244         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9245
9246 2019-06-11  Tom Tromey  <tom@tromey.com>
9247
9248         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9249         (xmalloc_failed): Move to alloc.c.
9250         * alloc.c: New file.
9251         * Makefile.in (COMMON_SFILES): Add alloc.c.
9252
9253 2019-06-11  Tom Tromey  <tom@tromey.com>
9254
9255         * nat/linux-waitpid.c: Don't include server.h.
9256         (linux_debug): Remove.
9257         (my_waitpid): Update.
9258
9259 2019-06-11  Tom Tromey  <tromey@adacore.com>
9260
9261         * infcall.c (_initialize_infcall): Remove trailing newline from
9262         help.
9263         * user-regs.c (_initialize_user_regs): Remove trailing newline
9264         from help.
9265         * typeprint.c (_initialize_typeprint): Remove trailing newline
9266         from help.
9267         * reverse.c (_initialize_reverse): Remove trailing newlines from
9268         help.
9269         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9270         from help.
9271         * language.c (add_set_language_command): Remove trailing newline
9272         from help.
9273         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9274         help.
9275         * disasm.c (_initialize_disasm): Remove trailing newline from
9276         help.
9277         * top.c (init_main): Remove trailing newline from help.
9278         * interps.c (_initialize_interpreter): Remove trailing newline
9279         from help.
9280         * btrace.c (_initialize_btrace): Remove trailing newlines from
9281         help.
9282         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9283         from help.
9284         * python/python.c (_initialize_python): Remove trailing newline
9285         from help.
9286         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9287         help.
9288         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9289         from help.  Reformat some text.
9290         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9291         from help.
9292         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9293         newline from help.
9294
9295 2019-06-11  Tom Tromey  <tromey@adacore.com>
9296
9297         * darwin-nat.c (darwin_decode_exception_message)
9298         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9299
9300 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * valops.c (value_slice): Check for not allocated or not
9303         associated values.
9304
9305 2019-06-10  Tom de Vries  <tdevries@suse.de>
9306
9307         PR gdb/24618
9308         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9309         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9310         invalid.
9311
9312 2019-06-10  Tom de Vries  <tdevries@suse.de>
9313
9314         PR gdb/24611
9315         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9316         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9317
9318 2019-06-10  Tom de Vries  <tdevries@suse.de>
9319
9320         PR symtab/24545
9321         * symtab.c (struct demangled_name_entry): Add language field.
9322         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9323         static minimal symbol".  Set and use language field.
9324
9325 2019-06-10  Tom Tromey  <tromey@adacore.com>
9326
9327         * ada-lang.c (_initialize_ada_language): Update help text.
9328
9329 2019-06-10  Tom Tromey  <tromey@adacore.com>
9330
9331         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9332         with a newline.
9333         * guile/guile.c (handle_boot_error): Don't end warning with a
9334         newline.
9335         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9336         warning with a newline.
9337         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9338         newline.
9339         (s12z_frame_cache): Likewise.
9340         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9341         a newline.
9342         * solib-svr4.c (disable_probes_interface): Don't end warning with
9343         a newline.
9344         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9345         newline.
9346         * python/python.c (do_finish_initialization): Don't end warning
9347         with a newline.
9348
9349 2019-06-10  Tom Tromey  <tom@tromey.com>
9350
9351         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9352         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9353         gdbpy_enter.
9354
9355 2019-06-10  Tom Tromey  <tromey@adacore.com>
9356
9357         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9358         data.
9359         (elf_new_init): Don't call stabsread_new_init.
9360         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9361         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9362         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9363
9364 2019-06-10  Tom de Vries  <tdevries@suse.de>
9365
9366         PR symtab/16264
9367         PR symtab/24517
9368         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9369
9370 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9371
9372         * source.c (find_and_open_source): Also rewrite relative file
9373         names.
9374
9375 2019-04-26  Amos Bird  <amosbird@gmail.com>
9376
9377         * annotate.c (annotate_thread_exited): Add "thread-exited"
9378         annotation.
9379
9380 2019-06-06  Tom Tromey  <tromey@adacore.com>
9381
9382         * maint.h (class scoped_command_stats): Use
9383         DISABLE_COPY_AND_ASSIGN.
9384         <print_time>: New method.
9385         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9386         print_time.
9387         (scoped_command_stats::print_time): New method.
9388
9389 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9390
9391         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9392         instructions of lengths 6 or 8 bytes.
9393
9394 2019-06-04  Pedro Alves  <palves@redhat.com>
9395
9396         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9397
9398         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9399         * breakpoint.c (condition_completer): Likewise.
9400         * cli/cli-dump.c (scan_expression): Likewise.
9401         * common/filestuff.c (mkdir_recursive): Likewise.
9402         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9403         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9404         (gdb_abspath): Likewise.
9405         * compile/compile-cplus-types.c
9406         (compile_cplus_instance::decl_name): Likewise.
9407         * completer.c (complete_explicit_location):
9408         (signal_completer, reg_or_group_completer_1): Likewise.
9409         * cp-support.c (cp_remove_params_if_any): Likewise.
9410         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9411         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9412         * infcmd.c (strip_bg_char): Likewise.
9413         * linespec.c (copy_token_string): Likewise.
9414         * mi/mi-main.c (output_cores): Likewise.
9415         * psymtab.c (psymtab_search_name):
9416         * symfile.c (test_set_ext_lang_command): Likewise.
9417         * target.c (target_fileio_read_stralloc): Likewise.
9418         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9419         * value.c (complete_internalvar): Likewise.
9420
9421 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9422
9423         Add objfile property to gdb.Type.
9424         * NEWS: Mention Python API addition.
9425         * python/py-type.c (typy_get_objfile): New method.
9426
9427 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9428
9429         * NEWS: Mention the new set|show style [title|highlight].
9430         Mention changes to "show style", "help" and "apropos".
9431
9432 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9433
9434         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9435         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9436         instead of print_help_for_command.
9437         (print_doc_of_command): New function.
9438         (help_list): Add 'apropos -v word' suggestion.
9439         (print_help_for_command): Style the command name using title style.
9440         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9441         (_initialize_cli_cmds): Describe -v in apropos_command help.
9442
9443 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9444
9445         * cli/cli-style.h (cli_style_option): Add name in constructor,
9446         add m_name class member, add constructor with intensity,
9447         add name class function.
9448         (cli_style_option::add_setshow_commands): Remove name argument.
9449         (highlight_style, title_style): New styles.
9450         * cli/cli-style.c (do_show): New function that shows a style
9451         characteristic styling the style name with itself.
9452         (set_style_name): New function.
9453         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9454         Update all callers according to the changes in cli/cli-style.h.
9455         * utils.h (fputs_highlighted): New function.
9456         * utils.c (fputs_highlighted): Likewise.
9457
9458 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9459
9460         * NEWS: Mention new pipe command and new convenience variables.
9461
9462 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9463
9464         * cli/cli-cmds.c (pipe_command): New function.
9465         (_initialize_cli_cmds): Call add_com for pipe_command.
9466         Define | as an alias for pipe.
9467         (exit_status_set_internal_vars): New function.
9468         (shell_escape): Call exit_status_set_internal_vars.
9469         cli/cli-decode.c (find_command_name_length): Recognize | as
9470         a single character command.
9471
9472 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9473
9474         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9475         top.c (execute_command_to_ui_file): New function, mostly a copy
9476         of execute_command_to_string.
9477         (execute_command_to_string): Implement by calling
9478         execute_command_to_ui_file.
9479
9480 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9481
9482         * top.h (saved_command_line): Remove declaration.
9483         * top.c (previous_saved_command_line, previous_repeat_arguments):
9484         New variables.
9485         (saved_command_line): Make static, define together with other
9486         'repeat variables'.
9487         (dont_repeat): Clear repeat_arguments.
9488         (repeat_previous, get_saved_command_line, save_command_line):
9489         New functions.
9490         (gdb_init): Initialize saved_command_line
9491         and previous_saved_command_line.
9492         * main.c (captured_main_1): Remove saved_command_line initialization.
9493         * event-top.c (handle_line_of_input): Update to use
9494         the new 'repeat' related functions instead of direct access to
9495         saved_command_line.
9496         * command.h (repeat_previous, get_saved_command_line,
9497         save_command_line): New declarations.
9498         (dont_repeat): Add comment.
9499
9500 2019-05-30  Tom Tromey  <tromey@adacore.com>
9501
9502         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9503         Fix comment.
9504         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9505
9506 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9507
9508         PR cli/24587
9509         * completer.c (complete): Initialize variable word.
9510
9511 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9512
9513         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9514         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9515         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9516         'body' is NULL to the outter 'if', protecting the '!is_define'
9517         situation as well.
9518
9519 2019-05-29  Tom Tromey  <tromey@adacore.com>
9520
9521         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9522         (dwarf_unknown): New function.
9523         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9524         (dwarf_type_encoding_name): Use dwarf_unknown.
9525
9526 2019-05-29  Tom Tromey  <tromey@adacore.com>
9527
9528         PR c++/20020:
9529         * cp-valprint.c (cp_print_value_fields): Call
9530         cp_print_static_field inside "try".
9531
9532 2019-05-29  Tom Tromey  <tromey@adacore.com>
9533
9534         * inflow.c (struct terminal_info): Add default operator=.
9535         * configure: Rebuild.
9536         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9537         -Wdeprecated-copy-dtor, -Wredundant-move.
9538
9539 2019-05-29  Tom Tromey  <tromey@adacore.com>
9540
9541         * NEWS: Add entry.
9542         * infcmd.c (print_return_value_1): Handle finish_print
9543         option.
9544         (show_print_finish): New function.
9545         (_initialize_infcmd): Add "set/show print finish" commands.
9546         * valprint.c (user_print_options): Initialize new member.
9547         * valprint.h (struct value_print_options) <finish_print>: New
9548         member.
9549
9550 2019-05-28  Tom Tromey  <tromey@adacore.com>
9551
9552         * ada-lang.c (ada_remove_Xbn_suffix)
9553         (find_old_style_renaming_symbol)
9554         (parse_old_style_renaming): Remove.
9555         (ada_find_renaming_symbol): Don't call
9556         find_old_style_renaming_symbol.
9557         (ada_is_renaming_symbol): Rename from
9558         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9559         bool.  Now static.
9560         (ada_read_var_value): Update and simplify.
9561         * ada-exp.y (write_var_or_type): Remove old code.
9562
9563 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9564
9565         PR gdb/25010
9566         * event-top.c: Remove include comment.
9567         * inflow.c (class scoped_ignore_sigttou): Move from here...
9568         * inflow.h (class scoped_ignore_sigttou): ...to here.
9569         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9570         * top.c:  Remove include comment.
9571
9572 2019-05-27  Tom Tromey  <tom@tromey.com>
9573
9574         * NEWS: Fix typo.
9575
9576 2019-05-22  Tom Tromey  <tromey@adacore.com>
9577
9578         * target.c (target_follow_exec): Constify parameter.
9579         * target-delegates.c: Rebuild.
9580         * remote.c (remote_target::follow_exec): Constify parameter.
9581         * infrun.c (follow_exec): Constify parameter.
9582         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9583         (target_follow_exec): Likewise.
9584
9585 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9586
9587         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9588         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9589
9590 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9591
9592         * NEWS: Add debugredirect and testsuite sections.
9593
9594 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9595
9596         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9597         target descriptions using exclusively floating point register name
9598         aliases.
9599
9600 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         PR gdb/18644:
9603         * f-lang.c (build_fortran_types): Handle the case where
9604         gdbarch_floatformat_for_type returns a nullptr.
9605
9606 2019-05-21  Tom de Vries  <tdevries@suse.de>
9607
9608         PR cli/24587
9609         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9610
9611 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         PR gdb/18644:
9614         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9615         16-byte floats.
9616         * i386-tdep.c (i386_floatformat_for_type): Use
9617         floatformats_ia64_quad for the 16-byte floating point component
9618         within a fortran 32-byte complex number.
9619
9620 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9623         delete default constructor.
9624         (find_partial_die): Update to return const struct.
9625         (partial_die_parent_scope): Move variable declaration into scope
9626         of its use and change its type to auto.
9627         (guess_partial_die_structure_name): Likewise.
9628         (partial_die_info::fixup): Likewise.
9629
9630 2019-05-17  Tom Tromey  <tromey@adacore.com>
9631
9632         * source.c (find_and_open_source): Remove cast.
9633
9634 2019-05-17  Tom Tromey  <tromey@adacore.com>
9635
9636         * annotate.c (annotate_source): Make "filename" const.
9637         * annotate.h (annotate_source): Use const.
9638
9639 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9640
9641         * disasm.c (set_disassembler_options): Send errors to stderr.
9642
9643 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9644
9645         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9646         (cli_interp_base::set_logging): Check debug_redirect.
9647         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9648         * cli/cli-logging.c (debug_redirect): Add static variable.
9649         (pop_output_files): Add default param.
9650         (handle_redirections): Print debug setting.
9651         (show_logging_command): Likewise.
9652         (_initialize_cli_logging): Add debugredirect command.
9653         * interps.c (current_interp_set_logging): Add debug_redirect
9654         parameter.
9655         * interps.h (set_logging): Add debug_redirect parameter.
9656         (current_interp_set_logging): Likewise.
9657         * mi/mi-common.h: Likewise.
9658         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9659
9660 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9661             Tom Tromey  <tromey@adacore.com>
9662
9663         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9664         directly.
9665         * cli/cli-interp.h (make_logging_output): Remove declaration.
9666         * cli/cli-logging.c (make_logging_output): Remove function.
9667         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9668         directly.
9669         * ui-file.c (tee_file::tee_file): Remove bools.
9670         (tee_file::~tee_file): Remove deletes.
9671         * ui-file.h (tee_file): Remove bools.
9672
9673 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9674
9675         * mi/mi-cmds.h (mi_cmd_complete): New function.
9676         * mi/mi-main.c (mi_cmd_complete): Likewise.
9677         * mi/mi-cmds.c: Define new MI command -complete.
9678         * NEWS: Mention new -complete command.
9679
9680 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9681
9682         * completer.h (complete): New function.
9683         * completer.c (complete): Likewise.
9684         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9685         function defined in completer.h.
9686
9687 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9688
9689         * MAINTAINERS (Write After Approval): Add myself.
9690
9691 2019-05-17  Tom de Vries  <tdevries@suse.de>
9692
9693         PR gdb/24094
9694         * dwarf2read.c (struct cu_partial_die_info): New struct.
9695         (find_partial_die): Return cu_partial_die_info.
9696         (partial_die_parent_scope, guess_partial_die_structure_name)
9697         (partial_die_info::fixup): Handle new return type of find_partial_die.
9698
9699 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9700
9701         PR breakpoints/24541
9702         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9703         "std::string", simplifying the algorithm.
9704
9705 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9706
9707         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9708         (stap_static_probe_ops::get_probes): Likewise.
9709
9710 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9711
9712         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9713         '-')" and "else if".
9714         (stap_parse_single_operand): Join checks for
9715         "gdbarch_stap_parse_special_token_p" and
9716         "gdbarch_stap_parse_special_token" in the same "if" statement.
9717         Invert check when verifying for operation on register
9718         displacement.
9719
9720 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9721
9722         * stap-probe.c (stap_get_opcode): Update comment.
9723         (stap_get_expected_argument_type): Likewise.
9724         (handle_stap_probe): Likewise.
9725
9726 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9727
9728         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9729         return type to 'bool'.  Adjust comment.  Use 'bool' when
9730         appropriate.
9731         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9732         * stap-probe.c (stap_parse_argument_1): Likewise.
9733         (stap_is_operator): Likewise.
9734         (stap_is_generic_prefix): Likewise.
9735         (stap_is_register_prefix): Likewise.
9736         (stap_is_register_indirection_prefix): Likewise.
9737         (stap_is_integer_prefix): Likewise.
9738         (stap_generic_check_suffix): Likewise.
9739         (stap_check_integer_suffix): Likewise.
9740         (stap_check_register_suffix): Likewise.
9741         (stap_check_register_indirection_suffix): Likewise.
9742         (stap_parse_register_operand): Likewise.
9743         (stap_parse_single_operand): Likewise.
9744         (stap_parse_argument_1): Likewise.
9745         (stap_probe::get_argument_count): Likewise.
9746         (stap_is_operator): Likewise.
9747
9748 2019-05-16  Tom Tromey  <tromey@adacore.com>
9749
9750         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9751         keyword to foreach.
9752
9753 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9754
9755         * linux-thread-db.c (try_thread_db_load_1): Change return type
9756         to bool.
9757         (try_thread_db_load): Likewise.
9758         (try_thread_db_load_from_pdir_1): Likewise.
9759         (try_thread_db_load_from_pdir): Likewise.
9760         (try_thread_db_load_from_sdir): Likewise.
9761         (try_thread_db_load_from_dir): Likewise.
9762         (thread_db_load_search): Likewise.
9763         (has_libpthread): Likewise.
9764         (thread_db_load): Likewise.
9765
9766 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9767
9768         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9769         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9770         NULL, and complain/return if that's the case.
9771
9772 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9773
9774         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9775         (advance, posn, abstract_read_memory): New functions.
9776         [struct mem_read_abstraction]: New struct.
9777         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9778
9779 2019-05-14  Tom Tromey  <tromey@adacore.com>
9780
9781         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9782         value is not lval_memory.
9783
9784 2019-05-14  Tom Tromey  <tromey@adacore.com>
9785
9786         * solib.c (info_sharedlibrary_command): Style the file name.
9787
9788 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9789
9790         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9791         (aarch64_vnv_type): Likewise.
9792         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9793         * common/tdesc.c: Likewise.
9794         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9795         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9796         * features/aarch64-fpu.xml: Add ieee half view.
9797         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9798         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9799         * gdbtypes.h (struct builtin_type): Likewise.
9800         (struct objfile_type): Likewise.
9801
9802 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9803
9804         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9805         typo.
9806         * location.h (string_to_event_location): Likewise.
9807
9808 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9809
9810         GDB 8.3 released.
9811
9812 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9813
9814         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9815         New variable declaration.
9816         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9817         New variable.
9818         (print_one_breakpoint): Use ui_out::test_flags and new global
9819         variable to compute use_fixed_output.
9820         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9821         Remove.
9822         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9823         (mi_multi_location_breakpoint_output_fixed): Remove.
9824         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9825         new variable.
9826         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9827         fix_multi_location_breakpoint_output flag if version >= 3.
9828         * ui-out.h (enum ui_out_flag)
9829         <fix_multi_location_breakpoint_output>: New enumerator.
9830
9831 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9832
9833         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9834
9835 2019-05-10  Tom Tromey  <tromey@adacore.com>
9836
9837         * ada-lang.c (catch_ada_completer): New function.
9838         (_initialize_ada_language): Use it.
9839
9840 2019-05-10  Tom Tromey  <tromey@adacore.com>
9841
9842         * thread.c (print_thread_info): Make "requested_threads" const.
9843         * gdbthread.h (print_thread_info): Make "requested_threads"
9844         const.
9845         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9846         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9847
9848 2019-05-08  Tom Tromey  <tom@tromey.com>
9849
9850         * gdbtypes.c (objfile_type_data): Change type.
9851         (objfile_type, _initialize_gdbtypes): Update.
9852
9853 2019-05-08  Tom Tromey  <tom@tromey.com>
9854
9855         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9856         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9857         (_initialize_dwarf2_frame): Update.
9858
9859 2019-05-08  Tom Tromey  <tom@tromey.com>
9860
9861         * objc-lang.c (objc_objfile_data): Change type.
9862         (find_methods): Update.
9863         (_initialize_objc_lang): Remove.
9864
9865 2019-05-08  Tom Tromey  <tom@tromey.com>
9866
9867         * stabsread.c (rs6000_builtin_type_data): Change type.
9868         (rs6000_builtin_type, _initialize_stabsread): Update.
9869
9870 2019-05-08  Tom Tromey  <tom@tromey.com>
9871
9872         * mips-tdep.c (mips_pdr_data): Remove.
9873         (_initialize_mips_tdep): Update.
9874
9875 2019-05-08  Tom Tromey  <tom@tromey.com>
9876
9877         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9878         (hppa_init_objfile_priv_data, read_unwind_info)
9879         (find_unwind_entry, _initialize_hppa_tdep): Update.
9880
9881 2019-05-08  Tom Tromey  <tom@tromey.com>
9882
9883         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9884         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9885         on obstack.
9886         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9887
9888 2019-05-08  Tom Tromey  <tom@tromey.com>
9889
9890         * mdebugread.c (basic_type_data): Change type.
9891         (basic_type, _initialize_mdebugread): Update.
9892
9893 2019-05-08  Tom Tromey  <tom@tromey.com>
9894
9895         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9896
9897 2019-05-08  Tom Tromey  <tom@tromey.com>
9898
9899         * nto-tdep.c (nto_inferior_data_reg): Change type.
9900         (nto_inferior_data): Update.
9901         (nto_inferior_data_cleanup, nto_new_inferior_data)
9902         (_initialize_nto_tdep): Remove.
9903         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9904
9905 2019-05-08  Tom Tromey  <tom@tromey.com>
9906
9907         * ada-lang.c (struct ada_inferior_data): Add initializers.
9908         (ada_inferior_data): Change type.
9909         (ada_inferior_data_cleanup): Remove.
9910         (get_ada_inferior_data, ada_inferior_exit)
9911         (struct ada_pspace_data): Add initializers, destructor.
9912         (ada_pspace_data_handle): Change type.
9913         (get_ada_pspace_data): Update.
9914         (ada_pspace_data_cleanup): Remove.
9915
9916 2019-05-08  Tom Tromey  <tom@tromey.com>
9917
9918         * coffread.c (struct coff_symfile_info): Add initializers.
9919         (coff_objfile_data_key): Move lower.  Change type.
9920         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9921         Update.
9922         (coff_free_info): Remove.
9923
9924 2019-05-08  Tom Tromey  <tom@tromey.com>
9925
9926         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9927         (fbsd_pspace_data_handle): Move lower.  Change type.
9928         (get_fbsd_pspace_data): Update.
9929         (fbsd_pspace_data_cleanup): Remove.
9930         (_initialize_fbsd_tdep): Update.
9931
9932 2019-05-08  Tom Tromey  <tom@tromey.com>
9933
9934         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9935         (get_ada_tasks_pspace_data): Update.
9936         (ada_tasks_pspace_data_cleanup): Remove.
9937         (_initialize_tasks): Update.
9938         (ada_tasks_inferior_data_handle): Change type.
9939         (get_ada_tasks_inferior_data): Update.
9940         (ada_tasks_inferior_data_cleanup): Remove.
9941         (struct ada_tasks_pspace_data): Add initializers.
9942
9943 2019-05-08  Tom Tromey  <tom@tromey.com>
9944
9945         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9946         * symfile-debug.c (debug_sym_get_probes): Change type.
9947         * stap-probe.c (handle_stap_probe):
9948         (stap_static_probe_ops::get_probes): Change type.
9949         * probe.h (class static_probe_ops) <get_probes>: Change type.
9950         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9951         (parse_probes_in_pspace): Update.
9952         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9953         Update.
9954         (any_static_probe_ops::get_probes): Change type.
9955         * elfread.c (elfread_data): New typedef.
9956         (probe_key): Change type.
9957         (elf_get_probes): Likewise.  Update.
9958         (probe_key_free): Remove.
9959         (_initialize_elfread): Update.
9960         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9961         Change type.
9962         (dtrace_process_dof_probe, dtrace_process_dof)
9963         (dtrace_static_probe_ops::get_probe): Change type.
9964
9965 2019-05-08  Tom Tromey  <tom@tromey.com>
9966
9967         * xcoffread.c (struct xcoff_symfile_info): Rename from
9968         coff_symfile_info.  Add initializers.
9969         (xcoff_objfile_data_key): Move lower.  Change type.
9970         (XCOFF_DATA): Rewrite.
9971         (xcoff_free_info): Remove.
9972         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9973         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9974         (xcoff_initial_scan): Update.
9975
9976 2019-05-08  Tom Tromey  <tom@tromey.com>
9977
9978         * solib-svr4.c (struct svr4_info): Add initializers and
9979         destructor.
9980         <probes_table>: Now an htab_up.
9981         (solib_svr4_pspace_data): Change type.
9982         (free_probes_table): Simplify.
9983         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9984         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9985         (probes_table_remove_objfile_probes, register_solib_event_probe)
9986         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9987         (_initialize_svr4_solib): Update.
9988
9989 2019-05-08  Tom Tromey  <tom@tromey.com>
9990
9991         * remote.c (remote_pspace_data): Change type.
9992         (remote_pspace_data_cleanup): Remove.
9993         (get_remote_exec_file, set_pspace_remote_exec_file)
9994         (_initialize_remote): Update.
9995
9996 2019-05-08  Tom Tromey  <tom@tromey.com>
9997
9998         * breakpoint.c (breakpoint_objfile_key): Change type.
9999         (get_breakpoint_objfile_data): Update.
10000         (free_breakpoint_objfile_data): Remove.
10001         (_initialize_breakpoint): Update.
10002
10003 2019-05-08  Tom Tromey  <tom@tromey.com>
10004
10005         * linux-tdep.c (struct linux_info): Add initializers.
10006         (linux_inferior_data): Move.  Change type.
10007         (invalidate_linux_cache_inf): Update.
10008         (linux_inferior_data_cleanup): Remove.
10009         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10010
10011 2019-05-08  Tom Tromey  <tom@tromey.com>
10012
10013         * auxv.c (auxv_inferior_data): Move.  Change type.
10014         (auxv_inferior_data_cleanup): Remove.
10015         (invalidate_auxv_cache_inf): Rewrite.
10016         (get_auxv_inferior_data, _initialize_auxv): Update.
10017
10018 2019-05-08  Tom Tromey  <tom@tromey.com>
10019
10020         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10021         (symfile_debug_objfile_data_key): Change type.
10022         (symfile_debug_installed, debug_qf_has_symbols)
10023         (debug_qf_find_last_source_symtab)
10024         (debug_qf_forget_cached_source_info)
10025         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10026         (debug_qf_print_stats, debug_qf_dump)
10027         (debug_qf_expand_symtabs_for_function)
10028         (debug_qf_expand_all_symtabs)
10029         (debug_qf_expand_symtabs_with_fullname)
10030         (debug_qf_map_matching_symbols)
10031         (debug_qf_expand_symtabs_matching)
10032         (debug_qf_find_pc_sect_compunit_symtab)
10033         (debug_qf_map_symbol_filenames)
10034         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10035         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10036         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10037         (debug_sym_read_linetable, debug_sym_relocate): Update.
10038         (symfile_debug_free_objfile): Remove.
10039         (install_symfile_debug_logging, _initialize_symfile_debug):
10040         Update.
10041
10042 2019-05-08  Tom Tromey  <tom@tromey.com>
10043
10044         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10045         allocate_on_obstack.
10046         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10047         (get_dwarf2_per_objfile): Update.
10048         (set_dwarf2_per_objfile): Remove.
10049         (dwarf2_has_info, dwarf2_get_section_info): Update.
10050         (dwarf2_free_objfile): Remove.
10051         (_initialize_dwarf2_read): Update.
10052
10053 2019-05-08  Tom Tromey  <tom@tromey.com>
10054
10055         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10056         initializers.
10057         <unsupported_script_warning_printed,
10058         script_not_found_warning_printed>: Now bool.
10059         (auto_load_pspace_data): Change type.
10060         (~auto_load_pspace_info): Rename from
10061         auto_load_pspace_data_cleanup.
10062         (get_auto_load_pspace_data, init_loaded_scripts_info)
10063         (clear_section_scripts, maybe_print_unsupported_script_warning)
10064         (maybe_print_script_not_found_warning, _initialize_auto_load):
10065         Update.
10066
10067 2019-05-08  Tom Tromey  <tom@tromey.com>
10068
10069         * objfiles.c (objfile_pspace_info): Add destructor and
10070         initializers.
10071         (objfiles_pspace_data): Change type.
10072         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10073         (get_objfile_pspace_data): Update.
10074         (objfiles_bfd_data): Change type.
10075         (get_objfile_bfd_data): Update.
10076         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10077
10078 2019-05-08  Tom Tromey  <tom@tromey.com>
10079
10080         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10081         Change type.
10082         (get_catch_syscall_inferior_data): Update.
10083         (catch_syscall_inferior_data_cleanup): Remove.
10084         (_initialize_break_catch_syscall): Update.
10085
10086 2019-05-08  Tom Tromey  <tom@tromey.com>
10087
10088         * inflow.c (struct terminal_info): Add destructor and
10089         initializers.
10090         (inflow_inferior_data): Change type.
10091         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10092         (get_inflow_inferior_data, inflow_inferior_exit)
10093         (swap_terminal_info, _initialize_inflow): Update.
10094
10095 2019-05-08  Tom Tromey  <tom@tromey.com>
10096
10097         * target-dcache.c (target_dcache_cleanup): Remove.
10098         (target_dcache_aspace_key): Change type.
10099         (target_dcache_init_p, target_dcache_invalidate)
10100         (target_dcache_get, target_dcache_get_or_init)
10101         (_initialize_target_dcache): Update.
10102         * dcache.h (struct dcache_deleter): New.
10103
10104 2019-05-08  Tom Tromey  <tom@tromey.com>
10105
10106         * symtab.c (struct symbol_cache): Add destructor and
10107         initializers.
10108         (symbol_cache_key): Move.  Change type.
10109         (make_symbol_cache, free_symbol_cache): Remove.
10110         (get_symbol_cache): Update.
10111         (symbol_cache_cleanup): Remove.
10112         (ALL_PSPACES, symbol_cache_flush)
10113         (maintenance_print_symbol_cache)
10114         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10115         Update.
10116
10117 2019-05-08  Tom Tromey  <tom@tromey.com>
10118
10119         * symtab.c (struct main_info): Add destructor and initializers.
10120         (main_progspace_key): Move.  Change type.
10121         (get_main_info): Update.
10122         (main_info_cleanup): Remove.
10123         (_initialize_symtab): Update.
10124
10125 2019-05-08  Tom Tromey  <tom@tromey.com>
10126
10127         * registry.h (DECLARE_REGISTRY): Define the _key class.
10128
10129 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10130
10131         * NEWS: Merge two 'New commands' sections.
10132
10133 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10134
10135         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10136         parameter and use Ada language definition instead.
10137         (ada_val_print_ptr): Remove unused language parameter.
10138         (ada_val_print_num): Remove language parameter and use Ada language
10139         definition instead.
10140         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10141         parameter.
10142         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10143         parameter and use Ada language definition instead.
10144         (ada_val_print_1): Update all ada_val_print_xxx calls.
10145         Remove language parameter.
10146         (ada_val_print): Update ada_val_print_1 call.
10147
10148 2019-05-08  Tom Tromey  <tromey@adacore.com>
10149
10150         * remote.c (remote_hw_watchpoint_limit)
10151         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10152         Now static.
10153
10154 2019-05-08  Tom Tromey  <tromey@adacore.com>
10155
10156         * maint.c (_initialize_maint_cmds): Move initialization code to
10157         remote.c.
10158         (watchdog, show_watchdog): Move to remote.c.
10159         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10160         "watchdog" static.
10161         (_initialize_remote): Move initialization code from maint.c.
10162         * defs.h (watchdog): Don't declare.
10163
10164 2019-05-08  Tom Tromey  <tromey@adacore.com>
10165
10166         * tui/tui-interp.c: Include main.h.
10167         * interps.c: Include main.h.
10168         * main.h (interpreter_p): Declare.
10169         * defs.h (interpreter_p): Don't declare.
10170
10171 2019-05-08  Tom Tromey  <tromey@adacore.com>
10172
10173         * dwarf2loc.c: Include dwarf2read.h.
10174         * defs.h (read_unsigned_leb128): Don't declare.
10175         * dwarf2read.h (read_unsigned_leb128): Declare.
10176
10177 2019-05-08  Tom Tromey  <tromey@adacore.com>
10178
10179         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10180         method.
10181
10182 2019-05-08  Tom Tromey  <tromey@adacore.com>
10183
10184         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10185         when no wrap column is set.
10186
10187 2019-05-08  Tom Tromey  <tromey@adacore.com>
10188
10189         * c-lang.c (c_get_string): Handle non-C-style arrays.
10190
10191 2019-05-08  Tom Tromey  <tromey@adacore.com>
10192
10193         * typeprint.c (print_offset_data::update): Print the bit offset,
10194         not the number of bits remaining.
10195
10196 2019-05-08  Tom Tromey  <tromey@adacore.com>
10197
10198         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10199         padding at end of comment.
10200
10201 2019-05-08  Tom Tromey  <tromey@adacore.com>
10202
10203         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10204         Compare main types.
10205
10206 2019-05-06  Tom Tromey  <tom@tromey.com>
10207
10208         * common/scoped_mmap.c: Include common-defs.h.
10209         * common/scoped_mmap.h: Don't include config.h.
10210
10211 2019-05-04  Tom Tromey  <tom@tromey.com>
10212
10213         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10214         (struct aarch64_call_info): Add initializers.
10215         <si>: Now a std::vector.
10216         (pass_on_stack, aarch64_push_dummy_call): Update.
10217
10218 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10219             Tom Tromey  <tom@tromey.com>
10220
10221         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10222         (ppc_threads): Now a std::vector.  Now static.
10223         (hwdebug_find_thread_points_by_tid)
10224         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10225         Update.
10226
10227 2019-05-04  Tom Tromey  <tom@tromey.com>
10228
10229         * arc-tdep.c (arc_tdesc_init): Return bool.
10230
10231 2019-05-04  Tom Tromey  <tom@tromey.com>
10232
10233         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10234         Use gdb_assert_not_reached.
10235
10236 2019-05-04  Tom Tromey  <tom@tromey.com>
10237
10238         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10239         "false".
10240
10241 2019-05-04  Tom Tromey  <tom@tromey.com>
10242
10243         * arc-tdep.c (arc_tdesc_init): Use bool.
10244
10245 2019-05-04  Tom Tromey  <tom@tromey.com>
10246
10247         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10248
10249 2019-05-04  Tom Tromey  <tom@tromey.com>
10250
10251         * cli/cli-cmds.c (valid_command_p): Return bool.
10252
10253 2019-05-04  Tom Tromey  <tom@tromey.com>
10254
10255         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10256         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10257
10258 2019-05-04  Raul Tambre  <raul@tambre.ee>
10259
10260         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10261         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10262         operator for comparison.
10263
10264 2019-05-04  Tom Tromey  <tom@tromey.com>
10265
10266         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10267         (lookup_partial_symbol, print_partial_symbols)
10268         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10269         (psymbol_compare): Update.
10270         (add_psymbol_to_bcache): Clear the entire psymbol.
10271         (maintenance_check_psymtabs): Update.
10272         * psympriv.h (struct partial_symbol): Don't derive from
10273         general_symbol_info.
10274         <obj_section, unrelocated_address, address,
10275         set_unrelocated_address>: Update.
10276         <ginfo>: New member.
10277         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10278         (debug_names::write_psymbols): Update.
10279
10280 2019-05-04  Tom de Vries  <tdevries@suse.de>
10281
10282         * contrib/cc-with-tweaks.sh: Support -n arg.
10283
10284 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10285
10286         * corelow.c (core_target::detach): Ensure frame cache and
10287         register caches are cleared.
10288         inferior.c (exit_inferior_1): Likewise.
10289
10290 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10291             Tom Tromey  <tom@tromey.com>
10292
10293         * dictionary.c (collate_pending_symbols_by_language): Remove
10294         "struct" from foreach.
10295         * symtab.c (lookup_global_symbol_from_objfile)
10296         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10297         foreach.
10298         * ser-tcp.c (net_open): Remove "struct" from foreach.
10299         * objfiles.c (objfile_relocate, objfile_rebase)
10300         (objfile_has_symbols): Remove "struct" from foreach.
10301         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10302         from foreach.
10303         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10304         foreach.
10305         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10306         "struct" from foreach.
10307         * ada-lang.c (create_excep_cond_exprs)
10308         (ada_exception_catchpoint_cond_string): Remove "struct" from
10309         foreach.
10310
10311 2019-05-03  Tom Tromey  <tromey@adacore.com>
10312
10313         * ada-exp.y (convert_char_literal): Check suffix of each
10314         enumerator.
10315
10316 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10317
10318         PR ada/21406:
10319         * ada-exp.y (yywrap): Don't define.
10320         * ada-lex.l (%option): Add noyywrap
10321         (yywrap): Remove.
10322
10323 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10324
10325         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10326         _WIN32_WINNT to the XP level, unless already defined to a higher
10327         level.
10328
10329         * unittests/parse-connection-spec-selftests.c:
10330         * ser-tcp.c:
10331         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10332         override.
10333
10334         * symfile.c (find_separate_debug_file): Remove colon from the
10335         drive spec of DOS/Windows file names of the target, so that the
10336         file name produced from DEBUGDIR and the target's directory will
10337         be valid on DOS/Windows systems.
10338
10339 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         * rust-lang.c (val_print_struct): Handle printing structures
10342         containing strings.
10343
10344 2019-05-02  Tom Tromey  <tromey@adacore.com>
10345
10346         * valarith.c (_initialize_valarith): Remove.
10347
10348 2019-05-01  Tom Tromey  <tromey@adacore.com>
10349
10350         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10351         bitfields.
10352
10353 2019-05-01  Tom Tromey  <tromey@adacore.com>
10354
10355         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10356         for big-endian copies.
10357
10358 2019-04-30  Ali Tamur  <tamur@google.com>
10359         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10360         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10361         (read_3_bytes): New function.
10362
10363 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10364
10365         * windows-nat.c (main_thread_id): Delete.
10366         (handle_output_debug_string): Replace main_thread_id by
10367         current_event.dwThreadId.
10368         (fake_create_process): Likewise.
10369         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10370         Do not set main_thread_id.
10371         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10372         current_event.dwThreadId.
10373         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10374
10375 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10376
10377         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10378         Use current_event.dwThreadId instead of main_thread_id.
10379
10380 2019-04-30  Tom Tromey  <tromey@adacore.com>
10381
10382         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10383         (create_excep_cond_exprs): Iterate over program spaces.
10384         (ada_exception_catchpoint_cond_string): Examine all minimal
10385         symbols for exception types.
10386
10387 2019-04-30  Tom Tromey  <tromey@adacore.com>
10388
10389         PR c++/24470:
10390         * dwarf2read.c (process_structure_scope): Handle case where type
10391         has template parameters but no symbol was created.
10392
10393 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10394             Chris January  <chris.january@arm.com>
10395
10396         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10397         qualifier.
10398         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10399
10400 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10401
10402         * f-typeprint.c (f_print_type): Update rules for printing
10403         whitespace.
10404         (f_type_print_varspec_suffix): Likewise.
10405
10406 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10407             Chris January  <chris.january@arm.com>
10408
10409         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10410         function arguments.
10411
10412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10413
10414         * f-lang.c (build_fortran_types): Change name of void type to
10415         lower case.
10416         * f-typeprint.c (f_type_print_base): Print the name of the void
10417         type, rather than a fixed string.
10418         * f-valprint.c (f_decorations): Use lower case void string.
10419
10420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10421             Chris January  <chris.january@arm.com>
10422
10423         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10424         types for Fortran.
10425
10426 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10427             Chris January  <chris.january@arm.com>
10428             David Lecomber  <david.lecomber@arm.com>
10429
10430         * f-exp.y (BINOP_INTRINSIC): New token.
10431         (exp): New parser rule handling BINOP_INTRINSIC.
10432         (f77_keywords): Add new builtin procedures.
10433         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10434         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10435         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10436         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10437         (print_unop_subexp_f): New function.
10438         (print_binop_subexp_f): New function.
10439         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10440         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10441         (dump_subexp_body_f): Likewise.
10442         (operator_check_f): Likewise.
10443         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10444         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10445
10446 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10449         UNOP_KIND.
10450         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10451         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10452         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10453         (operator_length_f): New fuction.
10454         (print_subexp_f): New function.
10455         (op_name_f): New function.
10456         (dump_subexp_body_f): New function.
10457         (operator_check_f): New function.
10458         (exp_descriptor_f): Replace standard expression handling functions
10459         with new functions.
10460         * gdb/fortran-operator.def: New file.
10461         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10462         * gdb/std-operator.def: Remove UNOP_KIND.
10463
10464 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10465
10466         * std-operator.def: Remove unbalanced, stray double quote
10467         character.
10468
10469 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10470             Chris January  <chris.january@arm.com>
10471             Daniel Everett  <daniel.everett@arm.com>
10472             Nick Forrington  <nick.forrington@arm.com>
10473             Richard Bunt  <richard.bunt@arm.com>
10474
10475         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10476         of depth when printing anonymous structs or unions.
10477         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10478         Don't print either the top-level value, or the children if the
10479         max-depth is exceeded.
10480         (ppscm_print_children): When printing the key of a map, allow one
10481         extra level of depth.
10482         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10483         print either the top-level value, or the children if the max-depth
10484         is exceeded.
10485         (print_children): When printing the key of a map, allow one extra
10486         level of depth.
10487         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10488         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10489         (user_print_options): Initialise max_depth field.
10490         (val_print_scalar_or_string_type_p): New function.
10491         (val_print): Check to see if the max depth has been reached.
10492         (val_print_check_max_depth): Define new function.
10493         (show_print_max_depth): New function.
10494         (_initialize_valprint): Add 'print max-depth' option.
10495         * valprint.h (struct value_print_options) <max_depth>: New field.
10496         (val_print_check_max_depth): Declare new function.
10497         * NEWS: Document new feature.
10498
10499 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10500
10501         * ada-lang.c (ada_language_defn): Initialise new field.
10502         * c-lang.c (c_is_string_type_p): New function.
10503         (c_language_defn): Initialise new field.
10504         (cplus_language_defn): Initialise new field.
10505         (asm_language_defn): Initialise new field.
10506         (minimal_language_defn): Initialise new field.
10507         * c-lang.h (c_is_string_type_p): Declare new function.
10508         * d-lang.c (d_language_defn): Initialise new field.
10509         * f-lang.c (f_is_string_type_p): New function.
10510         (f_language_defn): Initialise new field.
10511         * go-lang.c (go_is_string_type_p): New function.
10512         (go_language_defn): Initialise new field.
10513         * language.c (default_is_string_type_p): New function.
10514         (unknown_language_defn): Initialise new field.
10515         (auto_language_defn): Initialise new field.
10516         * language.h (struct language_defn) <la_is_string_type_p>: New
10517         member variable.
10518         (default_is_string_type_p): Declare new function.
10519         * m2-lang.c (m2_language_defn): Initialise new field.
10520         * objc-lang.c (objc_language_defn): Initialise new field.
10521         * opencl-lang.c (opencl_language_defn): Initialise new field.
10522         * p-lang.c (pascal_is_string_type_p): New function.
10523         (pascal_language_defn): Initialise new field.
10524         * rust-lang.c (rust_is_string_type_p): New function.
10525         (rust_language_defn): Initialise new field.
10526
10527 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10528
10529         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10530         New field.
10531         * ada-lang.c (ada_language_defn): Initialise new field.
10532         * c-lang.c (c_language_defn): Likewise.
10533         (cplus_language_defn): Likewise.
10534         (asm_language_defn): Likewise.
10535         (minimal_language_defn): Likewise.
10536         * d-lang.c (d_language_defn): Likewise.
10537         * f-lang.c (f_language_defn): Likewise.
10538         * go-lang.c (go_language_defn): Likewise.
10539         * language.c (unknown_language_defn): Likewise.
10540         (auto_language_defn): Likewise.
10541         * m2-lang.c (m2_language_defn): Likewise.
10542         * objc-lang.c (objc_language_defn): Likewise.
10543         * opencl-lang.c (opencl_language_defn): Likewise.
10544         * p-lang.c (pascal_language_defn): Likewise.
10545         * rust-lang.c (rust_language_defn): Likewise.
10546
10547 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10548
10549         * ada-lang.c (ada_is_character_type): Change return type to bool.
10550         (ada_is_string_type): Likewise.
10551         * ada-lang.h (ada_is_character_type): Update declaration
10552         (ada_is_string_type): Likewise.
10553
10554 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10555
10556         Support style in 'frame|thread apply'
10557
10558         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10559         * record.c (record_start, record_stop): Update callers of
10560         execute_command_to_string with false.
10561         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10562         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10563         methods.
10564         (class string_file): New constructor with term_out parameter.
10565         Override methods term_out and can_emit_style_escape.  New member
10566         term_out.
10567         (class stdio_file): Override can_emit_style_escape.
10568         (class tee_file): Override term_out and can_emit_style_escape.
10569         * utils.h (can_emit_style_escape): Remove.
10570         * utils.c (can_emit_style_escape): Likewise.
10571         Update all callers of can_emit_style_escape (SOMESTREAM) to
10572         SOMESTREAM->can_emit_style_escape.
10573         * source-cache.c (source_cache::get_source_lines): Likewise.
10574         * stack.c (frame_apply_command_count): Call execute_command_to_string
10575         passing the term_out characteristic of the current gdb_stdout.
10576         * thread.c (thr_try_catch_cmd): Likewise.
10577         * top.c (execute_command_to_string): pass term_out parameter
10578         to construct the string_file for the command output.
10579         * ui-file.c (term_cli_styling): New function (most code moved
10580         from utils.c can_emit_style_escape).
10581         (string_file::string_file, string_file::can_emit_style_escape,
10582         stdio_file::can_emit_style_escape, tee_file::term_out,
10583         tee_file::can_emit_style_escape): New functions.
10584
10585 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10586
10587         * NEWS: Mention the new set|show may-call-functions.
10588         * infcall.c (may_call_functions_p): New variable.
10589         (show_may_call_functions_p): New function.
10590         (call_function_by_hand_dummy): Throws an error if not
10591         may-call-functions.
10592         (_initialize_infcall): Call add_setshow_boolean_cmd for
10593         may-call-functions.
10594
10595 2019-04-25  Keith Seitz  <keiths@redhat.com>
10596
10597         PR c++/24367
10598         * cp-support.c (inspect_type): Don't attempt substitutions
10599         of symbol with the same name.
10600
10601 2019-04-25  Tom Tromey  <tromey@adacore.com>
10602
10603         PR gdb/24475:
10604         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10605         static.
10606
10607 2019-04-25  Tom Tromey  <tromey@adacore.com>
10608
10609         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10610         rvalue reference.
10611         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10612         (gdb_xml_parser::parse): Use std::move.
10613         * python/python-internal.h (gdbpy_convert_exception): Take a const
10614         reference.
10615         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10616         std::move.
10617         * python/py-utils.c (gdbpy_convert_exception): Take a const
10618         reference.
10619         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10620         Use std::move.
10621         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10622         Use std::move.
10623         * mi/mi-main.c (mi_print_exception): Take a const reference.
10624         * main.c (handle_command_errors): Take a const reference.
10625         * linespec.c (parse_linespec): Use std::move.
10626         * infcall.c (run_inferior_call): Use std::move.
10627         (call_function_by_hand_dummy): Use std::move.
10628         * exec.c (try_open_exec_file): Use std::move.
10629         * exceptions.h (exception_print, exception_fprintf)
10630         (exception_print_same): Update.
10631         * exceptions.c (print_exception, exception_print)
10632         (exception_fprintf, exception_print_same): Change parameters to
10633         const reference.
10634         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10635         * common/new-op.c: Use std::move.
10636         * common/common-exceptions.h (struct gdb_exception): Add move
10637         constructor.
10638         (struct gdb_exception_error, struct gdb_exception_quit, struct
10639         gdb_quit_bad_alloc): Change constructor to move constructor.
10640         (throw_exception): Change parameter to rvalue reference.
10641         * common/common-exceptions.c (throw_exception): Take rvalue
10642         reference.
10643         * cli/cli-interp.c (safe_execute_command): Use std::move.
10644         * breakpoint.c (insert_bp_location, location_to_sals): Use
10645         std::move.
10646
10647 2019-04-25  Tom Tromey  <tromey@adacore.com>
10648
10649         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10650         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10651         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10652         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10653         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10654         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10655         guile/scm-value.c: Use unpack.
10656         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10657         gdbscm_gdb_exception.
10658         (gdbscm_throw_gdb_exception): Likewise.
10659         (struct gdbscm_gdb_exception): New.
10660         (unpack): New function.
10661         (gdbscm_wrap): Use unpack.
10662
10663 2019-04-25  Tom Tromey  <tromey@adacore.com>
10664
10665         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10666         (gdb_rl_callback_handler): Use std::move.
10667         * common/common-exceptions.h (struct gdb_exception): Add move
10668         assignment operator.
10669         (throw_exception_sjlj): Change "exception" to const reference.
10670         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10671         (throw_exception_sjlj): Change "exception" to const reference.
10672
10673 2019-04-25  Tom Tromey  <tromey@adacore.com>
10674
10675         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10676         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10677         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10678         Update.
10679         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10680         Update.
10681         * mi/mi-interp.c (mi_interp::exec): Update.
10682         * linespec.c (parse_linespec): Update.
10683         * infcall.c (run_inferior_call): Update.
10684         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10685         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10686         (gdbscm_lookup_global_symbol): Update.
10687         * guile/scm-param.c (gdbscm_parameter_value): Update.
10688         * guile/scm-frame.c (gdbscm_frame_read_register)
10689         (gdbscm_frame_read_var): Update.
10690         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10691         * exec.c (try_open_exec_file): Update.
10692         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10693         (gdb_rl_callback_handler): Update.
10694         * common/common-exceptions.h (exception_none): Don't declare.
10695         * common/common-exceptions.c (exception_none): Don't define.
10696         (struct catcher) <exception>: Update.
10697         * cli/cli-interp.c (safe_execute_command): Update.
10698         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10699
10700 2019-04-25  Ali Tamur  <tamur@google.com>
10701
10702         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10703         (read_attribute_value): Likewise.
10704         (dwarf2_read_addr_index): Update comment.
10705         (read_str_index): Add DW_FORM_strx.
10706         (dwarf2_string_attr): Likewise.
10707         (dwarf2_const_value_attr): Likewise.
10708         (dump_die_shallow): Likewise.
10709         (dwarf2_fetch_constant_bytes): Likewise.
10710         (skip_form_bytes): Likewise.
10711         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10712
10713 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10714
10715         PR corefiles/11608
10716         PR corefiles/18187
10717         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10718         OFFSET.  Verify if current mapping contains an ELF header.
10719         (linux_find_memory_regions_full): Adjust call to
10720         dump_mapping_p.
10721
10722 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10723             Kang Li <kanglictf@gmail.com>
10724
10725         PR gdb/21600
10726
10727         * dwarf2-frame.c (read_initial_length): Be consistent about using
10728         unsigned representation of length.
10729         (decode_frame_entry_1): Likewise.  Check for wraparound of
10730         end pointer as well as buffer overflow.
10731
10732 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10733
10734         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10735         "vq".
10736
10737 2019-04-24  Tom Tromey  <tromey@adacore.com>
10738
10739         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10740
10741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10742
10743         * s12z-tdep.c (s12z_unwind_pc): Delete.
10744         (s12z_unwind_sp): Delete.
10745         (s12z_gdbarch_init): Don't register deleted functions with
10746         gdbarch.
10747
10748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10749
10750         * rl78-tdep.c (rl78_unwind_sp): Delete.
10751         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10752
10753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10754
10755         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10756         (xstormy16_unwind_pc): Delete.
10757         (xstormy16_dummy_id): Delete.
10758         (xstormy16_gdbarch_init): Don't register deleted functions with
10759         gdbarch.
10760
10761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10762
10763         * vax-tdep.c (vax_unwind_pc): Delete.
10764         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10765
10766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10767
10768         * v850-tdep.c (v850_unwind_sp): Delete.
10769         (v850_unwind_pc): Delete.
10770         (v850_dummy_id): Delete.
10771         (v850_gdbarch_init): Don't register deleted functions with
10772         gdbarch.
10773
10774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10775
10776         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10777         (tilegx_unwind_pc): Delete.
10778         (tilegx_unwind_dummy_id): Delete.
10779         (tilegx_gdbarch_init): Don't register deleted functions with
10780         gdbarch.
10781
10782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10783
10784         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10785         (tic6x_dummy_id): Delete.
10786         (tic6x_gdbarch_init): Don't register deleted functions with
10787         gdbarch.
10788
10789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10790
10791         * sparc-tdep.c (sparc_unwind_pc): Delete.
10792         (sparc32_gdbarch_init): Don't register deleted function with
10793         gdbarch.
10794
10795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10796
10797         * sh-tdep.c (sh_unwind_sp): Delete.
10798         (sh_unwind_pc): Delete.
10799         (sh_dummy_id): Delete.
10800         (sh_gdbarch_init): Don't register deleted functions with
10801         gdbarch.
10802
10803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * score-tdep.c (score_unwind_sp): Delete.
10806         (score_unwind_pc): Delete.
10807         (score_dummy_id): Delete.
10808         (score_gdbarch_init): Don't register deleted functions with
10809         gdbarch.
10810
10811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10812
10813         * rx-tdep.c (rx_unwind_pc): Delete.
10814         (rx_unwind_sp): Delete.
10815         (rx_dummy_id): Delete.
10816         (rx_gdbarch_init): Don't register deleted functions with
10817         gdbarch.  Update comment.
10818
10819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10820
10821         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10822         (rs6000_dummy_id): Delete.
10823         (rs6000_gdbarch_init): Don't register deleted functions with
10824         gdbarch.
10825
10826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10827
10828         * or1k-tdep.c (or1k_dummy_id): Delete.
10829         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10830
10831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10832
10833         * nios2-tdep.c (nios2_dummy_id): Delete.
10834         (nios2_unwind_sp): Delete.
10835         (nios2_gdbarch_init): Don't register deleted functions with
10836         gdbarch.
10837
10838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10839
10840         * nds32-tdep.c (nds32_dummy_id): Delete.
10841         (nds32_unwind_pc): Delete.
10842         (nds32_unwind_sp): Delete.
10843         (nds32_gdbarch_init): Don't register deleted functions with
10844         gdbarch.
10845
10846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10847
10848         * msp430-tdep.c (msp430_unwind_pc): Delete.
10849         (msp430_unwind_sp): Delete.
10850         (msp430_dummy_id): Delete.
10851         (msp430_gdbarch_init): Don't register deleted functions with
10852         gdbarch.
10853
10854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10855
10856         * moxie-tdep.c (moxie_unwind_sp): Delete.
10857         (moxie_unwind_pc): Delete.
10858         (moxie_dummy_id): Delete.
10859         (moxie_gdbarch_init): Don't register deleted functions with
10860         gdbarch.
10861
10862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10863
10864         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10865         (mn10300_unwind_pc): Delete.
10866         (mn10300_unwind_sp): Delete.
10867         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10868         mn10300_unwind_sp.
10869         (mn10300_frame_unwind_init): Don't register deleted functions with
10870         gdbarch.
10871
10872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10873
10874         * mep-tdep.c (mep_unwind_pc): Delete.
10875         (mep_unwind_sp): Delete.
10876         (mep_dummy_id): Delete.
10877         (mep_gdbarch_init): Don't register deleted functions with
10878         gdbarch.
10879
10880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10881
10882         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10883         (m68hc11_unwind_sp): Delete.
10884         (m68hc11_gdbarch_init): Don't register deleted functions with
10885         gdbarch.
10886
10887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10888
10889         * m32r-tdep.c (m32r_unwind_sp): Delete.
10890         (m32r_unwind_pc): Delete.
10891         (m32r_dummy_id): Delete.
10892         (m32r_gdbarch_init): Don't register deleted functions with
10893         gdbarch.
10894
10895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10896
10897         * m32c-tdep.c (m32c_unwind_pc): Delete.
10898         (m32c_unwind_sp): Delete.
10899         (m32c_dummy_id): Delete.
10900         (m32c_gdbarch_init): Don't register deleted functions with
10901         gdbarch.
10902
10903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10904
10905         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10906         (lm32_unwind_pc): Delete.
10907         (lm32_dummy_id): Delete.
10908         (lm32_gdbarch_init): Don't register deleted functions with
10909         gdbarch.
10910
10911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10912
10913         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10914         (iq2000_unwind_pc): Delete.
10915         (iq2000_dummy_id): Delete.
10916         (iq2000_gdbarch_init): Don't register deleted functions with
10917         gdbarch.
10918
10919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10920
10921         * nds32-tdep.c (nds32_type_align): Delete.
10922         (nds32_push_dummy_call): Use type_align instead.
10923
10924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * arm-tdep.c (arm_type_align): Only handle vector override case.
10927         (arm_push_dummy_call): Use type_align.
10928         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10929
10930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10931
10932         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10933         case.
10934         (pass_on_stack): Use type_align.
10935         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10936         function.
10937
10938 2019-04-23  Tom Tromey  <tromey@adacore.com>
10939
10940         * dwarf2read.c (line_header::file_name_at): Remove unused
10941         overload.
10942
10943 2019-04-23  Tom de Vries  <tdevries@suse.de>
10944
10945         PR gdb/24438
10946         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10947         invocation.
10948
10949
10950 2019-03-27  Ali Tamur  <tamur@google.com>
10951
10952         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10953         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10954         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10955         (dwarf_expr_context::get_addr_index): Likewise
10956         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10957         (symbol_needs_eval_context::get_addr_index): Likewise
10958         (disassemble_dwarf_expression): Add DW_OP_addrx
10959         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10960         (read_cutu_die_from_dwo): Update comment
10961         (skip_one_die): Add DW_FORM_addrx
10962         (read_attribute_value): Likewise
10963         (var_decode_location): Add DW_OP_addrx
10964         (dwarf2_const_value_attr): Add DW_FORM_addrx
10965         (dump_die_shallow): Likewise
10966         (dwarf2_fetch_constant_bytes): Likewise
10967         (decode_locdesc): Add DW_OP_addrx
10968         (skip_form_bytes): Add DW_FORM_addrx
10969
10970 2019-04-22  Ali Tamur  <tamur@google.com>
10971
10972         * MAINTAINERS (Write After Approval): Add self.
10973
10974 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10975
10976         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10977         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10978         (open_symbol_file_object): Likewise.
10979         (svr4_default_sos): Add info parameter.
10980         (svr4_read_so_list): Likewise.
10981         (svr4_current_sos_direct): Adjust functions calls to pass down
10982         info.
10983         (svr4_current_sos_1): Add info parameter.
10984         (svr4_current_sos): Call get_svr4_info, pass info down to
10985         svr4_current_sos_1.
10986         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10987         get_svr4_info.
10988         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10989         get_svr4_info.
10990         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10991         to get_svr4_info.
10992         (probes_table_remove_objfile_probes): Likewise.
10993         (register_solib_event_probe): Add info parameter.
10994         (solist_update_incremental): Pass info parameter down to
10995         svr4_read_so_list.
10996         (disable_probes_interface): Add info parameter.
10997         (svr4_handle_solib_event): Pass current_program_space to
10998         get_svr4_info.  Adjust disable_probes_interface cleanup.
10999         (svr4_create_probe_breakpoints): Add info parameter, pass it
11000         down to register_solib_event_probe.
11001         (svr4_create_solib_event_breakpoints): Add info parameter,
11002         pass it down to svr4_create_probe_breakpoints.
11003         (enable_break): Pass info down to
11004         svr4_create_solib_event_breakpoints.
11005         (svr4_solib_create_inferior_hook): Pass current_program_space to
11006         get_svr4_info.
11007         (svr4_clear_solib): Likewise.
11008
11009 2019-04-22  Pedro Alves  <palves@redhat.com>
11010
11011         * solib-svr4.c (svr4_free_objfile_observer): New.
11012         (probe_and_action::objfile): New field.
11013         (probes_table_htab_remove_objfile_probes)
11014         (probes_table_remove_objfile_probes): New functions.
11015         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11016         in the new probe_and_action.  Don't store the probe in 'lookup'.
11017         (svr4_create_probe_breakpoints): Pass objfile to
11018         register_solib_event_probe.
11019         (_initialize_svr4_solib): Register a free_objfile observer.
11020
11021 2019-04-19  Tom Tromey  <tom@tromey.com>
11022
11023         * common/queue.h: Remove.
11024
11025 2019-04-19  Tom Tromey  <tom@tromey.com>
11026
11027         * event-loop.c: Don't include "common/queue.h".
11028
11029 2019-04-19  Tom Tromey  <tom@tromey.com>
11030
11031         * remote.c (remote_target): Use delete.
11032         * remote-notif.h: Include <list>, not "common/queue.h".
11033         (notif_client_p): Remove typedef.
11034         (remote_notif_state): Add constructor, destructor, initializer.
11035         <notif_queue>: Now a std::list.
11036         (remote_notif_state_xfree): Don't declare.
11037         * remote-notif.c (remote_notif_process, handle_notification)
11038         (remote_notif_state_allocate): Update.
11039         (~remote_notif_state): Rename from remote_notif_state_xfree.
11040
11041 2019-04-19  Tom Tromey  <tom@tromey.com>
11042
11043         * symfile.c (reread_symbols): Update.
11044         * objfiles.c (objfile_register_static_link)
11045         (objfile_lookup_static_link): Update
11046         (~objfile) Don't delete static_links.
11047         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11048
11049 2019-04-19  Tom Tromey  <tom@tromey.com>
11050
11051         * type-stack.h (struct type_stack) <insert>: Constify string.
11052         * type-stack.c (type_stack::insert): Constify string.
11053         * gdbtypes.h (lookup_template_type): Update.
11054         (address_space_name_to_int): Update.
11055         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11056         const.
11057         (lookup_template_type): Make name const.
11058         * c-exp.y: Update rules.
11059         (lex_one_token, classify_name, classify_inner_name)
11060         (c_print_token): Update.
11061         * p-exp.y: Update rules.
11062         (yylex): Update.
11063         * f-exp.y: Update rules.
11064         (yylex): Update.
11065         * d-exp.y: Update rules.
11066         (lex_one_token, classify_name, classify_inner_name): Update.
11067         * parse.c (write_dollar_variable, copy_name): Return std::string.
11068         * parser-defs.h (copy_name): Change return type.
11069         * m2-exp.y: Update rules.
11070         (yylex): Update.
11071         * go-exp.y (lex_one_token): Update.
11072         Update rules.
11073         (classify_unsafe_function, classify_packaged_name)
11074         (classify_name, yylex): Update.
11075
11076 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11077
11078         * configure.ac: add --enable-source-highlight switch.
11079         * configure: Regenerate.
11080         * top.c (print_gdb_version): plumb --enable-source-highlight
11081         status to "show configuration".
11082
11083 2019-04-19  Tom Tromey  <tromey@adacore.com>
11084
11085         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11086         Check ADA_TYPE_P.
11087         (empty_record, ada_template_to_fixed_record_type_1)
11088         (template_to_static_fixed_type)
11089         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11090         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11091         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11092         macros.
11093
11094 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11095
11096         PR symtab/24423:
11097         * source.c (print_source_lines_base): Advance "iter" when a
11098         control character is seen.
11099
11100 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11101
11102         * inferior.h (struct infcall_suspend_state_deleter):
11103         Catch exception in destructor to avoid crash.
11104
11105 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11106
11107         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11108         close to the add_com "shell".
11109
11110 2019-04-18  Tom Tromey  <tromey@adacore.com>
11111
11112         * process-stratum-target.h (class process_stratum_target)
11113         <stratum>: Add "final".
11114
11115 2019-04-17  Tom Tromey  <tromey@adacore.com>
11116
11117         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11118         against nullptr before use.
11119
11120 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11121
11122         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11123
11124 2019-04-17  Jim Wilson  <jimw@sifive.com>
11125             Andrew Burgess  <andrew.burgess@embecosm.com>
11126
11127         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11128         code read might fail, assume 4-byte breakpoint in that case.
11129
11130 2019-04-15  Leszek Swirski  <leszeks@google.com>
11131
11132         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11133         rather than a hand-rolled POD check when checking for forced MEMORY
11134         classification.
11135
11136 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11137
11138         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11139         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11140         function.
11141         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11142         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11143         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11144         declaration.
11145
11146 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11147
11148         * aarch64-linux-nat.c
11149         (aarch64_linux_nat_target::thread_architecture): Add override.
11150         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11151         each VQ.
11152
11153 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11154
11155         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11156
11157 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11158
11159         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11160         target types of size 96-bits, add some additional comments, and
11161         check that the builtin type we found was the correct size.
11162
11163 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11164
11165         * utils.c (prompt_for_continue): Don't restore the styling at the
11166         end, as applied_style has the wrong value.  This fixes styling in
11167         long lists of file names that are interrupted by the "Continue?"
11168         prompt.
11169
11170 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11173         * c-lang.c (c_language_defn): Likewise.
11174         (cplus_language_defn): Likewise.
11175         (asm_language_defn): Likewise.
11176         (minimal_language_defn): Likewise.
11177         * d-lang.c (d_language_defn): Likewise.
11178         * f-lang.c (f_language_defn): Likewise.
11179         * go-lang.c (go_language_defn): Likewise.
11180         * language.c (unknown_language_defn): Likewise.
11181         (auto_language_defn): Likewise.
11182         * language.h (struct language_defn): Remove la_magic field.
11183         (LANG_MAGIC): Delete.
11184         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11185         * objc-lang.c (objc_language_defn): Likewise.
11186         * opencl-lang.c (opencl_language_defn): Likewise.
11187         * p-lang.c (pascal_language_defn): Likewise.
11188         * rust-lang.c (rust_language_defn): Likewise.
11189
11190 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11191
11192         * riscv-tdep.c (riscv_type_align): New function.
11193         (riscv_type_alignment): Delete.
11194         (riscv_arg_location): Use 'type_align'.
11195         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11196
11197 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11198
11199         * gdbtypes.c (type_align): A struct with no non-static fields also
11200         has alignment of 1.
11201
11202 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11203
11204         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11205         component to 0.
11206         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11207         member.
11208         (riscv_struct_info::analyse): New implementation using new
11209         analyse_inner member function.
11210         (riscv_struct_info::field_offset): New member function.
11211         (riscv_struct_info::m_offsets): New member variable.
11212         (riscv_struct_info::analyse_inner): New private member function,
11213         takes the old implementation of riscv_struct_info::analyse but
11214         extended to track field offsets.
11215         (riscv_call_arg_struct): Update the struct folding special cases
11216         to handle cases where empty C++ structs, which are non-zero
11217         length, are found.
11218         (riscv_arg_location): Initialise the length of each location, a
11219         non-zero length now indicates the location is in use.
11220         (riscv_push_dummy_call): Allow for the first location having a
11221         non-zero offset when setting up arguments.
11222         (riscv_return_value): Likewise, but for return values.
11223
11224 2019-04-11  Tom Tromey  <tromey@adacore.com>
11225
11226         * utils.c (internal_vproblem): Make "msg" const.
11227
11228 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11229
11230         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11231         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11232         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11233         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11234
11235 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11236
11237         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11238         function.
11239         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11240         of amd64_collect_native_gregset.
11241         (amd64_linux_nat_target::store_registers): Likewise.
11242
11243 2019-04-10  Tom Tromey  <tom@tromey.com>
11244
11245         * symtab.c (lookup_global_symbol_from_objfile)
11246         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11247         * objfiles.h (class separate_debug_iterator): New.
11248         (class separate_debug_range): New.
11249         (struct objfile) <separate_debug_objfiles>: New method.
11250         (objfile_separate_debug_iterate): Don't declare.
11251         * objfiles.c (separate_debug_iterator::operator++): Rename from
11252         objfile_separate_debug_iterate.
11253         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11254         iterator.
11255         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11256         iterator.
11257
11258 2019-04-10  Tom Tromey  <tom@tromey.com>
11259
11260         * symfile.c (reread_symbols): Remove old comment.
11261         * objfiles.c (free_all_objfiles): Fix a typo.
11262
11263 2019-04-10  Tom Tromey  <tom@tromey.com>
11264
11265         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11266         * minsyms.c (lookup_minimal_symbol): Use foreach.
11267         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11268         (lookup_minimal_symbol_solib_trampoline): Likewise.
11269         * symfile.c (reread_symbols): Use foreach.
11270
11271 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11272             Tom Tromey  <tromey@adacore.com>
11273
11274         PR rust/24414:
11275         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11276         (rust_lex_int_test): Change "value" to be LONGEST.
11277         (rust_lex_tests): Add test for long integer literal.
11278
11279 2019-04-09  Tom Tromey  <tromey@adacore.com>
11280
11281         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11282         to bool.
11283         (extended_remote_target::attach): Update.
11284         (remote_target::remote_notice_new_inferior): Update.
11285         (remote_target::add_current_inferior_and_thread): Update.
11286         * inferior.c (exit_inferior_1): Use "false".
11287         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11288
11289 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11290
11291         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11292         the "start" command.
11293
11294 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11295
11296         * python/py-inferior.c (infpy_thread_from_thread_handle):
11297         Adjust comments to reflect renaming of thread_from_thread_handle
11298         to thread_from_handle.  Adjust keywords.  Fix type error message.
11299         (inferior_object_methods): Add thread_from_handle.  Retain
11300         thread_from_thread_handle, but mark it as deprecated.
11301
11302 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11303
11304         * gdbthread.h (find_thread_by_handle): Revise declaration.
11305         * thread.c (find_thread_by_handle): Likewise.  Adjust
11306         implementation too.
11307         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11308         support for buffer objects as handles.
11309
11310 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11311
11312         * python/py-infthread.c (thpy_thread_handle): New function.
11313         (thread_object_methods): Register thpy_thread_handle.
11314
11315 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11316
11317         * gdbthread.h (thread_to_thread_handle): Declare.
11318         * thread.c (gdbtypes.h): Include.
11319         (thread_to_thread_handle): New function.
11320
11321         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11322         (target_thread_info_to_thread_handle): Declare.
11323         * target.c (target_thread_info_to_thread_handle): New function.
11324         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11325         * target-delegates.c: Regenerate.
11326
11327         * linux-thread-db.c (class thread_db_target): Add method
11328         thread_info_to_thread_handle.
11329         (thread_db_target::thread_info_to_thread_handle): Define.
11330         * remote.c (class remote_target): Add new method
11331         thread_info_to_thread_handle.
11332         (remote_target::thread_info_to_thread_handle): Define.
11333
11334 2019-04-08  Pedro Alves  <palves@redhat.com>
11335
11336         * common/common-exceptions.c (throw_exception): Don't create
11337         named object to throw; throw directly.
11338         (throw_it): Likewise.  Don't initialize gdb_exception::message
11339         here, with new; pass FMT and AP to the ctor instead.
11340         * common/common-exceptions.h: Include <string>.
11341         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11342         const char *, va_list)): New ctor.  Use std::make_shared.
11343         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11344         errors)): Delete.
11345         (gdb_exception_error::gdb_exception_error(enum errors, const char
11346         *, va_list)): New.
11347         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11348         Add assertion.
11349         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11350         errors)): Delete.
11351         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11352         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11353         Add assertion.
11354
11355 2019-04-08  Tom Tromey  <tom@tromey.com>
11356
11357         * valops.c (value_rtti_indirect_type): Replace throw_exception
11358         with throw.
11359         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11360         with throw.
11361         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11362         throw.
11363         * target.c (target_translate_tls_address): Replace throw_exception
11364         with throw.
11365         * stack.c (frame_apply_command_count): Replace throw_exception
11366         with throw.
11367         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11368         throw.
11369         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11370         with throw.
11371         * rs6000-tdep.c (rs6000_frame_cache)
11372         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11373         * remote.c: Replace throw_exception with throw.
11374         * record-full.c (record_full_message, record_full_wait_1)
11375         (record_full_restore): Replace throw_exception with throw.
11376         * record-btrace.c:
11377         (get_thread_current_frame_id, record_btrace_start_replaying)
11378         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11379         (cmd_record_btrace_start): Replace throw_exception with throw.
11380         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11381         throw.
11382         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11383         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11384         * linespec.c:
11385         (find_linespec_symbols): Replace throw_exception with throw.
11386         * infrun.c (displaced_step_prepare, resume): Replace
11387         throw_exception with throw.
11388         * infcmd.c (post_create_inferior): Replace throw_exception with
11389         throw.
11390         * inf-loop.c (inferior_event_handler): Replace throw_exception
11391         with throw.
11392         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11393         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11394         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11395         (get_prev_frame_always, get_frame_pc_if_available)
11396         (get_frame_address_in_block_if_available, get_frame_language):
11397         Replace throw_exception with throw.
11398         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11399         throw_exception with throw.
11400         * eval.c (fetch_subexp_value, evaluate_var_value)
11401         (evaluate_funcall, evaluate_subexp_standard): Replace
11402         throw_exception with throw.
11403         * dwarf2loc.c (call_site_find_chain)
11404         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11405         Replace throw_exception with throw.
11406         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11407         with throw.
11408         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11409         throw.
11410         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11411         * completer.c (complete_line_internal): Replace throw_exception
11412         with throw.
11413         * compile/compile-object-run.c (compile_object_run): Replace
11414         throw_exception with throw.
11415         * cli/cli-script.c (process_next_line): Replace throw_exception
11416         with throw.
11417         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11418         (btrace_enable, btrace_maint_update_pt_packets): Replace
11419         throw_exception with throw.
11420         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11421         throw_exception with throw.
11422         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11423         throw_exception with throw.
11424         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11425         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11426         * aarch64-tdep.c (aarch64_make_prologue_cache)
11427         (aarch64_make_stub_cache): Replace throw_exception with throw.
11428
11429 2019-04-08  Tom Tromey  <tom@tromey.com>
11430
11431         * common/common-exceptions.c (throw_exception): Rename from
11432         throw_exception_cxx.  Remove old copy.  Make argument const.
11433         (throw_it): Create and throw exception objects directly.
11434         * common/common-exceptions.h (throw_exception): Make argument
11435         const.
11436         (struct gdb_exception_error): Add constructor.
11437         (struct gdb_exception_quit): Add constructor.
11438
11439 2019-04-08  Tom Tromey  <tom@tromey.com>
11440
11441         * common/common-exceptions.h (exception_rethrow): Don't declare.
11442         (TRY_SJLJ): Update comment.
11443         (TRY, CATCH, END_CATCH): Remove.
11444         * common/common-exceptions.c (exception_rethrow): Remove.
11445
11446 2019-04-08  Tom Tromey  <tom@tromey.com>
11447
11448         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11449         Remove.
11450         (gdb_exception_error): Rename from
11451         gdb_exception_RETURN_MASK_ERROR.
11452         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11453         (gdb_quit_bad_alloc): Update.
11454         * aarch64-tdep.c: Update.
11455         * ada-lang.c: Update.
11456         * ada-typeprint.c: Update.
11457         * ada-valprint.c: Update.
11458         * amd64-tdep.c: Update.
11459         * arch-utils.c: Update.
11460         * break-catch-throw.c: Update.
11461         * breakpoint.c: Update.
11462         * btrace.c: Update.
11463         * c-varobj.c: Update.
11464         * cli/cli-cmds.c: Update.
11465         * cli/cli-interp.c: Update.
11466         * cli/cli-script.c: Update.
11467         * common/common-exceptions.c: Update.
11468         * common/new-op.c: Update.
11469         * common/selftest.c: Update.
11470         * compile/compile-c-symbols.c: Update.
11471         * compile/compile-cplus-symbols.c: Update.
11472         * compile/compile-object-load.c: Update.
11473         * compile/compile-object-run.c: Update.
11474         * completer.c: Update.
11475         * corelow.c: Update.
11476         * cp-abi.c: Update.
11477         * cp-support.c: Update.
11478         * cp-valprint.c: Update.
11479         * darwin-nat.c: Update.
11480         * disasm-selftests.c: Update.
11481         * dtrace-probe.c: Update.
11482         * dwarf-index-cache.c: Update.
11483         * dwarf-index-write.c: Update.
11484         * dwarf2-frame-tailcall.c: Update.
11485         * dwarf2-frame.c: Update.
11486         * dwarf2loc.c: Update.
11487         * dwarf2read.c: Update.
11488         * eval.c: Update.
11489         * event-loop.c: Update.
11490         * event-top.c: Update.
11491         * exec.c: Update.
11492         * f-valprint.c: Update.
11493         * fbsd-tdep.c: Update.
11494         * frame-unwind.c: Update.
11495         * frame.c: Update.
11496         * gdbtypes.c: Update.
11497         * gnu-v3-abi.c: Update.
11498         * guile/guile-internal.h: Update.
11499         * guile/scm-block.c: Update.
11500         * guile/scm-breakpoint.c: Update.
11501         * guile/scm-cmd.c: Update.
11502         * guile/scm-disasm.c: Update.
11503         * guile/scm-frame.c: Update.
11504         * guile/scm-lazy-string.c: Update.
11505         * guile/scm-math.c: Update.
11506         * guile/scm-param.c: Update.
11507         * guile/scm-ports.c: Update.
11508         * guile/scm-pretty-print.c: Update.
11509         * guile/scm-symbol.c: Update.
11510         * guile/scm-symtab.c: Update.
11511         * guile/scm-type.c: Update.
11512         * guile/scm-value.c: Update.
11513         * i386-linux-tdep.c: Update.
11514         * i386-tdep.c: Update.
11515         * inf-loop.c: Update.
11516         * infcall.c: Update.
11517         * infcmd.c: Update.
11518         * infrun.c: Update.
11519         * jit.c: Update.
11520         * language.c: Update.
11521         * linespec.c: Update.
11522         * linux-fork.c: Update.
11523         * linux-nat.c: Update.
11524         * linux-tdep.c: Update.
11525         * linux-thread-db.c: Update.
11526         * main.c: Update.
11527         * mi/mi-cmd-break.c: Update.
11528         * mi/mi-cmd-stack.c: Update.
11529         * mi/mi-interp.c: Update.
11530         * mi/mi-main.c: Update.
11531         * objc-lang.c: Update.
11532         * p-valprint.c: Update.
11533         * parse.c: Update.
11534         * ppc-linux-tdep.c: Update.
11535         * printcmd.c: Update.
11536         * python/py-arch.c: Update.
11537         * python/py-breakpoint.c: Update.
11538         * python/py-cmd.c: Update.
11539         * python/py-finishbreakpoint.c: Update.
11540         * python/py-frame.c: Update.
11541         * python/py-framefilter.c: Update.
11542         * python/py-gdb-readline.c: Update.
11543         * python/py-inferior.c: Update.
11544         * python/py-infthread.c: Update.
11545         * python/py-lazy-string.c: Update.
11546         * python/py-linetable.c: Update.
11547         * python/py-objfile.c: Update.
11548         * python/py-param.c: Update.
11549         * python/py-prettyprint.c: Update.
11550         * python/py-progspace.c: Update.
11551         * python/py-record-btrace.c: Update.
11552         * python/py-record.c: Update.
11553         * python/py-symbol.c: Update.
11554         * python/py-type.c: Update.
11555         * python/py-unwind.c: Update.
11556         * python/py-utils.c: Update.
11557         * python/py-value.c: Update.
11558         * python/python.c: Update.
11559         * record-btrace.c: Update.
11560         * record-full.c: Update.
11561         * remote-fileio.c: Update.
11562         * remote.c: Update.
11563         * riscv-tdep.c: Update.
11564         * rs6000-aix-tdep.c: Update.
11565         * rs6000-tdep.c: Update.
11566         * rust-exp.y: Update.
11567         * rust-lang.c: Update.
11568         * s390-tdep.c: Update.
11569         * selftest-arch.c: Update.
11570         * solib-dsbt.c: Update.
11571         * solib-frv.c: Update.
11572         * solib-spu.c: Update.
11573         * solib-svr4.c: Update.
11574         * solib.c: Update.
11575         * sparc64-linux-tdep.c: Update.
11576         * stack.c: Update.
11577         * symfile-mem.c: Update.
11578         * symmisc.c: Update.
11579         * target.c: Update.
11580         * thread.c: Update.
11581         * top.c: Update.
11582         * tracefile-tfile.c: Update.
11583         * tui/tui.c: Update.
11584         * typeprint.c: Update.
11585         * unittests/cli-utils-selftests.c: Update.
11586         * unittests/parse-connection-spec-selftests.c: Update.
11587         * valops.c: Update.
11588         * valprint.c: Update.
11589         * value.c: Update.
11590         * varobj.c: Update.
11591         * windows-nat.c: Update.
11592         * x86-linux-nat.c: Update.
11593         * xml-support.c: Update.
11594
11595 2019-04-08  Tom Tromey  <tom@tromey.com>
11596
11597         * xml-support.c: Use C++ exception handling.
11598         * x86-linux-nat.c: Use C++ exception handling.
11599         * windows-nat.c: Use C++ exception handling.
11600         * varobj.c: Use C++ exception handling.
11601         * value.c: Use C++ exception handling.
11602         * valprint.c: Use C++ exception handling.
11603         * valops.c: Use C++ exception handling.
11604         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11605         handling.
11606         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11607         * typeprint.c: Use C++ exception handling.
11608         * tui/tui.c: Use C++ exception handling.
11609         * tracefile-tfile.c: Use C++ exception handling.
11610         * top.c: Use C++ exception handling.
11611         * thread.c: Use C++ exception handling.
11612         * target.c: Use C++ exception handling.
11613         * symmisc.c: Use C++ exception handling.
11614         * symfile-mem.c: Use C++ exception handling.
11615         * stack.c: Use C++ exception handling.
11616         * sparc64-linux-tdep.c: Use C++ exception handling.
11617         * solib.c: Use C++ exception handling.
11618         * solib-svr4.c: Use C++ exception handling.
11619         * solib-spu.c: Use C++ exception handling.
11620         * solib-frv.c: Use C++ exception handling.
11621         * solib-dsbt.c: Use C++ exception handling.
11622         * selftest-arch.c: Use C++ exception handling.
11623         * s390-tdep.c: Use C++ exception handling.
11624         * rust-lang.c: Use C++ exception handling.
11625         * rust-exp.y: Use C++ exception handling.
11626         * rs6000-tdep.c: Use C++ exception handling.
11627         * rs6000-aix-tdep.c: Use C++ exception handling.
11628         * riscv-tdep.c: Use C++ exception handling.
11629         * remote.c: Use C++ exception handling.
11630         * remote-fileio.c: Use C++ exception handling.
11631         * record-full.c: Use C++ exception handling.
11632         * record-btrace.c: Use C++ exception handling.
11633         * python/python.c: Use C++ exception handling.
11634         * python/py-value.c: Use C++ exception handling.
11635         * python/py-utils.c: Use C++ exception handling.
11636         * python/py-unwind.c: Use C++ exception handling.
11637         * python/py-type.c: Use C++ exception handling.
11638         * python/py-symbol.c: Use C++ exception handling.
11639         * python/py-record.c: Use C++ exception handling.
11640         * python/py-record-btrace.c: Use C++ exception handling.
11641         * python/py-progspace.c: Use C++ exception handling.
11642         * python/py-prettyprint.c: Use C++ exception handling.
11643         * python/py-param.c: Use C++ exception handling.
11644         * python/py-objfile.c: Use C++ exception handling.
11645         * python/py-linetable.c: Use C++ exception handling.
11646         * python/py-lazy-string.c: Use C++ exception handling.
11647         * python/py-infthread.c: Use C++ exception handling.
11648         * python/py-inferior.c: Use C++ exception handling.
11649         * python/py-gdb-readline.c: Use C++ exception handling.
11650         * python/py-framefilter.c: Use C++ exception handling.
11651         * python/py-frame.c: Use C++ exception handling.
11652         * python/py-finishbreakpoint.c: Use C++ exception handling.
11653         * python/py-cmd.c: Use C++ exception handling.
11654         * python/py-breakpoint.c: Use C++ exception handling.
11655         * python/py-arch.c: Use C++ exception handling.
11656         * printcmd.c: Use C++ exception handling.
11657         * ppc-linux-tdep.c: Use C++ exception handling.
11658         * parse.c: Use C++ exception handling.
11659         * p-valprint.c: Use C++ exception handling.
11660         * objc-lang.c: Use C++ exception handling.
11661         * mi/mi-main.c: Use C++ exception handling.
11662         * mi/mi-interp.c: Use C++ exception handling.
11663         * mi/mi-cmd-stack.c: Use C++ exception handling.
11664         * mi/mi-cmd-break.c: Use C++ exception handling.
11665         * main.c: Use C++ exception handling.
11666         * linux-thread-db.c: Use C++ exception handling.
11667         * linux-tdep.c: Use C++ exception handling.
11668         * linux-nat.c: Use C++ exception handling.
11669         * linux-fork.c: Use C++ exception handling.
11670         * linespec.c: Use C++ exception handling.
11671         * language.c: Use C++ exception handling.
11672         * jit.c: Use C++ exception handling.
11673         * infrun.c: Use C++ exception handling.
11674         * infcmd.c: Use C++ exception handling.
11675         * infcall.c: Use C++ exception handling.
11676         * inf-loop.c: Use C++ exception handling.
11677         * i386-tdep.c: Use C++ exception handling.
11678         * i386-linux-tdep.c: Use C++ exception handling.
11679         * guile/scm-value.c: Use C++ exception handling.
11680         * guile/scm-type.c: Use C++ exception handling.
11681         * guile/scm-symtab.c: Use C++ exception handling.
11682         * guile/scm-symbol.c: Use C++ exception handling.
11683         * guile/scm-pretty-print.c: Use C++ exception handling.
11684         * guile/scm-ports.c: Use C++ exception handling.
11685         * guile/scm-param.c: Use C++ exception handling.
11686         * guile/scm-math.c: Use C++ exception handling.
11687         * guile/scm-lazy-string.c: Use C++ exception handling.
11688         * guile/scm-frame.c: Use C++ exception handling.
11689         * guile/scm-disasm.c: Use C++ exception handling.
11690         * guile/scm-cmd.c: Use C++ exception handling.
11691         * guile/scm-breakpoint.c: Use C++ exception handling.
11692         * guile/scm-block.c: Use C++ exception handling.
11693         * guile/guile-internal.h: Use C++ exception handling.
11694         * gnu-v3-abi.c: Use C++ exception handling.
11695         * gdbtypes.c: Use C++ exception handling.
11696         * frame.c: Use C++ exception handling.
11697         * frame-unwind.c: Use C++ exception handling.
11698         * fbsd-tdep.c: Use C++ exception handling.
11699         * f-valprint.c: Use C++ exception handling.
11700         * exec.c: Use C++ exception handling.
11701         * event-top.c: Use C++ exception handling.
11702         * event-loop.c: Use C++ exception handling.
11703         * eval.c: Use C++ exception handling.
11704         * dwarf2read.c: Use C++ exception handling.
11705         * dwarf2loc.c: Use C++ exception handling.
11706         * dwarf2-frame.c: Use C++ exception handling.
11707         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11708         * dwarf-index-write.c: Use C++ exception handling.
11709         * dwarf-index-cache.c: Use C++ exception handling.
11710         * dtrace-probe.c: Use C++ exception handling.
11711         * disasm-selftests.c: Use C++ exception handling.
11712         * darwin-nat.c: Use C++ exception handling.
11713         * cp-valprint.c: Use C++ exception handling.
11714         * cp-support.c: Use C++ exception handling.
11715         * cp-abi.c: Use C++ exception handling.
11716         * corelow.c: Use C++ exception handling.
11717         * completer.c: Use C++ exception handling.
11718         * compile/compile-object-run.c: Use C++ exception handling.
11719         * compile/compile-object-load.c: Use C++ exception handling.
11720         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11721         * compile/compile-c-symbols.c: Use C++ exception handling.
11722         * common/selftest.c: Use C++ exception handling.
11723         * common/new-op.c: Use C++ exception handling.
11724         * cli/cli-script.c: Use C++ exception handling.
11725         * cli/cli-interp.c: Use C++ exception handling.
11726         * cli/cli-cmds.c: Use C++ exception handling.
11727         * c-varobj.c: Use C++ exception handling.
11728         * btrace.c: Use C++ exception handling.
11729         * breakpoint.c: Use C++ exception handling.
11730         * break-catch-throw.c: Use C++ exception handling.
11731         * arch-utils.c: Use C++ exception handling.
11732         * amd64-tdep.c: Use C++ exception handling.
11733         * ada-valprint.c: Use C++ exception handling.
11734         * ada-typeprint.c: Use C++ exception handling.
11735         * ada-lang.c: Use C++ exception handling.
11736         * aarch64-tdep.c: Use C++ exception handling.
11737
11738 2019-04-08  Tom Tromey  <tom@tromey.com>
11739
11740         * xml-support.c (gdb_xml_parser::parse): Update.
11741         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11742         * value.c (show_convenience): Update.
11743         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11744         (test_parse_flags_qcs): Update.
11745         * thread.c (thr_try_catch_cmd): Update.
11746         * target.c (target_translate_tls_address): Update.
11747         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11748         (info_frame_command_core, frame_apply_command_count): Update.
11749         * rust-exp.y (rust_lex_exception_test): Update.
11750         * riscv-tdep.c (riscv_print_one_register_info): Update.
11751         * remote.c (remote_target::enable_btrace): Update.
11752         * record-btrace.c (record_btrace_enable_warn): Update.
11753         * python/py-utils.c (gdbpy_convert_exception): Update.
11754         * printcmd.c (do_one_display, print_variable_and_value): Update.
11755         * mi/mi-main.c (mi_print_exception): Update.
11756         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11757         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11758         * linux-nat.c (linux_nat_target::attach): Update.
11759         * linux-fork.c (class scoped_switch_fork_info): Update.
11760         * infrun.c (displaced_step_prepare): Update.
11761         * infcall.c (call_function_by_hand_dummy): Update.
11762         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11763         * gnu-v3-abi.c (print_one_vtable): Update.
11764         * frame.c (get_prev_frame_always): Update.
11765         * f-valprint.c (info_common_command_for_block): Update.
11766         * exec.c (try_open_exec_file): Update.
11767         * exceptions.c (print_exception, exception_print)
11768         (exception_fprintf, exception_print_same): Update.
11769         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11770         * dwarf-index-cache.c (index_cache::store)
11771         (index_cache::lookup_gdb_index): Update.
11772         * darwin-nat.c (maybe_cache_shell): Update.
11773         * cp-valprint.c (cp_print_value_fields): Update.
11774         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11775         (gcc_cplus_symbol_address): Update.
11776         * compile/compile-c-symbols.c (gcc_convert_symbol)
11777         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11778         * common/selftest.c: Update.
11779         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11780         a std::string.
11781         (exception_try_scope_entry, exception_try_scope_exit): Don't
11782         declare.
11783         (struct exception_try_scope): Remove.
11784         (TRY): Don't use exception_try_scope.
11785         (struct gdb_exception): Add constructor, operator=.
11786         <what>: New method.
11787         (struct gdb_exception_RETURN_MASK_ALL)
11788         (struct gdb_exception_RETURN_MASK_ERROR)
11789         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11790         (struct gdb_quit_bad_alloc): Update.
11791         * common/common-exceptions.c (exception_none): Change
11792         initializer.
11793         (struct catcher) <state, exception>: Initialize inline.
11794         <prev>: Remove member.
11795         (current_catcher): Remove.
11796         (catchers): New global.
11797         (exceptions_state_mc_init): Simplify.
11798         (catcher_pop): Remove.
11799         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11800         (try_scope_depth, exception_try_scope_entry)
11801         (exception_try_scope_exit): Remove.
11802         (throw_exception_sjlj): Update.
11803         (exception_messages, exception_messages_size): Remove.
11804         (throw_it): Simplify.
11805         (gdb_exception_sliced_copy): Remove.
11806         (throw_exception_cxx): Update.
11807         * cli/cli-script.c (script_from_file): Update.
11808         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11809         Update.
11810         * ada-valprint.c (ada_val_print): Update.
11811         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11812         (create_excep_cond_exprs): Update.
11813
11814 2019-04-08  Tom Tromey  <tom@tromey.com>
11815
11816         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11817         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11818         (TRY, CATCH, END_CATCH): Remove some definitions.
11819         * common/common-exceptions.c: Don't use GDB_XCPT.
11820         (catcher_list_size): Remove.
11821         (throw_exception, throw_it): Simplify.
11822
11823 2019-04-05  Tom Tromey  <tom@tromey.com>
11824
11825         Revert the header-sorting patch.
11826         * ft32-tdep.c: Revert.
11827         * frv-tdep.c: Revert.
11828         * frv-linux-tdep.c: Revert.
11829         * frame.c: Revert.
11830         * frame-unwind.c: Revert.
11831         * frame-base.c: Revert.
11832         * fork-child.c: Revert.
11833         * findvar.c: Revert.
11834         * findcmd.c: Revert.
11835         * filesystem.c: Revert.
11836         * filename-seen-cache.h: Revert.
11837         * filename-seen-cache.c: Revert.
11838         * fbsd-tdep.c: Revert.
11839         * fbsd-nat.h: Revert.
11840         * fbsd-nat.c: Revert.
11841         * f-valprint.c: Revert.
11842         * f-typeprint.c: Revert.
11843         * f-lang.c: Revert.
11844         * extension.h: Revert.
11845         * extension.c: Revert.
11846         * extension-priv.h: Revert.
11847         * expprint.c: Revert.
11848         * exec.h: Revert.
11849         * exec.c: Revert.
11850         * exceptions.c: Revert.
11851         * event-top.c: Revert.
11852         * event-loop.c: Revert.
11853         * eval.c: Revert.
11854         * elfread.c: Revert.
11855         * dwarf2read.h: Revert.
11856         * dwarf2read.c: Revert.
11857         * dwarf2loc.c: Revert.
11858         * dwarf2expr.h: Revert.
11859         * dwarf2expr.c: Revert.
11860         * dwarf2-frame.c: Revert.
11861         * dwarf2-frame-tailcall.c: Revert.
11862         * dwarf-index-write.h: Revert.
11863         * dwarf-index-write.c: Revert.
11864         * dwarf-index-common.c: Revert.
11865         * dwarf-index-cache.h: Revert.
11866         * dwarf-index-cache.c: Revert.
11867         * dummy-frame.c: Revert.
11868         * dtrace-probe.c: Revert.
11869         * disasm.h: Revert.
11870         * disasm.c: Revert.
11871         * disasm-selftests.c: Revert.
11872         * dictionary.c: Revert.
11873         * dicos-tdep.c: Revert.
11874         * demangle.c: Revert.
11875         * dcache.h: Revert.
11876         * dcache.c: Revert.
11877         * darwin-nat.h: Revert.
11878         * darwin-nat.c: Revert.
11879         * darwin-nat-info.c: Revert.
11880         * d-valprint.c: Revert.
11881         * d-namespace.c: Revert.
11882         * d-lang.c: Revert.
11883         * ctf.c: Revert.
11884         * csky-tdep.c: Revert.
11885         * csky-linux-tdep.c: Revert.
11886         * cris-tdep.c: Revert.
11887         * cris-linux-tdep.c: Revert.
11888         * cp-valprint.c: Revert.
11889         * cp-support.c: Revert.
11890         * cp-namespace.c: Revert.
11891         * cp-abi.c: Revert.
11892         * corelow.c: Revert.
11893         * corefile.c: Revert.
11894         * continuations.c: Revert.
11895         * completer.h: Revert.
11896         * completer.c: Revert.
11897         * complaints.c: Revert.
11898         * coffread.c: Revert.
11899         * coff-pe-read.c: Revert.
11900         * cli-out.h: Revert.
11901         * cli-out.c: Revert.
11902         * charset.c: Revert.
11903         * c-varobj.c: Revert.
11904         * c-valprint.c: Revert.
11905         * c-typeprint.c: Revert.
11906         * c-lang.c: Revert.
11907         * buildsym.c: Revert.
11908         * buildsym-legacy.c: Revert.
11909         * build-id.h: Revert.
11910         * build-id.c: Revert.
11911         * btrace.c: Revert.
11912         * bsd-uthread.c: Revert.
11913         * breakpoint.h: Revert.
11914         * breakpoint.c: Revert.
11915         * break-catch-throw.c: Revert.
11916         * break-catch-syscall.c: Revert.
11917         * break-catch-sig.c: Revert.
11918         * blockframe.c: Revert.
11919         * block.c: Revert.
11920         * bfin-tdep.c: Revert.
11921         * bfin-linux-tdep.c: Revert.
11922         * bfd-target.c: Revert.
11923         * bcache.c: Revert.
11924         * ax-general.c: Revert.
11925         * ax-gdb.h: Revert.
11926         * ax-gdb.c: Revert.
11927         * avr-tdep.c: Revert.
11928         * auxv.c: Revert.
11929         * auto-load.c: Revert.
11930         * arm-wince-tdep.c: Revert.
11931         * arm-tdep.c: Revert.
11932         * arm-symbian-tdep.c: Revert.
11933         * arm-pikeos-tdep.c: Revert.
11934         * arm-obsd-tdep.c: Revert.
11935         * arm-nbsd-tdep.c: Revert.
11936         * arm-nbsd-nat.c: Revert.
11937         * arm-linux-tdep.c: Revert.
11938         * arm-linux-nat.c: Revert.
11939         * arm-fbsd-tdep.c: Revert.
11940         * arm-fbsd-nat.c: Revert.
11941         * arm-bsd-tdep.c: Revert.
11942         * arch-utils.c: Revert.
11943         * arc-tdep.c: Revert.
11944         * arc-newlib-tdep.c: Revert.
11945         * annotate.h: Revert.
11946         * annotate.c: Revert.
11947         * amd64-windows-tdep.c: Revert.
11948         * amd64-windows-nat.c: Revert.
11949         * amd64-tdep.c: Revert.
11950         * amd64-sol2-tdep.c: Revert.
11951         * amd64-obsd-tdep.c: Revert.
11952         * amd64-obsd-nat.c: Revert.
11953         * amd64-nbsd-tdep.c: Revert.
11954         * amd64-nbsd-nat.c: Revert.
11955         * amd64-nat.c: Revert.
11956         * amd64-linux-tdep.c: Revert.
11957         * amd64-linux-nat.c: Revert.
11958         * amd64-fbsd-tdep.c: Revert.
11959         * amd64-fbsd-nat.c: Revert.
11960         * amd64-dicos-tdep.c: Revert.
11961         * amd64-darwin-tdep.c: Revert.
11962         * amd64-bsd-nat.c: Revert.
11963         * alpha-tdep.c: Revert.
11964         * alpha-obsd-tdep.c: Revert.
11965         * alpha-nbsd-tdep.c: Revert.
11966         * alpha-mdebug-tdep.c: Revert.
11967         * alpha-linux-tdep.c: Revert.
11968         * alpha-linux-nat.c: Revert.
11969         * alpha-bsd-tdep.c: Revert.
11970         * alpha-bsd-nat.c: Revert.
11971         * aix-thread.c: Revert.
11972         * agent.c: Revert.
11973         * addrmap.c: Revert.
11974         * ada-varobj.c: Revert.
11975         * ada-valprint.c: Revert.
11976         * ada-typeprint.c: Revert.
11977         * ada-tasks.c: Revert.
11978         * ada-lang.c: Revert.
11979         * aarch64-tdep.c: Revert.
11980         * aarch64-ravenscar-thread.c: Revert.
11981         * aarch64-newlib-tdep.c: Revert.
11982         * aarch64-linux-tdep.c: Revert.
11983         * aarch64-linux-nat.c: Revert.
11984         * aarch64-fbsd-tdep.c: Revert.
11985         * aarch64-fbsd-nat.c: Revert.
11986         * aarch32-linux-nat.c: Revert.
11987
11988 2019-04-05  Tom Tromey  <tom@tromey.com>
11989
11990         * ft32-tdep.c: Sort headers.
11991         * frv-tdep.c: Sort headers.
11992         * frv-linux-tdep.c: Sort headers.
11993         * frame.c: Sort headers.
11994         * frame-unwind.c: Sort headers.
11995         * frame-base.c: Sort headers.
11996         * fork-child.c: Sort headers.
11997         * findvar.c: Sort headers.
11998         * findcmd.c: Sort headers.
11999         * filesystem.c: Sort headers.
12000         * filename-seen-cache.h: Sort headers.
12001         * filename-seen-cache.c: Sort headers.
12002         * fbsd-tdep.c: Sort headers.
12003         * fbsd-nat.h: Sort headers.
12004         * fbsd-nat.c: Sort headers.
12005         * f-valprint.c: Sort headers.
12006         * f-typeprint.c: Sort headers.
12007         * f-lang.c: Sort headers.
12008         * extension.h: Sort headers.
12009         * extension.c: Sort headers.
12010         * extension-priv.h: Sort headers.
12011         * expprint.c: Sort headers.
12012         * exec.h: Sort headers.
12013         * exec.c: Sort headers.
12014         * exceptions.c: Sort headers.
12015         * event-top.c: Sort headers.
12016         * event-loop.c: Sort headers.
12017         * eval.c: Sort headers.
12018         * elfread.c: Sort headers.
12019         * dwarf2read.h: Sort headers.
12020         * dwarf2read.c: Sort headers.
12021         * dwarf2loc.c: Sort headers.
12022         * dwarf2expr.h: Sort headers.
12023         * dwarf2expr.c: Sort headers.
12024         * dwarf2-frame.c: Sort headers.
12025         * dwarf2-frame-tailcall.c: Sort headers.
12026         * dwarf-index-write.h: Sort headers.
12027         * dwarf-index-write.c: Sort headers.
12028         * dwarf-index-common.c: Sort headers.
12029         * dwarf-index-cache.h: Sort headers.
12030         * dwarf-index-cache.c: Sort headers.
12031         * dummy-frame.c: Sort headers.
12032         * dtrace-probe.c: Sort headers.
12033         * disasm.h: Sort headers.
12034         * disasm.c: Sort headers.
12035         * disasm-selftests.c: Sort headers.
12036         * dictionary.c: Sort headers.
12037         * dicos-tdep.c: Sort headers.
12038         * demangle.c: Sort headers.
12039         * dcache.h: Sort headers.
12040         * dcache.c: Sort headers.
12041         * darwin-nat.h: Sort headers.
12042         * darwin-nat.c: Sort headers.
12043         * darwin-nat-info.c: Sort headers.
12044         * d-valprint.c: Sort headers.
12045         * d-namespace.c: Sort headers.
12046         * d-lang.c: Sort headers.
12047         * ctf.c: Sort headers.
12048         * csky-tdep.c: Sort headers.
12049         * csky-linux-tdep.c: Sort headers.
12050         * cris-tdep.c: Sort headers.
12051         * cris-linux-tdep.c: Sort headers.
12052         * cp-valprint.c: Sort headers.
12053         * cp-support.c: Sort headers.
12054         * cp-namespace.c: Sort headers.
12055         * cp-abi.c: Sort headers.
12056         * corelow.c: Sort headers.
12057         * corefile.c: Sort headers.
12058         * continuations.c: Sort headers.
12059         * completer.h: Sort headers.
12060         * completer.c: Sort headers.
12061         * complaints.c: Sort headers.
12062         * coffread.c: Sort headers.
12063         * coff-pe-read.c: Sort headers.
12064         * cli-out.h: Sort headers.
12065         * cli-out.c: Sort headers.
12066         * charset.c: Sort headers.
12067         * c-varobj.c: Sort headers.
12068         * c-valprint.c: Sort headers.
12069         * c-typeprint.c: Sort headers.
12070         * c-lang.c: Sort headers.
12071         * buildsym.c: Sort headers.
12072         * buildsym-legacy.c: Sort headers.
12073         * build-id.h: Sort headers.
12074         * build-id.c: Sort headers.
12075         * btrace.c: Sort headers.
12076         * bsd-uthread.c: Sort headers.
12077         * breakpoint.h: Sort headers.
12078         * breakpoint.c: Sort headers.
12079         * break-catch-throw.c: Sort headers.
12080         * break-catch-syscall.c: Sort headers.
12081         * break-catch-sig.c: Sort headers.
12082         * blockframe.c: Sort headers.
12083         * block.c: Sort headers.
12084         * bfin-tdep.c: Sort headers.
12085         * bfin-linux-tdep.c: Sort headers.
12086         * bfd-target.c: Sort headers.
12087         * bcache.c: Sort headers.
12088         * ax-general.c: Sort headers.
12089         * ax-gdb.h: Sort headers.
12090         * ax-gdb.c: Sort headers.
12091         * avr-tdep.c: Sort headers.
12092         * auxv.c: Sort headers.
12093         * auto-load.c: Sort headers.
12094         * arm-wince-tdep.c: Sort headers.
12095         * arm-tdep.c: Sort headers.
12096         * arm-symbian-tdep.c: Sort headers.
12097         * arm-pikeos-tdep.c: Sort headers.
12098         * arm-obsd-tdep.c: Sort headers.
12099         * arm-nbsd-tdep.c: Sort headers.
12100         * arm-nbsd-nat.c: Sort headers.
12101         * arm-linux-tdep.c: Sort headers.
12102         * arm-linux-nat.c: Sort headers.
12103         * arm-fbsd-tdep.c: Sort headers.
12104         * arm-fbsd-nat.c: Sort headers.
12105         * arm-bsd-tdep.c: Sort headers.
12106         * arch-utils.c: Sort headers.
12107         * arc-tdep.c: Sort headers.
12108         * arc-newlib-tdep.c: Sort headers.
12109         * annotate.h: Sort headers.
12110         * annotate.c: Sort headers.
12111         * amd64-windows-tdep.c: Sort headers.
12112         * amd64-windows-nat.c: Sort headers.
12113         * amd64-tdep.c: Sort headers.
12114         * amd64-sol2-tdep.c: Sort headers.
12115         * amd64-obsd-tdep.c: Sort headers.
12116         * amd64-obsd-nat.c: Sort headers.
12117         * amd64-nbsd-tdep.c: Sort headers.
12118         * amd64-nbsd-nat.c: Sort headers.
12119         * amd64-nat.c: Sort headers.
12120         * amd64-linux-tdep.c: Sort headers.
12121         * amd64-linux-nat.c: Sort headers.
12122         * amd64-fbsd-tdep.c: Sort headers.
12123         * amd64-fbsd-nat.c: Sort headers.
12124         * amd64-dicos-tdep.c: Sort headers.
12125         * amd64-darwin-tdep.c: Sort headers.
12126         * amd64-bsd-nat.c: Sort headers.
12127         * alpha-tdep.c: Sort headers.
12128         * alpha-obsd-tdep.c: Sort headers.
12129         * alpha-nbsd-tdep.c: Sort headers.
12130         * alpha-mdebug-tdep.c: Sort headers.
12131         * alpha-linux-tdep.c: Sort headers.
12132         * alpha-linux-nat.c: Sort headers.
12133         * alpha-bsd-tdep.c: Sort headers.
12134         * alpha-bsd-nat.c: Sort headers.
12135         * aix-thread.c: Sort headers.
12136         * agent.c: Sort headers.
12137         * addrmap.c: Sort headers.
12138         * ada-varobj.c: Sort headers.
12139         * ada-valprint.c: Sort headers.
12140         * ada-typeprint.c: Sort headers.
12141         * ada-tasks.c: Sort headers.
12142         * ada-lang.c: Sort headers.
12143         * aarch64-tdep.c: Sort headers.
12144         * aarch64-ravenscar-thread.c: Sort headers.
12145         * aarch64-newlib-tdep.c: Sort headers.
12146         * aarch64-linux-tdep.c: Sort headers.
12147         * aarch64-linux-nat.c: Sort headers.
12148         * aarch64-fbsd-tdep.c: Sort headers.
12149         * aarch64-fbsd-nat.c: Sort headers.
12150         * aarch32-linux-nat.c: Sort headers.
12151
12152 2019-04-04  Tom Tromey  <tom@tromey.com>
12153
12154         * varobj.c (varobj_create): Update.
12155         * rust-exp.y (struct rust_parser) <update_innermost_block,
12156         lookup_symbol>: New methods.
12157         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12158         Rename.
12159         (rust_parser::rust_lookup_type)
12160         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12161         * printcmd.c (display_command, do_one_display): Update.
12162         * parser-defs.h (struct parser_state) <parser_state>: Add
12163         "tracker" parameter.
12164         (block_tracker): New member.
12165         (class innermost_block_tracker) <innermost_block_tracker>: Add
12166         "types" parameter.
12167         <reset>: Remove method.
12168         (innermost_block): Don't declare.
12169         (null_post_parser): Update.
12170         * parse.c (innermost_block): Remove global.
12171         (write_dollar_variable): Update.
12172         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12173         Remove "tracker_types" parameter.
12174         (parse_expression): Add "tracker" parameter.
12175         (parse_expression_for_completion): Update.
12176         (null_post_parser): Add "tracker" parameter.
12177         * p-exp.y: Update rules.
12178         * m2-exp.y: Update rules.
12179         * language.h (struct language_defn) <la_post_parser>: Add
12180         "tracker" parameter.
12181         * go-exp.y: Update rules.
12182         * f-exp.y: Update rules.
12183         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12184         parameter.
12185         * d-exp.y: Update rules.
12186         * c-exp.y: Update rules.
12187         * breakpoint.c (set_breakpoint_condition): Create an
12188         innermost_block_tracker.
12189         (watch_command_1): Likewise.
12190         * ada-lang.c (resolve): Add "tracker" parameter.
12191         (resolve_subexp): Likewise.
12192         * ada-exp.y (write_var_from_sym): Update.
12193
12194 2019-04-04  Tom Tromey  <tom@tromey.com>
12195
12196         * type-stack.h: New file.
12197         * type-stack.c: New file.
12198         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12199         type-stack.h.
12200         (insert_into_type_stack, insert_type, push_type, push_type_int)
12201         (insert_type_address_space, pop_type, pop_type_int)
12202         (pop_typelist, pop_type_stack, append_type_stack)
12203         (push_type_stack, get_type_stack, push_typelist)
12204         (follow_type_instance_flags, follow_types): Don't declare.
12205         * parse.c (type_stack): Remove global.
12206         (parse_exp_in_context): Update.
12207         (insert_into_type_stack, insert_type, push_type, push_type_int)
12208         (insert_type_address_space, pop_type, pop_type_int)
12209         (pop_typelist, pop_type_stack, append_type_stack)
12210         (push_type_stack, get_type_stack, push_typelist)
12211         (follow_type_instance_flags, follow_types): Remove (moved to
12212         type-stack.c).
12213         * f-exp.y (type_stack): New global.
12214         Update rules.
12215         (push_kind_type, f_parse): Update.
12216         * d-exp.y (type_stack): New global.
12217         Update rules.
12218         (d_parse): Update.
12219         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12220         Update rules.
12221         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12222         (HFILES_NO_SRCDIR): Add type-stack.h.
12223
12224 2019-04-04  Tom Tromey  <tom@tromey.com>
12225
12226         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12227         (rust_parser::convert_ast_to_expression, rust_parse)
12228         (rust_lex_test_completion, rust_lex_tests): Update.
12229         * parser-defs.h (struct expr_completion_state): New.
12230         (struct parser_state) <parser_state>: Add completion parameter.
12231         <mark_struct_expression, mark_completion_tag>: New methods.
12232         <parse_completion, m_completion_state>: New members.
12233         (prefixify_expression, null_post_parser): Update.
12234         (mark_struct_expression, mark_completion_tag): Don't declare.
12235         * parse.c (parse_completion, expout_last_struct)
12236         (expout_tag_completion_type, expout_completion_name): Remove
12237         globals.
12238         (parser_state::mark_struct_expression)
12239         (parser_state::mark_completion_tag): Now methods.
12240         (prefixify_expression): Add last_struct parameter.
12241         (prefixify_subexp): Likewise.
12242         (parse_exp_1): Update.
12243         (parse_exp_in_context): Add cstate parameter.  Update.
12244         (parse_expression_for_completion): Create an
12245         expr_completion_state.
12246         (null_post_parser): Add "completion" parameter.
12247         * p-exp.y: Update rules.
12248         (yylex): Update.
12249         * language.h (struct language_defn) <la_post_parser>: Add
12250         "completing" parameter.
12251         * go-exp.y: Update rules.
12252         (lex_one_token): Update.
12253         * expression.h (parse_completion): Don't declare.
12254         * d-exp.y: Update rules.
12255         (lex_one_token): Update rules.
12256         * c-exp.y: Update rules.
12257         (lex_one_token): Update.
12258         * ada-lang.c (resolve): Add "parse_completion" parameter.
12259         (resolve_subexp): Likewise.
12260         (ada_resolve_function): Likewise.
12261
12262 2019-04-04  Tom Tromey  <tom@tromey.com>
12263
12264         * parser-defs.h (struct parser_state) <start_arglist,
12265         end_arglist>: New methods.
12266         <arglist_len, m_funcall_chain>: New members.
12267         (arglist_len, start_arglist, end_arglist): Don't declare.
12268         * parse.c (arglist_len, funcall_chain): Remove global.
12269         (start_arglist, end_arglist): Remove functions.
12270         (parse_exp_in_context): Update.
12271         * p-exp.y: Update rules.
12272         * m2-exp.y: Update rules.
12273         * go-exp.y: Update rules.
12274         * f-exp.y: Update rules.
12275         * d-exp.y: Update rules.
12276         * c-exp.y: Update rules.
12277
12278 2019-04-04  Tom Tromey  <tom@tromey.com>
12279
12280         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12281         lex_operator, push_back>: New methods.
12282         Update all rules.
12283         (rust_parser::lex_hex, lex_escape): Rename and update.
12284         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12285         (rust_parser::lex_operator): Rename and update.
12286         (rust_parser::lex_number, rustyylex, rustyyerror)
12287         (rust_lex_test_init, rust_lex_test_sequence)
12288         (rust_lex_test_push_back, rust_lex_tests): Update.
12289         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12290         parameter.
12291         <lexptr, prev_lexptr>: New members.
12292         (lexptr, prev_lexptr): Don't declare.
12293         * parse.c (lexptr, prev_lexptr): Remove globals.
12294         (parse_exp_in_context): Update.
12295         * p-exp.y (yylex, yyerror): Update.
12296         * m2-exp.y (parse_number, yylex, yyerror): Update.
12297         * go-exp.y (lex_one_token, yyerror): Update.
12298         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12299         * d-exp.y (lex_one_token, yyerror): Update.
12300         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12301         (lex_one_token, yyerror): Update.
12302         * ada-lex.l (YY_INPUT): Update.
12303         (rewind_to_char): Update.
12304         * ada-exp.y (yyerror): Update.
12305
12306 2019-04-04  Tom Tromey  <tom@tromey.com>
12307
12308         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12309         * parser-defs.h (struct parser_state) <parser_state>: Add new
12310         parameter.
12311         <comma_terminates>: New member.
12312         (comma_terminates): Don't declare global.
12313         * parse.c (comma_terminates): Remove global.
12314         (parse_exp_in_context): Update.
12315         * p-exp.y (yylex): Update.
12316         * m2-exp.y (yylex): Update.
12317         * go-exp.y (lex_one_token): Update.
12318         * f-exp.y (yylex): Update.
12319         * d-exp.y (lex_one_token): Update.
12320         * c-exp.y (lex_one_token): Update.
12321         * ada-lex.l: Update.
12322
12323 2019-04-04  Tom Tromey  <tom@tromey.com>
12324
12325         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12326         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12327         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12328         * parser-defs.h (paren_depth): Don't declare.
12329         * parse.c (paren_depth): Remove global.
12330         (parse_exp_in_context): Update.
12331         * p-exp.y (paren_depth): New global.
12332         (pascal_parse): Initialize it.
12333         * m2-exp.y (paren_depth): New global.
12334         (m2_parse): Initialize it.
12335         * go-exp.y (paren_depth): New global.
12336         (go_parse): Initialize it.
12337         * f-exp.y (paren_depth): New global.
12338         (f_parse): Initialize it.
12339         * d-exp.y (paren_depth): New global.
12340         (d_parse): Initialize it.
12341         * c-exp.y (paren_depth): New global.
12342         (c_parse): Initialize it.
12343         * ada-lex.l (paren_depth): New global.
12344         (lexer_init): Initialize it.
12345
12346 2019-04-04  Tom Tromey  <tom@tromey.com>
12347
12348         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12349         (rust_parser::convert_ast_to_type)
12350         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12351         * parser-defs.h (struct parser_state) <parser_state>: Add
12352         parameters.  Initialize new members.
12353         <expression_context_block, expression_context_pc>: New members.
12354         * parse.c (expression_context_block, expression_context_pc):
12355         Remove globals.
12356         (parse_exp_in_context): Update.
12357         * p-exp.y: Update all rules.
12358         (yylex): Update.
12359         * m2-exp.y: Update all rules.
12360         (yylex): Update.
12361         * go-exp.y (yylex): Update.
12362         * f-exp.y (yylex): Update.
12363         * d-exp.y: Update all rules.
12364         (yylex): Update.
12365         * c-exp.y: Update all rules.
12366         (lex_one_token, classify_name, yylex, c_parse): Update.
12367         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12368
12369 2019-04-04  Tom Tromey  <tom@tromey.com>
12370
12371         * gdbarch.h, gdbarch.c: Rebuild.
12372         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12373         * stap-probe.h:
12374         (struct stap_parse_info): Replace "parser_state" with
12375         "expr_builder".
12376         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12377         (parser_state): New class.
12378         * parse.c (expr_builder): Rename.
12379         (expr_builder::release): Rename.
12380         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12381         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12382         (write_exp_elt_longcst, write_exp_elt_floatcst)
12383         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12384         (write_exp_string_vector, write_exp_bitstring)
12385         (write_exp_msymbol, mark_struct_expression)
12386         (write_dollar_variable)
12387         (insert_type_address_space, increase_expout_size): Replace
12388         "parser_state" with "expr_builder".
12389         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12390         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12391         "parser_state" with "expr_builder".
12392
12393 2019-04-04  Tom Tromey  <tom@tromey.com>
12394
12395         * rust-exp.y: Replace "parse_language" with method call.
12396         * p-exp.y:
12397         (yylex): Replace "parse_language" with method call.
12398         * m2-exp.y:
12399         (yylex): Replace "parse_language" with method call.
12400         * go-exp.y (classify_name): Replace "parse_language" with method
12401         call.
12402         * f-exp.y (yylex): Replace "parse_language" with method call.
12403         * d-exp.y (lex_one_token): Replace "parse_language" with method
12404         call.
12405         * c-exp.y:
12406         (lex_one_token, classify_name, yylex): Replace "parse_language"
12407         with method call.
12408         * ada-exp.y (find_primitive_type, type_char)
12409         (type_system_address): Replace "parse_language" with method call.
12410
12411 2019-04-04  Tom Tromey  <tom@tromey.com>
12412
12413         * rust-exp.y: Replace "parse_gdbarch" with method call.
12414         * parse.c (write_dollar_variable, insert_type_address_space):
12415         Replace "parse_gdbarch" with method call.
12416         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12417         call.
12418         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12419         call.
12420         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12421         "parse_gdbarch" with method call.
12422         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12423         with method call.
12424         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12425         "parse_gdbarch" with method call.
12426         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12427         "parse_gdbarch" with method call.
12428         * c-exp.y (parse_type, parse_number, classify_name): Replace
12429         "parse_gdbarch" with method call.
12430         * ada-lex.l: Replace "parse_gdbarch" with method call.
12431         * ada-exp.y (parse_type, find_primitive_type, type_char)
12432         (type_system_address): Replace "parse_gdbarch" with method call.
12433
12434 2019-04-04  Tom Tromey  <tom@tromey.com>
12435
12436         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12437         * stap-probe.c (stap_parse_argument): Update.
12438         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12439         initial_size parameter.
12440         * rust-exp.y (rust_lex_tests): Update.
12441         * parse.c (parser_state): Update.
12442         (parse_exp_in_context): Update.
12443         * parser-defs.h (struct parser_state) <parser_state>: Remove
12444         "initial_size" parameter.
12445
12446 2019-04-04  Tom Tromey  <tom@tromey.com>
12447
12448         * parser-defs.h (increase_expout_size): Don't declare.
12449         * parse.c (increase_expout_size): Now static.
12450
12451 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12452
12453         * gnu-nat.c (gnu_nat_target::wait): Fix
12454         target_waitstatus_to_string call.
12455
12456 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12457
12458         * eval.c (evaluate_subexp_standard): Handle internal functions
12459         during Fortran function call handling.
12460
12461 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12462
12463         * NEWS: Mention new internal functions.
12464         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12465         (read_base_type): Use dwarf2_init_complex_target_type.
12466         * value.c (creal_internal_fn): New function.
12467         (cimag_internal_fn): New function.
12468         (_initialize_values): Register new internal functions.
12469
12470 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12471
12472         * infrun.c (stop_all_threads): If debug_infrun, always
12473         trace the wait status after wait_one, using
12474         target_waitstatus_to_string and target_pid_to_str.
12475         (handle_inferior_event): Replace various trace of
12476         wait status kind by a single trace.
12477         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12478         wait status kind image by target_waitstatus_to_string.
12479         * target/waitstatus.c (target_waitstatus_to_string): Fix
12480         obsolete comment.
12481
12482 2019-04-01  Tom Tromey  <tromey@adacore.com>
12483
12484         PR symtab/23331:
12485         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12486
12487 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12488             Pedro Alves  <palves@redhat.com>
12489
12490         * top.c (quit_force): Call 'finalize_values'.
12491         * value.c (finalize_values): New function.
12492         * value.h (finalize_values): Declare.
12493
12494 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12495
12496         * NEWS: Announce $_gdb_major and $_gdb_minor.
12497
12498         * top.c (init_gdb_version_vars): New function.
12499         (gdb_init): Call init_gdb_version_vars.
12500
12501 2019-03-29  Tom Tromey  <tromey@adacore.com>
12502
12503         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12504         help text.  Remove dead code.
12505
12506 2019-03-29  Keith Seitz  <keiths@redhat.com>
12507
12508         From Siddhesh Poyarekar:
12509         * f-lang.h (f77_get_upperbound): Return LONGEST.
12510         (f77_get_lowerbound): Likewise.
12511         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12512         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12513         print them.
12514         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12515         plongest to format print it.
12516         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12517         (f77_get_upperbound): Likewise.
12518         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12519         LOWER_BOUND to LONGEST.
12520         (f77_create_arrayprint_offset_tbl): Likewise.
12521
12522 2019-03-29  Keith Seitz  <keiths@redhat.com>
12523
12524         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12525         %s/pulongest for TYPE_LENGTH instead of %d in format
12526         strings.
12527         * ada-typerint.c (ada_print_type): Likewise.
12528         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12529         * compile/compile-c-support.c (generate_register_struct): Likewise.
12530         * gdbtypes.c (recursive_dump_type): Likewise.
12531         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12532         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12533         instead of %d in format strings.
12534         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12535         to std::min to ULONGEST.
12536         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12537         instead of %d in format strings.
12538         * tracepoint.c (info_scope_command): Likewise.
12539         * typeprint.c (print_offset_data::update)
12540         (print_offset_data::finish): Likewise.
12541         * xtensa-tdep.c (xtensa_store_return_value)
12542         (xtensa_push_dummy_call): Likewise.
12543
12544 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12545
12546         * windows-nat.c (display_selector): Fixed format specifications
12547         for 64-bit Cygwin.
12548
12549 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12550
12551         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12552
12553 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12554
12555         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12556         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12557         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12558         (nios2_linux_init_abi): Install it.
12559
12560 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12561
12562         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12563
12564 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12565
12566         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12567
12568 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12569             Tom Tromey  <tromey@adacore.com>
12570
12571         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12572
12573 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12574
12575         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12576         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12577         method to compute the bounds of range types. Also print "[evaluated]"
12578         if the bounds' values come from a dynamic evaluation.
12579
12580 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12581
12582         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12583         whitespace when pretty printing is on.
12584
12585 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12586
12587         * ppc-linux-nat.c: Add include.
12588
12589 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12590
12591         * NEWS: Mention AArch64 Pointer Authentication.
12592
12593 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12594
12595         * arm-linux-nat.c: Add include.
12596
12597 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12598
12599         * source-cache.c (source_cache::get_source_lines): Re-read
12600         fullname after calling open_source_file.
12601
12602 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12603
12604         * NEWS: Mention TLS support for FreeBSD.
12605
12606 2019-03-25  Tom Tromey  <tromey@adacore.com>
12607
12608         * minsyms.c (BUNCH_SIZE): Update comment.
12609         (~minimal_symbol_reader): Remove old comment.
12610         (compact_minimal_symbols): Update comment.
12611         (minimal_symbol_reader::install): Remove old comment.  Update
12612         other comments.
12613
12614 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12615
12616         * s390-linux-nat.c: Add include.
12617
12618 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12619
12620         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12621         Call linux_get_hwcap.
12622         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12623         Likewise.
12624         (aarch64_linux_get_hwcap): Remove function.
12625         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12626         declaration.
12627         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12628         linux_get_hwcap.
12629         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12630         * linux-tdep.c (linux_get_hwcap): Add function.
12631         (linux_get_hwcap2): Likewise.
12632         * linux-tdep.h (linux_get_hwcap): Add declaration.
12633         (linux_get_hwcap2): Likewise.
12634         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12635         (ppc_linux_get_hwcap2): Likewise.
12636         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12637         linux_get_hwcap.
12638         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12639         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12640         (ppc_linux_nat_target::read_description): Likewise.
12641         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12642         * s390-linux-nat.c: Likewise.
12643         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12644
12645 2019-03-24  Tom Tromey  <tom@tromey.com>
12646
12647         * ada-lang.c (standard_lookup): Simplify initialization.
12648         (ada_lookup_symbol_nonlocal): Simplify return.
12649         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12650         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12651         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12652         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12653         initialization.
12654         * solib.c (solib_global_lookup): Simplify.
12655         * symtab.c (null_block_symbol): Remove.
12656         (symbol_cache_lookup): Simplify returns.
12657         (lookup_language_this): Simplify returns.
12658         (lookup_symbol_aux): Simplify return.
12659         (lookup_local_symbol): Simplify returns.
12660         (lookup_global_symbol_from_objfile): Simplify return.
12661         (lookup_symbol_in_objfile_symtabs)
12662         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12663         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12664         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12665         * cp-namespace.c (cp_lookup_bare_symbol)
12666         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12667         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12668         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12669         (cp_lookup_symbol_via_imports): Simplify initialization.
12670         (find_symbol_in_baseclass): Likewise.
12671         * symtab.h (null_block_symbol): Remove.
12672         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12673         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12674         (d_lookup_symbol_module): Likewise.
12675         (find_symbol_in_baseclass): Simplify initialization.
12676
12677 2019-03-24  Tom Tromey  <tom@tromey.com>
12678
12679         * expression.h: Don't include symtab.h.
12680         (struct block): Forward declare.
12681
12682 2019-03-24  Tom Tromey  <tom@tromey.com>
12683
12684         * c-exp.y (typebase): Remove casts.
12685         * gdbtypes.c (lookup_unsigned_typename, )
12686         (lookup_signed_typename): Remove cast.
12687         * eval.c (parse_to_comma_and_eval): Remove cast.
12688         * parse.c (write_dollar_variable): Remove cast.
12689         * block.h (struct block) <superblock>: Now const.
12690         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12691         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12692         (map_block): Make "block" const.
12693         * symfile.h (struct quick_symbol_functions)
12694         <map_matching_symbols>: Constify block argument to "callback".
12695         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12696         const.
12697         (find_pc_sect_compunit_symtab): Make "b" const.
12698         (find_symbol_at_address): Likewise.
12699         (search_symbols): Likewise.
12700         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12701         (dw2_debug_names_lookup_symbol): Likewise.
12702         (dw2_map_matching_symbols): Update.
12703         * p-valprint.c (pascal_val_print): Remove "block".
12704         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12705         (aux_add_nonlocal_symbols): Make "block" const.
12706         (resolve_subexp): Remove cast.
12707         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12708         const.
12709         (iterate_over_file_blocks): Likewise.
12710         * f-exp.y (%union) <bval>: Remove.
12711         * coffread.c (patch_opaque_types): Make "b" const.
12712         * spu-tdep.c (spu_catch_start): Make "block" const.
12713         * c-valprint.c (print_unpacked_pointer): Remove "block".
12714         * symmisc.c (dump_symtab_1): Make "b" const.
12715         (block_depth): Make "block" const.
12716         * d-exp.y (%union) <bval>: Remove.
12717         * cp-support.h (cp_lookup_rtti_type): Update.
12718         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12719         * psymtab.c (psym_lookup_symbol): Make "block" const.
12720         (maintenance_check_psymtabs): Make "b" const.
12721         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12722         (enumerate_locals, enumerate_args): Update.
12723         * python/py-symtab.c (stpy_global_block): Make "block" const.
12724         (stpy_static_block): Likewise.
12725         * inline-frame.c (block_starting_point_at): Make "new_block"
12726         const.
12727         * block.c (find_block_in_blockvector): Make return type const.
12728         (blockvector_for_pc_sect): Make "b" const.
12729         (find_block_in_blockvector): Make "b" const.
12730
12731 2019-03-23  Tom Tromey  <tom@tromey.com>
12732
12733         * varobj.c (varobj_create): Update.
12734         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12735         * printcmd.c (display_command, do_one_display): Don't reset
12736         innermost_block.
12737         * parser-defs.h (enum innermost_block_tracker_type): Move to
12738         expression.h.
12739         (innermost_block): Update comment.
12740         * parse.c (parse_exp_1): Add tracker_types parameter.
12741         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12742         tracker_types parameter.  Reset innermost_block.
12743         (parse_exp_in_context): Remove.
12744         (parse_expression_for_completion): Update.
12745         * objfiles.c (~objfile): Don't reset expression_context_block or
12746         innermost_block.
12747         * expression.h (enum innermost_block_tracker_type): Move from
12748         parser-defs.h.
12749         (parse_exp_1): Add tracker_types parameter.
12750         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12751         reset innermost_block.
12752
12753 2019-03-23  Tom Tromey  <tom@tromey.com>
12754
12755         * objfiles.h: Include bcache.h.
12756
12757 2019-03-23  Tom Tromey  <tom@tromey.com>
12758
12759         * linespec.c (get_current_search_block): Use
12760         scoped_restore_current_language.
12761         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12762
12763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12764             Jiong Wang  <jiong.wang@arm.com>
12765
12766         * aarch64-linux-tdep.c
12767         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12768         section.
12769         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12770
12771 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12772             Jiong Wang  <jiong.wang@arm.com>
12773
12774         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12775         instructions.
12776         (aarch64_analyze_prologue_test): Add PACIASP test.
12777         (aarch64_prologue_prev_register): Unmask PC value.
12778
12779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12780             Jiong Wang  <jiong.wang@arm.com>
12781
12782         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12783         (aarch64_dwarf2_prev_register): Unmask PC value.
12784         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12785         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12786         DW_CFA_AARCH64_negate_ra_state.
12787         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12788
12789 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12790             Jiong Wang  <jiong.wang@arm.com>
12791
12792         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12793         registers.
12794         (aarch64_pseudo_register_name): Likewise.
12795         (aarch64_pseudo_register_type): Likewise.
12796         (aarch64_pseudo_register_reggroup_p): Likewise.
12797         (aarch64_gdbarch_init): Add pauth registers.
12798         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12799         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12800         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12801         (struct gdbarch_tdep): Add regnum for ra_state.
12802
12803 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12804             Jiong Wang  <jiong.wang@arm.com>
12805
12806         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12807
12808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12809             Jiong Wang  <jiong.wang@arm.com>
12810
12811         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12812         function.
12813         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12814         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12815         (aarch64_gdbarch_init): Add puth registers.
12816         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12817         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12818         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12819
12820 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12821             Jiong Wang  <jiong.wang@arm.com>
12822
12823         * aarch64-linux-nat.c
12824         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12825         * aarch64-linux-tdep.c
12826         (aarch64_linux_core_read_description): Likewise.
12827         (aarch64_linux_get_hwcap): New function.
12828         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12829         (aarch64_linux_get_hwcap): New declaration.
12830
12831 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12832             Jiong Wang  <jiong.wang@arm.com>
12833
12834         * aarch64-linux-nat.c
12835         (aarch64_linux_nat_target::read_description): Add pauth param.
12836         * aarch64-linux-tdep.c
12837         (aarch64_linux_core_read_description): Likewise.
12838         * aarch64-tdep.c (struct target_desc): Add in pauth.
12839         (aarch64_read_description): Add pauth param.
12840         (aarch64_gdbarch_init): Likewise.
12841         * aarch64-tdep.h (aarch64_read_description): Likewise.
12842         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12843         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12844         * features/Makefile: Add new files.
12845         * features/aarch64-pauth.c: New file.
12846         * features/aarch64-pauth.xml: New file.
12847
12848 2019-03-20  Tom Tromey  <tromey@adacore.com>
12849
12850         * infrun.c (handle_inferior_event): Rename from
12851         handle_inferior_event_1.  Create a scoped_value_mark.
12852         (handle_inferior_event): Remove.
12853
12854 2019-03-19  Tom Tromey  <tromey@adacore.com>
12855
12856         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12857         * infrun.h (print_stop_event): Add "displays" parameter.
12858         * infrun.c (print_stop_event): Add "displays" parameter.
12859
12860 2019-03-19  Pedro Alves  <palves@redhat.com>
12861
12862         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12863         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12864         to -1.  Fix TABs vs spaces.
12865         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12866         * tui/tui-out.h (tui_ui_out) Add intro comments.
12867         <m_line, m_start_of_line>: In-class initialize, and add describing
12868         comment.
12869
12870 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12871
12872         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12873         variable names.
12874         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12875
12876 2019-03-18  Pedro Alves  <palves@redhat.com>
12877             Eli Zaretskii <eliz@gnu.org>
12878
12879         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12880         m_line and m_start_of_line.
12881
12882 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12883
12884         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12885         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12886         it returns a newline.  This fixes a regression in TU mode, whereby
12887         the next line is output on the same screen line as the user input.
12888
12889 2019-03-18  Tom Tromey  <tromey@adacore.com>
12890
12891         * minsyms.c (minimal_symbol_reader::install): Remove call to
12892         obstack_blank.
12893
12894 2019-03-18  Pedro Alves  <palves@redhat.com>
12895
12896         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12897         New globals.
12898         (apply_style): New, factored out from ...
12899         (apply_ansi_escape): ... this.  Handle reverse video mode.
12900         (tui_set_reverse_mode): New function.
12901         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12902         * tui/tui-winsource.c (tui_show_source_line): Use
12903         tui_set_reverse_mode instead of setting A_STANDOUT.
12904         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12905         New setter methods.
12906
12907 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12908
12909         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12910         Handle tabs.
12911
12912 2019-03-18  Tom Tromey  <tromey@adacore.com>
12913
12914         * ada-lang.c (empty_array): Add "high" parameter.
12915         (ada_evaluate_subexp): Update.
12916
12917 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12918
12919         * unittests/string_view-selftests.c: Define
12920         _initialize_string_view_selftests unconditionally.
12921
12922 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12923
12924         PR gdb/24350
12925         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12926
12927 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12928
12929         PR gdb/24351
12930         * windows-nat.c (display_selector): Fix format specifiers.
12931
12932 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12933
12934         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12935         tui_refill_source_window instead of tui_refresh_win, to update the
12936         current execution line.  This fixes redisplay of the current line
12937         when stepping through the code with "next" or "step".
12938
12939 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12940
12941         * source-cache.c (source_cache::get_source_lines): Call
12942         find_source_lines to initialize s->nlines.  This fixes vertical
12943         scrolling of TUI source window when the DOWN arrow is pressed.
12944
12945 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12946
12947         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12948         linux-thread-db.c (_initialize_thread_db): Likewise.
12949
12950 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12951
12952         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12953         wclrtoeol in tui_show_source_line".  This reverts changes made in
12954         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12955
12956 2019-03-15  Tom Tromey  <tom@tromey.com>
12957
12958         * symtab.h (struct minimal_symbol): Derive from
12959         general_symbol_info.
12960         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12961         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12962         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12963         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12964         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12965         (MSYMBOL_SEARCH_NAME): Update.
12966         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12967         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12968         * minsyms.c (minimal_symbol_reader::record_full): Update.
12969
12970 2019-03-15  Tom Tromey  <tom@tromey.com>
12971
12972         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12973
12974 2019-03-15  Tom Tromey  <tom@tromey.com>
12975
12976         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12977         unique_xmalloc_ptr.
12978         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12979         Update.
12980         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12981         (build_minimal_symbol_hash_tables)
12982         (minimal_symbol_reader::install): Update.
12983
12984 2019-03-15  Tom Tromey  <tom@tromey.com>
12985
12986         * symtab.c (create_demangled_names_hash): Update.
12987         (symbol_set_names): Update.
12988         * objfiles.h (struct objfile_per_bfd_storage)
12989         <demangled_names_hash>: Now an htab_up.
12990         * objfiles.c (objfile_per_bfd_storage): Simplify.
12991
12992 2019-03-15  Tom Tromey  <tom@tromey.com>
12993
12994         * objfiles.h (struct objfile_per_bfd_storage): Declare
12995         destructor.
12996         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12997         New.
12998         (get_objfile_bfd_data): Use new.  Don't initialize
12999         language_of_main.
13000         (free_objfile_per_bfd_storage): Remove.
13001         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13002
13003 2019-03-15  Tom Tromey  <tom@tromey.com>
13004
13005         * symfile.c (reread_symbols): Update.
13006         * objfiles.c (objfile::objfile): Update.
13007         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13008         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13009         comment.
13010         (minimal_symbol_reader::install): Update.
13011         (terminate_minimal_symbol_table): Remove.
13012         * jit.c (jit_object_close_impl): Update.
13013
13014 2019-03-15  Tom Tromey  <tom@tromey.com>
13015
13016         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13017         initializations.
13018
13019 2019-03-15  Tom Tromey  <tom@tromey.com>
13020
13021         * objfiles.h (struct objfile_per_bfd_storage)
13022         <demangled_hash_languages>: Now a bitset.
13023         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13024         (lookup_minimal_symbol): Update.
13025
13026 2019-03-15  Tom Tromey  <tom@tromey.com>
13027
13028         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13029         Don't return the symbol.
13030         * coffread.c (record_minimal_symbol): Use record_full.
13031
13032 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13033
13034         The MS-Windows port of ncurses fails to switch to a color pair if
13035         one or both of the colors are the implicit default colors.  This
13036         change records the default colors when TUI is initialized, and
13037         then specifies them explicitly when a color pair uses the default
13038         colors.  This allows color styling in TUI mode on MS-Windows.
13039
13040         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13041         ncurses_norm_attr.
13042         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13043         colors in ncurses_norm_attr.
13044         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13045         "none", replace it with the default color recorded in
13046         ncurses_norm_attr.
13047
13048 2019-03-14  Tom Tromey  <tromey@adacore.com>
13049
13050         * source-cache.h (class source_cache) <get_source_lines>: Return
13051         std::string.
13052         * source-cache.c (source_cache::extract_lines): Handle case where
13053         first_pos==npos.  Return std::string.
13054         (source_cache::get_source_lines): Update.
13055
13056 2019-03-14  Tom Tromey  <tromey@adacore.com>
13057
13058         * NEWS: Add item for "style sources" commands.
13059         * source-cache.c (source_cache::get_source_lines): Check
13060         source_styling.
13061         * cli/cli-style.c (source_styling): New global.
13062         (_initialize_cli_style): Add "style sources" commands.
13063         (show_style_sources): New function.
13064         * cli/cli-style.h (source_styling): Declare.
13065
13066 2019-03-14  Pedro Alves  <palves@redhat.com>
13067             Tom Tromey  <tromey@adacore.com>
13068
13069         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13070         * tui/tui-winsource.c (tui_refill_source_window): New function,
13071         from...
13072         (tui_horizontal_source_scroll): ... here.  Move some logic.
13073         * cli/cli-style.c (set_style_enabled): Notify new observable.
13074         * tui/tui-hooks.c (tui_redisplay_source): New function.
13075         (tui_attach_detach_observers): Attach or detach
13076         tui_redisplay_source.
13077         * observable.h (source_styling_changed): New observable.
13078         * observable.c: Define source_styling_changed observable.
13079
13080 2019-03-13  Tom Tromey  <tromey@adacore.com>
13081
13082         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13083         (i386_gnu_nat_target::store_registers): Update.
13084         * target-debug.h (target_debug_print_std_string): New macro.
13085         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13086         * windows-tdep.c (display_one_tib): Update.
13087         * tui/tui-stack.c (tui_make_status_line): Update.
13088         * top.c (print_inferior_quit_action): Update.
13089         * thread.c (thr_try_catch_cmd): Update.
13090         (add_thread_with_info): Update.
13091         (thread_target_id_str): Update.
13092         (thr_try_catch_cmd): Update.
13093         (thread_command): Update.
13094         (thread_find_command): Update.
13095         * record-btrace.c (record_btrace_target::info_record)
13096         (record_btrace_resume_thread, record_btrace_target::resume)
13097         (record_btrace_cancel_resume, record_btrace_step_thread)
13098         (record_btrace_target::wait, record_btrace_target::wait)
13099         (record_btrace_target::wait, record_btrace_target::stop): Update.
13100         * progspace.c (print_program_space): Update.
13101         * process-stratum-target.c
13102         (process_stratum_target::thread_address_space): Update.
13103         * linux-fork.c (linux_fork_mourn_inferior)
13104         (detach_checkpoint_command, info_checkpoints_command)
13105         (linux_fork_context): Update.
13106         (linux_fork_detach): Update.
13107         (class scoped_switch_fork_info): Update.
13108         (delete_checkpoint_command): Update.
13109         * infrun.c (follow_fork_inferior): Update.
13110         (follow_fork_inferior): Update.
13111         (proceed_after_vfork_done): Update.
13112         (handle_vfork_child_exec_or_exit): Update.
13113         (follow_exec): Update.
13114         (displaced_step_prepare_throw): Update.
13115         (displaced_step_restore): Update.
13116         (start_step_over): Update.
13117         (resume_1): Update.
13118         (clear_proceed_status_thread): Update.
13119         (proceed): Update.
13120         (print_target_wait_results): Update.
13121         (do_target_wait): Update.
13122         (context_switch): Update.
13123         (stop_all_threads): Update.
13124         (restart_threads): Update.
13125         (finish_step_over): Update.
13126         (handle_signal_stop): Update.
13127         (switch_back_to_stepped_thread): Update.
13128         (keep_going_pass_signal): Update.
13129         (print_exited_reason): Update.
13130         (normal_stop): Update.
13131         * inferior.c (inferior_pid_to_str): Change return type.
13132         (print_selected_inferior): Update.
13133         (add_inferior): Update.
13134         (detach_inferior): Update.
13135         * dummy-frame.c (fprint_dummy_frames): Update.
13136         * dcache.c (dcache_info_1): Update.
13137         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13138         (btrace_fetch, btrace_clear): Update.
13139         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13140         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13141         type.
13142         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13143         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13144         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13145         * gdbarch.c, gdbarch.h: Rebuild.
13146         * gdbarch.sh (core_pid_to_str): Change return type.
13147         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13148         return type.
13149         (windows_nat_target::pid_to_str): Change return type.
13150         (windows_delete_thread): Update.
13151         (windows_nat_target::attach): Update.
13152         (windows_nat_target::files_info): Update.
13153         * target-delegates.c: Rebuild.
13154         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13155         return type.
13156         (sol_thread_target::pid_to_str): Change return type.
13157         * remote.c (class remote_target) <pid_to_str>: Change return
13158         type.
13159         (remote_target::pid_to_str): Change return type.
13160         (extended_remote_target::attach, remote_target::remote_stop_ns)
13161         (remote_target::remote_notif_remove_queued_reply)
13162         (remote_target::push_stop_reply, remote_target::disable_btrace):
13163         Update.
13164         (extended_remote_target::attach): Update.
13165         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13166         type.
13167         (gdbsim_target::pid_to_str): Change return type.
13168         * ravenscar-thread.c (struct ravenscar_thread_target)
13169         <pid_to_str>: Change return type.
13170         (ravenscar_thread_target::pid_to_str): Change return type.
13171         * procfs.c (class procfs_target) <pid_to_str>: Change return
13172         type.
13173         (procfs_target::pid_to_str): Change return type.
13174         (procfs_target::attach): Update.
13175         (procfs_target::detach): Update.
13176         (procfs_target::fetch_registers): Update.
13177         (procfs_target::store_registers): Update.
13178         (procfs_target::wait): Update.
13179         (procfs_target::files_info): Update.
13180         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13181         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13182         return type.
13183         (nto_procfs_target::pid_to_str): Change return type.
13184         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13185         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13186         return type.
13187         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13188         (exit_lwp): Update.
13189         (attach_proc_task_lwp_callback, get_detach_signal)
13190         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13191         (linux_nat_target::resume, wait_lwp, stop_callback)
13192         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13193         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13194         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13195         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13196         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13197         type.
13198         (inf_ptrace_target::attach): Update.
13199         (inf_ptrace_target::files_info): Update.
13200         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13201         type.
13202         (go32_nat_target::pid_to_str): Change return type.
13203         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13204         (gnu_nat_target::wait): Update.
13205         (gnu_nat_target::wait): Update.
13206         (gnu_nat_target::resume): Update.
13207         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13208         (fbsd_nat_target::wait): Update.
13209         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13210         type.
13211         (darwin_nat_target::attach): Update.
13212         * corelow.c (class core_target) <pid_to_str>: Change return type.
13213         (core_target::pid_to_str): Change return type.
13214         * target.c (normal_pid_to_str): Change return type.
13215         (default_pid_to_str): Likewise.
13216         (target_pid_to_str): Change return type.
13217         (target_translate_tls_address): Update.
13218         (target_announce_detach): Update.
13219         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13220         return type.
13221         (bsd_uthread_target::pid_to_str): Change return type.
13222         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13223         type.
13224         (bsd_kvm_target::pid_to_str): Change return type.
13225         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13226         return type.
13227         (aix_thread_target::pid_to_str): Change return type.
13228         * target.h (struct target_ops) <pid_to_str>: Change return type.
13229         (target_pid_to_str, normal_pid_to_str): Likewise.
13230         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13231         type.
13232         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13233         type.
13234         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13235         return type.
13236         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13237         type.
13238         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13239         type.
13240         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13241         return type.
13242
13243 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13244
13245         * NEWS: Mention that the new default MI version is 3.  Mention
13246         changes to the output of commands and events that deal with
13247         multi-location breakpoints.
13248         * breakpoint.c: Include "mi/mi-out.h".
13249         (print_one_breakpoint): Change output syntax if using MI version
13250         >= 3.
13251         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13252         New.
13253         (mi_multi_location_breakpoint_output_fixed): New.
13254         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13255         (mi_cmd_fix_multi_location_breakpoint_output): New.
13256         (mi_multi_location_breakpoint_output_fixed): New.
13257         * mi/mi-cmds.c (mi_cmds): Register command
13258         -fix-multi-location-breakpoint-output.
13259         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13260         interpreter "mi".
13261
13262 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13263
13264         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13265         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13266         instantiate mi_ui_out based on interpreter name.
13267         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13268         * mi/mi-main.c (mi_load_progress): Likewise.
13269
13270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13271
13272         * NEWS: Combine separate "New targets" sections for 8.3.
13273
13274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13275
13276         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13277         (ppcfbsd_init_abi): Install gdbarch
13278         "fetch_tls_load_module_address" and "get_thread_local_address"
13279         methods.
13280
13281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13282
13283         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13284         (riscv_fbsd_init_abi): Install gdbarch
13285         "fetch_tls_load_module_address" and "get_thread_local_address"
13286         methods.
13287
13288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13289
13290         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13291         (i386fbsd_init_abi): Install gdbarch
13292         "fetch_tls_load_module_address" and "get_thread_local_address"
13293         methods.
13294
13295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13296
13297         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13298         (amd64fbsd_init_abi): Install gdbarch
13299         "fetch_tls_load_module_address" and "get_thread_local_address"
13300         methods.
13301
13302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13303
13304         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13305         (struct fbsd_pspace_data): New type.
13306         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13307         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13308         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13309         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13310         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13311
13312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13313
13314         * gdbtypes.c (lookup_struct_elt): New function.
13315         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13316         * gdbtypes.h (struct struct_elt): New type.
13317         (lookup_struct_elt): New prototype.
13318
13319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13320
13321         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13322         remove disabled code block.
13323
13324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13325
13326         * gdbarch.sh (get_thread_local_address): New method.
13327         * gdbarch.h, gdbarch.c: Regenerate.
13328         * target.c (target_translate_tls_address): Use
13329         gdbarch_get_thread_local_address if present instead of
13330         target::get_thread_local_address.
13331
13332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13333
13334         * target.h (target::get_thread_local_address): Update comment.
13335
13336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13337
13338         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13339         objfile->separate_debug_objfile_backlink if not NULL.
13340
13341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13342
13343         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13344         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13345         (amd64bsd_store_inferior_registers): Likewise.
13346         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13347         Enable segment base registers.
13348         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13349         PT_GETFSBASE and PT_GETGSBASE.
13350         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13351         PT_SETGSBASE.
13352         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13353         segment base registers.
13354         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13355
13356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13357
13358         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13359         Update calls to i386_target_description to add 'segments'
13360         parameter.
13361         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13362         add segment base registers.
13363         * arch/i386.c (i386_create_target_description): Add 'segments'
13364         parameter to enable segment base registers.
13365         * arch/i386.h (i386_create_target_description): Likewise.
13366         * features/i386/32bit-segments.xml: New file.
13367         * features/i386/32bit-segments.c: Generate.
13368         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13369         call to i386_target_description to add 'segments' parameter.
13370         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13371         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13372         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13373         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13374         if feature is present.
13375         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13376         Add 'segments' parameter to call to i386_target_description.
13377         (i386_target_description): Add 'segments' parameter to enable
13378         segment base registers.
13379         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13380         to call to i386_target_description.
13381         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13382         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13383         Define I386_NUM_REGS.
13384         (i386_target_description): Add 'segments' parameter to enable
13385         segment base registers.
13386
13387 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13388
13389         PR/24325
13390         * source-cache.c: #undef open and close, to avoid unresolved
13391         externals during linking.
13392
13393 2019-03-12  Tom Tromey  <tromey@adacore.com>
13394
13395         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13396         const.  Add initializers.
13397         (_initialize_remote): Don't initialize ptid globals.
13398
13399 2019-03-12  Pedro Alves  <palves@redhat.com>
13400
13401         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13402
13403 2019-03-12  Pedro Alves  <palves@redhat.com>
13404
13405         * cp-name-parser.y (main): Remove unused 'len' variable.
13406
13407 2019-03-12  Tom Tromey  <tromey@adacore.com>
13408
13409         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13410         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13411
13412 2019-03-12  Tom Tromey  <tromey@adacore.com>
13413
13414         * linux-nat.c (iterate_over_lwps): Update.
13415         (stop_callback): Remove parameter.
13416         (stop_wait_callback, detach_callback, resume_set_callback)
13417         (select_singlestep_lwp_callback, set_ignore_sigint)
13418         (status_callback, resumed_callback, resume_clear_callback)
13419         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13420         data parameter.
13421         (linux_nat_target::detach, linux_nat_target::resume)
13422         (linux_stop_and_wait_all_lwps, select_event_lwp)
13423         (linux_nat_filter_event, linux_nat_wait_1)
13424         (linux_nat_target::kill, linux_nat_target::stop)
13425         (linux_nat_target::stop): Update.
13426         (linux_nat_resume_callback): Change type.
13427         (resume_stopped_resumed_lwps, count_events_callback)
13428         (select_event_lwp_callback): Likewise.
13429         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13430         * arm-linux-nat.c (struct update_registers_data): Remove.
13431         (update_registers_callback): Change type.
13432         (arm_linux_insert_hw_breakpoint1): Update.
13433         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13434         parameter.
13435         (x86_linux_dr_set_addr): Update.
13436         (x86_linux_dr_set_control): Update.
13437         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13438         (iterate_over_lwps): Use gdb::function_view.
13439         * nat/aarch64-linux-hw-point.c (struct
13440         aarch64_dr_update_callback_param): Remove.
13441         (debug_reg_change_callback): Change type.
13442         (aarch64_notify_debug_reg_change): Update.
13443         * s390-linux-nat.c (s390_refresh_per_info): Update.
13444
13445 2019-03-11  Tom Tromey  <tromey@adacore.com>
13446
13447         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13448         redundant assignment to "this_cu".
13449
13450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13451
13452         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13453
13454 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13455
13456         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13457         from...
13458         (rank_one_type): ... this.
13459
13460 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13461
13462         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13463         from...
13464         (rank_one_type): ... this.
13465
13466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13467
13468         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13469         from...
13470         (rank_one_type): ... this.
13471
13472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13473
13474         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13475         from...
13476         (rank_one_type): ... this.
13477
13478 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13479
13480         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13481         from...
13482         (rank_one_type): ... this.
13483
13484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13485
13486         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13487         from...
13488         (rank_one_type): ... this.
13489
13490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13491
13492         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13493         from...
13494         (rank_one_type): ... this.
13495
13496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13497
13498         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13499         from...
13500         (rank_one_type): ... this.
13501
13502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13503
13504         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13505         from...
13506         (rank_one_type): ... this.
13507
13508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13509
13510         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13511         from...
13512         (rank_one_type): ... this.
13513
13514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13515
13516         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13517         from...
13518         (rank_one_type): ... this.
13519
13520 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13521
13522         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13523         from...
13524         (rank_one_type): ... this.
13525
13526 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13527
13528         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13529         inferior-events' shows the example events.
13530
13531 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13532
13533         Support styling on native MS-Windows console
13534
13535         PR/24315
13536         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13537         on MS-Windows if $TERM is not defined.
13538
13539         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13540
13541         * posix-hdep.c (gdb_console_fputs):
13542         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13543         functions.
13544         * ui-file.h (gdb_console_fputs): Add prototype.
13545
13546         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13547         back to fputs only if the former returns zero.
13548
13549 2019-03-07  Tom Tromey  <tom@tromey.com>
13550
13551         * symmisc.c (print_symbol_bcache_statistics): Update.
13552         (print_objfile_statistics): Update.
13553         * symfile.c (allocate_symtab): Update.
13554         * stabsread.c: Don't include bcache.h.
13555         * psymtab.h (struct psymbol_bcache): Don't declare.
13556         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13557         (psymbol_bcache_init, psymbol_bcache_free)
13558         (psymbol_bcache_get_bcache): Don't declare.
13559         * psymtab.c (struct psymbol_bcache): Remove.
13560         (psymtab_storage::psymtab_storage): Update.
13561         (psymtab_storage::~psymtab_storage): Update.
13562         (psymbol_bcache_init, psymbol_bcache_free)
13563         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13564         (add_psymbol_to_bcache): Update.
13565         (allocate_psymtab): Update.
13566         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13567         macro_cache>: No longer pointers.
13568         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13569         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13570         * macrotab.c (macro_bcache): Update.
13571         * macroexp.c: Don't include bcache.h.
13572         * gdbtypes.c (check_types_worklist): Update.
13573         (types_deeply_equal): Remove TRY/CATCH.  Update.
13574         * elfread.c (elf_symtab_read): Update.
13575         * dwarf2read.c: Don't include bcache.h.
13576         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13577         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13578         (print_bcache_statistics, bcache_memory_used): Don't declare.
13579         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13580         methods.  Rename all data members.
13581         * bcache.c (struct bcache): Move to bcache.h.
13582         (bcache::expand_hash_table): Rename from expand_hash_table.
13583         (bcache): Remove.
13584         (bcache::insert): Rename from bcache_full.
13585         (bcache::compare): Rename from bcache_compare.
13586         (bcache_xmalloc): Remove.
13587         (bcache::~bcache): Rename from bcache_xfree.
13588         (bcache::print_statistics): Rename from print_bcache_statistics.
13589         (bcache::memory_used): Rename from bcache_memory_used.
13590
13591 2019-03-07  Pedro Alves  <palves@redhat.com>
13592
13593         * infrun.c (normal_stop): Also check for
13594         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13595
13596 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13597
13598         * f-lang.c (value_from_host_double): Moved to...
13599         * value.c (value_from_host_double): ...here.
13600         * value.h (value_from_host_double): Declare.
13601         * guile/scm-math.c (vlscm_convert_typed_number): Use
13602         value_from_host_double.
13603         (vlscm_convert_number): Likewise.
13604         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13605         * python/py-value.c (convert_value_from_python): Likewise.
13606
13607 2019-03-06  Tom Tromey  <tom@tromey.com>
13608
13609         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13610
13611 2019-03-06  Tom Tromey  <tom@tromey.com>
13612
13613         * utils.h (free_current_contents): Don't declare.
13614         * utils.c (free_current_contents): Remove.
13615
13616 2019-03-06  Tom Tromey  <tom@tromey.com>
13617
13618         * top.c (quit_force): Update.
13619         * main.c (captured_command_loop): Update.
13620         * common/new-op.c (operator new): Update.
13621         * common/common-exceptions.c (struct catcher)
13622         <save_cleanup_chain>: Remove member.
13623         (exceptions_state_mc_init): Update.
13624         (exception_try_scope_entry): Return nullptr.
13625         (exception_try_scope_exit, exception_rethrow)
13626         (throw_exception_sjlj, throw_exception_cxx): Update.
13627         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13628         (all_cleanups, do_cleanups, discard_cleanups)
13629         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13630         (restore_cleanups, restore_final_cleanups): Don't declare.
13631         (do_final_cleanups): Remove parameter.
13632         * common/cleanups.c (cleanup_chain, make_cleanup)
13633         (make_cleanup_dtor, all_cleanups, do_cleanups)
13634         (discard_my_cleanups, discard_cleanups)
13635         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13636         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13637         (null_cleanup): Remove.
13638         (do_final_cleanups): Remove parameter.
13639
13640 2019-03-06  Tom Tromey  <tom@tromey.com>
13641
13642         * remote.c (remote_target::remote_parse_stop_reply): Use
13643         unique_xmalloc_ptr.
13644
13645 2019-03-06  Tom Tromey  <tom@tromey.com>
13646
13647         * stabsread.c (struct stabs_field_info): Rename from field_info.
13648         <list, fnlist>: Add initializers.
13649         <obstack>: New member.
13650         (read_member_functions, read_struct_fields, read_baseclasses):
13651         Allocate on obstack.  Don't use cleanups.
13652         (read_one_struct_field, read_member_functions, read_struct_fields)
13653         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13654         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13655         (read_struct_type): Update.
13656
13657 2019-03-06  Tom Tromey  <tom@tromey.com>
13658
13659         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13660         * common/filestuff.h (make_cleanup_close): Don't declare.
13661         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13662         Remove.
13663
13664 2019-03-06  Tom Tromey  <tom@tromey.com>
13665
13666         * solib-aix.c: Use make_scope_exit.
13667
13668 2019-03-06  Tom Tromey  <tom@tromey.com>
13669
13670         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13671         Use make_scope_exit.
13672
13673 2019-03-06  Tom Tromey  <tom@tromey.com>
13674
13675         * solib-svr4.c (disable_probes_interface): Remove parameter.
13676         (svr4_handle_solib_event): Use make_scope_exit.
13677
13678 2019-03-06  Tom Tromey  <tom@tromey.com>
13679
13680         * remote.c (struct stop_reply_deleter): Remove.
13681         (stop_reply_up): Update.
13682         (struct stop_reply): Derive from notif_event.  Don't typedef.
13683         <regcache>: Now a std::vector.
13684         (stop_reply_xfree): Remove.
13685         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13686         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13687         (remote_target::discard_pending_stop_replies): Use delete.
13688         (remote_target::remote_parse_stop_reply): Update.
13689         (remote_target::process_stop_reply): Update.
13690         * remote-notif.h (struct notif_event): Add virtual destructor.
13691         Remove "dtr" member.
13692         (struct notif_client) <alloc_event>: Return a unique_ptr.
13693         (notif_event_xfree): Don't declare.
13694         (notif_event_up): New typedef.
13695         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13696         (notif_event_xfree, do_notif_event_xfree): Remove.
13697         (remote_notif_state_xfree): Update.
13698
13699 2019-03-06  Tom Tromey  <tom@tromey.com>
13700
13701         * infrun.c (displaced_step_clear_cleanup): Now a
13702         forward_scope_exit type.
13703         (displaced_step_prepare_throw): Update.
13704         (displaced_step_fixup): Update.
13705
13706 2019-03-06  Tom Tromey  <tom@tromey.com>
13707
13708         * inferior.h (class inferior): Update comment.
13709         * gdbthread.h (class thread_info): Update comment.
13710
13711 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13712             Tom Tromey  <tom@tromey.com>
13713
13714         * stabsread.h (struct stab_section_list): Remove.
13715         (coffstab_build_psymtabs): Update.
13716         * dbxread.c (symbuf_sections): Now a std::vector.
13717         (sect_idx): New global.
13718         (fill_symbuf): Update.
13719         (coffstab_build_psymtabs): Change type of stabsects parameter.
13720         Update.
13721         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13722         std::vector.
13723         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13724         (coff_locate_sections): Update.
13725         (coff_symfile_read): Remove cleanups.  Update.
13726         (init_stringtab): Add storage parameter.
13727         (free_stringtab, free_stringtab_cleanup): Remove.
13728         (init_lineno): Add storage parameter.
13729         (free_linetab, free_linetab_cleanup): Remove.
13730
13731 2019-03-06  Pedro Alves  <palves@redhat.com>
13732
13733         * linux-fork.c (fork_info::clobber_regs): Delete.
13734         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13735         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13736         comment.  Adjust.
13737         (scoped_switch_fork_info::scoped_switch_fork_info)
13738         (checkpoint_command, linux_fork_context): Adjust
13739         fork_save_infrun_state calls.
13740
13741 2019-03-06  Pedro Alves  <palves@redhat.com>
13742
13743         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13744         (inf_has_multiple_threads): Return 'bool' and rewrite using
13745         inferior_info::threads().
13746
13747 2019-03-06  Pedro Alves  <palves@redhat.com>
13748
13749         * linux-fork.c: Include <list>.
13750         (fork_list): Now a std::list instance.
13751         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13752         (forks_exist_p, find_last_fork): Adjust.
13753         (new_fork): Delete.
13754         (one_fork_p): New.
13755         (add_fork): Adjust.
13756         (free_fork): Delete, folded into fork_info::~fork_info().
13757         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13758         Adjust.
13759         (init_fork_list): Delete.
13760         (linux_fork_killall, linux_fork_mourn_inferior)
13761         (linux_fork_detach, info_checkpoints_command): Adjust.
13762         (_initialize_linux_fork): No longer call init_fork_list.
13763
13764 2019-03-06  Pedro Alves  <palves@redhat.com>
13765
13766         * linux-fork.c (new_fork): New, split out of ...
13767         (add_fork): ... this.  Return void.  Move "first fork" special
13768         case from here, to ...
13769         (checkpoint_command): ... here.
13770         * linux-linux.h (add_fork): Return void.
13771
13772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13773
13774         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13775
13776 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13777             Chris January  <chris.january@arm.com>
13778             David Lecomber  <david.lecomber@arm.com>
13779
13780         * f-exp.y: New token, UNOP_INTRINSIC.
13781         (exp): New pattern using UNOP_INTRINSIC token.
13782         (f77_keywords): Add 'abs' keyword.
13783         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13784         (value_from_host_double): New function.
13785         (evaluate_subexp_f): Support UNOP_ABS.
13786
13787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13788
13789         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13790         types.
13791
13792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13793
13794         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13795         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13796         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13797
13798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13799
13800         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13801
13802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13803             Chris January  <chris.january@arm.com>
13804
13805         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13806         * f-exp.y: Define 'KIND' token.
13807         (exp): New pattern for KIND expressions.
13808         (ptype): Handle types with a kind extension.
13809         (direct_abs_decl): Extend to spot kind extensions.
13810         (f77_keywords): Add 'kind' to the list.
13811         (push_kind_type): New function.
13812         (convert_to_kind_type): New function.
13813         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13814         * parse.c (operator_length_standard): Likewise.
13815         * parser-defs.h (enum type_pieces): Add tp_kind.
13816         * std-operator.def: Add UNOP_KIND.
13817
13818 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13819
13820         * f-exp.y (f_parse): Set yydebug.
13821
13822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13823
13824         * f-lang.c (evaluate_subexp_f): New function.
13825         (exp_descriptor_f): New global.
13826         (f_language_defn): Use exp_descriptor_f instead of
13827         exp_descriptor_standard.
13828
13829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13830
13831         * f-exp.y (struct token): Add comments.
13832         (dot_ops): Remove uppercase versions and the end marker.
13833         (f77_keywords): Likewise.
13834         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13835         entries in the dot_ops array are case insensitive, and use
13836         strncasecmp to compare strings.  Also some whitespace cleanup in
13837         this area.  Similar for the f77_keywords array, except entries in
13838         this list might be case sensitive.
13839
13840 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13841
13842         * f-exp.y (struct f77_boolean_val): Add comments.
13843         (boolean_values): Remove uppercase versions, and end marker.
13844         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13845         and use strncasecmp to achieve case insensitivity.  Additionally,
13846         perform whitespace cleanup around this code.
13847
13848 2019-03-06  Tom Tromey  <tromey@adacore.com>
13849
13850         * remote-sim.c (gdbsim_target_open): Use result of
13851         gdb_argv::release.
13852
13853 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13854         Dirk Schubert  <dirk.schubert@arm.com>
13855         Chris January  <chris.january@arm.com>
13856
13857         * eval.c (evaluate_subexp_standard): Call Fortran argument
13858         wrapping logic.
13859         * f-lang.c (struct value): A value which can be passed into a
13860         Fortran function call.
13861         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13862         where appropriate.
13863         (struct type): Value ready for a Fortran function call.
13864         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13865         is needed.
13866         * f-lang.h (fortran_argument_convert): Declaration.
13867         (fortran_preserve_arg_pointer): Declaration.
13868         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13869
13870 2019-03-05  Tom Tromey  <tromey@adacore.com>
13871
13872         * python/py-prettyprint.c (print_string_repr): Remove #if.
13873         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13874
13875 2019-03-05  Tom Tromey  <tromey@adacore.com>
13876
13877         * target.c (the_dummy_target): Move later.  Change type to
13878         "dummy_target".
13879         (initialize_targets): Don't initialize the_dummy_target.
13880
13881 2019-03-05  Tom Tromey  <tromey@adacore.com>
13882
13883         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13884         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13885
13886 2019-03-05  Tom Tromey  <tromey@adacore.com>
13887
13888         * windows-nat.c (windows_nat_target::attach)
13889         (windows_nat_target::detach): Don't call gdb_flush.
13890         * valprint.c (generic_val_print, val_print, val_print_string):
13891         Don't call gdb_flush.
13892         * utils.c (defaulted_query): Don't call gdb_flush.
13893         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13894         * target.c (target_announce_detach): Don't call gdb_flush.
13895         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13896         * remote.c (extended_remote_target::attach): Don't call
13897         gdb_flush.
13898         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13899         * printcmd.c (do_examine): Don't call gdb_flush.
13900         (info_display_command): Don't call gdb_flush.
13901         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13902         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13903         * memattr.c (info_mem_command): Don't call gdb_flush.
13904         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13905         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13906         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13907         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13908         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13909         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13910         (gnu_nat_target::detach): Don't call gdb_flush.
13911         * f-valprint.c (f_val_print): Don't call gdb_flush.
13912         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13913         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13914         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13915         gdb_flush.
13916         * c-valprint.c (c_val_print): Don't call gdb_flush.
13917         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13918
13919 2019-03-05  Tom Tromey  <tromey@adacore.com>
13920
13921         * varobj.c (update_dynamic_varobj_children): Update.
13922         (install_default_visualizer): Use reset, not release.
13923         * value.c (set_internalvar): Update.
13924         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13925         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13926         ATTRIBUTE_UNUSED_RESULT.
13927
13928 2019-03-05  Tom Tromey  <tromey@adacore.com>
13929
13930         * remote.c (class scoped_remote_fd) <release>: Add
13931         ATTRIBUTE_UNUSED_RESULT.
13932
13933 2019-03-05  Tom Tromey  <tromey@adacore.com>
13934
13935         * macroexp.c (struct macro_buffer) <release>: Add
13936         ATTRIBUTE_UNUSED_RESULT.
13937
13938 2019-03-05  Tom Tromey  <tromey@adacore.com>
13939
13940         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13941         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13942         ATTRIBUTE_UNUSED_RESULT.
13943
13944 2019-03-05  Tom Tromey  <tromey@adacore.com>
13945
13946         * common/scoped_fd.h (class scoped_fd) <release>: Add
13947         ATTRIBUTE_UNUSED_RESULT.
13948
13949 2019-03-05  Tom Tromey  <tromey@adacore.com>
13950
13951         * parser-defs.h (struct parser_state) <release>: Add
13952         ATTRIBUTE_UNUSED_RESULT.
13953
13954 2019-03-05  Tom Tromey  <tromey@adacore.com>
13955
13956         * utils.h (class gdb_argv) <release>: Add
13957         ATTRIBUTE_UNUSED_RESULT.
13958         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13959
13960 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13961
13962         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13963         for-loop range, to avoid compiler warnings.
13964
13965         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13966         avoid compiler warnings about unused variables.
13967
13968         * NEWS: Mention end of support for native debugging on MS-Windows
13969         before XP.
13970
13971         PR gdb/24292
13972         * common/netstuff.c:
13973         * gdbserver/gdbreplay.c
13974         * gdbserver/remote-utils.c:
13975         * ser-tcp.c:
13976         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13977         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13978         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13979         'getaddrinfo' and 'freeaddrinfo' were not available before
13980         Windows XP, and mingw.org's MinGW headers by default define
13981         _WIN32_WINNT to 0x500.
13982
13983 2019-03-01  Gary Benson <gbenson@redhat.com>
13984
13985         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13986
13987 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13988             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13989
13990         PR gdb/8527
13991         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13992         set_sigint_trap, clear_sigint_trap.
13993
13994 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13995
13996         * target.c (target_detach): Clear the regcache and the
13997         frame cache.
13998
13999 2019-02-27  Pedro Alves  <palves@redhat.com>
14000
14001         * utils.c (set_screen_size): When we cap the height/width sizes,
14002         tweak the corresponding command variable to show "unlimited":
14003
14004 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14005             Pedro Alves  <palves@redhat.com>
14006
14007         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14008         before calling rl_set_screen_size.
14009
14010 2019-02-27  Tom Tromey  <tromey@adacore.com>
14011
14012         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14013         define.
14014         * python/py-value.c: Remove Python 2.4 workaround.
14015         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14016         workaround.
14017         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14018         Python 2.4 workaround.
14019         * python/python-internal.h: Remove Python 2.4 comment.
14020         (Py_ssize_t): Don't define.
14021         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14022         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14023         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14024         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14025         * python/python.c (do_start_initialization): Remove Python 2.4
14026         workaround.
14027         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14028         (print_children): Remove Python 2.4 workaround.
14029         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14030         workaround.
14031         (CHARBUFFERPROC_NAME): Remove.
14032         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14033         Python 2.4 workaround.
14034
14035 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14036
14037         * NEWS: Note minimum Python version.
14038
14039 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14040
14041         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14042         code from these functions.  Remove corresponding ifdefs.  Use
14043         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14044         Remove gotos and target of gotos.
14045         (infpy_search_memory): Likewise.
14046
14047 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14048
14049         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14050         (hppa_gdbarch_init): Don't register deleted functions with
14051         gdbarch.
14052
14053 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14054
14055         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14056         (h8300_unwind_sp): Delete.
14057         (h8300_dummy_id): Delete.
14058         (h8300_gdbarch_init): Don't register deleted functions with
14059         gdbarch.
14060
14061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14062
14063         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14064         (ft32_unwind_pc): Delete.
14065         (ft32_unwind_sp): Delete.
14066         (ft32_gdbarch_init): Don't register deleted functions with
14067         gdbarch.
14068
14069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14070
14071         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14072         (frv_unwind_pc): Delete.
14073         (frv_unwind_sp): Delete.
14074         (frv_gdbarch_init): Don't register deleted functions with
14075         gdbarch.
14076
14077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14078
14079         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14080         (riscv_unwind_pc): Delete.
14081         (riscv_unwind_sp): Delete.
14082         (riscv_gdbarch_init): Don't register deleted functions with
14083         gdbarch.
14084
14085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14086
14087         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14088         (csky_unwind_pc): Delete.
14089         (csky_unwind_sp): Delete.
14090         (csky_gdbarch_init): Don't register deleted functions with
14091         gdbarch.
14092
14093 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14094
14095         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14096         (cris_unwind_pc): Delete.
14097         (cris_unwind_sp): Delete.
14098         (cris_gdbarch_init): Don't register deleted functions with
14099         gdbarch.
14100
14101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14102
14103         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14104         (bfin_unwind_pc): Delete.
14105         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14106
14107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14108
14109         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14110         (arm_unwind_pc): Delete.
14111         (arm_unwind_sp): Delete.
14112         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14113
14114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14115
14116         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14117         (arc_unwind_pc): Delete.
14118         (arc_unwind_sp): Delete.
14119         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14120
14121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14122
14123         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14124         (alpha_unwind_pc): Delete.
14125         (alpha_gdbarch_init): Don't register deleted functions with
14126         gdbarch.
14127
14128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14129
14130         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14131         (aarch64_unwind_pc): Delete.
14132         (aarch64_unwind_sp): Delete.
14133         (aarch64_gdbarch_init): Don't register deleted functions with
14134         gdbarch.
14135
14136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14137
14138         * gdbtypes.c (type_align): Don't consider static members when
14139         computing structure alignment.
14140
14141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14142
14143         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14144         return 0 for other types.
14145         * arch-utils.c (default_type_align): Always return 0.
14146         * gdbarch.h: Regenerate.
14147         * gdbarch.sh (type_align): Extend comment.
14148         * gdbtypes.c (type_align): Add additional comments, always call
14149         gdbarch_type_align before applying the default rules.
14150         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14151         generic code will then apply a suitable default.
14152         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14153         types, return 0 for other types.
14154
14155 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14156
14157         * NEWS: Create a new section for the next release branch.
14158         Rename the section of the current branch, now that it has
14159         been cut.
14160
14161 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14162
14163         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14164         * version.in: Bump version to 8.3.50.DATE-git.
14165
14166 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14167
14168         * aix-thread.c (ptid_cmp): Remove unused variable.
14169         (get_signaled_thread): Likewise.
14170         (store_regs_user_thread): Likewise.
14171         (store_regs_kernel_thread): Likewise.
14172         (fetch_regs_kernel_thread): Remove shadowed variable.
14173
14174 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14175
14176         * features/riscv/32bit-cpu.xml: Add register numbers.
14177         * features/riscv/32bit-fpu.c: Regenerate.
14178         * features/riscv/32bit-fpu.xml: Add register numbers.
14179         * features/riscv/64bit-cpu.xml: Add register numbers.
14180         * features/riscv/64bit-fpu.c: Regenerate.
14181         * features/riscv/64bit-fpu.xml: Add register numbers.
14182
14183 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14184
14185         * NEWS: Mention two argument form of gdb.Value constructor.
14186         * python/py-value.c (convert_buffer_and_type_to_value): New
14187         function.
14188         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14189         Add support for handling an optional second argument.  Call
14190         convert_buffer_and_type_to_value as appropriate.
14191         * python/python-internal.h (Py_buffer_deleter): New struct.
14192         (Py_buffer_up): New typedef.
14193
14194 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14195
14196         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14197         instead of releasing ownership.
14198
14199 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14200
14201         * dwarf2read.c (open_and_init_dwp_file): Call
14202         elf_numsections instead of bfd_count_sections to initialize
14203         dwp_file->num_sections.
14204
14205 2019-02-25  Tom Tromey  <tromey@adacore.com>
14206
14207         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14208
14209 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14210
14211         * gcore.in: Add '--readnever' option when invoking GDB.
14212
14213 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14214
14215         * MAINTAINERS: Update my email address.
14216
14217 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14218
14219         * build-id.c (build_id_to_debug_bfd_1): New function.
14220         (build_id_to_debug_bfd): Look for separate debug file in
14221         sysroot.
14222
14223 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14224
14225         * gdbarch.sh: Update the copyright year range that is placed into
14226         generated files.
14227
14228 2019-02-22  Keith Seitz  <keiths@redhat.com>
14229
14230         PR symtab/23853
14231         * linespec.c (create_sals_line_offset): Search for the default
14232         symtab's filename instead of its fullname.
14233
14234 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14235
14236         * NEWS: Update style defaults.
14237
14238 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14239
14240         * main.c (captured_main_1): Disable styling in batch mode.
14241
14242 2019-02-20  Tom Tromey  <tom@tromey.com>
14243
14244         * symtab.c (symtab_symbol_info): Fix typos.
14245
14246 2019-02-20  Tom Tromey  <tromey@adacore.com>
14247
14248         * findcmd.c (_initialize_mem_search): Use upper case for
14249         metasyntactic variables.
14250
14251 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14252
14253         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14254         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14255
14256 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14257
14258         * top.h (source_file_name): Change to std::string.
14259         * top.c (source_file_name): Likewise.
14260         (command_line_input): Adjust.
14261         * cli/cli-script.c (script_from_file): Adjust.
14262
14263 2019-02-19  Tom Tromey  <tromey@adacore.com>
14264
14265         * ravenscar-thread.c
14266         (ravenscar_thread_target::update_thread_list): Don't call
14267         ada_build_task_list.
14268         * ada-lang.h (ada_build_task_list): Don't declare.
14269         * ada-tasks.c (struct ada_tasks_inferior_data)
14270         <task_list_valid_p>: Now bool.
14271         (read_known_tasks, ada_task_list_changed)
14272         (ada_tasks_invalidate_inferior_data): Update.
14273         (read_known_tasks_array): Return bool.
14274         (read_known_tasks_list): Likewise.
14275         (read_known_tasks): Return void.
14276         (ada_build_task_list): Now static.
14277
14278 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14279
14280         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14281         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14282
14283 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14284
14285         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14286         variant for ada_tasks_pspace_data_handle and
14287         ada_tasks_inferior_data_handle.
14288         (ada_tasks_pspace_data_cleanup): New function.
14289         (ada_tasks_inferior_data_cleanup): New function.
14290
14291 2019-02-17  Tom Tromey  <tom@tromey.com>
14292
14293         * macrotab.h (macro_source_fullname): Return a std::string.
14294         * macrotab.c (macro_include, check_for_redefinition)
14295         (macro_undef, macro_lookup_definition, foreach_macro)
14296         (foreach_macro_in_scope): Update.
14297         (macro_source_fullname): Return a std::string.
14298         * macrocmd.c (show_pp_source_pos): Update.
14299
14300 2019-02-17  Tom Tromey  <tom@tromey.com>
14301
14302         * macrocmd.c (show_pp_source_pos): Style the file names.
14303
14304 2019-02-17  Tom Tromey  <tom@tromey.com>
14305
14306         PR tui/24197:
14307         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14308
14309 2019-02-17  Tom Tromey  <tom@tromey.com>
14310
14311         * ada-lang.c (user_select_syms): Use filtered printing.
14312         * utils.c (wrap_style): New global.
14313         (desired_style): Remove.
14314         (emit_style_escape): Add stream parameter.
14315         (set_output_style, reset_terminal_style, prompt_for_continue):
14316         Update.
14317         (flush_wrap_buffer): Only flush gdb_stdout.
14318         (wrap_here): Set wrap_style.
14319         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14320         treat escape sequences as a character.  Change when wrap buffer is
14321         flushed.
14322         (fputs_styled): Do not set the output style when the default is
14323         requested.
14324         * ui-style.h (struct ui_file_style) <is_default>: New method.
14325         * source.c (print_source_lines_base): Emit escape sequences in one
14326         piece.
14327
14328 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14329
14330         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14331         integers and enumeration types.
14332
14333 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14334
14335         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14336         instead of lookup_symbol_in_language
14337         (do_exact_match): New function.
14338         (ada_get_symbol_name_matcher): Return do_exact_match when
14339         doing a verbatim match.
14340
14341 2019-02-15  Tom Tromey  <tromey@adacore.com>
14342
14343         * ravenscar-thread.c (ravenscar_thread_target::resume)
14344         (ravenscar_thread_target::wait): Special case wildcard requests.
14345
14346 2019-02-15  Tom Tromey  <tromey@adacore.com>
14347
14348         * ravenscar-thread.c (base_ptid): Remove.
14349         (struct ravenscar_thread_target) <close>: New method.
14350         <m_base_ptid>: New member.
14351         <update_inferior_ptid, active_task, task_is_currently_active,
14352         runtime_initialized>: Declare methods.
14353         <ravenscar_thread_target>: Add constructor.
14354         (ravenscar_thread_target::task_is_currently_active)
14355         (ravenscar_thread_target::update_inferior_ptid)
14356         (ravenscar_runtime_initialized): Rename.  Now methods.
14357         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14358         (ravenscar_thread_target::update_thread_list): Update.
14359         (ravenscar_thread_target::active_task): Now method.
14360         (ravenscar_thread_target::store_registers)
14361         (ravenscar_thread_target::prepare_to_store)
14362         (ravenscar_thread_target::prepare_to_store)
14363         (ravenscar_thread_target::mourn_inferior): Update.
14364         (ravenscar_inferior_created): Use "new" to create target.
14365         (ravenscar_thread_target::get_ada_task_ptid): Update.
14366         (_initialize_ravenscar): Don't initialize base_ptid.
14367         (ravenscar_ops): Remove global.
14368
14369 2019-02-15  Tom Tromey  <tromey@adacore.com>
14370
14371         * target.h (push_target): Declare new overload.
14372         * target.c (push_target): New overload, taking an rvalue reference.
14373         * remote.c (remote_target::open_1): Use push_target overload.
14374         * corelow.c (core_target_open): Use push_target overload.
14375
14376 2019-02-15  Tom Tromey  <tromey@adacore.com>
14377
14378         * ravenscar-thread.c (is_ravenscar_task)
14379         (ravenscar_task_is_currently_active): Return bool.
14380         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14381         (_initialize_ravenscar): Remove "(void)".
14382         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14383         Return bool.
14384
14385 2019-02-15  Tom Tromey  <tromey@adacore.com>
14386
14387         * ravenscar-thread.c (ravenscar_runtime_initializer)
14388         (has_ravenscar_runtime, get_running_thread_id)
14389         (ravenscar_thread_target::resume): Fix indentation.
14390
14391 2019-02-15  Tom Tromey  <tromey@adacore.com>
14392
14393         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14394         from ravenscar_arch_ops.
14395         (sparc_ravenscar_ops::fetch_registers)
14396         (sparc_ravenscar_ops::store_registers): Now methods.
14397         (sparc_ravenscar_prepare_to_store): Remove.
14398         (sparc_ravenscar_ops): Redefine.
14399         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14400         methods and destructor.  Remove members.
14401         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14402         (ravenscar_thread_target::store_registers)
14403         (ravenscar_thread_target::prepare_to_store): Update.
14404         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14405         Remove.
14406         (struct ppc_ravenscar_powerpc_ops): Derive from
14407         ravenscar_arch_ops.
14408         (ppc_ravenscar_powerpc_ops::fetch_registers)
14409         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14410         (ppc_ravenscar_powerpc_ops): Redefine.
14411         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14412         (ppc_ravenscar_e500_ops::fetch_registers)
14413         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14414         (ppc_ravenscar_e500_ops): Redefine.
14415         * aarch64-ravenscar-thread.c
14416         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14417         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14418         (aarch64_ravenscar_fetch_registers)
14419         (aarch64_ravenscar_store_registers): Now methods.
14420         (aarch64_ravenscar_ops): Redefine.
14421
14422 2019-02-15  Tom Tromey  <tromey@adacore.com>
14423
14424         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14425         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14426         (ravenscar_thread_target::stopped_by_watchpoint)
14427         (ravenscar_thread_target::stopped_data_address)
14428         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14429
14430 2019-02-15  Tom Tromey  <tromey@adacore.com>
14431
14432         * ravenscar-thread.c: Fix some typos.
14433
14434 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14435             Tom Tromey  <tromey@adacore.com>
14436
14437         * ada-lang.c (ada_exception_sal): Change addr_string to a
14438         std::string.
14439         (create_ada_exception_catchpoint): Update.
14440
14441 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14442             Tom Tromey  <tromey@adacore.com>
14443
14444         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14445         (bp_location_ops): Remove.
14446         (base_breakpoint_allocate_location): Update.
14447         (free_bp_location): Update.
14448         * ada-lang.c (class ada_catchpoint_location)
14449         <ada_catchpoint_location>: Remove ops parameter.
14450         (ada_catchpoint_location_dtor): Remove.
14451         (ada_catchpoint_location_ops): Remove.
14452         (allocate_location_exception): Update.
14453         * breakpoint.h (struct bp_location_ops): Remove.
14454         (class bp_location) <bp_location>: Remove bp_location_ops
14455         parameter.
14456         <~bp_location>: Add destructor.
14457         <ops>: Remove.
14458
14459 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14460             Pedro Alves  <palves@redhat.com>
14461
14462         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14463         'PATH_MAX'.
14464
14465 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14466             Samuel Thibault  <samuel.thibault@gnu.org>
14467             Thomas Schwinge  <thomas@codesourcery.com>
14468
14469         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14470         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14471
14472 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14473
14474         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14475         (check_empty): Use "const char *".
14476
14477         * gnu-nat.c (gnu_nat_target::detach): Instead of
14478         'detach_inferior (pid)' call
14479         'detach_inferior (find_inferior_pid (pid))'.
14480
14481         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14482         'nat/fork-inferior.o'.
14483         * gnu-nat.c: #include "nat/fork-inferior.h".
14484
14485         * gnu-nat.c (gnu_nat_target::detach): Instead of
14486         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14487         * gnu-nat.h: #include "inf-child.h".
14488         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14489         'i386_gnu_nat_target::fetch_registers'.
14490         (gnu_store_registers): Rename/move to
14491         'i386_gnu_nat_target::store_registers'.
14492
14493         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14494         * gnu-nat.h (mach_thread_info): New function.
14495         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14496
14497         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14498
14499 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14500
14501         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14502
14503 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14504
14505         * windows-nat.c (windows_add_thread): Add new parameter
14506         "main_thread_p" with default value set to false.  Update
14507         function documentation as well as all callers.
14508         (windows_delete_thread): Likewise.
14509         (fake_create_process): Update call to windows_add_thread.
14510         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14511         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14512         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14513         call to windows_delete_thread.
14514
14515 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14516
14517         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14518
14519 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14520
14521         * symfile.c (find_separate_debug_file): Use canonical path of
14522         sysroot with child_path instead of gdb_sysroot if it is valid.
14523
14524 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14525
14526         * symfile.c (find_separate_debug_file): Use child_path to
14527         determine if an object file is under a sysroot.
14528
14529 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14530
14531         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14532         unittests/child-path-selftests.c.
14533         * common/pathstuff.c (child_path): New function.
14534         * common/pathstuff.h (child_path): New prototype.
14535         * unittests/child-path-selftests.c: New file.
14536
14537 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14538
14539         * symfile.c (find_separate_debug_file): Look for separate debug
14540         files in debug directories under the sysroot.
14541
14542 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14543
14544         * symtab.h (struct minimal_symbol data_p): New const method.
14545         (struct minimal_symbol text_p): Likewise.
14546         * symtab.c (output_source_filename): Use file name style
14547         to print file name.
14548         (print_symbol_info): Likewise.
14549         (print_msymbol_info): Use address style to print addresses.
14550         Use function name style to print executable text symbols.
14551         (expand_symtab_containing_pc): Use data_p.
14552         (find_pc_sect_compunit_symtab): Likewise.
14553
14554 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14555
14556         * breakpoint.c (describe_other_breakpoints): Use address style
14557         to print addresses.
14558         (say_where): Likewise.
14559
14560 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14561
14562         * ada-typeprint.c (print_func_type): Print function name
14563         style to print function name.
14564         * c-typeprint.c (c_print_type_1): Likewise.
14565
14566 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14567
14568         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14569         for execve.
14570
14571 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14572
14573         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14574         type_stack.
14575
14576 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14577
14578         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14579         TYPE_CODE_REF types.
14580
14581 2019-02-08  Jim Wilson  <jimw@sifive.com>
14582
14583         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14584         (riscv_linux_fregset): New.
14585         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14586
14587 2019-02-07  Tom Tromey  <tom@tromey.com>
14588
14589         * thread.c (thread_cancel_execution_command): Update.
14590         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14591         methods.
14592         (struct thread_fsm_ops): Remove.
14593         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14594         (thread_fsm_should_stop, thread_fsm_return_value)
14595         (thread_fsm_set_finished, thread_fsm_finished_p)
14596         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14597         Don't declare.
14598         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14599         * infrun.c (clear_proceed_status_thread)
14600         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14601         (print_stop_event): Update.
14602         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14603         Add constructor.
14604         (step_command_fsm_ops): Remove.
14605         (new_step_command_fsm): Remove.
14606         (step_1): Update.
14607         (step_command_fsm::should_stop): Rename from
14608         step_command_fsm_should_stop.
14609         (step_command_fsm::clean_up): Rename from
14610         step_command_fsm_clean_up.
14611         (step_command_fsm::do_async_reply_reason): Rename from
14612         step_command_fsm_async_reply_reason.
14613         (struct until_next_fsm): Inherit from thread_fsm.  Add
14614         constructor.
14615         (until_next_fsm_ops): Remove.
14616         (new_until_next_fsm): Remove.
14617         (until_next_fsm::should_stop): Rename from
14618         until_next_fsm_should_stop.
14619         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14620         (until_next_fsm::do_async_reply_reason): Rename from
14621         until_next_fsm_async_reply_reason.
14622         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14623         constructor.  Change type of breakpoint.
14624         (finish_command_fsm_ops): Remove.
14625         (new_finish_command_fsm): Remove.
14626         (finish_command_fsm::should_stop): Rename from
14627         finish_command_fsm_should_stop.
14628         (finish_command_fsm::clean_up): Rename from
14629         finish_command_fsm_clean_up.
14630         (finish_command_fsm::return_value): Rename from
14631         finish_command_fsm_return_value.
14632         (finish_command_fsm::do_async_reply_reason): Rename from
14633         finish_command_fsm_async_reply_reason.
14634         (finish_command): Update.
14635         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14636         Add constructor.
14637         (call_thread_fsm_ops): Remove.
14638         (call_thread_fsm::call_thread_fsm): Rename from
14639         new_call_thread_fsm.
14640         (call_thread_fsm::should_stop): Rename from
14641         call_thread_fsm_should_stop.
14642         (call_thread_fsm::should_notify_stop): Rename from
14643         call_thread_fsm_should_notify_stop.
14644         (run_inferior_call, call_function_by_hand_dummy): Update.
14645         * cli/cli-interp.c (should_print_stop_to_console): Update.
14646         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14647         Add constructor.  Change type of location_breakpoint,
14648         caller_breakpoint.
14649         (until_break_fsm_ops): Remove.
14650         (new_until_break_fsm): Remove.
14651         (until_break_fsm::should_stop): Rename from
14652         until_break_fsm_should_stop.
14653         (until_break_fsm::clean_up): Rename from
14654         until_break_fsm_clean_up.
14655         (until_break_fsm::do_async_reply_reason): Rename from
14656         until_break_fsm_async_reply_reason.
14657         (until_break_command): Update.
14658         * thread-fsm.c: Remove.
14659         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14660
14661 2019-02-07  Tom Tromey  <tom@tromey.com>
14662
14663         * yy-remap.h: Add include guard.
14664         * xtensa-tdep.h: Add include guard.
14665         * xcoffread.h: Rename include guard.
14666         * varobj-iter.h: Add include guard.
14667         * tui/tui.h: Rename include guard.
14668         * tui/tui-winsource.h: Rename include guard.
14669         * tui/tui-wingeneral.h: Rename include guard.
14670         * tui/tui-windata.h: Rename include guard.
14671         * tui/tui-win.h: Rename include guard.
14672         * tui/tui-stack.h: Rename include guard.
14673         * tui/tui-source.h: Rename include guard.
14674         * tui/tui-regs.h: Rename include guard.
14675         * tui/tui-out.h: Rename include guard.
14676         * tui/tui-layout.h: Rename include guard.
14677         * tui/tui-io.h: Rename include guard.
14678         * tui/tui-hooks.h: Rename include guard.
14679         * tui/tui-file.h: Rename include guard.
14680         * tui/tui-disasm.h: Rename include guard.
14681         * tui/tui-data.h: Rename include guard.
14682         * tui/tui-command.h: Rename include guard.
14683         * tic6x-tdep.h: Add include guard.
14684         * target/waitstatus.h: Rename include guard.
14685         * target/wait.h: Rename include guard.
14686         * target/target.h: Rename include guard.
14687         * target/resume.h: Rename include guard.
14688         * target-float.h: Rename include guard.
14689         * stabsread.h: Add include guard.
14690         * rs6000-tdep.h: Add include guard.
14691         * riscv-fbsd-tdep.h: Add include guard.
14692         * regformats/regdef.h: Rename include guard.
14693         * record.h: Rename include guard.
14694         * python/python.h: Rename include guard.
14695         * python/python-internal.h: Rename include guard.
14696         * python/py-stopevent.h: Rename include guard.
14697         * python/py-ref.h: Rename include guard.
14698         * python/py-record.h: Rename include guard.
14699         * python/py-record-full.h: Rename include guard.
14700         * python/py-record-btrace.h: Rename include guard.
14701         * python/py-instruction.h: Rename include guard.
14702         * python/py-events.h: Rename include guard.
14703         * python/py-event.h: Rename include guard.
14704         * procfs.h: Add include guard.
14705         * proc-utils.h: Add include guard.
14706         * p-lang.h: Add include guard.
14707         * or1k-tdep.h: Rename include guard.
14708         * observable.h: Rename include guard.
14709         * nto-tdep.h: Rename include guard.
14710         * nat/x86-linux.h: Rename include guard.
14711         * nat/x86-linux-dregs.h: Rename include guard.
14712         * nat/x86-gcc-cpuid.h: Add include guard.
14713         * nat/x86-dregs.h: Rename include guard.
14714         * nat/x86-cpuid.h: Rename include guard.
14715         * nat/ppc-linux.h: Rename include guard.
14716         * nat/mips-linux-watch.h: Rename include guard.
14717         * nat/linux-waitpid.h: Rename include guard.
14718         * nat/linux-ptrace.h: Rename include guard.
14719         * nat/linux-procfs.h: Rename include guard.
14720         * nat/linux-osdata.h: Rename include guard.
14721         * nat/linux-nat.h: Rename include guard.
14722         * nat/linux-namespaces.h: Rename include guard.
14723         * nat/linux-btrace.h: Rename include guard.
14724         * nat/glibc_thread_db.h: Rename include guard.
14725         * nat/gdb_thread_db.h: Rename include guard.
14726         * nat/gdb_ptrace.h: Rename include guard.
14727         * nat/fork-inferior.h: Rename include guard.
14728         * nat/amd64-linux-siginfo.h: Rename include guard.
14729         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14730         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14731         * nat/aarch64-linux.h: Rename include guard.
14732         * nat/aarch64-linux-hw-point.h: Rename include guard.
14733         * mn10300-tdep.h: Add include guard.
14734         * mips-linux-tdep.h: Add include guard.
14735         * mi/mi-parse.h: Rename include guard.
14736         * mi/mi-out.h: Rename include guard.
14737         * mi/mi-main.h: Rename include guard.
14738         * mi/mi-interp.h: Rename include guard.
14739         * mi/mi-getopt.h: Rename include guard.
14740         * mi/mi-console.h: Rename include guard.
14741         * mi/mi-common.h: Rename include guard.
14742         * mi/mi-cmds.h: Rename include guard.
14743         * mi/mi-cmd-break.h: Rename include guard.
14744         * m2-lang.h: Add include guard.
14745         * location.h: Rename include guard.
14746         * linux-record.h: Rename include guard.
14747         * linux-nat.h: Add include guard.
14748         * linux-fork.h: Add include guard.
14749         * i386-darwin-tdep.h: Rename include guard.
14750         * hppa-linux-offsets.h: Add include guard.
14751         * guile/guile.h: Rename include guard.
14752         * guile/guile-internal.h: Rename include guard.
14753         * gnu-nat.h: Rename include guard.
14754         * gdb-stabs.h: Rename include guard.
14755         * frv-tdep.h: Add include guard.
14756         * f-lang.h: Add include guard.
14757         * event-loop.h: Add include guard.
14758         * darwin-nat.h: Rename include guard.
14759         * cp-abi.h: Rename include guard.
14760         * config/sparc/nm-sol2.h: Rename include guard.
14761         * config/nm-nto.h: Rename include guard.
14762         * config/nm-linux.h: Add include guard.
14763         * config/i386/nm-i386gnu.h: Rename include guard.
14764         * config/djgpp/nl_types.h: Rename include guard.
14765         * config/djgpp/langinfo.h: Rename include guard.
14766         * compile/gcc-cp-plugin.h: Add include guard.
14767         * compile/gcc-c-plugin.h: Add include guard.
14768         * compile/compile.h: Rename include guard.
14769         * compile/compile-object-run.h: Rename include guard.
14770         * compile/compile-object-load.h: Rename include guard.
14771         * compile/compile-internal.h: Rename include guard.
14772         * compile/compile-cplus.h: Rename include guard.
14773         * compile/compile-c.h: Rename include guard.
14774         * common/xml-utils.h: Rename include guard.
14775         * common/x86-xstate.h: Rename include guard.
14776         * common/version.h: Rename include guard.
14777         * common/vec.h: Rename include guard.
14778         * common/tdesc.h: Rename include guard.
14779         * common/selftest.h: Rename include guard.
14780         * common/scoped_restore.h: Rename include guard.
14781         * common/scoped_mmap.h: Rename include guard.
14782         * common/scoped_fd.h: Rename include guard.
14783         * common/safe-iterator.h: Rename include guard.
14784         * common/run-time-clock.h: Rename include guard.
14785         * common/refcounted-object.h: Rename include guard.
14786         * common/queue.h: Rename include guard.
14787         * common/ptid.h: Rename include guard.
14788         * common/print-utils.h: Rename include guard.
14789         * common/preprocessor.h: Rename include guard.
14790         * common/pathstuff.h: Rename include guard.
14791         * common/observable.h: Rename include guard.
14792         * common/netstuff.h: Rename include guard.
14793         * common/job-control.h: Rename include guard.
14794         * common/host-defs.h: Rename include guard.
14795         * common/gdb_wait.h: Rename include guard.
14796         * common/gdb_vecs.h: Rename include guard.
14797         * common/gdb_unlinker.h: Rename include guard.
14798         * common/gdb_unique_ptr.h: Rename include guard.
14799         * common/gdb_tilde_expand.h: Rename include guard.
14800         * common/gdb_sys_time.h: Rename include guard.
14801         * common/gdb_string_view.h: Rename include guard.
14802         * common/gdb_splay_tree.h: Rename include guard.
14803         * common/gdb_setjmp.h: Rename include guard.
14804         * common/gdb_ref_ptr.h: Rename include guard.
14805         * common/gdb_optional.h: Rename include guard.
14806         * common/gdb_locale.h: Rename include guard.
14807         * common/gdb_assert.h: Rename include guard.
14808         * common/filtered-iterator.h: Rename include guard.
14809         * common/filestuff.h: Rename include guard.
14810         * common/fileio.h: Rename include guard.
14811         * common/environ.h: Rename include guard.
14812         * common/common-utils.h: Rename include guard.
14813         * common/common-types.h: Rename include guard.
14814         * common/common-regcache.h: Rename include guard.
14815         * common/common-inferior.h: Rename include guard.
14816         * common/common-gdbthread.h: Rename include guard.
14817         * common/common-exceptions.h: Rename include guard.
14818         * common/common-defs.h: Rename include guard.
14819         * common/common-debug.h: Rename include guard.
14820         * common/cleanups.h: Rename include guard.
14821         * common/buffer.h: Rename include guard.
14822         * common/btrace-common.h: Rename include guard.
14823         * common/break-common.h: Rename include guard.
14824         * cli/cli-utils.h: Rename include guard.
14825         * cli/cli-style.h: Rename include guard.
14826         * cli/cli-setshow.h: Rename include guard.
14827         * cli/cli-script.h: Rename include guard.
14828         * cli/cli-interp.h: Rename include guard.
14829         * cli/cli-decode.h: Rename include guard.
14830         * cli/cli-cmds.h: Rename include guard.
14831         * charset-list.h: Add include guard.
14832         * buildsym-legacy.h: Rename include guard.
14833         * bfin-tdep.h: Add include guard.
14834         * ax.h: Rename include guard.
14835         * arm-linux-tdep.h: Add include guard.
14836         * arm-fbsd-tdep.h: Add include guard.
14837         * arch/xtensa.h: Rename include guard.
14838         * arch/tic6x.h: Add include guard.
14839         * arch/i386.h: Add include guard.
14840         * arch/arm.h: Rename include guard.
14841         * arch/arm-linux.h: Rename include guard.
14842         * arch/arm-get-next-pcs.h: Rename include guard.
14843         * arch/amd64.h: Add include guard.
14844         * arch/aarch64-insn.h: Rename include guard.
14845         * arch-utils.h: Rename include guard.
14846         * annotate.h: Add include guard.
14847         * amd64-darwin-tdep.h: Rename include guard.
14848         * aarch64-linux-tdep.h: Add include guard.
14849         * aarch64-fbsd-tdep.h: Add include guard.
14850         * aarch32-linux-nat.h: Add include guard.
14851
14852 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14853
14854         * macrotab.c (macro_define_internal): New function that
14855         factorizes macro_define_object_internal and macro_define_function
14856         code.
14857         (macro_define_object_internal): Use macro_define_internal.
14858         (macro_define_function): Likewise.
14859
14860 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14861
14862         * macrocmd.c (extract_identifier): Return
14863         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14864         callers.
14865
14866 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14867
14868         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14869
14870 2019-02-05  Tom Tromey  <tom@tromey.com>
14871
14872         * target.c (target_stack::unpush): Move assertion earlier.
14873
14874 2019-01-30  Tom Tromey  <tom@tromey.com>
14875
14876         PR python/23615:
14877         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14878         (gdbpy_parse_and_eval): Likewise.
14879         * python/python-internal.h (gdbpy_allow_threads): New class.
14880
14881 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14882
14883         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14884         (aarch64_fbsd_fpregmap): Move earlier.
14885         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14886         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14887         instead of individual calls to trad_frame_set_reg_addr.
14888         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14889         earlier.
14890         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14891         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14892         instead of individual calls to trad_frame_set_reg_addr.
14893
14894 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14895
14896         * CONTRIBUTE: Replace contribution list with wiki link.
14897
14898 2019-01-25  Tom Tromey  <tom@tromey.com>
14899
14900         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14901
14902 2019-01-25  Tom Tromey  <tom@tromey.com>
14903
14904         * xtensa-linux-nat.c: Fix common/ includes.
14905         * xml-support.h: Fix common/ includes.
14906         * xml-support.c: Fix common/ includes.
14907         * x86-linux-nat.c: Fix common/ includes.
14908         * windows-nat.c: Fix common/ includes.
14909         * varobj.h: Fix common/ includes.
14910         * varobj.c: Fix common/ includes.
14911         * value.c: Fix common/ includes.
14912         * valops.c: Fix common/ includes.
14913         * utils.c: Fix common/ includes.
14914         * unittests/xml-utils-selftests.c: Fix common/ includes.
14915         * unittests/utils-selftests.c: Fix common/ includes.
14916         * unittests/unpack-selftests.c: Fix common/ includes.
14917         * unittests/tracepoint-selftests.c: Fix common/ includes.
14918         * unittests/style-selftests.c: Fix common/ includes.
14919         * unittests/string_view-selftests.c: Fix common/ includes.
14920         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14921         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14922         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14923         * unittests/rsp-low-selftests.c: Fix common/ includes.
14924         * unittests/parse-connection-spec-selftests.c: Fix common/
14925         includes.
14926         * unittests/optional-selftests.c: Fix common/ includes.
14927         * unittests/offset-type-selftests.c: Fix common/ includes.
14928         * unittests/observable-selftests.c: Fix common/ includes.
14929         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14930         * unittests/memrange-selftests.c: Fix common/ includes.
14931         * unittests/memory-map-selftests.c: Fix common/ includes.
14932         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14933         * unittests/function-view-selftests.c: Fix common/ includes.
14934         * unittests/environ-selftests.c: Fix common/ includes.
14935         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14936         * unittests/common-utils-selftests.c: Fix common/ includes.
14937         * unittests/cli-utils-selftests.c: Fix common/ includes.
14938         * unittests/array-view-selftests.c: Fix common/ includes.
14939         * ui-file.c: Fix common/ includes.
14940         * tui/tui-io.c: Fix common/ includes.
14941         * tracepoint.h: Fix common/ includes.
14942         * tracepoint.c: Fix common/ includes.
14943         * tracefile-tfile.c: Fix common/ includes.
14944         * top.h: Fix common/ includes.
14945         * top.c: Fix common/ includes.
14946         * thread.c: Fix common/ includes.
14947         * target/waitstatus.h: Fix common/ includes.
14948         * target/waitstatus.c: Fix common/ includes.
14949         * target.h: Fix common/ includes.
14950         * target.c: Fix common/ includes.
14951         * target-memory.c: Fix common/ includes.
14952         * target-descriptions.c: Fix common/ includes.
14953         * symtab.h: Fix common/ includes.
14954         * symfile.c: Fix common/ includes.
14955         * stap-probe.c: Fix common/ includes.
14956         * spu-linux-nat.c: Fix common/ includes.
14957         * sparc-nat.c: Fix common/ includes.
14958         * source.c: Fix common/ includes.
14959         * solib.c: Fix common/ includes.
14960         * solib-target.c: Fix common/ includes.
14961         * ser-unix.c: Fix common/ includes.
14962         * ser-tcp.c: Fix common/ includes.
14963         * ser-pipe.c: Fix common/ includes.
14964         * ser-base.c: Fix common/ includes.
14965         * selftest-arch.c: Fix common/ includes.
14966         * s12z-tdep.c: Fix common/ includes.
14967         * rust-exp.y: Fix common/ includes.
14968         * rs6000-aix-tdep.c: Fix common/ includes.
14969         * riscv-tdep.c: Fix common/ includes.
14970         * remote.c: Fix common/ includes.
14971         * remote-notif.h: Fix common/ includes.
14972         * remote-fileio.h: Fix common/ includes.
14973         * remote-fileio.c: Fix common/ includes.
14974         * regcache.h: Fix common/ includes.
14975         * regcache.c: Fix common/ includes.
14976         * record-btrace.c: Fix common/ includes.
14977         * python/python.c: Fix common/ includes.
14978         * python/py-type.c: Fix common/ includes.
14979         * python/py-inferior.c: Fix common/ includes.
14980         * progspace.h: Fix common/ includes.
14981         * producer.c: Fix common/ includes.
14982         * procfs.c: Fix common/ includes.
14983         * proc-api.c: Fix common/ includes.
14984         * printcmd.c: Fix common/ includes.
14985         * ppc-linux-nat.c: Fix common/ includes.
14986         * parser-defs.h: Fix common/ includes.
14987         * osdata.c: Fix common/ includes.
14988         * obsd-nat.c: Fix common/ includes.
14989         * nat/x86-linux.c: Fix common/ includes.
14990         * nat/x86-linux-dregs.c: Fix common/ includes.
14991         * nat/x86-dregs.h: Fix common/ includes.
14992         * nat/x86-dregs.c: Fix common/ includes.
14993         * nat/ppc-linux.c: Fix common/ includes.
14994         * nat/mips-linux-watch.h: Fix common/ includes.
14995         * nat/mips-linux-watch.c: Fix common/ includes.
14996         * nat/linux-waitpid.c: Fix common/ includes.
14997         * nat/linux-ptrace.h: Fix common/ includes.
14998         * nat/linux-ptrace.c: Fix common/ includes.
14999         * nat/linux-procfs.c: Fix common/ includes.
15000         * nat/linux-personality.c: Fix common/ includes.
15001         * nat/linux-osdata.c: Fix common/ includes.
15002         * nat/linux-namespaces.c: Fix common/ includes.
15003         * nat/linux-btrace.h: Fix common/ includes.
15004         * nat/linux-btrace.c: Fix common/ includes.
15005         * nat/fork-inferior.c: Fix common/ includes.
15006         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15007         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15008         * nat/aarch64-linux.c: Fix common/ includes.
15009         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15010         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15011         * namespace.h: Fix common/ includes.
15012         * mips-linux-tdep.c: Fix common/ includes.
15013         * minsyms.c: Fix common/ includes.
15014         * mi/mi-parse.h: Fix common/ includes.
15015         * mi/mi-main.c: Fix common/ includes.
15016         * mi/mi-cmd-env.c: Fix common/ includes.
15017         * memrange.h: Fix common/ includes.
15018         * memattr.c: Fix common/ includes.
15019         * maint.h: Fix common/ includes.
15020         * maint.c: Fix common/ includes.
15021         * main.c: Fix common/ includes.
15022         * machoread.c: Fix common/ includes.
15023         * location.c: Fix common/ includes.
15024         * linux-thread-db.c: Fix common/ includes.
15025         * linux-nat.c: Fix common/ includes.
15026         * linux-fork.c: Fix common/ includes.
15027         * inline-frame.c: Fix common/ includes.
15028         * infrun.c: Fix common/ includes.
15029         * inflow.c: Fix common/ includes.
15030         * inferior.h: Fix common/ includes.
15031         * inferior.c: Fix common/ includes.
15032         * infcmd.c: Fix common/ includes.
15033         * inf-ptrace.c: Fix common/ includes.
15034         * inf-child.c: Fix common/ includes.
15035         * ia64-linux-nat.c: Fix common/ includes.
15036         * i387-tdep.c: Fix common/ includes.
15037         * i386-tdep.c: Fix common/ includes.
15038         * i386-linux-tdep.c: Fix common/ includes.
15039         * i386-linux-nat.c: Fix common/ includes.
15040         * i386-go32-tdep.c: Fix common/ includes.
15041         * i386-fbsd-tdep.c: Fix common/ includes.
15042         * i386-fbsd-nat.c: Fix common/ includes.
15043         * guile/scm-type.c: Fix common/ includes.
15044         * guile/guile.c: Fix common/ includes.
15045         * go32-nat.c: Fix common/ includes.
15046         * gnu-nat.c: Fix common/ includes.
15047         * gdbthread.h: Fix common/ includes.
15048         * gdbarch-selftests.c: Fix common/ includes.
15049         * gdb_usleep.c: Fix common/ includes.
15050         * gdb_select.h: Fix common/ includes.
15051         * gdb_bfd.c: Fix common/ includes.
15052         * gcore.c: Fix common/ includes.
15053         * fork-child.c: Fix common/ includes.
15054         * findvar.c: Fix common/ includes.
15055         * fbsd-nat.c: Fix common/ includes.
15056         * event-top.c: Fix common/ includes.
15057         * event-loop.c: Fix common/ includes.
15058         * dwarf2read.c: Fix common/ includes.
15059         * dwarf2loc.c: Fix common/ includes.
15060         * dwarf2-frame.c: Fix common/ includes.
15061         * dwarf-index-cache.c: Fix common/ includes.
15062         * dtrace-probe.c: Fix common/ includes.
15063         * disasm-selftests.c: Fix common/ includes.
15064         * defs.h: Fix common/ includes.
15065         * csky-tdep.c: Fix common/ includes.
15066         * cp-valprint.c: Fix common/ includes.
15067         * cp-support.h: Fix common/ includes.
15068         * cp-support.c: Fix common/ includes.
15069         * corelow.c: Fix common/ includes.
15070         * completer.h: Fix common/ includes.
15071         * completer.c: Fix common/ includes.
15072         * compile/compile.c: Fix common/ includes.
15073         * compile/compile-loc2c.c: Fix common/ includes.
15074         * compile/compile-cplus-types.c: Fix common/ includes.
15075         * compile/compile-cplus-symbols.c: Fix common/ includes.
15076         * command.h: Fix common/ includes.
15077         * cli/cli-dump.c: Fix common/ includes.
15078         * cli/cli-cmds.c: Fix common/ includes.
15079         * charset.c: Fix common/ includes.
15080         * build-id.c: Fix common/ includes.
15081         * btrace.h: Fix common/ includes.
15082         * btrace.c: Fix common/ includes.
15083         * breakpoint.h: Fix common/ includes.
15084         * breakpoint.c: Fix common/ includes.
15085         * ax.h:
15086         (enum agent_op): Fix common/ includes.
15087         * ax-general.c (struct aop_map): Fix common/ includes.
15088         * ax-gdb.c: Fix common/ includes.
15089         * auxv.c: Fix common/ includes.
15090         * auto-load.c: Fix common/ includes.
15091         * arm-tdep.c: Fix common/ includes.
15092         * arch/riscv.c: Fix common/ includes.
15093         * arch/ppc-linux-common.c: Fix common/ includes.
15094         * arch/i386.c: Fix common/ includes.
15095         * arch/arm.c: Fix common/ includes.
15096         * arch/arm-linux.c: Fix common/ includes.
15097         * arch/arm-get-next-pcs.c: Fix common/ includes.
15098         * arch/amd64.c: Fix common/ includes.
15099         * arch/aarch64.c: Fix common/ includes.
15100         * arch/aarch64-insn.c: Fix common/ includes.
15101         * arch-utils.c: Fix common/ includes.
15102         * amd64-windows-tdep.c: Fix common/ includes.
15103         * amd64-tdep.c: Fix common/ includes.
15104         * amd64-sol2-tdep.c: Fix common/ includes.
15105         * amd64-obsd-tdep.c: Fix common/ includes.
15106         * amd64-nbsd-tdep.c: Fix common/ includes.
15107         * amd64-linux-tdep.c: Fix common/ includes.
15108         * amd64-linux-nat.c: Fix common/ includes.
15109         * amd64-fbsd-tdep.c: Fix common/ includes.
15110         * amd64-fbsd-nat.c: Fix common/ includes.
15111         * amd64-dicos-tdep.c: Fix common/ includes.
15112         * amd64-darwin-tdep.c: Fix common/ includes.
15113         * agent.c: Fix common/ includes.
15114         * ada-lang.h: Fix common/ includes.
15115         * ada-lang.c: Fix common/ includes.
15116         * aarch64-tdep.c: Fix common/ includes.
15117
15118 2019-01-25  Tom Tromey  <tom@tromey.com>
15119
15120         * common/create-version.sh: Use common/version.h.
15121
15122 2019-01-24  Pedro Alves  <palves@redhat.com>
15123
15124         * infrun.c (signal_stop, signal_print, signal_program)
15125         (signal_catch, signal_pass): Now arrays instead of pointers.
15126         (update_signals_program_target, do_target_resume)
15127         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15128         * linux-nat.c (linux_nat_target::pass_signals)
15129         (linux_nat_target::create_inferior, linux_nat_target::attach):
15130         Adjust.
15131         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15132         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15133         * procfs.c (procfs_target::pass_signals): Adjust.
15134         * record-full.c (record_full_target::resume): Adjust.
15135         * remote.c (remote_target::pass_signals)
15136         (remote_target::program_signals): Adjust.
15137         * target-debug.h (target_debug_print_signals): Now takes a
15138         gdb::array_view as parameter.  Adjust.
15139         * target.h (target_ops) <pass_signals, program_signals>: Replace
15140         pointer and length parameters with gdb::array_view.
15141         (target_pass_signals, target_program_signals): Likewise.
15142         * target-delegates.c: Regenerate.
15143
15144 2019-01-24  Pedro Alves  <palves@redhat.com>
15145
15146         * common/forward-scope-exit.h
15147         (forward_scope_exit::forward_scope_exit): Pass arguments to
15148         m_bind_function directly, instead of creating a std::bind and
15149         copying that.
15150
15151 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15152
15153         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15154         for static members.
15155         (pass_in_v_vfp_candidate): Likewise.
15156
15157 2019-01-23  Tom Tromey  <tom@tromey.com>
15158             Pedro Alves  <palves@redhat.com>
15159
15160         * regcache.c (class regcache_invalidator): Remove.
15161         (regcache::raw_write): Use make_scope_exit.
15162
15163 2019-01-23  Tom Tromey  <tom@tromey.com>
15164
15165         * ui-out.h (class ui_out_emit_type): Update comment.
15166
15167 2019-01-23  Tom Tromey  <tom@tromey.com>
15168
15169         * infrun.c (fetch_inferior_event): Update comment.
15170
15171 2019-01-23  Tom Tromey  <tom@tromey.com>
15172             Pedro Alves  <palves@redhat.com>
15173
15174         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15175         parameter.
15176         (fetch_inferior_event): Use SCOPE_EXIT.
15177
15178
15179 2019-01-23  Tom Tromey  <tom@tromey.com>
15180             Pedro Alves  <palves@redhat.com>
15181
15182         * infrun.c (disable_thread_events): Delete.
15183         (stop_all_threads): Use SCOPE_EXIT.
15184
15185 2019-01-23  Tom Tromey  <tom@tromey.com>
15186             Pedro Alves  <palves@redhat.com>
15187
15188         * symfile.c: Include forward-scope-exit.h.
15189         (clear_symtab_users_cleanup): Replace forward declaration with
15190         a FORWARD_SCOPE_EXIT.
15191         (syms_from_objfile_1): Use the forward_scope_exit and
15192         gdb::optional instead of cleanup_function.
15193         (reread_symbols): Use the forward_scope_exit instead of
15194         cleanup_function.
15195         (clear_symtab_users_cleanup): Remove function.
15196
15197 2019-01-23  Tom Tromey  <tom@tromey.com>
15198             Pedro Alves  <palves@redhat.com>
15199
15200         * linux-nat.c: Include scope-exit.h.
15201         (cleanup_target_stop): Remove.
15202         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15203         SCOPE_EXIT.
15204
15205 2019-01-23  Tom Tromey  <tom@tromey.com>
15206             Pedro Alves  <palves@redhat.com>
15207
15208         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15209         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15210
15211 2019-01-23  Tom Tromey  <tom@tromey.com>
15212             Andrew Burgess  <andrew.burgess@embecosm.com>
15213             Pedro Alves  <palves@redhat.com>
15214
15215         * infrun.c (fetch_inferior_event): Use scope_exit.
15216         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15217         * top.c (execute_command): Use scope_exit.
15218         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15219         * utils.c (do_bpstat_clear_actions_cleanup)
15220         (make_bpstat_clear_actions_cleanup): Remove.
15221
15222 2019-01-23  Tom Tromey  <tom@tromey.com>
15223             Pedro Alves  <palves@redhat.com>
15224
15225         * infrun.c: Include "common/scope-exit.h"
15226         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15227         (wait_for_inferior): Use SCOPE_EXIT.
15228         (fetch_inferior_event): Use scope_exit.
15229
15230 2019-01-23  Tom Tromey  <tom@tromey.com>
15231             Pedro Alves  <palves@redhat.com>
15232
15233         * breakpoint.c (create_breakpoint): Remove cleanup.
15234
15235 2019-01-23  Tom Tromey  <tom@tromey.com>
15236             Andrew Burgess  <andrew.burgess@embecosm.com>
15237             Pedro Alves  <palves@redhat.com>
15238
15239 2019-01-23  Pedro Alves  <palves@redhat.com>
15240
15241         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15242
15243 2019-01-23  Pedro Alves  <palves@redhat.com>
15244             Andrew Burgess  <andrew.burgess@embecosm.com>
15245
15246         * gdbthread.h: Include "common/forward-scope-exit.h".
15247         (scoped_finish_thread_state): Redefine custom class in terms of
15248         forward_scope_exit.
15249
15250 2019-01-23  Pedro Alves  <palves@redhat.com>
15251             Andrew Burgess  <andrew.burgess@embecosm.com>
15252
15253         * common/forward-scope-exit.h: New file.
15254
15255 2019-01-23  Pedro Alves  <palves@redhat.com>
15256             Andrew Burgess  <andrew.burgess@embecosm.com>
15257             Tom Tromey  <tom@tromey.com>
15258
15259         * common/scope-exit.h: New file.
15260
15261 2019-01-23  Pedro Alves  <palves@redhat.com>
15262
15263         * common/preprocessor.h (ESC): Rename to ...
15264         (ESC_PARENS): ... this.
15265         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15266         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15267
15268 2019-01-23  Tom Tromey  <tom@tromey.com>
15269
15270         * language.h (class scoped_switch_to_sym_language_if_auto):
15271         Initialize m_lang in both cases.
15272
15273 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15274
15275         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15276         with XCNEW.
15277
15278 2019-01-22  Tom Tromey  <tom@tromey.com>
15279
15280         * corelow.c: Do not include sys/file.h.
15281
15282 2019-01-22  Tom Tromey  <tom@tromey.com>
15283
15284         * tui/tui-wingeneral.h: Include gdb_curses.h.
15285
15286 2019-01-22  Tom Tromey  <tom@tromey.com>
15287
15288         * source-cache.h (class source_cache) <get_source_lines,
15289         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15290
15291 2019-01-22  Tom Tromey  <tom@tromey.com>
15292
15293         * remote-fileio.h (struct remote_target): Declare.
15294
15295 2019-01-22  Tom Tromey  <tom@tromey.com>
15296
15297         * python/py-arch.c: Do not include py-ref.h.
15298         * python/py-bpevent.c: Do not include py-ref.h.
15299         * python/py-cmd.c: Do not include py-ref.h.
15300         * python/py-continueevent.c: Do not include py-ref.h.
15301         * python/py-event.h: Do not include py-ref.h.
15302         * python/py-evtregistry.c: Do not include py-ref.h.
15303         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15304         * python/py-frame.c: Do not include py-ref.h.
15305         * python/py-framefilter.c: Do not include py-ref.h.
15306         * python/py-function.c: Do not include py-ref.h.
15307         * python/py-infevents.c: Do not include py-ref.h.
15308         * python/py-linetable.c: Do not include py-ref.h.
15309         * python/py-objfile.c: Do not include py-ref.h.
15310         * python/py-param.c: Do not include py-ref.h.
15311         * python/py-prettyprint.c: Do not include py-ref.h.
15312         * python/py-progspace.c: Do not include py-ref.h.
15313         * python/py-symbol.c: Do not include py-ref.h.
15314         * python/py-symtab.c: Do not include py-ref.h.
15315         * python/py-type.c: Do not include py-ref.h.
15316         * python/py-unwind.c: Do not include py-ref.h.
15317         * python/py-utils.c: Do not include py-ref.h.
15318         * python/py-value.c: Do not include py-ref.h.
15319         * python/py-varobj.c: Do not include py-ref.h.
15320         * python/py-xmethods.c: Do not include py-ref.h.
15321         * python/python.c: Do not include py-ref.h.
15322         * varobj.c: Do not include py-ref.h.
15323
15324 2019-01-22  Tom Tromey  <tom@tromey.com>
15325
15326         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15327         keyword for bcache.
15328
15329 2019-01-22  Tom Tromey  <tom@tromey.com>
15330
15331         * compile/compile-cplus-types.c: Remove a comment by #include.
15332
15333 2019-01-22  Tom Tromey  <tom@tromey.com>
15334
15335         * compile/gcc-c-plugin.h: Include compile-internal.h.
15336
15337 2019-01-22  Tom Tromey  <tom@tromey.com>
15338
15339         * stabsread.c (EXTERN): Do not define.
15340         (symnum, next_symbol_text_func, processing_gcc_compilation)
15341         (within_function, global_sym_chain, global_stabs)
15342         (previous_stab_code, this_object_header_files)
15343         (n_this_object_header_files)
15344         (n_allocated_this_object_header_files): Define.
15345         * stabsread.h (EXTERN): Never define.  Use "extern".
15346
15347 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15348
15349         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15350         history_value.
15351
15352 2019-01-21  Tom Tromey  <tom@tromey.com>
15353
15354         * ui-out.c: Fix includes.
15355         * tui/tui-source.c: Fix includes.
15356         * target.c: Fix includes.
15357         * remote.c: Fix includes.
15358         * regcache.c: Fix includes.
15359         * python/py-block.c: Fix includes.
15360         * printcmd.c: Fix includes.
15361         * or1k-tdep.c: Fix includes.
15362         * mi/mi-main.c: Fix includes.
15363         * m32r-tdep.c: Fix includes.
15364         * csky-tdep.c: Fix includes.
15365         * compile/compile-cplus-types.c: Fix includes.
15366         * cli/cli-interp.c: Fix includes.
15367
15368 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15369
15370         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15371         for padding.
15372
15373 2019-01-16  Tom Tromey  <tom@tromey.com>
15374
15375         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15376         earlier.
15377         (struct objfile) <msymbols_range>: Move from top level.
15378         <msymbols>: New method.
15379         (class objfile_msymbols): Remove.
15380         * symtab.c (default_collect_symbol_completion_matches_break_on):
15381         Update.
15382         * symmisc.c (dump_msymbols): Update.
15383         * stabsread.c (scan_file_globals): Update.
15384         * objc-lang.c (info_selectors_command, info_classes_command)
15385         (find_methods): Update.
15386         * minsyms.c (find_solib_trampoline_target): Update.
15387         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15388         * coffread.c (coff_symfile_read): Update.
15389         * ada-lang.c (ada_lookup_simple_minsym)
15390         (ada_collect_symbol_completion_matches): Update.
15391
15392 2019-01-16  Tom Tromey  <tom@tromey.com>
15393
15394         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15395         type.  Remove no-argument constructor.
15396         <iterator::operator++>: Simplify.
15397         <begin>: Update.
15398         <end>: Use minimal_symbol_count.
15399
15400 2019-01-16  Tom Tromey  <tom@tromey.com>
15401
15402         * objfiles.h (struct objfile) <psymtabs>: New method.
15403         (class objfile_psymtabs): Remove.
15404         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15405         typedef.
15406         <range>: New method.
15407         (require_partial_symbols): Change return type.
15408         * psymtab.c (require_partial_symbols)
15409         (psym_expand_symtabs_matching): Update.
15410         * mdebugread.c (parse_partial_symbols): Update.
15411         * dbxread.c (dbx_end_psymtab): Update.
15412
15413 2019-01-15  Tom Tromey  <tom@tromey.com>
15414
15415         * symtab.c (lookup_objfile_from_block)
15416         (lookup_symbol_in_objfile_symtabs)
15417         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15418         (find_line_symtab, info_sources_command)
15419         (default_collect_symbol_completion_matches_break_on)
15420         (make_source_files_completion_list): Update.
15421         * symmisc.c (print_objfile_statistics, dump_objfile)
15422         (maintenance_print_symbols, maintenance_info_symtabs)
15423         (maintenance_check_symtabs, maintenance_info_line_tables):
15424         Update.
15425         * source.c (select_source_symtab)
15426         (forget_cached_source_info_for_objfile): Update.
15427         * objfiles.h (class objfile_compunits): Remove.
15428         (struct objfile) <compunits_range>: New typedef.
15429         (compunits): New method.
15430         * objfiles.c (objfile_relocate1): Update.
15431         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15432         * maint.c (count_symtabs_and_blocks): Update.
15433         * linespec.c (iterate_over_all_matching_symtabs): Update.
15434         * cp-support.c (add_symbol_overload_list_qualified): Update.
15435         * coffread.c (coff_symtab_read): Update.
15436         * ada-lang.c (add_nonlocal_symbols)
15437         (ada_collect_symbol_completion_matches)
15438         (ada_add_global_exceptions): Update.
15439
15440 2019-01-15  Tom Tromey  <tom@tromey.com>
15441
15442         * progspace.h (program_space) <objfiles_safe_range>: New
15443         typedef.
15444         <objfiles_safe>: New method.
15445         * objfiles.h (class all_objfiles_safe): Remove.
15446         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15447         * jit.c (jit_inferior_exit_hook): Update.
15448
15449 2019-01-17  Tom Tromey  <tom@tromey.com>
15450
15451         * progspace.h (program_space) <objfiles_range>: New typedef.
15452         <objfiles>: New method.
15453         <objfiles_head>: Rename from objfiles.
15454         (object_files): Update.
15455         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15456         * guile/scm-pretty-print.c
15457         (ppscm_find_pretty_printer_from_objfiles): Update.
15458         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15459         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15460         Update.
15461         * python/py-progspace.c (pspy_get_objfiles): Update.
15462         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15463         Update.
15464         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15465         (objfpy_lookup_objfile_by_build_id): Update.
15466         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15467         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15468         Update.
15469         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15470         (expand_symtab_containing_pc, lookup_objfile_from_block)
15471         (lookup_static_symbol, basic_lookup_transparent_type)
15472         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15473         (find_line_symtab, info_sources_command)
15474         (default_collect_symbol_completion_matches_break_on)
15475         (make_source_files_completion_list, find_main_name): Update.
15476         * symmisc.c (print_symbol_bcache_statistics)
15477         (print_objfile_statistics, maintenance_print_symbols)
15478         (maintenance_print_msymbols, maintenance_print_objfiles)
15479         (maintenance_info_symtabs, maintenance_check_symtabs)
15480         (maintenance_expand_symtabs, maintenance_info_line_tables):
15481         Update.
15482         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15483         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15484         (map_overlay_command, unmap_overlay_command)
15485         (simple_overlay_update, expand_symtabs_matching)
15486         (map_symbol_filenames): Update.
15487         * symfile-debug.c (set_debug_symfile): Update.
15488         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15489         Update.
15490         * source.c (select_source_symtab, forget_cached_source_info):
15491         Update.
15492         * solib.c (solib_read_symbols): Update.
15493         * solib-spu.c (append_ocl_sos): Update.
15494         * psymtab.c (maintenance_print_psymbols)
15495         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15496         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15497         * printcmd.c (info_symbol_command): Update.
15498         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15499         Update.
15500         * objfiles.h (class all_objfiles): Remove.
15501         * objfiles.c (have_partial_symbols, have_full_symbols)
15502         (have_minimal_symbols, qsort_cmp, update_section_map)
15503         (shared_objfile_contains_address_p)
15504         (default_iterate_over_objfiles_in_search_order): Update.
15505         * objc-lang.c (info_selectors_command, info_classes_command)
15506         (find_methods): Update.
15507         * minsyms.c (find_solib_trampoline_target): Update.
15508         * maint.c (maintenance_info_sections)
15509         (maintenance_translate_address, count_symtabs_and_blocks):
15510         Update.
15511         * main.c (captured_main_1): Update.
15512         * linux-thread-db.c (try_thread_db_load_from_pdir)
15513         (has_libpthread): Update.
15514         * linespec.c (iterate_over_all_matching_symtabs)
15515         (search_minsyms_for_name): Update.
15516         * jit.c (jit_find_objf_with_entry_addr): Update.
15517         * hppa-tdep.c (find_unwind_entry)
15518         (hppa_lookup_stub_minimal_symbol): Update.
15519         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15520         Update.
15521         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15522         (elf_gnu_ifunc_resolve_by_got): Update.
15523         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15524         * dwarf-index-write.c (save_gdb_index_command): Update.
15525         * cp-support.c (add_symbol_overload_list_qualified): Update.
15526         * breakpoint.c (create_overlay_event_breakpoint)
15527         (create_longjmp_master_breakpoint)
15528         (create_std_terminate_master_breakpoint)
15529         (create_exception_master_breakpoint): Update.
15530         * blockframe.c (find_pc_partial_function): Update.
15531         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15532         (ada_collect_symbol_completion_matches)
15533         (ada_add_global_exceptions): Update.
15534
15535 2019-01-17  Tom Tromey  <tom@tromey.com>
15536
15537         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15538         declare VEC.
15539         (solib_target_parse_libraries): Change return type.
15540         (library_list_start_segment, library_list_start_section)
15541         (library_list_end_library, library_list_start_library); Update.
15542         (solib_target_free_library_list): Remove.
15543         (solib_target_parse_libraries): Remove cleanup.  Change return
15544         type.
15545         (solib_target_current_sos): Update.
15546
15547 2019-01-17  Tom Tromey  <tromey@bapiya>
15548
15549         * valprint.c: Replace "the the" with "the".
15550         * symtab.c: Replace "the the" with "the".
15551         * solib.c: Replace "the the" with "the".
15552         * solib-dsbt.c: Replace "the the" with "the".
15553         * linespec.c: Replace "the the" with "the".
15554         * dwarf2loc.h: Replace "the the" with "the".
15555         * amd64-windows-tdep.c: Replace "the the" with "the".
15556         * aarch64-tdep.c: Replace "the the" with "the".
15557
15558 2019-01-16  Keith Seitz  <keiths@redhat.com>
15559
15560         PR gdb/23773
15561         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15562         <builder>: Rename to ..
15563         <m_builder>: ... this and make private.
15564         (dwarf2_cu::get_builder): New method.  Change all users of
15565         `builder' to use this method.
15566         (dwarf2_start_symtab): Move to ...
15567         (dwarf2_cu::start_symtab): ... here.  Update all callers
15568         (setup_type_unit_groups): Move to ...
15569         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15570         callers.
15571         (dwarf2_cu::reset_builder): New method.
15572         (process_full_compunit, process_full_type_unit): Use
15573         dwarf2_cu::reset_builder.
15574         (follow_die_offset): Record the ancestor CU if it is different
15575         from the followed DIE's CU.
15576         (follow_die_sig_1): Likewise.
15577
15578 2019-01-15  Tom Tromey  <tom@tromey.com>
15579
15580         * remote.c (class remote_state) <buf>: Now a char_vector.
15581         <buf_size>: Remove.
15582         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15583         parameter.
15584         (remote_target::getpkt_or_notif_sane_1)
15585         (remote_target::getpkt_sane)
15586         (remote_target::getpkt_or_notif_sane): Likewise.
15587         (class remote_target) <putpkt>: New overload.
15588         (remote_target::read_frame): Change type of "buf_p".  Remove
15589         sizeof_p parameter.
15590         (packet_ok): New overload.
15591         (packet_check_result): New overload.
15592         Update all uses.
15593
15594 2019-01-14  Tom Tromey  <tom@tromey.com>
15595
15596         * remote-notif.c (handle_notification, remote_notif_ack)
15597         (remote_notif_parse): Make "buf" const.
15598         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15599         const.
15600         (remote_notif_parse, remote_notif_ack, handle_notification):
15601         Likewise.
15602         * remote.c (remote_notif_stop_parse): Make "buf" const.
15603         (remote_target::remote_parse_stop_reply): Make "buf" const.
15604         (remote_notif_stop_ack): Make "buf" const.
15605
15606 2019-01-14  Tom Tromey  <tom@tromey.com>
15607
15608         * remote.c (remote_console_output): Make parameter const.
15609
15610 2019-01-14  Tom Tromey  <tom@tromey.com>
15611
15612         * target-debug.h (target_debug_print_signals): Constify.
15613         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15614         * procfs.c (procfs_target::pass_signals): Update.
15615         * linux-nat.c (linux_nat_target::pass_signals): Update.
15616         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15617         * target-delegates.c: Rebuild.
15618         * remote.c (remote_target::program_signals): Update.
15619         (remote_target::pass_signals): Update.
15620         * target.c (target_pass_signals): Constify argument.
15621         (target_program_signals): Likewise.
15622         * target.h (struct target_ops) <pass_signals, program_signals>:
15623         Constify argument.
15624         (target_pass_signals, target_program_signals): Constify argument.
15625
15626 2019-01-14  Tom Tromey  <tom@tromey.com>
15627
15628         PR tui/28819:
15629         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15630
15631 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15632
15633         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15634         field.
15635         * rs6000-tdep.c: Include reggroups.h.
15636         (IS_V_ALIAS_PSEUDOREG): Define.
15637         (rs6000_register_name): Return names for the "vX" aliases.
15638         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15639         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15640         aliases.  Call default_register_reggroup_p for all other
15641         pseudo-registers.
15642         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15643         New functions.
15644         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15645         Handle "vX" aliases.
15646         (v_alias_pseudo_register_collect): New function.
15647         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15648         (rs6000_gdbarch_init): Initialize "vX" aliases as
15649         pseudo-registers.  Restore registration of
15650         rs6000_pseudo_register_reggroup_p with
15651         set_tdesc_pseudo_register_reggroup_p.
15652
15653 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15654
15655         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15656         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15657         set_gdbarch_num_pseudo_regs.
15658
15659 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15660
15661         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15662         Remove arg prefixname, add do_set and do_show.
15663         Add member functions set_list and show_list.
15664         * cli/cli-style.c (class cli_style_option): Update accordingly.
15665         (style_set_list): Move to file scope.
15666         (style_show_list): Likewise.
15667         (set_style): Call help_list.
15668         (show_style): Call cmd_show_list.
15669         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15670         Update to use the new macro.
15671
15672 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15673
15674         * ada-lang.c (_initialize_ada_language): Expand the help text
15675         for the "catch exception" command.
15676
15677 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15678
15679         * symtab.c (matching_obj_sections): Initialize obj,
15680         declare it closer to its usage.
15681
15682 2019-01-10  Tom Tromey  <tom@tromey.com>
15683
15684         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15685         (basic_inf_threads_range): Remove.
15686         (inf_threads_range, inf_non_exited_threads_range)
15687         (safe_inf_threads_range): Use next_adapter.
15688
15689 2019-01-10  Keith Seitz  <keiths@redhat.com>
15690
15691         PR gdb/23712
15692         PR symtab/23010
15693         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15694         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15695
15696 2019-01-10  Keith Seitz  <keiths@redhat.com>
15697
15698         PR gdb/23712
15699         PR symtab/23010
15700         * dictionary.c (pending_to_vector): Remove.
15701         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15702         Remove _1 suffix, replacing functions of the same name.  Update
15703         all callers.
15704         (dict_create_hashed, dict_create_hashed_expandable)
15705         (dict_create_linear, dict_create_linear_expandable, dict_free)
15706         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15707         Make functions static.
15708
15709 2019-01-10  Keith Seitz  <keiths@redhat.com>
15710
15711         PR gdb/23712
15712         PR symtab/23010
15713         * dictionary.h (struct dictionary): Replace declaration with
15714         multidictionary.
15715         (dict_create_hashed, dict_create_hashed_expandable)
15716         (dict_create_linear, dict_create_linear_expandable)
15717         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15718         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15719         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15720         taking multidictionary argument.
15721         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15722         * block.h (struct block) <dict>: Change to multidictionary
15723         and rename `multidict'.
15724         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15725         symmisc.c: Update all dictionary references to multidictionary.
15726
15727 2019-01-10  Keith Seitz  <keiths@redhat.com>
15728
15729         PR gdb/23712
15730         PR symtab/23010
15731         * dictionary.c: Include unordered_map.
15732         (pending_to_vector): New function.
15733         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15734         Rewrite the non-"_1" functions to take vector instead
15735         of linked list.
15736         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15737         "new" _1 versions of the same name.
15738         (multidictionary): Define.
15739         (std::hash<enum language): New definition.
15740         (collate_pending_symbols_by_language, mdict_create_hashed)
15741         (mdict_create_hashed_expandable, mdict_create_linear)
15742         (mdict_create_linear_expandable, mdict_free)
15743         (find_language_dictionary, create_new_language_dictionary)
15744         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15745         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15746         (mdict_size, mdict_empty): New functions.
15747         * dictionary.h (mdict_iterator): Define.
15748
15749 2019-01-10  Pedro Alves  <palves@redhat.com>
15750
15751         * breakpoint.c (read_uploaded_action)
15752         (create_tracepoint_from_upload): Adjust to use
15753         gdb::unique_xmalloc_ptr.
15754         * ctf.c (ctf_write_uploaded_tp):
15755         (SET_ARRAY_FIELD): Use emplace_back.
15756         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15757         * tracefile-tfile.c (tfile_write_uploaded_tp):
15758         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15759         gdb::unique_xmalloc_ptr.
15760         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15761         at_string, cond_string, cmd_strings>: Replace char pointers
15762         with gdb::unique_xmalloc_ptr.
15763
15764 2019-01-10  Pedro Alves  <palves@redhat.com>
15765
15766         * solib-target.c (library_list_start_library): Don't xstrdup name.
15767
15768 2019-01-10  Pedro Alves  <palves@redhat.com>
15769
15770         * mdebugread.c (parse_partial_symbols): Use
15771         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15772
15773 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15774
15775         * linux-fork.c (scoped_switch_fork_info)
15776         <~scoped_switch_fork_info>: Fix incorrect variable name.
15777
15778 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15779
15780         * linux-fork.c (scoped_switch_fork_info)
15781         <scoped_switch_fork_info>: Make explicit.
15782         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15783
15784 2019-01-10  Tom Tromey  <tom@tromey.com>
15785
15786         * objfiles.h (objfile::reset_psymtabs): Update.
15787         * objfiles.c (objfile::objfile): Update.
15788         * psymtab.h (psymtab_storage::obstack): Update.
15789         (psymtab_storage::m_obstack): Use gdb::optional.
15790         (class psymtab_storage): Update comment.  Remove objfile
15791         parameter.
15792         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15793
15794 2019-01-10  Tom Tromey  <tom@tromey.com>
15795
15796         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15797         <free_psymtabs>: Now private.
15798         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15799         (allocate_psymtab): Use new method.
15800
15801 2019-01-10  Tom Tromey  <tom@tromey.com>
15802
15803         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15804         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15805         * mdebugread.c (parse_partial_symbols): Use
15806         allocate_dependencies.
15807         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15808         allocate_dependencies.
15809         (process_psymtab_comp_unit_reader)
15810         (build_type_psymtab_dependencies): Likewise.
15811         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15812
15813 2019-01-10  Tom Tromey  <tom@tromey.com>
15814
15815         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15816         PSYMBOL_SET_LANGUAGE.
15817         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15818
15819 2019-01-10  Tom Tromey  <tom@tromey.com>
15820
15821         * psymtab.h (psymtab_storage::obstack): New method.
15822         <m_obstack>: Rename from obstack; now private.
15823         * psymtab.c (psymtab_storage): Update.
15824         * dwarf2read.c (create_addrmap_from_index)
15825         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15826         Update.
15827
15828 2019-01-10  Tom Tromey  <tom@tromey.com>
15829
15830         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15831         * objfiles.h (objfile::reset_psymtabs): New method.
15832
15833 2019-01-10  Tom Tromey  <tom@tromey.com>
15834
15835         * symmisc.c (print_symbol_bcache_statistics): Update.
15836         (print_objfile_statistics): Update.
15837         * symfile.c (reread_symbols): Update.
15838         * psymtab.h (class psymtab_storage): New.
15839         * psymtab.c (psymtab_storage): New constructor.
15840         (~psymtab_storage): New destructor.
15841         (require_partial_symbols): Update.
15842         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15843         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15844         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15845         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15846         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15847         (start_psymtab_common, end_psymtab_common)
15848         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15849         (allocate_psymtab): Update.
15850         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15851         Update.
15852         (dump_psymtab_addrmap, maintenance_print_psymbols)
15853         (maintenance_check_psymtabs): Update.
15854         (class objfile_psymtabs): Move to objfiles.h.
15855         * psympriv.h (discard_psymtab): Now inline.
15856         (psymtab_discarder::psymtab_discarder): Update.
15857         (psymtab_discarder::~psymtab_discarder): Update.
15858         (ALL_OBJFILE_PSYMTABS): Rewrite.
15859         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15860         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15861         Remove fields.
15862         <partial_symtabs>: New field.
15863         (class objfile_psymtabs): Move from psymtab.h.  Update.
15864         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15865         psymbol_cache.
15866         (objfile::~objfile): Don't destroy psymbol_cache.
15867         * mdebugread.c (parse_partial_symbols): Update.
15868         * dwarf2read.c (create_addrmap_from_index)
15869         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15870         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15871         (add_partial_subprogram, dwarf2_ranges_read): Update.
15872         * dwarf-index-write.c (write_address_map)
15873         (write_one_signatured_type, recursively_write_psymbols)
15874         (class debug_names, class debug_names, write_psymtabs_to_index):
15875         Update.
15876
15877 2019-01-10  Tom Tromey  <tom@tromey.com>
15878
15879         * symtab.h (SYMBOL_SET_NAMES): Update.
15880         (symbol_set_names): Update.
15881         (MSYMBOL_SET_NAMES): Update.
15882         * symtab.c (symbol_set_names): Change argument to be an
15883         objfile_per_bfd_storage.
15884         * psymtab.c (add_psymbol_to_bcache): Update.
15885         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15886
15887 2019-01-10  Tom Tromey  <tom@tromey.com>
15888
15889         * symtab.c (create_demangled_names_hash): Change argument to be an
15890         objfile_per_bfd_storage.
15891         (symbol_set_names): Update.
15892
15893 2019-01-10  Tom Tromey  <tom@tromey.com>
15894
15895         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15896         init_psymbol_list.
15897         * psymtab.c (init_psymbol_list): Do nothing if already called.
15898         * psympriv.h (init_psymbol_list): Add comment.
15899         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15900         init_psymbol_list.
15901         * dbxread.c (dbx_symfile_read): Unconditionally call
15902         init_psymbol_list.
15903
15904 2019-01-10  Tom Tromey  <tom@tromey.com>
15905
15906         * xcoffread.c (scan_xcoff_symtab): Update.
15907         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15908         "where".
15909         * mdebugread.c (parse_partial_symbols)
15910         (handle_psymbol_enumerators): Update.
15911         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15912         * dbxread.c (read_dbx_symtab): Update.
15913         * psympriv.h (psymbol_placement): New enum.
15914         (add_psymbol_to_list): Update.
15915
15916 2019-01-10  Tom Tromey  <tom@tromey.com>
15917
15918         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15919         static_psymbols parameters.
15920         (scan_xcoff_symtab): Update.
15921         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15922         static_psymbols parameters.
15923         * psympriv.h (start_psymtab_common): Update.
15924         * mdebugread.c (parse_partial_symbols): Update.
15925         * dwarf2read.c (create_partial_symtab): Update.
15926         * dbxread.c (read_dbx_symtab): Update.
15927         (start_psymtab): Remove global_psymbols and static_psymbols
15928         parameters.
15929
15930 2019-01-10  Tom Tromey  <tom@tromey.com>
15931
15932         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15933         * psymtab.c (allocate_psymtab): Add comment.
15934         * psympriv.h (allocate_psymtab): Add comment.
15935         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15936         initializations.
15937         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15938
15939 2019-01-10  Tom Tromey  <tom@tromey.com>
15940
15941         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15942         Don't declare.
15943         * mipsread.c: Include mdebugread.h.
15944         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15945         Declare.
15946         * elfread.c: Include mdebugread.h.
15947
15948 2019-01-09  Tom Tromey  <tom@tromey.com>
15949
15950         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15951         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15952         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15953         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15954         (psym_lookup_symbol, psym_find_last_source_symtab)
15955         (psym_forget_cached_source_info, psym_print_stats)
15956         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15957         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15958         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15959         (psym_find_compunit_symtab_by_address)
15960         (maintenance_print_psymbols, maintenance_info_psymtabs)
15961         (maintenance_check_psymtabs): Use ranged for.
15962         * psymtab.h (class objfile_psymtabs): New.
15963         (require_partial_symbols): Return objfile_psymtabs.
15964         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15965
15966 2019-01-09  Tom Tromey  <tom@tromey.com>
15967
15968         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15969         (find_pc_mapped_section, list_overlays_command)
15970         (map_overlay_command, unmap_overlay_command)
15971         (simple_overlay_update): Use all_objfiles.
15972         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15973         * printcmd.c (info_symbol_command): Use all_objfiles.
15974         * objfiles.h (ALL_OBJSECTIONS): Remove.
15975         * maint.c (maintenance_translate_address): Use all_objfiles.
15976         * gcore.c (gcore_create_callback): Use all_objfiles.
15977         (objfile_find_memory_regions): Likewise.
15978
15979 2019-01-09  Tom Tromey  <tom@tromey.com>
15980
15981         * symtab.c (find_line_symtab, info_sources_command)
15982         (make_source_files_completion_list): Use objfile_compunits.
15983         * source.c (select_source_symtab): Use objfile_compunits.
15984         * objfiles.h (struct objfile): Update comment.
15985         (ALL_OBJFILES): Remove.
15986         (ALL_FILETABS): Remove.
15987         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15988         objfile_compunits.
15989
15990 2019-01-09  Tom Tromey  <tom@tromey.com>
15991
15992         * symmisc.c (print_objfile_statistics, dump_objfile)
15993         (maintenance_print_symbols): Use compunit_filetabs.
15994         * source.c (forget_cached_source_info_for_objfile): Use
15995         compunit_filetabs.
15996         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15997         (ALL_FILETABS): Use compunit_filetabs.
15998         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15999         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16000
16001 2019-01-09  Tom Tromey  <tom@tromey.com>
16002
16003         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16004         (compunit_filetabs): New.
16005         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16006         compunit_filetabs.
16007         (info_sources_command, make_source_files_completion_list): Remove
16008         declaration.
16009         * symmisc.c (print_objfile_statistics, dump_objfile)
16010         (maintenance_print_symbols): Remove declaration.
16011         (maintenance_info_symtabs): Use compunit_filetabs.
16012         (maintenance_info_line_tables): Likewise.
16013         * source.c (select_source_symtab): Change local variable name.
16014         (forget_cached_source_info_for_objfile): Remove declaration.
16015         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16016         * objfiles.c (objfile_relocate1): Remove declaration.
16017         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16018         declaration.
16019         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16020         * coffread.c (coff_symtab_read): Remove declaration.
16021         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16022         compunit_filetabs.
16023
16024 2019-01-09  Tom Tromey  <tom@tromey.com>
16025
16026         * symtab.c (lookup_objfile_from_block)
16027         (find_pc_sect_compunit_symtab, search_symbols)
16028         (default_collect_symbol_completion_matches_break_on): Use
16029         objfile_compunits.
16030         * objfiles.h (ALL_COMPUNITS): Remove.
16031         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16032         * cp-support.c (add_symbol_overload_list_qualified): Use
16033         objfile_compunits.
16034         * ada-lang.c (ada_collect_symbol_completion_matches)
16035         (ada_add_global_exceptions): Use objfile_compunits.
16036
16037 2019-01-09  Tom Tromey  <tom@tromey.com>
16038
16039         * source.c (select_source_symtab)
16040         (forget_cached_source_info_for_objfile): Remove declaration.
16041         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16042         declaration.
16043         * maint.c (count_symtabs_and_blocks): Remove declaration.
16044         * cp-support.c (add_symbol_overload_list_qualified): Remove
16045         declaration.
16046         * coffread.c (coff_symtab_read): Remove declaration.
16047         * symtab.c (lookup_symbol_in_objfile_symtabs)
16048         (basic_lookup_transparent_type_1): Use objfile_compunits.
16049         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16050         (info_sources_command, search_symbols)
16051         (default_collect_symbol_completion_matches_break_on)
16052         (make_source_files_completion_list): Remove declaration.
16053         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16054         (ada_collect_symbol_completion_matches)
16055         (ada_add_global_exceptions): Remove declaration.
16056         * linespec.c (iterate_over_all_matching_symtabs): Use
16057         objfile_compunits.
16058         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16059         (class objfile_compunits): New.
16060         (ALL_COMPUNITS): Use objfile_compunits.
16061         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16062         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16063         objfile_compunits.
16064         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16065
16066 2019-01-09  Tom Tromey  <tom@tromey.com>
16067
16068         * symtab.c (search_symbols)
16069         (default_collect_symbol_completion_matches_break_on): Use
16070         objfile_msymbols.
16071         * ada-lang.c (ada_lookup_simple_minsym)
16072         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16073         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16074         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16075         objfile_msymbols.
16076         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16077         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16078         * objc-lang.c (find_methods): Use objfile_msymbols.
16079         (info_selectors_command, info_classes_command): Likewise.
16080         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16081         * objfiles.h (class objfile_msymbols): New.
16082         (ALL_OBJFILE_MSYMBOLS): Remove.
16083         (ALL_MSYMBOLS): Remove.
16084
16085 2019-01-09  Tom Tromey  <tom@tromey.com>
16086
16087         * common/next-iterator.h (next_adapter): Add Iterator template
16088         parameter.
16089         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16090         (class all_objfiles_safe): New.
16091         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16092         * objfiles.c (put_objfile_before): Update comment.
16093         (add_separate_debug_objfile): Likewise.
16094         (free_all_objfiles): Use all_objfiles_safe.
16095         (objfile_purge_solibs): Likewise.
16096
16097 2019-01-09  Tom Tromey  <tom@tromey.com>
16098
16099         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16100         (expand_symtab_containing_pc, lookup_static_symbol)
16101         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16102         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16103         all_objfiles.
16104         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16105         * breakpoint.c (create_overlay_event_breakpoint)
16106         (create_longjmp_master_breakpoint)
16107         (create_std_terminate_master_breakpoint)
16108         (create_exception_master_breakpoint): Use all_objfiles.
16109         * linux-thread-db.c (try_thread_db_load_from_pdir)
16110         (has_libpthread): Use all_objfiles.
16111         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16112         * linespec.c (iterate_over_all_matching_symtabs)
16113         (search_minsyms_for_name): Use all_objfiles.
16114         * maint.c (maintenance_info_sections): Use all_objfiles.
16115         * main.c (captured_main_1): Use all_objfiles.
16116         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16117         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16118         * guile/scm-pretty-print.c
16119         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16120         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16121         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16122         (maintenance_print_msymbols): Use all_objfiles.
16123         * source.c (select_source_symtab): Use all_objfiles.
16124         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16125         * symfile.c (remove_symbol_file_command)
16126         (expand_symtabs_matching, map_symbol_filenames): Use
16127         all_objfiles.
16128         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16129         all_objfiles.
16130         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16131         * objc-lang.c (find_methods): Use all_objfiles.
16132         * objfiles.c (have_partial_symbols, have_full_symbols)
16133         (have_minimal_symbols, qsort_cmp)
16134         (default_iterate_over_objfiles_in_search_order): Use
16135         all_objfiles.
16136         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16137         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16138         (maintenance_check_psymtabs): Use all_objfiles.
16139         (ALL_PSYMTABS): Remove.
16140         * compile/compile-object-run.c (do_module_cleanup): Use
16141         all_objfiles.
16142         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16143         * cp-support.c (add_symbol_overload_list_qualified): Use
16144         all_objfiles.
16145         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16146         Use all_objfiles.
16147         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16148         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16149         all_objfiles.
16150         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16151         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16152         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16153         Uses all_objfiles.
16154         * solib.c (solib_read_symbols): Use all_objfiles
16155
16156 2019-01-09  Tom Tromey  <tom@tromey.com>
16157
16158         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16159         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16160         all_objfiles.
16161         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16162         * symmisc.c (print_symbol_bcache_statistics)
16163         (print_objfile_statistics, maintenance_print_objfiles)
16164         (maintenance_info_symtabs, maintenance_check_symtabs)
16165         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16166         all_objfiles.
16167         * source.c (forget_cached_source_info): Use all_objfiles.
16168         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16169         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16170         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16171         * objfiles.c (update_section_map): Use all_objfiles.
16172         (shared_objfile_contains_address_p): Likewise.
16173         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16174         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16175
16176 2019-01-09  Tom Tromey  <tom@tromey.com>
16177
16178         * common/next-iterator.h: New file.
16179         * objfiles.h (class all_objfiles): New.
16180         (struct objfile_iterator): New.
16181
16182 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16183
16184         * NEWS: Move the description of the changed "frame", "select-frame",
16185          and "info frame" commands to the Changed commands section.
16186
16187 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16188
16189         * gdbtypes.c (check_stub_method_group): Remove handling of old
16190         mangling schemes.
16191         * linespec.c (find_methods): Likewise.
16192         * stabsread.c (read_member_functions): Likewise.
16193         * valops.c (search_struct_method): Likewise.
16194         (value_struct_elt_for_reference): Likewise.
16195         * NEWS: Mention this change.
16196
16197 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16198
16199         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16200         print_source_lines.
16201         * source.c (print_source_lines_base): Update line number check.
16202         (print_source_lines): New function.
16203         (source_lines_range::source_lines_range): New function.
16204         * source.h (class source_lines_range): New class.
16205         (print_source_lines): New declaration.
16206
16207 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16208
16209         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16210
16211 2019-01-08  Tom Tromey  <tom@tromey.com>
16212             Simon Marchi  <simon.marchi@ericsson.com>
16213
16214         PR gdb/24060
16215         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16216         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16217         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16218         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16219         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16220         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16221
16222 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16223
16224         * source.c (select_source_symtab): Move header comment to
16225         declaration in source.h.
16226         (forget_cached_source_info_for_objfile): Likewise.
16227         (forget_cached_source_info): Likewise.
16228         (identify_source_line): Likewise.
16229         * source.h (identify_source_line): Move declaration from symtab.h
16230         and add comment from source.c
16231         (print_source_lines): Likewise.
16232         (forget_cached_source_info_for_objfile): Likewise.
16233         (forget_cached_source_info): Likewise.
16234         (select_source_symtab): Likewise.
16235         (enum print_source_lines_flag): Move definition from symtab.h.
16236         * symtab.h (identify_source_line): Move declaration to source.h.
16237         (print_source_lines): Likewise.
16238         (forget_cached_source_info_for_objfile): Likewise.
16239         (forget_cached_source_info): Likewise.
16240         (select_source_symtab): Likewise.
16241         (enum print_source_lines_flag): Move definition to source.h.
16242         * tui/tui-hooks.c: Add 'source.h' include.
16243
16244 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16245
16246         * source.c (print_source_lines_base): Handle requests to print
16247         reverse line number sequences, and guard against empty lines
16248         string.
16249
16250 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16251
16252         * source.c (print_source_lines_base): Fix skip of '\r' if next
16253         character is '\n'.
16254
16255 2019-01-06  Tom Tromey  <tom@tromey.com>
16256
16257         * c-exp.y (struct c_parse_state) <macro_original_text,
16258         expansion_obstack>: New member.
16259         (macro_original_text, expansion_obstack): Remove globals.
16260         (scan_macro_expansion, scanning_macro_expansion)
16261         (finished_macro_expansion): Update.
16262         (scan_macro_cleanup): Remove.
16263         (yylex, c_parse): Update.
16264
16265 2019-01-06  Tom Tromey  <tom@tromey.com>
16266
16267         * c-exp.y (struct c_parse_state) <strings>: New member.
16268         (operator_stoken): Update.
16269
16270 2019-01-06  Tom Tromey  <tom@tromey.com>
16271
16272         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16273         (union type_stack_elt) <typelist_val>: Now a pointer to
16274         std::vector.
16275         (type_stack_cleanup): Don't declare.
16276         (push_typelist): Update.
16277         * parse.c (pop_typelist): Return a std::vector.
16278         (push_typelist): Take a std::vector.
16279         (follow_types): Update.  Do not free args.
16280         (type_stack_cleanup): Remove.
16281         * c-exp.y (struct c_parse_state): New.
16282         (cpstate): New global.
16283         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16284         (nonempty_typelist): Update.
16285         (func_mod): Create a new vector.
16286         (c_parse): Create a c_parse_state.
16287         (check_parameter_typelist): Do not delete params.
16288         (function_method): Update.  Do not delete type_list.
16289
16290 2019-01-06  Tom Tromey  <tom@tromey.com>
16291
16292         PR gdb/28155:
16293         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16294         check_typedef.
16295         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16296         (print_return_value): Likewise.
16297
16298 2019-01-05  Tom Tromey  <tom@tromey.com>
16299
16300         * contrib/cleanup_check.py: Remove.
16301         * contrib/gcc-with-excheck: Remove.
16302         * contrib/exsummary.py: Remove.
16303         * contrib/excheck.py: Remove.
16304
16305 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16306
16307         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16308         NULL. Initialize tpprev to NULL instead of assigning it
16309         to NULL on the next statement.
16310         * windows-nat.c (windows_delete_thread): Remove check for
16311         main_thread_id before printing thread exit notifications.
16312         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16313         Remove thread ID check against main_thread_id.
16314         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16315         windows_delete_thread.
16316         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16317
16318 2019-01-04  Tom Tromey  <tom@tromey.com>
16319
16320         * compile/compile.c (_initialize_compile): Use upper case for
16321         metasyntactic variables.
16322         * symmisc.c (_initialize_symmisc): Use upper case for
16323         metasyntactic variables.
16324         * psymtab.c (_initialize_psymtab): Use upper case for
16325         metasyntactic variables.
16326         * demangle.c (demangle_command): Use upper case for metasyntactic
16327         variables.
16328         (_initialize_demangler): Likewise.
16329         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16330         variables.
16331
16332 2019-01-03  Tom Tromey  <tom@tromey.com>
16333
16334         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16335
16336 2019-01-03  Tom Tromey  <tom@tromey.com>
16337
16338         * python/py-symtab.c (salpy_str): Update.
16339         (struct salpy_sal_object) <symtab>: Now a PyObject.
16340         (salpy_dealloc): Update.
16341         (del_objfile_sal): Use gdbpy_ref.
16342
16343 2019-01-03  Tom Tromey  <tom@tromey.com>
16344
16345         * python/py-type.c (convert_field): Use new_reference.  Return
16346         gdbpy_ref.
16347         (make_fielditem): Return gdbpy_ref.
16348         (typy_fields): Update.
16349         (typy_getitem): Update.
16350         (field_name): Return gdbpy_ref.  Use new_reference.
16351         (typy_iterator_iternext): Update.
16352
16353 2019-01-03  Tom Tromey  <tom@tromey.com>
16354
16355         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16356
16357 2019-01-03  Tom Tromey  <tom@tromey.com>
16358
16359         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16360         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16361         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16362         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16363         (pspy_set_type_printers): Likewise.
16364         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16365         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16366         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16367         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16368         (objfpy_set_type_printers): Likewise.
16369
16370 2019-01-03  Tom Tromey  <tom@tromey.com>
16371
16372         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16373         (gdbpy_print_stack): Use gdbpy_err_fetch.
16374         * python/python-internal.h (class gdbpy_err_fetch): New class.
16375         (class gdbpy_enter) <m_error_type, m_error_value,
16376         m_error_traceback>: Remove.
16377         <m_error>: New member.
16378         (gdbpy_exception_to_string): Don't declare.
16379         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16380         * python/py-value.c (convert_value_from_python): Use
16381         gdbpy_err_fetch.
16382         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16383         gdbpy_exception_to_string.
16384         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16385         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16386         gdbpy_err_fetch.
16387
16388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16389
16390         * linux-nat.c (delete_lwp_cleanup): Delete.
16391         (struct lwp_deleter): New struct.
16392         (lwp_info_up): New typedef.
16393         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16394         lwp_info_up.
16395
16396 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16397
16398         * linux-fork.c (class scoped_switch_fork_info): New class.
16399         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16400
16401 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16402
16403         * valops.c (find_overload_match): Remove use of null_cleanup, and
16404         calls to do_cleanups.
16405
16406 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16407
16408         * compile/compile-cplus-types.c
16409         (compile_cplus_instance::decl_name): Handle changes to
16410         cp_func_name.
16411         * cp-support.c (cp_func_name): Update header comment, update
16412         return type.
16413         * cp-support.h (cp_func_name): Update return type in declaration.
16414         * valops.c (find_overload_match): Move temp_func local to top
16415         level of function and change its type.  Use temp_func to hold and
16416         delete temporary string obtained from cp_func_name.
16417
16418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16419
16420         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16421         gdb::char_vector, remove cleanup, and update uses of `msg`.
16422
16423 2019-01-03  Jim Wilson  <jimw@sifive.com>
16424
16425         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16426
16427 2019-01-02  Tom Tromey  <tom@tromey.com>
16428
16429         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16430         (tdesc_parse_xml): Remove cleanups.
16431         * target-descriptions.h (make_cleanup_free_target_description):
16432         Don't declare.
16433         (target_desc_deleter): New struct.
16434         (target_desc_up): New typedef.
16435         * target-descriptions.c (target_desc_deleter::operator()): Rename
16436         from free_target_description.
16437         (make_cleanup_free_target_description): Remove.
16438
16439 2019-01-02  Tom Tromey  <tom@tromey.com>
16440
16441         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16442         constructor, destructor.
16443         (linespec_parser): Remove typedef.
16444         (~linespec_parser): Rename from linespec_parser_delete.
16445         (linespec_lex_to_end, linespec_complete_label)
16446         (linespec_complete): Update.
16447         (decode_line_full): Remove cleanups.
16448         (decode_line_1): Update.
16449
16450 2019-01-02  Tom Tromey  <tom@tromey.com>
16451
16452         * python/python-internal.h (inferior_to_inferior_object): Change
16453         return type.
16454         * python/py-exitedevent.c (create_exited_event_object): Update.
16455         * python/py-inferior.c (inferior_to_inferior_object): Return
16456         gdbpy_ref.
16457         (python_new_inferior, python_inferior_deleted)
16458         (thread_to_thread_object, delete_thread_object)
16459         (build_inferior_list, gdbpy_selected_inferior): Update.
16460         * python/py-infthread.c (create_thread_object): Update.  Also fail
16461         if inferior_to_inferior_object fails.
16462
16463 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16464
16465         * inferior.h (class inferior) <displaced_step_state>: New field.
16466         * infrun.h (struct displaced_step_state): Move here from
16467         infrun.c.  Initialize fields, add constructor.
16468         <inf>: Remove field.
16469         <reset>: New method.
16470         * infrun.c (struct displaced_step_inferior_state): Move to
16471         infrun.h.
16472         (displaced_step_inferior_states): Remove.
16473         (get_displaced_stepping_state): Adust.
16474         (displaced_step_in_progress_any_inferior): Adjust.
16475         (displaced_step_in_progress_thread): Adjust.
16476         (displaced_step_in_progress): Adjust.
16477         (add_displaced_stepping_state): Remove.
16478         (get_displaced_step_closure_by_addr): Adjust.
16479         (remove_displaced_stepping_state): Remove.
16480         (infrun_inferior_exit): Call displaced_step_state.reset.
16481         (use_displaced_stepping): Don't check for NULL.
16482         (displaced_step_prepare_throw): Call
16483         get_displaced_stepping_state.
16484         (displaced_step_fixup): Don't check for NULL.
16485         (prepare_for_detach): Don't check for NULL.
16486
16487 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16488
16489         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16490          in case of call that did not complete.
16491
16492 2019-01-02  Andrey Utkin  <autkin@undo.io>
16493
16494         * symfile.c (find_separate_debug_file): Fix search of debug files for
16495         remote debuggee.
16496
16497 2019-01-02  Tom Tromey  <tom@tromey.com>
16498
16499         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16500         indentation.
16501         * python/py-frame.c (frapy_older): Remove cast.
16502         (frapy_newer): Likewise.
16503         * python/py-breakpoint.c (local_setattro): Remove cast.
16504         * python/py-arch.c (archpy_name): Remove local variable.
16505         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16506
16507 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16508
16509         * unittests/basic_string_view/element_access/char/empty.cc:
16510         Fix year range in copyright header.
16511
16512 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16513
16514         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16515         Delete.
16516         <operator==>: Update with for removed field.
16517         <hash>: Likewise.
16518         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16519         <isa_features>: ...this.
16520         <abi_features>: New field.
16521         (riscv_isa_flen): Update comment.
16522         (riscv_abi_xlen): New declaration.
16523         (riscv_abi_flen): New declaration.
16524         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16525         isa_features.
16526         (riscv_abi_xlen): New function.
16527         (riscv_isa_flen): Update to get answer from isa_features.
16528         (riscv_abi_flen): New function.
16529         (riscv_has_fp_abi): Update to get answer from abi_features.
16530         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16531         xlen and flen.
16532         (riscv_call_info) <xlen, flen>: Update comment.
16533         (riscv_call_arg_struct): Remove invalid assertions
16534         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16535         is removed.
16536         (riscv_gdbarch_init): Gather isa features and abi features
16537         separately, ensure both match on the gdbarch when reusing an old
16538         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16539         a target with 64-bit float hardware.
16540
16541 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16542
16543         * source.c (search_command_helper): Stop reverse search
16544         when line 1 has been searched.
16545
16546 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16547
16548         * record-full.c (record_full_base_target::close): Rewrite
16549         record_full_core_buf_list free logic.
16550
16551 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16552
16553         * break-catch-syscall.c (print_one_catch_syscall): xfree
16554         the last text.
16555
16556 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16557
16558         * top.c (print_gdb_version): Update Copyright year in version
16559         message.
16560
16561 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16562
16563         Update copyright year range in all GDB files.
16564
16565 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16566
16567         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16568
16569 For older changes see ChangeLog-2018.
16570 \f
16571 Local Variables:
16572 mode: change-log
16573 left-margin: 8
16574 fill-column: 74
16575 version-control: never
16576 coding: utf-8
16577 End:
16578