gdb/ChangeLog

   1 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
   4         avoid compile errors.
   5
   6 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * config.in: Regenerate.
   9         * configure: Regenerate.
  10         * gdbsupport/common.m4: No longer check for strerror_r.
  11         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  12         POSIX version of strerror_r, now that gnulib provides it if
  13         necessary.
  14
  15 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  16
  17         * README (`configure' options): Update.
  18
  19 2019-11-14  Tom Tromey  <tromey@adacore.com>
  20
  21         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  22         expected type for the RHS if the LHS is a convenience variable.
  23
  24 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  25
  26         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
  27         Provide explicit default and copy constructor.
  28
  29 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  30
  31         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
  32         only call Py_INCREF (newbp) in the bppy_pending_object case.
  33
  34 2019-11-13  Tom Tromey  <tromey@adacore.com>
  35
  36         PR build/25182:
  37         * psympriv.h (partial_symbol): Remove static assert.
  38         * symtab.h (general_symbol_info, symbol): Remove static assert.
  39
  40 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  41
  42         * gdbsupport/format.c (format_pieces::format_pieces): Support
  43         printf 'z' size modifier.
  44         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  45         * printcmd.c (ui_printf):  Handle size_t_arg.
  46         * ui-out.c (ui_out::vmessage): Likewise.
  47         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  48         function.
  49         (run_tests): Call test_format_int_sizes.
  50
  51 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  52
  53         * ada-exp.y (write_ambiguous_var): Update.
  54         * buildsym.c (add_symbol_to_list): Update.
  55         * dwarf2read.c (read_variable): Update.
  56         (new_symbol): Update.
  57         * jit.c (finalize_symtab): Update.
  58         * language.c (language_alloc_type_symbol): Update.
  59         * symtab.c (fixup_symbol_section): Update.
  60         (initialize_objfile_symbol_1): Move code to...
  61         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
  62         (allocate_symbol): Update.
  63         (allocate_template_symbol): Update.
  64         (get_symbol_address): Update.
  65         * symtab.h (struct symbol): Inherit from general_symbol_info instead
  66         of having as a field, and add a constructor.
  67         (SYMBOL_VALUE): Update.
  68         (SYMBOL_VALUE_ADDRESS): Update.
  69         (SET_SYMBOL_VALUE_ADDRESS): Update.
  70         (SYMBOL_VALUE_BYTES): Update.
  71         (SYMBOL_VALUE_COMMON_BLOCK): Update.
  72         (SYMBOL_BLOCK_VALUE): Update.
  73         (SYMBOL_VALUE_CHAIN): Update.
  74         (SYMBOL_LANGUAGE): Update.
  75         (SYMBOL_SECTION): Update.
  76         (SYMBOL_OBJ_SECTION): Update.
  77         (SYMBOL_SET_LANGUAGE): Update.
  78         (SYMBOL_SET_LINKAGE_NAME): Update.
  79         (SYMBOL_SET_NAMES): Update.
  80         (SYMBOL_NATURAL_NAME): Update.
  81         (SYMBOL_LINKAGE_NAME): Update.
  82         (SYMBOL_DEMANGLED_NAME): Update.
  83         (SYMBOL_SEARCH_NAME): Update.
  84         (SYMBOL_MATCHES_SEARCH_NAME): Update.
  85         (struct symbol): Update.
  86         (struct template_symbol): Update.
  87         (struct rust_vtable_symbol): Update.
  88         * xcoffread.c (SYMBOL_DUP): Update.
  89
  90 2019-11-12  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-layout.c (show_layout): Set current_layout.
  93         (show_source_disasm_command, show_data)
  94         (show_source_or_disasm_and_command): Don't set current_layout.
  95
  96 2019-11-12  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
  99
 100 2019-11-12  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-win.c (resize_message): New global.
 103         (show_tui_resize_message): New function.
 104         (tui_async_resize_screen): Print message if requested.
 105         (_initialize_tui_win): Add tui-resize-message setting.
 106         * NEWS: Add entry for new commands.
 107
 108 2019-11-11  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 111         functions.
 112
 113 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 114
 115         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 116
 117 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 118
 119         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 120         function.
 121         * python/python-internal.h (gdbpy_lookup_static_symbols):
 122         Declare new function.
 123         * python/python.c (python_GdbMethods): Add
 124         gdb.lookup_static_symbols method.
 125         * NEWS: Mention gdb.lookup_static_symbols.
 126
 127 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 128
 129         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 130         static block of current object file first.  Also fix typo in
 131         header comment.
 132
 133 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * stack.c (set_last_displayed_sal): Delete.
 136         (last_displayed_sal_valid): Delete.
 137         (last_displayed_pspace): Delete.
 138         (last_displayed_addr): Delete.
 139         (last_displayed_symtab): Delete.
 140         (last_displayed_line): Delete.
 141         (class last_displayed_symtab_info_type): New.
 142         (last_displayed_symtab_info): New static global variable.
 143         (print_frame_info): Call methods on last_displayed_symtab_info.
 144         (clear_last_displayed_sal): Update header comment, and make use of
 145         last_displayed_symtab_info.
 146         (last_displayed_sal_is_valid): Likewise.
 147         (get_last_displayed_pspace): Likewise.
 148         (get_last_displayed_addr): Likewise.
 149         (get_last_displayed_symtab): Likewise.
 150         (get_last_displayed_line): Likewise.
 151         (get_last_displayed_sal): Likewise.
 152         * stack.h (clear_last_displayed_sal): Update header comment.
 153         (last_displayed_sal_is_valid): Likewise.
 154         (get_last_displayed_pspace): Likewise.
 155         (get_last_displayed_addr): Likewise.
 156         (get_last_displayed_symtab): Likewise.
 157         (get_last_displayed_line): Likewise.
 158         (get_last_displayed_sal): Likewise.
 159
 160 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 161
 162         * stack.c (frame_show_address): Convert return type to bool.
 163         * stack.h (frame_show_address): Likewise, and update header
 164         comment.
 165
 166 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 169         * unittests/vec-utils-selftests.c: New file.
 170         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 171
 172 2019-11-10  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 175         (tui_highlight_win): Likewise.
 176         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 177         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 178         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 179         Don't set can_highlight.
 180
 181 2019-11-10  Tom Tromey  <tom@tromey.com>
 182
 183         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 184         Remove unused declaration.
 185
 186 2019-11-08  Tom Tromey  <tromey@adacore.com>
 187
 188         * top.c (read_command_file): Update.
 189         (command_line_input): Make return type const.
 190         * python/py-gdb-readline.c: Update.
 191         * linespec.c (decode_line_2): Update.
 192         * defs.h (command_line_input): Make return type const.
 193         * cli/cli-script.c (read_next_line): Make return type const.
 194         * ada-lang.c (get_selections): Update.
 195
 196 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 197
 198         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 199         * mi/mi-main.c (output_cores): Likewise.
 200         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 201         (linux_xfer_osdata_modules): Likewise.
 202         * remote.c (register_remote_support_xml): Likewise.
 203         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 204         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 205
 206 2019-11-06  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-interp.c: Don't include readline.h.
 209         * tui/tui-hooks.c: Don't include readline.h.
 210         * symmisc.c: Include tilde.h, not readline.h.
 211         * symfile.c: Include tilde.h, not readline.h.
 212         * source.c: Include tilde.h, not readline.h.
 213         * solib.c: Include tilde.h, not readline.h.
 214         * psymtab.c: Include tilde.h, not readline.h.
 215         * exec.c: Include tilde.h, not readline.h.
 216         * corelow.c: Include tilde.h, not readline.h.
 217         * cli/cli-dump.c: Include tilde.h, not readline.h.
 218         * cli/cli-cmds.c: Don't include readline.h.
 219
 220 2019-11-05  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 223         (tui_disassemble): Set addr_size.
 224         (tui_disasm_window::set_contents): Use addr_size.
 225
 226 2019-11-05  Tom Tromey  <tom@tromey.com>
 227
 228         * rust-lang.c (rust_language_defn): Update.
 229         * python/py-value.c (valpy_string): Call c_get_string.
 230         * p-lang.c (pascal_language_defn): Update.
 231         * opencl-lang.c (opencl_language_defn): Update.
 232         * objc-lang.c (objc_language_defn): Update.
 233         * m2-lang.c (m2_language_defn): Update.
 234         * language.c (unknown_language_defn, auto_language_defn): Update.
 235         (default_get_string): Remove.
 236         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 237         * go-lang.c (go_language_defn): Update.
 238         * f-lang.c (f_language_defn): Update.
 239         * d-lang.c (d_language_defn): Update.
 240         * c-lang.c (c_language_defn, cplus_language_defn)
 241         (asm_language_defn, minimal_language_defn): Update.
 242         * ada-lang.c (ada_language_defn): Update.
 243         * language.h (struct language_defn) <la_get_string>: Remove.
 244         (LA_GET_STRING): Remove.
 245         (default_get_string): Don't declare.
 246
 247 2019-11-05  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-source.h (struct tui_source_window): Inline
 250         constructor.  Remove destructor.
 251         <style_changed, m_observable>: Move to superclass.
 252         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 253         (struct tui_source_window_base): Move private members to end.
 254         <style_changed, m_observable>: Move from tui_source_window.
 255         * tui/tui-winsource.c (tui_copy_source_line): Move from
 256         tui-source.c.  Rename from copy_source_line.  Add special handling
 257         for negative line number.
 258         (tui_source_window_base::style_changed): Move from
 259         tui_source_window.
 260         (tui_source_window_base): Register observer.
 261         (~tui_source_window_base): New.
 262         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 263         rename.
 264         (tui_source_window::set_contents): Use tui_copy_source_line.
 265         (tui_source_window::tui_source_window): Move to tui-source.h.
 266         (tui_source_window::~tui_source_window): Remove.
 267         (tui_source_window::style_changed): Move to superclass.
 268         * tui/tui-disasm.c (tui_disassemble): Create string file with
 269         styling, when possible.  Add "addr_size" parameter.
 270         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 271         Don't compute maximum size.
 272         (len_without_escapes): New function
 273
 274 2019-11-05  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 277         std::string.
 278         * tui/tui-winsource.c (tui_show_source_line): Update.
 279         * tui/tui-source.c (tui_source_window::set_contents): Update.
 280         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 281
 282 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 283
 284         * symtab.h (gdb_static_assert): Put && operator at the beginning
 285         of the line instead of the end.
 286
 287 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 288
 289         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 290         and sizeof (symbol).
 291         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 292
 293 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 294
 295         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 296         * configure.host: Mark *-*-solaris2.10* obsolete.
 297         * configure.tgt: Mark Solaris < 11 obsolete.
 298         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 299         Update target triplet.
 300
 301 2019-11-01  Tom Tromey  <tromey@adacore.com>
 302
 303         * utils.c (print_sys_errmsg): Simplify.
 304
 305 2019-11-01  Tom Tromey  <tromey@adacore.com>
 306
 307         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 308
 309 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 310
 311         * configure: Regenerate.
 312         * configure.ac: Remove check for strerror_r.
 313         * gdbsupport/common.m4: Check for strerror_r.
 314
 315 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 316
 317         PR gdb/25124
 318
 319         * arm-tdep.c (arm_per_objfile): Rename to ...
 320         (arm_per_bfd): ... this.
 321         (arm_objfile_data_key): Rename to ...
 322         (arm_bfd_data_key): ... this.
 323         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 324         data.
 325         (arm_record_special_symbol): Likewise.
 326
 327 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 330         end.
 331         * c-typeprint.c (c_print_typedef): Likewise.
 332         * f-typeprint.c (f_print_typedef): Likewise.
 333         * m2-typeprint.c (m2_print_typedef): Likewise.
 334         * p-typeprint.c (pascal_print_typedef): Likewise.
 335         * rust-lang.c (rust_print_typedef): Likewise.
 336         * symtab.c (print_symbol_info): Print a newline after calling
 337         typedef_print.
 338
 339 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 340
 341         * symtab.c (info_module_cmdlist): New variable.
 342         (info_module_command): New function.
 343         (search_module_symbols): New function.
 344         (info_module_subcommand): New function.
 345         (struct info_modules_var_func_options): New struct.
 346         (info_modules_var_func_options_defs): New variable.
 347         (make_info_modules_var_func_options_def_group): New function.
 348         (info_module_functions_command): New function.
 349         (info_module_variables_command): New function.
 350         (info_module_var_func_command_completer): New function.
 351         (_initialize_symtab): Register new 'info module functions' and
 352         'info module variables' commands.
 353         * symtab.h (typedef symbol_search_in_module): New typedef.
 354         (search_module_symbols): Declare new function.
 355         * NEWS: Mention new commands.
 356
 357 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 360         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 361         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 362         MODULES_DOMAIN.
 363         (scan_partial_symbols): Only create partial module symbols for non
 364         declarations.
 365         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 366         and MODULES_DOMAIN.
 367         * symtab.c (search_domain_name): Likewise.
 368         (search_symbols): Likewise.
 369         (print_symbol_info): Likewise.
 370         (symtab_symbol_info): Likewise.
 371         (info_modules_command): New function.
 372         (_initialize_symtab): Register 'info modules' command.
 373         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 374         * NEWS: Mention new 'info modules' command.
 375
 376 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 377
 378         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 379         and $_gdb_maint_setting_str.
 380
 381 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 382
 383         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 384         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 385         (str_value_from_setting, gdb_setting_str_internal_fn)
 386         (gdb_maint_setting_str_internal_fn): New functions.
 387         (_initialize_cli_cmds): Define the new convenience functions.
 388         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 389         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 390
 391 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 392
 393         * agent.c (set_can_use_agent): When the setting is turned on,
 394         look up agent symbols if we don't have them yet.
 395         (agent_new_objfile): Don't look up agent symbols when the agent
 396         setting is off.
 397
 398 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 399
 400         * config.in: Regenerate.
 401
 402 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 403
 404         * configure: Regenerate.
 405         * configure.ac: Check for strerror_r.
 406         * gdbsupport/common-utils.h (safe_strerror): Change return value
 407         to const char * and document that this function is now threadsafe.
 408         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 409         thread_local and call strerror_r, if available.
 410         * utils.c (perror_string): Update.
 411         (print_sys_errmsg): Update.
 412
 413 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 414
 415         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 416         objfile_key.
 417         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 418         objfile to fetch per-bfd data.
 419         (arm_find_exidx_entry): Likewise.
 420
 421 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 422
 423         * gdbsupport/agent.c (debug_agent): Change type to bool.
 424         (use_agent): Likewise.
 425         (all_agent_symbols_look_up): Likewise.
 426         (agent_loaded_p): Change return value to bool.
 427         (agent_look_up_symbols): Update.
 428         (agent_capability_check): Change return value to bool.
 429         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 430         (debug_agent): Change type to bool.
 431         (use_agent): Likewise.
 432         (agent_capability_check): Change return value to bool.
 433
 434 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 435
 436         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 437         (build_minimal_symbol_hash_tables): Code to clear the table moved
 438         to clear_minimal_symbol_hash_tables.
 439         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 440         when needed.
 441
 442 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 443
 444         * infcmd.c: Remove includes.
 445         * infrun.c: Remove includes.
 446
 447 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 448
 449         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 450         (grow_vect): Remove declaration.
 451         (ada_type_of_array): Remove declaration.
 452         (ada_update_initial_language): Remove declaration.
 453         (ada_fold_name): Remove declaration.
 454         (ada_fill_in_ada_prototype): Remove declaration.
 455         (user_select_syms): Remove declaration.
 456         (get_selections): Remove declaration.
 457         (ada_tag_type): Remove declaration.
 458         (ada_value_tag): Remove declaration.
 459         (ada_is_others_clause): Remove declaration.
 460         (ada_in_variant): Remove declaration.
 461         (ada_value_struct_elt): Remove declaration.
 462         (ada_attribute_name): Remove declaration.
 463         (ada_system_address_type): Remove declaration.
 464         * ada-lang.c (ada_watch_location_expression): Make static.
 465         (GROW_VECT): Move here from ada-lang.h.
 466         (grow_vect): Make static.
 467         (ada_update_initial_language): Make static.
 468         (ada_fold_name): Make static.
 469         (ada_type_of_array): Make static.
 470         (encoded_ordered_before): Move up.
 471         (sort_choices): Move up.
 472         (print_signatures): Move up.
 473         (ada_print_symbol_signature): Move up.
 474         (get_selections): Move up and make static.
 475         (user_select_syms): Move up and make static.
 476         (ada_value_struct_elt): Move up and make static.
 477         (ada_tag_type): Make static.
 478         (ada_value_tag): Make static.
 479         (ada_is_others_clause): Make static.
 480         (ada_in_variant): Make static.
 481         (ada_attribute_name): Make static.
 482
 483 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 484
 485         * ada-lang.c: Remove includes.
 486         * ada-typeprint.c: Remove includes.
 487         * ada-valprint.c: Remove includes.
 488
 489 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 490
 491         * addrmap.c: Add static assertions of type size, moved from
 492         _initialize_addrmap.
 493         (_initialize_addrmap): Remove.
 494
 495 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 496
 497         * coffread.c (record_minimal_symbol): Update.
 498         (process_coff_symbol): Update.
 499         * dbxread.c (read_dbx_symtab): Update.
 500         * dwarf2read.c (add_partial_symbol): Update.
 501         (fixup_go_packaging): Update.
 502         (load_partial_dies): Update.
 503         (new_symbol): Update.
 504         * elfread.c (record_minimal_symbol): Change signature to use
 505         gdb::string_view instead of name+len.
 506         (elf_symtab_read): Update.
 507         (elf_rel_plt_read): Update.
 508         * mdebugread.c (parse_partial_symbols): Update.
 509         (handle_psymbol_enumerators): Update.
 510         (new_symbol): Update.
 511         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 512         to use gdb::string_view instead of name+len.
 513         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 514         * psympriv.h (add_psymbol_to_list): Likewise.
 515         * psymtab.c (add_psymbol_to_bcache): Likewise.
 516         (add_psymbol_to_list): Likewise.
 517         * stabsread.c (define_symbol): Update.
 518         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 519         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 520         (symbol_set_names): Likewise.
 521         * xcoffread.c (scan_xcoff_symtab): Update.
 522
 523 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 524
 525         * symtab.h (symbol_set_names): Document that copy_name must be
 526         set to true for non-nullterminated strings.
 527         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 528         linkage_name if the entry was not found and we need to demangle.
 529
 530 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 531
 532         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 533         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 534         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 535         * gdbsupport/gdb_binary_search.h: New file.
 536
 537 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 538
 539         * NEWS: Mention new --with-system-gdbinit-dir option.
 540         * config.in: Regenerate.
 541         * configure: Regenerate.
 542         * configure.ac: Add new option --with-system-gdbinit-dir.
 543         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 544         for a ".gdb" suffix.
 545         * main.c (get_init_files): Change system_gdbinit argument to
 546         a vector and return the files in SYSTEM_GDBINIT_DIR in
 547         addition to SYSTEM_GDBINIT.
 548         (captured_main_1): Update.
 549         (print_gdb_help): Update.
 550         * top.c (print_gdb_configuration): Also print the value of
 551         SYSTEM_GDBINIT_DIR.
 552
 553 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 554
 555         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 556         that takes gdb::string_view arguments.
 557
 558 2019-10-26  Tom de Vries  <tdevries@suse.de>
 559
 560         * aarch64-linux-tdep.c: Fix typos in comments.
 561         * aarch64-tdep.c: Same.
 562         * ada-lang.c: Same.
 563         * amd64-nat.c: Same.
 564         * arc-tdep.c: Same.
 565         * arch/aarch64-insn.c: Same.
 566         * block.c: Same.
 567         * breakpoint.h: Same.
 568         * btrace.h: Same.
 569         * c-varobj.c: Same.
 570         * cli/cli-decode.c: Same.
 571         * cli/cli-script.c: Same.
 572         * cli/cli-utils.h: Same.
 573         * coff-pe-read.c: Same.
 574         * coffread.c: Same.
 575         * compile/compile-cplus-symbols.c: Same.
 576         * compile/compile-object-run.c: Same.
 577         * completer.c: Same.
 578         * corelow.c: Same.
 579         * cp-support.c: Same.
 580         * demangle.c: Same.
 581         * dwarf-index-write.c: Same.
 582         * dwarf2-frame.c: Same.
 583         * dwarf2-frame.h: Same.
 584         * eval.c: Same.
 585         * frame-base.h: Same.
 586         * frame.h: Same.
 587         * gdbcmd.h: Same.
 588         * gdbtypes.h: Same.
 589         * gnu-nat.c: Same.
 590         * guile/scm-objfile.c: Same.
 591         * i386-tdep.c: Same.
 592         * i386-tdep.h: Same.
 593         * infcall.c: Same.
 594         * infcall.h: Same.
 595         * linux-nat.c: Same.
 596         * m68k-tdep.c: Same.
 597         * macroexp.c: Same.
 598         * memattr.c: Same.
 599         * mi/mi-cmd-disas.c: Same.
 600         * mi/mi-getopt.h: Same.
 601         * mi/mi-main.c: Same.
 602         * minsyms.c: Same.
 603         * nat/aarch64-sve-linux-sigcontext.h: Same.
 604         * objfiles.h: Same.
 605         * ppc-linux-nat.c: Same.
 606         * ppc-linux-tdep.c: Same.
 607         * ppc-tdep.h: Same.
 608         * progspace.h: Same.
 609         * prologue-value.h: Same.
 610         * python/py-evtregistry.c: Same.
 611         * python/py-instruction.h: Same.
 612         * record-btrace.c: Same.
 613         * record-full.c: Same.
 614         * remote.c: Same.
 615         * rs6000-tdep.c: Same.
 616         * ser-tcp.c: Same.
 617         * sol-thread.c: Same.
 618         * sparc-sol2-tdep.c: Same.
 619         * sparc64-tdep.c: Same.
 620         * stabsread.c: Same.
 621         * symfile.c: Same.
 622         * symtab.h: Same.
 623         * target.c: Same.
 624         * tracepoint.c: Same.
 625         * tui/tui-data.h: Same.
 626         * tui/tui-io.c: Same.
 627         * tui/tui-win.c: Same.
 628         * tui/tui.c: Same.
 629         * unittests/rsp-low-selftests.c: Same.
 630         * user-regs.h: Same.
 631         * utils.c: Same.
 632         * utils.h: Same.
 633         * valarith.c: Same.
 634         * valops.c: Same.
 635         * valprint.c: Same.
 636         * valprint.h: Same.
 637         * value.c: Same.
 638         * value.h: Same.
 639         * varobj.c: Same.
 640         * x86-nat.h: Same.
 641         * xtensa-tdep.c: Same.
 642
 643 2019-10-25  Ali Tamur <tamur@google.com>
 644
 645         * charset.c (find_charset_names): Reflect API change.
 646
 647 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 648
 649         * symtab.c (struct demangled_name_entry): Change demangled name
 650         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 651         part of the struct anymore.
 652         (symbol_set_names): No longer obstack allocate + copy the demangled
 653         name, just store the allocated name from bfd.
 654
 655 2019-10-25  Tom Tromey  <tromey@adacore.com>
 656
 657         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 658         (bsearch_cie_cmp, add_cie): Remove.
 659         (find_cie): Reimplement.
 660         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 661         (dwarf2_build_frame_info): Update.
 662
 663 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 664
 665         PR gdb/25126
 666         * symfile.c (reread_symbols): Call forget_cached_source_info to
 667         clear the stale source cache.
 668
 669 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * configure: Regenerate.
 672         * configure.ac: Remove code that sets python_has_threads.
 673
 674 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 675
 676         * config.in: Regenerate.
 677         * configure: Regenerate.
 678         * configure.ac: Remove the code that uses sed to get the python
 679         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 680
 681 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 684         error paths.
 685
 686 2019-10-23  Tom Tromey  <tom@tromey.com>
 687
 688         * arc-tdep.c: Remove ".." from include.
 689         * frv-tdep.c: Remove ".." from include.
 690         * lm32-tdep.c: Remove ".." from include.
 691         * microblaze-tdep.c: Remove ".." from include.
 692         * or1k-tdep.h: Remove ".." from include.
 693         * s12z-tdep.c: Remove ".." from include.
 694         * Makefile.in (OPCODES_CFLAGS): Add comment.
 695         (TOP_CFLAGS): New variable.
 696         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 697
 698 2019-10-23  Tom Tromey  <tom@tromey.com>
 699
 700         * Makefile.in (READLINE_DIR): Update.
 701
 702 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 703
 704         * infcall.c (call_function_by_hand_dummy): Fix the function
 705         comment.  And extract out a code section into...
 706         (reserve_stack_space): ...this new function.
 707
 708 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 709
 710         * infcall.c (value_arg_coerce): Remove an unused parameter.
 711         (call_function_by_hand_dummy): Update the call to
 712         'value_arg_coerce'.
 713
 714 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 715
 716         * infcall.c (call_function_by_hand_dummy): Refactor.
 717
 718 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 719
 720         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 721
 722 2019-10-23  Tom Tromey  <tom@tromey.com>
 723
 724         * configure: Rebuild.
 725         * configure.ac: Don't check for sigprocmask.
 726         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 727
 728 2019-10-23  Tom Tromey  <tom@tromey.com>
 729
 730         * configure: Rebuild.
 731         * acinclude.m4: Use m4_include, not sinclude.
 732
 733 2019-10-23  Tom de Vries  <tdevries@suse.de>
 734
 735         PR breakpoints/24687
 736         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 737
 738 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 739
 740         * symtab.c (struct demangled_name_entry) <language>: Change from
 741         bitfield to regular variable.
 742
 743 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 744
 745         * symtab.c (struct demangled_name_entry): Add a constructor.
 746         (free_demangled_name_entry): New function to call the destructor
 747         for demangled_name_entry.
 748         (create_demangled_names_hash): Pass free_demangled_name_entry to
 749         htab_create_alloc.
 750         (symbol_set_names): Call placement new for demangled_name_entry.
 751         * utils.c: No longer include xxhash.h here, now that fast_hash
 752         is inlined in the header.
 753         * utils.h: Instead, include it here.
 754
 755 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 756
 757         * Makefile.in: Link with libxxhash.
 758         * config.in: Regenerate.
 759         * configure: Regenerate.
 760         * configure.ac: Search for libxxhash.
 761         * utils.c (fast_hash): Use xxhash if present.
 762
 763 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 764
 765         * utils.h (fast_hash): New function.
 766         * symtab.c (hash_demangled_name_entry): Call new function
 767         fast_hash.
 768
 769 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 770
 771         * symtab.c (struct demangled_name_entry): Change type of mangled
 772         to gdb::string_view. Also adds a constructor that takes the
 773         mangled name.
 774         (hash_demangled_name_entry): Update.
 775         (eq_demangled_name_entry): Update.
 776         (free_demangled_name_entry): New function to call the destructor
 777         now that this is not a POD anymore.
 778         (create_demangled_names_hash): Pass free_demangled_name_entry to
 779         htab_create_alloc.
 780         (symbol_set_names): Update.
 781
 782 2019-10-21  Ali Tamur  <tamu@google.com>
 783
 784         * dwarf2read.c (dir_index): Change type.
 785         (file_name_index): Likewise.
 786         (line_header::include_dir_at): Change comment and implementation on
 787         whether it is DWARF 5.
 788         (line_header::is_valid_file_index): New function.
 789         (line_header::file_name_at): Change comment and implementation on
 790         whether it is DWARF 5.
 791         (line_header::file_names): Change to private field renamed as
 792         m_file_names and introduce a new accessor method.
 793         (line_header::file_names_size): New method.
 794         (line_header::include_dirs): Change to private field and rename as
 795         m_include_dirs.
 796         (dw2_get_file_names_reader): Define local var at a smaller scope and
 797         reflect API change.
 798         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 799         (process_structure_scope): Likewise.
 800         (line_header::add_include_dir): Change message and reflect renaming.
 801         (line_header::add_file_name): Likewise.
 802         (read_formatted_entries): Handle DW_FORM_data16.
 803         (dwarf_decode_line_header): Fix line header length calculation.
 804         (psymtab_include_file_name): Change comment and API.
 805         (lnp_state_machine::m_file): Update comment and reflect type change.
 806         (lnp_state_machine::record_line): Reflect type change.
 807         (dwarf_decode_lines): Reflect API change.
 808         (file_file_name): Likewise.
 809         (file_full_name): Likewise.
 810
 811 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 814
 815 2019-10-21  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 818
 819 2019-10-21  Tom Tromey  <tom@tromey.com>
 820
 821         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 822         NM_H.   Use AC_CONFIG_LINKS.
 823         * configure: Rebuild.
 824         * Makefile.in (NM_H): New variable.
 825         (generated_files): Add NM_H.  Remove gcore.
 826         (nm.h, stamp-nmh): New targets.
 827
 828 2019-10-20  Tom Tromey  <tom@tromey.com>
 829
 830         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 831         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 832         obsolete comment.
 833         (put_objfile_before): Now static.
 834
 835 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 836
 837         * gdbsupport/common-utils.h (startswith): Change return type to
 838         bool.
 839
 840 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 841
 842         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 843         * breakpoint.c (bp_locations_compare): Rename to...
 844         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 845         (update_global_location_list): Use std::sort instead of qsort.
 846         * buildsym.c (compare_line_numbers): Rename to...
 847         (lte_is_less_than): ...this, and change to std::sort semantics.
 848         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 849         instead of qsort.
 850         * disasm.c (compare_lines): Rename to...
 851         (line_is_less_than): ...this, and change to std::sort semantics.
 852         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 853         of qsort.
 854         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 855         (fde_is_less_than): ...this, and change to std::sort semantics.
 856         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 857         * mdebugread.c (compare_blocks):
 858         (block_is_less_than): ...this, and change to std::sort semantics.
 859         (sort_blocks): Call std::sort instead of qsort.
 860         * objfiles.c (qsort_cmp): Rename to...
 861         (sort_cmp): ...this, and change to std::sort semantics.
 862         (update_section_map): Call std::sort instead of qsort.
 863         * remote.c (compare_pnums): Remove.
 864         (map_regcache_remote_table): Call std::sort instead of qsort.
 865         * utils.c (compare_positive_ints): Remove.
 866         * utils.h (compare_positive_ints): Remove.
 867         * xcoffread.c (compare_lte): Remove.
 868         (arrange_linetable): Call std::sort instead of qsort.
 869
 870 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 871
 872         * symfile.c (init_entry_point_info): Fix typo.
 873         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 874
 875 2019-10-18  Tom de Vries  <tdevries@suse.de>
 876
 877         * aarch64-tdep.c: Fix typos in comments.
 878         * ada-lang.c: Same.
 879         * ada-tasks.c: Same.
 880         * alpha-tdep.c: Same.
 881         * alpha-tdep.h: Same.
 882         * amd64-nat.c: Same.
 883         * amd64-windows-tdep.c: Same.
 884         * arc-tdep.c: Same.
 885         * arc-tdep.h: Same.
 886         * arch-utils.c: Same.
 887         * arm-nbsd-tdep.c: Same.
 888         * arm-tdep.c: Same.
 889         * ax-gdb.c: Same.
 890         * blockframe.c: Same.
 891         * btrace.c: Same.
 892         * c-varobj.c: Same.
 893         * coff-pe-read.c: Same.
 894         * coffread.c: Same.
 895         * cris-tdep.c: Same.
 896         * darwin-nat.c: Same.
 897         * dbxread.c: Same.
 898         * dcache.c: Same.
 899         * disasm.c: Same.
 900         * dtrace-probe.c: Same.
 901         * dwarf-index-write.c: Same.
 902         * dwarf2-frame-tailcall.c: Same.
 903         * dwarf2-frame.c: Same.
 904         * dwarf2read.c: Same.
 905         * eval.c: Same.
 906         * exceptions.c: Same.
 907         * fbsd-tdep.c: Same.
 908         * findvar.c: Same.
 909         * frame.c: Same.
 910         * frv-tdep.c: Same.
 911         * gnu-v3-abi.c: Same.
 912         * go32-nat.c: Same.
 913         * h8300-tdep.c: Same.
 914         * hppa-tdep.c: Same.
 915         * i386-linux-tdep.c: Same.
 916         * i386-tdep.c: Same.
 917         * ia64-libunwind-tdep.c: Same.
 918         * ia64-tdep.c: Same.
 919         * infcmd.c: Same.
 920         * infrun.c: Same.
 921         * linespec.c: Same.
 922         * linux-nat.c: Same.
 923         * linux-thread-db.c: Same.
 924         * machoread.c: Same.
 925         * mdebugread.c: Same.
 926         * mep-tdep.c: Same.
 927         * mn10300-tdep.c: Same.
 928         * namespace.c: Same.
 929         * objfiles.c: Same.
 930         * opencl-lang.c: Same.
 931         * or1k-tdep.c: Same.
 932         * osabi.c: Same.
 933         * ppc-linux-nat.c: Same.
 934         * ppc-linux-tdep.c: Same.
 935         * ppc-sysv-tdep.c: Same.
 936         * printcmd.c: Same.
 937         * procfs.c: Same.
 938         * record-btrace.c: Same.
 939         * record-full.c: Same.
 940         * remote-fileio.c: Same.
 941         * remote.c: Same.
 942         * rs6000-tdep.c: Same.
 943         * s12z-tdep.c: Same.
 944         * score-tdep.c: Same.
 945         * ser-base.c: Same.
 946         * ser-go32.c: Same.
 947         * skip.c: Same.
 948         * sol-thread.c: Same.
 949         * solib-svr4.c: Same.
 950         * solib.c: Same.
 951         * source.c: Same.
 952         * sparc-nat.c: Same.
 953         * sparc-sol2-tdep.c: Same.
 954         * sparc-tdep.c: Same.
 955         * sparc64-tdep.c: Same.
 956         * stabsread.c: Same.
 957         * stack.c: Same.
 958         * symfile.c: Same.
 959         * symtab.c: Same.
 960         * target-descriptions.c: Same.
 961         * target-float.c: Same.
 962         * thread.c: Same.
 963         * utils.c: Same.
 964         * valops.c: Same.
 965         * valprint.c: Same.
 966         * value.c: Same.
 967         * varobj.c: Same.
 968         * windows-nat.c: Same.
 969         * xcoffread.c: Same.
 970         * xstormy16-tdep.c: Same.
 971         * xtensa-tdep.c: Same.
 972
 973 2019-10-17  Tom Tromey  <tromey@adacore.com>
 974
 975         * configure: Rebuild.
 976         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 977         in AC_CONFIG_FILES invocation.
 978         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 979         new-style config.status invocation.
 980
 981 2019-10-17  Tom de Vries  <tdevries@suse.de>
 982
 983         * arm-nbsd-nat.c: Fix typos in comments.
 984         * arm-tdep.c: Same.
 985         * darwin-nat-info.c: Same.
 986         * dwarf2read.c: Same.
 987         * elfread.c: Same.
 988         * event-top.c: Same.
 989         * findvar.c: Same.
 990         * gdbtypes.c: Same.
 991         * hppa-tdep.c: Same.
 992         * i386-tdep.c: Same.
 993         * jit.c: Same.
 994         * main.c: Same.
 995         * mdebugread.c: Same.
 996         * moxie-tdep.c: Same.
 997         * nto-procfs.c: Same.
 998         * osabi.c: Same.
 999         * ppc-linux-tdep.c: Same.
1000         * remote.c: Same.
1001         * riscv-tdep.c: Same.
1002         * s390-tdep.c: Same.
1003         * sh-tdep.c: Same.
1004         * sparc-linux-tdep.c: Same.
1005         * sparc-nat.c: Same.
1006         * stack.c: Same.
1007         * target-descriptions.c: Same.
1008         * top.c: Same.
1009         * varobj.c: Same.
1010
1011 2019-10-16  Tom Tromey  <tom@tromey.com>
1012
1013         * objfiles.h (struct objfile) <original_name>: Now const.
1014
1015 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1018         pass on to sigsetjmp's second argument.
1019         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1020
1021 2019-10-16  Keith Seitz  <keiths@redhat.com>
1022
1023         PR gdb/23567
1024         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1025         sections whose size is greater than the file size.
1026
1027 2019-10-16  Jim Wilson  <jimw@sifive.com>
1028
1029         * riscv-tdep.c (riscv_gcc_target_options): New.
1030         (riscv_gnu_triplet_regexp): New.
1031         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1032         set_gdbarch_gnu_triplet_regexp.
1033
1034 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * Makefile.in: Add xml-builtin.h.
1037         * features/feature_to_c.sh: Add an include for xml-builtin.h
1038         to ensure that the compiler checks that the types match.
1039         * xml-builtin.h: New file.
1040         * xml-support.c (fetch_xml_builtin): Add missing const.
1041         * xml-support.h: Remove declaration of xml_builtins.
1042
1043 2019-10-16  Tom de Vries  <tdevries@suse.de>
1044
1045         PR tdep/25096
1046         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1047         (amd64_classify_aggregate): ... here.
1048         (amd64_classify_aggregate_field): Handled fiels of nested structs
1049         recursively.
1050
1051 2019-10-16  Tom de Vries  <tdevries@suse.de>
1052
1053         PR tdep/24104
1054         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1055         that handles 'theclass'.
1056
1057 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * linespec.c (decode_digits_ordinary): Update comment.
1060         * make-target-delegates: No longer need to handle VEC case.
1061         * memrange.c (normalize_mem_ranges): Update comment.
1062         * namespace.c (add_using_directive): Update comment.
1063         * objc-lang.c (uniquify_strings): Update comment.
1064         * ppc-linux-nat.c (struct thread_points): Update comment.
1065         * probe.h (find_probes_in_objfile): Update comment.
1066         * target.h (enum flash_preserve_mode): Update comment.
1067         * varobj.c (varobj_restrict_range): Update comment.
1068         * varobj.h (varobj_list_children): Update comment.
1069
1070 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * Makefile.in: Remove references to vec.h and vec.c.
1073         * aarch64-tdep.c: No longer include vec.h.
1074         * ada-lang.c: Likewise.
1075         * ada-lang.h: Likewise.
1076         * arm-tdep.c: Likewise.
1077         * ax.h: Likewise.
1078         * breakpoint.h: Likewise.
1079         * charset.c: Likewise.
1080         * cp-support.h: Likewise.
1081         * dtrace-probe.c: Likewise.
1082         * dwarf2read.c: Likewise.
1083         * extension.h: Likewise.
1084         * gdb_bfd.c: Likewise.
1085         * gdbsupport/gdb_vecs.h: Likewise.
1086         * gdbsupport/vec.c: Remove.
1087         * gdbsupport/vec.h: Remove.
1088         * gdbthread.h: Likewise.
1089         * guile/scm-type.c: Likewise.
1090         * inline-frame.c: Likewise.
1091         * machoread.c: Likewise.
1092         * memattr.c: Likewise.
1093         * memrange.h: Likewise.
1094         * namespace.h: Likewise.
1095         * nat/linux-btrace.h: Likewise.
1096         * osdata.c: Likewise.
1097         * parser-defs.h: Likewise.
1098         * progspace.h: Likewise.
1099         * python/py-type.c: Likewise.
1100         * record-btrace.c: Likewise.
1101         * rust-exp.y: Likewise.
1102         * solib-target.c: Likewise.
1103         * stap-probe.c: Likewise.
1104         * target-descriptions.c: Likewise.
1105         * target-memory.c: Likewise.
1106         * target.h: Likewise.
1107         * varobj.c: Likewise.
1108         * varobj.h: Likewise.
1109         * xml-support.h: Likewise.
1110
1111 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1114         Update for new std::vector based implementation.
1115         (process_psymtab_comp_unit_reader): Likewise.
1116         (scan_partial_symbols): Likewise.
1117         (recursively_compute_inclusions): Likewise.
1118         (compute_compunit_symtab_includes): Likewise.
1119         (process_imported_unit_die): Likewise.
1120         (queue_and_load_dwo_tu): Likewise.
1121         (follow_die_sig_1): Likewise.
1122         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1123         (typedef dwarf2_per_cu_ptr): Remove.
1124         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1125         function.
1126         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1127         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1128         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1129         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1130         std::vector.
1131
1132 2019-10-15  Tom Tromey  <tromey@adacore.com>
1133
1134         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1135         TID.
1136
1137 2019-10-15  Tom Tromey  <tromey@adacore.com>
1138
1139         * windows-nat.c (windows_nat_target::fetch_registers)
1140         (windows_nat_target::store_registers): Rename "pid" to "tid".
1141
1142 2019-10-15  Tom Tromey  <tromey@adacore.com>
1143
1144         * gdbarch.h, gdbarch.c: Rebuild.
1145         * gdbarch.sh (gcc_target_options): Change return type to
1146         std::string.
1147         * compile/compile.c (get_args): Update.
1148         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1149         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1150         std::string.
1151         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1152         std::string.
1153         * arch-utils.c (default_gcc_target_options): Return std::string.
1154         * arch-utils.h (default_gcc_target_options): Return std::string.
1155         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1156
1157 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1158
1159         * breakpoint.c (breakpoint_chain): Make static.
1160         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1161         of accessing breakpoint_chain.
1162
1163 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1164
1165         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1166         to a gdb::function_view and return value to bool.
1167         * breakpoint.h (iterate_over_breakpoints): Likewise.
1168         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1169         (pop_dummy_frame): Update.
1170         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1171         (gdbscm_breakpoints): Update.
1172         * python/py-breakpoint.c (build_bp_list): Update.
1173         (gdbpy_breakpoints): Update.
1174         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1175         Update.
1176         (bpfinishpy_handle_stop): Update.
1177         (bpfinishpy_handle_exit): Update.
1178         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1179         (svr4_update_solib_event_breakpoints): Update.
1180
1181 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1182
1183         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1184         when unwrapping single-field structs.
1185
1186 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1187
1188         * dwarf2read.c: Remove includes.
1189
1190 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1191
1192         * ui-out.c (ui_out::call_do_message): Silence
1193         -Wformat-nonliteral warning.
1194
1195 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1196
1197         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1198         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1199         include: readline/tilde.h.
1200
1201 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1202
1203         * remote.c (remote_target::get_trace_status): Remove declaration of
1204         trace_regblock_size.
1205
1206 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1209         (show_user): Remove declaration of cmdlist.
1210         * cli/cli-cmds.h (max_user_call_depth): Declare.
1211         * cli/cli-script.c (execute_user_command): Remove declaration
1212         of max_user_call_depth.
1213
1214 2019-10-11  Jim Wilson  <jimw@sifive.com>
1215
1216         * gdbsupport/print-utils.h (pulongest): Fix comment.
1217         (plongest): Likewise.
1218         (phex): Add missing comment, mention leading zeros.
1219         (phex_nz): Add mention of no leading zeros to comment.
1220
1221         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1222         plongest instead of unsigned long long cast.
1223
1224 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1225
1226         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1227         for external_editor_command and gdbtk_test.
1228
1229 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1230
1231         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1232         * varobj.c (varobjdebug): Move comment to...
1233         * varobj.h (varobjdebug): ...here, and declare.
1234
1235 2019-10-09  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1238         erase_data_content.
1239
1240 2019-10-09  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1243         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1244         * tui/tui-command.c (tui_cmd_window::resize)
1245         (tui_refresh_cmd_win): Update.
1246         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1247         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1248         * tui/tui-data.c (~tui_gen_win_info): Remove.
1249         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1250         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1251         (tui_redisplay_readline, tui_mld_flush)
1252         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1253         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1254         (tui_data_window::erase_data_content)
1255         (tui_data_item_window::rerender)
1256         (tui_data_item_window::refresh_window): Update.
1257         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1258         (box_win, tui_gen_win_info::make_window)
1259         (tui_gen_win_info::make_visible): Update.
1260         (tui_delete_win): Remove.
1261         * tui/tui-winsource.c
1262         (tui_source_window_base::do_erase_source_content): Update.
1263         (tui_show_source_line, tui_source_window_base::update_tab_width)
1264         (tui_source_window_base::update_exec_info): Update.
1265         * tui/tui-data.h (struct curses_deleter): New.
1266         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1267         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1268
1269 2019-10-09  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1272
1273 2019-10-09  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1276         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1277
1278 2019-10-09  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1281         window height directly.
1282         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1283         declare.
1284         * tui/tui-layout.c (tui_default_win_height): Remove.
1285         (tui_default_win_viewport_height): Remove.
1286
1287 2019-10-09  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui.h: Remove comments.
1290
1291 2019-10-09  Tom de Vries  <tdevries@suse.de>
1292
1293         * python/lib/gdb/printer/bound_registers.py: Use
1294         '^builtin_type_bound128' as regexp argument for
1295         add_builtin_pretty_printer.
1296
1297 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1298
1299         * guile/guile.c (guile_extension_script_ops): Remove forward
1300         declaration and mark as static.
1301         (guile_script_ops): Likewise.
1302         (extension_language_guile): Move further down in the file so
1303         it can reference the definitions for guile_{extension_,}script_ops.
1304
1305 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1306
1307         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1308         except SORTL, DFLTCC, and KDSA.
1309
1310 2019-10-08  Tom Tromey  <tromey@adacore.com>
1311
1312         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1313         (struct safe_symbol_file_add_args): Remove.
1314
1315 2019-10-08  Tom Tromey  <tromey@adacore.com>
1316
1317         * windows-nat.c: Don't include buildsym-legacy.h.
1318
1319 2019-10-08  Tom Tromey  <tromey@adacore.com>
1320
1321         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1322
1323 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1324
1325         * gdbtypes.c (overload_debug): Move comment to header.
1326         * gdbtypes.h (overload_debug): Declare.
1327         * valops.c: Remove declaration of overload_debug, instead
1328         include gdbtypes.h.
1329
1330 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1331
1332         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1333         through _().
1334         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1335         move comment...
1336         * language.h (lang_frame_mismatch_warn): ... here. Also add
1337         declaration.
1338         * top.c (lang_frame_mismatch_warn): Remove declaration.
1339         (check_frame_language_change): Pass lang_frame_mismatch_warn
1340         through _().
1341
1342 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1343
1344         * c-lang.h (vtbl_ptr_name): Declare.
1345         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1346         it from the header.
1347         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1348
1349 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1350
1351         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1352         gdb_static_assert.
1353
1354 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1355
1356         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1357         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1358         * ctfread.c: New file.
1359         * ctfread.h: New file.
1360         * elfread.c: Include ctfread.h.
1361         (struct elfinfo text_p): New member ctfsect.
1362         (elf_locate_sections): Mark CTF section.
1363         (elf_symfile_read): Call elfctf_build_psymtabs.
1364         * Makefile.in (LIBCTF): Add.
1365         (CLIBS): Use it.
1366         (CDEPS): Likewise.
1367         (DIST): Add ctfread.c.
1368
1369 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1370
1371         * ctfread.c (struct nextfield): Renamed to ...
1372         (struct ctf_nextfield): ... this.
1373         (struct field_info): Renamed to ...
1374         (strut ctf_field_info): ... this.
1375         (attach_fields_to_type): Update for renamed structures.
1376         (ctf_add_member_cb): Likewise.
1377         (ctf_add_enum_member_cb): Likewise.
1378         (process_struct_members): Likewise.
1379         (process_enum_type): Likewise.
1380
1381 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1382
1383         * tracectf.h: Rename, was ctf.h.
1384         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1385         * tracefile.c: Likewise.
1386         * tracepoint.c: Remove unused include ctf.h.
1387         * mi/mi-main.c: Likewise.
1388         * Makefile.in Replace ctf.c with tracectf.c.
1389
1390 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1391
1392         * version.in: Change version number to "9.0.50.DATE-git".
1393
1394 2019-10-03  Tom Tromey  <tom@tromey.com>
1395
1396         PR rust/24976:
1397         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1398
1399 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1402         cp_search_name_hash.
1403         * NEWS: Add entry about nested function support.
1404
1405 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1406             Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1409         for nested static variables when searchin VAR_DOMAIN.
1410         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1411         global scope, update comment.
1412         (add_partial_subprogram): Call add_partial_subprogram recursively
1413         for nested subroutines when processinng Fortran.
1414         (load_partial_dies): Process the child entities of a subprogram
1415         when processing Fortran.
1416         (partial_die_parent_scope): Handle building scope
1417         for Fortran nested functions.
1418         (process_die): Record that nested functions have a scope.
1419         (new_symbol): Always record Fortran subprograms on the global
1420         symbol list.
1421         (determine_prefix): How to build the prefix for Fortran
1422         subprograms.
1423
1424 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1427         have just sent the thread a SIGSTOP and are waiting for it to
1428         arrive.
1429
1430 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * btrace.c (btrace_add_pc): Remove whitespace before the template
1433         parameter in 'std::vector <...>'.
1434         (parse_xml_btrace_block): Likewise.
1435         (btrace_maint_decode_pt): Likewise.
1436         (btrace_maint_update_packets): Likewise.
1437         (btrace_maint_print_packets): Likewise.
1438         * btrace.h (struct btrace_maint_info): Likewise.
1439         * dwarf2read.c (struct type_unit_group): Likewise.
1440         (build_type_psymtabs_reader): Likewise.
1441         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1442         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1443         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1444
1445 2019-10-03  Tom de Vries  <tdevries@suse.de>
1446
1447         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1448         the first line of the help text for set/show style metadata.
1449
1450 2019-10-02  Tom Tromey  <tromey@adacore.com>
1451
1452         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1453         * gdbsupport/common-inferior.c: New file.
1454         * infcmd.c (startup_with_shell): Don't define.
1455         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1456         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1457         * inferior.h (startup_with_shell): Don't declare.
1458
1459 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1460
1461         * gdbsupport/gdb_assert.h: Include errors.h.
1462         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1463
1464 2019-10-02  Tom Tromey  <tromey@adacore.com>
1465
1466         * NEWS: Add $_ada_exception entry.
1467         * ada-lang.c (struct ada_catchpoint): Add constructor.
1468         <m_kind>: New member.
1469         (allocate_location_exception, re_set_exception): Remove
1470         "ex" parameter.
1471         (should_stop_exception): Compute $_ada_exception.
1472         (check_status_exception, print_it_exception)
1473         (print_one_exception, print_mention_exception): Remove
1474         "ex" parameter.
1475         (allocate_location_catch_exception, re_set_catch_exception)
1476         (check_status_exception, print_it_catch_exception)
1477         (print_one_catch_exception, print_mention_catch_exception)
1478         (print_recreate_catch_exception)
1479         (allocate_location_catch_exception_unhandled)
1480         (re_set_catch_exception_unhandled)
1481         (check_status_exception, print_it_catch_exception_unhandled)
1482         (print_one_catch_exception_unhandled)
1483         (print_mention_catch_exception_unhandled)
1484         (print_recreate_catch_exception_unhandled)
1485         (allocate_location_catch_assert, re_set_catch_assert)
1486         (check_status_assert, print_it_catch_assert)
1487         (print_one_catch_assert, print_mention_catch_assert)
1488         (print_recreate_catch_assert)
1489         (allocate_location_catch_handlers, re_set_catch_handlers)
1490         (check_status_handlers, print_it_catch_handlers)
1491         (print_one_catch_handlers, print_mention_catch_handlers)
1492         (print_recreate_catch_handlers): Remove.
1493         (create_ada_exception_catchpoint): Update.
1494         (initialize_ada_catchpoint_ops): Update.
1495
1496 2019-10-02  Tom Tromey  <tromey@adacore.com>
1497
1498         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1499         (create_excep_cond_exprs): Simplify exception string computation.
1500         (ada_exception_catchpoint_cond_string): Likewise.
1501
1502 2019-10-02  Tom Tromey  <tromey@adacore.com>
1503
1504         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1505         * ada-lang.c (lesseq_defined_than): Handle
1506         LOC_STATIC.
1507         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1508         parameter.
1509         (dwarf2_has_info): Likewise.
1510         (new_symbol): Set maybe_copied on symbol when
1511         appropriate.
1512         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1513         parameter.
1514         <can_copy>: New member.
1515         * elfread.c (record_minimal_symbol): Set maybe_copied
1516         on symbol when appropriate.
1517         (elf_symfile_read): Update call to dwarf2_has_info.
1518         * minsyms.c (lookup_minimal_symbol_linkage): New
1519         function.
1520         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1521         * symtab.c (get_symbol_address, get_msymbol_address):
1522         New functions.
1523         * symtab.h (get_symbol_address, get_msymbol_address):
1524         Declare.
1525         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1526         maybe_copied.
1527         (struct symbol, struct minimal_symbol) <maybe_copied>:
1528         New member.
1529
1530 2019-10-02  Tom Tromey  <tromey@adacore.com>
1531
1532         * source.c (struct current_source_location): New.
1533         (current_source_key): New global.
1534         (current_source_symtab, current_source_line)
1535         (current_source_pspace): Remove.
1536         (get_source_location): New function.
1537         (get_current_source_symtab_and_line)
1538         (set_default_source_symtab_and_line)
1539         (set_current_source_symtab_and_line)
1540         (clear_current_source_symtab_and_line, select_source_symtab)
1541         (info_source_command, print_source_lines_base)
1542         (info_line_command, search_command_helper, _initialize_source):
1543         Update.
1544
1545 2019-10-02  Tom Tromey  <tromey@adacore.com>
1546
1547         * source.c (select_source_symtab): Don't call
1548         decode_line_with_current_source.
1549
1550 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * symtab.c (lookup_global_symbol): Search global block.
1553
1554 2019-10-02  Tom Tromey  <tromey@adacore.com>
1555
1556         * coffread.c (process_coff_symbol): Update.
1557         * dwarf2read.c (var_decode_location, new_symbol): Update.
1558         * mdebugread.c (parse_symbol): Update.
1559         * objfiles.c (relocate_one_symbol): Update.
1560         * stabsread.c (define_symbol, fix_common_block)
1561         (scan_file_globals): Update.
1562         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1563         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1564         * xcoffread.c (process_xcoff_symbol): Update.
1565
1566 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1567
1568         * MAINTAINERS: Update my email address.
1569
1570 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1571
1572         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1573         std::vector.
1574         (build_type_psymtabs_reader): Update for std::vector.
1575         (build_type_psymtab_dependencies): Likewise.
1576         * dwarf2read.h: Remove use of DEF_VEC_P.
1577         (typedef sig_type_ptr): Delete.
1578
1579 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1582         to std::vector.
1583         (btrace_maint_decode_pt): Likewise, and move allocation of the
1584         vector outside of the loop.
1585         (btrace_maint_update_packets): Update to handle change from VEC to
1586         std::vector.
1587         (btrace_maint_print_packets): Likewise.
1588         (maint_info_btrace_cmd): Likewise.
1589         * btrace.h: Remove use of DEF_VEC_O.
1590         (typedef btrace_pt_packet_s): Delete.
1591         (struct btrace_maint_info) <packets>: Change fromm VEC to
1592         std::vector.
1593         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1594
1595 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1598         make accesses into the vector constant references.
1599         (btrace_add_pc): Update for std::vector.
1600         (btrace_stitch_bts): Likewise.
1601         (parse_xml_btrace_block): Likewise.
1602         (btrace_maint_update_packets): Likewise.
1603         (btrace_maint_print_packets): Likewise.
1604         (maint_info_btrace_cmd): Likewise.
1605         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1606         std::vector.
1607         (btrace_data::empty): Likewise.
1608         (btrace_data_append): Likewise.
1609         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1610         (typedef btrace_block_s): Delete.
1611         (struct btrace_block): Add constructor.
1612         (struct btrace_data_bts) <blocks>: Change to std::vector.
1613         * nat/linux-btrace.c (perf_event_read_bts): Update for
1614         std::vector.
1615         (linux_read_bts): Likewise.
1616
1617 2019-10-01  Tom Tromey  <tom@tromey.com>
1618
1619         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1620
1621 2019-10-01  Tom Tromey  <tom@tromey.com>
1622
1623         * stack.c (print_frame, info_frame_command_core): Use
1624         styled_string.
1625         * linux-thread-db.c (try_thread_db_load_1)
1626         (try_thread_db_load_from_pdir_1): Use styled_string.
1627         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1628         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1629         (maybe_print_unsupported_script_warning)
1630         (maybe_print_script_not_found_warning): Use styled_string.
1631         * ada-lang.c (user_select_syms): Use styled_string.
1632
1633 2019-10-01  Tom Tromey  <tom@tromey.com>
1634
1635         * p-lang.c (pascal_printstr): Use metadata style.
1636         * value.c (show_convenience): Use metadata style.
1637         * valprint.c (valprint_check_validity, val_print_optimized_out)
1638         (val_print_not_saved, val_print_unavailable)
1639         (val_print_invalid_address, generic_val_print, val_print)
1640         (value_check_printable, val_print_array_elements): Use metadata
1641         style.
1642         * ui-out.h (class ui_out) <field_fmt>: New overload.
1643         <do_field_fmt>: Add style parameter.
1644         * ui-out.c (ui_out::field_fmt): New overload.
1645         * typeprint.c (type_print_unknown_return_type)
1646         (val_print_not_allocated, val_print_not_associated): Use metadata
1647         style.
1648         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1649         parameter.
1650         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1651         * tracepoint.c (tvariables_info_1): Use metadata style.
1652         * stack.c (print_frame_arg, print_frame_info, print_frame)
1653         (info_frame_command_core): Use metadata style.
1654         * skip.c (info_skip_command): Use metadata style.
1655         * rust-lang.c (rust_print_enum): Use metadata style.
1656         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1657         metadata style.
1658         * python/py-framefilter.c (py_print_single_arg): Use metadata
1659         style.
1660         * printcmd.c (do_one_display, print_variable_and_value): Use
1661         metadata style.
1662         * p-valprint.c (pascal_val_print)
1663         (pascal_object_print_value_fields): Use metadata style.
1664         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1665         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1666         parameter.
1667         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1668         * m2-valprint.c (m2_print_long_set): Use metadata style.
1669         * m2-typeprint.c (m2_print_type): Use metadata style.
1670         * infcmd.c (print_return_value_1): Use metadata style.
1671         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1672         * f-valprint.c (info_common_command_for_block): Use metadata
1673         style.
1674         * f-typeprint.c (f_type_print_base): Use metadata style.
1675         * expprint.c (print_subexp_standard): Use metadata style.
1676         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1677         * cli/cli-style.h (class cli_style_option): Add constructor.
1678         (metadata_style): Declare.
1679         * cli/cli-style.c (metadata_style): New global.
1680         (_initialize_cli_style): Register metadata style.
1681         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1682         parameter.
1683         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1684         * c-typeprint.c (c_type_print_base_struct_union)
1685         (c_type_print_base_1): Use metadata style.
1686         * breakpoint.c (watchpoint_value_print)
1687         (print_one_breakpoint_location): Use metadata style.
1688         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1689         style.
1690         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1691         style.
1692         * ada-valprint.c (val_print_packed_array_elements, printstr)
1693         (print_field_values, ada_val_print_ref, ada_val_print): Use
1694         metadata style.
1695         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1696         style.
1697         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1698         style.
1699         * ada-lang.c (user_select_syms): Use metadata style.
1700
1701 2019-10-01  Tom Tromey  <tom@tromey.com>
1702
1703         * cli/cli-cmds.c (pwd_command): Style output.
1704
1705 2019-10-01  Pedro Alves  <palves@redhat.com>
1706             Tom Tromey  <tom@tromey.com>
1707
1708         * symtab.c (print_symbol_info): Use %ps.
1709         (print_msymbol_info): Use %ps.
1710         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1711         * printcmd.c (print_variable_and_value): Use %ps.
1712         * macrocmd.c (show_pp_source_pos): Use %ps.
1713         * infrun.c (print_exited_reason): Use ui_out::message.
1714         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1715         (describe_other_breakpoints): Use ui_out::message and new
1716         formats.
1717         (say_where): Use new formats.
1718         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1719         and new formats.
1720
1721 2019-10-01  Pedro Alves  <palves@redhat.com>
1722             Tom Tromey  <tom@tromey.com>
1723
1724         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1725         (test_gdb_formats): New function.
1726         (run_tests): Call it.
1727         (test_format_specifier): Update.
1728         * utils.h (fputs_filtered): Update comment.
1729         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1730         (fputs_styled_unfiltered): Declare.
1731         * utils.c (fputs_styled_unfiltered): New function.
1732         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1733         (vfprintf_filtered): Update.
1734         (vfprintf_unfiltered, vprintf_filtered): Update.
1735         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1736         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1737         disallow_ui_out_field>: New constants.
1738         (enum class field_kind): New.
1739         (struct base_field_s, struct signed_field_s): New.
1740         (signed_field): New function.
1741         (struct string_field_s): New.
1742         (string_field): New function.
1743         (struct styled_string_s): New.
1744         (styled_string): New function.
1745         (class ui_out) <message>: Add comment.
1746         <vmessage, call_do_message>: New methods.
1747         <do_message>: Add style parameter.
1748         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1749         methods.
1750         (ui_out::message): Rewrite.
1751         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1752         parameter.
1753         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1754         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1755         gdb_extensions parameter.
1756         (class format_piece): Add parameter to constructor.
1757         (n_int_args): New field.
1758         * gdbsupport/format.c (format_pieces::format_pieces): Add
1759         gdb_extensions parameter.  Handle '*'.
1760         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1761         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1762         vfprintf_styled_no_gdbfmt.
1763         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1764         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1765         unfiltered output.
1766         * ui-style.h (struct ui_file_style) <ptr>: New method.
1767
1768 2019-10-01  Tom Tromey  <tom@tromey.com>
1769
1770         * unittests/format_pieces-selftests.c: Update.  Add final format.
1771         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1772         empty literal pieces.
1773
1774 2019-10-01  Tom Tromey  <tom@tromey.com>
1775
1776         * ui-out.h (enum class ui_out_style_kind): Remove.
1777         (class ui_out) <field_string, field_stsream, do_field_string>:
1778         Change type of "style".
1779         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1780         (ui_out::field_string): Update.
1781         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1782         of "style".
1783         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1784         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1785         * stack.c (print_frame_arg, print_frame_info, print_frame):
1786         Update.
1787         * source.c (print_source_lines_base): Update.
1788         * solib.c (info_sharedlibrary_command): Update.
1789         * skip.c (info_skip_command): Update.
1790         * record-btrace.c (btrace_call_history_src_line)
1791         (btrace_call_history): Update.
1792         * python/py-framefilter.c (py_print_frame): Update.
1793         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1794         "style".
1795         * mi/mi-out.c (mi_ui_out::do_table_header)
1796         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1797         (mi_ui_out::do_field_string): Update.
1798         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1799         Update.
1800         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1801         "style".
1802         * cli-out.c (cli_ui_out::do_table_header)
1803         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1804         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1805         (cli_ui_out::do_field_fmt): Update.
1806         * breakpoint.c (print_breakpoint_location): Update.
1807         (update_static_tracepoint): Update.
1808
1809 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1810
1811         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1812         conversion of gdb_datadir.
1813         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1814         remove not needed c_str ().
1815
1816 2019-09-30  Ali Tamur <tamur@google.com>
1817
1818         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1819         (dwarf2_string_attr): Likewise.
1820
1821 2019-09-30  Ali Tamur <tamur@google.com>
1822
1823         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1824         (process_full_type_unit): Likewise.
1825         (dump_die_shallow): Likewise.
1826         (cu_debug_loc_section): Likewise.
1827
1828 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1829
1830         * minsyms.c (compare_minimal_symbols): Rename to...
1831         (minimal_symbol_is_less_than): ...this, and adjust to STL
1832         conventions (return bool, take arguments as references)
1833         (minimal_symbol_reader::install): Call std::sort instead
1834         of qsort.
1835
1836 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1837
1838         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1839         hash and why.
1840         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1841         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1842
1843 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1844
1845         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1846         * psympriv.h (add_psymbol_to_list): Move comment here and update
1847         it.
1848
1849 2019-09-29  Tom de Vries  <tdevries@suse.de>
1850
1851         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1852         Use $tmpdir/$(basename "$output_file").dwz instead of
1853         "${output_file}.dwz".
1854
1855 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1856
1857         PR gdb/25045
1858         * hppa-linux-nat.c: Include gdbarch.h.
1859
1860 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1861
1862         * blockframe.c (find_pc_partial_function): Change return type to bool.
1863         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1864         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1865         (stub_gnu_ifunc_resolve_name): Likewise.
1866         * symtab.c (compare_filenames_for_search): Likewise.
1867         (compare_glob_filenames_for_search): Likewise.
1868         (matching_obj_sections): Likewise.
1869         (symbol_matches_domain): Likewise.
1870         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1871         (find_line_pc): Change return type to bool.
1872         (find_line_pc_range): Likewise.
1873         (producer_is_realview): Likewise.
1874         * symtab.h (symbol_matches_domain): Likewise.
1875         (find_pc_partial_function): Likewise.
1876         (find_pc_line_pc_range): Likewise.
1877         (in_gnu_ifunc_stub): Likewise.
1878         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1879         (find_line_pc): Likewise.
1880         (find_line_pc_range): Likewise.
1881         (matching_obj_sections): Likewise.
1882         (find_line_symtab): Change out parameter to bool.
1883         (producer_is_realview): Change return type to bool.
1884         (compare_filenames_for_search): Likewise.
1885         (compare_glob_filenames_for_search): Likewise.
1886
1887 2019-09-26  Tom Tromey  <tom@tromey.com>
1888
1889         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1890         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1891         * gdb_usleep.h: Remove.
1892         * gdb_usleep.c: Remove.
1893         * utils.c: Don't include gdb_usleep.h.
1894
1895 2019-09-26  Tom Tromey  <tromey@adacore.com>
1896
1897         * python/py-type.c (type_to_type_object): Call check_typedef
1898         for stub types.
1899
1900 2019-09-26  Tom Tromey  <tom@tromey.com>
1901
1902         * utils.h (initialize_utils): Don't declare.
1903         * top.c (gdb_init): Don't call initialize_utils.
1904         * utils.c (initialize_utils): Remove.  Move contents...
1905         (_initialize_utils): ... here.
1906
1907 2019-09-25  Tom Tromey  <tom@tromey.com>
1908
1909         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1910         * utils.h (make_hex_string): Don't declare.
1911         * utils.c (make_hex_string): Remove.
1912
1913 2019-09-24  Tom de Vries  <tdevries@suse.de>
1914
1915         PR gdb/23815
1916         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1917         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1918
1919 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1920
1921         * NEWS: Mention new simulator port for PRU.
1922
1923 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1924
1925         * ada-exp.y (write_object_remaining): Update.
1926         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1927         and eliminate the static buffer.
1928         (ada_decode_symbol): Update.
1929         (ada_la_decode): Update.
1930         (ada_sniff_from_mangled_name): Update.
1931         (is_valid_name_for_wild_match): Update.
1932         (ada_lookup_name_info::matches): Update and simplify.
1933         (name_matches_regex): Update.
1934         (ada_add_global_exceptions): Update.
1935         * ada-lang.h (ada_decode): Update signature.
1936         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1937         * dwarf-index-write.c (debug_names::insert): Update.
1938
1939 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1940
1941         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1942         formatting.
1943
1944 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1945
1946         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1947         Change "nonzero" to "true" in documentation.
1948
1949 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1950
1951         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1952         (_initialize_darwin_solib): Don't set
1953         darwin_so_ops.lookup_lib_global_symbol.
1954         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1955         set_gdbarch_iterate_over_objfiles_in_search_order.
1956         (elf_lookup_lib_symbol): Rename to...
1957         (svr4_iterate_over_objfiles_in_search_order): this, and update
1958         to iterate semantics.
1959         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1960         * solib.c (solib_global_lookup): Remove.
1961         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1962         (solib_global_lookup): Remove.
1963         * symtab.c (lookup_global_or_static_symbol): Remove call to
1964         solib_global_lookup.
1965
1966 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1967
1968         * NEWS: Move entries about default MI version now being
1969         version 3, and about the GDB/MI fix for multi-location
1970         breakpoints to the "since GDB 8.3" section.
1971
1972 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1973
1974         GDB 8.3.1 released.
1975
1976 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1977
1978         * NEWS: Mention that Cell/B.E. debugging support was removed.
1979         * MAINTAINERS: Remove spu target.
1980
1981         * config/djgpp/fnchange.lst: Remove entries for removed files.
1982
1983         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1984         spu-multiarch.o, and spu-tdep.o.
1985         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1986         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1987         spu-multiarch.c, and spu-tdep.c.
1988         * spu-linux-nat.c: Remove file.
1989         * spu-multiarch.c: Remove file.
1990         * spu-tdep.c: Remove file.
1991         * spu-tdep.h: Remove file.
1992         * solib-spu.c: Remove file.
1993         * solib-spu.h: Remove file.
1994
1995         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1996         * configure.nat (spu-linux): Remove.
1997         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1998         solib-multiarch.o from gdb_target_obs.
1999         (spu*-*-*): Remove.
2000
2001         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2002         feature flag.
2003         (ppc_linux_no_features): Update.
2004         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2005         Cell/B.E. support.
2006         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2007         (tdesc_powerpc_cell64l): Likewise.
2008         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2009         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2010         Cell/B.E. support.
2011         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2012         Do not include "features/rs6000/powerpc-cell32l.c" or
2013         "features/rs6000/powerpc-cell64l.c".
2014         (ppc_linux_spu_section): Remove.
2015         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2016         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2017         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2018         (ppc_linux_spe_context_lookup): Remove.
2019         (ppc_linux_spe_context_inferior_created): Remove.
2020         (ppc_linux_spe_context_solib_loaded): Remove.
2021         (ppc_linux_spe_context_solib_unloaded): Remove.
2022         (ppc_linux_spe_context): Remove.
2023         (struct ppu2spu_cache): Remove.
2024         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2025         (struct ppu2spu_data): Remove.
2026         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2027         ppu2spu_unwind): Remove.
2028         (ppc_linux_init_abi): Remove Cell/B.E. support.
2029         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2030
2031         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2032         (rs6000/powerpc-cell64l-expedite): Likewise
2033         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2034         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2035         rs6000/powerpc-cell64l.xml.
2036         * features/rs6000/powerpc-cell32l.xml: Remove.
2037         * features/rs6000/powerpc-cell64l.xml: Likewise.
2038         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2039         * features/rs6000/powerpc-cell64l.c: Likewise.
2040         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2041         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2042         * regformats/reg-spu.dat: Remove.
2043
2044         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2045         * corelow.c (struct spuid_list): Remove.
2046         (add_to_spuid_list): Remove.
2047         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2048         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2049         (remote_protocol_features): Remove associated entries.
2050         (_initialize_remote): No longer initialize them.
2051         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2052         * linux-nat.c (SPUFS_MAGIC): Remove.
2053         (linux_proc_xfer_spu): Remove.
2054         (spu_enumerate_spu_ids): Remove.
2055         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2056         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2057         (linux_make_corefile_notes): No longer call it.
2058
2059         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2060         (cooked_write_test): Likewise.
2061
2062 2019-09-20  Tom Tromey  <tom@tromey.com>
2063
2064         * NEWS: Mention case-sensitivity of TUI commands.
2065         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2066         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2067         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2068
2069 2019-09-20  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-source.c (tui_source_window::set_contents): Use
2072         make_unique_xstrdup.
2073         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2074         make_unique_xstrdup.
2075
2076 2019-09-20  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-data.c: Remove separator comments.
2079         * tui/tui-layout.c: Remove separator comments.
2080         * tui/tui-win.c: Remove separator comments.
2081         * tui/tui-wingeneral.c: Remove separator comments.
2082
2083 2019-09-20  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui.h (strcat_to_buf): Don't declare.
2086         * tui/tui.c (strcat_to_buf): Remove.
2087
2088 2019-09-20  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2091         from "fullname".
2092         * tui/tui-source.c (tui_source_window::set_contents)
2093         (tui_source_window::location_matches_p)
2094         (tui_source_window::maybe_update): Update.
2095
2096 2019-09-20  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2099         Update.
2100         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2101         prefix.
2102         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2103         (tui_data_window::line_from_reg_element_no)
2104         (tui_data_window::first_reg_element_no_inline)
2105         (tui_data_window::show_registers)
2106         (tui_data_window::show_register_group)
2107         (tui_data_window::display_registers_from)
2108         (tui_data_window::display_registers_from_line)
2109         (tui_data_window::first_data_item_displayed)
2110         (tui_data_window::delete_data_content_windows)
2111         (tui_data_window::erase_data_content)
2112         (tui_data_window::do_scroll_vertical)
2113         (tui_data_window::refresh_window)
2114         (tui_data_window::check_register_values): Update.
2115
2116 2019-09-20  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2119         (struct tui_locator_window) <full_name, proc_name>: Now
2120         std::string.
2121         * tui/tui-stack.c (tui_locator_window::make_status_line)
2122         (tui_locator_window::set_locator_fullname)
2123         (tui_locator_window::set_locator_info): Update.
2124         * tui/tui-source.c (tui_source_window::set_contents)
2125         (tui_source_window::showing_source_p): Update.
2126
2127 2019-09-20  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2130         Don't call tui_locator_win_info_ptr.
2131
2132 2019-09-20  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2135
2136 2019-09-20  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2139         height for locator.
2140         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2141         * tui/tui-layout.c (show_source_disasm_command, show_data)
2142         (show_source_or_disasm_and_command): Use 1 as height for locator.
2143
2144 2019-09-20  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui.c (tui_enable): Update.
2147         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2148         Update.
2149         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2150         Update.
2151         * tui/tui-data.c (win_resized): Now bool.
2152         (tui_win_resized): Return bool.
2153         (tui_set_win_resized_to): Accept a bool.
2154
2155 2019-09-20  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2158         Change type of "refresh_values_only".
2159         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2160         type of "refresh_values_only".
2161
2162 2019-09-20  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2165         std::string.
2166         (tui_disassemble): Add "pos" parameter.
2167         (tui_disasm_window::set_contents): Simplify.
2168
2169 2019-09-20  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-winsource.h (struct tui_source_window_base)
2172         <show_source_content>: Now private.
2173         * tui/tui-winsource.c
2174         (tui_source_window_base::show_source_content): Don't handle empty
2175         content case.
2176
2177 2019-09-20  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-layout.c (show_source_disasm_command)
2180         (show_source_or_disasm_and_command): Don't call
2181         show_source_content.
2182
2183 2019-09-20  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2186         Declare.
2187         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2188         from tui_make_status_line.
2189         (tui_locator_window::rerender): Update.
2190
2191 2019-09-20  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2194         (tui_locator_window::rerender): Update.
2195
2196 2019-09-20  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-winsource.h (struct tui_source_window_base)
2199         <~tui_source_window_base>: Don't declare.
2200         <fullname>: Remove.
2201         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2202         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2203         member.
2204         * tui/tui-source.c (tui_source_window::set_contents): Update.
2205         (tui_source_window::location_matches_p)
2206         (tui_source_window::maybe_update): Update.
2207
2208 2019-09-20  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-winsource.h (~tui_source_element): Remove.
2211         (tui_source_element): Update.
2212         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2213         * tui/tui-winsource.c (tui_show_source_line): Update.
2214         * tui/tui-source.c (tui_source_window::set_contents): Update.
2215         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2216
2217 2019-09-20  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2220         declare.
2221         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2222         tui_clear_source_windows_detail.
2223         * tui/tui-winsource.h (struct tui_source_window_base)
2224         <clear_detail>: Don't declare.
2225         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2226         Remove.
2227         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2228
2229 2019-09-20  Tom Tromey  <tromey@adacore.com>
2230
2231         PR ada/24919:
2232         * block.c (contained_in): Fix final return value.
2233
2234 2019-09-20  Alan Modra  <amodra@gmail.com>
2235
2236         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2237         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2238         (read_indirect_string_from_dwz): Use bfd accessor.
2239         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2240         * machoread.c (macho_symfile_read_all_oso): Likewise.
2241         * solib.c (solib_bfd_open): Likewise.
2242
2243 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2244
2245         * eval.c: Move declaration of overload_resolution to...
2246         * value.h: ...here.
2247
2248 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2249
2250         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2251         * arm-linux-tdep.c: Likewise.
2252         * arm-nbsd-nat.c: Likewise.
2253         * arm-tdep.h: Declare arm_apcs_32.
2254         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2255
2256 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2257
2258         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2259         * dwarf2read.h: Declare dwarf_always_disassemble.
2260
2261 2019-09-19  Tom de Vries  <tdevries@suse.de>
2262
2263         PR gdb/25009
2264         * source-cache.c (source_cache::ensure): Catch exception thrown during
2265         construction of the highlighter.
2266
2267 2019-09-18  Alan Modra  <amodra@gmail.com>
2268
2269         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2270         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2271         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2272         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2273         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2274         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2275         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2276         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2277         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2278         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2279         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2280         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2281         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2282         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2283         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2284         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2285         * mi/mi-interp.c: Update throughout for bfd section macro and
2286         function changes.
2287         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2288         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2289
2290 2019-09-18  Tom Tromey  <tom@tromey.com>
2291
2292         * NEWS: Add entry.
2293         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2294         call rl_initialize.
2295         (tui_enable): Do not call rl_initialize.
2296
2297 2019-09-18  Christian Groessler  <chris@groessler.org>
2298
2299         * alpha-linux-nat.c: Include gdbarch.h.
2300
2301 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2302
2303         * ui-file.c: Include cli/cli-style.h.
2304         (term_cli_styling): Remove cli_styling declaration.
2305
2306 2019-09-18  Alan Modra  <amodra@gmail.com>
2307
2308         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2309         to bfd_asymbol_section.
2310
2311 2019-09-18  Alan Modra  <amodra@gmail.com>
2312
2313         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2314         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2315         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2316
2317 2019-09-18  Alan Modra  <amodra@gmail.com>
2318
2319         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2320         * spu-linux-nat.c (spu_bfd_open): Likewise.
2321
2322 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2323
2324         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2325         to bool to match definition in dwarf2read.c.
2326
2327 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2330         (print_signatures): Likewise.
2331         (trust_pad_over_xvs): Likewise.
2332         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2333         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2334         * arm-linux-nat.c (arm_apcs_32): Likewise.
2335         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2336         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2337         * arm-tdep.c (arm_debug): Likewise.
2338         (arm_apcs_32): Likewise.
2339         * auto-load.c (debug_auto_load): Likewise.
2340         (auto_load_gdb_scripts): Likewise.
2341         (global_auto_load): Likewise.
2342         (auto_load_local_gdbinit): Likewise.
2343         (auto_load_local_gdbinit_loaded): Likewise.
2344         * auto-load.h (global_auto_load): Likewise.
2345         (auto_load_local_gdbinit): Likewise.
2346         (auto_load_local_gdbinit_loaded): Likewise.
2347         * breakpoint.c (disconnected_dprintf): Likewise.
2348         (breakpoint_proceeded): Likewise.
2349         (automatic_hardware_breakpoints): Likewise.
2350         (always_inserted_mode): Likewise.
2351         (target_exact_watchpoints): Likewise.
2352         (_initialize_breakpoint): Update.
2353         * breakpoint.h (target_exact_watchpoints): Change to bool.
2354         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2355         * cli/cli-cmds.c (trace_commands): Likewise.
2356         * cli/cli-cmds.h (trace_commands): Likewise.
2357         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2358         to bool*.
2359         * cli/cli-logging.c (logging_overwrite): Change to bool.
2360         (logging_redirect): Likewise.
2361         (debug_redirect): Likewise.
2362         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2363         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2364         to bool.
2365         <boolean_option_def>: Update.
2366         (struct flag_option_def): Change default type of Context to bool
2367         from int.
2368         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2369         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2370         (get_setshow_command_value_string): Likewise.
2371         * cli/cli-style.c (cli_styling): Change to bool.
2372         (source_styling): Likewise.
2373         * cli/cli-style.h (source_styling): Likewise.
2374         (cli_styling): Likewise.
2375         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2376         to bool.
2377         * command.h (var_types): Update comment.
2378         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2379         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2380         bool.
2381         (debug_compile_cplus_scopes): Likewise.
2382         * compile/compile-internal.h (compile_debug): Likewise.
2383         * compile/compile.c (compile_debug): Likewise.
2384         (struct compile_options) <raw>: Likewise.
2385         * cp-support.c (catch_demangler_crashes): Likewise.
2386         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2387         (usr_cmd_cris_dwarf2_cfi): Likewise.
2388         * csky-tdep.c (csky_debug): Likewise.
2389         * darwin-nat.c (enable_mach_exceptions): Likewise.
2390         * dcache.c (dcache_enabled_p): Likewise.
2391         * defs.h (info_verbose): Likewise.
2392         * demangle.c (demangle): Likewise.
2393         (asm_demangle): Likewise.
2394         * dwarf-index-cache.c (debug_index_cache): Likewise.
2395         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2396         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2397         * dwarf2read.c (check_physname): Likewise.
2398         (use_deprecated_index_sections): Likewise.
2399         (dwarf_always_disassemble): Likewise.
2400         * eval.c (overload_resolution): Likewise.
2401         * event-top.c (set_editing_cmd_var): Likewise.
2402         (exec_done_display_p): Likewise.
2403         * event-top.h (set_editing_cmd_var): Likewise.
2404         (exec_done_display_p): Likewise.
2405         * exec.c (write_files): Likewise.
2406         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2407         (debug_fbsd_nat): Likewise.
2408         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2409         Likewise.
2410         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2411         <backtrace_past_entry> Likewise.
2412         * gdb-demangle.h (demangle): Likewise.
2413         (asm_demangle): Likewise.
2414         * gdb_bfd.c (bfd_sharing): Likewise.
2415         * gdbcore.h (write_files): Likewise.
2416         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2417         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2418         * gdbthread.h (print_thread_events): Likewise.
2419         * gdbtypes.c (opaque_type_resolution): Likewise.
2420         (strict_type_checking): Likewise.
2421         * gnu-nat.c (gnu_debug_flag): Likewise.
2422         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2423         * guile/scm-param.c (pascm_variable): Add boolval.
2424         (add_setshow_generic): Update.
2425         (pascm_param_value): Update.
2426         (pascm_set_param_value_x): Update.
2427         * hppa-tdep.c (hppa_debug): Change to bool..
2428         * infcall.c (may_call_functions_p): Likewise.
2429         (coerce_float_to_double_p): Likewise.
2430         (unwind_on_signal_p): Likewise.
2431         (unwind_on_terminating_exception_p): Likewise.
2432         * infcmd.c (startup_with_shell): Likewise.
2433         * inferior.c (print_inferior_events): Likewise.
2434         * inferior.h (startup_with_shell): Likewise.
2435         (print_inferior_events): Likewise.
2436         * infrun.c (step_stop_if_no_debug): Likewise.
2437         (detach_fork): Likewise.
2438         (debug_displaced): Likewise.
2439         (disable_randomization): Likewise.
2440         (non_stop): Likewise.
2441         (non_stop_1): Likewise.
2442         (observer_mode): Likewise.
2443         (observer_mode_1): Likewise.
2444         (set_observer_mode): Update.
2445         (sched_multi): Change to bool.
2446         * infrun.h (debug_displaced): Likewise.
2447         (sched_multi): Likewise.
2448         (step_stop_if_no_debug): Likewise.
2449         (non_stop): Likewise.
2450         (disable_randomization): Likewise.
2451         * linux-tdep.c (use_coredump_filter): Likewise.
2452         (dump_excluded_mappings): Likewise.
2453         * linux-thread-db.c (auto_load_thread_db): Likewise.
2454         (check_thread_db_on_load): Likewise.
2455         * main.c (captured_main_1): Update.
2456         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2457         xx2_opt, boolean_opt>: Change to bool.
2458         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2459         * maint.c (maintenance_profile_p): Likewise.
2460         (per_command_time): Likewise.
2461         (per_command_space): Likewise.
2462         (per_command_symtab): Likewise.
2463         * memattr.c (inaccessible_by_default): Likewise.
2464         * mi/mi-main.c (mi_async): Likewise.
2465         (mi_async_1): Likewise.
2466         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2467         * nat/fork-inferior.h (startup_with_shell): Likewise.
2468         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2469         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2470         * nios2-tdep.c (nios2_debug): Likewise.
2471         * or1k-tdep.c (or1k_debug): Likewise.
2472         * parse.c (parser_debug): Likewise.
2473         * parser-defs.h (parser_debug): Likewise.
2474         * printcmd.c (print_symbol_filename): Likewise.
2475         * proc-api.c (procfs_trace): Likewise.
2476         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2477         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2478         (set_parameter_value): Update.
2479         (add_setshow_generic): Update.
2480         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2481         to bool*.
2482         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2483         int*.
2484         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2485         * record-btrace.c (record_btrace_target::store_registers): Update.
2486         * record-full.c (record_full_memory_query): Change to bool.
2487         (record_full_stop_at_limit): Likewise.
2488         * record-full.h (record_full_memory_query): Likewise.
2489         * remote-notif.c (notif_debug): Likewise.
2490         * remote-notif.h (notif_debug): Likewise.
2491         * remote.c (use_range_stepping): Likewise.
2492         (interrupt_on_connect): Likewise.
2493         (remote_break): Likewise.
2494         * ser-tcp.c (tcp_auto_retry): Likewise.
2495         * ser-unix.c (serial_hwflow): Likewise.
2496         * skip.c (debug_skip): Likewise.
2497         * solib-aix.c (solib_aix_debug): Likewise.
2498         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2499         (spu_auto_flush_cache_p): Likewise.
2500         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2501         Likewise.
2502         (struct info_print_options) <quiet>: Likewise.
2503         * symfile-debug.c (debug_symfile): Likewise.
2504         * symfile.c (auto_solib_add): Likewise.
2505         (separate_debug_file_debug): Likewise.
2506         * symfile.h (auto_solib_add): Likewise.
2507         (separate_debug_file_debug): Likewise.
2508         * symtab.c (basenames_may_differ): Likewise.
2509         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2510         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2511         (struct info_types_options) <quiet>: Likewise.
2512         * symtab.h (demangle): Likewise.
2513         (basenames_may_differ): Likewise.
2514         * target-dcache.c (stack_cache_enabled_1): Likewise.
2515         (code_cache_enabled_1): Likewise.
2516         * target.c (trust_readonly): Likewise.
2517         (may_write_registers): Likewise.
2518         (may_write_memory): Likewise.
2519         (may_insert_breakpoints): Likewise.
2520         (may_insert_tracepoints): Likewise.
2521         (may_insert_fast_tracepoints): Likewise.
2522         (may_stop): Likewise.
2523         (auto_connect_native_target): Likewise.
2524         (target_stop_and_wait): Update.
2525         (target_async_permitted): Change to bool.
2526         (target_async_permitted_1): Likewise.
2527         (may_write_registers_1): Likewise.
2528         (may_write_memory_1): Likewise.
2529         (may_insert_breakpoints_1): Likewise.
2530         (may_insert_tracepoints_1): Likewise.
2531         (may_insert_fast_tracepoints_1): Likewise.
2532         (may_stop_1): Likewise.
2533         * target.h (target_async_permitted): Likewise.
2534         (may_write_registers): Likewise.
2535         (may_write_memory): Likewise.
2536         (may_insert_breakpoints): Likewise.
2537         (may_insert_tracepoints): Likewise.
2538         (may_insert_fast_tracepoints): Likewise.
2539         (may_stop): Likewise.
2540         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2541         (make_thread_apply_all_options_def_group): Change argument from int*
2542         to bool*.
2543         (thread_apply_all_command): Update.
2544         (print_thread_events): Change to bool.
2545         * top.c (confirm): Likewise.
2546         (command_editing_p): Likewise.
2547         (history_expansion_p): Likewise.
2548         (write_history_p): Likewise.
2549         (info_verbose): Likewise.
2550         * top.h (confirm): Likewise.
2551         (history_expansion_p): Likewise.
2552         * tracepoint.c (disconnected_tracing): Likewise.
2553         (circular_trace_buffer): Likewise.
2554         * typeprint.c (print_methods): Likewise.
2555         (print_typedefs): Likewise.
2556         * utils.c (debug_timestamp): Likewise.
2557         (sevenbit_strings): Likewise.
2558         (pagination_enabled): Likewise.
2559         * utils.h (sevenbit_strings): Likewise.
2560         (pagination_enabled): Likewise.
2561         * valops.c (overload_resolution): Likewise.
2562         * valprint.h (struct value_print_options) <prettyformat_arrays,
2563         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2564         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2565         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2566         Likewise.
2567         * windows-nat.c (new_console): Likewise.
2568         (cygwin_exceptions): Likewise.
2569         (new_group): Likewise.
2570         (debug_exec): Likewise.
2571         (debug_events): Likewise.
2572         (debug_memory): Likewise.
2573         (debug_exceptions): Likewise.
2574         (useshell): Likewise.
2575         * windows-tdep.c (maint_display_all_tib): Likewise.
2576         * xml-support.c (debug_xml): Likewise.
2577
2578 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2579
2580         * source.c (prepare_path_for_appending): New function.
2581         (openp): Make use of new function.
2582         (find_and_open_source): Search for the compilation directory and
2583         source file as a relative path beneath the directory search path.
2584
2585 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * source-cache.c (source_cache::get_line_charpos): Catch
2588         exceptions and return false, this matches the behaviour documented
2589         in the header file.
2590
2591 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2592
2593         * ada-tasks.c (info_task): Remove quoting of the task's name.
2594
2595 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2596
2597         * symfile.c (auto_solib_add): Replace comment with a reference
2598         to the header file.
2599
2600 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2601
2602         * NEWS: Mention that gdb can now be compiled with Python 3
2603         on Windows.
2604
2605 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * maint.c (maint_print_section_data::maint_print_section_data):
2608         Force use of 'float log10 (float)' by casting the argument to
2609         float.
2610
2611 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2612
2613         * maint.c: Add 'cmath' include.
2614         (struct maint_print_section_data): New structure.
2615         (print_section_index): New function.
2616         (print_bfd_section_info): Add header comment, small whitespace
2617         cleanup, and update to call new print_section_index function.
2618         (print_objfile_section_info): Likewise.
2619         (maint_obj_section_from_bfd_section): New function.
2620         (print_bfd_section_info_maybe_relocated): New function.
2621         (maintenance_info_sections): Add header comment, always use
2622         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2623
2624 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2625
2626         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2627         inner scope, add check that the objfile has psymtabs before
2628         checking psymtabs_addrmap.
2629         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2630
2631 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2632
2633         * NEWS: Announce that Ada task names are now shown at more places,
2634         and between quotes (except in info task output).
2635         * gdb/ada-tasks.c (task_to_str): New function.
2636         (display_current_task_id): Call task_to_str.
2637         (task_command_1): Likewise.
2638         (print_ada_task_info): In non-mi mode, Properly align headers and data
2639         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2640
2641 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2642
2643         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2644         prstatus.pr_lwp.pr_info instead of making it up.
2645
2646 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2647
2648         * auto-load.c (auto_load_expand_dir_vars): Update.
2649         * defs.h (gdb_datadir): Change to std::string.
2650         (python_libdir): Likewise.
2651         (relocate_gdb_directory): Change return type to std::string.
2652         * guile/guile.c (gdbscm_data_directory): Update.
2653         (initialize_scheme_side): Update.
2654         * jit.c (jit_reader_dir): Change to std::string.
2655         (jit_reader_load_command): Update.
2656         * main.c (gdb_datadir): Change to std::string.
2657         (python_libdir): Likewise.
2658         (set_gdb_data_directory): Update.
2659         (relocate_path): Change to return std::string.
2660         (relocate_gdb_directory): Change to return std::string.
2661         (relocate_gdbinit_path_maybe_in_datadir): Update.
2662         (captured_main_1): Update.
2663         * python/python.c (do_start_initialization): Update.
2664         * top.c (show_gdb_datadir): Update.
2665         * xml-syscall.c (xml_init_syscalls_info): Update.
2666         (init_syscalls_info): Update.
2667
2668 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2669
2670         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2671         out of get_init_files.
2672         (get_init_files): Update.
2673
2674 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2675
2676         * main.c (get_init_files): Change to use std::string.
2677         (captured_main_1): Update.
2678         (print_gdb_help): Update.
2679
2680 2019-09-11  Ali Tamur  <tamur@google.com>
2681
2682         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2683         implementation.
2684
2685 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2686
2687         * dbxread.c (read_dbx_symtab): Update.
2688         * dwarf2read.c (load_partial_dies): Update.
2689         * mdebugread.c (parse_partial_symbols): Update.
2690         (handle_psymbol_enumerators): Update.
2691         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2692         * psymtab.c (add_psymbol_to_bcache): Likewise.
2693         (add_psymbol_to_list): Likewise.
2694         * symtab.c (symbol_set_names): Likewise.
2695         * symtab.h (symbol_set_names): Likewise.
2696         * xcoffread.c (scan_xcoff_symtab): Update.
2697
2698 2019-09-11  Tom Tromey  <tom@tromey.com>
2699
2700         * symfile-mem.c (symbol_file_add_from_memory): Use
2701         bfd_set_filename.
2702         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2703         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2704
2705 2019-09-10  Tom Tromey  <tromey@adacore.com>
2706
2707         * dwarf-index-write.c (write_psymbols): Extend error message.
2708         (debug_names::insert): Add Ada code.
2709         (debug_names::write_psymbols): Remove Ada check.
2710         (debug_names) <m_string_obstack>: New member.
2711         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2712         (gdb_index_symbol_name_matcher::matches): Remove.
2713         (mapped_index_base::find_name_components_bounds): Add "lang"
2714         parameter.
2715         (mapped_index_base::build_name_components): Also split names
2716         according to Ada syntax.
2717         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2718         type of "match_callback".
2719         (check_match, check_find_bounds_finds)
2720         (dw2_expand_symtabs_matching): Update.
2721         (dw2_debug_names_iterator): Add new constructor.
2722         (dw2_debug_names_map_matching_symbols): New function.
2723         (dw2_debug_names_expand_symtabs_matching): Update.
2724         (dwarf2_debug_names_functions): Use
2725         dw2_debug_names_map_matching_symbols.
2726
2727 2019-09-10  Tom Tromey  <tromey@adacore.com>
2728
2729         * dwarf2read.c (dw2_get_file_names_reader): Add the
2730         CU's file name to the results.
2731
2732 2019-09-10  Tom Tromey  <tromey@adacore.com>
2733
2734         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2735         map_matching_symbols.  Update.
2736         * dwarf2read.c (dw2_map_matching_symbols): Update.
2737         * psymtab.c (match_partial_symbol): Change type; update.
2738         (psym_map_matching_symbols): Likewise.
2739         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2740         type; update.
2741         * symfile.h (struct quick_symbol_functions)
2742         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2743         Remove "match".
2744
2745 2019-09-10  Tom Tromey  <tromey@adacore.com>
2746
2747         * psymtab.c (map_block): Remove.
2748         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2749         * symtab.c (iterate_over_symbols_terminated): New function.
2750         * symtab.c (iterate_over_symbols_terminated): Declare.
2751
2752 2019-09-10  Tom Tromey  <tromey@adacore.com>
2753
2754         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2755         * language.h (struct language_defn) <la_iterate_over_symbols>:
2756         Return bool.
2757         * symtab.c (iterate_over_symbols): Return bool.
2758         * symtab.h (iterate_over_symbols): Return bool.
2759
2760 2019-09-10  Tom Tromey  <tromey@adacore.com>
2761
2762         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2763         (add_nonlocal_symbols): Update.
2764         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2765         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2766         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2767         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2768         Change type of "callback".  Remove "data".
2769
2770
2771 2019-09-09  Ali Tamur  <tamur@google.com>
2772
2773         * dwarf2read.c (comp_unit_head): Update comment.
2774         (dwarf2_dwo_name): New function declaration.
2775         (dwarf_unit_type_name): New function declaration.
2776         (read_comp_unit_head): Add support for new compilation units,
2777         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2778         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2779         (currently named as "signature") in their header. Also clarify error
2780         messages.
2781         (lookup_dwo_id): New function. Returns the dwo id of the given
2782         compile unit.
2783         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2784         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2785         functions.
2786         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2787         (dwarf2_dwo_name): Get the dwo name if present.
2788         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2789         purposes.
2790
2791 2019-09-09  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2794
2795 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2796
2797         * python/python.c (do_start_initialization): Make progname_copy static,
2798         to avoid a leak report.
2799
2800 2019-09-08  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2803
2804 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2805
2806         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2807         Change type to gdb::optional<block_enum>.
2808         (dw2_symtab_iter_init): Change block_index parameter type
2809         to gdb::optional<block_enum>.
2810         (dw2_lookup_symbol): Change block_index parameter
2811         type to block_enum.c
2812         (dw2_debug_names_lookup_symbol): Likewise.
2813         * psymtab.c (psym_lookup_symbol): Likewise.
2814         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2815         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2816         Likewise.
2817
2818 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2819
2820         * defs.h (relocate_gdb_directory): Change int to bool in
2821         signature and rename flag to relocatable.
2822         * main.c (relocate_path): Likewise.
2823         (relocate_gdb_directory): Likewise.
2824
2825 2019-09-06  Alan Modra  <amodra@gmail.com>
2826
2827         * coffread.c (coff_symfile_read): Constify filename variable.
2828         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2829         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2830         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2831         * solib.c (reload_shared_libraries_1): Likewise.
2832         * symfile.c (reread_symbols): Likewise.
2833         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2834         * solib-darwin.c (darwin_bfd_open): Likewise.
2835         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2836
2837 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2838
2839         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2840         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2841
2842 2019-09-03  Tom Tromey  <tromey@adacore.com>
2843
2844         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2845         types.
2846         (has_negatives): Unbias a range type bound.
2847         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2848         * gdbtypes.c (operator==): Handle new field.
2849         (create_range_type): Add "bias" parameter.
2850         (create_static_range_type, resolve_dynamic_range): Update.
2851         * gdbtypes.h (struct range_bounds) <bias>: New member.
2852         (create_range_type): Add bias parameter.
2853         * printcmd.c (print_scalar_formatted): Unbias range types.
2854         * value.c (unpack_long): Unbias range types.
2855         (pack_long): Bias range types.
2856
2857 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2858
2859         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2860         probe arguments.
2861
2862 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2863
2864         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2865         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2866         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2867         (compile_probe_arg): Likewise.
2868         * probe.h (get_argument_count): Likewise.
2869         * solib-svr4.c (solib_event_probe_action): Likewise.
2870         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2871
2872 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2873
2874         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2875         code to here...
2876         (svr4_create_solib_event_breakpoints): ...from here.
2877
2878 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2879
2880         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2881         suffix from warning message.
2882
2883 2019-08-30  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-winsource.h (struct tui_source_window_base)
2886         <refresh_all>: Don't declare.
2887         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2888         Remove.
2889         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2890         tui_show_locator_content.
2891         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2892         declare.
2893         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2894         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2895         declare.
2896
2897 2019-08-30  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2900
2901 2019-08-30  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2904         Remove unnecessary forward declarations.
2905
2906 2019-08-30  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2909         rerender.
2910         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2911         tui_show_locator_content.
2912
2913 2019-08-30  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2916         (tui_locator_window::rerender): Rewrite using body of previous
2917         tui_show_locator_content.
2918
2919 2019-08-30  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2922         set_locator_fullname>: New methods.
2923         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2924         Rename from tui_set_locator_fullname.
2925         (tui_locator_window::set_locator_info): Rename from
2926         tui_set_locator_info.  Return bool.
2927         (tui_update_locator_fullname, tui_show_frame_info): Update.
2928
2929 2019-08-30  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2932
2933 2019-08-30  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2936         call touchwin.
2937
2938 2019-08-30  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-wingeneral.c (box_win): Assume win_info and
2941         win_info->handle cannot be NULL.
2942
2943 2019-08-30  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2946         refresh_window>: Declare.
2947         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2948         resize.
2949         (tui_data_item_window::rerender): Rename from
2950         tui_display_register.
2951         (tui_data_item_window::refresh_window): New method.
2952         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2953         no-op.
2954
2955 2019-08-30  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2958         regs_column_count, current_group>: Move later.  Now private.
2959         <get_current_group>: New method.
2960         * tui/tui-regs.c (tui_reg_command): Update.
2961         * tui/tui-layout.c (tui_set_layout): Update.
2962
2963 2019-08-30  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2966         (tui_data_window::rerender): Don't call
2967         check_and_display_highlight_if_needed.
2968         (tui_data_window::refresh_all): Remove call to
2969         erase_data_content.
2970
2971 2019-08-30  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2974         (tui_data_window::display_registers_from)
2975         (tui_data_window::display_reg_element_at_line)
2976         (tui_data_window::display_registers_from_line): Remove checks of
2977         "empty".
2978
2979 2019-08-30  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2982         Don't declare.
2983         * tui/tui-regs.c (tui_data_window::show_registers): Call
2984         rerender.
2985         (tui_data_window::rerender): Rename from display_all_data.
2986         (tui_data_window::rerender): Remove old implementation.
2987
2988 2019-08-30  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2991         text.
2992         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2993
2994 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2995             Sergio Durigan Junior  <sergiodj@redhat.com>
2996
2997         PR win32/24284
2998         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2999
3000 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3003         when searching for types.
3004
3005 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * f-lang.c (f_language_defn): Use f_print_typedef.
3008         * f-lang.h (f_print_typedef): Declare.
3009         * f-typeprint.c (f_print_typedef): Define.
3010
3011 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3012
3013         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3014
3015 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3016
3017         * cli/cli-utils.c (info_print_options_defs): Delete.
3018         (make_info_print_options_def_group): Delete.
3019         (extract_info_print_options): Delete.
3020         (info_print_command_completer): Delete.
3021         (info_print_args_help): Add extra parameter, and optionally
3022         include text about -n flag.
3023         * cli/cli-utils.h (struct info_print_options): Delete.
3024         (extract_info_print_options): Delete declaration.
3025         (info_print_command_completer): Delete declaration.
3026         (info_print_args_help): Add extra parameter, extend header
3027         comment.
3028         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3029         search_symbols.
3030         * stack.c (struct info_print_options): New type.
3031         (info_print_options_defs): New file scoped variable.
3032         (make_info_print_options_def_group): New static function.
3033         (info_print_command_completer): New static function.
3034         (info_locals_command): Update to use new local functions.
3035         (info_args_command): Likewise.
3036         (_initialize_stack): Add extra parameter to calls to
3037         info_print_args_help.
3038         * symtab.c (search_symbols): Add extra parameter, use this to
3039         possibly excluse non-debug symbols.
3040         (symtab_symbol_info): Add extra parameter, which is passed on to
3041         search_symbols.
3042         (struct info_print_options): New type.
3043         (info_print_options_defs): New file scoped variable.
3044         (make_info_print_options_def_group): New static function.
3045         (info_print_command_completer): New static function.
3046         (info_variables_command): Update to use local functions, and pass
3047         extra parameter through to symtab_symbol_info.
3048         (info_functions_command): Likewise.
3049         (info_types_command): Pass additional argument through to
3050         symtab_symbol_info.
3051         (rbreak_command): Pass extra argument to search_symbols.
3052         (_initialize_symtab): Add extra arguments for calls to
3053         info_print_args_help, and update help text for 'info variables',
3054         'whereis', and 'info functions' commands.
3055         * symtab.h (search_symbols): Add extra argument to declaration.
3056         * NEWS: Mention new flags.
3057
3058 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3059
3060         * symtab.c (lookup_static_symbol): Call the new function (and move
3061         it down to be next to lookup_global_symbol).
3062         (struct global_sym_lookup_data): Add block_enum member and rename to...
3063         (struct global_or_static_sym_lookup_data): ...this.
3064         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3065         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3066         (lookup_symbol_global_or_static_iterator_cb): ...this.
3067         (lookup_global_or_static_symbol): New function.
3068         (lookup_global_symbol): Call new function.
3069
3070 2019-08-26  Tom de Vries  <tdevries@suse.de>
3071
3072         PR c++/24852
3073         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3074         when pc_probe.prob == NULL.
3075
3076 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3077
3078         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3079         variable symbol_linkage to symbol_linkage_.
3080
3081 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3082
3083         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3084         represent whether the symbol is static, dynamic, or we don't
3085         know.
3086
3087 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3088
3089         * gdb/rx-tdep.c (rx_register_names): New.
3090         (rx_register_name): Delete.
3091         (rx_psw_type): Delete.
3092         (rx_fpsw_type): Delete.
3093         (rx_register_type): Delete.
3094         (rx_gdbarch_init): Convert target-descriptions.
3095         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3096         * gdb/features/Makefile: Add rx.xml.
3097         * gdb/features/rx.xml: New.
3098         * gdb/features/rx.c: Generated.
3099         * gdb/NEWS: Mention target description support.
3100
3101 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3102
3103         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3104         *slot_ptr.
3105
3106 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3107
3108         * configure.ac: Don't check for 'dlfcn.h' (moved to
3109         gdbsupport/common.m4).
3110         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3111         'gdbsupport/'.
3112         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3113         * compile/compile-c-support.c: Include
3114         'gdbsupport/gdb-dlfcn.h'.
3115         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3116         * gdb-dlfcn.c: Move to...
3117         * gdbsupport/gdb-dlfcn.c: ... here.
3118         * gdb-dlfcn.h: Move to...
3119         * gdbsupport/gdb-dlfcn.h: ... here.
3120
3121 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3122
3123         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3124         the offset field signed.
3125
3126 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3127
3128         * python/lib/gdb/__init__.py (_execute_file): New function.
3129         * python/python.c (python_run_simple_file): Call gdb._execute_file
3130         on Windows.
3131
3132 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3135         all uses as this was never set to anything but a zero value.
3136
3137 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3138
3139         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3140
3141 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3142
3143         * tui/tui-data.h (tui_gen_win_info): Add an =default
3144         move constructor, required by some GCC versions.
3145
3146 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3147
3148         * go32-nat.c (go32_sysinfo): Add hygon_p.
3149
3150 2019-08-20  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3153         line_from_reg_element_no, first_reg_element_no_inline,
3154         display_all_data, delete_data_content_windows,
3155         erase_data_content>: Now private.
3156
3157 2019-08-20  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3160         (tui_unhighlight_win, tui_highlight_win)
3161         (tui_win_info::make_window): Update.
3162         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3163
3164 2019-08-20  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3167         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3168         (MAX_PID_WIDTH): Move to tui-stack.c.
3169         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3170         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3171         (MAX_PID_WIDTH): Move from tui-data.h.
3172
3173 2019-08-20  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3176         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3177         (box_win): Update.
3178         (tui_gen_win_info::make_window): Rename from tui_make_window.
3179         (tui_win_info::make_window): New method.
3180         (tui_gen_win_info::make_visible): Update.
3181         * tui/tui-source.c (tui_source_window::set_contents): Update.
3182         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3183         (tui_data_window::display_registers_from): Update.
3184         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3185         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3186         Declare.
3187         <can_box>: Remove.
3188         <title>: Remove.
3189         (struct tui_win_info) <make_window>: Declare.
3190         <can_box>: Now virtual.
3191         <title>: New member.
3192         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3193         * tui/tui-command.c (tui_cmd_window::resize): Update.
3194
3195 2019-08-20  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3198         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3199         (tui_data_window::check_register_values): Update.
3200
3201 2019-08-20  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-regs.h (struct tui_data_window): Use
3204         DISABLE_COPY_AND_ASSIGN.
3205         <regs_content>: Change type, removing unique_ptr.
3206         <tui_data_window>: Add move constructor.
3207         * tui/tui-regs.c (tui_data_window::show_registers)
3208         (tui_data_window::show_register_group)
3209         (tui_data_window::display_registers_from)
3210         (tui_data_window::display_registers_from)
3211         (tui_data_window::first_data_item_displayed)
3212         (tui_data_window::delete_data_content_windows)
3213         (tui_data_window::rerender, tui_data_window::refresh_window)
3214         (tui_data_window::check_register_values): Update.
3215
3216 2019-08-20  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3219         show_register_group>: Declare.
3220         (tui_show_register_group): Don't declare.
3221         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3222         tui_show_registers.
3223         (tui_data_window::show_register_group): Rename from
3224         tui_show_register_group.
3225         (tui_data_window::check_register_values, tui_reg_command):
3226         Update.
3227         * tui/tui-layout.c (tui_set_layout): Update.
3228
3229 2019-08-20  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3232         Declare.
3233         (tui_check_register_values): Don't declare.
3234         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3235         from tui_check_register_values.
3236         * tui/tui-hooks.c (tui_register_changed): Update.
3237
3238 2019-08-20  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-regs.c (tui_reg_layout): Move later.
3241         (tui_show_registers): Don't enable TUI mode or change layout.
3242
3243 2019-08-20  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-regs.h (struct tui_data_item_window)
3246         <~tui_data_item_window>: Remove.
3247         <content>: Now a unique_xmalloc_ptr.
3248         * tui/tui-regs.c (tui_register_format): Return a
3249         unique_xmalloc_ptr.
3250         (tui_get_register): Update.
3251         (~tui_data_item_window): Remove.
3252         (tui_data_window::display_registers_from, tui_display_register):
3253         Update.
3254         * tui/tui-io.h (tui_expand_tabs): Update.
3255         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3256         Remove "col" parameter.
3257
3258 2019-08-20  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3261         field.
3262         * tui/tui-regs.c (~tui_data_item_window): Update.
3263
3264 2019-08-20  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3267         earlier.
3268
3269 2019-08-20  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3272
3273 2019-08-20  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-source.h (struct tui_source_window): Update.
3276         * tui/tui-regs.c (tui_show_registers): Update.
3277         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3278         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3279         (NO_REGS_STRING): Remove defines.
3280
3281 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3282
3283         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3284         unnecessary thread walk if remote doesn't support the packet.
3285
3286 2019-08-19  Tom Tromey  <tromey@adacore.com>
3287
3288         * python/py-value.c (value_has_field): Fix indentation.
3289
3290 2019-08-19  Tom Tromey  <tromey@adacore.com>
3291
3292         * printcmd.c (do_one_display, info_display_command): Update.
3293         * block.h (contained_in): Return bool.  Add allow_nested
3294         parameter.
3295         * block.c (contained_in): Return bool.  Add allow_nested
3296         parameter.
3297
3298 2019-08-19  Tom Tromey  <tom@tromey.com>
3299
3300         * configure: Rebuild.
3301         * configure.ac: Disallow the combination of -static-libstdc++ and
3302         source highlight.
3303         * source-cache.c (get_language_name): Handle rust.
3304         (source_cache::get_source_lines): Ignore highlighting exceptions.
3305
3306 2019-08-16  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3309         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3310         (struct tui_source_window_base) <make_visible, refresh_window,
3311         resize>: Remove methods.
3312         <execution_info>: Remove field.
3313         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3314         (tui_show_source_line, tui_source_window_base)
3315         (~tui_source_window_base): Update.
3316         (tui_source_window_base::resize)
3317         (tui_source_window_base::make_visible)
3318         (tui_source_window_base::refresh_window): Remove.
3319         (tui_source_window_base::update_exec_info): Update.
3320         * tui/tui-source.c (tui_source_window::set_contents): Update.
3321         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3322
3323 2019-08-16  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3326         deprecated_query_hook.
3327
3328 2019-08-16  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3331         (tui_update_source_windows_with_line): Update.
3332         * tui/tui-source.h (struct tui_source_window)
3333         <show_symtab_source>: Declare.
3334         (tui_show_symtab_source): Don't declare.
3335         * tui/tui-source.c (tui_show_symtab_source): Rename from
3336         tui_show_symtab_source.
3337
3338 2019-08-16  Tom Tromey  <tom@tromey.com>
3339
3340         * tui/tui-winsource.h (struct tui_source_window_base)
3341         <set_contents>: Declare.
3342         * tui/tui-winsource.c
3343         (tui_source_window_base::update_source_window_as_is): Update.
3344         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3345         Declare.
3346         (tui_set_source_content): Don't declare.
3347         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3348         tui_set_source_content.
3349         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3350         Declare.
3351         (tui_set_disassem_content): Don't declare.
3352         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3353         tui_set_disassem_content.
3354
3355 2019-08-16  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-winsource.h (struct tui_source_window_base)
3358         <update_breakpoint_info>: Declare.
3359         (tui_update_breakpoint_info): Don't declare.
3360         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3361         (tui_update_all_breakpoint_info): Update.
3362         (tui_source_window_base::update_breakpoint_info): Rename from
3363         tui_update_breakpoint_info.
3364         (tui_source_window_base::update_exec_info): Update.
3365
3366 2019-08-16  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui-winsource.h (struct tui_source_window_base)
3369         <update_source_window>: Declare.
3370         (tui_update_source_window): Don't declare.
3371         * tui/tui-winsource.c
3372         (tui_source_window_base::update_source_window): Rename from
3373         tui_update_source_window.
3374         (tui_source_window_base::rerender): Update.
3375         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3376         * tui/tui-disasm.c (tui_show_disassem)
3377         (tui_show_disassem_and_update_source)
3378         (tui_disasm_window::maybe_update): Update.
3379
3380 2019-08-16  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-winsource.h (struct tui_source_window_base)
3383         <update_source_window_as_is>: Declare.
3384         (tui_update_source_window_as_is): Don't declare.
3385         * tui/tui-winsource.c (tui_update_source_window): Update
3386         (tui_source_window_base::update_source_window_as_is): Rename from
3387         tui_update_source_window_as_is.
3388         (tui_source_window_base::refill): Update.
3389         * tui/tui-source.c (tui_show_symtab_source): Update.
3390         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3391         Update.
3392
3393 2019-08-16  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-winsource.h (tui_update_source_window)
3396         (tui_update_source_window_as_is): Remove "noerror" parameter.
3397         * tui/tui-winsource.c (tui_update_source_window)
3398         (tui_update_source_window_as_is): Remove "noerror" parameter.
3399         (tui_update_source_windows_with_addr)
3400         (tui_update_source_windows_with_line)
3401         (tui_source_window_base::rerender)
3402         (tui_source_window_base::refill): Update.
3403         * tui/tui-source.h (tui_set_source_content)
3404         (tui_show_symtab_source): Remove "noerror" parameter.
3405         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3406         parameter.
3407         (tui_show_symtab_source): Likewise.
3408         (tui_source_window::maybe_update): Update.
3409         * tui/tui-disasm.c (tui_show_disassem)
3410         (tui_show_disassem_and_update_source)
3411         (tui_disasm_window::do_scroll_vertical)
3412         (tui_disasm_window::maybe_update): Update.
3413
3414 2019-08-16  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui.c (tui_is_window_visible): Update.
3417         * tui/tui-wingeneral.c (tui_make_window)
3418         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3419         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3420         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3421         (tui_set_win_height_command, parse_scrolling_args): Update.
3422         * tui/tui-source.c (tui_source_window::style_changed): Update.
3423         * tui/tui-regs.c (tui_show_registers)
3424         (tui_data_window::first_data_item_displayed)
3425         (tui_data_window::delete_data_content_windows)
3426         (tui_check_register_values, tui_reg_command): Update.
3427         * tui/tui-disasm.c (tui_show_disassem): Update.
3428         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3429         method.
3430         <is_visible>: Remove field.
3431         * tui/tui-data.c (tui_next_win, tui_prev_win)
3432         (tui_delete_invisible_windows): Update.
3433
3434 2019-08-16  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-winsource.h (struct tui_source_window_base)
3437         <m_has_locator>: Remove.
3438         * tui/tui-layout.c (show_source_disasm_command, show_data)
3439         (show_source_or_disasm_and_command): Update.
3440
3441 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3442
3443         * NEWS (Other MI changes): New subsection.
3444         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3445         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3446         * arch-utils.c (default_get_pc_address_flags): New function.
3447         * arch-utils.h (default_get_pc_address_flags): New declaration.
3448         * gdbarch.sh: Add get_pc_address_flags.
3449         * gdbarch.c: Regenerate.
3450         * gdbarch.h: Likewise.
3451         * stack.c (print_pc): New function.
3452         (print_frame_info) (print_frame): Call print_pc.
3453
3454 2019-08-16  Tom de Vries  <tdevries@suse.de>
3455
3456         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3457         print_objfile_section_info.
3458
3459 2019-08-15  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3462         calling update_cmdwin_start_line.
3463         * tui/tui-winsource.h (struct tui_source_window_base)
3464         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3465         <rerender>: Declare.
3466         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3467         Call rerender.
3468         (tui_source_window_base::set_new_height): Remove.
3469         (tui_source_window_base::rerender): Rename from
3470         do_make_visible_with_new_height.
3471         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3472         resize method.
3473         (tui_win_info::make_invisible_and_set_new_height)
3474         (tui_win_info::make_visible_with_new_height): Remove.
3475         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3476         Declare.
3477         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3478         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3479         do_make_visible_with_new_height>: Don't declare.
3480         <rerender>: Declare.
3481         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3482         set_new_height.
3483         (tui_data_window::do_make_visible_with_new_height): Remove.
3484         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3485         call tui_show_locator_content.
3486         (tui_gen_win_info::resize): Call rerender.
3487         (show_source_or_disasm_and_command): Don't call
3488         tui_show_locator_content.
3489         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3490         method.
3491         (struct tui_win_info) <rerender>: Declare.
3492         <set_new_height, make_invisible_and_set_new_height,
3493         make_visible_with_new_height>: Don't declare.
3494         * tui/tui-data.c (tui_win_list::rerender): New method.
3495         * tui/tui-command.h (struct tui_cmd_window)
3496         <do_make_visible_with_new_height>: Don't declare.
3497         * tui/tui-command.c
3498         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3499
3500 2019-08-15  Tom Tromey  <tromey@adacore.com>
3501
3502         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3503         * ada-lang.c (ada_enum_name): Likewise.
3504
3505 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3506
3507         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3508         leading underscore.
3509         (GdbOutputErrorFile): Likewise.
3510         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3511         accordingly.
3512         (execute_unwinders): Rename to have a leading underscore.
3513         (auto_load_packages): Likewise.
3514         (global scope): Adjust call to auto_load_packages accordingly.
3515         (GdbSetPythonDirectory): Likewise.
3516         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3517         instead of execute_unwinders.
3518
3519 2019-08-15  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3522         (show_data): Don't change window visibility.
3523         (tui_gen_win_info::resize): Remove special case for command
3524         window.  Use wresize, when available.
3525         (show_source_or_disasm_and_command): Don't change window
3526         visibility.
3527         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3528         <make_visible>: New method.
3529         * tui/tui-command.c (tui_cmd_window::resize): New method.
3530
3531 2019-08-15  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3534         (struct tui_source_windows): New.
3535         * tui/tui-winsource.c (tui_display_main): Update.
3536         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3537         (new_height_ok, parse_scrolling_args): Update.
3538         * tui/tui-layout.c (show_layout, show_data): Update.
3539         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3540         (tui_add_to_source_windows): Don't declare.
3541         * tui/tui-data.c (source_windows, tui_source_windows)
3542         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3543
3544 2019-08-15  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3547         Rename from reset.
3548         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3549         * tui/tui-layout.c (show_source_disasm_command, show_data):
3550         Update.
3551         (tui_gen_win_info::resize): Rename.
3552         (show_source_or_disasm_and_command): Update.
3553         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3554         reset.
3555
3556 2019-08-15  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3559         * tui/tui-interp.c (tui_interp::init): Don't call
3560         tui_initialize_static_data.
3561         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3562
3563 2019-08-15  Tom Tromey  <tom@tromey.com>
3564
3565         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3566         examine tui_win_list.
3567
3568 2019-08-15  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3571         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3572         tui_clear_source_content.
3573         (tui_clear_source_content): Remove.
3574         (tui_source_window_base::do_erase_source_content): Hoist call to
3575         content.clear().
3576         * tui/tui-stack.c (tui_show_frame_info): Don't call
3577         tui_clear_source_content.
3578
3579 2019-08-15  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-winsource.h (struct tui_source_window_base)
3582         <do_erase_source_content>: New method.
3583         <erase_source_content>: New method.
3584         (tui_erase_source_content): Don't declare.
3585         * tui/tui-winsource.c (tui_clear_source_content): Update.
3586         (tui_source_window_base::do_erase_source_content): Rename from
3587         tui_erase_source_content.
3588         (tui_source_window_base::show_source_content): Update.
3589         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3590         * tui/tui-source.h (struct tui_source_window)
3591         <erase_source_content>: New method.
3592         * tui/tui-disasm.h (struct tui_disasm_window)
3593         <erase_source_content>: New method.
3594
3595 2019-08-15  Tom Tromey  <tom@tromey.com>
3596
3597         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3598         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3599         constructor.
3600         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3601         * tui/tui-source.c (tui_set_source_content): Update.
3602         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3603
3604 2019-08-15  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3607         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3608         tui-source.c.
3609         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3610         Declare.
3611         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3612         method.
3613         (tui_source_window::maybe_update): Update.
3614
3615 2019-08-15  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3618         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3619         tui-disasm.c.
3620         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3621         Declare.
3622         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3623         method.
3624         (tui_disasm_window::maybe_update): Update.
3625
3626 2019-08-15  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-winsource.h (struct tui_source_window_base)
3629         <maybe_update>: Declare.
3630         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3631         method.
3632         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3633         Declare.
3634         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3635         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3636         Declare.
3637         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3638
3639 2019-08-15  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3642
3643 2019-08-15  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-wingeneral.c: Include tui-stack.h.
3646         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3647         (struct tui_locator_window): Move from tui-data.h.
3648         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3649         (tui_initialize_static_data): Move from tui-data.c.
3650         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3651         (struct tui_locator_window): Move to tui-stack.c.
3652         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3653         (tui_initialize_static_data): Move to tui-stack.c.
3654
3655 2019-08-15  Tom Tromey  <tom@tromey.com>
3656
3657         * tui/tui-layout.c (show_source_disasm_command)
3658         (show_source_or_disasm_and_command): Use make_visible method, not
3659         tui_make_window.
3660         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3661         Remove.
3662
3663 2019-08-15  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-wingeneral.h (tui_make_window): Update.
3666         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3667         parameter.
3668         (tui_gen_win_info::make_visible): Update.
3669         * tui/tui-regs.c (tui_data_window::display_registers_from):
3670         Update.
3671         * tui/tui-layout.c (show_source_disasm_command)
3672         (show_source_or_disasm_and_command): Update.
3673         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3674         (enum tui_box): Remove.
3675         (struct tui_win_info) <can_box>: New method.
3676         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3677         method.
3678
3679 2019-08-15  Tom de Vries  <tdevries@suse.de>
3680
3681         * linux-nat-trad.c: Include gdbarch.h.
3682
3683 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3684
3685         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3686         register sizes.
3687
3688 2019-08-14  Tom Tromey  <tromey@adacore.com>
3689
3690         * darwin-nat.c: Include gdbarch.h.
3691         * darwin-nat-info.c: Include gdbarch.h.
3692
3693 2019-08-13  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3696         Remove.
3697         * tui/tui-data.c (tui_initialize_static_data): Update.
3698
3699 2019-08-13  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-winsource.h (struct tui_exec_info_window)
3702         <~tui_exec_info_window, maybe_allocate_content, get_content,
3703         m_content>: Remove.
3704         (struct tui_source_window_base) <set_exec_info_content,
3705         show_exec_info_content>: Don't declare.
3706         * tui/tui-winsource.c
3707         (tui_exec_info_window::maybe_allocate_content): Remove.
3708         (tui_source_window_base::update_exec_info): Rename from
3709         set_exec_info_content.
3710         (tui_source_window_base::show_exec_info_content)
3711         (tui_source_window_base::update_exec_info): Remove.
3712
3713 2019-08-13  Tom Tromey  <tom@tromey.com>
3714
3715         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3716         declare.
3717         * tui/tui-winsource.c (tui_update_source_window_as_is)
3718         (tui_update_source_windows_with_addr, tui_erase_source_content):
3719         Update.
3720         (tui_clear_exec_info_content): Remove.
3721
3722 2019-08-13  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3725         declare.
3726         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3727         call tui_erase_exec_info_content.
3728         (tui_clear_exec_info_content): Rename from
3729         tui_erase_exec_info_content.
3730         (tui_clear_exec_info_content): Delete.
3731
3732 2019-08-13  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-winsource.h (struct tui_source_window_base)
3735         <show_exec_info_content>: Declare.
3736         (tui_show_exec_info_content): Don't declare.
3737         * tui/tui-winsource.c
3738         (tui_source_window_base::show_exec_info_content): Rename from
3739         tui_show_exec_info_content.
3740         (tui_source_window_base::update_exec_info): Update.
3741
3742 2019-08-13  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3745         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3746         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3747         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3748         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3749         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3750         ... here.
3751
3752 2019-08-13  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-winsource.h (struct tui_source_window_base)
3755         <update_exec_info>: Declare.
3756         (tui_update_exec_info): Don't declare.
3757         * tui/tui-winsource.c (tui_update_source_window_as_is)
3758         (tui_source_window_base::refresh_all)
3759         (tui_update_all_breakpoint_info): Update.
3760         (tui_source_window_base::update_exec_info): Rename from
3761         tui_update_exec_info.
3762         * tui/tui-stack.c (tui_show_frame_info): Update.
3763
3764 2019-08-13  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-winsource.h (struct tui_source_window_base)
3767         <set_exec_info_content>: Declare.
3768         (tui_set_exec_info_content): Don't declare.
3769         * tui/tui-winsource.c
3770         (tui_source_window_base::set_exec_info_content): Rename from
3771         tui_set_exec_info_content.
3772         (tui_update_exec_info): Update.
3773
3774 2019-08-13  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-winsource.h (struct tui_source_window_base)
3777         <show_source_content>: Declare.
3778         (tui_show_source_content): Don't declare.
3779         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3780         (tui_source_window_base::show_source_content): Rename from
3781         tui_show_source_content.
3782         (tui_source_window_base::refresh_all): Update.
3783         * tui/tui-layout.c (show_source_disasm_command)
3784         (show_source_or_disasm_and_command): Update.
3785
3786 2019-08-13  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-winsource.c (tui_erase_source_content)
3789         (tui_show_source_content, tui_source_window_base::refresh_all):
3790         Update.
3791         * tui/tui-wingeneral.h
3792         (tui_check_and_display_highlight_if_needed): Don't declare.
3793         * tui/tui-wingeneral.c
3794         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3795         check_and_display_highlight_if_needed.
3796         * tui/tui-win.c (tui_rehighlight_all)
3797         (tui_win_info::make_visible_with_new_height): Update.
3798         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3799         (tui_data_window::erase_data_content)
3800         (tui_data_window::display_all_data): Update.
3801         * tui/tui-data.h (struct tui_win_info)
3802         <check_and_display_highlight_if_needed>: Declare.
3803
3804 2019-08-13  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-win.c (tui_resize_all): Call
3807         tui_delete_invisible_windows.
3808         * tui/tui-layout.c (show_layout): Call
3809         tui_delete_invisible_windows.
3810         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3811         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3812
3813 2019-08-13  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3816         tui_add_win_to_layout.
3817
3818 2019-08-13  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3821         * tui/tui-layout.c (tui_default_win_height): Now static.
3822
3823 2019-08-13  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3826         single switch.
3827         (show_source_disasm_command, show_source_or_disasm_and_command):
3828         Don't check current layout.
3829
3830 2019-08-13  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-wingeneral.c (make_all_visible): Remove.
3833         (tui_make_all_invisible): Simplify.
3834         * tui/tui-layout.c (tui_make_all_invisible): Move from
3835         tui-wingeneral.c; simplify.
3836         (show_layout): Hoist call to tui_make_all_invisible.
3837         (show_data): Don't call tui_make_all_invisible.
3838
3839 2019-08-13  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3842         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3843
3844 2019-08-13  Tom Tromey  <tom@tromey.com>
3845
3846         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3847         tui-data.c.
3848         (show_source_disasm_command, show_data)
3849         (show_source_or_disasm_and_command): Don't use
3850         tui_set_current_layout_to.
3851         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3852         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3853         tui-layout.c.
3854         (tui_set_current_layout_to): Remove.
3855
3856 2019-08-13  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-layout.c (tui_set_layout): Update.
3859         * tui/tui-data.h (struct tui_layout_def): Remove.
3860         (tui_layout_def): Don't declare.
3861         * tui/tui-data.c (layout_def): Remove.
3862         (tui_layout_def): Remove.
3863
3864 2019-08-13  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-winsource.h (struct tui_source_window_base)
3867         <clear_detail>: No longer "override".
3868         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3869         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3870         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3871         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3872         Remove.
3873         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3874
3875 2019-08-13  Tom Tromey  <tromey@adacore.com>
3876
3877         * tracepoint.c: Don't include readline.h or history.h.
3878
3879 2019-08-12  Tom Tromey  <tom@tromey.com>
3880
3881         * configure: Rebuild.
3882         * configure.ac: Check for readline 7.
3883         * NEWS: Mention readline 7 requirement.
3884         * README: Update.
3885
3886 2019-08-12  Tom Tromey  <tom@tromey.com>
3887
3888         * mingw-hdep.c (gdb_select): Remove readline hack.
3889
3890 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3891
3892         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3893         when the function fails.
3894
3895 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3896
3897         * s390-tdep.c (s390_type_align): New function.
3898         (s390_gdbarch_init): Set it as type_align gdbarch method.
3899
3900 2019-08-09  Tom de Vries  <tdevries@suse.de>
3901
3902         PR gdb/24591
3903         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3904         pc_low with relocation offset.
3905
3906 2019-08-07  Tom Tromey  <tromey@adacore.com>
3907
3908         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3909         (print_frame_args): Update.
3910         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3911         Update.
3912         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3913         * frame.h (struct frame_arg): Add initializers.
3914         <error>: Now a unique_xmalloc_ptr.
3915
3916 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3917
3918         * NEWS: Expand the Pointer Authentication entry.
3919         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3920         (aarch64_frame_unmask_lr): ... to this.
3921         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3922         Call aarch64_frame_unmask_lr.
3923         * frame.c (struct frame_info): Add "masked" variable.
3924         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3925         (fprint_frame): Check for masked pc.
3926         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3927         declarations.
3928         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3929         * stack.c (print_frame): Check for masked pc.
3930
3931 2019-08-06  Tom Tromey  <tom@tromey.com>
3932
3933         * stabsread.c (patch_block_stabs, read_one_struct_field)
3934         (read_enum_type): Use obstack_strndup.
3935         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3936         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3937         * dwarf2read.c (guess_full_die_structure_name)
3938         (anonymous_struct_prefix): Use obstack_strndup.
3939         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3940         * c-exp.y (yylex): Use obstack_strndup.
3941         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3942         (write_var_or_type): Use obstack_strndup.
3943
3944 2019-08-06  Tom Tromey  <tom@tromey.com>
3945
3946         * symfile.c (reread_symbols): Use obstack_strdup.
3947         * stabsread.c (read_type): Use obstack_strdup.
3948         * gdb_obstack.h (obstack_strdup): New overload.
3949         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3950         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3951         (dwarf2_canonicalize_name): Use obstack_strdup.
3952         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3953         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3954         Use obstack_strdup.
3955
3956 2019-08-06  Tom Tromey  <tom@tromey.com>
3957
3958         * gdb_obstack.h (obstack_strdup): Define.
3959         * gdb_obstack.c (obstack_strdup): Don't define.
3960
3961 2019-08-06  Tom Tromey  <tom@tromey.com>
3962
3963         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3964         obstack_strdup.
3965         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3966         obstack_strdup.
3967         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3968         * stabsread.c (common_block_start): Use obstack_strdup.
3969         * objfiles.c (set_objfile_main_name, objfile): Use
3970         obstack_strdup.
3971         * namespace.c (add_using_directive): Use obstack_strdup.
3972         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3973         * jit.c (finalize_symtab): Use obstack_strdup.
3974         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3975         (guess_partial_die_structure_name, partial_die_info::fixup)
3976         (dwarf2_name): Use obstack_strdup.
3977         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3978         obstack_strdup.
3979         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3980         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3981         obstack_strdup.
3982         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3983
3984 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * unittests/help-doc-selftests.c: New file.
3987         * Makefile.in: Add the new file.
3988
3989 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3990
3991         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3992         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3993         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3994         the trailing '.' is not output, and the first character is uppercased.
3995         (print_help_for_command): Update call to print_doc_line.
3996         (print_doc_of_command): Likewise.
3997         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3998         * cli/cli-option.c (append_indented_doc): Do not append newline.
3999         (build_help_option): Append newline after first appended_indented_doc
4000         only if a second call is done.
4001         (build_help): Append 2 new lines before each option, except the first
4002         one.
4003         * compile/compile.c (_initialize_compile): Add new lines after
4004         %OPTIONS%, when not at the end of the help.
4005         Change help doc or code
4006         producing the help doc to respect the invariants.
4007         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4008         Also removed the new line after 'Options:', as all other commands
4009         do not put an empty line between 'Options:' and the first option.
4010         * printcmd.c (_initialize_printcmd): Likewise.
4011         * stack.c (_initialize_stack): Likewise.
4012         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4013         incorrectly telling COMMAND is optional.
4014         * ada-lang.c (_initialize_ada_language): Change help doc or code
4015         producing the help doc to respect the invariants.
4016         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4017         * breakpoint.c (_initialize_breakpoint): Likewise.
4018         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4019         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4020         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4021         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4022         _initialize_cli_style): Likewise.
4023         * corelow.c (core_target_info): Likewise.
4024         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4025         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4026         * filesystem.c (_initialize_filesystem): Likewise.
4027         * frame.c (_initialize_frame): Likewise.
4028         * gnu-nat.c (add_task_commands): Likewise.
4029         * infcall.c (_initialize_infcall): Likewise.
4030         * infcmd.c (_initialize_infcmd): Likewise.
4031         * interps.c (_initialize_interpreter): Likewise.
4032         * language.c (_initialize_language): Likewise.
4033         * linux-fork.c (_initialize_linux_fork): Likewise.
4034         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4035         * maint.c (_initialize_maint_cmds): Likewise.
4036         * memattr.c (_initialize_mem): Likewise.
4037         * printcmd.c (_initialize_printcmd): Likewise.
4038         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4039         _RegEx): Likewise.
4040         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4041         * record-btrace.c (_initialize_record_btrace): Likewise.
4042         * record-full.c (_initialize_record_full): Likewise.
4043         * record.c (_initialize_record): Likewise.
4044         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4045         * regcache.c (_initialize_regcache): Likewise.
4046         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4047         _initialize_remote): Likewise.
4048         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4049         * serial.c (_initialize_serial): Likewise.
4050         * skip.c (_initialize_step_skip): Likewise.
4051         * source.c (_initialize_source): Likewise.
4052         * stack.c (_initialize_stack): Likewise.
4053         * symfile.c (_initialize_symfile): Likewise.
4054         * symtab.c (_initialize_symtab): Likewise.
4055         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4056         * top.c (init_main): Likewise.
4057         * tracefile-tfile.c (tfile_target_info): Likewise.
4058         * tracepoint.c (_initialize_tracepoint): Likewise.
4059         * tui/tui-win.c (_initialize_tui_win): Likewise.
4060         * utils.c (add_internal_problem_command): Likewise.
4061         * valprint.c (value_print_option_defs): Likewise.
4062
4063 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4064
4065         PR build/24886
4066         * configure.ac: Drop enable-libmcheck support.
4067         * configure, config.in: Rebuild.
4068         * libmcheck.m4: Remove.
4069         * acinclude.m4: Don't include it.
4070         * Makefile.in: Don't distribute it.
4071         * top.c (print_gdb_configuration): Don't mention it.
4072
4073 2019-08-06  Tom Tromey  <tom@tromey.com>
4074
4075         * utils.c (set_output_style): Sometimes pass stream to
4076         emit_style_escape.
4077         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4078         * record-btrace.c (btrace_insn_history): Update.
4079         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4080         method.
4081         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4082         Update initializers.
4083         <m_uiout>: New field.
4084         <m_di>: Move lower.
4085         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4086         Remove "uiout" parameter.
4087         (dump_insns): Update.
4088         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4089         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4090
4091 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4092
4093         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4094         (error_in_psymtab_expansion): Likewise.
4095         (lookup_symbol_via_quick_fns): Likewise.
4096         (basic_lookup_transparent_type_quick): Likewise.
4097         (basic_lookup_transparent_type_1): Likewise.
4098
4099 2019-08-06  Tom Tromey  <tromey@adacore.com>
4100
4101         * source.c (last_source_error): Now bool.
4102         (print_source_lines_base): Make "noprint" bool.  Only open
4103         source file when last_source_visited changes.
4104
4105 2019-08-06  Tom Tromey  <tromey@adacore.com>
4106
4107         * annotate.c (annotate_source_line): Use g_source_cache.
4108         * source-cache.c (source_cache::get_plain_source_lines): Change
4109         parameters.  Populate m_offset_cache.
4110         (source_cache::ensure): New method.
4111         (source_cache::get_line_charpos): New method.
4112         (extract_lines): Move lower.  Change parameters.
4113         (source_cache::get_source_lines): Move lower.
4114         * source-cache.h (class source_cache): Update comment.
4115         <get_line_charpos>: New method.
4116         <get_source_lines>: Update comment.
4117         <clear>: Clear m_offset_cache.
4118         <get_plain_source_lines>: Change parameters.
4119         <ensure>: New method
4120         <m_offset_cache>: New member.
4121         * source.c (forget_cached_source_info_for_objfile): Update.
4122         (info_source_command): Use g_source_cache.
4123         (find_source_lines, open_source_file_with_line_charpos): Remove.
4124         (print_source_lines_base, search_command_helper): Use g_source_cache.
4125         * source.h (open_source_file_with_line_charpos): Don't declare.
4126         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4127         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4128         Use g_source_cache.
4129
4130 2019-08-06  Tom Tromey  <tromey@adacore.com>
4131
4132         * source-cache.c (source_cache::get_plain_source_lines):
4133         Remove "first_line" and "last_line" parameters.
4134         (source_cache::get_source_lines): Cache plain text.
4135         * source-cache.h (class source_cache)
4136         <get_plain_source_lines>: Update.
4137
4138 2019-08-06  Tom Tromey  <tromey@adacore.com>
4139
4140         * source-cache.c (extract_lines): No longer a method.
4141         Changed type of parameter.  Include final newline.
4142         (selftests::extract_lines_test): New function.
4143         (_initialize_source_cache): Likewise.
4144         * source-cache.h (class source_cache)
4145         <extract_lines>: Don't declare.
4146
4147 2019-08-06  Tom Tromey  <tromey@adacore.com>
4148
4149         * breakpoint.c (init_breakpoint_sal): Update.
4150         (breakpoint): Update.
4151         * breakpoint.h (struct breakpoint) <filter>: Now a
4152         unique_xmalloc_ptr.
4153
4154 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4155
4156         * NEWS: Mention dictionary access on blocks.
4157         * python/py-block.c (blpy_getitem): New function.
4158         (block_object_as_mapping): New struct.
4159         (block_object_type): Use new struct for tp_as_mapping field.
4160
4161 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4162
4163         * objfiles.h (objfile): Add a comment describing partial symbols.
4164
4165 2019-08-05  Tom Tromey  <tromey@adacore.com>
4166
4167         * compile/compile.c (_initialize_compile): Use _(), not N_().
4168         * thread.c (_initialize_thread): Use _(), not N_().
4169         * stack.c (_initialize_stack): Use _(), not N_().
4170         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4171
4172 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4173
4174         * dwarf2read.c (struct dw2_symtab_iterator):
4175         <want_specific_block>: Remove.
4176         <block_index>: Change type to gdb::optional.
4177         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4178         change type of BLOCK_INDEX parameter to gdb::optional.
4179         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4180         (dw2_lookup_symbol): Don't pass argument for
4181         WANT_SPECIFIC_BLOCK.
4182         (dw2_expand_symtabs_for_function): Don't pass argument for
4183         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4184         (class dw2_debug_names_iterator)
4185         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4186         parameter, change BLOCK_INDEX type to gdb::optional.
4187         <m_want_specific_block>: Remove.
4188         <m_block_index>: Change type to gdb::optional.
4189         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4190         gdb::optional.  Re-write in function of gdb::optional.
4191         (dw2_debug_names_lookup_symbol): Don't pass argument for
4192         WANT_SPECIFIC_BLOCK.
4193         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4194         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4195         BLOCK_INDEX.
4196
4197 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4198
4199         * NEWS: Mention changes to "info sources" command.
4200
4201 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4202
4203         * symtab.c (filename_partial_match_opts): New struct type.
4204         (struct output_source_filename_data): New members
4205         regexp, c_regexp, partial_match.
4206         (output_source_filename): Use new members to decide to print file.
4207         (info_sources_option_defs): New variable.
4208         (make_info_sources_options_def_group, print_info_sources_header,
4209         info_sources_command_completer):
4210         New functions.
4211         (info_sources_command): Read new optional arguments.
4212         (_initialize_symtab): Update info sources help.
4213
4214 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4215
4216         * ada-lang.c (exception_support_info_v0): Renamed from...
4217         (default_exception_support_info): ... this.  Create new
4218         definition for v1.
4219         (ada_has_this_exception_support): Look up catch_handlers_sym.
4220         (ada_exception_support_info_sniffer): Try v0 after default.
4221
4222 2019-08-01  Tom Tromey  <tromey@adacore.com>
4223
4224         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4225         gdbarch.h.
4226
4227 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4228
4229         * s12z-tdep.c: Fix include path for s12z-opc.h.
4230
4231 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4232
4233         * NEWS: Require GNU make 3.82.
4234
4235 2019-07-16  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4238         declare.
4239
4240 2019-07-30  Tom Tromey  <tromey@adacore.com>
4241
4242         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4243
4244 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4245
4246         * printcmd.c (print_address_symbolic): Print negative offsets.
4247         (build_address_symbolic): Force signed arithmetic when computing
4248         offset.
4249
4250 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4251
4252         PR/24474: Add a function to lookup static variables.
4253         * NEWS: Mention this new function.
4254         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4255         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4256         * python/python.c (python_GdbMethods): Add new function.
4257
4258 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4259
4260         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4261         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4262         (objfpy_lookup_static_symbol): New function.
4263         (objfile_object_methods): Add new functions.
4264
4265 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4266
4267         * NEWS: Mention 'set|show print frame-info'.  Mention new
4268         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4269         backtrace argument.  Mention that python frame filtering code
4270         is now consistent with what 'backtrace' command prints.
4271
4272 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4273
4274         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4275         comments.
4276         (print_frame_info_auto, print_frame_info_source_line,
4277         print_frame_info_location, print_frame_info_source_and_location,
4278         print_frame_info_location_and_address, print_frame_info_short_location):
4279         New declarations.
4280         (struct frame_print_options): New member print_frame_info.
4281         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4282         * stack.h (get_user_print_what_frame_info): New declaration.
4283         (frame_show_address): New declaration.
4284         * stack.c (print_frame_arguments_choices): New value 'presence'.
4285         (print_frame_info_auto, print_frame_info_source_line,
4286         print_frame_info_location, print_frame_info_source_and_location,
4287         print_frame_info_location_and_address, print_frame_info_short_location,
4288         print_frame_info_choices, print_frame_info_print_what): New definitions.
4289         (print_frame_args): Only print dots for args if print frame-arguments
4290         is 'presence'.
4291         (frame_print_option_defs): New element for "frame-info".
4292         (get_user_print_what_frame_info): New function.
4293         (frame_show_address): Make non static.  Move comment to stack.h.
4294         (print_frame_info_to_print_what): New function.
4295         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4296         to decide what to print.
4297         (backtrace_command_1): Handle the new print_frame_arguments_presence
4298         value.
4299         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4300         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4301         (py_print_frame): In non-mi mode, use LOCATION as default for
4302         print_what, similarly to frame information printed directly by
4303         backtrace command. Handle frame-info user option in non MI mode.
4304
4305 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4306
4307         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4308         Add case for debugging 32-bit target on 64-bit host.  Revise
4309         comment.
4310
4311 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4312
4313         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4314         instead of find_function_entry_range_from_pc.
4315
4316 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4317
4318         * stack.c (find_frame_funname): Remove code which preferred
4319         minsym over symtab sym in "certain pathological cases".
4320
4321         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4322         parameter.  Change type of "do_demangle" to bool.
4323         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4324         Pass suitable "prefer_sym_over_minsym" flag to
4325         build_address_symbolic().  Don't output "+" for negative offsets.
4326         * printcmd.c (print_address_symbolic): Update invocation of
4327         build_address_symbolic to include a "prefer_sym_over_minsym"
4328         flag.
4329         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4330         Restrict cases in which use of minimal symbol is preferred to that
4331         of a found symbol.  Update comments.
4332
4333         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4334         for entry pc when entry pc is out of range for that FDE.
4335
4336 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4337
4338         PR gdb/24839:
4339         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4340         type.
4341
4342 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4343
4344         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4345         this function's Python signature.
4346
4347
4348 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4349
4350         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4351         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4352         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4353         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4354         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4355
4356
4357 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4358
4359         * h8300-tdep.c (h8300_register_name_common): New.
4360         h8300_register_name): Use h8300_register_name_common.
4361         (h8300s_register_name): Likewise.
4362         (h8300sx_register_name): Likewise.
4363         (h8300h_register_nam): New.
4364         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4365
4366
4367 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4368
4369         * arm-tdep.c (arm_skip_cmse_entry): New function.
4370         (arm_is_sgstubs_section): New function.
4371         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4372
4373 2019-07-22  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4376         Don't self-assign.
4377
4378 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4381         type_print.
4382
4383 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4386         so that GDB doesn't match any msymbols when searching in the
4387         TYPES_DOMAIN.
4388         (print_symbol_info): Print using typedef_print or type_print based
4389         on the type of the symbol.  Add updated FIXME comment moved from...
4390         (_initialize_symtab): ... move and update FIXME comment to above.
4391
4392 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4393
4394         * NEWS: Mention adding -q option to "info types".
4395         * symtab.c (struct info_types_options): New struct.
4396         (info_types_options_defs): New variable.
4397         (make_info_types_options_def_group): New function.
4398         (info_types_command): Use gdb::option framework to parse options.
4399         (info_types_command_completer): New function.
4400         (_initialize_symtab): Extend the help text on "info types" and
4401         register command completer.
4402
4403 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4404
4405         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4406         (lookup_symbol_in_objfile): Change int to block_enum and add a
4407         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4408
4409 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4410
4411         * MAINTAINERS (Write After Approval): Add self.
4412
4413 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4416         instruction to the dummy code region.
4417
4418 2019-07-19  Tom Tromey  <tromey@adacore.com>
4419
4420         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4421         (ARGSUSED, PARAMS, __func__): Remove rules.
4422
4423 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4424
4425         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4426         * features/arm/arm-with-iwmmxt.c: Remove.
4427         * features/arm/arm-with-iwmmxt.xml: Remove.
4428         * features/arm/arm-with-m-fpa-layout.c: Remove.
4429         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4430         * features/arm/arm-with-m-vfp-d16.c: Remove.
4431         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4432         * features/arm/arm-with-m.c: Remove.
4433         * features/arm/arm-with-m.xml: Remove.
4434         * features/arm/arm-with-neon.c: Remove.
4435         * features/arm/arm-with-neon.xml: Remove.
4436         * features/arm/arm-with-vfpv2.c: Remove.
4437         * features/arm/arm-with-vfpv2.xml: Remove.
4438         * features/arm/arm-with-vfpv3.c: Remove.
4439         * features/arm/arm-with-vfpv3.xml: Remove.
4440
4441 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4442
4443         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4444
4445 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4446
4447         * arch/aarch32.c (aarch32_create_target_description): Create
4448         target descriptions using features.
4449         * arch/arm.c (arm_create_target_description)
4450         (arm_create_mprofile_target_description): Likewise.
4451         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4452
4453 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4454
4455         * Makefile.in: Add new files.
4456         * aarch32-tdep.c: New file.
4457         * aarch32-tdep.h: New file.
4458         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4459         Call aarch32_read_description.
4460         * arch/aarch32.c: New file.
4461         * arch/aarch32.h: New file.
4462         * arch/arm.c (arm_create_target_description)
4463         (arm_create_mprofile_target_description): New function.
4464         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4465         (arm_create_target_description)
4466         (arm_create_mprofile_target_description): New declaration.
4467         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4468         read_description functions.
4469         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4470         Likewise.
4471         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4472         * arm-tdep.c (tdesc_arm_list): New variable.
4473         (arm_register_g_packet_guesses): Call create description functions.
4474         (arm_read_description) (arm_read_mprofile_description): New
4475         function.
4476         * arm-tdep.h (arm_read_description)
4477         (arm_read_mprofile_description): Add declaration.
4478         * configure.tgt: Add new files.
4479
4480 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4481
4482         * top.c (new_ui_command): Open specified terminal just once.
4483
4484 2019-07-18  Tom Tromey  <tromey@adacore.com>
4485
4486         * symtab.c (main_name): Constify return type.
4487         * symfile.c (set_initial_language): Update.
4488         * symtab.h (main_name): Constify return type.
4489
4490 2019-07-17  Tom Tromey  <tom@tromey.com>
4491
4492         * tui/tui-winsource.c (tui_update_source_window)
4493         (tui_update_source_window_as_is)
4494         (tui_update_source_windows_with_line): Remove return.
4495         * tui/tui-disasm.c (tui_show_disassem)
4496         (tui_show_disassem_and_update_source): Remove return.
4497         * tui/tui.c (tui_reset): Remove return.
4498         * tui/tui-wingeneral.c
4499         (tui_check_and_display_highlight_if_needed): Remove return.
4500
4501 2019-07-17  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4504
4505 2019-07-17  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-winsource.h (struct tui_exec_info_window)
4508         (struct tui_source_window_base): Move from tui-data.h.
4509         * tui/tui-winsource.c: Move many method definitions from
4510         elsewhere.  Remove "structuring" comments.
4511         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4512         (tui_source_window_base::refresh_window): Move to
4513         tui-winsource.c.
4514         * tui/tui-win.c (tui_source_window_base::refresh_all)
4515         (tui_source_window_base::update_tab_width)
4516         (tui_source_window_base::set_new_height)
4517         (tui_source_window_base::do_make_visible_with_new_height): Move to
4518         tui-winsource.c.
4519         * tui/tui-source.h: Update.
4520         * tui/tui-source.c (tui_source_window_base::reset): Move to
4521         tui-winsource.c.
4522         * tui/tui-disasm.h: Update.
4523         * tui/tui-data.h (struct tui_exec_info_window): Move to
4524         tui-winsource.h.
4525         (struct tui_source_window_base): Likewise.
4526         * tui/tui-data.c (tui_source_window_base::clear_detail)
4527         (tui_source_window_base, ~tui_source_window_base): Move to
4528         tui-winsource.c.
4529
4530 2019-07-17  Tom Tromey  <tom@tromey.com>
4531
4532         * tui/tui-win.c (tui_resize_all)
4533         (tui_source_window_base::update_tab_width)
4534         (tui_adjust_win_heights): Update.
4535         (tui_win_info::make_invisible_and_set_new_height): Rename from
4536         make_invisible_and_set_new_height.
4537         * tui/tui-data.h (struct tui_win_info)
4538         <make_invisible_and_set_new_height>: New method.
4539
4540 2019-07-17  Tom Tromey  <tom@tromey.com>
4541
4542         * tui/tui.c: Update.
4543         * tui/tui-source.h (struct tui_source_window): Move from
4544         tui-data.h.
4545         * tui/tui-layout.c: Update.
4546         * tui/tui-disasm.c: Update.
4547         * tui/tui-data.h (struct tui_source_window): Move to
4548         tui-source.h.
4549
4550 2019-07-17  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4553         tui-data.h.
4554         * tui/tui-data.h (struct tui_disasm_window): Move to
4555         tui-disasm.h.
4556
4557 2019-07-17  Tom Tromey  <tom@tromey.com>
4558
4559         * tui/tui-regs.h (struct tui_data_item_window): Move from
4560         tui-data.h.
4561         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4562         * tui/tui-data.h (struct tui_data_item_window): Move to
4563         tui-regs.h.
4564         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4565
4566 2019-07-17  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui.c: Update.
4569         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4570         (tui_cmd_window::max_height): Move to tui-command.c.
4571         * tui/tui-layout.c: Update.
4572         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4573         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4574         tui-command.c.
4575         * tui/tui-command.h (struct tui_cmd_window): Move from
4576         tui-data.h.
4577         * tui/tui-command.c: Remove "structuring" comments.
4578         (tui_cmd_window::clear_detail)
4579         (tui_cmd_window::do_make_visible_with_new_height)
4580         (tui_cmd_window::max_height): Move from elsewhere.
4581
4582 2019-07-17  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4585         Now static.
4586         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4587         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4588
4589 2019-07-17  Tom Tromey  <tom@tromey.com>
4590
4591         * tui/tui.c: Update.
4592         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4593         tui-regs.c.
4594         * tui/tui-windata.h: Remove file.
4595         * tui/tui-windata.c: Remove file.
4596         * tui/tui-win.c (tui_data_window::set_new_height)
4597         (tui_data_window::do_make_visible_with_new_height): Move to
4598         tui-regs.c.
4599         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4600         * tui/tui-regs.c: Remove "structuring" comments.
4601         (tui_data_window::first_data_item_displayed)
4602         (tui_data_window::delete_data_content_windows)
4603         (tui_data_window::erase_data_content)
4604         (tui_data_window::display_all_data)
4605         (tui_data_window::refresh_all)
4606         (tui_data_window::do_scroll_vertical)
4607         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4608         (tui_data_window::do_make_visible_with_new_height)
4609         (tui_data_window::refresh_window): Move from elsewhere.
4610         (_initialize_tui_regs): Move to end of file.
4611         * tui/tui-layout.c: Update.
4612         * tui/tui-hooks.c: Update.
4613         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4614         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4615         tui-regs.c.
4616         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4617
4618 2019-07-17  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4621         seen.
4622
4623 2019-07-17  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-win.c (tui_source_window_base::set_new_height)
4626         (tui_source_window_base::do_make_visible_with_new_height): Use
4627         m_has_locator field directly.
4628         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4629         method.
4630         (struct tui_source_window_base) <has_locator>: Likewise.
4631
4632 2019-07-17  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4635         Don't declare.
4636         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4637         Remove.
4638         * tui/tui-win.c (tui_source_window_base::set_new_height)
4639         (tui_source_window_base::set_new_height)
4640         (make_invisible_and_set_new_height)
4641         (tui_source_window_base::do_make_visible_with_new_height)
4642         (tui_source_window_base::do_make_visible_with_new_height):
4643         Update.
4644         * tui/tui-layout.c (show_source_disasm_command, show_data)
4645         (show_source_or_disasm_and_command): Update.
4646         * tui/tui-layout.c (show_layout): Update.
4647
4648 2019-07-17  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-layout.c (make_data_window): Remove.
4651         (show_data): Unify creation and re-initialization cases.
4652
4653 2019-07-17  Tom Tromey  <tom@tromey.com>
4654
4655         * tui/tui-layout.c (make_source_window, make_disasm_window):
4656         Remove.
4657         (show_data): Unify creation and re-initialization cases.
4658
4659 2019-07-17  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-layout.c (make_command_window): Remove.
4662         (show_source_disasm_command, show_source_or_disasm_and_command):
4663         Unify creation and re-initialization cases.
4664
4665 2019-07-17  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4668         creation and re-initialization cases.
4669
4670 2019-07-17  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-regs.c (tui_get_register): Return void.
4673
4674 2019-07-17  Tom Tromey  <tom@tromey.com>
4675
4676         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4677         Simplify.
4678
4679 2019-07-17  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4682         resetting.
4683
4684 2019-07-17  Tom Tromey  <tom@tromey.com>
4685
4686         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4687         * tui/tui-regs.c (tui_reg_layout): New function.
4688         (tui_show_registers, tui_reg_command): Use it.
4689         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4690         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4691         parameters.
4692         (tui_layout_command): Remove.
4693
4694 2019-07-17  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-layout.h (tui/tui-layout): Return void.
4697         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4698
4699 2019-07-17  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-layout.c (show_source_disasm_command, show_data):
4702         Update.
4703         (reset_locator): Remove.
4704         (show_source_or_disasm_and_command): Update.
4705
4706 2019-07-17  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-source.c (tui_source_window_base::reset): Remove
4709         win_type parameter.
4710         * tui/tui-layout.c (make_command_window, make_source_window)
4711         (make_disasm_window, make_data_window)
4712         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4713         (reset_locator, show_source_or_disasm_and_command): Update.
4714         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4715         win_type parameter.
4716         (struct tui_source_window_base) <reset>: Likewise.
4717
4718 2019-07-17  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-layout.c (show_source_disasm_command): Use
4721         reset_locator.
4722         (reset_locator): New function.
4723         (init_and_make_win): Remove.
4724         (show_source_or_disasm_and_command): Use reset_locator.
4725
4726 2019-07-17  Tom Tromey  <tom@tromey.com>
4727
4728         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4729         condition.
4730         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4731         Remove condition.
4732         * tui/tui-source.c (tui_source_window_base::reset): New method.
4733         * tui/tui-layout.c (make_command_window): Don't call
4734         init_and_make_win.
4735         (make_source_window, make_disasm_window): Don't call
4736         make_source_or_disasm_window.
4737         (make_data_window): Don't call init_and_make_win.  Change calling
4738         convention.
4739         (show_source_disasm_command, show_data): Simplify.
4740         (make_source_or_disasm_window): Remove.
4741         (show_source_or_disasm_and_command): Simplify.
4742         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4743         (struct tui_source_window_base) <reset>: Likewise.
4744         <execution_info>: Remove initializer.
4745         * tui/tui-data.c (tui_source_window_base): Initialize
4746         execution_info.
4747
4748 2019-07-17  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4751         variable.
4752
4753 2019-07-17  Tom Tromey  <tom@tromey.com>
4754
4755         * tui/tui.c (tui_rl_other_window): Update.
4756         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4757         superclass method first.  Always iterate over regs_content.
4758         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4759         method.
4760         * tui/tui-win.c (tui_set_focus_command): Update.
4761
4762 2019-07-17  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-win.c (tui_set_focus_command): Rename from
4765         tui_set_focus.  Call tui_enable.
4766         (tui_set_focus_command): Remove.
4767
4768 2019-07-17  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4771         refresh_window.
4772         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4773         touchwin.
4774         (tui_data_window::refresh_window): Call refresh_window on data
4775         items.  Always call superclass refresh_window.
4776         (tui_win_info::refresh): Remove.
4777         (tui_source_window_base::refresh_window): Update.
4778         (tui_refresh_all): Update.
4779         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4780         refresh_window.
4781         (show_source_or_disasm_and_command): Likewise.
4782         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4783         (struct tui_source_window_base) <refresh>: Likewise.
4784
4785 2019-07-17  Tom Tromey  <tom@tromey.com>
4786
4787         * tui/tui-winsource.c (tui_clear_source_content)
4788         (tui_show_source_content): Update.
4789         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4790         whether content is empty.
4791         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4792         Remove.
4793
4794 2019-07-17  Tom Tromey  <tom@tromey.com>
4795
4796         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4797         window's contents.
4798         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4799         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4800
4801 2019-07-17  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4804         (struct tui_data_item_window): Update.
4805
4806 2019-07-17  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4809         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4810         defines.
4811
4812 2019-07-17  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-winsource.h (tui_erase_source_content)
4815         (tui_clear_source_content): Remove "display_prompt" parameter.
4816         * tui/tui-winsource.c (tui_update_source_window_as_is)
4817         (tui_update_source_windows_with_addr): Update.
4818         (tui_clear_source_content): Remove "display_prompt" parameter.
4819         (tui_erase_source_content): Likewise.  Simplify.
4820         (tui_show_source_content): Update.
4821         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4822         * tui/tui-stack.c (tui_show_frame_info): Update.
4823         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4824         Remove defines.
4825
4826 2019-07-17  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4829         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4830         parameter.
4831         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4832         parameter.
4833
4834 2019-07-17  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-winsource.c (tui_clear_source_content)
4837         (tui_show_source_content, tui_show_exec_info_content)
4838         (tui_clear_exec_info_content): Update.
4839         * tui/tui-stack.c (tui_show_locator_content): Update.
4840         (tui_show_frame_info): Update.
4841         * tui/tui-source.h (tui_source_window): Don't declare.
4842         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4843         from tui_source_is_displayed.
4844         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4845         Remove field.
4846         (struct tui_source_window_base) <content_in_use>: New field.  Now
4847         bool.
4848         (struct tui_source_window) <showing_source_p>: New method.
4849         (TUI_SRC_WIN): Change cast.
4850         * tui/tui-data.c (tui_initialize_static_data): Update.
4851
4852 2019-07-17  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4855         location_matches_p.
4856         * tui/tui-source.c (tui_source_window::location_matches_p): New
4857         method.
4858         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4859         method.
4860         * tui/tui-data.h (struct tui_source_window_base)
4861         <location_matches_p>: New method.
4862         (struct tui_source_window, struct tui_disasm_window)
4863         <location_matches_p>: Likewise.
4864
4865 2019-07-17  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-win.c (tui_set_win_height_command): Rename from
4868         tui_set_win_height.
4869         (tui_set_win_height_command): Remove.
4870
4871 2019-07-17  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-source.c (tui_source_window): New constructor.  Add
4874         observer.
4875         (~tui_source_window): New destructor.
4876         (tui_source_window::style_changed): New method.
4877         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4878         (tui_attach_detach_observers): Update.
4879         * tui/tui-data.h (struct tui_source_window): Make constructor not
4880         inline.  Add destructor.
4881         (struct tui_source_window) <style_changed>: New method.
4882         <m_observable>: New member.
4883
4884 2019-07-17  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4887         * tui/tui-win.c (tui_resize_all): Fix typo.
4888
4889 2019-07-17  Tom Tromey  <tom@tromey.com>
4890
4891         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4892         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4893         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4894         * tui/tui-win.c (window_name_completer): Use foreach.
4895         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4896         (update_tab_width): Likewise.
4897         * tui/tui-layout.c (show_layout): Update.
4898         * tui/tui-data.h (class tui_window_iterator): New.
4899         (struct all_tui_windows): New.
4900         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4901
4902 2019-07-17  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4905         parameter.  Don't reference globals.
4906         (tui_reg_command): Update.
4907
4908 2019-07-17  Tom Tromey  <tom@tromey.com>
4909
4910         * tui/tui-regs.c (tui_show_registers): Simplify.
4911
4912 2019-07-17  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui-regs.c (tui_show_registers): Update.
4915         (tui_show_register_group): Add win_info parameter.
4916
4917 2019-07-17  Tom Tromey  <tom@tromey.com>
4918
4919         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4920         Rename from tui_display_reg_element_at_line.
4921         (tui_data_window::display_registers_from_line): Update.
4922         * tui/tui-data.h (struct tui_data_window)
4923         <display_reg_element_at_line>: New method.
4924
4925 2019-07-17  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-regs.h (tui_display_registers_from)
4928         (tui_display_registers_from_line): Don't declare.
4929         * tui/tui-windata.c (tui_data_window::display_all_data)
4930         (tui_data_window::refresh_all)
4931         (tui_data_window::do_scroll_vertical): Update.
4932         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4933         from tui_display_registers_from.
4934         (tui_display_reg_element_at_line): Update.
4935         (tui_data_window::display_registers_from_line): Rename from
4936         tui_display_registers_from_line.
4937         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4938         display_registers_from_line>: New methods.
4939
4940 2019-07-17  Tom Tromey  <tom@tromey.com>
4941
4942         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4943         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4944         from tui_erase_data_content.
4945         (tui_data_window::display_all_data)
4946         (tui_data_window::refresh_all)
4947         (tui_data_window::do_scroll_vertical): Update.
4948         * tui/tui-regs.c (tui_show_registers): Update.
4949         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4950         New method.
4951
4952 2019-07-17  Tom Tromey  <tom@tromey.com>
4953
4954         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4955         declare.
4956         * tui/tui-windata.c
4957         (tui_data_window::delete_data_content_windows): Rename from
4958         tui_delete_data_content_windows.
4959         (tui_data_window::display_all_data)
4960         (tui_data_window::do_scroll_vertical): Update.
4961         * tui/tui-data.h (struct tui_data_window)
4962         <delete_data_content_windows>: New method.
4963
4964 2019-07-17  Tom Tromey  <tom@tromey.com>
4965
4966         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4967         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4968
4969 2019-07-17  Tom Tromey  <tom@tromey.com>
4970
4971         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4972         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4973         from tui_display_all_data.
4974         * tui/tui-win.c
4975         (tui_data_window::do_make_visible_with_new_height): Update.
4976         * tui/tui-regs.c (tui_show_registers): Update.
4977         * tui/tui-layout.c (tui_set_layout): Update.
4978         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4979         method.
4980
4981 2019-07-17  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4984         * tui/tui-windata.c (tui_display_data_from): Remove.
4985         (tui_data_window::refresh_all): Update.
4986
4987 2019-07-17  Tom Tromey  <tom@tromey.com>
4988
4989         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4990         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4991         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4992         tui_display_registers_from_line.
4993         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4994         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4995         "force_display" parameter.
4996
4997 2019-07-17  Tom Tromey  <tom@tromey.com>
4998
4999         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5000         declare.
5001         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5002         Rename from tui_first_reg_element_no_inline.
5003         (tui_display_reg_element_at_line)
5004         (tui_display_registers_from_line): Update.
5005         * tui/tui-data.h (struct tui_data_window)
5006         <first_reg_element_no_inline>: New method.
5007
5008 2019-07-17  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-windata.c (tui_display_data_from)
5011         (tui_data_window::do_scroll_vertical): Update.
5012         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5013         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5014         Rename from tui_line_from_reg_element_no.
5015         (tui_display_registers_from_line): Update.
5016         * tui/tui-data.h (struct tui_data_window)
5017         <line_from_reg_element_no>: New method.
5018
5019 2019-07-17  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5022         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5023         tui_last_regs_line_no.
5024         (tui_display_reg_element_at_line)
5025         (tui_display_registers_from_line): Update.
5026         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5027         method.
5028
5029 2019-07-17  Tom Tromey  <tom@tromey.com>
5030
5031         PR tui/24722:
5032         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5033         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5034         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5035         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5036         (tui_update_breakpoint_info): Likewise.
5037         * tui/tui-hooks.c (tui_event_create_breakpoint)
5038         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5039         Update.
5040
5041 2019-07-17  Tom Tromey  <tom@tromey.com>
5042
5043         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5044
5045 2019-07-17  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-winsource.c (tui_update_source_window_as_is)
5048         (tui_update_source_windows_with_addr): Update.
5049         * tui/tui-source.h (tui_set_source_content)
5050         (tui_show_symtab_source): Add "win_info" parameter.
5051         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5052         parameter.
5053         (tui_show_symtab_source): Likewise.
5054
5055 2019-07-17  Tom Tromey  <tom@tromey.com>
5056
5057         * tui/tui-wingeneral.c
5058         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5059
5060 2019-07-17  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5063         (struct tui_cmd_window) <can_scroll>: New method.
5064         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5065         method.
5066
5067 2019-07-17  Tom Tromey  <tromey@adacore.com>
5068
5069         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5070         do_field_signed>: Rename.  Change type of "value".
5071         * ui-out.c (ui_out::field_signed): Rename from field_int.
5072         Change type of "value".
5073         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5074         type of "value".
5075         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5076         do_field_int.  Change type of "value".
5077         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5078         do_field_int.  Change type of "value".
5079         * tracepoint.c (trace_status_mi, tfind_1)
5080         (print_one_static_tracepoint_marker): Update.
5081         * thread.c (print_thread_info_1, print_selected_thread_frame):
5082         Update.
5083         * stack.c (print_frame, print_frame_info): Update.
5084         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5085         Update.
5086         * source.c (print_source_lines_base): Update.
5087         * skip.c (info_skip_command): Update.
5088         * record-btrace.c (btrace_ui_out_decode_error)
5089         (btrace_call_history_src_line): Update.
5090         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5091         Update.
5092         * progspace.c (print_program_space): Update.
5093         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5094         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5095         do_field_int.  Change type of "value".
5096         * mi/mi-out.c (mi_ui_out::do_table_begin)
5097         (mi_ui_out::do_table_header): Update.
5098         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5099         type of "value".
5100         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5101         (mi_cmd_data_list_changed_registers, output_register)
5102         (mi_cmd_data_read_memory, mi_load_progress)
5103         (mi_cmd_trace_frame_collected): Update.
5104         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5105         Update.
5106         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5107         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5108         (mi_cmd_var_list_children, varobj_update_one): Update.
5109         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5110         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5111         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5112         * inferior.c (print_inferior): Update.
5113         * gdb_bfd.c (print_one_bfd): Update.
5114         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5115         Update.
5116         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5117         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5118         do_field_int.  Change type of "value".
5119         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5120         do_field_int.  Change type of "value".
5121         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5122         (print_one_breakpoint_location, print_it_catch_fork)
5123         (print_one_catch_fork, print_it_catch_vfork)
5124         (print_one_catch_vfork, print_it_catch_solib)
5125         (print_it_catch_exec, print_it_ranged_breakpoint)
5126         (print_mention_watchpoint, print_mention_masked_watchpoint)
5127         (bkpt_print_it, update_static_tracepoint): Update.
5128         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5129         * break-catch-syscall.c (print_it_catch_syscall): Update.
5130         * ada-tasks.c (print_ada_task_info): Update.
5131         * ada-lang.c (print_it_exception, print_mention_exception):
5132         Update.
5133
5134 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         PR breakpoints/24541
5137         * gdbarch.c: Regenerate.
5138         * gdbarch.h: Regenerate.
5139         * gdbarch.sh: Adjust return type and parameter types for
5140         'stap_adjust_register'.
5141         (i386_stap_adjust_register): Adjust signature and return new
5142         register name.
5143         * stap-probe.c (stap_parse_register_operand): Adjust use of
5144         'gdbarch_stap_adjust_register'.
5145
5146 2019-07-17  Tom Tromey  <tromey@adacore.com>
5147
5148         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5149         declare VEC.
5150         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5151         std::vector.
5152         (struct s390_process_info): Add initializers.
5153         (s390_add_process): Use new.
5154         (s390_linux_nat_target::low_forget_process): Use delete.
5155         (s390_linux_nat_target::low_new_fork)
5156         (s390_linux_nat_target::stopped_by_watchpoint)
5157         (s390_linux_nat_target::low_prepare_to_resume)
5158         (s390_linux_nat_target::insert_watchpoint)
5159         (s390_linux_nat_target::insert_hw_breakpoint)
5160         (s390_linux_nat_target::remove_watchpoint)
5161         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5162
5163 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5164
5165         * aarch64-fbsd-nat.c: Include regcache.h.
5166         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5167         argument.
5168         (aarch64_fbsd_nat_target::fetch_registers)
5169         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5170         variable.
5171         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5172
5173 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5174
5175         * fbsd-nat.c: Include gdbarch.h.
5176
5177 2019-07-15  Tom Tromey  <tromey@adacore.com>
5178
5179         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5180
5181 2019-07-15  Tom Tromey  <tromey@adacore.com>
5182
5183         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5184         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5185         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5186         * cli-out.c (cli_ui_out::do_field_int): New method.
5187         * ui-out.c (ui_out::field_unsigned): New method.
5188         * symfile.c (generic_load): Use field_unsigned.
5189         (print_transfer_performance): Likewise.
5190         * record-btrace.c (ui_out_field_uint): Remove.
5191         (btrace_call_history_insn_range, btrace_call_history): Use
5192         field_unsigned.
5193         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5194         field_unsigned.
5195         * ui-out.h (class ui_out) <field_unsigned>: New method.
5196         <do_field_unsigned>: Likewise.
5197
5198 2019-07-15  Tom Tromey  <tromey@adacore.com>
5199
5200         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5201         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5202         * target.c (flash_erase_command): Use field_string.
5203         * infrun.c (print_signal_received_reason): Use field_string.
5204         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5205         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5206         field_string.
5207         * ada-tasks.c (print_ada_task_info): Use field_string.
5208
5209 2019-07-15  Tom Tromey  <tromey@adacore.com>
5210
5211         * target.c (flash_erase_command): Use field_core_addr.
5212         * symfile.c (generic_load): Use field_core_addr.
5213         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5214         Use field_core_addr.
5215         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5216         field_core_addr.
5217
5218 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5219
5220         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5221         value if its desired type is smaller than a CORE_ADDR and signed.
5222
5223 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5224
5225         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5226         of changes to field names, and use new is_reference field to
5227         decide if a property is a reference or not.
5228         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5229         field.
5230         (struct dwarf2_property_baton): Update header comment, rename
5231         'referenced_type' to 'property_type' and update comments.
5232         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5233         default property type, store in property baton, update to take
5234         accound of renamed field.
5235         (read_func_scope): Update call to attr_to_dynamic_prop.
5236         (read_array_type): Likewise.
5237         (dwarf2_per_cu_addr_sized_int_type): New function.
5238         (read_subrange_index_type): Move type finding code to
5239         dwarf2_per_cu_addr_sized_int_type.
5240         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5241         (dwarf2_per_cu_addr_type): New function.
5242         (set_die_type): Update calls to attr_to_dynamic_prop.
5243
5244 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * dwarf2read.c (read_subrange_index_type): New function.
5247         (read_subrange_type): Move code into new function and call it.
5248         * gdbtypes.c (create_range_type): Add some asserts.
5249
5250 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5251
5252         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5253         update return statements.
5254         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5255         declaration, and update comment to match.
5256         * gdbtypes.c (resolve_dynamic_array): Update call to
5257         dwarf2_evaluate_property to match new return type.
5258
5259 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5260
5261         * valarith.c (value_subscripted_rvalue): Change lowerbound
5262         parameter type from int to LONGEST.
5263         * value.h (value_subscripted_rvalue): Likewise in declaration.
5264
5265 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * cli/cli-utils.c (info_print_command_completer): New function.
5268         * cli/cli-utils.h: Add 'completer.h' include, and forward
5269         declaration for 'struct cmd_list_element'.
5270         (info_print_command_completer): Declare.
5271         * stack.c (_initialize_stack): Add completer for 'info locals' and
5272         'info args'.
5273         * symtab.c (_initialize_symtab): Add completer for 'info
5274         variables' and 'info functions'.
5275         * NEWS: Mention completion for additional info commands.
5276
5277 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5278
5279         * cli/cli-utils.c (extract_info_print_args): Delete.
5280         (extract_arg_maybe_quoted): Delete.
5281         (info_print_options_defs): New variable.
5282         (make_info_print_options_def_group): New function.
5283         (extract_info_print_options): Define new function.
5284         * cli/cli-utils.h (extract_info_print_args): Delete.
5285         (struct info_print_options): New structure.
5286         (extract_info_print_options): Declare new function.
5287         * stack.c (info_locals_command): Update to use new
5288         extract_info_print_options, also add a header comment.
5289         (info_args_command): Likewise.
5290         * symtab.c (info_variables_command): Likewise.
5291         (info_functions_command): Likewise.
5292
5293 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5294
5295         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5296         to extract string arguments.
5297         * common/common-utils.c (extract_string_maybe_quoted): New function.
5298         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5299
5300 2019-07-11  Tom Tromey  <tromey@adacore.com>
5301
5302         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5303         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5304         * top.h (gdbinit): Don't declare.
5305         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5306         into...
5307         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5308         * top.c (gdb_init): Don't call init_cli_cmds.
5309         (gdbinit): Remove.
5310         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5311
5312 2019-07-11  Tom Tromey  <tromey@adacore.com>
5313
5314         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5315         after it has been moved.
5316
5317 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5318
5319         * valops.c (value_must_coerce_to_target): Change return type to
5320         bool.
5321         * value.h (value_must_coerce_to_target): Likewise.
5322
5323 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5324
5325         * breakpoint.c (is_hardware_watchpoint): Remove
5326         forward-declaration.
5327         (is_masked_watchpoint): Change return type to bool.
5328         (is_tracepoint): Likewise.
5329         (is_breakpoint): Likewise.
5330         (is_hardware_watchpoint): Likewise.
5331         (is_watchpoint): Likewise.
5332         (is_no_memory_software_watchpoint): Likewise.
5333         (is_catchpoint): Likewise.
5334         (breakpoint_1): Make FILTER parameter's return type bool.
5335         is_masked_watchpoint): Change return type to bool.
5336         (save_breakpoints): Make FILTER parameter's return type bool.
5337         * breakpoint.h (is_breakpoint): Change return type to bool.
5338         (is_watchpoint): Likewise.
5339         (is_catchpoint): Likewise.
5340         (is_tracepoint): Likewise.
5341
5342 2019-07-10  Tom Tromey  <tom@tromey.com>
5343
5344         * defs.h: Don't include gdbarch.h.
5345         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5346         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5347         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5348         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5349         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5350         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5351         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5352         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5353         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5354         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5355         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5356         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5357         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5358         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5359         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5360         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5361         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5362         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5363         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5364         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5365         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5366         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5367         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5368         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5369         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5370         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5371         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5372
5373 2019-07-10  Tom Tromey  <tromey@adacore.com>
5374
5375         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5376         * breakpoint.c (init_ada_exception_breakpoint): Register as
5377         bp_catchpoint.
5378         (print_one_breakpoint_location, print_one_breakpoint): Use
5379         is_ada_exception_catchpoint.
5380         * ada-lang.c (class ada_catchpoint_location): Pass
5381         bp_loc_software_breakpoint to bp_location constructor.
5382         (is_ada_exception_catchpoint): New function.
5383
5384 2019-07-10  Tom Tromey  <tromey@adacore.com>
5385
5386         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5387         VEC.
5388         (struct arm_exidx_entry): New method operator<.
5389         (struct arm_exidx_data) <section_maps>: Change type.
5390         (arm_exidx_data_free): Remove.
5391         (arm_exidx_data_key): Change type.  Move lower.
5392         (arm_exidx_new_objfile): Update.
5393         (arm_compare_exidx_entries): Remove.
5394         (arm_find_exidx_entry, _initialize_arm_tdep)
5395
5396 2019-07-10  Tom Tromey  <tromey@adacore.com>
5397
5398         * solib-spu.c (ocl_program_data_key): Change type.
5399         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5400         Update.
5401
5402 2019-07-10  Tom Tromey  <tromey@adacore.com>
5403
5404         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5405         (struct solib_aix_inferior_data) <library_list>: Change type.
5406         (solib_aix_inferior_data_handle): Change type.
5407         (get_solib_aix_inferior_data): Update.
5408         (solib_aix_free_library_list): Remove.
5409         (library_list_start_library): Update.
5410         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5411         return type.
5412         (solib_aix_get_library_list)
5413         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5414         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5415
5416 2019-07-10  Tom Tromey  <tromey@adacore.com>
5417
5418         * solib-dsbt.c (struct dsbt_info): Add initializers.
5419         (solib_dsbt_pspace_data): Change type.
5420         (dsbt_pspace_data_cleanup): Remove.
5421         (get_dsbt_info, _initialize_dsbt_solib): Update.
5422
5423 2019-07-10  Tom Tromey  <tromey@adacore.com>
5424
5425         * spu-tdep.c (spu_overlay_data): Change type.
5426         (spu_get_overlay_table, spu_overlay_new_objfile)
5427         (_initialize_spu_tdep): Update.
5428
5429 2019-07-10  Tom Tromey  <tromey@adacore.com>
5430
5431         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5432         destructor.
5433         (dbx_objfile_data_key): Change type and declare later.
5434         (DBX_SYMFILE_INFO): Rewrite.
5435         * dbxread.c (dbx_objfile_data_key): Change type.
5436         (dbx_symfile_init): Update.
5437         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5438         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5439         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5440
5441 2019-07-10  Tom Tromey  <tromey@adacore.com>
5442
5443         * jit.c (jit_program_space_key): Change type.  Move lower.
5444         (get_jit_program_space_data): Update.
5445         (jit_program_space_data_cleanup): Remove.
5446         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5447         Update.
5448         (struct jit_program_space_data): Add initializers.
5449
5450 2019-07-10  Tom Tromey  <tromey@adacore.com>
5451
5452         * solib-darwin.c (struct darwin_info): Add initializers.
5453         (solib_darwin_pspace_data): Change type.
5454         (darwin_pspace_data_cleanup): Remove.
5455         (get_darwin_info, _initialize_darwin_solib): Update.
5456
5457 2019-07-10  Tom Tromey  <tromey@adacore.com>
5458
5459         * remote-sim.c (struct sim_inferior_data): Add initializers,
5460         constructor, and destructor.
5461         (sim_inferior_data_key): Change type.  Move lower.
5462         (check_for_duplicate_sim_descriptor): Update.
5463         (get_sim_inferior_data): Use new.  Update.
5464         (~sim_inferior_data_cleanup): Rename from
5465         sim_inferior_data_cleanup.  Simplify.
5466         (gdbsim_close_inferior, simulator_command)
5467         (sim_command_completer, _initialize_remote_sim): Update.
5468         (next_pid, INITIAL_PID): Move earlier.
5469
5470 2019-07-10  Tom Tromey  <tromey@adacore.com>
5471
5472         * python/python-internal.h (create_thread_object): Return
5473         gdbpy_ref.
5474         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5475         * python/py-inferior.c (struct threadlist_entry): Add
5476         constructor.
5477         <thread_obj>: Now a gdbpy_ref.
5478         (thread_to_thread_object): Update.
5479         (add_thread_object): Use new.
5480         (delete_thread_object): Use delete.
5481         (infpy_threads): Update.
5482         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5483         GIL.
5484
5485 2019-07-10  Tom Tromey  <tromey@adacore.com>
5486
5487         * valops.c (value_cast): Specialize error message for Ada.
5488
5489 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5490
5491         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5492
5493 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5494
5495         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5496         bpstat_should_step): Return bool, adjust comments.
5497         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5498         bpstat_should_step): Likewise.
5499
5500 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5501
5502         * features/Makefile: Use feature target descriptions for Arm.
5503         * features/arm/arm-core.c: Generate new file.
5504         * features/arm/arm-fpa.c: Likewise.
5505         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5506         * features/arm/arm-m-profile.c: Likewise.
5507         * features/arm/arm-vfpv2.c: Likewise.
5508         * features/arm/arm-vfpv3.c: Likewise.
5509         * features/arm/xscale-iwmmxt.c: Likewise.
5510         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5511
5512 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5513
5514         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5515         ptrace earlier.
5516
5517 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5518
5519         * features/aarch64-pauth.c: Regenerate.
5520
5521 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5522
5523         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5524         bool.
5525         (bpstat_what): Use false instead of 0.
5526
5527 2019-07-09  Pedro Alves  <palves@redhat.com>
5528
5529         * break-catch-throw.c (is_exception_catchpoint): New.
5530         * breakpoint.c (print_one_breakpoint_location): New parameter
5531         'raw_loc'.  Handle it.  Use
5532         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5533         looking at the breakpoint's type.
5534         (print_one_breakpoint): If handling "maint info breakpoints", also
5535         print locations of exception catchpoints.
5536         * breakpoint.h (is_exception_catchpoint): Declare.
5537
5538 2019-07-09  Pedro Alves  <palves@redhat.com>
5539
5540         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5541         "addr" field.
5542         (allocate_location_exception_catchpoint): New.
5543         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5544         (initialize_throw_catchpoint_ops): Install
5545         allocate_location_exception_catchpoint as allocate_location
5546         method.
5547         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5548         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5549         bp_loc_other.
5550         (breakpoint_address_is_meaningful): Delete.
5551         (bl_address_is_meaningful): New.
5552         (breakpoint_locations_match): Adjust comment.
5553         (bp_location_from_bp_type): New, factored out of...
5554         (bp_location::bp_location(breakpoint *)): ... this.
5555         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5556         factored out of...
5557         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5558         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5559         breakpoint_address_is_meaningful.
5560         (bp_locations_compare): Adjust comment.
5561         (update_global_location_list): Use bl_address_is_meaningful
5562         instead of breakpoint_address_is_meaningful.
5563         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5564         explicit.
5565         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5566         * python/py-breakpoint.c (bppy_get_location): No longer check
5567         whether location is null.
5568
5569 2019-07-09  Pedro Alves  <palves@redhat.com>
5570
5571         PR c++/15468
5572         * breakpoint.c (print_one_breakpoint_location): Remove
5573         single-location assert.
5574
5575 2019-07-09  Tom Tromey  <tom@tromey.com>
5576
5577         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5578         * configure: Rebuild.
5579         * configure.ac: Change common to gdbsupport.
5580         * gdbsupport: Rename from common.
5581         * acinclude.m4: Change common to gdbsupport.
5582         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5583         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5584         gdbsupport.
5585         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5586         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5587         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5588         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5589         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5590         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5591         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5592         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5593         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5594         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5595         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5596         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5597         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5598         coff-pe-read.c, command.h, compile/compile-c-support.c,
5599         compile/compile-c.h, compile/compile-cplus-symbols.c,
5600         compile/compile-cplus-types.c, compile/compile-cplus.h,
5601         compile/compile-loc2c.c, compile/compile.c, completer.c,
5602         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5603         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5604         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5605         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5606         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5607         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5608         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5609         features/aarch64-core.c, features/aarch64-fpu.c,
5610         features/aarch64-pauth.c, features/aarch64-sve.c,
5611         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5612         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5613         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5614         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5615         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5616         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5617         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5618         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5619         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5620         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5621         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5622         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5623         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5624         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5625         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5626         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5627         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5628         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5629         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5630         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5631         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5632         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5633         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5634         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5635         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5636         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5637         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5638         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5639         minsyms.c, mips-linux-tdep.c, namespace.h,
5640         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5641         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5642         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5643         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5644         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5645         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5646         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5647         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5648         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5649         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5650         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5651         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5652         procfs.c, producer.c, progspace.h, psymtab.h,
5653         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5654         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5655         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5656         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5657         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5658         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5659         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5660         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5661         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5662         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5663         target-memory.c, target.c, target.h, target/waitstatus.c,
5664         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5665         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5666         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5667         unittests/array-view-selftests.c,
5668         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5669         unittests/common-utils-selftests.c,
5670         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5671         unittests/format_pieces-selftests.c,
5672         unittests/function-view-selftests.c,
5673         unittests/lookup_name_info-selftests.c,
5674         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5675         unittests/mkdir-recursive-selftests.c,
5676         unittests/observable-selftests.c,
5677         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5678         unittests/parse-connection-spec-selftests.c,
5679         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5680         unittests/scoped_fd-selftests.c,
5681         unittests/scoped_mmap-selftests.c,
5682         unittests/scoped_restore-selftests.c,
5683         unittests/string_view-selftests.c, unittests/style-selftests.c,
5684         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5685         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5686         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5687         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5688         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5689         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5690
5691 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5692
5693         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5694         bool value.
5695         (decode_digits_ordinary): Set explicit_line field in sal.
5696         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5697         symtab_and_line that was set on an explicit line number in
5698         assembler code.  Do always update the recorded symtab and line if
5699         we do skip the prologue.
5700
5701 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5702
5703         * breakpoint.c (set_breakpoint_location_function): Remove
5704         explicit_loc parameter.
5705         (momentary_breakpoint_from_master): Update call to
5706         set_breakpoint_location_function.
5707         (add_location_to_breakpoint): Likewise.
5708
5709 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5710
5711         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5712         required features based on default bfd type when no specific bfd
5713         is present.
5714
5715 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5716
5717         * NEWS: Mention that GDB printf and eval commands can now print
5718         C-style and Ada-style convenience var strings without
5719         calling the inferior.
5720         * printcmd.c (printf_c_string): Locally print GDB internal var
5721         instead of transiting via the inferior.
5722         (printf_wide_c_string): Likewise.
5723
5724 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5725
5726         PR breakpoints/25011
5727         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5728
5729 2019-07-04  Tom Tromey  <tom@tromey.com>
5730
5731         PR tui/24724:
5732         * tui/tui-winsource.c (tui_clear_source_content): Update.
5733         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5734         (tui_update_breakpoint_info): Update.
5735         (tui_set_exec_info_content): Update.
5736         * tui/tui-source.c (tui_set_source_content_nil): Update.
5737         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5738         has_break.
5739         * tui/tui-data.h (enum tui_bp_flag): New.
5740         (tui_bp_flags): New enum flags type.
5741         (struct tui_source_element) <break_mode>: Change type.  Rename
5742         from has_break.
5743         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5744         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5745         constants.
5746         * tui/tui-winsource.h: Fix comment.
5747
5748 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5749
5750         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5751         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5752         (store_fpregs_to_thread)
5753         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5754         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5755         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5756         (IWMMXT_REGS_SIZE): Add define.
5757         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5758         (fetch_vfp_regs, store_vfp_regs)
5759         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5760         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5761
5762 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5763
5764         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5765         defines.
5766         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5767         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5768         (ARM_INT_REGISTER_SIZE): ...to this.
5769         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5770         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5771         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5772         (arm_linux_collect_gregset, supply_nwfpe_register)
5773         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5774         defines.
5775         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5776         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5777         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5778         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5779         (arm_return_in_memory, arm_store_return_value)
5780         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5781         (arm_record_ld_st_multiple): Likewise.
5782         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5783         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5784
5785 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5786
5787         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5788         AARCH64_DISPLACED_MODIFIED_INSNS.
5789         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5790         (aarch64_displaced_step_copy_insn): Likewise.
5791         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5792         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5793         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5794         ARM_DISPLACED_MODIFIED_INSNS.
5795         * arm-tdep.c (arm_gdbarch_init): Likewise.
5796         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5797         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5798         (struct arm_displaced_step_closure): Use
5799         ARM_DISPLACED_MODIFIED_INSNS.
5800
5801 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5802
5803         * features/Makefile: Remove unused xml files.
5804         * features/aarch64.xml: Remove.
5805         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5806         * features/i386/amd64-avx-avx512.xml: Remove.
5807         * features/i386/amd64-avx-linux.xml: Remove.
5808         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5809         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5810         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5811         * features/i386/amd64-avx-mpx.xml: Remove.
5812         * features/i386/amd64-avx.xml: Remove.
5813         * features/i386/amd64-linux.xml: Remove.
5814         * features/i386/amd64-mpx-linux.xml: Remove.
5815         * features/i386/amd64-mpx.xml: Remove.
5816         * features/i386/amd64.xml: Remove.
5817         * features/i386/i386-avx-avx512-linux.xml: Remove.
5818         * features/i386/i386-avx-avx512.xml: Remove.
5819         * features/i386/i386-avx-linux.xml: Remove.
5820         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5821         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5822         * features/i386/i386-avx-mpx-linux.xml: Remove.
5823         * features/i386/i386-avx-mpx.xml: Remove.
5824         * features/i386/i386-avx.xml: Remove.
5825         * features/i386/i386-linux.xml: Remove.
5826         * features/i386/i386-mmx-linux.xml: Remove.
5827         * features/i386/i386-mmx.xml: Remove.
5828         * features/i386/i386-mpx-linux.xml: Remove.
5829         * features/i386/i386-mpx.xml: Remove.
5830         * features/i386/i386.xml: Remove.
5831         * features/i386/x32-avx-avx512-linux.xml: Remove.
5832         * features/i386/x32-avx-linux.xml: Remove.
5833         * features/i386/x32-linux.xml: Remove.
5834
5835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5836
5837         * regformats/aarch64.dat: Remove.
5838         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5839         * regformats/i386/amd64-avx-linux.dat: Remove.
5840         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5841         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5842         * regformats/i386/amd64-linux.dat: Remove.
5843         * regformats/i386/amd64-mpx-linux.dat: Remove.
5844         * regformats/i386/amd64.dat: Remove.
5845         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5846         * regformats/i386/i386-avx-linux.dat: Remove.
5847         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5848         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5849         * regformats/i386/i386-linux.dat: Remove.
5850         * regformats/i386/i386-mmx-linux.dat: Remove.
5851         * regformats/i386/i386-mpx-linux.dat: Remove.
5852         * regformats/i386/i386.dat: Remove.
5853         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5854         * regformats/i386/x32-avx-linux.dat: Remove.
5855         * regformats/i386/x32-linux.dat: Remove.
5856
5857 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5858
5859         * aarch64-tdep.c: Remove xml self tests.
5860         * amd64-linux-tdep.c: Likewise.
5861         * amd64-tdep.c: Likewise.
5862         * i386-linux-tdep.c: Likewise.
5863         * i386-tdep.c: Likewise.
5864
5865 2019-07-03  Pedro Alves  <palves@redhat.com>
5866
5867         PR cli/24732
5868         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5869         (pipe_cmd_option_defs): New.
5870         (make_pipe_cmd_options_def_group): New.
5871         (pipe_command): Use gdb::option::process_options.
5872         (pipe_command_completer): New function.
5873         (_initialize_cli_cmds): Install completer for "pipe" command.
5874
5875 2019-07-03  Pedro Alves  <palves@redhat.com>
5876
5877         * cli/cli-option.c (union option_value) <string>: New field.
5878         (struct option_def_and_value): Add ctor, move ctor, dtor and
5879         use DISABLE_COPY_AND_ASSIGN.
5880         (option_def_and_value::clear_value): New.
5881         (parse_option, save_option_value_in_ctx, get_val_type_str)
5882         (add_setshow_cmds_for_options): Handle var_string.
5883         * cli-option.h (union option_def::var_address) <string>: New
5884         field.
5885         (struct string_option_def): New.
5886         * maint-test-options.c (struct test_options_opts): Add default
5887         ctor and use DISABLE_COPY_AND_ASSIGN.
5888         <string_opt>: New field.
5889         (test_options_opts::~test_options_opts): New.
5890         (test_options_opts::dump): Also dump "-string".
5891         (test_options_option_defs): Install "string.
5892
5893 2019-07-03  Pedro Alves  <palves@redhat.com>
5894
5895         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5896         option_value with a null enumeration.
5897         (complete_options): Save the option values in the context.
5898         (save_option_value_in_ctx): New, factored out from ...
5899         (process_options): ... here.
5900         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5901         of the function.
5902         * maint-test-options.c (test_options_opts::dump): New, factored
5903         out from ...
5904         (maintenance_test_options_command_mode): ... here.
5905         (maintenance_test_options_command_completion_result): Delete.
5906         (maintenance_test_options_command_completion_text): Update
5907         comment.
5908         (maintenance_show_test_options_completion_result): Change
5909         prototype.  Just print
5910         maintenance_test_options_command_completion_text.
5911         (save_completion_result): New.
5912         (maintenance_test_options_completer_mode): Pass options context to
5913         complete_options, and then save a dump.
5914         (_initialize_maint_test_options): Use add_cmd to install "maint
5915         show test-options-completion-result".
5916
5917 2019-07-03  Pedro Alves  <palves@redhat.com>
5918
5919         * NEWS (New commands): Mention "with" and "maint with".
5920         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5921         (with_command, with_command_completer): New.
5922         (pipe_command): Adjust to new repeat_previous
5923         interface.
5924         (_initialize_cli_cmds): Install the "with" command and its "w"
5925         alias.
5926         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5927         declarations.
5928         * cli/cli-setshow.c (parse_cli_var_uinteger)
5929         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5930         argument strings for all var_types.
5931         (get_setshow_command_value_string): New, factored out from ...
5932         (do_show_command): ... this.
5933         * cli/cli-setshow.h: Include <string>.
5934         (get_setshow_command_value_string): Declare.
5935         * command.h (repeat_previous): Now returns const char *.  Adjust
5936         comment.
5937         * maint.c: Include "cli/cli-cmds.h".
5938         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5939         (_initialize_maint_cmds): Register the "maintenance with" command.
5940         * top.c (repeat_previous): Move bits from pipe_command here:
5941         Return the saved command line, if any; error out if there's no
5942         command to relaunch.
5943
5944 2019-07-03  Pedro Alves  <palves@redhat.com>
5945
5946         * NEWS (New commands): Mention "maint set/show test-settings"
5947         instead of "maint test-settings".
5948         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5949         (maintenance_test_settings_set_list): Rename to ...
5950         (maintenance_set_test_settings_list): ... this.
5951         (maintenance_test_settings_show_list): Rename to  ...
5952         (maintenance_show_test_settings_list): ... this.
5953         (maintenance_test_settings_cmd): Delete.
5954         (maintenance_test_settings_set_cmd): ...
5955         (maintenance_set_test_settings_cmd): ... this.
5956         (maintenance_test_settings_show_cmd): ...
5957         (maintenance_show_test_settings_cmd): ... this.
5958         (maintenance_test_settings_show_value_cmd):
5959         (maintenance_show_test_settings_value_cmd): ... this.
5960         (_initialize_maint_test_settings): No longer install the "maint
5961         test-settings" prefix command.  Rename "maint test-settings set"
5962         to "maint set test-settings", and "maint test-settings show" to
5963         "maint show test-settings".  Adjust all subcommands.
5964
5965 2019-07-03  Pedro Alves  <palves@redhat.com>
5966
5967         * maint-test-settings.c: Fix file's intro comment.  Replace all
5968         references to "test-options" with references to "test-settings",
5969         in comments.
5970
5971 2019-07-03  Pedro Alves  <palves@redhat.com>
5972
5973         * maint-test-settings.c (maintenance_test_settings_xxx)
5974         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5975         New.
5976         (maintenance_test_settings_enums): Use them.
5977         (maintenance_test_settings_enum): Default to
5978         maintenance_test_settings_xxx.
5979         (_initialize_maint_test_settings): Initialize
5980         MAINTENANCE_TEST_SETTINGS_FILENAME.
5981
5982 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5983
5984         * breakpoint.h (remove_breakpoints_inf): Change return type to
5985         void, move function documentation here.
5986         * breakpoint.c (remove_breakpoints_inf): Change return type to
5987         void, move function documentation to header.
5988
5989 2019-07-02  Pedro Alves  <palves@redhat.com>
5990
5991         * NEWS (Completion improvements): Mention "info threads".
5992         * thread.c (struct info_threads_opts, info_threads_option_defs)
5993         (make_info_threads_options_def_group): New.
5994         (info_threads_command): Use gdb::option::process_options.
5995         (info_threads_command_completer): New.
5996         (_initialize_thread): Use gdb::option::build_help to build the
5997         help text for "info threads".
5998
5999 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6000
6001         * defs.h (generic_load): Move from here...
6002         * symfile.h (generic_load): ... to here.  Rename name parameter
6003         to args.
6004         * symfile.c (generic_load): Add comment.
6005
6006 2019-07-01  Tom Tromey  <tromey@adacore.com>
6007
6008         * dwarf2read.c
6009         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6010         declaration of without_params.  Fix formatting.
6011
6012 2019-07-01  Tom Tromey  <tromey@adacore.com>
6013
6014         * ada-exp.y (find_primitive_type): Update.
6015         * ada-lang.h (ada_lookup_symbol): Update.
6016         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6017         parameter.
6018         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6019
6020 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6021
6022         PR breakpoints/24541
6023         * gdbarch.c: Regenerate.
6024         * gdbarch.h: Regenerate.
6025         * gdbarch.sh: Add 'stap_adjust_register'.
6026         * i386-tdep.c: Include '<unordered_set>'.
6027         (i386_stap_adjust_register): New function.
6028         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6029         * stap-probe.c (stap_parse_register_operand): Call
6030         'gdbarch_stap_adjust_register'.
6031
6032 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6033
6034         PR python/24742
6035         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6036         * python/python.c (do_start_initialization): Use 'xmalloc'
6037         instead of 'PyMem_Malloc'.
6038
6039 2019-06-28  Tom Tromey  <tromey@adacore.com>
6040
6041         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6042         for Ada.
6043
6044 2019-06-27  Tom Tromey  <tromey@adacore.com>
6045
6046         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6047         objfile_key.
6048         (arm_find_mapping_symbol, arm_record_special_symbol)
6049         (_initialize_arm_tdep): Update.
6050         (arm_objfile_data_free): Remove.
6051
6052 2019-06-27  Tom Tromey  <tromey@adacore.com>
6053
6054         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6055         to cp_print_static_field.
6056
6057 2019-06-26  Tom Tromey  <tromey@adacore.com>
6058
6059         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6060         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6061         declare.
6062
6063 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6064
6065         * features/aarch64-core.c (create_feature_aarch64_core):
6066         Regenerate.
6067         * features/aarch64-core.xml: Add cpsr flags.
6068
6069 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6070
6071         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6072         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6073
6074 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6075
6076         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6077         field.
6078         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6079         use.
6080         (arm_record_special_symbol): Don't insert new symbol in sorted
6081         position, push it at the end.
6082
6083 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6084
6085         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6086         (arm_mapping_symbol_s): Remove.
6087         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6088         (arm_mapping_symbol_vec): New typedef.
6089         (struct arm_per_objfile): Add constructor.
6090         <section_maps>: Change type to
6091         std::unique_ptr<arm_mapping_symbol_vec[]>.
6092         (arm_compare_mapping_symbols): Remove.
6093         (arm_find_mapping_symbol): Adjust to section_maps type change.
6094         (arm_objfile_data_free): Call delete on arm_per_objfile.
6095         (arm_record_special_symbol): Adjust to section_maps type change.
6096         Allocate arm_per_objfile with new.
6097
6098 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6099
6100         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6101         with the command prefix.
6102
6103 2019-06-25  Tom Tromey  <tom@tromey.com>
6104
6105         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6106         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6107
6108 2019-06-25  Tom Tromey  <tom@tromey.com>
6109
6110         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6111         type.
6112         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6113         protected.
6114
6115 2019-06-25  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-winsource.c
6118         (tui_source_window_base::set_is_exec_point_at): Add check against
6119         LOA_ADDRESS.
6120
6121 2019-06-25  Tom Tromey  <tom@tromey.com>
6122
6123         * tui/tui-source.c (tui_set_source_content): Don't check before
6124         xfree.
6125         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6126
6127 2019-06-25  Tom Tromey  <tom@tromey.com>
6128
6129         * tui/tui-winsource.h (tui_update_source_window_as_is)
6130         (tui_alloc_source_buffer, tui_line_is_displayed)
6131         (tui_addr_is_displayed): Change type of win_info.
6132         * tui/tui-winsource.c (tui_update_source_window_as_is)
6133         (tui_clear_source_content, tui_show_source_line)
6134         (tui_show_source_content, tui_source_window_base::refill)
6135         (tui_source_window_base::set_is_exec_point_at)
6136         (tui_source_window_base::set_is_exec_point_at)
6137         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6138         (tui_alloc_source_buffer, tui_line_is_displayed)
6139         (tui_addr_is_displayed): Change type of win_info.  Update.
6140         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6141         (tui_source_window_base::do_make_visible_with_new_height):
6142         Update.
6143         * tui/tui-source.c (tui_set_source_content)
6144         (tui_set_source_content_nil)
6145         (tui_source_window::do_scroll_vertical): Update.
6146         * tui/tui-layout.c (show_layout): Update.
6147         * tui/tui-disasm.c (tui_set_disassem_content)
6148         (tui_disasm_window::do_scroll_vertical): Update.
6149         * tui/tui-data.h (tui_win_content): Remove.
6150         (struct tui_gen_win_info) <content, content_size>: Remove.
6151         (struct tui_source_element): Add initializers and destructor.
6152         (union tui_which_element, struct tui_win_element): Remove.
6153         (struct tui_source_window_base) <content>: New field.
6154         (struct tui_data_window): Remove destructor.
6155         (tui_alloc_content, tui_free_win_content)
6156         (tui_free_all_source_wins_content): Don't declare.
6157         * tui/tui-data.c (tui_initialize_static_data): Update.
6158         (init_content_element, tui_alloc_content): Remove.
6159         (~tui_gen_win_info): Update.
6160         (~tui_data_window, tui_free_all_source_wins_content)
6161         (tui_free_win_content, free_content, free_content_elements):
6162         Remove.
6163
6164 2019-06-25  Tom Tromey  <tom@tromey.com>
6165
6166         * tui/tui-winsource.h (tui_clear_source_content)
6167         (tui_erase_source_content, tui_show_source_content): Change type
6168         of win_info.
6169         * tui/tui-winsource.c (tui_clear_source_content)
6170         (tui_erase_source_content, tui_show_source_content): Change type
6171         of win_info.
6172         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6173         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6174         win_info.
6175         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6176         win_info.
6177         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6178
6179 2019-06-25  Tom Tromey  <tom@tromey.com>
6180
6181         * tui/tui-winsource.c (tui_clear_source_content)
6182         (tui_source_window_base::set_is_exec_point_at): Update.
6183         * tui/tui-source.c (tui_set_source_content_nil): Update.
6184         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6185         a bool.
6186         * tui/tui-data.c (init_content_element): Update.
6187
6188 2019-06-25  Tom Tromey  <tom@tromey.com>
6189
6190         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6191         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6192         * tui/tui-layout.c (init_and_make_win): Update.
6193         * tui/tui.h (enum tui_win_type): Update.
6194         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6195         tui_win_is_auxillary.
6196         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6197         tui_win_is_auxillary.
6198
6199 2019-06-25  Tom Tromey  <tom@tromey.com>
6200
6201         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6202         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6203         (tui_delete_data_content_windows, tui_display_all_data)
6204         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6205         Update.
6206         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6207         * tui/tui-regs.c (tui_last_regs_line_no)
6208         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6209         (tui_show_registers): Update.
6210         (tui_show_register_group): Return void.  Update.
6211         (tui_display_registers_from, tui_display_reg_element_at_line)
6212         (tui_display_registers_from_line, tui_check_register_values):
6213         Update.
6214         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6215         member.
6216         (struct tui_data_window) <regs_content>: Now a std::vector.
6217         <regs_content_count>: Remove.
6218         (tui_add_content_elements, tui_free_data_content): Don't declare.
6219         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6220         (init_content_element): Remove DATA_WIN case.  Add assert.
6221         (tui_add_content_elements): Remove.
6222         (tui_data_window): Update.
6223         (tui_free_data_content): Remove.
6224         (free_content_elements): Remove DATA_WIN case.
6225
6226 2019-06-25  Tom Tromey  <tom@tromey.com>
6227
6228         * tui/tui-data.c (tui_data_item_window): Update.
6229         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6230         * tui/tui-windata.c (tui_display_all_data)
6231         (tui_display_data_from_line): Update.
6232         (tui_check_data_values): Remove.
6233         * tui/tui-regs.c (tui_show_register_group)
6234         (tui_display_reg_element_at_line): Update.
6235         * tui/tui-hooks.c (tui_register_changed)
6236         (tui_refresh_frame_and_register_information): Call
6237         tui_check_register_values.
6238         * tui/tui-data.h (struct tui_data_window) <data_content,
6239         data_content_count, data_type>: Remove.
6240         (enum tui_data_type): Remove.
6241
6242         * tui/tui-data.c (tui_data_window::clear_detail)
6243         (~tui_data_window): Update.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6248         declare.
6249         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6250         Rename from tui_first_data_item_displayed.  Update.
6251         (tui_data_window::refresh_all)
6252         (tui_data_window::do_scroll_vertical): Update.
6253         * tui/tui-data.h (struct tui_data_window)
6254         <first_data_item_displayed>: Declare new method.
6255
6256 2019-06-25  Tom Tromey  <tom@tromey.com>
6257
6258         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6259         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6260         contents...
6261         (tui_initialize_static_data): ...here.
6262
6263 2019-06-25  Tom Tromey  <tom@tromey.com>
6264
6265         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6266         (tui_display_registers_from, tui_check_register_values): Update.
6267         (tui_display_register): Remove win_info parameter; update.
6268         (tui_get_register): Change type of parameters.
6269         * tui/tui-data.h (struct tui_data_element): Remove.
6270         (union tui_which_element) <data>: Remove.
6271         <data_window>: Change type.
6272         (struct tui_data_item_window): New.
6273         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6274         case.  Add assert.
6275         (~tui_data_item_window): New destructor.
6276         (free_content_elements): Remove DATA_ITEM_WIN case.
6277
6278 2019-06-25  Tom Tromey  <tom@tromey.com>
6279
6280         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6281         Remove.
6282
6283 2019-06-25  Tom Tromey  <tom@tromey.com>
6284
6285         * tui/tui-data.h (struct tui_command_element): Remove.
6286         (union tui_which_element) <command>: Remove.
6287         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6288         assert.
6289         (free_content_elements): Remove CMD_WIN case.
6290
6291 2019-06-25  Tom Tromey  <tom@tromey.com>
6292
6293         * tui/tui-layout.c (tui_set_layout): Update.
6294         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6295         * tui/tui-data.c (layout_def): Update.
6296
6297 2019-06-25  Tom Tromey  <tom@tromey.com>
6298
6299         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6300         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6301         (tui_source_window_base::set_new_height): Update.
6302         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6303         Update.
6304         (tui_set_locator_fullname, tui_set_locator_info)
6305         (tui_show_frame_info): Update.
6306         * tui/tui-source.c (tui_set_source_content)
6307         (tui_source_is_displayed): Update.
6308         * tui/tui-layout.c (show_source_disasm_command, show_data)
6309         (show_source_or_disasm_and_command): Update.
6310         * tui/tui-disasm.c (tui_set_disassem_content)
6311         (tui_get_begin_asm_address): Update.
6312         * tui/tui-data.h (struct tui_locator_element): Remove.
6313         (union tui_which_element) <locator>: Remove.
6314         (struct tui_locator_window): New.
6315         (tui_locator_win_info_ptr): Change return type.
6316         * tui/tui-data.c (_locator): Change type.
6317         (tui_locator_win_info_ptr): Change return type.
6318         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6319         (tui_alloc_content): Add assert.
6320
6321 2019-06-25  Tom Tromey  <tom@tromey.com>
6322
6323         * tui/tui-winsource.c
6324         (tui_exec_info_window::maybe_allocate_content): New method.
6325         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6326         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6327         (make_source_or_disasm_window): Add cast.
6328         * tui/tui-data.h (union tui_which_element) <simple_string>:
6329         Remove.
6330         (struct tui_source_info): New.
6331         (struct tui_source_window_base) <execution_info>: Change type.
6332         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6333         case, and add assert.
6334         (tui_alloc_content): Add assert.
6335
6336 2019-06-25  Tom Tromey  <tom@tromey.com>
6337
6338         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6339         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6340         * tui/tui-data.c (tui_alloc_win_info): Remove.
6341
6342 2019-06-25  Tom Tromey  <tom@tromey.com>
6343
6344         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6345         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6346         can_highlight.
6347
6348 2019-06-25  Tom Tromey  <tom@tromey.com>
6349
6350         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6351         make_visible_with_new_height method.
6352         (tui_win_info::make_visible_with_new_height): New method.
6353         (tui_source_window_base::do_make_visible_with_new_height)
6354         (tui_data_window::do_make_visible_with_new_height)
6355         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6356         (make_visible_with_new_height): Remove.
6357         (tui_resize_all, tui_adjust_win_heights): Use
6358         make_visible_with_new_height method.
6359         * tui/tui-data.h (struct tui_win_info)
6360         <do_make_visible_with_new_height, make_visible_with_new_height>:
6361         New methods.
6362         (struct tui_source_window_base, struct tui_data_window)
6363         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6364         methods.
6365
6366 2019-06-25  Tom Tromey  <tom@tromey.com>
6367
6368         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6369         method.
6370         (update_tab_width): Call update_tab_width method.
6371         * tui/tui-data.h (struct tui_win_info)
6372         (struct tui_source_window_base) <update_tab_width>: New methods.
6373
6374 2019-06-25  Tom Tromey  <tom@tromey.com>
6375
6376         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6377         parameter.
6378         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6379         parameter.
6380         (tui_gen_win_info::make_visible): Update.
6381         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6382         parameter.
6383         * tui/tui-data.h (enum tui_box): New enum.
6384         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6385
6386 2019-06-25  Tom Tromey  <tom@tromey.com>
6387
6388         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6389         init_and_make_win for EXEC_INFO_WIN.
6390         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6391         longer inline.
6392         (struct tui_win_info) <~tui_win_info>: Inline.
6393         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6394         Don't declare.
6395         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6396         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6397         Remove.
6398         (tui_initialize_static_data): Update.
6399         (~tui_gen_win_info): Handle more cleanup here.
6400         (~tui_source_window_base): Delete "execution_info".
6401         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6402
6403 2019-06-25  Tom Tromey  <tom@tromey.com>
6404
6405         * tui/tui-layout.c (make_command_window): Don't set
6406         can_highlight.
6407         (show_source_disasm_command): Call the reset method.
6408         (show_data): Don't set can_highlight.  Call the reset method.
6409         (tui_gen_win_info::reset): Rename from init_gen_win_info
6410         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6411         (show_source_or_disasm_and_command): Call the reset method.
6412         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6413         (struct tui_cmd_window): Set can_highlight.
6414
6415 2019-06-25  Tom Tromey  <tom@tromey.com>
6416
6417         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6418         from make_visible.
6419         (tui_make_visible, tui_make_invisible): Rewrite.
6420         (tui_win_info::make_visible): Remove.
6421         (tui_source_window_base::make_visible): Update.
6422         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6423         method.  Moved from...
6424         (struct tui_win_info) <make_visible>: ...here.
6425
6426 2019-06-25  Tom Tromey  <tom@tromey.com>
6427
6428         * tui/tui-winsource.c
6429         (tui_source_window_base::do_scroll_horizontal): Remove direction
6430         parameter.
6431         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6432         direction parameter.
6433         * tui/tui-win.c (tui_win_info::forward_scroll)
6434         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6435         (tui_win_info::right_scroll): Update.
6436         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6437         direction parameter.
6438         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6439         direction parameter.
6440         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6441         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6442         Remove direction parameter.
6443         (struct tui_source_window_base, struct tui_source_window)
6444         (struct tui_disasm_window, struct tui_data_window)
6445         (struct tui_cmd_window): Update.
6446
6447 2019-06-25  Tom Tromey  <tom@tromey.com>
6448
6449         * tui/tui-winsource.h (tui_set_exec_info_content)
6450         (tui_show_exec_info_content, tui_erase_exec_info_content)
6451         (tui_clear_exec_info_content, tui_update_exec_info): Change
6452         argument to tui_source_window_base.
6453         * tui/tui-winsource.c (tui_set_exec_info_content)
6454         (tui_show_exec_info_content, tui_erase_exec_info_content)
6455         (tui_clear_exec_info_content, tui_update_exec_info): Change
6456         argument to tui_source_window_base.
6457
6458 2019-06-25  Tom Tromey  <tom@tromey.com>
6459
6460         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6461         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6462
6463 2019-06-25  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6466         check.
6467
6468 2019-06-25  Tom Tromey  <tom@tromey.com>
6469
6470         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6471         type to void.
6472         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6473         type to void.
6474         * tui/tui-source.c (tui_set_source_content): Update.
6475         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6476
6477 2019-06-25  Tom Tromey  <tom@tromey.com>
6478
6479         * tui/tui-win.c (window_name_completer, tui_set_focus)
6480         (tui_all_windows_info): Use name method.
6481         * tui/tui-data.h (struct tui_gen_win_info)
6482         (struct tui_source_window, struct tui_disasm_window)
6483         (struct tui_data_window, struct tui_cmd_window) <name>: New
6484         method.
6485         (tui_win_name): Don't declare.
6486         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6487         (tui_win_name): Remove.
6488
6489 2019-06-25  Tom Tromey  <tom@tromey.com>
6490
6491         * tui/tui-winsource.h (tui_update_source_window)
6492         (tui_update_source_window_as_is): Change parameter type.
6493         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6494         to be a tui_source_window_base.
6495         (tui_update_source_window_as_is): Likewise.
6496         * tui/tui-win.c (make_visible_with_new_height): Update.
6497
6498 2019-06-25  Tom Tromey  <tom@tromey.com>
6499
6500         * tui/tui-winsource.c (tui_erase_source_content)
6501         (tui_show_source_content, tui_show_exec_info_content)
6502         (tui_erase_exec_info_content): Use refresh_window method.
6503         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6504         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6505         from tui_refresh_win.
6506         (tui_data_window::refresh_window): New method.
6507         (tui_win_info::refresh, tui_source_window_base::refresh)
6508         (tui_refresh_all): Use refresh_window method.
6509         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6510         method.
6511         * tui/tui-regs.c (tui_display_register): Call refresh_window
6512         method.
6513         * tui/tui-layout.c (show_source_disasm_command)
6514         (show_source_or_disasm_and_command): Call refresh_window method.
6515         * tui/tui-data.h (struct tui_gen_win_info)
6516         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6517         New method.
6518
6519 2019-06-25  Tom Tromey  <tom@tromey.com>
6520
6521         * tui/tui.c (tui_rl_other_window, tui_enable)
6522         (tui_is_window_visible, tui_get_command_dimension): Update.
6523         * tui/tui-winsource.c (tui_update_source_window_as_is)
6524         (tui_clear_source_content, tui_erase_source_content)
6525         (tui_show_source_line, tui_source_window_base::refill)
6526         (tui_source_window_base::do_scroll_horizontal)
6527         (tui_source_window_base::set_is_exec_point_at)
6528         (tui_update_breakpoint_info, tui_set_exec_info_content)
6529         (tui_alloc_source_buffer, tui_line_is_displayed)
6530         (tui_addr_is_displayed): Update.
6531         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6532         (tui_check_and_display_highlight_if_needed)
6533         (tui_win_info::make_visible, tui_win_info::refresh)
6534         (tui_refresh_all): Update.
6535         * tui/tui-windata.c (tui_first_data_item_displayed)
6536         (tui_delete_data_content_windows, tui_erase_data_content)
6537         (tui_display_all_data, tui_data_window::refresh_all)
6538         (tui_check_data_values): Update.
6539         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6540         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6541         (tui_win_info::backward_scroll, tui_refresh_all_win)
6542         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6543         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6544         (tui_source_window_base::set_new_height)
6545         (tui_data_window::set_new_height)
6546         (make_invisible_and_set_new_height)
6547         (make_visible_with_new_height, new_height_ok)
6548         (parse_scrolling_args): Update.
6549         * tui/tui-stack.c (tui_show_frame_info): Update.
6550         * tui/tui-source.c (tui_set_source_content)
6551         (tui_set_source_content_nil, tui_source_is_displayed)
6552         (tui_source_window::do_scroll_vertical): Update.
6553         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6554         (tui_display_registers_from, tui_display_reg_element_at_line)
6555         (tui_check_register_values, tui_reg_command): Update.
6556         * tui/tui-layout.c (tui_default_win_height)
6557         (show_source_disasm_command, show_data, init_and_make_win)
6558         (show_source_or_disasm_and_command): Update.
6559         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6560         (tui_redisplay_readline, tui_mld_flush)
6561         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6562         (tui_getc): Update.
6563         * tui/tui-disasm.c (tui_set_disassem_content)
6564         (tui_disasm_window::do_scroll_vertical): Update.
6565         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6566         Now virtual.
6567         (struct tui_win_info): Derive from tui_gen_win_info.
6568         <~tui_win_info>: Mark as override.
6569         <generic>: Remove member.
6570         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6571         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6572         (~tui_data_window, ~tui_win_info)
6573         (tui_free_all_source_wins_content): Update.
6574         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6575
6576 2019-06-25  Tom Tromey  <tom@tromey.com>
6577
6578         * tui/tui-layout.c (init_and_make_win): Use new.
6579         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6580         destructor, initializers.
6581         (tui_alloc_generic_win_info): Don't declare.
6582         * tui/tui-data.c (_locator): Add argument to constructor.
6583         (source_win, disasm_win): New globals.
6584         (exec_info): Remove.
6585         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6586         Update.
6587         (tui_alloc_generic_win_info): Remove.
6588         (init_content_element): Use new.
6589         (tui_win_info::tui_win_info): Update.
6590         (free_content_elements) <case DATA_WIN>: Use delete.
6591
6592 2019-06-25  Tom Tromey  <tom@tromey.com>
6593
6594         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6595         * tui/tui-windata.c (tui_first_data_item_displayed)
6596         (tui_delete_data_content_windows): Update.
6597         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6598         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6599         (tui_display_registers_from, tui_check_register_values): Update.
6600         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6601         pointer.
6602         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6603         window.
6604         (tui_free_data_content): Update.
6605         (free_content_elements) <case DATA_WIN>: Free the window.
6606
6607 2019-06-25  Tom Tromey  <tom@tromey.com>
6608
6609         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6610         Update.
6611         * tui/tui-layout.c (make_command_window)
6612         (show_source_disasm_command, show_data, init_and_make_win)
6613         (show_source_or_disasm_and_command): Update.
6614         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6615         method.
6616         <can_highight, is_highlighted>: Now bool.
6617         (tui_set_win_highlight): Don't declare.
6618         * tui/tui-data.c (tui_set_win_highlight): Remove.
6619
6620 2019-06-25  Tom Tromey  <tom@tromey.com>
6621
6622         * tui/tui-wingeneral.c (make_visible): Remove check of window
6623         type.
6624
6625 2019-06-25  Tom Tromey  <tom@tromey.com>
6626
6627         * tui/tui-win.c (tui_win_info::max_height)
6628         (tui_cmd_window::max_height): New methods.
6629         (new_height_ok): Call max_height.
6630         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6631         <max_height>: New method.
6632
6633 2019-06-25  Tom Tromey  <tom@tromey.com>
6634
6635         * tui/tui-win.c (tui_source_window_base::set_new_height)
6636         (tui_data_window::set_new_height): New methods.
6637         (make_invisible_and_set_new_height): Call set_new_height method.
6638         * tui/tui-data.h (struct tui_win_info)
6639         (struct tui_source_window_base, struct tui_data_window)
6640         <set_new_height>: New method.
6641
6642 2019-06-25  Tom Tromey  <tom@tromey.com>
6643
6644         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6645         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6646         tui_refresh_data_win.
6647         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6648         method.
6649         (tui_refresh_all_win): Call the refresh_all method.
6650         (tui_set_focus): Likewise.
6651         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6652         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6653         Likewise.
6654
6655 2019-06-25  Tom Tromey  <tom@tromey.com>
6656
6657         * tui/tui-winsource.h (tui_refill_source_window)
6658         (tui_set_is_exec_point_at): Don't declare.
6659         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6660         (tui_source_window_base::refill): Rename from
6661         tui_refill_source_window.
6662         (tui_source_window_base::do_scroll_horizontal): Update.
6663         (tui_source_window_base::set_is_exec_point_at): Rename from
6664         tui_set_is_exec_point_at.
6665         (tui_update_all_breakpoint_info): Update.
6666         * tui/tui-stack.c (tui_show_frame_info): Update.
6667         * tui/tui-layout.c (show_data): Add cast.
6668         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6669         * tui/tui-data.h (struct tui_source_window_base) <refill,
6670         set_is_exec_point_at>: New methods.
6671         (tui_source_windows, tui_add_to_source_windows): Update types.
6672         (tui_add_to_source_windows): Remove redundant declaration.
6673         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6674         (tui_source_windows): Change return type.
6675         (tui_clear_source_windows_detail): Update.
6676         (tui_add_to_source_windows): Change type of parameter.
6677         (tui_free_all_source_wins_content): Update.
6678
6679 2019-06-25  Tom Tromey  <tom@tromey.com>
6680
6681         * tui/tui-wingeneral.c (tui_win_info::refresh)
6682         (tui_source_window_base::refresh): New methods.
6683         (tui_refresh_all): Call the refresh method.
6684         * tui/tui-data.h (struct tui_win_info)
6685         (struct tui_source_window_base) <refresh>: New method.
6686
6687 2019-06-25  Tom Tromey  <tom@tromey.com>
6688
6689         * tui/tui.h (tui_is_window_visible): Return bool.
6690         * tui/tui.c (tui_is_window_visible): Return bool.
6691         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6692         (tui_make_visible, tui_make_invisible)
6693         (tui_win_info::make_visible)
6694         (tui_source_window_base::make_visible, make_all_visible)
6695         (tui_make_all_visible, tui_make_all_invisible): Update.
6696         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6697         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6698         bool.
6699         (struct tui_win_info, struct tui_source_window_base)
6700         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6701         * tui/tui-data.c (tui_init_generic_part): Update.
6702
6703 2019-06-25  Tom Tromey  <tom@tromey.com>
6704
6705         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6706         (tui_source_window_base::make_visible): New methods.
6707         (make_all_visible): Make method call.
6708         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6709         (struct tui_source_window_base, struct tui_cmd_window): Override
6710         make_visible.
6711         (tui_win_is_source_type): Don't declare.
6712         * tui/tui-data.c (tui_win_is_source_type): Remove.
6713
6714 2019-06-25  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6717         NULL check.
6718
6719 2019-06-25  Tom Tromey  <tom@tromey.com>
6720
6721         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6722         Inline constructor.  Add initializers for members.
6723         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6724         constructors; now inline in class.
6725
6726 2019-06-25  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-regs.c (tui_show_registers): Update.
6729         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6730         bool.
6731         * tui/tui-data.c (tui_data_window::clear_detail)
6732         (tui_data_window): Update.
6733
6734 2019-06-25  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-windata.c (tui_display_all_data)
6737         (tui_display_data_from_line, tui_display_data_from)
6738         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6739         Update.
6740         * tui/tui-regs.c (tui_last_regs_line_no)
6741         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6742         (tui_show_registers, tui_show_register_group)
6743         (tui_display_registers_from, tui_display_reg_element_at_line)
6744         (tui_display_registers_from_line, tui_check_register_values)
6745         (tui_reg_next, tui_reg_prev): Update.
6746         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6747         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6748         tui_data_window.
6749         (struct tui_win_info) <detail>: Remove.  Add new fields from
6750         tui_data_info.
6751         (TUI_DATA_WIN): Add cast.
6752         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6753         (~tui_data_window): Simplify.
6754
6755 2019-06-25  Tom Tromey  <tom@tromey.com>
6756
6757         * tui/tui-layout.c (show_source_disasm_command)
6758         (show_source_or_disasm_and_command): Update.
6759         * tui/tui-io.c (update_cmdwin_start_line)
6760         (tui_redisplay_readline): Update.
6761         * tui/tui-data.h (struct tui_command_info): Remove.
6762         (struct tui_win_info) <detail>: Remove command_info member.
6763         (struct tui_data_window) <start_line>: New member, from
6764         tui_command_info.
6765         (TUI_CMD_WIN): Add casts.
6766
6767 2019-06-25  Tom Tromey  <tom@tromey.com>
6768
6769         * tui/tui-winsource.c (tui_update_source_window)
6770         (tui_refill_source_window)
6771         (tui_source_window_base::do_scroll_horizontal)
6772         (tui_update_breakpoint_info, tui_set_exec_info_content)
6773         (tui_show_exec_info_content, tui_erase_exec_info_content)
6774         (tui_clear_exec_info_content): Update.
6775         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6776         Update.
6777         * tui/tui-win.c (make_invisible_and_set_new_height)
6778         (make_visible_with_new_height): Update.
6779         * tui/tui-source.c (tui_set_source_content)
6780         (tui_show_symtab_source): Update.
6781         * tui/tui-layout.c (extract_display_start_addr)
6782         (show_source_disasm_command, show_data)
6783         (make_source_or_disasm_window)
6784         (show_source_or_disasm_and_command): Update.
6785         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6786         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6787         "gdbarch".
6788         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6789         to tui_source_window_base.
6790         (struct tui_win_info) <detail>: Remove source_info member.
6791         (struct tui_source_window_base) <has_locator>: Inline.
6792         Move contents from tui_source_info; rename has_locator member to
6793         m_has_locator.
6794         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6795         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6796         header file.
6797         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6798         Simplify.
6799         (tui_free_all_source_wins_content): Cast to
6800         tui_source_window_base.
6801
6802 2019-06-25  Tom Tromey  <tom@tromey.com>
6803
6804         * tui/tui-win.c (make_invisible_and_set_new_height)
6805         (make_visible_with_new_height): Call has_locator method.
6806         * tui/tui-layout.c (show_source_disasm_command, show_data)
6807         (show_source_or_disasm_and_command): Update for bool change.
6808         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6809         (tui_win_info) <has_locator>: New method.
6810         (struct tui_source_window_base) <has_locator>: New method.
6811         (tui_win_has_locator): Don't declare.
6812         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6813         from tui_win_has_locator.
6814         (tui_source_window_base): Use false, not FALSE.
6815
6816 2019-06-25  Tom Tromey  <tom@tromey.com>
6817
6818         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6819         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6820         clear_detail method directly.
6821         (tui_clear_win_detail): Remove.
6822
6823 2019-06-25  Tom Tromey  <tom@tromey.com>
6824
6825         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6826         "this", not TUI_DISASM_WIN.
6827
6828 2019-06-25  Tom Tromey  <tom@tromey.com>
6829
6830         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6831         declare.
6832         * tui/tui-winsource.c
6833         (tui_source_window_base::do_scroll_horizontal): Rename from
6834         tui_horizontal_source_scroll.
6835         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6836         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6837         from tui_vertical_data_scroll.
6838         * tui/tui-win.h (tui_scroll): Don't declare.
6839         * tui/tui-win.c (tui_win_info::forward_scroll)
6840         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6841         (tui_win_info::right_scroll): Rename and update.
6842         (tui_scroll_forward_command, tui_scroll_backward_command)
6843         (tui_scroll_left_command, tui_scroll_right_command): Update.
6844         (tui_scroll): Remove.
6845         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6846         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6847         from tui_vertical_source_scroll.
6848         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6849         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6850         from tui_vertical_disassem_scroll.
6851         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6852         do_scroll_horizontal>: New methods.
6853         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6854         Likewise.
6855         (struct tui_source_window_base): Add do_scroll_horizontal.
6856         (struct tui_source_window, struct tui_disasm_window): Add
6857         do_scroll_vertical.
6858         (struct tui_data_window, struct tui_cmd_window): Add
6859         do_scroll_horizontal and do_scroll_vertical.
6860         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6861
6862 2019-06-25  Tom Tromey  <tom@tromey.com>
6863
6864         * tui/tui-data.h (struct tui_source_window_base): New struct.
6865         (struct tui_source_window): Derive from tui_source_window_base.
6866         (struct tui_disasm_window): New struct.
6867         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6868         from tui_source_window::clear_detail.
6869         (tui_source_window_base): Rename from tui_source_window.
6870         (~tui_source_window_base): Rename from ~tui_source_window.
6871         (tui_alloc_win_info): Create a tui_disasm_window.
6872
6873 2019-06-25  Tom Tromey  <tom@tromey.com>
6874
6875         * tui/tui-data.h (struct tui_source_window)
6876         (struct tui_data_window): Declare destructors.
6877         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6878         destructors.
6879         (tui_win_info): Simplify.
6880
6881 2019-06-25  Tom Tromey  <tom@tromey.com>
6882
6883         * tui/tui-winsource.c (tui_display_main)
6884         (tui_update_source_windows_with_addr)
6885         (tui_update_all_breakpoint_info): Update.
6886         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6887         (new_height_ok, parse_scrolling_args): Update.
6888         * tui/tui-stack.c (tui_show_frame_info): Update.
6889         * tui/tui-data.h (struct tui_list): Remove.
6890         (tui_source_windows): Return a reference to a std::vector.
6891         * tui/tui-data.c (source_windows): Now a std::vector.
6892         (tui_source_windows): Change return type.
6893         (tui_clear_source_windows): Rewrite.
6894         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6895         (tui_free_all_source_wins_content): Rewrite.
6896
6897 2019-06-25  Tom Tromey  <tom@tromey.com>
6898
6899         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6900         (struct tui_data_window, struct tui_cmd_window): Declare
6901         clear_detail method.
6902         * tui/tui-data.c (tui_source_window::clear_detail)
6903         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6904         methods.
6905         (tui_clear_win_detail): Simplify.
6906
6907 2019-06-25  Tom Tromey  <tom@tromey.com>
6908
6909         * tui/tui-layout.c (make_source_window, make_disasm_window)
6910         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6911         Return the new window.
6912         (show_source_disasm_command, show_data)
6913         (show_source_or_disasm_and_command): Update.
6914
6915 2019-06-25  Tom Tromey  <tom@tromey.com>
6916
6917         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6918         parameter.  Return the new window.
6919         (show_source_disasm_command): Update and remove NULL check.
6920         (show_source_or_disasm_and_command): Update.
6921
6922 2019-06-25  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6925
6926 2019-06-25  Tom Tromey  <tom@tromey.com>
6927
6928         * tui/tui-data.h (struct tui_win_info): Make constructor
6929         protected.  Make destructor virtual.  Add initializers.
6930         (tui_source_window, tui_data_window, tui_cmd_window): New
6931         classes.
6932         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6933         constructor.  Add "type" parameter.
6934         (tui_source_window, tui_data_window, tui_cmd_window): New
6935         constructors.
6936         (tui_alloc_win_info): Instantiate the appropriate subclass.
6937
6938 2019-06-25  Tom Tromey  <tom@tromey.com>
6939
6940         * tui/tui-win.c (tui_resize_all): Use delete.
6941         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6942         destructor.
6943         (tui_free_window): Don't declare.
6944         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6945         Update.
6946
6947 2019-06-25  Tom Tromey  <tom@tromey.com>
6948
6949         * tui/tui-data.h (struct tui_win_info): Add constructor.
6950         * tui/tui-data.c (tui_alloc_win_info): Use new.
6951         (tui_free_window): Use delete.
6952
6953 2019-06-22  Tom Tromey  <tom@tromey.com>
6954
6955         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6956         declare.
6957         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6958
6959 2019-06-22  Tom Tromey  <tom@tromey.com>
6960
6961         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6962         declare.
6963         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6964
6965 2019-06-22  Tom de Vries  <tdevries@suse.de>
6966
6967         * dwarf2read.c (create_addrmap_from_aranges)
6968         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6969         instead of '%zu'.
6970
6971 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6972
6973         * dwarf2read.h (dwarf2_section_info_def): Remove.
6974         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6975         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6976         std::vector<dwarf2_section_info>.
6977         (struct dwo_file) <~dwo_file>: Remove.
6978         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6979         types field.
6980         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6981         (dwarf2_read_debug_names): Likewise.
6982         (create_debug_types_hash_table): Change parameter type to
6983         array_view, adjust code accordingly.
6984         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6985         (partial_die_info::fixup): Likewise.
6986         (determine_prefix): Likewise.
6987         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6988
6989 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6990
6991         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6992         gdb_bfd_ref_ptr.
6993         <~dwo_file>: Remove call to gdb_bfd_unref.
6994         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6995         gdb_bfd_ref_ptr::get.
6996
6997 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6998
6999         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7000         type to htab_up.
7001         * dwarf2read.c (struct dwo_file): Initialize fields.
7002         <~dwo_file>: New.
7003         (free_dwo_file): Remove, move content to ~dwo_file.
7004         (struct dwo_file_deleter): Remove.
7005         (dwo_file_up>: Remove custom deleter.
7006         (free_dwo_files): Remove.
7007         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7008         dwo_files.
7009         (process_skeletonless_type_units): Call unique_ptr::get.
7010         (allocate_dwo_file_hash_table): Add deleter to created hash
7011         table.  Change return type to htab_up.
7012         (lookup_dwo_file_slot): Don't memset dwo_file, call
7013         unique_ptr::get.
7014         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7015         (create_dwo_unit_in_dwp_v2): Likewise.
7016         (open_and_init_dwo_file): Likewise.
7017         (free_dwo_file_from_slot): Remove.
7018
7019 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7020
7021         * dwarf2read.h (struct dwarf2_section_info) <readin,
7022         is_virtual>: Change type to bool.
7023         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7024         true instead of 1.
7025
7026 2019-06-19  Tom Tromey  <tom@tromey.com>
7027
7028         * tui/tui-data.h (tui_init_content_element): Don't declare.
7029
7030 2019-06-19  Tom Tromey  <tom@tromey.com>
7031
7032         * tui/tui-data.h (tui_init_win_info): Don't declare.
7033
7034 2019-06-19  Tom de Vries  <tdevries@suse.de>
7035
7036         * dwarf2read.h (abstract_to_concrete): Change type to
7037         std::unordered_map<sect_offset, std::vector<sect_offset>,
7038         gdb::hash_enum<sect_offset>>.
7039
7040 2019-06-19  Tom Tromey  <tromey@adacore.com>
7041
7042         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7043         EVAL_AVOID_SIDE_EFFECTS specially.
7044
7045 2019-06-19  Tom Tromey  <tromey@adacore.com>
7046
7047         * source-cache.c (highlighter): New global.
7048         (source_cache::get_source_lines): Create a highlighter on demand.
7049
7050 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7051
7052         * defs.h (deprecated_interactive_hook): Delete declaration.
7053         * interps.c (clear_interpreter_hooks): Remove use of
7054         deprecated_interactive_hook.
7055         * top.c (deprecated_interactive_hook): Delete definition.
7056         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7057
7058 2019-06-18  Tom de Vries  <tdevries@suse.de>
7059
7060         PR gdb/24515
7061         * dwarf2read.h (abstract_to_concrete): Change type from
7062         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7063         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7064         * dwarf2read.c (read_variable): Update.
7065         (dwarf2_fetch_die_loc_sect_off): Update.
7066
7067 2019-06-17  Tom de Vries  <tdevries@suse.de>
7068
7069         PR gdb/24617
7070         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7071         accessing parent[parent_len - 1].
7072
7073 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7074
7075         PR gdb/24364
7076         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7077         call dtrace_process_dof with NULL dof.
7078
7079 2019-06-16  Tom de Vries  <tdevries@suse.de>
7080
7081         PR gdb/24445
7082         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7083
7084 2019-06-16  Tom Tromey  <tom@tromey.com>
7085
7086         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7087         (make_all_visible): Use address of member.
7088
7089 2019-06-16  Tom Tromey  <tom@tromey.com>
7090
7091         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7092         (tui_free_window, free_content, free_content_elements): Remove
7093         unnecessary cast.
7094         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7095         cast.
7096         * tui/tui-regs.c (tui_show_register_group)
7097         (tui_display_registers_from, tui_display_reg_element_at_line):
7098         Remove unnecessary cast.
7099
7100 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * linux-nat.c (normal_mask): Delete.
7103         (_initialize_linux_nat): Don't initialise normal_mask.
7104
7105 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7106
7107         PR gdb/24445
7108         * dwarf-index-write.h (write_psymtabs_to_index): Add
7109         dwz_basename parameter.
7110         * dwarf-index-write.c (write_gdbindex): Move file writing to
7111         write_gdbindex_1.  Change return type void.
7112         (assert_file_size): Move up, remove filename parameter.
7113         (write_gdbindex_1): New function.
7114         (write_debug_names): Change return type to void, call
7115         assert_file_size.
7116         (struct index_wip_file): New struct.
7117         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7118         file logic to index_wip_file.  Write index for dwz file if
7119         needed.
7120         (save_gdb_index_command): Pass basename of dwz file, if present.
7121         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7122         build-id of dwz file, if present.
7123         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7124         (dwarf2_get_dwz_file): Likewise.
7125         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7126         (dwarf2_get_dwz_file): Likewise.
7127
7128 2019-06-16  Tom Tromey  <tom@tromey.com>
7129
7130         * coffread.c (process_coff_symbol): Use xstrdup.
7131         * value.c (create_internalvar): Use xstrdup.
7132
7133 2019-06-16  Tom Tromey  <tom@tromey.com>
7134
7135         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7136         * breakpoint.c (stopin_command, stopat_command)
7137         (until_break_command, decode_location_default): Remove unnecessary
7138         cast.
7139         * utils.c (subset_compare): Remove unnecessary cast.
7140         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7141         cast.
7142         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7143         cast.
7144         * infcmd.c (path_command): Remove unnecessary cast.
7145         * coffread.c (decode_type): Remove unnecessary cast.
7146         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7147         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7148         * tui/tui-stack.c (tui_show_locator_content)
7149         (tui_show_frame_info): Remove unnecessary cast.
7150         * tui/tui-win.c (tui_scroll_forward_command)
7151         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7152         (parse_scrolling_args): Remove unnecessary cast.
7153         * tui/tui-data.c (init_win_info, tui_del_window)
7154         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7155         (free_content_elements): Remove unnecessary cast.
7156         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7157         unnecessary cast.
7158         * tui/tui-source.c (tui_set_source_content)
7159         (tui_vertical_source_scroll): Remove unnecessary cast.
7160         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7161         cast.
7162         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7163         * tui/tui-regs.c (tui_display_registers_from)
7164         (tui_display_register): Remove unnecessary cast.
7165         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7166         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7167         (make_visible): Remove unnecessary cast.
7168         * tui/tui-winsource.c (tui_erase_source_content)
7169         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7170         unnecessary cast.
7171         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7172         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7173         * stabsread.c (read_type, read_array_type, read_range_type):
7174         Remove unnecessary cast.
7175         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7176         (parse_symbol, parse_type, upgrade_type, parse_external)
7177         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7178         unnecessary cast.
7179         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7180
7181 2019-06-16  Tom Tromey  <tom@tromey.com>
7182
7183         * tui/tui-data.c (tui_alloc_generic_win_info)
7184         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7185         checks.
7186
7187 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7188             Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * f-typeprint.c (f_print_type): Don't return early for not
7191         associated or not allocated types.
7192         (f_type_print_varspec_suffix): Add print_rank parameter and print
7193         ranks of array types in case they dangling.
7194         (f_type_print_base): Add print_rank parameter.
7195
7196 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7197
7198         * NEWS: Mention new MI commands.
7199         * break-catch-throw.c (enum exception_event_kind): Move to
7200         breakpoint.h.
7201         (print_mention_exception_catchpoint): Output text as a single
7202         message.
7203         (catch_exception_command_1): Rename to...
7204         (catch_exception_event): ...this, make non-static, update header
7205         command, and change some parameter types.
7206         (catch_catch_command): Update for changes to
7207         catch_exception_command_1.
7208         (catch_throw_command): Likewise.
7209         (catch_rethrow_command): Likewise.
7210         * breakpoint.c (enum exception_event_kind): Delete.
7211         * breakpoint.h (enum exception_event_kind): Moved here from
7212         break-catch-throw.c.
7213         (catch_exception_event): Declare.
7214         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7215         (mi_cmd_catch_throw): New function.
7216         (mi_cmd_catch_rethrow): New function.
7217         (mi_cmd_catch_catch): New function.
7218         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7219         'catch-catch' entries.
7220         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7221         (mi_cmd_catch_rethrow): Declare.
7222         (mi_cmd_catch_catch): Declare.
7223
7224 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * annotate.c (annotate_source_line): Change return type to void,
7227         update implementation to match.
7228         * annotate.h (annotate_source_line): Change return type to void,
7229         update header comment.
7230         * stack.c (print_frame_info): Don't change what frame information
7231         is printed based on whether annotations are on or not.
7232
7233 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7234
7235         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7236         (annotate_source): Make static.
7237         (annotate_source_line): Moved from source.c and renamed from
7238         identify_source_line.  Update the return type.
7239         * annotate.h (annotate_source): Delete declaration.
7240         (annotate_source_line): Declaration moved from source.h, and
7241         renamed from identify_source_line.  Return type updated.
7242         * source.c (identify_source_line): Moved to annotate.c and renamed
7243         to annotate_source_line.
7244         (info_line_command): Remove check of annotation_level.
7245         * source.h (identify_source_line): Move declaration to annotate.h
7246         and rename to annotate_source_line.
7247         * stack.c: Add 'annotate.h' include.
7248         (print_frame_info): Remove check of annotation_level before
7249         calling annotate_source_line.
7250
7251 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * source-cache.c (source_cache::get_plain_source_lines): Use
7254         open_source_file_with_line_charpos instead of just
7255         open_source_file, remove call to find_source_lines.
7256         (source_cache::get_source_lines): Likewise.
7257         * source.c (find_source_lines): Make static.
7258         (get_filename_and_charpos): Renamed into...
7259         (open_source_file_with_line_charpos): ..this along with changes to
7260         return a scoped_fd, and some other minor clean ups.
7261         (identify_source_line): Use open_source_file_with_line_charpos.
7262         (search_command_helper): Use open_source_file_with_line_charpos
7263         instead of just open_source_file, remove call to
7264         find_source_lines.
7265         * source.h (open_source_file_with_line_charpos): Declare new
7266         function.
7267         (find_source_lines): Delete declaration.
7268
7269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7270
7271         * source.c (get_filename_and_charpos): Remove fullname
7272         parameter.
7273         (identify_source_line): Update call to get_filename_and_charpos.
7274
7275 2019-06-14  Tom Tromey  <tromey@adacore.com>
7276
7277         PR gdb/24502:
7278         * ui-style.h (skip_ansi_escape): Update comment.
7279         * ui-file.h (class no_terminal_escape_file): New class.
7280         * ui-file.c (no_terminal_escape_file::write)
7281         (no_terminal_escape_file::puts): New methods.
7282         * cli/cli-logging.c (handle_redirections): Use
7283         no_terminal_escape_file.
7284
7285 2019-06-14  Tom Tromey  <tromey@adacore.com>
7286
7287         * NEWS: Move convenience variable news above Python news.
7288
7289 2019-06-14  Tom Tromey  <tom@tromey.com>
7290
7291         * gnulib: Move directory to top-level.
7292         * configure.ac: Don't configure gnulib.
7293         * configure: Rebuild.
7294         * common/common-defs.h: Use new path to gnulib.
7295         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7296         (GNULIB_H): Remove.
7297         (INCGNU): Look in new gnulib location.
7298         (HFILES_NO_SRCDIR): Remove gnulib files.
7299         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7300         (generated_files): Remove GNULIB_H.
7301         ($(LIBGNU), all-lib): Remove targets.
7302         (distclean): Don't mention GNULIB_BUILDDIR.
7303         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7304
7305 2019-06-14  Tom Tromey  <tromey@adacore.com>
7306
7307         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7308         Warn if symbol file does not provide any symbols.
7309
7310 2019-06-14  Tom Tromey  <tromey@adacore.com>
7311
7312         * source.c (find_and_open_source): Respect basenames_may_differ.
7313
7314 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7315
7316         * annotate.c (annotate_breakpoints_invalid): Make use of
7317         scoped_restore_terminal_state.
7318         (annotate_frames_invalid): Likewise.
7319
7320 2019-06-14  Tom Tromey  <tromey@adacore.com>
7321
7322         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7323         allow assignment to an internalvar.
7324
7325 2019-06-14  Tom Tromey  <tromey@adacore.com>
7326
7327         * ada-lex.l: Allow "_" in attribute names.
7328
7329 2019-06-14  Tom Tromey  <tromey@adacore.com>
7330
7331         PR gdb/24653:
7332         * regcache.c (registers_changed): Don't call alloca.
7333         * top.c (execute_command): Don't call alloca.
7334
7335 2019-06-13  Pedro Alves  <palves@redhat.com>
7336
7337         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7338         'expression'.  When parsing an expression, error out if there's
7339         junk after "unlimited".
7340         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7341         (do_set_command): Adjust calls to is_unlimited_literal.
7342
7343 2019-06-13  Pedro Alves  <palves@redhat.com>
7344
7345         * compile/compile.c (make_compile_options_def_group): Add braces
7346         around array_view initializer.
7347         * thread.c (make_thread_apply_all_options_def_group)
7348         (make_thread_apply_all_options_def_group): Likewise.
7349
7350 2019-06-13  Pedro Alves  <palves@redhat.com>
7351
7352         * NEWS (New commands): Mention "maint test-options
7353         require-delimiter", "maint test-options unknown-is-error", "maint
7354         test-options unknown-is-operand" and "maint show
7355         test-options-completion-result".
7356         (New command options, command completion): New section.
7357         (Completion improvements): New section.
7358         Mention that you can abbreviate "unlimited".
7359
7360 2019-06-13  Pedro Alves  <palves@redhat.com>
7361
7362         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7363         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7364         * unittests/cli-utils-selftests.c (test_parse_flags)
7365         (test_parse_flags_qcs): Delete.
7366         (test_cli_utils): Don't call deleted functions.
7367
7368 2019-06-13  Pedro Alves  <palves@redhat.com>
7369
7370         * thread.c: Include "cli/cli-option.h".
7371         (tp_array_compar_ascending): Global.
7372         (tp_array_compar): Delete function.
7373         (tp_array_compar_ascending, tp_array_compar_descending): New
7374         functions.
7375         (ascending_option_def, qcs_flag_option_def)
7376         (thr_qcs_flags_option_defs)
7377         (make_thread_apply_all_options_def_group)
7378         (make_thread_apply_options_def_group): New.
7379         (thread_apply_all_command): Use gdb::option::process_options.
7380         (thread_apply_command_completer)
7381         (thread_apply_all_command_completer): New.
7382         (thread_apply_command): Use gdb::option::process_options.
7383         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7384         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7385         to generate help text of "thread apply".  Adjust "taas"'s help.
7386         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7387         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7388
7389 2019-06-13  Pedro Alves  <palves@redhat.com>
7390
7391         * thread.c (thread_apply_command): Check for invalid TID with
7392         isdigit instead of !isalpha.
7393
7394 2019-06-13  Pedro Alves  <palves@redhat.com>
7395
7396         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7397         (validate_flags_qcs): New.
7398         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7399         (validate_flags_qcs): Declare.
7400         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7401         (make_frame_apply_options_def_group): New.
7402         (frame_apply_command_count): Process options with
7403         gdb::option::process_options.
7404         (frame_apply_completer): New.
7405         (frame_apply_level_completer, frame_apply_all_completer)
7406         (frame_apply_completer): New.
7407         (_initialize_stack): Update help of "frame apply", "frame apply
7408         level", "frame apply all" and "faas" to mention supported options
7409         and install command completers.
7410         * stack.h (frame_apply_all_completer): Declare.
7411         * thread.c: Include "stack.h".
7412         (tfaas_command): Add "--".
7413         (_initialize_thread): Update help "tfaas" to mention supported
7414         options and install command completer.
7415
7416 2019-06-13  Pedro Alves  <palves@redhat.com>
7417
7418         * completer.c (complete_nested_command_line): New.
7419         (gdb_completion_word_break_characters_throw): Add assertion.
7420         * completer.h (complete_nested_command_line): Declare.
7421
7422 2019-06-13  Pedro Alves  <palves@redhat.com>
7423
7424         * stack.c (parse_backtrace_qualifiers): New.
7425         (backtrace_command): Use it.
7426         (backtrace_command_completer): Complete on qualifiers.
7427
7428 2019-06-13  Pedro Alves  <palves@redhat.com>
7429
7430         * frame.c: Include "cli/cli-option.h.
7431         (user_set_backtrace_options): New.
7432         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7433         Delete.
7434         (get_prev_frame): Adjust.
7435         (boolean_option_def, uinteger_option_def)
7436         (set_backtrace_option_defs): New.
7437         (_initialize_frame): Adjust and use
7438         gdb::option::add_setshow_cmds_for_options to install "set
7439         backtrace past-main" and "set backtrace past-entry".
7440         * frame.h: Include "cli/cli-option.h".
7441         (struct frame_print_options): Forward declare.
7442         (print_frame_arguments_all, print_frame_arguments_scalars)
7443         (print_frame_arguments_none): Declare.
7444         (print_entry_values): Delete declaration.
7445         (struct frame_print_options, user_frame_print_options): New.
7446         (struct set_backtrace_options): New.
7447         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7448         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7449         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7450         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7451         (list_args_or_locals): Add frame_print_options parameter.
7452         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7453         * python/py-framefilter.c (enumerate_args): Pass down
7454         USER_FRAME_PRINT_OPTIONS.
7455         * stack.c: Include "cli/cli-option.h".
7456         (print_frame_arguments_all, print_frame_arguments_scalars)
7457         (print_frame_arguments_none): Declare.
7458         (print_raw_frame_arguments, print_entry_values): Delete.
7459         (user_frame_print_options): New.
7460         (boolean_option_def, enum_option_def, frame_print_option_defs):
7461         New.
7462         (struct backtrace_cmd_options): New.
7463         (bt_flag_option_def): New.
7464         (backtrace_command_option_defs): New.
7465         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7466         (print_frame_arg, read_frame_arg, print_frame_args)
7467         (print_frame_info, print_frame): Add frame_print_options parameter
7468         and use it.
7469         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7470         (backtrace_command_1): Add frame_print_options and
7471         backtrace_cmd_options parameters and use them.
7472         (make_backtrace_options_def_group): New.
7473         (backtrace_command): Process command options with
7474         gdb::option::process_options.
7475         (backtrace_command_completer): New.
7476         (_initialize_stack): Extend "backtrace"'s help to mention
7477         supported options.  Install completer for "backtrace".
7478         Install some settings commands with add_setshow_cmds_for_options.
7479
7480 2019-06-13  Pedro Alves  <palves@redhat.com>
7481
7482         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7483         and that "set/show print raw frame-arguments" are now deprecated.
7484
7485         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7486         command.
7487         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7488         * stack.c (_initialize_stack): Install "set/show print
7489         raw-frame-arguments", and deprecate "set/show print raw
7490         frame-arguments".
7491         * valprint.c (_initialize_valprint): Deprecate "set/show print
7492         raw".
7493
7494 2019-06-13  Pedro Alves  <palves@redhat.com>
7495
7496         * compile/compile.c (struct compile_options): New.
7497         (compile_flag_option_def, compile_command_option_defs)
7498         (make_compile_options_def_group): New.
7499         (compile_file_command): Handle options with
7500         gdb::option::process_options.
7501         (compile_file_command_completer): New function.
7502         (compile_code_command): Handle options with
7503         gdb::option::process_options.
7504         (compile_code_command_completer): New function.
7505         (_initialize_compiler): Install completers for "compile code" and
7506         "compile file".  Mention available options in "compile code" and
7507         "compile code"'s help.
7508         * completer.c (advance_to_completion_word): New, factored out from
7509         ...
7510         (advance_to_expression_complete_word_point): ... this.
7511         (advance_to_filename_complete_word_point): New.
7512         * completer.h (advance_to_filename_complete_word_point): New
7513         declaration.
7514
7515 2019-06-13  Pedro Alves  <palves@redhat.com>
7516
7517         * compile/compile.c: Include "cli/cli-option.h".
7518         (compile_print_value): Scope data pointer is now a
7519         value_print_options pointer; adjust.
7520         (compile_print_command): Process options.  Scope data pointer is
7521         now a value_print_options pointer; adjust.
7522         (_initialize_compile): Update "compile print"'s help to include
7523         supported options.  Install a completer for "compile print".
7524         * cp-valprint.c (show_vtblprint, show_objectprint)
7525         (show_static_field_print): Delete.
7526         (_initialize_cp_valprint): Don't install "set print
7527         static-members", "set print vtbl", "set print object" here.
7528         * printcmd.c: Include "cli/cli-option.h" and
7529         "common/gdb_optional.h".
7530         (print_command_parse_format): Rework to fill in a
7531         value_print_options instead of a format_data.
7532         (print_value): Change parameter type from format_data pointer to
7533         value_print_options reference.  Adjust.
7534         (print_command_1): Process options.  Adjust to pass down a
7535         value_print_options.
7536         (print_command_completer): New.
7537         (_initialize_printcmd): Install print_command_completer as
7538         handle_brkchars completer for the "print" command.  Update
7539         "print"'s help to include supported options.
7540         * valprint.c: Include "cli/cli-option.h".
7541         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7542         here from cp-valprint.c.
7543         (boolean_option_def, uinteger_option_def)
7544         (value_print_option_defs, make_value_print_options_def_group):
7545         New.  Use gdb::option::add_setshow_cmds_for_options to install
7546         "set print elements", "set print null-stop", "set print repeats",
7547         "set print pretty", "set print union", "set print array", "set
7548         print address", "set print symbol", "set print array-indexes".
7549         * valprint.h: Include <string> and "cli/cli-option.h".
7550         (make_value_print_options_def_group): Declare.
7551         (print_value): Change parameter type from format_data pointer to
7552         value_print_options reference.
7553         (print_command_completer): Declare.
7554
7555 2019-06-13  Pedro Alves  <palves@redhat.com>
7556
7557         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7558         (COMMON_SFILES): Add maint-test-settings.c.
7559         * cli/cli-decode.c (boolean_enums): New global, factored out from
7560         ...
7561         (add_setshow_boolean_cmd): ... here.
7562         * cli/cli-decode.h (boolean_enums): Declare.
7563         * cli/cli-option.c: New file.
7564         * cli/cli-option.h: New file.
7565         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7566         factored out from ...
7567         (parse_cli_boolean_value(const char *)): ... this.
7568         (is_unlimited_literal): Change parameter type to pointer to
7569         pointer.  Adjust and advance ARG pointer.
7570         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7571         (parse_cli_var_enum): New, factored out from ...
7572         (do_set_command): ... this.  Adjust.
7573         * cli/cli-setshow.h (parse_cli_boolean_value)
7574         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7575         (parse_cli_var_enum): Declare.
7576         * cli/cli-utils.c: Include "cli/cli-option.h".
7577         (get_ulongest): New.
7578         * cli/cli-utils.h (get_ulongest): Declare.
7579         (check_for_argument): New overloads.
7580         * maint-test-options.c: New file.
7581
7582 2019-06-13  Pedro Alves  <palves@redhat.com>
7583
7584         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7585         parse a range if "-" is at the end of the string.
7586
7587 2019-06-13  Pedro Alves  <palves@redhat.com>
7588
7589         * cli/cli-setshow.c (parse_auto_binary_operation)
7590         (parse_cli_boolean_value): Don't allow "o".
7591
7592 2019-06-13  Pedro Alves  <palves@redhat.com>
7593
7594         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7595         * NEWS: Mention maint test-settings KIND.
7596         * maint-test-settings.c: New file.
7597
7598 2019-06-13  Pedro Alves  <palves@redhat.com>
7599
7600         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7601         completer.
7602         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7603         "set" completers.
7604
7605 2019-06-13  Pedro Alves  <palves@redhat.com>
7606
7607         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7608         after item.
7609
7610 2019-06-13  Pedro Alves  <palves@redhat.com>
7611
7612         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7613
7614 2019-06-13  Pedro Alves <palves@redhat.com>
7615
7616         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7617         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7618         call.
7619         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7620         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7621         calls.
7622         (check_for_argument): Skip spaces after argument.
7623
7624 2019-06-13  Pedro Alves  <palves@redhat.com>
7625
7626         * thread.c (thread_apply_command): Adjust TID parsing.
7627         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7628         detected before end of string.
7629         (tid_is_in_list): Error out if LIST is invalid.
7630
7631 2019-06-13  Pedro Alves  <palves@redhat.com>
7632
7633         * completer.c (complete_line_internal_1): Rewind completion word
7634         point.
7635         (completion_tracker::advance_custom_word_point_by): Change
7636         parameter type to int.
7637         * completer.h (completion_tracker::advance_custom_word_point_by):
7638         Likewise.
7639
7640 2019-06-13  Pedro Alves  <palves@redhat.com>
7641
7642         * completer.c (advance_to_completion_word): Handle delimiters.
7643
7644 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7645
7646         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7647
7648 2019-06-11  Tom Tromey  <tom@tromey.com>
7649
7650         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7651         (xmalloc_failed): Move to alloc.c.
7652         * alloc.c: New file.
7653         * Makefile.in (COMMON_SFILES): Add alloc.c.
7654
7655 2019-06-11  Tom Tromey  <tom@tromey.com>
7656
7657         * nat/linux-waitpid.c: Don't include server.h.
7658         (linux_debug): Remove.
7659         (my_waitpid): Update.
7660
7661 2019-06-11  Tom Tromey  <tromey@adacore.com>
7662
7663         * infcall.c (_initialize_infcall): Remove trailing newline from
7664         help.
7665         * user-regs.c (_initialize_user_regs): Remove trailing newline
7666         from help.
7667         * typeprint.c (_initialize_typeprint): Remove trailing newline
7668         from help.
7669         * reverse.c (_initialize_reverse): Remove trailing newlines from
7670         help.
7671         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7672         from help.
7673         * language.c (add_set_language_command): Remove trailing newline
7674         from help.
7675         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7676         help.
7677         * disasm.c (_initialize_disasm): Remove trailing newline from
7678         help.
7679         * top.c (init_main): Remove trailing newline from help.
7680         * interps.c (_initialize_interpreter): Remove trailing newline
7681         from help.
7682         * btrace.c (_initialize_btrace): Remove trailing newlines from
7683         help.
7684         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7685         from help.
7686         * python/python.c (_initialize_python): Remove trailing newline
7687         from help.
7688         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7689         help.
7690         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7691         from help.  Reformat some text.
7692         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7693         from help.
7694         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7695         newline from help.
7696
7697 2019-06-11  Tom Tromey  <tromey@adacore.com>
7698
7699         * darwin-nat.c (darwin_decode_exception_message)
7700         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7701
7702 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * valops.c (value_slice): Check for not allocated or not
7705         associated values.
7706
7707 2019-06-10  Tom de Vries  <tdevries@suse.de>
7708
7709         PR gdb/24618
7710         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7711         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7712         invalid.
7713
7714 2019-06-10  Tom de Vries  <tdevries@suse.de>
7715
7716         PR gdb/24611
7717         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7718         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7719
7720 2019-06-10  Tom de Vries  <tdevries@suse.de>
7721
7722         PR symtab/24545
7723         * symtab.c (struct demangled_name_entry): Add language field.
7724         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7725         static minimal symbol".  Set and use language field.
7726
7727 2019-06-10  Tom Tromey  <tromey@adacore.com>
7728
7729         * ada-lang.c (_initialize_ada_language): Update help text.
7730
7731 2019-06-10  Tom Tromey  <tromey@adacore.com>
7732
7733         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7734         with a newline.
7735         * guile/guile.c (handle_boot_error): Don't end warning with a
7736         newline.
7737         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7738         warning with a newline.
7739         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7740         newline.
7741         (s12z_frame_cache): Likewise.
7742         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7743         a newline.
7744         * solib-svr4.c (disable_probes_interface): Don't end warning with
7745         a newline.
7746         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7747         newline.
7748         * python/python.c (do_finish_initialization): Don't end warning
7749         with a newline.
7750
7751 2019-06-10  Tom Tromey  <tom@tromey.com>
7752
7753         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7754         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7755         gdbpy_enter.
7756
7757 2019-06-10  Tom Tromey  <tromey@adacore.com>
7758
7759         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7760         data.
7761         (elf_new_init): Don't call stabsread_new_init.
7762         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7763         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7764         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7765
7766 2019-06-10  Tom de Vries  <tdevries@suse.de>
7767
7768         PR symtab/16264
7769         PR symtab/24517
7770         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7771
7772 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7773
7774         * source.c (find_and_open_source): Also rewrite relative file
7775         names.
7776
7777 2019-04-26  Amos Bird  <amosbird@gmail.com>
7778
7779         * annotate.c (annotate_thread_exited): Add "thread-exited"
7780         annotation.
7781
7782 2019-06-06  Tom Tromey  <tromey@adacore.com>
7783
7784         * maint.h (class scoped_command_stats): Use
7785         DISABLE_COPY_AND_ASSIGN.
7786         <print_time>: New method.
7787         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7788         print_time.
7789         (scoped_command_stats::print_time): New method.
7790
7791 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7792
7793         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7794         instructions of lengths 6 or 8 bytes.
7795
7796 2019-06-04  Pedro Alves  <palves@redhat.com>
7797
7798         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7799
7800         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7801         * breakpoint.c (condition_completer): Likewise.
7802         * cli/cli-dump.c (scan_expression): Likewise.
7803         * common/filestuff.c (mkdir_recursive): Likewise.
7804         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7805         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7806         (gdb_abspath): Likewise.
7807         * compile/compile-cplus-types.c
7808         (compile_cplus_instance::decl_name): Likewise.
7809         * completer.c (complete_explicit_location):
7810         (signal_completer, reg_or_group_completer_1): Likewise.
7811         * cp-support.c (cp_remove_params_if_any): Likewise.
7812         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7813         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7814         * infcmd.c (strip_bg_char): Likewise.
7815         * linespec.c (copy_token_string): Likewise.
7816         * mi/mi-main.c (output_cores): Likewise.
7817         * psymtab.c (psymtab_search_name):
7818         * symfile.c (test_set_ext_lang_command): Likewise.
7819         * target.c (target_fileio_read_stralloc): Likewise.
7820         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7821         * value.c (complete_internalvar): Likewise.
7822
7823 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7824
7825         Add objfile property to gdb.Type.
7826         * NEWS: Mention Python API addition.
7827         * python/py-type.c (typy_get_objfile): New method.
7828
7829 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7830
7831         * NEWS: Mention the new set|show style [title|highlight].
7832         Mention changes to "show style", "help" and "apropos".
7833
7834 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7835
7836         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7837         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7838         instead of print_help_for_command.
7839         (print_doc_of_command): New function.
7840         (help_list): Add 'apropos -v word' suggestion.
7841         (print_help_for_command): Style the command name using title style.
7842         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7843         (_initialize_cli_cmds): Describe -v in apropos_command help.
7844
7845 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7846
7847         * cli/cli-style.h (cli_style_option): Add name in constructor,
7848         add m_name class member, add constructor with intensity,
7849         add name class function.
7850         (cli_style_option::add_setshow_commands): Remove name argument.
7851         (highlight_style, title_style): New styles.
7852         * cli/cli-style.c (do_show): New function that shows a style
7853         characteristic styling the style name with itself.
7854         (set_style_name): New function.
7855         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7856         Update all callers according to the changes in cli/cli-style.h.
7857         * utils.h (fputs_highlighted): New function.
7858         * utils.c (fputs_highlighted): Likewise.
7859
7860 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7861
7862         * NEWS: Mention new pipe command and new convenience variables.
7863
7864 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7865
7866         * cli/cli-cmds.c (pipe_command): New function.
7867         (_initialize_cli_cmds): Call add_com for pipe_command.
7868         Define | as an alias for pipe.
7869         (exit_status_set_internal_vars): New function.
7870         (shell_escape): Call exit_status_set_internal_vars.
7871         cli/cli-decode.c (find_command_name_length): Recognize | as
7872         a single character command.
7873
7874 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7875
7876         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7877         top.c (execute_command_to_ui_file): New function, mostly a copy
7878         of execute_command_to_string.
7879         (execute_command_to_string): Implement by calling
7880         execute_command_to_ui_file.
7881
7882 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7883
7884         * top.h (saved_command_line): Remove declaration.
7885         * top.c (previous_saved_command_line, previous_repeat_arguments):
7886         New variables.
7887         (saved_command_line): Make static, define together with other
7888         'repeat variables'.
7889         (dont_repeat): Clear repeat_arguments.
7890         (repeat_previous, get_saved_command_line, save_command_line):
7891         New functions.
7892         (gdb_init): Initialize saved_command_line
7893         and previous_saved_command_line.
7894         * main.c (captured_main_1): Remove saved_command_line initialization.
7895         * event-top.c (handle_line_of_input): Update to use
7896         the new 'repeat' related functions instead of direct access to
7897         saved_command_line.
7898         * command.h (repeat_previous, get_saved_command_line,
7899         save_command_line): New declarations.
7900         (dont_repeat): Add comment.
7901
7902 2019-05-30  Tom Tromey  <tromey@adacore.com>
7903
7904         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7905         Fix comment.
7906         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7907
7908 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7909
7910         PR cli/24587
7911         * completer.c (complete): Initialize variable word.
7912
7913 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7914
7915         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7916         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7917         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7918         'body' is NULL to the outter 'if', protecting the '!is_define'
7919         situation as well.
7920
7921 2019-05-29  Tom Tromey  <tromey@adacore.com>
7922
7923         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7924         (dwarf_unknown): New function.
7925         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7926         (dwarf_type_encoding_name): Use dwarf_unknown.
7927
7928 2019-05-29  Tom Tromey  <tromey@adacore.com>
7929
7930         PR c++/20020:
7931         * cp-valprint.c (cp_print_value_fields): Call
7932         cp_print_static_field inside "try".
7933
7934 2019-05-29  Tom Tromey  <tromey@adacore.com>
7935
7936         * inflow.c (struct terminal_info): Add default operator=.
7937         * configure: Rebuild.
7938         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7939         -Wdeprecated-copy-dtor, -Wredundant-move.
7940
7941 2019-05-29  Tom Tromey  <tromey@adacore.com>
7942
7943         * NEWS: Add entry.
7944         * infcmd.c (print_return_value_1): Handle finish_print
7945         option.
7946         (show_print_finish): New function.
7947         (_initialize_infcmd): Add "set/show print finish" commands.
7948         * valprint.c (user_print_options): Initialize new member.
7949         * valprint.h (struct value_print_options) <finish_print>: New
7950         member.
7951
7952 2019-05-28  Tom Tromey  <tromey@adacore.com>
7953
7954         * ada-lang.c (ada_remove_Xbn_suffix)
7955         (find_old_style_renaming_symbol)
7956         (parse_old_style_renaming): Remove.
7957         (ada_find_renaming_symbol): Don't call
7958         find_old_style_renaming_symbol.
7959         (ada_is_renaming_symbol): Rename from
7960         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7961         bool.  Now static.
7962         (ada_read_var_value): Update and simplify.
7963         * ada-exp.y (write_var_or_type): Remove old code.
7964
7965 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7966
7967         PR gdb/25010
7968         * event-top.c: Remove include comment.
7969         * inflow.c (class scoped_ignore_sigttou): Move from here...
7970         * inflow.h (class scoped_ignore_sigttou): ...to here.
7971         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7972         * top.c:  Remove include comment.
7973
7974 2019-05-27  Tom Tromey  <tom@tromey.com>
7975
7976         * NEWS: Fix typo.
7977
7978 2019-05-22  Tom Tromey  <tromey@adacore.com>
7979
7980         * target.c (target_follow_exec): Constify parameter.
7981         * target-delegates.c: Rebuild.
7982         * remote.c (remote_target::follow_exec): Constify parameter.
7983         * infrun.c (follow_exec): Constify parameter.
7984         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7985         (target_follow_exec): Likewise.
7986
7987 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7988
7989         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7990         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7991
7992 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7993
7994         * NEWS: Add debugredirect and testsuite sections.
7995
7996 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7997
7998         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7999         target descriptions using exclusively floating point register name
8000         aliases.
8001
8002 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8003
8004         PR gdb/18644:
8005         * f-lang.c (build_fortran_types): Handle the case where
8006         gdbarch_floatformat_for_type returns a nullptr.
8007
8008 2019-05-21  Tom de Vries  <tdevries@suse.de>
8009
8010         PR cli/24587
8011         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8012
8013 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         PR gdb/18644:
8016         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8017         16-byte floats.
8018         * i386-tdep.c (i386_floatformat_for_type): Use
8019         floatformats_ia64_quad for the 16-byte floating point component
8020         within a fortran 32-byte complex number.
8021
8022 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8023
8024         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8025         delete default constructor.
8026         (find_partial_die): Update to return const struct.
8027         (partial_die_parent_scope): Move variable declaration into scope
8028         of its use and change its type to auto.
8029         (guess_partial_die_structure_name): Likewise.
8030         (partial_die_info::fixup): Likewise.
8031
8032 2019-05-17  Tom Tromey  <tromey@adacore.com>
8033
8034         * source.c (find_and_open_source): Remove cast.
8035
8036 2019-05-17  Tom Tromey  <tromey@adacore.com>
8037
8038         * annotate.c (annotate_source): Make "filename" const.
8039         * annotate.h (annotate_source): Use const.
8040
8041 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8042
8043         * disasm.c (set_disassembler_options): Send errors to stderr.
8044
8045 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8046
8047         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8048         (cli_interp_base::set_logging): Check debug_redirect.
8049         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8050         * cli/cli-logging.c (debug_redirect): Add static variable.
8051         (pop_output_files): Add default param.
8052         (handle_redirections): Print debug setting.
8053         (show_logging_command): Likewise.
8054         (_initialize_cli_logging): Add debugredirect command.
8055         * interps.c (current_interp_set_logging): Add debug_redirect
8056         parameter.
8057         * interps.h (set_logging): Add debug_redirect parameter.
8058         (current_interp_set_logging): Likewise.
8059         * mi/mi-common.h: Likewise.
8060         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8061
8062 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8063             Tom Tromey  <tromey@adacore.com>
8064
8065         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8066         directly.
8067         * cli/cli-interp.h (make_logging_output): Remove declaration.
8068         * cli/cli-logging.c (make_logging_output): Remove function.
8069         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8070         directly.
8071         * ui-file.c (tee_file::tee_file): Remove bools.
8072         (tee_file::~tee_file): Remove deletes.
8073         * ui-file.h (tee_file): Remove bools.
8074
8075 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8076
8077         * mi/mi-cmds.h (mi_cmd_complete): New function.
8078         * mi/mi-main.c (mi_cmd_complete): Likewise.
8079         * mi/mi-cmds.c: Define new MI command -complete.
8080         * NEWS: Mention new -complete command.
8081
8082 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8083
8084         * completer.h (complete): New function.
8085         * completer.c (complete): Likewise.
8086         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8087         function defined in completer.h.
8088
8089 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8090
8091         * MAINTAINERS (Write After Approval): Add myself.
8092
8093 2019-05-17  Tom de Vries  <tdevries@suse.de>
8094
8095         PR gdb/24094
8096         * dwarf2read.c (struct cu_partial_die_info): New struct.
8097         (find_partial_die): Return cu_partial_die_info.
8098         (partial_die_parent_scope, guess_partial_die_structure_name)
8099         (partial_die_info::fixup): Handle new return type of find_partial_die.
8100
8101 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8102
8103         PR breakpoints/24541
8104         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8105         "std::string", simplifying the algorithm.
8106
8107 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8108
8109         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8110         (stap_static_probe_ops::get_probes): Likewise.
8111
8112 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8113
8114         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8115         '-')" and "else if".
8116         (stap_parse_single_operand): Join checks for
8117         "gdbarch_stap_parse_special_token_p" and
8118         "gdbarch_stap_parse_special_token" in the same "if" statement.
8119         Invert check when verifying for operation on register
8120         displacement.
8121
8122 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8123
8124         * stap-probe.c (stap_get_opcode): Update comment.
8125         (stap_get_expected_argument_type): Likewise.
8126         (handle_stap_probe): Likewise.
8127
8128 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8129
8130         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8131         return type to 'bool'.  Adjust comment.  Use 'bool' when
8132         appropriate.
8133         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8134         * stap-probe.c (stap_parse_argument_1): Likewise.
8135         (stap_is_operator): Likewise.
8136         (stap_is_generic_prefix): Likewise.
8137         (stap_is_register_prefix): Likewise.
8138         (stap_is_register_indirection_prefix): Likewise.
8139         (stap_is_integer_prefix): Likewise.
8140         (stap_generic_check_suffix): Likewise.
8141         (stap_check_integer_suffix): Likewise.
8142         (stap_check_register_suffix): Likewise.
8143         (stap_check_register_indirection_suffix): Likewise.
8144         (stap_parse_register_operand): Likewise.
8145         (stap_parse_single_operand): Likewise.
8146         (stap_parse_argument_1): Likewise.
8147         (stap_probe::get_argument_count): Likewise.
8148         (stap_is_operator): Likewise.
8149
8150 2019-05-16  Tom Tromey  <tromey@adacore.com>
8151
8152         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8153         keyword to foreach.
8154
8155 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8156
8157         * linux-thread-db.c (try_thread_db_load_1): Change return type
8158         to bool.
8159         (try_thread_db_load): Likewise.
8160         (try_thread_db_load_from_pdir_1): Likewise.
8161         (try_thread_db_load_from_pdir): Likewise.
8162         (try_thread_db_load_from_sdir): Likewise.
8163         (try_thread_db_load_from_dir): Likewise.
8164         (thread_db_load_search): Likewise.
8165         (has_libpthread): Likewise.
8166         (thread_db_load): Likewise.
8167
8168 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8169
8170         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8171         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8172         NULL, and complain/return if that's the case.
8173
8174 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8175
8176         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8177         (advance, posn, abstract_read_memory): New functions.
8178         [struct mem_read_abstraction]: New struct.
8179         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8180
8181 2019-05-14  Tom Tromey  <tromey@adacore.com>
8182
8183         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8184         value is not lval_memory.
8185
8186 2019-05-14  Tom Tromey  <tromey@adacore.com>
8187
8188         * solib.c (info_sharedlibrary_command): Style the file name.
8189
8190 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8191
8192         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8193         (aarch64_vnv_type): Likewise.
8194         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8195         * common/tdesc.c: Likewise.
8196         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8197         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8198         * features/aarch64-fpu.xml: Add ieee half view.
8199         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8200         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8201         * gdbtypes.h (struct builtin_type): Likewise.
8202         (struct objfile_type): Likewise.
8203
8204 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8205
8206         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8207         typo.
8208         * location.h (string_to_event_location): Likewise.
8209
8210 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8211
8212         GDB 8.3 released.
8213
8214 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8215
8216         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8217         New variable declaration.
8218         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8219         New variable.
8220         (print_one_breakpoint): Use ui_out::test_flags and new global
8221         variable to compute use_fixed_output.
8222         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8223         Remove.
8224         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8225         (mi_multi_location_breakpoint_output_fixed): Remove.
8226         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8227         new variable.
8228         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8229         fix_multi_location_breakpoint_output flag if version >= 3.
8230         * ui-out.h (enum ui_out_flag)
8231         <fix_multi_location_breakpoint_output>: New enumerator.
8232
8233 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8234
8235         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8236
8237 2019-05-10  Tom Tromey  <tromey@adacore.com>
8238
8239         * ada-lang.c (catch_ada_completer): New function.
8240         (_initialize_ada_language): Use it.
8241
8242 2019-05-10  Tom Tromey  <tromey@adacore.com>
8243
8244         * thread.c (print_thread_info): Make "requested_threads" const.
8245         * gdbthread.h (print_thread_info): Make "requested_threads"
8246         const.
8247         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8248         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8249
8250 2019-05-08  Tom Tromey  <tom@tromey.com>
8251
8252         * gdbtypes.c (objfile_type_data): Change type.
8253         (objfile_type, _initialize_gdbtypes): Update.
8254
8255 2019-05-08  Tom Tromey  <tom@tromey.com>
8256
8257         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8258         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8259         (_initialize_dwarf2_frame): Update.
8260
8261 2019-05-08  Tom Tromey  <tom@tromey.com>
8262
8263         * objc-lang.c (objc_objfile_data): Change type.
8264         (find_methods): Update.
8265         (_initialize_objc_lang): Remove.
8266
8267 2019-05-08  Tom Tromey  <tom@tromey.com>
8268
8269         * stabsread.c (rs6000_builtin_type_data): Change type.
8270         (rs6000_builtin_type, _initialize_stabsread): Update.
8271
8272 2019-05-08  Tom Tromey  <tom@tromey.com>
8273
8274         * mips-tdep.c (mips_pdr_data): Remove.
8275         (_initialize_mips_tdep): Update.
8276
8277 2019-05-08  Tom Tromey  <tom@tromey.com>
8278
8279         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8280         (hppa_init_objfile_priv_data, read_unwind_info)
8281         (find_unwind_entry, _initialize_hppa_tdep): Update.
8282
8283 2019-05-08  Tom Tromey  <tom@tromey.com>
8284
8285         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8286         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8287         on obstack.
8288         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8289
8290 2019-05-08  Tom Tromey  <tom@tromey.com>
8291
8292         * mdebugread.c (basic_type_data): Change type.
8293         (basic_type, _initialize_mdebugread): Update.
8294
8295 2019-05-08  Tom Tromey  <tom@tromey.com>
8296
8297         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8298
8299 2019-05-08  Tom Tromey  <tom@tromey.com>
8300
8301         * nto-tdep.c (nto_inferior_data_reg): Change type.
8302         (nto_inferior_data): Update.
8303         (nto_inferior_data_cleanup, nto_new_inferior_data)
8304         (_initialize_nto_tdep): Remove.
8305         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8306
8307 2019-05-08  Tom Tromey  <tom@tromey.com>
8308
8309         * ada-lang.c (struct ada_inferior_data): Add initializers.
8310         (ada_inferior_data): Change type.
8311         (ada_inferior_data_cleanup): Remove.
8312         (get_ada_inferior_data, ada_inferior_exit)
8313         (struct ada_pspace_data): Add initializers, destructor.
8314         (ada_pspace_data_handle): Change type.
8315         (get_ada_pspace_data): Update.
8316         (ada_pspace_data_cleanup): Remove.
8317
8318 2019-05-08  Tom Tromey  <tom@tromey.com>
8319
8320         * coffread.c (struct coff_symfile_info): Add initializers.
8321         (coff_objfile_data_key): Move lower.  Change type.
8322         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8323         Update.
8324         (coff_free_info): Remove.
8325
8326 2019-05-08  Tom Tromey  <tom@tromey.com>
8327
8328         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8329         (fbsd_pspace_data_handle): Move lower.  Change type.
8330         (get_fbsd_pspace_data): Update.
8331         (fbsd_pspace_data_cleanup): Remove.
8332         (_initialize_fbsd_tdep): Update.
8333
8334 2019-05-08  Tom Tromey  <tom@tromey.com>
8335
8336         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8337         (get_ada_tasks_pspace_data): Update.
8338         (ada_tasks_pspace_data_cleanup): Remove.
8339         (_initialize_tasks): Update.
8340         (ada_tasks_inferior_data_handle): Change type.
8341         (get_ada_tasks_inferior_data): Update.
8342         (ada_tasks_inferior_data_cleanup): Remove.
8343         (struct ada_tasks_pspace_data): Add initializers.
8344
8345 2019-05-08  Tom Tromey  <tom@tromey.com>
8346
8347         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8348         * symfile-debug.c (debug_sym_get_probes): Change type.
8349         * stap-probe.c (handle_stap_probe):
8350         (stap_static_probe_ops::get_probes): Change type.
8351         * probe.h (class static_probe_ops) <get_probes>: Change type.
8352         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8353         (parse_probes_in_pspace): Update.
8354         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8355         Update.
8356         (any_static_probe_ops::get_probes): Change type.
8357         * elfread.c (elfread_data): New typedef.
8358         (probe_key): Change type.
8359         (elf_get_probes): Likewise.  Update.
8360         (probe_key_free): Remove.
8361         (_initialize_elfread): Update.
8362         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8363         Change type.
8364         (dtrace_process_dof_probe, dtrace_process_dof)
8365         (dtrace_static_probe_ops::get_probe): Change type.
8366
8367 2019-05-08  Tom Tromey  <tom@tromey.com>
8368
8369         * xcoffread.c (struct xcoff_symfile_info): Rename from
8370         coff_symfile_info.  Add initializers.
8371         (xcoff_objfile_data_key): Move lower.  Change type.
8372         (XCOFF_DATA): Rewrite.
8373         (xcoff_free_info): Remove.
8374         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8375         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8376         (xcoff_initial_scan): Update.
8377
8378 2019-05-08  Tom Tromey  <tom@tromey.com>
8379
8380         * solib-svr4.c (struct svr4_info): Add initializers and
8381         destructor.
8382         <probes_table>: Now an htab_up.
8383         (solib_svr4_pspace_data): Change type.
8384         (free_probes_table): Simplify.
8385         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8386         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8387         (probes_table_remove_objfile_probes, register_solib_event_probe)
8388         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8389         (_initialize_svr4_solib): Update.
8390
8391 2019-05-08  Tom Tromey  <tom@tromey.com>
8392
8393         * remote.c (remote_pspace_data): Change type.
8394         (remote_pspace_data_cleanup): Remove.
8395         (get_remote_exec_file, set_pspace_remote_exec_file)
8396         (_initialize_remote): Update.
8397
8398 2019-05-08  Tom Tromey  <tom@tromey.com>
8399
8400         * breakpoint.c (breakpoint_objfile_key): Change type.
8401         (get_breakpoint_objfile_data): Update.
8402         (free_breakpoint_objfile_data): Remove.
8403         (_initialize_breakpoint): Update.
8404
8405 2019-05-08  Tom Tromey  <tom@tromey.com>
8406
8407         * linux-tdep.c (struct linux_info): Add initializers.
8408         (linux_inferior_data): Move.  Change type.
8409         (invalidate_linux_cache_inf): Update.
8410         (linux_inferior_data_cleanup): Remove.
8411         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8412
8413 2019-05-08  Tom Tromey  <tom@tromey.com>
8414
8415         * auxv.c (auxv_inferior_data): Move.  Change type.
8416         (auxv_inferior_data_cleanup): Remove.
8417         (invalidate_auxv_cache_inf): Rewrite.
8418         (get_auxv_inferior_data, _initialize_auxv): Update.
8419
8420 2019-05-08  Tom Tromey  <tom@tromey.com>
8421
8422         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8423         (symfile_debug_objfile_data_key): Change type.
8424         (symfile_debug_installed, debug_qf_has_symbols)
8425         (debug_qf_find_last_source_symtab)
8426         (debug_qf_forget_cached_source_info)
8427         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8428         (debug_qf_print_stats, debug_qf_dump)
8429         (debug_qf_expand_symtabs_for_function)
8430         (debug_qf_expand_all_symtabs)
8431         (debug_qf_expand_symtabs_with_fullname)
8432         (debug_qf_map_matching_symbols)
8433         (debug_qf_expand_symtabs_matching)
8434         (debug_qf_find_pc_sect_compunit_symtab)
8435         (debug_qf_map_symbol_filenames)
8436         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8437         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8438         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8439         (debug_sym_read_linetable, debug_sym_relocate): Update.
8440         (symfile_debug_free_objfile): Remove.
8441         (install_symfile_debug_logging, _initialize_symfile_debug):
8442         Update.
8443
8444 2019-05-08  Tom Tromey  <tom@tromey.com>
8445
8446         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8447         allocate_on_obstack.
8448         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8449         (get_dwarf2_per_objfile): Update.
8450         (set_dwarf2_per_objfile): Remove.
8451         (dwarf2_has_info, dwarf2_get_section_info): Update.
8452         (dwarf2_free_objfile): Remove.
8453         (_initialize_dwarf2_read): Update.
8454
8455 2019-05-08  Tom Tromey  <tom@tromey.com>
8456
8457         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8458         initializers.
8459         <unsupported_script_warning_printed,
8460         script_not_found_warning_printed>: Now bool.
8461         (auto_load_pspace_data): Change type.
8462         (~auto_load_pspace_info): Rename from
8463         auto_load_pspace_data_cleanup.
8464         (get_auto_load_pspace_data, init_loaded_scripts_info)
8465         (clear_section_scripts, maybe_print_unsupported_script_warning)
8466         (maybe_print_script_not_found_warning, _initialize_auto_load):
8467         Update.
8468
8469 2019-05-08  Tom Tromey  <tom@tromey.com>
8470
8471         * objfiles.c (objfile_pspace_info): Add destructor and
8472         initializers.
8473         (objfiles_pspace_data): Change type.
8474         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8475         (get_objfile_pspace_data): Update.
8476         (objfiles_bfd_data): Change type.
8477         (get_objfile_bfd_data): Update.
8478         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8479
8480 2019-05-08  Tom Tromey  <tom@tromey.com>
8481
8482         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8483         Change type.
8484         (get_catch_syscall_inferior_data): Update.
8485         (catch_syscall_inferior_data_cleanup): Remove.
8486         (_initialize_break_catch_syscall): Update.
8487
8488 2019-05-08  Tom Tromey  <tom@tromey.com>
8489
8490         * inflow.c (struct terminal_info): Add destructor and
8491         initializers.
8492         (inflow_inferior_data): Change type.
8493         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8494         (get_inflow_inferior_data, inflow_inferior_exit)
8495         (swap_terminal_info, _initialize_inflow): Update.
8496
8497 2019-05-08  Tom Tromey  <tom@tromey.com>
8498
8499         * target-dcache.c (target_dcache_cleanup): Remove.
8500         (target_dcache_aspace_key): Change type.
8501         (target_dcache_init_p, target_dcache_invalidate)
8502         (target_dcache_get, target_dcache_get_or_init)
8503         (_initialize_target_dcache): Update.
8504         * dcache.h (struct dcache_deleter): New.
8505
8506 2019-05-08  Tom Tromey  <tom@tromey.com>
8507
8508         * symtab.c (struct symbol_cache): Add destructor and
8509         initializers.
8510         (symbol_cache_key): Move.  Change type.
8511         (make_symbol_cache, free_symbol_cache): Remove.
8512         (get_symbol_cache): Update.
8513         (symbol_cache_cleanup): Remove.
8514         (ALL_PSPACES, symbol_cache_flush)
8515         (maintenance_print_symbol_cache)
8516         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8517         Update.
8518
8519 2019-05-08  Tom Tromey  <tom@tromey.com>
8520
8521         * symtab.c (struct main_info): Add destructor and initializers.
8522         (main_progspace_key): Move.  Change type.
8523         (get_main_info): Update.
8524         (main_info_cleanup): Remove.
8525         (_initialize_symtab): Update.
8526
8527 2019-05-08  Tom Tromey  <tom@tromey.com>
8528
8529         * registry.h (DECLARE_REGISTRY): Define the _key class.
8530
8531 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8532
8533         * NEWS: Merge two 'New commands' sections.
8534
8535 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8536
8537         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8538         parameter and use Ada language definition instead.
8539         (ada_val_print_ptr): Remove unused language parameter.
8540         (ada_val_print_num): Remove language parameter and use Ada language
8541         definition instead.
8542         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8543         parameter.
8544         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8545         parameter and use Ada language definition instead.
8546         (ada_val_print_1): Update all ada_val_print_xxx calls.
8547         Remove language parameter.
8548         (ada_val_print): Update ada_val_print_1 call.
8549
8550 2019-05-08  Tom Tromey  <tromey@adacore.com>
8551
8552         * remote.c (remote_hw_watchpoint_limit)
8553         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8554         Now static.
8555
8556 2019-05-08  Tom Tromey  <tromey@adacore.com>
8557
8558         * maint.c (_initialize_maint_cmds): Move initialization code to
8559         remote.c.
8560         (watchdog, show_watchdog): Move to remote.c.
8561         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8562         "watchdog" static.
8563         (_initialize_remote): Move initialization code from maint.c.
8564         * defs.h (watchdog): Don't declare.
8565
8566 2019-05-08  Tom Tromey  <tromey@adacore.com>
8567
8568         * tui/tui-interp.c: Include main.h.
8569         * interps.c: Include main.h.
8570         * main.h (interpreter_p): Declare.
8571         * defs.h (interpreter_p): Don't declare.
8572
8573 2019-05-08  Tom Tromey  <tromey@adacore.com>
8574
8575         * dwarf2loc.c: Include dwarf2read.h.
8576         * defs.h (read_unsigned_leb128): Don't declare.
8577         * dwarf2read.h (read_unsigned_leb128): Declare.
8578
8579 2019-05-08  Tom Tromey  <tromey@adacore.com>
8580
8581         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8582         method.
8583
8584 2019-05-08  Tom Tromey  <tromey@adacore.com>
8585
8586         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8587         when no wrap column is set.
8588
8589 2019-05-08  Tom Tromey  <tromey@adacore.com>
8590
8591         * c-lang.c (c_get_string): Handle non-C-style arrays.
8592
8593 2019-05-08  Tom Tromey  <tromey@adacore.com>
8594
8595         * typeprint.c (print_offset_data::update): Print the bit offset,
8596         not the number of bits remaining.
8597
8598 2019-05-08  Tom Tromey  <tromey@adacore.com>
8599
8600         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8601         padding at end of comment.
8602
8603 2019-05-08  Tom Tromey  <tromey@adacore.com>
8604
8605         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8606         Compare main types.
8607
8608 2019-05-06  Tom Tromey  <tom@tromey.com>
8609
8610         * common/scoped_mmap.c: Include common-defs.h.
8611         * common/scoped_mmap.h: Don't include config.h.
8612
8613 2019-05-04  Tom Tromey  <tom@tromey.com>
8614
8615         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8616         (struct aarch64_call_info): Add initializers.
8617         <si>: Now a std::vector.
8618         (pass_on_stack, aarch64_push_dummy_call): Update.
8619
8620 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8621             Tom Tromey  <tom@tromey.com>
8622
8623         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8624         (ppc_threads): Now a std::vector.  Now static.
8625         (hwdebug_find_thread_points_by_tid)
8626         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8627         Update.
8628
8629 2019-05-04  Tom Tromey  <tom@tromey.com>
8630
8631         * arc-tdep.c (arc_tdesc_init): Return bool.
8632
8633 2019-05-04  Tom Tromey  <tom@tromey.com>
8634
8635         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8636         Use gdb_assert_not_reached.
8637
8638 2019-05-04  Tom Tromey  <tom@tromey.com>
8639
8640         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8641         "false".
8642
8643 2019-05-04  Tom Tromey  <tom@tromey.com>
8644
8645         * arc-tdep.c (arc_tdesc_init): Use bool.
8646
8647 2019-05-04  Tom Tromey  <tom@tromey.com>
8648
8649         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8650
8651 2019-05-04  Tom Tromey  <tom@tromey.com>
8652
8653         * cli/cli-cmds.c (valid_command_p): Return bool.
8654
8655 2019-05-04  Tom Tromey  <tom@tromey.com>
8656
8657         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8658         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8659
8660 2019-05-04  Raul Tambre  <raul@tambre.ee>
8661
8662         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8663         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8664         operator for comparison.
8665
8666 2019-05-04  Tom Tromey  <tom@tromey.com>
8667
8668         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8669         (lookup_partial_symbol, print_partial_symbols)
8670         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8671         (psymbol_compare): Update.
8672         (add_psymbol_to_bcache): Clear the entire psymbol.
8673         (maintenance_check_psymtabs): Update.
8674         * psympriv.h (struct partial_symbol): Don't derive from
8675         general_symbol_info.
8676         <obj_section, unrelocated_address, address,
8677         set_unrelocated_address>: Update.
8678         <ginfo>: New member.
8679         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8680         (debug_names::write_psymbols): Update.
8681
8682 2019-05-04  Tom de Vries  <tdevries@suse.de>
8683
8684         * contrib/cc-with-tweaks.sh: Support -n arg.
8685
8686 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8687
8688         * corelow.c (core_target::detach): Ensure frame cache and
8689         register caches are cleared.
8690         inferior.c (exit_inferior_1): Likewise.
8691
8692 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8693             Tom Tromey  <tom@tromey.com>
8694
8695         * dictionary.c (collate_pending_symbols_by_language): Remove
8696         "struct" from foreach.
8697         * symtab.c (lookup_global_symbol_from_objfile)
8698         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8699         foreach.
8700         * ser-tcp.c (net_open): Remove "struct" from foreach.
8701         * objfiles.c (objfile_relocate, objfile_rebase)
8702         (objfile_has_symbols): Remove "struct" from foreach.
8703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8704         from foreach.
8705         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8706         foreach.
8707         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8708         "struct" from foreach.
8709         * ada-lang.c (create_excep_cond_exprs)
8710         (ada_exception_catchpoint_cond_string): Remove "struct" from
8711         foreach.
8712
8713 2019-05-03  Tom Tromey  <tromey@adacore.com>
8714
8715         * ada-exp.y (convert_char_literal): Check suffix of each
8716         enumerator.
8717
8718 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8719
8720         PR ada/21406:
8721         * ada-exp.y (yywrap): Don't define.
8722         * ada-lex.l (%option): Add noyywrap
8723         (yywrap): Remove.
8724
8725 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8726
8727         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8728         _WIN32_WINNT to the XP level, unless already defined to a higher
8729         level.
8730
8731         * unittests/parse-connection-spec-selftests.c:
8732         * ser-tcp.c:
8733         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8734         override.
8735
8736         * symfile.c (find_separate_debug_file): Remove colon from the
8737         drive spec of DOS/Windows file names of the target, so that the
8738         file name produced from DEBUGDIR and the target's directory will
8739         be valid on DOS/Windows systems.
8740
8741 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8742
8743         * rust-lang.c (val_print_struct): Handle printing structures
8744         containing strings.
8745
8746 2019-05-02  Tom Tromey  <tromey@adacore.com>
8747
8748         * valarith.c (_initialize_valarith): Remove.
8749
8750 2019-05-01  Tom Tromey  <tromey@adacore.com>
8751
8752         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8753         bitfields.
8754
8755 2019-05-01  Tom Tromey  <tromey@adacore.com>
8756
8757         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8758         for big-endian copies.
8759
8760 2019-04-30  Ali Tamur  <tamur@google.com>
8761         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8762         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8763         (read_3_bytes): New function.
8764
8765 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8766
8767         * windows-nat.c (main_thread_id): Delete.
8768         (handle_output_debug_string): Replace main_thread_id by
8769         current_event.dwThreadId.
8770         (fake_create_process): Likewise.
8771         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8772         Do not set main_thread_id.
8773         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8774         current_event.dwThreadId.
8775         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8776
8777 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8778
8779         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8780         Use current_event.dwThreadId instead of main_thread_id.
8781
8782 2019-04-30  Tom Tromey  <tromey@adacore.com>
8783
8784         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8785         (create_excep_cond_exprs): Iterate over program spaces.
8786         (ada_exception_catchpoint_cond_string): Examine all minimal
8787         symbols for exception types.
8788
8789 2019-04-30  Tom Tromey  <tromey@adacore.com>
8790
8791         PR c++/24470:
8792         * dwarf2read.c (process_structure_scope): Handle case where type
8793         has template parameters but no symbol was created.
8794
8795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8796             Chris January  <chris.january@arm.com>
8797
8798         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8799         qualifier.
8800         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8801
8802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8803
8804         * f-typeprint.c (f_print_type): Update rules for printing
8805         whitespace.
8806         (f_type_print_varspec_suffix): Likewise.
8807
8808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8809             Chris January  <chris.january@arm.com>
8810
8811         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8812         function arguments.
8813
8814 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * f-lang.c (build_fortran_types): Change name of void type to
8817         lower case.
8818         * f-typeprint.c (f_type_print_base): Print the name of the void
8819         type, rather than a fixed string.
8820         * f-valprint.c (f_decorations): Use lower case void string.
8821
8822 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8823             Chris January  <chris.january@arm.com>
8824
8825         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8826         types for Fortran.
8827
8828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8829             Chris January  <chris.january@arm.com>
8830             David Lecomber  <david.lecomber@arm.com>
8831
8832         * f-exp.y (BINOP_INTRINSIC): New token.
8833         (exp): New parser rule handling BINOP_INTRINSIC.
8834         (f77_keywords): Add new builtin procedures.
8835         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8836         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8837         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8838         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8839         (print_unop_subexp_f): New function.
8840         (print_binop_subexp_f): New function.
8841         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8842         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8843         (dump_subexp_body_f): Likewise.
8844         (operator_check_f): Likewise.
8845         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8846         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8847
8848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8851         UNOP_KIND.
8852         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8853         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8854         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8855         (operator_length_f): New fuction.
8856         (print_subexp_f): New function.
8857         (op_name_f): New function.
8858         (dump_subexp_body_f): New function.
8859         (operator_check_f): New function.
8860         (exp_descriptor_f): Replace standard expression handling functions
8861         with new functions.
8862         * gdb/fortran-operator.def: New file.
8863         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8864         * gdb/std-operator.def: Remove UNOP_KIND.
8865
8866 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * std-operator.def: Remove unbalanced, stray double quote
8869         character.
8870
8871 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8872             Chris January  <chris.january@arm.com>
8873             Daniel Everett  <daniel.everett@arm.com>
8874             Nick Forrington  <nick.forrington@arm.com>
8875             Richard Bunt  <richard.bunt@arm.com>
8876
8877         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8878         of depth when printing anonymous structs or unions.
8879         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8880         Don't print either the top-level value, or the children if the
8881         max-depth is exceeded.
8882         (ppscm_print_children): When printing the key of a map, allow one
8883         extra level of depth.
8884         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8885         print either the top-level value, or the children if the max-depth
8886         is exceeded.
8887         (print_children): When printing the key of a map, allow one extra
8888         level of depth.
8889         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8890         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8891         (user_print_options): Initialise max_depth field.
8892         (val_print_scalar_or_string_type_p): New function.
8893         (val_print): Check to see if the max depth has been reached.
8894         (val_print_check_max_depth): Define new function.
8895         (show_print_max_depth): New function.
8896         (_initialize_valprint): Add 'print max-depth' option.
8897         * valprint.h (struct value_print_options) <max_depth>: New field.
8898         (val_print_check_max_depth): Declare new function.
8899         * NEWS: Document new feature.
8900
8901 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8902
8903         * ada-lang.c (ada_language_defn): Initialise new field.
8904         * c-lang.c (c_is_string_type_p): New function.
8905         (c_language_defn): Initialise new field.
8906         (cplus_language_defn): Initialise new field.
8907         (asm_language_defn): Initialise new field.
8908         (minimal_language_defn): Initialise new field.
8909         * c-lang.h (c_is_string_type_p): Declare new function.
8910         * d-lang.c (d_language_defn): Initialise new field.
8911         * f-lang.c (f_is_string_type_p): New function.
8912         (f_language_defn): Initialise new field.
8913         * go-lang.c (go_is_string_type_p): New function.
8914         (go_language_defn): Initialise new field.
8915         * language.c (default_is_string_type_p): New function.
8916         (unknown_language_defn): Initialise new field.
8917         (auto_language_defn): Initialise new field.
8918         * language.h (struct language_defn) <la_is_string_type_p>: New
8919         member variable.
8920         (default_is_string_type_p): Declare new function.
8921         * m2-lang.c (m2_language_defn): Initialise new field.
8922         * objc-lang.c (objc_language_defn): Initialise new field.
8923         * opencl-lang.c (opencl_language_defn): Initialise new field.
8924         * p-lang.c (pascal_is_string_type_p): New function.
8925         (pascal_language_defn): Initialise new field.
8926         * rust-lang.c (rust_is_string_type_p): New function.
8927         (rust_language_defn): Initialise new field.
8928
8929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8932         New field.
8933         * ada-lang.c (ada_language_defn): Initialise new field.
8934         * c-lang.c (c_language_defn): Likewise.
8935         (cplus_language_defn): Likewise.
8936         (asm_language_defn): Likewise.
8937         (minimal_language_defn): Likewise.
8938         * d-lang.c (d_language_defn): Likewise.
8939         * f-lang.c (f_language_defn): Likewise.
8940         * go-lang.c (go_language_defn): Likewise.
8941         * language.c (unknown_language_defn): Likewise.
8942         (auto_language_defn): Likewise.
8943         * m2-lang.c (m2_language_defn): Likewise.
8944         * objc-lang.c (objc_language_defn): Likewise.
8945         * opencl-lang.c (opencl_language_defn): Likewise.
8946         * p-lang.c (pascal_language_defn): Likewise.
8947         * rust-lang.c (rust_language_defn): Likewise.
8948
8949 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8950
8951         * ada-lang.c (ada_is_character_type): Change return type to bool.
8952         (ada_is_string_type): Likewise.
8953         * ada-lang.h (ada_is_character_type): Update declaration
8954         (ada_is_string_type): Likewise.
8955
8956 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8957
8958         Support style in 'frame|thread apply'
8959
8960         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8961         * record.c (record_start, record_stop): Update callers of
8962         execute_command_to_string with false.
8963         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8964         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8965         methods.
8966         (class string_file): New constructor with term_out parameter.
8967         Override methods term_out and can_emit_style_escape.  New member
8968         term_out.
8969         (class stdio_file): Override can_emit_style_escape.
8970         (class tee_file): Override term_out and can_emit_style_escape.
8971         * utils.h (can_emit_style_escape): Remove.
8972         * utils.c (can_emit_style_escape): Likewise.
8973         Update all callers of can_emit_style_escape (SOMESTREAM) to
8974         SOMESTREAM->can_emit_style_escape.
8975         * source-cache.c (source_cache::get_source_lines): Likewise.
8976         * stack.c (frame_apply_command_count): Call execute_command_to_string
8977         passing the term_out characteristic of the current gdb_stdout.
8978         * thread.c (thr_try_catch_cmd): Likewise.
8979         * top.c (execute_command_to_string): pass term_out parameter
8980         to construct the string_file for the command output.
8981         * ui-file.c (term_cli_styling): New function (most code moved
8982         from utils.c can_emit_style_escape).
8983         (string_file::string_file, string_file::can_emit_style_escape,
8984         stdio_file::can_emit_style_escape, tee_file::term_out,
8985         tee_file::can_emit_style_escape): New functions.
8986
8987 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8988
8989         * NEWS: Mention the new set|show may-call-functions.
8990         * infcall.c (may_call_functions_p): New variable.
8991         (show_may_call_functions_p): New function.
8992         (call_function_by_hand_dummy): Throws an error if not
8993         may-call-functions.
8994         (_initialize_infcall): Call add_setshow_boolean_cmd for
8995         may-call-functions.
8996
8997 2019-04-25  Keith Seitz  <keiths@redhat.com>
8998
8999         PR c++/24367
9000         * cp-support.c (inspect_type): Don't attempt substitutions
9001         of symbol with the same name.
9002
9003 2019-04-25  Tom Tromey  <tromey@adacore.com>
9004
9005         PR gdb/24475:
9006         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9007         static.
9008
9009 2019-04-25  Tom Tromey  <tromey@adacore.com>
9010
9011         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9012         rvalue reference.
9013         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9014         (gdb_xml_parser::parse): Use std::move.
9015         * python/python-internal.h (gdbpy_convert_exception): Take a const
9016         reference.
9017         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9018         std::move.
9019         * python/py-utils.c (gdbpy_convert_exception): Take a const
9020         reference.
9021         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9022         Use std::move.
9023         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9024         Use std::move.
9025         * mi/mi-main.c (mi_print_exception): Take a const reference.
9026         * main.c (handle_command_errors): Take a const reference.
9027         * linespec.c (parse_linespec): Use std::move.
9028         * infcall.c (run_inferior_call): Use std::move.
9029         (call_function_by_hand_dummy): Use std::move.
9030         * exec.c (try_open_exec_file): Use std::move.
9031         * exceptions.h (exception_print, exception_fprintf)
9032         (exception_print_same): Update.
9033         * exceptions.c (print_exception, exception_print)
9034         (exception_fprintf, exception_print_same): Change parameters to
9035         const reference.
9036         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9037         * common/new-op.c: Use std::move.
9038         * common/common-exceptions.h (struct gdb_exception): Add move
9039         constructor.
9040         (struct gdb_exception_error, struct gdb_exception_quit, struct
9041         gdb_quit_bad_alloc): Change constructor to move constructor.
9042         (throw_exception): Change parameter to rvalue reference.
9043         * common/common-exceptions.c (throw_exception): Take rvalue
9044         reference.
9045         * cli/cli-interp.c (safe_execute_command): Use std::move.
9046         * breakpoint.c (insert_bp_location, location_to_sals): Use
9047         std::move.
9048
9049 2019-04-25  Tom Tromey  <tromey@adacore.com>
9050
9051         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9052         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9053         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9054         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9055         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9056         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9057         guile/scm-value.c: Use unpack.
9058         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9059         gdbscm_gdb_exception.
9060         (gdbscm_throw_gdb_exception): Likewise.
9061         (struct gdbscm_gdb_exception): New.
9062         (unpack): New function.
9063         (gdbscm_wrap): Use unpack.
9064
9065 2019-04-25  Tom Tromey  <tromey@adacore.com>
9066
9067         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9068         (gdb_rl_callback_handler): Use std::move.
9069         * common/common-exceptions.h (struct gdb_exception): Add move
9070         assignment operator.
9071         (throw_exception_sjlj): Change "exception" to const reference.
9072         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9073         (throw_exception_sjlj): Change "exception" to const reference.
9074
9075 2019-04-25  Tom Tromey  <tromey@adacore.com>
9076
9077         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9078         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9079         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9080         Update.
9081         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9082         Update.
9083         * mi/mi-interp.c (mi_interp::exec): Update.
9084         * linespec.c (parse_linespec): Update.
9085         * infcall.c (run_inferior_call): Update.
9086         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9087         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9088         (gdbscm_lookup_global_symbol): Update.
9089         * guile/scm-param.c (gdbscm_parameter_value): Update.
9090         * guile/scm-frame.c (gdbscm_frame_read_register)
9091         (gdbscm_frame_read_var): Update.
9092         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9093         * exec.c (try_open_exec_file): Update.
9094         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9095         (gdb_rl_callback_handler): Update.
9096         * common/common-exceptions.h (exception_none): Don't declare.
9097         * common/common-exceptions.c (exception_none): Don't define.
9098         (struct catcher) <exception>: Update.
9099         * cli/cli-interp.c (safe_execute_command): Update.
9100         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9101
9102 2019-04-25  Ali Tamur  <tamur@google.com>
9103
9104         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9105         (read_attribute_value): Likewise.
9106         (dwarf2_read_addr_index): Update comment.
9107         (read_str_index): Add DW_FORM_strx.
9108         (dwarf2_string_attr): Likewise.
9109         (dwarf2_const_value_attr): Likewise.
9110         (dump_die_shallow): Likewise.
9111         (dwarf2_fetch_constant_bytes): Likewise.
9112         (skip_form_bytes): Likewise.
9113         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9114
9115 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9116
9117         PR corefiles/11608
9118         PR corefiles/18187
9119         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9120         OFFSET.  Verify if current mapping contains an ELF header.
9121         (linux_find_memory_regions_full): Adjust call to
9122         dump_mapping_p.
9123
9124 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9125             Kang Li <kanglictf@gmail.com>
9126
9127         PR gdb/21600
9128
9129         * dwarf2-frame.c (read_initial_length): Be consistent about using
9130         unsigned representation of length.
9131         (decode_frame_entry_1): Likewise.  Check for wraparound of
9132         end pointer as well as buffer overflow.
9133
9134 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9135
9136         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9137         "vq".
9138
9139 2019-04-24  Tom Tromey  <tromey@adacore.com>
9140
9141         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9142
9143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9144
9145         * s12z-tdep.c (s12z_unwind_pc): Delete.
9146         (s12z_unwind_sp): Delete.
9147         (s12z_gdbarch_init): Don't register deleted functions with
9148         gdbarch.
9149
9150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9151
9152         * rl78-tdep.c (rl78_unwind_sp): Delete.
9153         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9154
9155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9156
9157         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9158         (xstormy16_unwind_pc): Delete.
9159         (xstormy16_dummy_id): Delete.
9160         (xstormy16_gdbarch_init): Don't register deleted functions with
9161         gdbarch.
9162
9163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * vax-tdep.c (vax_unwind_pc): Delete.
9166         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9167
9168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9169
9170         * v850-tdep.c (v850_unwind_sp): Delete.
9171         (v850_unwind_pc): Delete.
9172         (v850_dummy_id): Delete.
9173         (v850_gdbarch_init): Don't register deleted functions with
9174         gdbarch.
9175
9176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9177
9178         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9179         (tilegx_unwind_pc): Delete.
9180         (tilegx_unwind_dummy_id): Delete.
9181         (tilegx_gdbarch_init): Don't register deleted functions with
9182         gdbarch.
9183
9184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9187         (tic6x_dummy_id): Delete.
9188         (tic6x_gdbarch_init): Don't register deleted functions with
9189         gdbarch.
9190
9191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * sparc-tdep.c (sparc_unwind_pc): Delete.
9194         (sparc32_gdbarch_init): Don't register deleted function with
9195         gdbarch.
9196
9197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9198
9199         * sh-tdep.c (sh_unwind_sp): Delete.
9200         (sh_unwind_pc): Delete.
9201         (sh_dummy_id): Delete.
9202         (sh_gdbarch_init): Don't register deleted functions with
9203         gdbarch.
9204
9205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9206
9207         * score-tdep.c (score_unwind_sp): Delete.
9208         (score_unwind_pc): Delete.
9209         (score_dummy_id): Delete.
9210         (score_gdbarch_init): Don't register deleted functions with
9211         gdbarch.
9212
9213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * rx-tdep.c (rx_unwind_pc): Delete.
9216         (rx_unwind_sp): Delete.
9217         (rx_dummy_id): Delete.
9218         (rx_gdbarch_init): Don't register deleted functions with
9219         gdbarch.  Update comment.
9220
9221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9224         (rs6000_dummy_id): Delete.
9225         (rs6000_gdbarch_init): Don't register deleted functions with
9226         gdbarch.
9227
9228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * or1k-tdep.c (or1k_dummy_id): Delete.
9231         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9232
9233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9234
9235         * nios2-tdep.c (nios2_dummy_id): Delete.
9236         (nios2_unwind_sp): Delete.
9237         (nios2_gdbarch_init): Don't register deleted functions with
9238         gdbarch.
9239
9240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9241
9242         * nds32-tdep.c (nds32_dummy_id): Delete.
9243         (nds32_unwind_pc): Delete.
9244         (nds32_unwind_sp): Delete.
9245         (nds32_gdbarch_init): Don't register deleted functions with
9246         gdbarch.
9247
9248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * msp430-tdep.c (msp430_unwind_pc): Delete.
9251         (msp430_unwind_sp): Delete.
9252         (msp430_dummy_id): Delete.
9253         (msp430_gdbarch_init): Don't register deleted functions with
9254         gdbarch.
9255
9256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9257
9258         * moxie-tdep.c (moxie_unwind_sp): Delete.
9259         (moxie_unwind_pc): Delete.
9260         (moxie_dummy_id): Delete.
9261         (moxie_gdbarch_init): Don't register deleted functions with
9262         gdbarch.
9263
9264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9267         (mn10300_unwind_pc): Delete.
9268         (mn10300_unwind_sp): Delete.
9269         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9270         mn10300_unwind_sp.
9271         (mn10300_frame_unwind_init): Don't register deleted functions with
9272         gdbarch.
9273
9274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * mep-tdep.c (mep_unwind_pc): Delete.
9277         (mep_unwind_sp): Delete.
9278         (mep_dummy_id): Delete.
9279         (mep_gdbarch_init): Don't register deleted functions with
9280         gdbarch.
9281
9282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9283
9284         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9285         (m68hc11_unwind_sp): Delete.
9286         (m68hc11_gdbarch_init): Don't register deleted functions with
9287         gdbarch.
9288
9289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * m32r-tdep.c (m32r_unwind_sp): Delete.
9292         (m32r_unwind_pc): Delete.
9293         (m32r_dummy_id): Delete.
9294         (m32r_gdbarch_init): Don't register deleted functions with
9295         gdbarch.
9296
9297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * m32c-tdep.c (m32c_unwind_pc): Delete.
9300         (m32c_unwind_sp): Delete.
9301         (m32c_dummy_id): Delete.
9302         (m32c_gdbarch_init): Don't register deleted functions with
9303         gdbarch.
9304
9305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9306
9307         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9308         (lm32_unwind_pc): Delete.
9309         (lm32_dummy_id): Delete.
9310         (lm32_gdbarch_init): Don't register deleted functions with
9311         gdbarch.
9312
9313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9316         (iq2000_unwind_pc): Delete.
9317         (iq2000_dummy_id): Delete.
9318         (iq2000_gdbarch_init): Don't register deleted functions with
9319         gdbarch.
9320
9321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * nds32-tdep.c (nds32_type_align): Delete.
9324         (nds32_push_dummy_call): Use type_align instead.
9325
9326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * arm-tdep.c (arm_type_align): Only handle vector override case.
9329         (arm_push_dummy_call): Use type_align.
9330         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9331
9332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9335         case.
9336         (pass_on_stack): Use type_align.
9337         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9338         function.
9339
9340 2019-04-23  Tom Tromey  <tromey@adacore.com>
9341
9342         * dwarf2read.c (line_header::file_name_at): Remove unused
9343         overload.
9344
9345 2019-04-23  Tom de Vries  <tdevries@suse.de>
9346
9347         PR gdb/24438
9348         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9349         invocation.
9350
9351
9352 2019-03-27  Ali Tamur  <tamur@google.com>
9353
9354         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9355         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9356         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9357         (dwarf_expr_context::get_addr_index): Likewise
9358         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9359         (symbol_needs_eval_context::get_addr_index): Likewise
9360         (disassemble_dwarf_expression): Add DW_OP_addrx
9361         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9362         (read_cutu_die_from_dwo): Update comment
9363         (skip_one_die): Add DW_FORM_addrx
9364         (read_attribute_value): Likewise
9365         (var_decode_location): Add DW_OP_addrx
9366         (dwarf2_const_value_attr): Add DW_FORM_addrx
9367         (dump_die_shallow): Likewise
9368         (dwarf2_fetch_constant_bytes): Likewise
9369         (decode_locdesc): Add DW_OP_addrx
9370         (skip_form_bytes): Add DW_FORM_addrx
9371
9372 2019-04-22  Ali Tamur  <tamur@google.com>
9373
9374         * MAINTAINERS (Write After Approval): Add self.
9375
9376 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9377
9378         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9379         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9380         (open_symbol_file_object): Likewise.
9381         (svr4_default_sos): Add info parameter.
9382         (svr4_read_so_list): Likewise.
9383         (svr4_current_sos_direct): Adjust functions calls to pass down
9384         info.
9385         (svr4_current_sos_1): Add info parameter.
9386         (svr4_current_sos): Call get_svr4_info, pass info down to
9387         svr4_current_sos_1.
9388         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9389         get_svr4_info.
9390         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9391         get_svr4_info.
9392         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9393         to get_svr4_info.
9394         (probes_table_remove_objfile_probes): Likewise.
9395         (register_solib_event_probe): Add info parameter.
9396         (solist_update_incremental): Pass info parameter down to
9397         svr4_read_so_list.
9398         (disable_probes_interface): Add info parameter.
9399         (svr4_handle_solib_event): Pass current_program_space to
9400         get_svr4_info.  Adjust disable_probes_interface cleanup.
9401         (svr4_create_probe_breakpoints): Add info parameter, pass it
9402         down to register_solib_event_probe.
9403         (svr4_create_solib_event_breakpoints): Add info parameter,
9404         pass it down to svr4_create_probe_breakpoints.
9405         (enable_break): Pass info down to
9406         svr4_create_solib_event_breakpoints.
9407         (svr4_solib_create_inferior_hook): Pass current_program_space to
9408         get_svr4_info.
9409         (svr4_clear_solib): Likewise.
9410
9411 2019-04-22  Pedro Alves  <palves@redhat.com>
9412
9413         * solib-svr4.c (svr4_free_objfile_observer): New.
9414         (probe_and_action::objfile): New field.
9415         (probes_table_htab_remove_objfile_probes)
9416         (probes_table_remove_objfile_probes): New functions.
9417         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9418         in the new probe_and_action.  Don't store the probe in 'lookup'.
9419         (svr4_create_probe_breakpoints): Pass objfile to
9420         register_solib_event_probe.
9421         (_initialize_svr4_solib): Register a free_objfile observer.
9422
9423 2019-04-19  Tom Tromey  <tom@tromey.com>
9424
9425         * common/queue.h: Remove.
9426
9427 2019-04-19  Tom Tromey  <tom@tromey.com>
9428
9429         * event-loop.c: Don't include "common/queue.h".
9430
9431 2019-04-19  Tom Tromey  <tom@tromey.com>
9432
9433         * remote.c (remote_target): Use delete.
9434         * remote-notif.h: Include <list>, not "common/queue.h".
9435         (notif_client_p): Remove typedef.
9436         (remote_notif_state): Add constructor, destructor, initializer.
9437         <notif_queue>: Now a std::list.
9438         (remote_notif_state_xfree): Don't declare.
9439         * remote-notif.c (remote_notif_process, handle_notification)
9440         (remote_notif_state_allocate): Update.
9441         (~remote_notif_state): Rename from remote_notif_state_xfree.
9442
9443 2019-04-19  Tom Tromey  <tom@tromey.com>
9444
9445         * symfile.c (reread_symbols): Update.
9446         * objfiles.c (objfile_register_static_link)
9447         (objfile_lookup_static_link): Update
9448         (~objfile) Don't delete static_links.
9449         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9450
9451 2019-04-19  Tom Tromey  <tom@tromey.com>
9452
9453         * type-stack.h (struct type_stack) <insert>: Constify string.
9454         * type-stack.c (type_stack::insert): Constify string.
9455         * gdbtypes.h (lookup_template_type): Update.
9456         (address_space_name_to_int): Update.
9457         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9458         const.
9459         (lookup_template_type): Make name const.
9460         * c-exp.y: Update rules.
9461         (lex_one_token, classify_name, classify_inner_name)
9462         (c_print_token): Update.
9463         * p-exp.y: Update rules.
9464         (yylex): Update.
9465         * f-exp.y: Update rules.
9466         (yylex): Update.
9467         * d-exp.y: Update rules.
9468         (lex_one_token, classify_name, classify_inner_name): Update.
9469         * parse.c (write_dollar_variable, copy_name): Return std::string.
9470         * parser-defs.h (copy_name): Change return type.
9471         * m2-exp.y: Update rules.
9472         (yylex): Update.
9473         * go-exp.y (lex_one_token): Update.
9474         Update rules.
9475         (classify_unsafe_function, classify_packaged_name)
9476         (classify_name, yylex): Update.
9477
9478 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9479
9480         * configure.ac: add --enable-source-highlight switch.
9481         * configure: Regenerate.
9482         * top.c (print_gdb_version): plumb --enable-source-highlight
9483         status to "show configuration".
9484
9485 2019-04-19  Tom Tromey  <tromey@adacore.com>
9486
9487         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9488         Check ADA_TYPE_P.
9489         (empty_record, ada_template_to_fixed_record_type_1)
9490         (template_to_static_fixed_type)
9491         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9492         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9493         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9494         macros.
9495
9496 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9497
9498         PR symtab/24423:
9499         * source.c (print_source_lines_base): Advance "iter" when a
9500         control character is seen.
9501
9502 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9503
9504         * inferior.h (struct infcall_suspend_state_deleter):
9505         Catch exception in destructor to avoid crash.
9506
9507 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9508
9509         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9510         close to the add_com "shell".
9511
9512 2019-04-18  Tom Tromey  <tromey@adacore.com>
9513
9514         * process-stratum-target.h (class process_stratum_target)
9515         <stratum>: Add "final".
9516
9517 2019-04-17  Tom Tromey  <tromey@adacore.com>
9518
9519         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9520         against nullptr before use.
9521
9522 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9523
9524         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9525
9526 2019-04-17  Jim Wilson  <jimw@sifive.com>
9527             Andrew Burgess  <andrew.burgess@embecosm.com>
9528
9529         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9530         code read might fail, assume 4-byte breakpoint in that case.
9531
9532 2019-04-15  Leszek Swirski  <leszeks@google.com>
9533
9534         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9535         rather than a hand-rolled POD check when checking for forced MEMORY
9536         classification.
9537
9538 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9539
9540         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9541         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9542         function.
9543         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9544         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9545         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9546         declaration.
9547
9548 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9549
9550         * aarch64-linux-nat.c
9551         (aarch64_linux_nat_target::thread_architecture): Add override.
9552         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9553         each VQ.
9554
9555 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9556
9557         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9558
9559 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9560
9561         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9562         target types of size 96-bits, add some additional comments, and
9563         check that the builtin type we found was the correct size.
9564
9565 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9566
9567         * utils.c (prompt_for_continue): Don't restore the styling at the
9568         end, as applied_style has the wrong value.  This fixes styling in
9569         long lists of file names that are interrupted by the "Continue?"
9570         prompt.
9571
9572 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9573
9574         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9575         * c-lang.c (c_language_defn): Likewise.
9576         (cplus_language_defn): Likewise.
9577         (asm_language_defn): Likewise.
9578         (minimal_language_defn): Likewise.
9579         * d-lang.c (d_language_defn): Likewise.
9580         * f-lang.c (f_language_defn): Likewise.
9581         * go-lang.c (go_language_defn): Likewise.
9582         * language.c (unknown_language_defn): Likewise.
9583         (auto_language_defn): Likewise.
9584         * language.h (struct language_defn): Remove la_magic field.
9585         (LANG_MAGIC): Delete.
9586         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9587         * objc-lang.c (objc_language_defn): Likewise.
9588         * opencl-lang.c (opencl_language_defn): Likewise.
9589         * p-lang.c (pascal_language_defn): Likewise.
9590         * rust-lang.c (rust_language_defn): Likewise.
9591
9592 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9593
9594         * riscv-tdep.c (riscv_type_align): New function.
9595         (riscv_type_alignment): Delete.
9596         (riscv_arg_location): Use 'type_align'.
9597         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9598
9599 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9600
9601         * gdbtypes.c (type_align): A struct with no non-static fields also
9602         has alignment of 1.
9603
9604 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9605
9606         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9607         component to 0.
9608         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9609         member.
9610         (riscv_struct_info::analyse): New implementation using new
9611         analyse_inner member function.
9612         (riscv_struct_info::field_offset): New member function.
9613         (riscv_struct_info::m_offsets): New member variable.
9614         (riscv_struct_info::analyse_inner): New private member function,
9615         takes the old implementation of riscv_struct_info::analyse but
9616         extended to track field offsets.
9617         (riscv_call_arg_struct): Update the struct folding special cases
9618         to handle cases where empty C++ structs, which are non-zero
9619         length, are found.
9620         (riscv_arg_location): Initialise the length of each location, a
9621         non-zero length now indicates the location is in use.
9622         (riscv_push_dummy_call): Allow for the first location having a
9623         non-zero offset when setting up arguments.
9624         (riscv_return_value): Likewise, but for return values.
9625
9626 2019-04-11  Tom Tromey  <tromey@adacore.com>
9627
9628         * utils.c (internal_vproblem): Make "msg" const.
9629
9630 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9631
9632         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9633         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9634         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9635         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9636
9637 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9638
9639         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9640         function.
9641         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9642         of amd64_collect_native_gregset.
9643         (amd64_linux_nat_target::store_registers): Likewise.
9644
9645 2019-04-10  Tom Tromey  <tom@tromey.com>
9646
9647         * symtab.c (lookup_global_symbol_from_objfile)
9648         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9649         * objfiles.h (class separate_debug_iterator): New.
9650         (class separate_debug_range): New.
9651         (struct objfile) <separate_debug_objfiles>: New method.
9652         (objfile_separate_debug_iterate): Don't declare.
9653         * objfiles.c (separate_debug_iterator::operator++): Rename from
9654         objfile_separate_debug_iterate.
9655         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9656         iterator.
9657         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9658         iterator.
9659
9660 2019-04-10  Tom Tromey  <tom@tromey.com>
9661
9662         * symfile.c (reread_symbols): Remove old comment.
9663         * objfiles.c (free_all_objfiles): Fix a typo.
9664
9665 2019-04-10  Tom Tromey  <tom@tromey.com>
9666
9667         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9668         * minsyms.c (lookup_minimal_symbol): Use foreach.
9669         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9670         (lookup_minimal_symbol_solib_trampoline): Likewise.
9671         * symfile.c (reread_symbols): Use foreach.
9672
9673 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9674             Tom Tromey  <tromey@adacore.com>
9675
9676         PR rust/24414:
9677         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9678         (rust_lex_int_test): Change "value" to be LONGEST.
9679         (rust_lex_tests): Add test for long integer literal.
9680
9681 2019-04-09  Tom Tromey  <tromey@adacore.com>
9682
9683         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9684         to bool.
9685         (extended_remote_target::attach): Update.
9686         (remote_target::remote_notice_new_inferior): Update.
9687         (remote_target::add_current_inferior_and_thread): Update.
9688         * inferior.c (exit_inferior_1): Use "false".
9689         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9690
9691 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9692
9693         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9694         the "start" command.
9695
9696 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9697
9698         * python/py-inferior.c (infpy_thread_from_thread_handle):
9699         Adjust comments to reflect renaming of thread_from_thread_handle
9700         to thread_from_handle.  Adjust keywords.  Fix type error message.
9701         (inferior_object_methods): Add thread_from_handle.  Retain
9702         thread_from_thread_handle, but mark it as deprecated.
9703
9704 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9705
9706         * gdbthread.h (find_thread_by_handle): Revise declaration.
9707         * thread.c (find_thread_by_handle): Likewise.  Adjust
9708         implementation too.
9709         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9710         support for buffer objects as handles.
9711
9712 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9713
9714         * python/py-infthread.c (thpy_thread_handle): New function.
9715         (thread_object_methods): Register thpy_thread_handle.
9716
9717 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9718
9719         * gdbthread.h (thread_to_thread_handle): Declare.
9720         * thread.c (gdbtypes.h): Include.
9721         (thread_to_thread_handle): New function.
9722
9723         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9724         (target_thread_info_to_thread_handle): Declare.
9725         * target.c (target_thread_info_to_thread_handle): New function.
9726         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9727         * target-delegates.c: Regenerate.
9728
9729         * linux-thread-db.c (class thread_db_target): Add method
9730         thread_info_to_thread_handle.
9731         (thread_db_target::thread_info_to_thread_handle): Define.
9732         * remote.c (class remote_target): Add new method
9733         thread_info_to_thread_handle.
9734         (remote_target::thread_info_to_thread_handle): Define.
9735
9736 2019-04-08  Pedro Alves  <palves@redhat.com>
9737
9738         * common/common-exceptions.c (throw_exception): Don't create
9739         named object to throw; throw directly.
9740         (throw_it): Likewise.  Don't initialize gdb_exception::message
9741         here, with new; pass FMT and AP to the ctor instead.
9742         * common/common-exceptions.h: Include <string>.
9743         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9744         const char *, va_list)): New ctor.  Use std::make_shared.
9745         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9746         errors)): Delete.
9747         (gdb_exception_error::gdb_exception_error(enum errors, const char
9748         *, va_list)): New.
9749         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9750         Add assertion.
9751         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9752         errors)): Delete.
9753         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9754         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9755         Add assertion.
9756
9757 2019-04-08  Tom Tromey  <tom@tromey.com>
9758
9759         * valops.c (value_rtti_indirect_type): Replace throw_exception
9760         with throw.
9761         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9762         with throw.
9763         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9764         throw.
9765         * target.c (target_translate_tls_address): Replace throw_exception
9766         with throw.
9767         * stack.c (frame_apply_command_count): Replace throw_exception
9768         with throw.
9769         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9770         throw.
9771         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9772         with throw.
9773         * rs6000-tdep.c (rs6000_frame_cache)
9774         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9775         * remote.c: Replace throw_exception with throw.
9776         * record-full.c (record_full_message, record_full_wait_1)
9777         (record_full_restore): Replace throw_exception with throw.
9778         * record-btrace.c:
9779         (get_thread_current_frame_id, record_btrace_start_replaying)
9780         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9781         (cmd_record_btrace_start): Replace throw_exception with throw.
9782         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9783         throw.
9784         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9785         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9786         * linespec.c:
9787         (find_linespec_symbols): Replace throw_exception with throw.
9788         * infrun.c (displaced_step_prepare, resume): Replace
9789         throw_exception with throw.
9790         * infcmd.c (post_create_inferior): Replace throw_exception with
9791         throw.
9792         * inf-loop.c (inferior_event_handler): Replace throw_exception
9793         with throw.
9794         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9795         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9796         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9797         (get_prev_frame_always, get_frame_pc_if_available)
9798         (get_frame_address_in_block_if_available, get_frame_language):
9799         Replace throw_exception with throw.
9800         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9801         throw_exception with throw.
9802         * eval.c (fetch_subexp_value, evaluate_var_value)
9803         (evaluate_funcall, evaluate_subexp_standard): Replace
9804         throw_exception with throw.
9805         * dwarf2loc.c (call_site_find_chain)
9806         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9807         Replace throw_exception with throw.
9808         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9809         with throw.
9810         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9811         throw.
9812         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9813         * completer.c (complete_line_internal): Replace throw_exception
9814         with throw.
9815         * compile/compile-object-run.c (compile_object_run): Replace
9816         throw_exception with throw.
9817         * cli/cli-script.c (process_next_line): Replace throw_exception
9818         with throw.
9819         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9820         (btrace_enable, btrace_maint_update_pt_packets): Replace
9821         throw_exception with throw.
9822         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9823         throw_exception with throw.
9824         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9825         throw_exception with throw.
9826         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9827         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9828         * aarch64-tdep.c (aarch64_make_prologue_cache)
9829         (aarch64_make_stub_cache): Replace throw_exception with throw.
9830
9831 2019-04-08  Tom Tromey  <tom@tromey.com>
9832
9833         * common/common-exceptions.c (throw_exception): Rename from
9834         throw_exception_cxx.  Remove old copy.  Make argument const.
9835         (throw_it): Create and throw exception objects directly.
9836         * common/common-exceptions.h (throw_exception): Make argument
9837         const.
9838         (struct gdb_exception_error): Add constructor.
9839         (struct gdb_exception_quit): Add constructor.
9840
9841 2019-04-08  Tom Tromey  <tom@tromey.com>
9842
9843         * common/common-exceptions.h (exception_rethrow): Don't declare.
9844         (TRY_SJLJ): Update comment.
9845         (TRY, CATCH, END_CATCH): Remove.
9846         * common/common-exceptions.c (exception_rethrow): Remove.
9847
9848 2019-04-08  Tom Tromey  <tom@tromey.com>
9849
9850         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9851         Remove.
9852         (gdb_exception_error): Rename from
9853         gdb_exception_RETURN_MASK_ERROR.
9854         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9855         (gdb_quit_bad_alloc): Update.
9856         * aarch64-tdep.c: Update.
9857         * ada-lang.c: Update.
9858         * ada-typeprint.c: Update.
9859         * ada-valprint.c: Update.
9860         * amd64-tdep.c: Update.
9861         * arch-utils.c: Update.
9862         * break-catch-throw.c: Update.
9863         * breakpoint.c: Update.
9864         * btrace.c: Update.
9865         * c-varobj.c: Update.
9866         * cli/cli-cmds.c: Update.
9867         * cli/cli-interp.c: Update.
9868         * cli/cli-script.c: Update.
9869         * common/common-exceptions.c: Update.
9870         * common/new-op.c: Update.
9871         * common/selftest.c: Update.
9872         * compile/compile-c-symbols.c: Update.
9873         * compile/compile-cplus-symbols.c: Update.
9874         * compile/compile-object-load.c: Update.
9875         * compile/compile-object-run.c: Update.
9876         * completer.c: Update.
9877         * corelow.c: Update.
9878         * cp-abi.c: Update.
9879         * cp-support.c: Update.
9880         * cp-valprint.c: Update.
9881         * darwin-nat.c: Update.
9882         * disasm-selftests.c: Update.
9883         * dtrace-probe.c: Update.
9884         * dwarf-index-cache.c: Update.
9885         * dwarf-index-write.c: Update.
9886         * dwarf2-frame-tailcall.c: Update.
9887         * dwarf2-frame.c: Update.
9888         * dwarf2loc.c: Update.
9889         * dwarf2read.c: Update.
9890         * eval.c: Update.
9891         * event-loop.c: Update.
9892         * event-top.c: Update.
9893         * exec.c: Update.
9894         * f-valprint.c: Update.
9895         * fbsd-tdep.c: Update.
9896         * frame-unwind.c: Update.
9897         * frame.c: Update.
9898         * gdbtypes.c: Update.
9899         * gnu-v3-abi.c: Update.
9900         * guile/guile-internal.h: Update.
9901         * guile/scm-block.c: Update.
9902         * guile/scm-breakpoint.c: Update.
9903         * guile/scm-cmd.c: Update.
9904         * guile/scm-disasm.c: Update.
9905         * guile/scm-frame.c: Update.
9906         * guile/scm-lazy-string.c: Update.
9907         * guile/scm-math.c: Update.
9908         * guile/scm-param.c: Update.
9909         * guile/scm-ports.c: Update.
9910         * guile/scm-pretty-print.c: Update.
9911         * guile/scm-symbol.c: Update.
9912         * guile/scm-symtab.c: Update.
9913         * guile/scm-type.c: Update.
9914         * guile/scm-value.c: Update.
9915         * i386-linux-tdep.c: Update.
9916         * i386-tdep.c: Update.
9917         * inf-loop.c: Update.
9918         * infcall.c: Update.
9919         * infcmd.c: Update.
9920         * infrun.c: Update.
9921         * jit.c: Update.
9922         * language.c: Update.
9923         * linespec.c: Update.
9924         * linux-fork.c: Update.
9925         * linux-nat.c: Update.
9926         * linux-tdep.c: Update.
9927         * linux-thread-db.c: Update.
9928         * main.c: Update.
9929         * mi/mi-cmd-break.c: Update.
9930         * mi/mi-cmd-stack.c: Update.
9931         * mi/mi-interp.c: Update.
9932         * mi/mi-main.c: Update.
9933         * objc-lang.c: Update.
9934         * p-valprint.c: Update.
9935         * parse.c: Update.
9936         * ppc-linux-tdep.c: Update.
9937         * printcmd.c: Update.
9938         * python/py-arch.c: Update.
9939         * python/py-breakpoint.c: Update.
9940         * python/py-cmd.c: Update.
9941         * python/py-finishbreakpoint.c: Update.
9942         * python/py-frame.c: Update.
9943         * python/py-framefilter.c: Update.
9944         * python/py-gdb-readline.c: Update.
9945         * python/py-inferior.c: Update.
9946         * python/py-infthread.c: Update.
9947         * python/py-lazy-string.c: Update.
9948         * python/py-linetable.c: Update.
9949         * python/py-objfile.c: Update.
9950         * python/py-param.c: Update.
9951         * python/py-prettyprint.c: Update.
9952         * python/py-progspace.c: Update.
9953         * python/py-record-btrace.c: Update.
9954         * python/py-record.c: Update.
9955         * python/py-symbol.c: Update.
9956         * python/py-type.c: Update.
9957         * python/py-unwind.c: Update.
9958         * python/py-utils.c: Update.
9959         * python/py-value.c: Update.
9960         * python/python.c: Update.
9961         * record-btrace.c: Update.
9962         * record-full.c: Update.
9963         * remote-fileio.c: Update.
9964         * remote.c: Update.
9965         * riscv-tdep.c: Update.
9966         * rs6000-aix-tdep.c: Update.
9967         * rs6000-tdep.c: Update.
9968         * rust-exp.y: Update.
9969         * rust-lang.c: Update.
9970         * s390-tdep.c: Update.
9971         * selftest-arch.c: Update.
9972         * solib-dsbt.c: Update.
9973         * solib-frv.c: Update.
9974         * solib-spu.c: Update.
9975         * solib-svr4.c: Update.
9976         * solib.c: Update.
9977         * sparc64-linux-tdep.c: Update.
9978         * stack.c: Update.
9979         * symfile-mem.c: Update.
9980         * symmisc.c: Update.
9981         * target.c: Update.
9982         * thread.c: Update.
9983         * top.c: Update.
9984         * tracefile-tfile.c: Update.
9985         * tui/tui.c: Update.
9986         * typeprint.c: Update.
9987         * unittests/cli-utils-selftests.c: Update.
9988         * unittests/parse-connection-spec-selftests.c: Update.
9989         * valops.c: Update.
9990         * valprint.c: Update.
9991         * value.c: Update.
9992         * varobj.c: Update.
9993         * windows-nat.c: Update.
9994         * x86-linux-nat.c: Update.
9995         * xml-support.c: Update.
9996
9997 2019-04-08  Tom Tromey  <tom@tromey.com>
9998
9999         * xml-support.c: Use C++ exception handling.
10000         * x86-linux-nat.c: Use C++ exception handling.
10001         * windows-nat.c: Use C++ exception handling.
10002         * varobj.c: Use C++ exception handling.
10003         * value.c: Use C++ exception handling.
10004         * valprint.c: Use C++ exception handling.
10005         * valops.c: Use C++ exception handling.
10006         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10007         handling.
10008         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10009         * typeprint.c: Use C++ exception handling.
10010         * tui/tui.c: Use C++ exception handling.
10011         * tracefile-tfile.c: Use C++ exception handling.
10012         * top.c: Use C++ exception handling.
10013         * thread.c: Use C++ exception handling.
10014         * target.c: Use C++ exception handling.
10015         * symmisc.c: Use C++ exception handling.
10016         * symfile-mem.c: Use C++ exception handling.
10017         * stack.c: Use C++ exception handling.
10018         * sparc64-linux-tdep.c: Use C++ exception handling.
10019         * solib.c: Use C++ exception handling.
10020         * solib-svr4.c: Use C++ exception handling.
10021         * solib-spu.c: Use C++ exception handling.
10022         * solib-frv.c: Use C++ exception handling.
10023         * solib-dsbt.c: Use C++ exception handling.
10024         * selftest-arch.c: Use C++ exception handling.
10025         * s390-tdep.c: Use C++ exception handling.
10026         * rust-lang.c: Use C++ exception handling.
10027         * rust-exp.y: Use C++ exception handling.
10028         * rs6000-tdep.c: Use C++ exception handling.
10029         * rs6000-aix-tdep.c: Use C++ exception handling.
10030         * riscv-tdep.c: Use C++ exception handling.
10031         * remote.c: Use C++ exception handling.
10032         * remote-fileio.c: Use C++ exception handling.
10033         * record-full.c: Use C++ exception handling.
10034         * record-btrace.c: Use C++ exception handling.
10035         * python/python.c: Use C++ exception handling.
10036         * python/py-value.c: Use C++ exception handling.
10037         * python/py-utils.c: Use C++ exception handling.
10038         * python/py-unwind.c: Use C++ exception handling.
10039         * python/py-type.c: Use C++ exception handling.
10040         * python/py-symbol.c: Use C++ exception handling.
10041         * python/py-record.c: Use C++ exception handling.
10042         * python/py-record-btrace.c: Use C++ exception handling.
10043         * python/py-progspace.c: Use C++ exception handling.
10044         * python/py-prettyprint.c: Use C++ exception handling.
10045         * python/py-param.c: Use C++ exception handling.
10046         * python/py-objfile.c: Use C++ exception handling.
10047         * python/py-linetable.c: Use C++ exception handling.
10048         * python/py-lazy-string.c: Use C++ exception handling.
10049         * python/py-infthread.c: Use C++ exception handling.
10050         * python/py-inferior.c: Use C++ exception handling.
10051         * python/py-gdb-readline.c: Use C++ exception handling.
10052         * python/py-framefilter.c: Use C++ exception handling.
10053         * python/py-frame.c: Use C++ exception handling.
10054         * python/py-finishbreakpoint.c: Use C++ exception handling.
10055         * python/py-cmd.c: Use C++ exception handling.
10056         * python/py-breakpoint.c: Use C++ exception handling.
10057         * python/py-arch.c: Use C++ exception handling.
10058         * printcmd.c: Use C++ exception handling.
10059         * ppc-linux-tdep.c: Use C++ exception handling.
10060         * parse.c: Use C++ exception handling.
10061         * p-valprint.c: Use C++ exception handling.
10062         * objc-lang.c: Use C++ exception handling.
10063         * mi/mi-main.c: Use C++ exception handling.
10064         * mi/mi-interp.c: Use C++ exception handling.
10065         * mi/mi-cmd-stack.c: Use C++ exception handling.
10066         * mi/mi-cmd-break.c: Use C++ exception handling.
10067         * main.c: Use C++ exception handling.
10068         * linux-thread-db.c: Use C++ exception handling.
10069         * linux-tdep.c: Use C++ exception handling.
10070         * linux-nat.c: Use C++ exception handling.
10071         * linux-fork.c: Use C++ exception handling.
10072         * linespec.c: Use C++ exception handling.
10073         * language.c: Use C++ exception handling.
10074         * jit.c: Use C++ exception handling.
10075         * infrun.c: Use C++ exception handling.
10076         * infcmd.c: Use C++ exception handling.
10077         * infcall.c: Use C++ exception handling.
10078         * inf-loop.c: Use C++ exception handling.
10079         * i386-tdep.c: Use C++ exception handling.
10080         * i386-linux-tdep.c: Use C++ exception handling.
10081         * guile/scm-value.c: Use C++ exception handling.
10082         * guile/scm-type.c: Use C++ exception handling.
10083         * guile/scm-symtab.c: Use C++ exception handling.
10084         * guile/scm-symbol.c: Use C++ exception handling.
10085         * guile/scm-pretty-print.c: Use C++ exception handling.
10086         * guile/scm-ports.c: Use C++ exception handling.
10087         * guile/scm-param.c: Use C++ exception handling.
10088         * guile/scm-math.c: Use C++ exception handling.
10089         * guile/scm-lazy-string.c: Use C++ exception handling.
10090         * guile/scm-frame.c: Use C++ exception handling.
10091         * guile/scm-disasm.c: Use C++ exception handling.
10092         * guile/scm-cmd.c: Use C++ exception handling.
10093         * guile/scm-breakpoint.c: Use C++ exception handling.
10094         * guile/scm-block.c: Use C++ exception handling.
10095         * guile/guile-internal.h: Use C++ exception handling.
10096         * gnu-v3-abi.c: Use C++ exception handling.
10097         * gdbtypes.c: Use C++ exception handling.
10098         * frame.c: Use C++ exception handling.
10099         * frame-unwind.c: Use C++ exception handling.
10100         * fbsd-tdep.c: Use C++ exception handling.
10101         * f-valprint.c: Use C++ exception handling.
10102         * exec.c: Use C++ exception handling.
10103         * event-top.c: Use C++ exception handling.
10104         * event-loop.c: Use C++ exception handling.
10105         * eval.c: Use C++ exception handling.
10106         * dwarf2read.c: Use C++ exception handling.
10107         * dwarf2loc.c: Use C++ exception handling.
10108         * dwarf2-frame.c: Use C++ exception handling.
10109         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10110         * dwarf-index-write.c: Use C++ exception handling.
10111         * dwarf-index-cache.c: Use C++ exception handling.
10112         * dtrace-probe.c: Use C++ exception handling.
10113         * disasm-selftests.c: Use C++ exception handling.
10114         * darwin-nat.c: Use C++ exception handling.
10115         * cp-valprint.c: Use C++ exception handling.
10116         * cp-support.c: Use C++ exception handling.
10117         * cp-abi.c: Use C++ exception handling.
10118         * corelow.c: Use C++ exception handling.
10119         * completer.c: Use C++ exception handling.
10120         * compile/compile-object-run.c: Use C++ exception handling.
10121         * compile/compile-object-load.c: Use C++ exception handling.
10122         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10123         * compile/compile-c-symbols.c: Use C++ exception handling.
10124         * common/selftest.c: Use C++ exception handling.
10125         * common/new-op.c: Use C++ exception handling.
10126         * cli/cli-script.c: Use C++ exception handling.
10127         * cli/cli-interp.c: Use C++ exception handling.
10128         * cli/cli-cmds.c: Use C++ exception handling.
10129         * c-varobj.c: Use C++ exception handling.
10130         * btrace.c: Use C++ exception handling.
10131         * breakpoint.c: Use C++ exception handling.
10132         * break-catch-throw.c: Use C++ exception handling.
10133         * arch-utils.c: Use C++ exception handling.
10134         * amd64-tdep.c: Use C++ exception handling.
10135         * ada-valprint.c: Use C++ exception handling.
10136         * ada-typeprint.c: Use C++ exception handling.
10137         * ada-lang.c: Use C++ exception handling.
10138         * aarch64-tdep.c: Use C++ exception handling.
10139
10140 2019-04-08  Tom Tromey  <tom@tromey.com>
10141
10142         * xml-support.c (gdb_xml_parser::parse): Update.
10143         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10144         * value.c (show_convenience): Update.
10145         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10146         (test_parse_flags_qcs): Update.
10147         * thread.c (thr_try_catch_cmd): Update.
10148         * target.c (target_translate_tls_address): Update.
10149         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10150         (info_frame_command_core, frame_apply_command_count): Update.
10151         * rust-exp.y (rust_lex_exception_test): Update.
10152         * riscv-tdep.c (riscv_print_one_register_info): Update.
10153         * remote.c (remote_target::enable_btrace): Update.
10154         * record-btrace.c (record_btrace_enable_warn): Update.
10155         * python/py-utils.c (gdbpy_convert_exception): Update.
10156         * printcmd.c (do_one_display, print_variable_and_value): Update.
10157         * mi/mi-main.c (mi_print_exception): Update.
10158         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10159         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10160         * linux-nat.c (linux_nat_target::attach): Update.
10161         * linux-fork.c (class scoped_switch_fork_info): Update.
10162         * infrun.c (displaced_step_prepare): Update.
10163         * infcall.c (call_function_by_hand_dummy): Update.
10164         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10165         * gnu-v3-abi.c (print_one_vtable): Update.
10166         * frame.c (get_prev_frame_always): Update.
10167         * f-valprint.c (info_common_command_for_block): Update.
10168         * exec.c (try_open_exec_file): Update.
10169         * exceptions.c (print_exception, exception_print)
10170         (exception_fprintf, exception_print_same): Update.
10171         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10172         * dwarf-index-cache.c (index_cache::store)
10173         (index_cache::lookup_gdb_index): Update.
10174         * darwin-nat.c (maybe_cache_shell): Update.
10175         * cp-valprint.c (cp_print_value_fields): Update.
10176         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10177         (gcc_cplus_symbol_address): Update.
10178         * compile/compile-c-symbols.c (gcc_convert_symbol)
10179         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10180         * common/selftest.c: Update.
10181         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10182         a std::string.
10183         (exception_try_scope_entry, exception_try_scope_exit): Don't
10184         declare.
10185         (struct exception_try_scope): Remove.
10186         (TRY): Don't use exception_try_scope.
10187         (struct gdb_exception): Add constructor, operator=.
10188         <what>: New method.
10189         (struct gdb_exception_RETURN_MASK_ALL)
10190         (struct gdb_exception_RETURN_MASK_ERROR)
10191         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10192         (struct gdb_quit_bad_alloc): Update.
10193         * common/common-exceptions.c (exception_none): Change
10194         initializer.
10195         (struct catcher) <state, exception>: Initialize inline.
10196         <prev>: Remove member.
10197         (current_catcher): Remove.
10198         (catchers): New global.
10199         (exceptions_state_mc_init): Simplify.
10200         (catcher_pop): Remove.
10201         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10202         (try_scope_depth, exception_try_scope_entry)
10203         (exception_try_scope_exit): Remove.
10204         (throw_exception_sjlj): Update.
10205         (exception_messages, exception_messages_size): Remove.
10206         (throw_it): Simplify.
10207         (gdb_exception_sliced_copy): Remove.
10208         (throw_exception_cxx): Update.
10209         * cli/cli-script.c (script_from_file): Update.
10210         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10211         Update.
10212         * ada-valprint.c (ada_val_print): Update.
10213         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10214         (create_excep_cond_exprs): Update.
10215
10216 2019-04-08  Tom Tromey  <tom@tromey.com>
10217
10218         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10219         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10220         (TRY, CATCH, END_CATCH): Remove some definitions.
10221         * common/common-exceptions.c: Don't use GDB_XCPT.
10222         (catcher_list_size): Remove.
10223         (throw_exception, throw_it): Simplify.
10224
10225 2019-04-05  Tom Tromey  <tom@tromey.com>
10226
10227         Revert the header-sorting patch.
10228         * ft32-tdep.c: Revert.
10229         * frv-tdep.c: Revert.
10230         * frv-linux-tdep.c: Revert.
10231         * frame.c: Revert.
10232         * frame-unwind.c: Revert.
10233         * frame-base.c: Revert.
10234         * fork-child.c: Revert.
10235         * findvar.c: Revert.
10236         * findcmd.c: Revert.
10237         * filesystem.c: Revert.
10238         * filename-seen-cache.h: Revert.
10239         * filename-seen-cache.c: Revert.
10240         * fbsd-tdep.c: Revert.
10241         * fbsd-nat.h: Revert.
10242         * fbsd-nat.c: Revert.
10243         * f-valprint.c: Revert.
10244         * f-typeprint.c: Revert.
10245         * f-lang.c: Revert.
10246         * extension.h: Revert.
10247         * extension.c: Revert.
10248         * extension-priv.h: Revert.
10249         * expprint.c: Revert.
10250         * exec.h: Revert.
10251         * exec.c: Revert.
10252         * exceptions.c: Revert.
10253         * event-top.c: Revert.
10254         * event-loop.c: Revert.
10255         * eval.c: Revert.
10256         * elfread.c: Revert.
10257         * dwarf2read.h: Revert.
10258         * dwarf2read.c: Revert.
10259         * dwarf2loc.c: Revert.
10260         * dwarf2expr.h: Revert.
10261         * dwarf2expr.c: Revert.
10262         * dwarf2-frame.c: Revert.
10263         * dwarf2-frame-tailcall.c: Revert.
10264         * dwarf-index-write.h: Revert.
10265         * dwarf-index-write.c: Revert.
10266         * dwarf-index-common.c: Revert.
10267         * dwarf-index-cache.h: Revert.
10268         * dwarf-index-cache.c: Revert.
10269         * dummy-frame.c: Revert.
10270         * dtrace-probe.c: Revert.
10271         * disasm.h: Revert.
10272         * disasm.c: Revert.
10273         * disasm-selftests.c: Revert.
10274         * dictionary.c: Revert.
10275         * dicos-tdep.c: Revert.
10276         * demangle.c: Revert.
10277         * dcache.h: Revert.
10278         * dcache.c: Revert.
10279         * darwin-nat.h: Revert.
10280         * darwin-nat.c: Revert.
10281         * darwin-nat-info.c: Revert.
10282         * d-valprint.c: Revert.
10283         * d-namespace.c: Revert.
10284         * d-lang.c: Revert.
10285         * ctf.c: Revert.
10286         * csky-tdep.c: Revert.
10287         * csky-linux-tdep.c: Revert.
10288         * cris-tdep.c: Revert.
10289         * cris-linux-tdep.c: Revert.
10290         * cp-valprint.c: Revert.
10291         * cp-support.c: Revert.
10292         * cp-namespace.c: Revert.
10293         * cp-abi.c: Revert.
10294         * corelow.c: Revert.
10295         * corefile.c: Revert.
10296         * continuations.c: Revert.
10297         * completer.h: Revert.
10298         * completer.c: Revert.
10299         * complaints.c: Revert.
10300         * coffread.c: Revert.
10301         * coff-pe-read.c: Revert.
10302         * cli-out.h: Revert.
10303         * cli-out.c: Revert.
10304         * charset.c: Revert.
10305         * c-varobj.c: Revert.
10306         * c-valprint.c: Revert.
10307         * c-typeprint.c: Revert.
10308         * c-lang.c: Revert.
10309         * buildsym.c: Revert.
10310         * buildsym-legacy.c: Revert.
10311         * build-id.h: Revert.
10312         * build-id.c: Revert.
10313         * btrace.c: Revert.
10314         * bsd-uthread.c: Revert.
10315         * breakpoint.h: Revert.
10316         * breakpoint.c: Revert.
10317         * break-catch-throw.c: Revert.
10318         * break-catch-syscall.c: Revert.
10319         * break-catch-sig.c: Revert.
10320         * blockframe.c: Revert.
10321         * block.c: Revert.
10322         * bfin-tdep.c: Revert.
10323         * bfin-linux-tdep.c: Revert.
10324         * bfd-target.c: Revert.
10325         * bcache.c: Revert.
10326         * ax-general.c: Revert.
10327         * ax-gdb.h: Revert.
10328         * ax-gdb.c: Revert.
10329         * avr-tdep.c: Revert.
10330         * auxv.c: Revert.
10331         * auto-load.c: Revert.
10332         * arm-wince-tdep.c: Revert.
10333         * arm-tdep.c: Revert.
10334         * arm-symbian-tdep.c: Revert.
10335         * arm-pikeos-tdep.c: Revert.
10336         * arm-obsd-tdep.c: Revert.
10337         * arm-nbsd-tdep.c: Revert.
10338         * arm-nbsd-nat.c: Revert.
10339         * arm-linux-tdep.c: Revert.
10340         * arm-linux-nat.c: Revert.
10341         * arm-fbsd-tdep.c: Revert.
10342         * arm-fbsd-nat.c: Revert.
10343         * arm-bsd-tdep.c: Revert.
10344         * arch-utils.c: Revert.
10345         * arc-tdep.c: Revert.
10346         * arc-newlib-tdep.c: Revert.
10347         * annotate.h: Revert.
10348         * annotate.c: Revert.
10349         * amd64-windows-tdep.c: Revert.
10350         * amd64-windows-nat.c: Revert.
10351         * amd64-tdep.c: Revert.
10352         * amd64-sol2-tdep.c: Revert.
10353         * amd64-obsd-tdep.c: Revert.
10354         * amd64-obsd-nat.c: Revert.
10355         * amd64-nbsd-tdep.c: Revert.
10356         * amd64-nbsd-nat.c: Revert.
10357         * amd64-nat.c: Revert.
10358         * amd64-linux-tdep.c: Revert.
10359         * amd64-linux-nat.c: Revert.
10360         * amd64-fbsd-tdep.c: Revert.
10361         * amd64-fbsd-nat.c: Revert.
10362         * amd64-dicos-tdep.c: Revert.
10363         * amd64-darwin-tdep.c: Revert.
10364         * amd64-bsd-nat.c: Revert.
10365         * alpha-tdep.c: Revert.
10366         * alpha-obsd-tdep.c: Revert.
10367         * alpha-nbsd-tdep.c: Revert.
10368         * alpha-mdebug-tdep.c: Revert.
10369         * alpha-linux-tdep.c: Revert.
10370         * alpha-linux-nat.c: Revert.
10371         * alpha-bsd-tdep.c: Revert.
10372         * alpha-bsd-nat.c: Revert.
10373         * aix-thread.c: Revert.
10374         * agent.c: Revert.
10375         * addrmap.c: Revert.
10376         * ada-varobj.c: Revert.
10377         * ada-valprint.c: Revert.
10378         * ada-typeprint.c: Revert.
10379         * ada-tasks.c: Revert.
10380         * ada-lang.c: Revert.
10381         * aarch64-tdep.c: Revert.
10382         * aarch64-ravenscar-thread.c: Revert.
10383         * aarch64-newlib-tdep.c: Revert.
10384         * aarch64-linux-tdep.c: Revert.
10385         * aarch64-linux-nat.c: Revert.
10386         * aarch64-fbsd-tdep.c: Revert.
10387         * aarch64-fbsd-nat.c: Revert.
10388         * aarch32-linux-nat.c: Revert.
10389
10390 2019-04-05  Tom Tromey  <tom@tromey.com>
10391
10392         * ft32-tdep.c: Sort headers.
10393         * frv-tdep.c: Sort headers.
10394         * frv-linux-tdep.c: Sort headers.
10395         * frame.c: Sort headers.
10396         * frame-unwind.c: Sort headers.
10397         * frame-base.c: Sort headers.
10398         * fork-child.c: Sort headers.
10399         * findvar.c: Sort headers.
10400         * findcmd.c: Sort headers.
10401         * filesystem.c: Sort headers.
10402         * filename-seen-cache.h: Sort headers.
10403         * filename-seen-cache.c: Sort headers.
10404         * fbsd-tdep.c: Sort headers.
10405         * fbsd-nat.h: Sort headers.
10406         * fbsd-nat.c: Sort headers.
10407         * f-valprint.c: Sort headers.
10408         * f-typeprint.c: Sort headers.
10409         * f-lang.c: Sort headers.
10410         * extension.h: Sort headers.
10411         * extension.c: Sort headers.
10412         * extension-priv.h: Sort headers.
10413         * expprint.c: Sort headers.
10414         * exec.h: Sort headers.
10415         * exec.c: Sort headers.
10416         * exceptions.c: Sort headers.
10417         * event-top.c: Sort headers.
10418         * event-loop.c: Sort headers.
10419         * eval.c: Sort headers.
10420         * elfread.c: Sort headers.
10421         * dwarf2read.h: Sort headers.
10422         * dwarf2read.c: Sort headers.
10423         * dwarf2loc.c: Sort headers.
10424         * dwarf2expr.h: Sort headers.
10425         * dwarf2expr.c: Sort headers.
10426         * dwarf2-frame.c: Sort headers.
10427         * dwarf2-frame-tailcall.c: Sort headers.
10428         * dwarf-index-write.h: Sort headers.
10429         * dwarf-index-write.c: Sort headers.
10430         * dwarf-index-common.c: Sort headers.
10431         * dwarf-index-cache.h: Sort headers.
10432         * dwarf-index-cache.c: Sort headers.
10433         * dummy-frame.c: Sort headers.
10434         * dtrace-probe.c: Sort headers.
10435         * disasm.h: Sort headers.
10436         * disasm.c: Sort headers.
10437         * disasm-selftests.c: Sort headers.
10438         * dictionary.c: Sort headers.
10439         * dicos-tdep.c: Sort headers.
10440         * demangle.c: Sort headers.
10441         * dcache.h: Sort headers.
10442         * dcache.c: Sort headers.
10443         * darwin-nat.h: Sort headers.
10444         * darwin-nat.c: Sort headers.
10445         * darwin-nat-info.c: Sort headers.
10446         * d-valprint.c: Sort headers.
10447         * d-namespace.c: Sort headers.
10448         * d-lang.c: Sort headers.
10449         * ctf.c: Sort headers.
10450         * csky-tdep.c: Sort headers.
10451         * csky-linux-tdep.c: Sort headers.
10452         * cris-tdep.c: Sort headers.
10453         * cris-linux-tdep.c: Sort headers.
10454         * cp-valprint.c: Sort headers.
10455         * cp-support.c: Sort headers.
10456         * cp-namespace.c: Sort headers.
10457         * cp-abi.c: Sort headers.
10458         * corelow.c: Sort headers.
10459         * corefile.c: Sort headers.
10460         * continuations.c: Sort headers.
10461         * completer.h: Sort headers.
10462         * completer.c: Sort headers.
10463         * complaints.c: Sort headers.
10464         * coffread.c: Sort headers.
10465         * coff-pe-read.c: Sort headers.
10466         * cli-out.h: Sort headers.
10467         * cli-out.c: Sort headers.
10468         * charset.c: Sort headers.
10469         * c-varobj.c: Sort headers.
10470         * c-valprint.c: Sort headers.
10471         * c-typeprint.c: Sort headers.
10472         * c-lang.c: Sort headers.
10473         * buildsym.c: Sort headers.
10474         * buildsym-legacy.c: Sort headers.
10475         * build-id.h: Sort headers.
10476         * build-id.c: Sort headers.
10477         * btrace.c: Sort headers.
10478         * bsd-uthread.c: Sort headers.
10479         * breakpoint.h: Sort headers.
10480         * breakpoint.c: Sort headers.
10481         * break-catch-throw.c: Sort headers.
10482         * break-catch-syscall.c: Sort headers.
10483         * break-catch-sig.c: Sort headers.
10484         * blockframe.c: Sort headers.
10485         * block.c: Sort headers.
10486         * bfin-tdep.c: Sort headers.
10487         * bfin-linux-tdep.c: Sort headers.
10488         * bfd-target.c: Sort headers.
10489         * bcache.c: Sort headers.
10490         * ax-general.c: Sort headers.
10491         * ax-gdb.h: Sort headers.
10492         * ax-gdb.c: Sort headers.
10493         * avr-tdep.c: Sort headers.
10494         * auxv.c: Sort headers.
10495         * auto-load.c: Sort headers.
10496         * arm-wince-tdep.c: Sort headers.
10497         * arm-tdep.c: Sort headers.
10498         * arm-symbian-tdep.c: Sort headers.
10499         * arm-pikeos-tdep.c: Sort headers.
10500         * arm-obsd-tdep.c: Sort headers.
10501         * arm-nbsd-tdep.c: Sort headers.
10502         * arm-nbsd-nat.c: Sort headers.
10503         * arm-linux-tdep.c: Sort headers.
10504         * arm-linux-nat.c: Sort headers.
10505         * arm-fbsd-tdep.c: Sort headers.
10506         * arm-fbsd-nat.c: Sort headers.
10507         * arm-bsd-tdep.c: Sort headers.
10508         * arch-utils.c: Sort headers.
10509         * arc-tdep.c: Sort headers.
10510         * arc-newlib-tdep.c: Sort headers.
10511         * annotate.h: Sort headers.
10512         * annotate.c: Sort headers.
10513         * amd64-windows-tdep.c: Sort headers.
10514         * amd64-windows-nat.c: Sort headers.
10515         * amd64-tdep.c: Sort headers.
10516         * amd64-sol2-tdep.c: Sort headers.
10517         * amd64-obsd-tdep.c: Sort headers.
10518         * amd64-obsd-nat.c: Sort headers.
10519         * amd64-nbsd-tdep.c: Sort headers.
10520         * amd64-nbsd-nat.c: Sort headers.
10521         * amd64-nat.c: Sort headers.
10522         * amd64-linux-tdep.c: Sort headers.
10523         * amd64-linux-nat.c: Sort headers.
10524         * amd64-fbsd-tdep.c: Sort headers.
10525         * amd64-fbsd-nat.c: Sort headers.
10526         * amd64-dicos-tdep.c: Sort headers.
10527         * amd64-darwin-tdep.c: Sort headers.
10528         * amd64-bsd-nat.c: Sort headers.
10529         * alpha-tdep.c: Sort headers.
10530         * alpha-obsd-tdep.c: Sort headers.
10531         * alpha-nbsd-tdep.c: Sort headers.
10532         * alpha-mdebug-tdep.c: Sort headers.
10533         * alpha-linux-tdep.c: Sort headers.
10534         * alpha-linux-nat.c: Sort headers.
10535         * alpha-bsd-tdep.c: Sort headers.
10536         * alpha-bsd-nat.c: Sort headers.
10537         * aix-thread.c: Sort headers.
10538         * agent.c: Sort headers.
10539         * addrmap.c: Sort headers.
10540         * ada-varobj.c: Sort headers.
10541         * ada-valprint.c: Sort headers.
10542         * ada-typeprint.c: Sort headers.
10543         * ada-tasks.c: Sort headers.
10544         * ada-lang.c: Sort headers.
10545         * aarch64-tdep.c: Sort headers.
10546         * aarch64-ravenscar-thread.c: Sort headers.
10547         * aarch64-newlib-tdep.c: Sort headers.
10548         * aarch64-linux-tdep.c: Sort headers.
10549         * aarch64-linux-nat.c: Sort headers.
10550         * aarch64-fbsd-tdep.c: Sort headers.
10551         * aarch64-fbsd-nat.c: Sort headers.
10552         * aarch32-linux-nat.c: Sort headers.
10553
10554 2019-04-04  Tom Tromey  <tom@tromey.com>
10555
10556         * varobj.c (varobj_create): Update.
10557         * rust-exp.y (struct rust_parser) <update_innermost_block,
10558         lookup_symbol>: New methods.
10559         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10560         Rename.
10561         (rust_parser::rust_lookup_type)
10562         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10563         * printcmd.c (display_command, do_one_display): Update.
10564         * parser-defs.h (struct parser_state) <parser_state>: Add
10565         "tracker" parameter.
10566         (block_tracker): New member.
10567         (class innermost_block_tracker) <innermost_block_tracker>: Add
10568         "types" parameter.
10569         <reset>: Remove method.
10570         (innermost_block): Don't declare.
10571         (null_post_parser): Update.
10572         * parse.c (innermost_block): Remove global.
10573         (write_dollar_variable): Update.
10574         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10575         Remove "tracker_types" parameter.
10576         (parse_expression): Add "tracker" parameter.
10577         (parse_expression_for_completion): Update.
10578         (null_post_parser): Add "tracker" parameter.
10579         * p-exp.y: Update rules.
10580         * m2-exp.y: Update rules.
10581         * language.h (struct language_defn) <la_post_parser>: Add
10582         "tracker" parameter.
10583         * go-exp.y: Update rules.
10584         * f-exp.y: Update rules.
10585         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10586         parameter.
10587         * d-exp.y: Update rules.
10588         * c-exp.y: Update rules.
10589         * breakpoint.c (set_breakpoint_condition): Create an
10590         innermost_block_tracker.
10591         (watch_command_1): Likewise.
10592         * ada-lang.c (resolve): Add "tracker" parameter.
10593         (resolve_subexp): Likewise.
10594         * ada-exp.y (write_var_from_sym): Update.
10595
10596 2019-04-04  Tom Tromey  <tom@tromey.com>
10597
10598         * type-stack.h: New file.
10599         * type-stack.c: New file.
10600         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10601         type-stack.h.
10602         (insert_into_type_stack, insert_type, push_type, push_type_int)
10603         (insert_type_address_space, pop_type, pop_type_int)
10604         (pop_typelist, pop_type_stack, append_type_stack)
10605         (push_type_stack, get_type_stack, push_typelist)
10606         (follow_type_instance_flags, follow_types): Don't declare.
10607         * parse.c (type_stack): Remove global.
10608         (parse_exp_in_context): Update.
10609         (insert_into_type_stack, insert_type, push_type, push_type_int)
10610         (insert_type_address_space, pop_type, pop_type_int)
10611         (pop_typelist, pop_type_stack, append_type_stack)
10612         (push_type_stack, get_type_stack, push_typelist)
10613         (follow_type_instance_flags, follow_types): Remove (moved to
10614         type-stack.c).
10615         * f-exp.y (type_stack): New global.
10616         Update rules.
10617         (push_kind_type, f_parse): Update.
10618         * d-exp.y (type_stack): New global.
10619         Update rules.
10620         (d_parse): Update.
10621         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10622         Update rules.
10623         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10624         (HFILES_NO_SRCDIR): Add type-stack.h.
10625
10626 2019-04-04  Tom Tromey  <tom@tromey.com>
10627
10628         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10629         (rust_parser::convert_ast_to_expression, rust_parse)
10630         (rust_lex_test_completion, rust_lex_tests): Update.
10631         * parser-defs.h (struct expr_completion_state): New.
10632         (struct parser_state) <parser_state>: Add completion parameter.
10633         <mark_struct_expression, mark_completion_tag>: New methods.
10634         <parse_completion, m_completion_state>: New members.
10635         (prefixify_expression, null_post_parser): Update.
10636         (mark_struct_expression, mark_completion_tag): Don't declare.
10637         * parse.c (parse_completion, expout_last_struct)
10638         (expout_tag_completion_type, expout_completion_name): Remove
10639         globals.
10640         (parser_state::mark_struct_expression)
10641         (parser_state::mark_completion_tag): Now methods.
10642         (prefixify_expression): Add last_struct parameter.
10643         (prefixify_subexp): Likewise.
10644         (parse_exp_1): Update.
10645         (parse_exp_in_context): Add cstate parameter.  Update.
10646         (parse_expression_for_completion): Create an
10647         expr_completion_state.
10648         (null_post_parser): Add "completion" parameter.
10649         * p-exp.y: Update rules.
10650         (yylex): Update.
10651         * language.h (struct language_defn) <la_post_parser>: Add
10652         "completing" parameter.
10653         * go-exp.y: Update rules.
10654         (lex_one_token): Update.
10655         * expression.h (parse_completion): Don't declare.
10656         * d-exp.y: Update rules.
10657         (lex_one_token): Update rules.
10658         * c-exp.y: Update rules.
10659         (lex_one_token): Update.
10660         * ada-lang.c (resolve): Add "parse_completion" parameter.
10661         (resolve_subexp): Likewise.
10662         (ada_resolve_function): Likewise.
10663
10664 2019-04-04  Tom Tromey  <tom@tromey.com>
10665
10666         * parser-defs.h (struct parser_state) <start_arglist,
10667         end_arglist>: New methods.
10668         <arglist_len, m_funcall_chain>: New members.
10669         (arglist_len, start_arglist, end_arglist): Don't declare.
10670         * parse.c (arglist_len, funcall_chain): Remove global.
10671         (start_arglist, end_arglist): Remove functions.
10672         (parse_exp_in_context): Update.
10673         * p-exp.y: Update rules.
10674         * m2-exp.y: Update rules.
10675         * go-exp.y: Update rules.
10676         * f-exp.y: Update rules.
10677         * d-exp.y: Update rules.
10678         * c-exp.y: Update rules.
10679
10680 2019-04-04  Tom Tromey  <tom@tromey.com>
10681
10682         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10683         lex_operator, push_back>: New methods.
10684         Update all rules.
10685         (rust_parser::lex_hex, lex_escape): Rename and update.
10686         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10687         (rust_parser::lex_operator): Rename and update.
10688         (rust_parser::lex_number, rustyylex, rustyyerror)
10689         (rust_lex_test_init, rust_lex_test_sequence)
10690         (rust_lex_test_push_back, rust_lex_tests): Update.
10691         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10692         parameter.
10693         <lexptr, prev_lexptr>: New members.
10694         (lexptr, prev_lexptr): Don't declare.
10695         * parse.c (lexptr, prev_lexptr): Remove globals.
10696         (parse_exp_in_context): Update.
10697         * p-exp.y (yylex, yyerror): Update.
10698         * m2-exp.y (parse_number, yylex, yyerror): Update.
10699         * go-exp.y (lex_one_token, yyerror): Update.
10700         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10701         * d-exp.y (lex_one_token, yyerror): Update.
10702         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10703         (lex_one_token, yyerror): Update.
10704         * ada-lex.l (YY_INPUT): Update.
10705         (rewind_to_char): Update.
10706         * ada-exp.y (yyerror): Update.
10707
10708 2019-04-04  Tom Tromey  <tom@tromey.com>
10709
10710         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10711         * parser-defs.h (struct parser_state) <parser_state>: Add new
10712         parameter.
10713         <comma_terminates>: New member.
10714         (comma_terminates): Don't declare global.
10715         * parse.c (comma_terminates): Remove global.
10716         (parse_exp_in_context): Update.
10717         * p-exp.y (yylex): Update.
10718         * m2-exp.y (yylex): Update.
10719         * go-exp.y (lex_one_token): Update.
10720         * f-exp.y (yylex): Update.
10721         * d-exp.y (lex_one_token): Update.
10722         * c-exp.y (lex_one_token): Update.
10723         * ada-lex.l: Update.
10724
10725 2019-04-04  Tom Tromey  <tom@tromey.com>
10726
10727         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10728         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10729         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10730         * parser-defs.h (paren_depth): Don't declare.
10731         * parse.c (paren_depth): Remove global.
10732         (parse_exp_in_context): Update.
10733         * p-exp.y (paren_depth): New global.
10734         (pascal_parse): Initialize it.
10735         * m2-exp.y (paren_depth): New global.
10736         (m2_parse): Initialize it.
10737         * go-exp.y (paren_depth): New global.
10738         (go_parse): Initialize it.
10739         * f-exp.y (paren_depth): New global.
10740         (f_parse): Initialize it.
10741         * d-exp.y (paren_depth): New global.
10742         (d_parse): Initialize it.
10743         * c-exp.y (paren_depth): New global.
10744         (c_parse): Initialize it.
10745         * ada-lex.l (paren_depth): New global.
10746         (lexer_init): Initialize it.
10747
10748 2019-04-04  Tom Tromey  <tom@tromey.com>
10749
10750         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10751         (rust_parser::convert_ast_to_type)
10752         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10753         * parser-defs.h (struct parser_state) <parser_state>: Add
10754         parameters.  Initialize new members.
10755         <expression_context_block, expression_context_pc>: New members.
10756         * parse.c (expression_context_block, expression_context_pc):
10757         Remove globals.
10758         (parse_exp_in_context): Update.
10759         * p-exp.y: Update all rules.
10760         (yylex): Update.
10761         * m2-exp.y: Update all rules.
10762         (yylex): Update.
10763         * go-exp.y (yylex): Update.
10764         * f-exp.y (yylex): Update.
10765         * d-exp.y: Update all rules.
10766         (yylex): Update.
10767         * c-exp.y: Update all rules.
10768         (lex_one_token, classify_name, yylex, c_parse): Update.
10769         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10770
10771 2019-04-04  Tom Tromey  <tom@tromey.com>
10772
10773         * gdbarch.h, gdbarch.c: Rebuild.
10774         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10775         * stap-probe.h:
10776         (struct stap_parse_info): Replace "parser_state" with
10777         "expr_builder".
10778         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10779         (parser_state): New class.
10780         * parse.c (expr_builder): Rename.
10781         (expr_builder::release): Rename.
10782         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10783         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10784         (write_exp_elt_longcst, write_exp_elt_floatcst)
10785         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10786         (write_exp_string_vector, write_exp_bitstring)
10787         (write_exp_msymbol, mark_struct_expression)
10788         (write_dollar_variable)
10789         (insert_type_address_space, increase_expout_size): Replace
10790         "parser_state" with "expr_builder".
10791         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10792         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10793         "parser_state" with "expr_builder".
10794
10795 2019-04-04  Tom Tromey  <tom@tromey.com>
10796
10797         * rust-exp.y: Replace "parse_language" with method call.
10798         * p-exp.y:
10799         (yylex): Replace "parse_language" with method call.
10800         * m2-exp.y:
10801         (yylex): Replace "parse_language" with method call.
10802         * go-exp.y (classify_name): Replace "parse_language" with method
10803         call.
10804         * f-exp.y (yylex): Replace "parse_language" with method call.
10805         * d-exp.y (lex_one_token): Replace "parse_language" with method
10806         call.
10807         * c-exp.y:
10808         (lex_one_token, classify_name, yylex): Replace "parse_language"
10809         with method call.
10810         * ada-exp.y (find_primitive_type, type_char)
10811         (type_system_address): Replace "parse_language" with method call.
10812
10813 2019-04-04  Tom Tromey  <tom@tromey.com>
10814
10815         * rust-exp.y: Replace "parse_gdbarch" with method call.
10816         * parse.c (write_dollar_variable, insert_type_address_space):
10817         Replace "parse_gdbarch" with method call.
10818         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10819         call.
10820         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10821         call.
10822         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10823         "parse_gdbarch" with method call.
10824         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10825         with method call.
10826         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10827         "parse_gdbarch" with method call.
10828         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10829         "parse_gdbarch" with method call.
10830         * c-exp.y (parse_type, parse_number, classify_name): Replace
10831         "parse_gdbarch" with method call.
10832         * ada-lex.l: Replace "parse_gdbarch" with method call.
10833         * ada-exp.y (parse_type, find_primitive_type, type_char)
10834         (type_system_address): Replace "parse_gdbarch" with method call.
10835
10836 2019-04-04  Tom Tromey  <tom@tromey.com>
10837
10838         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10839         * stap-probe.c (stap_parse_argument): Update.
10840         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10841         initial_size parameter.
10842         * rust-exp.y (rust_lex_tests): Update.
10843         * parse.c (parser_state): Update.
10844         (parse_exp_in_context): Update.
10845         * parser-defs.h (struct parser_state) <parser_state>: Remove
10846         "initial_size" parameter.
10847
10848 2019-04-04  Tom Tromey  <tom@tromey.com>
10849
10850         * parser-defs.h (increase_expout_size): Don't declare.
10851         * parse.c (increase_expout_size): Now static.
10852
10853 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10854
10855         * gnu-nat.c (gnu_nat_target::wait): Fix
10856         target_waitstatus_to_string call.
10857
10858 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10859
10860         * eval.c (evaluate_subexp_standard): Handle internal functions
10861         during Fortran function call handling.
10862
10863 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10864
10865         * NEWS: Mention new internal functions.
10866         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10867         (read_base_type): Use dwarf2_init_complex_target_type.
10868         * value.c (creal_internal_fn): New function.
10869         (cimag_internal_fn): New function.
10870         (_initialize_values): Register new internal functions.
10871
10872 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10873
10874         * infrun.c (stop_all_threads): If debug_infrun, always
10875         trace the wait status after wait_one, using
10876         target_waitstatus_to_string and target_pid_to_str.
10877         (handle_inferior_event): Replace various trace of
10878         wait status kind by a single trace.
10879         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10880         wait status kind image by target_waitstatus_to_string.
10881         * target/waitstatus.c (target_waitstatus_to_string): Fix
10882         obsolete comment.
10883
10884 2019-04-01  Tom Tromey  <tromey@adacore.com>
10885
10886         PR symtab/23331:
10887         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10888
10889 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10890             Pedro Alves  <palves@redhat.com>
10891
10892         * top.c (quit_force): Call 'finalize_values'.
10893         * value.c (finalize_values): New function.
10894         * value.h (finalize_values): Declare.
10895
10896 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10897
10898         * NEWS: Announce $_gdb_major and $_gdb_minor.
10899
10900         * top.c (init_gdb_version_vars): New function.
10901         (gdb_init): Call init_gdb_version_vars.
10902
10903 2019-03-29  Tom Tromey  <tromey@adacore.com>
10904
10905         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10906         help text.  Remove dead code.
10907
10908 2019-03-29  Keith Seitz  <keiths@redhat.com>
10909
10910         From Siddhesh Poyarekar:
10911         * f-lang.h (f77_get_upperbound): Return LONGEST.
10912         (f77_get_lowerbound): Likewise.
10913         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10914         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10915         print them.
10916         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10917         plongest to format print it.
10918         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10919         (f77_get_upperbound): Likewise.
10920         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10921         LOWER_BOUND to LONGEST.
10922         (f77_create_arrayprint_offset_tbl): Likewise.
10923
10924 2019-03-29  Keith Seitz  <keiths@redhat.com>
10925
10926         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10927         %s/pulongest for TYPE_LENGTH instead of %d in format
10928         strings.
10929         * ada-typerint.c (ada_print_type): Likewise.
10930         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10931         * compile/compile-c-support.c (generate_register_struct): Likewise.
10932         * gdbtypes.c (recursive_dump_type): Likewise.
10933         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10934         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10935         instead of %d in format strings.
10936         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10937         to std::min to ULONGEST.
10938         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10939         instead of %d in format strings.
10940         * tracepoint.c (info_scope_command): Likewise.
10941         * typeprint.c (print_offset_data::update)
10942         (print_offset_data::finish): Likewise.
10943         * xtensa-tdep.c (xtensa_store_return_value)
10944         (xtensa_push_dummy_call): Likewise.
10945
10946 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10947
10948         * windows-nat.c (display_selector): Fixed format specifications
10949         for 64-bit Cygwin.
10950
10951 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10952
10953         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10954
10955 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10956
10957         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10958         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10959         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10960         (nios2_linux_init_abi): Install it.
10961
10962 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10963
10964         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10965
10966 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10967
10968         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10969
10970 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10971             Tom Tromey  <tromey@adacore.com>
10972
10973         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10974
10975 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10976
10977         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10978         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10979         method to compute the bounds of range types. Also print "[evaluated]"
10980         if the bounds' values come from a dynamic evaluation.
10981
10982 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10983
10984         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10985         whitespace when pretty printing is on.
10986
10987 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10988
10989         * ppc-linux-nat.c: Add include.
10990
10991 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10992
10993         * NEWS: Mention AArch64 Pointer Authentication.
10994
10995 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10996
10997         * arm-linux-nat.c: Add include.
10998
10999 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11000
11001         * source-cache.c (source_cache::get_source_lines): Re-read
11002         fullname after calling open_source_file.
11003
11004 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11005
11006         * NEWS: Mention TLS support for FreeBSD.
11007
11008 2019-03-25  Tom Tromey  <tromey@adacore.com>
11009
11010         * minsyms.c (BUNCH_SIZE): Update comment.
11011         (~minimal_symbol_reader): Remove old comment.
11012         (compact_minimal_symbols): Update comment.
11013         (minimal_symbol_reader::install): Remove old comment.  Update
11014         other comments.
11015
11016 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11017
11018         * s390-linux-nat.c: Add include.
11019
11020 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11021
11022         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11023         Call linux_get_hwcap.
11024         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11025         Likewise.
11026         (aarch64_linux_get_hwcap): Remove function.
11027         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11028         declaration.
11029         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11030         linux_get_hwcap.
11031         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11032         * linux-tdep.c (linux_get_hwcap): Add function.
11033         (linux_get_hwcap2): Likewise.
11034         * linux-tdep.h (linux_get_hwcap): Add declaration.
11035         (linux_get_hwcap2): Likewise.
11036         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11037         (ppc_linux_get_hwcap2): Likewise.
11038         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11039         linux_get_hwcap.
11040         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11041         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11042         (ppc_linux_nat_target::read_description): Likewise.
11043         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11044         * s390-linux-nat.c: Likewise.
11045         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11046
11047 2019-03-24  Tom Tromey  <tom@tromey.com>
11048
11049         * ada-lang.c (standard_lookup): Simplify initialization.
11050         (ada_lookup_symbol_nonlocal): Simplify return.
11051         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11052         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11053         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11054         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11055         initialization.
11056         * solib.c (solib_global_lookup): Simplify.
11057         * symtab.c (null_block_symbol): Remove.
11058         (symbol_cache_lookup): Simplify returns.
11059         (lookup_language_this): Simplify returns.
11060         (lookup_symbol_aux): Simplify return.
11061         (lookup_local_symbol): Simplify returns.
11062         (lookup_global_symbol_from_objfile): Simplify return.
11063         (lookup_symbol_in_objfile_symtabs)
11064         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11065         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11066         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11067         * cp-namespace.c (cp_lookup_bare_symbol)
11068         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11069         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11070         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11071         (cp_lookup_symbol_via_imports): Simplify initialization.
11072         (find_symbol_in_baseclass): Likewise.
11073         * symtab.h (null_block_symbol): Remove.
11074         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11075         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11076         (d_lookup_symbol_module): Likewise.
11077         (find_symbol_in_baseclass): Simplify initialization.
11078
11079 2019-03-24  Tom Tromey  <tom@tromey.com>
11080
11081         * expression.h: Don't include symtab.h.
11082         (struct block): Forward declare.
11083
11084 2019-03-24  Tom Tromey  <tom@tromey.com>
11085
11086         * c-exp.y (typebase): Remove casts.
11087         * gdbtypes.c (lookup_unsigned_typename, )
11088         (lookup_signed_typename): Remove cast.
11089         * eval.c (parse_to_comma_and_eval): Remove cast.
11090         * parse.c (write_dollar_variable): Remove cast.
11091         * block.h (struct block) <superblock>: Now const.
11092         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11093         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11094         (map_block): Make "block" const.
11095         * symfile.h (struct quick_symbol_functions)
11096         <map_matching_symbols>: Constify block argument to "callback".
11097         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11098         const.
11099         (find_pc_sect_compunit_symtab): Make "b" const.
11100         (find_symbol_at_address): Likewise.
11101         (search_symbols): Likewise.
11102         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11103         (dw2_debug_names_lookup_symbol): Likewise.
11104         (dw2_map_matching_symbols): Update.
11105         * p-valprint.c (pascal_val_print): Remove "block".
11106         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11107         (aux_add_nonlocal_symbols): Make "block" const.
11108         (resolve_subexp): Remove cast.
11109         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11110         const.
11111         (iterate_over_file_blocks): Likewise.
11112         * f-exp.y (%union) <bval>: Remove.
11113         * coffread.c (patch_opaque_types): Make "b" const.
11114         * spu-tdep.c (spu_catch_start): Make "block" const.
11115         * c-valprint.c (print_unpacked_pointer): Remove "block".
11116         * symmisc.c (dump_symtab_1): Make "b" const.
11117         (block_depth): Make "block" const.
11118         * d-exp.y (%union) <bval>: Remove.
11119         * cp-support.h (cp_lookup_rtti_type): Update.
11120         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11121         * psymtab.c (psym_lookup_symbol): Make "block" const.
11122         (maintenance_check_psymtabs): Make "b" const.
11123         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11124         (enumerate_locals, enumerate_args): Update.
11125         * python/py-symtab.c (stpy_global_block): Make "block" const.
11126         (stpy_static_block): Likewise.
11127         * inline-frame.c (block_starting_point_at): Make "new_block"
11128         const.
11129         * block.c (find_block_in_blockvector): Make return type const.
11130         (blockvector_for_pc_sect): Make "b" const.
11131         (find_block_in_blockvector): Make "b" const.
11132
11133 2019-03-23  Tom Tromey  <tom@tromey.com>
11134
11135         * varobj.c (varobj_create): Update.
11136         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11137         * printcmd.c (display_command, do_one_display): Don't reset
11138         innermost_block.
11139         * parser-defs.h (enum innermost_block_tracker_type): Move to
11140         expression.h.
11141         (innermost_block): Update comment.
11142         * parse.c (parse_exp_1): Add tracker_types parameter.
11143         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11144         tracker_types parameter.  Reset innermost_block.
11145         (parse_exp_in_context): Remove.
11146         (parse_expression_for_completion): Update.
11147         * objfiles.c (~objfile): Don't reset expression_context_block or
11148         innermost_block.
11149         * expression.h (enum innermost_block_tracker_type): Move from
11150         parser-defs.h.
11151         (parse_exp_1): Add tracker_types parameter.
11152         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11153         reset innermost_block.
11154
11155 2019-03-23  Tom Tromey  <tom@tromey.com>
11156
11157         * objfiles.h: Include bcache.h.
11158
11159 2019-03-23  Tom Tromey  <tom@tromey.com>
11160
11161         * linespec.c (get_current_search_block): Use
11162         scoped_restore_current_language.
11163         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11164
11165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11166             Jiong Wang  <jiong.wang@arm.com>
11167
11168         * aarch64-linux-tdep.c
11169         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11170         section.
11171         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11172
11173 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11174             Jiong Wang  <jiong.wang@arm.com>
11175
11176         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11177         instructions.
11178         (aarch64_analyze_prologue_test): Add PACIASP test.
11179         (aarch64_prologue_prev_register): Unmask PC value.
11180
11181 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11182             Jiong Wang  <jiong.wang@arm.com>
11183
11184         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11185         (aarch64_dwarf2_prev_register): Unmask PC value.
11186         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11187         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11188         DW_CFA_AARCH64_negate_ra_state.
11189         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11190
11191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11192             Jiong Wang  <jiong.wang@arm.com>
11193
11194         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11195         registers.
11196         (aarch64_pseudo_register_name): Likewise.
11197         (aarch64_pseudo_register_type): Likewise.
11198         (aarch64_pseudo_register_reggroup_p): Likewise.
11199         (aarch64_gdbarch_init): Add pauth registers.
11200         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11201         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11202         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11203         (struct gdbarch_tdep): Add regnum for ra_state.
11204
11205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11206             Jiong Wang  <jiong.wang@arm.com>
11207
11208         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11209
11210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11211             Jiong Wang  <jiong.wang@arm.com>
11212
11213         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11214         function.
11215         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11216         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11217         (aarch64_gdbarch_init): Add puth registers.
11218         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11219         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11220         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11221
11222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11223             Jiong Wang  <jiong.wang@arm.com>
11224
11225         * aarch64-linux-nat.c
11226         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11227         * aarch64-linux-tdep.c
11228         (aarch64_linux_core_read_description): Likewise.
11229         (aarch64_linux_get_hwcap): New function.
11230         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11231         (aarch64_linux_get_hwcap): New declaration.
11232
11233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11234             Jiong Wang  <jiong.wang@arm.com>
11235
11236         * aarch64-linux-nat.c
11237         (aarch64_linux_nat_target::read_description): Add pauth param.
11238         * aarch64-linux-tdep.c
11239         (aarch64_linux_core_read_description): Likewise.
11240         * aarch64-tdep.c (struct target_desc): Add in pauth.
11241         (aarch64_read_description): Add pauth param.
11242         (aarch64_gdbarch_init): Likewise.
11243         * aarch64-tdep.h (aarch64_read_description): Likewise.
11244         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11245         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11246         * features/Makefile: Add new files.
11247         * features/aarch64-pauth.c: New file.
11248         * features/aarch64-pauth.xml: New file.
11249
11250 2019-03-20  Tom Tromey  <tromey@adacore.com>
11251
11252         * infrun.c (handle_inferior_event): Rename from
11253         handle_inferior_event_1.  Create a scoped_value_mark.
11254         (handle_inferior_event): Remove.
11255
11256 2019-03-19  Tom Tromey  <tromey@adacore.com>
11257
11258         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11259         * infrun.h (print_stop_event): Add "displays" parameter.
11260         * infrun.c (print_stop_event): Add "displays" parameter.
11261
11262 2019-03-19  Pedro Alves  <palves@redhat.com>
11263
11264         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11265         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11266         to -1.  Fix TABs vs spaces.
11267         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11268         * tui/tui-out.h (tui_ui_out) Add intro comments.
11269         <m_line, m_start_of_line>: In-class initialize, and add describing
11270         comment.
11271
11272 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11273
11274         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11275         variable names.
11276         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11277
11278 2019-03-18  Pedro Alves  <palves@redhat.com>
11279             Eli Zaretskii <eliz@gnu.org>
11280
11281         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11282         m_line and m_start_of_line.
11283
11284 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11285
11286         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11287         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11288         it returns a newline.  This fixes a regression in TU mode, whereby
11289         the next line is output on the same screen line as the user input.
11290
11291 2019-03-18  Tom Tromey  <tromey@adacore.com>
11292
11293         * minsyms.c (minimal_symbol_reader::install): Remove call to
11294         obstack_blank.
11295
11296 2019-03-18  Pedro Alves  <palves@redhat.com>
11297
11298         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11299         New globals.
11300         (apply_style): New, factored out from ...
11301         (apply_ansi_escape): ... this.  Handle reverse video mode.
11302         (tui_set_reverse_mode): New function.
11303         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11304         * tui/tui-winsource.c (tui_show_source_line): Use
11305         tui_set_reverse_mode instead of setting A_STANDOUT.
11306         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11307         New setter methods.
11308
11309 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11310
11311         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11312         Handle tabs.
11313
11314 2019-03-18  Tom Tromey  <tromey@adacore.com>
11315
11316         * ada-lang.c (empty_array): Add "high" parameter.
11317         (ada_evaluate_subexp): Update.
11318
11319 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11320
11321         * unittests/string_view-selftests.c: Define
11322         _initialize_string_view_selftests unconditionally.
11323
11324 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11325
11326         PR gdb/24350
11327         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11328
11329 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11330
11331         PR gdb/24351
11332         * windows-nat.c (display_selector): Fix format specifiers.
11333
11334 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11335
11336         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11337         tui_refill_source_window instead of tui_refresh_win, to update the
11338         current execution line.  This fixes redisplay of the current line
11339         when stepping through the code with "next" or "step".
11340
11341 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11342
11343         * source-cache.c (source_cache::get_source_lines): Call
11344         find_source_lines to initialize s->nlines.  This fixes vertical
11345         scrolling of TUI source window when the DOWN arrow is pressed.
11346
11347 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11348
11349         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11350         linux-thread-db.c (_initialize_thread_db): Likewise.
11351
11352 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11353
11354         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11355         wclrtoeol in tui_show_source_line".  This reverts changes made in
11356         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11357
11358 2019-03-15  Tom Tromey  <tom@tromey.com>
11359
11360         * symtab.h (struct minimal_symbol): Derive from
11361         general_symbol_info.
11362         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11363         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11364         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11365         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11366         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11367         (MSYMBOL_SEARCH_NAME): Update.
11368         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11369         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11370         * minsyms.c (minimal_symbol_reader::record_full): Update.
11371
11372 2019-03-15  Tom Tromey  <tom@tromey.com>
11373
11374         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11375
11376 2019-03-15  Tom Tromey  <tom@tromey.com>
11377
11378         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11379         unique_xmalloc_ptr.
11380         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11381         Update.
11382         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11383         (build_minimal_symbol_hash_tables)
11384         (minimal_symbol_reader::install): Update.
11385
11386 2019-03-15  Tom Tromey  <tom@tromey.com>
11387
11388         * symtab.c (create_demangled_names_hash): Update.
11389         (symbol_set_names): Update.
11390         * objfiles.h (struct objfile_per_bfd_storage)
11391         <demangled_names_hash>: Now an htab_up.
11392         * objfiles.c (objfile_per_bfd_storage): Simplify.
11393
11394 2019-03-15  Tom Tromey  <tom@tromey.com>
11395
11396         * objfiles.h (struct objfile_per_bfd_storage): Declare
11397         destructor.
11398         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11399         New.
11400         (get_objfile_bfd_data): Use new.  Don't initialize
11401         language_of_main.
11402         (free_objfile_per_bfd_storage): Remove.
11403         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11404
11405 2019-03-15  Tom Tromey  <tom@tromey.com>
11406
11407         * symfile.c (reread_symbols): Update.
11408         * objfiles.c (objfile::objfile): Update.
11409         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11410         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11411         comment.
11412         (minimal_symbol_reader::install): Update.
11413         (terminate_minimal_symbol_table): Remove.
11414         * jit.c (jit_object_close_impl): Update.
11415
11416 2019-03-15  Tom Tromey  <tom@tromey.com>
11417
11418         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11419         initializations.
11420
11421 2019-03-15  Tom Tromey  <tom@tromey.com>
11422
11423         * objfiles.h (struct objfile_per_bfd_storage)
11424         <demangled_hash_languages>: Now a bitset.
11425         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11426         (lookup_minimal_symbol): Update.
11427
11428 2019-03-15  Tom Tromey  <tom@tromey.com>
11429
11430         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11431         Don't return the symbol.
11432         * coffread.c (record_minimal_symbol): Use record_full.
11433
11434 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11435
11436         The MS-Windows port of ncurses fails to switch to a color pair if
11437         one or both of the colors are the implicit default colors.  This
11438         change records the default colors when TUI is initialized, and
11439         then specifies them explicitly when a color pair uses the default
11440         colors.  This allows color styling in TUI mode on MS-Windows.
11441
11442         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11443         ncurses_norm_attr.
11444         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11445         colors in ncurses_norm_attr.
11446         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11447         "none", replace it with the default color recorded in
11448         ncurses_norm_attr.
11449
11450 2019-03-14  Tom Tromey  <tromey@adacore.com>
11451
11452         * source-cache.h (class source_cache) <get_source_lines>: Return
11453         std::string.
11454         * source-cache.c (source_cache::extract_lines): Handle case where
11455         first_pos==npos.  Return std::string.
11456         (source_cache::get_source_lines): Update.
11457
11458 2019-03-14  Tom Tromey  <tromey@adacore.com>
11459
11460         * NEWS: Add item for "style sources" commands.
11461         * source-cache.c (source_cache::get_source_lines): Check
11462         source_styling.
11463         * cli/cli-style.c (source_styling): New global.
11464         (_initialize_cli_style): Add "style sources" commands.
11465         (show_style_sources): New function.
11466         * cli/cli-style.h (source_styling): Declare.
11467
11468 2019-03-14  Pedro Alves  <palves@redhat.com>
11469             Tom Tromey  <tromey@adacore.com>
11470
11471         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11472         * tui/tui-winsource.c (tui_refill_source_window): New function,
11473         from...
11474         (tui_horizontal_source_scroll): ... here.  Move some logic.
11475         * cli/cli-style.c (set_style_enabled): Notify new observable.
11476         * tui/tui-hooks.c (tui_redisplay_source): New function.
11477         (tui_attach_detach_observers): Attach or detach
11478         tui_redisplay_source.
11479         * observable.h (source_styling_changed): New observable.
11480         * observable.c: Define source_styling_changed observable.
11481
11482 2019-03-13  Tom Tromey  <tromey@adacore.com>
11483
11484         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11485         (i386_gnu_nat_target::store_registers): Update.
11486         * target-debug.h (target_debug_print_std_string): New macro.
11487         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11488         * windows-tdep.c (display_one_tib): Update.
11489         * tui/tui-stack.c (tui_make_status_line): Update.
11490         * top.c (print_inferior_quit_action): Update.
11491         * thread.c (thr_try_catch_cmd): Update.
11492         (add_thread_with_info): Update.
11493         (thread_target_id_str): Update.
11494         (thr_try_catch_cmd): Update.
11495         (thread_command): Update.
11496         (thread_find_command): Update.
11497         * record-btrace.c (record_btrace_target::info_record)
11498         (record_btrace_resume_thread, record_btrace_target::resume)
11499         (record_btrace_cancel_resume, record_btrace_step_thread)
11500         (record_btrace_target::wait, record_btrace_target::wait)
11501         (record_btrace_target::wait, record_btrace_target::stop): Update.
11502         * progspace.c (print_program_space): Update.
11503         * process-stratum-target.c
11504         (process_stratum_target::thread_address_space): Update.
11505         * linux-fork.c (linux_fork_mourn_inferior)
11506         (detach_checkpoint_command, info_checkpoints_command)
11507         (linux_fork_context): Update.
11508         (linux_fork_detach): Update.
11509         (class scoped_switch_fork_info): Update.
11510         (delete_checkpoint_command): Update.
11511         * infrun.c (follow_fork_inferior): Update.
11512         (follow_fork_inferior): Update.
11513         (proceed_after_vfork_done): Update.
11514         (handle_vfork_child_exec_or_exit): Update.
11515         (follow_exec): Update.
11516         (displaced_step_prepare_throw): Update.
11517         (displaced_step_restore): Update.
11518         (start_step_over): Update.
11519         (resume_1): Update.
11520         (clear_proceed_status_thread): Update.
11521         (proceed): Update.
11522         (print_target_wait_results): Update.
11523         (do_target_wait): Update.
11524         (context_switch): Update.
11525         (stop_all_threads): Update.
11526         (restart_threads): Update.
11527         (finish_step_over): Update.
11528         (handle_signal_stop): Update.
11529         (switch_back_to_stepped_thread): Update.
11530         (keep_going_pass_signal): Update.
11531         (print_exited_reason): Update.
11532         (normal_stop): Update.
11533         * inferior.c (inferior_pid_to_str): Change return type.
11534         (print_selected_inferior): Update.
11535         (add_inferior): Update.
11536         (detach_inferior): Update.
11537         * dummy-frame.c (fprint_dummy_frames): Update.
11538         * dcache.c (dcache_info_1): Update.
11539         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11540         (btrace_fetch, btrace_clear): Update.
11541         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11542         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11543         type.
11544         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11545         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11546         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11547         * gdbarch.c, gdbarch.h: Rebuild.
11548         * gdbarch.sh (core_pid_to_str): Change return type.
11549         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11550         return type.
11551         (windows_nat_target::pid_to_str): Change return type.
11552         (windows_delete_thread): Update.
11553         (windows_nat_target::attach): Update.
11554         (windows_nat_target::files_info): Update.
11555         * target-delegates.c: Rebuild.
11556         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11557         return type.
11558         (sol_thread_target::pid_to_str): Change return type.
11559         * remote.c (class remote_target) <pid_to_str>: Change return
11560         type.
11561         (remote_target::pid_to_str): Change return type.
11562         (extended_remote_target::attach, remote_target::remote_stop_ns)
11563         (remote_target::remote_notif_remove_queued_reply)
11564         (remote_target::push_stop_reply, remote_target::disable_btrace):
11565         Update.
11566         (extended_remote_target::attach): Update.
11567         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11568         type.
11569         (gdbsim_target::pid_to_str): Change return type.
11570         * ravenscar-thread.c (struct ravenscar_thread_target)
11571         <pid_to_str>: Change return type.
11572         (ravenscar_thread_target::pid_to_str): Change return type.
11573         * procfs.c (class procfs_target) <pid_to_str>: Change return
11574         type.
11575         (procfs_target::pid_to_str): Change return type.
11576         (procfs_target::attach): Update.
11577         (procfs_target::detach): Update.
11578         (procfs_target::fetch_registers): Update.
11579         (procfs_target::store_registers): Update.
11580         (procfs_target::wait): Update.
11581         (procfs_target::files_info): Update.
11582         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11583         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11584         return type.
11585         (nto_procfs_target::pid_to_str): Change return type.
11586         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11587         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11588         return type.
11589         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11590         (exit_lwp): Update.
11591         (attach_proc_task_lwp_callback, get_detach_signal)
11592         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11593         (linux_nat_target::resume, wait_lwp, stop_callback)
11594         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11595         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11596         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11597         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11598         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11599         type.
11600         (inf_ptrace_target::attach): Update.
11601         (inf_ptrace_target::files_info): Update.
11602         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11603         type.
11604         (go32_nat_target::pid_to_str): Change return type.
11605         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11606         (gnu_nat_target::wait): Update.
11607         (gnu_nat_target::wait): Update.
11608         (gnu_nat_target::resume): Update.
11609         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11610         (fbsd_nat_target::wait): Update.
11611         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11612         type.
11613         (darwin_nat_target::attach): Update.
11614         * corelow.c (class core_target) <pid_to_str>: Change return type.
11615         (core_target::pid_to_str): Change return type.
11616         * target.c (normal_pid_to_str): Change return type.
11617         (default_pid_to_str): Likewise.
11618         (target_pid_to_str): Change return type.
11619         (target_translate_tls_address): Update.
11620         (target_announce_detach): Update.
11621         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11622         return type.
11623         (bsd_uthread_target::pid_to_str): Change return type.
11624         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11625         type.
11626         (bsd_kvm_target::pid_to_str): Change return type.
11627         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11628         return type.
11629         (aix_thread_target::pid_to_str): Change return type.
11630         * target.h (struct target_ops) <pid_to_str>: Change return type.
11631         (target_pid_to_str, normal_pid_to_str): Likewise.
11632         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11633         type.
11634         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11635         type.
11636         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11637         return type.
11638         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11639         type.
11640         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11641         type.
11642         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11643         return type.
11644
11645 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11646
11647         * NEWS: Mention that the new default MI version is 3.  Mention
11648         changes to the output of commands and events that deal with
11649         multi-location breakpoints.
11650         * breakpoint.c: Include "mi/mi-out.h".
11651         (print_one_breakpoint): Change output syntax if using MI version
11652         >= 3.
11653         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11654         New.
11655         (mi_multi_location_breakpoint_output_fixed): New.
11656         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11657         (mi_cmd_fix_multi_location_breakpoint_output): New.
11658         (mi_multi_location_breakpoint_output_fixed): New.
11659         * mi/mi-cmds.c (mi_cmds): Register command
11660         -fix-multi-location-breakpoint-output.
11661         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11662         interpreter "mi".
11663
11664 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11665
11666         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11667         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11668         instantiate mi_ui_out based on interpreter name.
11669         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11670         * mi/mi-main.c (mi_load_progress): Likewise.
11671
11672 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11673
11674         * NEWS: Combine separate "New targets" sections for 8.3.
11675
11676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11677
11678         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11679         (ppcfbsd_init_abi): Install gdbarch
11680         "fetch_tls_load_module_address" and "get_thread_local_address"
11681         methods.
11682
11683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11684
11685         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11686         (riscv_fbsd_init_abi): Install gdbarch
11687         "fetch_tls_load_module_address" and "get_thread_local_address"
11688         methods.
11689
11690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11691
11692         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11693         (i386fbsd_init_abi): Install gdbarch
11694         "fetch_tls_load_module_address" and "get_thread_local_address"
11695         methods.
11696
11697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11698
11699         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11700         (amd64fbsd_init_abi): Install gdbarch
11701         "fetch_tls_load_module_address" and "get_thread_local_address"
11702         methods.
11703
11704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11705
11706         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11707         (struct fbsd_pspace_data): New type.
11708         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11709         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11710         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11711         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11712         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11713
11714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11715
11716         * gdbtypes.c (lookup_struct_elt): New function.
11717         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11718         * gdbtypes.h (struct struct_elt): New type.
11719         (lookup_struct_elt): New prototype.
11720
11721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11722
11723         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11724         remove disabled code block.
11725
11726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11727
11728         * gdbarch.sh (get_thread_local_address): New method.
11729         * gdbarch.h, gdbarch.c: Regenerate.
11730         * target.c (target_translate_tls_address): Use
11731         gdbarch_get_thread_local_address if present instead of
11732         target::get_thread_local_address.
11733
11734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11735
11736         * target.h (target::get_thread_local_address): Update comment.
11737
11738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11739
11740         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11741         objfile->separate_debug_objfile_backlink if not NULL.
11742
11743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11744
11745         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11746         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11747         (amd64bsd_store_inferior_registers): Likewise.
11748         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11749         Enable segment base registers.
11750         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11751         PT_GETFSBASE and PT_GETGSBASE.
11752         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11753         PT_SETGSBASE.
11754         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11755         segment base registers.
11756         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11757
11758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11759
11760         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11761         Update calls to i386_target_description to add 'segments'
11762         parameter.
11763         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11764         add segment base registers.
11765         * arch/i386.c (i386_create_target_description): Add 'segments'
11766         parameter to enable segment base registers.
11767         * arch/i386.h (i386_create_target_description): Likewise.
11768         * features/i386/32bit-segments.xml: New file.
11769         * features/i386/32bit-segments.c: Generate.
11770         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11771         call to i386_target_description to add 'segments' parameter.
11772         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11773         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11774         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11775         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11776         if feature is present.
11777         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11778         Add 'segments' parameter to call to i386_target_description.
11779         (i386_target_description): Add 'segments' parameter to enable
11780         segment base registers.
11781         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11782         to call to i386_target_description.
11783         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11784         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11785         Define I386_NUM_REGS.
11786         (i386_target_description): Add 'segments' parameter to enable
11787         segment base registers.
11788
11789 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11790
11791         PR/24325
11792         * source-cache.c: #undef open and close, to avoid unresolved
11793         externals during linking.
11794
11795 2019-03-12  Tom Tromey  <tromey@adacore.com>
11796
11797         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11798         const.  Add initializers.
11799         (_initialize_remote): Don't initialize ptid globals.
11800
11801 2019-03-12  Pedro Alves  <palves@redhat.com>
11802
11803         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11804
11805 2019-03-12  Pedro Alves  <palves@redhat.com>
11806
11807         * cp-name-parser.y (main): Remove unused 'len' variable.
11808
11809 2019-03-12  Tom Tromey  <tromey@adacore.com>
11810
11811         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11812         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11813
11814 2019-03-12  Tom Tromey  <tromey@adacore.com>
11815
11816         * linux-nat.c (iterate_over_lwps): Update.
11817         (stop_callback): Remove parameter.
11818         (stop_wait_callback, detach_callback, resume_set_callback)
11819         (select_singlestep_lwp_callback, set_ignore_sigint)
11820         (status_callback, resumed_callback, resume_clear_callback)
11821         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11822         data parameter.
11823         (linux_nat_target::detach, linux_nat_target::resume)
11824         (linux_stop_and_wait_all_lwps, select_event_lwp)
11825         (linux_nat_filter_event, linux_nat_wait_1)
11826         (linux_nat_target::kill, linux_nat_target::stop)
11827         (linux_nat_target::stop): Update.
11828         (linux_nat_resume_callback): Change type.
11829         (resume_stopped_resumed_lwps, count_events_callback)
11830         (select_event_lwp_callback): Likewise.
11831         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11832         * arm-linux-nat.c (struct update_registers_data): Remove.
11833         (update_registers_callback): Change type.
11834         (arm_linux_insert_hw_breakpoint1): Update.
11835         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11836         parameter.
11837         (x86_linux_dr_set_addr): Update.
11838         (x86_linux_dr_set_control): Update.
11839         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11840         (iterate_over_lwps): Use gdb::function_view.
11841         * nat/aarch64-linux-hw-point.c (struct
11842         aarch64_dr_update_callback_param): Remove.
11843         (debug_reg_change_callback): Change type.
11844         (aarch64_notify_debug_reg_change): Update.
11845         * s390-linux-nat.c (s390_refresh_per_info): Update.
11846
11847 2019-03-11  Tom Tromey  <tromey@adacore.com>
11848
11849         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11850         redundant assignment to "this_cu".
11851
11852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11853
11854         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11855
11856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11857
11858         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11859         from...
11860         (rank_one_type): ... this.
11861
11862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11863
11864         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11865         from...
11866         (rank_one_type): ... this.
11867
11868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11869
11870         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11871         from...
11872         (rank_one_type): ... this.
11873
11874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11875
11876         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11877         from...
11878         (rank_one_type): ... this.
11879
11880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11881
11882         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11883         from...
11884         (rank_one_type): ... this.
11885
11886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11887
11888         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11889         from...
11890         (rank_one_type): ... this.
11891
11892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11893
11894         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11895         from...
11896         (rank_one_type): ... this.
11897
11898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11899
11900         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11901         from...
11902         (rank_one_type): ... this.
11903
11904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11905
11906         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11907         from...
11908         (rank_one_type): ... this.
11909
11910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11911
11912         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11913         from...
11914         (rank_one_type): ... this.
11915
11916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11917
11918         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11919         from...
11920         (rank_one_type): ... this.
11921
11922 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11923
11924         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11925         from...
11926         (rank_one_type): ... this.
11927
11928 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11929
11930         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11931         inferior-events' shows the example events.
11932
11933 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11934
11935         Support styling on native MS-Windows console
11936
11937         PR/24315
11938         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11939         on MS-Windows if $TERM is not defined.
11940
11941         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11942
11943         * posix-hdep.c (gdb_console_fputs):
11944         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11945         functions.
11946         * ui-file.h (gdb_console_fputs): Add prototype.
11947
11948         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11949         back to fputs only if the former returns zero.
11950
11951 2019-03-07  Tom Tromey  <tom@tromey.com>
11952
11953         * symmisc.c (print_symbol_bcache_statistics): Update.
11954         (print_objfile_statistics): Update.
11955         * symfile.c (allocate_symtab): Update.
11956         * stabsread.c: Don't include bcache.h.
11957         * psymtab.h (struct psymbol_bcache): Don't declare.
11958         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11959         (psymbol_bcache_init, psymbol_bcache_free)
11960         (psymbol_bcache_get_bcache): Don't declare.
11961         * psymtab.c (struct psymbol_bcache): Remove.
11962         (psymtab_storage::psymtab_storage): Update.
11963         (psymtab_storage::~psymtab_storage): Update.
11964         (psymbol_bcache_init, psymbol_bcache_free)
11965         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11966         (add_psymbol_to_bcache): Update.
11967         (allocate_psymtab): Update.
11968         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11969         macro_cache>: No longer pointers.
11970         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11971         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11972         * macrotab.c (macro_bcache): Update.
11973         * macroexp.c: Don't include bcache.h.
11974         * gdbtypes.c (check_types_worklist): Update.
11975         (types_deeply_equal): Remove TRY/CATCH.  Update.
11976         * elfread.c (elf_symtab_read): Update.
11977         * dwarf2read.c: Don't include bcache.h.
11978         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11979         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11980         (print_bcache_statistics, bcache_memory_used): Don't declare.
11981         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11982         methods.  Rename all data members.
11983         * bcache.c (struct bcache): Move to bcache.h.
11984         (bcache::expand_hash_table): Rename from expand_hash_table.
11985         (bcache): Remove.
11986         (bcache::insert): Rename from bcache_full.
11987         (bcache::compare): Rename from bcache_compare.
11988         (bcache_xmalloc): Remove.
11989         (bcache::~bcache): Rename from bcache_xfree.
11990         (bcache::print_statistics): Rename from print_bcache_statistics.
11991         (bcache::memory_used): Rename from bcache_memory_used.
11992
11993 2019-03-07  Pedro Alves  <palves@redhat.com>
11994
11995         * infrun.c (normal_stop): Also check for
11996         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11997
11998 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11999
12000         * f-lang.c (value_from_host_double): Moved to...
12001         * value.c (value_from_host_double): ...here.
12002         * value.h (value_from_host_double): Declare.
12003         * guile/scm-math.c (vlscm_convert_typed_number): Use
12004         value_from_host_double.
12005         (vlscm_convert_number): Likewise.
12006         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12007         * python/py-value.c (convert_value_from_python): Likewise.
12008
12009 2019-03-06  Tom Tromey  <tom@tromey.com>
12010
12011         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12012
12013 2019-03-06  Tom Tromey  <tom@tromey.com>
12014
12015         * utils.h (free_current_contents): Don't declare.
12016         * utils.c (free_current_contents): Remove.
12017
12018 2019-03-06  Tom Tromey  <tom@tromey.com>
12019
12020         * top.c (quit_force): Update.
12021         * main.c (captured_command_loop): Update.
12022         * common/new-op.c (operator new): Update.
12023         * common/common-exceptions.c (struct catcher)
12024         <save_cleanup_chain>: Remove member.
12025         (exceptions_state_mc_init): Update.
12026         (exception_try_scope_entry): Return nullptr.
12027         (exception_try_scope_exit, exception_rethrow)
12028         (throw_exception_sjlj, throw_exception_cxx): Update.
12029         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12030         (all_cleanups, do_cleanups, discard_cleanups)
12031         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12032         (restore_cleanups, restore_final_cleanups): Don't declare.
12033         (do_final_cleanups): Remove parameter.
12034         * common/cleanups.c (cleanup_chain, make_cleanup)
12035         (make_cleanup_dtor, all_cleanups, do_cleanups)
12036         (discard_my_cleanups, discard_cleanups)
12037         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12038         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12039         (null_cleanup): Remove.
12040         (do_final_cleanups): Remove parameter.
12041
12042 2019-03-06  Tom Tromey  <tom@tromey.com>
12043
12044         * remote.c (remote_target::remote_parse_stop_reply): Use
12045         unique_xmalloc_ptr.
12046
12047 2019-03-06  Tom Tromey  <tom@tromey.com>
12048
12049         * stabsread.c (struct stabs_field_info): Rename from field_info.
12050         <list, fnlist>: Add initializers.
12051         <obstack>: New member.
12052         (read_member_functions, read_struct_fields, read_baseclasses):
12053         Allocate on obstack.  Don't use cleanups.
12054         (read_one_struct_field, read_member_functions, read_struct_fields)
12055         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12056         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12057         (read_struct_type): Update.
12058
12059 2019-03-06  Tom Tromey  <tom@tromey.com>
12060
12061         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12062         * common/filestuff.h (make_cleanup_close): Don't declare.
12063         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12064         Remove.
12065
12066 2019-03-06  Tom Tromey  <tom@tromey.com>
12067
12068         * solib-aix.c: Use make_scope_exit.
12069
12070 2019-03-06  Tom Tromey  <tom@tromey.com>
12071
12072         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12073         Use make_scope_exit.
12074
12075 2019-03-06  Tom Tromey  <tom@tromey.com>
12076
12077         * solib-svr4.c (disable_probes_interface): Remove parameter.
12078         (svr4_handle_solib_event): Use make_scope_exit.
12079
12080 2019-03-06  Tom Tromey  <tom@tromey.com>
12081
12082         * remote.c (struct stop_reply_deleter): Remove.
12083         (stop_reply_up): Update.
12084         (struct stop_reply): Derive from notif_event.  Don't typedef.
12085         <regcache>: Now a std::vector.
12086         (stop_reply_xfree): Remove.
12087         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12088         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12089         (remote_target::discard_pending_stop_replies): Use delete.
12090         (remote_target::remote_parse_stop_reply): Update.
12091         (remote_target::process_stop_reply): Update.
12092         * remote-notif.h (struct notif_event): Add virtual destructor.
12093         Remove "dtr" member.
12094         (struct notif_client) <alloc_event>: Return a unique_ptr.
12095         (notif_event_xfree): Don't declare.
12096         (notif_event_up): New typedef.
12097         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12098         (notif_event_xfree, do_notif_event_xfree): Remove.
12099         (remote_notif_state_xfree): Update.
12100
12101 2019-03-06  Tom Tromey  <tom@tromey.com>
12102
12103         * infrun.c (displaced_step_clear_cleanup): Now a
12104         forward_scope_exit type.
12105         (displaced_step_prepare_throw): Update.
12106         (displaced_step_fixup): Update.
12107
12108 2019-03-06  Tom Tromey  <tom@tromey.com>
12109
12110         * inferior.h (class inferior): Update comment.
12111         * gdbthread.h (class thread_info): Update comment.
12112
12113 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12114             Tom Tromey  <tom@tromey.com>
12115
12116         * stabsread.h (struct stab_section_list): Remove.
12117         (coffstab_build_psymtabs): Update.
12118         * dbxread.c (symbuf_sections): Now a std::vector.
12119         (sect_idx): New global.
12120         (fill_symbuf): Update.
12121         (coffstab_build_psymtabs): Change type of stabsects parameter.
12122         Update.
12123         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12124         std::vector.
12125         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12126         (coff_locate_sections): Update.
12127         (coff_symfile_read): Remove cleanups.  Update.
12128         (init_stringtab): Add storage parameter.
12129         (free_stringtab, free_stringtab_cleanup): Remove.
12130         (init_lineno): Add storage parameter.
12131         (free_linetab, free_linetab_cleanup): Remove.
12132
12133 2019-03-06  Pedro Alves  <palves@redhat.com>
12134
12135         * linux-fork.c (fork_info::clobber_regs): Delete.
12136         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12137         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12138         comment.  Adjust.
12139         (scoped_switch_fork_info::scoped_switch_fork_info)
12140         (checkpoint_command, linux_fork_context): Adjust
12141         fork_save_infrun_state calls.
12142
12143 2019-03-06  Pedro Alves  <palves@redhat.com>
12144
12145         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12146         (inf_has_multiple_threads): Return 'bool' and rewrite using
12147         inferior_info::threads().
12148
12149 2019-03-06  Pedro Alves  <palves@redhat.com>
12150
12151         * linux-fork.c: Include <list>.
12152         (fork_list): Now a std::list instance.
12153         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12154         (forks_exist_p, find_last_fork): Adjust.
12155         (new_fork): Delete.
12156         (one_fork_p): New.
12157         (add_fork): Adjust.
12158         (free_fork): Delete, folded into fork_info::~fork_info().
12159         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12160         Adjust.
12161         (init_fork_list): Delete.
12162         (linux_fork_killall, linux_fork_mourn_inferior)
12163         (linux_fork_detach, info_checkpoints_command): Adjust.
12164         (_initialize_linux_fork): No longer call init_fork_list.
12165
12166 2019-03-06  Pedro Alves  <palves@redhat.com>
12167
12168         * linux-fork.c (new_fork): New, split out of ...
12169         (add_fork): ... this.  Return void.  Move "first fork" special
12170         case from here, to ...
12171         (checkpoint_command): ... here.
12172         * linux-linux.h (add_fork): Return void.
12173
12174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12175
12176         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12177
12178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12179             Chris January  <chris.january@arm.com>
12180             David Lecomber  <david.lecomber@arm.com>
12181
12182         * f-exp.y: New token, UNOP_INTRINSIC.
12183         (exp): New pattern using UNOP_INTRINSIC token.
12184         (f77_keywords): Add 'abs' keyword.
12185         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12186         (value_from_host_double): New function.
12187         (evaluate_subexp_f): Support UNOP_ABS.
12188
12189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12190
12191         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12192         types.
12193
12194 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12195
12196         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12197         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12198         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12199
12200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12201
12202         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12203
12204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12205             Chris January  <chris.january@arm.com>
12206
12207         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12208         * f-exp.y: Define 'KIND' token.
12209         (exp): New pattern for KIND expressions.
12210         (ptype): Handle types with a kind extension.
12211         (direct_abs_decl): Extend to spot kind extensions.
12212         (f77_keywords): Add 'kind' to the list.
12213         (push_kind_type): New function.
12214         (convert_to_kind_type): New function.
12215         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12216         * parse.c (operator_length_standard): Likewise.
12217         * parser-defs.h (enum type_pieces): Add tp_kind.
12218         * std-operator.def: Add UNOP_KIND.
12219
12220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12221
12222         * f-exp.y (f_parse): Set yydebug.
12223
12224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12225
12226         * f-lang.c (evaluate_subexp_f): New function.
12227         (exp_descriptor_f): New global.
12228         (f_language_defn): Use exp_descriptor_f instead of
12229         exp_descriptor_standard.
12230
12231 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12232
12233         * f-exp.y (struct token): Add comments.
12234         (dot_ops): Remove uppercase versions and the end marker.
12235         (f77_keywords): Likewise.
12236         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12237         entries in the dot_ops array are case insensitive, and use
12238         strncasecmp to compare strings.  Also some whitespace cleanup in
12239         this area.  Similar for the f77_keywords array, except entries in
12240         this list might be case sensitive.
12241
12242 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12243
12244         * f-exp.y (struct f77_boolean_val): Add comments.
12245         (boolean_values): Remove uppercase versions, and end marker.
12246         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12247         and use strncasecmp to achieve case insensitivity.  Additionally,
12248         perform whitespace cleanup around this code.
12249
12250 2019-03-06  Tom Tromey  <tromey@adacore.com>
12251
12252         * remote-sim.c (gdbsim_target_open): Use result of
12253         gdb_argv::release.
12254
12255 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12256         Dirk Schubert  <dirk.schubert@arm.com>
12257         Chris January  <chris.january@arm.com>
12258
12259         * eval.c (evaluate_subexp_standard): Call Fortran argument
12260         wrapping logic.
12261         * f-lang.c (struct value): A value which can be passed into a
12262         Fortran function call.
12263         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12264         where appropriate.
12265         (struct type): Value ready for a Fortran function call.
12266         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12267         is needed.
12268         * f-lang.h (fortran_argument_convert): Declaration.
12269         (fortran_preserve_arg_pointer): Declaration.
12270         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12271
12272 2019-03-05  Tom Tromey  <tromey@adacore.com>
12273
12274         * python/py-prettyprint.c (print_string_repr): Remove #if.
12275         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12276
12277 2019-03-05  Tom Tromey  <tromey@adacore.com>
12278
12279         * target.c (the_dummy_target): Move later.  Change type to
12280         "dummy_target".
12281         (initialize_targets): Don't initialize the_dummy_target.
12282
12283 2019-03-05  Tom Tromey  <tromey@adacore.com>
12284
12285         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12286         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12287
12288 2019-03-05  Tom Tromey  <tromey@adacore.com>
12289
12290         * windows-nat.c (windows_nat_target::attach)
12291         (windows_nat_target::detach): Don't call gdb_flush.
12292         * valprint.c (generic_val_print, val_print, val_print_string):
12293         Don't call gdb_flush.
12294         * utils.c (defaulted_query): Don't call gdb_flush.
12295         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12296         * target.c (target_announce_detach): Don't call gdb_flush.
12297         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12298         * remote.c (extended_remote_target::attach): Don't call
12299         gdb_flush.
12300         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12301         * printcmd.c (do_examine): Don't call gdb_flush.
12302         (info_display_command): Don't call gdb_flush.
12303         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12304         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12305         * memattr.c (info_mem_command): Don't call gdb_flush.
12306         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12307         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12308         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12309         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12310         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12311         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12312         (gnu_nat_target::detach): Don't call gdb_flush.
12313         * f-valprint.c (f_val_print): Don't call gdb_flush.
12314         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12315         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12316         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12317         gdb_flush.
12318         * c-valprint.c (c_val_print): Don't call gdb_flush.
12319         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12320
12321 2019-03-05  Tom Tromey  <tromey@adacore.com>
12322
12323         * varobj.c (update_dynamic_varobj_children): Update.
12324         (install_default_visualizer): Use reset, not release.
12325         * value.c (set_internalvar): Update.
12326         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12327         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12328         ATTRIBUTE_UNUSED_RESULT.
12329
12330 2019-03-05  Tom Tromey  <tromey@adacore.com>
12331
12332         * remote.c (class scoped_remote_fd) <release>: Add
12333         ATTRIBUTE_UNUSED_RESULT.
12334
12335 2019-03-05  Tom Tromey  <tromey@adacore.com>
12336
12337         * macroexp.c (struct macro_buffer) <release>: Add
12338         ATTRIBUTE_UNUSED_RESULT.
12339
12340 2019-03-05  Tom Tromey  <tromey@adacore.com>
12341
12342         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12343         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12344         ATTRIBUTE_UNUSED_RESULT.
12345
12346 2019-03-05  Tom Tromey  <tromey@adacore.com>
12347
12348         * common/scoped_fd.h (class scoped_fd) <release>: Add
12349         ATTRIBUTE_UNUSED_RESULT.
12350
12351 2019-03-05  Tom Tromey  <tromey@adacore.com>
12352
12353         * parser-defs.h (struct parser_state) <release>: Add
12354         ATTRIBUTE_UNUSED_RESULT.
12355
12356 2019-03-05  Tom Tromey  <tromey@adacore.com>
12357
12358         * utils.h (class gdb_argv) <release>: Add
12359         ATTRIBUTE_UNUSED_RESULT.
12360         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12361
12362 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12363
12364         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12365         for-loop range, to avoid compiler warnings.
12366
12367         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12368         avoid compiler warnings about unused variables.
12369
12370         * NEWS: Mention end of support for native debugging on MS-Windows
12371         before XP.
12372
12373         PR gdb/24292
12374         * common/netstuff.c:
12375         * gdbserver/gdbreplay.c
12376         * gdbserver/remote-utils.c:
12377         * ser-tcp.c:
12378         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12379         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12380         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12381         'getaddrinfo' and 'freeaddrinfo' were not available before
12382         Windows XP, and mingw.org's MinGW headers by default define
12383         _WIN32_WINNT to 0x500.
12384
12385 2019-03-01  Gary Benson <gbenson@redhat.com>
12386
12387         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12388
12389 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12390             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12391
12392         PR gdb/8527
12393         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12394         set_sigint_trap, clear_sigint_trap.
12395
12396 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12397
12398         * target.c (target_detach): Clear the regcache and the
12399         frame cache.
12400
12401 2019-02-27  Pedro Alves  <palves@redhat.com>
12402
12403         * utils.c (set_screen_size): When we cap the height/width sizes,
12404         tweak the corresponding command variable to show "unlimited":
12405
12406 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12407             Pedro Alves  <palves@redhat.com>
12408
12409         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12410         before calling rl_set_screen_size.
12411
12412 2019-02-27  Tom Tromey  <tromey@adacore.com>
12413
12414         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12415         define.
12416         * python/py-value.c: Remove Python 2.4 workaround.
12417         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12418         workaround.
12419         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12420         Python 2.4 workaround.
12421         * python/python-internal.h: Remove Python 2.4 comment.
12422         (Py_ssize_t): Don't define.
12423         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12424         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12425         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12426         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12427         * python/python.c (do_start_initialization): Remove Python 2.4
12428         workaround.
12429         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12430         (print_children): Remove Python 2.4 workaround.
12431         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12432         workaround.
12433         (CHARBUFFERPROC_NAME): Remove.
12434         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12435         Python 2.4 workaround.
12436
12437 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12438
12439         * NEWS: Note minimum Python version.
12440
12441 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12442
12443         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12444         code from these functions.  Remove corresponding ifdefs.  Use
12445         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12446         Remove gotos and target of gotos.
12447         (infpy_search_memory): Likewise.
12448
12449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12450
12451         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12452         (hppa_gdbarch_init): Don't register deleted functions with
12453         gdbarch.
12454
12455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12456
12457         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12458         (h8300_unwind_sp): Delete.
12459         (h8300_dummy_id): Delete.
12460         (h8300_gdbarch_init): Don't register deleted functions with
12461         gdbarch.
12462
12463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12464
12465         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12466         (ft32_unwind_pc): Delete.
12467         (ft32_unwind_sp): Delete.
12468         (ft32_gdbarch_init): Don't register deleted functions with
12469         gdbarch.
12470
12471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12472
12473         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12474         (frv_unwind_pc): Delete.
12475         (frv_unwind_sp): Delete.
12476         (frv_gdbarch_init): Don't register deleted functions with
12477         gdbarch.
12478
12479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12480
12481         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12482         (riscv_unwind_pc): Delete.
12483         (riscv_unwind_sp): Delete.
12484         (riscv_gdbarch_init): Don't register deleted functions with
12485         gdbarch.
12486
12487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12488
12489         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12490         (csky_unwind_pc): Delete.
12491         (csky_unwind_sp): Delete.
12492         (csky_gdbarch_init): Don't register deleted functions with
12493         gdbarch.
12494
12495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12496
12497         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12498         (cris_unwind_pc): Delete.
12499         (cris_unwind_sp): Delete.
12500         (cris_gdbarch_init): Don't register deleted functions with
12501         gdbarch.
12502
12503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12504
12505         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12506         (bfin_unwind_pc): Delete.
12507         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12508
12509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12510
12511         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12512         (arm_unwind_pc): Delete.
12513         (arm_unwind_sp): Delete.
12514         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12515
12516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12517
12518         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12519         (arc_unwind_pc): Delete.
12520         (arc_unwind_sp): Delete.
12521         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12522
12523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12524
12525         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12526         (alpha_unwind_pc): Delete.
12527         (alpha_gdbarch_init): Don't register deleted functions with
12528         gdbarch.
12529
12530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12531
12532         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12533         (aarch64_unwind_pc): Delete.
12534         (aarch64_unwind_sp): Delete.
12535         (aarch64_gdbarch_init): Don't register deleted functions with
12536         gdbarch.
12537
12538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12539
12540         * gdbtypes.c (type_align): Don't consider static members when
12541         computing structure alignment.
12542
12543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12544
12545         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12546         return 0 for other types.
12547         * arch-utils.c (default_type_align): Always return 0.
12548         * gdbarch.h: Regenerate.
12549         * gdbarch.sh (type_align): Extend comment.
12550         * gdbtypes.c (type_align): Add additional comments, always call
12551         gdbarch_type_align before applying the default rules.
12552         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12553         generic code will then apply a suitable default.
12554         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12555         types, return 0 for other types.
12556
12557 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12558
12559         * NEWS: Create a new section for the next release branch.
12560         Rename the section of the current branch, now that it has
12561         been cut.
12562
12563 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12564
12565         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12566         * version.in: Bump version to 8.3.50.DATE-git.
12567
12568 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12569
12570         * aix-thread.c (ptid_cmp): Remove unused variable.
12571         (get_signaled_thread): Likewise.
12572         (store_regs_user_thread): Likewise.
12573         (store_regs_kernel_thread): Likewise.
12574         (fetch_regs_kernel_thread): Remove shadowed variable.
12575
12576 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12577
12578         * features/riscv/32bit-cpu.xml: Add register numbers.
12579         * features/riscv/32bit-fpu.c: Regenerate.
12580         * features/riscv/32bit-fpu.xml: Add register numbers.
12581         * features/riscv/64bit-cpu.xml: Add register numbers.
12582         * features/riscv/64bit-fpu.c: Regenerate.
12583         * features/riscv/64bit-fpu.xml: Add register numbers.
12584
12585 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12586
12587         * NEWS: Mention two argument form of gdb.Value constructor.
12588         * python/py-value.c (convert_buffer_and_type_to_value): New
12589         function.
12590         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12591         Add support for handling an optional second argument.  Call
12592         convert_buffer_and_type_to_value as appropriate.
12593         * python/python-internal.h (Py_buffer_deleter): New struct.
12594         (Py_buffer_up): New typedef.
12595
12596 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12597
12598         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12599         instead of releasing ownership.
12600
12601 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12602
12603         * dwarf2read.c (open_and_init_dwp_file): Call
12604         elf_numsections instead of bfd_count_sections to initialize
12605         dwp_file->num_sections.
12606
12607 2019-02-25  Tom Tromey  <tromey@adacore.com>
12608
12609         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12610
12611 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12612
12613         * gcore.in: Add '--readnever' option when invoking GDB.
12614
12615 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12616
12617         * MAINTAINERS: Update my email address.
12618
12619 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12620
12621         * build-id.c (build_id_to_debug_bfd_1): New function.
12622         (build_id_to_debug_bfd): Look for separate debug file in
12623         sysroot.
12624
12625 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12626
12627         * gdbarch.sh: Update the copyright year range that is placed into
12628         generated files.
12629
12630 2019-02-22  Keith Seitz  <keiths@redhat.com>
12631
12632         PR symtab/23853
12633         * linespec.c (create_sals_line_offset): Search for the default
12634         symtab's filename instead of its fullname.
12635
12636 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12637
12638         * NEWS: Update style defaults.
12639
12640 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12641
12642         * main.c (captured_main_1): Disable styling in batch mode.
12643
12644 2019-02-20  Tom Tromey  <tom@tromey.com>
12645
12646         * symtab.c (symtab_symbol_info): Fix typos.
12647
12648 2019-02-20  Tom Tromey  <tromey@adacore.com>
12649
12650         * findcmd.c (_initialize_mem_search): Use upper case for
12651         metasyntactic variables.
12652
12653 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12654
12655         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12656         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12657
12658 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12659
12660         * top.h (source_file_name): Change to std::string.
12661         * top.c (source_file_name): Likewise.
12662         (command_line_input): Adjust.
12663         * cli/cli-script.c (script_from_file): Adjust.
12664
12665 2019-02-19  Tom Tromey  <tromey@adacore.com>
12666
12667         * ravenscar-thread.c
12668         (ravenscar_thread_target::update_thread_list): Don't call
12669         ada_build_task_list.
12670         * ada-lang.h (ada_build_task_list): Don't declare.
12671         * ada-tasks.c (struct ada_tasks_inferior_data)
12672         <task_list_valid_p>: Now bool.
12673         (read_known_tasks, ada_task_list_changed)
12674         (ada_tasks_invalidate_inferior_data): Update.
12675         (read_known_tasks_array): Return bool.
12676         (read_known_tasks_list): Likewise.
12677         (read_known_tasks): Return void.
12678         (ada_build_task_list): Now static.
12679
12680 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12681
12682         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12683         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12684
12685 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12686
12687         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12688         variant for ada_tasks_pspace_data_handle and
12689         ada_tasks_inferior_data_handle.
12690         (ada_tasks_pspace_data_cleanup): New function.
12691         (ada_tasks_inferior_data_cleanup): New function.
12692
12693 2019-02-17  Tom Tromey  <tom@tromey.com>
12694
12695         * macrotab.h (macro_source_fullname): Return a std::string.
12696         * macrotab.c (macro_include, check_for_redefinition)
12697         (macro_undef, macro_lookup_definition, foreach_macro)
12698         (foreach_macro_in_scope): Update.
12699         (macro_source_fullname): Return a std::string.
12700         * macrocmd.c (show_pp_source_pos): Update.
12701
12702 2019-02-17  Tom Tromey  <tom@tromey.com>
12703
12704         * macrocmd.c (show_pp_source_pos): Style the file names.
12705
12706 2019-02-17  Tom Tromey  <tom@tromey.com>
12707
12708         PR tui/24197:
12709         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12710
12711 2019-02-17  Tom Tromey  <tom@tromey.com>
12712
12713         * ada-lang.c (user_select_syms): Use filtered printing.
12714         * utils.c (wrap_style): New global.
12715         (desired_style): Remove.
12716         (emit_style_escape): Add stream parameter.
12717         (set_output_style, reset_terminal_style, prompt_for_continue):
12718         Update.
12719         (flush_wrap_buffer): Only flush gdb_stdout.
12720         (wrap_here): Set wrap_style.
12721         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12722         treat escape sequences as a character.  Change when wrap buffer is
12723         flushed.
12724         (fputs_styled): Do not set the output style when the default is
12725         requested.
12726         * ui-style.h (struct ui_file_style) <is_default>: New method.
12727         * source.c (print_source_lines_base): Emit escape sequences in one
12728         piece.
12729
12730 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12731
12732         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12733         integers and enumeration types.
12734
12735 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12736
12737         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12738         instead of lookup_symbol_in_language
12739         (do_exact_match): New function.
12740         (ada_get_symbol_name_matcher): Return do_exact_match when
12741         doing a verbatim match.
12742
12743 2019-02-15  Tom Tromey  <tromey@adacore.com>
12744
12745         * ravenscar-thread.c (ravenscar_thread_target::resume)
12746         (ravenscar_thread_target::wait): Special case wildcard requests.
12747
12748 2019-02-15  Tom Tromey  <tromey@adacore.com>
12749
12750         * ravenscar-thread.c (base_ptid): Remove.
12751         (struct ravenscar_thread_target) <close>: New method.
12752         <m_base_ptid>: New member.
12753         <update_inferior_ptid, active_task, task_is_currently_active,
12754         runtime_initialized>: Declare methods.
12755         <ravenscar_thread_target>: Add constructor.
12756         (ravenscar_thread_target::task_is_currently_active)
12757         (ravenscar_thread_target::update_inferior_ptid)
12758         (ravenscar_runtime_initialized): Rename.  Now methods.
12759         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12760         (ravenscar_thread_target::update_thread_list): Update.
12761         (ravenscar_thread_target::active_task): Now method.
12762         (ravenscar_thread_target::store_registers)
12763         (ravenscar_thread_target::prepare_to_store)
12764         (ravenscar_thread_target::prepare_to_store)
12765         (ravenscar_thread_target::mourn_inferior): Update.
12766         (ravenscar_inferior_created): Use "new" to create target.
12767         (ravenscar_thread_target::get_ada_task_ptid): Update.
12768         (_initialize_ravenscar): Don't initialize base_ptid.
12769         (ravenscar_ops): Remove global.
12770
12771 2019-02-15  Tom Tromey  <tromey@adacore.com>
12772
12773         * target.h (push_target): Declare new overload.
12774         * target.c (push_target): New overload, taking an rvalue reference.
12775         * remote.c (remote_target::open_1): Use push_target overload.
12776         * corelow.c (core_target_open): Use push_target overload.
12777
12778 2019-02-15  Tom Tromey  <tromey@adacore.com>
12779
12780         * ravenscar-thread.c (is_ravenscar_task)
12781         (ravenscar_task_is_currently_active): Return bool.
12782         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12783         (_initialize_ravenscar): Remove "(void)".
12784         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12785         Return bool.
12786
12787 2019-02-15  Tom Tromey  <tromey@adacore.com>
12788
12789         * ravenscar-thread.c (ravenscar_runtime_initializer)
12790         (has_ravenscar_runtime, get_running_thread_id)
12791         (ravenscar_thread_target::resume): Fix indentation.
12792
12793 2019-02-15  Tom Tromey  <tromey@adacore.com>
12794
12795         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12796         from ravenscar_arch_ops.
12797         (sparc_ravenscar_ops::fetch_registers)
12798         (sparc_ravenscar_ops::store_registers): Now methods.
12799         (sparc_ravenscar_prepare_to_store): Remove.
12800         (sparc_ravenscar_ops): Redefine.
12801         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12802         methods and destructor.  Remove members.
12803         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12804         (ravenscar_thread_target::store_registers)
12805         (ravenscar_thread_target::prepare_to_store): Update.
12806         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12807         Remove.
12808         (struct ppc_ravenscar_powerpc_ops): Derive from
12809         ravenscar_arch_ops.
12810         (ppc_ravenscar_powerpc_ops::fetch_registers)
12811         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12812         (ppc_ravenscar_powerpc_ops): Redefine.
12813         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12814         (ppc_ravenscar_e500_ops::fetch_registers)
12815         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12816         (ppc_ravenscar_e500_ops): Redefine.
12817         * aarch64-ravenscar-thread.c
12818         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12819         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12820         (aarch64_ravenscar_fetch_registers)
12821         (aarch64_ravenscar_store_registers): Now methods.
12822         (aarch64_ravenscar_ops): Redefine.
12823
12824 2019-02-15  Tom Tromey  <tromey@adacore.com>
12825
12826         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12827         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12828         (ravenscar_thread_target::stopped_by_watchpoint)
12829         (ravenscar_thread_target::stopped_data_address)
12830         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12831
12832 2019-02-15  Tom Tromey  <tromey@adacore.com>
12833
12834         * ravenscar-thread.c: Fix some typos.
12835
12836 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12837             Tom Tromey  <tromey@adacore.com>
12838
12839         * ada-lang.c (ada_exception_sal): Change addr_string to a
12840         std::string.
12841         (create_ada_exception_catchpoint): Update.
12842
12843 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12844             Tom Tromey  <tromey@adacore.com>
12845
12846         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12847         (bp_location_ops): Remove.
12848         (base_breakpoint_allocate_location): Update.
12849         (free_bp_location): Update.
12850         * ada-lang.c (class ada_catchpoint_location)
12851         <ada_catchpoint_location>: Remove ops parameter.
12852         (ada_catchpoint_location_dtor): Remove.
12853         (ada_catchpoint_location_ops): Remove.
12854         (allocate_location_exception): Update.
12855         * breakpoint.h (struct bp_location_ops): Remove.
12856         (class bp_location) <bp_location>: Remove bp_location_ops
12857         parameter.
12858         <~bp_location>: Add destructor.
12859         <ops>: Remove.
12860
12861 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12862             Pedro Alves  <palves@redhat.com>
12863
12864         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12865         'PATH_MAX'.
12866
12867 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12868             Samuel Thibault  <samuel.thibault@gnu.org>
12869             Thomas Schwinge  <thomas@codesourcery.com>
12870
12871         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12872         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12873
12874 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12875
12876         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12877         (check_empty): Use "const char *".
12878
12879         * gnu-nat.c (gnu_nat_target::detach): Instead of
12880         'detach_inferior (pid)' call
12881         'detach_inferior (find_inferior_pid (pid))'.
12882
12883         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12884         'nat/fork-inferior.o'.
12885         * gnu-nat.c: #include "nat/fork-inferior.h".
12886
12887         * gnu-nat.c (gnu_nat_target::detach): Instead of
12888         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12889         * gnu-nat.h: #include "inf-child.h".
12890         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12891         'i386_gnu_nat_target::fetch_registers'.
12892         (gnu_store_registers): Rename/move to
12893         'i386_gnu_nat_target::store_registers'.
12894
12895         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12896         * gnu-nat.h (mach_thread_info): New function.
12897         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12898
12899         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12900
12901 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12902
12903         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12904
12905 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12906
12907         * windows-nat.c (windows_add_thread): Add new parameter
12908         "main_thread_p" with default value set to false.  Update
12909         function documentation as well as all callers.
12910         (windows_delete_thread): Likewise.
12911         (fake_create_process): Update call to windows_add_thread.
12912         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12913         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12914         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12915         call to windows_delete_thread.
12916
12917 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12918
12919         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12920
12921 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12922
12923         * symfile.c (find_separate_debug_file): Use canonical path of
12924         sysroot with child_path instead of gdb_sysroot if it is valid.
12925
12926 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12927
12928         * symfile.c (find_separate_debug_file): Use child_path to
12929         determine if an object file is under a sysroot.
12930
12931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12932
12933         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12934         unittests/child-path-selftests.c.
12935         * common/pathstuff.c (child_path): New function.
12936         * common/pathstuff.h (child_path): New prototype.
12937         * unittests/child-path-selftests.c: New file.
12938
12939 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12940
12941         * symfile.c (find_separate_debug_file): Look for separate debug
12942         files in debug directories under the sysroot.
12943
12944 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12945
12946         * symtab.h (struct minimal_symbol data_p): New const method.
12947         (struct minimal_symbol text_p): Likewise.
12948         * symtab.c (output_source_filename): Use file name style
12949         to print file name.
12950         (print_symbol_info): Likewise.
12951         (print_msymbol_info): Use address style to print addresses.
12952         Use function name style to print executable text symbols.
12953         (expand_symtab_containing_pc): Use data_p.
12954         (find_pc_sect_compunit_symtab): Likewise.
12955
12956 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12957
12958         * breakpoint.c (describe_other_breakpoints): Use address style
12959         to print addresses.
12960         (say_where): Likewise.
12961
12962 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12963
12964         * ada-typeprint.c (print_func_type): Print function name
12965         style to print function name.
12966         * c-typeprint.c (c_print_type_1): Likewise.
12967
12968 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12969
12970         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12971         for execve.
12972
12973 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12974
12975         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12976         type_stack.
12977
12978 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12979
12980         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12981         TYPE_CODE_REF types.
12982
12983 2019-02-08  Jim Wilson  <jimw@sifive.com>
12984
12985         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12986         (riscv_linux_fregset): New.
12987         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12988
12989 2019-02-07  Tom Tromey  <tom@tromey.com>
12990
12991         * thread.c (thread_cancel_execution_command): Update.
12992         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12993         methods.
12994         (struct thread_fsm_ops): Remove.
12995         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12996         (thread_fsm_should_stop, thread_fsm_return_value)
12997         (thread_fsm_set_finished, thread_fsm_finished_p)
12998         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12999         Don't declare.
13000         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13001         * infrun.c (clear_proceed_status_thread)
13002         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13003         (print_stop_event): Update.
13004         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13005         Add constructor.
13006         (step_command_fsm_ops): Remove.
13007         (new_step_command_fsm): Remove.
13008         (step_1): Update.
13009         (step_command_fsm::should_stop): Rename from
13010         step_command_fsm_should_stop.
13011         (step_command_fsm::clean_up): Rename from
13012         step_command_fsm_clean_up.
13013         (step_command_fsm::do_async_reply_reason): Rename from
13014         step_command_fsm_async_reply_reason.
13015         (struct until_next_fsm): Inherit from thread_fsm.  Add
13016         constructor.
13017         (until_next_fsm_ops): Remove.
13018         (new_until_next_fsm): Remove.
13019         (until_next_fsm::should_stop): Rename from
13020         until_next_fsm_should_stop.
13021         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13022         (until_next_fsm::do_async_reply_reason): Rename from
13023         until_next_fsm_async_reply_reason.
13024         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13025         constructor.  Change type of breakpoint.
13026         (finish_command_fsm_ops): Remove.
13027         (new_finish_command_fsm): Remove.
13028         (finish_command_fsm::should_stop): Rename from
13029         finish_command_fsm_should_stop.
13030         (finish_command_fsm::clean_up): Rename from
13031         finish_command_fsm_clean_up.
13032         (finish_command_fsm::return_value): Rename from
13033         finish_command_fsm_return_value.
13034         (finish_command_fsm::do_async_reply_reason): Rename from
13035         finish_command_fsm_async_reply_reason.
13036         (finish_command): Update.
13037         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13038         Add constructor.
13039         (call_thread_fsm_ops): Remove.
13040         (call_thread_fsm::call_thread_fsm): Rename from
13041         new_call_thread_fsm.
13042         (call_thread_fsm::should_stop): Rename from
13043         call_thread_fsm_should_stop.
13044         (call_thread_fsm::should_notify_stop): Rename from
13045         call_thread_fsm_should_notify_stop.
13046         (run_inferior_call, call_function_by_hand_dummy): Update.
13047         * cli/cli-interp.c (should_print_stop_to_console): Update.
13048         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13049         Add constructor.  Change type of location_breakpoint,
13050         caller_breakpoint.
13051         (until_break_fsm_ops): Remove.
13052         (new_until_break_fsm): Remove.
13053         (until_break_fsm::should_stop): Rename from
13054         until_break_fsm_should_stop.
13055         (until_break_fsm::clean_up): Rename from
13056         until_break_fsm_clean_up.
13057         (until_break_fsm::do_async_reply_reason): Rename from
13058         until_break_fsm_async_reply_reason.
13059         (until_break_command): Update.
13060         * thread-fsm.c: Remove.
13061         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13062
13063 2019-02-07  Tom Tromey  <tom@tromey.com>
13064
13065         * yy-remap.h: Add include guard.
13066         * xtensa-tdep.h: Add include guard.
13067         * xcoffread.h: Rename include guard.
13068         * varobj-iter.h: Add include guard.
13069         * tui/tui.h: Rename include guard.
13070         * tui/tui-winsource.h: Rename include guard.
13071         * tui/tui-wingeneral.h: Rename include guard.
13072         * tui/tui-windata.h: Rename include guard.
13073         * tui/tui-win.h: Rename include guard.
13074         * tui/tui-stack.h: Rename include guard.
13075         * tui/tui-source.h: Rename include guard.
13076         * tui/tui-regs.h: Rename include guard.
13077         * tui/tui-out.h: Rename include guard.
13078         * tui/tui-layout.h: Rename include guard.
13079         * tui/tui-io.h: Rename include guard.
13080         * tui/tui-hooks.h: Rename include guard.
13081         * tui/tui-file.h: Rename include guard.
13082         * tui/tui-disasm.h: Rename include guard.
13083         * tui/tui-data.h: Rename include guard.
13084         * tui/tui-command.h: Rename include guard.
13085         * tic6x-tdep.h: Add include guard.
13086         * target/waitstatus.h: Rename include guard.
13087         * target/wait.h: Rename include guard.
13088         * target/target.h: Rename include guard.
13089         * target/resume.h: Rename include guard.
13090         * target-float.h: Rename include guard.
13091         * stabsread.h: Add include guard.
13092         * rs6000-tdep.h: Add include guard.
13093         * riscv-fbsd-tdep.h: Add include guard.
13094         * regformats/regdef.h: Rename include guard.
13095         * record.h: Rename include guard.
13096         * python/python.h: Rename include guard.
13097         * python/python-internal.h: Rename include guard.
13098         * python/py-stopevent.h: Rename include guard.
13099         * python/py-ref.h: Rename include guard.
13100         * python/py-record.h: Rename include guard.
13101         * python/py-record-full.h: Rename include guard.
13102         * python/py-record-btrace.h: Rename include guard.
13103         * python/py-instruction.h: Rename include guard.
13104         * python/py-events.h: Rename include guard.
13105         * python/py-event.h: Rename include guard.
13106         * procfs.h: Add include guard.
13107         * proc-utils.h: Add include guard.
13108         * p-lang.h: Add include guard.
13109         * or1k-tdep.h: Rename include guard.
13110         * observable.h: Rename include guard.
13111         * nto-tdep.h: Rename include guard.
13112         * nat/x86-linux.h: Rename include guard.
13113         * nat/x86-linux-dregs.h: Rename include guard.
13114         * nat/x86-gcc-cpuid.h: Add include guard.
13115         * nat/x86-dregs.h: Rename include guard.
13116         * nat/x86-cpuid.h: Rename include guard.
13117         * nat/ppc-linux.h: Rename include guard.
13118         * nat/mips-linux-watch.h: Rename include guard.
13119         * nat/linux-waitpid.h: Rename include guard.
13120         * nat/linux-ptrace.h: Rename include guard.
13121         * nat/linux-procfs.h: Rename include guard.
13122         * nat/linux-osdata.h: Rename include guard.
13123         * nat/linux-nat.h: Rename include guard.
13124         * nat/linux-namespaces.h: Rename include guard.
13125         * nat/linux-btrace.h: Rename include guard.
13126         * nat/glibc_thread_db.h: Rename include guard.
13127         * nat/gdb_thread_db.h: Rename include guard.
13128         * nat/gdb_ptrace.h: Rename include guard.
13129         * nat/fork-inferior.h: Rename include guard.
13130         * nat/amd64-linux-siginfo.h: Rename include guard.
13131         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13132         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13133         * nat/aarch64-linux.h: Rename include guard.
13134         * nat/aarch64-linux-hw-point.h: Rename include guard.
13135         * mn10300-tdep.h: Add include guard.
13136         * mips-linux-tdep.h: Add include guard.
13137         * mi/mi-parse.h: Rename include guard.
13138         * mi/mi-out.h: Rename include guard.
13139         * mi/mi-main.h: Rename include guard.
13140         * mi/mi-interp.h: Rename include guard.
13141         * mi/mi-getopt.h: Rename include guard.
13142         * mi/mi-console.h: Rename include guard.
13143         * mi/mi-common.h: Rename include guard.
13144         * mi/mi-cmds.h: Rename include guard.
13145         * mi/mi-cmd-break.h: Rename include guard.
13146         * m2-lang.h: Add include guard.
13147         * location.h: Rename include guard.
13148         * linux-record.h: Rename include guard.
13149         * linux-nat.h: Add include guard.
13150         * linux-fork.h: Add include guard.
13151         * i386-darwin-tdep.h: Rename include guard.
13152         * hppa-linux-offsets.h: Add include guard.
13153         * guile/guile.h: Rename include guard.
13154         * guile/guile-internal.h: Rename include guard.
13155         * gnu-nat.h: Rename include guard.
13156         * gdb-stabs.h: Rename include guard.
13157         * frv-tdep.h: Add include guard.
13158         * f-lang.h: Add include guard.
13159         * event-loop.h: Add include guard.
13160         * darwin-nat.h: Rename include guard.
13161         * cp-abi.h: Rename include guard.
13162         * config/sparc/nm-sol2.h: Rename include guard.
13163         * config/nm-nto.h: Rename include guard.
13164         * config/nm-linux.h: Add include guard.
13165         * config/i386/nm-i386gnu.h: Rename include guard.
13166         * config/djgpp/nl_types.h: Rename include guard.
13167         * config/djgpp/langinfo.h: Rename include guard.
13168         * compile/gcc-cp-plugin.h: Add include guard.
13169         * compile/gcc-c-plugin.h: Add include guard.
13170         * compile/compile.h: Rename include guard.
13171         * compile/compile-object-run.h: Rename include guard.
13172         * compile/compile-object-load.h: Rename include guard.
13173         * compile/compile-internal.h: Rename include guard.
13174         * compile/compile-cplus.h: Rename include guard.
13175         * compile/compile-c.h: Rename include guard.
13176         * common/xml-utils.h: Rename include guard.
13177         * common/x86-xstate.h: Rename include guard.
13178         * common/version.h: Rename include guard.
13179         * common/vec.h: Rename include guard.
13180         * common/tdesc.h: Rename include guard.
13181         * common/selftest.h: Rename include guard.
13182         * common/scoped_restore.h: Rename include guard.
13183         * common/scoped_mmap.h: Rename include guard.
13184         * common/scoped_fd.h: Rename include guard.
13185         * common/safe-iterator.h: Rename include guard.
13186         * common/run-time-clock.h: Rename include guard.
13187         * common/refcounted-object.h: Rename include guard.
13188         * common/queue.h: Rename include guard.
13189         * common/ptid.h: Rename include guard.
13190         * common/print-utils.h: Rename include guard.
13191         * common/preprocessor.h: Rename include guard.
13192         * common/pathstuff.h: Rename include guard.
13193         * common/observable.h: Rename include guard.
13194         * common/netstuff.h: Rename include guard.
13195         * common/job-control.h: Rename include guard.
13196         * common/host-defs.h: Rename include guard.
13197         * common/gdb_wait.h: Rename include guard.
13198         * common/gdb_vecs.h: Rename include guard.
13199         * common/gdb_unlinker.h: Rename include guard.
13200         * common/gdb_unique_ptr.h: Rename include guard.
13201         * common/gdb_tilde_expand.h: Rename include guard.
13202         * common/gdb_sys_time.h: Rename include guard.
13203         * common/gdb_string_view.h: Rename include guard.
13204         * common/gdb_splay_tree.h: Rename include guard.
13205         * common/gdb_setjmp.h: Rename include guard.
13206         * common/gdb_ref_ptr.h: Rename include guard.
13207         * common/gdb_optional.h: Rename include guard.
13208         * common/gdb_locale.h: Rename include guard.
13209         * common/gdb_assert.h: Rename include guard.
13210         * common/filtered-iterator.h: Rename include guard.
13211         * common/filestuff.h: Rename include guard.
13212         * common/fileio.h: Rename include guard.
13213         * common/environ.h: Rename include guard.
13214         * common/common-utils.h: Rename include guard.
13215         * common/common-types.h: Rename include guard.
13216         * common/common-regcache.h: Rename include guard.
13217         * common/common-inferior.h: Rename include guard.
13218         * common/common-gdbthread.h: Rename include guard.
13219         * common/common-exceptions.h: Rename include guard.
13220         * common/common-defs.h: Rename include guard.
13221         * common/common-debug.h: Rename include guard.
13222         * common/cleanups.h: Rename include guard.
13223         * common/buffer.h: Rename include guard.
13224         * common/btrace-common.h: Rename include guard.
13225         * common/break-common.h: Rename include guard.
13226         * cli/cli-utils.h: Rename include guard.
13227         * cli/cli-style.h: Rename include guard.
13228         * cli/cli-setshow.h: Rename include guard.
13229         * cli/cli-script.h: Rename include guard.
13230         * cli/cli-interp.h: Rename include guard.
13231         * cli/cli-decode.h: Rename include guard.
13232         * cli/cli-cmds.h: Rename include guard.
13233         * charset-list.h: Add include guard.
13234         * buildsym-legacy.h: Rename include guard.
13235         * bfin-tdep.h: Add include guard.
13236         * ax.h: Rename include guard.
13237         * arm-linux-tdep.h: Add include guard.
13238         * arm-fbsd-tdep.h: Add include guard.
13239         * arch/xtensa.h: Rename include guard.
13240         * arch/tic6x.h: Add include guard.
13241         * arch/i386.h: Add include guard.
13242         * arch/arm.h: Rename include guard.
13243         * arch/arm-linux.h: Rename include guard.
13244         * arch/arm-get-next-pcs.h: Rename include guard.
13245         * arch/amd64.h: Add include guard.
13246         * arch/aarch64-insn.h: Rename include guard.
13247         * arch-utils.h: Rename include guard.
13248         * annotate.h: Add include guard.
13249         * amd64-darwin-tdep.h: Rename include guard.
13250         * aarch64-linux-tdep.h: Add include guard.
13251         * aarch64-fbsd-tdep.h: Add include guard.
13252         * aarch32-linux-nat.h: Add include guard.
13253
13254 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13255
13256         * macrotab.c (macro_define_internal): New function that
13257         factorizes macro_define_object_internal and macro_define_function
13258         code.
13259         (macro_define_object_internal): Use macro_define_internal.
13260         (macro_define_function): Likewise.
13261
13262 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13263
13264         * macrocmd.c (extract_identifier): Return
13265         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13266         callers.
13267
13268 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13269
13270         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13271
13272 2019-02-05  Tom Tromey  <tom@tromey.com>
13273
13274         * target.c (target_stack::unpush): Move assertion earlier.
13275
13276 2019-01-30  Tom Tromey  <tom@tromey.com>
13277
13278         PR python/23615:
13279         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13280         (gdbpy_parse_and_eval): Likewise.
13281         * python/python-internal.h (gdbpy_allow_threads): New class.
13282
13283 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13284
13285         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13286         (aarch64_fbsd_fpregmap): Move earlier.
13287         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13288         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13289         instead of individual calls to trad_frame_set_reg_addr.
13290         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13291         earlier.
13292         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13293         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13294         instead of individual calls to trad_frame_set_reg_addr.
13295
13296 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13297
13298         * CONTRIBUTE: Replace contribution list with wiki link.
13299
13300 2019-01-25  Tom Tromey  <tom@tromey.com>
13301
13302         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13303
13304 2019-01-25  Tom Tromey  <tom@tromey.com>
13305
13306         * xtensa-linux-nat.c: Fix common/ includes.
13307         * xml-support.h: Fix common/ includes.
13308         * xml-support.c: Fix common/ includes.
13309         * x86-linux-nat.c: Fix common/ includes.
13310         * windows-nat.c: Fix common/ includes.
13311         * varobj.h: Fix common/ includes.
13312         * varobj.c: Fix common/ includes.
13313         * value.c: Fix common/ includes.
13314         * valops.c: Fix common/ includes.
13315         * utils.c: Fix common/ includes.
13316         * unittests/xml-utils-selftests.c: Fix common/ includes.
13317         * unittests/utils-selftests.c: Fix common/ includes.
13318         * unittests/unpack-selftests.c: Fix common/ includes.
13319         * unittests/tracepoint-selftests.c: Fix common/ includes.
13320         * unittests/style-selftests.c: Fix common/ includes.
13321         * unittests/string_view-selftests.c: Fix common/ includes.
13322         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13323         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13324         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13325         * unittests/rsp-low-selftests.c: Fix common/ includes.
13326         * unittests/parse-connection-spec-selftests.c: Fix common/
13327         includes.
13328         * unittests/optional-selftests.c: Fix common/ includes.
13329         * unittests/offset-type-selftests.c: Fix common/ includes.
13330         * unittests/observable-selftests.c: Fix common/ includes.
13331         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13332         * unittests/memrange-selftests.c: Fix common/ includes.
13333         * unittests/memory-map-selftests.c: Fix common/ includes.
13334         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13335         * unittests/function-view-selftests.c: Fix common/ includes.
13336         * unittests/environ-selftests.c: Fix common/ includes.
13337         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13338         * unittests/common-utils-selftests.c: Fix common/ includes.
13339         * unittests/cli-utils-selftests.c: Fix common/ includes.
13340         * unittests/array-view-selftests.c: Fix common/ includes.
13341         * ui-file.c: Fix common/ includes.
13342         * tui/tui-io.c: Fix common/ includes.
13343         * tracepoint.h: Fix common/ includes.
13344         * tracepoint.c: Fix common/ includes.
13345         * tracefile-tfile.c: Fix common/ includes.
13346         * top.h: Fix common/ includes.
13347         * top.c: Fix common/ includes.
13348         * thread.c: Fix common/ includes.
13349         * target/waitstatus.h: Fix common/ includes.
13350         * target/waitstatus.c: Fix common/ includes.
13351         * target.h: Fix common/ includes.
13352         * target.c: Fix common/ includes.
13353         * target-memory.c: Fix common/ includes.
13354         * target-descriptions.c: Fix common/ includes.
13355         * symtab.h: Fix common/ includes.
13356         * symfile.c: Fix common/ includes.
13357         * stap-probe.c: Fix common/ includes.
13358         * spu-linux-nat.c: Fix common/ includes.
13359         * sparc-nat.c: Fix common/ includes.
13360         * source.c: Fix common/ includes.
13361         * solib.c: Fix common/ includes.
13362         * solib-target.c: Fix common/ includes.
13363         * ser-unix.c: Fix common/ includes.
13364         * ser-tcp.c: Fix common/ includes.
13365         * ser-pipe.c: Fix common/ includes.
13366         * ser-base.c: Fix common/ includes.
13367         * selftest-arch.c: Fix common/ includes.
13368         * s12z-tdep.c: Fix common/ includes.
13369         * rust-exp.y: Fix common/ includes.
13370         * rs6000-aix-tdep.c: Fix common/ includes.
13371         * riscv-tdep.c: Fix common/ includes.
13372         * remote.c: Fix common/ includes.
13373         * remote-notif.h: Fix common/ includes.
13374         * remote-fileio.h: Fix common/ includes.
13375         * remote-fileio.c: Fix common/ includes.
13376         * regcache.h: Fix common/ includes.
13377         * regcache.c: Fix common/ includes.
13378         * record-btrace.c: Fix common/ includes.
13379         * python/python.c: Fix common/ includes.
13380         * python/py-type.c: Fix common/ includes.
13381         * python/py-inferior.c: Fix common/ includes.
13382         * progspace.h: Fix common/ includes.
13383         * producer.c: Fix common/ includes.
13384         * procfs.c: Fix common/ includes.
13385         * proc-api.c: Fix common/ includes.
13386         * printcmd.c: Fix common/ includes.
13387         * ppc-linux-nat.c: Fix common/ includes.
13388         * parser-defs.h: Fix common/ includes.
13389         * osdata.c: Fix common/ includes.
13390         * obsd-nat.c: Fix common/ includes.
13391         * nat/x86-linux.c: Fix common/ includes.
13392         * nat/x86-linux-dregs.c: Fix common/ includes.
13393         * nat/x86-dregs.h: Fix common/ includes.
13394         * nat/x86-dregs.c: Fix common/ includes.
13395         * nat/ppc-linux.c: Fix common/ includes.
13396         * nat/mips-linux-watch.h: Fix common/ includes.
13397         * nat/mips-linux-watch.c: Fix common/ includes.
13398         * nat/linux-waitpid.c: Fix common/ includes.
13399         * nat/linux-ptrace.h: Fix common/ includes.
13400         * nat/linux-ptrace.c: Fix common/ includes.
13401         * nat/linux-procfs.c: Fix common/ includes.
13402         * nat/linux-personality.c: Fix common/ includes.
13403         * nat/linux-osdata.c: Fix common/ includes.
13404         * nat/linux-namespaces.c: Fix common/ includes.
13405         * nat/linux-btrace.h: Fix common/ includes.
13406         * nat/linux-btrace.c: Fix common/ includes.
13407         * nat/fork-inferior.c: Fix common/ includes.
13408         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13409         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13410         * nat/aarch64-linux.c: Fix common/ includes.
13411         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13412         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13413         * namespace.h: Fix common/ includes.
13414         * mips-linux-tdep.c: Fix common/ includes.
13415         * minsyms.c: Fix common/ includes.
13416         * mi/mi-parse.h: Fix common/ includes.
13417         * mi/mi-main.c: Fix common/ includes.
13418         * mi/mi-cmd-env.c: Fix common/ includes.
13419         * memrange.h: Fix common/ includes.
13420         * memattr.c: Fix common/ includes.
13421         * maint.h: Fix common/ includes.
13422         * maint.c: Fix common/ includes.
13423         * main.c: Fix common/ includes.
13424         * machoread.c: Fix common/ includes.
13425         * location.c: Fix common/ includes.
13426         * linux-thread-db.c: Fix common/ includes.
13427         * linux-nat.c: Fix common/ includes.
13428         * linux-fork.c: Fix common/ includes.
13429         * inline-frame.c: Fix common/ includes.
13430         * infrun.c: Fix common/ includes.
13431         * inflow.c: Fix common/ includes.
13432         * inferior.h: Fix common/ includes.
13433         * inferior.c: Fix common/ includes.
13434         * infcmd.c: Fix common/ includes.
13435         * inf-ptrace.c: Fix common/ includes.
13436         * inf-child.c: Fix common/ includes.
13437         * ia64-linux-nat.c: Fix common/ includes.
13438         * i387-tdep.c: Fix common/ includes.
13439         * i386-tdep.c: Fix common/ includes.
13440         * i386-linux-tdep.c: Fix common/ includes.
13441         * i386-linux-nat.c: Fix common/ includes.
13442         * i386-go32-tdep.c: Fix common/ includes.
13443         * i386-fbsd-tdep.c: Fix common/ includes.
13444         * i386-fbsd-nat.c: Fix common/ includes.
13445         * guile/scm-type.c: Fix common/ includes.
13446         * guile/guile.c: Fix common/ includes.
13447         * go32-nat.c: Fix common/ includes.
13448         * gnu-nat.c: Fix common/ includes.
13449         * gdbthread.h: Fix common/ includes.
13450         * gdbarch-selftests.c: Fix common/ includes.
13451         * gdb_usleep.c: Fix common/ includes.
13452         * gdb_select.h: Fix common/ includes.
13453         * gdb_bfd.c: Fix common/ includes.
13454         * gcore.c: Fix common/ includes.
13455         * fork-child.c: Fix common/ includes.
13456         * findvar.c: Fix common/ includes.
13457         * fbsd-nat.c: Fix common/ includes.
13458         * event-top.c: Fix common/ includes.
13459         * event-loop.c: Fix common/ includes.
13460         * dwarf2read.c: Fix common/ includes.
13461         * dwarf2loc.c: Fix common/ includes.
13462         * dwarf2-frame.c: Fix common/ includes.
13463         * dwarf-index-cache.c: Fix common/ includes.
13464         * dtrace-probe.c: Fix common/ includes.
13465         * disasm-selftests.c: Fix common/ includes.
13466         * defs.h: Fix common/ includes.
13467         * csky-tdep.c: Fix common/ includes.
13468         * cp-valprint.c: Fix common/ includes.
13469         * cp-support.h: Fix common/ includes.
13470         * cp-support.c: Fix common/ includes.
13471         * corelow.c: Fix common/ includes.
13472         * completer.h: Fix common/ includes.
13473         * completer.c: Fix common/ includes.
13474         * compile/compile.c: Fix common/ includes.
13475         * compile/compile-loc2c.c: Fix common/ includes.
13476         * compile/compile-cplus-types.c: Fix common/ includes.
13477         * compile/compile-cplus-symbols.c: Fix common/ includes.
13478         * command.h: Fix common/ includes.
13479         * cli/cli-dump.c: Fix common/ includes.
13480         * cli/cli-cmds.c: Fix common/ includes.
13481         * charset.c: Fix common/ includes.
13482         * build-id.c: Fix common/ includes.
13483         * btrace.h: Fix common/ includes.
13484         * btrace.c: Fix common/ includes.
13485         * breakpoint.h: Fix common/ includes.
13486         * breakpoint.c: Fix common/ includes.
13487         * ax.h:
13488         (enum agent_op): Fix common/ includes.
13489         * ax-general.c (struct aop_map): Fix common/ includes.
13490         * ax-gdb.c: Fix common/ includes.
13491         * auxv.c: Fix common/ includes.
13492         * auto-load.c: Fix common/ includes.
13493         * arm-tdep.c: Fix common/ includes.
13494         * arch/riscv.c: Fix common/ includes.
13495         * arch/ppc-linux-common.c: Fix common/ includes.
13496         * arch/i386.c: Fix common/ includes.
13497         * arch/arm.c: Fix common/ includes.
13498         * arch/arm-linux.c: Fix common/ includes.
13499         * arch/arm-get-next-pcs.c: Fix common/ includes.
13500         * arch/amd64.c: Fix common/ includes.
13501         * arch/aarch64.c: Fix common/ includes.
13502         * arch/aarch64-insn.c: Fix common/ includes.
13503         * arch-utils.c: Fix common/ includes.
13504         * amd64-windows-tdep.c: Fix common/ includes.
13505         * amd64-tdep.c: Fix common/ includes.
13506         * amd64-sol2-tdep.c: Fix common/ includes.
13507         * amd64-obsd-tdep.c: Fix common/ includes.
13508         * amd64-nbsd-tdep.c: Fix common/ includes.
13509         * amd64-linux-tdep.c: Fix common/ includes.
13510         * amd64-linux-nat.c: Fix common/ includes.
13511         * amd64-fbsd-tdep.c: Fix common/ includes.
13512         * amd64-fbsd-nat.c: Fix common/ includes.
13513         * amd64-dicos-tdep.c: Fix common/ includes.
13514         * amd64-darwin-tdep.c: Fix common/ includes.
13515         * agent.c: Fix common/ includes.
13516         * ada-lang.h: Fix common/ includes.
13517         * ada-lang.c: Fix common/ includes.
13518         * aarch64-tdep.c: Fix common/ includes.
13519
13520 2019-01-25  Tom Tromey  <tom@tromey.com>
13521
13522         * common/create-version.sh: Use common/version.h.
13523
13524 2019-01-24  Pedro Alves  <palves@redhat.com>
13525
13526         * infrun.c (signal_stop, signal_print, signal_program)
13527         (signal_catch, signal_pass): Now arrays instead of pointers.
13528         (update_signals_program_target, do_target_resume)
13529         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13530         * linux-nat.c (linux_nat_target::pass_signals)
13531         (linux_nat_target::create_inferior, linux_nat_target::attach):
13532         Adjust.
13533         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13534         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13535         * procfs.c (procfs_target::pass_signals): Adjust.
13536         * record-full.c (record_full_target::resume): Adjust.
13537         * remote.c (remote_target::pass_signals)
13538         (remote_target::program_signals): Adjust.
13539         * target-debug.h (target_debug_print_signals): Now takes a
13540         gdb::array_view as parameter.  Adjust.
13541         * target.h (target_ops) <pass_signals, program_signals>: Replace
13542         pointer and length parameters with gdb::array_view.
13543         (target_pass_signals, target_program_signals): Likewise.
13544         * target-delegates.c: Regenerate.
13545
13546 2019-01-24  Pedro Alves  <palves@redhat.com>
13547
13548         * common/forward-scope-exit.h
13549         (forward_scope_exit::forward_scope_exit): Pass arguments to
13550         m_bind_function directly, instead of creating a std::bind and
13551         copying that.
13552
13553 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13554
13555         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13556         for static members.
13557         (pass_in_v_vfp_candidate): Likewise.
13558
13559 2019-01-23  Tom Tromey  <tom@tromey.com>
13560             Pedro Alves  <palves@redhat.com>
13561
13562         * regcache.c (class regcache_invalidator): Remove.
13563         (regcache::raw_write): Use make_scope_exit.
13564
13565 2019-01-23  Tom Tromey  <tom@tromey.com>
13566
13567         * ui-out.h (class ui_out_emit_type): Update comment.
13568
13569 2019-01-23  Tom Tromey  <tom@tromey.com>
13570
13571         * infrun.c (fetch_inferior_event): Update comment.
13572
13573 2019-01-23  Tom Tromey  <tom@tromey.com>
13574             Pedro Alves  <palves@redhat.com>
13575
13576         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13577         parameter.
13578         (fetch_inferior_event): Use SCOPE_EXIT.
13579
13580
13581 2019-01-23  Tom Tromey  <tom@tromey.com>
13582             Pedro Alves  <palves@redhat.com>
13583
13584         * infrun.c (disable_thread_events): Delete.
13585         (stop_all_threads): Use SCOPE_EXIT.
13586
13587 2019-01-23  Tom Tromey  <tom@tromey.com>
13588             Pedro Alves  <palves@redhat.com>
13589
13590         * symfile.c: Include forward-scope-exit.h.
13591         (clear_symtab_users_cleanup): Replace forward declaration with
13592         a FORWARD_SCOPE_EXIT.
13593         (syms_from_objfile_1): Use the forward_scope_exit and
13594         gdb::optional instead of cleanup_function.
13595         (reread_symbols): Use the forward_scope_exit instead of
13596         cleanup_function.
13597         (clear_symtab_users_cleanup): Remove function.
13598
13599 2019-01-23  Tom Tromey  <tom@tromey.com>
13600             Pedro Alves  <palves@redhat.com>
13601
13602         * linux-nat.c: Include scope-exit.h.
13603         (cleanup_target_stop): Remove.
13604         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13605         SCOPE_EXIT.
13606
13607 2019-01-23  Tom Tromey  <tom@tromey.com>
13608             Pedro Alves  <palves@redhat.com>
13609
13610         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13611         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13612
13613 2019-01-23  Tom Tromey  <tom@tromey.com>
13614             Andrew Burgess  <andrew.burgess@embecosm.com>
13615             Pedro Alves  <palves@redhat.com>
13616
13617         * infrun.c (fetch_inferior_event): Use scope_exit.
13618         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13619         * top.c (execute_command): Use scope_exit.
13620         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13621         * utils.c (do_bpstat_clear_actions_cleanup)
13622         (make_bpstat_clear_actions_cleanup): Remove.
13623
13624 2019-01-23  Tom Tromey  <tom@tromey.com>
13625             Pedro Alves  <palves@redhat.com>
13626
13627         * infrun.c: Include "common/scope-exit.h"
13628         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13629         (wait_for_inferior): Use SCOPE_EXIT.
13630         (fetch_inferior_event): Use scope_exit.
13631
13632 2019-01-23  Tom Tromey  <tom@tromey.com>
13633             Pedro Alves  <palves@redhat.com>
13634
13635         * breakpoint.c (create_breakpoint): Remove cleanup.
13636
13637 2019-01-23  Tom Tromey  <tom@tromey.com>
13638             Andrew Burgess  <andrew.burgess@embecosm.com>
13639             Pedro Alves  <palves@redhat.com>
13640
13641 2019-01-23  Pedro Alves  <palves@redhat.com>
13642
13643         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13644
13645 2019-01-23  Pedro Alves  <palves@redhat.com>
13646             Andrew Burgess  <andrew.burgess@embecosm.com>
13647
13648         * gdbthread.h: Include "common/forward-scope-exit.h".
13649         (scoped_finish_thread_state): Redefine custom class in terms of
13650         forward_scope_exit.
13651
13652 2019-01-23  Pedro Alves  <palves@redhat.com>
13653             Andrew Burgess  <andrew.burgess@embecosm.com>
13654
13655         * common/forward-scope-exit.h: New file.
13656
13657 2019-01-23  Pedro Alves  <palves@redhat.com>
13658             Andrew Burgess  <andrew.burgess@embecosm.com>
13659             Tom Tromey  <tom@tromey.com>
13660
13661         * common/scope-exit.h: New file.
13662
13663 2019-01-23  Pedro Alves  <palves@redhat.com>
13664
13665         * common/preprocessor.h (ESC): Rename to ...
13666         (ESC_PARENS): ... this.
13667         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13668         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13669
13670 2019-01-23  Tom Tromey  <tom@tromey.com>
13671
13672         * language.h (class scoped_switch_to_sym_language_if_auto):
13673         Initialize m_lang in both cases.
13674
13675 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13676
13677         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13678         with XCNEW.
13679
13680 2019-01-22  Tom Tromey  <tom@tromey.com>
13681
13682         * corelow.c: Do not include sys/file.h.
13683
13684 2019-01-22  Tom Tromey  <tom@tromey.com>
13685
13686         * tui/tui-wingeneral.h: Include gdb_curses.h.
13687
13688 2019-01-22  Tom Tromey  <tom@tromey.com>
13689
13690         * source-cache.h (class source_cache) <get_source_lines,
13691         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13692
13693 2019-01-22  Tom Tromey  <tom@tromey.com>
13694
13695         * remote-fileio.h (struct remote_target): Declare.
13696
13697 2019-01-22  Tom Tromey  <tom@tromey.com>
13698
13699         * python/py-arch.c: Do not include py-ref.h.
13700         * python/py-bpevent.c: Do not include py-ref.h.
13701         * python/py-cmd.c: Do not include py-ref.h.
13702         * python/py-continueevent.c: Do not include py-ref.h.
13703         * python/py-event.h: Do not include py-ref.h.
13704         * python/py-evtregistry.c: Do not include py-ref.h.
13705         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13706         * python/py-frame.c: Do not include py-ref.h.
13707         * python/py-framefilter.c: Do not include py-ref.h.
13708         * python/py-function.c: Do not include py-ref.h.
13709         * python/py-infevents.c: Do not include py-ref.h.
13710         * python/py-linetable.c: Do not include py-ref.h.
13711         * python/py-objfile.c: Do not include py-ref.h.
13712         * python/py-param.c: Do not include py-ref.h.
13713         * python/py-prettyprint.c: Do not include py-ref.h.
13714         * python/py-progspace.c: Do not include py-ref.h.
13715         * python/py-symbol.c: Do not include py-ref.h.
13716         * python/py-symtab.c: Do not include py-ref.h.
13717         * python/py-type.c: Do not include py-ref.h.
13718         * python/py-unwind.c: Do not include py-ref.h.
13719         * python/py-utils.c: Do not include py-ref.h.
13720         * python/py-value.c: Do not include py-ref.h.
13721         * python/py-varobj.c: Do not include py-ref.h.
13722         * python/py-xmethods.c: Do not include py-ref.h.
13723         * python/python.c: Do not include py-ref.h.
13724         * varobj.c: Do not include py-ref.h.
13725
13726 2019-01-22  Tom Tromey  <tom@tromey.com>
13727
13728         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13729         keyword for bcache.
13730
13731 2019-01-22  Tom Tromey  <tom@tromey.com>
13732
13733         * compile/compile-cplus-types.c: Remove a comment by #include.
13734
13735 2019-01-22  Tom Tromey  <tom@tromey.com>
13736
13737         * compile/gcc-c-plugin.h: Include compile-internal.h.
13738
13739 2019-01-22  Tom Tromey  <tom@tromey.com>
13740
13741         * stabsread.c (EXTERN): Do not define.
13742         (symnum, next_symbol_text_func, processing_gcc_compilation)
13743         (within_function, global_sym_chain, global_stabs)
13744         (previous_stab_code, this_object_header_files)
13745         (n_this_object_header_files)
13746         (n_allocated_this_object_header_files): Define.
13747         * stabsread.h (EXTERN): Never define.  Use "extern".
13748
13749 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13750
13751         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13752         history_value.
13753
13754 2019-01-21  Tom Tromey  <tom@tromey.com>
13755
13756         * ui-out.c: Fix includes.
13757         * tui/tui-source.c: Fix includes.
13758         * target.c: Fix includes.
13759         * remote.c: Fix includes.
13760         * regcache.c: Fix includes.
13761         * python/py-block.c: Fix includes.
13762         * printcmd.c: Fix includes.
13763         * or1k-tdep.c: Fix includes.
13764         * mi/mi-main.c: Fix includes.
13765         * m32r-tdep.c: Fix includes.
13766         * csky-tdep.c: Fix includes.
13767         * compile/compile-cplus-types.c: Fix includes.
13768         * cli/cli-interp.c: Fix includes.
13769
13770 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13771
13772         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13773         for padding.
13774
13775 2019-01-16  Tom Tromey  <tom@tromey.com>
13776
13777         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13778         earlier.
13779         (struct objfile) <msymbols_range>: Move from top level.
13780         <msymbols>: New method.
13781         (class objfile_msymbols): Remove.
13782         * symtab.c (default_collect_symbol_completion_matches_break_on):
13783         Update.
13784         * symmisc.c (dump_msymbols): Update.
13785         * stabsread.c (scan_file_globals): Update.
13786         * objc-lang.c (info_selectors_command, info_classes_command)
13787         (find_methods): Update.
13788         * minsyms.c (find_solib_trampoline_target): Update.
13789         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13790         * coffread.c (coff_symfile_read): Update.
13791         * ada-lang.c (ada_lookup_simple_minsym)
13792         (ada_collect_symbol_completion_matches): Update.
13793
13794 2019-01-16  Tom Tromey  <tom@tromey.com>
13795
13796         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13797         type.  Remove no-argument constructor.
13798         <iterator::operator++>: Simplify.
13799         <begin>: Update.
13800         <end>: Use minimal_symbol_count.
13801
13802 2019-01-16  Tom Tromey  <tom@tromey.com>
13803
13804         * objfiles.h (struct objfile) <psymtabs>: New method.
13805         (class objfile_psymtabs): Remove.
13806         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13807         typedef.
13808         <range>: New method.
13809         (require_partial_symbols): Change return type.
13810         * psymtab.c (require_partial_symbols)
13811         (psym_expand_symtabs_matching): Update.
13812         * mdebugread.c (parse_partial_symbols): Update.
13813         * dbxread.c (dbx_end_psymtab): Update.
13814
13815 2019-01-15  Tom Tromey  <tom@tromey.com>
13816
13817         * symtab.c (lookup_objfile_from_block)
13818         (lookup_symbol_in_objfile_symtabs)
13819         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13820         (find_line_symtab, info_sources_command)
13821         (default_collect_symbol_completion_matches_break_on)
13822         (make_source_files_completion_list): Update.
13823         * symmisc.c (print_objfile_statistics, dump_objfile)
13824         (maintenance_print_symbols, maintenance_info_symtabs)
13825         (maintenance_check_symtabs, maintenance_info_line_tables):
13826         Update.
13827         * source.c (select_source_symtab)
13828         (forget_cached_source_info_for_objfile): Update.
13829         * objfiles.h (class objfile_compunits): Remove.
13830         (struct objfile) <compunits_range>: New typedef.
13831         (compunits): New method.
13832         * objfiles.c (objfile_relocate1): Update.
13833         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13834         * maint.c (count_symtabs_and_blocks): Update.
13835         * linespec.c (iterate_over_all_matching_symtabs): Update.
13836         * cp-support.c (add_symbol_overload_list_qualified): Update.
13837         * coffread.c (coff_symtab_read): Update.
13838         * ada-lang.c (add_nonlocal_symbols)
13839         (ada_collect_symbol_completion_matches)
13840         (ada_add_global_exceptions): Update.
13841
13842 2019-01-15  Tom Tromey  <tom@tromey.com>
13843
13844         * progspace.h (program_space) <objfiles_safe_range>: New
13845         typedef.
13846         <objfiles_safe>: New method.
13847         * objfiles.h (class all_objfiles_safe): Remove.
13848         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13849         * jit.c (jit_inferior_exit_hook): Update.
13850
13851 2019-01-17  Tom Tromey  <tom@tromey.com>
13852
13853         * progspace.h (program_space) <objfiles_range>: New typedef.
13854         <objfiles>: New method.
13855         <objfiles_head>: Rename from objfiles.
13856         (object_files): Update.
13857         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13858         * guile/scm-pretty-print.c
13859         (ppscm_find_pretty_printer_from_objfiles): Update.
13860         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13861         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13862         Update.
13863         * python/py-progspace.c (pspy_get_objfiles): Update.
13864         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13865         Update.
13866         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13867         (objfpy_lookup_objfile_by_build_id): Update.
13868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13869         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13870         Update.
13871         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13872         (expand_symtab_containing_pc, lookup_objfile_from_block)
13873         (lookup_static_symbol, basic_lookup_transparent_type)
13874         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13875         (find_line_symtab, info_sources_command)
13876         (default_collect_symbol_completion_matches_break_on)
13877         (make_source_files_completion_list, find_main_name): Update.
13878         * symmisc.c (print_symbol_bcache_statistics)
13879         (print_objfile_statistics, maintenance_print_symbols)
13880         (maintenance_print_msymbols, maintenance_print_objfiles)
13881         (maintenance_info_symtabs, maintenance_check_symtabs)
13882         (maintenance_expand_symtabs, maintenance_info_line_tables):
13883         Update.
13884         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13885         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13886         (map_overlay_command, unmap_overlay_command)
13887         (simple_overlay_update, expand_symtabs_matching)
13888         (map_symbol_filenames): Update.
13889         * symfile-debug.c (set_debug_symfile): Update.
13890         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13891         Update.
13892         * source.c (select_source_symtab, forget_cached_source_info):
13893         Update.
13894         * solib.c (solib_read_symbols): Update.
13895         * solib-spu.c (append_ocl_sos): Update.
13896         * psymtab.c (maintenance_print_psymbols)
13897         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13898         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13899         * printcmd.c (info_symbol_command): Update.
13900         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13901         Update.
13902         * objfiles.h (class all_objfiles): Remove.
13903         * objfiles.c (have_partial_symbols, have_full_symbols)
13904         (have_minimal_symbols, qsort_cmp, update_section_map)
13905         (shared_objfile_contains_address_p)
13906         (default_iterate_over_objfiles_in_search_order): Update.
13907         * objc-lang.c (info_selectors_command, info_classes_command)
13908         (find_methods): Update.
13909         * minsyms.c (find_solib_trampoline_target): Update.
13910         * maint.c (maintenance_info_sections)
13911         (maintenance_translate_address, count_symtabs_and_blocks):
13912         Update.
13913         * main.c (captured_main_1): Update.
13914         * linux-thread-db.c (try_thread_db_load_from_pdir)
13915         (has_libpthread): Update.
13916         * linespec.c (iterate_over_all_matching_symtabs)
13917         (search_minsyms_for_name): Update.
13918         * jit.c (jit_find_objf_with_entry_addr): Update.
13919         * hppa-tdep.c (find_unwind_entry)
13920         (hppa_lookup_stub_minimal_symbol): Update.
13921         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13922         Update.
13923         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13924         (elf_gnu_ifunc_resolve_by_got): Update.
13925         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13926         * dwarf-index-write.c (save_gdb_index_command): Update.
13927         * cp-support.c (add_symbol_overload_list_qualified): Update.
13928         * breakpoint.c (create_overlay_event_breakpoint)
13929         (create_longjmp_master_breakpoint)
13930         (create_std_terminate_master_breakpoint)
13931         (create_exception_master_breakpoint): Update.
13932         * blockframe.c (find_pc_partial_function): Update.
13933         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13934         (ada_collect_symbol_completion_matches)
13935         (ada_add_global_exceptions): Update.
13936
13937 2019-01-17  Tom Tromey  <tom@tromey.com>
13938
13939         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13940         declare VEC.
13941         (solib_target_parse_libraries): Change return type.
13942         (library_list_start_segment, library_list_start_section)
13943         (library_list_end_library, library_list_start_library); Update.
13944         (solib_target_free_library_list): Remove.
13945         (solib_target_parse_libraries): Remove cleanup.  Change return
13946         type.
13947         (solib_target_current_sos): Update.
13948
13949 2019-01-17  Tom Tromey  <tromey@bapiya>
13950
13951         * valprint.c: Replace "the the" with "the".
13952         * symtab.c: Replace "the the" with "the".
13953         * solib.c: Replace "the the" with "the".
13954         * solib-dsbt.c: Replace "the the" with "the".
13955         * linespec.c: Replace "the the" with "the".
13956         * dwarf2loc.h: Replace "the the" with "the".
13957         * amd64-windows-tdep.c: Replace "the the" with "the".
13958         * aarch64-tdep.c: Replace "the the" with "the".
13959
13960 2019-01-16  Keith Seitz  <keiths@redhat.com>
13961
13962         PR gdb/23773
13963         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13964         <builder>: Rename to ..
13965         <m_builder>: ... this and make private.
13966         (dwarf2_cu::get_builder): New method.  Change all users of
13967         `builder' to use this method.
13968         (dwarf2_start_symtab): Move to ...
13969         (dwarf2_cu::start_symtab): ... here.  Update all callers
13970         (setup_type_unit_groups): Move to ...
13971         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13972         callers.
13973         (dwarf2_cu::reset_builder): New method.
13974         (process_full_compunit, process_full_type_unit): Use
13975         dwarf2_cu::reset_builder.
13976         (follow_die_offset): Record the ancestor CU if it is different
13977         from the followed DIE's CU.
13978         (follow_die_sig_1): Likewise.
13979
13980 2019-01-15  Tom Tromey  <tom@tromey.com>
13981
13982         * remote.c (class remote_state) <buf>: Now a char_vector.
13983         <buf_size>: Remove.
13984         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13985         parameter.
13986         (remote_target::getpkt_or_notif_sane_1)
13987         (remote_target::getpkt_sane)
13988         (remote_target::getpkt_or_notif_sane): Likewise.
13989         (class remote_target) <putpkt>: New overload.
13990         (remote_target::read_frame): Change type of "buf_p".  Remove
13991         sizeof_p parameter.
13992         (packet_ok): New overload.
13993         (packet_check_result): New overload.
13994         Update all uses.
13995
13996 2019-01-14  Tom Tromey  <tom@tromey.com>
13997
13998         * remote-notif.c (handle_notification, remote_notif_ack)
13999         (remote_notif_parse): Make "buf" const.
14000         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14001         const.
14002         (remote_notif_parse, remote_notif_ack, handle_notification):
14003         Likewise.
14004         * remote.c (remote_notif_stop_parse): Make "buf" const.
14005         (remote_target::remote_parse_stop_reply): Make "buf" const.
14006         (remote_notif_stop_ack): Make "buf" const.
14007
14008 2019-01-14  Tom Tromey  <tom@tromey.com>
14009
14010         * remote.c (remote_console_output): Make parameter const.
14011
14012 2019-01-14  Tom Tromey  <tom@tromey.com>
14013
14014         * target-debug.h (target_debug_print_signals): Constify.
14015         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14016         * procfs.c (procfs_target::pass_signals): Update.
14017         * linux-nat.c (linux_nat_target::pass_signals): Update.
14018         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14019         * target-delegates.c: Rebuild.
14020         * remote.c (remote_target::program_signals): Update.
14021         (remote_target::pass_signals): Update.
14022         * target.c (target_pass_signals): Constify argument.
14023         (target_program_signals): Likewise.
14024         * target.h (struct target_ops) <pass_signals, program_signals>:
14025         Constify argument.
14026         (target_pass_signals, target_program_signals): Constify argument.
14027
14028 2019-01-14  Tom Tromey  <tom@tromey.com>
14029
14030         PR tui/28819:
14031         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14032
14033 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14034
14035         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14036         field.
14037         * rs6000-tdep.c: Include reggroups.h.
14038         (IS_V_ALIAS_PSEUDOREG): Define.
14039         (rs6000_register_name): Return names for the "vX" aliases.
14040         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14041         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14042         aliases.  Call default_register_reggroup_p for all other
14043         pseudo-registers.
14044         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14045         New functions.
14046         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14047         Handle "vX" aliases.
14048         (v_alias_pseudo_register_collect): New function.
14049         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14050         (rs6000_gdbarch_init): Initialize "vX" aliases as
14051         pseudo-registers.  Restore registration of
14052         rs6000_pseudo_register_reggroup_p with
14053         set_tdesc_pseudo_register_reggroup_p.
14054
14055 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14056
14057         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14058         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14059         set_gdbarch_num_pseudo_regs.
14060
14061 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14062
14063         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14064         Remove arg prefixname, add do_set and do_show.
14065         Add member functions set_list and show_list.
14066         * cli/cli-style.c (class cli_style_option): Update accordingly.
14067         (style_set_list): Move to file scope.
14068         (style_show_list): Likewise.
14069         (set_style): Call help_list.
14070         (show_style): Call cmd_show_list.
14071         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14072         Update to use the new macro.
14073
14074 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14075
14076         * ada-lang.c (_initialize_ada_language): Expand the help text
14077         for the "catch exception" command.
14078
14079 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14080
14081         * symtab.c (matching_obj_sections): Initialize obj,
14082         declare it closer to its usage.
14083
14084 2019-01-10  Tom Tromey  <tom@tromey.com>
14085
14086         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14087         (basic_inf_threads_range): Remove.
14088         (inf_threads_range, inf_non_exited_threads_range)
14089         (safe_inf_threads_range): Use next_adapter.
14090
14091 2019-01-10  Keith Seitz  <keiths@redhat.com>
14092
14093         PR gdb/23712
14094         PR symtab/23010
14095         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14096         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14097
14098 2019-01-10  Keith Seitz  <keiths@redhat.com>
14099
14100         PR gdb/23712
14101         PR symtab/23010
14102         * dictionary.c (pending_to_vector): Remove.
14103         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14104         Remove _1 suffix, replacing functions of the same name.  Update
14105         all callers.
14106         (dict_create_hashed, dict_create_hashed_expandable)
14107         (dict_create_linear, dict_create_linear_expandable, dict_free)
14108         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14109         Make functions static.
14110
14111 2019-01-10  Keith Seitz  <keiths@redhat.com>
14112
14113         PR gdb/23712
14114         PR symtab/23010
14115         * dictionary.h (struct dictionary): Replace declaration with
14116         multidictionary.
14117         (dict_create_hashed, dict_create_hashed_expandable)
14118         (dict_create_linear, dict_create_linear_expandable)
14119         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14120         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14121         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14122         taking multidictionary argument.
14123         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14124         * block.h (struct block) <dict>: Change to multidictionary
14125         and rename `multidict'.
14126         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14127         symmisc.c: Update all dictionary references to multidictionary.
14128
14129 2019-01-10  Keith Seitz  <keiths@redhat.com>
14130
14131         PR gdb/23712
14132         PR symtab/23010
14133         * dictionary.c: Include unordered_map.
14134         (pending_to_vector): New function.
14135         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14136         Rewrite the non-"_1" functions to take vector instead
14137         of linked list.
14138         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14139         "new" _1 versions of the same name.
14140         (multidictionary): Define.
14141         (std::hash<enum language): New definition.
14142         (collate_pending_symbols_by_language, mdict_create_hashed)
14143         (mdict_create_hashed_expandable, mdict_create_linear)
14144         (mdict_create_linear_expandable, mdict_free)
14145         (find_language_dictionary, create_new_language_dictionary)
14146         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14147         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14148         (mdict_size, mdict_empty): New functions.
14149         * dictionary.h (mdict_iterator): Define.
14150
14151 2019-01-10  Pedro Alves  <palves@redhat.com>
14152
14153         * breakpoint.c (read_uploaded_action)
14154         (create_tracepoint_from_upload): Adjust to use
14155         gdb::unique_xmalloc_ptr.
14156         * ctf.c (ctf_write_uploaded_tp):
14157         (SET_ARRAY_FIELD): Use emplace_back.
14158         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14159         * tracefile-tfile.c (tfile_write_uploaded_tp):
14160         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14161         gdb::unique_xmalloc_ptr.
14162         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14163         at_string, cond_string, cmd_strings>: Replace char pointers
14164         with gdb::unique_xmalloc_ptr.
14165
14166 2019-01-10  Pedro Alves  <palves@redhat.com>
14167
14168         * solib-target.c (library_list_start_library): Don't xstrdup name.
14169
14170 2019-01-10  Pedro Alves  <palves@redhat.com>
14171
14172         * mdebugread.c (parse_partial_symbols): Use
14173         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14174
14175 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14176
14177         * linux-fork.c (scoped_switch_fork_info)
14178         <~scoped_switch_fork_info>: Fix incorrect variable name.
14179
14180 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14181
14182         * linux-fork.c (scoped_switch_fork_info)
14183         <scoped_switch_fork_info>: Make explicit.
14184         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14185
14186 2019-01-10  Tom Tromey  <tom@tromey.com>
14187
14188         * objfiles.h (objfile::reset_psymtabs): Update.
14189         * objfiles.c (objfile::objfile): Update.
14190         * psymtab.h (psymtab_storage::obstack): Update.
14191         (psymtab_storage::m_obstack): Use gdb::optional.
14192         (class psymtab_storage): Update comment.  Remove objfile
14193         parameter.
14194         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14195
14196 2019-01-10  Tom Tromey  <tom@tromey.com>
14197
14198         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14199         <free_psymtabs>: Now private.
14200         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14201         (allocate_psymtab): Use new method.
14202
14203 2019-01-10  Tom Tromey  <tom@tromey.com>
14204
14205         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14206         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14207         * mdebugread.c (parse_partial_symbols): Use
14208         allocate_dependencies.
14209         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14210         allocate_dependencies.
14211         (process_psymtab_comp_unit_reader)
14212         (build_type_psymtab_dependencies): Likewise.
14213         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14214
14215 2019-01-10  Tom Tromey  <tom@tromey.com>
14216
14217         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14218         PSYMBOL_SET_LANGUAGE.
14219         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14220
14221 2019-01-10  Tom Tromey  <tom@tromey.com>
14222
14223         * psymtab.h (psymtab_storage::obstack): New method.
14224         <m_obstack>: Rename from obstack; now private.
14225         * psymtab.c (psymtab_storage): Update.
14226         * dwarf2read.c (create_addrmap_from_index)
14227         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14228         Update.
14229
14230 2019-01-10  Tom Tromey  <tom@tromey.com>
14231
14232         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14233         * objfiles.h (objfile::reset_psymtabs): New method.
14234
14235 2019-01-10  Tom Tromey  <tom@tromey.com>
14236
14237         * symmisc.c (print_symbol_bcache_statistics): Update.
14238         (print_objfile_statistics): Update.
14239         * symfile.c (reread_symbols): Update.
14240         * psymtab.h (class psymtab_storage): New.
14241         * psymtab.c (psymtab_storage): New constructor.
14242         (~psymtab_storage): New destructor.
14243         (require_partial_symbols): Update.
14244         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14245         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14246         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14247         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14248         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14249         (start_psymtab_common, end_psymtab_common)
14250         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14251         (allocate_psymtab): Update.
14252         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14253         Update.
14254         (dump_psymtab_addrmap, maintenance_print_psymbols)
14255         (maintenance_check_psymtabs): Update.
14256         (class objfile_psymtabs): Move to objfiles.h.
14257         * psympriv.h (discard_psymtab): Now inline.
14258         (psymtab_discarder::psymtab_discarder): Update.
14259         (psymtab_discarder::~psymtab_discarder): Update.
14260         (ALL_OBJFILE_PSYMTABS): Rewrite.
14261         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14262         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14263         Remove fields.
14264         <partial_symtabs>: New field.
14265         (class objfile_psymtabs): Move from psymtab.h.  Update.
14266         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14267         psymbol_cache.
14268         (objfile::~objfile): Don't destroy psymbol_cache.
14269         * mdebugread.c (parse_partial_symbols): Update.
14270         * dwarf2read.c (create_addrmap_from_index)
14271         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14272         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14273         (add_partial_subprogram, dwarf2_ranges_read): Update.
14274         * dwarf-index-write.c (write_address_map)
14275         (write_one_signatured_type, recursively_write_psymbols)
14276         (class debug_names, class debug_names, write_psymtabs_to_index):
14277         Update.
14278
14279 2019-01-10  Tom Tromey  <tom@tromey.com>
14280
14281         * symtab.h (SYMBOL_SET_NAMES): Update.
14282         (symbol_set_names): Update.
14283         (MSYMBOL_SET_NAMES): Update.
14284         * symtab.c (symbol_set_names): Change argument to be an
14285         objfile_per_bfd_storage.
14286         * psymtab.c (add_psymbol_to_bcache): Update.
14287         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14288
14289 2019-01-10  Tom Tromey  <tom@tromey.com>
14290
14291         * symtab.c (create_demangled_names_hash): Change argument to be an
14292         objfile_per_bfd_storage.
14293         (symbol_set_names): Update.
14294
14295 2019-01-10  Tom Tromey  <tom@tromey.com>
14296
14297         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14298         init_psymbol_list.
14299         * psymtab.c (init_psymbol_list): Do nothing if already called.
14300         * psympriv.h (init_psymbol_list): Add comment.
14301         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14302         init_psymbol_list.
14303         * dbxread.c (dbx_symfile_read): Unconditionally call
14304         init_psymbol_list.
14305
14306 2019-01-10  Tom Tromey  <tom@tromey.com>
14307
14308         * xcoffread.c (scan_xcoff_symtab): Update.
14309         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14310         "where".
14311         * mdebugread.c (parse_partial_symbols)
14312         (handle_psymbol_enumerators): Update.
14313         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14314         * dbxread.c (read_dbx_symtab): Update.
14315         * psympriv.h (psymbol_placement): New enum.
14316         (add_psymbol_to_list): Update.
14317
14318 2019-01-10  Tom Tromey  <tom@tromey.com>
14319
14320         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14321         static_psymbols parameters.
14322         (scan_xcoff_symtab): Update.
14323         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14324         static_psymbols parameters.
14325         * psympriv.h (start_psymtab_common): Update.
14326         * mdebugread.c (parse_partial_symbols): Update.
14327         * dwarf2read.c (create_partial_symtab): Update.
14328         * dbxread.c (read_dbx_symtab): Update.
14329         (start_psymtab): Remove global_psymbols and static_psymbols
14330         parameters.
14331
14332 2019-01-10  Tom Tromey  <tom@tromey.com>
14333
14334         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14335         * psymtab.c (allocate_psymtab): Add comment.
14336         * psympriv.h (allocate_psymtab): Add comment.
14337         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14338         initializations.
14339         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14340
14341 2019-01-10  Tom Tromey  <tom@tromey.com>
14342
14343         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14344         Don't declare.
14345         * mipsread.c: Include mdebugread.h.
14346         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14347         Declare.
14348         * elfread.c: Include mdebugread.h.
14349
14350 2019-01-09  Tom Tromey  <tom@tromey.com>
14351
14352         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14353         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14354         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14355         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14356         (psym_lookup_symbol, psym_find_last_source_symtab)
14357         (psym_forget_cached_source_info, psym_print_stats)
14358         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14359         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14360         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14361         (psym_find_compunit_symtab_by_address)
14362         (maintenance_print_psymbols, maintenance_info_psymtabs)
14363         (maintenance_check_psymtabs): Use ranged for.
14364         * psymtab.h (class objfile_psymtabs): New.
14365         (require_partial_symbols): Return objfile_psymtabs.
14366         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14367
14368 2019-01-09  Tom Tromey  <tom@tromey.com>
14369
14370         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14371         (find_pc_mapped_section, list_overlays_command)
14372         (map_overlay_command, unmap_overlay_command)
14373         (simple_overlay_update): Use all_objfiles.
14374         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14375         * printcmd.c (info_symbol_command): Use all_objfiles.
14376         * objfiles.h (ALL_OBJSECTIONS): Remove.
14377         * maint.c (maintenance_translate_address): Use all_objfiles.
14378         * gcore.c (gcore_create_callback): Use all_objfiles.
14379         (objfile_find_memory_regions): Likewise.
14380
14381 2019-01-09  Tom Tromey  <tom@tromey.com>
14382
14383         * symtab.c (find_line_symtab, info_sources_command)
14384         (make_source_files_completion_list): Use objfile_compunits.
14385         * source.c (select_source_symtab): Use objfile_compunits.
14386         * objfiles.h (struct objfile): Update comment.
14387         (ALL_OBJFILES): Remove.
14388         (ALL_FILETABS): Remove.
14389         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14390         objfile_compunits.
14391
14392 2019-01-09  Tom Tromey  <tom@tromey.com>
14393
14394         * symmisc.c (print_objfile_statistics, dump_objfile)
14395         (maintenance_print_symbols): Use compunit_filetabs.
14396         * source.c (forget_cached_source_info_for_objfile): Use
14397         compunit_filetabs.
14398         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14399         (ALL_FILETABS): Use compunit_filetabs.
14400         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14401         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14402
14403 2019-01-09  Tom Tromey  <tom@tromey.com>
14404
14405         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14406         (compunit_filetabs): New.
14407         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14408         compunit_filetabs.
14409         (info_sources_command, make_source_files_completion_list): Remove
14410         declaration.
14411         * symmisc.c (print_objfile_statistics, dump_objfile)
14412         (maintenance_print_symbols): Remove declaration.
14413         (maintenance_info_symtabs): Use compunit_filetabs.
14414         (maintenance_info_line_tables): Likewise.
14415         * source.c (select_source_symtab): Change local variable name.
14416         (forget_cached_source_info_for_objfile): Remove declaration.
14417         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14418         * objfiles.c (objfile_relocate1): Remove declaration.
14419         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14420         declaration.
14421         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14422         * coffread.c (coff_symtab_read): Remove declaration.
14423         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14424         compunit_filetabs.
14425
14426 2019-01-09  Tom Tromey  <tom@tromey.com>
14427
14428         * symtab.c (lookup_objfile_from_block)
14429         (find_pc_sect_compunit_symtab, search_symbols)
14430         (default_collect_symbol_completion_matches_break_on): Use
14431         objfile_compunits.
14432         * objfiles.h (ALL_COMPUNITS): Remove.
14433         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14434         * cp-support.c (add_symbol_overload_list_qualified): Use
14435         objfile_compunits.
14436         * ada-lang.c (ada_collect_symbol_completion_matches)
14437         (ada_add_global_exceptions): Use objfile_compunits.
14438
14439 2019-01-09  Tom Tromey  <tom@tromey.com>
14440
14441         * source.c (select_source_symtab)
14442         (forget_cached_source_info_for_objfile): Remove declaration.
14443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14444         declaration.
14445         * maint.c (count_symtabs_and_blocks): Remove declaration.
14446         * cp-support.c (add_symbol_overload_list_qualified): Remove
14447         declaration.
14448         * coffread.c (coff_symtab_read): Remove declaration.
14449         * symtab.c (lookup_symbol_in_objfile_symtabs)
14450         (basic_lookup_transparent_type_1): Use objfile_compunits.
14451         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14452         (info_sources_command, search_symbols)
14453         (default_collect_symbol_completion_matches_break_on)
14454         (make_source_files_completion_list): Remove declaration.
14455         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14456         (ada_collect_symbol_completion_matches)
14457         (ada_add_global_exceptions): Remove declaration.
14458         * linespec.c (iterate_over_all_matching_symtabs): Use
14459         objfile_compunits.
14460         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14461         (class objfile_compunits): New.
14462         (ALL_COMPUNITS): Use objfile_compunits.
14463         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14464         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14465         objfile_compunits.
14466         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14467
14468 2019-01-09  Tom Tromey  <tom@tromey.com>
14469
14470         * symtab.c (search_symbols)
14471         (default_collect_symbol_completion_matches_break_on): Use
14472         objfile_msymbols.
14473         * ada-lang.c (ada_lookup_simple_minsym)
14474         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14475         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14476         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14477         objfile_msymbols.
14478         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14479         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14480         * objc-lang.c (find_methods): Use objfile_msymbols.
14481         (info_selectors_command, info_classes_command): Likewise.
14482         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14483         * objfiles.h (class objfile_msymbols): New.
14484         (ALL_OBJFILE_MSYMBOLS): Remove.
14485         (ALL_MSYMBOLS): Remove.
14486
14487 2019-01-09  Tom Tromey  <tom@tromey.com>
14488
14489         * common/next-iterator.h (next_adapter): Add Iterator template
14490         parameter.
14491         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14492         (class all_objfiles_safe): New.
14493         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14494         * objfiles.c (put_objfile_before): Update comment.
14495         (add_separate_debug_objfile): Likewise.
14496         (free_all_objfiles): Use all_objfiles_safe.
14497         (objfile_purge_solibs): Likewise.
14498
14499 2019-01-09  Tom Tromey  <tom@tromey.com>
14500
14501         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14502         (expand_symtab_containing_pc, lookup_static_symbol)
14503         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14504         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14505         all_objfiles.
14506         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14507         * breakpoint.c (create_overlay_event_breakpoint)
14508         (create_longjmp_master_breakpoint)
14509         (create_std_terminate_master_breakpoint)
14510         (create_exception_master_breakpoint): Use all_objfiles.
14511         * linux-thread-db.c (try_thread_db_load_from_pdir)
14512         (has_libpthread): Use all_objfiles.
14513         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14514         * linespec.c (iterate_over_all_matching_symtabs)
14515         (search_minsyms_for_name): Use all_objfiles.
14516         * maint.c (maintenance_info_sections): Use all_objfiles.
14517         * main.c (captured_main_1): Use all_objfiles.
14518         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14519         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14520         * guile/scm-pretty-print.c
14521         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14522         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14523         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14524         (maintenance_print_msymbols): Use all_objfiles.
14525         * source.c (select_source_symtab): Use all_objfiles.
14526         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14527         * symfile.c (remove_symbol_file_command)
14528         (expand_symtabs_matching, map_symbol_filenames): Use
14529         all_objfiles.
14530         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14531         all_objfiles.
14532         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14533         * objc-lang.c (find_methods): Use all_objfiles.
14534         * objfiles.c (have_partial_symbols, have_full_symbols)
14535         (have_minimal_symbols, qsort_cmp)
14536         (default_iterate_over_objfiles_in_search_order): Use
14537         all_objfiles.
14538         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14539         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14540         (maintenance_check_psymtabs): Use all_objfiles.
14541         (ALL_PSYMTABS): Remove.
14542         * compile/compile-object-run.c (do_module_cleanup): Use
14543         all_objfiles.
14544         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14545         * cp-support.c (add_symbol_overload_list_qualified): Use
14546         all_objfiles.
14547         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14548         Use all_objfiles.
14549         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14550         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14551         all_objfiles.
14552         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14553         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14554         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14555         Uses all_objfiles.
14556         * solib.c (solib_read_symbols): Use all_objfiles
14557
14558 2019-01-09  Tom Tromey  <tom@tromey.com>
14559
14560         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14561         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14562         all_objfiles.
14563         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14564         * symmisc.c (print_symbol_bcache_statistics)
14565         (print_objfile_statistics, maintenance_print_objfiles)
14566         (maintenance_info_symtabs, maintenance_check_symtabs)
14567         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14568         all_objfiles.
14569         * source.c (forget_cached_source_info): Use all_objfiles.
14570         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14571         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14572         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14573         * objfiles.c (update_section_map): Use all_objfiles.
14574         (shared_objfile_contains_address_p): Likewise.
14575         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14576         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14577
14578 2019-01-09  Tom Tromey  <tom@tromey.com>
14579
14580         * common/next-iterator.h: New file.
14581         * objfiles.h (class all_objfiles): New.
14582         (struct objfile_iterator): New.
14583
14584 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14585
14586         * NEWS: Move the description of the changed "frame", "select-frame",
14587          and "info frame" commands to the Changed commands section.
14588
14589 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14590
14591         * gdbtypes.c (check_stub_method_group): Remove handling of old
14592         mangling schemes.
14593         * linespec.c (find_methods): Likewise.
14594         * stabsread.c (read_member_functions): Likewise.
14595         * valops.c (search_struct_method): Likewise.
14596         (value_struct_elt_for_reference): Likewise.
14597         * NEWS: Mention this change.
14598
14599 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14600
14601         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14602         print_source_lines.
14603         * source.c (print_source_lines_base): Update line number check.
14604         (print_source_lines): New function.
14605         (source_lines_range::source_lines_range): New function.
14606         * source.h (class source_lines_range): New class.
14607         (print_source_lines): New declaration.
14608
14609 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14610
14611         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14612
14613 2019-01-08  Tom Tromey  <tom@tromey.com>
14614             Simon Marchi  <simon.marchi@ericsson.com>
14615
14616         PR gdb/24060
14617         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14618         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14619         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14620         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14621         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14622         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14623
14624 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14625
14626         * source.c (select_source_symtab): Move header comment to
14627         declaration in source.h.
14628         (forget_cached_source_info_for_objfile): Likewise.
14629         (forget_cached_source_info): Likewise.
14630         (identify_source_line): Likewise.
14631         * source.h (identify_source_line): Move declaration from symtab.h
14632         and add comment from source.c
14633         (print_source_lines): Likewise.
14634         (forget_cached_source_info_for_objfile): Likewise.
14635         (forget_cached_source_info): Likewise.
14636         (select_source_symtab): Likewise.
14637         (enum print_source_lines_flag): Move definition from symtab.h.
14638         * symtab.h (identify_source_line): Move declaration to source.h.
14639         (print_source_lines): Likewise.
14640         (forget_cached_source_info_for_objfile): Likewise.
14641         (forget_cached_source_info): Likewise.
14642         (select_source_symtab): Likewise.
14643         (enum print_source_lines_flag): Move definition to source.h.
14644         * tui/tui-hooks.c: Add 'source.h' include.
14645
14646 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14647
14648         * source.c (print_source_lines_base): Handle requests to print
14649         reverse line number sequences, and guard against empty lines
14650         string.
14651
14652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14653
14654         * source.c (print_source_lines_base): Fix skip of '\r' if next
14655         character is '\n'.
14656
14657 2019-01-06  Tom Tromey  <tom@tromey.com>
14658
14659         * c-exp.y (struct c_parse_state) <macro_original_text,
14660         expansion_obstack>: New member.
14661         (macro_original_text, expansion_obstack): Remove globals.
14662         (scan_macro_expansion, scanning_macro_expansion)
14663         (finished_macro_expansion): Update.
14664         (scan_macro_cleanup): Remove.
14665         (yylex, c_parse): Update.
14666
14667 2019-01-06  Tom Tromey  <tom@tromey.com>
14668
14669         * c-exp.y (struct c_parse_state) <strings>: New member.
14670         (operator_stoken): Update.
14671
14672 2019-01-06  Tom Tromey  <tom@tromey.com>
14673
14674         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14675         (union type_stack_elt) <typelist_val>: Now a pointer to
14676         std::vector.
14677         (type_stack_cleanup): Don't declare.
14678         (push_typelist): Update.
14679         * parse.c (pop_typelist): Return a std::vector.
14680         (push_typelist): Take a std::vector.
14681         (follow_types): Update.  Do not free args.
14682         (type_stack_cleanup): Remove.
14683         * c-exp.y (struct c_parse_state): New.
14684         (cpstate): New global.
14685         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14686         (nonempty_typelist): Update.
14687         (func_mod): Create a new vector.
14688         (c_parse): Create a c_parse_state.
14689         (check_parameter_typelist): Do not delete params.
14690         (function_method): Update.  Do not delete type_list.
14691
14692 2019-01-06  Tom Tromey  <tom@tromey.com>
14693
14694         PR gdb/28155:
14695         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14696         check_typedef.
14697         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14698         (print_return_value): Likewise.
14699
14700 2019-01-05  Tom Tromey  <tom@tromey.com>
14701
14702         * contrib/cleanup_check.py: Remove.
14703         * contrib/gcc-with-excheck: Remove.
14704         * contrib/exsummary.py: Remove.
14705         * contrib/excheck.py: Remove.
14706
14707 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14708
14709         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14710         NULL. Initialize tpprev to NULL instead of assigning it
14711         to NULL on the next statement.
14712         * windows-nat.c (windows_delete_thread): Remove check for
14713         main_thread_id before printing thread exit notifications.
14714         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14715         Remove thread ID check against main_thread_id.
14716         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14717         windows_delete_thread.
14718         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14719
14720 2019-01-04  Tom Tromey  <tom@tromey.com>
14721
14722         * compile/compile.c (_initialize_compile): Use upper case for
14723         metasyntactic variables.
14724         * symmisc.c (_initialize_symmisc): Use upper case for
14725         metasyntactic variables.
14726         * psymtab.c (_initialize_psymtab): Use upper case for
14727         metasyntactic variables.
14728         * demangle.c (demangle_command): Use upper case for metasyntactic
14729         variables.
14730         (_initialize_demangler): Likewise.
14731         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14732         variables.
14733
14734 2019-01-03  Tom Tromey  <tom@tromey.com>
14735
14736         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14737
14738 2019-01-03  Tom Tromey  <tom@tromey.com>
14739
14740         * python/py-symtab.c (salpy_str): Update.
14741         (struct salpy_sal_object) <symtab>: Now a PyObject.
14742         (salpy_dealloc): Update.
14743         (del_objfile_sal): Use gdbpy_ref.
14744
14745 2019-01-03  Tom Tromey  <tom@tromey.com>
14746
14747         * python/py-type.c (convert_field): Use new_reference.  Return
14748         gdbpy_ref.
14749         (make_fielditem): Return gdbpy_ref.
14750         (typy_fields): Update.
14751         (typy_getitem): Update.
14752         (field_name): Return gdbpy_ref.  Use new_reference.
14753         (typy_iterator_iternext): Update.
14754
14755 2019-01-03  Tom Tromey  <tom@tromey.com>
14756
14757         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14758
14759 2019-01-03  Tom Tromey  <tom@tromey.com>
14760
14761         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14762         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14763         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14764         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14765         (pspy_set_type_printers): Likewise.
14766         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14767         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14768         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14769         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14770         (objfpy_set_type_printers): Likewise.
14771
14772 2019-01-03  Tom Tromey  <tom@tromey.com>
14773
14774         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14775         (gdbpy_print_stack): Use gdbpy_err_fetch.
14776         * python/python-internal.h (class gdbpy_err_fetch): New class.
14777         (class gdbpy_enter) <m_error_type, m_error_value,
14778         m_error_traceback>: Remove.
14779         <m_error>: New member.
14780         (gdbpy_exception_to_string): Don't declare.
14781         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14782         * python/py-value.c (convert_value_from_python): Use
14783         gdbpy_err_fetch.
14784         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14785         gdbpy_exception_to_string.
14786         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14787         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14788         gdbpy_err_fetch.
14789
14790 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14791
14792         * linux-nat.c (delete_lwp_cleanup): Delete.
14793         (struct lwp_deleter): New struct.
14794         (lwp_info_up): New typedef.
14795         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14796         lwp_info_up.
14797
14798 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14799
14800         * linux-fork.c (class scoped_switch_fork_info): New class.
14801         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14802
14803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14804
14805         * valops.c (find_overload_match): Remove use of null_cleanup, and
14806         calls to do_cleanups.
14807
14808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14809
14810         * compile/compile-cplus-types.c
14811         (compile_cplus_instance::decl_name): Handle changes to
14812         cp_func_name.
14813         * cp-support.c (cp_func_name): Update header comment, update
14814         return type.
14815         * cp-support.h (cp_func_name): Update return type in declaration.
14816         * valops.c (find_overload_match): Move temp_func local to top
14817         level of function and change its type.  Use temp_func to hold and
14818         delete temporary string obtained from cp_func_name.
14819
14820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14821
14822         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14823         gdb::char_vector, remove cleanup, and update uses of `msg`.
14824
14825 2019-01-03  Jim Wilson  <jimw@sifive.com>
14826
14827         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14828
14829 2019-01-02  Tom Tromey  <tom@tromey.com>
14830
14831         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14832         (tdesc_parse_xml): Remove cleanups.
14833         * target-descriptions.h (make_cleanup_free_target_description):
14834         Don't declare.
14835         (target_desc_deleter): New struct.
14836         (target_desc_up): New typedef.
14837         * target-descriptions.c (target_desc_deleter::operator()): Rename
14838         from free_target_description.
14839         (make_cleanup_free_target_description): Remove.
14840
14841 2019-01-02  Tom Tromey  <tom@tromey.com>
14842
14843         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14844         constructor, destructor.
14845         (linespec_parser): Remove typedef.
14846         (~linespec_parser): Rename from linespec_parser_delete.
14847         (linespec_lex_to_end, linespec_complete_label)
14848         (linespec_complete): Update.
14849         (decode_line_full): Remove cleanups.
14850         (decode_line_1): Update.
14851
14852 2019-01-02  Tom Tromey  <tom@tromey.com>
14853
14854         * python/python-internal.h (inferior_to_inferior_object): Change
14855         return type.
14856         * python/py-exitedevent.c (create_exited_event_object): Update.
14857         * python/py-inferior.c (inferior_to_inferior_object): Return
14858         gdbpy_ref.
14859         (python_new_inferior, python_inferior_deleted)
14860         (thread_to_thread_object, delete_thread_object)
14861         (build_inferior_list, gdbpy_selected_inferior): Update.
14862         * python/py-infthread.c (create_thread_object): Update.  Also fail
14863         if inferior_to_inferior_object fails.
14864
14865 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14866
14867         * inferior.h (class inferior) <displaced_step_state>: New field.
14868         * infrun.h (struct displaced_step_state): Move here from
14869         infrun.c.  Initialize fields, add constructor.
14870         <inf>: Remove field.
14871         <reset>: New method.
14872         * infrun.c (struct displaced_step_inferior_state): Move to
14873         infrun.h.
14874         (displaced_step_inferior_states): Remove.
14875         (get_displaced_stepping_state): Adust.
14876         (displaced_step_in_progress_any_inferior): Adjust.
14877         (displaced_step_in_progress_thread): Adjust.
14878         (displaced_step_in_progress): Adjust.
14879         (add_displaced_stepping_state): Remove.
14880         (get_displaced_step_closure_by_addr): Adjust.
14881         (remove_displaced_stepping_state): Remove.
14882         (infrun_inferior_exit): Call displaced_step_state.reset.
14883         (use_displaced_stepping): Don't check for NULL.
14884         (displaced_step_prepare_throw): Call
14885         get_displaced_stepping_state.
14886         (displaced_step_fixup): Don't check for NULL.
14887         (prepare_for_detach): Don't check for NULL.
14888
14889 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14890
14891         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14892          in case of call that did not complete.
14893
14894 2019-01-02  Andrey Utkin  <autkin@undo.io>
14895
14896         * symfile.c (find_separate_debug_file): Fix search of debug files for
14897         remote debuggee.
14898
14899 2019-01-02  Tom Tromey  <tom@tromey.com>
14900
14901         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14902         indentation.
14903         * python/py-frame.c (frapy_older): Remove cast.
14904         (frapy_newer): Likewise.
14905         * python/py-breakpoint.c (local_setattro): Remove cast.
14906         * python/py-arch.c (archpy_name): Remove local variable.
14907         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14908
14909 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14910
14911         * unittests/basic_string_view/element_access/char/empty.cc:
14912         Fix year range in copyright header.
14913
14914 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14915
14916         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14917         Delete.
14918         <operator==>: Update with for removed field.
14919         <hash>: Likewise.
14920         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14921         <isa_features>: ...this.
14922         <abi_features>: New field.
14923         (riscv_isa_flen): Update comment.
14924         (riscv_abi_xlen): New declaration.
14925         (riscv_abi_flen): New declaration.
14926         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14927         isa_features.
14928         (riscv_abi_xlen): New function.
14929         (riscv_isa_flen): Update to get answer from isa_features.
14930         (riscv_abi_flen): New function.
14931         (riscv_has_fp_abi): Update to get answer from abi_features.
14932         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14933         xlen and flen.
14934         (riscv_call_info) <xlen, flen>: Update comment.
14935         (riscv_call_arg_struct): Remove invalid assertions
14936         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14937         is removed.
14938         (riscv_gdbarch_init): Gather isa features and abi features
14939         separately, ensure both match on the gdbarch when reusing an old
14940         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14941         a target with 64-bit float hardware.
14942
14943 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14944
14945         * source.c (search_command_helper): Stop reverse search
14946         when line 1 has been searched.
14947
14948 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14949
14950         * record-full.c (record_full_base_target::close): Rewrite
14951         record_full_core_buf_list free logic.
14952
14953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14954
14955         * break-catch-syscall.c (print_one_catch_syscall): xfree
14956         the last text.
14957
14958 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14959
14960         * top.c (print_gdb_version): Update Copyright year in version
14961         message.
14962
14963 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14964
14965         Update copyright year range in all GDB files.
14966
14967 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14968
14969         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14970
14971 For older changes see ChangeLog-2018.
14972 \f
14973 Local Variables:
14974 mode: change-log
14975 left-margin: 8
14976 fill-column: 74
14977 version-control: never
14978 coding: utf-8
14979 End:
14980