gdb/ChangeLog

   1 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
   2
   3         PR ada/21406:
   4         * ada-exp.y (yywrap): Don't define.
   5         * ada-lex.l (%option): Add noyywrap
   6         (yywrap): Remove.
   7
   8 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
   9
  10         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  11         _WIN32_WINNT to the XP level, unless already defined to a higher
  12         level.
  13
  14         * unittests/parse-connection-spec-selftests.c:
  15         * ser-tcp.c:
  16         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  17         override.
  18
  19         * symfile.c (find_separate_debug_file): Remove colon from the
  20         drive spec of DOS/Windows file names of the target, so that the
  21         file name produced from DEBUGDIR and the target's directory will
  22         be valid on DOS/Windows systems.
  23
  24 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  25
  26         * rust-lang.c (val_print_struct): Handle printing structures
  27         containing strings.
  28
  29 2019-05-02  Tom Tromey  <tromey@adacore.com>
  30
  31         * valarith.c (_initialize_valarith): Remove.
  32
  33 2019-05-01  Tom Tromey  <tromey@adacore.com>
  34
  35         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  36         bitfields.
  37
  38 2019-05-01  Tom Tromey  <tromey@adacore.com>
  39
  40         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  41         for big-endian copies.
  42
  43 2019-04-30  Ali Tamur  <tamur@google.com>
  44         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  45         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  46         (read_3_bytes): New function.
  47
  48 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  49
  50         * windows-nat.c (main_thread_id): Delete.
  51         (handle_output_debug_string): Replace main_thread_id by
  52         current_event.dwThreadId.
  53         (fake_create_process): Likewise.
  54         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  55         Do not set main_thread_id.
  56         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  57         current_event.dwThreadId.
  58         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  59
  60 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  61
  62         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  63         Use current_event.dwThreadId instead of main_thread_id.
  64
  65 2019-04-30  Tom Tromey  <tromey@adacore.com>
  66
  67         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  68         (create_excep_cond_exprs): Iterate over program spaces.
  69         (ada_exception_catchpoint_cond_string): Examine all minimal
  70         symbols for exception types.
  71
  72 2019-04-30  Tom Tromey  <tromey@adacore.com>
  73
  74         PR c++/24470:
  75         * dwarf2read.c (process_structure_scope): Handle case where type
  76         has template parameters but no symbol was created.
  77
  78 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  79             Chris January  <chris.january@arm.com>
  80
  81         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  82         qualifier.
  83         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  84
  85 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * f-typeprint.c (f_print_type): Update rules for printing
  88         whitespace.
  89         (f_type_print_varspec_suffix): Likewise.
  90
  91 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  92             Chris January  <chris.january@arm.com>
  93
  94         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  95         function arguments.
  96
  97 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * f-lang.c (build_fortran_types): Change name of void type to
 100         lower case.
 101         * f-typeprint.c (f_type_print_base): Print the name of the void
 102         type, rather than a fixed string.
 103         * f-valprint.c (f_decorations): Use lower case void string.
 104
 105 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 106             Chris January  <chris.january@arm.com>
 107
 108         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 109         types for Fortran.
 110
 111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 112             Chris January  <chris.january@arm.com>
 113             David Lecomber  <david.lecomber@arm.com>
 114
 115         * f-exp.y (BINOP_INTRINSIC): New token.
 116         (exp): New parser rule handling BINOP_INTRINSIC.
 117         (f77_keywords): Add new builtin procedures.
 118         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 119         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 120         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 121         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 122         (print_unop_subexp_f): New function.
 123         (print_binop_subexp_f): New function.
 124         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 125         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 126         (dump_subexp_body_f): Likewise.
 127         (operator_check_f): Likewise.
 128         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 129         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 130
 131 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 132
 133         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 134         UNOP_KIND.
 135         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 136         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 137         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 138         (operator_length_f): New fuction.
 139         (print_subexp_f): New function.
 140         (op_name_f): New function.
 141         (dump_subexp_body_f): New function.
 142         (operator_check_f): New function.
 143         (exp_descriptor_f): Replace standard expression handling functions
 144         with new functions.
 145         * gdb/fortran-operator.def: New file.
 146         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 147         * gdb/std-operator.def: Remove UNOP_KIND.
 148
 149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * std-operator.def: Remove unbalanced, stray double quote
 152         character.
 153
 154 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 155             Chris January  <chris.january@arm.com>
 156             Daniel Everett  <daniel.everett@arm.com>
 157             Nick Forrington  <nick.forrington@arm.com>
 158             Richard Bunt  <richard.bunt@arm.com>
 159
 160         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 161         of depth when printing anonymous structs or unions.
 162         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 163         Don't print either the top-level value, or the children if the
 164         max-depth is exceeded.
 165         (ppscm_print_children): When printing the key of a map, allow one
 166         extra level of depth.
 167         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 168         print either the top-level value, or the children if the max-depth
 169         is exceeded.
 170         (print_children): When printing the key of a map, allow one extra
 171         level of depth.
 172         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 173         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 174         (user_print_options): Initialise max_depth field.
 175         (val_print_scalar_or_string_type_p): New function.
 176         (val_print): Check to see if the max depth has been reached.
 177         (val_print_check_max_depth): Define new function.
 178         (show_print_max_depth): New function.
 179         (_initialize_valprint): Add 'print max-depth' option.
 180         * valprint.h (struct value_print_options) <max_depth>: New field.
 181         (val_print_check_max_depth): Declare new function.
 182         * NEWS: Document new feature.
 183
 184 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 185
 186         * ada-lang.c (ada_language_defn): Initialise new field.
 187         * c-lang.c (c_is_string_type_p): New function.
 188         (c_language_defn): Initialise new field.
 189         (cplus_language_defn): Initialise new field.
 190         (asm_language_defn): Initialise new field.
 191         (minimal_language_defn): Initialise new field.
 192         * c-lang.h (c_is_string_type_p): Declare new function.
 193         * d-lang.c (d_language_defn): Initialise new field.
 194         * f-lang.c (f_is_string_type_p): New function.
 195         (f_language_defn): Initialise new field.
 196         * go-lang.c (go_is_string_type_p): New function.
 197         (go_language_defn): Initialise new field.
 198         * language.c (default_is_string_type_p): New function.
 199         (unknown_language_defn): Initialise new field.
 200         (auto_language_defn): Initialise new field.
 201         * language.h (struct language_defn) <la_is_string_type_p>: New
 202         member variable.
 203         (default_is_string_type_p): Declare new function.
 204         * m2-lang.c (m2_language_defn): Initialise new field.
 205         * objc-lang.c (objc_language_defn): Initialise new field.
 206         * opencl-lang.c (opencl_language_defn): Initialise new field.
 207         * p-lang.c (pascal_is_string_type_p): New function.
 208         (pascal_language_defn): Initialise new field.
 209         * rust-lang.c (rust_is_string_type_p): New function.
 210         (rust_language_defn): Initialise new field.
 211
 212 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 215         New field.
 216         * ada-lang.c (ada_language_defn): Initialise new field.
 217         * c-lang.c (c_language_defn): Likewise.
 218         (cplus_language_defn): Likewise.
 219         (asm_language_defn): Likewise.
 220         (minimal_language_defn): Likewise.
 221         * d-lang.c (d_language_defn): Likewise.
 222         * f-lang.c (f_language_defn): Likewise.
 223         * go-lang.c (go_language_defn): Likewise.
 224         * language.c (unknown_language_defn): Likewise.
 225         (auto_language_defn): Likewise.
 226         * m2-lang.c (m2_language_defn): Likewise.
 227         * objc-lang.c (objc_language_defn): Likewise.
 228         * opencl-lang.c (opencl_language_defn): Likewise.
 229         * p-lang.c (pascal_language_defn): Likewise.
 230         * rust-lang.c (rust_language_defn): Likewise.
 231
 232 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * ada-lang.c (ada_is_character_type): Change return type to bool.
 235         (ada_is_string_type): Likewise.
 236         * ada-lang.h (ada_is_character_type): Update declaration
 237         (ada_is_string_type): Likewise.
 238
 239 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 240
 241         Support style in 'frame|thread apply'
 242
 243         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 244         * record.c (record_start, record_stop): Update callers of
 245         execute_command_to_string with false.
 246         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 247         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 248         methods.
 249         (class string_file): New constructor with term_out parameter.
 250         Override methods term_out and can_emit_style_escape.  New member
 251         term_out.
 252         (class stdio_file): Override can_emit_style_escape.
 253         (class tee_file): Override term_out and can_emit_style_escape.
 254         * utils.h (can_emit_style_escape): Remove.
 255         * utils.c (can_emit_style_escape): Likewise.
 256         Update all callers of can_emit_style_escape (SOMESTREAM) to
 257         SOMESTREAM->can_emit_style_escape.
 258         * source-cache.c (source_cache::get_source_lines): Likewise.
 259         * stack.c (frame_apply_command_count): Call execute_command_to_string
 260         passing the term_out characteristic of the current gdb_stdout.
 261         * thread.c (thr_try_catch_cmd): Likewise.
 262         * top.c (execute_command_to_string): pass term_out parameter
 263         to construct the string_file for the command output.
 264         * ui-file.c (term_cli_styling): New function (most code moved
 265         from utils.c can_emit_style_escape).
 266         (string_file::string_file, string_file::can_emit_style_escape,
 267         stdio_file::can_emit_style_escape, tee_file::term_out,
 268         tee_file::can_emit_style_escape): New functions.
 269
 270 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 271
 272         * NEWS: Mention the new set|show may-call-functions.
 273         * infcall.c (may_call_functions_p): New variable.
 274         (show_may_call_functions_p): New function.
 275         (call_function_by_hand_dummy): Throws an error if not
 276         may-call-functions.
 277         (_initialize_infcall): Call add_setshow_boolean_cmd for
 278         may-call-functions.
 279
 280 2019-04-25  Keith Seitz  <keiths@redhat.com>
 281
 282         PR c++/24367
 283         * cp-support.c (inspect_type): Don't attempt substitutions
 284         of symbol with the same name.
 285
 286 2019-04-25  Tom Tromey  <tromey@adacore.com>
 287
 288         PR gdb/24475:
 289         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 290         static.
 291
 292 2019-04-25  Tom Tromey  <tromey@adacore.com>
 293
 294         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 295         rvalue reference.
 296         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 297         (gdb_xml_parser::parse): Use std::move.
 298         * python/python-internal.h (gdbpy_convert_exception): Take a const
 299         reference.
 300         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 301         std::move.
 302         * python/py-utils.c (gdbpy_convert_exception): Take a const
 303         reference.
 304         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 305         Use std::move.
 306         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 307         Use std::move.
 308         * mi/mi-main.c (mi_print_exception): Take a const reference.
 309         * main.c (handle_command_errors): Take a const reference.
 310         * linespec.c (parse_linespec): Use std::move.
 311         * infcall.c (run_inferior_call): Use std::move.
 312         (call_function_by_hand_dummy): Use std::move.
 313         * exec.c (try_open_exec_file): Use std::move.
 314         * exceptions.h (exception_print, exception_fprintf)
 315         (exception_print_same): Update.
 316         * exceptions.c (print_exception, exception_print)
 317         (exception_fprintf, exception_print_same): Change parameters to
 318         const reference.
 319         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 320         * common/new-op.c: Use std::move.
 321         * common/common-exceptions.h (struct gdb_exception): Add move
 322         constructor.
 323         (struct gdb_exception_error, struct gdb_exception_quit, struct
 324         gdb_quit_bad_alloc): Change constructor to move constructor.
 325         (throw_exception): Change parameter to rvalue reference.
 326         * common/common-exceptions.c (throw_exception): Take rvalue
 327         reference.
 328         * cli/cli-interp.c (safe_execute_command): Use std::move.
 329         * breakpoint.c (insert_bp_location, location_to_sals): Use
 330         std::move.
 331
 332 2019-04-25  Tom Tromey  <tromey@adacore.com>
 333
 334         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 335         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 336         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 337         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 338         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 339         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 340         guile/scm-value.c: Use unpack.
 341         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 342         gdbscm_gdb_exception.
 343         (gdbscm_throw_gdb_exception): Likewise.
 344         (struct gdbscm_gdb_exception): New.
 345         (unpack): New function.
 346         (gdbscm_wrap): Use unpack.
 347
 348 2019-04-25  Tom Tromey  <tromey@adacore.com>
 349
 350         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 351         (gdb_rl_callback_handler): Use std::move.
 352         * common/common-exceptions.h (struct gdb_exception): Add move
 353         assignment operator.
 354         (throw_exception_sjlj): Change "exception" to const reference.
 355         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 356         (throw_exception_sjlj): Change "exception" to const reference.
 357
 358 2019-04-25  Tom Tromey  <tromey@adacore.com>
 359
 360         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 361         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 362         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 363         Update.
 364         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 365         Update.
 366         * mi/mi-interp.c (mi_interp::exec): Update.
 367         * linespec.c (parse_linespec): Update.
 368         * infcall.c (run_inferior_call): Update.
 369         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 370         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 371         (gdbscm_lookup_global_symbol): Update.
 372         * guile/scm-param.c (gdbscm_parameter_value): Update.
 373         * guile/scm-frame.c (gdbscm_frame_read_register)
 374         (gdbscm_frame_read_var): Update.
 375         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 376         * exec.c (try_open_exec_file): Update.
 377         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 378         (gdb_rl_callback_handler): Update.
 379         * common/common-exceptions.h (exception_none): Don't declare.
 380         * common/common-exceptions.c (exception_none): Don't define.
 381         (struct catcher) <exception>: Update.
 382         * cli/cli-interp.c (safe_execute_command): Update.
 383         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 384
 385 2019-04-25  Ali Tamur  <tamur@google.com>
 386
 387         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 388         (read_attribute_value): Likewise.
 389         (dwarf2_read_addr_index): Update comment.
 390         (read_str_index): Add DW_FORM_strx.
 391         (dwarf2_string_attr): Likewise.
 392         (dwarf2_const_value_attr): Likewise.
 393         (dump_die_shallow): Likewise.
 394         (dwarf2_fetch_constant_bytes): Likewise.
 395         (skip_form_bytes): Likewise.
 396         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 397
 398 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 399
 400         PR corefiles/11608
 401         PR corefiles/18187
 402         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 403         OFFSET.  Verify if current mapping contains an ELF header.
 404         (linux_find_memory_regions_full): Adjust call to
 405         dump_mapping_p.
 406
 407 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 408             Kang Li <kanglictf@gmail.com>
 409
 410         PR gdb/21600
 411
 412         * dwarf2-frame.c (read_initial_length): Be consistent about using
 413         unsigned representation of length.
 414         (decode_frame_entry_1): Likewise.  Check for wraparound of
 415         end pointer as well as buffer overflow.
 416
 417 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 418
 419         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 420         "vq".
 421
 422 2019-04-24  Tom Tromey  <tromey@adacore.com>
 423
 424         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 425
 426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * s12z-tdep.c (s12z_unwind_pc): Delete.
 429         (s12z_unwind_sp): Delete.
 430         (s12z_gdbarch_init): Don't register deleted functions with
 431         gdbarch.
 432
 433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * rl78-tdep.c (rl78_unwind_sp): Delete.
 436         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 437
 438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 439
 440         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 441         (xstormy16_unwind_pc): Delete.
 442         (xstormy16_dummy_id): Delete.
 443         (xstormy16_gdbarch_init): Don't register deleted functions with
 444         gdbarch.
 445
 446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * vax-tdep.c (vax_unwind_pc): Delete.
 449         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 450
 451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * v850-tdep.c (v850_unwind_sp): Delete.
 454         (v850_unwind_pc): Delete.
 455         (v850_dummy_id): Delete.
 456         (v850_gdbarch_init): Don't register deleted functions with
 457         gdbarch.
 458
 459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 462         (tilegx_unwind_pc): Delete.
 463         (tilegx_unwind_dummy_id): Delete.
 464         (tilegx_gdbarch_init): Don't register deleted functions with
 465         gdbarch.
 466
 467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 468
 469         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 470         (tic6x_dummy_id): Delete.
 471         (tic6x_gdbarch_init): Don't register deleted functions with
 472         gdbarch.
 473
 474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 475
 476         * sparc-tdep.c (sparc_unwind_pc): Delete.
 477         (sparc32_gdbarch_init): Don't register deleted function with
 478         gdbarch.
 479
 480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 481
 482         * sh-tdep.c (sh_unwind_sp): Delete.
 483         (sh_unwind_pc): Delete.
 484         (sh_dummy_id): Delete.
 485         (sh_gdbarch_init): Don't register deleted functions with
 486         gdbarch.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * score-tdep.c (score_unwind_sp): Delete.
 491         (score_unwind_pc): Delete.
 492         (score_dummy_id): Delete.
 493         (score_gdbarch_init): Don't register deleted functions with
 494         gdbarch.
 495
 496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * rx-tdep.c (rx_unwind_pc): Delete.
 499         (rx_unwind_sp): Delete.
 500         (rx_dummy_id): Delete.
 501         (rx_gdbarch_init): Don't register deleted functions with
 502         gdbarch.  Update comment.
 503
 504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 507         (rs6000_dummy_id): Delete.
 508         (rs6000_gdbarch_init): Don't register deleted functions with
 509         gdbarch.
 510
 511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * or1k-tdep.c (or1k_dummy_id): Delete.
 514         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 515
 516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * nios2-tdep.c (nios2_dummy_id): Delete.
 519         (nios2_unwind_sp): Delete.
 520         (nios2_gdbarch_init): Don't register deleted functions with
 521         gdbarch.
 522
 523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * nds32-tdep.c (nds32_dummy_id): Delete.
 526         (nds32_unwind_pc): Delete.
 527         (nds32_unwind_sp): Delete.
 528         (nds32_gdbarch_init): Don't register deleted functions with
 529         gdbarch.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * msp430-tdep.c (msp430_unwind_pc): Delete.
 534         (msp430_unwind_sp): Delete.
 535         (msp430_dummy_id): Delete.
 536         (msp430_gdbarch_init): Don't register deleted functions with
 537         gdbarch.
 538
 539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * moxie-tdep.c (moxie_unwind_sp): Delete.
 542         (moxie_unwind_pc): Delete.
 543         (moxie_dummy_id): Delete.
 544         (moxie_gdbarch_init): Don't register deleted functions with
 545         gdbarch.
 546
 547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 548
 549         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 550         (mn10300_unwind_pc): Delete.
 551         (mn10300_unwind_sp): Delete.
 552         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 553         mn10300_unwind_sp.
 554         (mn10300_frame_unwind_init): Don't register deleted functions with
 555         gdbarch.
 556
 557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * mep-tdep.c (mep_unwind_pc): Delete.
 560         (mep_unwind_sp): Delete.
 561         (mep_dummy_id): Delete.
 562         (mep_gdbarch_init): Don't register deleted functions with
 563         gdbarch.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 568         (m68hc11_unwind_sp): Delete.
 569         (m68hc11_gdbarch_init): Don't register deleted functions with
 570         gdbarch.
 571
 572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * m32r-tdep.c (m32r_unwind_sp): Delete.
 575         (m32r_unwind_pc): Delete.
 576         (m32r_dummy_id): Delete.
 577         (m32r_gdbarch_init): Don't register deleted functions with
 578         gdbarch.
 579
 580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         * m32c-tdep.c (m32c_unwind_pc): Delete.
 583         (m32c_unwind_sp): Delete.
 584         (m32c_dummy_id): Delete.
 585         (m32c_gdbarch_init): Don't register deleted functions with
 586         gdbarch.
 587
 588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 591         (lm32_unwind_pc): Delete.
 592         (lm32_dummy_id): Delete.
 593         (lm32_gdbarch_init): Don't register deleted functions with
 594         gdbarch.
 595
 596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 599         (iq2000_unwind_pc): Delete.
 600         (iq2000_dummy_id): Delete.
 601         (iq2000_gdbarch_init): Don't register deleted functions with
 602         gdbarch.
 603
 604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 605
 606         * nds32-tdep.c (nds32_type_align): Delete.
 607         (nds32_push_dummy_call): Use type_align instead.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * arm-tdep.c (arm_type_align): Only handle vector override case.
 612         (arm_push_dummy_call): Use type_align.
 613         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 614
 615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 616
 617         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 618         case.
 619         (pass_on_stack): Use type_align.
 620         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 621         function.
 622
 623 2019-04-23  Tom Tromey  <tromey@adacore.com>
 624
 625         * dwarf2read.c (line_header::file_name_at): Remove unused
 626         overload.
 627
 628 2019-04-23  Tom de Vries  <tdevries@suse.de>
 629
 630         PR gdb/24438
 631         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 632         invocation.
 633
 634
 635 2019-03-27  Ali Tamur  <tamur@google.com>
 636
 637         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 638         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 639         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 640         (dwarf_expr_context::get_addr_index): Likewise
 641         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 642         (symbol_needs_eval_context::get_addr_index): Likewise
 643         (disassemble_dwarf_expression): Add DW_OP_addrx
 644         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 645         (read_cutu_die_from_dwo): Update comment
 646         (skip_one_die): Add DW_FORM_addrx
 647         (read_attribute_value): Likewise
 648         (var_decode_location): Add DW_OP_addrx
 649         (dwarf2_const_value_attr): Add DW_FORM_addrx
 650         (dump_die_shallow): Likewise
 651         (dwarf2_fetch_constant_bytes): Likewise
 652         (decode_locdesc): Add DW_OP_addrx
 653         (skip_form_bytes): Add DW_FORM_addrx
 654
 655 2019-04-22  Ali Tamur  <tamur@google.com>
 656
 657         * MAINTAINERS (Write After Approval): Add self.
 658
 659 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 660
 661         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 662         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 663         (open_symbol_file_object): Likewise.
 664         (svr4_default_sos): Add info parameter.
 665         (svr4_read_so_list): Likewise.
 666         (svr4_current_sos_direct): Adjust functions calls to pass down
 667         info.
 668         (svr4_current_sos_1): Add info parameter.
 669         (svr4_current_sos): Call get_svr4_info, pass info down to
 670         svr4_current_sos_1.
 671         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 672         get_svr4_info.
 673         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 674         get_svr4_info.
 675         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 676         to get_svr4_info.
 677         (probes_table_remove_objfile_probes): Likewise.
 678         (register_solib_event_probe): Add info parameter.
 679         (solist_update_incremental): Pass info parameter down to
 680         svr4_read_so_list.
 681         (disable_probes_interface): Add info parameter.
 682         (svr4_handle_solib_event): Pass current_program_space to
 683         get_svr4_info.  Adjust disable_probes_interface cleanup.
 684         (svr4_create_probe_breakpoints): Add info parameter, pass it
 685         down to register_solib_event_probe.
 686         (svr4_create_solib_event_breakpoints): Add info parameter,
 687         pass it down to svr4_create_probe_breakpoints.
 688         (enable_break): Pass info down to
 689         svr4_create_solib_event_breakpoints.
 690         (svr4_solib_create_inferior_hook): Pass current_program_space to
 691         get_svr4_info.
 692         (svr4_clear_solib): Likewise.
 693
 694 2019-04-22  Pedro Alves  <palves@redhat.com>
 695
 696         * solib-svr4.c (svr4_free_objfile_observer): New.
 697         (probe_and_action::objfile): New field.
 698         (probes_table_htab_remove_objfile_probes)
 699         (probes_table_remove_objfile_probes): New functions.
 700         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 701         in the new probe_and_action.  Don't store the probe in 'lookup'.
 702         (svr4_create_probe_breakpoints): Pass objfile to
 703         register_solib_event_probe.
 704         (_initialize_svr4_solib): Register a free_objfile observer.
 705
 706 2019-04-19  Tom Tromey  <tom@tromey.com>
 707
 708         * common/queue.h: Remove.
 709
 710 2019-04-19  Tom Tromey  <tom@tromey.com>
 711
 712         * event-loop.c: Don't include "common/queue.h".
 713
 714 2019-04-19  Tom Tromey  <tom@tromey.com>
 715
 716         * remote.c (remote_target): Use delete.
 717         * remote-notif.h: Include <list>, not "common/queue.h".
 718         (notif_client_p): Remove typedef.
 719         (remote_notif_state): Add constructor, destructor, initializer.
 720         <notif_queue>: Now a std::list.
 721         (remote_notif_state_xfree): Don't declare.
 722         * remote-notif.c (remote_notif_process, handle_notification)
 723         (remote_notif_state_allocate): Update.
 724         (~remote_notif_state): Rename from remote_notif_state_xfree.
 725
 726 2019-04-19  Tom Tromey  <tom@tromey.com>
 727
 728         * symfile.c (reread_symbols): Update.
 729         * objfiles.c (objfile_register_static_link)
 730         (objfile_lookup_static_link): Update
 731         (~objfile) Don't delete static_links.
 732         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 733
 734 2019-04-19  Tom Tromey  <tom@tromey.com>
 735
 736         * type-stack.h (struct type_stack) <insert>: Constify string.
 737         * type-stack.c (type_stack::insert): Constify string.
 738         * gdbtypes.h (lookup_template_type): Update.
 739         (address_space_name_to_int): Update.
 740         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 741         const.
 742         (lookup_template_type): Make name const.
 743         * c-exp.y: Update rules.
 744         (lex_one_token, classify_name, classify_inner_name)
 745         (c_print_token): Update.
 746         * p-exp.y: Update rules.
 747         (yylex): Update.
 748         * f-exp.y: Update rules.
 749         (yylex): Update.
 750         * d-exp.y: Update rules.
 751         (lex_one_token, classify_name, classify_inner_name): Update.
 752         * parse.c (write_dollar_variable, copy_name): Return std::string.
 753         * parser-defs.h (copy_name): Change return type.
 754         * m2-exp.y: Update rules.
 755         (yylex): Update.
 756         * go-exp.y (lex_one_token): Update.
 757         Update rules.
 758         (classify_unsafe_function, classify_packaged_name)
 759         (classify_name, yylex): Update.
 760
 761 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 762
 763         * configure.ac: add --enable-source-highlight switch.
 764         * configure: Regenerate.
 765         * top.c (print_gdb_version): plumb --enable-source-highlight
 766         status to "show configuration".
 767
 768 2019-04-19  Tom Tromey  <tromey@adacore.com>
 769
 770         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 771         Check ADA_TYPE_P.
 772         (empty_record, ada_template_to_fixed_record_type_1)
 773         (template_to_static_fixed_type)
 774         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 775         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 776         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 777         macros.
 778
 779 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 780
 781         PR symtab/24423:
 782         * source.c (print_source_lines_base): Advance "iter" when a
 783         control character is seen.
 784
 785 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 786
 787         * inferior.h (struct infcall_suspend_state_deleter):
 788         Catch exception in destructor to avoid crash.
 789
 790 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 791
 792         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 793         close to the add_com "shell".
 794
 795 2019-04-18  Tom Tromey  <tromey@adacore.com>
 796
 797         * process-stratum-target.h (class process_stratum_target)
 798         <stratum>: Add "final".
 799
 800 2019-04-17  Tom Tromey  <tromey@adacore.com>
 801
 802         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 803         against nullptr before use.
 804
 805 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 806
 807         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 808
 809 2019-04-17  Jim Wilson  <jimw@sifive.com>
 810             Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 813         code read might fail, assume 4-byte breakpoint in that case.
 814
 815 2019-04-15  Leszek Swirski  <leszeks@google.com>
 816
 817         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 818         rather than a hand-rolled POD check when checking for forced MEMORY
 819         classification.
 820
 821 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 822
 823         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 824         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 825         function.
 826         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 827         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 828         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 829         declaration.
 830
 831 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 832
 833         * aarch64-linux-nat.c
 834         (aarch64_linux_nat_target::thread_architecture): Add override.
 835         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 836         each VQ.
 837
 838 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 839
 840         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 841
 842 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 845         target types of size 96-bits, add some additional comments, and
 846         check that the builtin type we found was the correct size.
 847
 848 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 849
 850         * utils.c (prompt_for_continue): Don't restore the styling at the
 851         end, as applied_style has the wrong value.  This fixes styling in
 852         long lists of file names that are interrupted by the "Continue?"
 853         prompt.
 854
 855 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 858         * c-lang.c (c_language_defn): Likewise.
 859         (cplus_language_defn): Likewise.
 860         (asm_language_defn): Likewise.
 861         (minimal_language_defn): Likewise.
 862         * d-lang.c (d_language_defn): Likewise.
 863         * f-lang.c (f_language_defn): Likewise.
 864         * go-lang.c (go_language_defn): Likewise.
 865         * language.c (unknown_language_defn): Likewise.
 866         (auto_language_defn): Likewise.
 867         * language.h (struct language_defn): Remove la_magic field.
 868         (LANG_MAGIC): Delete.
 869         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 870         * objc-lang.c (objc_language_defn): Likewise.
 871         * opencl-lang.c (opencl_language_defn): Likewise.
 872         * p-lang.c (pascal_language_defn): Likewise.
 873         * rust-lang.c (rust_language_defn): Likewise.
 874
 875 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * riscv-tdep.c (riscv_type_align): New function.
 878         (riscv_type_alignment): Delete.
 879         (riscv_arg_location): Use 'type_align'.
 880         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 881
 882 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * gdbtypes.c (type_align): A struct with no non-static fields also
 885         has alignment of 1.
 886
 887 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 890         component to 0.
 891         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 892         member.
 893         (riscv_struct_info::analyse): New implementation using new
 894         analyse_inner member function.
 895         (riscv_struct_info::field_offset): New member function.
 896         (riscv_struct_info::m_offsets): New member variable.
 897         (riscv_struct_info::analyse_inner): New private member function,
 898         takes the old implementation of riscv_struct_info::analyse but
 899         extended to track field offsets.
 900         (riscv_call_arg_struct): Update the struct folding special cases
 901         to handle cases where empty C++ structs, which are non-zero
 902         length, are found.
 903         (riscv_arg_location): Initialise the length of each location, a
 904         non-zero length now indicates the location is in use.
 905         (riscv_push_dummy_call): Allow for the first location having a
 906         non-zero offset when setting up arguments.
 907         (riscv_return_value): Likewise, but for return values.
 908
 909 2019-04-11  Tom Tromey  <tromey@adacore.com>
 910
 911         * utils.c (internal_vproblem): Make "msg" const.
 912
 913 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 914
 915         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 916         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 917         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 918         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 919
 920 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 921
 922         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 923         function.
 924         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 925         of amd64_collect_native_gregset.
 926         (amd64_linux_nat_target::store_registers): Likewise.
 927
 928 2019-04-10  Tom Tromey  <tom@tromey.com>
 929
 930         * symtab.c (lookup_global_symbol_from_objfile)
 931         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 932         * objfiles.h (class separate_debug_iterator): New.
 933         (class separate_debug_range): New.
 934         (struct objfile) <separate_debug_objfiles>: New method.
 935         (objfile_separate_debug_iterate): Don't declare.
 936         * objfiles.c (separate_debug_iterator::operator++): Rename from
 937         objfile_separate_debug_iterate.
 938         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 939         iterator.
 940         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 941         iterator.
 942
 943 2019-04-10  Tom Tromey  <tom@tromey.com>
 944
 945         * symfile.c (reread_symbols): Remove old comment.
 946         * objfiles.c (free_all_objfiles): Fix a typo.
 947
 948 2019-04-10  Tom Tromey  <tom@tromey.com>
 949
 950         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 951         * minsyms.c (lookup_minimal_symbol): Use foreach.
 952         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 953         (lookup_minimal_symbol_solib_trampoline): Likewise.
 954         * symfile.c (reread_symbols): Use foreach.
 955
 956 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 957             Tom Tromey  <tromey@adacore.com>
 958
 959         PR rust/24414:
 960         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 961         (rust_lex_int_test): Change "value" to be LONGEST.
 962         (rust_lex_tests): Add test for long integer literal.
 963
 964 2019-04-09  Tom Tromey  <tromey@adacore.com>
 965
 966         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 967         to bool.
 968         (extended_remote_target::attach): Update.
 969         (remote_target::remote_notice_new_inferior): Update.
 970         (remote_target::add_current_inferior_and_thread): Update.
 971         * inferior.c (exit_inferior_1): Use "false".
 972         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 973
 974 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 975
 976         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 977         the "start" command.
 978
 979 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 980
 981         * python/py-inferior.c (infpy_thread_from_thread_handle):
 982         Adjust comments to reflect renaming of thread_from_thread_handle
 983         to thread_from_handle.  Adjust keywords.  Fix type error message.
 984         (inferior_object_methods): Add thread_from_handle.  Retain
 985         thread_from_thread_handle, but mark it as deprecated.
 986
 987 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 988
 989         * gdbthread.h (find_thread_by_handle): Revise declaration.
 990         * thread.c (find_thread_by_handle): Likewise.  Adjust
 991         implementation too.
 992         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 993         support for buffer objects as handles.
 994
 995 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 996
 997         * python/py-infthread.c (thpy_thread_handle): New function.
 998         (thread_object_methods): Register thpy_thread_handle.
 999
1000 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1001
1002         * gdbthread.h (thread_to_thread_handle): Declare.
1003         * thread.c (gdbtypes.h): Include.
1004         (thread_to_thread_handle): New function.
1005
1006         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1007         (target_thread_info_to_thread_handle): Declare.
1008         * target.c (target_thread_info_to_thread_handle): New function.
1009         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1010         * target-delegates.c: Regenerate.
1011
1012         * linux-thread-db.c (class thread_db_target): Add method
1013         thread_info_to_thread_handle.
1014         (thread_db_target::thread_info_to_thread_handle): Define.
1015         * remote.c (class remote_target): Add new method
1016         thread_info_to_thread_handle.
1017         (remote_target::thread_info_to_thread_handle): Define.
1018
1019 2019-04-08  Pedro Alves  <palves@redhat.com>
1020
1021         * common/common-exceptions.c (throw_exception): Don't create
1022         named object to throw; throw directly.
1023         (throw_it): Likewise.  Don't initialize gdb_exception::message
1024         here, with new; pass FMT and AP to the ctor instead.
1025         * common/common-exceptions.h: Include <string>.
1026         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1027         const char *, va_list)): New ctor.  Use std::make_shared.
1028         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1029         errors)): Delete.
1030         (gdb_exception_error::gdb_exception_error(enum errors, const char
1031         *, va_list)): New.
1032         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1033         Add assertion.
1034         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1035         errors)): Delete.
1036         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1037         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1038         Add assertion.
1039
1040 2019-04-08  Tom Tromey  <tom@tromey.com>
1041
1042         * valops.c (value_rtti_indirect_type): Replace throw_exception
1043         with throw.
1044         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1045         with throw.
1046         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1047         throw.
1048         * target.c (target_translate_tls_address): Replace throw_exception
1049         with throw.
1050         * stack.c (frame_apply_command_count): Replace throw_exception
1051         with throw.
1052         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1053         throw.
1054         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1055         with throw.
1056         * rs6000-tdep.c (rs6000_frame_cache)
1057         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1058         * remote.c: Replace throw_exception with throw.
1059         * record-full.c (record_full_message, record_full_wait_1)
1060         (record_full_restore): Replace throw_exception with throw.
1061         * record-btrace.c:
1062         (get_thread_current_frame_id, record_btrace_start_replaying)
1063         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1064         (cmd_record_btrace_start): Replace throw_exception with throw.
1065         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1066         throw.
1067         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1068         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1069         * linespec.c:
1070         (find_linespec_symbols): Replace throw_exception with throw.
1071         * infrun.c (displaced_step_prepare, resume): Replace
1072         throw_exception with throw.
1073         * infcmd.c (post_create_inferior): Replace throw_exception with
1074         throw.
1075         * inf-loop.c (inferior_event_handler): Replace throw_exception
1076         with throw.
1077         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1078         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1079         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1080         (get_prev_frame_always, get_frame_pc_if_available)
1081         (get_frame_address_in_block_if_available, get_frame_language):
1082         Replace throw_exception with throw.
1083         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1084         throw_exception with throw.
1085         * eval.c (fetch_subexp_value, evaluate_var_value)
1086         (evaluate_funcall, evaluate_subexp_standard): Replace
1087         throw_exception with throw.
1088         * dwarf2loc.c (call_site_find_chain)
1089         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1090         Replace throw_exception with throw.
1091         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1092         with throw.
1093         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1094         throw.
1095         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1096         * completer.c (complete_line_internal): Replace throw_exception
1097         with throw.
1098         * compile/compile-object-run.c (compile_object_run): Replace
1099         throw_exception with throw.
1100         * cli/cli-script.c (process_next_line): Replace throw_exception
1101         with throw.
1102         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1103         (btrace_enable, btrace_maint_update_pt_packets): Replace
1104         throw_exception with throw.
1105         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1106         throw_exception with throw.
1107         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1108         throw_exception with throw.
1109         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1110         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1111         * aarch64-tdep.c (aarch64_make_prologue_cache)
1112         (aarch64_make_stub_cache): Replace throw_exception with throw.
1113
1114 2019-04-08  Tom Tromey  <tom@tromey.com>
1115
1116         * common/common-exceptions.c (throw_exception): Rename from
1117         throw_exception_cxx.  Remove old copy.  Make argument const.
1118         (throw_it): Create and throw exception objects directly.
1119         * common/common-exceptions.h (throw_exception): Make argument
1120         const.
1121         (struct gdb_exception_error): Add constructor.
1122         (struct gdb_exception_quit): Add constructor.
1123
1124 2019-04-08  Tom Tromey  <tom@tromey.com>
1125
1126         * common/common-exceptions.h (exception_rethrow): Don't declare.
1127         (TRY_SJLJ): Update comment.
1128         (TRY, CATCH, END_CATCH): Remove.
1129         * common/common-exceptions.c (exception_rethrow): Remove.
1130
1131 2019-04-08  Tom Tromey  <tom@tromey.com>
1132
1133         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1134         Remove.
1135         (gdb_exception_error): Rename from
1136         gdb_exception_RETURN_MASK_ERROR.
1137         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1138         (gdb_quit_bad_alloc): Update.
1139         * aarch64-tdep.c: Update.
1140         * ada-lang.c: Update.
1141         * ada-typeprint.c: Update.
1142         * ada-valprint.c: Update.
1143         * amd64-tdep.c: Update.
1144         * arch-utils.c: Update.
1145         * break-catch-throw.c: Update.
1146         * breakpoint.c: Update.
1147         * btrace.c: Update.
1148         * c-varobj.c: Update.
1149         * cli/cli-cmds.c: Update.
1150         * cli/cli-interp.c: Update.
1151         * cli/cli-script.c: Update.
1152         * common/common-exceptions.c: Update.
1153         * common/new-op.c: Update.
1154         * common/selftest.c: Update.
1155         * compile/compile-c-symbols.c: Update.
1156         * compile/compile-cplus-symbols.c: Update.
1157         * compile/compile-object-load.c: Update.
1158         * compile/compile-object-run.c: Update.
1159         * completer.c: Update.
1160         * corelow.c: Update.
1161         * cp-abi.c: Update.
1162         * cp-support.c: Update.
1163         * cp-valprint.c: Update.
1164         * darwin-nat.c: Update.
1165         * disasm-selftests.c: Update.
1166         * dtrace-probe.c: Update.
1167         * dwarf-index-cache.c: Update.
1168         * dwarf-index-write.c: Update.
1169         * dwarf2-frame-tailcall.c: Update.
1170         * dwarf2-frame.c: Update.
1171         * dwarf2loc.c: Update.
1172         * dwarf2read.c: Update.
1173         * eval.c: Update.
1174         * event-loop.c: Update.
1175         * event-top.c: Update.
1176         * exec.c: Update.
1177         * f-valprint.c: Update.
1178         * fbsd-tdep.c: Update.
1179         * frame-unwind.c: Update.
1180         * frame.c: Update.
1181         * gdbtypes.c: Update.
1182         * gnu-v3-abi.c: Update.
1183         * guile/guile-internal.h: Update.
1184         * guile/scm-block.c: Update.
1185         * guile/scm-breakpoint.c: Update.
1186         * guile/scm-cmd.c: Update.
1187         * guile/scm-disasm.c: Update.
1188         * guile/scm-frame.c: Update.
1189         * guile/scm-lazy-string.c: Update.
1190         * guile/scm-math.c: Update.
1191         * guile/scm-param.c: Update.
1192         * guile/scm-ports.c: Update.
1193         * guile/scm-pretty-print.c: Update.
1194         * guile/scm-symbol.c: Update.
1195         * guile/scm-symtab.c: Update.
1196         * guile/scm-type.c: Update.
1197         * guile/scm-value.c: Update.
1198         * i386-linux-tdep.c: Update.
1199         * i386-tdep.c: Update.
1200         * inf-loop.c: Update.
1201         * infcall.c: Update.
1202         * infcmd.c: Update.
1203         * infrun.c: Update.
1204         * jit.c: Update.
1205         * language.c: Update.
1206         * linespec.c: Update.
1207         * linux-fork.c: Update.
1208         * linux-nat.c: Update.
1209         * linux-tdep.c: Update.
1210         * linux-thread-db.c: Update.
1211         * main.c: Update.
1212         * mi/mi-cmd-break.c: Update.
1213         * mi/mi-cmd-stack.c: Update.
1214         * mi/mi-interp.c: Update.
1215         * mi/mi-main.c: Update.
1216         * objc-lang.c: Update.
1217         * p-valprint.c: Update.
1218         * parse.c: Update.
1219         * ppc-linux-tdep.c: Update.
1220         * printcmd.c: Update.
1221         * python/py-arch.c: Update.
1222         * python/py-breakpoint.c: Update.
1223         * python/py-cmd.c: Update.
1224         * python/py-finishbreakpoint.c: Update.
1225         * python/py-frame.c: Update.
1226         * python/py-framefilter.c: Update.
1227         * python/py-gdb-readline.c: Update.
1228         * python/py-inferior.c: Update.
1229         * python/py-infthread.c: Update.
1230         * python/py-lazy-string.c: Update.
1231         * python/py-linetable.c: Update.
1232         * python/py-objfile.c: Update.
1233         * python/py-param.c: Update.
1234         * python/py-prettyprint.c: Update.
1235         * python/py-progspace.c: Update.
1236         * python/py-record-btrace.c: Update.
1237         * python/py-record.c: Update.
1238         * python/py-symbol.c: Update.
1239         * python/py-type.c: Update.
1240         * python/py-unwind.c: Update.
1241         * python/py-utils.c: Update.
1242         * python/py-value.c: Update.
1243         * python/python.c: Update.
1244         * record-btrace.c: Update.
1245         * record-full.c: Update.
1246         * remote-fileio.c: Update.
1247         * remote.c: Update.
1248         * riscv-tdep.c: Update.
1249         * rs6000-aix-tdep.c: Update.
1250         * rs6000-tdep.c: Update.
1251         * rust-exp.y: Update.
1252         * rust-lang.c: Update.
1253         * s390-tdep.c: Update.
1254         * selftest-arch.c: Update.
1255         * solib-dsbt.c: Update.
1256         * solib-frv.c: Update.
1257         * solib-spu.c: Update.
1258         * solib-svr4.c: Update.
1259         * solib.c: Update.
1260         * sparc64-linux-tdep.c: Update.
1261         * stack.c: Update.
1262         * symfile-mem.c: Update.
1263         * symmisc.c: Update.
1264         * target.c: Update.
1265         * thread.c: Update.
1266         * top.c: Update.
1267         * tracefile-tfile.c: Update.
1268         * tui/tui.c: Update.
1269         * typeprint.c: Update.
1270         * unittests/cli-utils-selftests.c: Update.
1271         * unittests/parse-connection-spec-selftests.c: Update.
1272         * valops.c: Update.
1273         * valprint.c: Update.
1274         * value.c: Update.
1275         * varobj.c: Update.
1276         * windows-nat.c: Update.
1277         * x86-linux-nat.c: Update.
1278         * xml-support.c: Update.
1279
1280 2019-04-08  Tom Tromey  <tom@tromey.com>
1281
1282         * xml-support.c: Use C++ exception handling.
1283         * x86-linux-nat.c: Use C++ exception handling.
1284         * windows-nat.c: Use C++ exception handling.
1285         * varobj.c: Use C++ exception handling.
1286         * value.c: Use C++ exception handling.
1287         * valprint.c: Use C++ exception handling.
1288         * valops.c: Use C++ exception handling.
1289         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1290         handling.
1291         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1292         * typeprint.c: Use C++ exception handling.
1293         * tui/tui.c: Use C++ exception handling.
1294         * tracefile-tfile.c: Use C++ exception handling.
1295         * top.c: Use C++ exception handling.
1296         * thread.c: Use C++ exception handling.
1297         * target.c: Use C++ exception handling.
1298         * symmisc.c: Use C++ exception handling.
1299         * symfile-mem.c: Use C++ exception handling.
1300         * stack.c: Use C++ exception handling.
1301         * sparc64-linux-tdep.c: Use C++ exception handling.
1302         * solib.c: Use C++ exception handling.
1303         * solib-svr4.c: Use C++ exception handling.
1304         * solib-spu.c: Use C++ exception handling.
1305         * solib-frv.c: Use C++ exception handling.
1306         * solib-dsbt.c: Use C++ exception handling.
1307         * selftest-arch.c: Use C++ exception handling.
1308         * s390-tdep.c: Use C++ exception handling.
1309         * rust-lang.c: Use C++ exception handling.
1310         * rust-exp.y: Use C++ exception handling.
1311         * rs6000-tdep.c: Use C++ exception handling.
1312         * rs6000-aix-tdep.c: Use C++ exception handling.
1313         * riscv-tdep.c: Use C++ exception handling.
1314         * remote.c: Use C++ exception handling.
1315         * remote-fileio.c: Use C++ exception handling.
1316         * record-full.c: Use C++ exception handling.
1317         * record-btrace.c: Use C++ exception handling.
1318         * python/python.c: Use C++ exception handling.
1319         * python/py-value.c: Use C++ exception handling.
1320         * python/py-utils.c: Use C++ exception handling.
1321         * python/py-unwind.c: Use C++ exception handling.
1322         * python/py-type.c: Use C++ exception handling.
1323         * python/py-symbol.c: Use C++ exception handling.
1324         * python/py-record.c: Use C++ exception handling.
1325         * python/py-record-btrace.c: Use C++ exception handling.
1326         * python/py-progspace.c: Use C++ exception handling.
1327         * python/py-prettyprint.c: Use C++ exception handling.
1328         * python/py-param.c: Use C++ exception handling.
1329         * python/py-objfile.c: Use C++ exception handling.
1330         * python/py-linetable.c: Use C++ exception handling.
1331         * python/py-lazy-string.c: Use C++ exception handling.
1332         * python/py-infthread.c: Use C++ exception handling.
1333         * python/py-inferior.c: Use C++ exception handling.
1334         * python/py-gdb-readline.c: Use C++ exception handling.
1335         * python/py-framefilter.c: Use C++ exception handling.
1336         * python/py-frame.c: Use C++ exception handling.
1337         * python/py-finishbreakpoint.c: Use C++ exception handling.
1338         * python/py-cmd.c: Use C++ exception handling.
1339         * python/py-breakpoint.c: Use C++ exception handling.
1340         * python/py-arch.c: Use C++ exception handling.
1341         * printcmd.c: Use C++ exception handling.
1342         * ppc-linux-tdep.c: Use C++ exception handling.
1343         * parse.c: Use C++ exception handling.
1344         * p-valprint.c: Use C++ exception handling.
1345         * objc-lang.c: Use C++ exception handling.
1346         * mi/mi-main.c: Use C++ exception handling.
1347         * mi/mi-interp.c: Use C++ exception handling.
1348         * mi/mi-cmd-stack.c: Use C++ exception handling.
1349         * mi/mi-cmd-break.c: Use C++ exception handling.
1350         * main.c: Use C++ exception handling.
1351         * linux-thread-db.c: Use C++ exception handling.
1352         * linux-tdep.c: Use C++ exception handling.
1353         * linux-nat.c: Use C++ exception handling.
1354         * linux-fork.c: Use C++ exception handling.
1355         * linespec.c: Use C++ exception handling.
1356         * language.c: Use C++ exception handling.
1357         * jit.c: Use C++ exception handling.
1358         * infrun.c: Use C++ exception handling.
1359         * infcmd.c: Use C++ exception handling.
1360         * infcall.c: Use C++ exception handling.
1361         * inf-loop.c: Use C++ exception handling.
1362         * i386-tdep.c: Use C++ exception handling.
1363         * i386-linux-tdep.c: Use C++ exception handling.
1364         * guile/scm-value.c: Use C++ exception handling.
1365         * guile/scm-type.c: Use C++ exception handling.
1366         * guile/scm-symtab.c: Use C++ exception handling.
1367         * guile/scm-symbol.c: Use C++ exception handling.
1368         * guile/scm-pretty-print.c: Use C++ exception handling.
1369         * guile/scm-ports.c: Use C++ exception handling.
1370         * guile/scm-param.c: Use C++ exception handling.
1371         * guile/scm-math.c: Use C++ exception handling.
1372         * guile/scm-lazy-string.c: Use C++ exception handling.
1373         * guile/scm-frame.c: Use C++ exception handling.
1374         * guile/scm-disasm.c: Use C++ exception handling.
1375         * guile/scm-cmd.c: Use C++ exception handling.
1376         * guile/scm-breakpoint.c: Use C++ exception handling.
1377         * guile/scm-block.c: Use C++ exception handling.
1378         * guile/guile-internal.h: Use C++ exception handling.
1379         * gnu-v3-abi.c: Use C++ exception handling.
1380         * gdbtypes.c: Use C++ exception handling.
1381         * frame.c: Use C++ exception handling.
1382         * frame-unwind.c: Use C++ exception handling.
1383         * fbsd-tdep.c: Use C++ exception handling.
1384         * f-valprint.c: Use C++ exception handling.
1385         * exec.c: Use C++ exception handling.
1386         * event-top.c: Use C++ exception handling.
1387         * event-loop.c: Use C++ exception handling.
1388         * eval.c: Use C++ exception handling.
1389         * dwarf2read.c: Use C++ exception handling.
1390         * dwarf2loc.c: Use C++ exception handling.
1391         * dwarf2-frame.c: Use C++ exception handling.
1392         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1393         * dwarf-index-write.c: Use C++ exception handling.
1394         * dwarf-index-cache.c: Use C++ exception handling.
1395         * dtrace-probe.c: Use C++ exception handling.
1396         * disasm-selftests.c: Use C++ exception handling.
1397         * darwin-nat.c: Use C++ exception handling.
1398         * cp-valprint.c: Use C++ exception handling.
1399         * cp-support.c: Use C++ exception handling.
1400         * cp-abi.c: Use C++ exception handling.
1401         * corelow.c: Use C++ exception handling.
1402         * completer.c: Use C++ exception handling.
1403         * compile/compile-object-run.c: Use C++ exception handling.
1404         * compile/compile-object-load.c: Use C++ exception handling.
1405         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1406         * compile/compile-c-symbols.c: Use C++ exception handling.
1407         * common/selftest.c: Use C++ exception handling.
1408         * common/new-op.c: Use C++ exception handling.
1409         * cli/cli-script.c: Use C++ exception handling.
1410         * cli/cli-interp.c: Use C++ exception handling.
1411         * cli/cli-cmds.c: Use C++ exception handling.
1412         * c-varobj.c: Use C++ exception handling.
1413         * btrace.c: Use C++ exception handling.
1414         * breakpoint.c: Use C++ exception handling.
1415         * break-catch-throw.c: Use C++ exception handling.
1416         * arch-utils.c: Use C++ exception handling.
1417         * amd64-tdep.c: Use C++ exception handling.
1418         * ada-valprint.c: Use C++ exception handling.
1419         * ada-typeprint.c: Use C++ exception handling.
1420         * ada-lang.c: Use C++ exception handling.
1421         * aarch64-tdep.c: Use C++ exception handling.
1422
1423 2019-04-08  Tom Tromey  <tom@tromey.com>
1424
1425         * xml-support.c (gdb_xml_parser::parse): Update.
1426         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1427         * value.c (show_convenience): Update.
1428         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1429         (test_parse_flags_qcs): Update.
1430         * thread.c (thr_try_catch_cmd): Update.
1431         * target.c (target_translate_tls_address): Update.
1432         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1433         (info_frame_command_core, frame_apply_command_count): Update.
1434         * rust-exp.y (rust_lex_exception_test): Update.
1435         * riscv-tdep.c (riscv_print_one_register_info): Update.
1436         * remote.c (remote_target::enable_btrace): Update.
1437         * record-btrace.c (record_btrace_enable_warn): Update.
1438         * python/py-utils.c (gdbpy_convert_exception): Update.
1439         * printcmd.c (do_one_display, print_variable_and_value): Update.
1440         * mi/mi-main.c (mi_print_exception): Update.
1441         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1442         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1443         * linux-nat.c (linux_nat_target::attach): Update.
1444         * linux-fork.c (class scoped_switch_fork_info): Update.
1445         * infrun.c (displaced_step_prepare): Update.
1446         * infcall.c (call_function_by_hand_dummy): Update.
1447         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1448         * gnu-v3-abi.c (print_one_vtable): Update.
1449         * frame.c (get_prev_frame_always): Update.
1450         * f-valprint.c (info_common_command_for_block): Update.
1451         * exec.c (try_open_exec_file): Update.
1452         * exceptions.c (print_exception, exception_print)
1453         (exception_fprintf, exception_print_same): Update.
1454         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1455         * dwarf-index-cache.c (index_cache::store)
1456         (index_cache::lookup_gdb_index): Update.
1457         * darwin-nat.c (maybe_cache_shell): Update.
1458         * cp-valprint.c (cp_print_value_fields): Update.
1459         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1460         (gcc_cplus_symbol_address): Update.
1461         * compile/compile-c-symbols.c (gcc_convert_symbol)
1462         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1463         * common/selftest.c: Update.
1464         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1465         a std::string.
1466         (exception_try_scope_entry, exception_try_scope_exit): Don't
1467         declare.
1468         (struct exception_try_scope): Remove.
1469         (TRY): Don't use exception_try_scope.
1470         (struct gdb_exception): Add constructor, operator=.
1471         <what>: New method.
1472         (struct gdb_exception_RETURN_MASK_ALL)
1473         (struct gdb_exception_RETURN_MASK_ERROR)
1474         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1475         (struct gdb_quit_bad_alloc): Update.
1476         * common/common-exceptions.c (exception_none): Change
1477         initializer.
1478         (struct catcher) <state, exception>: Initialize inline.
1479         <prev>: Remove member.
1480         (current_catcher): Remove.
1481         (catchers): New global.
1482         (exceptions_state_mc_init): Simplify.
1483         (catcher_pop): Remove.
1484         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1485         (try_scope_depth, exception_try_scope_entry)
1486         (exception_try_scope_exit): Remove.
1487         (throw_exception_sjlj): Update.
1488         (exception_messages, exception_messages_size): Remove.
1489         (throw_it): Simplify.
1490         (gdb_exception_sliced_copy): Remove.
1491         (throw_exception_cxx): Update.
1492         * cli/cli-script.c (script_from_file): Update.
1493         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1494         Update.
1495         * ada-valprint.c (ada_val_print): Update.
1496         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1497         (create_excep_cond_exprs): Update.
1498
1499 2019-04-08  Tom Tromey  <tom@tromey.com>
1500
1501         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1502         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1503         (TRY, CATCH, END_CATCH): Remove some definitions.
1504         * common/common-exceptions.c: Don't use GDB_XCPT.
1505         (catcher_list_size): Remove.
1506         (throw_exception, throw_it): Simplify.
1507
1508 2019-04-05  Tom Tromey  <tom@tromey.com>
1509
1510         Revert the header-sorting patch.
1511         * ft32-tdep.c: Revert.
1512         * frv-tdep.c: Revert.
1513         * frv-linux-tdep.c: Revert.
1514         * frame.c: Revert.
1515         * frame-unwind.c: Revert.
1516         * frame-base.c: Revert.
1517         * fork-child.c: Revert.
1518         * findvar.c: Revert.
1519         * findcmd.c: Revert.
1520         * filesystem.c: Revert.
1521         * filename-seen-cache.h: Revert.
1522         * filename-seen-cache.c: Revert.
1523         * fbsd-tdep.c: Revert.
1524         * fbsd-nat.h: Revert.
1525         * fbsd-nat.c: Revert.
1526         * f-valprint.c: Revert.
1527         * f-typeprint.c: Revert.
1528         * f-lang.c: Revert.
1529         * extension.h: Revert.
1530         * extension.c: Revert.
1531         * extension-priv.h: Revert.
1532         * expprint.c: Revert.
1533         * exec.h: Revert.
1534         * exec.c: Revert.
1535         * exceptions.c: Revert.
1536         * event-top.c: Revert.
1537         * event-loop.c: Revert.
1538         * eval.c: Revert.
1539         * elfread.c: Revert.
1540         * dwarf2read.h: Revert.
1541         * dwarf2read.c: Revert.
1542         * dwarf2loc.c: Revert.
1543         * dwarf2expr.h: Revert.
1544         * dwarf2expr.c: Revert.
1545         * dwarf2-frame.c: Revert.
1546         * dwarf2-frame-tailcall.c: Revert.
1547         * dwarf-index-write.h: Revert.
1548         * dwarf-index-write.c: Revert.
1549         * dwarf-index-common.c: Revert.
1550         * dwarf-index-cache.h: Revert.
1551         * dwarf-index-cache.c: Revert.
1552         * dummy-frame.c: Revert.
1553         * dtrace-probe.c: Revert.
1554         * disasm.h: Revert.
1555         * disasm.c: Revert.
1556         * disasm-selftests.c: Revert.
1557         * dictionary.c: Revert.
1558         * dicos-tdep.c: Revert.
1559         * demangle.c: Revert.
1560         * dcache.h: Revert.
1561         * dcache.c: Revert.
1562         * darwin-nat.h: Revert.
1563         * darwin-nat.c: Revert.
1564         * darwin-nat-info.c: Revert.
1565         * d-valprint.c: Revert.
1566         * d-namespace.c: Revert.
1567         * d-lang.c: Revert.
1568         * ctf.c: Revert.
1569         * csky-tdep.c: Revert.
1570         * csky-linux-tdep.c: Revert.
1571         * cris-tdep.c: Revert.
1572         * cris-linux-tdep.c: Revert.
1573         * cp-valprint.c: Revert.
1574         * cp-support.c: Revert.
1575         * cp-namespace.c: Revert.
1576         * cp-abi.c: Revert.
1577         * corelow.c: Revert.
1578         * corefile.c: Revert.
1579         * continuations.c: Revert.
1580         * completer.h: Revert.
1581         * completer.c: Revert.
1582         * complaints.c: Revert.
1583         * coffread.c: Revert.
1584         * coff-pe-read.c: Revert.
1585         * cli-out.h: Revert.
1586         * cli-out.c: Revert.
1587         * charset.c: Revert.
1588         * c-varobj.c: Revert.
1589         * c-valprint.c: Revert.
1590         * c-typeprint.c: Revert.
1591         * c-lang.c: Revert.
1592         * buildsym.c: Revert.
1593         * buildsym-legacy.c: Revert.
1594         * build-id.h: Revert.
1595         * build-id.c: Revert.
1596         * btrace.c: Revert.
1597         * bsd-uthread.c: Revert.
1598         * breakpoint.h: Revert.
1599         * breakpoint.c: Revert.
1600         * break-catch-throw.c: Revert.
1601         * break-catch-syscall.c: Revert.
1602         * break-catch-sig.c: Revert.
1603         * blockframe.c: Revert.
1604         * block.c: Revert.
1605         * bfin-tdep.c: Revert.
1606         * bfin-linux-tdep.c: Revert.
1607         * bfd-target.c: Revert.
1608         * bcache.c: Revert.
1609         * ax-general.c: Revert.
1610         * ax-gdb.h: Revert.
1611         * ax-gdb.c: Revert.
1612         * avr-tdep.c: Revert.
1613         * auxv.c: Revert.
1614         * auto-load.c: Revert.
1615         * arm-wince-tdep.c: Revert.
1616         * arm-tdep.c: Revert.
1617         * arm-symbian-tdep.c: Revert.
1618         * arm-pikeos-tdep.c: Revert.
1619         * arm-obsd-tdep.c: Revert.
1620         * arm-nbsd-tdep.c: Revert.
1621         * arm-nbsd-nat.c: Revert.
1622         * arm-linux-tdep.c: Revert.
1623         * arm-linux-nat.c: Revert.
1624         * arm-fbsd-tdep.c: Revert.
1625         * arm-fbsd-nat.c: Revert.
1626         * arm-bsd-tdep.c: Revert.
1627         * arch-utils.c: Revert.
1628         * arc-tdep.c: Revert.
1629         * arc-newlib-tdep.c: Revert.
1630         * annotate.h: Revert.
1631         * annotate.c: Revert.
1632         * amd64-windows-tdep.c: Revert.
1633         * amd64-windows-nat.c: Revert.
1634         * amd64-tdep.c: Revert.
1635         * amd64-sol2-tdep.c: Revert.
1636         * amd64-obsd-tdep.c: Revert.
1637         * amd64-obsd-nat.c: Revert.
1638         * amd64-nbsd-tdep.c: Revert.
1639         * amd64-nbsd-nat.c: Revert.
1640         * amd64-nat.c: Revert.
1641         * amd64-linux-tdep.c: Revert.
1642         * amd64-linux-nat.c: Revert.
1643         * amd64-fbsd-tdep.c: Revert.
1644         * amd64-fbsd-nat.c: Revert.
1645         * amd64-dicos-tdep.c: Revert.
1646         * amd64-darwin-tdep.c: Revert.
1647         * amd64-bsd-nat.c: Revert.
1648         * alpha-tdep.c: Revert.
1649         * alpha-obsd-tdep.c: Revert.
1650         * alpha-nbsd-tdep.c: Revert.
1651         * alpha-mdebug-tdep.c: Revert.
1652         * alpha-linux-tdep.c: Revert.
1653         * alpha-linux-nat.c: Revert.
1654         * alpha-bsd-tdep.c: Revert.
1655         * alpha-bsd-nat.c: Revert.
1656         * aix-thread.c: Revert.
1657         * agent.c: Revert.
1658         * addrmap.c: Revert.
1659         * ada-varobj.c: Revert.
1660         * ada-valprint.c: Revert.
1661         * ada-typeprint.c: Revert.
1662         * ada-tasks.c: Revert.
1663         * ada-lang.c: Revert.
1664         * aarch64-tdep.c: Revert.
1665         * aarch64-ravenscar-thread.c: Revert.
1666         * aarch64-newlib-tdep.c: Revert.
1667         * aarch64-linux-tdep.c: Revert.
1668         * aarch64-linux-nat.c: Revert.
1669         * aarch64-fbsd-tdep.c: Revert.
1670         * aarch64-fbsd-nat.c: Revert.
1671         * aarch32-linux-nat.c: Revert.
1672
1673 2019-04-05  Tom Tromey  <tom@tromey.com>
1674
1675         * ft32-tdep.c: Sort headers.
1676         * frv-tdep.c: Sort headers.
1677         * frv-linux-tdep.c: Sort headers.
1678         * frame.c: Sort headers.
1679         * frame-unwind.c: Sort headers.
1680         * frame-base.c: Sort headers.
1681         * fork-child.c: Sort headers.
1682         * findvar.c: Sort headers.
1683         * findcmd.c: Sort headers.
1684         * filesystem.c: Sort headers.
1685         * filename-seen-cache.h: Sort headers.
1686         * filename-seen-cache.c: Sort headers.
1687         * fbsd-tdep.c: Sort headers.
1688         * fbsd-nat.h: Sort headers.
1689         * fbsd-nat.c: Sort headers.
1690         * f-valprint.c: Sort headers.
1691         * f-typeprint.c: Sort headers.
1692         * f-lang.c: Sort headers.
1693         * extension.h: Sort headers.
1694         * extension.c: Sort headers.
1695         * extension-priv.h: Sort headers.
1696         * expprint.c: Sort headers.
1697         * exec.h: Sort headers.
1698         * exec.c: Sort headers.
1699         * exceptions.c: Sort headers.
1700         * event-top.c: Sort headers.
1701         * event-loop.c: Sort headers.
1702         * eval.c: Sort headers.
1703         * elfread.c: Sort headers.
1704         * dwarf2read.h: Sort headers.
1705         * dwarf2read.c: Sort headers.
1706         * dwarf2loc.c: Sort headers.
1707         * dwarf2expr.h: Sort headers.
1708         * dwarf2expr.c: Sort headers.
1709         * dwarf2-frame.c: Sort headers.
1710         * dwarf2-frame-tailcall.c: Sort headers.
1711         * dwarf-index-write.h: Sort headers.
1712         * dwarf-index-write.c: Sort headers.
1713         * dwarf-index-common.c: Sort headers.
1714         * dwarf-index-cache.h: Sort headers.
1715         * dwarf-index-cache.c: Sort headers.
1716         * dummy-frame.c: Sort headers.
1717         * dtrace-probe.c: Sort headers.
1718         * disasm.h: Sort headers.
1719         * disasm.c: Sort headers.
1720         * disasm-selftests.c: Sort headers.
1721         * dictionary.c: Sort headers.
1722         * dicos-tdep.c: Sort headers.
1723         * demangle.c: Sort headers.
1724         * dcache.h: Sort headers.
1725         * dcache.c: Sort headers.
1726         * darwin-nat.h: Sort headers.
1727         * darwin-nat.c: Sort headers.
1728         * darwin-nat-info.c: Sort headers.
1729         * d-valprint.c: Sort headers.
1730         * d-namespace.c: Sort headers.
1731         * d-lang.c: Sort headers.
1732         * ctf.c: Sort headers.
1733         * csky-tdep.c: Sort headers.
1734         * csky-linux-tdep.c: Sort headers.
1735         * cris-tdep.c: Sort headers.
1736         * cris-linux-tdep.c: Sort headers.
1737         * cp-valprint.c: Sort headers.
1738         * cp-support.c: Sort headers.
1739         * cp-namespace.c: Sort headers.
1740         * cp-abi.c: Sort headers.
1741         * corelow.c: Sort headers.
1742         * corefile.c: Sort headers.
1743         * continuations.c: Sort headers.
1744         * completer.h: Sort headers.
1745         * completer.c: Sort headers.
1746         * complaints.c: Sort headers.
1747         * coffread.c: Sort headers.
1748         * coff-pe-read.c: Sort headers.
1749         * cli-out.h: Sort headers.
1750         * cli-out.c: Sort headers.
1751         * charset.c: Sort headers.
1752         * c-varobj.c: Sort headers.
1753         * c-valprint.c: Sort headers.
1754         * c-typeprint.c: Sort headers.
1755         * c-lang.c: Sort headers.
1756         * buildsym.c: Sort headers.
1757         * buildsym-legacy.c: Sort headers.
1758         * build-id.h: Sort headers.
1759         * build-id.c: Sort headers.
1760         * btrace.c: Sort headers.
1761         * bsd-uthread.c: Sort headers.
1762         * breakpoint.h: Sort headers.
1763         * breakpoint.c: Sort headers.
1764         * break-catch-throw.c: Sort headers.
1765         * break-catch-syscall.c: Sort headers.
1766         * break-catch-sig.c: Sort headers.
1767         * blockframe.c: Sort headers.
1768         * block.c: Sort headers.
1769         * bfin-tdep.c: Sort headers.
1770         * bfin-linux-tdep.c: Sort headers.
1771         * bfd-target.c: Sort headers.
1772         * bcache.c: Sort headers.
1773         * ax-general.c: Sort headers.
1774         * ax-gdb.h: Sort headers.
1775         * ax-gdb.c: Sort headers.
1776         * avr-tdep.c: Sort headers.
1777         * auxv.c: Sort headers.
1778         * auto-load.c: Sort headers.
1779         * arm-wince-tdep.c: Sort headers.
1780         * arm-tdep.c: Sort headers.
1781         * arm-symbian-tdep.c: Sort headers.
1782         * arm-pikeos-tdep.c: Sort headers.
1783         * arm-obsd-tdep.c: Sort headers.
1784         * arm-nbsd-tdep.c: Sort headers.
1785         * arm-nbsd-nat.c: Sort headers.
1786         * arm-linux-tdep.c: Sort headers.
1787         * arm-linux-nat.c: Sort headers.
1788         * arm-fbsd-tdep.c: Sort headers.
1789         * arm-fbsd-nat.c: Sort headers.
1790         * arm-bsd-tdep.c: Sort headers.
1791         * arch-utils.c: Sort headers.
1792         * arc-tdep.c: Sort headers.
1793         * arc-newlib-tdep.c: Sort headers.
1794         * annotate.h: Sort headers.
1795         * annotate.c: Sort headers.
1796         * amd64-windows-tdep.c: Sort headers.
1797         * amd64-windows-nat.c: Sort headers.
1798         * amd64-tdep.c: Sort headers.
1799         * amd64-sol2-tdep.c: Sort headers.
1800         * amd64-obsd-tdep.c: Sort headers.
1801         * amd64-obsd-nat.c: Sort headers.
1802         * amd64-nbsd-tdep.c: Sort headers.
1803         * amd64-nbsd-nat.c: Sort headers.
1804         * amd64-nat.c: Sort headers.
1805         * amd64-linux-tdep.c: Sort headers.
1806         * amd64-linux-nat.c: Sort headers.
1807         * amd64-fbsd-tdep.c: Sort headers.
1808         * amd64-fbsd-nat.c: Sort headers.
1809         * amd64-dicos-tdep.c: Sort headers.
1810         * amd64-darwin-tdep.c: Sort headers.
1811         * amd64-bsd-nat.c: Sort headers.
1812         * alpha-tdep.c: Sort headers.
1813         * alpha-obsd-tdep.c: Sort headers.
1814         * alpha-nbsd-tdep.c: Sort headers.
1815         * alpha-mdebug-tdep.c: Sort headers.
1816         * alpha-linux-tdep.c: Sort headers.
1817         * alpha-linux-nat.c: Sort headers.
1818         * alpha-bsd-tdep.c: Sort headers.
1819         * alpha-bsd-nat.c: Sort headers.
1820         * aix-thread.c: Sort headers.
1821         * agent.c: Sort headers.
1822         * addrmap.c: Sort headers.
1823         * ada-varobj.c: Sort headers.
1824         * ada-valprint.c: Sort headers.
1825         * ada-typeprint.c: Sort headers.
1826         * ada-tasks.c: Sort headers.
1827         * ada-lang.c: Sort headers.
1828         * aarch64-tdep.c: Sort headers.
1829         * aarch64-ravenscar-thread.c: Sort headers.
1830         * aarch64-newlib-tdep.c: Sort headers.
1831         * aarch64-linux-tdep.c: Sort headers.
1832         * aarch64-linux-nat.c: Sort headers.
1833         * aarch64-fbsd-tdep.c: Sort headers.
1834         * aarch64-fbsd-nat.c: Sort headers.
1835         * aarch32-linux-nat.c: Sort headers.
1836
1837 2019-04-04  Tom Tromey  <tom@tromey.com>
1838
1839         * varobj.c (varobj_create): Update.
1840         * rust-exp.y (struct rust_parser) <update_innermost_block,
1841         lookup_symbol>: New methods.
1842         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1843         Rename.
1844         (rust_parser::rust_lookup_type)
1845         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1846         * printcmd.c (display_command, do_one_display): Update.
1847         * parser-defs.h (struct parser_state) <parser_state>: Add
1848         "tracker" parameter.
1849         (block_tracker): New member.
1850         (class innermost_block_tracker) <innermost_block_tracker>: Add
1851         "types" parameter.
1852         <reset>: Remove method.
1853         (innermost_block): Don't declare.
1854         (null_post_parser): Update.
1855         * parse.c (innermost_block): Remove global.
1856         (write_dollar_variable): Update.
1857         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1858         Remove "tracker_types" parameter.
1859         (parse_expression): Add "tracker" parameter.
1860         (parse_expression_for_completion): Update.
1861         (null_post_parser): Add "tracker" parameter.
1862         * p-exp.y: Update rules.
1863         * m2-exp.y: Update rules.
1864         * language.h (struct language_defn) <la_post_parser>: Add
1865         "tracker" parameter.
1866         * go-exp.y: Update rules.
1867         * f-exp.y: Update rules.
1868         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1869         parameter.
1870         * d-exp.y: Update rules.
1871         * c-exp.y: Update rules.
1872         * breakpoint.c (set_breakpoint_condition): Create an
1873         innermost_block_tracker.
1874         (watch_command_1): Likewise.
1875         * ada-lang.c (resolve): Add "tracker" parameter.
1876         (resolve_subexp): Likewise.
1877         * ada-exp.y (write_var_from_sym): Update.
1878
1879 2019-04-04  Tom Tromey  <tom@tromey.com>
1880
1881         * type-stack.h: New file.
1882         * type-stack.c: New file.
1883         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1884         type-stack.h.
1885         (insert_into_type_stack, insert_type, push_type, push_type_int)
1886         (insert_type_address_space, pop_type, pop_type_int)
1887         (pop_typelist, pop_type_stack, append_type_stack)
1888         (push_type_stack, get_type_stack, push_typelist)
1889         (follow_type_instance_flags, follow_types): Don't declare.
1890         * parse.c (type_stack): Remove global.
1891         (parse_exp_in_context): Update.
1892         (insert_into_type_stack, insert_type, push_type, push_type_int)
1893         (insert_type_address_space, pop_type, pop_type_int)
1894         (pop_typelist, pop_type_stack, append_type_stack)
1895         (push_type_stack, get_type_stack, push_typelist)
1896         (follow_type_instance_flags, follow_types): Remove (moved to
1897         type-stack.c).
1898         * f-exp.y (type_stack): New global.
1899         Update rules.
1900         (push_kind_type, f_parse): Update.
1901         * d-exp.y (type_stack): New global.
1902         Update rules.
1903         (d_parse): Update.
1904         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1905         Update rules.
1906         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1907         (HFILES_NO_SRCDIR): Add type-stack.h.
1908
1909 2019-04-04  Tom Tromey  <tom@tromey.com>
1910
1911         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1912         (rust_parser::convert_ast_to_expression, rust_parse)
1913         (rust_lex_test_completion, rust_lex_tests): Update.
1914         * parser-defs.h (struct expr_completion_state): New.
1915         (struct parser_state) <parser_state>: Add completion parameter.
1916         <mark_struct_expression, mark_completion_tag>: New methods.
1917         <parse_completion, m_completion_state>: New members.
1918         (prefixify_expression, null_post_parser): Update.
1919         (mark_struct_expression, mark_completion_tag): Don't declare.
1920         * parse.c (parse_completion, expout_last_struct)
1921         (expout_tag_completion_type, expout_completion_name): Remove
1922         globals.
1923         (parser_state::mark_struct_expression)
1924         (parser_state::mark_completion_tag): Now methods.
1925         (prefixify_expression): Add last_struct parameter.
1926         (prefixify_subexp): Likewise.
1927         (parse_exp_1): Update.
1928         (parse_exp_in_context): Add cstate parameter.  Update.
1929         (parse_expression_for_completion): Create an
1930         expr_completion_state.
1931         (null_post_parser): Add "completion" parameter.
1932         * p-exp.y: Update rules.
1933         (yylex): Update.
1934         * language.h (struct language_defn) <la_post_parser>: Add
1935         "completing" parameter.
1936         * go-exp.y: Update rules.
1937         (lex_one_token): Update.
1938         * expression.h (parse_completion): Don't declare.
1939         * d-exp.y: Update rules.
1940         (lex_one_token): Update rules.
1941         * c-exp.y: Update rules.
1942         (lex_one_token): Update.
1943         * ada-lang.c (resolve): Add "parse_completion" parameter.
1944         (resolve_subexp): Likewise.
1945         (ada_resolve_function): Likewise.
1946
1947 2019-04-04  Tom Tromey  <tom@tromey.com>
1948
1949         * parser-defs.h (struct parser_state) <start_arglist,
1950         end_arglist>: New methods.
1951         <arglist_len, m_funcall_chain>: New members.
1952         (arglist_len, start_arglist, end_arglist): Don't declare.
1953         * parse.c (arglist_len, funcall_chain): Remove global.
1954         (start_arglist, end_arglist): Remove functions.
1955         (parse_exp_in_context): Update.
1956         * p-exp.y: Update rules.
1957         * m2-exp.y: Update rules.
1958         * go-exp.y: Update rules.
1959         * f-exp.y: Update rules.
1960         * d-exp.y: Update rules.
1961         * c-exp.y: Update rules.
1962
1963 2019-04-04  Tom Tromey  <tom@tromey.com>
1964
1965         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1966         lex_operator, push_back>: New methods.
1967         Update all rules.
1968         (rust_parser::lex_hex, lex_escape): Rename and update.
1969         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1970         (rust_parser::lex_operator): Rename and update.
1971         (rust_parser::lex_number, rustyylex, rustyyerror)
1972         (rust_lex_test_init, rust_lex_test_sequence)
1973         (rust_lex_test_push_back, rust_lex_tests): Update.
1974         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1975         parameter.
1976         <lexptr, prev_lexptr>: New members.
1977         (lexptr, prev_lexptr): Don't declare.
1978         * parse.c (lexptr, prev_lexptr): Remove globals.
1979         (parse_exp_in_context): Update.
1980         * p-exp.y (yylex, yyerror): Update.
1981         * m2-exp.y (parse_number, yylex, yyerror): Update.
1982         * go-exp.y (lex_one_token, yyerror): Update.
1983         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1984         * d-exp.y (lex_one_token, yyerror): Update.
1985         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1986         (lex_one_token, yyerror): Update.
1987         * ada-lex.l (YY_INPUT): Update.
1988         (rewind_to_char): Update.
1989         * ada-exp.y (yyerror): Update.
1990
1991 2019-04-04  Tom Tromey  <tom@tromey.com>
1992
1993         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1994         * parser-defs.h (struct parser_state) <parser_state>: Add new
1995         parameter.
1996         <comma_terminates>: New member.
1997         (comma_terminates): Don't declare global.
1998         * parse.c (comma_terminates): Remove global.
1999         (parse_exp_in_context): Update.
2000         * p-exp.y (yylex): Update.
2001         * m2-exp.y (yylex): Update.
2002         * go-exp.y (lex_one_token): Update.
2003         * f-exp.y (yylex): Update.
2004         * d-exp.y (lex_one_token): Update.
2005         * c-exp.y (lex_one_token): Update.
2006         * ada-lex.l: Update.
2007
2008 2019-04-04  Tom Tromey  <tom@tromey.com>
2009
2010         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2011         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2012         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2013         * parser-defs.h (paren_depth): Don't declare.
2014         * parse.c (paren_depth): Remove global.
2015         (parse_exp_in_context): Update.
2016         * p-exp.y (paren_depth): New global.
2017         (pascal_parse): Initialize it.
2018         * m2-exp.y (paren_depth): New global.
2019         (m2_parse): Initialize it.
2020         * go-exp.y (paren_depth): New global.
2021         (go_parse): Initialize it.
2022         * f-exp.y (paren_depth): New global.
2023         (f_parse): Initialize it.
2024         * d-exp.y (paren_depth): New global.
2025         (d_parse): Initialize it.
2026         * c-exp.y (paren_depth): New global.
2027         (c_parse): Initialize it.
2028         * ada-lex.l (paren_depth): New global.
2029         (lexer_init): Initialize it.
2030
2031 2019-04-04  Tom Tromey  <tom@tromey.com>
2032
2033         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2034         (rust_parser::convert_ast_to_type)
2035         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2036         * parser-defs.h (struct parser_state) <parser_state>: Add
2037         parameters.  Initialize new members.
2038         <expression_context_block, expression_context_pc>: New members.
2039         * parse.c (expression_context_block, expression_context_pc):
2040         Remove globals.
2041         (parse_exp_in_context): Update.
2042         * p-exp.y: Update all rules.
2043         (yylex): Update.
2044         * m2-exp.y: Update all rules.
2045         (yylex): Update.
2046         * go-exp.y (yylex): Update.
2047         * f-exp.y (yylex): Update.
2048         * d-exp.y: Update all rules.
2049         (yylex): Update.
2050         * c-exp.y: Update all rules.
2051         (lex_one_token, classify_name, yylex, c_parse): Update.
2052         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2053
2054 2019-04-04  Tom Tromey  <tom@tromey.com>
2055
2056         * gdbarch.h, gdbarch.c: Rebuild.
2057         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2058         * stap-probe.h:
2059         (struct stap_parse_info): Replace "parser_state" with
2060         "expr_builder".
2061         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2062         (parser_state): New class.
2063         * parse.c (expr_builder): Rename.
2064         (expr_builder::release): Rename.
2065         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2066         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2067         (write_exp_elt_longcst, write_exp_elt_floatcst)
2068         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2069         (write_exp_string_vector, write_exp_bitstring)
2070         (write_exp_msymbol, mark_struct_expression)
2071         (write_dollar_variable)
2072         (insert_type_address_space, increase_expout_size): Replace
2073         "parser_state" with "expr_builder".
2074         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2075         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2076         "parser_state" with "expr_builder".
2077
2078 2019-04-04  Tom Tromey  <tom@tromey.com>
2079
2080         * rust-exp.y: Replace "parse_language" with method call.
2081         * p-exp.y:
2082         (yylex): Replace "parse_language" with method call.
2083         * m2-exp.y:
2084         (yylex): Replace "parse_language" with method call.
2085         * go-exp.y (classify_name): Replace "parse_language" with method
2086         call.
2087         * f-exp.y (yylex): Replace "parse_language" with method call.
2088         * d-exp.y (lex_one_token): Replace "parse_language" with method
2089         call.
2090         * c-exp.y:
2091         (lex_one_token, classify_name, yylex): Replace "parse_language"
2092         with method call.
2093         * ada-exp.y (find_primitive_type, type_char)
2094         (type_system_address): Replace "parse_language" with method call.
2095
2096 2019-04-04  Tom Tromey  <tom@tromey.com>
2097
2098         * rust-exp.y: Replace "parse_gdbarch" with method call.
2099         * parse.c (write_dollar_variable, insert_type_address_space):
2100         Replace "parse_gdbarch" with method call.
2101         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2102         call.
2103         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2104         call.
2105         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2106         "parse_gdbarch" with method call.
2107         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2108         with method call.
2109         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2110         "parse_gdbarch" with method call.
2111         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2112         "parse_gdbarch" with method call.
2113         * c-exp.y (parse_type, parse_number, classify_name): Replace
2114         "parse_gdbarch" with method call.
2115         * ada-lex.l: Replace "parse_gdbarch" with method call.
2116         * ada-exp.y (parse_type, find_primitive_type, type_char)
2117         (type_system_address): Replace "parse_gdbarch" with method call.
2118
2119 2019-04-04  Tom Tromey  <tom@tromey.com>
2120
2121         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2122         * stap-probe.c (stap_parse_argument): Update.
2123         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2124         initial_size parameter.
2125         * rust-exp.y (rust_lex_tests): Update.
2126         * parse.c (parser_state): Update.
2127         (parse_exp_in_context): Update.
2128         * parser-defs.h (struct parser_state) <parser_state>: Remove
2129         "initial_size" parameter.
2130
2131 2019-04-04  Tom Tromey  <tom@tromey.com>
2132
2133         * parser-defs.h (increase_expout_size): Don't declare.
2134         * parse.c (increase_expout_size): Now static.
2135
2136 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2137
2138         * gnu-nat.c (gnu_nat_target::wait): Fix
2139         target_waitstatus_to_string call.
2140
2141 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * eval.c (evaluate_subexp_standard): Handle internal functions
2144         during Fortran function call handling.
2145
2146 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * NEWS: Mention new internal functions.
2149         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2150         (read_base_type): Use dwarf2_init_complex_target_type.
2151         * value.c (creal_internal_fn): New function.
2152         (cimag_internal_fn): New function.
2153         (_initialize_values): Register new internal functions.
2154
2155 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2156
2157         * infrun.c (stop_all_threads): If debug_infrun, always
2158         trace the wait status after wait_one, using
2159         target_waitstatus_to_string and target_pid_to_str.
2160         (handle_inferior_event): Replace various trace of
2161         wait status kind by a single trace.
2162         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2163         wait status kind image by target_waitstatus_to_string.
2164         * target/waitstatus.c (target_waitstatus_to_string): Fix
2165         obsolete comment.
2166
2167 2019-04-01  Tom Tromey  <tromey@adacore.com>
2168
2169         PR symtab/23331:
2170         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2171
2172 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2173             Pedro Alves  <palves@redhat.com>
2174
2175         * top.c (quit_force): Call 'finalize_values'.
2176         * value.c (finalize_values): New function.
2177         * value.h (finalize_values): Declare.
2178
2179 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2180
2181         * NEWS: Announce $_gdb_major and $_gdb_minor.
2182
2183         * top.c (init_gdb_version_vars): New function.
2184         (gdb_init): Call init_gdb_version_vars.
2185
2186 2019-03-29  Tom Tromey  <tromey@adacore.com>
2187
2188         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2189         help text.  Remove dead code.
2190
2191 2019-03-29  Keith Seitz  <keiths@redhat.com>
2192
2193         From Siddhesh Poyarekar:
2194         * f-lang.h (f77_get_upperbound): Return LONGEST.
2195         (f77_get_lowerbound): Likewise.
2196         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2197         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2198         print them.
2199         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2200         plongest to format print it.
2201         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2202         (f77_get_upperbound): Likewise.
2203         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2204         LOWER_BOUND to LONGEST.
2205         (f77_create_arrayprint_offset_tbl): Likewise.
2206
2207 2019-03-29  Keith Seitz  <keiths@redhat.com>
2208
2209         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2210         %s/pulongest for TYPE_LENGTH instead of %d in format
2211         strings.
2212         * ada-typerint.c (ada_print_type): Likewise.
2213         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2214         * compile/compile-c-support.c (generate_register_struct): Likewise.
2215         * gdbtypes.c (recursive_dump_type): Likewise.
2216         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2217         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2218         instead of %d in format strings.
2219         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2220         to std::min to ULONGEST.
2221         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2222         instead of %d in format strings.
2223         * tracepoint.c (info_scope_command): Likewise.
2224         * typeprint.c (print_offset_data::update)
2225         (print_offset_data::finish): Likewise.
2226         * xtensa-tdep.c (xtensa_store_return_value)
2227         (xtensa_push_dummy_call): Likewise.
2228
2229 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2230
2231         * windows-nat.c (display_selector): Fixed format specifications
2232         for 64-bit Cygwin.
2233
2234 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2235
2236         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2237
2238 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2239
2240         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2241         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2242         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2243         (nios2_linux_init_abi): Install it.
2244
2245 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2246
2247         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2248
2249 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2250
2251         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2252
2253 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2254             Tom Tromey  <tromey@adacore.com>
2255
2256         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2257
2258 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2259
2260         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2261         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2262         method to compute the bounds of range types. Also print "[evaluated]"
2263         if the bounds' values come from a dynamic evaluation.
2264
2265 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2266
2267         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2268         whitespace when pretty printing is on.
2269
2270 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2271
2272         * ppc-linux-nat.c: Add include.
2273
2274 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2275
2276         * NEWS: Mention AArch64 Pointer Authentication.
2277
2278 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2279
2280         * arm-linux-nat.c: Add include.
2281
2282 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2283
2284         * source-cache.c (source_cache::get_source_lines): Re-read
2285         fullname after calling open_source_file.
2286
2287 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2288
2289         * NEWS: Mention TLS support for FreeBSD.
2290
2291 2019-03-25  Tom Tromey  <tromey@adacore.com>
2292
2293         * minsyms.c (BUNCH_SIZE): Update comment.
2294         (~minimal_symbol_reader): Remove old comment.
2295         (compact_minimal_symbols): Update comment.
2296         (minimal_symbol_reader::install): Remove old comment.  Update
2297         other comments.
2298
2299 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2300
2301         * s390-linux-nat.c: Add include.
2302
2303 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2304
2305         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2306         Call linux_get_hwcap.
2307         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2308         Likewise.
2309         (aarch64_linux_get_hwcap): Remove function.
2310         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2311         declaration.
2312         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2313         linux_get_hwcap.
2314         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2315         * linux-tdep.c (linux_get_hwcap): Add function.
2316         (linux_get_hwcap2): Likewise.
2317         * linux-tdep.h (linux_get_hwcap): Add declaration.
2318         (linux_get_hwcap2): Likewise.
2319         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2320         (ppc_linux_get_hwcap2): Likewise.
2321         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2322         linux_get_hwcap.
2323         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2324         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2325         (ppc_linux_nat_target::read_description): Likewise.
2326         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2327         * s390-linux-nat.c: Likewise.
2328         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2329
2330 2019-03-24  Tom Tromey  <tom@tromey.com>
2331
2332         * ada-lang.c (standard_lookup): Simplify initialization.
2333         (ada_lookup_symbol_nonlocal): Simplify return.
2334         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2335         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2336         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2337         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2338         initialization.
2339         * solib.c (solib_global_lookup): Simplify.
2340         * symtab.c (null_block_symbol): Remove.
2341         (symbol_cache_lookup): Simplify returns.
2342         (lookup_language_this): Simplify returns.
2343         (lookup_symbol_aux): Simplify return.
2344         (lookup_local_symbol): Simplify returns.
2345         (lookup_global_symbol_from_objfile): Simplify return.
2346         (lookup_symbol_in_objfile_symtabs)
2347         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2348         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2349         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2350         * cp-namespace.c (cp_lookup_bare_symbol)
2351         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2352         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2353         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2354         (cp_lookup_symbol_via_imports): Simplify initialization.
2355         (find_symbol_in_baseclass): Likewise.
2356         * symtab.h (null_block_symbol): Remove.
2357         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2358         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2359         (d_lookup_symbol_module): Likewise.
2360         (find_symbol_in_baseclass): Simplify initialization.
2361
2362 2019-03-24  Tom Tromey  <tom@tromey.com>
2363
2364         * expression.h: Don't include symtab.h.
2365         (struct block): Forward declare.
2366
2367 2019-03-24  Tom Tromey  <tom@tromey.com>
2368
2369         * c-exp.y (typebase): Remove casts.
2370         * gdbtypes.c (lookup_unsigned_typename, )
2371         (lookup_signed_typename): Remove cast.
2372         * eval.c (parse_to_comma_and_eval): Remove cast.
2373         * parse.c (write_dollar_variable): Remove cast.
2374         * block.h (struct block) <superblock>: Now const.
2375         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2376         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2377         (map_block): Make "block" const.
2378         * symfile.h (struct quick_symbol_functions)
2379         <map_matching_symbols>: Constify block argument to "callback".
2380         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2381         const.
2382         (find_pc_sect_compunit_symtab): Make "b" const.
2383         (find_symbol_at_address): Likewise.
2384         (search_symbols): Likewise.
2385         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2386         (dw2_debug_names_lookup_symbol): Likewise.
2387         (dw2_map_matching_symbols): Update.
2388         * p-valprint.c (pascal_val_print): Remove "block".
2389         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2390         (aux_add_nonlocal_symbols): Make "block" const.
2391         (resolve_subexp): Remove cast.
2392         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2393         const.
2394         (iterate_over_file_blocks): Likewise.
2395         * f-exp.y (%union) <bval>: Remove.
2396         * coffread.c (patch_opaque_types): Make "b" const.
2397         * spu-tdep.c (spu_catch_start): Make "block" const.
2398         * c-valprint.c (print_unpacked_pointer): Remove "block".
2399         * symmisc.c (dump_symtab_1): Make "b" const.
2400         (block_depth): Make "block" const.
2401         * d-exp.y (%union) <bval>: Remove.
2402         * cp-support.h (cp_lookup_rtti_type): Update.
2403         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2404         * psymtab.c (psym_lookup_symbol): Make "block" const.
2405         (maintenance_check_psymtabs): Make "b" const.
2406         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2407         (enumerate_locals, enumerate_args): Update.
2408         * python/py-symtab.c (stpy_global_block): Make "block" const.
2409         (stpy_static_block): Likewise.
2410         * inline-frame.c (block_starting_point_at): Make "new_block"
2411         const.
2412         * block.c (find_block_in_blockvector): Make return type const.
2413         (blockvector_for_pc_sect): Make "b" const.
2414         (find_block_in_blockvector): Make "b" const.
2415
2416 2019-03-23  Tom Tromey  <tom@tromey.com>
2417
2418         * varobj.c (varobj_create): Update.
2419         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2420         * printcmd.c (display_command, do_one_display): Don't reset
2421         innermost_block.
2422         * parser-defs.h (enum innermost_block_tracker_type): Move to
2423         expression.h.
2424         (innermost_block): Update comment.
2425         * parse.c (parse_exp_1): Add tracker_types parameter.
2426         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2427         tracker_types parameter.  Reset innermost_block.
2428         (parse_exp_in_context): Remove.
2429         (parse_expression_for_completion): Update.
2430         * objfiles.c (~objfile): Don't reset expression_context_block or
2431         innermost_block.
2432         * expression.h (enum innermost_block_tracker_type): Move from
2433         parser-defs.h.
2434         (parse_exp_1): Add tracker_types parameter.
2435         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2436         reset innermost_block.
2437
2438 2019-03-23  Tom Tromey  <tom@tromey.com>
2439
2440         * objfiles.h: Include bcache.h.
2441
2442 2019-03-23  Tom Tromey  <tom@tromey.com>
2443
2444         * linespec.c (get_current_search_block): Use
2445         scoped_restore_current_language.
2446         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2447
2448 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2449             Jiong Wang  <jiong.wang@arm.com>
2450
2451         * aarch64-linux-tdep.c
2452         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2453         section.
2454         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2455
2456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2457             Jiong Wang  <jiong.wang@arm.com>
2458
2459         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2460         instructions.
2461         (aarch64_analyze_prologue_test): Add PACIASP test.
2462         (aarch64_prologue_prev_register): Unmask PC value.
2463
2464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2465             Jiong Wang  <jiong.wang@arm.com>
2466
2467         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2468         (aarch64_dwarf2_prev_register): Unmask PC value.
2469         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2470         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2471         DW_CFA_AARCH64_negate_ra_state.
2472         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2473
2474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2475             Jiong Wang  <jiong.wang@arm.com>
2476
2477         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2478         registers.
2479         (aarch64_pseudo_register_name): Likewise.
2480         (aarch64_pseudo_register_type): Likewise.
2481         (aarch64_pseudo_register_reggroup_p): Likewise.
2482         (aarch64_gdbarch_init): Add pauth registers.
2483         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2484         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2485         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2486         (struct gdbarch_tdep): Add regnum for ra_state.
2487
2488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2489             Jiong Wang  <jiong.wang@arm.com>
2490
2491         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2492
2493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2494             Jiong Wang  <jiong.wang@arm.com>
2495
2496         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2497         function.
2498         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2499         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2500         (aarch64_gdbarch_init): Add puth registers.
2501         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2502         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2503         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2504
2505 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2506             Jiong Wang  <jiong.wang@arm.com>
2507
2508         * aarch64-linux-nat.c
2509         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2510         * aarch64-linux-tdep.c
2511         (aarch64_linux_core_read_description): Likewise.
2512         (aarch64_linux_get_hwcap): New function.
2513         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2514         (aarch64_linux_get_hwcap): New declaration.
2515
2516 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2517             Jiong Wang  <jiong.wang@arm.com>
2518
2519         * aarch64-linux-nat.c
2520         (aarch64_linux_nat_target::read_description): Add pauth param.
2521         * aarch64-linux-tdep.c
2522         (aarch64_linux_core_read_description): Likewise.
2523         * aarch64-tdep.c (struct target_desc): Add in pauth.
2524         (aarch64_read_description): Add pauth param.
2525         (aarch64_gdbarch_init): Likewise.
2526         * aarch64-tdep.h (aarch64_read_description): Likewise.
2527         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2528         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2529         * features/Makefile: Add new files.
2530         * features/aarch64-pauth.c: New file.
2531         * features/aarch64-pauth.xml: New file.
2532
2533 2019-03-20  Tom Tromey  <tromey@adacore.com>
2534
2535         * infrun.c (handle_inferior_event): Rename from
2536         handle_inferior_event_1.  Create a scoped_value_mark.
2537         (handle_inferior_event): Remove.
2538
2539 2019-03-19  Tom Tromey  <tromey@adacore.com>
2540
2541         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2542         * infrun.h (print_stop_event): Add "displays" parameter.
2543         * infrun.c (print_stop_event): Add "displays" parameter.
2544
2545 2019-03-19  Pedro Alves  <palves@redhat.com>
2546
2547         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2548         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2549         to -1.  Fix TABs vs spaces.
2550         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2551         * tui/tui-out.h (tui_ui_out) Add intro comments.
2552         <m_line, m_start_of_line>: In-class initialize, and add describing
2553         comment.
2554
2555 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2556
2557         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2558         variable names.
2559         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2560
2561 2019-03-18  Pedro Alves  <palves@redhat.com>
2562             Eli Zaretskii <eliz@gnu.org>
2563
2564         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2565         m_line and m_start_of_line.
2566
2567 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2568
2569         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2570         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2571         it returns a newline.  This fixes a regression in TU mode, whereby
2572         the next line is output on the same screen line as the user input.
2573
2574 2019-03-18  Tom Tromey  <tromey@adacore.com>
2575
2576         * minsyms.c (minimal_symbol_reader::install): Remove call to
2577         obstack_blank.
2578
2579 2019-03-18  Pedro Alves  <palves@redhat.com>
2580
2581         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2582         New globals.
2583         (apply_style): New, factored out from ...
2584         (apply_ansi_escape): ... this.  Handle reverse video mode.
2585         (tui_set_reverse_mode): New function.
2586         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2587         * tui/tui-winsource.c (tui_show_source_line): Use
2588         tui_set_reverse_mode instead of setting A_STANDOUT.
2589         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2590         New setter methods.
2591
2592 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2593
2594         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2595         Handle tabs.
2596
2597 2019-03-18  Tom Tromey  <tromey@adacore.com>
2598
2599         * ada-lang.c (empty_array): Add "high" parameter.
2600         (ada_evaluate_subexp): Update.
2601
2602 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2603
2604         * unittests/string_view-selftests.c: Define
2605         _initialize_string_view_selftests unconditionally.
2606
2607 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2608
2609         PR gdb/24350
2610         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2611
2612 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2613
2614         PR gdb/24351
2615         * windows-nat.c (display_selector): Fix format specifiers.
2616
2617 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2618
2619         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2620         tui_refill_source_window instead of tui_refresh_win, to update the
2621         current execution line.  This fixes redisplay of the current line
2622         when stepping through the code with "next" or "step".
2623
2624 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2625
2626         * source-cache.c (source_cache::get_source_lines): Call
2627         find_source_lines to initialize s->nlines.  This fixes vertical
2628         scrolling of TUI source window when the DOWN arrow is pressed.
2629
2630 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2631
2632         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2633         linux-thread-db.c (_initialize_thread_db): Likewise.
2634
2635 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2636
2637         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2638         wclrtoeol in tui_show_source_line".  This reverts changes made in
2639         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2640
2641 2019-03-15  Tom Tromey  <tom@tromey.com>
2642
2643         * symtab.h (struct minimal_symbol): Derive from
2644         general_symbol_info.
2645         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2646         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2647         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2648         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2649         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2650         (MSYMBOL_SEARCH_NAME): Update.
2651         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2652         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2653         * minsyms.c (minimal_symbol_reader::record_full): Update.
2654
2655 2019-03-15  Tom Tromey  <tom@tromey.com>
2656
2657         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2658
2659 2019-03-15  Tom Tromey  <tom@tromey.com>
2660
2661         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2662         unique_xmalloc_ptr.
2663         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2664         Update.
2665         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2666         (build_minimal_symbol_hash_tables)
2667         (minimal_symbol_reader::install): Update.
2668
2669 2019-03-15  Tom Tromey  <tom@tromey.com>
2670
2671         * symtab.c (create_demangled_names_hash): Update.
2672         (symbol_set_names): Update.
2673         * objfiles.h (struct objfile_per_bfd_storage)
2674         <demangled_names_hash>: Now an htab_up.
2675         * objfiles.c (objfile_per_bfd_storage): Simplify.
2676
2677 2019-03-15  Tom Tromey  <tom@tromey.com>
2678
2679         * objfiles.h (struct objfile_per_bfd_storage): Declare
2680         destructor.
2681         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2682         New.
2683         (get_objfile_bfd_data): Use new.  Don't initialize
2684         language_of_main.
2685         (free_objfile_per_bfd_storage): Remove.
2686         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2687
2688 2019-03-15  Tom Tromey  <tom@tromey.com>
2689
2690         * symfile.c (reread_symbols): Update.
2691         * objfiles.c (objfile::objfile): Update.
2692         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2693         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2694         comment.
2695         (minimal_symbol_reader::install): Update.
2696         (terminate_minimal_symbol_table): Remove.
2697         * jit.c (jit_object_close_impl): Update.
2698
2699 2019-03-15  Tom Tromey  <tom@tromey.com>
2700
2701         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2702         initializations.
2703
2704 2019-03-15  Tom Tromey  <tom@tromey.com>
2705
2706         * objfiles.h (struct objfile_per_bfd_storage)
2707         <demangled_hash_languages>: Now a bitset.
2708         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2709         (lookup_minimal_symbol): Update.
2710
2711 2019-03-15  Tom Tromey  <tom@tromey.com>
2712
2713         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2714         Don't return the symbol.
2715         * coffread.c (record_minimal_symbol): Use record_full.
2716
2717 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2718
2719         The MS-Windows port of ncurses fails to switch to a color pair if
2720         one or both of the colors are the implicit default colors.  This
2721         change records the default colors when TUI is initialized, and
2722         then specifies them explicitly when a color pair uses the default
2723         colors.  This allows color styling in TUI mode on MS-Windows.
2724
2725         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2726         ncurses_norm_attr.
2727         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2728         colors in ncurses_norm_attr.
2729         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2730         "none", replace it with the default color recorded in
2731         ncurses_norm_attr.
2732
2733 2019-03-14  Tom Tromey  <tromey@adacore.com>
2734
2735         * source-cache.h (class source_cache) <get_source_lines>: Return
2736         std::string.
2737         * source-cache.c (source_cache::extract_lines): Handle case where
2738         first_pos==npos.  Return std::string.
2739         (source_cache::get_source_lines): Update.
2740
2741 2019-03-14  Tom Tromey  <tromey@adacore.com>
2742
2743         * NEWS: Add item for "style sources" commands.
2744         * source-cache.c (source_cache::get_source_lines): Check
2745         source_styling.
2746         * cli/cli-style.c (source_styling): New global.
2747         (_initialize_cli_style): Add "style sources" commands.
2748         (show_style_sources): New function.
2749         * cli/cli-style.h (source_styling): Declare.
2750
2751 2019-03-14  Pedro Alves  <palves@redhat.com>
2752             Tom Tromey  <tromey@adacore.com>
2753
2754         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2755         * tui/tui-winsource.c (tui_refill_source_window): New function,
2756         from...
2757         (tui_horizontal_source_scroll): ... here.  Move some logic.
2758         * cli/cli-style.c (set_style_enabled): Notify new observable.
2759         * tui/tui-hooks.c (tui_redisplay_source): New function.
2760         (tui_attach_detach_observers): Attach or detach
2761         tui_redisplay_source.
2762         * observable.h (source_styling_changed): New observable.
2763         * observable.c: Define source_styling_changed observable.
2764
2765 2019-03-13  Tom Tromey  <tromey@adacore.com>
2766
2767         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2768         (i386_gnu_nat_target::store_registers): Update.
2769         * target-debug.h (target_debug_print_std_string): New macro.
2770         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2771         * windows-tdep.c (display_one_tib): Update.
2772         * tui/tui-stack.c (tui_make_status_line): Update.
2773         * top.c (print_inferior_quit_action): Update.
2774         * thread.c (thr_try_catch_cmd): Update.
2775         (add_thread_with_info): Update.
2776         (thread_target_id_str): Update.
2777         (thr_try_catch_cmd): Update.
2778         (thread_command): Update.
2779         (thread_find_command): Update.
2780         * record-btrace.c (record_btrace_target::info_record)
2781         (record_btrace_resume_thread, record_btrace_target::resume)
2782         (record_btrace_cancel_resume, record_btrace_step_thread)
2783         (record_btrace_target::wait, record_btrace_target::wait)
2784         (record_btrace_target::wait, record_btrace_target::stop): Update.
2785         * progspace.c (print_program_space): Update.
2786         * process-stratum-target.c
2787         (process_stratum_target::thread_address_space): Update.
2788         * linux-fork.c (linux_fork_mourn_inferior)
2789         (detach_checkpoint_command, info_checkpoints_command)
2790         (linux_fork_context): Update.
2791         (linux_fork_detach): Update.
2792         (class scoped_switch_fork_info): Update.
2793         (delete_checkpoint_command): Update.
2794         * infrun.c (follow_fork_inferior): Update.
2795         (follow_fork_inferior): Update.
2796         (proceed_after_vfork_done): Update.
2797         (handle_vfork_child_exec_or_exit): Update.
2798         (follow_exec): Update.
2799         (displaced_step_prepare_throw): Update.
2800         (displaced_step_restore): Update.
2801         (start_step_over): Update.
2802         (resume_1): Update.
2803         (clear_proceed_status_thread): Update.
2804         (proceed): Update.
2805         (print_target_wait_results): Update.
2806         (do_target_wait): Update.
2807         (context_switch): Update.
2808         (stop_all_threads): Update.
2809         (restart_threads): Update.
2810         (finish_step_over): Update.
2811         (handle_signal_stop): Update.
2812         (switch_back_to_stepped_thread): Update.
2813         (keep_going_pass_signal): Update.
2814         (print_exited_reason): Update.
2815         (normal_stop): Update.
2816         * inferior.c (inferior_pid_to_str): Change return type.
2817         (print_selected_inferior): Update.
2818         (add_inferior): Update.
2819         (detach_inferior): Update.
2820         * dummy-frame.c (fprint_dummy_frames): Update.
2821         * dcache.c (dcache_info_1): Update.
2822         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2823         (btrace_fetch, btrace_clear): Update.
2824         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2825         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2826         type.
2827         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2828         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2829         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2830         * gdbarch.c, gdbarch.h: Rebuild.
2831         * gdbarch.sh (core_pid_to_str): Change return type.
2832         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2833         return type.
2834         (windows_nat_target::pid_to_str): Change return type.
2835         (windows_delete_thread): Update.
2836         (windows_nat_target::attach): Update.
2837         (windows_nat_target::files_info): Update.
2838         * target-delegates.c: Rebuild.
2839         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2840         return type.
2841         (sol_thread_target::pid_to_str): Change return type.
2842         * remote.c (class remote_target) <pid_to_str>: Change return
2843         type.
2844         (remote_target::pid_to_str): Change return type.
2845         (extended_remote_target::attach, remote_target::remote_stop_ns)
2846         (remote_target::remote_notif_remove_queued_reply)
2847         (remote_target::push_stop_reply, remote_target::disable_btrace):
2848         Update.
2849         (extended_remote_target::attach): Update.
2850         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2851         type.
2852         (gdbsim_target::pid_to_str): Change return type.
2853         * ravenscar-thread.c (struct ravenscar_thread_target)
2854         <pid_to_str>: Change return type.
2855         (ravenscar_thread_target::pid_to_str): Change return type.
2856         * procfs.c (class procfs_target) <pid_to_str>: Change return
2857         type.
2858         (procfs_target::pid_to_str): Change return type.
2859         (procfs_target::attach): Update.
2860         (procfs_target::detach): Update.
2861         (procfs_target::fetch_registers): Update.
2862         (procfs_target::store_registers): Update.
2863         (procfs_target::wait): Update.
2864         (procfs_target::files_info): Update.
2865         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2866         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2867         return type.
2868         (nto_procfs_target::pid_to_str): Change return type.
2869         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2870         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2871         return type.
2872         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2873         (exit_lwp): Update.
2874         (attach_proc_task_lwp_callback, get_detach_signal)
2875         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2876         (linux_nat_target::resume, wait_lwp, stop_callback)
2877         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2878         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2879         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2880         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2881         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2882         type.
2883         (inf_ptrace_target::attach): Update.
2884         (inf_ptrace_target::files_info): Update.
2885         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2886         type.
2887         (go32_nat_target::pid_to_str): Change return type.
2888         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2889         (gnu_nat_target::wait): Update.
2890         (gnu_nat_target::wait): Update.
2891         (gnu_nat_target::resume): Update.
2892         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2893         (fbsd_nat_target::wait): Update.
2894         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2895         type.
2896         (darwin_nat_target::attach): Update.
2897         * corelow.c (class core_target) <pid_to_str>: Change return type.
2898         (core_target::pid_to_str): Change return type.
2899         * target.c (normal_pid_to_str): Change return type.
2900         (default_pid_to_str): Likewise.
2901         (target_pid_to_str): Change return type.
2902         (target_translate_tls_address): Update.
2903         (target_announce_detach): Update.
2904         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2905         return type.
2906         (bsd_uthread_target::pid_to_str): Change return type.
2907         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2908         type.
2909         (bsd_kvm_target::pid_to_str): Change return type.
2910         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2911         return type.
2912         (aix_thread_target::pid_to_str): Change return type.
2913         * target.h (struct target_ops) <pid_to_str>: Change return type.
2914         (target_pid_to_str, normal_pid_to_str): Likewise.
2915         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2916         type.
2917         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2918         type.
2919         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2920         return type.
2921         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2922         type.
2923         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2924         type.
2925         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2926         return type.
2927
2928 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2929
2930         * NEWS: Mention that the new default MI version is 3.  Mention
2931         changes to the output of commands and events that deal with
2932         multi-location breakpoints.
2933         * breakpoint.c: Include "mi/mi-out.h".
2934         (print_one_breakpoint): Change output syntax if using MI version
2935         >= 3.
2936         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2937         New.
2938         (mi_multi_location_breakpoint_output_fixed): New.
2939         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2940         (mi_cmd_fix_multi_location_breakpoint_output): New.
2941         (mi_multi_location_breakpoint_output_fixed): New.
2942         * mi/mi-cmds.c (mi_cmds): Register command
2943         -fix-multi-location-breakpoint-output.
2944         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2945         interpreter "mi".
2946
2947 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2948
2949         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2950         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2951         instantiate mi_ui_out based on interpreter name.
2952         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2953         * mi/mi-main.c (mi_load_progress): Likewise.
2954
2955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2956
2957         * NEWS: Combine separate "New targets" sections for 8.3.
2958
2959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2960
2961         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2962         (ppcfbsd_init_abi): Install gdbarch
2963         "fetch_tls_load_module_address" and "get_thread_local_address"
2964         methods.
2965
2966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2967
2968         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2969         (riscv_fbsd_init_abi): Install gdbarch
2970         "fetch_tls_load_module_address" and "get_thread_local_address"
2971         methods.
2972
2973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2974
2975         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2976         (i386fbsd_init_abi): Install gdbarch
2977         "fetch_tls_load_module_address" and "get_thread_local_address"
2978         methods.
2979
2980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2981
2982         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2983         (amd64fbsd_init_abi): Install gdbarch
2984         "fetch_tls_load_module_address" and "get_thread_local_address"
2985         methods.
2986
2987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2988
2989         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2990         (struct fbsd_pspace_data): New type.
2991         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2992         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2993         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2994         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2995         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2996
2997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2998
2999         * gdbtypes.c (lookup_struct_elt): New function.
3000         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3001         * gdbtypes.h (struct struct_elt): New type.
3002         (lookup_struct_elt): New prototype.
3003
3004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3005
3006         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3007         remove disabled code block.
3008
3009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3010
3011         * gdbarch.sh (get_thread_local_address): New method.
3012         * gdbarch.h, gdbarch.c: Regenerate.
3013         * target.c (target_translate_tls_address): Use
3014         gdbarch_get_thread_local_address if present instead of
3015         target::get_thread_local_address.
3016
3017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3018
3019         * target.h (target::get_thread_local_address): Update comment.
3020
3021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3022
3023         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3024         objfile->separate_debug_objfile_backlink if not NULL.
3025
3026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3027
3028         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3029         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3030         (amd64bsd_store_inferior_registers): Likewise.
3031         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3032         Enable segment base registers.
3033         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3034         PT_GETFSBASE and PT_GETGSBASE.
3035         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3036         PT_SETGSBASE.
3037         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3038         segment base registers.
3039         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3040
3041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3042
3043         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3044         Update calls to i386_target_description to add 'segments'
3045         parameter.
3046         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3047         add segment base registers.
3048         * arch/i386.c (i386_create_target_description): Add 'segments'
3049         parameter to enable segment base registers.
3050         * arch/i386.h (i386_create_target_description): Likewise.
3051         * features/i386/32bit-segments.xml: New file.
3052         * features/i386/32bit-segments.c: Generate.
3053         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3054         call to i386_target_description to add 'segments' parameter.
3055         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3056         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3057         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3058         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3059         if feature is present.
3060         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3061         Add 'segments' parameter to call to i386_target_description.
3062         (i386_target_description): Add 'segments' parameter to enable
3063         segment base registers.
3064         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3065         to call to i386_target_description.
3066         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3067         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3068         Define I386_NUM_REGS.
3069         (i386_target_description): Add 'segments' parameter to enable
3070         segment base registers.
3071
3072 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3073
3074         PR/24325
3075         * source-cache.c: #undef open and close, to avoid unresolved
3076         externals during linking.
3077
3078 2019-03-12  Tom Tromey  <tromey@adacore.com>
3079
3080         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3081         const.  Add initializers.
3082         (_initialize_remote): Don't initialize ptid globals.
3083
3084 2019-03-12  Pedro Alves  <palves@redhat.com>
3085
3086         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3087
3088 2019-03-12  Pedro Alves  <palves@redhat.com>
3089
3090         * cp-name-parser.y (main): Remove unused 'len' variable.
3091
3092 2019-03-12  Tom Tromey  <tromey@adacore.com>
3093
3094         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3095         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3096
3097 2019-03-12  Tom Tromey  <tromey@adacore.com>
3098
3099         * linux-nat.c (iterate_over_lwps): Update.
3100         (stop_callback): Remove parameter.
3101         (stop_wait_callback, detach_callback, resume_set_callback)
3102         (select_singlestep_lwp_callback, set_ignore_sigint)
3103         (status_callback, resumed_callback, resume_clear_callback)
3104         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3105         data parameter.
3106         (linux_nat_target::detach, linux_nat_target::resume)
3107         (linux_stop_and_wait_all_lwps, select_event_lwp)
3108         (linux_nat_filter_event, linux_nat_wait_1)
3109         (linux_nat_target::kill, linux_nat_target::stop)
3110         (linux_nat_target::stop): Update.
3111         (linux_nat_resume_callback): Change type.
3112         (resume_stopped_resumed_lwps, count_events_callback)
3113         (select_event_lwp_callback): Likewise.
3114         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3115         * arm-linux-nat.c (struct update_registers_data): Remove.
3116         (update_registers_callback): Change type.
3117         (arm_linux_insert_hw_breakpoint1): Update.
3118         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3119         parameter.
3120         (x86_linux_dr_set_addr): Update.
3121         (x86_linux_dr_set_control): Update.
3122         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3123         (iterate_over_lwps): Use gdb::function_view.
3124         * nat/aarch64-linux-hw-point.c (struct
3125         aarch64_dr_update_callback_param): Remove.
3126         (debug_reg_change_callback): Change type.
3127         (aarch64_notify_debug_reg_change): Update.
3128         * s390-linux-nat.c (s390_refresh_per_info): Update.
3129
3130 2019-03-11  Tom Tromey  <tromey@adacore.com>
3131
3132         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3133         redundant assignment to "this_cu".
3134
3135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3136
3137         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3138
3139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3140
3141         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3142         from...
3143         (rank_one_type): ... this.
3144
3145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3146
3147         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3148         from...
3149         (rank_one_type): ... this.
3150
3151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3152
3153         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3154         from...
3155         (rank_one_type): ... this.
3156
3157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3158
3159         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3160         from...
3161         (rank_one_type): ... this.
3162
3163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3164
3165         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3166         from...
3167         (rank_one_type): ... this.
3168
3169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3170
3171         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3172         from...
3173         (rank_one_type): ... this.
3174
3175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3176
3177         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3178         from...
3179         (rank_one_type): ... this.
3180
3181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3182
3183         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3184         from...
3185         (rank_one_type): ... this.
3186
3187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3188
3189         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3190         from...
3191         (rank_one_type): ... this.
3192
3193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3194
3195         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3196         from...
3197         (rank_one_type): ... this.
3198
3199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3200
3201         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3202         from...
3203         (rank_one_type): ... this.
3204
3205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3206
3207         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3208         from...
3209         (rank_one_type): ... this.
3210
3211 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3212
3213         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3214         inferior-events' shows the example events.
3215
3216 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3217
3218         Support styling on native MS-Windows console
3219
3220         PR/24315
3221         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3222         on MS-Windows if $TERM is not defined.
3223
3224         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3225
3226         * posix-hdep.c (gdb_console_fputs):
3227         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3228         functions.
3229         * ui-file.h (gdb_console_fputs): Add prototype.
3230
3231         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3232         back to fputs only if the former returns zero.
3233
3234 2019-03-07  Tom Tromey  <tom@tromey.com>
3235
3236         * symmisc.c (print_symbol_bcache_statistics): Update.
3237         (print_objfile_statistics): Update.
3238         * symfile.c (allocate_symtab): Update.
3239         * stabsread.c: Don't include bcache.h.
3240         * psymtab.h (struct psymbol_bcache): Don't declare.
3241         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3242         (psymbol_bcache_init, psymbol_bcache_free)
3243         (psymbol_bcache_get_bcache): Don't declare.
3244         * psymtab.c (struct psymbol_bcache): Remove.
3245         (psymtab_storage::psymtab_storage): Update.
3246         (psymtab_storage::~psymtab_storage): Update.
3247         (psymbol_bcache_init, psymbol_bcache_free)
3248         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3249         (add_psymbol_to_bcache): Update.
3250         (allocate_psymtab): Update.
3251         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3252         macro_cache>: No longer pointers.
3253         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3254         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3255         * macrotab.c (macro_bcache): Update.
3256         * macroexp.c: Don't include bcache.h.
3257         * gdbtypes.c (check_types_worklist): Update.
3258         (types_deeply_equal): Remove TRY/CATCH.  Update.
3259         * elfread.c (elf_symtab_read): Update.
3260         * dwarf2read.c: Don't include bcache.h.
3261         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3262         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3263         (print_bcache_statistics, bcache_memory_used): Don't declare.
3264         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3265         methods.  Rename all data members.
3266         * bcache.c (struct bcache): Move to bcache.h.
3267         (bcache::expand_hash_table): Rename from expand_hash_table.
3268         (bcache): Remove.
3269         (bcache::insert): Rename from bcache_full.
3270         (bcache::compare): Rename from bcache_compare.
3271         (bcache_xmalloc): Remove.
3272         (bcache::~bcache): Rename from bcache_xfree.
3273         (bcache::print_statistics): Rename from print_bcache_statistics.
3274         (bcache::memory_used): Rename from bcache_memory_used.
3275
3276 2019-03-07  Pedro Alves  <palves@redhat.com>
3277
3278         * infrun.c (normal_stop): Also check for
3279         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3280
3281 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * f-lang.c (value_from_host_double): Moved to...
3284         * value.c (value_from_host_double): ...here.
3285         * value.h (value_from_host_double): Declare.
3286         * guile/scm-math.c (vlscm_convert_typed_number): Use
3287         value_from_host_double.
3288         (vlscm_convert_number): Likewise.
3289         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3290         * python/py-value.c (convert_value_from_python): Likewise.
3291
3292 2019-03-06  Tom Tromey  <tom@tromey.com>
3293
3294         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3295
3296 2019-03-06  Tom Tromey  <tom@tromey.com>
3297
3298         * utils.h (free_current_contents): Don't declare.
3299         * utils.c (free_current_contents): Remove.
3300
3301 2019-03-06  Tom Tromey  <tom@tromey.com>
3302
3303         * top.c (quit_force): Update.
3304         * main.c (captured_command_loop): Update.
3305         * common/new-op.c (operator new): Update.
3306         * common/common-exceptions.c (struct catcher)
3307         <save_cleanup_chain>: Remove member.
3308         (exceptions_state_mc_init): Update.
3309         (exception_try_scope_entry): Return nullptr.
3310         (exception_try_scope_exit, exception_rethrow)
3311         (throw_exception_sjlj, throw_exception_cxx): Update.
3312         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3313         (all_cleanups, do_cleanups, discard_cleanups)
3314         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3315         (restore_cleanups, restore_final_cleanups): Don't declare.
3316         (do_final_cleanups): Remove parameter.
3317         * common/cleanups.c (cleanup_chain, make_cleanup)
3318         (make_cleanup_dtor, all_cleanups, do_cleanups)
3319         (discard_my_cleanups, discard_cleanups)
3320         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3321         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3322         (null_cleanup): Remove.
3323         (do_final_cleanups): Remove parameter.
3324
3325 2019-03-06  Tom Tromey  <tom@tromey.com>
3326
3327         * remote.c (remote_target::remote_parse_stop_reply): Use
3328         unique_xmalloc_ptr.
3329
3330 2019-03-06  Tom Tromey  <tom@tromey.com>
3331
3332         * stabsread.c (struct stabs_field_info): Rename from field_info.
3333         <list, fnlist>: Add initializers.
3334         <obstack>: New member.
3335         (read_member_functions, read_struct_fields, read_baseclasses):
3336         Allocate on obstack.  Don't use cleanups.
3337         (read_one_struct_field, read_member_functions, read_struct_fields)
3338         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3339         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3340         (read_struct_type): Update.
3341
3342 2019-03-06  Tom Tromey  <tom@tromey.com>
3343
3344         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3345         * common/filestuff.h (make_cleanup_close): Don't declare.
3346         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3347         Remove.
3348
3349 2019-03-06  Tom Tromey  <tom@tromey.com>
3350
3351         * solib-aix.c: Use make_scope_exit.
3352
3353 2019-03-06  Tom Tromey  <tom@tromey.com>
3354
3355         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3356         Use make_scope_exit.
3357
3358 2019-03-06  Tom Tromey  <tom@tromey.com>
3359
3360         * solib-svr4.c (disable_probes_interface): Remove parameter.
3361         (svr4_handle_solib_event): Use make_scope_exit.
3362
3363 2019-03-06  Tom Tromey  <tom@tromey.com>
3364
3365         * remote.c (struct stop_reply_deleter): Remove.
3366         (stop_reply_up): Update.
3367         (struct stop_reply): Derive from notif_event.  Don't typedef.
3368         <regcache>: Now a std::vector.
3369         (stop_reply_xfree): Remove.
3370         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3371         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3372         (remote_target::discard_pending_stop_replies): Use delete.
3373         (remote_target::remote_parse_stop_reply): Update.
3374         (remote_target::process_stop_reply): Update.
3375         * remote-notif.h (struct notif_event): Add virtual destructor.
3376         Remove "dtr" member.
3377         (struct notif_client) <alloc_event>: Return a unique_ptr.
3378         (notif_event_xfree): Don't declare.
3379         (notif_event_up): New typedef.
3380         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3381         (notif_event_xfree, do_notif_event_xfree): Remove.
3382         (remote_notif_state_xfree): Update.
3383
3384 2019-03-06  Tom Tromey  <tom@tromey.com>
3385
3386         * infrun.c (displaced_step_clear_cleanup): Now a
3387         forward_scope_exit type.
3388         (displaced_step_prepare_throw): Update.
3389         (displaced_step_fixup): Update.
3390
3391 2019-03-06  Tom Tromey  <tom@tromey.com>
3392
3393         * inferior.h (class inferior): Update comment.
3394         * gdbthread.h (class thread_info): Update comment.
3395
3396 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3397             Tom Tromey  <tom@tromey.com>
3398
3399         * stabsread.h (struct stab_section_list): Remove.
3400         (coffstab_build_psymtabs): Update.
3401         * dbxread.c (symbuf_sections): Now a std::vector.
3402         (sect_idx): New global.
3403         (fill_symbuf): Update.
3404         (coffstab_build_psymtabs): Change type of stabsects parameter.
3405         Update.
3406         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3407         std::vector.
3408         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3409         (coff_locate_sections): Update.
3410         (coff_symfile_read): Remove cleanups.  Update.
3411         (init_stringtab): Add storage parameter.
3412         (free_stringtab, free_stringtab_cleanup): Remove.
3413         (init_lineno): Add storage parameter.
3414         (free_linetab, free_linetab_cleanup): Remove.
3415
3416 2019-03-06  Pedro Alves  <palves@redhat.com>
3417
3418         * linux-fork.c (fork_info::clobber_regs): Delete.
3419         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3420         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3421         comment.  Adjust.
3422         (scoped_switch_fork_info::scoped_switch_fork_info)
3423         (checkpoint_command, linux_fork_context): Adjust
3424         fork_save_infrun_state calls.
3425
3426 2019-03-06  Pedro Alves  <palves@redhat.com>
3427
3428         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3429         (inf_has_multiple_threads): Return 'bool' and rewrite using
3430         inferior_info::threads().
3431
3432 2019-03-06  Pedro Alves  <palves@redhat.com>
3433
3434         * linux-fork.c: Include <list>.
3435         (fork_list): Now a std::list instance.
3436         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3437         (forks_exist_p, find_last_fork): Adjust.
3438         (new_fork): Delete.
3439         (one_fork_p): New.
3440         (add_fork): Adjust.
3441         (free_fork): Delete, folded into fork_info::~fork_info().
3442         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3443         Adjust.
3444         (init_fork_list): Delete.
3445         (linux_fork_killall, linux_fork_mourn_inferior)
3446         (linux_fork_detach, info_checkpoints_command): Adjust.
3447         (_initialize_linux_fork): No longer call init_fork_list.
3448
3449 2019-03-06  Pedro Alves  <palves@redhat.com>
3450
3451         * linux-fork.c (new_fork): New, split out of ...
3452         (add_fork): ... this.  Return void.  Move "first fork" special
3453         case from here, to ...
3454         (checkpoint_command): ... here.
3455         * linux-linux.h (add_fork): Return void.
3456
3457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3460
3461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3462             Chris January  <chris.january@arm.com>
3463             David Lecomber  <david.lecomber@arm.com>
3464
3465         * f-exp.y: New token, UNOP_INTRINSIC.
3466         (exp): New pattern using UNOP_INTRINSIC token.
3467         (f77_keywords): Add 'abs' keyword.
3468         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3469         (value_from_host_double): New function.
3470         (evaluate_subexp_f): Support UNOP_ABS.
3471
3472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3475         types.
3476
3477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3480         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3481         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3482
3483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3486
3487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3488             Chris January  <chris.january@arm.com>
3489
3490         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3491         * f-exp.y: Define 'KIND' token.
3492         (exp): New pattern for KIND expressions.
3493         (ptype): Handle types with a kind extension.
3494         (direct_abs_decl): Extend to spot kind extensions.
3495         (f77_keywords): Add 'kind' to the list.
3496         (push_kind_type): New function.
3497         (convert_to_kind_type): New function.
3498         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3499         * parse.c (operator_length_standard): Likewise.
3500         * parser-defs.h (enum type_pieces): Add tp_kind.
3501         * std-operator.def: Add UNOP_KIND.
3502
3503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * f-exp.y (f_parse): Set yydebug.
3506
3507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         * f-lang.c (evaluate_subexp_f): New function.
3510         (exp_descriptor_f): New global.
3511         (f_language_defn): Use exp_descriptor_f instead of
3512         exp_descriptor_standard.
3513
3514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3515
3516         * f-exp.y (struct token): Add comments.
3517         (dot_ops): Remove uppercase versions and the end marker.
3518         (f77_keywords): Likewise.
3519         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3520         entries in the dot_ops array are case insensitive, and use
3521         strncasecmp to compare strings.  Also some whitespace cleanup in
3522         this area.  Similar for the f77_keywords array, except entries in
3523         this list might be case sensitive.
3524
3525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * f-exp.y (struct f77_boolean_val): Add comments.
3528         (boolean_values): Remove uppercase versions, and end marker.
3529         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3530         and use strncasecmp to achieve case insensitivity.  Additionally,
3531         perform whitespace cleanup around this code.
3532
3533 2019-03-06  Tom Tromey  <tromey@adacore.com>
3534
3535         * remote-sim.c (gdbsim_target_open): Use result of
3536         gdb_argv::release.
3537
3538 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3539         Dirk Schubert  <dirk.schubert@arm.com>
3540         Chris January  <chris.january@arm.com>
3541
3542         * eval.c (evaluate_subexp_standard): Call Fortran argument
3543         wrapping logic.
3544         * f-lang.c (struct value): A value which can be passed into a
3545         Fortran function call.
3546         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3547         where appropriate.
3548         (struct type): Value ready for a Fortran function call.
3549         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3550         is needed.
3551         * f-lang.h (fortran_argument_convert): Declaration.
3552         (fortran_preserve_arg_pointer): Declaration.
3553         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3554
3555 2019-03-05  Tom Tromey  <tromey@adacore.com>
3556
3557         * python/py-prettyprint.c (print_string_repr): Remove #if.
3558         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3559
3560 2019-03-05  Tom Tromey  <tromey@adacore.com>
3561
3562         * target.c (the_dummy_target): Move later.  Change type to
3563         "dummy_target".
3564         (initialize_targets): Don't initialize the_dummy_target.
3565
3566 2019-03-05  Tom Tromey  <tromey@adacore.com>
3567
3568         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3569         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3570
3571 2019-03-05  Tom Tromey  <tromey@adacore.com>
3572
3573         * windows-nat.c (windows_nat_target::attach)
3574         (windows_nat_target::detach): Don't call gdb_flush.
3575         * valprint.c (generic_val_print, val_print, val_print_string):
3576         Don't call gdb_flush.
3577         * utils.c (defaulted_query): Don't call gdb_flush.
3578         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3579         * target.c (target_announce_detach): Don't call gdb_flush.
3580         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3581         * remote.c (extended_remote_target::attach): Don't call
3582         gdb_flush.
3583         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3584         * printcmd.c (do_examine): Don't call gdb_flush.
3585         (info_display_command): Don't call gdb_flush.
3586         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3587         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3588         * memattr.c (info_mem_command): Don't call gdb_flush.
3589         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3590         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3591         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3592         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3593         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3594         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3595         (gnu_nat_target::detach): Don't call gdb_flush.
3596         * f-valprint.c (f_val_print): Don't call gdb_flush.
3597         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3598         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3599         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3600         gdb_flush.
3601         * c-valprint.c (c_val_print): Don't call gdb_flush.
3602         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3603
3604 2019-03-05  Tom Tromey  <tromey@adacore.com>
3605
3606         * varobj.c (update_dynamic_varobj_children): Update.
3607         (install_default_visualizer): Use reset, not release.
3608         * value.c (set_internalvar): Update.
3609         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3610         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3611         ATTRIBUTE_UNUSED_RESULT.
3612
3613 2019-03-05  Tom Tromey  <tromey@adacore.com>
3614
3615         * remote.c (class scoped_remote_fd) <release>: Add
3616         ATTRIBUTE_UNUSED_RESULT.
3617
3618 2019-03-05  Tom Tromey  <tromey@adacore.com>
3619
3620         * macroexp.c (struct macro_buffer) <release>: Add
3621         ATTRIBUTE_UNUSED_RESULT.
3622
3623 2019-03-05  Tom Tromey  <tromey@adacore.com>
3624
3625         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3626         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3627         ATTRIBUTE_UNUSED_RESULT.
3628
3629 2019-03-05  Tom Tromey  <tromey@adacore.com>
3630
3631         * common/scoped_fd.h (class scoped_fd) <release>: Add
3632         ATTRIBUTE_UNUSED_RESULT.
3633
3634 2019-03-05  Tom Tromey  <tromey@adacore.com>
3635
3636         * parser-defs.h (struct parser_state) <release>: Add
3637         ATTRIBUTE_UNUSED_RESULT.
3638
3639 2019-03-05  Tom Tromey  <tromey@adacore.com>
3640
3641         * utils.h (class gdb_argv) <release>: Add
3642         ATTRIBUTE_UNUSED_RESULT.
3643         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3644
3645 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3646
3647         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3648         for-loop range, to avoid compiler warnings.
3649
3650         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3651         avoid compiler warnings about unused variables.
3652
3653         * NEWS: Mention end of support for native debugging on MS-Windows
3654         before XP.
3655
3656         PR gdb/24292
3657         * common/netstuff.c:
3658         * gdbserver/gdbreplay.c
3659         * gdbserver/remote-utils.c:
3660         * ser-tcp.c:
3661         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3662         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3663         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3664         'getaddrinfo' and 'freeaddrinfo' were not available before
3665         Windows XP, and mingw.org's MinGW headers by default define
3666         _WIN32_WINNT to 0x500.
3667
3668 2019-03-01  Gary Benson <gbenson@redhat.com>
3669
3670         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3671
3672 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3673             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3674
3675         PR gdb/8527
3676         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3677         set_sigint_trap, clear_sigint_trap.
3678
3679 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3680
3681         * target.c (target_detach): Clear the regcache and the
3682         frame cache.
3683
3684 2019-02-27  Pedro Alves  <palves@redhat.com>
3685
3686         * utils.c (set_screen_size): When we cap the height/width sizes,
3687         tweak the corresponding command variable to show "unlimited":
3688
3689 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3690             Pedro Alves  <palves@redhat.com>
3691
3692         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3693         before calling rl_set_screen_size.
3694
3695 2019-02-27  Tom Tromey  <tromey@adacore.com>
3696
3697         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3698         define.
3699         * python/py-value.c: Remove Python 2.4 workaround.
3700         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3701         workaround.
3702         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3703         Python 2.4 workaround.
3704         * python/python-internal.h: Remove Python 2.4 comment.
3705         (Py_ssize_t): Don't define.
3706         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3707         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3708         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3709         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3710         * python/python.c (do_start_initialization): Remove Python 2.4
3711         workaround.
3712         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3713         (print_children): Remove Python 2.4 workaround.
3714         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3715         workaround.
3716         (CHARBUFFERPROC_NAME): Remove.
3717         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3718         Python 2.4 workaround.
3719
3720 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3721
3722         * NEWS: Note minimum Python version.
3723
3724 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3725
3726         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3727         code from these functions.  Remove corresponding ifdefs.  Use
3728         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3729         Remove gotos and target of gotos.
3730         (infpy_search_memory): Likewise.
3731
3732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3735         (hppa_gdbarch_init): Don't register deleted functions with
3736         gdbarch.
3737
3738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3741         (h8300_unwind_sp): Delete.
3742         (h8300_dummy_id): Delete.
3743         (h8300_gdbarch_init): Don't register deleted functions with
3744         gdbarch.
3745
3746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3749         (ft32_unwind_pc): Delete.
3750         (ft32_unwind_sp): Delete.
3751         (ft32_gdbarch_init): Don't register deleted functions with
3752         gdbarch.
3753
3754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3757         (frv_unwind_pc): Delete.
3758         (frv_unwind_sp): Delete.
3759         (frv_gdbarch_init): Don't register deleted functions with
3760         gdbarch.
3761
3762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3765         (riscv_unwind_pc): Delete.
3766         (riscv_unwind_sp): Delete.
3767         (riscv_gdbarch_init): Don't register deleted functions with
3768         gdbarch.
3769
3770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3773         (csky_unwind_pc): Delete.
3774         (csky_unwind_sp): Delete.
3775         (csky_gdbarch_init): Don't register deleted functions with
3776         gdbarch.
3777
3778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3781         (cris_unwind_pc): Delete.
3782         (cris_unwind_sp): Delete.
3783         (cris_gdbarch_init): Don't register deleted functions with
3784         gdbarch.
3785
3786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3789         (bfin_unwind_pc): Delete.
3790         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3791
3792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3795         (arm_unwind_pc): Delete.
3796         (arm_unwind_sp): Delete.
3797         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3798
3799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3802         (arc_unwind_pc): Delete.
3803         (arc_unwind_sp): Delete.
3804         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3805
3806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3809         (alpha_unwind_pc): Delete.
3810         (alpha_gdbarch_init): Don't register deleted functions with
3811         gdbarch.
3812
3813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3816         (aarch64_unwind_pc): Delete.
3817         (aarch64_unwind_sp): Delete.
3818         (aarch64_gdbarch_init): Don't register deleted functions with
3819         gdbarch.
3820
3821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * gdbtypes.c (type_align): Don't consider static members when
3824         computing structure alignment.
3825
3826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3829         return 0 for other types.
3830         * arch-utils.c (default_type_align): Always return 0.
3831         * gdbarch.h: Regenerate.
3832         * gdbarch.sh (type_align): Extend comment.
3833         * gdbtypes.c (type_align): Add additional comments, always call
3834         gdbarch_type_align before applying the default rules.
3835         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3836         generic code will then apply a suitable default.
3837         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3838         types, return 0 for other types.
3839
3840 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3841
3842         * NEWS: Create a new section for the next release branch.
3843         Rename the section of the current branch, now that it has
3844         been cut.
3845
3846 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3847
3848         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3849         * version.in: Bump version to 8.3.50.DATE-git.
3850
3851 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3852
3853         * aix-thread.c (ptid_cmp): Remove unused variable.
3854         (get_signaled_thread): Likewise.
3855         (store_regs_user_thread): Likewise.
3856         (store_regs_kernel_thread): Likewise.
3857         (fetch_regs_kernel_thread): Remove shadowed variable.
3858
3859 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * features/riscv/32bit-cpu.xml: Add register numbers.
3862         * features/riscv/32bit-fpu.c: Regenerate.
3863         * features/riscv/32bit-fpu.xml: Add register numbers.
3864         * features/riscv/64bit-cpu.xml: Add register numbers.
3865         * features/riscv/64bit-fpu.c: Regenerate.
3866         * features/riscv/64bit-fpu.xml: Add register numbers.
3867
3868 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3869
3870         * NEWS: Mention two argument form of gdb.Value constructor.
3871         * python/py-value.c (convert_buffer_and_type_to_value): New
3872         function.
3873         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3874         Add support for handling an optional second argument.  Call
3875         convert_buffer_and_type_to_value as appropriate.
3876         * python/python-internal.h (Py_buffer_deleter): New struct.
3877         (Py_buffer_up): New typedef.
3878
3879 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3880
3881         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3882         instead of releasing ownership.
3883
3884 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3885
3886         * dwarf2read.c (open_and_init_dwp_file): Call
3887         elf_numsections instead of bfd_count_sections to initialize
3888         dwp_file->num_sections.
3889
3890 2019-02-25  Tom Tromey  <tromey@adacore.com>
3891
3892         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3893
3894 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3895
3896         * gcore.in: Add '--readnever' option when invoking GDB.
3897
3898 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3899
3900         * MAINTAINERS: Update my email address.
3901
3902 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3903
3904         * build-id.c (build_id_to_debug_bfd_1): New function.
3905         (build_id_to_debug_bfd): Look for separate debug file in
3906         sysroot.
3907
3908 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3909
3910         * gdbarch.sh: Update the copyright year range that is placed into
3911         generated files.
3912
3913 2019-02-22  Keith Seitz  <keiths@redhat.com>
3914
3915         PR symtab/23853
3916         * linespec.c (create_sals_line_offset): Search for the default
3917         symtab's filename instead of its fullname.
3918
3919 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3920
3921         * NEWS: Update style defaults.
3922
3923 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3924
3925         * main.c (captured_main_1): Disable styling in batch mode.
3926
3927 2019-02-20  Tom Tromey  <tom@tromey.com>
3928
3929         * symtab.c (symtab_symbol_info): Fix typos.
3930
3931 2019-02-20  Tom Tromey  <tromey@adacore.com>
3932
3933         * findcmd.c (_initialize_mem_search): Use upper case for
3934         metasyntactic variables.
3935
3936 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3937
3938         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3939         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3940
3941 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3942
3943         * top.h (source_file_name): Change to std::string.
3944         * top.c (source_file_name): Likewise.
3945         (command_line_input): Adjust.
3946         * cli/cli-script.c (script_from_file): Adjust.
3947
3948 2019-02-19  Tom Tromey  <tromey@adacore.com>
3949
3950         * ravenscar-thread.c
3951         (ravenscar_thread_target::update_thread_list): Don't call
3952         ada_build_task_list.
3953         * ada-lang.h (ada_build_task_list): Don't declare.
3954         * ada-tasks.c (struct ada_tasks_inferior_data)
3955         <task_list_valid_p>: Now bool.
3956         (read_known_tasks, ada_task_list_changed)
3957         (ada_tasks_invalidate_inferior_data): Update.
3958         (read_known_tasks_array): Return bool.
3959         (read_known_tasks_list): Likewise.
3960         (read_known_tasks): Return void.
3961         (ada_build_task_list): Now static.
3962
3963 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3966         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3967
3968 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3969
3970         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3971         variant for ada_tasks_pspace_data_handle and
3972         ada_tasks_inferior_data_handle.
3973         (ada_tasks_pspace_data_cleanup): New function.
3974         (ada_tasks_inferior_data_cleanup): New function.
3975
3976 2019-02-17  Tom Tromey  <tom@tromey.com>
3977
3978         * macrotab.h (macro_source_fullname): Return a std::string.
3979         * macrotab.c (macro_include, check_for_redefinition)
3980         (macro_undef, macro_lookup_definition, foreach_macro)
3981         (foreach_macro_in_scope): Update.
3982         (macro_source_fullname): Return a std::string.
3983         * macrocmd.c (show_pp_source_pos): Update.
3984
3985 2019-02-17  Tom Tromey  <tom@tromey.com>
3986
3987         * macrocmd.c (show_pp_source_pos): Style the file names.
3988
3989 2019-02-17  Tom Tromey  <tom@tromey.com>
3990
3991         PR tui/24197:
3992         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3993
3994 2019-02-17  Tom Tromey  <tom@tromey.com>
3995
3996         * ada-lang.c (user_select_syms): Use filtered printing.
3997         * utils.c (wrap_style): New global.
3998         (desired_style): Remove.
3999         (emit_style_escape): Add stream parameter.
4000         (set_output_style, reset_terminal_style, prompt_for_continue):
4001         Update.
4002         (flush_wrap_buffer): Only flush gdb_stdout.
4003         (wrap_here): Set wrap_style.
4004         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4005         treat escape sequences as a character.  Change when wrap buffer is
4006         flushed.
4007         (fputs_styled): Do not set the output style when the default is
4008         requested.
4009         * ui-style.h (struct ui_file_style) <is_default>: New method.
4010         * source.c (print_source_lines_base): Emit escape sequences in one
4011         piece.
4012
4013 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4014
4015         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4016         integers and enumeration types.
4017
4018 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4019
4020         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4021         instead of lookup_symbol_in_language
4022         (do_exact_match): New function.
4023         (ada_get_symbol_name_matcher): Return do_exact_match when
4024         doing a verbatim match.
4025
4026 2019-02-15  Tom Tromey  <tromey@adacore.com>
4027
4028         * ravenscar-thread.c (ravenscar_thread_target::resume)
4029         (ravenscar_thread_target::wait): Special case wildcard requests.
4030
4031 2019-02-15  Tom Tromey  <tromey@adacore.com>
4032
4033         * ravenscar-thread.c (base_ptid): Remove.
4034         (struct ravenscar_thread_target) <close>: New method.
4035         <m_base_ptid>: New member.
4036         <update_inferior_ptid, active_task, task_is_currently_active,
4037         runtime_initialized>: Declare methods.
4038         <ravenscar_thread_target>: Add constructor.
4039         (ravenscar_thread_target::task_is_currently_active)
4040         (ravenscar_thread_target::update_inferior_ptid)
4041         (ravenscar_runtime_initialized): Rename.  Now methods.
4042         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4043         (ravenscar_thread_target::update_thread_list): Update.
4044         (ravenscar_thread_target::active_task): Now method.
4045         (ravenscar_thread_target::store_registers)
4046         (ravenscar_thread_target::prepare_to_store)
4047         (ravenscar_thread_target::prepare_to_store)
4048         (ravenscar_thread_target::mourn_inferior): Update.
4049         (ravenscar_inferior_created): Use "new" to create target.
4050         (ravenscar_thread_target::get_ada_task_ptid): Update.
4051         (_initialize_ravenscar): Don't initialize base_ptid.
4052         (ravenscar_ops): Remove global.
4053
4054 2019-02-15  Tom Tromey  <tromey@adacore.com>
4055
4056         * target.h (push_target): Declare new overload.
4057         * target.c (push_target): New overload, taking an rvalue reference.
4058         * remote.c (remote_target::open_1): Use push_target overload.
4059         * corelow.c (core_target_open): Use push_target overload.
4060
4061 2019-02-15  Tom Tromey  <tromey@adacore.com>
4062
4063         * ravenscar-thread.c (is_ravenscar_task)
4064         (ravenscar_task_is_currently_active): Return bool.
4065         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4066         (_initialize_ravenscar): Remove "(void)".
4067         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4068         Return bool.
4069
4070 2019-02-15  Tom Tromey  <tromey@adacore.com>
4071
4072         * ravenscar-thread.c (ravenscar_runtime_initializer)
4073         (has_ravenscar_runtime, get_running_thread_id)
4074         (ravenscar_thread_target::resume): Fix indentation.
4075
4076 2019-02-15  Tom Tromey  <tromey@adacore.com>
4077
4078         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4079         from ravenscar_arch_ops.
4080         (sparc_ravenscar_ops::fetch_registers)
4081         (sparc_ravenscar_ops::store_registers): Now methods.
4082         (sparc_ravenscar_prepare_to_store): Remove.
4083         (sparc_ravenscar_ops): Redefine.
4084         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4085         methods and destructor.  Remove members.
4086         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4087         (ravenscar_thread_target::store_registers)
4088         (ravenscar_thread_target::prepare_to_store): Update.
4089         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4090         Remove.
4091         (struct ppc_ravenscar_powerpc_ops): Derive from
4092         ravenscar_arch_ops.
4093         (ppc_ravenscar_powerpc_ops::fetch_registers)
4094         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4095         (ppc_ravenscar_powerpc_ops): Redefine.
4096         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4097         (ppc_ravenscar_e500_ops::fetch_registers)
4098         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4099         (ppc_ravenscar_e500_ops): Redefine.
4100         * aarch64-ravenscar-thread.c
4101         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4102         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4103         (aarch64_ravenscar_fetch_registers)
4104         (aarch64_ravenscar_store_registers): Now methods.
4105         (aarch64_ravenscar_ops): Redefine.
4106
4107 2019-02-15  Tom Tromey  <tromey@adacore.com>
4108
4109         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4110         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4111         (ravenscar_thread_target::stopped_by_watchpoint)
4112         (ravenscar_thread_target::stopped_data_address)
4113         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4114
4115 2019-02-15  Tom Tromey  <tromey@adacore.com>
4116
4117         * ravenscar-thread.c: Fix some typos.
4118
4119 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4120             Tom Tromey  <tromey@adacore.com>
4121
4122         * ada-lang.c (ada_exception_sal): Change addr_string to a
4123         std::string.
4124         (create_ada_exception_catchpoint): Update.
4125
4126 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4127             Tom Tromey  <tromey@adacore.com>
4128
4129         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4130         (bp_location_ops): Remove.
4131         (base_breakpoint_allocate_location): Update.
4132         (free_bp_location): Update.
4133         * ada-lang.c (class ada_catchpoint_location)
4134         <ada_catchpoint_location>: Remove ops parameter.
4135         (ada_catchpoint_location_dtor): Remove.
4136         (ada_catchpoint_location_ops): Remove.
4137         (allocate_location_exception): Update.
4138         * breakpoint.h (struct bp_location_ops): Remove.
4139         (class bp_location) <bp_location>: Remove bp_location_ops
4140         parameter.
4141         <~bp_location>: Add destructor.
4142         <ops>: Remove.
4143
4144 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4145             Pedro Alves  <palves@redhat.com>
4146
4147         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4148         'PATH_MAX'.
4149
4150 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4151             Samuel Thibault  <samuel.thibault@gnu.org>
4152             Thomas Schwinge  <thomas@codesourcery.com>
4153
4154         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4155         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4156
4157 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4158
4159         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4160         (check_empty): Use "const char *".
4161
4162         * gnu-nat.c (gnu_nat_target::detach): Instead of
4163         'detach_inferior (pid)' call
4164         'detach_inferior (find_inferior_pid (pid))'.
4165
4166         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4167         'nat/fork-inferior.o'.
4168         * gnu-nat.c: #include "nat/fork-inferior.h".
4169
4170         * gnu-nat.c (gnu_nat_target::detach): Instead of
4171         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4172         * gnu-nat.h: #include "inf-child.h".
4173         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4174         'i386_gnu_nat_target::fetch_registers'.
4175         (gnu_store_registers): Rename/move to
4176         'i386_gnu_nat_target::store_registers'.
4177
4178         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4179         * gnu-nat.h (mach_thread_info): New function.
4180         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4181
4182         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4183
4184 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4185
4186         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4187
4188 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4189
4190         * windows-nat.c (windows_add_thread): Add new parameter
4191         "main_thread_p" with default value set to false.  Update
4192         function documentation as well as all callers.
4193         (windows_delete_thread): Likewise.
4194         (fake_create_process): Update call to windows_add_thread.
4195         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4196         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4197         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4198         call to windows_delete_thread.
4199
4200 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4201
4202         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4203
4204 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4205
4206         * symfile.c (find_separate_debug_file): Use canonical path of
4207         sysroot with child_path instead of gdb_sysroot if it is valid.
4208
4209 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4210
4211         * symfile.c (find_separate_debug_file): Use child_path to
4212         determine if an object file is under a sysroot.
4213
4214 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4215
4216         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4217         unittests/child-path-selftests.c.
4218         * common/pathstuff.c (child_path): New function.
4219         * common/pathstuff.h (child_path): New prototype.
4220         * unittests/child-path-selftests.c: New file.
4221
4222 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4223
4224         * symfile.c (find_separate_debug_file): Look for separate debug
4225         files in debug directories under the sysroot.
4226
4227 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4228
4229         * symtab.h (struct minimal_symbol data_p): New const method.
4230         (struct minimal_symbol text_p): Likewise.
4231         * symtab.c (output_source_filename): Use file name style
4232         to print file name.
4233         (print_symbol_info): Likewise.
4234         (print_msymbol_info): Use address style to print addresses.
4235         Use function name style to print executable text symbols.
4236         (expand_symtab_containing_pc): Use data_p.
4237         (find_pc_sect_compunit_symtab): Likewise.
4238
4239 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240
4241         * breakpoint.c (describe_other_breakpoints): Use address style
4242         to print addresses.
4243         (say_where): Likewise.
4244
4245 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4246
4247         * ada-typeprint.c (print_func_type): Print function name
4248         style to print function name.
4249         * c-typeprint.c (c_print_type_1): Likewise.
4250
4251 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4252
4253         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4254         for execve.
4255
4256 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4257
4258         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4259         type_stack.
4260
4261 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4262
4263         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4264         TYPE_CODE_REF types.
4265
4266 2019-02-08  Jim Wilson  <jimw@sifive.com>
4267
4268         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4269         (riscv_linux_fregset): New.
4270         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4271
4272 2019-02-07  Tom Tromey  <tom@tromey.com>
4273
4274         * thread.c (thread_cancel_execution_command): Update.
4275         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4276         methods.
4277         (struct thread_fsm_ops): Remove.
4278         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4279         (thread_fsm_should_stop, thread_fsm_return_value)
4280         (thread_fsm_set_finished, thread_fsm_finished_p)
4281         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4282         Don't declare.
4283         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4284         * infrun.c (clear_proceed_status_thread)
4285         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4286         (print_stop_event): Update.
4287         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4288         Add constructor.
4289         (step_command_fsm_ops): Remove.
4290         (new_step_command_fsm): Remove.
4291         (step_1): Update.
4292         (step_command_fsm::should_stop): Rename from
4293         step_command_fsm_should_stop.
4294         (step_command_fsm::clean_up): Rename from
4295         step_command_fsm_clean_up.
4296         (step_command_fsm::do_async_reply_reason): Rename from
4297         step_command_fsm_async_reply_reason.
4298         (struct until_next_fsm): Inherit from thread_fsm.  Add
4299         constructor.
4300         (until_next_fsm_ops): Remove.
4301         (new_until_next_fsm): Remove.
4302         (until_next_fsm::should_stop): Rename from
4303         until_next_fsm_should_stop.
4304         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4305         (until_next_fsm::do_async_reply_reason): Rename from
4306         until_next_fsm_async_reply_reason.
4307         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4308         constructor.  Change type of breakpoint.
4309         (finish_command_fsm_ops): Remove.
4310         (new_finish_command_fsm): Remove.
4311         (finish_command_fsm::should_stop): Rename from
4312         finish_command_fsm_should_stop.
4313         (finish_command_fsm::clean_up): Rename from
4314         finish_command_fsm_clean_up.
4315         (finish_command_fsm::return_value): Rename from
4316         finish_command_fsm_return_value.
4317         (finish_command_fsm::do_async_reply_reason): Rename from
4318         finish_command_fsm_async_reply_reason.
4319         (finish_command): Update.
4320         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4321         Add constructor.
4322         (call_thread_fsm_ops): Remove.
4323         (call_thread_fsm::call_thread_fsm): Rename from
4324         new_call_thread_fsm.
4325         (call_thread_fsm::should_stop): Rename from
4326         call_thread_fsm_should_stop.
4327         (call_thread_fsm::should_notify_stop): Rename from
4328         call_thread_fsm_should_notify_stop.
4329         (run_inferior_call, call_function_by_hand_dummy): Update.
4330         * cli/cli-interp.c (should_print_stop_to_console): Update.
4331         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4332         Add constructor.  Change type of location_breakpoint,
4333         caller_breakpoint.
4334         (until_break_fsm_ops): Remove.
4335         (new_until_break_fsm): Remove.
4336         (until_break_fsm::should_stop): Rename from
4337         until_break_fsm_should_stop.
4338         (until_break_fsm::clean_up): Rename from
4339         until_break_fsm_clean_up.
4340         (until_break_fsm::do_async_reply_reason): Rename from
4341         until_break_fsm_async_reply_reason.
4342         (until_break_command): Update.
4343         * thread-fsm.c: Remove.
4344         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4345
4346 2019-02-07  Tom Tromey  <tom@tromey.com>
4347
4348         * yy-remap.h: Add include guard.
4349         * xtensa-tdep.h: Add include guard.
4350         * xcoffread.h: Rename include guard.
4351         * varobj-iter.h: Add include guard.
4352         * tui/tui.h: Rename include guard.
4353         * tui/tui-winsource.h: Rename include guard.
4354         * tui/tui-wingeneral.h: Rename include guard.
4355         * tui/tui-windata.h: Rename include guard.
4356         * tui/tui-win.h: Rename include guard.
4357         * tui/tui-stack.h: Rename include guard.
4358         * tui/tui-source.h: Rename include guard.
4359         * tui/tui-regs.h: Rename include guard.
4360         * tui/tui-out.h: Rename include guard.
4361         * tui/tui-layout.h: Rename include guard.
4362         * tui/tui-io.h: Rename include guard.
4363         * tui/tui-hooks.h: Rename include guard.
4364         * tui/tui-file.h: Rename include guard.
4365         * tui/tui-disasm.h: Rename include guard.
4366         * tui/tui-data.h: Rename include guard.
4367         * tui/tui-command.h: Rename include guard.
4368         * tic6x-tdep.h: Add include guard.
4369         * target/waitstatus.h: Rename include guard.
4370         * target/wait.h: Rename include guard.
4371         * target/target.h: Rename include guard.
4372         * target/resume.h: Rename include guard.
4373         * target-float.h: Rename include guard.
4374         * stabsread.h: Add include guard.
4375         * rs6000-tdep.h: Add include guard.
4376         * riscv-fbsd-tdep.h: Add include guard.
4377         * regformats/regdef.h: Rename include guard.
4378         * record.h: Rename include guard.
4379         * python/python.h: Rename include guard.
4380         * python/python-internal.h: Rename include guard.
4381         * python/py-stopevent.h: Rename include guard.
4382         * python/py-ref.h: Rename include guard.
4383         * python/py-record.h: Rename include guard.
4384         * python/py-record-full.h: Rename include guard.
4385         * python/py-record-btrace.h: Rename include guard.
4386         * python/py-instruction.h: Rename include guard.
4387         * python/py-events.h: Rename include guard.
4388         * python/py-event.h: Rename include guard.
4389         * procfs.h: Add include guard.
4390         * proc-utils.h: Add include guard.
4391         * p-lang.h: Add include guard.
4392         * or1k-tdep.h: Rename include guard.
4393         * observable.h: Rename include guard.
4394         * nto-tdep.h: Rename include guard.
4395         * nat/x86-linux.h: Rename include guard.
4396         * nat/x86-linux-dregs.h: Rename include guard.
4397         * nat/x86-gcc-cpuid.h: Add include guard.
4398         * nat/x86-dregs.h: Rename include guard.
4399         * nat/x86-cpuid.h: Rename include guard.
4400         * nat/ppc-linux.h: Rename include guard.
4401         * nat/mips-linux-watch.h: Rename include guard.
4402         * nat/linux-waitpid.h: Rename include guard.
4403         * nat/linux-ptrace.h: Rename include guard.
4404         * nat/linux-procfs.h: Rename include guard.
4405         * nat/linux-osdata.h: Rename include guard.
4406         * nat/linux-nat.h: Rename include guard.
4407         * nat/linux-namespaces.h: Rename include guard.
4408         * nat/linux-btrace.h: Rename include guard.
4409         * nat/glibc_thread_db.h: Rename include guard.
4410         * nat/gdb_thread_db.h: Rename include guard.
4411         * nat/gdb_ptrace.h: Rename include guard.
4412         * nat/fork-inferior.h: Rename include guard.
4413         * nat/amd64-linux-siginfo.h: Rename include guard.
4414         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4415         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4416         * nat/aarch64-linux.h: Rename include guard.
4417         * nat/aarch64-linux-hw-point.h: Rename include guard.
4418         * mn10300-tdep.h: Add include guard.
4419         * mips-linux-tdep.h: Add include guard.
4420         * mi/mi-parse.h: Rename include guard.
4421         * mi/mi-out.h: Rename include guard.
4422         * mi/mi-main.h: Rename include guard.
4423         * mi/mi-interp.h: Rename include guard.
4424         * mi/mi-getopt.h: Rename include guard.
4425         * mi/mi-console.h: Rename include guard.
4426         * mi/mi-common.h: Rename include guard.
4427         * mi/mi-cmds.h: Rename include guard.
4428         * mi/mi-cmd-break.h: Rename include guard.
4429         * m2-lang.h: Add include guard.
4430         * location.h: Rename include guard.
4431         * linux-record.h: Rename include guard.
4432         * linux-nat.h: Add include guard.
4433         * linux-fork.h: Add include guard.
4434         * i386-darwin-tdep.h: Rename include guard.
4435         * hppa-linux-offsets.h: Add include guard.
4436         * guile/guile.h: Rename include guard.
4437         * guile/guile-internal.h: Rename include guard.
4438         * gnu-nat.h: Rename include guard.
4439         * gdb-stabs.h: Rename include guard.
4440         * frv-tdep.h: Add include guard.
4441         * f-lang.h: Add include guard.
4442         * event-loop.h: Add include guard.
4443         * darwin-nat.h: Rename include guard.
4444         * cp-abi.h: Rename include guard.
4445         * config/sparc/nm-sol2.h: Rename include guard.
4446         * config/nm-nto.h: Rename include guard.
4447         * config/nm-linux.h: Add include guard.
4448         * config/i386/nm-i386gnu.h: Rename include guard.
4449         * config/djgpp/nl_types.h: Rename include guard.
4450         * config/djgpp/langinfo.h: Rename include guard.
4451         * compile/gcc-cp-plugin.h: Add include guard.
4452         * compile/gcc-c-plugin.h: Add include guard.
4453         * compile/compile.h: Rename include guard.
4454         * compile/compile-object-run.h: Rename include guard.
4455         * compile/compile-object-load.h: Rename include guard.
4456         * compile/compile-internal.h: Rename include guard.
4457         * compile/compile-cplus.h: Rename include guard.
4458         * compile/compile-c.h: Rename include guard.
4459         * common/xml-utils.h: Rename include guard.
4460         * common/x86-xstate.h: Rename include guard.
4461         * common/version.h: Rename include guard.
4462         * common/vec.h: Rename include guard.
4463         * common/tdesc.h: Rename include guard.
4464         * common/selftest.h: Rename include guard.
4465         * common/scoped_restore.h: Rename include guard.
4466         * common/scoped_mmap.h: Rename include guard.
4467         * common/scoped_fd.h: Rename include guard.
4468         * common/safe-iterator.h: Rename include guard.
4469         * common/run-time-clock.h: Rename include guard.
4470         * common/refcounted-object.h: Rename include guard.
4471         * common/queue.h: Rename include guard.
4472         * common/ptid.h: Rename include guard.
4473         * common/print-utils.h: Rename include guard.
4474         * common/preprocessor.h: Rename include guard.
4475         * common/pathstuff.h: Rename include guard.
4476         * common/observable.h: Rename include guard.
4477         * common/netstuff.h: Rename include guard.
4478         * common/job-control.h: Rename include guard.
4479         * common/host-defs.h: Rename include guard.
4480         * common/gdb_wait.h: Rename include guard.
4481         * common/gdb_vecs.h: Rename include guard.
4482         * common/gdb_unlinker.h: Rename include guard.
4483         * common/gdb_unique_ptr.h: Rename include guard.
4484         * common/gdb_tilde_expand.h: Rename include guard.
4485         * common/gdb_sys_time.h: Rename include guard.
4486         * common/gdb_string_view.h: Rename include guard.
4487         * common/gdb_splay_tree.h: Rename include guard.
4488         * common/gdb_setjmp.h: Rename include guard.
4489         * common/gdb_ref_ptr.h: Rename include guard.
4490         * common/gdb_optional.h: Rename include guard.
4491         * common/gdb_locale.h: Rename include guard.
4492         * common/gdb_assert.h: Rename include guard.
4493         * common/filtered-iterator.h: Rename include guard.
4494         * common/filestuff.h: Rename include guard.
4495         * common/fileio.h: Rename include guard.
4496         * common/environ.h: Rename include guard.
4497         * common/common-utils.h: Rename include guard.
4498         * common/common-types.h: Rename include guard.
4499         * common/common-regcache.h: Rename include guard.
4500         * common/common-inferior.h: Rename include guard.
4501         * common/common-gdbthread.h: Rename include guard.
4502         * common/common-exceptions.h: Rename include guard.
4503         * common/common-defs.h: Rename include guard.
4504         * common/common-debug.h: Rename include guard.
4505         * common/cleanups.h: Rename include guard.
4506         * common/buffer.h: Rename include guard.
4507         * common/btrace-common.h: Rename include guard.
4508         * common/break-common.h: Rename include guard.
4509         * cli/cli-utils.h: Rename include guard.
4510         * cli/cli-style.h: Rename include guard.
4511         * cli/cli-setshow.h: Rename include guard.
4512         * cli/cli-script.h: Rename include guard.
4513         * cli/cli-interp.h: Rename include guard.
4514         * cli/cli-decode.h: Rename include guard.
4515         * cli/cli-cmds.h: Rename include guard.
4516         * charset-list.h: Add include guard.
4517         * buildsym-legacy.h: Rename include guard.
4518         * bfin-tdep.h: Add include guard.
4519         * ax.h: Rename include guard.
4520         * arm-linux-tdep.h: Add include guard.
4521         * arm-fbsd-tdep.h: Add include guard.
4522         * arch/xtensa.h: Rename include guard.
4523         * arch/tic6x.h: Add include guard.
4524         * arch/i386.h: Add include guard.
4525         * arch/arm.h: Rename include guard.
4526         * arch/arm-linux.h: Rename include guard.
4527         * arch/arm-get-next-pcs.h: Rename include guard.
4528         * arch/amd64.h: Add include guard.
4529         * arch/aarch64-insn.h: Rename include guard.
4530         * arch-utils.h: Rename include guard.
4531         * annotate.h: Add include guard.
4532         * amd64-darwin-tdep.h: Rename include guard.
4533         * aarch64-linux-tdep.h: Add include guard.
4534         * aarch64-fbsd-tdep.h: Add include guard.
4535         * aarch32-linux-nat.h: Add include guard.
4536
4537 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4538
4539         * macrotab.c (macro_define_internal): New function that
4540         factorizes macro_define_object_internal and macro_define_function
4541         code.
4542         (macro_define_object_internal): Use macro_define_internal.
4543         (macro_define_function): Likewise.
4544
4545 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4546
4547         * macrocmd.c (extract_identifier): Return
4548         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4549         callers.
4550
4551 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4552
4553         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4554
4555 2019-02-05  Tom Tromey  <tom@tromey.com>
4556
4557         * target.c (target_stack::unpush): Move assertion earlier.
4558
4559 2019-01-30  Tom Tromey  <tom@tromey.com>
4560
4561         PR python/23615:
4562         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4563         (gdbpy_parse_and_eval): Likewise.
4564         * python/python-internal.h (gdbpy_allow_threads): New class.
4565
4566 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4567
4568         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4569         (aarch64_fbsd_fpregmap): Move earlier.
4570         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4571         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4572         instead of individual calls to trad_frame_set_reg_addr.
4573         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4574         earlier.
4575         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4576         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4577         instead of individual calls to trad_frame_set_reg_addr.
4578
4579 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4580
4581         * CONTRIBUTE: Replace contribution list with wiki link.
4582
4583 2019-01-25  Tom Tromey  <tom@tromey.com>
4584
4585         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4586
4587 2019-01-25  Tom Tromey  <tom@tromey.com>
4588
4589         * xtensa-linux-nat.c: Fix common/ includes.
4590         * xml-support.h: Fix common/ includes.
4591         * xml-support.c: Fix common/ includes.
4592         * x86-linux-nat.c: Fix common/ includes.
4593         * windows-nat.c: Fix common/ includes.
4594         * varobj.h: Fix common/ includes.
4595         * varobj.c: Fix common/ includes.
4596         * value.c: Fix common/ includes.
4597         * valops.c: Fix common/ includes.
4598         * utils.c: Fix common/ includes.
4599         * unittests/xml-utils-selftests.c: Fix common/ includes.
4600         * unittests/utils-selftests.c: Fix common/ includes.
4601         * unittests/unpack-selftests.c: Fix common/ includes.
4602         * unittests/tracepoint-selftests.c: Fix common/ includes.
4603         * unittests/style-selftests.c: Fix common/ includes.
4604         * unittests/string_view-selftests.c: Fix common/ includes.
4605         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4606         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4607         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4608         * unittests/rsp-low-selftests.c: Fix common/ includes.
4609         * unittests/parse-connection-spec-selftests.c: Fix common/
4610         includes.
4611         * unittests/optional-selftests.c: Fix common/ includes.
4612         * unittests/offset-type-selftests.c: Fix common/ includes.
4613         * unittests/observable-selftests.c: Fix common/ includes.
4614         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4615         * unittests/memrange-selftests.c: Fix common/ includes.
4616         * unittests/memory-map-selftests.c: Fix common/ includes.
4617         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4618         * unittests/function-view-selftests.c: Fix common/ includes.
4619         * unittests/environ-selftests.c: Fix common/ includes.
4620         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4621         * unittests/common-utils-selftests.c: Fix common/ includes.
4622         * unittests/cli-utils-selftests.c: Fix common/ includes.
4623         * unittests/array-view-selftests.c: Fix common/ includes.
4624         * ui-file.c: Fix common/ includes.
4625         * tui/tui-io.c: Fix common/ includes.
4626         * tracepoint.h: Fix common/ includes.
4627         * tracepoint.c: Fix common/ includes.
4628         * tracefile-tfile.c: Fix common/ includes.
4629         * top.h: Fix common/ includes.
4630         * top.c: Fix common/ includes.
4631         * thread.c: Fix common/ includes.
4632         * target/waitstatus.h: Fix common/ includes.
4633         * target/waitstatus.c: Fix common/ includes.
4634         * target.h: Fix common/ includes.
4635         * target.c: Fix common/ includes.
4636         * target-memory.c: Fix common/ includes.
4637         * target-descriptions.c: Fix common/ includes.
4638         * symtab.h: Fix common/ includes.
4639         * symfile.c: Fix common/ includes.
4640         * stap-probe.c: Fix common/ includes.
4641         * spu-linux-nat.c: Fix common/ includes.
4642         * sparc-nat.c: Fix common/ includes.
4643         * source.c: Fix common/ includes.
4644         * solib.c: Fix common/ includes.
4645         * solib-target.c: Fix common/ includes.
4646         * ser-unix.c: Fix common/ includes.
4647         * ser-tcp.c: Fix common/ includes.
4648         * ser-pipe.c: Fix common/ includes.
4649         * ser-base.c: Fix common/ includes.
4650         * selftest-arch.c: Fix common/ includes.
4651         * s12z-tdep.c: Fix common/ includes.
4652         * rust-exp.y: Fix common/ includes.
4653         * rs6000-aix-tdep.c: Fix common/ includes.
4654         * riscv-tdep.c: Fix common/ includes.
4655         * remote.c: Fix common/ includes.
4656         * remote-notif.h: Fix common/ includes.
4657         * remote-fileio.h: Fix common/ includes.
4658         * remote-fileio.c: Fix common/ includes.
4659         * regcache.h: Fix common/ includes.
4660         * regcache.c: Fix common/ includes.
4661         * record-btrace.c: Fix common/ includes.
4662         * python/python.c: Fix common/ includes.
4663         * python/py-type.c: Fix common/ includes.
4664         * python/py-inferior.c: Fix common/ includes.
4665         * progspace.h: Fix common/ includes.
4666         * producer.c: Fix common/ includes.
4667         * procfs.c: Fix common/ includes.
4668         * proc-api.c: Fix common/ includes.
4669         * printcmd.c: Fix common/ includes.
4670         * ppc-linux-nat.c: Fix common/ includes.
4671         * parser-defs.h: Fix common/ includes.
4672         * osdata.c: Fix common/ includes.
4673         * obsd-nat.c: Fix common/ includes.
4674         * nat/x86-linux.c: Fix common/ includes.
4675         * nat/x86-linux-dregs.c: Fix common/ includes.
4676         * nat/x86-dregs.h: Fix common/ includes.
4677         * nat/x86-dregs.c: Fix common/ includes.
4678         * nat/ppc-linux.c: Fix common/ includes.
4679         * nat/mips-linux-watch.h: Fix common/ includes.
4680         * nat/mips-linux-watch.c: Fix common/ includes.
4681         * nat/linux-waitpid.c: Fix common/ includes.
4682         * nat/linux-ptrace.h: Fix common/ includes.
4683         * nat/linux-ptrace.c: Fix common/ includes.
4684         * nat/linux-procfs.c: Fix common/ includes.
4685         * nat/linux-personality.c: Fix common/ includes.
4686         * nat/linux-osdata.c: Fix common/ includes.
4687         * nat/linux-namespaces.c: Fix common/ includes.
4688         * nat/linux-btrace.h: Fix common/ includes.
4689         * nat/linux-btrace.c: Fix common/ includes.
4690         * nat/fork-inferior.c: Fix common/ includes.
4691         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4692         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4693         * nat/aarch64-linux.c: Fix common/ includes.
4694         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4695         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4696         * namespace.h: Fix common/ includes.
4697         * mips-linux-tdep.c: Fix common/ includes.
4698         * minsyms.c: Fix common/ includes.
4699         * mi/mi-parse.h: Fix common/ includes.
4700         * mi/mi-main.c: Fix common/ includes.
4701         * mi/mi-cmd-env.c: Fix common/ includes.
4702         * memrange.h: Fix common/ includes.
4703         * memattr.c: Fix common/ includes.
4704         * maint.h: Fix common/ includes.
4705         * maint.c: Fix common/ includes.
4706         * main.c: Fix common/ includes.
4707         * machoread.c: Fix common/ includes.
4708         * location.c: Fix common/ includes.
4709         * linux-thread-db.c: Fix common/ includes.
4710         * linux-nat.c: Fix common/ includes.
4711         * linux-fork.c: Fix common/ includes.
4712         * inline-frame.c: Fix common/ includes.
4713         * infrun.c: Fix common/ includes.
4714         * inflow.c: Fix common/ includes.
4715         * inferior.h: Fix common/ includes.
4716         * inferior.c: Fix common/ includes.
4717         * infcmd.c: Fix common/ includes.
4718         * inf-ptrace.c: Fix common/ includes.
4719         * inf-child.c: Fix common/ includes.
4720         * ia64-linux-nat.c: Fix common/ includes.
4721         * i387-tdep.c: Fix common/ includes.
4722         * i386-tdep.c: Fix common/ includes.
4723         * i386-linux-tdep.c: Fix common/ includes.
4724         * i386-linux-nat.c: Fix common/ includes.
4725         * i386-go32-tdep.c: Fix common/ includes.
4726         * i386-fbsd-tdep.c: Fix common/ includes.
4727         * i386-fbsd-nat.c: Fix common/ includes.
4728         * guile/scm-type.c: Fix common/ includes.
4729         * guile/guile.c: Fix common/ includes.
4730         * go32-nat.c: Fix common/ includes.
4731         * gnu-nat.c: Fix common/ includes.
4732         * gdbthread.h: Fix common/ includes.
4733         * gdbarch-selftests.c: Fix common/ includes.
4734         * gdb_usleep.c: Fix common/ includes.
4735         * gdb_select.h: Fix common/ includes.
4736         * gdb_bfd.c: Fix common/ includes.
4737         * gcore.c: Fix common/ includes.
4738         * fork-child.c: Fix common/ includes.
4739         * findvar.c: Fix common/ includes.
4740         * fbsd-nat.c: Fix common/ includes.
4741         * event-top.c: Fix common/ includes.
4742         * event-loop.c: Fix common/ includes.
4743         * dwarf2read.c: Fix common/ includes.
4744         * dwarf2loc.c: Fix common/ includes.
4745         * dwarf2-frame.c: Fix common/ includes.
4746         * dwarf-index-cache.c: Fix common/ includes.
4747         * dtrace-probe.c: Fix common/ includes.
4748         * disasm-selftests.c: Fix common/ includes.
4749         * defs.h: Fix common/ includes.
4750         * csky-tdep.c: Fix common/ includes.
4751         * cp-valprint.c: Fix common/ includes.
4752         * cp-support.h: Fix common/ includes.
4753         * cp-support.c: Fix common/ includes.
4754         * corelow.c: Fix common/ includes.
4755         * completer.h: Fix common/ includes.
4756         * completer.c: Fix common/ includes.
4757         * compile/compile.c: Fix common/ includes.
4758         * compile/compile-loc2c.c: Fix common/ includes.
4759         * compile/compile-cplus-types.c: Fix common/ includes.
4760         * compile/compile-cplus-symbols.c: Fix common/ includes.
4761         * command.h: Fix common/ includes.
4762         * cli/cli-dump.c: Fix common/ includes.
4763         * cli/cli-cmds.c: Fix common/ includes.
4764         * charset.c: Fix common/ includes.
4765         * build-id.c: Fix common/ includes.
4766         * btrace.h: Fix common/ includes.
4767         * btrace.c: Fix common/ includes.
4768         * breakpoint.h: Fix common/ includes.
4769         * breakpoint.c: Fix common/ includes.
4770         * ax.h:
4771         (enum agent_op): Fix common/ includes.
4772         * ax-general.c (struct aop_map): Fix common/ includes.
4773         * ax-gdb.c: Fix common/ includes.
4774         * auxv.c: Fix common/ includes.
4775         * auto-load.c: Fix common/ includes.
4776         * arm-tdep.c: Fix common/ includes.
4777         * arch/riscv.c: Fix common/ includes.
4778         * arch/ppc-linux-common.c: Fix common/ includes.
4779         * arch/i386.c: Fix common/ includes.
4780         * arch/arm.c: Fix common/ includes.
4781         * arch/arm-linux.c: Fix common/ includes.
4782         * arch/arm-get-next-pcs.c: Fix common/ includes.
4783         * arch/amd64.c: Fix common/ includes.
4784         * arch/aarch64.c: Fix common/ includes.
4785         * arch/aarch64-insn.c: Fix common/ includes.
4786         * arch-utils.c: Fix common/ includes.
4787         * amd64-windows-tdep.c: Fix common/ includes.
4788         * amd64-tdep.c: Fix common/ includes.
4789         * amd64-sol2-tdep.c: Fix common/ includes.
4790         * amd64-obsd-tdep.c: Fix common/ includes.
4791         * amd64-nbsd-tdep.c: Fix common/ includes.
4792         * amd64-linux-tdep.c: Fix common/ includes.
4793         * amd64-linux-nat.c: Fix common/ includes.
4794         * amd64-fbsd-tdep.c: Fix common/ includes.
4795         * amd64-fbsd-nat.c: Fix common/ includes.
4796         * amd64-dicos-tdep.c: Fix common/ includes.
4797         * amd64-darwin-tdep.c: Fix common/ includes.
4798         * agent.c: Fix common/ includes.
4799         * ada-lang.h: Fix common/ includes.
4800         * ada-lang.c: Fix common/ includes.
4801         * aarch64-tdep.c: Fix common/ includes.
4802
4803 2019-01-25  Tom Tromey  <tom@tromey.com>
4804
4805         * common/create-version.sh: Use common/version.h.
4806
4807 2019-01-24  Pedro Alves  <palves@redhat.com>
4808
4809         * infrun.c (signal_stop, signal_print, signal_program)
4810         (signal_catch, signal_pass): Now arrays instead of pointers.
4811         (update_signals_program_target, do_target_resume)
4812         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4813         * linux-nat.c (linux_nat_target::pass_signals)
4814         (linux_nat_target::create_inferior, linux_nat_target::attach):
4815         Adjust.
4816         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4817         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4818         * procfs.c (procfs_target::pass_signals): Adjust.
4819         * record-full.c (record_full_target::resume): Adjust.
4820         * remote.c (remote_target::pass_signals)
4821         (remote_target::program_signals): Adjust.
4822         * target-debug.h (target_debug_print_signals): Now takes a
4823         gdb::array_view as parameter.  Adjust.
4824         * target.h (target_ops) <pass_signals, program_signals>: Replace
4825         pointer and length parameters with gdb::array_view.
4826         (target_pass_signals, target_program_signals): Likewise.
4827         * target-delegates.c: Regenerate.
4828
4829 2019-01-24  Pedro Alves  <palves@redhat.com>
4830
4831         * common/forward-scope-exit.h
4832         (forward_scope_exit::forward_scope_exit): Pass arguments to
4833         m_bind_function directly, instead of creating a std::bind and
4834         copying that.
4835
4836 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4837
4838         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4839         for static members.
4840         (pass_in_v_vfp_candidate): Likewise.
4841
4842 2019-01-23  Tom Tromey  <tom@tromey.com>
4843             Pedro Alves  <palves@redhat.com>
4844
4845         * regcache.c (class regcache_invalidator): Remove.
4846         (regcache::raw_write): Use make_scope_exit.
4847
4848 2019-01-23  Tom Tromey  <tom@tromey.com>
4849
4850         * ui-out.h (class ui_out_emit_type): Update comment.
4851
4852 2019-01-23  Tom Tromey  <tom@tromey.com>
4853
4854         * infrun.c (fetch_inferior_event): Update comment.
4855
4856 2019-01-23  Tom Tromey  <tom@tromey.com>
4857             Pedro Alves  <palves@redhat.com>
4858
4859         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4860         parameter.
4861         (fetch_inferior_event): Use SCOPE_EXIT.
4862
4863
4864 2019-01-23  Tom Tromey  <tom@tromey.com>
4865             Pedro Alves  <palves@redhat.com>
4866
4867         * infrun.c (disable_thread_events): Delete.
4868         (stop_all_threads): Use SCOPE_EXIT.
4869
4870 2019-01-23  Tom Tromey  <tom@tromey.com>
4871             Pedro Alves  <palves@redhat.com>
4872
4873         * symfile.c: Include forward-scope-exit.h.
4874         (clear_symtab_users_cleanup): Replace forward declaration with
4875         a FORWARD_SCOPE_EXIT.
4876         (syms_from_objfile_1): Use the forward_scope_exit and
4877         gdb::optional instead of cleanup_function.
4878         (reread_symbols): Use the forward_scope_exit instead of
4879         cleanup_function.
4880         (clear_symtab_users_cleanup): Remove function.
4881
4882 2019-01-23  Tom Tromey  <tom@tromey.com>
4883             Pedro Alves  <palves@redhat.com>
4884
4885         * linux-nat.c: Include scope-exit.h.
4886         (cleanup_target_stop): Remove.
4887         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4888         SCOPE_EXIT.
4889
4890 2019-01-23  Tom Tromey  <tom@tromey.com>
4891             Pedro Alves  <palves@redhat.com>
4892
4893         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4894         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4895
4896 2019-01-23  Tom Tromey  <tom@tromey.com>
4897             Andrew Burgess  <andrew.burgess@embecosm.com>
4898             Pedro Alves  <palves@redhat.com>
4899
4900         * infrun.c (fetch_inferior_event): Use scope_exit.
4901         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4902         * top.c (execute_command): Use scope_exit.
4903         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4904         * utils.c (do_bpstat_clear_actions_cleanup)
4905         (make_bpstat_clear_actions_cleanup): Remove.
4906
4907 2019-01-23  Tom Tromey  <tom@tromey.com>
4908             Pedro Alves  <palves@redhat.com>
4909
4910         * infrun.c: Include "common/scope-exit.h"
4911         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4912         (wait_for_inferior): Use SCOPE_EXIT.
4913         (fetch_inferior_event): Use scope_exit.
4914
4915 2019-01-23  Tom Tromey  <tom@tromey.com>
4916             Pedro Alves  <palves@redhat.com>
4917
4918         * breakpoint.c (create_breakpoint): Remove cleanup.
4919
4920 2019-01-23  Tom Tromey  <tom@tromey.com>
4921             Andrew Burgess  <andrew.burgess@embecosm.com>
4922             Pedro Alves  <palves@redhat.com>
4923
4924 2019-01-23  Pedro Alves  <palves@redhat.com>
4925
4926         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4927
4928 2019-01-23  Pedro Alves  <palves@redhat.com>
4929             Andrew Burgess  <andrew.burgess@embecosm.com>
4930
4931         * gdbthread.h: Include "common/forward-scope-exit.h".
4932         (scoped_finish_thread_state): Redefine custom class in terms of
4933         forward_scope_exit.
4934
4935 2019-01-23  Pedro Alves  <palves@redhat.com>
4936             Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * common/forward-scope-exit.h: New file.
4939
4940 2019-01-23  Pedro Alves  <palves@redhat.com>
4941             Andrew Burgess  <andrew.burgess@embecosm.com>
4942             Tom Tromey  <tom@tromey.com>
4943
4944         * common/scope-exit.h: New file.
4945
4946 2019-01-23  Pedro Alves  <palves@redhat.com>
4947
4948         * common/preprocessor.h (ESC): Rename to ...
4949         (ESC_PARENS): ... this.
4950         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4951         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4952
4953 2019-01-23  Tom Tromey  <tom@tromey.com>
4954
4955         * language.h (class scoped_switch_to_sym_language_if_auto):
4956         Initialize m_lang in both cases.
4957
4958 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4959
4960         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4961         with XCNEW.
4962
4963 2019-01-22  Tom Tromey  <tom@tromey.com>
4964
4965         * corelow.c: Do not include sys/file.h.
4966
4967 2019-01-22  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-wingeneral.h: Include gdb_curses.h.
4970
4971 2019-01-22  Tom Tromey  <tom@tromey.com>
4972
4973         * source-cache.h (class source_cache) <get_source_lines,
4974         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4975
4976 2019-01-22  Tom Tromey  <tom@tromey.com>
4977
4978         * remote-fileio.h (struct remote_target): Declare.
4979
4980 2019-01-22  Tom Tromey  <tom@tromey.com>
4981
4982         * python/py-arch.c: Do not include py-ref.h.
4983         * python/py-bpevent.c: Do not include py-ref.h.
4984         * python/py-cmd.c: Do not include py-ref.h.
4985         * python/py-continueevent.c: Do not include py-ref.h.
4986         * python/py-event.h: Do not include py-ref.h.
4987         * python/py-evtregistry.c: Do not include py-ref.h.
4988         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4989         * python/py-frame.c: Do not include py-ref.h.
4990         * python/py-framefilter.c: Do not include py-ref.h.
4991         * python/py-function.c: Do not include py-ref.h.
4992         * python/py-infevents.c: Do not include py-ref.h.
4993         * python/py-linetable.c: Do not include py-ref.h.
4994         * python/py-objfile.c: Do not include py-ref.h.
4995         * python/py-param.c: Do not include py-ref.h.
4996         * python/py-prettyprint.c: Do not include py-ref.h.
4997         * python/py-progspace.c: Do not include py-ref.h.
4998         * python/py-symbol.c: Do not include py-ref.h.
4999         * python/py-symtab.c: Do not include py-ref.h.
5000         * python/py-type.c: Do not include py-ref.h.
5001         * python/py-unwind.c: Do not include py-ref.h.
5002         * python/py-utils.c: Do not include py-ref.h.
5003         * python/py-value.c: Do not include py-ref.h.
5004         * python/py-varobj.c: Do not include py-ref.h.
5005         * python/py-xmethods.c: Do not include py-ref.h.
5006         * python/python.c: Do not include py-ref.h.
5007         * varobj.c: Do not include py-ref.h.
5008
5009 2019-01-22  Tom Tromey  <tom@tromey.com>
5010
5011         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5012         keyword for bcache.
5013
5014 2019-01-22  Tom Tromey  <tom@tromey.com>
5015
5016         * compile/compile-cplus-types.c: Remove a comment by #include.
5017
5018 2019-01-22  Tom Tromey  <tom@tromey.com>
5019
5020         * compile/gcc-c-plugin.h: Include compile-internal.h.
5021
5022 2019-01-22  Tom Tromey  <tom@tromey.com>
5023
5024         * stabsread.c (EXTERN): Do not define.
5025         (symnum, next_symbol_text_func, processing_gcc_compilation)
5026         (within_function, global_sym_chain, global_stabs)
5027         (previous_stab_code, this_object_header_files)
5028         (n_this_object_header_files)
5029         (n_allocated_this_object_header_files): Define.
5030         * stabsread.h (EXTERN): Never define.  Use "extern".
5031
5032 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5033
5034         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5035         history_value.
5036
5037 2019-01-21  Tom Tromey  <tom@tromey.com>
5038
5039         * ui-out.c: Fix includes.
5040         * tui/tui-source.c: Fix includes.
5041         * target.c: Fix includes.
5042         * remote.c: Fix includes.
5043         * regcache.c: Fix includes.
5044         * python/py-block.c: Fix includes.
5045         * printcmd.c: Fix includes.
5046         * or1k-tdep.c: Fix includes.
5047         * mi/mi-main.c: Fix includes.
5048         * m32r-tdep.c: Fix includes.
5049         * csky-tdep.c: Fix includes.
5050         * compile/compile-cplus-types.c: Fix includes.
5051         * cli/cli-interp.c: Fix includes.
5052
5053 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5054
5055         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5056         for padding.
5057
5058 2019-01-16  Tom Tromey  <tom@tromey.com>
5059
5060         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5061         earlier.
5062         (struct objfile) <msymbols_range>: Move from top level.
5063         <msymbols>: New method.
5064         (class objfile_msymbols): Remove.
5065         * symtab.c (default_collect_symbol_completion_matches_break_on):
5066         Update.
5067         * symmisc.c (dump_msymbols): Update.
5068         * stabsread.c (scan_file_globals): Update.
5069         * objc-lang.c (info_selectors_command, info_classes_command)
5070         (find_methods): Update.
5071         * minsyms.c (find_solib_trampoline_target): Update.
5072         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5073         * coffread.c (coff_symfile_read): Update.
5074         * ada-lang.c (ada_lookup_simple_minsym)
5075         (ada_collect_symbol_completion_matches): Update.
5076
5077 2019-01-16  Tom Tromey  <tom@tromey.com>
5078
5079         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5080         type.  Remove no-argument constructor.
5081         <iterator::operator++>: Simplify.
5082         <begin>: Update.
5083         <end>: Use minimal_symbol_count.
5084
5085 2019-01-16  Tom Tromey  <tom@tromey.com>
5086
5087         * objfiles.h (struct objfile) <psymtabs>: New method.
5088         (class objfile_psymtabs): Remove.
5089         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5090         typedef.
5091         <range>: New method.
5092         (require_partial_symbols): Change return type.
5093         * psymtab.c (require_partial_symbols)
5094         (psym_expand_symtabs_matching): Update.
5095         * mdebugread.c (parse_partial_symbols): Update.
5096         * dbxread.c (dbx_end_psymtab): Update.
5097
5098 2019-01-15  Tom Tromey  <tom@tromey.com>
5099
5100         * symtab.c (lookup_objfile_from_block)
5101         (lookup_symbol_in_objfile_symtabs)
5102         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5103         (find_line_symtab, info_sources_command)
5104         (default_collect_symbol_completion_matches_break_on)
5105         (make_source_files_completion_list): Update.
5106         * symmisc.c (print_objfile_statistics, dump_objfile)
5107         (maintenance_print_symbols, maintenance_info_symtabs)
5108         (maintenance_check_symtabs, maintenance_info_line_tables):
5109         Update.
5110         * source.c (select_source_symtab)
5111         (forget_cached_source_info_for_objfile): Update.
5112         * objfiles.h (class objfile_compunits): Remove.
5113         (struct objfile) <compunits_range>: New typedef.
5114         (compunits): New method.
5115         * objfiles.c (objfile_relocate1): Update.
5116         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5117         * maint.c (count_symtabs_and_blocks): Update.
5118         * linespec.c (iterate_over_all_matching_symtabs): Update.
5119         * cp-support.c (add_symbol_overload_list_qualified): Update.
5120         * coffread.c (coff_symtab_read): Update.
5121         * ada-lang.c (add_nonlocal_symbols)
5122         (ada_collect_symbol_completion_matches)
5123         (ada_add_global_exceptions): Update.
5124
5125 2019-01-15  Tom Tromey  <tom@tromey.com>
5126
5127         * progspace.h (program_space) <objfiles_safe_range>: New
5128         typedef.
5129         <objfiles_safe>: New method.
5130         * objfiles.h (class all_objfiles_safe): Remove.
5131         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5132         * jit.c (jit_inferior_exit_hook): Update.
5133
5134 2019-01-17  Tom Tromey  <tom@tromey.com>
5135
5136         * progspace.h (program_space) <objfiles_range>: New typedef.
5137         <objfiles>: New method.
5138         <objfiles_head>: Rename from objfiles.
5139         (object_files): Update.
5140         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5141         * guile/scm-pretty-print.c
5142         (ppscm_find_pretty_printer_from_objfiles): Update.
5143         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5144         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5145         Update.
5146         * python/py-progspace.c (pspy_get_objfiles): Update.
5147         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5148         Update.
5149         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5150         (objfpy_lookup_objfile_by_build_id): Update.
5151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5152         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5153         Update.
5154         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5155         (expand_symtab_containing_pc, lookup_objfile_from_block)
5156         (lookup_static_symbol, basic_lookup_transparent_type)
5157         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5158         (find_line_symtab, info_sources_command)
5159         (default_collect_symbol_completion_matches_break_on)
5160         (make_source_files_completion_list, find_main_name): Update.
5161         * symmisc.c (print_symbol_bcache_statistics)
5162         (print_objfile_statistics, maintenance_print_symbols)
5163         (maintenance_print_msymbols, maintenance_print_objfiles)
5164         (maintenance_info_symtabs, maintenance_check_symtabs)
5165         (maintenance_expand_symtabs, maintenance_info_line_tables):
5166         Update.
5167         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5168         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5169         (map_overlay_command, unmap_overlay_command)
5170         (simple_overlay_update, expand_symtabs_matching)
5171         (map_symbol_filenames): Update.
5172         * symfile-debug.c (set_debug_symfile): Update.
5173         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5174         Update.
5175         * source.c (select_source_symtab, forget_cached_source_info):
5176         Update.
5177         * solib.c (solib_read_symbols): Update.
5178         * solib-spu.c (append_ocl_sos): Update.
5179         * psymtab.c (maintenance_print_psymbols)
5180         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5181         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5182         * printcmd.c (info_symbol_command): Update.
5183         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5184         Update.
5185         * objfiles.h (class all_objfiles): Remove.
5186         * objfiles.c (have_partial_symbols, have_full_symbols)
5187         (have_minimal_symbols, qsort_cmp, update_section_map)
5188         (shared_objfile_contains_address_p)
5189         (default_iterate_over_objfiles_in_search_order): Update.
5190         * objc-lang.c (info_selectors_command, info_classes_command)
5191         (find_methods): Update.
5192         * minsyms.c (find_solib_trampoline_target): Update.
5193         * maint.c (maintenance_info_sections)
5194         (maintenance_translate_address, count_symtabs_and_blocks):
5195         Update.
5196         * main.c (captured_main_1): Update.
5197         * linux-thread-db.c (try_thread_db_load_from_pdir)
5198         (has_libpthread): Update.
5199         * linespec.c (iterate_over_all_matching_symtabs)
5200         (search_minsyms_for_name): Update.
5201         * jit.c (jit_find_objf_with_entry_addr): Update.
5202         * hppa-tdep.c (find_unwind_entry)
5203         (hppa_lookup_stub_minimal_symbol): Update.
5204         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5205         Update.
5206         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5207         (elf_gnu_ifunc_resolve_by_got): Update.
5208         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5209         * dwarf-index-write.c (save_gdb_index_command): Update.
5210         * cp-support.c (add_symbol_overload_list_qualified): Update.
5211         * breakpoint.c (create_overlay_event_breakpoint)
5212         (create_longjmp_master_breakpoint)
5213         (create_std_terminate_master_breakpoint)
5214         (create_exception_master_breakpoint): Update.
5215         * blockframe.c (find_pc_partial_function): Update.
5216         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5217         (ada_collect_symbol_completion_matches)
5218         (ada_add_global_exceptions): Update.
5219
5220 2019-01-17  Tom Tromey  <tom@tromey.com>
5221
5222         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5223         declare VEC.
5224         (solib_target_parse_libraries): Change return type.
5225         (library_list_start_segment, library_list_start_section)
5226         (library_list_end_library, library_list_start_library); Update.
5227         (solib_target_free_library_list): Remove.
5228         (solib_target_parse_libraries): Remove cleanup.  Change return
5229         type.
5230         (solib_target_current_sos): Update.
5231
5232 2019-01-17  Tom Tromey  <tromey@bapiya>
5233
5234         * valprint.c: Replace "the the" with "the".
5235         * symtab.c: Replace "the the" with "the".
5236         * solib.c: Replace "the the" with "the".
5237         * solib-dsbt.c: Replace "the the" with "the".
5238         * linespec.c: Replace "the the" with "the".
5239         * dwarf2loc.h: Replace "the the" with "the".
5240         * amd64-windows-tdep.c: Replace "the the" with "the".
5241         * aarch64-tdep.c: Replace "the the" with "the".
5242
5243 2019-01-16  Keith Seitz  <keiths@redhat.com>
5244
5245         PR gdb/23773
5246         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5247         <builder>: Rename to ..
5248         <m_builder>: ... this and make private.
5249         (dwarf2_cu::get_builder): New method.  Change all users of
5250         `builder' to use this method.
5251         (dwarf2_start_symtab): Move to ...
5252         (dwarf2_cu::start_symtab): ... here.  Update all callers
5253         (setup_type_unit_groups): Move to ...
5254         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5255         callers.
5256         (dwarf2_cu::reset_builder): New method.
5257         (process_full_compunit, process_full_type_unit): Use
5258         dwarf2_cu::reset_builder.
5259         (follow_die_offset): Record the ancestor CU if it is different
5260         from the followed DIE's CU.
5261         (follow_die_sig_1): Likewise.
5262
5263 2019-01-15  Tom Tromey  <tom@tromey.com>
5264
5265         * remote.c (class remote_state) <buf>: Now a char_vector.
5266         <buf_size>: Remove.
5267         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5268         parameter.
5269         (remote_target::getpkt_or_notif_sane_1)
5270         (remote_target::getpkt_sane)
5271         (remote_target::getpkt_or_notif_sane): Likewise.
5272         (class remote_target) <putpkt>: New overload.
5273         (remote_target::read_frame): Change type of "buf_p".  Remove
5274         sizeof_p parameter.
5275         (packet_ok): New overload.
5276         (packet_check_result): New overload.
5277         Update all uses.
5278
5279 2019-01-14  Tom Tromey  <tom@tromey.com>
5280
5281         * remote-notif.c (handle_notification, remote_notif_ack)
5282         (remote_notif_parse): Make "buf" const.
5283         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5284         const.
5285         (remote_notif_parse, remote_notif_ack, handle_notification):
5286         Likewise.
5287         * remote.c (remote_notif_stop_parse): Make "buf" const.
5288         (remote_target::remote_parse_stop_reply): Make "buf" const.
5289         (remote_notif_stop_ack): Make "buf" const.
5290
5291 2019-01-14  Tom Tromey  <tom@tromey.com>
5292
5293         * remote.c (remote_console_output): Make parameter const.
5294
5295 2019-01-14  Tom Tromey  <tom@tromey.com>
5296
5297         * target-debug.h (target_debug_print_signals): Constify.
5298         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5299         * procfs.c (procfs_target::pass_signals): Update.
5300         * linux-nat.c (linux_nat_target::pass_signals): Update.
5301         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5302         * target-delegates.c: Rebuild.
5303         * remote.c (remote_target::program_signals): Update.
5304         (remote_target::pass_signals): Update.
5305         * target.c (target_pass_signals): Constify argument.
5306         (target_program_signals): Likewise.
5307         * target.h (struct target_ops) <pass_signals, program_signals>:
5308         Constify argument.
5309         (target_pass_signals, target_program_signals): Constify argument.
5310
5311 2019-01-14  Tom Tromey  <tom@tromey.com>
5312
5313         PR tui/28819:
5314         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5315
5316 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5317
5318         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5319         field.
5320         * rs6000-tdep.c: Include reggroups.h.
5321         (IS_V_ALIAS_PSEUDOREG): Define.
5322         (rs6000_register_name): Return names for the "vX" aliases.
5323         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5324         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5325         aliases.  Call default_register_reggroup_p for all other
5326         pseudo-registers.
5327         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5328         New functions.
5329         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5330         Handle "vX" aliases.
5331         (v_alias_pseudo_register_collect): New function.
5332         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5333         (rs6000_gdbarch_init): Initialize "vX" aliases as
5334         pseudo-registers.  Restore registration of
5335         rs6000_pseudo_register_reggroup_p with
5336         set_tdesc_pseudo_register_reggroup_p.
5337
5338 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5339
5340         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5341         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5342         set_gdbarch_num_pseudo_regs.
5343
5344 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5345
5346         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5347         Remove arg prefixname, add do_set and do_show.
5348         Add member functions set_list and show_list.
5349         * cli/cli-style.c (class cli_style_option): Update accordingly.
5350         (style_set_list): Move to file scope.
5351         (style_show_list): Likewise.
5352         (set_style): Call help_list.
5353         (show_style): Call cmd_show_list.
5354         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5355         Update to use the new macro.
5356
5357 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5358
5359         * ada-lang.c (_initialize_ada_language): Expand the help text
5360         for the "catch exception" command.
5361
5362 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5363
5364         * symtab.c (matching_obj_sections): Initialize obj,
5365         declare it closer to its usage.
5366
5367 2019-01-10  Tom Tromey  <tom@tromey.com>
5368
5369         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5370         (basic_inf_threads_range): Remove.
5371         (inf_threads_range, inf_non_exited_threads_range)
5372         (safe_inf_threads_range): Use next_adapter.
5373
5374 2019-01-10  Keith Seitz  <keiths@redhat.com>
5375
5376         PR gdb/23712
5377         PR symtab/23010
5378         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5379         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5380
5381 2019-01-10  Keith Seitz  <keiths@redhat.com>
5382
5383         PR gdb/23712
5384         PR symtab/23010
5385         * dictionary.c (pending_to_vector): Remove.
5386         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5387         Remove _1 suffix, replacing functions of the same name.  Update
5388         all callers.
5389         (dict_create_hashed, dict_create_hashed_expandable)
5390         (dict_create_linear, dict_create_linear_expandable, dict_free)
5391         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5392         Make functions static.
5393
5394 2019-01-10  Keith Seitz  <keiths@redhat.com>
5395
5396         PR gdb/23712
5397         PR symtab/23010
5398         * dictionary.h (struct dictionary): Replace declaration with
5399         multidictionary.
5400         (dict_create_hashed, dict_create_hashed_expandable)
5401         (dict_create_linear, dict_create_linear_expandable)
5402         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5403         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5404         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5405         taking multidictionary argument.
5406         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5407         * block.h (struct block) <dict>: Change to multidictionary
5408         and rename `multidict'.
5409         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5410         symmisc.c: Update all dictionary references to multidictionary.
5411
5412 2019-01-10  Keith Seitz  <keiths@redhat.com>
5413
5414         PR gdb/23712
5415         PR symtab/23010
5416         * dictionary.c: Include unordered_map.
5417         (pending_to_vector): New function.
5418         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5419         Rewrite the non-"_1" functions to take vector instead
5420         of linked list.
5421         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5422         "new" _1 versions of the same name.
5423         (multidictionary): Define.
5424         (std::hash<enum language): New definition.
5425         (collate_pending_symbols_by_language, mdict_create_hashed)
5426         (mdict_create_hashed_expandable, mdict_create_linear)
5427         (mdict_create_linear_expandable, mdict_free)
5428         (find_language_dictionary, create_new_language_dictionary)
5429         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5430         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5431         (mdict_size, mdict_empty): New functions.
5432         * dictionary.h (mdict_iterator): Define.
5433
5434 2019-01-10  Pedro Alves  <palves@redhat.com>
5435
5436         * breakpoint.c (read_uploaded_action)
5437         (create_tracepoint_from_upload): Adjust to use
5438         gdb::unique_xmalloc_ptr.
5439         * ctf.c (ctf_write_uploaded_tp):
5440         (SET_ARRAY_FIELD): Use emplace_back.
5441         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5442         * tracefile-tfile.c (tfile_write_uploaded_tp):
5443         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5444         gdb::unique_xmalloc_ptr.
5445         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5446         at_string, cond_string, cmd_strings>: Replace char pointers
5447         with gdb::unique_xmalloc_ptr.
5448
5449 2019-01-10  Pedro Alves  <palves@redhat.com>
5450
5451         * solib-target.c (library_list_start_library): Don't xstrdup name.
5452
5453 2019-01-10  Pedro Alves  <palves@redhat.com>
5454
5455         * mdebugread.c (parse_partial_symbols): Use
5456         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5457
5458 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5459
5460         * linux-fork.c (scoped_switch_fork_info)
5461         <~scoped_switch_fork_info>: Fix incorrect variable name.
5462
5463 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * linux-fork.c (scoped_switch_fork_info)
5466         <scoped_switch_fork_info>: Make explicit.
5467         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5468
5469 2019-01-10  Tom Tromey  <tom@tromey.com>
5470
5471         * objfiles.h (objfile::reset_psymtabs): Update.
5472         * objfiles.c (objfile::objfile): Update.
5473         * psymtab.h (psymtab_storage::obstack): Update.
5474         (psymtab_storage::m_obstack): Use gdb::optional.
5475         (class psymtab_storage): Update comment.  Remove objfile
5476         parameter.
5477         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5478
5479 2019-01-10  Tom Tromey  <tom@tromey.com>
5480
5481         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5482         <free_psymtabs>: Now private.
5483         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5484         (allocate_psymtab): Use new method.
5485
5486 2019-01-10  Tom Tromey  <tom@tromey.com>
5487
5488         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5489         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5490         * mdebugread.c (parse_partial_symbols): Use
5491         allocate_dependencies.
5492         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5493         allocate_dependencies.
5494         (process_psymtab_comp_unit_reader)
5495         (build_type_psymtab_dependencies): Likewise.
5496         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5497
5498 2019-01-10  Tom Tromey  <tom@tromey.com>
5499
5500         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5501         PSYMBOL_SET_LANGUAGE.
5502         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5503
5504 2019-01-10  Tom Tromey  <tom@tromey.com>
5505
5506         * psymtab.h (psymtab_storage::obstack): New method.
5507         <m_obstack>: Rename from obstack; now private.
5508         * psymtab.c (psymtab_storage): Update.
5509         * dwarf2read.c (create_addrmap_from_index)
5510         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5511         Update.
5512
5513 2019-01-10  Tom Tromey  <tom@tromey.com>
5514
5515         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5516         * objfiles.h (objfile::reset_psymtabs): New method.
5517
5518 2019-01-10  Tom Tromey  <tom@tromey.com>
5519
5520         * symmisc.c (print_symbol_bcache_statistics): Update.
5521         (print_objfile_statistics): Update.
5522         * symfile.c (reread_symbols): Update.
5523         * psymtab.h (class psymtab_storage): New.
5524         * psymtab.c (psymtab_storage): New constructor.
5525         (~psymtab_storage): New destructor.
5526         (require_partial_symbols): Update.
5527         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5528         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5529         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5530         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5531         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5532         (start_psymtab_common, end_psymtab_common)
5533         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5534         (allocate_psymtab): Update.
5535         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5536         Update.
5537         (dump_psymtab_addrmap, maintenance_print_psymbols)
5538         (maintenance_check_psymtabs): Update.
5539         (class objfile_psymtabs): Move to objfiles.h.
5540         * psympriv.h (discard_psymtab): Now inline.
5541         (psymtab_discarder::psymtab_discarder): Update.
5542         (psymtab_discarder::~psymtab_discarder): Update.
5543         (ALL_OBJFILE_PSYMTABS): Rewrite.
5544         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5545         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5546         Remove fields.
5547         <partial_symtabs>: New field.
5548         (class objfile_psymtabs): Move from psymtab.h.  Update.
5549         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5550         psymbol_cache.
5551         (objfile::~objfile): Don't destroy psymbol_cache.
5552         * mdebugread.c (parse_partial_symbols): Update.
5553         * dwarf2read.c (create_addrmap_from_index)
5554         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5555         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5556         (add_partial_subprogram, dwarf2_ranges_read): Update.
5557         * dwarf-index-write.c (write_address_map)
5558         (write_one_signatured_type, recursively_write_psymbols)
5559         (class debug_names, class debug_names, write_psymtabs_to_index):
5560         Update.
5561
5562 2019-01-10  Tom Tromey  <tom@tromey.com>
5563
5564         * symtab.h (SYMBOL_SET_NAMES): Update.
5565         (symbol_set_names): Update.
5566         (MSYMBOL_SET_NAMES): Update.
5567         * symtab.c (symbol_set_names): Change argument to be an
5568         objfile_per_bfd_storage.
5569         * psymtab.c (add_psymbol_to_bcache): Update.
5570         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5571
5572 2019-01-10  Tom Tromey  <tom@tromey.com>
5573
5574         * symtab.c (create_demangled_names_hash): Change argument to be an
5575         objfile_per_bfd_storage.
5576         (symbol_set_names): Update.
5577
5578 2019-01-10  Tom Tromey  <tom@tromey.com>
5579
5580         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5581         init_psymbol_list.
5582         * psymtab.c (init_psymbol_list): Do nothing if already called.
5583         * psympriv.h (init_psymbol_list): Add comment.
5584         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5585         init_psymbol_list.
5586         * dbxread.c (dbx_symfile_read): Unconditionally call
5587         init_psymbol_list.
5588
5589 2019-01-10  Tom Tromey  <tom@tromey.com>
5590
5591         * xcoffread.c (scan_xcoff_symtab): Update.
5592         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5593         "where".
5594         * mdebugread.c (parse_partial_symbols)
5595         (handle_psymbol_enumerators): Update.
5596         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5597         * dbxread.c (read_dbx_symtab): Update.
5598         * psympriv.h (psymbol_placement): New enum.
5599         (add_psymbol_to_list): Update.
5600
5601 2019-01-10  Tom Tromey  <tom@tromey.com>
5602
5603         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5604         static_psymbols parameters.
5605         (scan_xcoff_symtab): Update.
5606         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5607         static_psymbols parameters.
5608         * psympriv.h (start_psymtab_common): Update.
5609         * mdebugread.c (parse_partial_symbols): Update.
5610         * dwarf2read.c (create_partial_symtab): Update.
5611         * dbxread.c (read_dbx_symtab): Update.
5612         (start_psymtab): Remove global_psymbols and static_psymbols
5613         parameters.
5614
5615 2019-01-10  Tom Tromey  <tom@tromey.com>
5616
5617         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5618         * psymtab.c (allocate_psymtab): Add comment.
5619         * psympriv.h (allocate_psymtab): Add comment.
5620         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5621         initializations.
5622         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5623
5624 2019-01-10  Tom Tromey  <tom@tromey.com>
5625
5626         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5627         Don't declare.
5628         * mipsread.c: Include mdebugread.h.
5629         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5630         Declare.
5631         * elfread.c: Include mdebugread.h.
5632
5633 2019-01-09  Tom Tromey  <tom@tromey.com>
5634
5635         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5636         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5637         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5638         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5639         (psym_lookup_symbol, psym_find_last_source_symtab)
5640         (psym_forget_cached_source_info, psym_print_stats)
5641         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5642         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5643         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5644         (psym_find_compunit_symtab_by_address)
5645         (maintenance_print_psymbols, maintenance_info_psymtabs)
5646         (maintenance_check_psymtabs): Use ranged for.
5647         * psymtab.h (class objfile_psymtabs): New.
5648         (require_partial_symbols): Return objfile_psymtabs.
5649         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5650
5651 2019-01-09  Tom Tromey  <tom@tromey.com>
5652
5653         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5654         (find_pc_mapped_section, list_overlays_command)
5655         (map_overlay_command, unmap_overlay_command)
5656         (simple_overlay_update): Use all_objfiles.
5657         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5658         * printcmd.c (info_symbol_command): Use all_objfiles.
5659         * objfiles.h (ALL_OBJSECTIONS): Remove.
5660         * maint.c (maintenance_translate_address): Use all_objfiles.
5661         * gcore.c (gcore_create_callback): Use all_objfiles.
5662         (objfile_find_memory_regions): Likewise.
5663
5664 2019-01-09  Tom Tromey  <tom@tromey.com>
5665
5666         * symtab.c (find_line_symtab, info_sources_command)
5667         (make_source_files_completion_list): Use objfile_compunits.
5668         * source.c (select_source_symtab): Use objfile_compunits.
5669         * objfiles.h (struct objfile): Update comment.
5670         (ALL_OBJFILES): Remove.
5671         (ALL_FILETABS): Remove.
5672         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5673         objfile_compunits.
5674
5675 2019-01-09  Tom Tromey  <tom@tromey.com>
5676
5677         * symmisc.c (print_objfile_statistics, dump_objfile)
5678         (maintenance_print_symbols): Use compunit_filetabs.
5679         * source.c (forget_cached_source_info_for_objfile): Use
5680         compunit_filetabs.
5681         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5682         (ALL_FILETABS): Use compunit_filetabs.
5683         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5684         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5685
5686 2019-01-09  Tom Tromey  <tom@tromey.com>
5687
5688         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5689         (compunit_filetabs): New.
5690         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5691         compunit_filetabs.
5692         (info_sources_command, make_source_files_completion_list): Remove
5693         declaration.
5694         * symmisc.c (print_objfile_statistics, dump_objfile)
5695         (maintenance_print_symbols): Remove declaration.
5696         (maintenance_info_symtabs): Use compunit_filetabs.
5697         (maintenance_info_line_tables): Likewise.
5698         * source.c (select_source_symtab): Change local variable name.
5699         (forget_cached_source_info_for_objfile): Remove declaration.
5700         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5701         * objfiles.c (objfile_relocate1): Remove declaration.
5702         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5703         declaration.
5704         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5705         * coffread.c (coff_symtab_read): Remove declaration.
5706         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5707         compunit_filetabs.
5708
5709 2019-01-09  Tom Tromey  <tom@tromey.com>
5710
5711         * symtab.c (lookup_objfile_from_block)
5712         (find_pc_sect_compunit_symtab, search_symbols)
5713         (default_collect_symbol_completion_matches_break_on): Use
5714         objfile_compunits.
5715         * objfiles.h (ALL_COMPUNITS): Remove.
5716         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5717         * cp-support.c (add_symbol_overload_list_qualified): Use
5718         objfile_compunits.
5719         * ada-lang.c (ada_collect_symbol_completion_matches)
5720         (ada_add_global_exceptions): Use objfile_compunits.
5721
5722 2019-01-09  Tom Tromey  <tom@tromey.com>
5723
5724         * source.c (select_source_symtab)
5725         (forget_cached_source_info_for_objfile): Remove declaration.
5726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5727         declaration.
5728         * maint.c (count_symtabs_and_blocks): Remove declaration.
5729         * cp-support.c (add_symbol_overload_list_qualified): Remove
5730         declaration.
5731         * coffread.c (coff_symtab_read): Remove declaration.
5732         * symtab.c (lookup_symbol_in_objfile_symtabs)
5733         (basic_lookup_transparent_type_1): Use objfile_compunits.
5734         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5735         (info_sources_command, search_symbols)
5736         (default_collect_symbol_completion_matches_break_on)
5737         (make_source_files_completion_list): Remove declaration.
5738         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5739         (ada_collect_symbol_completion_matches)
5740         (ada_add_global_exceptions): Remove declaration.
5741         * linespec.c (iterate_over_all_matching_symtabs): Use
5742         objfile_compunits.
5743         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5744         (class objfile_compunits): New.
5745         (ALL_COMPUNITS): Use objfile_compunits.
5746         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5747         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5748         objfile_compunits.
5749         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5750
5751 2019-01-09  Tom Tromey  <tom@tromey.com>
5752
5753         * symtab.c (search_symbols)
5754         (default_collect_symbol_completion_matches_break_on): Use
5755         objfile_msymbols.
5756         * ada-lang.c (ada_lookup_simple_minsym)
5757         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5758         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5759         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5760         objfile_msymbols.
5761         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5762         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5763         * objc-lang.c (find_methods): Use objfile_msymbols.
5764         (info_selectors_command, info_classes_command): Likewise.
5765         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5766         * objfiles.h (class objfile_msymbols): New.
5767         (ALL_OBJFILE_MSYMBOLS): Remove.
5768         (ALL_MSYMBOLS): Remove.
5769
5770 2019-01-09  Tom Tromey  <tom@tromey.com>
5771
5772         * common/next-iterator.h (next_adapter): Add Iterator template
5773         parameter.
5774         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5775         (class all_objfiles_safe): New.
5776         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5777         * objfiles.c (put_objfile_before): Update comment.
5778         (add_separate_debug_objfile): Likewise.
5779         (free_all_objfiles): Use all_objfiles_safe.
5780         (objfile_purge_solibs): Likewise.
5781
5782 2019-01-09  Tom Tromey  <tom@tromey.com>
5783
5784         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5785         (expand_symtab_containing_pc, lookup_static_symbol)
5786         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5787         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5788         all_objfiles.
5789         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5790         * breakpoint.c (create_overlay_event_breakpoint)
5791         (create_longjmp_master_breakpoint)
5792         (create_std_terminate_master_breakpoint)
5793         (create_exception_master_breakpoint): Use all_objfiles.
5794         * linux-thread-db.c (try_thread_db_load_from_pdir)
5795         (has_libpthread): Use all_objfiles.
5796         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5797         * linespec.c (iterate_over_all_matching_symtabs)
5798         (search_minsyms_for_name): Use all_objfiles.
5799         * maint.c (maintenance_info_sections): Use all_objfiles.
5800         * main.c (captured_main_1): Use all_objfiles.
5801         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5802         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5803         * guile/scm-pretty-print.c
5804         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5805         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5806         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5807         (maintenance_print_msymbols): Use all_objfiles.
5808         * source.c (select_source_symtab): Use all_objfiles.
5809         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5810         * symfile.c (remove_symbol_file_command)
5811         (expand_symtabs_matching, map_symbol_filenames): Use
5812         all_objfiles.
5813         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5814         all_objfiles.
5815         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5816         * objc-lang.c (find_methods): Use all_objfiles.
5817         * objfiles.c (have_partial_symbols, have_full_symbols)
5818         (have_minimal_symbols, qsort_cmp)
5819         (default_iterate_over_objfiles_in_search_order): Use
5820         all_objfiles.
5821         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5822         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5823         (maintenance_check_psymtabs): Use all_objfiles.
5824         (ALL_PSYMTABS): Remove.
5825         * compile/compile-object-run.c (do_module_cleanup): Use
5826         all_objfiles.
5827         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5828         * cp-support.c (add_symbol_overload_list_qualified): Use
5829         all_objfiles.
5830         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5831         Use all_objfiles.
5832         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5833         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5834         all_objfiles.
5835         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5836         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5837         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5838         Uses all_objfiles.
5839         * solib.c (solib_read_symbols): Use all_objfiles
5840
5841 2019-01-09  Tom Tromey  <tom@tromey.com>
5842
5843         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5844         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5845         all_objfiles.
5846         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5847         * symmisc.c (print_symbol_bcache_statistics)
5848         (print_objfile_statistics, maintenance_print_objfiles)
5849         (maintenance_info_symtabs, maintenance_check_symtabs)
5850         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5851         all_objfiles.
5852         * source.c (forget_cached_source_info): Use all_objfiles.
5853         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5854         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5855         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5856         * objfiles.c (update_section_map): Use all_objfiles.
5857         (shared_objfile_contains_address_p): Likewise.
5858         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5859         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5860
5861 2019-01-09  Tom Tromey  <tom@tromey.com>
5862
5863         * common/next-iterator.h: New file.
5864         * objfiles.h (class all_objfiles): New.
5865         (struct objfile_iterator): New.
5866
5867 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5868
5869         * NEWS: Move the description of the changed "frame", "select-frame",
5870          and "info frame" commands to the Changed commands section.
5871
5872 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5873
5874         * gdbtypes.c (check_stub_method_group): Remove handling of old
5875         mangling schemes.
5876         * linespec.c (find_methods): Likewise.
5877         * stabsread.c (read_member_functions): Likewise.
5878         * valops.c (search_struct_method): Likewise.
5879         (value_struct_elt_for_reference): Likewise.
5880         * NEWS: Mention this change.
5881
5882 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5885         print_source_lines.
5886         * source.c (print_source_lines_base): Update line number check.
5887         (print_source_lines): New function.
5888         (source_lines_range::source_lines_range): New function.
5889         * source.h (class source_lines_range): New class.
5890         (print_source_lines): New declaration.
5891
5892 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5893
5894         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5895
5896 2019-01-08  Tom Tromey  <tom@tromey.com>
5897             Simon Marchi  <simon.marchi@ericsson.com>
5898
5899         PR gdb/24060
5900         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5901         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5902         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5903         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5904         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5905         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5906
5907 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5908
5909         * source.c (select_source_symtab): Move header comment to
5910         declaration in source.h.
5911         (forget_cached_source_info_for_objfile): Likewise.
5912         (forget_cached_source_info): Likewise.
5913         (identify_source_line): Likewise.
5914         * source.h (identify_source_line): Move declaration from symtab.h
5915         and add comment from source.c
5916         (print_source_lines): Likewise.
5917         (forget_cached_source_info_for_objfile): Likewise.
5918         (forget_cached_source_info): Likewise.
5919         (select_source_symtab): Likewise.
5920         (enum print_source_lines_flag): Move definition from symtab.h.
5921         * symtab.h (identify_source_line): Move declaration to source.h.
5922         (print_source_lines): Likewise.
5923         (forget_cached_source_info_for_objfile): Likewise.
5924         (forget_cached_source_info): Likewise.
5925         (select_source_symtab): Likewise.
5926         (enum print_source_lines_flag): Move definition to source.h.
5927         * tui/tui-hooks.c: Add 'source.h' include.
5928
5929 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5930
5931         * source.c (print_source_lines_base): Handle requests to print
5932         reverse line number sequences, and guard against empty lines
5933         string.
5934
5935 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5936
5937         * source.c (print_source_lines_base): Fix skip of '\r' if next
5938         character is '\n'.
5939
5940 2019-01-06  Tom Tromey  <tom@tromey.com>
5941
5942         * c-exp.y (struct c_parse_state) <macro_original_text,
5943         expansion_obstack>: New member.
5944         (macro_original_text, expansion_obstack): Remove globals.
5945         (scan_macro_expansion, scanning_macro_expansion)
5946         (finished_macro_expansion): Update.
5947         (scan_macro_cleanup): Remove.
5948         (yylex, c_parse): Update.
5949
5950 2019-01-06  Tom Tromey  <tom@tromey.com>
5951
5952         * c-exp.y (struct c_parse_state) <strings>: New member.
5953         (operator_stoken): Update.
5954
5955 2019-01-06  Tom Tromey  <tom@tromey.com>
5956
5957         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5958         (union type_stack_elt) <typelist_val>: Now a pointer to
5959         std::vector.
5960         (type_stack_cleanup): Don't declare.
5961         (push_typelist): Update.
5962         * parse.c (pop_typelist): Return a std::vector.
5963         (push_typelist): Take a std::vector.
5964         (follow_types): Update.  Do not free args.
5965         (type_stack_cleanup): Remove.
5966         * c-exp.y (struct c_parse_state): New.
5967         (cpstate): New global.
5968         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5969         (nonempty_typelist): Update.
5970         (func_mod): Create a new vector.
5971         (c_parse): Create a c_parse_state.
5972         (check_parameter_typelist): Do not delete params.
5973         (function_method): Update.  Do not delete type_list.
5974
5975 2019-01-06  Tom Tromey  <tom@tromey.com>
5976
5977         PR gdb/28155:
5978         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5979         check_typedef.
5980         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5981         (print_return_value): Likewise.
5982
5983 2019-01-05  Tom Tromey  <tom@tromey.com>
5984
5985         * contrib/cleanup_check.py: Remove.
5986         * contrib/gcc-with-excheck: Remove.
5987         * contrib/exsummary.py: Remove.
5988         * contrib/excheck.py: Remove.
5989
5990 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5991
5992         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5993         NULL. Initialize tpprev to NULL instead of assigning it
5994         to NULL on the next statement.
5995         * windows-nat.c (windows_delete_thread): Remove check for
5996         main_thread_id before printing thread exit notifications.
5997         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5998         Remove thread ID check against main_thread_id.
5999         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6000         windows_delete_thread.
6001         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6002
6003 2019-01-04  Tom Tromey  <tom@tromey.com>
6004
6005         * compile/compile.c (_initialize_compile): Use upper case for
6006         metasyntactic variables.
6007         * symmisc.c (_initialize_symmisc): Use upper case for
6008         metasyntactic variables.
6009         * psymtab.c (_initialize_psymtab): Use upper case for
6010         metasyntactic variables.
6011         * demangle.c (demangle_command): Use upper case for metasyntactic
6012         variables.
6013         (_initialize_demangler): Likewise.
6014         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6015         variables.
6016
6017 2019-01-03  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6020
6021 2019-01-03  Tom Tromey  <tom@tromey.com>
6022
6023         * python/py-symtab.c (salpy_str): Update.
6024         (struct salpy_sal_object) <symtab>: Now a PyObject.
6025         (salpy_dealloc): Update.
6026         (del_objfile_sal): Use gdbpy_ref.
6027
6028 2019-01-03  Tom Tromey  <tom@tromey.com>
6029
6030         * python/py-type.c (convert_field): Use new_reference.  Return
6031         gdbpy_ref.
6032         (make_fielditem): Return gdbpy_ref.
6033         (typy_fields): Update.
6034         (typy_getitem): Update.
6035         (field_name): Return gdbpy_ref.  Use new_reference.
6036         (typy_iterator_iternext): Update.
6037
6038 2019-01-03  Tom Tromey  <tom@tromey.com>
6039
6040         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6041
6042 2019-01-03  Tom Tromey  <tom@tromey.com>
6043
6044         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6045         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6046         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6047         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6048         (pspy_set_type_printers): Likewise.
6049         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6050         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6051         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6052         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6053         (objfpy_set_type_printers): Likewise.
6054
6055 2019-01-03  Tom Tromey  <tom@tromey.com>
6056
6057         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6058         (gdbpy_print_stack): Use gdbpy_err_fetch.
6059         * python/python-internal.h (class gdbpy_err_fetch): New class.
6060         (class gdbpy_enter) <m_error_type, m_error_value,
6061         m_error_traceback>: Remove.
6062         <m_error>: New member.
6063         (gdbpy_exception_to_string): Don't declare.
6064         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6065         * python/py-value.c (convert_value_from_python): Use
6066         gdbpy_err_fetch.
6067         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6068         gdbpy_exception_to_string.
6069         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6070         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6071         gdbpy_err_fetch.
6072
6073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * linux-nat.c (delete_lwp_cleanup): Delete.
6076         (struct lwp_deleter): New struct.
6077         (lwp_info_up): New typedef.
6078         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6079         lwp_info_up.
6080
6081 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6082
6083         * linux-fork.c (class scoped_switch_fork_info): New class.
6084         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6085
6086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * valops.c (find_overload_match): Remove use of null_cleanup, and
6089         calls to do_cleanups.
6090
6091 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * compile/compile-cplus-types.c
6094         (compile_cplus_instance::decl_name): Handle changes to
6095         cp_func_name.
6096         * cp-support.c (cp_func_name): Update header comment, update
6097         return type.
6098         * cp-support.h (cp_func_name): Update return type in declaration.
6099         * valops.c (find_overload_match): Move temp_func local to top
6100         level of function and change its type.  Use temp_func to hold and
6101         delete temporary string obtained from cp_func_name.
6102
6103 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6106         gdb::char_vector, remove cleanup, and update uses of `msg`.
6107
6108 2019-01-03  Jim Wilson  <jimw@sifive.com>
6109
6110         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6111
6112 2019-01-02  Tom Tromey  <tom@tromey.com>
6113
6114         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6115         (tdesc_parse_xml): Remove cleanups.
6116         * target-descriptions.h (make_cleanup_free_target_description):
6117         Don't declare.
6118         (target_desc_deleter): New struct.
6119         (target_desc_up): New typedef.
6120         * target-descriptions.c (target_desc_deleter::operator()): Rename
6121         from free_target_description.
6122         (make_cleanup_free_target_description): Remove.
6123
6124 2019-01-02  Tom Tromey  <tom@tromey.com>
6125
6126         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6127         constructor, destructor.
6128         (linespec_parser): Remove typedef.
6129         (~linespec_parser): Rename from linespec_parser_delete.
6130         (linespec_lex_to_end, linespec_complete_label)
6131         (linespec_complete): Update.
6132         (decode_line_full): Remove cleanups.
6133         (decode_line_1): Update.
6134
6135 2019-01-02  Tom Tromey  <tom@tromey.com>
6136
6137         * python/python-internal.h (inferior_to_inferior_object): Change
6138         return type.
6139         * python/py-exitedevent.c (create_exited_event_object): Update.
6140         * python/py-inferior.c (inferior_to_inferior_object): Return
6141         gdbpy_ref.
6142         (python_new_inferior, python_inferior_deleted)
6143         (thread_to_thread_object, delete_thread_object)
6144         (build_inferior_list, gdbpy_selected_inferior): Update.
6145         * python/py-infthread.c (create_thread_object): Update.  Also fail
6146         if inferior_to_inferior_object fails.
6147
6148 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6149
6150         * inferior.h (class inferior) <displaced_step_state>: New field.
6151         * infrun.h (struct displaced_step_state): Move here from
6152         infrun.c.  Initialize fields, add constructor.
6153         <inf>: Remove field.
6154         <reset>: New method.
6155         * infrun.c (struct displaced_step_inferior_state): Move to
6156         infrun.h.
6157         (displaced_step_inferior_states): Remove.
6158         (get_displaced_stepping_state): Adust.
6159         (displaced_step_in_progress_any_inferior): Adjust.
6160         (displaced_step_in_progress_thread): Adjust.
6161         (displaced_step_in_progress): Adjust.
6162         (add_displaced_stepping_state): Remove.
6163         (get_displaced_step_closure_by_addr): Adjust.
6164         (remove_displaced_stepping_state): Remove.
6165         (infrun_inferior_exit): Call displaced_step_state.reset.
6166         (use_displaced_stepping): Don't check for NULL.
6167         (displaced_step_prepare_throw): Call
6168         get_displaced_stepping_state.
6169         (displaced_step_fixup): Don't check for NULL.
6170         (prepare_for_detach): Don't check for NULL.
6171
6172 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6175          in case of call that did not complete.
6176
6177 2019-01-02  Andrey Utkin  <autkin@undo.io>
6178
6179         * symfile.c (find_separate_debug_file): Fix search of debug files for
6180         remote debuggee.
6181
6182 2019-01-02  Tom Tromey  <tom@tromey.com>
6183
6184         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6185         indentation.
6186         * python/py-frame.c (frapy_older): Remove cast.
6187         (frapy_newer): Likewise.
6188         * python/py-breakpoint.c (local_setattro): Remove cast.
6189         * python/py-arch.c (archpy_name): Remove local variable.
6190         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6191
6192 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6193
6194         * unittests/basic_string_view/element_access/char/empty.cc:
6195         Fix year range in copyright header.
6196
6197 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6200         Delete.
6201         <operator==>: Update with for removed field.
6202         <hash>: Likewise.
6203         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6204         <isa_features>: ...this.
6205         <abi_features>: New field.
6206         (riscv_isa_flen): Update comment.
6207         (riscv_abi_xlen): New declaration.
6208         (riscv_abi_flen): New declaration.
6209         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6210         isa_features.
6211         (riscv_abi_xlen): New function.
6212         (riscv_isa_flen): Update to get answer from isa_features.
6213         (riscv_abi_flen): New function.
6214         (riscv_has_fp_abi): Update to get answer from abi_features.
6215         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6216         xlen and flen.
6217         (riscv_call_info) <xlen, flen>: Update comment.
6218         (riscv_call_arg_struct): Remove invalid assertions
6219         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6220         is removed.
6221         (riscv_gdbarch_init): Gather isa features and abi features
6222         separately, ensure both match on the gdbarch when reusing an old
6223         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6224         a target with 64-bit float hardware.
6225
6226 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6227
6228         * source.c (search_command_helper): Stop reverse search
6229         when line 1 has been searched.
6230
6231 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * record-full.c (record_full_base_target::close): Rewrite
6234         record_full_core_buf_list free logic.
6235
6236 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6237
6238         * break-catch-syscall.c (print_one_catch_syscall): xfree
6239         the last text.
6240
6241 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6242
6243         * top.c (print_gdb_version): Update Copyright year in version
6244         message.
6245
6246 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6247
6248         Update copyright year range in all GDB files.
6249
6250 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6251
6252         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6253
6254 For older changes see ChangeLog-2018.
6255 \f
6256 Local Variables:
6257 mode: change-log
6258 left-margin: 8
6259 fill-column: 74
6260 version-control: never
6261 coding: utf-8
6262 End:
6263