Make gdb_flush also flush the wrap buffer
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
2
3 * gdb/event-loop.c (gdb_wait_for_event): Update.
4 * gdb/printcmd.c (printf_command): Update.
5 * gdb/remote-fileio.c (remote_fileio_func_write): Update.
6 * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
7 (gdb_os_flush_stderr): Update.
8 * gdb/remote.c (remote_console_output): Update.
9 * gdb/ui-file.c (gdb_flush): Rename to...
10 (ui_file_flush): ...this.
11 (stderr_file::write): Update.
12 (stderr_file::puts): Update.
13 * gdb/ui-file.h (gdb_flush): Rename to...
14 (ui_file_flush): ...this.
15 * gdb/utils.c (gdb_flush): Add function.
16 * gdb/utils.h (gdb_flush): Add declaration.
17
18 2020-02-07 Tom Tromey <tromey@adacore.com>
19
20 PR breakpoints/24915:
21 * source.c (find_and_open_source): Do not check basenames_may_differ.
22
23 2020-01-10 Christian Biesinger <cbiesinger@google.com>
24
25 * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
26
27 2020-01-07 Tom Tromey <tromey@adacore.com>
28
29 PR build/24937:
30 * stap-probe.c (class stap_static_probe_ops): Add constructor.
31
32 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
33
34 * stack.c (print_frame_info): Move disassemble_next_line code
35 inside source_print block.
36
37 2020-01-01 Joel Brobecker <brobecker@adacore.com>
38
39 * gdbarch.sh: Update copyright year range of generated files.
40
41 2020-01-01 Joel Brobecker <brobecker@adacore.com>
42
43 Update copyright year range in all the GDB files automatically
44 handled by our copyright.py script.
45
46 2020-01-01 Joel Brobecker <brobecker@adacore.com>
47
48 * copyright.py: Convert to Python 3.
49
50 2020-01-01 Joel Brobecker <brobecker@adacore.com>
51
52 * copyright.py: Adapt after move of gnulib directory from gdb
53 directory to toplevel directory.
54
55 2020-01-01 Joel Brobecker <brobecker@adacore.com>
56
57 * copyright.py (main): Exit if run from the wrong directory.
58
59 2020-01-01 Joel Brobecker <brobecker@adacore.com>
60
61 * top.c (print_gdb_version): Change copyright year to 2020.
62
63 2019-12-26 Christian Biesinger <cbiesinger@google.com>
64
65 * configure: Regenerate.
66 * configure.ac: Quote variable arguments of test.
67 * gdbsupport/common.m4: Likewise.
68
69 2019-12-21 Eli Zaretskii <eliz@gnu.org>
70
71 * top.c (print_gdb_configuration): Print "--with-xxhash" or
72 "--without-xxhash" according to HAVE_LIBXXHASH.
73
74 2019-12-18 Tom Tromey <tromey@adacore.com>
75
76 PR build/25268:
77 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
78 type on macOS. Add comment.
79
80 2019-12-18 Tom Tromey <tromey@adacore.com>
81
82 PR build/25250:
83 * ui-out.c (ui_out::vmessage): Update.
84 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
85 Rename.
86 (string_field): Update.
87 (signed_field): Update.
88
89 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
90
91 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
92
93 2019-12-11 Joel Brobecker <brobecker@adacore.com>
94
95 * version.in: Set GDB version number to 9.0.90.DATE-git.
96
97 2019-12-11 Joel Brobecker <brobecker@adacore.com>
98
99 GDB 9.0.90 released.
100
101 2019-12-11 Joel Brobecker <brobecker@adacore.com>
102
103 * version.in: Set GDB version number to 9.0.90.
104
105 2019-12-11 Joel Brobecker <brobecker@adacore.com>
106
107 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
108
109 2019-12-11 Joel Brobecker <brobecker@adacore.com>
110
111 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
112 * version.in: Bump version to 9.0.90.DATE-git.
113
114 2019-12-11 Tom Tromey <tromey@adacore.com>
115
116 PR build/25268:
117 * gdbsupport/thread-pool.c (set_thread_name): New function.
118 (thread_pool::set_thread_count): Don't call pthread_setname_np.
119 (thread_pool::thread_function): Call set_thread_name.
120
121 2019-12-11 Tom Tromey <tromey@adacore.com>
122
123 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
124 bfd_get_signed_8.
125
126 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
127
128 * NEWS: Document -raw-values option and the related setting commands.
129 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
130 only set it on when /r is given.
131 * valprint.c (value_print_option_defs): New element raw-values.
132 * Makefile.in: Add the new file.
133
134 2019-12-10 Christian Biesinger <cbiesinger@google.com>
135
136 * gdbsupport/safe-strerror.c: Supress the unused function warning
137 for select_strerror_r.
138
139 2019-12-10 Christian Biesinger <cbiesinger@google.com>
140
141 * config.in: Regenerate.
142 * configure: Regenerate.
143 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
144 safe_strerror instead of strerror.
145 * gdbsupport/common.m4: Don't check for strerror.
146 * gdbsupport/safe-strerror.c: Support both the glibc version
147 of strerror_r and the XSI version.
148
149 2019-12-10 Tom Tromey <tromey@adacore.com>
150
151 * ada-typeprint.c (print_choices): Use a single "?".
152 (print_variant_part): Print "?" if the discriminant name
153 is not known.
154
155 2019-12-10 George Barrett <bob@bob131.so>
156
157 Fix scripted probe breakpoints.
158 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
159 declaration forward.
160 (breakpoint_ops_for_event_location_type)
161 (breakpoint_ops_for_event_location): Add function definitions.
162 (break_command_1, trace_command): Use
163 breakpoint_ops_for_event_location.
164 * breakpoint.h (breakpoint_ops_for_event_location): Add function
165 declarations.
166 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
167 breakpoint_ops_for_event_location.
168 * python/py-breakpoint.c (bppy_init): Use
169 breakpoint_ops_for_event_location.
170
171 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
172
173 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
174 when ranking an lvalue argument for an rvalue parameter.
175
176 2019-12-08 Wataru Ashihara <wataash@wataash.com>
177
178 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
179 template argument for scoped_restore_tmpl from bool to int.
180
181 2019-12-07 Keith Seitz <keiths@redhat.com>
182
183 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
184 (build_id_to_debug_bfd): Make static, rewriting to use
185 build_id_to_bfd_suffix.
186 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
187 adding `suffix' parameter. Append SUFFIX to file names
188 when searching for matching files.
189 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
190 (build_id_to_exec_bfd): Likewise.
191 * build-id.h (build_id_to_debug_bfd): Clarify that function
192 searches for BFD of debug info file.
193 (build_id_to_exec_bfd): Declare.
194 * corelow.c: Include build-id.h.
195 (locate_exec_from_corefile_build_id): New function.
196 (core_target_open): If no executable BFD is found,
197 search for a core file BFD using build-id.
198
199 2019-12-06 Christian Biesinger <cbiesinger@google.com>
200
201 * bcache.c: Put in namespace gdb.
202 * bcache.h: Likewise.
203 * gdbtypes.c (check_types_worklist): Update.
204 (types_deeply_equal): Update.
205 * macrotab.c (struct macro_table) <bcache>: Update.
206 (new_macro_table): Update.
207 * macrotab.h (struct bcache): Put this forward declaration
208 inside namespace gdb.
209 (new_macro_table): Update.
210 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
211 Update.
212 <macro_cache>: Update.
213 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
214
215 2019-12-06 Tom de Vries <tdevries@suse.de>
216
217 PR symtab/24971
218 * block.c (best_symbol, better_symbol): New function.
219 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
220 decl.
221
222 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
223
224 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
225 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
226 for ranking see-through reference cases.
227
228 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
229 * stack.c (faas_command): Check a command is provided.
230 * thread.c (taas_command, tfaas_command): Likewise.
231
232 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
233 * inferior.c (prune_inferiors): Only call delete_inferior,
234 Do not modify the inferior list.
235
236 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
237
238 * c-exp.y: Update calls to lookup_typename,
239 lookup_signed_typename and lookup_unsigned_typename.
240 * c-lang.c (evaluate_subexp_c): Likewise.
241 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
242 Likewise.
243 * eval.c (binop_promote): Likewise.
244 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
245 (lookup_unsigned_typename): Likewise.
246 (lookup_signed_typename): Likewise.
247 * gdbtypes.h (lookup_unsigned_typename): Likewise.
248 (lookup_signed_typename): Likewise.
249 (lookup_typename): Likewise.
250 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
251 lookup_typename, lookup_signed_typename,
252 lookup_unsigned_typename.
253 * m2-exp.y: Likewise.
254 * printcmd.c (printf_wide_c_string): Likewise.
255 (ui_printf): Likewise.
256 * python/py-type.c (typy_lookup_typename): Likewise.
257 * python/py-xmethods.c (python_xmethod_worker::invoke):
258 Likewise.
259 * rust-exp.y: Likewise.
260
261 2019-12-04 Christian Biesinger <cbiesinger@google.com>
262
263 * configure.nat (obsd64): Add missing files x86-nat.o and
264 nat/x86-dregs.o.
265
266 2019-12-04 Tom Tromey <tom@tromey.com>
267
268 * valprint.c (val_print_string): Use metadata_style.
269 * go-valprint.c (print_go_string): Use metadata style.
270 * p-valprint.c (pascal_object_print_static_field): Use metadata
271 style.
272 * cp-valprint.c (cp_print_static_field): Use metadata style.
273
274 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
275 Chris January <chris.january@arm.com>
276
277 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
278 tokens.
279 (typebase): New patterns for complex, single/double precision, and
280 single/double complex.
281 (f77_keywords): Change token for complex keyword, and add single,
282 double, and precision keywords.
283
284 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
285
286 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
287 "info io_registers".
288
289 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
290
291 * regcache.c (cooked_read_test): Initialize thread list of
292 mock_inferior.
293
294 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
295
296 * aarch64-linux-tdep.c: Remove includes.
297
298 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
299
300 * aarch64-tdep.c: Remove includes.
301
302 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
303
304 * filtered-iterator.h (filtered_iterator) <operator==,
305 operator!=>: Compare wrapped iterators, not wrapped pointers.
306 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
307 unittests/filtered_iterator-selftests.c.
308 * unittests/filtered_iterator-selftests.c: New file.
309
310 2019-12-04 Tom Tromey <tromey@adacore.com>
311
312 * gdbtypes.c (create_range_type): Inherit endianity
313 from base type.
314
315 2019-12-04 Tom Tromey <tromey@adacore.com>
316
317 * ada-lang.c (decode_constrained_packed_array)
318 (ada_value_assign, value_assign_to_component): Update.
319 * dwarf2loc.c (rw_pieced_value, access_memory)
320 (dwarf2_compile_expr_to_ax): Update.
321 * dwarf2read.c (dwarf2_add_field): Update.
322 * eval.c (evaluate_subexp_standard): Update.
323 * gdbarch.c, gdbarch.h: Rebuild.
324 * gdbarch.sh (bits_big_endian): Remove.
325 * gdbtypes.h (union field_location): Update comment.
326 * target-descriptions.c (make_gdb_type): Update.
327 * valarith.c (value_bit_index): Update.
328 * value.c (struct value) <bitpos>: Update comment.
329 (unpack_bits_as_long, modify_field): Update.
330 * value.h (value_bitpos): Update comment.
331
332 2019-12-04 Tom Tromey <tromey@adacore.com>
333
334 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
335 endian-ness.
336
337 2019-12-04 Tom Tromey <tromey@adacore.com>
338
339 * dwarf2read.c (dwarf2_init_float_type)
340 (dwarf2_init_complex_target_type): Add byte_order parameter.
341 (read_base_type): Compute byte order earlier.
342 * gdbtypes.c (init_float_type): Add byte_order parameter.
343 * gdbtypes.h (init_float_type): Add byte_order parameter.
344
345 2019-12-04 Tom Tromey <tromey@adacore.com>
346
347 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
348
349 2019-12-04 Tom Tromey <tromey@adacore.com>
350
351 * dwarf2read.c (process_structure_scope): Initialize
352 "discr_offset".
353
354 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
355
356 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
357 add it into the search spec.
358 (parse_max_results_option): New function.
359 (mi_info_functions_or_variables): Parse -max-results flag and pass
360 it to mi_symbol_info.
361 (mi_cmd_symbol_info_modules): Likewise.
362 (mi_cmd_symbol_info_types): Likewise.
363 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
364 return type to bool, change result container into a set, and don't
365 add new results if we have enough already.
366 (global_symbol_searcher::add_matching_msymbols): Change return
367 type to bool, and don't add new results if we have enough already.
368 (sort_search_symbols_remove_dups): Delete.
369 (global_symbol_searcher::search): Early exit from search loop when
370 we have enough results. Use a std::set to collect the results
371 from calling add_matching_symbols.
372 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
373 member function.
374 (global_symbol_searcher) <m_max_search_results>: New member
375 variable.
376 (global_symbol_searcher) <add_matching_symbols>: Update header
377 comment and change return type to bool.
378 (global_symbol_searcher) <add_matching_msymbols>: Update header
379 comment and change return type to bool.
380
381 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
382
383 * symtab.c (symbol_search::compare_search_syms): Update header
384 comment.
385 (global_symbol_searcher::is_suitable_msymbol): New function.
386 (global_symbol_searcher::expand_symtabs): New function.
387 (global_symbol_searcher::add_matching_symbols): New function.
388 (global_symbol_searcher::add_matching_msymbols): New function.
389 (global_symbol_searcher::search): Move most of the content
390 into the new functions above, and call them as needed.
391 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
392 function.
393 (global_symbol_searcher) <add_matching_symbols>: New member
394 function.
395 (global_symbol_searcher) <add_matching_msymbols>: New member
396 function.
397 (global_symbol_searcher) <is_suitable_msymbol>: New member
398 function.
399
400 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
401
402 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
403 -symbol-info-module-variables entries.
404 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
405 (mi_cmd_symbol_info_module_variables): Declare.
406 * mi/mi-symbol-cmds.c
407 (module_symbol_search_iterator): New typedef.
408 (output_module_symbols_in_single_module_and_file): New function.
409 (output_module_symbols_in_single_module): New function.
410 (mi_info_module_functions_or_variables): New function.
411 (mi_cmd_symbol_info_module_functions): New function.
412 (mi_cmd_symbol_info_module_variables): New function.
413 * NEWS: Mention new MI command.
414
415 2019-12-03 Christian Biesinger <cbiesinger@google.com>
416
417 * bcache.c (hash): Remove.
418 (hash_continue): Remove.
419 * bcache.h (hash): Remove.
420 (hash_continue): Remove.
421 (struct bcache) <ctor>: Update.
422 * psymtab.c (psymbol_hash): Update.
423 * stabsread.c (hashname): Update.
424 * utils.h (fast_hash): Add an argument for a start value,
425 defaulting to zero.
426
427 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
428 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
429 (destroy_block_symbol_cache): New function.
430 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
431 (resize_symbol_cache): Likewise.
432
433 2019-12-02 Tom Tromey <tom@tromey.com>
434
435 * unittests/tui-selftests.c (run_tests): Make conditional.
436 (_initialize_tui_selftest): Make conditional.
437
438 2019-12-02 Christian Biesinger <cbiesinger@google.com>
439
440 * aix-thread.c (debug_aix_thread): Change type to bool.
441
442 2019-12-02 Luis Machado <luis.machado@linaro.org>
443
444 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
445
446 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
447
448 * dwarf2read.c (read_tag_string_type): Read the fields required to
449 make a dynamic string, and possibly create a dynamic range for the
450 string.
451 (attr_to_dynamic_prop): Setup is_reference based on the type of
452 attribute being processed.
453 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
454 (resolve_dynamic_array): Rename to...
455 (resolve_dynamic_array_or_string): ...this, update header comment,
456 and accept TYPE_CODE_STRING.
457 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
458
459 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
460
461 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
462 of its implementation from...
463 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
464 the new function.
465
466 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
467
468 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
469 create a range with stride where appropriate.
470 * f-valprint.c: Include 'gdbarch.h'.
471 (f77_print_array_1): Take the stride into account when walking the
472 array. Also convert the stride into addressable units.
473 * gdbtypes.c (create_range_type): Initialise the stride to
474 constant zero.
475 (create_range_type_with_stride): New function, initialise the
476 range as normal, and then setup the stride.
477 (has_static_range): Include the stride here. Also change the
478 return type to bool.
479 (create_array_type_with_stride): Consider the range stride if the
480 array isn't given its own stride.
481 (resolve_dynamic_range): Resolve the stride if needed.
482 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
483 (struct range_bounds) <flag_is_byte_stride>: New member variable.
484 (TYPE_BIT_STRIDE): Define.
485 (TYPE_ARRAY_BIT_STRIDE): Define.
486 (create_range_type_with_stride): Declare.
487 * valarith.c (value_subscripted_rvalue): Take range stride into
488 account when walking the array.
489
490 2019-12-01 Tom Tromey <tom@tromey.com>
491
492 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
493 specially.
494
495 2019-12-01 Tom Tromey <tom@tromey.com>
496
497 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
498 \0.
499 * unittests/tui-selftests.c: New file.
500 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
501
502 2019-12-01 Tom Tromey <tom@tromey.com>
503
504 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
505
506 2019-12-01 Tom Tromey <tom@tromey.com>
507
508 * NEWS: Document new settings.
509 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
510 * tui/tui-win.c (_initialize_tui_win): Add border style
511 observers.
512 * tui/tui-io.h (tui_apply_style): Declare.
513 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
514 longer static.
515 (apply_ansi_escape, tui_set_reverse_mode): Update.
516 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
517 Add "skip_intensity" parameter.
518 <changed>: New member.
519 <do_set_value>: Declare.
520 (tui_border_style, tui_active_border_style): Declare.
521 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
522 globals.
523 (cli_style_option): Initialize "changed".
524 (cli_style_option::do_set_value): New function.
525 (cli_style_option::add_setshow_commands): Add "skip_intensity"
526 parameter. Update.
527 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
528 (_initialize_cli_style): Update. Create TUI border style
529 commands.
530
531 2019-12-01 Tom Tromey <tom@tromey.com>
532
533 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
534 parameter.
535 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
536 parameter.
537 * tui/tui-win.h (compact_source): Declare.
538 * tui/tui-win.c (compact_source): New global.
539 (tui_set_compact_source, tui_show_compact_source): New functions.
540 (_initialize_tui_win): Add "compact-source" setting.
541 * tui/tui-source.c (tui_source_window::set_contents): Handle
542 compact_source setting.
543 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
544 * NEWS: Document new setting.
545
546 2019-11-30 Tom Tromey <tom@tromey.com>
547
548 * dwarf2read.c (dwarf2_add_field): Include field offset when
549 computing variant part length.
550
551 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
552 * NEWS: Mention define-prefix. Tell that command names can now
553 contain a . character.
554
555 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
556
557 * command.h (valid_cmd_char_p): Declare.
558 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
559 the check of valid command char.
560 (find_command_name_length, valid_user_defined_cmd_name_p): Use
561 valid_cmd_char_p.
562 * cli/cli-script.c (validate_comname): Likewise.
563 * completer.c (gdb_completer_command_word_break_characters):
564 Do not remove . from the word break char, update comments.
565 (complete_line_internal_1): Use valid_cmd_char_p.
566 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
567 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
568
569 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
570
571 * cli/cli-script.c (do_define_command): Ensure a redefined
572 prefix command is kept as a prefix command.
573 (define_prefix_command): New function.
574 (show_user_1): Report user defined prefixes.
575 (_initialize_cli_script): Create the new 'define-prefix' command.
576 Add completers for 'define' and 'document'.
577 * top.c (execute_command): If command is a user-defined prefix only
578 command, report the list of commands for this prefix command.
579
580 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
581
582 * valops.c (find_oload_champ): Improve debug output.
583
584 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
585
586 * valops.c (find_oload_champ): Print part of debug messages
587 before the badness vector is std::move'd.
588
589 2019-11-28 Tom Tromey <tom@tromey.com>
590
591 * value.c (creal_internal_fn): Fix comment.
592
593 2019-11-28 Tom Tromey <tom@tromey.com>
594
595 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
596 flag_bound_evaluated>: Now unsigned.
597
598 2019-11-28 Tom Tromey <tom@tromey.com>
599
600 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
601 declare.
602
603 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
604
605 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
606 debug output.
607 * jit.c (jit_unregister_code): Add debug print to match
608 `jit_register_code`.
609
610 2019-11-27 Christian Biesinger <cbiesinger@google.com>
611
612 * NEWS: Mention the new multithreaded symbol loading.
613
614 2019-11-27 Christian Biesinger <cbiesinger@google.com>
615
616 * maint.c (n_worker_threads): Default to 0.
617 (worker_threads_disabled): New function.
618 * maint.h (worker_threads_disabled): New function.
619 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
620 here if worker_threads_disabled () is true.
621 (minimal_symbol_reader::install): Skip all threading if
622 worker_threads_disabled () is true.
623
624 2019-11-27 Christian Biesinger <cbiesinger@google.com>
625
626 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
627 hash code if possible.
628 (add_minsym_to_demangled_hash_table): Likewise.
629 (minimal_symbol_reader::install): Compute the hash codes for msymbol
630 on the background thread.
631 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
632 Add these fields.
633
634 2019-11-27 Christian Biesinger <cbiesinger@google.com>
635
636 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
637 of the mangled name on the background thread.
638 * symtab.c (symbol_set_names): Allow passing in the hash of the
639 linkage_name.
640 * symtab.h (symbol_set_names): Likewise.
641
642 2019-11-27 Kevin Buettner <kevinb@redhat.com>
643
644 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
645 physnames are computed for inherited DIEs.
646
647 2019-11-27 Tom Tromey <tromey@adacore.com>
648
649 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
650 backslashes.
651 * cp-support.c: Remove unnecessary backslashes.
652
653 2019-11-27 Christian Biesinger <cbiesinger@google.com>
654
655 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
656 with sym->set_linkage_name.
657 * coffread.c (coff_read_enum_type): Likewise.
658 * mdebugread.c (parse_symbol): Likewise.
659 * stabsread.c (patch_block_stabs): Likewise.
660 (define_symbol): Likewise.
661 (read_enum_type): Likewise.
662 (common_block_end): Likewise.
663 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
664 function.
665 (SYMBOL_SET_LINKAGE_NAME): Remove.
666 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
667 with sym->set_linkage_name.
668
669 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
670
671 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
672 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
673 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
674 * NEWS: Mention new MI command.
675
676 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
677
678 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
679 '-symbol-info-types', and '-symbol-info-variables'.
680 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
681 (mi_cmd_symbol_info_types): Declare.
682 (mi_cmd_symbol_info_variables): Declare.
683 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
684 (output_debug_symbol): New function.
685 (output_nondebug_symbol): New function.
686 (mi_symbol_info): New function.
687 (mi_info_functions_or_variables): New function.
688 (mi_cmd_symbol_info_functions): New function.
689 (mi_cmd_symbol_info_types): New function.
690 (mi_cmd_symbol_info_variables): New function.
691 * NEWS: Mention new commands.
692
693 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
694
695 * symtab.c (symbol_to_info_string): New function, most content
696 moved from print_symbol_info, but updated to return a std::string.
697 (print_symbol_info): Update to use symbol_to_info_string and print
698 returned string.
699 * symtab.h (symbol_to_info_string): Declare new function.
700
701 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
702
703 * python/python.c (gdbpy_rbreak): Convert to using
704 global_symbol_searcher.
705 * symtab.c (file_matches): Convert return type to bool, change
706 file list to std::vector, update header comment.
707 (search_symbols): Rename to...
708 (global_symbol_searcher::search): ...this and update now its
709 a member function of global_symbol_searcher. Take account of the
710 changes to file_matches.
711 (symtab_symbol_info): Convert to using global_symbol_searcher.
712 (rbreak_command): Likewise.
713 (search_module_symbols): Likewise.
714 * symtab.h (enum symbol_search): Update comment.
715 (search_symbols): Remove declaration.
716 (class global_symbol_searcher): New class.
717
718 2019-11-26 Tom Tromey <tromey@adacore.com>
719
720 * cp-support.c (_initialize_cp_support): Conditionally initialize
721 gdb_demangle_attempt_core_dump.
722
723 2019-11-26 Tom Tromey <tom@tromey.com>
724
725 * python/py-function.c (fnpy_init): Update.
726 * value.h (add_internal_function): Adjust declaration.
727 * value.c (function_destroyer): Remove.
728 (do_add_internal_function): Don't set destroyer or copy name.
729 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
730 Set name_allocated.
731 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
732 (cmdpy_init): Set name_allocated.
733 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
734 member.
735 (~cmd_list_element): Free "name" if needed.
736
737 2019-11-26 Tom Tromey <tom@tromey.com>
738
739 * value.h (add_internal_function): Add new overload. Move
740 documentation from value.h.
741 * value.c (do_add_internal_function): New function.
742 (add_internal_function): Use it. Add new overload.
743 (function_destroyer): Don't free doc.
744 * python/py-function.c (fnpy_init): Update.
745
746 2019-11-26 Tom Tromey <tom@tromey.com>
747
748 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
749 (cmdpy_init): Set "doc_allocated".
750
751 2019-11-26 Tom Tromey <tom@tromey.com>
752
753 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
754 name of worker thread.
755 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
756 pthread_setname_np.
757 * configure, config.in: Rebuild.
758
759 2019-11-26 Tom Tromey <tom@tromey.com>
760
761 * python/python.c (class gdbpy_gil): New.
762 (struct gdbpy_event): Add constructor, destructor, operator().
763 (gdbpy_post_event): Use run_on_main_thread.
764 (gdbpy_initialize_events): Remove.
765 (do_start_initialization): Update.
766
767 2019-11-26 Tom Tromey <tom@tromey.com>
768
769 * NEWS: Add entry.
770 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
771 commands. Call update_thread_pool_size.
772 (update_thread_pool_size, maintenance_set_worker_threads): New
773 functions.
774 (n_worker_threads): New global.
775
776 2019-11-26 Christian Biesinger <cbiesinger@google.com>
777 Tom Tromey <tom@tromey.com>
778
779 * minsyms.c (minimal_symbol_reader::install): Use
780 parallel_for_each.
781 * gdbsupport/parallel-for.h: New file.
782 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
783
784 2019-11-26 Christian Biesinger <cbiesinger@google.com>
785 Tom Tromey <tom@tromey.com>
786
787 * gdbsupport/thread-pool.h: New file.
788 * gdbsupport/thread-pool.c: New file.
789 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
790 (HFILES_NO_SRCDIR): Add thread-pool.h.
791
792 2019-11-26 Tom Tromey <tom@tromey.com>
793
794 * event-top.h (thread_local_segv_handler): Declare.
795 * event-top.c (thread_local_segv_handler): New global.
796 (install_handle_sigsegv, handle_sigsegv): New functions.
797 (async_init_signals): Install SIGSEGV handler.
798 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
799 thread-local.
800 (report_failed_demangle): New function.
801 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
802 handler-setting code, instead use segv_handler. Run warning code
803 on main thread.
804
805 2019-11-26 Tom Tromey <tom@tromey.com>
806
807 * run-on-main-thread.c: New file.
808 * run-on-main-thread.h: New file.
809 * unittests/main-thread-selftests.c: New file.
810 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
811 main-thread-selftests.c.
812 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
813 (COMMON_SFILES): Add run-on-main-thread.c.
814
815 2019-11-26 Tom Tromey <tom@tromey.com>
816
817 * main.c (setup_alternate_signal_stack): Remove.
818 (captured_main_1): Use gdb::alternate_signal_stack.
819 * gdbsupport/alt-stack.h: New file.
820
821 2019-11-26 Tom Tromey <tom@tromey.com>
822
823 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
824 Remove comment.
825 (save_original_signals_state, restore_original_signals_state): Use
826 gdb_sigmask.
827 * linux-nat.c (block_child_signals, restore_child_signals_mask)
828 (_initialize_linux_nat): Use gdb_sigmask.
829 * guile/guile.c (_initialize_guile): Use block_signals.
830 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
831 * gdbsupport/gdb-sigmask.h: New file.
832 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
833 * cp-support.c (gdb_demangle): Use gdb_sigmask.
834 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
835 pthread_sigmask.
836 * configure, config.in: Rebuild.
837 * gdbsupport/block-signals.h: New file.
838
839 2019-11-26 Tom Tromey <tom@tromey.com>
840
841 * acinclude.m4: Include ax_pthread.m4.
842 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
843 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
844 (CLIBS): Use PTHREAD_LIBS.
845 (aclocal_m4_deps): Add ax_pthread.m4.
846 * config.in, configure: Rebuild.
847 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
848
849 2019-11-26 Tom Tromey <tom@tromey.com>
850
851 * symtab.h (struct minimal_symbol) <name_set>: New member.
852 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
853 Don't call symbol_set_names.
854 (minimal_symbol_reader::install): Call symbol_set_names.
855
856 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
857
858 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
859 restore_active_ext_lang, as GIL is needed for (indirectly)
860 called PyOS_InterruptOccurred.
861
862 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
863
864 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
865 definition.
866
867 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
868
869 * remote-sim.c (simulator_command): Make static, remove
870 declaration.
871
872 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
873
874 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
875 static.
876 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
877 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
878 (main): Likewise.
879 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
880 (main): Likewise.
881 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
882 (main): Likewise.
883 * unittests/basic_string_view/element_access/char/1.cc (test01):
884 Likewise.
885 (main): Likewise.
886 * unittests/basic_string_view/element_access/char/empty.cc (main):
887 Likewise.
888 * unittests/basic_string_view/element_access/char/front_back.cc
889 (test01): Likewise.
890 (main): Likewise.
891 * unittests/basic_string_view/inserters/char/2.cc (test05):
892 Likewise.
893 (main): Likewise.
894 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
895 (test01): Likewise.
896 (main): Likewise.
897 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
898 (test01): Likewise.
899 (main): Likewise.
900 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
901 Likewise.
902 * unittests/basic_string_view/operations/compare/char/1.cc
903 (test01): Likewise.
904 (main): Likewise.
905 * unittests/basic_string_view/operations/compare/char/13650.cc
906 (test01): Likewise.
907 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
908 Likewise.
909 (main): Likewise.
910 * unittests/basic_string_view/operations/data/char/1.cc (test01):
911 Likewise.
912 (main): Likewise.
913 * unittests/basic_string_view/operations/find/char/1.cc (test01):
914 Likewise.
915 (main): Likewise.
916 * unittests/basic_string_view/operations/find/char/2.cc (test02):
917 Likewise.
918 (main): Likewise.
919 * unittests/basic_string_view/operations/find/char/3.cc (test03):
920 Likewise.
921 (main): Likewise.
922 * unittests/basic_string_view/operations/find/char/4.cc (main):
923 Likewise.
924 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
925 Likewise.
926 (main): Likewise.
927 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
928 Likewise.
929 (main): Likewise.
930 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
931 Likewise.
932 (main): Likewise.
933 * unittests/basic_string_view/operations/substr/char/1.cc
934 (test01): Likewise.
935 (main): Likewise.
936 * unittests/basic_string_view/operators/char/2.cc (main):
937 Likewise.
938 * unittests/optional/assignment/1.cc (test): Likewise.
939 * unittests/optional/assignment/2.cc (test): Likewise.
940 * unittests/optional/assignment/3.cc (test): Likewise.
941 * unittests/optional/assignment/4.cc (test): Likewise.
942 * unittests/optional/assignment/5.cc (test): Likewise.
943 * unittests/optional/assignment/6.cc (test): Likewise.
944 * unittests/optional/assignment/7.cc (test): Likewise.
945 * unittests/optional/cons/copy.cc (test): Likewise.
946 * unittests/optional/cons/default.cc (test): Likewise.
947 * unittests/optional/cons/move.cc (test): Likewise.
948 * unittests/optional/cons/value.cc (test): Likewise.
949 * unittests/optional/in_place.cc (test): Likewise.
950 * unittests/optional/observers/1.cc (test): Likewise.
951 * unittests/optional/observers/2.cc (test): Likewise.
952
953 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
954
955 * tui-win.h (tui_set_var_cmd): Remove.
956 * tui-win.c (tui_set_var_cmd): Make static.
957
958 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
959
960 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
961 rbreak_command_wrapper): Remove.
962 * symtab.c (rbreak_command_wrapper): Remove.
963
964 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
965
966 * inferior.h (info_terminal_command): Remove declaration.
967 * inflow.c (info_terminal_command): Make static.
968
969 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
970
971 * inferior.c (exit_inferior_silent): Remove.
972
973 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
974
975 * dictionary.c (dict_empty, mdict_empty): Remove.
976 * dictionary.c (mdict_empty): Remove.
977
978 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
979
980 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
981 (arc_insn_get_memory_offset): Likewise.
982 (arc_insn_dump): Likewise.
983 * cp-support.c (test_cp_symbol_name_matches): Likewise.
984 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
985 * dictionary.c (dict_iterator_next): Likewise.
986 (dict_iter_match_first): Likewise.
987 (dict_iter_match_next): Likewise.
988 * f-lang.c (evaluate_subexp_f): Likewise.
989 * hppa-tdep.c (hppa_read_pc): Likewise.
990 * i386-tdep.c (i386_floatformat_for_type): Likewise.
991 * parse.c (write_exp_elt_msym): Likewise.
992 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
993 * remote.c (remote_packet_size): Likewise.
994 (remote_notif_stop_parse): Likewise.
995 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
996 * s12z-tdep.c (s12z_disassemble_info): Likewise.
997 * source.c (prepare_path_for_appending): Likewise.
998 * sparc64-linux-tdep.c
999 (sparc64_linux_handle_segmentation_fault); Likewise.
1000 * stack.c (frame_selection_by_function_completer): Likewise.
1001
1002 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1003
1004 * completer.c (set_gdb_completion_word_break_characters):
1005 Remove.
1006
1007 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1008
1009 * dwarf-index-write.c: Include dwarf-index-write.h.
1010 * mi/mi-interp.c: Include mi/mi-interp.h.
1011
1012 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1013
1014 * aarch32-tdep.c: Include aarch32-tdep.h.
1015 * aarch32-tdep.h: Forward-declare struct target_desc.
1016
1017 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1018
1019 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1020 strerror.
1021 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1022 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1023
1024 2019-11-25 Tom de Vries <tdevries@suse.de>
1025
1026 * contrib/words.sh: Add -c option.
1027
1028 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1029
1030 * solib.c (solib_find_1): Change int to bool.
1031 (exec_file_find): Change int to bool.
1032 (solib_find): Change int to bool.
1033 (solib_read_symbols): Change int to bool.
1034 (solib_used): Change int to bool.
1035 (solib_add): Change int to bool.
1036 (info_sharedlibrary_command): Change int to bool.
1037 (solib_contains_address_p): Change int to bool.
1038 (solib_keep_data_in_core): Change int to bool.
1039 (in_solib_dynsym_resolve_code): Change int to bool.
1040 (reload_shared_libraries_1): Change int to bool.
1041 (gdb_sysroot_changed): Change int to bool.
1042 * solib.h (solib_read_symbols): Change int to bool.
1043 (solib_contains_address_p): Change int to bool.
1044 (solib_keep_data_in_core): Change int to bool.
1045 (in_solib_dynsym_resolve_code): Change int to bool.
1046 (libpthread_name_p): Change int to bool.
1047
1048 2019-11-25 Luis Machado <luis.machado@linaro.org>
1049
1050 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1051 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1052 (remote_packet_max_chars): New static global.
1053 (show_remote_packet_max_chars): New function.
1054 (remote_target::putpkt_binary): Adjust to use new
1055 remote_packet_max_chars option.
1056 (remote_target::getpkt_or_notif_sane_1): Likewise.
1057 (_initialize_remote): Register new remote-packet-max-chars option.
1058
1059 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1060
1061 * m68k-linux-nat.c: Include gdbarch.h.
1062
1063 2019-11-24 Tom Tromey <tom@tromey.com>
1064
1065 * symfile.c (read_symbols): Update.
1066 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1067 bool.
1068 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1069 (psym_lookup_symbol, psym_find_last_source_symtab)
1070 (psym_forget_cached_source_info, psym_print_stats)
1071 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1072 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1073 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1074 (psym_find_compunit_symtab_by_address)
1075 (maintenance_print_psymbols, maintenance_info_psymtabs)
1076 (maintenance_check_psymtabs): Update.
1077 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1078 bool.
1079
1080 2019-11-22 Tom Tromey <tom@tromey.com>
1081
1082 * observable.h: Update comments.
1083
1084 2019-11-22 Tom Tromey <tromey@adacore.com>
1085
1086 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1087 (print_ada_task_info): Don't try to fetch thread id if task is not
1088 alive.
1089
1090 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1091
1092 * ada-exp.y: Update.
1093 * ada-lang.c (sort_choices): Update.
1094 (ada_print_symbol_signature): Update.
1095 (resolve_subexp): Update.
1096 (ada_parse_renaming): Update.
1097 (ada_read_renaming_var_value): Update.
1098 (lesseq_defined_than): Update.
1099 (remove_extra_symbols): Update.
1100 (remove_irrelevant_renamings): Update.
1101 (ada_add_block_symbols): Update.
1102 (ada_collect_symbol_completion_matches): Update.
1103 (ada_is_renaming_symbol): Update.
1104 (aggregate_assign_from_choices): Update.
1105 (ada_evaluate_subexp): Update.
1106 (ada_has_this_exception_support): Update.
1107 (ada_is_non_standard_exception_sym): Update.
1108 (ada_add_exceptions_from_frame): Update.
1109 (ada_add_global_exceptions): Update.
1110 (ada_print_subexp): Update.
1111 * ax-gdb.c (gen_var_ref): Update.
1112 (gen_maybe_namespace_elt): Update.
1113 (gen_expr_for_cast): Update.
1114 (gen_expr): Update.
1115 * block.h: Update.
1116 * blockframe.c (find_pc_partial_function): Update.
1117 * breakpoint.c (print_breakpoint_location): Update.
1118 (update_static_tracepoint): Update.
1119 * btrace.c (ftrace_print_function_name): Update.
1120 (ftrace_function_switched): Update.
1121 * buildsym.c (find_symbol_in_list): Update.
1122 * c-exp.y: Update.
1123 * c-typeprint.c (c_print_typedef): Update.
1124 (c_type_print_template_args): Update.
1125 * cli/cli-cmds.c (edit_command): Update.
1126 (list_command): Update.
1127 (print_sal_location): Update.
1128 * coffread.c (patch_opaque_types): Update.
1129 (process_coff_symbol): Update.
1130 (coff_read_enum_type): Update.
1131 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1132 (convert_one_symbol): Update.
1133 (hash_symname): Update.
1134 (eq_symname): Update.
1135 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1136 * compile/compile-cplus-types.c (debug_print_scope): Update.
1137 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1138 * compile/compile-object-load.c (get_out_value_type): Update.
1139 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1140 (search_symbol_list): Update.
1141 (cp_lookup_symbol_imports_or_template): Update.
1142 * cp-support.c (overload_list_add_symbol): Update.
1143 * ctfread.c (psymtab_to_symtab): Update.
1144 * dbxread.c (cp_set_block_scope): Update.
1145 * dictionary.c (iter_match_first_hashed): Update.
1146 (iter_match_next_hashed): Update.
1147 (insert_symbol_hashed): Update.
1148 (iter_match_next_linear): Update.
1149 * dictionary.h: Update.
1150 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1151 (locexpr_describe_location_piece): Update.
1152 (locexpr_describe_location_1): Update.
1153 (locexpr_generate_c_location): Update.
1154 (loclist_describe_location): Update.
1155 (loclist_generate_c_location): Update.
1156 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1157 (read_func_scope): Update.
1158 (process_enumeration_scope): Update.
1159 (new_symbol): Update.
1160 (dwarf2_const_value): Update.
1161 (dwarf2_symbol_mark_computed): Update.
1162 * eval.c (evaluate_funcall): Update.
1163 (evaluate_subexp_standard): Update.
1164 * expprint.c (print_subexp_standard): Update.
1165 (dump_subexp_body_standard): Update.
1166 * f-valprint.c (info_common_command_for_block): Update.
1167 * findvar.c (get_hosting_frame): Update.
1168 (default_read_var_value): Update.
1169 * go-lang.c (go_symbol_package_name): Update.
1170 * guile/scm-block.c (bkscm_print_block_smob): Update.
1171 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1172 (gdbscm_symbol_name): Update.
1173 (gdbscm_symbol_linkage_name): Update.
1174 (gdbscm_symbol_print_name): Update.
1175 * infcall.c (get_function_name): Update.
1176 * infcmd.c (jump_command): Update.
1177 (finish_command): Update.
1178 * infrun.c (insert_exception_resume_breakpoint): Update.
1179 * linespec.c (canonicalize_linespec): Update.
1180 (create_sals_line_offset): Update.
1181 (convert_linespec_to_sals): Update.
1182 (complete_label): Update.
1183 (find_label_symbols_in_block): Update.
1184 * m2-typeprint.c (m2_print_typedef): Update.
1185 * mdebugread.c (mdebug_reg_to_regnum): Update.
1186 (parse_symbol): Update.
1187 (mylookup_symbol): Update.
1188 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1189 (list_args_or_locals): Update.
1190 * objc-lang.c (compare_selectors): Update.
1191 (info_selectors_command): Update.
1192 (compare_classes): Update.
1193 (info_classes_command): Update.
1194 (find_imps): Update.
1195 * p-typeprint.c (pascal_print_typedef): Update.
1196 * printcmd.c (build_address_symbolic): Update.
1197 (info_address_command): Update.
1198 (print_variable_and_value): Update.
1199 * python/py-framefilter.c (extract_sym): Update.
1200 (py_print_single_arg): Update.
1201 * python/py-symbol.c (sympy_str): Update.
1202 (sympy_get_name): Update.
1203 (sympy_get_linkage_name): Update.
1204 * python/python.c (gdbpy_rbreak): Update.
1205 * record-btrace.c (btrace_get_bfun_name): Update.
1206 (btrace_call_history): Update.
1207 * rust-lang.c (rust_print_typedef): Update.
1208 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1209 * stabsread.c (stab_reg_to_regnum): Update.
1210 (define_symbol): Update.
1211 (read_enum_type): Update.
1212 (common_block_end): Update.
1213 (cleanup_undefined_types_1): Update.
1214 (scan_file_globals): Update.
1215 * stack.c (print_frame_arg): Update.
1216 (print_frame_args): Update.
1217 (find_frame_funname): Update.
1218 (info_frame_command_core): Update.
1219 (iterate_over_block_locals): Update.
1220 (print_block_frame_labels): Update.
1221 (do_print_variable_and_value): Update.
1222 (iterate_over_block_arg_vars): Update.
1223 (return_command): Update.
1224 * symmisc.c (dump_symtab_1): Update.
1225 (print_symbol): Update.
1226 * symtab.c (eq_symbol_entry): Update.
1227 (symbol_cache_dump): Update.
1228 (lookup_language_this): Update.
1229 (find_pc_sect_line): Update.
1230 (skip_prologue_sal): Update.
1231 (symbol_search::compare_search_syms): Update.
1232 (treg_matches_sym_type_name): Update.
1233 (search_symbols): Update.
1234 (print_symbol_info): Update.
1235 (rbreak_command): Update.
1236 (completion_list_add_symbol): Update.
1237 (find_gnu_ifunc): Update.
1238 (get_symbol_address): Update.
1239 (search_module_symbols): Update.
1240 (info_module_subcommand): Update.
1241 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1242 (SYMBOL_LINKAGE_NAME): Remove.
1243 (SYMBOL_DEMANGLED_NAME): Remove.
1244 (SYMBOL_PRINT_NAME): Remove.
1245 (SYMBOL_SEARCH_NAME): Remove.
1246 * tracepoint.c (set_traceframe_context): Update.
1247 (validate_actionline): Update.
1248 (collection_list::collect_symbol): Update.
1249 (encode_actions_1): Update.
1250 (info_scope_command): Update.
1251 (print_one_static_tracepoint_marker): Update.
1252 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1253 * valops.c (address_of_variable): Update.
1254 (find_overload_match): Update.
1255 (find_oload_champ): Update.
1256
1257 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1258
1259 * ada-lang.c (ada_lookup_simple_minsym): Update.
1260 (ada_collect_symbol_completion_matches): Update.
1261 * ada-tasks.c (read_atcb): Update.
1262 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1263 (amd64_windows_skip_trampoline_code): Update.
1264 * arm-tdep.c (skip_prologue_function): Update.
1265 (arm_skip_stack_protector): Update.
1266 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1267 (arm_wince_skip_main_prologue): Update.
1268 * ax-gdb.c (gen_expr): Update.
1269 * block.c (call_site_for_pc): Update.
1270 * blockframe.c (find_pc_partial_function): Update.
1271 * breakpoint.c (set_breakpoint_location_function): Update.
1272 * btrace.c (ftrace_print_function_name): Update.
1273 (ftrace_function_switched): Update.
1274 * c-valprint.c (print_unpacked_pointer): Update.
1275 * coffread.c (coff_symfile_read): Update.
1276 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1277 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1278 * dwarf-index-write.c (write_psymbols): Update.
1279 * dwarf2loc.c (call_site_to_target_addr): Update.
1280 (func_verify_no_selftailcall): Update.
1281 (tailcall_dump): Update.
1282 (call_site_find_chain_1): Update.
1283 (dwarf_expr_reg_to_entry_parameter): Update.
1284 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1285 * eval.c (evaluate_funcall): Update.
1286 (evaluate_subexp_standard): Update.
1287 (evaluate_subexp_for_sizeof): Update.
1288 * expprint.c (print_subexp_standard): Update.
1289 (dump_subexp_body_standard): Update.
1290 * frame.c (get_prev_frame_always_1): Update.
1291 * frv-tdep.c (frv_skip_main_prologue): Update.
1292 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1293 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1294 (gnuv3_get_typename_from_type_info): Update.
1295 (gnuv3_skip_trampoline): Update.
1296 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1297 * i386-tdep.c (i386_skip_main_prologue): Update.
1298 (i386_pe_skip_trampoline_code): Update.
1299 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1300 * infcall.c (get_function_name): Update.
1301 * linespec.c (minsym_found): Update.
1302 * linux-fork.c (info_checkpoints_command): Update.
1303 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1304 (m32c_m16c_pointer_to_address): Update.
1305 * maint.c (maintenance_translate_address): Update.
1306 * minsyms.c (add_minsym_to_hash_table): Update.
1307 (add_minsym_to_demangled_hash_table): Update.
1308 (lookup_minimal_symbol_mangled): Update.
1309 (lookup_minimal_symbol_demangled): Update.
1310 (lookup_minimal_symbol_linkage): Update.
1311 (lookup_minimal_symbol_text): Update.
1312 (lookup_minimal_symbol_by_pc_name): Update.
1313 (minimal_symbol_is_less_than): Update.
1314 (compact_minimal_symbols): Update.
1315 (build_minimal_symbol_hash_tables): Update.
1316 (find_solib_trampoline_target): Update.
1317 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1318 (mips_skip_pic_trampoline_code): Update.
1319 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1320 * objc-lang.c (info_selectors_command): Update.
1321 (info_classes_command): Update.
1322 (find_methods): Update.
1323 (find_imps): Update.
1324 * p-valprint.c (pascal_val_print): Update.
1325 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1326 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1327 * printcmd.c (build_address_symbolic): Update.
1328 (info_symbol_command): Update.
1329 * psymtab.c (psymbol_name_matches): Update.
1330 (match_partial_symbol): Update.
1331 (lookup_partial_symbol): Update.
1332 (print_partial_symbols): Update.
1333 (sort_pst_symbols): Update.
1334 (maintenance_check_psymtabs): Update.
1335 * python/py-framefilter.c (py_print_frame): Update.
1336 * python/python.c (gdbpy_rbreak): Update.
1337 * record-btrace.c (btrace_get_bfun_name): Update.
1338 (btrace_call_history): Update.
1339 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1340 (rs6000_skip_trampoline_code): Update.
1341 * sol-thread.c (info_cb): Update.
1342 * stabsread.c (scan_file_globals): Update.
1343 * stack.c (find_frame_funname): Update.
1344 (info_frame_command_core): Update.
1345 * symmisc.c (dump_msymbols): Update.
1346 * symtab.c (symbol_natural_name): Rename to..,
1347 (general_symbol_info::natural_name): ...this.
1348 (symbol_demangled_name): Rename to...
1349 (general_symbol_info::demangled_name): ...this.
1350 (symbol_search_name): Rename to...
1351 (general_symbol_info::search_name): ...this.
1352 (symbol_matches_search_name): Update.
1353 (find_pc_sect_line): Update.
1354 (skip_prologue_sal): Update.
1355 (search_symbols): Update.
1356 (print_msymbol_info): Update.
1357 (rbreak_command): Update.
1358 (completion_list_add_msymbol): Update.
1359 (completion_list_objc_symbol): Update.
1360 (get_msymbol_address): Update.
1361 * symtab.h (struct general_symbol_info): Add member functions
1362 natural_name (), linkage_name (), print_name (), demangled_name (),
1363 and search_name ().
1364 (SYMBOL_NATURAL_NAME): Update.
1365 (symbol_natural_name): Move to a member function on general_symbol_info.
1366 (SYMBOL_DEMANGLED_NAME): Update.
1367 (symbol_demangled_name): Move to a member function on
1368 general_symbol_info.
1369 (SYMBOL_SEARCH_NAME): Update.
1370 (symbol_search_name): Move to a member function on general_symbol_info.
1371 (MSYMBOL_NATURAL_NAME): Remove.
1372 (MSYMBOL_LINKAGE_NAME): Remove.
1373 (MSYMBOL_PRINT_NAME): Remove.
1374 (MSYMBOL_DEMANGLED_NAME): Remove.
1375 (MSYMBOL_SEARCH_NAME): Remove.
1376 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1377
1378 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1379
1380 * symtab.c (create_demangled_names_hash): Use per_bfd->
1381 minimal_symbol_count for computing the initial size, if greater
1382 than our default size.
1383
1384 2019-11-22 Tom de Vries <tdevries@suse.de>
1385
1386 * contrib/words.sh: Improve words extraction.
1387
1388 2019-11-22 Tom de Vries <tdevries@suse.de>
1389
1390 * contrib/words.sh: Combine sed invocations.
1391
1392 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1393
1394 * Makefile.in: Update.
1395 * demangle.c: Rename to...
1396 * gdb-demangle.c: ..this.
1397 (is_cplus_marker): Change return type to bool.
1398 (_initialize_demangler): Rename to...
1399 (_initialize_gdb_demangle): ...this.
1400 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1401 * symtab.h (demangle): Remove declaration; instead include
1402 gdb-demangle.h.
1403
1404 2019-11-21 Tom Tromey <tromey@adacore.com>
1405
1406 * gdbsupport/format.c (format_pieces): Parse %I64d.
1407 * unittests/format_pieces-selftests.c (test_windows_formats): New
1408 function.
1409 (run_tests): Call it.
1410
1411 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1412
1413 Byte reverse display of variables with DW_END_big, DW_END_little
1414 (DW_AT_endianity) dwarf attributes if different than the native
1415 byte order.
1416 * ada-lang.c (ada_value_binop):
1417 Use type_byte_order instead of gdbarch_byte_order.
1418 * ada-valprint.c (printstr):
1419 (ada_val_print_string):
1420 * ada-lang.c (value_pointer):
1421 (ada_value_binop):
1422 Use type_byte_order instead of gdbarch_byte_order.
1423 * c-lang.c (c_get_string):
1424 Use type_byte_order instead of gdbarch_byte_order.
1425 * c-valprint.c (c_val_print_array):
1426 Use type_byte_order instead of gdbarch_byte_order.
1427 * cp-valprint.c (cp_print_class_member):
1428 Use type_byte_order instead of gdbarch_byte_order.
1429 * dwarf2loc.c (rw_pieced_value):
1430 Use type_byte_order instead of gdbarch_byte_order.
1431 * dwarf2read.c (read_base_type): Handle DW_END_big,
1432 DW_END_little
1433 * f-lang.c (f_get_encoding):
1434 Use type_byte_order instead of gdbarch_byte_order.
1435 * findvar.c (default_read_var_value):
1436 Use type_byte_order instead of gdbarch_byte_order.
1437 * gdbtypes.c (check_types_equal):
1438 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1439 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1440 and TYPE_ENDIANITY_LITTLE if set.
1441 (type_byte_order): new function.
1442 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1443 (struct main_type) <flag_endianity_not_default>:
1444 New field.
1445 (type_byte_order): New function.
1446 * infcmd.c (default_print_one_register_info):
1447 Use type_byte_order instead of gdbarch_byte_order.
1448 * p-lang.c (pascal_printstr):
1449 Use type_byte_order instead of gdbarch_byte_order.
1450 * p-valprint.c (pascal_val_print):
1451 Use type_byte_order instead of gdbarch_byte_order.
1452 * printcmd.c (print_scalar_formatted):
1453 Use type_byte_order instead of gdbarch_byte_order.
1454 * solib-darwin.c (darwin_current_sos):
1455 Use type_byte_order instead of gdbarch_byte_order.
1456 * solib-svr4.c (solib_svr4_r_ldsomap):
1457 Use type_byte_order instead of gdbarch_byte_order.
1458 * stap-probe.c (stap_modify_semaphore):
1459 Use type_byte_order instead of gdbarch_byte_order.
1460 * target-float.c (target_float_same_format_p):
1461 Use type_byte_order instead of gdbarch_byte_order.
1462 * valarith.c (scalar_binop):
1463 (value_bit_index):
1464 Use type_byte_order instead of gdbarch_byte_order.
1465 * valops.c (value_cast):
1466 Use type_byte_order instead of gdbarch_byte_order.
1467 * valprint.c (generic_emit_char):
1468 (generic_printstr):
1469 (val_print_string):
1470 Use type_byte_order instead of gdbarch_byte_order.
1471 * value.c (unpack_long):
1472 (unpack_bits_as_long):
1473 (unpack_value_bitfield):
1474 (modify_field):
1475 (pack_long):
1476 (pack_unsigned_long):
1477 Use type_byte_order instead of gdbarch_byte_order.
1478 * findvar.c (unsigned_pointer_to_address):
1479 (signed_pointer_to_address):
1480 (unsigned_address_to_pointer):
1481 (address_to_signed_pointer):
1482 (default_read_var_value):
1483 (default_value_from_register):
1484 Use type_byte_order instead of gdbarch_byte_order.
1485 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1486 Use type_byte_order instead of gdbarch_byte_order.
1487 * riscv-tdep.c (riscv_print_one_register_info):
1488 Use type_byte_order instead of gdbarch_byte_order.
1489
1490 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1491
1492 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1493 (current_ui_gdb_stdin_ptr): Likewise.
1494 (current_ui_gdb_stderr_ptr): Likewise.
1495 (current_ui_gdb_stdlog_ptr): Likewise.
1496 (current_ui_current_uiout_ptr): Likewise.
1497 (gen_ret_current_ui_field_ptr): Remove.
1498
1499 2019-11-21 Tom de Vries <tdevries@suse.de>
1500
1501 PR gdb/24956
1502 * cli/cli-script.c (execute_control_command): Only switch to
1503 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1504
1505 2019-11-19 Tom Tromey <tom@tromey.com>
1506
1507 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1508 Now static. Change type of "name".
1509 (tui_set_win_height_command): Don't copy "arg".
1510 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1511 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1512
1513 2019-11-19 Ali Tamur <tamur@google.com>
1514
1515 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1516 "if (attr != nullptr)".
1517 (dwarf2_find_base_address): Likewise.
1518 (dwarf2_build_include_psymtabs): Likewise.
1519 (read_cutu_die_from_dwo): Likewise.
1520 (read_func_scope): Likewise.
1521 (read_call_site_scope): Likewise.
1522 (dwarf2_get_pc_bounds): Likewise.
1523 (dwarf2_record_block_ranges): Likewise.
1524 (dwarf2_add_field): Likewise.
1525 (dwarf2_add_member_fn): Likewise.
1526 (read_structure_type): Likewise.
1527 (read_enumeration_type): Likewise.
1528 (read_array_type): Likewise.
1529 (read_array_order): Likewise.
1530 (read_set_type): Likewise.
1531 (read_common_block): Likewise.
1532 (read_tag_reference_type): Likewise.
1533 (read_tag_string_type): Likewise.
1534 (read_subroutine_type): Likewise.
1535 (read_base_type): Likewise.
1536 (read_subrange_type): Likewise.
1537 (new_symbol): Likewise.
1538 (prepare_one_comp_unit): Likewise.
1539
1540 2019-11-19 Tom Tromey <tromey@adacore.com>
1541
1542 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1543 result in error when DebugActiveProcess fails.
1544
1545 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1546 Pedro Alves <palves@redhat.com>
1547
1548 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1549 * target.c (target_stack::push): Call 'unpush' if there's a
1550 target on top of the stack.
1551
1552 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1553
1554 * python/py-block.c (blpy_dealloc): Call tp_free.
1555 (blpy_block_syms_dealloc): Likewise.
1556 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1557 * python/py-inferior.c (infpy_dealloc): Likewise.
1558 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1559 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1560 * python/py-symbol.c (sympy_dealloc): Likewise.
1561 * python/py-symtab.c (stpy_dealloc): Likewise.
1562 * python/py-type.c (typy_iterator_dealloc): Likewise.
1563
1564 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1565
1566 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1567 constructor instead of using a class initializer.
1568
1569 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1570
1571 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1572 * configure: Regenerate.
1573 * configure.ac: Don't source common.host.
1574 * gdbsupport/common.host: Remove.
1575 * gdbsupport/mingw-strerror.c: Remove.
1576 * gdbsupport/posix-strerror.c: Rename to...
1577 * gdbsupport/safe-strerror.c: ...this.
1578
1579 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1580
1581 * maint.c (scoped_command_stats::print_time): Use localtime_r
1582 instead of localtime (provided through gnulib if necessary).
1583 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1584 of ctime.
1585
1586 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1587
1588 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1589 avoid compile errors.
1590
1591 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1592
1593 * config.in: Regenerate.
1594 * configure: Regenerate.
1595 * gdbsupport/common.m4: No longer check for strerror_r.
1596 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1597 POSIX version of strerror_r, now that gnulib provides it if
1598 necessary.
1599
1600 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1601
1602 * README (`configure' options): Update.
1603
1604 2019-11-14 Tom Tromey <tromey@adacore.com>
1605
1606 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1607 expected type for the RHS if the LHS is a convenience variable.
1608
1609 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1610
1611 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1612 Provide explicit default and copy constructor.
1613
1614 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1615
1616 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1617 only call Py_INCREF (newbp) in the bppy_pending_object case.
1618
1619 2019-11-13 Tom Tromey <tromey@adacore.com>
1620
1621 PR build/25182:
1622 * psympriv.h (partial_symbol): Remove static assert.
1623 * symtab.h (general_symbol_info, symbol): Remove static assert.
1624
1625 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1626
1627 * gdbsupport/format.c (format_pieces::format_pieces): Support
1628 printf 'z' size modifier.
1629 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1630 * printcmd.c (ui_printf): Handle size_t_arg.
1631 * ui-out.c (ui_out::vmessage): Likewise.
1632 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1633 function.
1634 (run_tests): Call test_format_int_sizes.
1635
1636 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1637
1638 * ada-exp.y (write_ambiguous_var): Update.
1639 * buildsym.c (add_symbol_to_list): Update.
1640 * dwarf2read.c (read_variable): Update.
1641 (new_symbol): Update.
1642 * jit.c (finalize_symtab): Update.
1643 * language.c (language_alloc_type_symbol): Update.
1644 * symtab.c (fixup_symbol_section): Update.
1645 (initialize_objfile_symbol_1): Move code to...
1646 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1647 (allocate_symbol): Update.
1648 (allocate_template_symbol): Update.
1649 (get_symbol_address): Update.
1650 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1651 of having as a field, and add a constructor.
1652 (SYMBOL_VALUE): Update.
1653 (SYMBOL_VALUE_ADDRESS): Update.
1654 (SET_SYMBOL_VALUE_ADDRESS): Update.
1655 (SYMBOL_VALUE_BYTES): Update.
1656 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1657 (SYMBOL_BLOCK_VALUE): Update.
1658 (SYMBOL_VALUE_CHAIN): Update.
1659 (SYMBOL_LANGUAGE): Update.
1660 (SYMBOL_SECTION): Update.
1661 (SYMBOL_OBJ_SECTION): Update.
1662 (SYMBOL_SET_LANGUAGE): Update.
1663 (SYMBOL_SET_LINKAGE_NAME): Update.
1664 (SYMBOL_SET_NAMES): Update.
1665 (SYMBOL_NATURAL_NAME): Update.
1666 (SYMBOL_LINKAGE_NAME): Update.
1667 (SYMBOL_DEMANGLED_NAME): Update.
1668 (SYMBOL_SEARCH_NAME): Update.
1669 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1670 (struct symbol): Update.
1671 (struct template_symbol): Update.
1672 (struct rust_vtable_symbol): Update.
1673 * xcoffread.c (SYMBOL_DUP): Update.
1674
1675 2019-11-12 Tom Tromey <tom@tromey.com>
1676
1677 * tui/tui-layout.c (show_layout): Set current_layout.
1678 (show_source_disasm_command, show_data)
1679 (show_source_or_disasm_and_command): Don't set current_layout.
1680
1681 2019-11-12 Tom Tromey <tom@tromey.com>
1682
1683 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1684
1685 2019-11-12 Tom Tromey <tom@tromey.com>
1686
1687 * tui/tui-win.c (resize_message): New global.
1688 (show_tui_resize_message): New function.
1689 (tui_async_resize_screen): Print message if requested.
1690 (_initialize_tui_win): Add tui-resize-message setting.
1691 * NEWS: Add entry for new commands.
1692
1693 2019-11-11 Tom Tromey <tom@tromey.com>
1694
1695 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1696 functions.
1697
1698 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1699
1700 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1701
1702 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1703
1704 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1705 function.
1706 * python/python-internal.h (gdbpy_lookup_static_symbols):
1707 Declare new function.
1708 * python/python.c (python_GdbMethods): Add
1709 gdb.lookup_static_symbols method.
1710 * NEWS: Mention gdb.lookup_static_symbols.
1711
1712 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1713
1714 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1715 static block of current object file first. Also fix typo in
1716 header comment.
1717
1718 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1719
1720 * stack.c (set_last_displayed_sal): Delete.
1721 (last_displayed_sal_valid): Delete.
1722 (last_displayed_pspace): Delete.
1723 (last_displayed_addr): Delete.
1724 (last_displayed_symtab): Delete.
1725 (last_displayed_line): Delete.
1726 (class last_displayed_symtab_info_type): New.
1727 (last_displayed_symtab_info): New static global variable.
1728 (print_frame_info): Call methods on last_displayed_symtab_info.
1729 (clear_last_displayed_sal): Update header comment, and make use of
1730 last_displayed_symtab_info.
1731 (last_displayed_sal_is_valid): Likewise.
1732 (get_last_displayed_pspace): Likewise.
1733 (get_last_displayed_addr): Likewise.
1734 (get_last_displayed_symtab): Likewise.
1735 (get_last_displayed_line): Likewise.
1736 (get_last_displayed_sal): Likewise.
1737 * stack.h (clear_last_displayed_sal): Update header comment.
1738 (last_displayed_sal_is_valid): Likewise.
1739 (get_last_displayed_pspace): Likewise.
1740 (get_last_displayed_addr): Likewise.
1741 (get_last_displayed_symtab): Likewise.
1742 (get_last_displayed_line): Likewise.
1743 (get_last_displayed_sal): Likewise.
1744
1745 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1746
1747 * stack.c (frame_show_address): Convert return type to bool.
1748 * stack.h (frame_show_address): Likewise, and update header
1749 comment.
1750
1751 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1752
1753 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1754 * unittests/vec-utils-selftests.c: New file.
1755 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1756
1757 2019-11-10 Tom Tromey <tom@tromey.com>
1758
1759 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1760 (tui_highlight_win): Likewise.
1761 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1762 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1763 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1764 Don't set can_highlight.
1765
1766 2019-11-10 Tom Tromey <tom@tromey.com>
1767
1768 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1769 Remove unused declaration.
1770
1771 2019-11-08 Tom Tromey <tromey@adacore.com>
1772
1773 * top.c (read_command_file): Update.
1774 (command_line_input): Make return type const.
1775 * python/py-gdb-readline.c: Update.
1776 * linespec.c (decode_line_2): Update.
1777 * defs.h (command_line_input): Make return type const.
1778 * cli/cli-script.c (read_next_line): Make return type const.
1779 * ada-lang.c (get_selections): Update.
1780
1781 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1782
1783 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1784 * mi/mi-main.c (output_cores): Likewise.
1785 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1786 (linux_xfer_osdata_modules): Likewise.
1787 * remote.c (register_remote_support_xml): Likewise.
1788 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1789 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1790
1791 2019-11-06 Tom Tromey <tom@tromey.com>
1792
1793 * tui/tui-interp.c: Don't include readline.h.
1794 * tui/tui-hooks.c: Don't include readline.h.
1795 * symmisc.c: Include tilde.h, not readline.h.
1796 * symfile.c: Include tilde.h, not readline.h.
1797 * source.c: Include tilde.h, not readline.h.
1798 * solib.c: Include tilde.h, not readline.h.
1799 * psymtab.c: Include tilde.h, not readline.h.
1800 * exec.c: Include tilde.h, not readline.h.
1801 * corelow.c: Include tilde.h, not readline.h.
1802 * cli/cli-dump.c: Include tilde.h, not readline.h.
1803 * cli/cli-cmds.c: Don't include readline.h.
1804
1805 2019-11-05 Tom Tromey <tom@tromey.com>
1806
1807 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1808 (tui_disassemble): Set addr_size.
1809 (tui_disasm_window::set_contents): Use addr_size.
1810
1811 2019-11-05 Tom Tromey <tom@tromey.com>
1812
1813 * rust-lang.c (rust_language_defn): Update.
1814 * python/py-value.c (valpy_string): Call c_get_string.
1815 * p-lang.c (pascal_language_defn): Update.
1816 * opencl-lang.c (opencl_language_defn): Update.
1817 * objc-lang.c (objc_language_defn): Update.
1818 * m2-lang.c (m2_language_defn): Update.
1819 * language.c (unknown_language_defn, auto_language_defn): Update.
1820 (default_get_string): Remove.
1821 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1822 * go-lang.c (go_language_defn): Update.
1823 * f-lang.c (f_language_defn): Update.
1824 * d-lang.c (d_language_defn): Update.
1825 * c-lang.c (c_language_defn, cplus_language_defn)
1826 (asm_language_defn, minimal_language_defn): Update.
1827 * ada-lang.c (ada_language_defn): Update.
1828 * language.h (struct language_defn) <la_get_string>: Remove.
1829 (LA_GET_STRING): Remove.
1830 (default_get_string): Don't declare.
1831
1832 2019-11-05 Tom Tromey <tom@tromey.com>
1833
1834 * tui/tui-source.h (struct tui_source_window): Inline
1835 constructor. Remove destructor.
1836 <style_changed, m_observable>: Move to superclass.
1837 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1838 (struct tui_source_window_base): Move private members to end.
1839 <style_changed, m_observable>: Move from tui_source_window.
1840 * tui/tui-winsource.c (tui_copy_source_line): Move from
1841 tui-source.c. Rename from copy_source_line. Add special handling
1842 for negative line number.
1843 (tui_source_window_base::style_changed): Move from
1844 tui_source_window.
1845 (tui_source_window_base): Register observer.
1846 (~tui_source_window_base): New.
1847 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1848 rename.
1849 (tui_source_window::set_contents): Use tui_copy_source_line.
1850 (tui_source_window::tui_source_window): Move to tui-source.h.
1851 (tui_source_window::~tui_source_window): Remove.
1852 (tui_source_window::style_changed): Move to superclass.
1853 * tui/tui-disasm.c (tui_disassemble): Create string file with
1854 styling, when possible. Add "addr_size" parameter.
1855 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1856 Don't compute maximum size.
1857 (len_without_escapes): New function
1858
1859 2019-11-05 Tom Tromey <tom@tromey.com>
1860
1861 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1862 std::string.
1863 * tui/tui-winsource.c (tui_show_source_line): Update.
1864 * tui/tui-source.c (tui_source_window::set_contents): Update.
1865 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1866
1867 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1868
1869 * symtab.h (gdb_static_assert): Put && operator at the beginning
1870 of the line instead of the end.
1871
1872 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1873
1874 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1875 and sizeof (symbol).
1876 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1877
1878 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1879
1880 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1881 * configure.host: Mark *-*-solaris2.10* obsolete.
1882 * configure.tgt: Mark Solaris < 11 obsolete.
1883 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1884 Update target triplet.
1885
1886 2019-11-01 Tom Tromey <tromey@adacore.com>
1887
1888 * utils.c (print_sys_errmsg): Simplify.
1889
1890 2019-11-01 Tom Tromey <tromey@adacore.com>
1891
1892 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1893
1894 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1895
1896 * configure: Regenerate.
1897 * configure.ac: Remove check for strerror_r.
1898 * gdbsupport/common.m4: Check for strerror_r.
1899
1900 2019-11-01 Luis Machado <luis.machado@linaro.org>
1901
1902 PR gdb/25124
1903
1904 * arm-tdep.c (arm_per_objfile): Rename to ...
1905 (arm_per_bfd): ... this.
1906 (arm_objfile_data_key): Rename to ...
1907 (arm_bfd_data_key): ... this.
1908 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1909 data.
1910 (arm_record_special_symbol): Likewise.
1911
1912 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1913
1914 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1915 end.
1916 * c-typeprint.c (c_print_typedef): Likewise.
1917 * f-typeprint.c (f_print_typedef): Likewise.
1918 * m2-typeprint.c (m2_print_typedef): Likewise.
1919 * p-typeprint.c (pascal_print_typedef): Likewise.
1920 * rust-lang.c (rust_print_typedef): Likewise.
1921 * symtab.c (print_symbol_info): Print a newline after calling
1922 typedef_print.
1923
1924 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1925
1926 * symtab.c (info_module_cmdlist): New variable.
1927 (info_module_command): New function.
1928 (search_module_symbols): New function.
1929 (info_module_subcommand): New function.
1930 (struct info_modules_var_func_options): New struct.
1931 (info_modules_var_func_options_defs): New variable.
1932 (make_info_modules_var_func_options_def_group): New function.
1933 (info_module_functions_command): New function.
1934 (info_module_variables_command): New function.
1935 (info_module_var_func_command_completer): New function.
1936 (_initialize_symtab): Register new 'info module functions' and
1937 'info module variables' commands.
1938 * symtab.h (typedef symbol_search_in_module): New typedef.
1939 (search_module_symbols): Declare new function.
1940 * NEWS: Mention new commands.
1941
1942 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1943
1944 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1945 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1946 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1947 MODULES_DOMAIN.
1948 (scan_partial_symbols): Only create partial module symbols for non
1949 declarations.
1950 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1951 and MODULES_DOMAIN.
1952 * symtab.c (search_domain_name): Likewise.
1953 (search_symbols): Likewise.
1954 (print_symbol_info): Likewise.
1955 (symtab_symbol_info): Likewise.
1956 (info_modules_command): New function.
1957 (_initialize_symtab): Register 'info modules' command.
1958 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1959 * NEWS: Mention new 'info modules' command.
1960
1961 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1962
1963 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1964 and $_gdb_maint_setting_str.
1965
1966 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1967
1968 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1969 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1970 (str_value_from_setting, gdb_setting_str_internal_fn)
1971 (gdb_maint_setting_str_internal_fn): New functions.
1972 (_initialize_cli_cmds): Define the new convenience functions.
1973 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1974 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1975
1976 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1977
1978 * agent.c (set_can_use_agent): When the setting is turned on,
1979 look up agent symbols if we don't have them yet.
1980 (agent_new_objfile): Don't look up agent symbols when the agent
1981 setting is off.
1982
1983 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1984
1985 * config.in: Regenerate.
1986
1987 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1988
1989 * configure: Regenerate.
1990 * configure.ac: Check for strerror_r.
1991 * gdbsupport/common-utils.h (safe_strerror): Change return value
1992 to const char * and document that this function is now threadsafe.
1993 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1994 thread_local and call strerror_r, if available.
1995 * utils.c (perror_string): Update.
1996 (print_sys_errmsg): Update.
1997
1998 2019-10-31 Luis Machado <luis.machado@linaro.org>
1999
2000 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2001 objfile_key.
2002 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2003 objfile to fetch per-bfd data.
2004 (arm_find_exidx_entry): Likewise.
2005
2006 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2007
2008 * gdbsupport/agent.c (debug_agent): Change type to bool.
2009 (use_agent): Likewise.
2010 (all_agent_symbols_look_up): Likewise.
2011 (agent_loaded_p): Change return value to bool.
2012 (agent_look_up_symbols): Update.
2013 (agent_capability_check): Change return value to bool.
2014 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2015 (debug_agent): Change type to bool.
2016 (use_agent): Likewise.
2017 (agent_capability_check): Change return value to bool.
2018
2019 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2020
2021 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2022 (build_minimal_symbol_hash_tables): Code to clear the table moved
2023 to clear_minimal_symbol_hash_tables.
2024 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2025 when needed.
2026
2027 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2028
2029 * infcmd.c: Remove includes.
2030 * infrun.c: Remove includes.
2031
2032 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2033
2034 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2035 (grow_vect): Remove declaration.
2036 (ada_type_of_array): Remove declaration.
2037 (ada_update_initial_language): Remove declaration.
2038 (ada_fold_name): Remove declaration.
2039 (ada_fill_in_ada_prototype): Remove declaration.
2040 (user_select_syms): Remove declaration.
2041 (get_selections): Remove declaration.
2042 (ada_tag_type): Remove declaration.
2043 (ada_value_tag): Remove declaration.
2044 (ada_is_others_clause): Remove declaration.
2045 (ada_in_variant): Remove declaration.
2046 (ada_value_struct_elt): Remove declaration.
2047 (ada_attribute_name): Remove declaration.
2048 (ada_system_address_type): Remove declaration.
2049 * ada-lang.c (ada_watch_location_expression): Make static.
2050 (GROW_VECT): Move here from ada-lang.h.
2051 (grow_vect): Make static.
2052 (ada_update_initial_language): Make static.
2053 (ada_fold_name): Make static.
2054 (ada_type_of_array): Make static.
2055 (encoded_ordered_before): Move up.
2056 (sort_choices): Move up.
2057 (print_signatures): Move up.
2058 (ada_print_symbol_signature): Move up.
2059 (get_selections): Move up and make static.
2060 (user_select_syms): Move up and make static.
2061 (ada_value_struct_elt): Move up and make static.
2062 (ada_tag_type): Make static.
2063 (ada_value_tag): Make static.
2064 (ada_is_others_clause): Make static.
2065 (ada_in_variant): Make static.
2066 (ada_attribute_name): Make static.
2067
2068 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2069
2070 * ada-lang.c: Remove includes.
2071 * ada-typeprint.c: Remove includes.
2072 * ada-valprint.c: Remove includes.
2073
2074 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2075
2076 * addrmap.c: Add static assertions of type size, moved from
2077 _initialize_addrmap.
2078 (_initialize_addrmap): Remove.
2079
2080 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2081
2082 * coffread.c (record_minimal_symbol): Update.
2083 (process_coff_symbol): Update.
2084 * dbxread.c (read_dbx_symtab): Update.
2085 * dwarf2read.c (add_partial_symbol): Update.
2086 (fixup_go_packaging): Update.
2087 (load_partial_dies): Update.
2088 (new_symbol): Update.
2089 * elfread.c (record_minimal_symbol): Change signature to use
2090 gdb::string_view instead of name+len.
2091 (elf_symtab_read): Update.
2092 (elf_rel_plt_read): Update.
2093 * mdebugread.c (parse_partial_symbols): Update.
2094 (handle_psymbol_enumerators): Update.
2095 (new_symbol): Update.
2096 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2097 to use gdb::string_view instead of name+len.
2098 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2099 * psympriv.h (add_psymbol_to_list): Likewise.
2100 * psymtab.c (add_psymbol_to_bcache): Likewise.
2101 (add_psymbol_to_list): Likewise.
2102 * stabsread.c (define_symbol): Update.
2103 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2104 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2105 (symbol_set_names): Likewise.
2106 * xcoffread.c (scan_xcoff_symtab): Update.
2107
2108 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2109
2110 * symtab.h (symbol_set_names): Document that copy_name must be
2111 set to true for non-nullterminated strings.
2112 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2113 linkage_name if the entry was not found and we need to demangle.
2114
2115 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2116
2117 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2118 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2119 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2120 * gdbsupport/gdb_binary_search.h: New file.
2121
2122 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2123
2124 * NEWS: Mention new --with-system-gdbinit-dir option.
2125 * config.in: Regenerate.
2126 * configure: Regenerate.
2127 * configure.ac: Add new option --with-system-gdbinit-dir.
2128 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2129 for a ".gdb" suffix.
2130 * main.c (get_init_files): Change system_gdbinit argument to
2131 a vector and return the files in SYSTEM_GDBINIT_DIR in
2132 addition to SYSTEM_GDBINIT.
2133 (captured_main_1): Update.
2134 (print_gdb_help): Update.
2135 * top.c (print_gdb_configuration): Also print the value of
2136 SYSTEM_GDBINIT_DIR.
2137
2138 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2139
2140 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2141 that takes gdb::string_view arguments.
2142
2143 2019-10-26 Tom de Vries <tdevries@suse.de>
2144
2145 * aarch64-linux-tdep.c: Fix typos in comments.
2146 * aarch64-tdep.c: Same.
2147 * ada-lang.c: Same.
2148 * amd64-nat.c: Same.
2149 * arc-tdep.c: Same.
2150 * arch/aarch64-insn.c: Same.
2151 * block.c: Same.
2152 * breakpoint.h: Same.
2153 * btrace.h: Same.
2154 * c-varobj.c: Same.
2155 * cli/cli-decode.c: Same.
2156 * cli/cli-script.c: Same.
2157 * cli/cli-utils.h: Same.
2158 * coff-pe-read.c: Same.
2159 * coffread.c: Same.
2160 * compile/compile-cplus-symbols.c: Same.
2161 * compile/compile-object-run.c: Same.
2162 * completer.c: Same.
2163 * corelow.c: Same.
2164 * cp-support.c: Same.
2165 * demangle.c: Same.
2166 * dwarf-index-write.c: Same.
2167 * dwarf2-frame.c: Same.
2168 * dwarf2-frame.h: Same.
2169 * eval.c: Same.
2170 * frame-base.h: Same.
2171 * frame.h: Same.
2172 * gdbcmd.h: Same.
2173 * gdbtypes.h: Same.
2174 * gnu-nat.c: Same.
2175 * guile/scm-objfile.c: Same.
2176 * i386-tdep.c: Same.
2177 * i386-tdep.h: Same.
2178 * infcall.c: Same.
2179 * infcall.h: Same.
2180 * linux-nat.c: Same.
2181 * m68k-tdep.c: Same.
2182 * macroexp.c: Same.
2183 * memattr.c: Same.
2184 * mi/mi-cmd-disas.c: Same.
2185 * mi/mi-getopt.h: Same.
2186 * mi/mi-main.c: Same.
2187 * minsyms.c: Same.
2188 * nat/aarch64-sve-linux-sigcontext.h: Same.
2189 * objfiles.h: Same.
2190 * ppc-linux-nat.c: Same.
2191 * ppc-linux-tdep.c: Same.
2192 * ppc-tdep.h: Same.
2193 * progspace.h: Same.
2194 * prologue-value.h: Same.
2195 * python/py-evtregistry.c: Same.
2196 * python/py-instruction.h: Same.
2197 * record-btrace.c: Same.
2198 * record-full.c: Same.
2199 * remote.c: Same.
2200 * rs6000-tdep.c: Same.
2201 * ser-tcp.c: Same.
2202 * sol-thread.c: Same.
2203 * sparc-sol2-tdep.c: Same.
2204 * sparc64-tdep.c: Same.
2205 * stabsread.c: Same.
2206 * symfile.c: Same.
2207 * symtab.h: Same.
2208 * target.c: Same.
2209 * tracepoint.c: Same.
2210 * tui/tui-data.h: Same.
2211 * tui/tui-io.c: Same.
2212 * tui/tui-win.c: Same.
2213 * tui/tui.c: Same.
2214 * unittests/rsp-low-selftests.c: Same.
2215 * user-regs.h: Same.
2216 * utils.c: Same.
2217 * utils.h: Same.
2218 * valarith.c: Same.
2219 * valops.c: Same.
2220 * valprint.c: Same.
2221 * valprint.h: Same.
2222 * value.c: Same.
2223 * value.h: Same.
2224 * varobj.c: Same.
2225 * x86-nat.h: Same.
2226 * xtensa-tdep.c: Same.
2227
2228 2019-10-25 Ali Tamur <tamur@google.com>
2229
2230 * charset.c (find_charset_names): Reflect API change.
2231
2232 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2233
2234 * symtab.c (struct demangled_name_entry): Change demangled name
2235 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2236 part of the struct anymore.
2237 (symbol_set_names): No longer obstack allocate + copy the demangled
2238 name, just store the allocated name from bfd.
2239
2240 2019-10-25 Tom Tromey <tromey@adacore.com>
2241
2242 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2243 (bsearch_cie_cmp, add_cie): Remove.
2244 (find_cie): Reimplement.
2245 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2246 (dwarf2_build_frame_info): Update.
2247
2248 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2249
2250 PR gdb/25126
2251 * symfile.c (reread_symbols): Call forget_cached_source_info to
2252 clear the stale source cache.
2253
2254 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2255
2256 * configure: Regenerate.
2257 * configure.ac: Remove code that sets python_has_threads.
2258
2259 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2260
2261 * config.in: Regenerate.
2262 * configure: Regenerate.
2263 * configure.ac: Remove the code that uses sed to get the python
2264 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2265
2266 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2267
2268 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2269 error paths.
2270
2271 2019-10-23 Tom Tromey <tom@tromey.com>
2272
2273 * arc-tdep.c: Remove ".." from include.
2274 * frv-tdep.c: Remove ".." from include.
2275 * lm32-tdep.c: Remove ".." from include.
2276 * microblaze-tdep.c: Remove ".." from include.
2277 * or1k-tdep.h: Remove ".." from include.
2278 * s12z-tdep.c: Remove ".." from include.
2279 * Makefile.in (OPCODES_CFLAGS): Add comment.
2280 (TOP_CFLAGS): New variable.
2281 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2282
2283 2019-10-23 Tom Tromey <tom@tromey.com>
2284
2285 * Makefile.in (READLINE_DIR): Update.
2286
2287 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2288
2289 * infcall.c (call_function_by_hand_dummy): Fix the function
2290 comment. And extract out a code section into...
2291 (reserve_stack_space): ...this new function.
2292
2293 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2294
2295 * infcall.c (value_arg_coerce): Remove an unused parameter.
2296 (call_function_by_hand_dummy): Update the call to
2297 'value_arg_coerce'.
2298
2299 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2300
2301 * infcall.c (call_function_by_hand_dummy): Refactor.
2302
2303 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2304
2305 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2306
2307 2019-10-23 Tom Tromey <tom@tromey.com>
2308
2309 * configure: Rebuild.
2310 * configure.ac: Don't check for sigprocmask.
2311 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2312
2313 2019-10-23 Tom Tromey <tom@tromey.com>
2314
2315 * configure: Rebuild.
2316 * acinclude.m4: Use m4_include, not sinclude.
2317
2318 2019-10-23 Tom de Vries <tdevries@suse.de>
2319
2320 PR breakpoints/24687
2321 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2322
2323 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2324
2325 * symtab.c (struct demangled_name_entry) <language>: Change from
2326 bitfield to regular variable.
2327
2328 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2329
2330 * symtab.c (struct demangled_name_entry): Add a constructor.
2331 (free_demangled_name_entry): New function to call the destructor
2332 for demangled_name_entry.
2333 (create_demangled_names_hash): Pass free_demangled_name_entry to
2334 htab_create_alloc.
2335 (symbol_set_names): Call placement new for demangled_name_entry.
2336 * utils.c: No longer include xxhash.h here, now that fast_hash
2337 is inlined in the header.
2338 * utils.h: Instead, include it here.
2339
2340 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2341
2342 * Makefile.in: Link with libxxhash.
2343 * config.in: Regenerate.
2344 * configure: Regenerate.
2345 * configure.ac: Search for libxxhash.
2346 * utils.c (fast_hash): Use xxhash if present.
2347
2348 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2349
2350 * utils.h (fast_hash): New function.
2351 * symtab.c (hash_demangled_name_entry): Call new function
2352 fast_hash.
2353
2354 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2355
2356 * symtab.c (struct demangled_name_entry): Change type of mangled
2357 to gdb::string_view. Also adds a constructor that takes the
2358 mangled name.
2359 (hash_demangled_name_entry): Update.
2360 (eq_demangled_name_entry): Update.
2361 (free_demangled_name_entry): New function to call the destructor
2362 now that this is not a POD anymore.
2363 (create_demangled_names_hash): Pass free_demangled_name_entry to
2364 htab_create_alloc.
2365 (symbol_set_names): Update.
2366
2367 2019-10-21 Ali Tamur <tamu@google.com>
2368
2369 * dwarf2read.c (dir_index): Change type.
2370 (file_name_index): Likewise.
2371 (line_header::include_dir_at): Change comment and implementation on
2372 whether it is DWARF 5.
2373 (line_header::is_valid_file_index): New function.
2374 (line_header::file_name_at): Change comment and implementation on
2375 whether it is DWARF 5.
2376 (line_header::file_names): Change to private field renamed as
2377 m_file_names and introduce a new accessor method.
2378 (line_header::file_names_size): New method.
2379 (line_header::include_dirs): Change to private field and rename as
2380 m_include_dirs.
2381 (dw2_get_file_names_reader): Define local var at a smaller scope and
2382 reflect API change.
2383 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2384 (process_structure_scope): Likewise.
2385 (line_header::add_include_dir): Change message and reflect renaming.
2386 (line_header::add_file_name): Likewise.
2387 (read_formatted_entries): Handle DW_FORM_data16.
2388 (dwarf_decode_line_header): Fix line header length calculation.
2389 (psymtab_include_file_name): Change comment and API.
2390 (lnp_state_machine::m_file): Update comment and reflect type change.
2391 (lnp_state_machine::record_line): Reflect type change.
2392 (dwarf_decode_lines): Reflect API change.
2393 (file_file_name): Likewise.
2394 (file_full_name): Likewise.
2395
2396 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2397
2398 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2399
2400 2019-10-21 Tom Tromey <tom@tromey.com>
2401
2402 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2403
2404 2019-10-21 Tom Tromey <tom@tromey.com>
2405
2406 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2407 NM_H. Use AC_CONFIG_LINKS.
2408 * configure: Rebuild.
2409 * Makefile.in (NM_H): New variable.
2410 (generated_files): Add NM_H. Remove gcore.
2411 (nm.h, stamp-nmh): New targets.
2412
2413 2019-10-20 Tom Tromey <tom@tromey.com>
2414
2415 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2416 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2417 obsolete comment.
2418 (put_objfile_before): Now static.
2419
2420 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2421
2422 * gdbsupport/common-utils.h (startswith): Change return type to
2423 bool.
2424
2425 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2426
2427 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2428 * breakpoint.c (bp_locations_compare): Rename to...
2429 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2430 (update_global_location_list): Use std::sort instead of qsort.
2431 * buildsym.c (compare_line_numbers): Rename to...
2432 (lte_is_less_than): ...this, and change to std::sort semantics.
2433 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2434 instead of qsort.
2435 * disasm.c (compare_lines): Rename to...
2436 (line_is_less_than): ...this, and change to std::sort semantics.
2437 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2438 of qsort.
2439 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2440 (fde_is_less_than): ...this, and change to std::sort semantics.
2441 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2442 * mdebugread.c (compare_blocks):
2443 (block_is_less_than): ...this, and change to std::sort semantics.
2444 (sort_blocks): Call std::sort instead of qsort.
2445 * objfiles.c (qsort_cmp): Rename to...
2446 (sort_cmp): ...this, and change to std::sort semantics.
2447 (update_section_map): Call std::sort instead of qsort.
2448 * remote.c (compare_pnums): Remove.
2449 (map_regcache_remote_table): Call std::sort instead of qsort.
2450 * utils.c (compare_positive_ints): Remove.
2451 * utils.h (compare_positive_ints): Remove.
2452 * xcoffread.c (compare_lte): Remove.
2453 (arrange_linetable): Call std::sort instead of qsort.
2454
2455 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2456
2457 * symfile.c (init_entry_point_info): Fix typo.
2458 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2459
2460 2019-10-18 Tom de Vries <tdevries@suse.de>
2461
2462 * aarch64-tdep.c: Fix typos in comments.
2463 * ada-lang.c: Same.
2464 * ada-tasks.c: Same.
2465 * alpha-tdep.c: Same.
2466 * alpha-tdep.h: Same.
2467 * amd64-nat.c: Same.
2468 * amd64-windows-tdep.c: Same.
2469 * arc-tdep.c: Same.
2470 * arc-tdep.h: Same.
2471 * arch-utils.c: Same.
2472 * arm-nbsd-tdep.c: Same.
2473 * arm-tdep.c: Same.
2474 * ax-gdb.c: Same.
2475 * blockframe.c: Same.
2476 * btrace.c: Same.
2477 * c-varobj.c: Same.
2478 * coff-pe-read.c: Same.
2479 * coffread.c: Same.
2480 * cris-tdep.c: Same.
2481 * darwin-nat.c: Same.
2482 * dbxread.c: Same.
2483 * dcache.c: Same.
2484 * disasm.c: Same.
2485 * dtrace-probe.c: Same.
2486 * dwarf-index-write.c: Same.
2487 * dwarf2-frame-tailcall.c: Same.
2488 * dwarf2-frame.c: Same.
2489 * dwarf2read.c: Same.
2490 * eval.c: Same.
2491 * exceptions.c: Same.
2492 * fbsd-tdep.c: Same.
2493 * findvar.c: Same.
2494 * frame.c: Same.
2495 * frv-tdep.c: Same.
2496 * gnu-v3-abi.c: Same.
2497 * go32-nat.c: Same.
2498 * h8300-tdep.c: Same.
2499 * hppa-tdep.c: Same.
2500 * i386-linux-tdep.c: Same.
2501 * i386-tdep.c: Same.
2502 * ia64-libunwind-tdep.c: Same.
2503 * ia64-tdep.c: Same.
2504 * infcmd.c: Same.
2505 * infrun.c: Same.
2506 * linespec.c: Same.
2507 * linux-nat.c: Same.
2508 * linux-thread-db.c: Same.
2509 * machoread.c: Same.
2510 * mdebugread.c: Same.
2511 * mep-tdep.c: Same.
2512 * mn10300-tdep.c: Same.
2513 * namespace.c: Same.
2514 * objfiles.c: Same.
2515 * opencl-lang.c: Same.
2516 * or1k-tdep.c: Same.
2517 * osabi.c: Same.
2518 * ppc-linux-nat.c: Same.
2519 * ppc-linux-tdep.c: Same.
2520 * ppc-sysv-tdep.c: Same.
2521 * printcmd.c: Same.
2522 * procfs.c: Same.
2523 * record-btrace.c: Same.
2524 * record-full.c: Same.
2525 * remote-fileio.c: Same.
2526 * remote.c: Same.
2527 * rs6000-tdep.c: Same.
2528 * s12z-tdep.c: Same.
2529 * score-tdep.c: Same.
2530 * ser-base.c: Same.
2531 * ser-go32.c: Same.
2532 * skip.c: Same.
2533 * sol-thread.c: Same.
2534 * solib-svr4.c: Same.
2535 * solib.c: Same.
2536 * source.c: Same.
2537 * sparc-nat.c: Same.
2538 * sparc-sol2-tdep.c: Same.
2539 * sparc-tdep.c: Same.
2540 * sparc64-tdep.c: Same.
2541 * stabsread.c: Same.
2542 * stack.c: Same.
2543 * symfile.c: Same.
2544 * symtab.c: Same.
2545 * target-descriptions.c: Same.
2546 * target-float.c: Same.
2547 * thread.c: Same.
2548 * utils.c: Same.
2549 * valops.c: Same.
2550 * valprint.c: Same.
2551 * value.c: Same.
2552 * varobj.c: Same.
2553 * windows-nat.c: Same.
2554 * xcoffread.c: Same.
2555 * xstormy16-tdep.c: Same.
2556 * xtensa-tdep.c: Same.
2557
2558 2019-10-17 Tom Tromey <tromey@adacore.com>
2559
2560 * configure: Rebuild.
2561 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2562 in AC_CONFIG_FILES invocation.
2563 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2564 new-style config.status invocation.
2565
2566 2019-10-17 Tom de Vries <tdevries@suse.de>
2567
2568 * arm-nbsd-nat.c: Fix typos in comments.
2569 * arm-tdep.c: Same.
2570 * darwin-nat-info.c: Same.
2571 * dwarf2read.c: Same.
2572 * elfread.c: Same.
2573 * event-top.c: Same.
2574 * findvar.c: Same.
2575 * gdbtypes.c: Same.
2576 * hppa-tdep.c: Same.
2577 * i386-tdep.c: Same.
2578 * jit.c: Same.
2579 * main.c: Same.
2580 * mdebugread.c: Same.
2581 * moxie-tdep.c: Same.
2582 * nto-procfs.c: Same.
2583 * osabi.c: Same.
2584 * ppc-linux-tdep.c: Same.
2585 * remote.c: Same.
2586 * riscv-tdep.c: Same.
2587 * s390-tdep.c: Same.
2588 * sh-tdep.c: Same.
2589 * sparc-linux-tdep.c: Same.
2590 * sparc-nat.c: Same.
2591 * stack.c: Same.
2592 * target-descriptions.c: Same.
2593 * top.c: Same.
2594 * varobj.c: Same.
2595
2596 2019-10-16 Tom Tromey <tom@tromey.com>
2597
2598 * objfiles.h (struct objfile) <original_name>: Now const.
2599
2600 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2601
2602 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2603 pass on to sigsetjmp's second argument.
2604 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2605
2606 2019-10-16 Keith Seitz <keiths@redhat.com>
2607
2608 PR gdb/23567
2609 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2610 sections whose size is greater than the file size.
2611
2612 2019-10-16 Jim Wilson <jimw@sifive.com>
2613
2614 * riscv-tdep.c (riscv_gcc_target_options): New.
2615 (riscv_gnu_triplet_regexp): New.
2616 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2617 set_gdbarch_gnu_triplet_regexp.
2618
2619 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2620
2621 * Makefile.in: Add xml-builtin.h.
2622 * features/feature_to_c.sh: Add an include for xml-builtin.h
2623 to ensure that the compiler checks that the types match.
2624 * xml-builtin.h: New file.
2625 * xml-support.c (fetch_xml_builtin): Add missing const.
2626 * xml-support.h: Remove declaration of xml_builtins.
2627
2628 2019-10-16 Tom de Vries <tdevries@suse.de>
2629
2630 PR tdep/25096
2631 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2632 (amd64_classify_aggregate): ... here.
2633 (amd64_classify_aggregate_field): Handled fiels of nested structs
2634 recursively.
2635
2636 2019-10-16 Tom de Vries <tdevries@suse.de>
2637
2638 PR tdep/24104
2639 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2640 that handles 'theclass'.
2641
2642 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2643
2644 * linespec.c (decode_digits_ordinary): Update comment.
2645 * make-target-delegates: No longer need to handle VEC case.
2646 * memrange.c (normalize_mem_ranges): Update comment.
2647 * namespace.c (add_using_directive): Update comment.
2648 * objc-lang.c (uniquify_strings): Update comment.
2649 * ppc-linux-nat.c (struct thread_points): Update comment.
2650 * probe.h (find_probes_in_objfile): Update comment.
2651 * target.h (enum flash_preserve_mode): Update comment.
2652 * varobj.c (varobj_restrict_range): Update comment.
2653 * varobj.h (varobj_list_children): Update comment.
2654
2655 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2656
2657 * Makefile.in: Remove references to vec.h and vec.c.
2658 * aarch64-tdep.c: No longer include vec.h.
2659 * ada-lang.c: Likewise.
2660 * ada-lang.h: Likewise.
2661 * arm-tdep.c: Likewise.
2662 * ax.h: Likewise.
2663 * breakpoint.h: Likewise.
2664 * charset.c: Likewise.
2665 * cp-support.h: Likewise.
2666 * dtrace-probe.c: Likewise.
2667 * dwarf2read.c: Likewise.
2668 * extension.h: Likewise.
2669 * gdb_bfd.c: Likewise.
2670 * gdbsupport/gdb_vecs.h: Likewise.
2671 * gdbsupport/vec.c: Remove.
2672 * gdbsupport/vec.h: Remove.
2673 * gdbthread.h: Likewise.
2674 * guile/scm-type.c: Likewise.
2675 * inline-frame.c: Likewise.
2676 * machoread.c: Likewise.
2677 * memattr.c: Likewise.
2678 * memrange.h: Likewise.
2679 * namespace.h: Likewise.
2680 * nat/linux-btrace.h: Likewise.
2681 * osdata.c: Likewise.
2682 * parser-defs.h: Likewise.
2683 * progspace.h: Likewise.
2684 * python/py-type.c: Likewise.
2685 * record-btrace.c: Likewise.
2686 * rust-exp.y: Likewise.
2687 * solib-target.c: Likewise.
2688 * stap-probe.c: Likewise.
2689 * target-descriptions.c: Likewise.
2690 * target-memory.c: Likewise.
2691 * target.h: Likewise.
2692 * varobj.c: Likewise.
2693 * varobj.h: Likewise.
2694 * xml-support.h: Likewise.
2695
2696 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2697
2698 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2699 Update for new std::vector based implementation.
2700 (process_psymtab_comp_unit_reader): Likewise.
2701 (scan_partial_symbols): Likewise.
2702 (recursively_compute_inclusions): Likewise.
2703 (compute_compunit_symtab_includes): Likewise.
2704 (process_imported_unit_die): Likewise.
2705 (queue_and_load_dwo_tu): Likewise.
2706 (follow_die_sig_1): Likewise.
2707 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2708 (typedef dwarf2_per_cu_ptr): Remove.
2709 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2710 function.
2711 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2712 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2713 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2714 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2715 std::vector.
2716
2717 2019-10-15 Tom Tromey <tromey@adacore.com>
2718
2719 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2720 TID.
2721
2722 2019-10-15 Tom Tromey <tromey@adacore.com>
2723
2724 * windows-nat.c (windows_nat_target::fetch_registers)
2725 (windows_nat_target::store_registers): Rename "pid" to "tid".
2726
2727 2019-10-15 Tom Tromey <tromey@adacore.com>
2728
2729 * gdbarch.h, gdbarch.c: Rebuild.
2730 * gdbarch.sh (gcc_target_options): Change return type to
2731 std::string.
2732 * compile/compile.c (get_args): Update.
2733 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2734 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2735 std::string.
2736 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2737 std::string.
2738 * arch-utils.c (default_gcc_target_options): Return std::string.
2739 * arch-utils.h (default_gcc_target_options): Return std::string.
2740 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2741
2742 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2743
2744 * breakpoint.c (breakpoint_chain): Make static.
2745 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2746 of accessing breakpoint_chain.
2747
2748 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2749
2750 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2751 to a gdb::function_view and return value to bool.
2752 * breakpoint.h (iterate_over_breakpoints): Likewise.
2753 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2754 (pop_dummy_frame): Update.
2755 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2756 (gdbscm_breakpoints): Update.
2757 * python/py-breakpoint.c (build_bp_list): Update.
2758 (gdbpy_breakpoints): Update.
2759 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2760 Update.
2761 (bpfinishpy_handle_stop): Update.
2762 (bpfinishpy_handle_exit): Update.
2763 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2764 (svr4_update_solib_event_breakpoints): Update.
2765
2766 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2767
2768 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2769 when unwrapping single-field structs.
2770
2771 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2772
2773 * dwarf2read.c: Remove includes.
2774
2775 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2776
2777 * ui-out.c (ui_out::call_do_message): Silence
2778 -Wformat-nonliteral warning.
2779
2780 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2781
2782 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2783 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2784 include: readline/tilde.h.
2785
2786 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2787
2788 * remote.c (remote_target::get_trace_status): Remove declaration of
2789 trace_regblock_size.
2790
2791 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2792
2793 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2794 (show_user): Remove declaration of cmdlist.
2795 * cli/cli-cmds.h (max_user_call_depth): Declare.
2796 * cli/cli-script.c (execute_user_command): Remove declaration
2797 of max_user_call_depth.
2798
2799 2019-10-11 Jim Wilson <jimw@sifive.com>
2800
2801 * gdbsupport/print-utils.h (pulongest): Fix comment.
2802 (plongest): Likewise.
2803 (phex): Add missing comment, mention leading zeros.
2804 (phex_nz): Add mention of no leading zeros to comment.
2805
2806 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2807 plongest instead of unsigned long long cast.
2808
2809 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2810
2811 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2812 for external_editor_command and gdbtk_test.
2813
2814 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2815
2816 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2817 * varobj.c (varobjdebug): Move comment to...
2818 * varobj.h (varobjdebug): ...here, and declare.
2819
2820 2019-10-09 Tom Tromey <tom@tromey.com>
2821
2822 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2823 erase_data_content.
2824
2825 2019-10-09 Tom Tromey <tom@tromey.com>
2826
2827 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2828 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2829 * tui/tui-command.c (tui_cmd_window::resize)
2830 (tui_refresh_cmd_win): Update.
2831 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2832 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2833 * tui/tui-data.c (~tui_gen_win_info): Remove.
2834 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2835 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2836 (tui_redisplay_readline, tui_mld_flush)
2837 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2838 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2839 (tui_data_window::erase_data_content)
2840 (tui_data_item_window::rerender)
2841 (tui_data_item_window::refresh_window): Update.
2842 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2843 (box_win, tui_gen_win_info::make_window)
2844 (tui_gen_win_info::make_visible): Update.
2845 (tui_delete_win): Remove.
2846 * tui/tui-winsource.c
2847 (tui_source_window_base::do_erase_source_content): Update.
2848 (tui_show_source_line, tui_source_window_base::update_tab_width)
2849 (tui_source_window_base::update_exec_info): Update.
2850 * tui/tui-data.h (struct curses_deleter): New.
2851 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2852 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2853
2854 2019-10-09 Tom Tromey <tom@tromey.com>
2855
2856 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2857
2858 2019-10-09 Tom Tromey <tom@tromey.com>
2859
2860 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2861 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2862
2863 2019-10-09 Tom Tromey <tom@tromey.com>
2864
2865 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2866 window height directly.
2867 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2868 declare.
2869 * tui/tui-layout.c (tui_default_win_height): Remove.
2870 (tui_default_win_viewport_height): Remove.
2871
2872 2019-10-09 Tom Tromey <tom@tromey.com>
2873
2874 * tui/tui.h: Remove comments.
2875
2876 2019-10-09 Tom de Vries <tdevries@suse.de>
2877
2878 * python/lib/gdb/printer/bound_registers.py: Use
2879 '^builtin_type_bound128' as regexp argument for
2880 add_builtin_pretty_printer.
2881
2882 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2883
2884 * guile/guile.c (guile_extension_script_ops): Remove forward
2885 declaration and mark as static.
2886 (guile_script_ops): Likewise.
2887 (extension_language_guile): Move further down in the file so
2888 it can reference the definitions for guile_{extension_,}script_ops.
2889
2890 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2891
2892 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2893 except SORTL, DFLTCC, and KDSA.
2894
2895 2019-10-08 Tom Tromey <tromey@adacore.com>
2896
2897 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2898 (struct safe_symbol_file_add_args): Remove.
2899
2900 2019-10-08 Tom Tromey <tromey@adacore.com>
2901
2902 * windows-nat.c: Don't include buildsym-legacy.h.
2903
2904 2019-10-08 Tom Tromey <tromey@adacore.com>
2905
2906 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2907
2908 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2909
2910 * gdbtypes.c (overload_debug): Move comment to header.
2911 * gdbtypes.h (overload_debug): Declare.
2912 * valops.c: Remove declaration of overload_debug, instead
2913 include gdbtypes.h.
2914
2915 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2916
2917 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2918 through _().
2919 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2920 move comment...
2921 * language.h (lang_frame_mismatch_warn): ... here. Also add
2922 declaration.
2923 * top.c (lang_frame_mismatch_warn): Remove declaration.
2924 (check_frame_language_change): Pass lang_frame_mismatch_warn
2925 through _().
2926
2927 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2928
2929 * c-lang.h (vtbl_ptr_name): Declare.
2930 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2931 it from the header.
2932 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2933
2934 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2935
2936 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2937 gdb_static_assert.
2938
2939 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2940
2941 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2942 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2943 * ctfread.c: New file.
2944 * ctfread.h: New file.
2945 * elfread.c: Include ctfread.h.
2946 (struct elfinfo text_p): New member ctfsect.
2947 (elf_locate_sections): Mark CTF section.
2948 (elf_symfile_read): Call elfctf_build_psymtabs.
2949 * Makefile.in (LIBCTF): Add.
2950 (CLIBS): Use it.
2951 (CDEPS): Likewise.
2952 (DIST): Add ctfread.c.
2953
2954 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2955
2956 * ctfread.c (struct nextfield): Renamed to ...
2957 (struct ctf_nextfield): ... this.
2958 (struct field_info): Renamed to ...
2959 (strut ctf_field_info): ... this.
2960 (attach_fields_to_type): Update for renamed structures.
2961 (ctf_add_member_cb): Likewise.
2962 (ctf_add_enum_member_cb): Likewise.
2963 (process_struct_members): Likewise.
2964 (process_enum_type): Likewise.
2965
2966 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2967
2968 * tracectf.h: Rename, was ctf.h.
2969 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2970 * tracefile.c: Likewise.
2971 * tracepoint.c: Remove unused include ctf.h.
2972 * mi/mi-main.c: Likewise.
2973 * Makefile.in Replace ctf.c with tracectf.c.
2974
2975 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2976
2977 * version.in: Change version number to "9.0.50.DATE-git".
2978
2979 2019-10-03 Tom Tromey <tom@tromey.com>
2980
2981 PR rust/24976:
2982 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2983
2984 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2985
2986 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2987 cp_search_name_hash.
2988 * NEWS: Add entry about nested function support.
2989
2990 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2991 Andrew Burgess <andrew.burgess@embecosm.com>
2992
2993 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2994 for nested static variables when searchin VAR_DOMAIN.
2995 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2996 global scope, update comment.
2997 (add_partial_subprogram): Call add_partial_subprogram recursively
2998 for nested subroutines when processinng Fortran.
2999 (load_partial_dies): Process the child entities of a subprogram
3000 when processing Fortran.
3001 (partial_die_parent_scope): Handle building scope
3002 for Fortran nested functions.
3003 (process_die): Record that nested functions have a scope.
3004 (new_symbol): Always record Fortran subprograms on the global
3005 symbol list.
3006 (determine_prefix): How to build the prefix for Fortran
3007 subprograms.
3008
3009 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3010
3011 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3012 have just sent the thread a SIGSTOP and are waiting for it to
3013 arrive.
3014
3015 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3016
3017 * btrace.c (btrace_add_pc): Remove whitespace before the template
3018 parameter in 'std::vector <...>'.
3019 (parse_xml_btrace_block): Likewise.
3020 (btrace_maint_decode_pt): Likewise.
3021 (btrace_maint_update_packets): Likewise.
3022 (btrace_maint_print_packets): Likewise.
3023 * btrace.h (struct btrace_maint_info): Likewise.
3024 * dwarf2read.c (struct type_unit_group): Likewise.
3025 (build_type_psymtabs_reader): Likewise.
3026 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3027 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3028 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3029
3030 2019-10-03 Tom de Vries <tdevries@suse.de>
3031
3032 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3033 the first line of the help text for set/show style metadata.
3034
3035 2019-10-02 Tom Tromey <tromey@adacore.com>
3036
3037 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3038 * gdbsupport/common-inferior.c: New file.
3039 * infcmd.c (startup_with_shell): Don't define.
3040 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3041 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3042 * inferior.h (startup_with_shell): Don't declare.
3043
3044 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3045
3046 * gdbsupport/gdb_assert.h: Include errors.h.
3047 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3048
3049 2019-10-02 Tom Tromey <tromey@adacore.com>
3050
3051 * NEWS: Add $_ada_exception entry.
3052 * ada-lang.c (struct ada_catchpoint): Add constructor.
3053 <m_kind>: New member.
3054 (allocate_location_exception, re_set_exception): Remove
3055 "ex" parameter.
3056 (should_stop_exception): Compute $_ada_exception.
3057 (check_status_exception, print_it_exception)
3058 (print_one_exception, print_mention_exception): Remove
3059 "ex" parameter.
3060 (allocate_location_catch_exception, re_set_catch_exception)
3061 (check_status_exception, print_it_catch_exception)
3062 (print_one_catch_exception, print_mention_catch_exception)
3063 (print_recreate_catch_exception)
3064 (allocate_location_catch_exception_unhandled)
3065 (re_set_catch_exception_unhandled)
3066 (check_status_exception, print_it_catch_exception_unhandled)
3067 (print_one_catch_exception_unhandled)
3068 (print_mention_catch_exception_unhandled)
3069 (print_recreate_catch_exception_unhandled)
3070 (allocate_location_catch_assert, re_set_catch_assert)
3071 (check_status_assert, print_it_catch_assert)
3072 (print_one_catch_assert, print_mention_catch_assert)
3073 (print_recreate_catch_assert)
3074 (allocate_location_catch_handlers, re_set_catch_handlers)
3075 (check_status_handlers, print_it_catch_handlers)
3076 (print_one_catch_handlers, print_mention_catch_handlers)
3077 (print_recreate_catch_handlers): Remove.
3078 (create_ada_exception_catchpoint): Update.
3079 (initialize_ada_catchpoint_ops): Update.
3080
3081 2019-10-02 Tom Tromey <tromey@adacore.com>
3082
3083 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3084 (create_excep_cond_exprs): Simplify exception string computation.
3085 (ada_exception_catchpoint_cond_string): Likewise.
3086
3087 2019-10-02 Tom Tromey <tromey@adacore.com>
3088
3089 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3090 * ada-lang.c (lesseq_defined_than): Handle
3091 LOC_STATIC.
3092 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3093 parameter.
3094 (dwarf2_has_info): Likewise.
3095 (new_symbol): Set maybe_copied on symbol when
3096 appropriate.
3097 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3098 parameter.
3099 <can_copy>: New member.
3100 * elfread.c (record_minimal_symbol): Set maybe_copied
3101 on symbol when appropriate.
3102 (elf_symfile_read): Update call to dwarf2_has_info.
3103 * minsyms.c (lookup_minimal_symbol_linkage): New
3104 function.
3105 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3106 * symtab.c (get_symbol_address, get_msymbol_address):
3107 New functions.
3108 * symtab.h (get_symbol_address, get_msymbol_address):
3109 Declare.
3110 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3111 maybe_copied.
3112 (struct symbol, struct minimal_symbol) <maybe_copied>:
3113 New member.
3114
3115 2019-10-02 Tom Tromey <tromey@adacore.com>
3116
3117 * source.c (struct current_source_location): New.
3118 (current_source_key): New global.
3119 (current_source_symtab, current_source_line)
3120 (current_source_pspace): Remove.
3121 (get_source_location): New function.
3122 (get_current_source_symtab_and_line)
3123 (set_default_source_symtab_and_line)
3124 (set_current_source_symtab_and_line)
3125 (clear_current_source_symtab_and_line, select_source_symtab)
3126 (info_source_command, print_source_lines_base)
3127 (info_line_command, search_command_helper, _initialize_source):
3128 Update.
3129
3130 2019-10-02 Tom Tromey <tromey@adacore.com>
3131
3132 * source.c (select_source_symtab): Don't call
3133 decode_line_with_current_source.
3134
3135 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3136
3137 * symtab.c (lookup_global_symbol): Search global block.
3138
3139 2019-10-02 Tom Tromey <tromey@adacore.com>
3140
3141 * coffread.c (process_coff_symbol): Update.
3142 * dwarf2read.c (var_decode_location, new_symbol): Update.
3143 * mdebugread.c (parse_symbol): Update.
3144 * objfiles.c (relocate_one_symbol): Update.
3145 * stabsread.c (define_symbol, fix_common_block)
3146 (scan_file_globals): Update.
3147 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3148 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3149 * xcoffread.c (process_xcoff_symbol): Update.
3150
3151 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3152
3153 * MAINTAINERS: Update my email address.
3154
3155 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3156
3157 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3158 std::vector.
3159 (build_type_psymtabs_reader): Update for std::vector.
3160 (build_type_psymtab_dependencies): Likewise.
3161 * dwarf2read.h: Remove use of DEF_VEC_P.
3162 (typedef sig_type_ptr): Delete.
3163
3164 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3165
3166 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3167 to std::vector.
3168 (btrace_maint_decode_pt): Likewise, and move allocation of the
3169 vector outside of the loop.
3170 (btrace_maint_update_packets): Update to handle change from VEC to
3171 std::vector.
3172 (btrace_maint_print_packets): Likewise.
3173 (maint_info_btrace_cmd): Likewise.
3174 * btrace.h: Remove use of DEF_VEC_O.
3175 (typedef btrace_pt_packet_s): Delete.
3176 (struct btrace_maint_info) <packets>: Change fromm VEC to
3177 std::vector.
3178 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3179
3180 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3181
3182 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3183 make accesses into the vector constant references.
3184 (btrace_add_pc): Update for std::vector.
3185 (btrace_stitch_bts): Likewise.
3186 (parse_xml_btrace_block): Likewise.
3187 (btrace_maint_update_packets): Likewise.
3188 (btrace_maint_print_packets): Likewise.
3189 (maint_info_btrace_cmd): Likewise.
3190 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3191 std::vector.
3192 (btrace_data::empty): Likewise.
3193 (btrace_data_append): Likewise.
3194 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3195 (typedef btrace_block_s): Delete.
3196 (struct btrace_block): Add constructor.
3197 (struct btrace_data_bts) <blocks>: Change to std::vector.
3198 * nat/linux-btrace.c (perf_event_read_bts): Update for
3199 std::vector.
3200 (linux_read_bts): Likewise.
3201
3202 2019-10-01 Tom Tromey <tom@tromey.com>
3203
3204 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3205
3206 2019-10-01 Tom Tromey <tom@tromey.com>
3207
3208 * stack.c (print_frame, info_frame_command_core): Use
3209 styled_string.
3210 * linux-thread-db.c (try_thread_db_load_1)
3211 (try_thread_db_load_from_pdir_1): Use styled_string.
3212 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3213 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3214 (maybe_print_unsupported_script_warning)
3215 (maybe_print_script_not_found_warning): Use styled_string.
3216 * ada-lang.c (user_select_syms): Use styled_string.
3217
3218 2019-10-01 Tom Tromey <tom@tromey.com>
3219
3220 * p-lang.c (pascal_printstr): Use metadata style.
3221 * value.c (show_convenience): Use metadata style.
3222 * valprint.c (valprint_check_validity, val_print_optimized_out)
3223 (val_print_not_saved, val_print_unavailable)
3224 (val_print_invalid_address, generic_val_print, val_print)
3225 (value_check_printable, val_print_array_elements): Use metadata
3226 style.
3227 * ui-out.h (class ui_out) <field_fmt>: New overload.
3228 <do_field_fmt>: Add style parameter.
3229 * ui-out.c (ui_out::field_fmt): New overload.
3230 * typeprint.c (type_print_unknown_return_type)
3231 (val_print_not_allocated, val_print_not_associated): Use metadata
3232 style.
3233 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3234 parameter.
3235 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3236 * tracepoint.c (tvariables_info_1): Use metadata style.
3237 * stack.c (print_frame_arg, print_frame_info, print_frame)
3238 (info_frame_command_core): Use metadata style.
3239 * skip.c (info_skip_command): Use metadata style.
3240 * rust-lang.c (rust_print_enum): Use metadata style.
3241 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3242 metadata style.
3243 * python/py-framefilter.c (py_print_single_arg): Use metadata
3244 style.
3245 * printcmd.c (do_one_display, print_variable_and_value): Use
3246 metadata style.
3247 * p-valprint.c (pascal_val_print)
3248 (pascal_object_print_value_fields): Use metadata style.
3249 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3250 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3251 parameter.
3252 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3253 * m2-valprint.c (m2_print_long_set): Use metadata style.
3254 * m2-typeprint.c (m2_print_type): Use metadata style.
3255 * infcmd.c (print_return_value_1): Use metadata style.
3256 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3257 * f-valprint.c (info_common_command_for_block): Use metadata
3258 style.
3259 * f-typeprint.c (f_type_print_base): Use metadata style.
3260 * expprint.c (print_subexp_standard): Use metadata style.
3261 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3262 * cli/cli-style.h (class cli_style_option): Add constructor.
3263 (metadata_style): Declare.
3264 * cli/cli-style.c (metadata_style): New global.
3265 (_initialize_cli_style): Register metadata style.
3266 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3267 parameter.
3268 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3269 * c-typeprint.c (c_type_print_base_struct_union)
3270 (c_type_print_base_1): Use metadata style.
3271 * breakpoint.c (watchpoint_value_print)
3272 (print_one_breakpoint_location): Use metadata style.
3273 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3274 style.
3275 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3276 style.
3277 * ada-valprint.c (val_print_packed_array_elements, printstr)
3278 (print_field_values, ada_val_print_ref, ada_val_print): Use
3279 metadata style.
3280 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3281 style.
3282 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3283 style.
3284 * ada-lang.c (user_select_syms): Use metadata style.
3285
3286 2019-10-01 Tom Tromey <tom@tromey.com>
3287
3288 * cli/cli-cmds.c (pwd_command): Style output.
3289
3290 2019-10-01 Pedro Alves <palves@redhat.com>
3291 Tom Tromey <tom@tromey.com>
3292
3293 * symtab.c (print_symbol_info): Use %ps.
3294 (print_msymbol_info): Use %ps.
3295 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3296 * printcmd.c (print_variable_and_value): Use %ps.
3297 * macrocmd.c (show_pp_source_pos): Use %ps.
3298 * infrun.c (print_exited_reason): Use ui_out::message.
3299 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3300 (describe_other_breakpoints): Use ui_out::message and new
3301 formats.
3302 (say_where): Use new formats.
3303 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3304 and new formats.
3305
3306 2019-10-01 Pedro Alves <palves@redhat.com>
3307 Tom Tromey <tom@tromey.com>
3308
3309 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3310 (test_gdb_formats): New function.
3311 (run_tests): Call it.
3312 (test_format_specifier): Update.
3313 * utils.h (fputs_filtered): Update comment.
3314 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3315 (fputs_styled_unfiltered): Declare.
3316 * utils.c (fputs_styled_unfiltered): New function.
3317 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3318 (vfprintf_filtered): Update.
3319 (vfprintf_unfiltered, vprintf_filtered): Update.
3320 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3321 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3322 disallow_ui_out_field>: New constants.
3323 (enum class field_kind): New.
3324 (struct base_field_s, struct signed_field_s): New.
3325 (signed_field): New function.
3326 (struct string_field_s): New.
3327 (string_field): New function.
3328 (struct styled_string_s): New.
3329 (styled_string): New function.
3330 (class ui_out) <message>: Add comment.
3331 <vmessage, call_do_message>: New methods.
3332 <do_message>: Add style parameter.
3333 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3334 methods.
3335 (ui_out::message): Rewrite.
3336 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3337 parameter.
3338 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3339 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3340 gdb_extensions parameter.
3341 (class format_piece): Add parameter to constructor.
3342 (n_int_args): New field.
3343 * gdbsupport/format.c (format_pieces::format_pieces): Add
3344 gdb_extensions parameter. Handle '*'.
3345 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3346 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3347 vfprintf_styled_no_gdbfmt.
3348 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3349 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3350 unfiltered output.
3351 * ui-style.h (struct ui_file_style) <ptr>: New method.
3352
3353 2019-10-01 Tom Tromey <tom@tromey.com>
3354
3355 * unittests/format_pieces-selftests.c: Update. Add final format.
3356 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3357 empty literal pieces.
3358
3359 2019-10-01 Tom Tromey <tom@tromey.com>
3360
3361 * ui-out.h (enum class ui_out_style_kind): Remove.
3362 (class ui_out) <field_string, field_stsream, do_field_string>:
3363 Change type of "style".
3364 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3365 (ui_out::field_string): Update.
3366 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3367 of "style".
3368 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3369 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3370 * stack.c (print_frame_arg, print_frame_info, print_frame):
3371 Update.
3372 * source.c (print_source_lines_base): Update.
3373 * solib.c (info_sharedlibrary_command): Update.
3374 * skip.c (info_skip_command): Update.
3375 * record-btrace.c (btrace_call_history_src_line)
3376 (btrace_call_history): Update.
3377 * python/py-framefilter.c (py_print_frame): Update.
3378 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3379 "style".
3380 * mi/mi-out.c (mi_ui_out::do_table_header)
3381 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3382 (mi_ui_out::do_field_string): Update.
3383 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3384 Update.
3385 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3386 "style".
3387 * cli-out.c (cli_ui_out::do_table_header)
3388 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3389 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3390 (cli_ui_out::do_field_fmt): Update.
3391 * breakpoint.c (print_breakpoint_location): Update.
3392 (update_static_tracepoint): Update.
3393
3394 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3395
3396 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3397 conversion of gdb_datadir.
3398 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3399 remove not needed c_str ().
3400
3401 2019-09-30 Ali Tamur <tamur@google.com>
3402
3403 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3404 (dwarf2_string_attr): Likewise.
3405
3406 2019-09-30 Ali Tamur <tamur@google.com>
3407
3408 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3409 (process_full_type_unit): Likewise.
3410 (dump_die_shallow): Likewise.
3411 (cu_debug_loc_section): Likewise.
3412
3413 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3414
3415 * minsyms.c (compare_minimal_symbols): Rename to...
3416 (minimal_symbol_is_less_than): ...this, and adjust to STL
3417 conventions (return bool, take arguments as references)
3418 (minimal_symbol_reader::install): Call std::sort instead
3419 of qsort.
3420
3421 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3422
3423 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3424 hash and why.
3425 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3426 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3427
3428 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3429
3430 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3431 * psympriv.h (add_psymbol_to_list): Move comment here and update
3432 it.
3433
3434 2019-09-29 Tom de Vries <tdevries@suse.de>
3435
3436 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3437 Use $tmpdir/$(basename "$output_file").dwz instead of
3438 "${output_file}.dwz".
3439
3440 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3441
3442 PR gdb/25045
3443 * hppa-linux-nat.c: Include gdbarch.h.
3444
3445 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3446
3447 * blockframe.c (find_pc_partial_function): Change return type to bool.
3448 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3449 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3450 (stub_gnu_ifunc_resolve_name): Likewise.
3451 * symtab.c (compare_filenames_for_search): Likewise.
3452 (compare_glob_filenames_for_search): Likewise.
3453 (matching_obj_sections): Likewise.
3454 (symbol_matches_domain): Likewise.
3455 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3456 (find_line_pc): Change return type to bool.
3457 (find_line_pc_range): Likewise.
3458 (producer_is_realview): Likewise.
3459 * symtab.h (symbol_matches_domain): Likewise.
3460 (find_pc_partial_function): Likewise.
3461 (find_pc_line_pc_range): Likewise.
3462 (in_gnu_ifunc_stub): Likewise.
3463 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3464 (find_line_pc): Likewise.
3465 (find_line_pc_range): Likewise.
3466 (matching_obj_sections): Likewise.
3467 (find_line_symtab): Change out parameter to bool.
3468 (producer_is_realview): Change return type to bool.
3469 (compare_filenames_for_search): Likewise.
3470 (compare_glob_filenames_for_search): Likewise.
3471
3472 2019-09-26 Tom Tromey <tom@tromey.com>
3473
3474 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3475 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3476 * gdb_usleep.h: Remove.
3477 * gdb_usleep.c: Remove.
3478 * utils.c: Don't include gdb_usleep.h.
3479
3480 2019-09-26 Tom Tromey <tromey@adacore.com>
3481
3482 * python/py-type.c (type_to_type_object): Call check_typedef
3483 for stub types.
3484
3485 2019-09-26 Tom Tromey <tom@tromey.com>
3486
3487 * utils.h (initialize_utils): Don't declare.
3488 * top.c (gdb_init): Don't call initialize_utils.
3489 * utils.c (initialize_utils): Remove. Move contents...
3490 (_initialize_utils): ... here.
3491
3492 2019-09-25 Tom Tromey <tom@tromey.com>
3493
3494 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3495 * utils.h (make_hex_string): Don't declare.
3496 * utils.c (make_hex_string): Remove.
3497
3498 2019-09-24 Tom de Vries <tdevries@suse.de>
3499
3500 PR gdb/23815
3501 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3502 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3503
3504 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3505
3506 * NEWS: Mention new simulator port for PRU.
3507
3508 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3509
3510 * ada-exp.y (write_object_remaining): Update.
3511 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3512 and eliminate the static buffer.
3513 (ada_decode_symbol): Update.
3514 (ada_la_decode): Update.
3515 (ada_sniff_from_mangled_name): Update.
3516 (is_valid_name_for_wild_match): Update.
3517 (ada_lookup_name_info::matches): Update and simplify.
3518 (name_matches_regex): Update.
3519 (ada_add_global_exceptions): Update.
3520 * ada-lang.h (ada_decode): Update signature.
3521 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3522 * dwarf-index-write.c (debug_names::insert): Update.
3523
3524 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3525
3526 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3527 formatting.
3528
3529 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3530
3531 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3532 Change "nonzero" to "true" in documentation.
3533
3534 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3535
3536 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3537 (_initialize_darwin_solib): Don't set
3538 darwin_so_ops.lookup_lib_global_symbol.
3539 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3540 set_gdbarch_iterate_over_objfiles_in_search_order.
3541 (elf_lookup_lib_symbol): Rename to...
3542 (svr4_iterate_over_objfiles_in_search_order): this, and update
3543 to iterate semantics.
3544 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3545 * solib.c (solib_global_lookup): Remove.
3546 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3547 (solib_global_lookup): Remove.
3548 * symtab.c (lookup_global_or_static_symbol): Remove call to
3549 solib_global_lookup.
3550
3551 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3552
3553 * NEWS: Move entries about default MI version now being
3554 version 3, and about the GDB/MI fix for multi-location
3555 breakpoints to the "since GDB 8.3" section.
3556
3557 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3558
3559 GDB 8.3.1 released.
3560
3561 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3562
3563 * NEWS: Mention that Cell/B.E. debugging support was removed.
3564 * MAINTAINERS: Remove spu target.
3565
3566 * config/djgpp/fnchange.lst: Remove entries for removed files.
3567
3568 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3569 spu-multiarch.o, and spu-tdep.o.
3570 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3571 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3572 spu-multiarch.c, and spu-tdep.c.
3573 * spu-linux-nat.c: Remove file.
3574 * spu-multiarch.c: Remove file.
3575 * spu-tdep.c: Remove file.
3576 * spu-tdep.h: Remove file.
3577 * solib-spu.c: Remove file.
3578 * solib-spu.h: Remove file.
3579
3580 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3581 * configure.nat (spu-linux): Remove.
3582 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3583 solib-multiarch.o from gdb_target_obs.
3584 (spu*-*-*): Remove.
3585
3586 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3587 feature flag.
3588 (ppc_linux_no_features): Update.
3589 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3590 Cell/B.E. support.
3591 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3592 (tdesc_powerpc_cell64l): Likewise.
3593 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3594 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3595 Cell/B.E. support.
3596 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3597 Do not include "features/rs6000/powerpc-cell32l.c" or
3598 "features/rs6000/powerpc-cell64l.c".
3599 (ppc_linux_spu_section): Remove.
3600 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3601 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3602 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3603 (ppc_linux_spe_context_lookup): Remove.
3604 (ppc_linux_spe_context_inferior_created): Remove.
3605 (ppc_linux_spe_context_solib_loaded): Remove.
3606 (ppc_linux_spe_context_solib_unloaded): Remove.
3607 (ppc_linux_spe_context): Remove.
3608 (struct ppu2spu_cache): Remove.
3609 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3610 (struct ppu2spu_data): Remove.
3611 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3612 ppu2spu_unwind): Remove.
3613 (ppc_linux_init_abi): Remove Cell/B.E. support.
3614 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3615
3616 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3617 (rs6000/powerpc-cell64l-expedite): Likewise
3618 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3619 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3620 rs6000/powerpc-cell64l.xml.
3621 * features/rs6000/powerpc-cell32l.xml: Remove.
3622 * features/rs6000/powerpc-cell64l.xml: Likewise.
3623 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3624 * features/rs6000/powerpc-cell64l.c: Likewise.
3625 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3626 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3627 * regformats/reg-spu.dat: Remove.
3628
3629 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3630 * corelow.c (struct spuid_list): Remove.
3631 (add_to_spuid_list): Remove.
3632 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3633 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3634 (remote_protocol_features): Remove associated entries.
3635 (_initialize_remote): No longer initialize them.
3636 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3637 * linux-nat.c (SPUFS_MAGIC): Remove.
3638 (linux_proc_xfer_spu): Remove.
3639 (spu_enumerate_spu_ids): Remove.
3640 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3641 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3642 (linux_make_corefile_notes): No longer call it.
3643
3644 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3645 (cooked_write_test): Likewise.
3646
3647 2019-09-20 Tom Tromey <tom@tromey.com>
3648
3649 * NEWS: Mention case-sensitivity of TUI commands.
3650 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3651 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3652 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3653
3654 2019-09-20 Tom Tromey <tom@tromey.com>
3655
3656 * tui/tui-source.c (tui_source_window::set_contents): Use
3657 make_unique_xstrdup.
3658 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3659 make_unique_xstrdup.
3660
3661 2019-09-20 Tom Tromey <tom@tromey.com>
3662
3663 * tui/tui-data.c: Remove separator comments.
3664 * tui/tui-layout.c: Remove separator comments.
3665 * tui/tui-win.c: Remove separator comments.
3666 * tui/tui-wingeneral.c: Remove separator comments.
3667
3668 2019-09-20 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui.h (strcat_to_buf): Don't declare.
3671 * tui/tui.c (strcat_to_buf): Remove.
3672
3673 2019-09-20 Tom Tromey <tom@tromey.com>
3674
3675 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3676 from "fullname".
3677 * tui/tui-source.c (tui_source_window::set_contents)
3678 (tui_source_window::location_matches_p)
3679 (tui_source_window::maybe_update): Update.
3680
3681 2019-09-20 Tom Tromey <tom@tromey.com>
3682
3683 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3684 Update.
3685 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3686 prefix.
3687 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3688 (tui_data_window::line_from_reg_element_no)
3689 (tui_data_window::first_reg_element_no_inline)
3690 (tui_data_window::show_registers)
3691 (tui_data_window::show_register_group)
3692 (tui_data_window::display_registers_from)
3693 (tui_data_window::display_registers_from_line)
3694 (tui_data_window::first_data_item_displayed)
3695 (tui_data_window::delete_data_content_windows)
3696 (tui_data_window::erase_data_content)
3697 (tui_data_window::do_scroll_vertical)
3698 (tui_data_window::refresh_window)
3699 (tui_data_window::check_register_values): Update.
3700
3701 2019-09-20 Tom Tromey <tom@tromey.com>
3702
3703 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3704 (struct tui_locator_window) <full_name, proc_name>: Now
3705 std::string.
3706 * tui/tui-stack.c (tui_locator_window::make_status_line)
3707 (tui_locator_window::set_locator_fullname)
3708 (tui_locator_window::set_locator_info): Update.
3709 * tui/tui-source.c (tui_source_window::set_contents)
3710 (tui_source_window::showing_source_p): Update.
3711
3712 2019-09-20 Tom Tromey <tom@tromey.com>
3713
3714 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3715 Don't call tui_locator_win_info_ptr.
3716
3717 2019-09-20 Tom Tromey <tom@tromey.com>
3718
3719 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3720
3721 2019-09-20 Tom Tromey <tom@tromey.com>
3722
3723 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3724 height for locator.
3725 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3726 * tui/tui-layout.c (show_source_disasm_command, show_data)
3727 (show_source_or_disasm_and_command): Use 1 as height for locator.
3728
3729 2019-09-20 Tom Tromey <tom@tromey.com>
3730
3731 * tui/tui.c (tui_enable): Update.
3732 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3733 Update.
3734 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3735 Update.
3736 * tui/tui-data.c (win_resized): Now bool.
3737 (tui_win_resized): Return bool.
3738 (tui_set_win_resized_to): Accept a bool.
3739
3740 2019-09-20 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3743 Change type of "refresh_values_only".
3744 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3745 type of "refresh_values_only".
3746
3747 2019-09-20 Tom Tromey <tom@tromey.com>
3748
3749 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3750 std::string.
3751 (tui_disassemble): Add "pos" parameter.
3752 (tui_disasm_window::set_contents): Simplify.
3753
3754 2019-09-20 Tom Tromey <tom@tromey.com>
3755
3756 * tui/tui-winsource.h (struct tui_source_window_base)
3757 <show_source_content>: Now private.
3758 * tui/tui-winsource.c
3759 (tui_source_window_base::show_source_content): Don't handle empty
3760 content case.
3761
3762 2019-09-20 Tom Tromey <tom@tromey.com>
3763
3764 * tui/tui-layout.c (show_source_disasm_command)
3765 (show_source_or_disasm_and_command): Don't call
3766 show_source_content.
3767
3768 2019-09-20 Tom Tromey <tom@tromey.com>
3769
3770 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3771 Declare.
3772 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3773 from tui_make_status_line.
3774 (tui_locator_window::rerender): Update.
3775
3776 2019-09-20 Tom Tromey <tom@tromey.com>
3777
3778 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3779 (tui_locator_window::rerender): Update.
3780
3781 2019-09-20 Tom Tromey <tom@tromey.com>
3782
3783 * tui/tui-winsource.h (struct tui_source_window_base)
3784 <~tui_source_window_base>: Don't declare.
3785 <fullname>: Remove.
3786 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3787 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3788 member.
3789 * tui/tui-source.c (tui_source_window::set_contents): Update.
3790 (tui_source_window::location_matches_p)
3791 (tui_source_window::maybe_update): Update.
3792
3793 2019-09-20 Tom Tromey <tom@tromey.com>
3794
3795 * tui/tui-winsource.h (~tui_source_element): Remove.
3796 (tui_source_element): Update.
3797 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3798 * tui/tui-winsource.c (tui_show_source_line): Update.
3799 * tui/tui-source.c (tui_source_window::set_contents): Update.
3800 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3801
3802 2019-09-20 Tom Tromey <tom@tromey.com>
3803
3804 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3805 declare.
3806 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3807 tui_clear_source_windows_detail.
3808 * tui/tui-winsource.h (struct tui_source_window_base)
3809 <clear_detail>: Don't declare.
3810 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3811 Remove.
3812 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3813
3814 2019-09-20 Tom Tromey <tromey@adacore.com>
3815
3816 PR ada/24919:
3817 * block.c (contained_in): Fix final return value.
3818
3819 2019-09-20 Alan Modra <amodra@gmail.com>
3820
3821 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3822 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3823 (read_indirect_string_from_dwz): Use bfd accessor.
3824 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3825 * machoread.c (macho_symfile_read_all_oso): Likewise.
3826 * solib.c (solib_bfd_open): Likewise.
3827
3828 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3829
3830 * eval.c: Move declaration of overload_resolution to...
3831 * value.h: ...here.
3832
3833 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3834
3835 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3836 * arm-linux-tdep.c: Likewise.
3837 * arm-nbsd-nat.c: Likewise.
3838 * arm-tdep.h: Declare arm_apcs_32.
3839 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3840
3841 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3842
3843 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3844 * dwarf2read.h: Declare dwarf_always_disassemble.
3845
3846 2019-09-19 Tom de Vries <tdevries@suse.de>
3847
3848 PR gdb/25009
3849 * source-cache.c (source_cache::ensure): Catch exception thrown during
3850 construction of the highlighter.
3851
3852 2019-09-18 Alan Modra <amodra@gmail.com>
3853
3854 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3855 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3856 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3857 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3858 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3859 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3860 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3861 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3862 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3863 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3864 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3865 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3866 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3867 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3868 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3869 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3870 * mi/mi-interp.c: Update throughout for bfd section macro and
3871 function changes.
3872 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3873 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3874
3875 2019-09-18 Tom Tromey <tom@tromey.com>
3876
3877 * NEWS: Add entry.
3878 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3879 call rl_initialize.
3880 (tui_enable): Do not call rl_initialize.
3881
3882 2019-09-18 Christian Groessler <chris@groessler.org>
3883
3884 * alpha-linux-nat.c: Include gdbarch.h.
3885
3886 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3887
3888 * ui-file.c: Include cli/cli-style.h.
3889 (term_cli_styling): Remove cli_styling declaration.
3890
3891 2019-09-18 Alan Modra <amodra@gmail.com>
3892
3893 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3894 to bfd_asymbol_section.
3895
3896 2019-09-18 Alan Modra <amodra@gmail.com>
3897
3898 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3899 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3900 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3901
3902 2019-09-18 Alan Modra <amodra@gmail.com>
3903
3904 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3905 * spu-linux-nat.c (spu_bfd_open): Likewise.
3906
3907 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3908
3909 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3910 to bool to match definition in dwarf2read.c.
3911
3912 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3913
3914 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3915 (print_signatures): Likewise.
3916 (trust_pad_over_xvs): Likewise.
3917 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3918 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3919 * arm-linux-nat.c (arm_apcs_32): Likewise.
3920 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3921 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3922 * arm-tdep.c (arm_debug): Likewise.
3923 (arm_apcs_32): Likewise.
3924 * auto-load.c (debug_auto_load): Likewise.
3925 (auto_load_gdb_scripts): Likewise.
3926 (global_auto_load): Likewise.
3927 (auto_load_local_gdbinit): Likewise.
3928 (auto_load_local_gdbinit_loaded): Likewise.
3929 * auto-load.h (global_auto_load): Likewise.
3930 (auto_load_local_gdbinit): Likewise.
3931 (auto_load_local_gdbinit_loaded): Likewise.
3932 * breakpoint.c (disconnected_dprintf): Likewise.
3933 (breakpoint_proceeded): Likewise.
3934 (automatic_hardware_breakpoints): Likewise.
3935 (always_inserted_mode): Likewise.
3936 (target_exact_watchpoints): Likewise.
3937 (_initialize_breakpoint): Update.
3938 * breakpoint.h (target_exact_watchpoints): Change to bool.
3939 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3940 * cli/cli-cmds.c (trace_commands): Likewise.
3941 * cli/cli-cmds.h (trace_commands): Likewise.
3942 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3943 to bool*.
3944 * cli/cli-logging.c (logging_overwrite): Change to bool.
3945 (logging_redirect): Likewise.
3946 (debug_redirect): Likewise.
3947 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3948 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3949 to bool.
3950 <boolean_option_def>: Update.
3951 (struct flag_option_def): Change default type of Context to bool
3952 from int.
3953 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3954 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3955 (get_setshow_command_value_string): Likewise.
3956 * cli/cli-style.c (cli_styling): Change to bool.
3957 (source_styling): Likewise.
3958 * cli/cli-style.h (source_styling): Likewise.
3959 (cli_styling): Likewise.
3960 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3961 to bool.
3962 * command.h (var_types): Update comment.
3963 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3964 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3965 bool.
3966 (debug_compile_cplus_scopes): Likewise.
3967 * compile/compile-internal.h (compile_debug): Likewise.
3968 * compile/compile.c (compile_debug): Likewise.
3969 (struct compile_options) <raw>: Likewise.
3970 * cp-support.c (catch_demangler_crashes): Likewise.
3971 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3972 (usr_cmd_cris_dwarf2_cfi): Likewise.
3973 * csky-tdep.c (csky_debug): Likewise.
3974 * darwin-nat.c (enable_mach_exceptions): Likewise.
3975 * dcache.c (dcache_enabled_p): Likewise.
3976 * defs.h (info_verbose): Likewise.
3977 * demangle.c (demangle): Likewise.
3978 (asm_demangle): Likewise.
3979 * dwarf-index-cache.c (debug_index_cache): Likewise.
3980 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3981 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3982 * dwarf2read.c (check_physname): Likewise.
3983 (use_deprecated_index_sections): Likewise.
3984 (dwarf_always_disassemble): Likewise.
3985 * eval.c (overload_resolution): Likewise.
3986 * event-top.c (set_editing_cmd_var): Likewise.
3987 (exec_done_display_p): Likewise.
3988 * event-top.h (set_editing_cmd_var): Likewise.
3989 (exec_done_display_p): Likewise.
3990 * exec.c (write_files): Likewise.
3991 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3992 (debug_fbsd_nat): Likewise.
3993 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3994 Likewise.
3995 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3996 <backtrace_past_entry> Likewise.
3997 * gdb-demangle.h (demangle): Likewise.
3998 (asm_demangle): Likewise.
3999 * gdb_bfd.c (bfd_sharing): Likewise.
4000 * gdbcore.h (write_files): Likewise.
4001 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4002 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4003 * gdbthread.h (print_thread_events): Likewise.
4004 * gdbtypes.c (opaque_type_resolution): Likewise.
4005 (strict_type_checking): Likewise.
4006 * gnu-nat.c (gnu_debug_flag): Likewise.
4007 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4008 * guile/scm-param.c (pascm_variable): Add boolval.
4009 (add_setshow_generic): Update.
4010 (pascm_param_value): Update.
4011 (pascm_set_param_value_x): Update.
4012 * hppa-tdep.c (hppa_debug): Change to bool..
4013 * infcall.c (may_call_functions_p): Likewise.
4014 (coerce_float_to_double_p): Likewise.
4015 (unwind_on_signal_p): Likewise.
4016 (unwind_on_terminating_exception_p): Likewise.
4017 * infcmd.c (startup_with_shell): Likewise.
4018 * inferior.c (print_inferior_events): Likewise.
4019 * inferior.h (startup_with_shell): Likewise.
4020 (print_inferior_events): Likewise.
4021 * infrun.c (step_stop_if_no_debug): Likewise.
4022 (detach_fork): Likewise.
4023 (debug_displaced): Likewise.
4024 (disable_randomization): Likewise.
4025 (non_stop): Likewise.
4026 (non_stop_1): Likewise.
4027 (observer_mode): Likewise.
4028 (observer_mode_1): Likewise.
4029 (set_observer_mode): Update.
4030 (sched_multi): Change to bool.
4031 * infrun.h (debug_displaced): Likewise.
4032 (sched_multi): Likewise.
4033 (step_stop_if_no_debug): Likewise.
4034 (non_stop): Likewise.
4035 (disable_randomization): Likewise.
4036 * linux-tdep.c (use_coredump_filter): Likewise.
4037 (dump_excluded_mappings): Likewise.
4038 * linux-thread-db.c (auto_load_thread_db): Likewise.
4039 (check_thread_db_on_load): Likewise.
4040 * main.c (captured_main_1): Update.
4041 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4042 xx2_opt, boolean_opt>: Change to bool.
4043 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4044 * maint.c (maintenance_profile_p): Likewise.
4045 (per_command_time): Likewise.
4046 (per_command_space): Likewise.
4047 (per_command_symtab): Likewise.
4048 * memattr.c (inaccessible_by_default): Likewise.
4049 * mi/mi-main.c (mi_async): Likewise.
4050 (mi_async_1): Likewise.
4051 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4052 * nat/fork-inferior.h (startup_with_shell): Likewise.
4053 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4054 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4055 * nios2-tdep.c (nios2_debug): Likewise.
4056 * or1k-tdep.c (or1k_debug): Likewise.
4057 * parse.c (parser_debug): Likewise.
4058 * parser-defs.h (parser_debug): Likewise.
4059 * printcmd.c (print_symbol_filename): Likewise.
4060 * proc-api.c (procfs_trace): Likewise.
4061 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4062 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4063 (set_parameter_value): Update.
4064 (add_setshow_generic): Update.
4065 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4066 to bool*.
4067 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4068 int*.
4069 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4070 * record-btrace.c (record_btrace_target::store_registers): Update.
4071 * record-full.c (record_full_memory_query): Change to bool.
4072 (record_full_stop_at_limit): Likewise.
4073 * record-full.h (record_full_memory_query): Likewise.
4074 * remote-notif.c (notif_debug): Likewise.
4075 * remote-notif.h (notif_debug): Likewise.
4076 * remote.c (use_range_stepping): Likewise.
4077 (interrupt_on_connect): Likewise.
4078 (remote_break): Likewise.
4079 * ser-tcp.c (tcp_auto_retry): Likewise.
4080 * ser-unix.c (serial_hwflow): Likewise.
4081 * skip.c (debug_skip): Likewise.
4082 * solib-aix.c (solib_aix_debug): Likewise.
4083 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4084 (spu_auto_flush_cache_p): Likewise.
4085 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4086 Likewise.
4087 (struct info_print_options) <quiet>: Likewise.
4088 * symfile-debug.c (debug_symfile): Likewise.
4089 * symfile.c (auto_solib_add): Likewise.
4090 (separate_debug_file_debug): Likewise.
4091 * symfile.h (auto_solib_add): Likewise.
4092 (separate_debug_file_debug): Likewise.
4093 * symtab.c (basenames_may_differ): Likewise.
4094 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4095 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4096 (struct info_types_options) <quiet>: Likewise.
4097 * symtab.h (demangle): Likewise.
4098 (basenames_may_differ): Likewise.
4099 * target-dcache.c (stack_cache_enabled_1): Likewise.
4100 (code_cache_enabled_1): Likewise.
4101 * target.c (trust_readonly): Likewise.
4102 (may_write_registers): Likewise.
4103 (may_write_memory): Likewise.
4104 (may_insert_breakpoints): Likewise.
4105 (may_insert_tracepoints): Likewise.
4106 (may_insert_fast_tracepoints): Likewise.
4107 (may_stop): Likewise.
4108 (auto_connect_native_target): Likewise.
4109 (target_stop_and_wait): Update.
4110 (target_async_permitted): Change to bool.
4111 (target_async_permitted_1): Likewise.
4112 (may_write_registers_1): Likewise.
4113 (may_write_memory_1): Likewise.
4114 (may_insert_breakpoints_1): Likewise.
4115 (may_insert_tracepoints_1): Likewise.
4116 (may_insert_fast_tracepoints_1): Likewise.
4117 (may_stop_1): Likewise.
4118 * target.h (target_async_permitted): Likewise.
4119 (may_write_registers): Likewise.
4120 (may_write_memory): Likewise.
4121 (may_insert_breakpoints): Likewise.
4122 (may_insert_tracepoints): Likewise.
4123 (may_insert_fast_tracepoints): Likewise.
4124 (may_stop): Likewise.
4125 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4126 (make_thread_apply_all_options_def_group): Change argument from int*
4127 to bool*.
4128 (thread_apply_all_command): Update.
4129 (print_thread_events): Change to bool.
4130 * top.c (confirm): Likewise.
4131 (command_editing_p): Likewise.
4132 (history_expansion_p): Likewise.
4133 (write_history_p): Likewise.
4134 (info_verbose): Likewise.
4135 * top.h (confirm): Likewise.
4136 (history_expansion_p): Likewise.
4137 * tracepoint.c (disconnected_tracing): Likewise.
4138 (circular_trace_buffer): Likewise.
4139 * typeprint.c (print_methods): Likewise.
4140 (print_typedefs): Likewise.
4141 * utils.c (debug_timestamp): Likewise.
4142 (sevenbit_strings): Likewise.
4143 (pagination_enabled): Likewise.
4144 * utils.h (sevenbit_strings): Likewise.
4145 (pagination_enabled): Likewise.
4146 * valops.c (overload_resolution): Likewise.
4147 * valprint.h (struct value_print_options) <prettyformat_arrays,
4148 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4149 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4150 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4151 Likewise.
4152 * windows-nat.c (new_console): Likewise.
4153 (cygwin_exceptions): Likewise.
4154 (new_group): Likewise.
4155 (debug_exec): Likewise.
4156 (debug_events): Likewise.
4157 (debug_memory): Likewise.
4158 (debug_exceptions): Likewise.
4159 (useshell): Likewise.
4160 * windows-tdep.c (maint_display_all_tib): Likewise.
4161 * xml-support.c (debug_xml): Likewise.
4162
4163 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4164
4165 * source.c (prepare_path_for_appending): New function.
4166 (openp): Make use of new function.
4167 (find_and_open_source): Search for the compilation directory and
4168 source file as a relative path beneath the directory search path.
4169
4170 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4171
4172 * source-cache.c (source_cache::get_line_charpos): Catch
4173 exceptions and return false, this matches the behaviour documented
4174 in the header file.
4175
4176 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4177
4178 * ada-tasks.c (info_task): Remove quoting of the task's name.
4179
4180 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4181
4182 * symfile.c (auto_solib_add): Replace comment with a reference
4183 to the header file.
4184
4185 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4186
4187 * NEWS: Mention that gdb can now be compiled with Python 3
4188 on Windows.
4189
4190 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4191
4192 * maint.c (maint_print_section_data::maint_print_section_data):
4193 Force use of 'float log10 (float)' by casting the argument to
4194 float.
4195
4196 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4197
4198 * maint.c: Add 'cmath' include.
4199 (struct maint_print_section_data): New structure.
4200 (print_section_index): New function.
4201 (print_bfd_section_info): Add header comment, small whitespace
4202 cleanup, and update to call new print_section_index function.
4203 (print_objfile_section_info): Likewise.
4204 (maint_obj_section_from_bfd_section): New function.
4205 (print_bfd_section_info_maybe_relocated): New function.
4206 (maintenance_info_sections): Add header comment, always use
4207 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4208
4209 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4210
4211 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4212 inner scope, add check that the objfile has psymtabs before
4213 checking psymtabs_addrmap.
4214 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4215
4216 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4217
4218 * NEWS: Announce that Ada task names are now shown at more places,
4219 and between quotes (except in info task output).
4220 * gdb/ada-tasks.c (task_to_str): New function.
4221 (display_current_task_id): Call task_to_str.
4222 (task_command_1): Likewise.
4223 (print_ada_task_info): In non-mi mode, Properly align headers and data
4224 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4225
4226 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4227
4228 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4229 prstatus.pr_lwp.pr_info instead of making it up.
4230
4231 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4232
4233 * auto-load.c (auto_load_expand_dir_vars): Update.
4234 * defs.h (gdb_datadir): Change to std::string.
4235 (python_libdir): Likewise.
4236 (relocate_gdb_directory): Change return type to std::string.
4237 * guile/guile.c (gdbscm_data_directory): Update.
4238 (initialize_scheme_side): Update.
4239 * jit.c (jit_reader_dir): Change to std::string.
4240 (jit_reader_load_command): Update.
4241 * main.c (gdb_datadir): Change to std::string.
4242 (python_libdir): Likewise.
4243 (set_gdb_data_directory): Update.
4244 (relocate_path): Change to return std::string.
4245 (relocate_gdb_directory): Change to return std::string.
4246 (relocate_gdbinit_path_maybe_in_datadir): Update.
4247 (captured_main_1): Update.
4248 * python/python.c (do_start_initialization): Update.
4249 * top.c (show_gdb_datadir): Update.
4250 * xml-syscall.c (xml_init_syscalls_info): Update.
4251 (init_syscalls_info): Update.
4252
4253 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4254
4255 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4256 out of get_init_files.
4257 (get_init_files): Update.
4258
4259 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4260
4261 * main.c (get_init_files): Change to use std::string.
4262 (captured_main_1): Update.
4263 (print_gdb_help): Update.
4264
4265 2019-09-11 Ali Tamur <tamur@google.com>
4266
4267 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4268 implementation.
4269
4270 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4271
4272 * dbxread.c (read_dbx_symtab): Update.
4273 * dwarf2read.c (load_partial_dies): Update.
4274 * mdebugread.c (parse_partial_symbols): Update.
4275 (handle_psymbol_enumerators): Update.
4276 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4277 * psymtab.c (add_psymbol_to_bcache): Likewise.
4278 (add_psymbol_to_list): Likewise.
4279 * symtab.c (symbol_set_names): Likewise.
4280 * symtab.h (symbol_set_names): Likewise.
4281 * xcoffread.c (scan_xcoff_symtab): Update.
4282
4283 2019-09-11 Tom Tromey <tom@tromey.com>
4284
4285 * symfile-mem.c (symbol_file_add_from_memory): Use
4286 bfd_set_filename.
4287 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4288 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4289
4290 2019-09-10 Tom Tromey <tromey@adacore.com>
4291
4292 * dwarf-index-write.c (write_psymbols): Extend error message.
4293 (debug_names::insert): Add Ada code.
4294 (debug_names::write_psymbols): Remove Ada check.
4295 (debug_names) <m_string_obstack>: New member.
4296 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4297 (gdb_index_symbol_name_matcher::matches): Remove.
4298 (mapped_index_base::find_name_components_bounds): Add "lang"
4299 parameter.
4300 (mapped_index_base::build_name_components): Also split names
4301 according to Ada syntax.
4302 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4303 type of "match_callback".
4304 (check_match, check_find_bounds_finds)
4305 (dw2_expand_symtabs_matching): Update.
4306 (dw2_debug_names_iterator): Add new constructor.
4307 (dw2_debug_names_map_matching_symbols): New function.
4308 (dw2_debug_names_expand_symtabs_matching): Update.
4309 (dwarf2_debug_names_functions): Use
4310 dw2_debug_names_map_matching_symbols.
4311
4312 2019-09-10 Tom Tromey <tromey@adacore.com>
4313
4314 * dwarf2read.c (dw2_get_file_names_reader): Add the
4315 CU's file name to the results.
4316
4317 2019-09-10 Tom Tromey <tromey@adacore.com>
4318
4319 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4320 map_matching_symbols. Update.
4321 * dwarf2read.c (dw2_map_matching_symbols): Update.
4322 * psymtab.c (match_partial_symbol): Change type; update.
4323 (psym_map_matching_symbols): Likewise.
4324 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4325 type; update.
4326 * symfile.h (struct quick_symbol_functions)
4327 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4328 Remove "match".
4329
4330 2019-09-10 Tom Tromey <tromey@adacore.com>
4331
4332 * psymtab.c (map_block): Remove.
4333 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4334 * symtab.c (iterate_over_symbols_terminated): New function.
4335 * symtab.c (iterate_over_symbols_terminated): Declare.
4336
4337 2019-09-10 Tom Tromey <tromey@adacore.com>
4338
4339 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4340 * language.h (struct language_defn) <la_iterate_over_symbols>:
4341 Return bool.
4342 * symtab.c (iterate_over_symbols): Return bool.
4343 * symtab.h (iterate_over_symbols): Return bool.
4344
4345 2019-09-10 Tom Tromey <tromey@adacore.com>
4346
4347 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4348 (add_nonlocal_symbols): Update.
4349 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4350 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4351 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4352 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4353 Change type of "callback". Remove "data".
4354
4355
4356 2019-09-09 Ali Tamur <tamur@google.com>
4357
4358 * dwarf2read.c (comp_unit_head): Update comment.
4359 (dwarf2_dwo_name): New function declaration.
4360 (dwarf_unit_type_name): New function declaration.
4361 (read_comp_unit_head): Add support for new compilation units,
4362 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4363 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4364 (currently named as "signature") in their header. Also clarify error
4365 messages.
4366 (lookup_dwo_id): New function. Returns the dwo id of the given
4367 compile unit.
4368 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4369 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4370 functions.
4371 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4372 (dwarf2_dwo_name): Get the dwo name if present.
4373 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4374 purposes.
4375
4376 2019-09-09 Tom Tromey <tom@tromey.com>
4377
4378 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4379
4380 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4381
4382 * python/python.c (do_start_initialization): Make progname_copy static,
4383 to avoid a leak report.
4384
4385 2019-09-08 Tom Tromey <tom@tromey.com>
4386
4387 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4388
4389 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4390
4391 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4392 Change type to gdb::optional<block_enum>.
4393 (dw2_symtab_iter_init): Change block_index parameter type
4394 to gdb::optional<block_enum>.
4395 (dw2_lookup_symbol): Change block_index parameter
4396 type to block_enum.c
4397 (dw2_debug_names_lookup_symbol): Likewise.
4398 * psymtab.c (psym_lookup_symbol): Likewise.
4399 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4400 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4401 Likewise.
4402
4403 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4404
4405 * defs.h (relocate_gdb_directory): Change int to bool in
4406 signature and rename flag to relocatable.
4407 * main.c (relocate_path): Likewise.
4408 (relocate_gdb_directory): Likewise.
4409
4410 2019-09-06 Alan Modra <amodra@gmail.com>
4411
4412 * coffread.c (coff_symfile_read): Constify filename variable.
4413 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4414 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4415 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4416 * solib.c (reload_shared_libraries_1): Likewise.
4417 * symfile.c (reread_symbols): Likewise.
4418 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4419 * solib-darwin.c (darwin_bfd_open): Likewise.
4420 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4421
4422 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4423
4424 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4425 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4426
4427 2019-09-03 Tom Tromey <tromey@adacore.com>
4428
4429 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4430 types.
4431 (has_negatives): Unbias a range type bound.
4432 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4433 * gdbtypes.c (operator==): Handle new field.
4434 (create_range_type): Add "bias" parameter.
4435 (create_static_range_type, resolve_dynamic_range): Update.
4436 * gdbtypes.h (struct range_bounds) <bias>: New member.
4437 (create_range_type): Add bias parameter.
4438 * printcmd.c (print_scalar_formatted): Unbias range types.
4439 * value.c (unpack_long): Unbias range types.
4440 (pack_long): Bias range types.
4441
4442 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4443
4444 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4445 probe arguments.
4446
4447 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4448
4449 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4450 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4451 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4452 (compile_probe_arg): Likewise.
4453 * probe.h (get_argument_count): Likewise.
4454 * solib-svr4.c (solib_event_probe_action): Likewise.
4455 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4456
4457 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4458
4459 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4460 code to here...
4461 (svr4_create_solib_event_breakpoints): ...from here.
4462
4463 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4464
4465 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4466 suffix from warning message.
4467
4468 2019-08-30 Tom Tromey <tom@tromey.com>
4469
4470 * tui/tui-winsource.h (struct tui_source_window_base)
4471 <refresh_all>: Don't declare.
4472 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4473 Remove.
4474 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4475 tui_show_locator_content.
4476 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4477 declare.
4478 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4479 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4480 declare.
4481
4482 2019-08-30 Tom Tromey <tom@tromey.com>
4483
4484 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4485
4486 2019-08-30 Tom Tromey <tom@tromey.com>
4487
4488 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4489 Remove unnecessary forward declarations.
4490
4491 2019-08-30 Tom Tromey <tom@tromey.com>
4492
4493 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4494 rerender.
4495 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4496 tui_show_locator_content.
4497
4498 2019-08-30 Tom Tromey <tom@tromey.com>
4499
4500 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4501 (tui_locator_window::rerender): Rewrite using body of previous
4502 tui_show_locator_content.
4503
4504 2019-08-30 Tom Tromey <tom@tromey.com>
4505
4506 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4507 set_locator_fullname>: New methods.
4508 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4509 Rename from tui_set_locator_fullname.
4510 (tui_locator_window::set_locator_info): Rename from
4511 tui_set_locator_info. Return bool.
4512 (tui_update_locator_fullname, tui_show_frame_info): Update.
4513
4514 2019-08-30 Tom Tromey <tom@tromey.com>
4515
4516 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4517
4518 2019-08-30 Tom Tromey <tom@tromey.com>
4519
4520 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4521 call touchwin.
4522
4523 2019-08-30 Tom Tromey <tom@tromey.com>
4524
4525 * tui/tui-wingeneral.c (box_win): Assume win_info and
4526 win_info->handle cannot be NULL.
4527
4528 2019-08-30 Tom Tromey <tom@tromey.com>
4529
4530 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4531 refresh_window>: Declare.
4532 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4533 resize.
4534 (tui_data_item_window::rerender): Rename from
4535 tui_display_register.
4536 (tui_data_item_window::refresh_window): New method.
4537 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4538 no-op.
4539
4540 2019-08-30 Tom Tromey <tom@tromey.com>
4541
4542 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4543 regs_column_count, current_group>: Move later. Now private.
4544 <get_current_group>: New method.
4545 * tui/tui-regs.c (tui_reg_command): Update.
4546 * tui/tui-layout.c (tui_set_layout): Update.
4547
4548 2019-08-30 Tom Tromey <tom@tromey.com>
4549
4550 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4551 (tui_data_window::rerender): Don't call
4552 check_and_display_highlight_if_needed.
4553 (tui_data_window::refresh_all): Remove call to
4554 erase_data_content.
4555
4556 2019-08-30 Tom Tromey <tom@tromey.com>
4557
4558 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4559 (tui_data_window::display_registers_from)
4560 (tui_data_window::display_reg_element_at_line)
4561 (tui_data_window::display_registers_from_line): Remove checks of
4562 "empty".
4563
4564 2019-08-30 Tom Tromey <tom@tromey.com>
4565
4566 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4567 Don't declare.
4568 * tui/tui-regs.c (tui_data_window::show_registers): Call
4569 rerender.
4570 (tui_data_window::rerender): Rename from display_all_data.
4571 (tui_data_window::rerender): Remove old implementation.
4572
4573 2019-08-30 Tom Tromey <tom@tromey.com>
4574
4575 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4576 text.
4577 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4578
4579 2019-08-29 Bernhard Wodok <barto@gmx.net>
4580 Sergio Durigan Junior <sergiodj@redhat.com>
4581
4582 PR win32/24284
4583 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4584
4585 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4586
4587 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4588 when searching for types.
4589
4590 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4591
4592 * f-lang.c (f_language_defn): Use f_print_typedef.
4593 * f-lang.h (f_print_typedef): Declare.
4594 * f-typeprint.c (f_print_typedef): Define.
4595
4596 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4597
4598 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4599
4600 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4601
4602 * cli/cli-utils.c (info_print_options_defs): Delete.
4603 (make_info_print_options_def_group): Delete.
4604 (extract_info_print_options): Delete.
4605 (info_print_command_completer): Delete.
4606 (info_print_args_help): Add extra parameter, and optionally
4607 include text about -n flag.
4608 * cli/cli-utils.h (struct info_print_options): Delete.
4609 (extract_info_print_options): Delete declaration.
4610 (info_print_command_completer): Delete declaration.
4611 (info_print_args_help): Add extra parameter, extend header
4612 comment.
4613 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4614 search_symbols.
4615 * stack.c (struct info_print_options): New type.
4616 (info_print_options_defs): New file scoped variable.
4617 (make_info_print_options_def_group): New static function.
4618 (info_print_command_completer): New static function.
4619 (info_locals_command): Update to use new local functions.
4620 (info_args_command): Likewise.
4621 (_initialize_stack): Add extra parameter to calls to
4622 info_print_args_help.
4623 * symtab.c (search_symbols): Add extra parameter, use this to
4624 possibly excluse non-debug symbols.
4625 (symtab_symbol_info): Add extra parameter, which is passed on to
4626 search_symbols.
4627 (struct info_print_options): New type.
4628 (info_print_options_defs): New file scoped variable.
4629 (make_info_print_options_def_group): New static function.
4630 (info_print_command_completer): New static function.
4631 (info_variables_command): Update to use local functions, and pass
4632 extra parameter through to symtab_symbol_info.
4633 (info_functions_command): Likewise.
4634 (info_types_command): Pass additional argument through to
4635 symtab_symbol_info.
4636 (rbreak_command): Pass extra argument to search_symbols.
4637 (_initialize_symtab): Add extra arguments for calls to
4638 info_print_args_help, and update help text for 'info variables',
4639 'whereis', and 'info functions' commands.
4640 * symtab.h (search_symbols): Add extra argument to declaration.
4641 * NEWS: Mention new flags.
4642
4643 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4644
4645 * symtab.c (lookup_static_symbol): Call the new function (and move
4646 it down to be next to lookup_global_symbol).
4647 (struct global_sym_lookup_data): Add block_enum member and rename to...
4648 (struct global_or_static_sym_lookup_data): ...this.
4649 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4650 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4651 (lookup_symbol_global_or_static_iterator_cb): ...this.
4652 (lookup_global_or_static_symbol): New function.
4653 (lookup_global_symbol): Call new function.
4654
4655 2019-08-26 Tom de Vries <tdevries@suse.de>
4656
4657 PR c++/24852
4658 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4659 when pc_probe.prob == NULL.
4660
4661 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4662
4663 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4664 variable symbol_linkage to symbol_linkage_.
4665
4666 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4667
4668 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4669 represent whether the symbol is static, dynamic, or we don't
4670 know.
4671
4672 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4673
4674 * gdb/rx-tdep.c (rx_register_names): New.
4675 (rx_register_name): Delete.
4676 (rx_psw_type): Delete.
4677 (rx_fpsw_type): Delete.
4678 (rx_register_type): Delete.
4679 (rx_gdbarch_init): Convert target-descriptions.
4680 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4681 * gdb/features/Makefile: Add rx.xml.
4682 * gdb/features/rx.xml: New.
4683 * gdb/features/rx.c: Generated.
4684 * gdb/NEWS: Mention target description support.
4685
4686 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4687
4688 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4689 *slot_ptr.
4690
4691 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4692
4693 * configure.ac: Don't check for 'dlfcn.h' (moved to
4694 gdbsupport/common.m4).
4695 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4696 'gdbsupport/'.
4697 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4698 * compile/compile-c-support.c: Include
4699 'gdbsupport/gdb-dlfcn.h'.
4700 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4701 * gdb-dlfcn.c: Move to...
4702 * gdbsupport/gdb-dlfcn.c: ... here.
4703 * gdb-dlfcn.h: Move to...
4704 * gdbsupport/gdb-dlfcn.h: ... here.
4705
4706 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4707
4708 * nios2-tdep.c (struct reg_value): Improve comments. Make
4709 the offset field signed.
4710
4711 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4712
4713 * python/lib/gdb/__init__.py (_execute_file): New function.
4714 * python/python.c (python_run_simple_file): Call gdb._execute_file
4715 on Windows.
4716
4717 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4718
4719 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4720 all uses as this was never set to anything but a zero value.
4721
4722 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4723
4724 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4725
4726 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4727
4728 * tui/tui-data.h (tui_gen_win_info): Add an =default
4729 move constructor, required by some GCC versions.
4730
4731 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4732
4733 * go32-nat.c (go32_sysinfo): Add hygon_p.
4734
4735 2019-08-20 Tom Tromey <tom@tromey.com>
4736
4737 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4738 line_from_reg_element_no, first_reg_element_no_inline,
4739 display_all_data, delete_data_content_windows,
4740 erase_data_content>: Now private.
4741
4742 2019-08-20 Tom Tromey <tom@tromey.com>
4743
4744 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4745 (tui_unhighlight_win, tui_highlight_win)
4746 (tui_win_info::make_window): Update.
4747 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4748
4749 2019-08-20 Tom Tromey <tom@tromey.com>
4750
4751 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4752 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4753 (MAX_PID_WIDTH): Move to tui-stack.c.
4754 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4755 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4756 (MAX_PID_WIDTH): Move from tui-data.h.
4757
4758 2019-08-20 Tom Tromey <tom@tromey.com>
4759
4760 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4761 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4762 (box_win): Update.
4763 (tui_gen_win_info::make_window): Rename from tui_make_window.
4764 (tui_win_info::make_window): New method.
4765 (tui_gen_win_info::make_visible): Update.
4766 * tui/tui-source.c (tui_source_window::set_contents): Update.
4767 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4768 (tui_data_window::display_registers_from): Update.
4769 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4770 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4771 Declare.
4772 <can_box>: Remove.
4773 <title>: Remove.
4774 (struct tui_win_info) <make_window>: Declare.
4775 <can_box>: Now virtual.
4776 <title>: New member.
4777 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4778 * tui/tui-command.c (tui_cmd_window::resize): Update.
4779
4780 2019-08-20 Tom Tromey <tom@tromey.com>
4781
4782 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4783 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4784 (tui_data_window::check_register_values): Update.
4785
4786 2019-08-20 Tom Tromey <tom@tromey.com>
4787
4788 * tui/tui-regs.h (struct tui_data_window): Use
4789 DISABLE_COPY_AND_ASSIGN.
4790 <regs_content>: Change type, removing unique_ptr.
4791 <tui_data_window>: Add move constructor.
4792 * tui/tui-regs.c (tui_data_window::show_registers)
4793 (tui_data_window::show_register_group)
4794 (tui_data_window::display_registers_from)
4795 (tui_data_window::display_registers_from)
4796 (tui_data_window::first_data_item_displayed)
4797 (tui_data_window::delete_data_content_windows)
4798 (tui_data_window::rerender, tui_data_window::refresh_window)
4799 (tui_data_window::check_register_values): Update.
4800
4801 2019-08-20 Tom Tromey <tom@tromey.com>
4802
4803 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4804 show_register_group>: Declare.
4805 (tui_show_register_group): Don't declare.
4806 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4807 tui_show_registers.
4808 (tui_data_window::show_register_group): Rename from
4809 tui_show_register_group.
4810 (tui_data_window::check_register_values, tui_reg_command):
4811 Update.
4812 * tui/tui-layout.c (tui_set_layout): Update.
4813
4814 2019-08-20 Tom Tromey <tom@tromey.com>
4815
4816 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4817 Declare.
4818 (tui_check_register_values): Don't declare.
4819 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4820 from tui_check_register_values.
4821 * tui/tui-hooks.c (tui_register_changed): Update.
4822
4823 2019-08-20 Tom Tromey <tom@tromey.com>
4824
4825 * tui/tui-regs.c (tui_reg_layout): Move later.
4826 (tui_show_registers): Don't enable TUI mode or change layout.
4827
4828 2019-08-20 Tom Tromey <tom@tromey.com>
4829
4830 * tui/tui-regs.h (struct tui_data_item_window)
4831 <~tui_data_item_window>: Remove.
4832 <content>: Now a unique_xmalloc_ptr.
4833 * tui/tui-regs.c (tui_register_format): Return a
4834 unique_xmalloc_ptr.
4835 (tui_get_register): Update.
4836 (~tui_data_item_window): Remove.
4837 (tui_data_window::display_registers_from, tui_display_register):
4838 Update.
4839 * tui/tui-io.h (tui_expand_tabs): Update.
4840 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4841 Remove "col" parameter.
4842
4843 2019-08-20 Tom Tromey <tom@tromey.com>
4844
4845 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4846 field.
4847 * tui/tui-regs.c (~tui_data_item_window): Update.
4848
4849 2019-08-20 Tom Tromey <tom@tromey.com>
4850
4851 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4852 earlier.
4853
4854 2019-08-20 Tom Tromey <tom@tromey.com>
4855
4856 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4857
4858 2019-08-20 Tom Tromey <tom@tromey.com>
4859
4860 * tui/tui-source.h (struct tui_source_window): Update.
4861 * tui/tui-regs.c (tui_show_registers): Update.
4862 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4863 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4864 (NO_REGS_STRING): Remove defines.
4865
4866 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4867
4868 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4869 unnecessary thread walk if remote doesn't support the packet.
4870
4871 2019-08-19 Tom Tromey <tromey@adacore.com>
4872
4873 * python/py-value.c (value_has_field): Fix indentation.
4874
4875 2019-08-19 Tom Tromey <tromey@adacore.com>
4876
4877 * printcmd.c (do_one_display, info_display_command): Update.
4878 * block.h (contained_in): Return bool. Add allow_nested
4879 parameter.
4880 * block.c (contained_in): Return bool. Add allow_nested
4881 parameter.
4882
4883 2019-08-19 Tom Tromey <tom@tromey.com>
4884
4885 * configure: Rebuild.
4886 * configure.ac: Disallow the combination of -static-libstdc++ and
4887 source highlight.
4888 * source-cache.c (get_language_name): Handle rust.
4889 (source_cache::get_source_lines): Ignore highlighting exceptions.
4890
4891 2019-08-16 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4894 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4895 (struct tui_source_window_base) <make_visible, refresh_window,
4896 resize>: Remove methods.
4897 <execution_info>: Remove field.
4898 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4899 (tui_show_source_line, tui_source_window_base)
4900 (~tui_source_window_base): Update.
4901 (tui_source_window_base::resize)
4902 (tui_source_window_base::make_visible)
4903 (tui_source_window_base::refresh_window): Remove.
4904 (tui_source_window_base::update_exec_info): Update.
4905 * tui/tui-source.c (tui_source_window::set_contents): Update.
4906 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4907
4908 2019-08-16 Tom Tromey <tom@tromey.com>
4909
4910 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4911 deprecated_query_hook.
4912
4913 2019-08-16 Tom Tromey <tom@tromey.com>
4914
4915 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4916 (tui_update_source_windows_with_line): Update.
4917 * tui/tui-source.h (struct tui_source_window)
4918 <show_symtab_source>: Declare.
4919 (tui_show_symtab_source): Don't declare.
4920 * tui/tui-source.c (tui_show_symtab_source): Rename from
4921 tui_show_symtab_source.
4922
4923 2019-08-16 Tom Tromey <tom@tromey.com>
4924
4925 * tui/tui-winsource.h (struct tui_source_window_base)
4926 <set_contents>: Declare.
4927 * tui/tui-winsource.c
4928 (tui_source_window_base::update_source_window_as_is): Update.
4929 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4930 Declare.
4931 (tui_set_source_content): Don't declare.
4932 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4933 tui_set_source_content.
4934 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4935 Declare.
4936 (tui_set_disassem_content): Don't declare.
4937 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4938 tui_set_disassem_content.
4939
4940 2019-08-16 Tom Tromey <tom@tromey.com>
4941
4942 * tui/tui-winsource.h (struct tui_source_window_base)
4943 <update_breakpoint_info>: Declare.
4944 (tui_update_breakpoint_info): Don't declare.
4945 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4946 (tui_update_all_breakpoint_info): Update.
4947 (tui_source_window_base::update_breakpoint_info): Rename from
4948 tui_update_breakpoint_info.
4949 (tui_source_window_base::update_exec_info): Update.
4950
4951 2019-08-16 Tom Tromey <tom@tromey.com>
4952
4953 * tui/tui-winsource.h (struct tui_source_window_base)
4954 <update_source_window>: Declare.
4955 (tui_update_source_window): Don't declare.
4956 * tui/tui-winsource.c
4957 (tui_source_window_base::update_source_window): Rename from
4958 tui_update_source_window.
4959 (tui_source_window_base::rerender): Update.
4960 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4961 * tui/tui-disasm.c (tui_show_disassem)
4962 (tui_show_disassem_and_update_source)
4963 (tui_disasm_window::maybe_update): Update.
4964
4965 2019-08-16 Tom Tromey <tom@tromey.com>
4966
4967 * tui/tui-winsource.h (struct tui_source_window_base)
4968 <update_source_window_as_is>: Declare.
4969 (tui_update_source_window_as_is): Don't declare.
4970 * tui/tui-winsource.c (tui_update_source_window): Update
4971 (tui_source_window_base::update_source_window_as_is): Rename from
4972 tui_update_source_window_as_is.
4973 (tui_source_window_base::refill): Update.
4974 * tui/tui-source.c (tui_show_symtab_source): Update.
4975 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4976 Update.
4977
4978 2019-08-16 Tom Tromey <tom@tromey.com>
4979
4980 * tui/tui-winsource.h (tui_update_source_window)
4981 (tui_update_source_window_as_is): Remove "noerror" parameter.
4982 * tui/tui-winsource.c (tui_update_source_window)
4983 (tui_update_source_window_as_is): Remove "noerror" parameter.
4984 (tui_update_source_windows_with_addr)
4985 (tui_update_source_windows_with_line)
4986 (tui_source_window_base::rerender)
4987 (tui_source_window_base::refill): Update.
4988 * tui/tui-source.h (tui_set_source_content)
4989 (tui_show_symtab_source): Remove "noerror" parameter.
4990 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4991 parameter.
4992 (tui_show_symtab_source): Likewise.
4993 (tui_source_window::maybe_update): Update.
4994 * tui/tui-disasm.c (tui_show_disassem)
4995 (tui_show_disassem_and_update_source)
4996 (tui_disasm_window::do_scroll_vertical)
4997 (tui_disasm_window::maybe_update): Update.
4998
4999 2019-08-16 Tom Tromey <tom@tromey.com>
5000
5001 * tui/tui.c (tui_is_window_visible): Update.
5002 * tui/tui-wingeneral.c (tui_make_window)
5003 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5004 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5005 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5006 (tui_set_win_height_command, parse_scrolling_args): Update.
5007 * tui/tui-source.c (tui_source_window::style_changed): Update.
5008 * tui/tui-regs.c (tui_show_registers)
5009 (tui_data_window::first_data_item_displayed)
5010 (tui_data_window::delete_data_content_windows)
5011 (tui_check_register_values, tui_reg_command): Update.
5012 * tui/tui-disasm.c (tui_show_disassem): Update.
5013 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5014 method.
5015 <is_visible>: Remove field.
5016 * tui/tui-data.c (tui_next_win, tui_prev_win)
5017 (tui_delete_invisible_windows): Update.
5018
5019 2019-08-16 Tom Tromey <tom@tromey.com>
5020
5021 * tui/tui-winsource.h (struct tui_source_window_base)
5022 <m_has_locator>: Remove.
5023 * tui/tui-layout.c (show_source_disasm_command, show_data)
5024 (show_source_or_disasm_and_command): Update.
5025
5026 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5027
5028 * NEWS (Other MI changes): New subsection.
5029 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5030 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5031 * arch-utils.c (default_get_pc_address_flags): New function.
5032 * arch-utils.h (default_get_pc_address_flags): New declaration.
5033 * gdbarch.sh: Add get_pc_address_flags.
5034 * gdbarch.c: Regenerate.
5035 * gdbarch.h: Likewise.
5036 * stack.c (print_pc): New function.
5037 (print_frame_info) (print_frame): Call print_pc.
5038
5039 2019-08-16 Tom de Vries <tdevries@suse.de>
5040
5041 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5042 print_objfile_section_info.
5043
5044 2019-08-15 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5047 calling update_cmdwin_start_line.
5048 * tui/tui-winsource.h (struct tui_source_window_base)
5049 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5050 <rerender>: Declare.
5051 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5052 Call rerender.
5053 (tui_source_window_base::set_new_height): Remove.
5054 (tui_source_window_base::rerender): Rename from
5055 do_make_visible_with_new_height.
5056 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5057 resize method.
5058 (tui_win_info::make_invisible_and_set_new_height)
5059 (tui_win_info::make_visible_with_new_height): Remove.
5060 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5061 Declare.
5062 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5063 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5064 do_make_visible_with_new_height>: Don't declare.
5065 <rerender>: Declare.
5066 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5067 set_new_height.
5068 (tui_data_window::do_make_visible_with_new_height): Remove.
5069 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5070 call tui_show_locator_content.
5071 (tui_gen_win_info::resize): Call rerender.
5072 (show_source_or_disasm_and_command): Don't call
5073 tui_show_locator_content.
5074 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5075 method.
5076 (struct tui_win_info) <rerender>: Declare.
5077 <set_new_height, make_invisible_and_set_new_height,
5078 make_visible_with_new_height>: Don't declare.
5079 * tui/tui-data.c (tui_win_list::rerender): New method.
5080 * tui/tui-command.h (struct tui_cmd_window)
5081 <do_make_visible_with_new_height>: Don't declare.
5082 * tui/tui-command.c
5083 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5084
5085 2019-08-15 Tom Tromey <tromey@adacore.com>
5086
5087 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5088 * ada-lang.c (ada_enum_name): Likewise.
5089
5090 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5091
5092 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5093 leading underscore.
5094 (GdbOutputErrorFile): Likewise.
5095 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5096 accordingly.
5097 (execute_unwinders): Rename to have a leading underscore.
5098 (auto_load_packages): Likewise.
5099 (global scope): Adjust call to auto_load_packages accordingly.
5100 (GdbSetPythonDirectory): Likewise.
5101 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5102 instead of execute_unwinders.
5103
5104 2019-08-15 Tom Tromey <tom@tromey.com>
5105
5106 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5107 (show_data): Don't change window visibility.
5108 (tui_gen_win_info::resize): Remove special case for command
5109 window. Use wresize, when available.
5110 (show_source_or_disasm_and_command): Don't change window
5111 visibility.
5112 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5113 <make_visible>: New method.
5114 * tui/tui-command.c (tui_cmd_window::resize): New method.
5115
5116 2019-08-15 Tom Tromey <tom@tromey.com>
5117
5118 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5119 (struct tui_source_windows): New.
5120 * tui/tui-winsource.c (tui_display_main): Update.
5121 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5122 (new_height_ok, parse_scrolling_args): Update.
5123 * tui/tui-layout.c (show_layout, show_data): Update.
5124 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5125 (tui_add_to_source_windows): Don't declare.
5126 * tui/tui-data.c (source_windows, tui_source_windows)
5127 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5128
5129 2019-08-15 Tom Tromey <tom@tromey.com>
5130
5131 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5132 Rename from reset.
5133 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5134 * tui/tui-layout.c (show_source_disasm_command, show_data):
5135 Update.
5136 (tui_gen_win_info::resize): Rename.
5137 (show_source_or_disasm_and_command): Update.
5138 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5139 reset.
5140
5141 2019-08-15 Tom Tromey <tom@tromey.com>
5142
5143 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5144 * tui/tui-interp.c (tui_interp::init): Don't call
5145 tui_initialize_static_data.
5146 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5147
5148 2019-08-15 Tom Tromey <tom@tromey.com>
5149
5150 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5151 examine tui_win_list.
5152
5153 2019-08-15 Tom Tromey <tom@tromey.com>
5154
5155 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5156 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5157 tui_clear_source_content.
5158 (tui_clear_source_content): Remove.
5159 (tui_source_window_base::do_erase_source_content): Hoist call to
5160 content.clear().
5161 * tui/tui-stack.c (tui_show_frame_info): Don't call
5162 tui_clear_source_content.
5163
5164 2019-08-15 Tom Tromey <tom@tromey.com>
5165
5166 * tui/tui-winsource.h (struct tui_source_window_base)
5167 <do_erase_source_content>: New method.
5168 <erase_source_content>: New method.
5169 (tui_erase_source_content): Don't declare.
5170 * tui/tui-winsource.c (tui_clear_source_content): Update.
5171 (tui_source_window_base::do_erase_source_content): Rename from
5172 tui_erase_source_content.
5173 (tui_source_window_base::show_source_content): Update.
5174 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5175 * tui/tui-source.h (struct tui_source_window)
5176 <erase_source_content>: New method.
5177 * tui/tui-disasm.h (struct tui_disasm_window)
5178 <erase_source_content>: New method.
5179
5180 2019-08-15 Tom Tromey <tom@tromey.com>
5181
5182 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5183 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5184 constructor.
5185 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5186 * tui/tui-source.c (tui_set_source_content): Update.
5187 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5188
5189 2019-08-15 Tom Tromey <tom@tromey.com>
5190
5191 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5192 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5193 tui-source.c.
5194 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5195 Declare.
5196 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5197 method.
5198 (tui_source_window::maybe_update): Update.
5199
5200 2019-08-15 Tom Tromey <tom@tromey.com>
5201
5202 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5203 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5204 tui-disasm.c.
5205 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5206 Declare.
5207 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5208 method.
5209 (tui_disasm_window::maybe_update): Update.
5210
5211 2019-08-15 Tom Tromey <tom@tromey.com>
5212
5213 * tui/tui-winsource.h (struct tui_source_window_base)
5214 <maybe_update>: Declare.
5215 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5216 method.
5217 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5218 Declare.
5219 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5220 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5221 Declare.
5222 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5223
5224 2019-08-15 Tom Tromey <tom@tromey.com>
5225
5226 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5227
5228 2019-08-15 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-wingeneral.c: Include tui-stack.h.
5231 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5232 (struct tui_locator_window): Move from tui-data.h.
5233 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5234 (tui_initialize_static_data): Move from tui-data.c.
5235 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5236 (struct tui_locator_window): Move to tui-stack.c.
5237 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5238 (tui_initialize_static_data): Move to tui-stack.c.
5239
5240 2019-08-15 Tom Tromey <tom@tromey.com>
5241
5242 * tui/tui-layout.c (show_source_disasm_command)
5243 (show_source_or_disasm_and_command): Use make_visible method, not
5244 tui_make_window.
5245 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5246 Remove.
5247
5248 2019-08-15 Tom Tromey <tom@tromey.com>
5249
5250 * tui/tui-wingeneral.h (tui_make_window): Update.
5251 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5252 parameter.
5253 (tui_gen_win_info::make_visible): Update.
5254 * tui/tui-regs.c (tui_data_window::display_registers_from):
5255 Update.
5256 * tui/tui-layout.c (show_source_disasm_command)
5257 (show_source_or_disasm_and_command): Update.
5258 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5259 (enum tui_box): Remove.
5260 (struct tui_win_info) <can_box>: New method.
5261 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5262 method.
5263
5264 2019-08-15 Tom de Vries <tdevries@suse.de>
5265
5266 * linux-nat-trad.c: Include gdbarch.h.
5267
5268 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5269
5270 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5271 register sizes.
5272
5273 2019-08-14 Tom Tromey <tromey@adacore.com>
5274
5275 * darwin-nat.c: Include gdbarch.h.
5276 * darwin-nat-info.c: Include gdbarch.h.
5277
5278 2019-08-13 Tom Tromey <tom@tromey.com>
5279
5280 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5281 Remove.
5282 * tui/tui-data.c (tui_initialize_static_data): Update.
5283
5284 2019-08-13 Tom Tromey <tom@tromey.com>
5285
5286 * tui/tui-winsource.h (struct tui_exec_info_window)
5287 <~tui_exec_info_window, maybe_allocate_content, get_content,
5288 m_content>: Remove.
5289 (struct tui_source_window_base) <set_exec_info_content,
5290 show_exec_info_content>: Don't declare.
5291 * tui/tui-winsource.c
5292 (tui_exec_info_window::maybe_allocate_content): Remove.
5293 (tui_source_window_base::update_exec_info): Rename from
5294 set_exec_info_content.
5295 (tui_source_window_base::show_exec_info_content)
5296 (tui_source_window_base::update_exec_info): Remove.
5297
5298 2019-08-13 Tom Tromey <tom@tromey.com>
5299
5300 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5301 declare.
5302 * tui/tui-winsource.c (tui_update_source_window_as_is)
5303 (tui_update_source_windows_with_addr, tui_erase_source_content):
5304 Update.
5305 (tui_clear_exec_info_content): Remove.
5306
5307 2019-08-13 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5310 declare.
5311 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5312 call tui_erase_exec_info_content.
5313 (tui_clear_exec_info_content): Rename from
5314 tui_erase_exec_info_content.
5315 (tui_clear_exec_info_content): Delete.
5316
5317 2019-08-13 Tom Tromey <tom@tromey.com>
5318
5319 * tui/tui-winsource.h (struct tui_source_window_base)
5320 <show_exec_info_content>: Declare.
5321 (tui_show_exec_info_content): Don't declare.
5322 * tui/tui-winsource.c
5323 (tui_source_window_base::show_exec_info_content): Rename from
5324 tui_show_exec_info_content.
5325 (tui_source_window_base::update_exec_info): Update.
5326
5327 2019-08-13 Tom Tromey <tom@tromey.com>
5328
5329 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5330 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5331 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5332 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5333 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5334 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5335 ... here.
5336
5337 2019-08-13 Tom Tromey <tom@tromey.com>
5338
5339 * tui/tui-winsource.h (struct tui_source_window_base)
5340 <update_exec_info>: Declare.
5341 (tui_update_exec_info): Don't declare.
5342 * tui/tui-winsource.c (tui_update_source_window_as_is)
5343 (tui_source_window_base::refresh_all)
5344 (tui_update_all_breakpoint_info): Update.
5345 (tui_source_window_base::update_exec_info): Rename from
5346 tui_update_exec_info.
5347 * tui/tui-stack.c (tui_show_frame_info): Update.
5348
5349 2019-08-13 Tom Tromey <tom@tromey.com>
5350
5351 * tui/tui-winsource.h (struct tui_source_window_base)
5352 <set_exec_info_content>: Declare.
5353 (tui_set_exec_info_content): Don't declare.
5354 * tui/tui-winsource.c
5355 (tui_source_window_base::set_exec_info_content): Rename from
5356 tui_set_exec_info_content.
5357 (tui_update_exec_info): Update.
5358
5359 2019-08-13 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-winsource.h (struct tui_source_window_base)
5362 <show_source_content>: Declare.
5363 (tui_show_source_content): Don't declare.
5364 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5365 (tui_source_window_base::show_source_content): Rename from
5366 tui_show_source_content.
5367 (tui_source_window_base::refresh_all): Update.
5368 * tui/tui-layout.c (show_source_disasm_command)
5369 (show_source_or_disasm_and_command): Update.
5370
5371 2019-08-13 Tom Tromey <tom@tromey.com>
5372
5373 * tui/tui-winsource.c (tui_erase_source_content)
5374 (tui_show_source_content, tui_source_window_base::refresh_all):
5375 Update.
5376 * tui/tui-wingeneral.h
5377 (tui_check_and_display_highlight_if_needed): Don't declare.
5378 * tui/tui-wingeneral.c
5379 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5380 check_and_display_highlight_if_needed.
5381 * tui/tui-win.c (tui_rehighlight_all)
5382 (tui_win_info::make_visible_with_new_height): Update.
5383 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5384 (tui_data_window::erase_data_content)
5385 (tui_data_window::display_all_data): Update.
5386 * tui/tui-data.h (struct tui_win_info)
5387 <check_and_display_highlight_if_needed>: Declare.
5388
5389 2019-08-13 Tom Tromey <tom@tromey.com>
5390
5391 * tui/tui-win.c (tui_resize_all): Call
5392 tui_delete_invisible_windows.
5393 * tui/tui-layout.c (show_layout): Call
5394 tui_delete_invisible_windows.
5395 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5396 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5397
5398 2019-08-13 Tom Tromey <tom@tromey.com>
5399
5400 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5401 tui_add_win_to_layout.
5402
5403 2019-08-13 Tom Tromey <tom@tromey.com>
5404
5405 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5406 * tui/tui-layout.c (tui_default_win_height): Now static.
5407
5408 2019-08-13 Tom Tromey <tom@tromey.com>
5409
5410 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5411 single switch.
5412 (show_source_disasm_command, show_source_or_disasm_and_command):
5413 Don't check current layout.
5414
5415 2019-08-13 Tom Tromey <tom@tromey.com>
5416
5417 * tui/tui-wingeneral.c (make_all_visible): Remove.
5418 (tui_make_all_invisible): Simplify.
5419 * tui/tui-layout.c (tui_make_all_invisible): Move from
5420 tui-wingeneral.c; simplify.
5421 (show_layout): Hoist call to tui_make_all_invisible.
5422 (show_data): Don't call tui_make_all_invisible.
5423
5424 2019-08-13 Tom Tromey <tom@tromey.com>
5425
5426 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5427 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5428
5429 2019-08-13 Tom Tromey <tom@tromey.com>
5430
5431 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5432 tui-data.c.
5433 (show_source_disasm_command, show_data)
5434 (show_source_or_disasm_and_command): Don't use
5435 tui_set_current_layout_to.
5436 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5437 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5438 tui-layout.c.
5439 (tui_set_current_layout_to): Remove.
5440
5441 2019-08-13 Tom Tromey <tom@tromey.com>
5442
5443 * tui/tui-layout.c (tui_set_layout): Update.
5444 * tui/tui-data.h (struct tui_layout_def): Remove.
5445 (tui_layout_def): Don't declare.
5446 * tui/tui-data.c (layout_def): Remove.
5447 (tui_layout_def): Remove.
5448
5449 2019-08-13 Tom Tromey <tom@tromey.com>
5450
5451 * tui/tui-winsource.h (struct tui_source_window_base)
5452 <clear_detail>: No longer "override".
5453 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5454 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5455 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5456 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5457 Remove.
5458 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5459
5460 2019-08-13 Tom Tromey <tromey@adacore.com>
5461
5462 * tracepoint.c: Don't include readline.h or history.h.
5463
5464 2019-08-12 Tom Tromey <tom@tromey.com>
5465
5466 * configure: Rebuild.
5467 * configure.ac: Check for readline 7.
5468 * NEWS: Mention readline 7 requirement.
5469 * README: Update.
5470
5471 2019-08-12 Tom Tromey <tom@tromey.com>
5472
5473 * mingw-hdep.c (gdb_select): Remove readline hack.
5474
5475 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5476
5477 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5478 when the function fails.
5479
5480 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5481
5482 * s390-tdep.c (s390_type_align): New function.
5483 (s390_gdbarch_init): Set it as type_align gdbarch method.
5484
5485 2019-08-09 Tom de Vries <tdevries@suse.de>
5486
5487 PR gdb/24591
5488 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5489 pc_low with relocation offset.
5490
5491 2019-08-07 Tom Tromey <tromey@adacore.com>
5492
5493 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5494 (print_frame_args): Update.
5495 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5496 Update.
5497 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5498 * frame.h (struct frame_arg): Add initializers.
5499 <error>: Now a unique_xmalloc_ptr.
5500
5501 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5502
5503 * NEWS: Expand the Pointer Authentication entry.
5504 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5505 (aarch64_frame_unmask_lr): ... to this.
5506 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5507 Call aarch64_frame_unmask_lr.
5508 * frame.c (struct frame_info): Add "masked" variable.
5509 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5510 (fprint_frame): Check for masked pc.
5511 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5512 declarations.
5513 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5514 * stack.c (print_frame): Check for masked pc.
5515
5516 2019-08-06 Tom Tromey <tom@tromey.com>
5517
5518 * stabsread.c (patch_block_stabs, read_one_struct_field)
5519 (read_enum_type): Use obstack_strndup.
5520 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5521 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5522 * dwarf2read.c (guess_full_die_structure_name)
5523 (anonymous_struct_prefix): Use obstack_strndup.
5524 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5525 * c-exp.y (yylex): Use obstack_strndup.
5526 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5527 (write_var_or_type): Use obstack_strndup.
5528
5529 2019-08-06 Tom Tromey <tom@tromey.com>
5530
5531 * symfile.c (reread_symbols): Use obstack_strdup.
5532 * stabsread.c (read_type): Use obstack_strdup.
5533 * gdb_obstack.h (obstack_strdup): New overload.
5534 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5535 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5536 (dwarf2_canonicalize_name): Use obstack_strdup.
5537 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5538 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5539 Use obstack_strdup.
5540
5541 2019-08-06 Tom Tromey <tom@tromey.com>
5542
5543 * gdb_obstack.h (obstack_strdup): Define.
5544 * gdb_obstack.c (obstack_strdup): Don't define.
5545
5546 2019-08-06 Tom Tromey <tom@tromey.com>
5547
5548 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5549 obstack_strdup.
5550 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5551 obstack_strdup.
5552 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5553 * stabsread.c (common_block_start): Use obstack_strdup.
5554 * objfiles.c (set_objfile_main_name, objfile): Use
5555 obstack_strdup.
5556 * namespace.c (add_using_directive): Use obstack_strdup.
5557 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5558 * jit.c (finalize_symtab): Use obstack_strdup.
5559 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5560 (guess_partial_die_structure_name, partial_die_info::fixup)
5561 (dwarf2_name): Use obstack_strdup.
5562 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5563 obstack_strdup.
5564 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5565 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5566 obstack_strdup.
5567 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5568
5569 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5570
5571 * unittests/help-doc-selftests.c: New file.
5572 * Makefile.in: Add the new file.
5573
5574 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5575
5576 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5577 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5578 the full first line, except when FOR_VALUE_PREFIX. In this case,
5579 the trailing '.' is not output, and the first character is uppercased.
5580 (print_help_for_command): Update call to print_doc_line.
5581 (print_doc_of_command): Likewise.
5582 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5583 * cli/cli-option.c (append_indented_doc): Do not append newline.
5584 (build_help_option): Append newline after first appended_indented_doc
5585 only if a second call is done.
5586 (build_help): Append 2 new lines before each option, except the first
5587 one.
5588 * compile/compile.c (_initialize_compile): Add new lines after
5589 %OPTIONS%, when not at the end of the help.
5590 Change help doc or code
5591 producing the help doc to respect the invariants.
5592 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5593 Also removed the new line after 'Options:', as all other commands
5594 do not put an empty line between 'Options:' and the first option.
5595 * printcmd.c (_initialize_printcmd): Likewise.
5596 * stack.c (_initialize_stack): Likewise.
5597 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5598 incorrectly telling COMMAND is optional.
5599 * ada-lang.c (_initialize_ada_language): Change help doc or code
5600 producing the help doc to respect the invariants.
5601 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5602 * breakpoint.c (_initialize_breakpoint): Likewise.
5603 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5604 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5605 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5606 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5607 _initialize_cli_style): Likewise.
5608 * corelow.c (core_target_info): Likewise.
5609 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5610 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5611 * filesystem.c (_initialize_filesystem): Likewise.
5612 * frame.c (_initialize_frame): Likewise.
5613 * gnu-nat.c (add_task_commands): Likewise.
5614 * infcall.c (_initialize_infcall): Likewise.
5615 * infcmd.c (_initialize_infcmd): Likewise.
5616 * interps.c (_initialize_interpreter): Likewise.
5617 * language.c (_initialize_language): Likewise.
5618 * linux-fork.c (_initialize_linux_fork): Likewise.
5619 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5620 * maint.c (_initialize_maint_cmds): Likewise.
5621 * memattr.c (_initialize_mem): Likewise.
5622 * printcmd.c (_initialize_printcmd): Likewise.
5623 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5624 _RegEx): Likewise.
5625 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5626 * record-btrace.c (_initialize_record_btrace): Likewise.
5627 * record-full.c (_initialize_record_full): Likewise.
5628 * record.c (_initialize_record): Likewise.
5629 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5630 * regcache.c (_initialize_regcache): Likewise.
5631 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5632 _initialize_remote): Likewise.
5633 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5634 * serial.c (_initialize_serial): Likewise.
5635 * skip.c (_initialize_step_skip): Likewise.
5636 * source.c (_initialize_source): Likewise.
5637 * stack.c (_initialize_stack): Likewise.
5638 * symfile.c (_initialize_symfile): Likewise.
5639 * symtab.c (_initialize_symtab): Likewise.
5640 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5641 * top.c (init_main): Likewise.
5642 * tracefile-tfile.c (tfile_target_info): Likewise.
5643 * tracepoint.c (_initialize_tracepoint): Likewise.
5644 * tui/tui-win.c (_initialize_tui_win): Likewise.
5645 * utils.c (add_internal_problem_command): Likewise.
5646 * valprint.c (value_print_option_defs): Likewise.
5647
5648 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5649
5650 PR build/24886
5651 * configure.ac: Drop enable-libmcheck support.
5652 * configure, config.in: Rebuild.
5653 * libmcheck.m4: Remove.
5654 * acinclude.m4: Don't include it.
5655 * Makefile.in: Don't distribute it.
5656 * top.c (print_gdb_configuration): Don't mention it.
5657
5658 2019-08-06 Tom Tromey <tom@tromey.com>
5659
5660 * utils.c (set_output_style): Sometimes pass stream to
5661 emit_style_escape.
5662 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5663 * record-btrace.c (btrace_insn_history): Update.
5664 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5665 method.
5666 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5667 Update initializers.
5668 <m_uiout>: New field.
5669 <m_di>: Move lower.
5670 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5671 Remove "uiout" parameter.
5672 (dump_insns): Update.
5673 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5674 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5675
5676 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5677
5678 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5679 (error_in_psymtab_expansion): Likewise.
5680 (lookup_symbol_via_quick_fns): Likewise.
5681 (basic_lookup_transparent_type_quick): Likewise.
5682 (basic_lookup_transparent_type_1): Likewise.
5683
5684 2019-08-06 Tom Tromey <tromey@adacore.com>
5685
5686 * source.c (last_source_error): Now bool.
5687 (print_source_lines_base): Make "noprint" bool. Only open
5688 source file when last_source_visited changes.
5689
5690 2019-08-06 Tom Tromey <tromey@adacore.com>
5691
5692 * annotate.c (annotate_source_line): Use g_source_cache.
5693 * source-cache.c (source_cache::get_plain_source_lines): Change
5694 parameters. Populate m_offset_cache.
5695 (source_cache::ensure): New method.
5696 (source_cache::get_line_charpos): New method.
5697 (extract_lines): Move lower. Change parameters.
5698 (source_cache::get_source_lines): Move lower.
5699 * source-cache.h (class source_cache): Update comment.
5700 <get_line_charpos>: New method.
5701 <get_source_lines>: Update comment.
5702 <clear>: Clear m_offset_cache.
5703 <get_plain_source_lines>: Change parameters.
5704 <ensure>: New method
5705 <m_offset_cache>: New member.
5706 * source.c (forget_cached_source_info_for_objfile): Update.
5707 (info_source_command): Use g_source_cache.
5708 (find_source_lines, open_source_file_with_line_charpos): Remove.
5709 (print_source_lines_base, search_command_helper): Use g_source_cache.
5710 * source.h (open_source_file_with_line_charpos): Don't declare.
5711 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5712 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5713 Use g_source_cache.
5714
5715 2019-08-06 Tom Tromey <tromey@adacore.com>
5716
5717 * source-cache.c (source_cache::get_plain_source_lines):
5718 Remove "first_line" and "last_line" parameters.
5719 (source_cache::get_source_lines): Cache plain text.
5720 * source-cache.h (class source_cache)
5721 <get_plain_source_lines>: Update.
5722
5723 2019-08-06 Tom Tromey <tromey@adacore.com>
5724
5725 * source-cache.c (extract_lines): No longer a method.
5726 Changed type of parameter. Include final newline.
5727 (selftests::extract_lines_test): New function.
5728 (_initialize_source_cache): Likewise.
5729 * source-cache.h (class source_cache)
5730 <extract_lines>: Don't declare.
5731
5732 2019-08-06 Tom Tromey <tromey@adacore.com>
5733
5734 * breakpoint.c (init_breakpoint_sal): Update.
5735 (breakpoint): Update.
5736 * breakpoint.h (struct breakpoint) <filter>: Now a
5737 unique_xmalloc_ptr.
5738
5739 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5740
5741 * NEWS: Mention dictionary access on blocks.
5742 * python/py-block.c (blpy_getitem): New function.
5743 (block_object_as_mapping): New struct.
5744 (block_object_type): Use new struct for tp_as_mapping field.
5745
5746 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5747
5748 * objfiles.h (objfile): Add a comment describing partial symbols.
5749
5750 2019-08-05 Tom Tromey <tromey@adacore.com>
5751
5752 * compile/compile.c (_initialize_compile): Use _(), not N_().
5753 * thread.c (_initialize_thread): Use _(), not N_().
5754 * stack.c (_initialize_stack): Use _(), not N_().
5755 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5756
5757 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5758
5759 * dwarf2read.c (struct dw2_symtab_iterator):
5760 <want_specific_block>: Remove.
5761 <block_index>: Change type to gdb::optional.
5762 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5763 change type of BLOCK_INDEX parameter to gdb::optional.
5764 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5765 (dw2_lookup_symbol): Don't pass argument for
5766 WANT_SPECIFIC_BLOCK.
5767 (dw2_expand_symtabs_for_function): Don't pass argument for
5768 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5769 (class dw2_debug_names_iterator)
5770 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5771 parameter, change BLOCK_INDEX type to gdb::optional.
5772 <m_want_specific_block>: Remove.
5773 <m_block_index>: Change type to gdb::optional.
5774 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5775 gdb::optional. Re-write in function of gdb::optional.
5776 (dw2_debug_names_lookup_symbol): Don't pass argument for
5777 WANT_SPECIFIC_BLOCK.
5778 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5779 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5780 BLOCK_INDEX.
5781
5782 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5783
5784 * NEWS: Mention changes to "info sources" command.
5785
5786 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5787
5788 * symtab.c (filename_partial_match_opts): New struct type.
5789 (struct output_source_filename_data): New members
5790 regexp, c_regexp, partial_match.
5791 (output_source_filename): Use new members to decide to print file.
5792 (info_sources_option_defs): New variable.
5793 (make_info_sources_options_def_group, print_info_sources_header,
5794 info_sources_command_completer):
5795 New functions.
5796 (info_sources_command): Read new optional arguments.
5797 (_initialize_symtab): Update info sources help.
5798
5799 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5800
5801 * ada-lang.c (exception_support_info_v0): Renamed from...
5802 (default_exception_support_info): ... this. Create new
5803 definition for v1.
5804 (ada_has_this_exception_support): Look up catch_handlers_sym.
5805 (ada_exception_support_info_sniffer): Try v0 after default.
5806
5807 2019-08-01 Tom Tromey <tromey@adacore.com>
5808
5809 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5810 gdbarch.h.
5811
5812 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5813
5814 * s12z-tdep.c: Fix include path for s12z-opc.h.
5815
5816 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5817
5818 * NEWS: Require GNU make 3.82.
5819
5820 2019-07-16 Tom Tromey <tom@tromey.com>
5821
5822 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5823 declare.
5824
5825 2019-07-30 Tom Tromey <tromey@adacore.com>
5826
5827 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5828
5829 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5830
5831 * printcmd.c (print_address_symbolic): Print negative offsets.
5832 (build_address_symbolic): Force signed arithmetic when computing
5833 offset.
5834
5835 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5836
5837 PR/24474: Add a function to lookup static variables.
5838 * NEWS: Mention this new function.
5839 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5840 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5841 * python/python.c (python_GdbMethods): Add new function.
5842
5843 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5844
5845 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5846 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5847 (objfpy_lookup_static_symbol): New function.
5848 (objfile_object_methods): Add new functions.
5849
5850 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5851
5852 * NEWS: Mention 'set|show print frame-info'. Mention new
5853 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5854 backtrace argument. Mention that python frame filtering code
5855 is now consistent with what 'backtrace' command prints.
5856
5857 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5858
5859 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5860 comments.
5861 (print_frame_info_auto, print_frame_info_source_line,
5862 print_frame_info_location, print_frame_info_source_and_location,
5863 print_frame_info_location_and_address, print_frame_info_short_location):
5864 New declarations.
5865 (struct frame_print_options): New member print_frame_info.
5866 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5867 * stack.h (get_user_print_what_frame_info): New declaration.
5868 (frame_show_address): New declaration.
5869 * stack.c (print_frame_arguments_choices): New value 'presence'.
5870 (print_frame_info_auto, print_frame_info_source_line,
5871 print_frame_info_location, print_frame_info_source_and_location,
5872 print_frame_info_location_and_address, print_frame_info_short_location,
5873 print_frame_info_choices, print_frame_info_print_what): New definitions.
5874 (print_frame_args): Only print dots for args if print frame-arguments
5875 is 'presence'.
5876 (frame_print_option_defs): New element for "frame-info".
5877 (get_user_print_what_frame_info): New function.
5878 (frame_show_address): Make non static. Move comment to stack.h.
5879 (print_frame_info_to_print_what): New function.
5880 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5881 to decide what to print.
5882 (backtrace_command_1): Handle the new print_frame_arguments_presence
5883 value.
5884 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5885 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5886 (py_print_frame): In non-mi mode, use LOCATION as default for
5887 print_what, similarly to frame information printed directly by
5888 backtrace command. Handle frame-info user option in non MI mode.
5889
5890 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5891
5892 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5893 Add case for debugging 32-bit target on 64-bit host. Revise
5894 comment.
5895
5896 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5897
5898 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5899 instead of find_function_entry_range_from_pc.
5900
5901 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5902
5903 * stack.c (find_frame_funname): Remove code which preferred
5904 minsym over symtab sym in "certain pathological cases".
5905
5906 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5907 parameter. Change type of "do_demangle" to bool.
5908 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5909 Pass suitable "prefer_sym_over_minsym" flag to
5910 build_address_symbolic(). Don't output "+" for negative offsets.
5911 * printcmd.c (print_address_symbolic): Update invocation of
5912 build_address_symbolic to include a "prefer_sym_over_minsym"
5913 flag.
5914 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5915 Restrict cases in which use of minimal symbol is preferred to that
5916 of a found symbol. Update comments.
5917
5918 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5919 for entry pc when entry pc is out of range for that FDE.
5920
5921 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5922
5923 PR gdb/24839:
5924 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5925 type.
5926
5927 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5928
5929 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5930 this function's Python signature.
5931
5932
5933 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5934
5935 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5936 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5937 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5938 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5939 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5940
5941
5942 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5943
5944 * h8300-tdep.c (h8300_register_name_common): New.
5945 h8300_register_name): Use h8300_register_name_common.
5946 (h8300s_register_name): Likewise.
5947 (h8300sx_register_name): Likewise.
5948 (h8300h_register_nam): New.
5949 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5950
5951
5952 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5953
5954 * arm-tdep.c (arm_skip_cmse_entry): New function.
5955 (arm_is_sgstubs_section): New function.
5956 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5957
5958 2019-07-22 Tom Tromey <tom@tromey.com>
5959
5960 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5961 Don't self-assign.
5962
5963 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5964
5965 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5966 type_print.
5967
5968 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5969
5970 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5971 so that GDB doesn't match any msymbols when searching in the
5972 TYPES_DOMAIN.
5973 (print_symbol_info): Print using typedef_print or type_print based
5974 on the type of the symbol. Add updated FIXME comment moved from...
5975 (_initialize_symtab): ... move and update FIXME comment to above.
5976
5977 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5978
5979 * NEWS: Mention adding -q option to "info types".
5980 * symtab.c (struct info_types_options): New struct.
5981 (info_types_options_defs): New variable.
5982 (make_info_types_options_def_group): New function.
5983 (info_types_command): Use gdb::option framework to parse options.
5984 (info_types_command_completer): New function.
5985 (_initialize_symtab): Extend the help text on "info types" and
5986 register command completer.
5987
5988 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5989
5990 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5991 (lookup_symbol_in_objfile): Change int to block_enum and add a
5992 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5993
5994 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5995
5996 * MAINTAINERS (Write After Approval): Add self.
5997
5998 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5999
6000 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6001 instruction to the dummy code region.
6002
6003 2019-07-19 Tom Tromey <tromey@adacore.com>
6004
6005 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6006 (ARGSUSED, PARAMS, __func__): Remove rules.
6007
6008 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6009
6010 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6011 * features/arm/arm-with-iwmmxt.c: Remove.
6012 * features/arm/arm-with-iwmmxt.xml: Remove.
6013 * features/arm/arm-with-m-fpa-layout.c: Remove.
6014 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6015 * features/arm/arm-with-m-vfp-d16.c: Remove.
6016 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6017 * features/arm/arm-with-m.c: Remove.
6018 * features/arm/arm-with-m.xml: Remove.
6019 * features/arm/arm-with-neon.c: Remove.
6020 * features/arm/arm-with-neon.xml: Remove.
6021 * features/arm/arm-with-vfpv2.c: Remove.
6022 * features/arm/arm-with-vfpv2.xml: Remove.
6023 * features/arm/arm-with-vfpv3.c: Remove.
6024 * features/arm/arm-with-vfpv3.xml: Remove.
6025
6026 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6027
6028 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6029
6030 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6031
6032 * arch/aarch32.c (aarch32_create_target_description): Create
6033 target descriptions using features.
6034 * arch/arm.c (arm_create_target_description)
6035 (arm_create_mprofile_target_description): Likewise.
6036 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6037
6038 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6039
6040 * Makefile.in: Add new files.
6041 * aarch32-tdep.c: New file.
6042 * aarch32-tdep.h: New file.
6043 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6044 Call aarch32_read_description.
6045 * arch/aarch32.c: New file.
6046 * arch/aarch32.h: New file.
6047 * arch/arm.c (arm_create_target_description)
6048 (arm_create_mprofile_target_description): New function.
6049 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6050 (arm_create_target_description)
6051 (arm_create_mprofile_target_description): New declaration.
6052 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6053 read_description functions.
6054 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6055 Likewise.
6056 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6057 * arm-tdep.c (tdesc_arm_list): New variable.
6058 (arm_register_g_packet_guesses): Call create description functions.
6059 (arm_read_description) (arm_read_mprofile_description): New
6060 function.
6061 * arm-tdep.h (arm_read_description)
6062 (arm_read_mprofile_description): Add declaration.
6063 * configure.tgt: Add new files.
6064
6065 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6066
6067 * top.c (new_ui_command): Open specified terminal just once.
6068
6069 2019-07-18 Tom Tromey <tromey@adacore.com>
6070
6071 * symtab.c (main_name): Constify return type.
6072 * symfile.c (set_initial_language): Update.
6073 * symtab.h (main_name): Constify return type.
6074
6075 2019-07-17 Tom Tromey <tom@tromey.com>
6076
6077 * tui/tui-winsource.c (tui_update_source_window)
6078 (tui_update_source_window_as_is)
6079 (tui_update_source_windows_with_line): Remove return.
6080 * tui/tui-disasm.c (tui_show_disassem)
6081 (tui_show_disassem_and_update_source): Remove return.
6082 * tui/tui.c (tui_reset): Remove return.
6083 * tui/tui-wingeneral.c
6084 (tui_check_and_display_highlight_if_needed): Remove return.
6085
6086 2019-07-17 Tom Tromey <tom@tromey.com>
6087
6088 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6089
6090 2019-07-17 Tom Tromey <tom@tromey.com>
6091
6092 * tui/tui-winsource.h (struct tui_exec_info_window)
6093 (struct tui_source_window_base): Move from tui-data.h.
6094 * tui/tui-winsource.c: Move many method definitions from
6095 elsewhere. Remove "structuring" comments.
6096 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6097 (tui_source_window_base::refresh_window): Move to
6098 tui-winsource.c.
6099 * tui/tui-win.c (tui_source_window_base::refresh_all)
6100 (tui_source_window_base::update_tab_width)
6101 (tui_source_window_base::set_new_height)
6102 (tui_source_window_base::do_make_visible_with_new_height): Move to
6103 tui-winsource.c.
6104 * tui/tui-source.h: Update.
6105 * tui/tui-source.c (tui_source_window_base::reset): Move to
6106 tui-winsource.c.
6107 * tui/tui-disasm.h: Update.
6108 * tui/tui-data.h (struct tui_exec_info_window): Move to
6109 tui-winsource.h.
6110 (struct tui_source_window_base): Likewise.
6111 * tui/tui-data.c (tui_source_window_base::clear_detail)
6112 (tui_source_window_base, ~tui_source_window_base): Move to
6113 tui-winsource.c.
6114
6115 2019-07-17 Tom Tromey <tom@tromey.com>
6116
6117 * tui/tui-win.c (tui_resize_all)
6118 (tui_source_window_base::update_tab_width)
6119 (tui_adjust_win_heights): Update.
6120 (tui_win_info::make_invisible_and_set_new_height): Rename from
6121 make_invisible_and_set_new_height.
6122 * tui/tui-data.h (struct tui_win_info)
6123 <make_invisible_and_set_new_height>: New method.
6124
6125 2019-07-17 Tom Tromey <tom@tromey.com>
6126
6127 * tui/tui.c: Update.
6128 * tui/tui-source.h (struct tui_source_window): Move from
6129 tui-data.h.
6130 * tui/tui-layout.c: Update.
6131 * tui/tui-disasm.c: Update.
6132 * tui/tui-data.h (struct tui_source_window): Move to
6133 tui-source.h.
6134
6135 2019-07-17 Tom Tromey <tom@tromey.com>
6136
6137 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6138 tui-data.h.
6139 * tui/tui-data.h (struct tui_disasm_window): Move to
6140 tui-disasm.h.
6141
6142 2019-07-17 Tom Tromey <tom@tromey.com>
6143
6144 * tui/tui-regs.h (struct tui_data_item_window): Move from
6145 tui-data.h.
6146 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6147 * tui/tui-data.h (struct tui_data_item_window): Move to
6148 tui-regs.h.
6149 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6150
6151 2019-07-17 Tom Tromey <tom@tromey.com>
6152
6153 * tui/tui.c: Update.
6154 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6155 (tui_cmd_window::max_height): Move to tui-command.c.
6156 * tui/tui-layout.c: Update.
6157 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6158 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6159 tui-command.c.
6160 * tui/tui-command.h (struct tui_cmd_window): Move from
6161 tui-data.h.
6162 * tui/tui-command.c: Remove "structuring" comments.
6163 (tui_cmd_window::clear_detail)
6164 (tui_cmd_window::do_make_visible_with_new_height)
6165 (tui_cmd_window::max_height): Move from elsewhere.
6166
6167 2019-07-17 Tom Tromey <tom@tromey.com>
6168
6169 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6170 Now static.
6171 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6172 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6173
6174 2019-07-17 Tom Tromey <tom@tromey.com>
6175
6176 * tui/tui.c: Update.
6177 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6178 tui-regs.c.
6179 * tui/tui-windata.h: Remove file.
6180 * tui/tui-windata.c: Remove file.
6181 * tui/tui-win.c (tui_data_window::set_new_height)
6182 (tui_data_window::do_make_visible_with_new_height): Move to
6183 tui-regs.c.
6184 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6185 * tui/tui-regs.c: Remove "structuring" comments.
6186 (tui_data_window::first_data_item_displayed)
6187 (tui_data_window::delete_data_content_windows)
6188 (tui_data_window::erase_data_content)
6189 (tui_data_window::display_all_data)
6190 (tui_data_window::refresh_all)
6191 (tui_data_window::do_scroll_vertical)
6192 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6193 (tui_data_window::do_make_visible_with_new_height)
6194 (tui_data_window::refresh_window): Move from elsewhere.
6195 (_initialize_tui_regs): Move to end of file.
6196 * tui/tui-layout.c: Update.
6197 * tui/tui-hooks.c: Update.
6198 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6199 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6200 tui-regs.c.
6201 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6202
6203 2019-07-17 Tom Tromey <tom@tromey.com>
6204
6205 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6206 seen.
6207
6208 2019-07-17 Tom Tromey <tom@tromey.com>
6209
6210 * tui/tui-win.c (tui_source_window_base::set_new_height)
6211 (tui_source_window_base::do_make_visible_with_new_height): Use
6212 m_has_locator field directly.
6213 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6214 method.
6215 (struct tui_source_window_base) <has_locator>: Likewise.
6216
6217 2019-07-17 Tom Tromey <tom@tromey.com>
6218
6219 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6220 Don't declare.
6221 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6222 Remove.
6223 * tui/tui-win.c (tui_source_window_base::set_new_height)
6224 (tui_source_window_base::set_new_height)
6225 (make_invisible_and_set_new_height)
6226 (tui_source_window_base::do_make_visible_with_new_height)
6227 (tui_source_window_base::do_make_visible_with_new_height):
6228 Update.
6229 * tui/tui-layout.c (show_source_disasm_command, show_data)
6230 (show_source_or_disasm_and_command): Update.
6231 * tui/tui-layout.c (show_layout): Update.
6232
6233 2019-07-17 Tom Tromey <tom@tromey.com>
6234
6235 * tui/tui-layout.c (make_data_window): Remove.
6236 (show_data): Unify creation and re-initialization cases.
6237
6238 2019-07-17 Tom Tromey <tom@tromey.com>
6239
6240 * tui/tui-layout.c (make_source_window, make_disasm_window):
6241 Remove.
6242 (show_data): Unify creation and re-initialization cases.
6243
6244 2019-07-17 Tom Tromey <tom@tromey.com>
6245
6246 * tui/tui-layout.c (make_command_window): Remove.
6247 (show_source_disasm_command, show_source_or_disasm_and_command):
6248 Unify creation and re-initialization cases.
6249
6250 2019-07-17 Tom Tromey <tom@tromey.com>
6251
6252 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6253 creation and re-initialization cases.
6254
6255 2019-07-17 Tom Tromey <tom@tromey.com>
6256
6257 * tui/tui-regs.c (tui_get_register): Return void.
6258
6259 2019-07-17 Tom Tromey <tom@tromey.com>
6260
6261 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6262 Simplify.
6263
6264 2019-07-17 Tom Tromey <tom@tromey.com>
6265
6266 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6267 resetting.
6268
6269 2019-07-17 Tom Tromey <tom@tromey.com>
6270
6271 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6272 * tui/tui-regs.c (tui_reg_layout): New function.
6273 (tui_show_registers, tui_reg_command): Use it.
6274 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6275 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6276 parameters.
6277 (tui_layout_command): Remove.
6278
6279 2019-07-17 Tom Tromey <tom@tromey.com>
6280
6281 * tui/tui-layout.h (tui/tui-layout): Return void.
6282 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6283
6284 2019-07-17 Tom Tromey <tom@tromey.com>
6285
6286 * tui/tui-layout.c (show_source_disasm_command, show_data):
6287 Update.
6288 (reset_locator): Remove.
6289 (show_source_or_disasm_and_command): Update.
6290
6291 2019-07-17 Tom Tromey <tom@tromey.com>
6292
6293 * tui/tui-source.c (tui_source_window_base::reset): Remove
6294 win_type parameter.
6295 * tui/tui-layout.c (make_command_window, make_source_window)
6296 (make_disasm_window, make_data_window)
6297 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6298 (reset_locator, show_source_or_disasm_and_command): Update.
6299 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6300 win_type parameter.
6301 (struct tui_source_window_base) <reset>: Likewise.
6302
6303 2019-07-17 Tom Tromey <tom@tromey.com>
6304
6305 * tui/tui-layout.c (show_source_disasm_command): Use
6306 reset_locator.
6307 (reset_locator): New function.
6308 (init_and_make_win): Remove.
6309 (show_source_or_disasm_and_command): Use reset_locator.
6310
6311 2019-07-17 Tom Tromey <tom@tromey.com>
6312
6313 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6314 condition.
6315 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6316 Remove condition.
6317 * tui/tui-source.c (tui_source_window_base::reset): New method.
6318 * tui/tui-layout.c (make_command_window): Don't call
6319 init_and_make_win.
6320 (make_source_window, make_disasm_window): Don't call
6321 make_source_or_disasm_window.
6322 (make_data_window): Don't call init_and_make_win. Change calling
6323 convention.
6324 (show_source_disasm_command, show_data): Simplify.
6325 (make_source_or_disasm_window): Remove.
6326 (show_source_or_disasm_and_command): Simplify.
6327 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6328 (struct tui_source_window_base) <reset>: Likewise.
6329 <execution_info>: Remove initializer.
6330 * tui/tui-data.c (tui_source_window_base): Initialize
6331 execution_info.
6332
6333 2019-07-17 Tom Tromey <tom@tromey.com>
6334
6335 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6336 variable.
6337
6338 2019-07-17 Tom Tromey <tom@tromey.com>
6339
6340 * tui/tui.c (tui_rl_other_window): Update.
6341 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6342 superclass method first. Always iterate over regs_content.
6343 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6344 method.
6345 * tui/tui-win.c (tui_set_focus_command): Update.
6346
6347 2019-07-17 Tom Tromey <tom@tromey.com>
6348
6349 * tui/tui-win.c (tui_set_focus_command): Rename from
6350 tui_set_focus. Call tui_enable.
6351 (tui_set_focus_command): Remove.
6352
6353 2019-07-17 Tom Tromey <tom@tromey.com>
6354
6355 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6356 refresh_window.
6357 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6358 touchwin.
6359 (tui_data_window::refresh_window): Call refresh_window on data
6360 items. Always call superclass refresh_window.
6361 (tui_win_info::refresh): Remove.
6362 (tui_source_window_base::refresh_window): Update.
6363 (tui_refresh_all): Update.
6364 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6365 refresh_window.
6366 (show_source_or_disasm_and_command): Likewise.
6367 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6368 (struct tui_source_window_base) <refresh>: Likewise.
6369
6370 2019-07-17 Tom Tromey <tom@tromey.com>
6371
6372 * tui/tui-winsource.c (tui_clear_source_content)
6373 (tui_show_source_content): Update.
6374 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6375 whether content is empty.
6376 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6377 Remove.
6378
6379 2019-07-17 Tom Tromey <tom@tromey.com>
6380
6381 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6382 window's contents.
6383 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6384 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6385
6386 2019-07-17 Tom Tromey <tom@tromey.com>
6387
6388 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6389 (struct tui_data_item_window): Update.
6390
6391 2019-07-17 Tom Tromey <tom@tromey.com>
6392
6393 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6394 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6395 defines.
6396
6397 2019-07-17 Tom Tromey <tom@tromey.com>
6398
6399 * tui/tui-winsource.h (tui_erase_source_content)
6400 (tui_clear_source_content): Remove "display_prompt" parameter.
6401 * tui/tui-winsource.c (tui_update_source_window_as_is)
6402 (tui_update_source_windows_with_addr): Update.
6403 (tui_clear_source_content): Remove "display_prompt" parameter.
6404 (tui_erase_source_content): Likewise. Simplify.
6405 (tui_show_source_content): Update.
6406 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6407 * tui/tui-stack.c (tui_show_frame_info): Update.
6408 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6409 Remove defines.
6410
6411 2019-07-17 Tom Tromey <tom@tromey.com>
6412
6413 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6414 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6415 parameter.
6416 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6417 parameter.
6418
6419 2019-07-17 Tom Tromey <tom@tromey.com>
6420
6421 * tui/tui-winsource.c (tui_clear_source_content)
6422 (tui_show_source_content, tui_show_exec_info_content)
6423 (tui_clear_exec_info_content): Update.
6424 * tui/tui-stack.c (tui_show_locator_content): Update.
6425 (tui_show_frame_info): Update.
6426 * tui/tui-source.h (tui_source_window): Don't declare.
6427 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6428 from tui_source_is_displayed.
6429 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6430 Remove field.
6431 (struct tui_source_window_base) <content_in_use>: New field. Now
6432 bool.
6433 (struct tui_source_window) <showing_source_p>: New method.
6434 (TUI_SRC_WIN): Change cast.
6435 * tui/tui-data.c (tui_initialize_static_data): Update.
6436
6437 2019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6440 location_matches_p.
6441 * tui/tui-source.c (tui_source_window::location_matches_p): New
6442 method.
6443 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6444 method.
6445 * tui/tui-data.h (struct tui_source_window_base)
6446 <location_matches_p>: New method.
6447 (struct tui_source_window, struct tui_disasm_window)
6448 <location_matches_p>: Likewise.
6449
6450 2019-07-17 Tom Tromey <tom@tromey.com>
6451
6452 * tui/tui-win.c (tui_set_win_height_command): Rename from
6453 tui_set_win_height.
6454 (tui_set_win_height_command): Remove.
6455
6456 2019-07-17 Tom Tromey <tom@tromey.com>
6457
6458 * tui/tui-source.c (tui_source_window): New constructor. Add
6459 observer.
6460 (~tui_source_window): New destructor.
6461 (tui_source_window::style_changed): New method.
6462 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6463 (tui_attach_detach_observers): Update.
6464 * tui/tui-data.h (struct tui_source_window): Make constructor not
6465 inline. Add destructor.
6466 (struct tui_source_window) <style_changed>: New method.
6467 <m_observable>: New member.
6468
6469 2019-07-17 Tom Tromey <tom@tromey.com>
6470
6471 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6472 * tui/tui-win.c (tui_resize_all): Fix typo.
6473
6474 2019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6477 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6478 (tui_refresh_all): Remove "list" parameter. Use foreach.
6479 * tui/tui-win.c (window_name_completer): Use foreach.
6480 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6481 (update_tab_width): Likewise.
6482 * tui/tui-layout.c (show_layout): Update.
6483 * tui/tui-data.h (class tui_window_iterator): New.
6484 (struct all_tui_windows): New.
6485 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6486
6487 2019-07-17 Tom Tromey <tom@tromey.com>
6488
6489 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6490 parameter. Don't reference globals.
6491 (tui_reg_command): Update.
6492
6493 2019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-regs.c (tui_show_registers): Simplify.
6496
6497 2019-07-17 Tom Tromey <tom@tromey.com>
6498
6499 * tui/tui-regs.c (tui_show_registers): Update.
6500 (tui_show_register_group): Add win_info parameter.
6501
6502 2019-07-17 Tom Tromey <tom@tromey.com>
6503
6504 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6505 Rename from tui_display_reg_element_at_line.
6506 (tui_data_window::display_registers_from_line): Update.
6507 * tui/tui-data.h (struct tui_data_window)
6508 <display_reg_element_at_line>: New method.
6509
6510 2019-07-17 Tom Tromey <tom@tromey.com>
6511
6512 * tui/tui-regs.h (tui_display_registers_from)
6513 (tui_display_registers_from_line): Don't declare.
6514 * tui/tui-windata.c (tui_data_window::display_all_data)
6515 (tui_data_window::refresh_all)
6516 (tui_data_window::do_scroll_vertical): Update.
6517 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6518 from tui_display_registers_from.
6519 (tui_display_reg_element_at_line): Update.
6520 (tui_data_window::display_registers_from_line): Rename from
6521 tui_display_registers_from_line.
6522 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6523 display_registers_from_line>: New methods.
6524
6525 2019-07-17 Tom Tromey <tom@tromey.com>
6526
6527 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6528 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6529 from tui_erase_data_content.
6530 (tui_data_window::display_all_data)
6531 (tui_data_window::refresh_all)
6532 (tui_data_window::do_scroll_vertical): Update.
6533 * tui/tui-regs.c (tui_show_registers): Update.
6534 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6535 New method.
6536
6537 2019-07-17 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6540 declare.
6541 * tui/tui-windata.c
6542 (tui_data_window::delete_data_content_windows): Rename from
6543 tui_delete_data_content_windows.
6544 (tui_data_window::display_all_data)
6545 (tui_data_window::do_scroll_vertical): Update.
6546 * tui/tui-data.h (struct tui_data_window)
6547 <delete_data_content_windows>: New method.
6548
6549 2019-07-17 Tom Tromey <tom@tromey.com>
6550
6551 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6552 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6553
6554 2019-07-17 Tom Tromey <tom@tromey.com>
6555
6556 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6557 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6558 from tui_display_all_data.
6559 * tui/tui-win.c
6560 (tui_data_window::do_make_visible_with_new_height): Update.
6561 * tui/tui-regs.c (tui_show_registers): Update.
6562 * tui/tui-layout.c (tui_set_layout): Update.
6563 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6564 method.
6565
6566 2019-07-17 Tom Tromey <tom@tromey.com>
6567
6568 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6569 * tui/tui-windata.c (tui_display_data_from): Remove.
6570 (tui_data_window::refresh_all): Update.
6571
6572 2019-07-17 Tom Tromey <tom@tromey.com>
6573
6574 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6575 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6576 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6577 tui_display_registers_from_line.
6578 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6579 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6580 "force_display" parameter.
6581
6582 2019-07-17 Tom Tromey <tom@tromey.com>
6583
6584 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6585 declare.
6586 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6587 Rename from tui_first_reg_element_no_inline.
6588 (tui_display_reg_element_at_line)
6589 (tui_display_registers_from_line): Update.
6590 * tui/tui-data.h (struct tui_data_window)
6591 <first_reg_element_no_inline>: New method.
6592
6593 2019-07-17 Tom Tromey <tom@tromey.com>
6594
6595 * tui/tui-windata.c (tui_display_data_from)
6596 (tui_data_window::do_scroll_vertical): Update.
6597 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6598 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6599 Rename from tui_line_from_reg_element_no.
6600 (tui_display_registers_from_line): Update.
6601 * tui/tui-data.h (struct tui_data_window)
6602 <line_from_reg_element_no>: New method.
6603
6604 2019-07-17 Tom Tromey <tom@tromey.com>
6605
6606 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6607 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6608 tui_last_regs_line_no.
6609 (tui_display_reg_element_at_line)
6610 (tui_display_registers_from_line): Update.
6611 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6612 method.
6613
6614 2019-07-17 Tom Tromey <tom@tromey.com>
6615
6616 PR tui/24722:
6617 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6618 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6619 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6620 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6621 (tui_update_breakpoint_info): Likewise.
6622 * tui/tui-hooks.c (tui_event_create_breakpoint)
6623 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6624 Update.
6625
6626 2019-07-17 Tom Tromey <tom@tromey.com>
6627
6628 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6629
6630 2019-07-17 Tom Tromey <tom@tromey.com>
6631
6632 * tui/tui-winsource.c (tui_update_source_window_as_is)
6633 (tui_update_source_windows_with_addr): Update.
6634 * tui/tui-source.h (tui_set_source_content)
6635 (tui_show_symtab_source): Add "win_info" parameter.
6636 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6637 parameter.
6638 (tui_show_symtab_source): Likewise.
6639
6640 2019-07-17 Tom Tromey <tom@tromey.com>
6641
6642 * tui/tui-wingeneral.c
6643 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6644
6645 2019-07-17 Tom Tromey <tom@tromey.com>
6646
6647 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6648 (struct tui_cmd_window) <can_scroll>: New method.
6649 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6650 method.
6651
6652 2019-07-17 Tom Tromey <tromey@adacore.com>
6653
6654 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6655 do_field_signed>: Rename. Change type of "value".
6656 * ui-out.c (ui_out::field_signed): Rename from field_int.
6657 Change type of "value".
6658 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6659 type of "value".
6660 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6661 do_field_int. Change type of "value".
6662 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6663 do_field_int. Change type of "value".
6664 * tracepoint.c (trace_status_mi, tfind_1)
6665 (print_one_static_tracepoint_marker): Update.
6666 * thread.c (print_thread_info_1, print_selected_thread_frame):
6667 Update.
6668 * stack.c (print_frame, print_frame_info): Update.
6669 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6670 Update.
6671 * source.c (print_source_lines_base): Update.
6672 * skip.c (info_skip_command): Update.
6673 * record-btrace.c (btrace_ui_out_decode_error)
6674 (btrace_call_history_src_line): Update.
6675 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6676 Update.
6677 * progspace.c (print_program_space): Update.
6678 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6679 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6680 do_field_int. Change type of "value".
6681 * mi/mi-out.c (mi_ui_out::do_table_begin)
6682 (mi_ui_out::do_table_header): Update.
6683 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6684 type of "value".
6685 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6686 (mi_cmd_data_list_changed_registers, output_register)
6687 (mi_cmd_data_read_memory, mi_load_progress)
6688 (mi_cmd_trace_frame_collected): Update.
6689 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6690 Update.
6691 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6692 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6693 (mi_cmd_var_list_children, varobj_update_one): Update.
6694 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6695 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6696 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6697 * inferior.c (print_inferior): Update.
6698 * gdb_bfd.c (print_one_bfd): Update.
6699 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6700 Update.
6701 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6702 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6703 do_field_int. Change type of "value".
6704 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6705 do_field_int. Change type of "value".
6706 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6707 (print_one_breakpoint_location, print_it_catch_fork)
6708 (print_one_catch_fork, print_it_catch_vfork)
6709 (print_one_catch_vfork, print_it_catch_solib)
6710 (print_it_catch_exec, print_it_ranged_breakpoint)
6711 (print_mention_watchpoint, print_mention_masked_watchpoint)
6712 (bkpt_print_it, update_static_tracepoint): Update.
6713 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6714 * break-catch-syscall.c (print_it_catch_syscall): Update.
6715 * ada-tasks.c (print_ada_task_info): Update.
6716 * ada-lang.c (print_it_exception, print_mention_exception):
6717 Update.
6718
6719 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6720
6721 PR breakpoints/24541
6722 * gdbarch.c: Regenerate.
6723 * gdbarch.h: Regenerate.
6724 * gdbarch.sh: Adjust return type and parameter types for
6725 'stap_adjust_register'.
6726 (i386_stap_adjust_register): Adjust signature and return new
6727 register name.
6728 * stap-probe.c (stap_parse_register_operand): Adjust use of
6729 'gdbarch_stap_adjust_register'.
6730
6731 2019-07-17 Tom Tromey <tromey@adacore.com>
6732
6733 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6734 declare VEC.
6735 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6736 std::vector.
6737 (struct s390_process_info): Add initializers.
6738 (s390_add_process): Use new.
6739 (s390_linux_nat_target::low_forget_process): Use delete.
6740 (s390_linux_nat_target::low_new_fork)
6741 (s390_linux_nat_target::stopped_by_watchpoint)
6742 (s390_linux_nat_target::low_prepare_to_resume)
6743 (s390_linux_nat_target::insert_watchpoint)
6744 (s390_linux_nat_target::insert_hw_breakpoint)
6745 (s390_linux_nat_target::remove_watchpoint)
6746 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6747
6748 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6749
6750 * aarch64-fbsd-nat.c: Include regcache.h.
6751 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6752 argument.
6753 (aarch64_fbsd_nat_target::fetch_registers)
6754 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6755 variable.
6756 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6757
6758 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6759
6760 * fbsd-nat.c: Include gdbarch.h.
6761
6762 2019-07-15 Tom Tromey <tromey@adacore.com>
6763
6764 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6765
6766 2019-07-15 Tom Tromey <tromey@adacore.com>
6767
6768 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6769 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6770 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6771 * cli-out.c (cli_ui_out::do_field_int): New method.
6772 * ui-out.c (ui_out::field_unsigned): New method.
6773 * symfile.c (generic_load): Use field_unsigned.
6774 (print_transfer_performance): Likewise.
6775 * record-btrace.c (ui_out_field_uint): Remove.
6776 (btrace_call_history_insn_range, btrace_call_history): Use
6777 field_unsigned.
6778 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6779 field_unsigned.
6780 * ui-out.h (class ui_out) <field_unsigned>: New method.
6781 <do_field_unsigned>: Likewise.
6782
6783 2019-07-15 Tom Tromey <tromey@adacore.com>
6784
6785 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6786 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6787 * target.c (flash_erase_command): Use field_string.
6788 * infrun.c (print_signal_received_reason): Use field_string.
6789 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6790 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6791 field_string.
6792 * ada-tasks.c (print_ada_task_info): Use field_string.
6793
6794 2019-07-15 Tom Tromey <tromey@adacore.com>
6795
6796 * target.c (flash_erase_command): Use field_core_addr.
6797 * symfile.c (generic_load): Use field_core_addr.
6798 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6799 Use field_core_addr.
6800 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6801 field_core_addr.
6802
6803 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6804
6805 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6806 value if its desired type is smaller than a CORE_ADDR and signed.
6807
6808 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6809
6810 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6811 of changes to field names, and use new is_reference field to
6812 decide if a property is a reference or not.
6813 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6814 field.
6815 (struct dwarf2_property_baton): Update header comment, rename
6816 'referenced_type' to 'property_type' and update comments.
6817 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6818 default property type, store in property baton, update to take
6819 accound of renamed field.
6820 (read_func_scope): Update call to attr_to_dynamic_prop.
6821 (read_array_type): Likewise.
6822 (dwarf2_per_cu_addr_sized_int_type): New function.
6823 (read_subrange_index_type): Move type finding code to
6824 dwarf2_per_cu_addr_sized_int_type.
6825 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6826 (dwarf2_per_cu_addr_type): New function.
6827 (set_die_type): Update calls to attr_to_dynamic_prop.
6828
6829 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6830
6831 * dwarf2read.c (read_subrange_index_type): New function.
6832 (read_subrange_type): Move code into new function and call it.
6833 * gdbtypes.c (create_range_type): Add some asserts.
6834
6835 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6836
6837 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6838 update return statements.
6839 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6840 declaration, and update comment to match.
6841 * gdbtypes.c (resolve_dynamic_array): Update call to
6842 dwarf2_evaluate_property to match new return type.
6843
6844 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6845
6846 * valarith.c (value_subscripted_rvalue): Change lowerbound
6847 parameter type from int to LONGEST.
6848 * value.h (value_subscripted_rvalue): Likewise in declaration.
6849
6850 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6851
6852 * cli/cli-utils.c (info_print_command_completer): New function.
6853 * cli/cli-utils.h: Add 'completer.h' include, and forward
6854 declaration for 'struct cmd_list_element'.
6855 (info_print_command_completer): Declare.
6856 * stack.c (_initialize_stack): Add completer for 'info locals' and
6857 'info args'.
6858 * symtab.c (_initialize_symtab): Add completer for 'info
6859 variables' and 'info functions'.
6860 * NEWS: Mention completion for additional info commands.
6861
6862 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6863
6864 * cli/cli-utils.c (extract_info_print_args): Delete.
6865 (extract_arg_maybe_quoted): Delete.
6866 (info_print_options_defs): New variable.
6867 (make_info_print_options_def_group): New function.
6868 (extract_info_print_options): Define new function.
6869 * cli/cli-utils.h (extract_info_print_args): Delete.
6870 (struct info_print_options): New structure.
6871 (extract_info_print_options): Declare new function.
6872 * stack.c (info_locals_command): Update to use new
6873 extract_info_print_options, also add a header comment.
6874 (info_args_command): Likewise.
6875 * symtab.c (info_variables_command): Likewise.
6876 (info_functions_command): Likewise.
6877
6878 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6879
6880 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6881 to extract string arguments.
6882 * common/common-utils.c (extract_string_maybe_quoted): New function.
6883 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6884
6885 2019-07-11 Tom Tromey <tromey@adacore.com>
6886
6887 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6888 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6889 * top.h (gdbinit): Don't declare.
6890 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6891 into...
6892 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6893 * top.c (gdb_init): Don't call init_cli_cmds.
6894 (gdbinit): Remove.
6895 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6896
6897 2019-07-11 Tom Tromey <tromey@adacore.com>
6898
6899 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6900 after it has been moved.
6901
6902 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6903
6904 * valops.c (value_must_coerce_to_target): Change return type to
6905 bool.
6906 * value.h (value_must_coerce_to_target): Likewise.
6907
6908 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6909
6910 * breakpoint.c (is_hardware_watchpoint): Remove
6911 forward-declaration.
6912 (is_masked_watchpoint): Change return type to bool.
6913 (is_tracepoint): Likewise.
6914 (is_breakpoint): Likewise.
6915 (is_hardware_watchpoint): Likewise.
6916 (is_watchpoint): Likewise.
6917 (is_no_memory_software_watchpoint): Likewise.
6918 (is_catchpoint): Likewise.
6919 (breakpoint_1): Make FILTER parameter's return type bool.
6920 is_masked_watchpoint): Change return type to bool.
6921 (save_breakpoints): Make FILTER parameter's return type bool.
6922 * breakpoint.h (is_breakpoint): Change return type to bool.
6923 (is_watchpoint): Likewise.
6924 (is_catchpoint): Likewise.
6925 (is_tracepoint): Likewise.
6926
6927 2019-07-10 Tom Tromey <tom@tromey.com>
6928
6929 * defs.h: Don't include gdbarch.h.
6930 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6931 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6932 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6933 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6934 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6935 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6936 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6937 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6938 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6939 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6940 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6941 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6942 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6943 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6944 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6945 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6946 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6947 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6948 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6949 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6950 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6951 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6952 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6953 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6954 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6955 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6956 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6957
6958 2019-07-10 Tom Tromey <tromey@adacore.com>
6959
6960 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6961 * breakpoint.c (init_ada_exception_breakpoint): Register as
6962 bp_catchpoint.
6963 (print_one_breakpoint_location, print_one_breakpoint): Use
6964 is_ada_exception_catchpoint.
6965 * ada-lang.c (class ada_catchpoint_location): Pass
6966 bp_loc_software_breakpoint to bp_location constructor.
6967 (is_ada_exception_catchpoint): New function.
6968
6969 2019-07-10 Tom Tromey <tromey@adacore.com>
6970
6971 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6972 VEC.
6973 (struct arm_exidx_entry): New method operator<.
6974 (struct arm_exidx_data) <section_maps>: Change type.
6975 (arm_exidx_data_free): Remove.
6976 (arm_exidx_data_key): Change type. Move lower.
6977 (arm_exidx_new_objfile): Update.
6978 (arm_compare_exidx_entries): Remove.
6979 (arm_find_exidx_entry, _initialize_arm_tdep)
6980
6981 2019-07-10 Tom Tromey <tromey@adacore.com>
6982
6983 * solib-spu.c (ocl_program_data_key): Change type.
6984 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6985 Update.
6986
6987 2019-07-10 Tom Tromey <tromey@adacore.com>
6988
6989 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6990 (struct solib_aix_inferior_data) <library_list>: Change type.
6991 (solib_aix_inferior_data_handle): Change type.
6992 (get_solib_aix_inferior_data): Update.
6993 (solib_aix_free_library_list): Remove.
6994 (library_list_start_library): Update.
6995 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6996 return type.
6997 (solib_aix_get_library_list)
6998 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6999 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7000
7001 2019-07-10 Tom Tromey <tromey@adacore.com>
7002
7003 * solib-dsbt.c (struct dsbt_info): Add initializers.
7004 (solib_dsbt_pspace_data): Change type.
7005 (dsbt_pspace_data_cleanup): Remove.
7006 (get_dsbt_info, _initialize_dsbt_solib): Update.
7007
7008 2019-07-10 Tom Tromey <tromey@adacore.com>
7009
7010 * spu-tdep.c (spu_overlay_data): Change type.
7011 (spu_get_overlay_table, spu_overlay_new_objfile)
7012 (_initialize_spu_tdep): Update.
7013
7014 2019-07-10 Tom Tromey <tromey@adacore.com>
7015
7016 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7017 destructor.
7018 (dbx_objfile_data_key): Change type and declare later.
7019 (DBX_SYMFILE_INFO): Rewrite.
7020 * dbxread.c (dbx_objfile_data_key): Change type.
7021 (dbx_symfile_init): Update.
7022 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7023 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7024 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7025
7026 2019-07-10 Tom Tromey <tromey@adacore.com>
7027
7028 * jit.c (jit_program_space_key): Change type. Move lower.
7029 (get_jit_program_space_data): Update.
7030 (jit_program_space_data_cleanup): Remove.
7031 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7032 Update.
7033 (struct jit_program_space_data): Add initializers.
7034
7035 2019-07-10 Tom Tromey <tromey@adacore.com>
7036
7037 * solib-darwin.c (struct darwin_info): Add initializers.
7038 (solib_darwin_pspace_data): Change type.
7039 (darwin_pspace_data_cleanup): Remove.
7040 (get_darwin_info, _initialize_darwin_solib): Update.
7041
7042 2019-07-10 Tom Tromey <tromey@adacore.com>
7043
7044 * remote-sim.c (struct sim_inferior_data): Add initializers,
7045 constructor, and destructor.
7046 (sim_inferior_data_key): Change type. Move lower.
7047 (check_for_duplicate_sim_descriptor): Update.
7048 (get_sim_inferior_data): Use new. Update.
7049 (~sim_inferior_data_cleanup): Rename from
7050 sim_inferior_data_cleanup. Simplify.
7051 (gdbsim_close_inferior, simulator_command)
7052 (sim_command_completer, _initialize_remote_sim): Update.
7053 (next_pid, INITIAL_PID): Move earlier.
7054
7055 2019-07-10 Tom Tromey <tromey@adacore.com>
7056
7057 * python/python-internal.h (create_thread_object): Return
7058 gdbpy_ref.
7059 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7060 * python/py-inferior.c (struct threadlist_entry): Add
7061 constructor.
7062 <thread_obj>: Now a gdbpy_ref.
7063 (thread_to_thread_object): Update.
7064 (add_thread_object): Use new.
7065 (delete_thread_object): Use delete.
7066 (infpy_threads): Update.
7067 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7068 GIL.
7069
7070 2019-07-10 Tom Tromey <tromey@adacore.com>
7071
7072 * valops.c (value_cast): Specialize error message for Ada.
7073
7074 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7075
7076 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7077
7078 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7079
7080 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7081 bpstat_should_step): Return bool, adjust comments.
7082 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7083 bpstat_should_step): Likewise.
7084
7085 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7086
7087 * features/Makefile: Use feature target descriptions for Arm.
7088 * features/arm/arm-core.c: Generate new file.
7089 * features/arm/arm-fpa.c: Likewise.
7090 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7091 * features/arm/arm-m-profile.c: Likewise.
7092 * features/arm/arm-vfpv2.c: Likewise.
7093 * features/arm/arm-vfpv3.c: Likewise.
7094 * features/arm/xscale-iwmmxt.c: Likewise.
7095 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7096
7097 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7098
7099 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7100 ptrace earlier.
7101
7102 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7103
7104 * features/aarch64-pauth.c: Regenerate.
7105
7106 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7107
7108 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7109 bool.
7110 (bpstat_what): Use false instead of 0.
7111
7112 2019-07-09 Pedro Alves <palves@redhat.com>
7113
7114 * break-catch-throw.c (is_exception_catchpoint): New.
7115 * breakpoint.c (print_one_breakpoint_location): New parameter
7116 'raw_loc'. Handle it. Use
7117 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7118 looking at the breakpoint's type.
7119 (print_one_breakpoint): If handling "maint info breakpoints", also
7120 print locations of exception catchpoints.
7121 * breakpoint.h (is_exception_catchpoint): Declare.
7122
7123 2019-07-09 Pedro Alves <palves@redhat.com>
7124
7125 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7126 "addr" field.
7127 (allocate_location_exception_catchpoint): New.
7128 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7129 (initialize_throw_catchpoint_ops): Install
7130 allocate_location_exception_catchpoint as allocate_location
7131 method.
7132 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7133 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7134 bp_loc_other.
7135 (breakpoint_address_is_meaningful): Delete.
7136 (bl_address_is_meaningful): New.
7137 (breakpoint_locations_match): Adjust comment.
7138 (bp_location_from_bp_type): New, factored out of...
7139 (bp_location::bp_location(breakpoint *)): ... this.
7140 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7141 factored out of...
7142 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7143 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7144 breakpoint_address_is_meaningful.
7145 (bp_locations_compare): Adjust comment.
7146 (update_global_location_list): Use bl_address_is_meaningful
7147 instead of breakpoint_address_is_meaningful.
7148 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7149 explicit.
7150 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7151 * python/py-breakpoint.c (bppy_get_location): No longer check
7152 whether location is null.
7153
7154 2019-07-09 Pedro Alves <palves@redhat.com>
7155
7156 PR c++/15468
7157 * breakpoint.c (print_one_breakpoint_location): Remove
7158 single-location assert.
7159
7160 2019-07-09 Tom Tromey <tom@tromey.com>
7161
7162 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7163 * configure: Rebuild.
7164 * configure.ac: Change common to gdbsupport.
7165 * gdbsupport: Rename from common.
7166 * acinclude.m4: Change common to gdbsupport.
7167 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7168 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7169 gdbsupport.
7170 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7171 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7172 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7173 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7174 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7175 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7176 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7177 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7178 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7179 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7180 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7181 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7182 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7183 coff-pe-read.c, command.h, compile/compile-c-support.c,
7184 compile/compile-c.h, compile/compile-cplus-symbols.c,
7185 compile/compile-cplus-types.c, compile/compile-cplus.h,
7186 compile/compile-loc2c.c, compile/compile.c, completer.c,
7187 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7188 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7189 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7190 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7191 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7192 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7193 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7194 features/aarch64-core.c, features/aarch64-fpu.c,
7195 features/aarch64-pauth.c, features/aarch64-sve.c,
7196 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7197 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7198 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7199 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7200 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7201 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7202 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7203 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7204 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7205 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7206 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7207 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7208 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7209 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7210 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7211 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7212 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7213 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7214 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7215 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7216 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7217 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7218 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7219 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7220 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7221 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7222 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7223 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7224 minsyms.c, mips-linux-tdep.c, namespace.h,
7225 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7226 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7227 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7228 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7229 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7230 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7231 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7232 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7233 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7234 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7235 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7236 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7237 procfs.c, producer.c, progspace.h, psymtab.h,
7238 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7239 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7240 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7241 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7242 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7243 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7244 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7245 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7246 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7247 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7248 target-memory.c, target.c, target.h, target/waitstatus.c,
7249 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7250 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7251 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7252 unittests/array-view-selftests.c,
7253 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7254 unittests/common-utils-selftests.c,
7255 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7256 unittests/format_pieces-selftests.c,
7257 unittests/function-view-selftests.c,
7258 unittests/lookup_name_info-selftests.c,
7259 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7260 unittests/mkdir-recursive-selftests.c,
7261 unittests/observable-selftests.c,
7262 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7263 unittests/parse-connection-spec-selftests.c,
7264 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7265 unittests/scoped_fd-selftests.c,
7266 unittests/scoped_mmap-selftests.c,
7267 unittests/scoped_restore-selftests.c,
7268 unittests/string_view-selftests.c, unittests/style-selftests.c,
7269 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7270 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7271 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7272 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7273 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7274 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7275
7276 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7277
7278 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7279 bool value.
7280 (decode_digits_ordinary): Set explicit_line field in sal.
7281 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7282 symtab_and_line that was set on an explicit line number in
7283 assembler code. Do always update the recorded symtab and line if
7284 we do skip the prologue.
7285
7286 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7287
7288 * breakpoint.c (set_breakpoint_location_function): Remove
7289 explicit_loc parameter.
7290 (momentary_breakpoint_from_master): Update call to
7291 set_breakpoint_location_function.
7292 (add_location_to_breakpoint): Likewise.
7293
7294 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7295
7296 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7297 required features based on default bfd type when no specific bfd
7298 is present.
7299
7300 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7301
7302 * NEWS: Mention that GDB printf and eval commands can now print
7303 C-style and Ada-style convenience var strings without
7304 calling the inferior.
7305 * printcmd.c (printf_c_string): Locally print GDB internal var
7306 instead of transiting via the inferior.
7307 (printf_wide_c_string): Likewise.
7308
7309 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7310
7311 PR breakpoints/25011
7312 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7313
7314 2019-07-04 Tom Tromey <tom@tromey.com>
7315
7316 PR tui/24724:
7317 * tui/tui-winsource.c (tui_clear_source_content): Update.
7318 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7319 (tui_update_breakpoint_info): Update.
7320 (tui_set_exec_info_content): Update.
7321 * tui/tui-source.c (tui_set_source_content_nil): Update.
7322 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7323 has_break.
7324 * tui/tui-data.h (enum tui_bp_flag): New.
7325 (tui_bp_flags): New enum flags type.
7326 (struct tui_source_element) <break_mode>: Change type. Rename
7327 from has_break.
7328 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7329 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7330 constants.
7331 * tui/tui-winsource.h: Fix comment.
7332
7333 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7334
7335 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7336 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7337 (store_fpregs_to_thread)
7338 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7339 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7340 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7341 (IWMMXT_REGS_SIZE): Add define.
7342 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7343 (fetch_vfp_regs, store_vfp_regs)
7344 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7345 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7346
7347 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7348
7349 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7350 defines.
7351 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7352 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7353 (ARM_INT_REGISTER_SIZE): ...to this.
7354 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7355 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7356 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7357 (arm_linux_collect_gregset, supply_nwfpe_register)
7358 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7359 defines.
7360 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7361 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7362 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7363 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7364 (arm_return_in_memory, arm_store_return_value)
7365 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7366 (arm_record_ld_st_multiple): Likewise.
7367 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7368 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7369
7370 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7371
7372 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7373 AARCH64_DISPLACED_MODIFIED_INSNS.
7374 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7375 (aarch64_displaced_step_copy_insn): Likewise.
7376 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7377 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7378 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7379 ARM_DISPLACED_MODIFIED_INSNS.
7380 * arm-tdep.c (arm_gdbarch_init): Likewise.
7381 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7382 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7383 (struct arm_displaced_step_closure): Use
7384 ARM_DISPLACED_MODIFIED_INSNS.
7385
7386 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7387
7388 * features/Makefile: Remove unused xml files.
7389 * features/aarch64.xml: Remove.
7390 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7391 * features/i386/amd64-avx-avx512.xml: Remove.
7392 * features/i386/amd64-avx-linux.xml: Remove.
7393 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7394 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7395 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7396 * features/i386/amd64-avx-mpx.xml: Remove.
7397 * features/i386/amd64-avx.xml: Remove.
7398 * features/i386/amd64-linux.xml: Remove.
7399 * features/i386/amd64-mpx-linux.xml: Remove.
7400 * features/i386/amd64-mpx.xml: Remove.
7401 * features/i386/amd64.xml: Remove.
7402 * features/i386/i386-avx-avx512-linux.xml: Remove.
7403 * features/i386/i386-avx-avx512.xml: Remove.
7404 * features/i386/i386-avx-linux.xml: Remove.
7405 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7406 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7407 * features/i386/i386-avx-mpx-linux.xml: Remove.
7408 * features/i386/i386-avx-mpx.xml: Remove.
7409 * features/i386/i386-avx.xml: Remove.
7410 * features/i386/i386-linux.xml: Remove.
7411 * features/i386/i386-mmx-linux.xml: Remove.
7412 * features/i386/i386-mmx.xml: Remove.
7413 * features/i386/i386-mpx-linux.xml: Remove.
7414 * features/i386/i386-mpx.xml: Remove.
7415 * features/i386/i386.xml: Remove.
7416 * features/i386/x32-avx-avx512-linux.xml: Remove.
7417 * features/i386/x32-avx-linux.xml: Remove.
7418 * features/i386/x32-linux.xml: Remove.
7419
7420 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7421
7422 * regformats/aarch64.dat: Remove.
7423 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7424 * regformats/i386/amd64-avx-linux.dat: Remove.
7425 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7426 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7427 * regformats/i386/amd64-linux.dat: Remove.
7428 * regformats/i386/amd64-mpx-linux.dat: Remove.
7429 * regformats/i386/amd64.dat: Remove.
7430 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7431 * regformats/i386/i386-avx-linux.dat: Remove.
7432 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7433 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7434 * regformats/i386/i386-linux.dat: Remove.
7435 * regformats/i386/i386-mmx-linux.dat: Remove.
7436 * regformats/i386/i386-mpx-linux.dat: Remove.
7437 * regformats/i386/i386.dat: Remove.
7438 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7439 * regformats/i386/x32-avx-linux.dat: Remove.
7440 * regformats/i386/x32-linux.dat: Remove.
7441
7442 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7443
7444 * aarch64-tdep.c: Remove xml self tests.
7445 * amd64-linux-tdep.c: Likewise.
7446 * amd64-tdep.c: Likewise.
7447 * i386-linux-tdep.c: Likewise.
7448 * i386-tdep.c: Likewise.
7449
7450 2019-07-03 Pedro Alves <palves@redhat.com>
7451
7452 PR cli/24732
7453 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7454 (pipe_cmd_option_defs): New.
7455 (make_pipe_cmd_options_def_group): New.
7456 (pipe_command): Use gdb::option::process_options.
7457 (pipe_command_completer): New function.
7458 (_initialize_cli_cmds): Install completer for "pipe" command.
7459
7460 2019-07-03 Pedro Alves <palves@redhat.com>
7461
7462 * cli/cli-option.c (union option_value) <string>: New field.
7463 (struct option_def_and_value): Add ctor, move ctor, dtor and
7464 use DISABLE_COPY_AND_ASSIGN.
7465 (option_def_and_value::clear_value): New.
7466 (parse_option, save_option_value_in_ctx, get_val_type_str)
7467 (add_setshow_cmds_for_options): Handle var_string.
7468 * cli-option.h (union option_def::var_address) <string>: New
7469 field.
7470 (struct string_option_def): New.
7471 * maint-test-options.c (struct test_options_opts): Add default
7472 ctor and use DISABLE_COPY_AND_ASSIGN.
7473 <string_opt>: New field.
7474 (test_options_opts::~test_options_opts): New.
7475 (test_options_opts::dump): Also dump "-string".
7476 (test_options_option_defs): Install "string.
7477
7478 2019-07-03 Pedro Alves <palves@redhat.com>
7479
7480 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7481 option_value with a null enumeration.
7482 (complete_options): Save the option values in the context.
7483 (save_option_value_in_ctx): New, factored out from ...
7484 (process_options): ... here.
7485 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7486 of the function.
7487 * maint-test-options.c (test_options_opts::dump): New, factored
7488 out from ...
7489 (maintenance_test_options_command_mode): ... here.
7490 (maintenance_test_options_command_completion_result): Delete.
7491 (maintenance_test_options_command_completion_text): Update
7492 comment.
7493 (maintenance_show_test_options_completion_result): Change
7494 prototype. Just print
7495 maintenance_test_options_command_completion_text.
7496 (save_completion_result): New.
7497 (maintenance_test_options_completer_mode): Pass options context to
7498 complete_options, and then save a dump.
7499 (_initialize_maint_test_options): Use add_cmd to install "maint
7500 show test-options-completion-result".
7501
7502 2019-07-03 Pedro Alves <palves@redhat.com>
7503
7504 * NEWS (New commands): Mention "with" and "maint with".
7505 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7506 (with_command, with_command_completer): New.
7507 (pipe_command): Adjust to new repeat_previous
7508 interface.
7509 (_initialize_cli_cmds): Install the "with" command and its "w"
7510 alias.
7511 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7512 declarations.
7513 * cli/cli-setshow.c (parse_cli_var_uinteger)
7514 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7515 argument strings for all var_types.
7516 (get_setshow_command_value_string): New, factored out from ...
7517 (do_show_command): ... this.
7518 * cli/cli-setshow.h: Include <string>.
7519 (get_setshow_command_value_string): Declare.
7520 * command.h (repeat_previous): Now returns const char *. Adjust
7521 comment.
7522 * maint.c: Include "cli/cli-cmds.h".
7523 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7524 (_initialize_maint_cmds): Register the "maintenance with" command.
7525 * top.c (repeat_previous): Move bits from pipe_command here:
7526 Return the saved command line, if any; error out if there's no
7527 command to relaunch.
7528
7529 2019-07-03 Pedro Alves <palves@redhat.com>
7530
7531 * NEWS (New commands): Mention "maint set/show test-settings"
7532 instead of "maint test-settings".
7533 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7534 (maintenance_test_settings_set_list): Rename to ...
7535 (maintenance_set_test_settings_list): ... this.
7536 (maintenance_test_settings_show_list): Rename to ...
7537 (maintenance_show_test_settings_list): ... this.
7538 (maintenance_test_settings_cmd): Delete.
7539 (maintenance_test_settings_set_cmd): ...
7540 (maintenance_set_test_settings_cmd): ... this.
7541 (maintenance_test_settings_show_cmd): ...
7542 (maintenance_show_test_settings_cmd): ... this.
7543 (maintenance_test_settings_show_value_cmd):
7544 (maintenance_show_test_settings_value_cmd): ... this.
7545 (_initialize_maint_test_settings): No longer install the "maint
7546 test-settings" prefix command. Rename "maint test-settings set"
7547 to "maint set test-settings", and "maint test-settings show" to
7548 "maint show test-settings". Adjust all subcommands.
7549
7550 2019-07-03 Pedro Alves <palves@redhat.com>
7551
7552 * maint-test-settings.c: Fix file's intro comment. Replace all
7553 references to "test-options" with references to "test-settings",
7554 in comments.
7555
7556 2019-07-03 Pedro Alves <palves@redhat.com>
7557
7558 * maint-test-settings.c (maintenance_test_settings_xxx)
7559 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7560 New.
7561 (maintenance_test_settings_enums): Use them.
7562 (maintenance_test_settings_enum): Default to
7563 maintenance_test_settings_xxx.
7564 (_initialize_maint_test_settings): Initialize
7565 MAINTENANCE_TEST_SETTINGS_FILENAME.
7566
7567 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7568
7569 * breakpoint.h (remove_breakpoints_inf): Change return type to
7570 void, move function documentation here.
7571 * breakpoint.c (remove_breakpoints_inf): Change return type to
7572 void, move function documentation to header.
7573
7574 2019-07-02 Pedro Alves <palves@redhat.com>
7575
7576 * NEWS (Completion improvements): Mention "info threads".
7577 * thread.c (struct info_threads_opts, info_threads_option_defs)
7578 (make_info_threads_options_def_group): New.
7579 (info_threads_command): Use gdb::option::process_options.
7580 (info_threads_command_completer): New.
7581 (_initialize_thread): Use gdb::option::build_help to build the
7582 help text for "info threads".
7583
7584 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7585
7586 * defs.h (generic_load): Move from here...
7587 * symfile.h (generic_load): ... to here. Rename name parameter
7588 to args.
7589 * symfile.c (generic_load): Add comment.
7590
7591 2019-07-01 Tom Tromey <tromey@adacore.com>
7592
7593 * dwarf2read.c
7594 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7595 declaration of without_params. Fix formatting.
7596
7597 2019-07-01 Tom Tromey <tromey@adacore.com>
7598
7599 * ada-exp.y (find_primitive_type): Update.
7600 * ada-lang.h (ada_lookup_symbol): Update.
7601 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7602 parameter.
7603 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7604
7605 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7606
7607 PR breakpoints/24541
7608 * gdbarch.c: Regenerate.
7609 * gdbarch.h: Regenerate.
7610 * gdbarch.sh: Add 'stap_adjust_register'.
7611 * i386-tdep.c: Include '<unordered_set>'.
7612 (i386_stap_adjust_register): New function.
7613 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7614 * stap-probe.c (stap_parse_register_operand): Call
7615 'gdbarch_stap_adjust_register'.
7616
7617 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7618
7619 PR python/24742
7620 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7621 * python/python.c (do_start_initialization): Use 'xmalloc'
7622 instead of 'PyMem_Malloc'.
7623
7624 2019-06-28 Tom Tromey <tromey@adacore.com>
7625
7626 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7627 for Ada.
7628
7629 2019-06-27 Tom Tromey <tromey@adacore.com>
7630
7631 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7632 objfile_key.
7633 (arm_find_mapping_symbol, arm_record_special_symbol)
7634 (_initialize_arm_tdep): Update.
7635 (arm_objfile_data_free): Remove.
7636
7637 2019-06-27 Tom Tromey <tromey@adacore.com>
7638
7639 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7640 to cp_print_static_field.
7641
7642 2019-06-26 Tom Tromey <tromey@adacore.com>
7643
7644 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7645 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7646 declare.
7647
7648 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7649
7650 * features/aarch64-core.c (create_feature_aarch64_core):
7651 Regenerate.
7652 * features/aarch64-core.xml: Add cpsr flags.
7653
7654 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7655
7656 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7657 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7658
7659 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7660
7661 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7662 field.
7663 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7664 use.
7665 (arm_record_special_symbol): Don't insert new symbol in sorted
7666 position, push it at the end.
7667
7668 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7669
7670 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7671 (arm_mapping_symbol_s): Remove.
7672 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7673 (arm_mapping_symbol_vec): New typedef.
7674 (struct arm_per_objfile): Add constructor.
7675 <section_maps>: Change type to
7676 std::unique_ptr<arm_mapping_symbol_vec[]>.
7677 (arm_compare_mapping_symbols): Remove.
7678 (arm_find_mapping_symbol): Adjust to section_maps type change.
7679 (arm_objfile_data_free): Call delete on arm_per_objfile.
7680 (arm_record_special_symbol): Adjust to section_maps type change.
7681 Allocate arm_per_objfile with new.
7682
7683 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7684
7685 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7686 with the command prefix.
7687
7688 2019-06-25 Tom Tromey <tom@tromey.com>
7689
7690 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7691 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7692
7693 2019-06-25 Tom Tromey <tom@tromey.com>
7694
7695 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7696 type.
7697 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7698 protected.
7699
7700 2019-06-25 Tom Tromey <tom@tromey.com>
7701
7702 * tui/tui-winsource.c
7703 (tui_source_window_base::set_is_exec_point_at): Add check against
7704 LOA_ADDRESS.
7705
7706 2019-06-25 Tom Tromey <tom@tromey.com>
7707
7708 * tui/tui-source.c (tui_set_source_content): Don't check before
7709 xfree.
7710 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7711
7712 2019-06-25 Tom Tromey <tom@tromey.com>
7713
7714 * tui/tui-winsource.h (tui_update_source_window_as_is)
7715 (tui_alloc_source_buffer, tui_line_is_displayed)
7716 (tui_addr_is_displayed): Change type of win_info.
7717 * tui/tui-winsource.c (tui_update_source_window_as_is)
7718 (tui_clear_source_content, tui_show_source_line)
7719 (tui_show_source_content, tui_source_window_base::refill)
7720 (tui_source_window_base::set_is_exec_point_at)
7721 (tui_source_window_base::set_is_exec_point_at)
7722 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7723 (tui_alloc_source_buffer, tui_line_is_displayed)
7724 (tui_addr_is_displayed): Change type of win_info. Update.
7725 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7726 (tui_source_window_base::do_make_visible_with_new_height):
7727 Update.
7728 * tui/tui-source.c (tui_set_source_content)
7729 (tui_set_source_content_nil)
7730 (tui_source_window::do_scroll_vertical): Update.
7731 * tui/tui-layout.c (show_layout): Update.
7732 * tui/tui-disasm.c (tui_set_disassem_content)
7733 (tui_disasm_window::do_scroll_vertical): Update.
7734 * tui/tui-data.h (tui_win_content): Remove.
7735 (struct tui_gen_win_info) <content, content_size>: Remove.
7736 (struct tui_source_element): Add initializers and destructor.
7737 (union tui_which_element, struct tui_win_element): Remove.
7738 (struct tui_source_window_base) <content>: New field.
7739 (struct tui_data_window): Remove destructor.
7740 (tui_alloc_content, tui_free_win_content)
7741 (tui_free_all_source_wins_content): Don't declare.
7742 * tui/tui-data.c (tui_initialize_static_data): Update.
7743 (init_content_element, tui_alloc_content): Remove.
7744 (~tui_gen_win_info): Update.
7745 (~tui_data_window, tui_free_all_source_wins_content)
7746 (tui_free_win_content, free_content, free_content_elements):
7747 Remove.
7748
7749 2019-06-25 Tom Tromey <tom@tromey.com>
7750
7751 * tui/tui-winsource.h (tui_clear_source_content)
7752 (tui_erase_source_content, tui_show_source_content): Change type
7753 of win_info.
7754 * tui/tui-winsource.c (tui_clear_source_content)
7755 (tui_erase_source_content, tui_show_source_content): Change type
7756 of win_info.
7757 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7758 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7759 win_info.
7760 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7761 win_info.
7762 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7763
7764 2019-06-25 Tom Tromey <tom@tromey.com>
7765
7766 * tui/tui-winsource.c (tui_clear_source_content)
7767 (tui_source_window_base::set_is_exec_point_at): Update.
7768 * tui/tui-source.c (tui_set_source_content_nil): Update.
7769 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7770 a bool.
7771 * tui/tui-data.c (init_content_element): Update.
7772
7773 2019-06-25 Tom Tromey <tom@tromey.com>
7774
7775 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7776 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7777 * tui/tui-layout.c (init_and_make_win): Update.
7778 * tui/tui.h (enum tui_win_type): Update.
7779 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7780 tui_win_is_auxillary.
7781 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7782 tui_win_is_auxillary.
7783
7784 2019-06-25 Tom Tromey <tom@tromey.com>
7785
7786 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7787 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7788 (tui_delete_data_content_windows, tui_display_all_data)
7789 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7790 Update.
7791 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7792 * tui/tui-regs.c (tui_last_regs_line_no)
7793 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7794 (tui_show_registers): Update.
7795 (tui_show_register_group): Return void. Update.
7796 (tui_display_registers_from, tui_display_reg_element_at_line)
7797 (tui_display_registers_from_line, tui_check_register_values):
7798 Update.
7799 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7800 member.
7801 (struct tui_data_window) <regs_content>: Now a std::vector.
7802 <regs_content_count>: Remove.
7803 (tui_add_content_elements, tui_free_data_content): Don't declare.
7804 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7805 (init_content_element): Remove DATA_WIN case. Add assert.
7806 (tui_add_content_elements): Remove.
7807 (tui_data_window): Update.
7808 (tui_free_data_content): Remove.
7809 (free_content_elements): Remove DATA_WIN case.
7810
7811 2019-06-25 Tom Tromey <tom@tromey.com>
7812
7813 * tui/tui-data.c (tui_data_item_window): Update.
7814 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7815 * tui/tui-windata.c (tui_display_all_data)
7816 (tui_display_data_from_line): Update.
7817 (tui_check_data_values): Remove.
7818 * tui/tui-regs.c (tui_show_register_group)
7819 (tui_display_reg_element_at_line): Update.
7820 * tui/tui-hooks.c (tui_register_changed)
7821 (tui_refresh_frame_and_register_information): Call
7822 tui_check_register_values.
7823 * tui/tui-data.h (struct tui_data_window) <data_content,
7824 data_content_count, data_type>: Remove.
7825 (enum tui_data_type): Remove.
7826
7827 * tui/tui-data.c (tui_data_window::clear_detail)
7828 (~tui_data_window): Update.
7829
7830 2019-06-25 Tom Tromey <tom@tromey.com>
7831
7832 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7833 declare.
7834 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7835 Rename from tui_first_data_item_displayed. Update.
7836 (tui_data_window::refresh_all)
7837 (tui_data_window::do_scroll_vertical): Update.
7838 * tui/tui-data.h (struct tui_data_window)
7839 <first_data_item_displayed>: Declare new method.
7840
7841 2019-06-25 Tom Tromey <tom@tromey.com>
7842
7843 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7844 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7845 contents...
7846 (tui_initialize_static_data): ...here.
7847
7848 2019-06-25 Tom Tromey <tom@tromey.com>
7849
7850 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7851 (tui_display_registers_from, tui_check_register_values): Update.
7852 (tui_display_register): Remove win_info parameter; update.
7853 (tui_get_register): Change type of parameters.
7854 * tui/tui-data.h (struct tui_data_element): Remove.
7855 (union tui_which_element) <data>: Remove.
7856 <data_window>: Change type.
7857 (struct tui_data_item_window): New.
7858 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7859 case. Add assert.
7860 (~tui_data_item_window): New destructor.
7861 (free_content_elements): Remove DATA_ITEM_WIN case.
7862
7863 2019-06-25 Tom Tromey <tom@tromey.com>
7864
7865 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7866 Remove.
7867
7868 2019-06-25 Tom Tromey <tom@tromey.com>
7869
7870 * tui/tui-data.h (struct tui_command_element): Remove.
7871 (union tui_which_element) <command>: Remove.
7872 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7873 assert.
7874 (free_content_elements): Remove CMD_WIN case.
7875
7876 2019-06-25 Tom Tromey <tom@tromey.com>
7877
7878 * tui/tui-layout.c (tui_set_layout): Update.
7879 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7880 * tui/tui-data.c (layout_def): Update.
7881
7882 2019-06-25 Tom Tromey <tom@tromey.com>
7883
7884 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7885 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7886 (tui_source_window_base::set_new_height): Update.
7887 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7888 Update.
7889 (tui_set_locator_fullname, tui_set_locator_info)
7890 (tui_show_frame_info): Update.
7891 * tui/tui-source.c (tui_set_source_content)
7892 (tui_source_is_displayed): Update.
7893 * tui/tui-layout.c (show_source_disasm_command, show_data)
7894 (show_source_or_disasm_and_command): Update.
7895 * tui/tui-disasm.c (tui_set_disassem_content)
7896 (tui_get_begin_asm_address): Update.
7897 * tui/tui-data.h (struct tui_locator_element): Remove.
7898 (union tui_which_element) <locator>: Remove.
7899 (struct tui_locator_window): New.
7900 (tui_locator_win_info_ptr): Change return type.
7901 * tui/tui-data.c (_locator): Change type.
7902 (tui_locator_win_info_ptr): Change return type.
7903 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7904 (tui_alloc_content): Add assert.
7905
7906 2019-06-25 Tom Tromey <tom@tromey.com>
7907
7908 * tui/tui-winsource.c
7909 (tui_exec_info_window::maybe_allocate_content): New method.
7910 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7911 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7912 (make_source_or_disasm_window): Add cast.
7913 * tui/tui-data.h (union tui_which_element) <simple_string>:
7914 Remove.
7915 (struct tui_source_info): New.
7916 (struct tui_source_window_base) <execution_info>: Change type.
7917 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7918 case, and add assert.
7919 (tui_alloc_content): Add assert.
7920
7921 2019-06-25 Tom Tromey <tom@tromey.com>
7922
7923 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7924 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7925 * tui/tui-data.c (tui_alloc_win_info): Remove.
7926
7927 2019-06-25 Tom Tromey <tom@tromey.com>
7928
7929 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7930 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7931 can_highlight.
7932
7933 2019-06-25 Tom Tromey <tom@tromey.com>
7934
7935 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7936 make_visible_with_new_height method.
7937 (tui_win_info::make_visible_with_new_height): New method.
7938 (tui_source_window_base::do_make_visible_with_new_height)
7939 (tui_data_window::do_make_visible_with_new_height)
7940 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7941 (make_visible_with_new_height): Remove.
7942 (tui_resize_all, tui_adjust_win_heights): Use
7943 make_visible_with_new_height method.
7944 * tui/tui-data.h (struct tui_win_info)
7945 <do_make_visible_with_new_height, make_visible_with_new_height>:
7946 New methods.
7947 (struct tui_source_window_base, struct tui_data_window)
7948 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7949 methods.
7950
7951 2019-06-25 Tom Tromey <tom@tromey.com>
7952
7953 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7954 method.
7955 (update_tab_width): Call update_tab_width method.
7956 * tui/tui-data.h (struct tui_win_info)
7957 (struct tui_source_window_base) <update_tab_width>: New methods.
7958
7959 2019-06-25 Tom Tromey <tom@tromey.com>
7960
7961 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7962 parameter.
7963 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7964 parameter.
7965 (tui_gen_win_info::make_visible): Update.
7966 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7967 parameter.
7968 * tui/tui-data.h (enum tui_box): New enum.
7969 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7970
7971 2019-06-25 Tom Tromey <tom@tromey.com>
7972
7973 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7974 init_and_make_win for EXEC_INFO_WIN.
7975 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7976 longer inline.
7977 (struct tui_win_info) <~tui_win_info>: Inline.
7978 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7979 Don't declare.
7980 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7981 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7982 Remove.
7983 (tui_initialize_static_data): Update.
7984 (~tui_gen_win_info): Handle more cleanup here.
7985 (~tui_source_window_base): Delete "execution_info".
7986 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7987
7988 2019-06-25 Tom Tromey <tom@tromey.com>
7989
7990 * tui/tui-layout.c (make_command_window): Don't set
7991 can_highlight.
7992 (show_source_disasm_command): Call the reset method.
7993 (show_data): Don't set can_highlight. Call the reset method.
7994 (tui_gen_win_info::reset): Rename from init_gen_win_info
7995 (init_and_make_win): Simplify. Return tui_gen_win_info.
7996 (show_source_or_disasm_and_command): Call the reset method.
7997 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7998 (struct tui_cmd_window): Set can_highlight.
7999
8000 2019-06-25 Tom Tromey <tom@tromey.com>
8001
8002 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8003 from make_visible.
8004 (tui_make_visible, tui_make_invisible): Rewrite.
8005 (tui_win_info::make_visible): Remove.
8006 (tui_source_window_base::make_visible): Update.
8007 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8008 method. Moved from...
8009 (struct tui_win_info) <make_visible>: ...here.
8010
8011 2019-06-25 Tom Tromey <tom@tromey.com>
8012
8013 * tui/tui-winsource.c
8014 (tui_source_window_base::do_scroll_horizontal): Remove direction
8015 parameter.
8016 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8017 direction parameter.
8018 * tui/tui-win.c (tui_win_info::forward_scroll)
8019 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8020 (tui_win_info::right_scroll): Update.
8021 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8022 direction parameter.
8023 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8024 direction parameter.
8025 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8026 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8027 Remove direction parameter.
8028 (struct tui_source_window_base, struct tui_source_window)
8029 (struct tui_disasm_window, struct tui_data_window)
8030 (struct tui_cmd_window): Update.
8031
8032 2019-06-25 Tom Tromey <tom@tromey.com>
8033
8034 * tui/tui-winsource.h (tui_set_exec_info_content)
8035 (tui_show_exec_info_content, tui_erase_exec_info_content)
8036 (tui_clear_exec_info_content, tui_update_exec_info): Change
8037 argument to tui_source_window_base.
8038 * tui/tui-winsource.c (tui_set_exec_info_content)
8039 (tui_show_exec_info_content, tui_erase_exec_info_content)
8040 (tui_clear_exec_info_content, tui_update_exec_info): Change
8041 argument to tui_source_window_base.
8042
8043 2019-06-25 Tom Tromey <tom@tromey.com>
8044
8045 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8046 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8047
8048 2019-06-25 Tom Tromey <tom@tromey.com>
8049
8050 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8051 check.
8052
8053 2019-06-25 Tom Tromey <tom@tromey.com>
8054
8055 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8056 type to void.
8057 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8058 type to void.
8059 * tui/tui-source.c (tui_set_source_content): Update.
8060 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8061
8062 2019-06-25 Tom Tromey <tom@tromey.com>
8063
8064 * tui/tui-win.c (window_name_completer, tui_set_focus)
8065 (tui_all_windows_info): Use name method.
8066 * tui/tui-data.h (struct tui_gen_win_info)
8067 (struct tui_source_window, struct tui_disasm_window)
8068 (struct tui_data_window, struct tui_cmd_window) <name>: New
8069 method.
8070 (tui_win_name): Don't declare.
8071 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8072 (tui_win_name): Remove.
8073
8074 2019-06-25 Tom Tromey <tom@tromey.com>
8075
8076 * tui/tui-winsource.h (tui_update_source_window)
8077 (tui_update_source_window_as_is): Change parameter type.
8078 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8079 to be a tui_source_window_base.
8080 (tui_update_source_window_as_is): Likewise.
8081 * tui/tui-win.c (make_visible_with_new_height): Update.
8082
8083 2019-06-25 Tom Tromey <tom@tromey.com>
8084
8085 * tui/tui-winsource.c (tui_erase_source_content)
8086 (tui_show_source_content, tui_show_exec_info_content)
8087 (tui_erase_exec_info_content): Use refresh_window method.
8088 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8089 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8090 from tui_refresh_win.
8091 (tui_data_window::refresh_window): New method.
8092 (tui_win_info::refresh, tui_source_window_base::refresh)
8093 (tui_refresh_all): Use refresh_window method.
8094 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8095 method.
8096 * tui/tui-regs.c (tui_display_register): Call refresh_window
8097 method.
8098 * tui/tui-layout.c (show_source_disasm_command)
8099 (show_source_or_disasm_and_command): Call refresh_window method.
8100 * tui/tui-data.h (struct tui_gen_win_info)
8101 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8102 New method.
8103
8104 2019-06-25 Tom Tromey <tom@tromey.com>
8105
8106 * tui/tui.c (tui_rl_other_window, tui_enable)
8107 (tui_is_window_visible, tui_get_command_dimension): Update.
8108 * tui/tui-winsource.c (tui_update_source_window_as_is)
8109 (tui_clear_source_content, tui_erase_source_content)
8110 (tui_show_source_line, tui_source_window_base::refill)
8111 (tui_source_window_base::do_scroll_horizontal)
8112 (tui_source_window_base::set_is_exec_point_at)
8113 (tui_update_breakpoint_info, tui_set_exec_info_content)
8114 (tui_alloc_source_buffer, tui_line_is_displayed)
8115 (tui_addr_is_displayed): Update.
8116 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8117 (tui_check_and_display_highlight_if_needed)
8118 (tui_win_info::make_visible, tui_win_info::refresh)
8119 (tui_refresh_all): Update.
8120 * tui/tui-windata.c (tui_first_data_item_displayed)
8121 (tui_delete_data_content_windows, tui_erase_data_content)
8122 (tui_display_all_data, tui_data_window::refresh_all)
8123 (tui_check_data_values): Update.
8124 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8125 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8126 (tui_win_info::backward_scroll, tui_refresh_all_win)
8127 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8128 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8129 (tui_source_window_base::set_new_height)
8130 (tui_data_window::set_new_height)
8131 (make_invisible_and_set_new_height)
8132 (make_visible_with_new_height, new_height_ok)
8133 (parse_scrolling_args): Update.
8134 * tui/tui-stack.c (tui_show_frame_info): Update.
8135 * tui/tui-source.c (tui_set_source_content)
8136 (tui_set_source_content_nil, tui_source_is_displayed)
8137 (tui_source_window::do_scroll_vertical): Update.
8138 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8139 (tui_display_registers_from, tui_display_reg_element_at_line)
8140 (tui_check_register_values, tui_reg_command): Update.
8141 * tui/tui-layout.c (tui_default_win_height)
8142 (show_source_disasm_command, show_data, init_and_make_win)
8143 (show_source_or_disasm_and_command): Update.
8144 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8145 (tui_redisplay_readline, tui_mld_flush)
8146 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8147 (tui_getc): Update.
8148 * tui/tui-disasm.c (tui_set_disassem_content)
8149 (tui_disasm_window::do_scroll_vertical): Update.
8150 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8151 Now virtual.
8152 (struct tui_win_info): Derive from tui_gen_win_info.
8153 <~tui_win_info>: Mark as override.
8154 <generic>: Remove member.
8155 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8156 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8157 (~tui_data_window, ~tui_win_info)
8158 (tui_free_all_source_wins_content): Update.
8159 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8160
8161 2019-06-25 Tom Tromey <tom@tromey.com>
8162
8163 * tui/tui-layout.c (init_and_make_win): Use new.
8164 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8165 destructor, initializers.
8166 (tui_alloc_generic_win_info): Don't declare.
8167 * tui/tui-data.c (_locator): Add argument to constructor.
8168 (source_win, disasm_win): New globals.
8169 (exec_info): Remove.
8170 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8171 Update.
8172 (tui_alloc_generic_win_info): Remove.
8173 (init_content_element): Use new.
8174 (tui_win_info::tui_win_info): Update.
8175 (free_content_elements) <case DATA_WIN>: Use delete.
8176
8177 2019-06-25 Tom Tromey <tom@tromey.com>
8178
8179 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8180 * tui/tui-windata.c (tui_first_data_item_displayed)
8181 (tui_delete_data_content_windows): Update.
8182 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8183 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8184 (tui_display_registers_from, tui_check_register_values): Update.
8185 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8186 pointer.
8187 * tui/tui-data.c (init_content_element): Update. Allocate the new
8188 window.
8189 (tui_free_data_content): Update.
8190 (free_content_elements) <case DATA_WIN>: Free the window.
8191
8192 2019-06-25 Tom Tromey <tom@tromey.com>
8193
8194 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8195 Update.
8196 * tui/tui-layout.c (make_command_window)
8197 (show_source_disasm_command, show_data, init_and_make_win)
8198 (show_source_or_disasm_and_command): Update.
8199 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8200 method.
8201 <can_highight, is_highlighted>: Now bool.
8202 (tui_set_win_highlight): Don't declare.
8203 * tui/tui-data.c (tui_set_win_highlight): Remove.
8204
8205 2019-06-25 Tom Tromey <tom@tromey.com>
8206
8207 * tui/tui-wingeneral.c (make_visible): Remove check of window
8208 type.
8209
8210 2019-06-25 Tom Tromey <tom@tromey.com>
8211
8212 * tui/tui-win.c (tui_win_info::max_height)
8213 (tui_cmd_window::max_height): New methods.
8214 (new_height_ok): Call max_height.
8215 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8216 <max_height>: New method.
8217
8218 2019-06-25 Tom Tromey <tom@tromey.com>
8219
8220 * tui/tui-win.c (tui_source_window_base::set_new_height)
8221 (tui_data_window::set_new_height): New methods.
8222 (make_invisible_and_set_new_height): Call set_new_height method.
8223 * tui/tui-data.h (struct tui_win_info)
8224 (struct tui_source_window_base, struct tui_data_window)
8225 <set_new_height>: New method.
8226
8227 2019-06-25 Tom Tromey <tom@tromey.com>
8228
8229 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8230 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8231 tui_refresh_data_win.
8232 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8233 method.
8234 (tui_refresh_all_win): Call the refresh_all method.
8235 (tui_set_focus): Likewise.
8236 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8237 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8238 Likewise.
8239
8240 2019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui-winsource.h (tui_refill_source_window)
8243 (tui_set_is_exec_point_at): Don't declare.
8244 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8245 (tui_source_window_base::refill): Rename from
8246 tui_refill_source_window.
8247 (tui_source_window_base::do_scroll_horizontal): Update.
8248 (tui_source_window_base::set_is_exec_point_at): Rename from
8249 tui_set_is_exec_point_at.
8250 (tui_update_all_breakpoint_info): Update.
8251 * tui/tui-stack.c (tui_show_frame_info): Update.
8252 * tui/tui-layout.c (show_data): Add cast.
8253 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8254 * tui/tui-data.h (struct tui_source_window_base) <refill,
8255 set_is_exec_point_at>: New methods.
8256 (tui_source_windows, tui_add_to_source_windows): Update types.
8257 (tui_add_to_source_windows): Remove redundant declaration.
8258 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8259 (tui_source_windows): Change return type.
8260 (tui_clear_source_windows_detail): Update.
8261 (tui_add_to_source_windows): Change type of parameter.
8262 (tui_free_all_source_wins_content): Update.
8263
8264 2019-06-25 Tom Tromey <tom@tromey.com>
8265
8266 * tui/tui-wingeneral.c (tui_win_info::refresh)
8267 (tui_source_window_base::refresh): New methods.
8268 (tui_refresh_all): Call the refresh method.
8269 * tui/tui-data.h (struct tui_win_info)
8270 (struct tui_source_window_base) <refresh>: New method.
8271
8272 2019-06-25 Tom Tromey <tom@tromey.com>
8273
8274 * tui/tui.h (tui_is_window_visible): Return bool.
8275 * tui/tui.c (tui_is_window_visible): Return bool.
8276 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8277 (tui_make_visible, tui_make_invisible)
8278 (tui_win_info::make_visible)
8279 (tui_source_window_base::make_visible, make_all_visible)
8280 (tui_make_all_visible, tui_make_all_invisible): Update.
8281 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8282 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8283 bool.
8284 (struct tui_win_info, struct tui_source_window_base)
8285 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8286 * tui/tui-data.c (tui_init_generic_part): Update.
8287
8288 2019-06-25 Tom Tromey <tom@tromey.com>
8289
8290 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8291 (tui_source_window_base::make_visible): New methods.
8292 (make_all_visible): Make method call.
8293 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8294 (struct tui_source_window_base, struct tui_cmd_window): Override
8295 make_visible.
8296 (tui_win_is_source_type): Don't declare.
8297 * tui/tui-data.c (tui_win_is_source_type): Remove.
8298
8299 2019-06-25 Tom Tromey <tom@tromey.com>
8300
8301 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8302 NULL check.
8303
8304 2019-06-25 Tom Tromey <tom@tromey.com>
8305
8306 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8307 Inline constructor. Add initializers for members.
8308 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8309 constructors; now inline in class.
8310
8311 2019-06-25 Tom Tromey <tom@tromey.com>
8312
8313 * tui/tui-regs.c (tui_show_registers): Update.
8314 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8315 bool.
8316 * tui/tui-data.c (tui_data_window::clear_detail)
8317 (tui_data_window): Update.
8318
8319 2019-06-25 Tom Tromey <tom@tromey.com>
8320
8321 * tui/tui-windata.c (tui_display_all_data)
8322 (tui_display_data_from_line, tui_display_data_from)
8323 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8324 Update.
8325 * tui/tui-regs.c (tui_last_regs_line_no)
8326 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8327 (tui_show_registers, tui_show_register_group)
8328 (tui_display_registers_from, tui_display_reg_element_at_line)
8329 (tui_display_registers_from_line, tui_check_register_values)
8330 (tui_reg_next, tui_reg_prev): Update.
8331 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8332 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8333 tui_data_window.
8334 (struct tui_win_info) <detail>: Remove. Add new fields from
8335 tui_data_info.
8336 (TUI_DATA_WIN): Add cast.
8337 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8338 (~tui_data_window): Simplify.
8339
8340 2019-06-25 Tom Tromey <tom@tromey.com>
8341
8342 * tui/tui-layout.c (show_source_disasm_command)
8343 (show_source_or_disasm_and_command): Update.
8344 * tui/tui-io.c (update_cmdwin_start_line)
8345 (tui_redisplay_readline): Update.
8346 * tui/tui-data.h (struct tui_command_info): Remove.
8347 (struct tui_win_info) <detail>: Remove command_info member.
8348 (struct tui_data_window) <start_line>: New member, from
8349 tui_command_info.
8350 (TUI_CMD_WIN): Add casts.
8351
8352 2019-06-25 Tom Tromey <tom@tromey.com>
8353
8354 * tui/tui-winsource.c (tui_update_source_window)
8355 (tui_refill_source_window)
8356 (tui_source_window_base::do_scroll_horizontal)
8357 (tui_update_breakpoint_info, tui_set_exec_info_content)
8358 (tui_show_exec_info_content, tui_erase_exec_info_content)
8359 (tui_clear_exec_info_content): Update.
8360 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8361 Update.
8362 * tui/tui-win.c (make_invisible_and_set_new_height)
8363 (make_visible_with_new_height): Update.
8364 * tui/tui-source.c (tui_set_source_content)
8365 (tui_show_symtab_source): Update.
8366 * tui/tui-layout.c (extract_display_start_addr)
8367 (show_source_disasm_command, show_data)
8368 (make_source_or_disasm_window)
8369 (show_source_or_disasm_and_command): Update.
8370 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8371 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8372 "gdbarch".
8373 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8374 to tui_source_window_base.
8375 (struct tui_win_info) <detail>: Remove source_info member.
8376 (struct tui_source_window_base) <has_locator>: Inline.
8377 Move contents from tui_source_info; rename has_locator member to
8378 m_has_locator.
8379 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8380 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8381 header file.
8382 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8383 Simplify.
8384 (tui_free_all_source_wins_content): Cast to
8385 tui_source_window_base.
8386
8387 2019-06-25 Tom Tromey <tom@tromey.com>
8388
8389 * tui/tui-win.c (make_invisible_and_set_new_height)
8390 (make_visible_with_new_height): Call has_locator method.
8391 * tui/tui-layout.c (show_source_disasm_command, show_data)
8392 (show_source_or_disasm_and_command): Update for bool change.
8393 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8394 (tui_win_info) <has_locator>: New method.
8395 (struct tui_source_window_base) <has_locator>: New method.
8396 (tui_win_has_locator): Don't declare.
8397 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8398 from tui_win_has_locator.
8399 (tui_source_window_base): Use false, not FALSE.
8400
8401 2019-06-25 Tom Tromey <tom@tromey.com>
8402
8403 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8404 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8405 clear_detail method directly.
8406 (tui_clear_win_detail): Remove.
8407
8408 2019-06-25 Tom Tromey <tom@tromey.com>
8409
8410 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8411 "this", not TUI_DISASM_WIN.
8412
8413 2019-06-25 Tom Tromey <tom@tromey.com>
8414
8415 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8416 declare.
8417 * tui/tui-winsource.c
8418 (tui_source_window_base::do_scroll_horizontal): Rename from
8419 tui_horizontal_source_scroll.
8420 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8421 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8422 from tui_vertical_data_scroll.
8423 * tui/tui-win.h (tui_scroll): Don't declare.
8424 * tui/tui-win.c (tui_win_info::forward_scroll)
8425 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8426 (tui_win_info::right_scroll): Rename and update.
8427 (tui_scroll_forward_command, tui_scroll_backward_command)
8428 (tui_scroll_left_command, tui_scroll_right_command): Update.
8429 (tui_scroll): Remove.
8430 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8431 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8432 from tui_vertical_source_scroll.
8433 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8434 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8435 from tui_vertical_disassem_scroll.
8436 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8437 do_scroll_horizontal>: New methods.
8438 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8439 Likewise.
8440 (struct tui_source_window_base): Add do_scroll_horizontal.
8441 (struct tui_source_window, struct tui_disasm_window): Add
8442 do_scroll_vertical.
8443 (struct tui_data_window, struct tui_cmd_window): Add
8444 do_scroll_horizontal and do_scroll_vertical.
8445 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8446
8447 2019-06-25 Tom Tromey <tom@tromey.com>
8448
8449 * tui/tui-data.h (struct tui_source_window_base): New struct.
8450 (struct tui_source_window): Derive from tui_source_window_base.
8451 (struct tui_disasm_window): New struct.
8452 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8453 from tui_source_window::clear_detail.
8454 (tui_source_window_base): Rename from tui_source_window.
8455 (~tui_source_window_base): Rename from ~tui_source_window.
8456 (tui_alloc_win_info): Create a tui_disasm_window.
8457
8458 2019-06-25 Tom Tromey <tom@tromey.com>
8459
8460 * tui/tui-data.h (struct tui_source_window)
8461 (struct tui_data_window): Declare destructors.
8462 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8463 destructors.
8464 (tui_win_info): Simplify.
8465
8466 2019-06-25 Tom Tromey <tom@tromey.com>
8467
8468 * tui/tui-winsource.c (tui_display_main)
8469 (tui_update_source_windows_with_addr)
8470 (tui_update_all_breakpoint_info): Update.
8471 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8472 (new_height_ok, parse_scrolling_args): Update.
8473 * tui/tui-stack.c (tui_show_frame_info): Update.
8474 * tui/tui-data.h (struct tui_list): Remove.
8475 (tui_source_windows): Return a reference to a std::vector.
8476 * tui/tui-data.c (source_windows): Now a std::vector.
8477 (tui_source_windows): Change return type.
8478 (tui_clear_source_windows): Rewrite.
8479 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8480 (tui_free_all_source_wins_content): Rewrite.
8481
8482 2019-06-25 Tom Tromey <tom@tromey.com>
8483
8484 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8485 (struct tui_data_window, struct tui_cmd_window): Declare
8486 clear_detail method.
8487 * tui/tui-data.c (tui_source_window::clear_detail)
8488 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8489 methods.
8490 (tui_clear_win_detail): Simplify.
8491
8492 2019-06-25 Tom Tromey <tom@tromey.com>
8493
8494 * tui/tui-layout.c (make_source_window, make_disasm_window)
8495 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8496 Return the new window.
8497 (show_source_disasm_command, show_data)
8498 (show_source_or_disasm_and_command): Update.
8499
8500 2019-06-25 Tom Tromey <tom@tromey.com>
8501
8502 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8503 parameter. Return the new window.
8504 (show_source_disasm_command): Update and remove NULL check.
8505 (show_source_or_disasm_and_command): Update.
8506
8507 2019-06-25 Tom Tromey <tom@tromey.com>
8508
8509 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8510
8511 2019-06-25 Tom Tromey <tom@tromey.com>
8512
8513 * tui/tui-data.h (struct tui_win_info): Make constructor
8514 protected. Make destructor virtual. Add initializers.
8515 (tui_source_window, tui_data_window, tui_cmd_window): New
8516 classes.
8517 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8518 constructor. Add "type" parameter.
8519 (tui_source_window, tui_data_window, tui_cmd_window): New
8520 constructors.
8521 (tui_alloc_win_info): Instantiate the appropriate subclass.
8522
8523 2019-06-25 Tom Tromey <tom@tromey.com>
8524
8525 * tui/tui-win.c (tui_resize_all): Use delete.
8526 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8527 destructor.
8528 (tui_free_window): Don't declare.
8529 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8530 Update.
8531
8532 2019-06-25 Tom Tromey <tom@tromey.com>
8533
8534 * tui/tui-data.h (struct tui_win_info): Add constructor.
8535 * tui/tui-data.c (tui_alloc_win_info): Use new.
8536 (tui_free_window): Use delete.
8537
8538 2019-06-22 Tom Tromey <tom@tromey.com>
8539
8540 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8541 declare.
8542 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8543
8544 2019-06-22 Tom Tromey <tom@tromey.com>
8545
8546 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8547 declare.
8548 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8549
8550 2019-06-22 Tom de Vries <tdevries@suse.de>
8551
8552 * dwarf2read.c (create_addrmap_from_aranges)
8553 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8554 instead of '%zu'.
8555
8556 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8557
8558 * dwarf2read.h (dwarf2_section_info_def): Remove.
8559 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8560 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8561 std::vector<dwarf2_section_info>.
8562 (struct dwo_file) <~dwo_file>: Remove.
8563 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8564 types field.
8565 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8566 (dwarf2_read_debug_names): Likewise.
8567 (create_debug_types_hash_table): Change parameter type to
8568 array_view, adjust code accordingly.
8569 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8570 (partial_die_info::fixup): Likewise.
8571 (determine_prefix): Likewise.
8572 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8573
8574 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8575
8576 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8577 gdb_bfd_ref_ptr.
8578 <~dwo_file>: Remove call to gdb_bfd_unref.
8579 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8580 gdb_bfd_ref_ptr::get.
8581
8582 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8583
8584 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8585 type to htab_up.
8586 * dwarf2read.c (struct dwo_file): Initialize fields.
8587 <~dwo_file>: New.
8588 (free_dwo_file): Remove, move content to ~dwo_file.
8589 (struct dwo_file_deleter): Remove.
8590 (dwo_file_up>: Remove custom deleter.
8591 (free_dwo_files): Remove.
8592 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8593 dwo_files.
8594 (process_skeletonless_type_units): Call unique_ptr::get.
8595 (allocate_dwo_file_hash_table): Add deleter to created hash
8596 table. Change return type to htab_up.
8597 (lookup_dwo_file_slot): Don't memset dwo_file, call
8598 unique_ptr::get.
8599 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8600 (create_dwo_unit_in_dwp_v2): Likewise.
8601 (open_and_init_dwo_file): Likewise.
8602 (free_dwo_file_from_slot): Remove.
8603
8604 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8605
8606 * dwarf2read.h (struct dwarf2_section_info) <readin,
8607 is_virtual>: Change type to bool.
8608 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8609 true instead of 1.
8610
8611 2019-06-19 Tom Tromey <tom@tromey.com>
8612
8613 * tui/tui-data.h (tui_init_content_element): Don't declare.
8614
8615 2019-06-19 Tom Tromey <tom@tromey.com>
8616
8617 * tui/tui-data.h (tui_init_win_info): Don't declare.
8618
8619 2019-06-19 Tom de Vries <tdevries@suse.de>
8620
8621 * dwarf2read.h (abstract_to_concrete): Change type to
8622 std::unordered_map<sect_offset, std::vector<sect_offset>,
8623 gdb::hash_enum<sect_offset>>.
8624
8625 2019-06-19 Tom Tromey <tromey@adacore.com>
8626
8627 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8628 EVAL_AVOID_SIDE_EFFECTS specially.
8629
8630 2019-06-19 Tom Tromey <tromey@adacore.com>
8631
8632 * source-cache.c (highlighter): New global.
8633 (source_cache::get_source_lines): Create a highlighter on demand.
8634
8635 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8636
8637 * defs.h (deprecated_interactive_hook): Delete declaration.
8638 * interps.c (clear_interpreter_hooks): Remove use of
8639 deprecated_interactive_hook.
8640 * top.c (deprecated_interactive_hook): Delete definition.
8641 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8642
8643 2019-06-18 Tom de Vries <tdevries@suse.de>
8644
8645 PR gdb/24515
8646 * dwarf2read.h (abstract_to_concrete): Change type from
8647 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8648 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8649 * dwarf2read.c (read_variable): Update.
8650 (dwarf2_fetch_die_loc_sect_off): Update.
8651
8652 2019-06-17 Tom de Vries <tdevries@suse.de>
8653
8654 PR gdb/24617
8655 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8656 accessing parent[parent_len - 1].
8657
8658 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8659
8660 PR gdb/24364
8661 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8662 call dtrace_process_dof with NULL dof.
8663
8664 2019-06-16 Tom de Vries <tdevries@suse.de>
8665
8666 PR gdb/24445
8667 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8668
8669 2019-06-16 Tom Tromey <tom@tromey.com>
8670
8671 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8672 (make_all_visible): Use address of member.
8673
8674 2019-06-16 Tom Tromey <tom@tromey.com>
8675
8676 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8677 (tui_free_window, free_content, free_content_elements): Remove
8678 unnecessary cast.
8679 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8680 cast.
8681 * tui/tui-regs.c (tui_show_register_group)
8682 (tui_display_registers_from, tui_display_reg_element_at_line):
8683 Remove unnecessary cast.
8684
8685 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8686
8687 * linux-nat.c (normal_mask): Delete.
8688 (_initialize_linux_nat): Don't initialise normal_mask.
8689
8690 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8691
8692 PR gdb/24445
8693 * dwarf-index-write.h (write_psymtabs_to_index): Add
8694 dwz_basename parameter.
8695 * dwarf-index-write.c (write_gdbindex): Move file writing to
8696 write_gdbindex_1. Change return type void.
8697 (assert_file_size): Move up, remove filename parameter.
8698 (write_gdbindex_1): New function.
8699 (write_debug_names): Change return type to void, call
8700 assert_file_size.
8701 (struct index_wip_file): New struct.
8702 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8703 file logic to index_wip_file. Write index for dwz file if
8704 needed.
8705 (save_gdb_index_command): Pass basename of dwz file, if present.
8706 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8707 build-id of dwz file, if present.
8708 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8709 (dwarf2_get_dwz_file): Likewise.
8710 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8711 (dwarf2_get_dwz_file): Likewise.
8712
8713 2019-06-16 Tom Tromey <tom@tromey.com>
8714
8715 * coffread.c (process_coff_symbol): Use xstrdup.
8716 * value.c (create_internalvar): Use xstrdup.
8717
8718 2019-06-16 Tom Tromey <tom@tromey.com>
8719
8720 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8721 * breakpoint.c (stopin_command, stopat_command)
8722 (until_break_command, decode_location_default): Remove unnecessary
8723 cast.
8724 * utils.c (subset_compare): Remove unnecessary cast.
8725 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8726 cast.
8727 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8728 cast.
8729 * infcmd.c (path_command): Remove unnecessary cast.
8730 * coffread.c (decode_type): Remove unnecessary cast.
8731 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8732 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8733 * tui/tui-stack.c (tui_show_locator_content)
8734 (tui_show_frame_info): Remove unnecessary cast.
8735 * tui/tui-win.c (tui_scroll_forward_command)
8736 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8737 (parse_scrolling_args): Remove unnecessary cast.
8738 * tui/tui-data.c (init_win_info, tui_del_window)
8739 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8740 (free_content_elements): Remove unnecessary cast.
8741 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8742 unnecessary cast.
8743 * tui/tui-source.c (tui_set_source_content)
8744 (tui_vertical_source_scroll): Remove unnecessary cast.
8745 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8746 cast.
8747 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8748 * tui/tui-regs.c (tui_display_registers_from)
8749 (tui_display_register): Remove unnecessary cast.
8750 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8751 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8752 (make_visible): Remove unnecessary cast.
8753 * tui/tui-winsource.c (tui_erase_source_content)
8754 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8755 unnecessary cast.
8756 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8757 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8758 * stabsread.c (read_type, read_array_type, read_range_type):
8759 Remove unnecessary cast.
8760 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8761 (parse_symbol, parse_type, upgrade_type, parse_external)
8762 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8763 unnecessary cast.
8764 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8765
8766 2019-06-16 Tom Tromey <tom@tromey.com>
8767
8768 * tui/tui-data.c (tui_alloc_generic_win_info)
8769 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8770 checks.
8771
8772 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8773 Andrew Burgess <andrew.burgess@embecosm.com>
8774
8775 * f-typeprint.c (f_print_type): Don't return early for not
8776 associated or not allocated types.
8777 (f_type_print_varspec_suffix): Add print_rank parameter and print
8778 ranks of array types in case they dangling.
8779 (f_type_print_base): Add print_rank parameter.
8780
8781 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8782
8783 * NEWS: Mention new MI commands.
8784 * break-catch-throw.c (enum exception_event_kind): Move to
8785 breakpoint.h.
8786 (print_mention_exception_catchpoint): Output text as a single
8787 message.
8788 (catch_exception_command_1): Rename to...
8789 (catch_exception_event): ...this, make non-static, update header
8790 command, and change some parameter types.
8791 (catch_catch_command): Update for changes to
8792 catch_exception_command_1.
8793 (catch_throw_command): Likewise.
8794 (catch_rethrow_command): Likewise.
8795 * breakpoint.c (enum exception_event_kind): Delete.
8796 * breakpoint.h (enum exception_event_kind): Moved here from
8797 break-catch-throw.c.
8798 (catch_exception_event): Declare.
8799 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8800 (mi_cmd_catch_throw): New function.
8801 (mi_cmd_catch_rethrow): New function.
8802 (mi_cmd_catch_catch): New function.
8803 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8804 'catch-catch' entries.
8805 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8806 (mi_cmd_catch_rethrow): Declare.
8807 (mi_cmd_catch_catch): Declare.
8808
8809 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8810
8811 * annotate.c (annotate_source_line): Change return type to void,
8812 update implementation to match.
8813 * annotate.h (annotate_source_line): Change return type to void,
8814 update header comment.
8815 * stack.c (print_frame_info): Don't change what frame information
8816 is printed based on whether annotations are on or not.
8817
8818 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8819
8820 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8821 (annotate_source): Make static.
8822 (annotate_source_line): Moved from source.c and renamed from
8823 identify_source_line. Update the return type.
8824 * annotate.h (annotate_source): Delete declaration.
8825 (annotate_source_line): Declaration moved from source.h, and
8826 renamed from identify_source_line. Return type updated.
8827 * source.c (identify_source_line): Moved to annotate.c and renamed
8828 to annotate_source_line.
8829 (info_line_command): Remove check of annotation_level.
8830 * source.h (identify_source_line): Move declaration to annotate.h
8831 and rename to annotate_source_line.
8832 * stack.c: Add 'annotate.h' include.
8833 (print_frame_info): Remove check of annotation_level before
8834 calling annotate_source_line.
8835
8836 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8837
8838 * source-cache.c (source_cache::get_plain_source_lines): Use
8839 open_source_file_with_line_charpos instead of just
8840 open_source_file, remove call to find_source_lines.
8841 (source_cache::get_source_lines): Likewise.
8842 * source.c (find_source_lines): Make static.
8843 (get_filename_and_charpos): Renamed into...
8844 (open_source_file_with_line_charpos): ..this along with changes to
8845 return a scoped_fd, and some other minor clean ups.
8846 (identify_source_line): Use open_source_file_with_line_charpos.
8847 (search_command_helper): Use open_source_file_with_line_charpos
8848 instead of just open_source_file, remove call to
8849 find_source_lines.
8850 * source.h (open_source_file_with_line_charpos): Declare new
8851 function.
8852 (find_source_lines): Delete declaration.
8853
8854 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8855
8856 * source.c (get_filename_and_charpos): Remove fullname
8857 parameter.
8858 (identify_source_line): Update call to get_filename_and_charpos.
8859
8860 2019-06-14 Tom Tromey <tromey@adacore.com>
8861
8862 PR gdb/24502:
8863 * ui-style.h (skip_ansi_escape): Update comment.
8864 * ui-file.h (class no_terminal_escape_file): New class.
8865 * ui-file.c (no_terminal_escape_file::write)
8866 (no_terminal_escape_file::puts): New methods.
8867 * cli/cli-logging.c (handle_redirections): Use
8868 no_terminal_escape_file.
8869
8870 2019-06-14 Tom Tromey <tromey@adacore.com>
8871
8872 * NEWS: Move convenience variable news above Python news.
8873
8874 2019-06-14 Tom Tromey <tom@tromey.com>
8875
8876 * gnulib: Move directory to top-level.
8877 * configure.ac: Don't configure gnulib.
8878 * configure: Rebuild.
8879 * common/common-defs.h: Use new path to gnulib.
8880 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8881 (GNULIB_H): Remove.
8882 (INCGNU): Look in new gnulib location.
8883 (HFILES_NO_SRCDIR): Remove gnulib files.
8884 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8885 (generated_files): Remove GNULIB_H.
8886 ($(LIBGNU), all-lib): Remove targets.
8887 (distclean): Don't mention GNULIB_BUILDDIR.
8888 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8889
8890 2019-06-14 Tom Tromey <tromey@adacore.com>
8891
8892 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8893 Warn if symbol file does not provide any symbols.
8894
8895 2019-06-14 Tom Tromey <tromey@adacore.com>
8896
8897 * source.c (find_and_open_source): Respect basenames_may_differ.
8898
8899 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8900
8901 * annotate.c (annotate_breakpoints_invalid): Make use of
8902 scoped_restore_terminal_state.
8903 (annotate_frames_invalid): Likewise.
8904
8905 2019-06-14 Tom Tromey <tromey@adacore.com>
8906
8907 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8908 allow assignment to an internalvar.
8909
8910 2019-06-14 Tom Tromey <tromey@adacore.com>
8911
8912 * ada-lex.l: Allow "_" in attribute names.
8913
8914 2019-06-14 Tom Tromey <tromey@adacore.com>
8915
8916 PR gdb/24653:
8917 * regcache.c (registers_changed): Don't call alloca.
8918 * top.c (execute_command): Don't call alloca.
8919
8920 2019-06-13 Pedro Alves <palves@redhat.com>
8921
8922 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8923 'expression'. When parsing an expression, error out if there's
8924 junk after "unlimited".
8925 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8926 (do_set_command): Adjust calls to is_unlimited_literal.
8927
8928 2019-06-13 Pedro Alves <palves@redhat.com>
8929
8930 * compile/compile.c (make_compile_options_def_group): Add braces
8931 around array_view initializer.
8932 * thread.c (make_thread_apply_all_options_def_group)
8933 (make_thread_apply_all_options_def_group): Likewise.
8934
8935 2019-06-13 Pedro Alves <palves@redhat.com>
8936
8937 * NEWS (New commands): Mention "maint test-options
8938 require-delimiter", "maint test-options unknown-is-error", "maint
8939 test-options unknown-is-operand" and "maint show
8940 test-options-completion-result".
8941 (New command options, command completion): New section.
8942 (Completion improvements): New section.
8943 Mention that you can abbreviate "unlimited".
8944
8945 2019-06-13 Pedro Alves <palves@redhat.com>
8946
8947 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8948 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8949 * unittests/cli-utils-selftests.c (test_parse_flags)
8950 (test_parse_flags_qcs): Delete.
8951 (test_cli_utils): Don't call deleted functions.
8952
8953 2019-06-13 Pedro Alves <palves@redhat.com>
8954
8955 * thread.c: Include "cli/cli-option.h".
8956 (tp_array_compar_ascending): Global.
8957 (tp_array_compar): Delete function.
8958 (tp_array_compar_ascending, tp_array_compar_descending): New
8959 functions.
8960 (ascending_option_def, qcs_flag_option_def)
8961 (thr_qcs_flags_option_defs)
8962 (make_thread_apply_all_options_def_group)
8963 (make_thread_apply_options_def_group): New.
8964 (thread_apply_all_command): Use gdb::option::process_options.
8965 (thread_apply_command_completer)
8966 (thread_apply_all_command_completer): New.
8967 (thread_apply_command): Use gdb::option::process_options.
8968 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8969 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8970 to generate help text of "thread apply". Adjust "taas"'s help.
8971 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8972 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8973
8974 2019-06-13 Pedro Alves <palves@redhat.com>
8975
8976 * thread.c (thread_apply_command): Check for invalid TID with
8977 isdigit instead of !isalpha.
8978
8979 2019-06-13 Pedro Alves <palves@redhat.com>
8980
8981 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8982 (validate_flags_qcs): New.
8983 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8984 (validate_flags_qcs): Declare.
8985 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8986 (make_frame_apply_options_def_group): New.
8987 (frame_apply_command_count): Process options with
8988 gdb::option::process_options.
8989 (frame_apply_completer): New.
8990 (frame_apply_level_completer, frame_apply_all_completer)
8991 (frame_apply_completer): New.
8992 (_initialize_stack): Update help of "frame apply", "frame apply
8993 level", "frame apply all" and "faas" to mention supported options
8994 and install command completers.
8995 * stack.h (frame_apply_all_completer): Declare.
8996 * thread.c: Include "stack.h".
8997 (tfaas_command): Add "--".
8998 (_initialize_thread): Update help "tfaas" to mention supported
8999 options and install command completer.
9000
9001 2019-06-13 Pedro Alves <palves@redhat.com>
9002
9003 * completer.c (complete_nested_command_line): New.
9004 (gdb_completion_word_break_characters_throw): Add assertion.
9005 * completer.h (complete_nested_command_line): Declare.
9006
9007 2019-06-13 Pedro Alves <palves@redhat.com>
9008
9009 * stack.c (parse_backtrace_qualifiers): New.
9010 (backtrace_command): Use it.
9011 (backtrace_command_completer): Complete on qualifiers.
9012
9013 2019-06-13 Pedro Alves <palves@redhat.com>
9014
9015 * frame.c: Include "cli/cli-option.h.
9016 (user_set_backtrace_options): New.
9017 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9018 Delete.
9019 (get_prev_frame): Adjust.
9020 (boolean_option_def, uinteger_option_def)
9021 (set_backtrace_option_defs): New.
9022 (_initialize_frame): Adjust and use
9023 gdb::option::add_setshow_cmds_for_options to install "set
9024 backtrace past-main" and "set backtrace past-entry".
9025 * frame.h: Include "cli/cli-option.h".
9026 (struct frame_print_options): Forward declare.
9027 (print_frame_arguments_all, print_frame_arguments_scalars)
9028 (print_frame_arguments_none): Declare.
9029 (print_entry_values): Delete declaration.
9030 (struct frame_print_options, user_frame_print_options): New.
9031 (struct set_backtrace_options): New.
9032 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9033 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9034 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9035 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9036 (list_args_or_locals): Add frame_print_options parameter.
9037 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9038 * python/py-framefilter.c (enumerate_args): Pass down
9039 USER_FRAME_PRINT_OPTIONS.
9040 * stack.c: Include "cli/cli-option.h".
9041 (print_frame_arguments_all, print_frame_arguments_scalars)
9042 (print_frame_arguments_none): Declare.
9043 (print_raw_frame_arguments, print_entry_values): Delete.
9044 (user_frame_print_options): New.
9045 (boolean_option_def, enum_option_def, frame_print_option_defs):
9046 New.
9047 (struct backtrace_cmd_options): New.
9048 (bt_flag_option_def): New.
9049 (backtrace_command_option_defs): New.
9050 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9051 (print_frame_arg, read_frame_arg, print_frame_args)
9052 (print_frame_info, print_frame): Add frame_print_options parameter
9053 and use it.
9054 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9055 (backtrace_command_1): Add frame_print_options and
9056 backtrace_cmd_options parameters and use them.
9057 (make_backtrace_options_def_group): New.
9058 (backtrace_command): Process command options with
9059 gdb::option::process_options.
9060 (backtrace_command_completer): New.
9061 (_initialize_stack): Extend "backtrace"'s help to mention
9062 supported options. Install completer for "backtrace".
9063 Install some settings commands with add_setshow_cmds_for_options.
9064
9065 2019-06-13 Pedro Alves <palves@redhat.com>
9066
9067 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9068 and that "set/show print raw frame-arguments" are now deprecated.
9069
9070 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9071 command.
9072 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9073 * stack.c (_initialize_stack): Install "set/show print
9074 raw-frame-arguments", and deprecate "set/show print raw
9075 frame-arguments".
9076 * valprint.c (_initialize_valprint): Deprecate "set/show print
9077 raw".
9078
9079 2019-06-13 Pedro Alves <palves@redhat.com>
9080
9081 * compile/compile.c (struct compile_options): New.
9082 (compile_flag_option_def, compile_command_option_defs)
9083 (make_compile_options_def_group): New.
9084 (compile_file_command): Handle options with
9085 gdb::option::process_options.
9086 (compile_file_command_completer): New function.
9087 (compile_code_command): Handle options with
9088 gdb::option::process_options.
9089 (compile_code_command_completer): New function.
9090 (_initialize_compiler): Install completers for "compile code" and
9091 "compile file". Mention available options in "compile code" and
9092 "compile code"'s help.
9093 * completer.c (advance_to_completion_word): New, factored out from
9094 ...
9095 (advance_to_expression_complete_word_point): ... this.
9096 (advance_to_filename_complete_word_point): New.
9097 * completer.h (advance_to_filename_complete_word_point): New
9098 declaration.
9099
9100 2019-06-13 Pedro Alves <palves@redhat.com>
9101
9102 * compile/compile.c: Include "cli/cli-option.h".
9103 (compile_print_value): Scope data pointer is now a
9104 value_print_options pointer; adjust.
9105 (compile_print_command): Process options. Scope data pointer is
9106 now a value_print_options pointer; adjust.
9107 (_initialize_compile): Update "compile print"'s help to include
9108 supported options. Install a completer for "compile print".
9109 * cp-valprint.c (show_vtblprint, show_objectprint)
9110 (show_static_field_print): Delete.
9111 (_initialize_cp_valprint): Don't install "set print
9112 static-members", "set print vtbl", "set print object" here.
9113 * printcmd.c: Include "cli/cli-option.h" and
9114 "common/gdb_optional.h".
9115 (print_command_parse_format): Rework to fill in a
9116 value_print_options instead of a format_data.
9117 (print_value): Change parameter type from format_data pointer to
9118 value_print_options reference. Adjust.
9119 (print_command_1): Process options. Adjust to pass down a
9120 value_print_options.
9121 (print_command_completer): New.
9122 (_initialize_printcmd): Install print_command_completer as
9123 handle_brkchars completer for the "print" command. Update
9124 "print"'s help to include supported options.
9125 * valprint.c: Include "cli/cli-option.h".
9126 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9127 here from cp-valprint.c.
9128 (boolean_option_def, uinteger_option_def)
9129 (value_print_option_defs, make_value_print_options_def_group):
9130 New. Use gdb::option::add_setshow_cmds_for_options to install
9131 "set print elements", "set print null-stop", "set print repeats",
9132 "set print pretty", "set print union", "set print array", "set
9133 print address", "set print symbol", "set print array-indexes".
9134 * valprint.h: Include <string> and "cli/cli-option.h".
9135 (make_value_print_options_def_group): Declare.
9136 (print_value): Change parameter type from format_data pointer to
9137 value_print_options reference.
9138 (print_command_completer): Declare.
9139
9140 2019-06-13 Pedro Alves <palves@redhat.com>
9141
9142 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9143 (COMMON_SFILES): Add maint-test-settings.c.
9144 * cli/cli-decode.c (boolean_enums): New global, factored out from
9145 ...
9146 (add_setshow_boolean_cmd): ... here.
9147 * cli/cli-decode.h (boolean_enums): Declare.
9148 * cli/cli-option.c: New file.
9149 * cli/cli-option.h: New file.
9150 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9151 factored out from ...
9152 (parse_cli_boolean_value(const char *)): ... this.
9153 (is_unlimited_literal): Change parameter type to pointer to
9154 pointer. Adjust and advance ARG pointer.
9155 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9156 (parse_cli_var_enum): New, factored out from ...
9157 (do_set_command): ... this. Adjust.
9158 * cli/cli-setshow.h (parse_cli_boolean_value)
9159 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9160 (parse_cli_var_enum): Declare.
9161 * cli/cli-utils.c: Include "cli/cli-option.h".
9162 (get_ulongest): New.
9163 * cli/cli-utils.h (get_ulongest): Declare.
9164 (check_for_argument): New overloads.
9165 * maint-test-options.c: New file.
9166
9167 2019-06-13 Pedro Alves <palves@redhat.com>
9168
9169 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9170 parse a range if "-" is at the end of the string.
9171
9172 2019-06-13 Pedro Alves <palves@redhat.com>
9173
9174 * cli/cli-setshow.c (parse_auto_binary_operation)
9175 (parse_cli_boolean_value): Don't allow "o".
9176
9177 2019-06-13 Pedro Alves <palves@redhat.com>
9178
9179 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9180 * NEWS: Mention maint test-settings KIND.
9181 * maint-test-settings.c: New file.
9182
9183 2019-06-13 Pedro Alves <palves@redhat.com>
9184
9185 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9186 completer.
9187 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9188 "set" completers.
9189
9190 2019-06-13 Pedro Alves <palves@redhat.com>
9191
9192 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9193 after item.
9194
9195 2019-06-13 Pedro Alves <palves@redhat.com>
9196
9197 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9198
9199 2019-06-13 Pedro Alves <palves@redhat.com>
9200
9201 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9202 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9203 call.
9204 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9205 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9206 calls.
9207 (check_for_argument): Skip spaces after argument.
9208
9209 2019-06-13 Pedro Alves <palves@redhat.com>
9210
9211 * thread.c (thread_apply_command): Adjust TID parsing.
9212 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9213 detected before end of string.
9214 (tid_is_in_list): Error out if LIST is invalid.
9215
9216 2019-06-13 Pedro Alves <palves@redhat.com>
9217
9218 * completer.c (complete_line_internal_1): Rewind completion word
9219 point.
9220 (completion_tracker::advance_custom_word_point_by): Change
9221 parameter type to int.
9222 * completer.h (completion_tracker::advance_custom_word_point_by):
9223 Likewise.
9224
9225 2019-06-13 Pedro Alves <palves@redhat.com>
9226
9227 * completer.c (advance_to_completion_word): Handle delimiters.
9228
9229 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9230
9231 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9232
9233 2019-06-11 Tom Tromey <tom@tromey.com>
9234
9235 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9236 (xmalloc_failed): Move to alloc.c.
9237 * alloc.c: New file.
9238 * Makefile.in (COMMON_SFILES): Add alloc.c.
9239
9240 2019-06-11 Tom Tromey <tom@tromey.com>
9241
9242 * nat/linux-waitpid.c: Don't include server.h.
9243 (linux_debug): Remove.
9244 (my_waitpid): Update.
9245
9246 2019-06-11 Tom Tromey <tromey@adacore.com>
9247
9248 * infcall.c (_initialize_infcall): Remove trailing newline from
9249 help.
9250 * user-regs.c (_initialize_user_regs): Remove trailing newline
9251 from help.
9252 * typeprint.c (_initialize_typeprint): Remove trailing newline
9253 from help.
9254 * reverse.c (_initialize_reverse): Remove trailing newlines from
9255 help.
9256 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9257 from help.
9258 * language.c (add_set_language_command): Remove trailing newline
9259 from help.
9260 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9261 help.
9262 * disasm.c (_initialize_disasm): Remove trailing newline from
9263 help.
9264 * top.c (init_main): Remove trailing newline from help.
9265 * interps.c (_initialize_interpreter): Remove trailing newline
9266 from help.
9267 * btrace.c (_initialize_btrace): Remove trailing newlines from
9268 help.
9269 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9270 from help.
9271 * python/python.c (_initialize_python): Remove trailing newline
9272 from help.
9273 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9274 help.
9275 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9276 from help. Reformat some text.
9277 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9278 from help.
9279 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9280 newline from help.
9281
9282 2019-06-11 Tom Tromey <tromey@adacore.com>
9283
9284 * darwin-nat.c (darwin_decode_exception_message)
9285 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9286
9287 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9288
9289 * valops.c (value_slice): Check for not allocated or not
9290 associated values.
9291
9292 2019-06-10 Tom de Vries <tdevries@suse.de>
9293
9294 PR gdb/24618
9295 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9296 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9297 invalid.
9298
9299 2019-06-10 Tom de Vries <tdevries@suse.de>
9300
9301 PR gdb/24611
9302 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9303 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9304
9305 2019-06-10 Tom de Vries <tdevries@suse.de>
9306
9307 PR symtab/24545
9308 * symtab.c (struct demangled_name_entry): Add language field.
9309 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9310 static minimal symbol". Set and use language field.
9311
9312 2019-06-10 Tom Tromey <tromey@adacore.com>
9313
9314 * ada-lang.c (_initialize_ada_language): Update help text.
9315
9316 2019-06-10 Tom Tromey <tromey@adacore.com>
9317
9318 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9319 with a newline.
9320 * guile/guile.c (handle_boot_error): Don't end warning with a
9321 newline.
9322 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9323 warning with a newline.
9324 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9325 newline.
9326 (s12z_frame_cache): Likewise.
9327 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9328 a newline.
9329 * solib-svr4.c (disable_probes_interface): Don't end warning with
9330 a newline.
9331 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9332 newline.
9333 * python/python.c (do_finish_initialization): Don't end warning
9334 with a newline.
9335
9336 2019-06-10 Tom Tromey <tom@tromey.com>
9337
9338 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9339 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9340 gdbpy_enter.
9341
9342 2019-06-10 Tom Tromey <tromey@adacore.com>
9343
9344 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9345 data.
9346 (elf_new_init): Don't call stabsread_new_init.
9347 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9348 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9349 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9350
9351 2019-06-10 Tom de Vries <tdevries@suse.de>
9352
9353 PR symtab/16264
9354 PR symtab/24517
9355 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9356
9357 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9358
9359 * source.c (find_and_open_source): Also rewrite relative file
9360 names.
9361
9362 2019-04-26 Amos Bird <amosbird@gmail.com>
9363
9364 * annotate.c (annotate_thread_exited): Add "thread-exited"
9365 annotation.
9366
9367 2019-06-06 Tom Tromey <tromey@adacore.com>
9368
9369 * maint.h (class scoped_command_stats): Use
9370 DISABLE_COPY_AND_ASSIGN.
9371 <print_time>: New method.
9372 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9373 print_time.
9374 (scoped_command_stats::print_time): New method.
9375
9376 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9377
9378 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9379 instructions of lengths 6 or 8 bytes.
9380
9381 2019-06-04 Pedro Alves <palves@redhat.com>
9382
9383 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9384
9385 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9386 * breakpoint.c (condition_completer): Likewise.
9387 * cli/cli-dump.c (scan_expression): Likewise.
9388 * common/filestuff.c (mkdir_recursive): Likewise.
9389 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9390 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9391 (gdb_abspath): Likewise.
9392 * compile/compile-cplus-types.c
9393 (compile_cplus_instance::decl_name): Likewise.
9394 * completer.c (complete_explicit_location):
9395 (signal_completer, reg_or_group_completer_1): Likewise.
9396 * cp-support.c (cp_remove_params_if_any): Likewise.
9397 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9398 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9399 * infcmd.c (strip_bg_char): Likewise.
9400 * linespec.c (copy_token_string): Likewise.
9401 * mi/mi-main.c (output_cores): Likewise.
9402 * psymtab.c (psymtab_search_name):
9403 * symfile.c (test_set_ext_lang_command): Likewise.
9404 * target.c (target_fileio_read_stralloc): Likewise.
9405 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9406 * value.c (complete_internalvar): Likewise.
9407
9408 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9409
9410 Add objfile property to gdb.Type.
9411 * NEWS: Mention Python API addition.
9412 * python/py-type.c (typy_get_objfile): New method.
9413
9414 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9415
9416 * NEWS: Mention the new set|show style [title|highlight].
9417 Mention changes to "show style", "help" and "apropos".
9418
9419 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9420
9421 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9422 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9423 instead of print_help_for_command.
9424 (print_doc_of_command): New function.
9425 (help_list): Add 'apropos -v word' suggestion.
9426 (print_help_for_command): Style the command name using title style.
9427 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9428 (_initialize_cli_cmds): Describe -v in apropos_command help.
9429
9430 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9431
9432 * cli/cli-style.h (cli_style_option): Add name in constructor,
9433 add m_name class member, add constructor with intensity,
9434 add name class function.
9435 (cli_style_option::add_setshow_commands): Remove name argument.
9436 (highlight_style, title_style): New styles.
9437 * cli/cli-style.c (do_show): New function that shows a style
9438 characteristic styling the style name with itself.
9439 (set_style_name): New function.
9440 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9441 Update all callers according to the changes in cli/cli-style.h.
9442 * utils.h (fputs_highlighted): New function.
9443 * utils.c (fputs_highlighted): Likewise.
9444
9445 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9446
9447 * NEWS: Mention new pipe command and new convenience variables.
9448
9449 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9450
9451 * cli/cli-cmds.c (pipe_command): New function.
9452 (_initialize_cli_cmds): Call add_com for pipe_command.
9453 Define | as an alias for pipe.
9454 (exit_status_set_internal_vars): New function.
9455 (shell_escape): Call exit_status_set_internal_vars.
9456 cli/cli-decode.c (find_command_name_length): Recognize | as
9457 a single character command.
9458
9459 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9460
9461 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9462 top.c (execute_command_to_ui_file): New function, mostly a copy
9463 of execute_command_to_string.
9464 (execute_command_to_string): Implement by calling
9465 execute_command_to_ui_file.
9466
9467 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9468
9469 * top.h (saved_command_line): Remove declaration.
9470 * top.c (previous_saved_command_line, previous_repeat_arguments):
9471 New variables.
9472 (saved_command_line): Make static, define together with other
9473 'repeat variables'.
9474 (dont_repeat): Clear repeat_arguments.
9475 (repeat_previous, get_saved_command_line, save_command_line):
9476 New functions.
9477 (gdb_init): Initialize saved_command_line
9478 and previous_saved_command_line.
9479 * main.c (captured_main_1): Remove saved_command_line initialization.
9480 * event-top.c (handle_line_of_input): Update to use
9481 the new 'repeat' related functions instead of direct access to
9482 saved_command_line.
9483 * command.h (repeat_previous, get_saved_command_line,
9484 save_command_line): New declarations.
9485 (dont_repeat): Add comment.
9486
9487 2019-05-30 Tom Tromey <tromey@adacore.com>
9488
9489 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9490 Fix comment.
9491 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9492
9493 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9494
9495 PR cli/24587
9496 * completer.c (complete): Initialize variable word.
9497
9498 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9499
9500 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9501 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9502 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9503 'body' is NULL to the outter 'if', protecting the '!is_define'
9504 situation as well.
9505
9506 2019-05-29 Tom Tromey <tromey@adacore.com>
9507
9508 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9509 (dwarf_unknown): New function.
9510 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9511 (dwarf_type_encoding_name): Use dwarf_unknown.
9512
9513 2019-05-29 Tom Tromey <tromey@adacore.com>
9514
9515 PR c++/20020:
9516 * cp-valprint.c (cp_print_value_fields): Call
9517 cp_print_static_field inside "try".
9518
9519 2019-05-29 Tom Tromey <tromey@adacore.com>
9520
9521 * inflow.c (struct terminal_info): Add default operator=.
9522 * configure: Rebuild.
9523 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9524 -Wdeprecated-copy-dtor, -Wredundant-move.
9525
9526 2019-05-29 Tom Tromey <tromey@adacore.com>
9527
9528 * NEWS: Add entry.
9529 * infcmd.c (print_return_value_1): Handle finish_print
9530 option.
9531 (show_print_finish): New function.
9532 (_initialize_infcmd): Add "set/show print finish" commands.
9533 * valprint.c (user_print_options): Initialize new member.
9534 * valprint.h (struct value_print_options) <finish_print>: New
9535 member.
9536
9537 2019-05-28 Tom Tromey <tromey@adacore.com>
9538
9539 * ada-lang.c (ada_remove_Xbn_suffix)
9540 (find_old_style_renaming_symbol)
9541 (parse_old_style_renaming): Remove.
9542 (ada_find_renaming_symbol): Don't call
9543 find_old_style_renaming_symbol.
9544 (ada_is_renaming_symbol): Rename from
9545 ada_find_renaming_symbol. Remove "block" parameter. Return
9546 bool. Now static.
9547 (ada_read_var_value): Update and simplify.
9548 * ada-exp.y (write_var_or_type): Remove old code.
9549
9550 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9551
9552 PR gdb/25010
9553 * event-top.c: Remove include comment.
9554 * inflow.c (class scoped_ignore_sigttou): Move from here...
9555 * inflow.h (class scoped_ignore_sigttou): ...to here.
9556 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9557 * top.c: Remove include comment.
9558
9559 2019-05-27 Tom Tromey <tom@tromey.com>
9560
9561 * NEWS: Fix typo.
9562
9563 2019-05-22 Tom Tromey <tromey@adacore.com>
9564
9565 * target.c (target_follow_exec): Constify parameter.
9566 * target-delegates.c: Rebuild.
9567 * remote.c (remote_target::follow_exec): Constify parameter.
9568 * infrun.c (follow_exec): Constify parameter.
9569 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9570 (target_follow_exec): Likewise.
9571
9572 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9573
9574 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9575 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9576
9577 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9578
9579 * NEWS: Add debugredirect and testsuite sections.
9580
9581 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9582
9583 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9584 target descriptions using exclusively floating point register name
9585 aliases.
9586
9587 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9588
9589 PR gdb/18644:
9590 * f-lang.c (build_fortran_types): Handle the case where
9591 gdbarch_floatformat_for_type returns a nullptr.
9592
9593 2019-05-21 Tom de Vries <tdevries@suse.de>
9594
9595 PR cli/24587
9596 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9597
9598 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9599
9600 PR gdb/18644:
9601 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9602 16-byte floats.
9603 * i386-tdep.c (i386_floatformat_for_type): Use
9604 floatformats_ia64_quad for the 16-byte floating point component
9605 within a fortran 32-byte complex number.
9606
9607 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9608
9609 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9610 delete default constructor.
9611 (find_partial_die): Update to return const struct.
9612 (partial_die_parent_scope): Move variable declaration into scope
9613 of its use and change its type to auto.
9614 (guess_partial_die_structure_name): Likewise.
9615 (partial_die_info::fixup): Likewise.
9616
9617 2019-05-17 Tom Tromey <tromey@adacore.com>
9618
9619 * source.c (find_and_open_source): Remove cast.
9620
9621 2019-05-17 Tom Tromey <tromey@adacore.com>
9622
9623 * annotate.c (annotate_source): Make "filename" const.
9624 * annotate.h (annotate_source): Use const.
9625
9626 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9627
9628 * disasm.c (set_disassembler_options): Send errors to stderr.
9629
9630 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9631
9632 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9633 (cli_interp_base::set_logging): Check debug_redirect.
9634 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9635 * cli/cli-logging.c (debug_redirect): Add static variable.
9636 (pop_output_files): Add default param.
9637 (handle_redirections): Print debug setting.
9638 (show_logging_command): Likewise.
9639 (_initialize_cli_logging): Add debugredirect command.
9640 * interps.c (current_interp_set_logging): Add debug_redirect
9641 parameter.
9642 * interps.h (set_logging): Add debug_redirect parameter.
9643 (current_interp_set_logging): Likewise.
9644 * mi/mi-common.h: Likewise.
9645 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9646
9647 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9648 Tom Tromey <tromey@adacore.com>
9649
9650 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9651 directly.
9652 * cli/cli-interp.h (make_logging_output): Remove declaration.
9653 * cli/cli-logging.c (make_logging_output): Remove function.
9654 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9655 directly.
9656 * ui-file.c (tee_file::tee_file): Remove bools.
9657 (tee_file::~tee_file): Remove deletes.
9658 * ui-file.h (tee_file): Remove bools.
9659
9660 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9661
9662 * mi/mi-cmds.h (mi_cmd_complete): New function.
9663 * mi/mi-main.c (mi_cmd_complete): Likewise.
9664 * mi/mi-cmds.c: Define new MI command -complete.
9665 * NEWS: Mention new -complete command.
9666
9667 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9668
9669 * completer.h (complete): New function.
9670 * completer.c (complete): Likewise.
9671 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9672 function defined in completer.h.
9673
9674 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9675
9676 * MAINTAINERS (Write After Approval): Add myself.
9677
9678 2019-05-17 Tom de Vries <tdevries@suse.de>
9679
9680 PR gdb/24094
9681 * dwarf2read.c (struct cu_partial_die_info): New struct.
9682 (find_partial_die): Return cu_partial_die_info.
9683 (partial_die_parent_scope, guess_partial_die_structure_name)
9684 (partial_die_info::fixup): Handle new return type of find_partial_die.
9685
9686 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9687
9688 PR breakpoints/24541
9689 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9690 "std::string", simplifying the algorithm.
9691
9692 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9693
9694 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9695 (stap_static_probe_ops::get_probes): Likewise.
9696
9697 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9698
9699 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9700 '-')" and "else if".
9701 (stap_parse_single_operand): Join checks for
9702 "gdbarch_stap_parse_special_token_p" and
9703 "gdbarch_stap_parse_special_token" in the same "if" statement.
9704 Invert check when verifying for operation on register
9705 displacement.
9706
9707 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9708
9709 * stap-probe.c (stap_get_opcode): Update comment.
9710 (stap_get_expected_argument_type): Likewise.
9711 (handle_stap_probe): Likewise.
9712
9713 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9714
9715 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9716 return type to 'bool'. Adjust comment. Use 'bool' when
9717 appropriate.
9718 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9719 * stap-probe.c (stap_parse_argument_1): Likewise.
9720 (stap_is_operator): Likewise.
9721 (stap_is_generic_prefix): Likewise.
9722 (stap_is_register_prefix): Likewise.
9723 (stap_is_register_indirection_prefix): Likewise.
9724 (stap_is_integer_prefix): Likewise.
9725 (stap_generic_check_suffix): Likewise.
9726 (stap_check_integer_suffix): Likewise.
9727 (stap_check_register_suffix): Likewise.
9728 (stap_check_register_indirection_suffix): Likewise.
9729 (stap_parse_register_operand): Likewise.
9730 (stap_parse_single_operand): Likewise.
9731 (stap_parse_argument_1): Likewise.
9732 (stap_probe::get_argument_count): Likewise.
9733 (stap_is_operator): Likewise.
9734
9735 2019-05-16 Tom Tromey <tromey@adacore.com>
9736
9737 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9738 keyword to foreach.
9739
9740 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9741
9742 * linux-thread-db.c (try_thread_db_load_1): Change return type
9743 to bool.
9744 (try_thread_db_load): Likewise.
9745 (try_thread_db_load_from_pdir_1): Likewise.
9746 (try_thread_db_load_from_pdir): Likewise.
9747 (try_thread_db_load_from_sdir): Likewise.
9748 (try_thread_db_load_from_dir): Likewise.
9749 (thread_db_load_search): Likewise.
9750 (has_libpthread): Likewise.
9751 (thread_db_load): Likewise.
9752
9753 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9754
9755 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9756 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9757 NULL, and complain/return if that's the case.
9758
9759 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9760
9761 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9762 (advance, posn, abstract_read_memory): New functions.
9763 [struct mem_read_abstraction]: New struct.
9764 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9765
9766 2019-05-14 Tom Tromey <tromey@adacore.com>
9767
9768 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9769 value is not lval_memory.
9770
9771 2019-05-14 Tom Tromey <tromey@adacore.com>
9772
9773 * solib.c (info_sharedlibrary_command): Style the file name.
9774
9775 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9776
9777 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9778 (aarch64_vnv_type): Likewise.
9779 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9780 * common/tdesc.c: Likewise.
9781 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9782 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9783 * features/aarch64-fpu.xml: Add ieee half view.
9784 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9785 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9786 * gdbtypes.h (struct builtin_type): Likewise.
9787 (struct objfile_type): Likewise.
9788
9789 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9790
9791 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9792 typo.
9793 * location.h (string_to_event_location): Likewise.
9794
9795 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9796
9797 GDB 8.3 released.
9798
9799 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9800
9801 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9802 New variable declaration.
9803 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9804 New variable.
9805 (print_one_breakpoint): Use ui_out::test_flags and new global
9806 variable to compute use_fixed_output.
9807 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9808 Remove.
9809 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9810 (mi_multi_location_breakpoint_output_fixed): Remove.
9811 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9812 new variable.
9813 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9814 fix_multi_location_breakpoint_output flag if version >= 3.
9815 * ui-out.h (enum ui_out_flag)
9816 <fix_multi_location_breakpoint_output>: New enumerator.
9817
9818 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9819
9820 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9821
9822 2019-05-10 Tom Tromey <tromey@adacore.com>
9823
9824 * ada-lang.c (catch_ada_completer): New function.
9825 (_initialize_ada_language): Use it.
9826
9827 2019-05-10 Tom Tromey <tromey@adacore.com>
9828
9829 * thread.c (print_thread_info): Make "requested_threads" const.
9830 * gdbthread.h (print_thread_info): Make "requested_threads"
9831 const.
9832 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9833 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9834
9835 2019-05-08 Tom Tromey <tom@tromey.com>
9836
9837 * gdbtypes.c (objfile_type_data): Change type.
9838 (objfile_type, _initialize_gdbtypes): Update.
9839
9840 2019-05-08 Tom Tromey <tom@tromey.com>
9841
9842 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9843 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9844 (_initialize_dwarf2_frame): Update.
9845
9846 2019-05-08 Tom Tromey <tom@tromey.com>
9847
9848 * objc-lang.c (objc_objfile_data): Change type.
9849 (find_methods): Update.
9850 (_initialize_objc_lang): Remove.
9851
9852 2019-05-08 Tom Tromey <tom@tromey.com>
9853
9854 * stabsread.c (rs6000_builtin_type_data): Change type.
9855 (rs6000_builtin_type, _initialize_stabsread): Update.
9856
9857 2019-05-08 Tom Tromey <tom@tromey.com>
9858
9859 * mips-tdep.c (mips_pdr_data): Remove.
9860 (_initialize_mips_tdep): Update.
9861
9862 2019-05-08 Tom Tromey <tom@tromey.com>
9863
9864 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9865 (hppa_init_objfile_priv_data, read_unwind_info)
9866 (find_unwind_entry, _initialize_hppa_tdep): Update.
9867
9868 2019-05-08 Tom Tromey <tom@tromey.com>
9869
9870 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9871 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9872 on obstack.
9873 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9874
9875 2019-05-08 Tom Tromey <tom@tromey.com>
9876
9877 * mdebugread.c (basic_type_data): Change type.
9878 (basic_type, _initialize_mdebugread): Update.
9879
9880 2019-05-08 Tom Tromey <tom@tromey.com>
9881
9882 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9883
9884 2019-05-08 Tom Tromey <tom@tromey.com>
9885
9886 * nto-tdep.c (nto_inferior_data_reg): Change type.
9887 (nto_inferior_data): Update.
9888 (nto_inferior_data_cleanup, nto_new_inferior_data)
9889 (_initialize_nto_tdep): Remove.
9890 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9891
9892 2019-05-08 Tom Tromey <tom@tromey.com>
9893
9894 * ada-lang.c (struct ada_inferior_data): Add initializers.
9895 (ada_inferior_data): Change type.
9896 (ada_inferior_data_cleanup): Remove.
9897 (get_ada_inferior_data, ada_inferior_exit)
9898 (struct ada_pspace_data): Add initializers, destructor.
9899 (ada_pspace_data_handle): Change type.
9900 (get_ada_pspace_data): Update.
9901 (ada_pspace_data_cleanup): Remove.
9902
9903 2019-05-08 Tom Tromey <tom@tromey.com>
9904
9905 * coffread.c (struct coff_symfile_info): Add initializers.
9906 (coff_objfile_data_key): Move lower. Change type.
9907 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9908 Update.
9909 (coff_free_info): Remove.
9910
9911 2019-05-08 Tom Tromey <tom@tromey.com>
9912
9913 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9914 (fbsd_pspace_data_handle): Move lower. Change type.
9915 (get_fbsd_pspace_data): Update.
9916 (fbsd_pspace_data_cleanup): Remove.
9917 (_initialize_fbsd_tdep): Update.
9918
9919 2019-05-08 Tom Tromey <tom@tromey.com>
9920
9921 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9922 (get_ada_tasks_pspace_data): Update.
9923 (ada_tasks_pspace_data_cleanup): Remove.
9924 (_initialize_tasks): Update.
9925 (ada_tasks_inferior_data_handle): Change type.
9926 (get_ada_tasks_inferior_data): Update.
9927 (ada_tasks_inferior_data_cleanup): Remove.
9928 (struct ada_tasks_pspace_data): Add initializers.
9929
9930 2019-05-08 Tom Tromey <tom@tromey.com>
9931
9932 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9933 * symfile-debug.c (debug_sym_get_probes): Change type.
9934 * stap-probe.c (handle_stap_probe):
9935 (stap_static_probe_ops::get_probes): Change type.
9936 * probe.h (class static_probe_ops) <get_probes>: Change type.
9937 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9938 (parse_probes_in_pspace): Update.
9939 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9940 Update.
9941 (any_static_probe_ops::get_probes): Change type.
9942 * elfread.c (elfread_data): New typedef.
9943 (probe_key): Change type.
9944 (elf_get_probes): Likewise. Update.
9945 (probe_key_free): Remove.
9946 (_initialize_elfread): Update.
9947 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9948 Change type.
9949 (dtrace_process_dof_probe, dtrace_process_dof)
9950 (dtrace_static_probe_ops::get_probe): Change type.
9951
9952 2019-05-08 Tom Tromey <tom@tromey.com>
9953
9954 * xcoffread.c (struct xcoff_symfile_info): Rename from
9955 coff_symfile_info. Add initializers.
9956 (xcoff_objfile_data_key): Move lower. Change type.
9957 (XCOFF_DATA): Rewrite.
9958 (xcoff_free_info): Remove.
9959 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9960 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9961 (xcoff_initial_scan): Update.
9962
9963 2019-05-08 Tom Tromey <tom@tromey.com>
9964
9965 * solib-svr4.c (struct svr4_info): Add initializers and
9966 destructor.
9967 <probes_table>: Now an htab_up.
9968 (solib_svr4_pspace_data): Change type.
9969 (free_probes_table): Simplify.
9970 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9971 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9972 (probes_table_remove_objfile_probes, register_solib_event_probe)
9973 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9974 (_initialize_svr4_solib): Update.
9975
9976 2019-05-08 Tom Tromey <tom@tromey.com>
9977
9978 * remote.c (remote_pspace_data): Change type.
9979 (remote_pspace_data_cleanup): Remove.
9980 (get_remote_exec_file, set_pspace_remote_exec_file)
9981 (_initialize_remote): Update.
9982
9983 2019-05-08 Tom Tromey <tom@tromey.com>
9984
9985 * breakpoint.c (breakpoint_objfile_key): Change type.
9986 (get_breakpoint_objfile_data): Update.
9987 (free_breakpoint_objfile_data): Remove.
9988 (_initialize_breakpoint): Update.
9989
9990 2019-05-08 Tom Tromey <tom@tromey.com>
9991
9992 * linux-tdep.c (struct linux_info): Add initializers.
9993 (linux_inferior_data): Move. Change type.
9994 (invalidate_linux_cache_inf): Update.
9995 (linux_inferior_data_cleanup): Remove.
9996 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9997
9998 2019-05-08 Tom Tromey <tom@tromey.com>
9999
10000 * auxv.c (auxv_inferior_data): Move. Change type.
10001 (auxv_inferior_data_cleanup): Remove.
10002 (invalidate_auxv_cache_inf): Rewrite.
10003 (get_auxv_inferior_data, _initialize_auxv): Update.
10004
10005 2019-05-08 Tom Tromey <tom@tromey.com>
10006
10007 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10008 (symfile_debug_objfile_data_key): Change type.
10009 (symfile_debug_installed, debug_qf_has_symbols)
10010 (debug_qf_find_last_source_symtab)
10011 (debug_qf_forget_cached_source_info)
10012 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10013 (debug_qf_print_stats, debug_qf_dump)
10014 (debug_qf_expand_symtabs_for_function)
10015 (debug_qf_expand_all_symtabs)
10016 (debug_qf_expand_symtabs_with_fullname)
10017 (debug_qf_map_matching_symbols)
10018 (debug_qf_expand_symtabs_matching)
10019 (debug_qf_find_pc_sect_compunit_symtab)
10020 (debug_qf_map_symbol_filenames)
10021 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10022 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10023 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10024 (debug_sym_read_linetable, debug_sym_relocate): Update.
10025 (symfile_debug_free_objfile): Remove.
10026 (install_symfile_debug_logging, _initialize_symfile_debug):
10027 Update.
10028
10029 2019-05-08 Tom Tromey <tom@tromey.com>
10030
10031 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10032 allocate_on_obstack.
10033 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10034 (get_dwarf2_per_objfile): Update.
10035 (set_dwarf2_per_objfile): Remove.
10036 (dwarf2_has_info, dwarf2_get_section_info): Update.
10037 (dwarf2_free_objfile): Remove.
10038 (_initialize_dwarf2_read): Update.
10039
10040 2019-05-08 Tom Tromey <tom@tromey.com>
10041
10042 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10043 initializers.
10044 <unsupported_script_warning_printed,
10045 script_not_found_warning_printed>: Now bool.
10046 (auto_load_pspace_data): Change type.
10047 (~auto_load_pspace_info): Rename from
10048 auto_load_pspace_data_cleanup.
10049 (get_auto_load_pspace_data, init_loaded_scripts_info)
10050 (clear_section_scripts, maybe_print_unsupported_script_warning)
10051 (maybe_print_script_not_found_warning, _initialize_auto_load):
10052 Update.
10053
10054 2019-05-08 Tom Tromey <tom@tromey.com>
10055
10056 * objfiles.c (objfile_pspace_info): Add destructor and
10057 initializers.
10058 (objfiles_pspace_data): Change type.
10059 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10060 (get_objfile_pspace_data): Update.
10061 (objfiles_bfd_data): Change type.
10062 (get_objfile_bfd_data): Update.
10063 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10064
10065 2019-05-08 Tom Tromey <tom@tromey.com>
10066
10067 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10068 Change type.
10069 (get_catch_syscall_inferior_data): Update.
10070 (catch_syscall_inferior_data_cleanup): Remove.
10071 (_initialize_break_catch_syscall): Update.
10072
10073 2019-05-08 Tom Tromey <tom@tromey.com>
10074
10075 * inflow.c (struct terminal_info): Add destructor and
10076 initializers.
10077 (inflow_inferior_data): Change type.
10078 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10079 (get_inflow_inferior_data, inflow_inferior_exit)
10080 (swap_terminal_info, _initialize_inflow): Update.
10081
10082 2019-05-08 Tom Tromey <tom@tromey.com>
10083
10084 * target-dcache.c (target_dcache_cleanup): Remove.
10085 (target_dcache_aspace_key): Change type.
10086 (target_dcache_init_p, target_dcache_invalidate)
10087 (target_dcache_get, target_dcache_get_or_init)
10088 (_initialize_target_dcache): Update.
10089 * dcache.h (struct dcache_deleter): New.
10090
10091 2019-05-08 Tom Tromey <tom@tromey.com>
10092
10093 * symtab.c (struct symbol_cache): Add destructor and
10094 initializers.
10095 (symbol_cache_key): Move. Change type.
10096 (make_symbol_cache, free_symbol_cache): Remove.
10097 (get_symbol_cache): Update.
10098 (symbol_cache_cleanup): Remove.
10099 (ALL_PSPACES, symbol_cache_flush)
10100 (maintenance_print_symbol_cache)
10101 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10102 Update.
10103
10104 2019-05-08 Tom Tromey <tom@tromey.com>
10105
10106 * symtab.c (struct main_info): Add destructor and initializers.
10107 (main_progspace_key): Move. Change type.
10108 (get_main_info): Update.
10109 (main_info_cleanup): Remove.
10110 (_initialize_symtab): Update.
10111
10112 2019-05-08 Tom Tromey <tom@tromey.com>
10113
10114 * registry.h (DECLARE_REGISTRY): Define the _key class.
10115
10116 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10117
10118 * NEWS: Merge two 'New commands' sections.
10119
10120 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10121
10122 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10123 parameter and use Ada language definition instead.
10124 (ada_val_print_ptr): Remove unused language parameter.
10125 (ada_val_print_num): Remove language parameter and use Ada language
10126 definition instead.
10127 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10128 parameter.
10129 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10130 parameter and use Ada language definition instead.
10131 (ada_val_print_1): Update all ada_val_print_xxx calls.
10132 Remove language parameter.
10133 (ada_val_print): Update ada_val_print_1 call.
10134
10135 2019-05-08 Tom Tromey <tromey@adacore.com>
10136
10137 * remote.c (remote_hw_watchpoint_limit)
10138 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10139 Now static.
10140
10141 2019-05-08 Tom Tromey <tromey@adacore.com>
10142
10143 * maint.c (_initialize_maint_cmds): Move initialization code to
10144 remote.c.
10145 (watchdog, show_watchdog): Move to remote.c.
10146 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10147 "watchdog" static.
10148 (_initialize_remote): Move initialization code from maint.c.
10149 * defs.h (watchdog): Don't declare.
10150
10151 2019-05-08 Tom Tromey <tromey@adacore.com>
10152
10153 * tui/tui-interp.c: Include main.h.
10154 * interps.c: Include main.h.
10155 * main.h (interpreter_p): Declare.
10156 * defs.h (interpreter_p): Don't declare.
10157
10158 2019-05-08 Tom Tromey <tromey@adacore.com>
10159
10160 * dwarf2loc.c: Include dwarf2read.h.
10161 * defs.h (read_unsigned_leb128): Don't declare.
10162 * dwarf2read.h (read_unsigned_leb128): Declare.
10163
10164 2019-05-08 Tom Tromey <tromey@adacore.com>
10165
10166 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10167 method.
10168
10169 2019-05-08 Tom Tromey <tromey@adacore.com>
10170
10171 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10172 when no wrap column is set.
10173
10174 2019-05-08 Tom Tromey <tromey@adacore.com>
10175
10176 * c-lang.c (c_get_string): Handle non-C-style arrays.
10177
10178 2019-05-08 Tom Tromey <tromey@adacore.com>
10179
10180 * typeprint.c (print_offset_data::update): Print the bit offset,
10181 not the number of bits remaining.
10182
10183 2019-05-08 Tom Tromey <tromey@adacore.com>
10184
10185 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10186 padding at end of comment.
10187
10188 2019-05-08 Tom Tromey <tromey@adacore.com>
10189
10190 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10191 Compare main types.
10192
10193 2019-05-06 Tom Tromey <tom@tromey.com>
10194
10195 * common/scoped_mmap.c: Include common-defs.h.
10196 * common/scoped_mmap.h: Don't include config.h.
10197
10198 2019-05-04 Tom Tromey <tom@tromey.com>
10199
10200 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10201 (struct aarch64_call_info): Add initializers.
10202 <si>: Now a std::vector.
10203 (pass_on_stack, aarch64_push_dummy_call): Update.
10204
10205 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10206 Tom Tromey <tom@tromey.com>
10207
10208 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10209 (ppc_threads): Now a std::vector. Now static.
10210 (hwdebug_find_thread_points_by_tid)
10211 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10212 Update.
10213
10214 2019-05-04 Tom Tromey <tom@tromey.com>
10215
10216 * arc-tdep.c (arc_tdesc_init): Return bool.
10217
10218 2019-05-04 Tom Tromey <tom@tromey.com>
10219
10220 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10221 Use gdb_assert_not_reached.
10222
10223 2019-05-04 Tom Tromey <tom@tromey.com>
10224
10225 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10226 "false".
10227
10228 2019-05-04 Tom Tromey <tom@tromey.com>
10229
10230 * arc-tdep.c (arc_tdesc_init): Use bool.
10231
10232 2019-05-04 Tom Tromey <tom@tromey.com>
10233
10234 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10235
10236 2019-05-04 Tom Tromey <tom@tromey.com>
10237
10238 * cli/cli-cmds.c (valid_command_p): Return bool.
10239
10240 2019-05-04 Tom Tromey <tom@tromey.com>
10241
10242 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10243 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10244
10245 2019-05-04 Raul Tambre <raul@tambre.ee>
10246
10247 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10248 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10249 operator for comparison.
10250
10251 2019-05-04 Tom Tromey <tom@tromey.com>
10252
10253 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10254 (lookup_partial_symbol, print_partial_symbols)
10255 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10256 (psymbol_compare): Update.
10257 (add_psymbol_to_bcache): Clear the entire psymbol.
10258 (maintenance_check_psymtabs): Update.
10259 * psympriv.h (struct partial_symbol): Don't derive from
10260 general_symbol_info.
10261 <obj_section, unrelocated_address, address,
10262 set_unrelocated_address>: Update.
10263 <ginfo>: New member.
10264 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10265 (debug_names::write_psymbols): Update.
10266
10267 2019-05-04 Tom de Vries <tdevries@suse.de>
10268
10269 * contrib/cc-with-tweaks.sh: Support -n arg.
10270
10271 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10272
10273 * corelow.c (core_target::detach): Ensure frame cache and
10274 register caches are cleared.
10275 inferior.c (exit_inferior_1): Likewise.
10276
10277 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10278 Tom Tromey <tom@tromey.com>
10279
10280 * dictionary.c (collate_pending_symbols_by_language): Remove
10281 "struct" from foreach.
10282 * symtab.c (lookup_global_symbol_from_objfile)
10283 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10284 foreach.
10285 * ser-tcp.c (net_open): Remove "struct" from foreach.
10286 * objfiles.c (objfile_relocate, objfile_rebase)
10287 (objfile_has_symbols): Remove "struct" from foreach.
10288 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10289 from foreach.
10290 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10291 foreach.
10292 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10293 "struct" from foreach.
10294 * ada-lang.c (create_excep_cond_exprs)
10295 (ada_exception_catchpoint_cond_string): Remove "struct" from
10296 foreach.
10297
10298 2019-05-03 Tom Tromey <tromey@adacore.com>
10299
10300 * ada-exp.y (convert_char_literal): Check suffix of each
10301 enumerator.
10302
10303 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10304
10305 PR ada/21406:
10306 * ada-exp.y (yywrap): Don't define.
10307 * ada-lex.l (%option): Add noyywrap
10308 (yywrap): Remove.
10309
10310 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10311
10312 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10313 _WIN32_WINNT to the XP level, unless already defined to a higher
10314 level.
10315
10316 * unittests/parse-connection-spec-selftests.c:
10317 * ser-tcp.c:
10318 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10319 override.
10320
10321 * symfile.c (find_separate_debug_file): Remove colon from the
10322 drive spec of DOS/Windows file names of the target, so that the
10323 file name produced from DEBUGDIR and the target's directory will
10324 be valid on DOS/Windows systems.
10325
10326 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10327
10328 * rust-lang.c (val_print_struct): Handle printing structures
10329 containing strings.
10330
10331 2019-05-02 Tom Tromey <tromey@adacore.com>
10332
10333 * valarith.c (_initialize_valarith): Remove.
10334
10335 2019-05-01 Tom Tromey <tromey@adacore.com>
10336
10337 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10338 bitfields.
10339
10340 2019-05-01 Tom Tromey <tromey@adacore.com>
10341
10342 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10343 for big-endian copies.
10344
10345 2019-04-30 Ali Tamur <tamur@google.com>
10346 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10347 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10348 (read_3_bytes): New function.
10349
10350 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10351
10352 * windows-nat.c (main_thread_id): Delete.
10353 (handle_output_debug_string): Replace main_thread_id by
10354 current_event.dwThreadId.
10355 (fake_create_process): Likewise.
10356 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10357 Do not set main_thread_id.
10358 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10359 current_event.dwThreadId.
10360 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10361
10362 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10363
10364 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10365 Use current_event.dwThreadId instead of main_thread_id.
10366
10367 2019-04-30 Tom Tromey <tromey@adacore.com>
10368
10369 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10370 (create_excep_cond_exprs): Iterate over program spaces.
10371 (ada_exception_catchpoint_cond_string): Examine all minimal
10372 symbols for exception types.
10373
10374 2019-04-30 Tom Tromey <tromey@adacore.com>
10375
10376 PR c++/24470:
10377 * dwarf2read.c (process_structure_scope): Handle case where type
10378 has template parameters but no symbol was created.
10379
10380 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10381 Chris January <chris.january@arm.com>
10382
10383 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10384 qualifier.
10385 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10386
10387 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10388
10389 * f-typeprint.c (f_print_type): Update rules for printing
10390 whitespace.
10391 (f_type_print_varspec_suffix): Likewise.
10392
10393 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10394 Chris January <chris.january@arm.com>
10395
10396 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10397 function arguments.
10398
10399 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10400
10401 * f-lang.c (build_fortran_types): Change name of void type to
10402 lower case.
10403 * f-typeprint.c (f_type_print_base): Print the name of the void
10404 type, rather than a fixed string.
10405 * f-valprint.c (f_decorations): Use lower case void string.
10406
10407 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10408 Chris January <chris.january@arm.com>
10409
10410 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10411 types for Fortran.
10412
10413 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10414 Chris January <chris.january@arm.com>
10415 David Lecomber <david.lecomber@arm.com>
10416
10417 * f-exp.y (BINOP_INTRINSIC): New token.
10418 (exp): New parser rule handling BINOP_INTRINSIC.
10419 (f77_keywords): Add new builtin procedures.
10420 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10421 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10422 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10423 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10424 (print_unop_subexp_f): New function.
10425 (print_binop_subexp_f): New function.
10426 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10427 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10428 (dump_subexp_body_f): Likewise.
10429 (operator_check_f): Likewise.
10430 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10431 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10432
10433 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10434
10435 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10436 UNOP_KIND.
10437 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10438 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10439 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10440 (operator_length_f): New fuction.
10441 (print_subexp_f): New function.
10442 (op_name_f): New function.
10443 (dump_subexp_body_f): New function.
10444 (operator_check_f): New function.
10445 (exp_descriptor_f): Replace standard expression handling functions
10446 with new functions.
10447 * gdb/fortran-operator.def: New file.
10448 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10449 * gdb/std-operator.def: Remove UNOP_KIND.
10450
10451 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10452
10453 * std-operator.def: Remove unbalanced, stray double quote
10454 character.
10455
10456 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10457 Chris January <chris.january@arm.com>
10458 Daniel Everett <daniel.everett@arm.com>
10459 Nick Forrington <nick.forrington@arm.com>
10460 Richard Bunt <richard.bunt@arm.com>
10461
10462 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10463 of depth when printing anonymous structs or unions.
10464 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10465 Don't print either the top-level value, or the children if the
10466 max-depth is exceeded.
10467 (ppscm_print_children): When printing the key of a map, allow one
10468 extra level of depth.
10469 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10470 print either the top-level value, or the children if the max-depth
10471 is exceeded.
10472 (print_children): When printing the key of a map, allow one extra
10473 level of depth.
10474 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10475 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10476 (user_print_options): Initialise max_depth field.
10477 (val_print_scalar_or_string_type_p): New function.
10478 (val_print): Check to see if the max depth has been reached.
10479 (val_print_check_max_depth): Define new function.
10480 (show_print_max_depth): New function.
10481 (_initialize_valprint): Add 'print max-depth' option.
10482 * valprint.h (struct value_print_options) <max_depth>: New field.
10483 (val_print_check_max_depth): Declare new function.
10484 * NEWS: Document new feature.
10485
10486 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10487
10488 * ada-lang.c (ada_language_defn): Initialise new field.
10489 * c-lang.c (c_is_string_type_p): New function.
10490 (c_language_defn): Initialise new field.
10491 (cplus_language_defn): Initialise new field.
10492 (asm_language_defn): Initialise new field.
10493 (minimal_language_defn): Initialise new field.
10494 * c-lang.h (c_is_string_type_p): Declare new function.
10495 * d-lang.c (d_language_defn): Initialise new field.
10496 * f-lang.c (f_is_string_type_p): New function.
10497 (f_language_defn): Initialise new field.
10498 * go-lang.c (go_is_string_type_p): New function.
10499 (go_language_defn): Initialise new field.
10500 * language.c (default_is_string_type_p): New function.
10501 (unknown_language_defn): Initialise new field.
10502 (auto_language_defn): Initialise new field.
10503 * language.h (struct language_defn) <la_is_string_type_p>: New
10504 member variable.
10505 (default_is_string_type_p): Declare new function.
10506 * m2-lang.c (m2_language_defn): Initialise new field.
10507 * objc-lang.c (objc_language_defn): Initialise new field.
10508 * opencl-lang.c (opencl_language_defn): Initialise new field.
10509 * p-lang.c (pascal_is_string_type_p): New function.
10510 (pascal_language_defn): Initialise new field.
10511 * rust-lang.c (rust_is_string_type_p): New function.
10512 (rust_language_defn): Initialise new field.
10513
10514 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10515
10516 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10517 New field.
10518 * ada-lang.c (ada_language_defn): Initialise new field.
10519 * c-lang.c (c_language_defn): Likewise.
10520 (cplus_language_defn): Likewise.
10521 (asm_language_defn): Likewise.
10522 (minimal_language_defn): Likewise.
10523 * d-lang.c (d_language_defn): Likewise.
10524 * f-lang.c (f_language_defn): Likewise.
10525 * go-lang.c (go_language_defn): Likewise.
10526 * language.c (unknown_language_defn): Likewise.
10527 (auto_language_defn): Likewise.
10528 * m2-lang.c (m2_language_defn): Likewise.
10529 * objc-lang.c (objc_language_defn): Likewise.
10530 * opencl-lang.c (opencl_language_defn): Likewise.
10531 * p-lang.c (pascal_language_defn): Likewise.
10532 * rust-lang.c (rust_language_defn): Likewise.
10533
10534 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10535
10536 * ada-lang.c (ada_is_character_type): Change return type to bool.
10537 (ada_is_string_type): Likewise.
10538 * ada-lang.h (ada_is_character_type): Update declaration
10539 (ada_is_string_type): Likewise.
10540
10541 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10542
10543 Support style in 'frame|thread apply'
10544
10545 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10546 * record.c (record_start, record_stop): Update callers of
10547 execute_command_to_string with false.
10548 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10549 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10550 methods.
10551 (class string_file): New constructor with term_out parameter.
10552 Override methods term_out and can_emit_style_escape. New member
10553 term_out.
10554 (class stdio_file): Override can_emit_style_escape.
10555 (class tee_file): Override term_out and can_emit_style_escape.
10556 * utils.h (can_emit_style_escape): Remove.
10557 * utils.c (can_emit_style_escape): Likewise.
10558 Update all callers of can_emit_style_escape (SOMESTREAM) to
10559 SOMESTREAM->can_emit_style_escape.
10560 * source-cache.c (source_cache::get_source_lines): Likewise.
10561 * stack.c (frame_apply_command_count): Call execute_command_to_string
10562 passing the term_out characteristic of the current gdb_stdout.
10563 * thread.c (thr_try_catch_cmd): Likewise.
10564 * top.c (execute_command_to_string): pass term_out parameter
10565 to construct the string_file for the command output.
10566 * ui-file.c (term_cli_styling): New function (most code moved
10567 from utils.c can_emit_style_escape).
10568 (string_file::string_file, string_file::can_emit_style_escape,
10569 stdio_file::can_emit_style_escape, tee_file::term_out,
10570 tee_file::can_emit_style_escape): New functions.
10571
10572 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10573
10574 * NEWS: Mention the new set|show may-call-functions.
10575 * infcall.c (may_call_functions_p): New variable.
10576 (show_may_call_functions_p): New function.
10577 (call_function_by_hand_dummy): Throws an error if not
10578 may-call-functions.
10579 (_initialize_infcall): Call add_setshow_boolean_cmd for
10580 may-call-functions.
10581
10582 2019-04-25 Keith Seitz <keiths@redhat.com>
10583
10584 PR c++/24367
10585 * cp-support.c (inspect_type): Don't attempt substitutions
10586 of symbol with the same name.
10587
10588 2019-04-25 Tom Tromey <tromey@adacore.com>
10589
10590 PR gdb/24475:
10591 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10592 static.
10593
10594 2019-04-25 Tom Tromey <tromey@adacore.com>
10595
10596 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10597 rvalue reference.
10598 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10599 (gdb_xml_parser::parse): Use std::move.
10600 * python/python-internal.h (gdbpy_convert_exception): Take a const
10601 reference.
10602 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10603 std::move.
10604 * python/py-utils.c (gdbpy_convert_exception): Take a const
10605 reference.
10606 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10607 Use std::move.
10608 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10609 Use std::move.
10610 * mi/mi-main.c (mi_print_exception): Take a const reference.
10611 * main.c (handle_command_errors): Take a const reference.
10612 * linespec.c (parse_linespec): Use std::move.
10613 * infcall.c (run_inferior_call): Use std::move.
10614 (call_function_by_hand_dummy): Use std::move.
10615 * exec.c (try_open_exec_file): Use std::move.
10616 * exceptions.h (exception_print, exception_fprintf)
10617 (exception_print_same): Update.
10618 * exceptions.c (print_exception, exception_print)
10619 (exception_fprintf, exception_print_same): Change parameters to
10620 const reference.
10621 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10622 * common/new-op.c: Use std::move.
10623 * common/common-exceptions.h (struct gdb_exception): Add move
10624 constructor.
10625 (struct gdb_exception_error, struct gdb_exception_quit, struct
10626 gdb_quit_bad_alloc): Change constructor to move constructor.
10627 (throw_exception): Change parameter to rvalue reference.
10628 * common/common-exceptions.c (throw_exception): Take rvalue
10629 reference.
10630 * cli/cli-interp.c (safe_execute_command): Use std::move.
10631 * breakpoint.c (insert_bp_location, location_to_sals): Use
10632 std::move.
10633
10634 2019-04-25 Tom Tromey <tromey@adacore.com>
10635
10636 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10637 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10638 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10639 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10640 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10641 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10642 guile/scm-value.c: Use unpack.
10643 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10644 gdbscm_gdb_exception.
10645 (gdbscm_throw_gdb_exception): Likewise.
10646 (struct gdbscm_gdb_exception): New.
10647 (unpack): New function.
10648 (gdbscm_wrap): Use unpack.
10649
10650 2019-04-25 Tom Tromey <tromey@adacore.com>
10651
10652 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10653 (gdb_rl_callback_handler): Use std::move.
10654 * common/common-exceptions.h (struct gdb_exception): Add move
10655 assignment operator.
10656 (throw_exception_sjlj): Change "exception" to const reference.
10657 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10658 (throw_exception_sjlj): Change "exception" to const reference.
10659
10660 2019-04-25 Tom Tromey <tromey@adacore.com>
10661
10662 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10663 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10664 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10665 Update.
10666 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10667 Update.
10668 * mi/mi-interp.c (mi_interp::exec): Update.
10669 * linespec.c (parse_linespec): Update.
10670 * infcall.c (run_inferior_call): Update.
10671 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10672 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10673 (gdbscm_lookup_global_symbol): Update.
10674 * guile/scm-param.c (gdbscm_parameter_value): Update.
10675 * guile/scm-frame.c (gdbscm_frame_read_register)
10676 (gdbscm_frame_read_var): Update.
10677 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10678 * exec.c (try_open_exec_file): Update.
10679 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10680 (gdb_rl_callback_handler): Update.
10681 * common/common-exceptions.h (exception_none): Don't declare.
10682 * common/common-exceptions.c (exception_none): Don't define.
10683 (struct catcher) <exception>: Update.
10684 * cli/cli-interp.c (safe_execute_command): Update.
10685 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10686
10687 2019-04-25 Ali Tamur <tamur@google.com>
10688
10689 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10690 (read_attribute_value): Likewise.
10691 (dwarf2_read_addr_index): Update comment.
10692 (read_str_index): Add DW_FORM_strx.
10693 (dwarf2_string_attr): Likewise.
10694 (dwarf2_const_value_attr): Likewise.
10695 (dump_die_shallow): Likewise.
10696 (dwarf2_fetch_constant_bytes): Likewise.
10697 (skip_form_bytes): Likewise.
10698 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10699
10700 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10701
10702 PR corefiles/11608
10703 PR corefiles/18187
10704 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10705 OFFSET. Verify if current mapping contains an ELF header.
10706 (linux_find_memory_regions_full): Adjust call to
10707 dump_mapping_p.
10708
10709 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10710 Kang Li <kanglictf@gmail.com>
10711
10712 PR gdb/21600
10713
10714 * dwarf2-frame.c (read_initial_length): Be consistent about using
10715 unsigned representation of length.
10716 (decode_frame_entry_1): Likewise. Check for wraparound of
10717 end pointer as well as buffer overflow.
10718
10719 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10720
10721 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10722 "vq".
10723
10724 2019-04-24 Tom Tromey <tromey@adacore.com>
10725
10726 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10727
10728 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10729
10730 * s12z-tdep.c (s12z_unwind_pc): Delete.
10731 (s12z_unwind_sp): Delete.
10732 (s12z_gdbarch_init): Don't register deleted functions with
10733 gdbarch.
10734
10735 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10736
10737 * rl78-tdep.c (rl78_unwind_sp): Delete.
10738 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10739
10740 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10741
10742 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10743 (xstormy16_unwind_pc): Delete.
10744 (xstormy16_dummy_id): Delete.
10745 (xstormy16_gdbarch_init): Don't register deleted functions with
10746 gdbarch.
10747
10748 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10749
10750 * vax-tdep.c (vax_unwind_pc): Delete.
10751 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10752
10753 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10754
10755 * v850-tdep.c (v850_unwind_sp): Delete.
10756 (v850_unwind_pc): Delete.
10757 (v850_dummy_id): Delete.
10758 (v850_gdbarch_init): Don't register deleted functions with
10759 gdbarch.
10760
10761 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10762
10763 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10764 (tilegx_unwind_pc): Delete.
10765 (tilegx_unwind_dummy_id): Delete.
10766 (tilegx_gdbarch_init): Don't register deleted functions with
10767 gdbarch.
10768
10769 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10770
10771 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10772 (tic6x_dummy_id): Delete.
10773 (tic6x_gdbarch_init): Don't register deleted functions with
10774 gdbarch.
10775
10776 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10777
10778 * sparc-tdep.c (sparc_unwind_pc): Delete.
10779 (sparc32_gdbarch_init): Don't register deleted function with
10780 gdbarch.
10781
10782 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10783
10784 * sh-tdep.c (sh_unwind_sp): Delete.
10785 (sh_unwind_pc): Delete.
10786 (sh_dummy_id): Delete.
10787 (sh_gdbarch_init): Don't register deleted functions with
10788 gdbarch.
10789
10790 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10791
10792 * score-tdep.c (score_unwind_sp): Delete.
10793 (score_unwind_pc): Delete.
10794 (score_dummy_id): Delete.
10795 (score_gdbarch_init): Don't register deleted functions with
10796 gdbarch.
10797
10798 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10799
10800 * rx-tdep.c (rx_unwind_pc): Delete.
10801 (rx_unwind_sp): Delete.
10802 (rx_dummy_id): Delete.
10803 (rx_gdbarch_init): Don't register deleted functions with
10804 gdbarch. Update comment.
10805
10806 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10807
10808 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10809 (rs6000_dummy_id): Delete.
10810 (rs6000_gdbarch_init): Don't register deleted functions with
10811 gdbarch.
10812
10813 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10814
10815 * or1k-tdep.c (or1k_dummy_id): Delete.
10816 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10817
10818 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10819
10820 * nios2-tdep.c (nios2_dummy_id): Delete.
10821 (nios2_unwind_sp): Delete.
10822 (nios2_gdbarch_init): Don't register deleted functions with
10823 gdbarch.
10824
10825 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10826
10827 * nds32-tdep.c (nds32_dummy_id): Delete.
10828 (nds32_unwind_pc): Delete.
10829 (nds32_unwind_sp): Delete.
10830 (nds32_gdbarch_init): Don't register deleted functions with
10831 gdbarch.
10832
10833 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10834
10835 * msp430-tdep.c (msp430_unwind_pc): Delete.
10836 (msp430_unwind_sp): Delete.
10837 (msp430_dummy_id): Delete.
10838 (msp430_gdbarch_init): Don't register deleted functions with
10839 gdbarch.
10840
10841 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10842
10843 * moxie-tdep.c (moxie_unwind_sp): Delete.
10844 (moxie_unwind_pc): Delete.
10845 (moxie_dummy_id): Delete.
10846 (moxie_gdbarch_init): Don't register deleted functions with
10847 gdbarch.
10848
10849 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10850
10851 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10852 (mn10300_unwind_pc): Delete.
10853 (mn10300_unwind_sp): Delete.
10854 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10855 mn10300_unwind_sp.
10856 (mn10300_frame_unwind_init): Don't register deleted functions with
10857 gdbarch.
10858
10859 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10860
10861 * mep-tdep.c (mep_unwind_pc): Delete.
10862 (mep_unwind_sp): Delete.
10863 (mep_dummy_id): Delete.
10864 (mep_gdbarch_init): Don't register deleted functions with
10865 gdbarch.
10866
10867 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10868
10869 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10870 (m68hc11_unwind_sp): Delete.
10871 (m68hc11_gdbarch_init): Don't register deleted functions with
10872 gdbarch.
10873
10874 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10875
10876 * m32r-tdep.c (m32r_unwind_sp): Delete.
10877 (m32r_unwind_pc): Delete.
10878 (m32r_dummy_id): Delete.
10879 (m32r_gdbarch_init): Don't register deleted functions with
10880 gdbarch.
10881
10882 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10883
10884 * m32c-tdep.c (m32c_unwind_pc): Delete.
10885 (m32c_unwind_sp): Delete.
10886 (m32c_dummy_id): Delete.
10887 (m32c_gdbarch_init): Don't register deleted functions with
10888 gdbarch.
10889
10890 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10891
10892 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10893 (lm32_unwind_pc): Delete.
10894 (lm32_dummy_id): Delete.
10895 (lm32_gdbarch_init): Don't register deleted functions with
10896 gdbarch.
10897
10898 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10899
10900 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10901 (iq2000_unwind_pc): Delete.
10902 (iq2000_dummy_id): Delete.
10903 (iq2000_gdbarch_init): Don't register deleted functions with
10904 gdbarch.
10905
10906 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10907
10908 * nds32-tdep.c (nds32_type_align): Delete.
10909 (nds32_push_dummy_call): Use type_align instead.
10910
10911 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10912
10913 * arm-tdep.c (arm_type_align): Only handle vector override case.
10914 (arm_push_dummy_call): Use type_align.
10915 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10916
10917 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10918
10919 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10920 case.
10921 (pass_on_stack): Use type_align.
10922 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10923 function.
10924
10925 2019-04-23 Tom Tromey <tromey@adacore.com>
10926
10927 * dwarf2read.c (line_header::file_name_at): Remove unused
10928 overload.
10929
10930 2019-04-23 Tom de Vries <tdevries@suse.de>
10931
10932 PR gdb/24438
10933 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10934 invocation.
10935
10936
10937 2019-03-27 Ali Tamur <tamur@google.com>
10938
10939 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10940 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10941 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10942 (dwarf_expr_context::get_addr_index): Likewise
10943 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10944 (symbol_needs_eval_context::get_addr_index): Likewise
10945 (disassemble_dwarf_expression): Add DW_OP_addrx
10946 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10947 (read_cutu_die_from_dwo): Update comment
10948 (skip_one_die): Add DW_FORM_addrx
10949 (read_attribute_value): Likewise
10950 (var_decode_location): Add DW_OP_addrx
10951 (dwarf2_const_value_attr): Add DW_FORM_addrx
10952 (dump_die_shallow): Likewise
10953 (dwarf2_fetch_constant_bytes): Likewise
10954 (decode_locdesc): Add DW_OP_addrx
10955 (skip_form_bytes): Add DW_FORM_addrx
10956
10957 2019-04-22 Ali Tamur <tamur@google.com>
10958
10959 * MAINTAINERS (Write After Approval): Add self.
10960
10961 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10962
10963 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10964 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10965 (open_symbol_file_object): Likewise.
10966 (svr4_default_sos): Add info parameter.
10967 (svr4_read_so_list): Likewise.
10968 (svr4_current_sos_direct): Adjust functions calls to pass down
10969 info.
10970 (svr4_current_sos_1): Add info parameter.
10971 (svr4_current_sos): Call get_svr4_info, pass info down to
10972 svr4_current_sos_1.
10973 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10974 get_svr4_info.
10975 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10976 get_svr4_info.
10977 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10978 to get_svr4_info.
10979 (probes_table_remove_objfile_probes): Likewise.
10980 (register_solib_event_probe): Add info parameter.
10981 (solist_update_incremental): Pass info parameter down to
10982 svr4_read_so_list.
10983 (disable_probes_interface): Add info parameter.
10984 (svr4_handle_solib_event): Pass current_program_space to
10985 get_svr4_info. Adjust disable_probes_interface cleanup.
10986 (svr4_create_probe_breakpoints): Add info parameter, pass it
10987 down to register_solib_event_probe.
10988 (svr4_create_solib_event_breakpoints): Add info parameter,
10989 pass it down to svr4_create_probe_breakpoints.
10990 (enable_break): Pass info down to
10991 svr4_create_solib_event_breakpoints.
10992 (svr4_solib_create_inferior_hook): Pass current_program_space to
10993 get_svr4_info.
10994 (svr4_clear_solib): Likewise.
10995
10996 2019-04-22 Pedro Alves <palves@redhat.com>
10997
10998 * solib-svr4.c (svr4_free_objfile_observer): New.
10999 (probe_and_action::objfile): New field.
11000 (probes_table_htab_remove_objfile_probes)
11001 (probes_table_remove_objfile_probes): New functions.
11002 (register_solib_event_probe): Add 'objfile' parameter. Store it
11003 in the new probe_and_action. Don't store the probe in 'lookup'.
11004 (svr4_create_probe_breakpoints): Pass objfile to
11005 register_solib_event_probe.
11006 (_initialize_svr4_solib): Register a free_objfile observer.
11007
11008 2019-04-19 Tom Tromey <tom@tromey.com>
11009
11010 * common/queue.h: Remove.
11011
11012 2019-04-19 Tom Tromey <tom@tromey.com>
11013
11014 * event-loop.c: Don't include "common/queue.h".
11015
11016 2019-04-19 Tom Tromey <tom@tromey.com>
11017
11018 * remote.c (remote_target): Use delete.
11019 * remote-notif.h: Include <list>, not "common/queue.h".
11020 (notif_client_p): Remove typedef.
11021 (remote_notif_state): Add constructor, destructor, initializer.
11022 <notif_queue>: Now a std::list.
11023 (remote_notif_state_xfree): Don't declare.
11024 * remote-notif.c (remote_notif_process, handle_notification)
11025 (remote_notif_state_allocate): Update.
11026 (~remote_notif_state): Rename from remote_notif_state_xfree.
11027
11028 2019-04-19 Tom Tromey <tom@tromey.com>
11029
11030 * symfile.c (reread_symbols): Update.
11031 * objfiles.c (objfile_register_static_link)
11032 (objfile_lookup_static_link): Update
11033 (~objfile) Don't delete static_links.
11034 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11035
11036 2019-04-19 Tom Tromey <tom@tromey.com>
11037
11038 * type-stack.h (struct type_stack) <insert>: Constify string.
11039 * type-stack.c (type_stack::insert): Constify string.
11040 * gdbtypes.h (lookup_template_type): Update.
11041 (address_space_name_to_int): Update.
11042 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11043 const.
11044 (lookup_template_type): Make name const.
11045 * c-exp.y: Update rules.
11046 (lex_one_token, classify_name, classify_inner_name)
11047 (c_print_token): Update.
11048 * p-exp.y: Update rules.
11049 (yylex): Update.
11050 * f-exp.y: Update rules.
11051 (yylex): Update.
11052 * d-exp.y: Update rules.
11053 (lex_one_token, classify_name, classify_inner_name): Update.
11054 * parse.c (write_dollar_variable, copy_name): Return std::string.
11055 * parser-defs.h (copy_name): Change return type.
11056 * m2-exp.y: Update rules.
11057 (yylex): Update.
11058 * go-exp.y (lex_one_token): Update.
11059 Update rules.
11060 (classify_unsafe_function, classify_packaged_name)
11061 (classify_name, yylex): Update.
11062
11063 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11064
11065 * configure.ac: add --enable-source-highlight switch.
11066 * configure: Regenerate.
11067 * top.c (print_gdb_version): plumb --enable-source-highlight
11068 status to "show configuration".
11069
11070 2019-04-19 Tom Tromey <tromey@adacore.com>
11071
11072 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11073 Check ADA_TYPE_P.
11074 (empty_record, ada_template_to_fixed_record_type_1)
11075 (template_to_static_fixed_type)
11076 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11077 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11078 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11079 macros.
11080
11081 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11082
11083 PR symtab/24423:
11084 * source.c (print_source_lines_base): Advance "iter" when a
11085 control character is seen.
11086
11087 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11088
11089 * inferior.h (struct infcall_suspend_state_deleter):
11090 Catch exception in destructor to avoid crash.
11091
11092 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11093
11094 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11095 close to the add_com "shell".
11096
11097 2019-04-18 Tom Tromey <tromey@adacore.com>
11098
11099 * process-stratum-target.h (class process_stratum_target)
11100 <stratum>: Add "final".
11101
11102 2019-04-17 Tom Tromey <tromey@adacore.com>
11103
11104 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11105 against nullptr before use.
11106
11107 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11108
11109 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11110
11111 2019-04-17 Jim Wilson <jimw@sifive.com>
11112 Andrew Burgess <andrew.burgess@embecosm.com>
11113
11114 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11115 code read might fail, assume 4-byte breakpoint in that case.
11116
11117 2019-04-15 Leszek Swirski <leszeks@google.com>
11118
11119 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11120 rather than a hand-rolled POD check when checking for forced MEMORY
11121 classification.
11122
11123 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11124
11125 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11126 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11127 function.
11128 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11129 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11130 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11131 declaration.
11132
11133 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11134
11135 * aarch64-linux-nat.c
11136 (aarch64_linux_nat_target::thread_architecture): Add override.
11137 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11138 each VQ.
11139
11140 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11141
11142 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11143
11144 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11145
11146 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11147 target types of size 96-bits, add some additional comments, and
11148 check that the builtin type we found was the correct size.
11149
11150 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11151
11152 * utils.c (prompt_for_continue): Don't restore the styling at the
11153 end, as applied_style has the wrong value. This fixes styling in
11154 long lists of file names that are interrupted by the "Continue?"
11155 prompt.
11156
11157 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11158
11159 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11160 * c-lang.c (c_language_defn): Likewise.
11161 (cplus_language_defn): Likewise.
11162 (asm_language_defn): Likewise.
11163 (minimal_language_defn): Likewise.
11164 * d-lang.c (d_language_defn): Likewise.
11165 * f-lang.c (f_language_defn): Likewise.
11166 * go-lang.c (go_language_defn): Likewise.
11167 * language.c (unknown_language_defn): Likewise.
11168 (auto_language_defn): Likewise.
11169 * language.h (struct language_defn): Remove la_magic field.
11170 (LANG_MAGIC): Delete.
11171 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11172 * objc-lang.c (objc_language_defn): Likewise.
11173 * opencl-lang.c (opencl_language_defn): Likewise.
11174 * p-lang.c (pascal_language_defn): Likewise.
11175 * rust-lang.c (rust_language_defn): Likewise.
11176
11177 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11178
11179 * riscv-tdep.c (riscv_type_align): New function.
11180 (riscv_type_alignment): Delete.
11181 (riscv_arg_location): Use 'type_align'.
11182 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11183
11184 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11185
11186 * gdbtypes.c (type_align): A struct with no non-static fields also
11187 has alignment of 1.
11188
11189 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11190
11191 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11192 component to 0.
11193 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11194 member.
11195 (riscv_struct_info::analyse): New implementation using new
11196 analyse_inner member function.
11197 (riscv_struct_info::field_offset): New member function.
11198 (riscv_struct_info::m_offsets): New member variable.
11199 (riscv_struct_info::analyse_inner): New private member function,
11200 takes the old implementation of riscv_struct_info::analyse but
11201 extended to track field offsets.
11202 (riscv_call_arg_struct): Update the struct folding special cases
11203 to handle cases where empty C++ structs, which are non-zero
11204 length, are found.
11205 (riscv_arg_location): Initialise the length of each location, a
11206 non-zero length now indicates the location is in use.
11207 (riscv_push_dummy_call): Allow for the first location having a
11208 non-zero offset when setting up arguments.
11209 (riscv_return_value): Likewise, but for return values.
11210
11211 2019-04-11 Tom Tromey <tromey@adacore.com>
11212
11213 * utils.c (internal_vproblem): Make "msg" const.
11214
11215 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11216
11217 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11218 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11219 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11220 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11221
11222 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11223
11224 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11225 function.
11226 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11227 of amd64_collect_native_gregset.
11228 (amd64_linux_nat_target::store_registers): Likewise.
11229
11230 2019-04-10 Tom Tromey <tom@tromey.com>
11231
11232 * symtab.c (lookup_global_symbol_from_objfile)
11233 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11234 * objfiles.h (class separate_debug_iterator): New.
11235 (class separate_debug_range): New.
11236 (struct objfile) <separate_debug_objfiles>: New method.
11237 (objfile_separate_debug_iterate): Don't declare.
11238 * objfiles.c (separate_debug_iterator::operator++): Rename from
11239 objfile_separate_debug_iterate.
11240 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11241 iterator.
11242 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11243 iterator.
11244
11245 2019-04-10 Tom Tromey <tom@tromey.com>
11246
11247 * symfile.c (reread_symbols): Remove old comment.
11248 * objfiles.c (free_all_objfiles): Fix a typo.
11249
11250 2019-04-10 Tom Tromey <tom@tromey.com>
11251
11252 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11253 * minsyms.c (lookup_minimal_symbol): Use foreach.
11254 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11255 (lookup_minimal_symbol_solib_trampoline): Likewise.
11256 * symfile.c (reread_symbols): Use foreach.
11257
11258 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11259 Tom Tromey <tromey@adacore.com>
11260
11261 PR rust/24414:
11262 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11263 (rust_lex_int_test): Change "value" to be LONGEST.
11264 (rust_lex_tests): Add test for long integer literal.
11265
11266 2019-04-09 Tom Tromey <tromey@adacore.com>
11267
11268 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11269 to bool.
11270 (extended_remote_target::attach): Update.
11271 (remote_target::remote_notice_new_inferior): Update.
11272 (remote_target::add_current_inferior_and_thread): Update.
11273 * inferior.c (exit_inferior_1): Use "false".
11274 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11275
11276 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11277
11278 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11279 the "start" command.
11280
11281 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11282
11283 * python/py-inferior.c (infpy_thread_from_thread_handle):
11284 Adjust comments to reflect renaming of thread_from_thread_handle
11285 to thread_from_handle. Adjust keywords. Fix type error message.
11286 (inferior_object_methods): Add thread_from_handle. Retain
11287 thread_from_thread_handle, but mark it as deprecated.
11288
11289 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11290
11291 * gdbthread.h (find_thread_by_handle): Revise declaration.
11292 * thread.c (find_thread_by_handle): Likewise. Adjust
11293 implementation too.
11294 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11295 support for buffer objects as handles.
11296
11297 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11298
11299 * python/py-infthread.c (thpy_thread_handle): New function.
11300 (thread_object_methods): Register thpy_thread_handle.
11301
11302 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11303
11304 * gdbthread.h (thread_to_thread_handle): Declare.
11305 * thread.c (gdbtypes.h): Include.
11306 (thread_to_thread_handle): New function.
11307
11308 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11309 (target_thread_info_to_thread_handle): Declare.
11310 * target.c (target_thread_info_to_thread_handle): New function.
11311 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11312 * target-delegates.c: Regenerate.
11313
11314 * linux-thread-db.c (class thread_db_target): Add method
11315 thread_info_to_thread_handle.
11316 (thread_db_target::thread_info_to_thread_handle): Define.
11317 * remote.c (class remote_target): Add new method
11318 thread_info_to_thread_handle.
11319 (remote_target::thread_info_to_thread_handle): Define.
11320
11321 2019-04-08 Pedro Alves <palves@redhat.com>
11322
11323 * common/common-exceptions.c (throw_exception): Don't create
11324 named object to throw; throw directly.
11325 (throw_it): Likewise. Don't initialize gdb_exception::message
11326 here, with new; pass FMT and AP to the ctor instead.
11327 * common/common-exceptions.h: Include <string>.
11328 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11329 const char *, va_list)): New ctor. Use std::make_shared.
11330 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11331 errors)): Delete.
11332 (gdb_exception_error::gdb_exception_error(enum errors, const char
11333 *, va_list)): New.
11334 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11335 Add assertion.
11336 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11337 errors)): Delete.
11338 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11339 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11340 Add assertion.
11341
11342 2019-04-08 Tom Tromey <tom@tromey.com>
11343
11344 * valops.c (value_rtti_indirect_type): Replace throw_exception
11345 with throw.
11346 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11347 with throw.
11348 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11349 throw.
11350 * target.c (target_translate_tls_address): Replace throw_exception
11351 with throw.
11352 * stack.c (frame_apply_command_count): Replace throw_exception
11353 with throw.
11354 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11355 throw.
11356 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11357 with throw.
11358 * rs6000-tdep.c (rs6000_frame_cache)
11359 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11360 * remote.c: Replace throw_exception with throw.
11361 * record-full.c (record_full_message, record_full_wait_1)
11362 (record_full_restore): Replace throw_exception with throw.
11363 * record-btrace.c:
11364 (get_thread_current_frame_id, record_btrace_start_replaying)
11365 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11366 (cmd_record_btrace_start): Replace throw_exception with throw.
11367 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11368 throw.
11369 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11370 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11371 * linespec.c:
11372 (find_linespec_symbols): Replace throw_exception with throw.
11373 * infrun.c (displaced_step_prepare, resume): Replace
11374 throw_exception with throw.
11375 * infcmd.c (post_create_inferior): Replace throw_exception with
11376 throw.
11377 * inf-loop.c (inferior_event_handler): Replace throw_exception
11378 with throw.
11379 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11380 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11381 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11382 (get_prev_frame_always, get_frame_pc_if_available)
11383 (get_frame_address_in_block_if_available, get_frame_language):
11384 Replace throw_exception with throw.
11385 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11386 throw_exception with throw.
11387 * eval.c (fetch_subexp_value, evaluate_var_value)
11388 (evaluate_funcall, evaluate_subexp_standard): Replace
11389 throw_exception with throw.
11390 * dwarf2loc.c (call_site_find_chain)
11391 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11392 Replace throw_exception with throw.
11393 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11394 with throw.
11395 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11396 throw.
11397 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11398 * completer.c (complete_line_internal): Replace throw_exception
11399 with throw.
11400 * compile/compile-object-run.c (compile_object_run): Replace
11401 throw_exception with throw.
11402 * cli/cli-script.c (process_next_line): Replace throw_exception
11403 with throw.
11404 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11405 (btrace_enable, btrace_maint_update_pt_packets): Replace
11406 throw_exception with throw.
11407 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11408 throw_exception with throw.
11409 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11410 throw_exception with throw.
11411 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11412 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11413 * aarch64-tdep.c (aarch64_make_prologue_cache)
11414 (aarch64_make_stub_cache): Replace throw_exception with throw.
11415
11416 2019-04-08 Tom Tromey <tom@tromey.com>
11417
11418 * common/common-exceptions.c (throw_exception): Rename from
11419 throw_exception_cxx. Remove old copy. Make argument const.
11420 (throw_it): Create and throw exception objects directly.
11421 * common/common-exceptions.h (throw_exception): Make argument
11422 const.
11423 (struct gdb_exception_error): Add constructor.
11424 (struct gdb_exception_quit): Add constructor.
11425
11426 2019-04-08 Tom Tromey <tom@tromey.com>
11427
11428 * common/common-exceptions.h (exception_rethrow): Don't declare.
11429 (TRY_SJLJ): Update comment.
11430 (TRY, CATCH, END_CATCH): Remove.
11431 * common/common-exceptions.c (exception_rethrow): Remove.
11432
11433 2019-04-08 Tom Tromey <tom@tromey.com>
11434
11435 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11436 Remove.
11437 (gdb_exception_error): Rename from
11438 gdb_exception_RETURN_MASK_ERROR.
11439 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11440 (gdb_quit_bad_alloc): Update.
11441 * aarch64-tdep.c: Update.
11442 * ada-lang.c: Update.
11443 * ada-typeprint.c: Update.
11444 * ada-valprint.c: Update.
11445 * amd64-tdep.c: Update.
11446 * arch-utils.c: Update.
11447 * break-catch-throw.c: Update.
11448 * breakpoint.c: Update.
11449 * btrace.c: Update.
11450 * c-varobj.c: Update.
11451 * cli/cli-cmds.c: Update.
11452 * cli/cli-interp.c: Update.
11453 * cli/cli-script.c: Update.
11454 * common/common-exceptions.c: Update.
11455 * common/new-op.c: Update.
11456 * common/selftest.c: Update.
11457 * compile/compile-c-symbols.c: Update.
11458 * compile/compile-cplus-symbols.c: Update.
11459 * compile/compile-object-load.c: Update.
11460 * compile/compile-object-run.c: Update.
11461 * completer.c: Update.
11462 * corelow.c: Update.
11463 * cp-abi.c: Update.
11464 * cp-support.c: Update.
11465 * cp-valprint.c: Update.
11466 * darwin-nat.c: Update.
11467 * disasm-selftests.c: Update.
11468 * dtrace-probe.c: Update.
11469 * dwarf-index-cache.c: Update.
11470 * dwarf-index-write.c: Update.
11471 * dwarf2-frame-tailcall.c: Update.
11472 * dwarf2-frame.c: Update.
11473 * dwarf2loc.c: Update.
11474 * dwarf2read.c: Update.
11475 * eval.c: Update.
11476 * event-loop.c: Update.
11477 * event-top.c: Update.
11478 * exec.c: Update.
11479 * f-valprint.c: Update.
11480 * fbsd-tdep.c: Update.
11481 * frame-unwind.c: Update.
11482 * frame.c: Update.
11483 * gdbtypes.c: Update.
11484 * gnu-v3-abi.c: Update.
11485 * guile/guile-internal.h: Update.
11486 * guile/scm-block.c: Update.
11487 * guile/scm-breakpoint.c: Update.
11488 * guile/scm-cmd.c: Update.
11489 * guile/scm-disasm.c: Update.
11490 * guile/scm-frame.c: Update.
11491 * guile/scm-lazy-string.c: Update.
11492 * guile/scm-math.c: Update.
11493 * guile/scm-param.c: Update.
11494 * guile/scm-ports.c: Update.
11495 * guile/scm-pretty-print.c: Update.
11496 * guile/scm-symbol.c: Update.
11497 * guile/scm-symtab.c: Update.
11498 * guile/scm-type.c: Update.
11499 * guile/scm-value.c: Update.
11500 * i386-linux-tdep.c: Update.
11501 * i386-tdep.c: Update.
11502 * inf-loop.c: Update.
11503 * infcall.c: Update.
11504 * infcmd.c: Update.
11505 * infrun.c: Update.
11506 * jit.c: Update.
11507 * language.c: Update.
11508 * linespec.c: Update.
11509 * linux-fork.c: Update.
11510 * linux-nat.c: Update.
11511 * linux-tdep.c: Update.
11512 * linux-thread-db.c: Update.
11513 * main.c: Update.
11514 * mi/mi-cmd-break.c: Update.
11515 * mi/mi-cmd-stack.c: Update.
11516 * mi/mi-interp.c: Update.
11517 * mi/mi-main.c: Update.
11518 * objc-lang.c: Update.
11519 * p-valprint.c: Update.
11520 * parse.c: Update.
11521 * ppc-linux-tdep.c: Update.
11522 * printcmd.c: Update.
11523 * python/py-arch.c: Update.
11524 * python/py-breakpoint.c: Update.
11525 * python/py-cmd.c: Update.
11526 * python/py-finishbreakpoint.c: Update.
11527 * python/py-frame.c: Update.
11528 * python/py-framefilter.c: Update.
11529 * python/py-gdb-readline.c: Update.
11530 * python/py-inferior.c: Update.
11531 * python/py-infthread.c: Update.
11532 * python/py-lazy-string.c: Update.
11533 * python/py-linetable.c: Update.
11534 * python/py-objfile.c: Update.
11535 * python/py-param.c: Update.
11536 * python/py-prettyprint.c: Update.
11537 * python/py-progspace.c: Update.
11538 * python/py-record-btrace.c: Update.
11539 * python/py-record.c: Update.
11540 * python/py-symbol.c: Update.
11541 * python/py-type.c: Update.
11542 * python/py-unwind.c: Update.
11543 * python/py-utils.c: Update.
11544 * python/py-value.c: Update.
11545 * python/python.c: Update.
11546 * record-btrace.c: Update.
11547 * record-full.c: Update.
11548 * remote-fileio.c: Update.
11549 * remote.c: Update.
11550 * riscv-tdep.c: Update.
11551 * rs6000-aix-tdep.c: Update.
11552 * rs6000-tdep.c: Update.
11553 * rust-exp.y: Update.
11554 * rust-lang.c: Update.
11555 * s390-tdep.c: Update.
11556 * selftest-arch.c: Update.
11557 * solib-dsbt.c: Update.
11558 * solib-frv.c: Update.
11559 * solib-spu.c: Update.
11560 * solib-svr4.c: Update.
11561 * solib.c: Update.
11562 * sparc64-linux-tdep.c: Update.
11563 * stack.c: Update.
11564 * symfile-mem.c: Update.
11565 * symmisc.c: Update.
11566 * target.c: Update.
11567 * thread.c: Update.
11568 * top.c: Update.
11569 * tracefile-tfile.c: Update.
11570 * tui/tui.c: Update.
11571 * typeprint.c: Update.
11572 * unittests/cli-utils-selftests.c: Update.
11573 * unittests/parse-connection-spec-selftests.c: Update.
11574 * valops.c: Update.
11575 * valprint.c: Update.
11576 * value.c: Update.
11577 * varobj.c: Update.
11578 * windows-nat.c: Update.
11579 * x86-linux-nat.c: Update.
11580 * xml-support.c: Update.
11581
11582 2019-04-08 Tom Tromey <tom@tromey.com>
11583
11584 * xml-support.c: Use C++ exception handling.
11585 * x86-linux-nat.c: Use C++ exception handling.
11586 * windows-nat.c: Use C++ exception handling.
11587 * varobj.c: Use C++ exception handling.
11588 * value.c: Use C++ exception handling.
11589 * valprint.c: Use C++ exception handling.
11590 * valops.c: Use C++ exception handling.
11591 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11592 handling.
11593 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11594 * typeprint.c: Use C++ exception handling.
11595 * tui/tui.c: Use C++ exception handling.
11596 * tracefile-tfile.c: Use C++ exception handling.
11597 * top.c: Use C++ exception handling.
11598 * thread.c: Use C++ exception handling.
11599 * target.c: Use C++ exception handling.
11600 * symmisc.c: Use C++ exception handling.
11601 * symfile-mem.c: Use C++ exception handling.
11602 * stack.c: Use C++ exception handling.
11603 * sparc64-linux-tdep.c: Use C++ exception handling.
11604 * solib.c: Use C++ exception handling.
11605 * solib-svr4.c: Use C++ exception handling.
11606 * solib-spu.c: Use C++ exception handling.
11607 * solib-frv.c: Use C++ exception handling.
11608 * solib-dsbt.c: Use C++ exception handling.
11609 * selftest-arch.c: Use C++ exception handling.
11610 * s390-tdep.c: Use C++ exception handling.
11611 * rust-lang.c: Use C++ exception handling.
11612 * rust-exp.y: Use C++ exception handling.
11613 * rs6000-tdep.c: Use C++ exception handling.
11614 * rs6000-aix-tdep.c: Use C++ exception handling.
11615 * riscv-tdep.c: Use C++ exception handling.
11616 * remote.c: Use C++ exception handling.
11617 * remote-fileio.c: Use C++ exception handling.
11618 * record-full.c: Use C++ exception handling.
11619 * record-btrace.c: Use C++ exception handling.
11620 * python/python.c: Use C++ exception handling.
11621 * python/py-value.c: Use C++ exception handling.
11622 * python/py-utils.c: Use C++ exception handling.
11623 * python/py-unwind.c: Use C++ exception handling.
11624 * python/py-type.c: Use C++ exception handling.
11625 * python/py-symbol.c: Use C++ exception handling.
11626 * python/py-record.c: Use C++ exception handling.
11627 * python/py-record-btrace.c: Use C++ exception handling.
11628 * python/py-progspace.c: Use C++ exception handling.
11629 * python/py-prettyprint.c: Use C++ exception handling.
11630 * python/py-param.c: Use C++ exception handling.
11631 * python/py-objfile.c: Use C++ exception handling.
11632 * python/py-linetable.c: Use C++ exception handling.
11633 * python/py-lazy-string.c: Use C++ exception handling.
11634 * python/py-infthread.c: Use C++ exception handling.
11635 * python/py-inferior.c: Use C++ exception handling.
11636 * python/py-gdb-readline.c: Use C++ exception handling.
11637 * python/py-framefilter.c: Use C++ exception handling.
11638 * python/py-frame.c: Use C++ exception handling.
11639 * python/py-finishbreakpoint.c: Use C++ exception handling.
11640 * python/py-cmd.c: Use C++ exception handling.
11641 * python/py-breakpoint.c: Use C++ exception handling.
11642 * python/py-arch.c: Use C++ exception handling.
11643 * printcmd.c: Use C++ exception handling.
11644 * ppc-linux-tdep.c: Use C++ exception handling.
11645 * parse.c: Use C++ exception handling.
11646 * p-valprint.c: Use C++ exception handling.
11647 * objc-lang.c: Use C++ exception handling.
11648 * mi/mi-main.c: Use C++ exception handling.
11649 * mi/mi-interp.c: Use C++ exception handling.
11650 * mi/mi-cmd-stack.c: Use C++ exception handling.
11651 * mi/mi-cmd-break.c: Use C++ exception handling.
11652 * main.c: Use C++ exception handling.
11653 * linux-thread-db.c: Use C++ exception handling.
11654 * linux-tdep.c: Use C++ exception handling.
11655 * linux-nat.c: Use C++ exception handling.
11656 * linux-fork.c: Use C++ exception handling.
11657 * linespec.c: Use C++ exception handling.
11658 * language.c: Use C++ exception handling.
11659 * jit.c: Use C++ exception handling.
11660 * infrun.c: Use C++ exception handling.
11661 * infcmd.c: Use C++ exception handling.
11662 * infcall.c: Use C++ exception handling.
11663 * inf-loop.c: Use C++ exception handling.
11664 * i386-tdep.c: Use C++ exception handling.
11665 * i386-linux-tdep.c: Use C++ exception handling.
11666 * guile/scm-value.c: Use C++ exception handling.
11667 * guile/scm-type.c: Use C++ exception handling.
11668 * guile/scm-symtab.c: Use C++ exception handling.
11669 * guile/scm-symbol.c: Use C++ exception handling.
11670 * guile/scm-pretty-print.c: Use C++ exception handling.
11671 * guile/scm-ports.c: Use C++ exception handling.
11672 * guile/scm-param.c: Use C++ exception handling.
11673 * guile/scm-math.c: Use C++ exception handling.
11674 * guile/scm-lazy-string.c: Use C++ exception handling.
11675 * guile/scm-frame.c: Use C++ exception handling.
11676 * guile/scm-disasm.c: Use C++ exception handling.
11677 * guile/scm-cmd.c: Use C++ exception handling.
11678 * guile/scm-breakpoint.c: Use C++ exception handling.
11679 * guile/scm-block.c: Use C++ exception handling.
11680 * guile/guile-internal.h: Use C++ exception handling.
11681 * gnu-v3-abi.c: Use C++ exception handling.
11682 * gdbtypes.c: Use C++ exception handling.
11683 * frame.c: Use C++ exception handling.
11684 * frame-unwind.c: Use C++ exception handling.
11685 * fbsd-tdep.c: Use C++ exception handling.
11686 * f-valprint.c: Use C++ exception handling.
11687 * exec.c: Use C++ exception handling.
11688 * event-top.c: Use C++ exception handling.
11689 * event-loop.c: Use C++ exception handling.
11690 * eval.c: Use C++ exception handling.
11691 * dwarf2read.c: Use C++ exception handling.
11692 * dwarf2loc.c: Use C++ exception handling.
11693 * dwarf2-frame.c: Use C++ exception handling.
11694 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11695 * dwarf-index-write.c: Use C++ exception handling.
11696 * dwarf-index-cache.c: Use C++ exception handling.
11697 * dtrace-probe.c: Use C++ exception handling.
11698 * disasm-selftests.c: Use C++ exception handling.
11699 * darwin-nat.c: Use C++ exception handling.
11700 * cp-valprint.c: Use C++ exception handling.
11701 * cp-support.c: Use C++ exception handling.
11702 * cp-abi.c: Use C++ exception handling.
11703 * corelow.c: Use C++ exception handling.
11704 * completer.c: Use C++ exception handling.
11705 * compile/compile-object-run.c: Use C++ exception handling.
11706 * compile/compile-object-load.c: Use C++ exception handling.
11707 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11708 * compile/compile-c-symbols.c: Use C++ exception handling.
11709 * common/selftest.c: Use C++ exception handling.
11710 * common/new-op.c: Use C++ exception handling.
11711 * cli/cli-script.c: Use C++ exception handling.
11712 * cli/cli-interp.c: Use C++ exception handling.
11713 * cli/cli-cmds.c: Use C++ exception handling.
11714 * c-varobj.c: Use C++ exception handling.
11715 * btrace.c: Use C++ exception handling.
11716 * breakpoint.c: Use C++ exception handling.
11717 * break-catch-throw.c: Use C++ exception handling.
11718 * arch-utils.c: Use C++ exception handling.
11719 * amd64-tdep.c: Use C++ exception handling.
11720 * ada-valprint.c: Use C++ exception handling.
11721 * ada-typeprint.c: Use C++ exception handling.
11722 * ada-lang.c: Use C++ exception handling.
11723 * aarch64-tdep.c: Use C++ exception handling.
11724
11725 2019-04-08 Tom Tromey <tom@tromey.com>
11726
11727 * xml-support.c (gdb_xml_parser::parse): Update.
11728 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11729 * value.c (show_convenience): Update.
11730 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11731 (test_parse_flags_qcs): Update.
11732 * thread.c (thr_try_catch_cmd): Update.
11733 * target.c (target_translate_tls_address): Update.
11734 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11735 (info_frame_command_core, frame_apply_command_count): Update.
11736 * rust-exp.y (rust_lex_exception_test): Update.
11737 * riscv-tdep.c (riscv_print_one_register_info): Update.
11738 * remote.c (remote_target::enable_btrace): Update.
11739 * record-btrace.c (record_btrace_enable_warn): Update.
11740 * python/py-utils.c (gdbpy_convert_exception): Update.
11741 * printcmd.c (do_one_display, print_variable_and_value): Update.
11742 * mi/mi-main.c (mi_print_exception): Update.
11743 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11744 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11745 * linux-nat.c (linux_nat_target::attach): Update.
11746 * linux-fork.c (class scoped_switch_fork_info): Update.
11747 * infrun.c (displaced_step_prepare): Update.
11748 * infcall.c (call_function_by_hand_dummy): Update.
11749 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11750 * gnu-v3-abi.c (print_one_vtable): Update.
11751 * frame.c (get_prev_frame_always): Update.
11752 * f-valprint.c (info_common_command_for_block): Update.
11753 * exec.c (try_open_exec_file): Update.
11754 * exceptions.c (print_exception, exception_print)
11755 (exception_fprintf, exception_print_same): Update.
11756 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11757 * dwarf-index-cache.c (index_cache::store)
11758 (index_cache::lookup_gdb_index): Update.
11759 * darwin-nat.c (maybe_cache_shell): Update.
11760 * cp-valprint.c (cp_print_value_fields): Update.
11761 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11762 (gcc_cplus_symbol_address): Update.
11763 * compile/compile-c-symbols.c (gcc_convert_symbol)
11764 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11765 * common/selftest.c: Update.
11766 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11767 a std::string.
11768 (exception_try_scope_entry, exception_try_scope_exit): Don't
11769 declare.
11770 (struct exception_try_scope): Remove.
11771 (TRY): Don't use exception_try_scope.
11772 (struct gdb_exception): Add constructor, operator=.
11773 <what>: New method.
11774 (struct gdb_exception_RETURN_MASK_ALL)
11775 (struct gdb_exception_RETURN_MASK_ERROR)
11776 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11777 (struct gdb_quit_bad_alloc): Update.
11778 * common/common-exceptions.c (exception_none): Change
11779 initializer.
11780 (struct catcher) <state, exception>: Initialize inline.
11781 <prev>: Remove member.
11782 (current_catcher): Remove.
11783 (catchers): New global.
11784 (exceptions_state_mc_init): Simplify.
11785 (catcher_pop): Remove.
11786 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11787 (try_scope_depth, exception_try_scope_entry)
11788 (exception_try_scope_exit): Remove.
11789 (throw_exception_sjlj): Update.
11790 (exception_messages, exception_messages_size): Remove.
11791 (throw_it): Simplify.
11792 (gdb_exception_sliced_copy): Remove.
11793 (throw_exception_cxx): Update.
11794 * cli/cli-script.c (script_from_file): Update.
11795 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11796 Update.
11797 * ada-valprint.c (ada_val_print): Update.
11798 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11799 (create_excep_cond_exprs): Update.
11800
11801 2019-04-08 Tom Tromey <tom@tromey.com>
11802
11803 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11804 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11805 (TRY, CATCH, END_CATCH): Remove some definitions.
11806 * common/common-exceptions.c: Don't use GDB_XCPT.
11807 (catcher_list_size): Remove.
11808 (throw_exception, throw_it): Simplify.
11809
11810 2019-04-05 Tom Tromey <tom@tromey.com>
11811
11812 Revert the header-sorting patch.
11813 * ft32-tdep.c: Revert.
11814 * frv-tdep.c: Revert.
11815 * frv-linux-tdep.c: Revert.
11816 * frame.c: Revert.
11817 * frame-unwind.c: Revert.
11818 * frame-base.c: Revert.
11819 * fork-child.c: Revert.
11820 * findvar.c: Revert.
11821 * findcmd.c: Revert.
11822 * filesystem.c: Revert.
11823 * filename-seen-cache.h: Revert.
11824 * filename-seen-cache.c: Revert.
11825 * fbsd-tdep.c: Revert.
11826 * fbsd-nat.h: Revert.
11827 * fbsd-nat.c: Revert.
11828 * f-valprint.c: Revert.
11829 * f-typeprint.c: Revert.
11830 * f-lang.c: Revert.
11831 * extension.h: Revert.
11832 * extension.c: Revert.
11833 * extension-priv.h: Revert.
11834 * expprint.c: Revert.
11835 * exec.h: Revert.
11836 * exec.c: Revert.
11837 * exceptions.c: Revert.
11838 * event-top.c: Revert.
11839 * event-loop.c: Revert.
11840 * eval.c: Revert.
11841 * elfread.c: Revert.
11842 * dwarf2read.h: Revert.
11843 * dwarf2read.c: Revert.
11844 * dwarf2loc.c: Revert.
11845 * dwarf2expr.h: Revert.
11846 * dwarf2expr.c: Revert.
11847 * dwarf2-frame.c: Revert.
11848 * dwarf2-frame-tailcall.c: Revert.
11849 * dwarf-index-write.h: Revert.
11850 * dwarf-index-write.c: Revert.
11851 * dwarf-index-common.c: Revert.
11852 * dwarf-index-cache.h: Revert.
11853 * dwarf-index-cache.c: Revert.
11854 * dummy-frame.c: Revert.
11855 * dtrace-probe.c: Revert.
11856 * disasm.h: Revert.
11857 * disasm.c: Revert.
11858 * disasm-selftests.c: Revert.
11859 * dictionary.c: Revert.
11860 * dicos-tdep.c: Revert.
11861 * demangle.c: Revert.
11862 * dcache.h: Revert.
11863 * dcache.c: Revert.
11864 * darwin-nat.h: Revert.
11865 * darwin-nat.c: Revert.
11866 * darwin-nat-info.c: Revert.
11867 * d-valprint.c: Revert.
11868 * d-namespace.c: Revert.
11869 * d-lang.c: Revert.
11870 * ctf.c: Revert.
11871 * csky-tdep.c: Revert.
11872 * csky-linux-tdep.c: Revert.
11873 * cris-tdep.c: Revert.
11874 * cris-linux-tdep.c: Revert.
11875 * cp-valprint.c: Revert.
11876 * cp-support.c: Revert.
11877 * cp-namespace.c: Revert.
11878 * cp-abi.c: Revert.
11879 * corelow.c: Revert.
11880 * corefile.c: Revert.
11881 * continuations.c: Revert.
11882 * completer.h: Revert.
11883 * completer.c: Revert.
11884 * complaints.c: Revert.
11885 * coffread.c: Revert.
11886 * coff-pe-read.c: Revert.
11887 * cli-out.h: Revert.
11888 * cli-out.c: Revert.
11889 * charset.c: Revert.
11890 * c-varobj.c: Revert.
11891 * c-valprint.c: Revert.
11892 * c-typeprint.c: Revert.
11893 * c-lang.c: Revert.
11894 * buildsym.c: Revert.
11895 * buildsym-legacy.c: Revert.
11896 * build-id.h: Revert.
11897 * build-id.c: Revert.
11898 * btrace.c: Revert.
11899 * bsd-uthread.c: Revert.
11900 * breakpoint.h: Revert.
11901 * breakpoint.c: Revert.
11902 * break-catch-throw.c: Revert.
11903 * break-catch-syscall.c: Revert.
11904 * break-catch-sig.c: Revert.
11905 * blockframe.c: Revert.
11906 * block.c: Revert.
11907 * bfin-tdep.c: Revert.
11908 * bfin-linux-tdep.c: Revert.
11909 * bfd-target.c: Revert.
11910 * bcache.c: Revert.
11911 * ax-general.c: Revert.
11912 * ax-gdb.h: Revert.
11913 * ax-gdb.c: Revert.
11914 * avr-tdep.c: Revert.
11915 * auxv.c: Revert.
11916 * auto-load.c: Revert.
11917 * arm-wince-tdep.c: Revert.
11918 * arm-tdep.c: Revert.
11919 * arm-symbian-tdep.c: Revert.
11920 * arm-pikeos-tdep.c: Revert.
11921 * arm-obsd-tdep.c: Revert.
11922 * arm-nbsd-tdep.c: Revert.
11923 * arm-nbsd-nat.c: Revert.
11924 * arm-linux-tdep.c: Revert.
11925 * arm-linux-nat.c: Revert.
11926 * arm-fbsd-tdep.c: Revert.
11927 * arm-fbsd-nat.c: Revert.
11928 * arm-bsd-tdep.c: Revert.
11929 * arch-utils.c: Revert.
11930 * arc-tdep.c: Revert.
11931 * arc-newlib-tdep.c: Revert.
11932 * annotate.h: Revert.
11933 * annotate.c: Revert.
11934 * amd64-windows-tdep.c: Revert.
11935 * amd64-windows-nat.c: Revert.
11936 * amd64-tdep.c: Revert.
11937 * amd64-sol2-tdep.c: Revert.
11938 * amd64-obsd-tdep.c: Revert.
11939 * amd64-obsd-nat.c: Revert.
11940 * amd64-nbsd-tdep.c: Revert.
11941 * amd64-nbsd-nat.c: Revert.
11942 * amd64-nat.c: Revert.
11943 * amd64-linux-tdep.c: Revert.
11944 * amd64-linux-nat.c: Revert.
11945 * amd64-fbsd-tdep.c: Revert.
11946 * amd64-fbsd-nat.c: Revert.
11947 * amd64-dicos-tdep.c: Revert.
11948 * amd64-darwin-tdep.c: Revert.
11949 * amd64-bsd-nat.c: Revert.
11950 * alpha-tdep.c: Revert.
11951 * alpha-obsd-tdep.c: Revert.
11952 * alpha-nbsd-tdep.c: Revert.
11953 * alpha-mdebug-tdep.c: Revert.
11954 * alpha-linux-tdep.c: Revert.
11955 * alpha-linux-nat.c: Revert.
11956 * alpha-bsd-tdep.c: Revert.
11957 * alpha-bsd-nat.c: Revert.
11958 * aix-thread.c: Revert.
11959 * agent.c: Revert.
11960 * addrmap.c: Revert.
11961 * ada-varobj.c: Revert.
11962 * ada-valprint.c: Revert.
11963 * ada-typeprint.c: Revert.
11964 * ada-tasks.c: Revert.
11965 * ada-lang.c: Revert.
11966 * aarch64-tdep.c: Revert.
11967 * aarch64-ravenscar-thread.c: Revert.
11968 * aarch64-newlib-tdep.c: Revert.
11969 * aarch64-linux-tdep.c: Revert.
11970 * aarch64-linux-nat.c: Revert.
11971 * aarch64-fbsd-tdep.c: Revert.
11972 * aarch64-fbsd-nat.c: Revert.
11973 * aarch32-linux-nat.c: Revert.
11974
11975 2019-04-05 Tom Tromey <tom@tromey.com>
11976
11977 * ft32-tdep.c: Sort headers.
11978 * frv-tdep.c: Sort headers.
11979 * frv-linux-tdep.c: Sort headers.
11980 * frame.c: Sort headers.
11981 * frame-unwind.c: Sort headers.
11982 * frame-base.c: Sort headers.
11983 * fork-child.c: Sort headers.
11984 * findvar.c: Sort headers.
11985 * findcmd.c: Sort headers.
11986 * filesystem.c: Sort headers.
11987 * filename-seen-cache.h: Sort headers.
11988 * filename-seen-cache.c: Sort headers.
11989 * fbsd-tdep.c: Sort headers.
11990 * fbsd-nat.h: Sort headers.
11991 * fbsd-nat.c: Sort headers.
11992 * f-valprint.c: Sort headers.
11993 * f-typeprint.c: Sort headers.
11994 * f-lang.c: Sort headers.
11995 * extension.h: Sort headers.
11996 * extension.c: Sort headers.
11997 * extension-priv.h: Sort headers.
11998 * expprint.c: Sort headers.
11999 * exec.h: Sort headers.
12000 * exec.c: Sort headers.
12001 * exceptions.c: Sort headers.
12002 * event-top.c: Sort headers.
12003 * event-loop.c: Sort headers.
12004 * eval.c: Sort headers.
12005 * elfread.c: Sort headers.
12006 * dwarf2read.h: Sort headers.
12007 * dwarf2read.c: Sort headers.
12008 * dwarf2loc.c: Sort headers.
12009 * dwarf2expr.h: Sort headers.
12010 * dwarf2expr.c: Sort headers.
12011 * dwarf2-frame.c: Sort headers.
12012 * dwarf2-frame-tailcall.c: Sort headers.
12013 * dwarf-index-write.h: Sort headers.
12014 * dwarf-index-write.c: Sort headers.
12015 * dwarf-index-common.c: Sort headers.
12016 * dwarf-index-cache.h: Sort headers.
12017 * dwarf-index-cache.c: Sort headers.
12018 * dummy-frame.c: Sort headers.
12019 * dtrace-probe.c: Sort headers.
12020 * disasm.h: Sort headers.
12021 * disasm.c: Sort headers.
12022 * disasm-selftests.c: Sort headers.
12023 * dictionary.c: Sort headers.
12024 * dicos-tdep.c: Sort headers.
12025 * demangle.c: Sort headers.
12026 * dcache.h: Sort headers.
12027 * dcache.c: Sort headers.
12028 * darwin-nat.h: Sort headers.
12029 * darwin-nat.c: Sort headers.
12030 * darwin-nat-info.c: Sort headers.
12031 * d-valprint.c: Sort headers.
12032 * d-namespace.c: Sort headers.
12033 * d-lang.c: Sort headers.
12034 * ctf.c: Sort headers.
12035 * csky-tdep.c: Sort headers.
12036 * csky-linux-tdep.c: Sort headers.
12037 * cris-tdep.c: Sort headers.
12038 * cris-linux-tdep.c: Sort headers.
12039 * cp-valprint.c: Sort headers.
12040 * cp-support.c: Sort headers.
12041 * cp-namespace.c: Sort headers.
12042 * cp-abi.c: Sort headers.
12043 * corelow.c: Sort headers.
12044 * corefile.c: Sort headers.
12045 * continuations.c: Sort headers.
12046 * completer.h: Sort headers.
12047 * completer.c: Sort headers.
12048 * complaints.c: Sort headers.
12049 * coffread.c: Sort headers.
12050 * coff-pe-read.c: Sort headers.
12051 * cli-out.h: Sort headers.
12052 * cli-out.c: Sort headers.
12053 * charset.c: Sort headers.
12054 * c-varobj.c: Sort headers.
12055 * c-valprint.c: Sort headers.
12056 * c-typeprint.c: Sort headers.
12057 * c-lang.c: Sort headers.
12058 * buildsym.c: Sort headers.
12059 * buildsym-legacy.c: Sort headers.
12060 * build-id.h: Sort headers.
12061 * build-id.c: Sort headers.
12062 * btrace.c: Sort headers.
12063 * bsd-uthread.c: Sort headers.
12064 * breakpoint.h: Sort headers.
12065 * breakpoint.c: Sort headers.
12066 * break-catch-throw.c: Sort headers.
12067 * break-catch-syscall.c: Sort headers.
12068 * break-catch-sig.c: Sort headers.
12069 * blockframe.c: Sort headers.
12070 * block.c: Sort headers.
12071 * bfin-tdep.c: Sort headers.
12072 * bfin-linux-tdep.c: Sort headers.
12073 * bfd-target.c: Sort headers.
12074 * bcache.c: Sort headers.
12075 * ax-general.c: Sort headers.
12076 * ax-gdb.h: Sort headers.
12077 * ax-gdb.c: Sort headers.
12078 * avr-tdep.c: Sort headers.
12079 * auxv.c: Sort headers.
12080 * auto-load.c: Sort headers.
12081 * arm-wince-tdep.c: Sort headers.
12082 * arm-tdep.c: Sort headers.
12083 * arm-symbian-tdep.c: Sort headers.
12084 * arm-pikeos-tdep.c: Sort headers.
12085 * arm-obsd-tdep.c: Sort headers.
12086 * arm-nbsd-tdep.c: Sort headers.
12087 * arm-nbsd-nat.c: Sort headers.
12088 * arm-linux-tdep.c: Sort headers.
12089 * arm-linux-nat.c: Sort headers.
12090 * arm-fbsd-tdep.c: Sort headers.
12091 * arm-fbsd-nat.c: Sort headers.
12092 * arm-bsd-tdep.c: Sort headers.
12093 * arch-utils.c: Sort headers.
12094 * arc-tdep.c: Sort headers.
12095 * arc-newlib-tdep.c: Sort headers.
12096 * annotate.h: Sort headers.
12097 * annotate.c: Sort headers.
12098 * amd64-windows-tdep.c: Sort headers.
12099 * amd64-windows-nat.c: Sort headers.
12100 * amd64-tdep.c: Sort headers.
12101 * amd64-sol2-tdep.c: Sort headers.
12102 * amd64-obsd-tdep.c: Sort headers.
12103 * amd64-obsd-nat.c: Sort headers.
12104 * amd64-nbsd-tdep.c: Sort headers.
12105 * amd64-nbsd-nat.c: Sort headers.
12106 * amd64-nat.c: Sort headers.
12107 * amd64-linux-tdep.c: Sort headers.
12108 * amd64-linux-nat.c: Sort headers.
12109 * amd64-fbsd-tdep.c: Sort headers.
12110 * amd64-fbsd-nat.c: Sort headers.
12111 * amd64-dicos-tdep.c: Sort headers.
12112 * amd64-darwin-tdep.c: Sort headers.
12113 * amd64-bsd-nat.c: Sort headers.
12114 * alpha-tdep.c: Sort headers.
12115 * alpha-obsd-tdep.c: Sort headers.
12116 * alpha-nbsd-tdep.c: Sort headers.
12117 * alpha-mdebug-tdep.c: Sort headers.
12118 * alpha-linux-tdep.c: Sort headers.
12119 * alpha-linux-nat.c: Sort headers.
12120 * alpha-bsd-tdep.c: Sort headers.
12121 * alpha-bsd-nat.c: Sort headers.
12122 * aix-thread.c: Sort headers.
12123 * agent.c: Sort headers.
12124 * addrmap.c: Sort headers.
12125 * ada-varobj.c: Sort headers.
12126 * ada-valprint.c: Sort headers.
12127 * ada-typeprint.c: Sort headers.
12128 * ada-tasks.c: Sort headers.
12129 * ada-lang.c: Sort headers.
12130 * aarch64-tdep.c: Sort headers.
12131 * aarch64-ravenscar-thread.c: Sort headers.
12132 * aarch64-newlib-tdep.c: Sort headers.
12133 * aarch64-linux-tdep.c: Sort headers.
12134 * aarch64-linux-nat.c: Sort headers.
12135 * aarch64-fbsd-tdep.c: Sort headers.
12136 * aarch64-fbsd-nat.c: Sort headers.
12137 * aarch32-linux-nat.c: Sort headers.
12138
12139 2019-04-04 Tom Tromey <tom@tromey.com>
12140
12141 * varobj.c (varobj_create): Update.
12142 * rust-exp.y (struct rust_parser) <update_innermost_block,
12143 lookup_symbol>: New methods.
12144 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12145 Rename.
12146 (rust_parser::rust_lookup_type)
12147 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12148 * printcmd.c (display_command, do_one_display): Update.
12149 * parser-defs.h (struct parser_state) <parser_state>: Add
12150 "tracker" parameter.
12151 (block_tracker): New member.
12152 (class innermost_block_tracker) <innermost_block_tracker>: Add
12153 "types" parameter.
12154 <reset>: Remove method.
12155 (innermost_block): Don't declare.
12156 (null_post_parser): Update.
12157 * parse.c (innermost_block): Remove global.
12158 (write_dollar_variable): Update.
12159 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12160 Remove "tracker_types" parameter.
12161 (parse_expression): Add "tracker" parameter.
12162 (parse_expression_for_completion): Update.
12163 (null_post_parser): Add "tracker" parameter.
12164 * p-exp.y: Update rules.
12165 * m2-exp.y: Update rules.
12166 * language.h (struct language_defn) <la_post_parser>: Add
12167 "tracker" parameter.
12168 * go-exp.y: Update rules.
12169 * f-exp.y: Update rules.
12170 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12171 parameter.
12172 * d-exp.y: Update rules.
12173 * c-exp.y: Update rules.
12174 * breakpoint.c (set_breakpoint_condition): Create an
12175 innermost_block_tracker.
12176 (watch_command_1): Likewise.
12177 * ada-lang.c (resolve): Add "tracker" parameter.
12178 (resolve_subexp): Likewise.
12179 * ada-exp.y (write_var_from_sym): Update.
12180
12181 2019-04-04 Tom Tromey <tom@tromey.com>
12182
12183 * type-stack.h: New file.
12184 * type-stack.c: New file.
12185 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12186 type-stack.h.
12187 (insert_into_type_stack, insert_type, push_type, push_type_int)
12188 (insert_type_address_space, pop_type, pop_type_int)
12189 (pop_typelist, pop_type_stack, append_type_stack)
12190 (push_type_stack, get_type_stack, push_typelist)
12191 (follow_type_instance_flags, follow_types): Don't declare.
12192 * parse.c (type_stack): Remove global.
12193 (parse_exp_in_context): Update.
12194 (insert_into_type_stack, insert_type, push_type, push_type_int)
12195 (insert_type_address_space, pop_type, pop_type_int)
12196 (pop_typelist, pop_type_stack, append_type_stack)
12197 (push_type_stack, get_type_stack, push_typelist)
12198 (follow_type_instance_flags, follow_types): Remove (moved to
12199 type-stack.c).
12200 * f-exp.y (type_stack): New global.
12201 Update rules.
12202 (push_kind_type, f_parse): Update.
12203 * d-exp.y (type_stack): New global.
12204 Update rules.
12205 (d_parse): Update.
12206 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12207 Update rules.
12208 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12209 (HFILES_NO_SRCDIR): Add type-stack.h.
12210
12211 2019-04-04 Tom Tromey <tom@tromey.com>
12212
12213 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12214 (rust_parser::convert_ast_to_expression, rust_parse)
12215 (rust_lex_test_completion, rust_lex_tests): Update.
12216 * parser-defs.h (struct expr_completion_state): New.
12217 (struct parser_state) <parser_state>: Add completion parameter.
12218 <mark_struct_expression, mark_completion_tag>: New methods.
12219 <parse_completion, m_completion_state>: New members.
12220 (prefixify_expression, null_post_parser): Update.
12221 (mark_struct_expression, mark_completion_tag): Don't declare.
12222 * parse.c (parse_completion, expout_last_struct)
12223 (expout_tag_completion_type, expout_completion_name): Remove
12224 globals.
12225 (parser_state::mark_struct_expression)
12226 (parser_state::mark_completion_tag): Now methods.
12227 (prefixify_expression): Add last_struct parameter.
12228 (prefixify_subexp): Likewise.
12229 (parse_exp_1): Update.
12230 (parse_exp_in_context): Add cstate parameter. Update.
12231 (parse_expression_for_completion): Create an
12232 expr_completion_state.
12233 (null_post_parser): Add "completion" parameter.
12234 * p-exp.y: Update rules.
12235 (yylex): Update.
12236 * language.h (struct language_defn) <la_post_parser>: Add
12237 "completing" parameter.
12238 * go-exp.y: Update rules.
12239 (lex_one_token): Update.
12240 * expression.h (parse_completion): Don't declare.
12241 * d-exp.y: Update rules.
12242 (lex_one_token): Update rules.
12243 * c-exp.y: Update rules.
12244 (lex_one_token): Update.
12245 * ada-lang.c (resolve): Add "parse_completion" parameter.
12246 (resolve_subexp): Likewise.
12247 (ada_resolve_function): Likewise.
12248
12249 2019-04-04 Tom Tromey <tom@tromey.com>
12250
12251 * parser-defs.h (struct parser_state) <start_arglist,
12252 end_arglist>: New methods.
12253 <arglist_len, m_funcall_chain>: New members.
12254 (arglist_len, start_arglist, end_arglist): Don't declare.
12255 * parse.c (arglist_len, funcall_chain): Remove global.
12256 (start_arglist, end_arglist): Remove functions.
12257 (parse_exp_in_context): Update.
12258 * p-exp.y: Update rules.
12259 * m2-exp.y: Update rules.
12260 * go-exp.y: Update rules.
12261 * f-exp.y: Update rules.
12262 * d-exp.y: Update rules.
12263 * c-exp.y: Update rules.
12264
12265 2019-04-04 Tom Tromey <tom@tromey.com>
12266
12267 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12268 lex_operator, push_back>: New methods.
12269 Update all rules.
12270 (rust_parser::lex_hex, lex_escape): Rename and update.
12271 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12272 (rust_parser::lex_operator): Rename and update.
12273 (rust_parser::lex_number, rustyylex, rustyyerror)
12274 (rust_lex_test_init, rust_lex_test_sequence)
12275 (rust_lex_test_push_back, rust_lex_tests): Update.
12276 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12277 parameter.
12278 <lexptr, prev_lexptr>: New members.
12279 (lexptr, prev_lexptr): Don't declare.
12280 * parse.c (lexptr, prev_lexptr): Remove globals.
12281 (parse_exp_in_context): Update.
12282 * p-exp.y (yylex, yyerror): Update.
12283 * m2-exp.y (parse_number, yylex, yyerror): Update.
12284 * go-exp.y (lex_one_token, yyerror): Update.
12285 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12286 * d-exp.y (lex_one_token, yyerror): Update.
12287 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12288 (lex_one_token, yyerror): Update.
12289 * ada-lex.l (YY_INPUT): Update.
12290 (rewind_to_char): Update.
12291 * ada-exp.y (yyerror): Update.
12292
12293 2019-04-04 Tom Tromey <tom@tromey.com>
12294
12295 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12296 * parser-defs.h (struct parser_state) <parser_state>: Add new
12297 parameter.
12298 <comma_terminates>: New member.
12299 (comma_terminates): Don't declare global.
12300 * parse.c (comma_terminates): Remove global.
12301 (parse_exp_in_context): Update.
12302 * p-exp.y (yylex): Update.
12303 * m2-exp.y (yylex): Update.
12304 * go-exp.y (lex_one_token): Update.
12305 * f-exp.y (yylex): Update.
12306 * d-exp.y (lex_one_token): Update.
12307 * c-exp.y (lex_one_token): Update.
12308 * ada-lex.l: Update.
12309
12310 2019-04-04 Tom Tromey <tom@tromey.com>
12311
12312 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12313 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12314 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12315 * parser-defs.h (paren_depth): Don't declare.
12316 * parse.c (paren_depth): Remove global.
12317 (parse_exp_in_context): Update.
12318 * p-exp.y (paren_depth): New global.
12319 (pascal_parse): Initialize it.
12320 * m2-exp.y (paren_depth): New global.
12321 (m2_parse): Initialize it.
12322 * go-exp.y (paren_depth): New global.
12323 (go_parse): Initialize it.
12324 * f-exp.y (paren_depth): New global.
12325 (f_parse): Initialize it.
12326 * d-exp.y (paren_depth): New global.
12327 (d_parse): Initialize it.
12328 * c-exp.y (paren_depth): New global.
12329 (c_parse): Initialize it.
12330 * ada-lex.l (paren_depth): New global.
12331 (lexer_init): Initialize it.
12332
12333 2019-04-04 Tom Tromey <tom@tromey.com>
12334
12335 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12336 (rust_parser::convert_ast_to_type)
12337 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12338 * parser-defs.h (struct parser_state) <parser_state>: Add
12339 parameters. Initialize new members.
12340 <expression_context_block, expression_context_pc>: New members.
12341 * parse.c (expression_context_block, expression_context_pc):
12342 Remove globals.
12343 (parse_exp_in_context): Update.
12344 * p-exp.y: Update all rules.
12345 (yylex): Update.
12346 * m2-exp.y: Update all rules.
12347 (yylex): Update.
12348 * go-exp.y (yylex): Update.
12349 * f-exp.y (yylex): Update.
12350 * d-exp.y: Update all rules.
12351 (yylex): Update.
12352 * c-exp.y: Update all rules.
12353 (lex_one_token, classify_name, yylex, c_parse): Update.
12354 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12355
12356 2019-04-04 Tom Tromey <tom@tromey.com>
12357
12358 * gdbarch.h, gdbarch.c: Rebuild.
12359 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12360 * stap-probe.h:
12361 (struct stap_parse_info): Replace "parser_state" with
12362 "expr_builder".
12363 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12364 (parser_state): New class.
12365 * parse.c (expr_builder): Rename.
12366 (expr_builder::release): Rename.
12367 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12368 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12369 (write_exp_elt_longcst, write_exp_elt_floatcst)
12370 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12371 (write_exp_string_vector, write_exp_bitstring)
12372 (write_exp_msymbol, mark_struct_expression)
12373 (write_dollar_variable)
12374 (insert_type_address_space, increase_expout_size): Replace
12375 "parser_state" with "expr_builder".
12376 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12377 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12378 "parser_state" with "expr_builder".
12379
12380 2019-04-04 Tom Tromey <tom@tromey.com>
12381
12382 * rust-exp.y: Replace "parse_language" with method call.
12383 * p-exp.y:
12384 (yylex): Replace "parse_language" with method call.
12385 * m2-exp.y:
12386 (yylex): Replace "parse_language" with method call.
12387 * go-exp.y (classify_name): Replace "parse_language" with method
12388 call.
12389 * f-exp.y (yylex): Replace "parse_language" with method call.
12390 * d-exp.y (lex_one_token): Replace "parse_language" with method
12391 call.
12392 * c-exp.y:
12393 (lex_one_token, classify_name, yylex): Replace "parse_language"
12394 with method call.
12395 * ada-exp.y (find_primitive_type, type_char)
12396 (type_system_address): Replace "parse_language" with method call.
12397
12398 2019-04-04 Tom Tromey <tom@tromey.com>
12399
12400 * rust-exp.y: Replace "parse_gdbarch" with method call.
12401 * parse.c (write_dollar_variable, insert_type_address_space):
12402 Replace "parse_gdbarch" with method call.
12403 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12404 call.
12405 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12406 call.
12407 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12408 "parse_gdbarch" with method call.
12409 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12410 with method call.
12411 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12412 "parse_gdbarch" with method call.
12413 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12414 "parse_gdbarch" with method call.
12415 * c-exp.y (parse_type, parse_number, classify_name): Replace
12416 "parse_gdbarch" with method call.
12417 * ada-lex.l: Replace "parse_gdbarch" with method call.
12418 * ada-exp.y (parse_type, find_primitive_type, type_char)
12419 (type_system_address): Replace "parse_gdbarch" with method call.
12420
12421 2019-04-04 Tom Tromey <tom@tromey.com>
12422
12423 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12424 * stap-probe.c (stap_parse_argument): Update.
12425 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12426 initial_size parameter.
12427 * rust-exp.y (rust_lex_tests): Update.
12428 * parse.c (parser_state): Update.
12429 (parse_exp_in_context): Update.
12430 * parser-defs.h (struct parser_state) <parser_state>: Remove
12431 "initial_size" parameter.
12432
12433 2019-04-04 Tom Tromey <tom@tromey.com>
12434
12435 * parser-defs.h (increase_expout_size): Don't declare.
12436 * parse.c (increase_expout_size): Now static.
12437
12438 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12439
12440 * gnu-nat.c (gnu_nat_target::wait): Fix
12441 target_waitstatus_to_string call.
12442
12443 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12444
12445 * eval.c (evaluate_subexp_standard): Handle internal functions
12446 during Fortran function call handling.
12447
12448 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12449
12450 * NEWS: Mention new internal functions.
12451 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12452 (read_base_type): Use dwarf2_init_complex_target_type.
12453 * value.c (creal_internal_fn): New function.
12454 (cimag_internal_fn): New function.
12455 (_initialize_values): Register new internal functions.
12456
12457 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12458
12459 * infrun.c (stop_all_threads): If debug_infrun, always
12460 trace the wait status after wait_one, using
12461 target_waitstatus_to_string and target_pid_to_str.
12462 (handle_inferior_event): Replace various trace of
12463 wait status kind by a single trace.
12464 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12465 wait status kind image by target_waitstatus_to_string.
12466 * target/waitstatus.c (target_waitstatus_to_string): Fix
12467 obsolete comment.
12468
12469 2019-04-01 Tom Tromey <tromey@adacore.com>
12470
12471 PR symtab/23331:
12472 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12473
12474 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12475 Pedro Alves <palves@redhat.com>
12476
12477 * top.c (quit_force): Call 'finalize_values'.
12478 * value.c (finalize_values): New function.
12479 * value.h (finalize_values): Declare.
12480
12481 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12482
12483 * NEWS: Announce $_gdb_major and $_gdb_minor.
12484
12485 * top.c (init_gdb_version_vars): New function.
12486 (gdb_init): Call init_gdb_version_vars.
12487
12488 2019-03-29 Tom Tromey <tromey@adacore.com>
12489
12490 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12491 help text. Remove dead code.
12492
12493 2019-03-29 Keith Seitz <keiths@redhat.com>
12494
12495 From Siddhesh Poyarekar:
12496 * f-lang.h (f77_get_upperbound): Return LONGEST.
12497 (f77_get_lowerbound): Likewise.
12498 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12499 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12500 print them.
12501 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12502 plongest to format print it.
12503 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12504 (f77_get_upperbound): Likewise.
12505 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12506 LOWER_BOUND to LONGEST.
12507 (f77_create_arrayprint_offset_tbl): Likewise.
12508
12509 2019-03-29 Keith Seitz <keiths@redhat.com>
12510
12511 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12512 %s/pulongest for TYPE_LENGTH instead of %d in format
12513 strings.
12514 * ada-typerint.c (ada_print_type): Likewise.
12515 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12516 * compile/compile-c-support.c (generate_register_struct): Likewise.
12517 * gdbtypes.c (recursive_dump_type): Likewise.
12518 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12519 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12520 instead of %d in format strings.
12521 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12522 to std::min to ULONGEST.
12523 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12524 instead of %d in format strings.
12525 * tracepoint.c (info_scope_command): Likewise.
12526 * typeprint.c (print_offset_data::update)
12527 (print_offset_data::finish): Likewise.
12528 * xtensa-tdep.c (xtensa_store_return_value)
12529 (xtensa_push_dummy_call): Likewise.
12530
12531 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12532
12533 * windows-nat.c (display_selector): Fixed format specifications
12534 for 64-bit Cygwin.
12535
12536 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12537
12538 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12539
12540 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12541
12542 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12543 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12544 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12545 (nios2_linux_init_abi): Install it.
12546
12547 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12548
12549 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12550
12551 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12552
12553 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12554
12555 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12556 Tom Tromey <tromey@adacore.com>
12557
12558 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12559
12560 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12561
12562 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12563 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12564 method to compute the bounds of range types. Also print "[evaluated]"
12565 if the bounds' values come from a dynamic evaluation.
12566
12567 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12568
12569 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12570 whitespace when pretty printing is on.
12571
12572 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12573
12574 * ppc-linux-nat.c: Add include.
12575
12576 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12577
12578 * NEWS: Mention AArch64 Pointer Authentication.
12579
12580 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12581
12582 * arm-linux-nat.c: Add include.
12583
12584 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12585
12586 * source-cache.c (source_cache::get_source_lines): Re-read
12587 fullname after calling open_source_file.
12588
12589 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12590
12591 * NEWS: Mention TLS support for FreeBSD.
12592
12593 2019-03-25 Tom Tromey <tromey@adacore.com>
12594
12595 * minsyms.c (BUNCH_SIZE): Update comment.
12596 (~minimal_symbol_reader): Remove old comment.
12597 (compact_minimal_symbols): Update comment.
12598 (minimal_symbol_reader::install): Remove old comment. Update
12599 other comments.
12600
12601 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12602
12603 * s390-linux-nat.c: Add include.
12604
12605 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12606
12607 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12608 Call linux_get_hwcap.
12609 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12610 Likewise.
12611 (aarch64_linux_get_hwcap): Remove function.
12612 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12613 declaration.
12614 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12615 linux_get_hwcap.
12616 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12617 * linux-tdep.c (linux_get_hwcap): Add function.
12618 (linux_get_hwcap2): Likewise.
12619 * linux-tdep.h (linux_get_hwcap): Add declaration.
12620 (linux_get_hwcap2): Likewise.
12621 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12622 (ppc_linux_get_hwcap2): Likewise.
12623 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12624 linux_get_hwcap.
12625 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12626 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12627 (ppc_linux_nat_target::read_description): Likewise.
12628 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12629 * s390-linux-nat.c: Likewise.
12630 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12631
12632 2019-03-24 Tom Tromey <tom@tromey.com>
12633
12634 * ada-lang.c (standard_lookup): Simplify initialization.
12635 (ada_lookup_symbol_nonlocal): Simplify return.
12636 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12637 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12638 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12639 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12640 initialization.
12641 * solib.c (solib_global_lookup): Simplify.
12642 * symtab.c (null_block_symbol): Remove.
12643 (symbol_cache_lookup): Simplify returns.
12644 (lookup_language_this): Simplify returns.
12645 (lookup_symbol_aux): Simplify return.
12646 (lookup_local_symbol): Simplify returns.
12647 (lookup_global_symbol_from_objfile): Simplify return.
12648 (lookup_symbol_in_objfile_symtabs)
12649 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12650 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12651 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12652 * cp-namespace.c (cp_lookup_bare_symbol)
12653 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12654 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12655 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12656 (cp_lookup_symbol_via_imports): Simplify initialization.
12657 (find_symbol_in_baseclass): Likewise.
12658 * symtab.h (null_block_symbol): Remove.
12659 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12660 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12661 (d_lookup_symbol_module): Likewise.
12662 (find_symbol_in_baseclass): Simplify initialization.
12663
12664 2019-03-24 Tom Tromey <tom@tromey.com>
12665
12666 * expression.h: Don't include symtab.h.
12667 (struct block): Forward declare.
12668
12669 2019-03-24 Tom Tromey <tom@tromey.com>
12670
12671 * c-exp.y (typebase): Remove casts.
12672 * gdbtypes.c (lookup_unsigned_typename, )
12673 (lookup_signed_typename): Remove cast.
12674 * eval.c (parse_to_comma_and_eval): Remove cast.
12675 * parse.c (write_dollar_variable): Remove cast.
12676 * block.h (struct block) <superblock>: Now const.
12677 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12678 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12679 (map_block): Make "block" const.
12680 * symfile.h (struct quick_symbol_functions)
12681 <map_matching_symbols>: Constify block argument to "callback".
12682 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12683 const.
12684 (find_pc_sect_compunit_symtab): Make "b" const.
12685 (find_symbol_at_address): Likewise.
12686 (search_symbols): Likewise.
12687 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12688 (dw2_debug_names_lookup_symbol): Likewise.
12689 (dw2_map_matching_symbols): Update.
12690 * p-valprint.c (pascal_val_print): Remove "block".
12691 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12692 (aux_add_nonlocal_symbols): Make "block" const.
12693 (resolve_subexp): Remove cast.
12694 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12695 const.
12696 (iterate_over_file_blocks): Likewise.
12697 * f-exp.y (%union) <bval>: Remove.
12698 * coffread.c (patch_opaque_types): Make "b" const.
12699 * spu-tdep.c (spu_catch_start): Make "block" const.
12700 * c-valprint.c (print_unpacked_pointer): Remove "block".
12701 * symmisc.c (dump_symtab_1): Make "b" const.
12702 (block_depth): Make "block" const.
12703 * d-exp.y (%union) <bval>: Remove.
12704 * cp-support.h (cp_lookup_rtti_type): Update.
12705 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12706 * psymtab.c (psym_lookup_symbol): Make "block" const.
12707 (maintenance_check_psymtabs): Make "b" const.
12708 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12709 (enumerate_locals, enumerate_args): Update.
12710 * python/py-symtab.c (stpy_global_block): Make "block" const.
12711 (stpy_static_block): Likewise.
12712 * inline-frame.c (block_starting_point_at): Make "new_block"
12713 const.
12714 * block.c (find_block_in_blockvector): Make return type const.
12715 (blockvector_for_pc_sect): Make "b" const.
12716 (find_block_in_blockvector): Make "b" const.
12717
12718 2019-03-23 Tom Tromey <tom@tromey.com>
12719
12720 * varobj.c (varobj_create): Update.
12721 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12722 * printcmd.c (display_command, do_one_display): Don't reset
12723 innermost_block.
12724 * parser-defs.h (enum innermost_block_tracker_type): Move to
12725 expression.h.
12726 (innermost_block): Update comment.
12727 * parse.c (parse_exp_1): Add tracker_types parameter.
12728 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12729 tracker_types parameter. Reset innermost_block.
12730 (parse_exp_in_context): Remove.
12731 (parse_expression_for_completion): Update.
12732 * objfiles.c (~objfile): Don't reset expression_context_block or
12733 innermost_block.
12734 * expression.h (enum innermost_block_tracker_type): Move from
12735 parser-defs.h.
12736 (parse_exp_1): Add tracker_types parameter.
12737 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12738 reset innermost_block.
12739
12740 2019-03-23 Tom Tromey <tom@tromey.com>
12741
12742 * objfiles.h: Include bcache.h.
12743
12744 2019-03-23 Tom Tromey <tom@tromey.com>
12745
12746 * linespec.c (get_current_search_block): Use
12747 scoped_restore_current_language.
12748 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12749
12750 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12751 Jiong Wang <jiong.wang@arm.com>
12752
12753 * aarch64-linux-tdep.c
12754 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12755 section.
12756 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12757
12758 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12759 Jiong Wang <jiong.wang@arm.com>
12760
12761 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12762 instructions.
12763 (aarch64_analyze_prologue_test): Add PACIASP test.
12764 (aarch64_prologue_prev_register): Unmask PC value.
12765
12766 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12767 Jiong Wang <jiong.wang@arm.com>
12768
12769 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12770 (aarch64_dwarf2_prev_register): Unmask PC value.
12771 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12772 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12773 DW_CFA_AARCH64_negate_ra_state.
12774 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12775
12776 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12777 Jiong Wang <jiong.wang@arm.com>
12778
12779 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12780 registers.
12781 (aarch64_pseudo_register_name): Likewise.
12782 (aarch64_pseudo_register_type): Likewise.
12783 (aarch64_pseudo_register_reggroup_p): Likewise.
12784 (aarch64_gdbarch_init): Add pauth registers.
12785 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12786 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12787 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12788 (struct gdbarch_tdep): Add regnum for ra_state.
12789
12790 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12791 Jiong Wang <jiong.wang@arm.com>
12792
12793 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12794
12795 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12796 Jiong Wang <jiong.wang@arm.com>
12797
12798 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12799 function.
12800 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12801 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12802 (aarch64_gdbarch_init): Add puth registers.
12803 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12804 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12805 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12806
12807 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12808 Jiong Wang <jiong.wang@arm.com>
12809
12810 * aarch64-linux-nat.c
12811 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12812 * aarch64-linux-tdep.c
12813 (aarch64_linux_core_read_description): Likewise.
12814 (aarch64_linux_get_hwcap): New function.
12815 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12816 (aarch64_linux_get_hwcap): New declaration.
12817
12818 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12819 Jiong Wang <jiong.wang@arm.com>
12820
12821 * aarch64-linux-nat.c
12822 (aarch64_linux_nat_target::read_description): Add pauth param.
12823 * aarch64-linux-tdep.c
12824 (aarch64_linux_core_read_description): Likewise.
12825 * aarch64-tdep.c (struct target_desc): Add in pauth.
12826 (aarch64_read_description): Add pauth param.
12827 (aarch64_gdbarch_init): Likewise.
12828 * aarch64-tdep.h (aarch64_read_description): Likewise.
12829 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12830 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12831 * features/Makefile: Add new files.
12832 * features/aarch64-pauth.c: New file.
12833 * features/aarch64-pauth.xml: New file.
12834
12835 2019-03-20 Tom Tromey <tromey@adacore.com>
12836
12837 * infrun.c (handle_inferior_event): Rename from
12838 handle_inferior_event_1. Create a scoped_value_mark.
12839 (handle_inferior_event): Remove.
12840
12841 2019-03-19 Tom Tromey <tromey@adacore.com>
12842
12843 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12844 * infrun.h (print_stop_event): Add "displays" parameter.
12845 * infrun.c (print_stop_event): Add "displays" parameter.
12846
12847 2019-03-19 Pedro Alves <palves@redhat.com>
12848
12849 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12850 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12851 to -1. Fix TABs vs spaces.
12852 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12853 * tui/tui-out.h (tui_ui_out) Add intro comments.
12854 <m_line, m_start_of_line>: In-class initialize, and add describing
12855 comment.
12856
12857 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12858
12859 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12860 variable names.
12861 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12862
12863 2019-03-18 Pedro Alves <palves@redhat.com>
12864 Eli Zaretskii <eliz@gnu.org>
12865
12866 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12867 m_line and m_start_of_line.
12868
12869 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12870
12871 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12872 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12873 it returns a newline. This fixes a regression in TU mode, whereby
12874 the next line is output on the same screen line as the user input.
12875
12876 2019-03-18 Tom Tromey <tromey@adacore.com>
12877
12878 * minsyms.c (minimal_symbol_reader::install): Remove call to
12879 obstack_blank.
12880
12881 2019-03-18 Pedro Alves <palves@redhat.com>
12882
12883 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12884 New globals.
12885 (apply_style): New, factored out from ...
12886 (apply_ansi_escape): ... this. Handle reverse video mode.
12887 (tui_set_reverse_mode): New function.
12888 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12889 * tui/tui-winsource.c (tui_show_source_line): Use
12890 tui_set_reverse_mode instead of setting A_STANDOUT.
12891 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12892 New setter methods.
12893
12894 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12895
12896 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12897 Handle tabs.
12898
12899 2019-03-18 Tom Tromey <tromey@adacore.com>
12900
12901 * ada-lang.c (empty_array): Add "high" parameter.
12902 (ada_evaluate_subexp): Update.
12903
12904 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12905
12906 * unittests/string_view-selftests.c: Define
12907 _initialize_string_view_selftests unconditionally.
12908
12909 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12910
12911 PR gdb/24350
12912 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12913
12914 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12915
12916 PR gdb/24351
12917 * windows-nat.c (display_selector): Fix format specifiers.
12918
12919 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12920
12921 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12922 tui_refill_source_window instead of tui_refresh_win, to update the
12923 current execution line. This fixes redisplay of the current line
12924 when stepping through the code with "next" or "step".
12925
12926 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12927
12928 * source-cache.c (source_cache::get_source_lines): Call
12929 find_source_lines to initialize s->nlines. This fixes vertical
12930 scrolling of TUI source window when the DOWN arrow is pressed.
12931
12932 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12933
12934 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12935 linux-thread-db.c (_initialize_thread_db): Likewise.
12936
12937 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12938
12939 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12940 wclrtoeol in tui_show_source_line". This reverts changes made in
12941 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12942
12943 2019-03-15 Tom Tromey <tom@tromey.com>
12944
12945 * symtab.h (struct minimal_symbol): Derive from
12946 general_symbol_info.
12947 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12948 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12949 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12950 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12951 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12952 (MSYMBOL_SEARCH_NAME): Update.
12953 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12954 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12955 * minsyms.c (minimal_symbol_reader::record_full): Update.
12956
12957 2019-03-15 Tom Tromey <tom@tromey.com>
12958
12959 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12960
12961 2019-03-15 Tom Tromey <tom@tromey.com>
12962
12963 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12964 unique_xmalloc_ptr.
12965 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12966 Update.
12967 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12968 (build_minimal_symbol_hash_tables)
12969 (minimal_symbol_reader::install): Update.
12970
12971 2019-03-15 Tom Tromey <tom@tromey.com>
12972
12973 * symtab.c (create_demangled_names_hash): Update.
12974 (symbol_set_names): Update.
12975 * objfiles.h (struct objfile_per_bfd_storage)
12976 <demangled_names_hash>: Now an htab_up.
12977 * objfiles.c (objfile_per_bfd_storage): Simplify.
12978
12979 2019-03-15 Tom Tromey <tom@tromey.com>
12980
12981 * objfiles.h (struct objfile_per_bfd_storage): Declare
12982 destructor.
12983 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12984 New.
12985 (get_objfile_bfd_data): Use new. Don't initialize
12986 language_of_main.
12987 (free_objfile_per_bfd_storage): Remove.
12988 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12989
12990 2019-03-15 Tom Tromey <tom@tromey.com>
12991
12992 * symfile.c (reread_symbols): Update.
12993 * objfiles.c (objfile::objfile): Update.
12994 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12995 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12996 comment.
12997 (minimal_symbol_reader::install): Update.
12998 (terminate_minimal_symbol_table): Remove.
12999 * jit.c (jit_object_close_impl): Update.
13000
13001 2019-03-15 Tom Tromey <tom@tromey.com>
13002
13003 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13004 initializations.
13005
13006 2019-03-15 Tom Tromey <tom@tromey.com>
13007
13008 * objfiles.h (struct objfile_per_bfd_storage)
13009 <demangled_hash_languages>: Now a bitset.
13010 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13011 (lookup_minimal_symbol): Update.
13012
13013 2019-03-15 Tom Tromey <tom@tromey.com>
13014
13015 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13016 Don't return the symbol.
13017 * coffread.c (record_minimal_symbol): Use record_full.
13018
13019 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13020
13021 The MS-Windows port of ncurses fails to switch to a color pair if
13022 one or both of the colors are the implicit default colors. This
13023 change records the default colors when TUI is initialized, and
13024 then specifies them explicitly when a color pair uses the default
13025 colors. This allows color styling in TUI mode on MS-Windows.
13026
13027 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13028 ncurses_norm_attr.
13029 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13030 colors in ncurses_norm_attr.
13031 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13032 "none", replace it with the default color recorded in
13033 ncurses_norm_attr.
13034
13035 2019-03-14 Tom Tromey <tromey@adacore.com>
13036
13037 * source-cache.h (class source_cache) <get_source_lines>: Return
13038 std::string.
13039 * source-cache.c (source_cache::extract_lines): Handle case where
13040 first_pos==npos. Return std::string.
13041 (source_cache::get_source_lines): Update.
13042
13043 2019-03-14 Tom Tromey <tromey@adacore.com>
13044
13045 * NEWS: Add item for "style sources" commands.
13046 * source-cache.c (source_cache::get_source_lines): Check
13047 source_styling.
13048 * cli/cli-style.c (source_styling): New global.
13049 (_initialize_cli_style): Add "style sources" commands.
13050 (show_style_sources): New function.
13051 * cli/cli-style.h (source_styling): Declare.
13052
13053 2019-03-14 Pedro Alves <palves@redhat.com>
13054 Tom Tromey <tromey@adacore.com>
13055
13056 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13057 * tui/tui-winsource.c (tui_refill_source_window): New function,
13058 from...
13059 (tui_horizontal_source_scroll): ... here. Move some logic.
13060 * cli/cli-style.c (set_style_enabled): Notify new observable.
13061 * tui/tui-hooks.c (tui_redisplay_source): New function.
13062 (tui_attach_detach_observers): Attach or detach
13063 tui_redisplay_source.
13064 * observable.h (source_styling_changed): New observable.
13065 * observable.c: Define source_styling_changed observable.
13066
13067 2019-03-13 Tom Tromey <tromey@adacore.com>
13068
13069 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13070 (i386_gnu_nat_target::store_registers): Update.
13071 * target-debug.h (target_debug_print_std_string): New macro.
13072 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13073 * windows-tdep.c (display_one_tib): Update.
13074 * tui/tui-stack.c (tui_make_status_line): Update.
13075 * top.c (print_inferior_quit_action): Update.
13076 * thread.c (thr_try_catch_cmd): Update.
13077 (add_thread_with_info): Update.
13078 (thread_target_id_str): Update.
13079 (thr_try_catch_cmd): Update.
13080 (thread_command): Update.
13081 (thread_find_command): Update.
13082 * record-btrace.c (record_btrace_target::info_record)
13083 (record_btrace_resume_thread, record_btrace_target::resume)
13084 (record_btrace_cancel_resume, record_btrace_step_thread)
13085 (record_btrace_target::wait, record_btrace_target::wait)
13086 (record_btrace_target::wait, record_btrace_target::stop): Update.
13087 * progspace.c (print_program_space): Update.
13088 * process-stratum-target.c
13089 (process_stratum_target::thread_address_space): Update.
13090 * linux-fork.c (linux_fork_mourn_inferior)
13091 (detach_checkpoint_command, info_checkpoints_command)
13092 (linux_fork_context): Update.
13093 (linux_fork_detach): Update.
13094 (class scoped_switch_fork_info): Update.
13095 (delete_checkpoint_command): Update.
13096 * infrun.c (follow_fork_inferior): Update.
13097 (follow_fork_inferior): Update.
13098 (proceed_after_vfork_done): Update.
13099 (handle_vfork_child_exec_or_exit): Update.
13100 (follow_exec): Update.
13101 (displaced_step_prepare_throw): Update.
13102 (displaced_step_restore): Update.
13103 (start_step_over): Update.
13104 (resume_1): Update.
13105 (clear_proceed_status_thread): Update.
13106 (proceed): Update.
13107 (print_target_wait_results): Update.
13108 (do_target_wait): Update.
13109 (context_switch): Update.
13110 (stop_all_threads): Update.
13111 (restart_threads): Update.
13112 (finish_step_over): Update.
13113 (handle_signal_stop): Update.
13114 (switch_back_to_stepped_thread): Update.
13115 (keep_going_pass_signal): Update.
13116 (print_exited_reason): Update.
13117 (normal_stop): Update.
13118 * inferior.c (inferior_pid_to_str): Change return type.
13119 (print_selected_inferior): Update.
13120 (add_inferior): Update.
13121 (detach_inferior): Update.
13122 * dummy-frame.c (fprint_dummy_frames): Update.
13123 * dcache.c (dcache_info_1): Update.
13124 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13125 (btrace_fetch, btrace_clear): Update.
13126 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13127 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13128 type.
13129 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13130 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13131 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13132 * gdbarch.c, gdbarch.h: Rebuild.
13133 * gdbarch.sh (core_pid_to_str): Change return type.
13134 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13135 return type.
13136 (windows_nat_target::pid_to_str): Change return type.
13137 (windows_delete_thread): Update.
13138 (windows_nat_target::attach): Update.
13139 (windows_nat_target::files_info): Update.
13140 * target-delegates.c: Rebuild.
13141 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13142 return type.
13143 (sol_thread_target::pid_to_str): Change return type.
13144 * remote.c (class remote_target) <pid_to_str>: Change return
13145 type.
13146 (remote_target::pid_to_str): Change return type.
13147 (extended_remote_target::attach, remote_target::remote_stop_ns)
13148 (remote_target::remote_notif_remove_queued_reply)
13149 (remote_target::push_stop_reply, remote_target::disable_btrace):
13150 Update.
13151 (extended_remote_target::attach): Update.
13152 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13153 type.
13154 (gdbsim_target::pid_to_str): Change return type.
13155 * ravenscar-thread.c (struct ravenscar_thread_target)
13156 <pid_to_str>: Change return type.
13157 (ravenscar_thread_target::pid_to_str): Change return type.
13158 * procfs.c (class procfs_target) <pid_to_str>: Change return
13159 type.
13160 (procfs_target::pid_to_str): Change return type.
13161 (procfs_target::attach): Update.
13162 (procfs_target::detach): Update.
13163 (procfs_target::fetch_registers): Update.
13164 (procfs_target::store_registers): Update.
13165 (procfs_target::wait): Update.
13166 (procfs_target::files_info): Update.
13167 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13168 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13169 return type.
13170 (nto_procfs_target::pid_to_str): Change return type.
13171 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13172 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13173 return type.
13174 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13175 (exit_lwp): Update.
13176 (attach_proc_task_lwp_callback, get_detach_signal)
13177 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13178 (linux_nat_target::resume, wait_lwp, stop_callback)
13179 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13180 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13181 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13182 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13183 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13184 type.
13185 (inf_ptrace_target::attach): Update.
13186 (inf_ptrace_target::files_info): Update.
13187 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13188 type.
13189 (go32_nat_target::pid_to_str): Change return type.
13190 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13191 (gnu_nat_target::wait): Update.
13192 (gnu_nat_target::wait): Update.
13193 (gnu_nat_target::resume): Update.
13194 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13195 (fbsd_nat_target::wait): Update.
13196 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13197 type.
13198 (darwin_nat_target::attach): Update.
13199 * corelow.c (class core_target) <pid_to_str>: Change return type.
13200 (core_target::pid_to_str): Change return type.
13201 * target.c (normal_pid_to_str): Change return type.
13202 (default_pid_to_str): Likewise.
13203 (target_pid_to_str): Change return type.
13204 (target_translate_tls_address): Update.
13205 (target_announce_detach): Update.
13206 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13207 return type.
13208 (bsd_uthread_target::pid_to_str): Change return type.
13209 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13210 type.
13211 (bsd_kvm_target::pid_to_str): Change return type.
13212 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13213 return type.
13214 (aix_thread_target::pid_to_str): Change return type.
13215 * target.h (struct target_ops) <pid_to_str>: Change return type.
13216 (target_pid_to_str, normal_pid_to_str): Likewise.
13217 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13218 type.
13219 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13220 type.
13221 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13222 return type.
13223 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13224 type.
13225 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13226 type.
13227 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13228 return type.
13229
13230 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13231
13232 * NEWS: Mention that the new default MI version is 3. Mention
13233 changes to the output of commands and events that deal with
13234 multi-location breakpoints.
13235 * breakpoint.c: Include "mi/mi-out.h".
13236 (print_one_breakpoint): Change output syntax if using MI version
13237 >= 3.
13238 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13239 New.
13240 (mi_multi_location_breakpoint_output_fixed): New.
13241 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13242 (mi_cmd_fix_multi_location_breakpoint_output): New.
13243 (mi_multi_location_breakpoint_output_fixed): New.
13244 * mi/mi-cmds.c (mi_cmds): Register command
13245 -fix-multi-location-breakpoint-output.
13246 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13247 interpreter "mi".
13248
13249 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13250
13251 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13252 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13253 instantiate mi_ui_out based on interpreter name.
13254 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13255 * mi/mi-main.c (mi_load_progress): Likewise.
13256
13257 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13258
13259 * NEWS: Combine separate "New targets" sections for 8.3.
13260
13261 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13262
13263 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13264 (ppcfbsd_init_abi): Install gdbarch
13265 "fetch_tls_load_module_address" and "get_thread_local_address"
13266 methods.
13267
13268 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13269
13270 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13271 (riscv_fbsd_init_abi): Install gdbarch
13272 "fetch_tls_load_module_address" and "get_thread_local_address"
13273 methods.
13274
13275 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13276
13277 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13278 (i386fbsd_init_abi): Install gdbarch
13279 "fetch_tls_load_module_address" and "get_thread_local_address"
13280 methods.
13281
13282 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13283
13284 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13285 (amd64fbsd_init_abi): Install gdbarch
13286 "fetch_tls_load_module_address" and "get_thread_local_address"
13287 methods.
13288
13289 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13290
13291 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13292 (struct fbsd_pspace_data): New type.
13293 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13294 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13295 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13296 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13297 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13298
13299 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13300
13301 * gdbtypes.c (lookup_struct_elt): New function.
13302 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13303 * gdbtypes.h (struct struct_elt): New type.
13304 (lookup_struct_elt): New prototype.
13305
13306 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13307
13308 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13309 remove disabled code block.
13310
13311 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13312
13313 * gdbarch.sh (get_thread_local_address): New method.
13314 * gdbarch.h, gdbarch.c: Regenerate.
13315 * target.c (target_translate_tls_address): Use
13316 gdbarch_get_thread_local_address if present instead of
13317 target::get_thread_local_address.
13318
13319 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13320
13321 * target.h (target::get_thread_local_address): Update comment.
13322
13323 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13324
13325 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13326 objfile->separate_debug_objfile_backlink if not NULL.
13327
13328 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13329
13330 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13331 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13332 (amd64bsd_store_inferior_registers): Likewise.
13333 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13334 Enable segment base registers.
13335 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13336 PT_GETFSBASE and PT_GETGSBASE.
13337 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13338 PT_SETGSBASE.
13339 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13340 segment base registers.
13341 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13342
13343 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13344
13345 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13346 Update calls to i386_target_description to add 'segments'
13347 parameter.
13348 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13349 add segment base registers.
13350 * arch/i386.c (i386_create_target_description): Add 'segments'
13351 parameter to enable segment base registers.
13352 * arch/i386.h (i386_create_target_description): Likewise.
13353 * features/i386/32bit-segments.xml: New file.
13354 * features/i386/32bit-segments.c: Generate.
13355 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13356 call to i386_target_description to add 'segments' parameter.
13357 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13358 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13359 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13360 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13361 if feature is present.
13362 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13363 Add 'segments' parameter to call to i386_target_description.
13364 (i386_target_description): Add 'segments' parameter to enable
13365 segment base registers.
13366 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13367 to call to i386_target_description.
13368 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13369 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13370 Define I386_NUM_REGS.
13371 (i386_target_description): Add 'segments' parameter to enable
13372 segment base registers.
13373
13374 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13375
13376 PR/24325
13377 * source-cache.c: #undef open and close, to avoid unresolved
13378 externals during linking.
13379
13380 2019-03-12 Tom Tromey <tromey@adacore.com>
13381
13382 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13383 const. Add initializers.
13384 (_initialize_remote): Don't initialize ptid globals.
13385
13386 2019-03-12 Pedro Alves <palves@redhat.com>
13387
13388 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13389
13390 2019-03-12 Pedro Alves <palves@redhat.com>
13391
13392 * cp-name-parser.y (main): Remove unused 'len' variable.
13393
13394 2019-03-12 Tom Tromey <tromey@adacore.com>
13395
13396 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13397 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13398
13399 2019-03-12 Tom Tromey <tromey@adacore.com>
13400
13401 * linux-nat.c (iterate_over_lwps): Update.
13402 (stop_callback): Remove parameter.
13403 (stop_wait_callback, detach_callback, resume_set_callback)
13404 (select_singlestep_lwp_callback, set_ignore_sigint)
13405 (status_callback, resumed_callback, resume_clear_callback)
13406 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13407 data parameter.
13408 (linux_nat_target::detach, linux_nat_target::resume)
13409 (linux_stop_and_wait_all_lwps, select_event_lwp)
13410 (linux_nat_filter_event, linux_nat_wait_1)
13411 (linux_nat_target::kill, linux_nat_target::stop)
13412 (linux_nat_target::stop): Update.
13413 (linux_nat_resume_callback): Change type.
13414 (resume_stopped_resumed_lwps, count_events_callback)
13415 (select_event_lwp_callback): Likewise.
13416 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13417 * arm-linux-nat.c (struct update_registers_data): Remove.
13418 (update_registers_callback): Change type.
13419 (arm_linux_insert_hw_breakpoint1): Update.
13420 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13421 parameter.
13422 (x86_linux_dr_set_addr): Update.
13423 (x86_linux_dr_set_control): Update.
13424 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13425 (iterate_over_lwps): Use gdb::function_view.
13426 * nat/aarch64-linux-hw-point.c (struct
13427 aarch64_dr_update_callback_param): Remove.
13428 (debug_reg_change_callback): Change type.
13429 (aarch64_notify_debug_reg_change): Update.
13430 * s390-linux-nat.c (s390_refresh_per_info): Update.
13431
13432 2019-03-11 Tom Tromey <tromey@adacore.com>
13433
13434 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13435 redundant assignment to "this_cu".
13436
13437 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13438
13439 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13440
13441 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13442
13443 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13444 from...
13445 (rank_one_type): ... this.
13446
13447 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13448
13449 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13450 from...
13451 (rank_one_type): ... this.
13452
13453 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13454
13455 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13456 from...
13457 (rank_one_type): ... this.
13458
13459 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13460
13461 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13462 from...
13463 (rank_one_type): ... this.
13464
13465 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13466
13467 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13468 from...
13469 (rank_one_type): ... this.
13470
13471 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13472
13473 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13474 from...
13475 (rank_one_type): ... this.
13476
13477 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13478
13479 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13480 from...
13481 (rank_one_type): ... this.
13482
13483 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13484
13485 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13486 from...
13487 (rank_one_type): ... this.
13488
13489 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13490
13491 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13492 from...
13493 (rank_one_type): ... this.
13494
13495 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13496
13497 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13498 from...
13499 (rank_one_type): ... this.
13500
13501 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13502
13503 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13504 from...
13505 (rank_one_type): ... this.
13506
13507 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13508
13509 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13510 from...
13511 (rank_one_type): ... this.
13512
13513 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13514
13515 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13516 inferior-events' shows the example events.
13517
13518 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13519
13520 Support styling on native MS-Windows console
13521
13522 PR/24315
13523 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13524 on MS-Windows if $TERM is not defined.
13525
13526 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13527
13528 * posix-hdep.c (gdb_console_fputs):
13529 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13530 functions.
13531 * ui-file.h (gdb_console_fputs): Add prototype.
13532
13533 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13534 back to fputs only if the former returns zero.
13535
13536 2019-03-07 Tom Tromey <tom@tromey.com>
13537
13538 * symmisc.c (print_symbol_bcache_statistics): Update.
13539 (print_objfile_statistics): Update.
13540 * symfile.c (allocate_symtab): Update.
13541 * stabsread.c: Don't include bcache.h.
13542 * psymtab.h (struct psymbol_bcache): Don't declare.
13543 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13544 (psymbol_bcache_init, psymbol_bcache_free)
13545 (psymbol_bcache_get_bcache): Don't declare.
13546 * psymtab.c (struct psymbol_bcache): Remove.
13547 (psymtab_storage::psymtab_storage): Update.
13548 (psymtab_storage::~psymtab_storage): Update.
13549 (psymbol_bcache_init, psymbol_bcache_free)
13550 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13551 (add_psymbol_to_bcache): Update.
13552 (allocate_psymtab): Update.
13553 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13554 macro_cache>: No longer pointers.
13555 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13556 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13557 * macrotab.c (macro_bcache): Update.
13558 * macroexp.c: Don't include bcache.h.
13559 * gdbtypes.c (check_types_worklist): Update.
13560 (types_deeply_equal): Remove TRY/CATCH. Update.
13561 * elfread.c (elf_symtab_read): Update.
13562 * dwarf2read.c: Don't include bcache.h.
13563 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13564 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13565 (print_bcache_statistics, bcache_memory_used): Don't declare.
13566 (struct bcache): Move from bcache.c. Add constructor, destructor,
13567 methods. Rename all data members.
13568 * bcache.c (struct bcache): Move to bcache.h.
13569 (bcache::expand_hash_table): Rename from expand_hash_table.
13570 (bcache): Remove.
13571 (bcache::insert): Rename from bcache_full.
13572 (bcache::compare): Rename from bcache_compare.
13573 (bcache_xmalloc): Remove.
13574 (bcache::~bcache): Rename from bcache_xfree.
13575 (bcache::print_statistics): Rename from print_bcache_statistics.
13576 (bcache::memory_used): Rename from bcache_memory_used.
13577
13578 2019-03-07 Pedro Alves <palves@redhat.com>
13579
13580 * infrun.c (normal_stop): Also check for
13581 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13582
13583 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13584
13585 * f-lang.c (value_from_host_double): Moved to...
13586 * value.c (value_from_host_double): ...here.
13587 * value.h (value_from_host_double): Declare.
13588 * guile/scm-math.c (vlscm_convert_typed_number): Use
13589 value_from_host_double.
13590 (vlscm_convert_number): Likewise.
13591 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13592 * python/py-value.c (convert_value_from_python): Likewise.
13593
13594 2019-03-06 Tom Tromey <tom@tromey.com>
13595
13596 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13597
13598 2019-03-06 Tom Tromey <tom@tromey.com>
13599
13600 * utils.h (free_current_contents): Don't declare.
13601 * utils.c (free_current_contents): Remove.
13602
13603 2019-03-06 Tom Tromey <tom@tromey.com>
13604
13605 * top.c (quit_force): Update.
13606 * main.c (captured_command_loop): Update.
13607 * common/new-op.c (operator new): Update.
13608 * common/common-exceptions.c (struct catcher)
13609 <save_cleanup_chain>: Remove member.
13610 (exceptions_state_mc_init): Update.
13611 (exception_try_scope_entry): Return nullptr.
13612 (exception_try_scope_exit, exception_rethrow)
13613 (throw_exception_sjlj, throw_exception_cxx): Update.
13614 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13615 (all_cleanups, do_cleanups, discard_cleanups)
13616 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13617 (restore_cleanups, restore_final_cleanups): Don't declare.
13618 (do_final_cleanups): Remove parameter.
13619 * common/cleanups.c (cleanup_chain, make_cleanup)
13620 (make_cleanup_dtor, all_cleanups, do_cleanups)
13621 (discard_my_cleanups, discard_cleanups)
13622 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13623 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13624 (null_cleanup): Remove.
13625 (do_final_cleanups): Remove parameter.
13626
13627 2019-03-06 Tom Tromey <tom@tromey.com>
13628
13629 * remote.c (remote_target::remote_parse_stop_reply): Use
13630 unique_xmalloc_ptr.
13631
13632 2019-03-06 Tom Tromey <tom@tromey.com>
13633
13634 * stabsread.c (struct stabs_field_info): Rename from field_info.
13635 <list, fnlist>: Add initializers.
13636 <obstack>: New member.
13637 (read_member_functions, read_struct_fields, read_baseclasses):
13638 Allocate on obstack. Don't use cleanups.
13639 (read_one_struct_field, read_member_functions, read_struct_fields)
13640 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13641 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13642 (read_struct_type): Update.
13643
13644 2019-03-06 Tom Tromey <tom@tromey.com>
13645
13646 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13647 * common/filestuff.h (make_cleanup_close): Don't declare.
13648 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13649 Remove.
13650
13651 2019-03-06 Tom Tromey <tom@tromey.com>
13652
13653 * solib-aix.c: Use make_scope_exit.
13654
13655 2019-03-06 Tom Tromey <tom@tromey.com>
13656
13657 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13658 Use make_scope_exit.
13659
13660 2019-03-06 Tom Tromey <tom@tromey.com>
13661
13662 * solib-svr4.c (disable_probes_interface): Remove parameter.
13663 (svr4_handle_solib_event): Use make_scope_exit.
13664
13665 2019-03-06 Tom Tromey <tom@tromey.com>
13666
13667 * remote.c (struct stop_reply_deleter): Remove.
13668 (stop_reply_up): Update.
13669 (struct stop_reply): Derive from notif_event. Don't typedef.
13670 <regcache>: Now a std::vector.
13671 (stop_reply_xfree): Remove.
13672 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13673 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13674 (remote_target::discard_pending_stop_replies): Use delete.
13675 (remote_target::remote_parse_stop_reply): Update.
13676 (remote_target::process_stop_reply): Update.
13677 * remote-notif.h (struct notif_event): Add virtual destructor.
13678 Remove "dtr" member.
13679 (struct notif_client) <alloc_event>: Return a unique_ptr.
13680 (notif_event_xfree): Don't declare.
13681 (notif_event_up): New typedef.
13682 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13683 (notif_event_xfree, do_notif_event_xfree): Remove.
13684 (remote_notif_state_xfree): Update.
13685
13686 2019-03-06 Tom Tromey <tom@tromey.com>
13687
13688 * infrun.c (displaced_step_clear_cleanup): Now a
13689 forward_scope_exit type.
13690 (displaced_step_prepare_throw): Update.
13691 (displaced_step_fixup): Update.
13692
13693 2019-03-06 Tom Tromey <tom@tromey.com>
13694
13695 * inferior.h (class inferior): Update comment.
13696 * gdbthread.h (class thread_info): Update comment.
13697
13698 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13699 Tom Tromey <tom@tromey.com>
13700
13701 * stabsread.h (struct stab_section_list): Remove.
13702 (coffstab_build_psymtabs): Update.
13703 * dbxread.c (symbuf_sections): Now a std::vector.
13704 (sect_idx): New global.
13705 (fill_symbuf): Update.
13706 (coffstab_build_psymtabs): Change type of stabsects parameter.
13707 Update.
13708 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13709 std::vector.
13710 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13711 (coff_locate_sections): Update.
13712 (coff_symfile_read): Remove cleanups. Update.
13713 (init_stringtab): Add storage parameter.
13714 (free_stringtab, free_stringtab_cleanup): Remove.
13715 (init_lineno): Add storage parameter.
13716 (free_linetab, free_linetab_cleanup): Remove.
13717
13718 2019-03-06 Pedro Alves <palves@redhat.com>
13719
13720 * linux-fork.c (fork_info::clobber_regs): Delete.
13721 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13722 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13723 comment. Adjust.
13724 (scoped_switch_fork_info::scoped_switch_fork_info)
13725 (checkpoint_command, linux_fork_context): Adjust
13726 fork_save_infrun_state calls.
13727
13728 2019-03-06 Pedro Alves <palves@redhat.com>
13729
13730 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13731 (inf_has_multiple_threads): Return 'bool' and rewrite using
13732 inferior_info::threads().
13733
13734 2019-03-06 Pedro Alves <palves@redhat.com>
13735
13736 * linux-fork.c: Include <list>.
13737 (fork_list): Now a std::list instance.
13738 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13739 (forks_exist_p, find_last_fork): Adjust.
13740 (new_fork): Delete.
13741 (one_fork_p): New.
13742 (add_fork): Adjust.
13743 (free_fork): Delete, folded into fork_info::~fork_info().
13744 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13745 Adjust.
13746 (init_fork_list): Delete.
13747 (linux_fork_killall, linux_fork_mourn_inferior)
13748 (linux_fork_detach, info_checkpoints_command): Adjust.
13749 (_initialize_linux_fork): No longer call init_fork_list.
13750
13751 2019-03-06 Pedro Alves <palves@redhat.com>
13752
13753 * linux-fork.c (new_fork): New, split out of ...
13754 (add_fork): ... this. Return void. Move "first fork" special
13755 case from here, to ...
13756 (checkpoint_command): ... here.
13757 * linux-linux.h (add_fork): Return void.
13758
13759 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13760
13761 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13762
13763 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13764 Chris January <chris.january@arm.com>
13765 David Lecomber <david.lecomber@arm.com>
13766
13767 * f-exp.y: New token, UNOP_INTRINSIC.
13768 (exp): New pattern using UNOP_INTRINSIC token.
13769 (f77_keywords): Add 'abs' keyword.
13770 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13771 (value_from_host_double): New function.
13772 (evaluate_subexp_f): Support UNOP_ABS.
13773
13774 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13775
13776 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13777 types.
13778
13779 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13780
13781 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13782 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13783 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13784
13785 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13786
13787 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13788
13789 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13790 Chris January <chris.january@arm.com>
13791
13792 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13793 * f-exp.y: Define 'KIND' token.
13794 (exp): New pattern for KIND expressions.
13795 (ptype): Handle types with a kind extension.
13796 (direct_abs_decl): Extend to spot kind extensions.
13797 (f77_keywords): Add 'kind' to the list.
13798 (push_kind_type): New function.
13799 (convert_to_kind_type): New function.
13800 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13801 * parse.c (operator_length_standard): Likewise.
13802 * parser-defs.h (enum type_pieces): Add tp_kind.
13803 * std-operator.def: Add UNOP_KIND.
13804
13805 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13806
13807 * f-exp.y (f_parse): Set yydebug.
13808
13809 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13810
13811 * f-lang.c (evaluate_subexp_f): New function.
13812 (exp_descriptor_f): New global.
13813 (f_language_defn): Use exp_descriptor_f instead of
13814 exp_descriptor_standard.
13815
13816 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13817
13818 * f-exp.y (struct token): Add comments.
13819 (dot_ops): Remove uppercase versions and the end marker.
13820 (f77_keywords): Likewise.
13821 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13822 entries in the dot_ops array are case insensitive, and use
13823 strncasecmp to compare strings. Also some whitespace cleanup in
13824 this area. Similar for the f77_keywords array, except entries in
13825 this list might be case sensitive.
13826
13827 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13828
13829 * f-exp.y (struct f77_boolean_val): Add comments.
13830 (boolean_values): Remove uppercase versions, and end marker.
13831 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13832 and use strncasecmp to achieve case insensitivity. Additionally,
13833 perform whitespace cleanup around this code.
13834
13835 2019-03-06 Tom Tromey <tromey@adacore.com>
13836
13837 * remote-sim.c (gdbsim_target_open): Use result of
13838 gdb_argv::release.
13839
13840 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13841 Dirk Schubert <dirk.schubert@arm.com>
13842 Chris January <chris.january@arm.com>
13843
13844 * eval.c (evaluate_subexp_standard): Call Fortran argument
13845 wrapping logic.
13846 * f-lang.c (struct value): A value which can be passed into a
13847 Fortran function call.
13848 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13849 where appropriate.
13850 (struct type): Value ready for a Fortran function call.
13851 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13852 is needed.
13853 * f-lang.h (fortran_argument_convert): Declaration.
13854 (fortran_preserve_arg_pointer): Declaration.
13855 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13856
13857 2019-03-05 Tom Tromey <tromey@adacore.com>
13858
13859 * python/py-prettyprint.c (print_string_repr): Remove #if.
13860 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13861
13862 2019-03-05 Tom Tromey <tromey@adacore.com>
13863
13864 * target.c (the_dummy_target): Move later. Change type to
13865 "dummy_target".
13866 (initialize_targets): Don't initialize the_dummy_target.
13867
13868 2019-03-05 Tom Tromey <tromey@adacore.com>
13869
13870 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13871 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13872
13873 2019-03-05 Tom Tromey <tromey@adacore.com>
13874
13875 * windows-nat.c (windows_nat_target::attach)
13876 (windows_nat_target::detach): Don't call gdb_flush.
13877 * valprint.c (generic_val_print, val_print, val_print_string):
13878 Don't call gdb_flush.
13879 * utils.c (defaulted_query): Don't call gdb_flush.
13880 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13881 * target.c (target_announce_detach): Don't call gdb_flush.
13882 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13883 * remote.c (extended_remote_target::attach): Don't call
13884 gdb_flush.
13885 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13886 * printcmd.c (do_examine): Don't call gdb_flush.
13887 (info_display_command): Don't call gdb_flush.
13888 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13889 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13890 * memattr.c (info_mem_command): Don't call gdb_flush.
13891 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13892 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13893 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13894 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13895 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13896 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13897 (gnu_nat_target::detach): Don't call gdb_flush.
13898 * f-valprint.c (f_val_print): Don't call gdb_flush.
13899 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13900 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13901 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13902 gdb_flush.
13903 * c-valprint.c (c_val_print): Don't call gdb_flush.
13904 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13905
13906 2019-03-05 Tom Tromey <tromey@adacore.com>
13907
13908 * varobj.c (update_dynamic_varobj_children): Update.
13909 (install_default_visualizer): Use reset, not release.
13910 * value.c (set_internalvar): Update.
13911 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13912 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13913 ATTRIBUTE_UNUSED_RESULT.
13914
13915 2019-03-05 Tom Tromey <tromey@adacore.com>
13916
13917 * remote.c (class scoped_remote_fd) <release>: Add
13918 ATTRIBUTE_UNUSED_RESULT.
13919
13920 2019-03-05 Tom Tromey <tromey@adacore.com>
13921
13922 * macroexp.c (struct macro_buffer) <release>: Add
13923 ATTRIBUTE_UNUSED_RESULT.
13924
13925 2019-03-05 Tom Tromey <tromey@adacore.com>
13926
13927 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13928 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13929 ATTRIBUTE_UNUSED_RESULT.
13930
13931 2019-03-05 Tom Tromey <tromey@adacore.com>
13932
13933 * common/scoped_fd.h (class scoped_fd) <release>: Add
13934 ATTRIBUTE_UNUSED_RESULT.
13935
13936 2019-03-05 Tom Tromey <tromey@adacore.com>
13937
13938 * parser-defs.h (struct parser_state) <release>: Add
13939 ATTRIBUTE_UNUSED_RESULT.
13940
13941 2019-03-05 Tom Tromey <tromey@adacore.com>
13942
13943 * utils.h (class gdb_argv) <release>: Add
13944 ATTRIBUTE_UNUSED_RESULT.
13945 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13946
13947 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13948
13949 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13950 for-loop range, to avoid compiler warnings.
13951
13952 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13953 avoid compiler warnings about unused variables.
13954
13955 * NEWS: Mention end of support for native debugging on MS-Windows
13956 before XP.
13957
13958 PR gdb/24292
13959 * common/netstuff.c:
13960 * gdbserver/gdbreplay.c
13961 * gdbserver/remote-utils.c:
13962 * ser-tcp.c:
13963 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13964 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13965 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13966 'getaddrinfo' and 'freeaddrinfo' were not available before
13967 Windows XP, and mingw.org's MinGW headers by default define
13968 _WIN32_WINNT to 0x500.
13969
13970 2019-03-01 Gary Benson <gbenson@redhat.com>
13971
13972 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13973
13974 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13975 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13976
13977 PR gdb/8527
13978 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13979 set_sigint_trap, clear_sigint_trap.
13980
13981 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13982
13983 * target.c (target_detach): Clear the regcache and the
13984 frame cache.
13985
13986 2019-02-27 Pedro Alves <palves@redhat.com>
13987
13988 * utils.c (set_screen_size): When we cap the height/width sizes,
13989 tweak the corresponding command variable to show "unlimited":
13990
13991 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13992 Pedro Alves <palves@redhat.com>
13993
13994 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13995 before calling rl_set_screen_size.
13996
13997 2019-02-27 Tom Tromey <tromey@adacore.com>
13998
13999 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14000 define.
14001 * python/py-value.c: Remove Python 2.4 workaround.
14002 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14003 workaround.
14004 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14005 Python 2.4 workaround.
14006 * python/python-internal.h: Remove Python 2.4 comment.
14007 (Py_ssize_t): Don't define.
14008 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14009 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14010 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14011 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14012 * python/python.c (do_start_initialization): Remove Python 2.4
14013 workaround.
14014 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14015 (print_children): Remove Python 2.4 workaround.
14016 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14017 workaround.
14018 (CHARBUFFERPROC_NAME): Remove.
14019 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14020 Python 2.4 workaround.
14021
14022 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14023
14024 * NEWS: Note minimum Python version.
14025
14026 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14027
14028 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14029 code from these functions. Remove corresponding ifdefs. Use
14030 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14031 Remove gotos and target of gotos.
14032 (infpy_search_memory): Likewise.
14033
14034 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14035
14036 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14037 (hppa_gdbarch_init): Don't register deleted functions with
14038 gdbarch.
14039
14040 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14041
14042 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14043 (h8300_unwind_sp): Delete.
14044 (h8300_dummy_id): Delete.
14045 (h8300_gdbarch_init): Don't register deleted functions with
14046 gdbarch.
14047
14048 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14049
14050 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14051 (ft32_unwind_pc): Delete.
14052 (ft32_unwind_sp): Delete.
14053 (ft32_gdbarch_init): Don't register deleted functions with
14054 gdbarch.
14055
14056 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14057
14058 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14059 (frv_unwind_pc): Delete.
14060 (frv_unwind_sp): Delete.
14061 (frv_gdbarch_init): Don't register deleted functions with
14062 gdbarch.
14063
14064 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14065
14066 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14067 (riscv_unwind_pc): Delete.
14068 (riscv_unwind_sp): Delete.
14069 (riscv_gdbarch_init): Don't register deleted functions with
14070 gdbarch.
14071
14072 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14073
14074 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14075 (csky_unwind_pc): Delete.
14076 (csky_unwind_sp): Delete.
14077 (csky_gdbarch_init): Don't register deleted functions with
14078 gdbarch.
14079
14080 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14081
14082 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14083 (cris_unwind_pc): Delete.
14084 (cris_unwind_sp): Delete.
14085 (cris_gdbarch_init): Don't register deleted functions with
14086 gdbarch.
14087
14088 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14089
14090 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14091 (bfin_unwind_pc): Delete.
14092 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14093
14094 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14095
14096 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14097 (arm_unwind_pc): Delete.
14098 (arm_unwind_sp): Delete.
14099 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14100
14101 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14102
14103 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14104 (arc_unwind_pc): Delete.
14105 (arc_unwind_sp): Delete.
14106 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14107
14108 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14109
14110 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14111 (alpha_unwind_pc): Delete.
14112 (alpha_gdbarch_init): Don't register deleted functions with
14113 gdbarch.
14114
14115 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14116
14117 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14118 (aarch64_unwind_pc): Delete.
14119 (aarch64_unwind_sp): Delete.
14120 (aarch64_gdbarch_init): Don't register deleted functions with
14121 gdbarch.
14122
14123 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14124
14125 * gdbtypes.c (type_align): Don't consider static members when
14126 computing structure alignment.
14127
14128 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14129
14130 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14131 return 0 for other types.
14132 * arch-utils.c (default_type_align): Always return 0.
14133 * gdbarch.h: Regenerate.
14134 * gdbarch.sh (type_align): Extend comment.
14135 * gdbtypes.c (type_align): Add additional comments, always call
14136 gdbarch_type_align before applying the default rules.
14137 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14138 generic code will then apply a suitable default.
14139 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14140 types, return 0 for other types.
14141
14142 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14143
14144 * NEWS: Create a new section for the next release branch.
14145 Rename the section of the current branch, now that it has
14146 been cut.
14147
14148 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14149
14150 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14151 * version.in: Bump version to 8.3.50.DATE-git.
14152
14153 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14154
14155 * aix-thread.c (ptid_cmp): Remove unused variable.
14156 (get_signaled_thread): Likewise.
14157 (store_regs_user_thread): Likewise.
14158 (store_regs_kernel_thread): Likewise.
14159 (fetch_regs_kernel_thread): Remove shadowed variable.
14160
14161 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14162
14163 * features/riscv/32bit-cpu.xml: Add register numbers.
14164 * features/riscv/32bit-fpu.c: Regenerate.
14165 * features/riscv/32bit-fpu.xml: Add register numbers.
14166 * features/riscv/64bit-cpu.xml: Add register numbers.
14167 * features/riscv/64bit-fpu.c: Regenerate.
14168 * features/riscv/64bit-fpu.xml: Add register numbers.
14169
14170 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14171
14172 * NEWS: Mention two argument form of gdb.Value constructor.
14173 * python/py-value.c (convert_buffer_and_type_to_value): New
14174 function.
14175 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14176 Add support for handling an optional second argument. Call
14177 convert_buffer_and_type_to_value as appropriate.
14178 * python/python-internal.h (Py_buffer_deleter): New struct.
14179 (Py_buffer_up): New typedef.
14180
14181 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14182
14183 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14184 instead of releasing ownership.
14185
14186 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14187
14188 * dwarf2read.c (open_and_init_dwp_file): Call
14189 elf_numsections instead of bfd_count_sections to initialize
14190 dwp_file->num_sections.
14191
14192 2019-02-25 Tom Tromey <tromey@adacore.com>
14193
14194 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14195
14196 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14197
14198 * gcore.in: Add '--readnever' option when invoking GDB.
14199
14200 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14201
14202 * MAINTAINERS: Update my email address.
14203
14204 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14205
14206 * build-id.c (build_id_to_debug_bfd_1): New function.
14207 (build_id_to_debug_bfd): Look for separate debug file in
14208 sysroot.
14209
14210 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14211
14212 * gdbarch.sh: Update the copyright year range that is placed into
14213 generated files.
14214
14215 2019-02-22 Keith Seitz <keiths@redhat.com>
14216
14217 PR symtab/23853
14218 * linespec.c (create_sals_line_offset): Search for the default
14219 symtab's filename instead of its fullname.
14220
14221 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14222
14223 * NEWS: Update style defaults.
14224
14225 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14226
14227 * main.c (captured_main_1): Disable styling in batch mode.
14228
14229 2019-02-20 Tom Tromey <tom@tromey.com>
14230
14231 * symtab.c (symtab_symbol_info): Fix typos.
14232
14233 2019-02-20 Tom Tromey <tromey@adacore.com>
14234
14235 * findcmd.c (_initialize_mem_search): Use upper case for
14236 metasyntactic variables.
14237
14238 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14239
14240 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14241 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14242
14243 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14244
14245 * top.h (source_file_name): Change to std::string.
14246 * top.c (source_file_name): Likewise.
14247 (command_line_input): Adjust.
14248 * cli/cli-script.c (script_from_file): Adjust.
14249
14250 2019-02-19 Tom Tromey <tromey@adacore.com>
14251
14252 * ravenscar-thread.c
14253 (ravenscar_thread_target::update_thread_list): Don't call
14254 ada_build_task_list.
14255 * ada-lang.h (ada_build_task_list): Don't declare.
14256 * ada-tasks.c (struct ada_tasks_inferior_data)
14257 <task_list_valid_p>: Now bool.
14258 (read_known_tasks, ada_task_list_changed)
14259 (ada_tasks_invalidate_inferior_data): Update.
14260 (read_known_tasks_array): Return bool.
14261 (read_known_tasks_list): Likewise.
14262 (read_known_tasks): Return void.
14263 (ada_build_task_list): Now static.
14264
14265 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14266
14267 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14268 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14269
14270 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14271
14272 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14273 variant for ada_tasks_pspace_data_handle and
14274 ada_tasks_inferior_data_handle.
14275 (ada_tasks_pspace_data_cleanup): New function.
14276 (ada_tasks_inferior_data_cleanup): New function.
14277
14278 2019-02-17 Tom Tromey <tom@tromey.com>
14279
14280 * macrotab.h (macro_source_fullname): Return a std::string.
14281 * macrotab.c (macro_include, check_for_redefinition)
14282 (macro_undef, macro_lookup_definition, foreach_macro)
14283 (foreach_macro_in_scope): Update.
14284 (macro_source_fullname): Return a std::string.
14285 * macrocmd.c (show_pp_source_pos): Update.
14286
14287 2019-02-17 Tom Tromey <tom@tromey.com>
14288
14289 * macrocmd.c (show_pp_source_pos): Style the file names.
14290
14291 2019-02-17 Tom Tromey <tom@tromey.com>
14292
14293 PR tui/24197:
14294 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14295
14296 2019-02-17 Tom Tromey <tom@tromey.com>
14297
14298 * ada-lang.c (user_select_syms): Use filtered printing.
14299 * utils.c (wrap_style): New global.
14300 (desired_style): Remove.
14301 (emit_style_escape): Add stream parameter.
14302 (set_output_style, reset_terminal_style, prompt_for_continue):
14303 Update.
14304 (flush_wrap_buffer): Only flush gdb_stdout.
14305 (wrap_here): Set wrap_style.
14306 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14307 treat escape sequences as a character. Change when wrap buffer is
14308 flushed.
14309 (fputs_styled): Do not set the output style when the default is
14310 requested.
14311 * ui-style.h (struct ui_file_style) <is_default>: New method.
14312 * source.c (print_source_lines_base): Emit escape sequences in one
14313 piece.
14314
14315 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14316
14317 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14318 integers and enumeration types.
14319
14320 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14321
14322 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14323 instead of lookup_symbol_in_language
14324 (do_exact_match): New function.
14325 (ada_get_symbol_name_matcher): Return do_exact_match when
14326 doing a verbatim match.
14327
14328 2019-02-15 Tom Tromey <tromey@adacore.com>
14329
14330 * ravenscar-thread.c (ravenscar_thread_target::resume)
14331 (ravenscar_thread_target::wait): Special case wildcard requests.
14332
14333 2019-02-15 Tom Tromey <tromey@adacore.com>
14334
14335 * ravenscar-thread.c (base_ptid): Remove.
14336 (struct ravenscar_thread_target) <close>: New method.
14337 <m_base_ptid>: New member.
14338 <update_inferior_ptid, active_task, task_is_currently_active,
14339 runtime_initialized>: Declare methods.
14340 <ravenscar_thread_target>: Add constructor.
14341 (ravenscar_thread_target::task_is_currently_active)
14342 (ravenscar_thread_target::update_inferior_ptid)
14343 (ravenscar_runtime_initialized): Rename. Now methods.
14344 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14345 (ravenscar_thread_target::update_thread_list): Update.
14346 (ravenscar_thread_target::active_task): Now method.
14347 (ravenscar_thread_target::store_registers)
14348 (ravenscar_thread_target::prepare_to_store)
14349 (ravenscar_thread_target::prepare_to_store)
14350 (ravenscar_thread_target::mourn_inferior): Update.
14351 (ravenscar_inferior_created): Use "new" to create target.
14352 (ravenscar_thread_target::get_ada_task_ptid): Update.
14353 (_initialize_ravenscar): Don't initialize base_ptid.
14354 (ravenscar_ops): Remove global.
14355
14356 2019-02-15 Tom Tromey <tromey@adacore.com>
14357
14358 * target.h (push_target): Declare new overload.
14359 * target.c (push_target): New overload, taking an rvalue reference.
14360 * remote.c (remote_target::open_1): Use push_target overload.
14361 * corelow.c (core_target_open): Use push_target overload.
14362
14363 2019-02-15 Tom Tromey <tromey@adacore.com>
14364
14365 * ravenscar-thread.c (is_ravenscar_task)
14366 (ravenscar_task_is_currently_active): Return bool.
14367 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14368 (_initialize_ravenscar): Remove "(void)".
14369 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14370 Return bool.
14371
14372 2019-02-15 Tom Tromey <tromey@adacore.com>
14373
14374 * ravenscar-thread.c (ravenscar_runtime_initializer)
14375 (has_ravenscar_runtime, get_running_thread_id)
14376 (ravenscar_thread_target::resume): Fix indentation.
14377
14378 2019-02-15 Tom Tromey <tromey@adacore.com>
14379
14380 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14381 from ravenscar_arch_ops.
14382 (sparc_ravenscar_ops::fetch_registers)
14383 (sparc_ravenscar_ops::store_registers): Now methods.
14384 (sparc_ravenscar_prepare_to_store): Remove.
14385 (sparc_ravenscar_ops): Redefine.
14386 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14387 methods and destructor. Remove members.
14388 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14389 (ravenscar_thread_target::store_registers)
14390 (ravenscar_thread_target::prepare_to_store): Update.
14391 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14392 Remove.
14393 (struct ppc_ravenscar_powerpc_ops): Derive from
14394 ravenscar_arch_ops.
14395 (ppc_ravenscar_powerpc_ops::fetch_registers)
14396 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14397 (ppc_ravenscar_powerpc_ops): Redefine.
14398 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14399 (ppc_ravenscar_e500_ops::fetch_registers)
14400 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14401 (ppc_ravenscar_e500_ops): Redefine.
14402 * aarch64-ravenscar-thread.c
14403 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14404 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14405 (aarch64_ravenscar_fetch_registers)
14406 (aarch64_ravenscar_store_registers): Now methods.
14407 (aarch64_ravenscar_ops): Redefine.
14408
14409 2019-02-15 Tom Tromey <tromey@adacore.com>
14410
14411 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14412 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14413 (ravenscar_thread_target::stopped_by_watchpoint)
14414 (ravenscar_thread_target::stopped_data_address)
14415 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14416
14417 2019-02-15 Tom Tromey <tromey@adacore.com>
14418
14419 * ravenscar-thread.c: Fix some typos.
14420
14421 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14422 Tom Tromey <tromey@adacore.com>
14423
14424 * ada-lang.c (ada_exception_sal): Change addr_string to a
14425 std::string.
14426 (create_ada_exception_catchpoint): Update.
14427
14428 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14429 Tom Tromey <tromey@adacore.com>
14430
14431 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14432 (bp_location_ops): Remove.
14433 (base_breakpoint_allocate_location): Update.
14434 (free_bp_location): Update.
14435 * ada-lang.c (class ada_catchpoint_location)
14436 <ada_catchpoint_location>: Remove ops parameter.
14437 (ada_catchpoint_location_dtor): Remove.
14438 (ada_catchpoint_location_ops): Remove.
14439 (allocate_location_exception): Update.
14440 * breakpoint.h (struct bp_location_ops): Remove.
14441 (class bp_location) <bp_location>: Remove bp_location_ops
14442 parameter.
14443 <~bp_location>: Add destructor.
14444 <ops>: Remove.
14445
14446 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14447 Pedro Alves <palves@redhat.com>
14448
14449 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14450 'PATH_MAX'.
14451
14452 2019-02-14 David Michael <fedora.dm0@gmail.com>
14453 Samuel Thibault <samuel.thibault@gnu.org>
14454 Thomas Schwinge <thomas@codesourcery.com>
14455
14456 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14457 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14458
14459 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14460
14461 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14462 (check_empty): Use "const char *".
14463
14464 * gnu-nat.c (gnu_nat_target::detach): Instead of
14465 'detach_inferior (pid)' call
14466 'detach_inferior (find_inferior_pid (pid))'.
14467
14468 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14469 'nat/fork-inferior.o'.
14470 * gnu-nat.c: #include "nat/fork-inferior.h".
14471
14472 * gnu-nat.c (gnu_nat_target::detach): Instead of
14473 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14474 * gnu-nat.h: #include "inf-child.h".
14475 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14476 'i386_gnu_nat_target::fetch_registers'.
14477 (gnu_store_registers): Rename/move to
14478 'i386_gnu_nat_target::store_registers'.
14479
14480 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14481 * gnu-nat.h (mach_thread_info): New function.
14482 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14483
14484 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14485
14486 2019-02-14 Frederic Konrad <konrad@adacore.com>
14487
14488 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14489
14490 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14491
14492 * windows-nat.c (windows_add_thread): Add new parameter
14493 "main_thread_p" with default value set to false. Update
14494 function documentation as well as all callers.
14495 (windows_delete_thread): Likewise.
14496 (fake_create_process): Update call to windows_add_thread.
14497 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14498 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14499 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14500 call to windows_delete_thread.
14501
14502 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14503
14504 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14505
14506 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14507
14508 * symfile.c (find_separate_debug_file): Use canonical path of
14509 sysroot with child_path instead of gdb_sysroot if it is valid.
14510
14511 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14512
14513 * symfile.c (find_separate_debug_file): Use child_path to
14514 determine if an object file is under a sysroot.
14515
14516 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14517
14518 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14519 unittests/child-path-selftests.c.
14520 * common/pathstuff.c (child_path): New function.
14521 * common/pathstuff.h (child_path): New prototype.
14522 * unittests/child-path-selftests.c: New file.
14523
14524 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14525
14526 * symfile.c (find_separate_debug_file): Look for separate debug
14527 files in debug directories under the sysroot.
14528
14529 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14530
14531 * symtab.h (struct minimal_symbol data_p): New const method.
14532 (struct minimal_symbol text_p): Likewise.
14533 * symtab.c (output_source_filename): Use file name style
14534 to print file name.
14535 (print_symbol_info): Likewise.
14536 (print_msymbol_info): Use address style to print addresses.
14537 Use function name style to print executable text symbols.
14538 (expand_symtab_containing_pc): Use data_p.
14539 (find_pc_sect_compunit_symtab): Likewise.
14540
14541 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14542
14543 * breakpoint.c (describe_other_breakpoints): Use address style
14544 to print addresses.
14545 (say_where): Likewise.
14546
14547 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14548
14549 * ada-typeprint.c (print_func_type): Print function name
14550 style to print function name.
14551 * c-typeprint.c (c_print_type_1): Likewise.
14552
14553 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14554
14555 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14556 for execve.
14557
14558 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14559
14560 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14561 type_stack.
14562
14563 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14564
14565 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14566 TYPE_CODE_REF types.
14567
14568 2019-02-08 Jim Wilson <jimw@sifive.com>
14569
14570 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14571 (riscv_linux_fregset): New.
14572 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14573
14574 2019-02-07 Tom Tromey <tom@tromey.com>
14575
14576 * thread.c (thread_cancel_execution_command): Update.
14577 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14578 methods.
14579 (struct thread_fsm_ops): Remove.
14580 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14581 (thread_fsm_should_stop, thread_fsm_return_value)
14582 (thread_fsm_set_finished, thread_fsm_finished_p)
14583 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14584 Don't declare.
14585 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14586 * infrun.c (clear_proceed_status_thread)
14587 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14588 (print_stop_event): Update.
14589 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14590 Add constructor.
14591 (step_command_fsm_ops): Remove.
14592 (new_step_command_fsm): Remove.
14593 (step_1): Update.
14594 (step_command_fsm::should_stop): Rename from
14595 step_command_fsm_should_stop.
14596 (step_command_fsm::clean_up): Rename from
14597 step_command_fsm_clean_up.
14598 (step_command_fsm::do_async_reply_reason): Rename from
14599 step_command_fsm_async_reply_reason.
14600 (struct until_next_fsm): Inherit from thread_fsm. Add
14601 constructor.
14602 (until_next_fsm_ops): Remove.
14603 (new_until_next_fsm): Remove.
14604 (until_next_fsm::should_stop): Rename from
14605 until_next_fsm_should_stop.
14606 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14607 (until_next_fsm::do_async_reply_reason): Rename from
14608 until_next_fsm_async_reply_reason.
14609 (struct finish_command_fsm): Inherit from thread_fsm. Add
14610 constructor. Change type of breakpoint.
14611 (finish_command_fsm_ops): Remove.
14612 (new_finish_command_fsm): Remove.
14613 (finish_command_fsm::should_stop): Rename from
14614 finish_command_fsm_should_stop.
14615 (finish_command_fsm::clean_up): Rename from
14616 finish_command_fsm_clean_up.
14617 (finish_command_fsm::return_value): Rename from
14618 finish_command_fsm_return_value.
14619 (finish_command_fsm::do_async_reply_reason): Rename from
14620 finish_command_fsm_async_reply_reason.
14621 (finish_command): Update.
14622 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14623 Add constructor.
14624 (call_thread_fsm_ops): Remove.
14625 (call_thread_fsm::call_thread_fsm): Rename from
14626 new_call_thread_fsm.
14627 (call_thread_fsm::should_stop): Rename from
14628 call_thread_fsm_should_stop.
14629 (call_thread_fsm::should_notify_stop): Rename from
14630 call_thread_fsm_should_notify_stop.
14631 (run_inferior_call, call_function_by_hand_dummy): Update.
14632 * cli/cli-interp.c (should_print_stop_to_console): Update.
14633 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14634 Add constructor. Change type of location_breakpoint,
14635 caller_breakpoint.
14636 (until_break_fsm_ops): Remove.
14637 (new_until_break_fsm): Remove.
14638 (until_break_fsm::should_stop): Rename from
14639 until_break_fsm_should_stop.
14640 (until_break_fsm::clean_up): Rename from
14641 until_break_fsm_clean_up.
14642 (until_break_fsm::do_async_reply_reason): Rename from
14643 until_break_fsm_async_reply_reason.
14644 (until_break_command): Update.
14645 * thread-fsm.c: Remove.
14646 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14647
14648 2019-02-07 Tom Tromey <tom@tromey.com>
14649
14650 * yy-remap.h: Add include guard.
14651 * xtensa-tdep.h: Add include guard.
14652 * xcoffread.h: Rename include guard.
14653 * varobj-iter.h: Add include guard.
14654 * tui/tui.h: Rename include guard.
14655 * tui/tui-winsource.h: Rename include guard.
14656 * tui/tui-wingeneral.h: Rename include guard.
14657 * tui/tui-windata.h: Rename include guard.
14658 * tui/tui-win.h: Rename include guard.
14659 * tui/tui-stack.h: Rename include guard.
14660 * tui/tui-source.h: Rename include guard.
14661 * tui/tui-regs.h: Rename include guard.
14662 * tui/tui-out.h: Rename include guard.
14663 * tui/tui-layout.h: Rename include guard.
14664 * tui/tui-io.h: Rename include guard.
14665 * tui/tui-hooks.h: Rename include guard.
14666 * tui/tui-file.h: Rename include guard.
14667 * tui/tui-disasm.h: Rename include guard.
14668 * tui/tui-data.h: Rename include guard.
14669 * tui/tui-command.h: Rename include guard.
14670 * tic6x-tdep.h: Add include guard.
14671 * target/waitstatus.h: Rename include guard.
14672 * target/wait.h: Rename include guard.
14673 * target/target.h: Rename include guard.
14674 * target/resume.h: Rename include guard.
14675 * target-float.h: Rename include guard.
14676 * stabsread.h: Add include guard.
14677 * rs6000-tdep.h: Add include guard.
14678 * riscv-fbsd-tdep.h: Add include guard.
14679 * regformats/regdef.h: Rename include guard.
14680 * record.h: Rename include guard.
14681 * python/python.h: Rename include guard.
14682 * python/python-internal.h: Rename include guard.
14683 * python/py-stopevent.h: Rename include guard.
14684 * python/py-ref.h: Rename include guard.
14685 * python/py-record.h: Rename include guard.
14686 * python/py-record-full.h: Rename include guard.
14687 * python/py-record-btrace.h: Rename include guard.
14688 * python/py-instruction.h: Rename include guard.
14689 * python/py-events.h: Rename include guard.
14690 * python/py-event.h: Rename include guard.
14691 * procfs.h: Add include guard.
14692 * proc-utils.h: Add include guard.
14693 * p-lang.h: Add include guard.
14694 * or1k-tdep.h: Rename include guard.
14695 * observable.h: Rename include guard.
14696 * nto-tdep.h: Rename include guard.
14697 * nat/x86-linux.h: Rename include guard.
14698 * nat/x86-linux-dregs.h: Rename include guard.
14699 * nat/x86-gcc-cpuid.h: Add include guard.
14700 * nat/x86-dregs.h: Rename include guard.
14701 * nat/x86-cpuid.h: Rename include guard.
14702 * nat/ppc-linux.h: Rename include guard.
14703 * nat/mips-linux-watch.h: Rename include guard.
14704 * nat/linux-waitpid.h: Rename include guard.
14705 * nat/linux-ptrace.h: Rename include guard.
14706 * nat/linux-procfs.h: Rename include guard.
14707 * nat/linux-osdata.h: Rename include guard.
14708 * nat/linux-nat.h: Rename include guard.
14709 * nat/linux-namespaces.h: Rename include guard.
14710 * nat/linux-btrace.h: Rename include guard.
14711 * nat/glibc_thread_db.h: Rename include guard.
14712 * nat/gdb_thread_db.h: Rename include guard.
14713 * nat/gdb_ptrace.h: Rename include guard.
14714 * nat/fork-inferior.h: Rename include guard.
14715 * nat/amd64-linux-siginfo.h: Rename include guard.
14716 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14717 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14718 * nat/aarch64-linux.h: Rename include guard.
14719 * nat/aarch64-linux-hw-point.h: Rename include guard.
14720 * mn10300-tdep.h: Add include guard.
14721 * mips-linux-tdep.h: Add include guard.
14722 * mi/mi-parse.h: Rename include guard.
14723 * mi/mi-out.h: Rename include guard.
14724 * mi/mi-main.h: Rename include guard.
14725 * mi/mi-interp.h: Rename include guard.
14726 * mi/mi-getopt.h: Rename include guard.
14727 * mi/mi-console.h: Rename include guard.
14728 * mi/mi-common.h: Rename include guard.
14729 * mi/mi-cmds.h: Rename include guard.
14730 * mi/mi-cmd-break.h: Rename include guard.
14731 * m2-lang.h: Add include guard.
14732 * location.h: Rename include guard.
14733 * linux-record.h: Rename include guard.
14734 * linux-nat.h: Add include guard.
14735 * linux-fork.h: Add include guard.
14736 * i386-darwin-tdep.h: Rename include guard.
14737 * hppa-linux-offsets.h: Add include guard.
14738 * guile/guile.h: Rename include guard.
14739 * guile/guile-internal.h: Rename include guard.
14740 * gnu-nat.h: Rename include guard.
14741 * gdb-stabs.h: Rename include guard.
14742 * frv-tdep.h: Add include guard.
14743 * f-lang.h: Add include guard.
14744 * event-loop.h: Add include guard.
14745 * darwin-nat.h: Rename include guard.
14746 * cp-abi.h: Rename include guard.
14747 * config/sparc/nm-sol2.h: Rename include guard.
14748 * config/nm-nto.h: Rename include guard.
14749 * config/nm-linux.h: Add include guard.
14750 * config/i386/nm-i386gnu.h: Rename include guard.
14751 * config/djgpp/nl_types.h: Rename include guard.
14752 * config/djgpp/langinfo.h: Rename include guard.
14753 * compile/gcc-cp-plugin.h: Add include guard.
14754 * compile/gcc-c-plugin.h: Add include guard.
14755 * compile/compile.h: Rename include guard.
14756 * compile/compile-object-run.h: Rename include guard.
14757 * compile/compile-object-load.h: Rename include guard.
14758 * compile/compile-internal.h: Rename include guard.
14759 * compile/compile-cplus.h: Rename include guard.
14760 * compile/compile-c.h: Rename include guard.
14761 * common/xml-utils.h: Rename include guard.
14762 * common/x86-xstate.h: Rename include guard.
14763 * common/version.h: Rename include guard.
14764 * common/vec.h: Rename include guard.
14765 * common/tdesc.h: Rename include guard.
14766 * common/selftest.h: Rename include guard.
14767 * common/scoped_restore.h: Rename include guard.
14768 * common/scoped_mmap.h: Rename include guard.
14769 * common/scoped_fd.h: Rename include guard.
14770 * common/safe-iterator.h: Rename include guard.
14771 * common/run-time-clock.h: Rename include guard.
14772 * common/refcounted-object.h: Rename include guard.
14773 * common/queue.h: Rename include guard.
14774 * common/ptid.h: Rename include guard.
14775 * common/print-utils.h: Rename include guard.
14776 * common/preprocessor.h: Rename include guard.
14777 * common/pathstuff.h: Rename include guard.
14778 * common/observable.h: Rename include guard.
14779 * common/netstuff.h: Rename include guard.
14780 * common/job-control.h: Rename include guard.
14781 * common/host-defs.h: Rename include guard.
14782 * common/gdb_wait.h: Rename include guard.
14783 * common/gdb_vecs.h: Rename include guard.
14784 * common/gdb_unlinker.h: Rename include guard.
14785 * common/gdb_unique_ptr.h: Rename include guard.
14786 * common/gdb_tilde_expand.h: Rename include guard.
14787 * common/gdb_sys_time.h: Rename include guard.
14788 * common/gdb_string_view.h: Rename include guard.
14789 * common/gdb_splay_tree.h: Rename include guard.
14790 * common/gdb_setjmp.h: Rename include guard.
14791 * common/gdb_ref_ptr.h: Rename include guard.
14792 * common/gdb_optional.h: Rename include guard.
14793 * common/gdb_locale.h: Rename include guard.
14794 * common/gdb_assert.h: Rename include guard.
14795 * common/filtered-iterator.h: Rename include guard.
14796 * common/filestuff.h: Rename include guard.
14797 * common/fileio.h: Rename include guard.
14798 * common/environ.h: Rename include guard.
14799 * common/common-utils.h: Rename include guard.
14800 * common/common-types.h: Rename include guard.
14801 * common/common-regcache.h: Rename include guard.
14802 * common/common-inferior.h: Rename include guard.
14803 * common/common-gdbthread.h: Rename include guard.
14804 * common/common-exceptions.h: Rename include guard.
14805 * common/common-defs.h: Rename include guard.
14806 * common/common-debug.h: Rename include guard.
14807 * common/cleanups.h: Rename include guard.
14808 * common/buffer.h: Rename include guard.
14809 * common/btrace-common.h: Rename include guard.
14810 * common/break-common.h: Rename include guard.
14811 * cli/cli-utils.h: Rename include guard.
14812 * cli/cli-style.h: Rename include guard.
14813 * cli/cli-setshow.h: Rename include guard.
14814 * cli/cli-script.h: Rename include guard.
14815 * cli/cli-interp.h: Rename include guard.
14816 * cli/cli-decode.h: Rename include guard.
14817 * cli/cli-cmds.h: Rename include guard.
14818 * charset-list.h: Add include guard.
14819 * buildsym-legacy.h: Rename include guard.
14820 * bfin-tdep.h: Add include guard.
14821 * ax.h: Rename include guard.
14822 * arm-linux-tdep.h: Add include guard.
14823 * arm-fbsd-tdep.h: Add include guard.
14824 * arch/xtensa.h: Rename include guard.
14825 * arch/tic6x.h: Add include guard.
14826 * arch/i386.h: Add include guard.
14827 * arch/arm.h: Rename include guard.
14828 * arch/arm-linux.h: Rename include guard.
14829 * arch/arm-get-next-pcs.h: Rename include guard.
14830 * arch/amd64.h: Add include guard.
14831 * arch/aarch64-insn.h: Rename include guard.
14832 * arch-utils.h: Rename include guard.
14833 * annotate.h: Add include guard.
14834 * amd64-darwin-tdep.h: Rename include guard.
14835 * aarch64-linux-tdep.h: Add include guard.
14836 * aarch64-fbsd-tdep.h: Add include guard.
14837 * aarch32-linux-nat.h: Add include guard.
14838
14839 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14840
14841 * macrotab.c (macro_define_internal): New function that
14842 factorizes macro_define_object_internal and macro_define_function
14843 code.
14844 (macro_define_object_internal): Use macro_define_internal.
14845 (macro_define_function): Likewise.
14846
14847 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14848
14849 * macrocmd.c (extract_identifier): Return
14850 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14851 callers.
14852
14853 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14854
14855 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14856
14857 2019-02-05 Tom Tromey <tom@tromey.com>
14858
14859 * target.c (target_stack::unpush): Move assertion earlier.
14860
14861 2019-01-30 Tom Tromey <tom@tromey.com>
14862
14863 PR python/23615:
14864 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14865 (gdbpy_parse_and_eval): Likewise.
14866 * python/python-internal.h (gdbpy_allow_threads): New class.
14867
14868 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14869
14870 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14871 (aarch64_fbsd_fpregmap): Move earlier.
14872 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14873 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14874 instead of individual calls to trad_frame_set_reg_addr.
14875 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14876 earlier.
14877 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14878 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14879 instead of individual calls to trad_frame_set_reg_addr.
14880
14881 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14882
14883 * CONTRIBUTE: Replace contribution list with wiki link.
14884
14885 2019-01-25 Tom Tromey <tom@tromey.com>
14886
14887 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14888
14889 2019-01-25 Tom Tromey <tom@tromey.com>
14890
14891 * xtensa-linux-nat.c: Fix common/ includes.
14892 * xml-support.h: Fix common/ includes.
14893 * xml-support.c: Fix common/ includes.
14894 * x86-linux-nat.c: Fix common/ includes.
14895 * windows-nat.c: Fix common/ includes.
14896 * varobj.h: Fix common/ includes.
14897 * varobj.c: Fix common/ includes.
14898 * value.c: Fix common/ includes.
14899 * valops.c: Fix common/ includes.
14900 * utils.c: Fix common/ includes.
14901 * unittests/xml-utils-selftests.c: Fix common/ includes.
14902 * unittests/utils-selftests.c: Fix common/ includes.
14903 * unittests/unpack-selftests.c: Fix common/ includes.
14904 * unittests/tracepoint-selftests.c: Fix common/ includes.
14905 * unittests/style-selftests.c: Fix common/ includes.
14906 * unittests/string_view-selftests.c: Fix common/ includes.
14907 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14908 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14909 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14910 * unittests/rsp-low-selftests.c: Fix common/ includes.
14911 * unittests/parse-connection-spec-selftests.c: Fix common/
14912 includes.
14913 * unittests/optional-selftests.c: Fix common/ includes.
14914 * unittests/offset-type-selftests.c: Fix common/ includes.
14915 * unittests/observable-selftests.c: Fix common/ includes.
14916 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14917 * unittests/memrange-selftests.c: Fix common/ includes.
14918 * unittests/memory-map-selftests.c: Fix common/ includes.
14919 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14920 * unittests/function-view-selftests.c: Fix common/ includes.
14921 * unittests/environ-selftests.c: Fix common/ includes.
14922 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14923 * unittests/common-utils-selftests.c: Fix common/ includes.
14924 * unittests/cli-utils-selftests.c: Fix common/ includes.
14925 * unittests/array-view-selftests.c: Fix common/ includes.
14926 * ui-file.c: Fix common/ includes.
14927 * tui/tui-io.c: Fix common/ includes.
14928 * tracepoint.h: Fix common/ includes.
14929 * tracepoint.c: Fix common/ includes.
14930 * tracefile-tfile.c: Fix common/ includes.
14931 * top.h: Fix common/ includes.
14932 * top.c: Fix common/ includes.
14933 * thread.c: Fix common/ includes.
14934 * target/waitstatus.h: Fix common/ includes.
14935 * target/waitstatus.c: Fix common/ includes.
14936 * target.h: Fix common/ includes.
14937 * target.c: Fix common/ includes.
14938 * target-memory.c: Fix common/ includes.
14939 * target-descriptions.c: Fix common/ includes.
14940 * symtab.h: Fix common/ includes.
14941 * symfile.c: Fix common/ includes.
14942 * stap-probe.c: Fix common/ includes.
14943 * spu-linux-nat.c: Fix common/ includes.
14944 * sparc-nat.c: Fix common/ includes.
14945 * source.c: Fix common/ includes.
14946 * solib.c: Fix common/ includes.
14947 * solib-target.c: Fix common/ includes.
14948 * ser-unix.c: Fix common/ includes.
14949 * ser-tcp.c: Fix common/ includes.
14950 * ser-pipe.c: Fix common/ includes.
14951 * ser-base.c: Fix common/ includes.
14952 * selftest-arch.c: Fix common/ includes.
14953 * s12z-tdep.c: Fix common/ includes.
14954 * rust-exp.y: Fix common/ includes.
14955 * rs6000-aix-tdep.c: Fix common/ includes.
14956 * riscv-tdep.c: Fix common/ includes.
14957 * remote.c: Fix common/ includes.
14958 * remote-notif.h: Fix common/ includes.
14959 * remote-fileio.h: Fix common/ includes.
14960 * remote-fileio.c: Fix common/ includes.
14961 * regcache.h: Fix common/ includes.
14962 * regcache.c: Fix common/ includes.
14963 * record-btrace.c: Fix common/ includes.
14964 * python/python.c: Fix common/ includes.
14965 * python/py-type.c: Fix common/ includes.
14966 * python/py-inferior.c: Fix common/ includes.
14967 * progspace.h: Fix common/ includes.
14968 * producer.c: Fix common/ includes.
14969 * procfs.c: Fix common/ includes.
14970 * proc-api.c: Fix common/ includes.
14971 * printcmd.c: Fix common/ includes.
14972 * ppc-linux-nat.c: Fix common/ includes.
14973 * parser-defs.h: Fix common/ includes.
14974 * osdata.c: Fix common/ includes.
14975 * obsd-nat.c: Fix common/ includes.
14976 * nat/x86-linux.c: Fix common/ includes.
14977 * nat/x86-linux-dregs.c: Fix common/ includes.
14978 * nat/x86-dregs.h: Fix common/ includes.
14979 * nat/x86-dregs.c: Fix common/ includes.
14980 * nat/ppc-linux.c: Fix common/ includes.
14981 * nat/mips-linux-watch.h: Fix common/ includes.
14982 * nat/mips-linux-watch.c: Fix common/ includes.
14983 * nat/linux-waitpid.c: Fix common/ includes.
14984 * nat/linux-ptrace.h: Fix common/ includes.
14985 * nat/linux-ptrace.c: Fix common/ includes.
14986 * nat/linux-procfs.c: Fix common/ includes.
14987 * nat/linux-personality.c: Fix common/ includes.
14988 * nat/linux-osdata.c: Fix common/ includes.
14989 * nat/linux-namespaces.c: Fix common/ includes.
14990 * nat/linux-btrace.h: Fix common/ includes.
14991 * nat/linux-btrace.c: Fix common/ includes.
14992 * nat/fork-inferior.c: Fix common/ includes.
14993 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14994 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14995 * nat/aarch64-linux.c: Fix common/ includes.
14996 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14997 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14998 * namespace.h: Fix common/ includes.
14999 * mips-linux-tdep.c: Fix common/ includes.
15000 * minsyms.c: Fix common/ includes.
15001 * mi/mi-parse.h: Fix common/ includes.
15002 * mi/mi-main.c: Fix common/ includes.
15003 * mi/mi-cmd-env.c: Fix common/ includes.
15004 * memrange.h: Fix common/ includes.
15005 * memattr.c: Fix common/ includes.
15006 * maint.h: Fix common/ includes.
15007 * maint.c: Fix common/ includes.
15008 * main.c: Fix common/ includes.
15009 * machoread.c: Fix common/ includes.
15010 * location.c: Fix common/ includes.
15011 * linux-thread-db.c: Fix common/ includes.
15012 * linux-nat.c: Fix common/ includes.
15013 * linux-fork.c: Fix common/ includes.
15014 * inline-frame.c: Fix common/ includes.
15015 * infrun.c: Fix common/ includes.
15016 * inflow.c: Fix common/ includes.
15017 * inferior.h: Fix common/ includes.
15018 * inferior.c: Fix common/ includes.
15019 * infcmd.c: Fix common/ includes.
15020 * inf-ptrace.c: Fix common/ includes.
15021 * inf-child.c: Fix common/ includes.
15022 * ia64-linux-nat.c: Fix common/ includes.
15023 * i387-tdep.c: Fix common/ includes.
15024 * i386-tdep.c: Fix common/ includes.
15025 * i386-linux-tdep.c: Fix common/ includes.
15026 * i386-linux-nat.c: Fix common/ includes.
15027 * i386-go32-tdep.c: Fix common/ includes.
15028 * i386-fbsd-tdep.c: Fix common/ includes.
15029 * i386-fbsd-nat.c: Fix common/ includes.
15030 * guile/scm-type.c: Fix common/ includes.
15031 * guile/guile.c: Fix common/ includes.
15032 * go32-nat.c: Fix common/ includes.
15033 * gnu-nat.c: Fix common/ includes.
15034 * gdbthread.h: Fix common/ includes.
15035 * gdbarch-selftests.c: Fix common/ includes.
15036 * gdb_usleep.c: Fix common/ includes.
15037 * gdb_select.h: Fix common/ includes.
15038 * gdb_bfd.c: Fix common/ includes.
15039 * gcore.c: Fix common/ includes.
15040 * fork-child.c: Fix common/ includes.
15041 * findvar.c: Fix common/ includes.
15042 * fbsd-nat.c: Fix common/ includes.
15043 * event-top.c: Fix common/ includes.
15044 * event-loop.c: Fix common/ includes.
15045 * dwarf2read.c: Fix common/ includes.
15046 * dwarf2loc.c: Fix common/ includes.
15047 * dwarf2-frame.c: Fix common/ includes.
15048 * dwarf-index-cache.c: Fix common/ includes.
15049 * dtrace-probe.c: Fix common/ includes.
15050 * disasm-selftests.c: Fix common/ includes.
15051 * defs.h: Fix common/ includes.
15052 * csky-tdep.c: Fix common/ includes.
15053 * cp-valprint.c: Fix common/ includes.
15054 * cp-support.h: Fix common/ includes.
15055 * cp-support.c: Fix common/ includes.
15056 * corelow.c: Fix common/ includes.
15057 * completer.h: Fix common/ includes.
15058 * completer.c: Fix common/ includes.
15059 * compile/compile.c: Fix common/ includes.
15060 * compile/compile-loc2c.c: Fix common/ includes.
15061 * compile/compile-cplus-types.c: Fix common/ includes.
15062 * compile/compile-cplus-symbols.c: Fix common/ includes.
15063 * command.h: Fix common/ includes.
15064 * cli/cli-dump.c: Fix common/ includes.
15065 * cli/cli-cmds.c: Fix common/ includes.
15066 * charset.c: Fix common/ includes.
15067 * build-id.c: Fix common/ includes.
15068 * btrace.h: Fix common/ includes.
15069 * btrace.c: Fix common/ includes.
15070 * breakpoint.h: Fix common/ includes.
15071 * breakpoint.c: Fix common/ includes.
15072 * ax.h:
15073 (enum agent_op): Fix common/ includes.
15074 * ax-general.c (struct aop_map): Fix common/ includes.
15075 * ax-gdb.c: Fix common/ includes.
15076 * auxv.c: Fix common/ includes.
15077 * auto-load.c: Fix common/ includes.
15078 * arm-tdep.c: Fix common/ includes.
15079 * arch/riscv.c: Fix common/ includes.
15080 * arch/ppc-linux-common.c: Fix common/ includes.
15081 * arch/i386.c: Fix common/ includes.
15082 * arch/arm.c: Fix common/ includes.
15083 * arch/arm-linux.c: Fix common/ includes.
15084 * arch/arm-get-next-pcs.c: Fix common/ includes.
15085 * arch/amd64.c: Fix common/ includes.
15086 * arch/aarch64.c: Fix common/ includes.
15087 * arch/aarch64-insn.c: Fix common/ includes.
15088 * arch-utils.c: Fix common/ includes.
15089 * amd64-windows-tdep.c: Fix common/ includes.
15090 * amd64-tdep.c: Fix common/ includes.
15091 * amd64-sol2-tdep.c: Fix common/ includes.
15092 * amd64-obsd-tdep.c: Fix common/ includes.
15093 * amd64-nbsd-tdep.c: Fix common/ includes.
15094 * amd64-linux-tdep.c: Fix common/ includes.
15095 * amd64-linux-nat.c: Fix common/ includes.
15096 * amd64-fbsd-tdep.c: Fix common/ includes.
15097 * amd64-fbsd-nat.c: Fix common/ includes.
15098 * amd64-dicos-tdep.c: Fix common/ includes.
15099 * amd64-darwin-tdep.c: Fix common/ includes.
15100 * agent.c: Fix common/ includes.
15101 * ada-lang.h: Fix common/ includes.
15102 * ada-lang.c: Fix common/ includes.
15103 * aarch64-tdep.c: Fix common/ includes.
15104
15105 2019-01-25 Tom Tromey <tom@tromey.com>
15106
15107 * common/create-version.sh: Use common/version.h.
15108
15109 2019-01-24 Pedro Alves <palves@redhat.com>
15110
15111 * infrun.c (signal_stop, signal_print, signal_program)
15112 (signal_catch, signal_pass): Now arrays instead of pointers.
15113 (update_signals_program_target, do_target_resume)
15114 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15115 * linux-nat.c (linux_nat_target::pass_signals)
15116 (linux_nat_target::create_inferior, linux_nat_target::attach):
15117 Adjust.
15118 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15119 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15120 * procfs.c (procfs_target::pass_signals): Adjust.
15121 * record-full.c (record_full_target::resume): Adjust.
15122 * remote.c (remote_target::pass_signals)
15123 (remote_target::program_signals): Adjust.
15124 * target-debug.h (target_debug_print_signals): Now takes a
15125 gdb::array_view as parameter. Adjust.
15126 * target.h (target_ops) <pass_signals, program_signals>: Replace
15127 pointer and length parameters with gdb::array_view.
15128 (target_pass_signals, target_program_signals): Likewise.
15129 * target-delegates.c: Regenerate.
15130
15131 2019-01-24 Pedro Alves <palves@redhat.com>
15132
15133 * common/forward-scope-exit.h
15134 (forward_scope_exit::forward_scope_exit): Pass arguments to
15135 m_bind_function directly, instead of creating a std::bind and
15136 copying that.
15137
15138 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15139
15140 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15141 for static members.
15142 (pass_in_v_vfp_candidate): Likewise.
15143
15144 2019-01-23 Tom Tromey <tom@tromey.com>
15145 Pedro Alves <palves@redhat.com>
15146
15147 * regcache.c (class regcache_invalidator): Remove.
15148 (regcache::raw_write): Use make_scope_exit.
15149
15150 2019-01-23 Tom Tromey <tom@tromey.com>
15151
15152 * ui-out.h (class ui_out_emit_type): Update comment.
15153
15154 2019-01-23 Tom Tromey <tom@tromey.com>
15155
15156 * infrun.c (fetch_inferior_event): Update comment.
15157
15158 2019-01-23 Tom Tromey <tom@tromey.com>
15159 Pedro Alves <palves@redhat.com>
15160
15161 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15162 parameter.
15163 (fetch_inferior_event): Use SCOPE_EXIT.
15164
15165
15166 2019-01-23 Tom Tromey <tom@tromey.com>
15167 Pedro Alves <palves@redhat.com>
15168
15169 * infrun.c (disable_thread_events): Delete.
15170 (stop_all_threads): Use SCOPE_EXIT.
15171
15172 2019-01-23 Tom Tromey <tom@tromey.com>
15173 Pedro Alves <palves@redhat.com>
15174
15175 * symfile.c: Include forward-scope-exit.h.
15176 (clear_symtab_users_cleanup): Replace forward declaration with
15177 a FORWARD_SCOPE_EXIT.
15178 (syms_from_objfile_1): Use the forward_scope_exit and
15179 gdb::optional instead of cleanup_function.
15180 (reread_symbols): Use the forward_scope_exit instead of
15181 cleanup_function.
15182 (clear_symtab_users_cleanup): Remove function.
15183
15184 2019-01-23 Tom Tromey <tom@tromey.com>
15185 Pedro Alves <palves@redhat.com>
15186
15187 * linux-nat.c: Include scope-exit.h.
15188 (cleanup_target_stop): Remove.
15189 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15190 SCOPE_EXIT.
15191
15192 2019-01-23 Tom Tromey <tom@tromey.com>
15193 Pedro Alves <palves@redhat.com>
15194
15195 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15196 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15197
15198 2019-01-23 Tom Tromey <tom@tromey.com>
15199 Andrew Burgess <andrew.burgess@embecosm.com>
15200 Pedro Alves <palves@redhat.com>
15201
15202 * infrun.c (fetch_inferior_event): Use scope_exit.
15203 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15204 * top.c (execute_command): Use scope_exit.
15205 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15206 * utils.c (do_bpstat_clear_actions_cleanup)
15207 (make_bpstat_clear_actions_cleanup): Remove.
15208
15209 2019-01-23 Tom Tromey <tom@tromey.com>
15210 Pedro Alves <palves@redhat.com>
15211
15212 * infrun.c: Include "common/scope-exit.h"
15213 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15214 (wait_for_inferior): Use SCOPE_EXIT.
15215 (fetch_inferior_event): Use scope_exit.
15216
15217 2019-01-23 Tom Tromey <tom@tromey.com>
15218 Pedro Alves <palves@redhat.com>
15219
15220 * breakpoint.c (create_breakpoint): Remove cleanup.
15221
15222 2019-01-23 Tom Tromey <tom@tromey.com>
15223 Andrew Burgess <andrew.burgess@embecosm.com>
15224 Pedro Alves <palves@redhat.com>
15225
15226 2019-01-23 Pedro Alves <palves@redhat.com>
15227
15228 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15229
15230 2019-01-23 Pedro Alves <palves@redhat.com>
15231 Andrew Burgess <andrew.burgess@embecosm.com>
15232
15233 * gdbthread.h: Include "common/forward-scope-exit.h".
15234 (scoped_finish_thread_state): Redefine custom class in terms of
15235 forward_scope_exit.
15236
15237 2019-01-23 Pedro Alves <palves@redhat.com>
15238 Andrew Burgess <andrew.burgess@embecosm.com>
15239
15240 * common/forward-scope-exit.h: New file.
15241
15242 2019-01-23 Pedro Alves <palves@redhat.com>
15243 Andrew Burgess <andrew.burgess@embecosm.com>
15244 Tom Tromey <tom@tromey.com>
15245
15246 * common/scope-exit.h: New file.
15247
15248 2019-01-23 Pedro Alves <palves@redhat.com>
15249
15250 * common/preprocessor.h (ESC): Rename to ...
15251 (ESC_PARENS): ... this.
15252 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15253 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15254
15255 2019-01-23 Tom Tromey <tom@tromey.com>
15256
15257 * language.h (class scoped_switch_to_sym_language_if_auto):
15258 Initialize m_lang in both cases.
15259
15260 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15261
15262 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15263 with XCNEW.
15264
15265 2019-01-22 Tom Tromey <tom@tromey.com>
15266
15267 * corelow.c: Do not include sys/file.h.
15268
15269 2019-01-22 Tom Tromey <tom@tromey.com>
15270
15271 * tui/tui-wingeneral.h: Include gdb_curses.h.
15272
15273 2019-01-22 Tom Tromey <tom@tromey.com>
15274
15275 * source-cache.h (class source_cache) <get_source_lines,
15276 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15277
15278 2019-01-22 Tom Tromey <tom@tromey.com>
15279
15280 * remote-fileio.h (struct remote_target): Declare.
15281
15282 2019-01-22 Tom Tromey <tom@tromey.com>
15283
15284 * python/py-arch.c: Do not include py-ref.h.
15285 * python/py-bpevent.c: Do not include py-ref.h.
15286 * python/py-cmd.c: Do not include py-ref.h.
15287 * python/py-continueevent.c: Do not include py-ref.h.
15288 * python/py-event.h: Do not include py-ref.h.
15289 * python/py-evtregistry.c: Do not include py-ref.h.
15290 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15291 * python/py-frame.c: Do not include py-ref.h.
15292 * python/py-framefilter.c: Do not include py-ref.h.
15293 * python/py-function.c: Do not include py-ref.h.
15294 * python/py-infevents.c: Do not include py-ref.h.
15295 * python/py-linetable.c: Do not include py-ref.h.
15296 * python/py-objfile.c: Do not include py-ref.h.
15297 * python/py-param.c: Do not include py-ref.h.
15298 * python/py-prettyprint.c: Do not include py-ref.h.
15299 * python/py-progspace.c: Do not include py-ref.h.
15300 * python/py-symbol.c: Do not include py-ref.h.
15301 * python/py-symtab.c: Do not include py-ref.h.
15302 * python/py-type.c: Do not include py-ref.h.
15303 * python/py-unwind.c: Do not include py-ref.h.
15304 * python/py-utils.c: Do not include py-ref.h.
15305 * python/py-value.c: Do not include py-ref.h.
15306 * python/py-varobj.c: Do not include py-ref.h.
15307 * python/py-xmethods.c: Do not include py-ref.h.
15308 * python/python.c: Do not include py-ref.h.
15309 * varobj.c: Do not include py-ref.h.
15310
15311 2019-01-22 Tom Tromey <tom@tromey.com>
15312
15313 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15314 keyword for bcache.
15315
15316 2019-01-22 Tom Tromey <tom@tromey.com>
15317
15318 * compile/compile-cplus-types.c: Remove a comment by #include.
15319
15320 2019-01-22 Tom Tromey <tom@tromey.com>
15321
15322 * compile/gcc-c-plugin.h: Include compile-internal.h.
15323
15324 2019-01-22 Tom Tromey <tom@tromey.com>
15325
15326 * stabsread.c (EXTERN): Do not define.
15327 (symnum, next_symbol_text_func, processing_gcc_compilation)
15328 (within_function, global_sym_chain, global_stabs)
15329 (previous_stab_code, this_object_header_files)
15330 (n_this_object_header_files)
15331 (n_allocated_this_object_header_files): Define.
15332 * stabsread.h (EXTERN): Never define. Use "extern".
15333
15334 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15335
15336 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15337 history_value.
15338
15339 2019-01-21 Tom Tromey <tom@tromey.com>
15340
15341 * ui-out.c: Fix includes.
15342 * tui/tui-source.c: Fix includes.
15343 * target.c: Fix includes.
15344 * remote.c: Fix includes.
15345 * regcache.c: Fix includes.
15346 * python/py-block.c: Fix includes.
15347 * printcmd.c: Fix includes.
15348 * or1k-tdep.c: Fix includes.
15349 * mi/mi-main.c: Fix includes.
15350 * m32r-tdep.c: Fix includes.
15351 * csky-tdep.c: Fix includes.
15352 * compile/compile-cplus-types.c: Fix includes.
15353 * cli/cli-interp.c: Fix includes.
15354
15355 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15356
15357 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15358 for padding.
15359
15360 2019-01-16 Tom Tromey <tom@tromey.com>
15361
15362 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15363 earlier.
15364 (struct objfile) <msymbols_range>: Move from top level.
15365 <msymbols>: New method.
15366 (class objfile_msymbols): Remove.
15367 * symtab.c (default_collect_symbol_completion_matches_break_on):
15368 Update.
15369 * symmisc.c (dump_msymbols): Update.
15370 * stabsread.c (scan_file_globals): Update.
15371 * objc-lang.c (info_selectors_command, info_classes_command)
15372 (find_methods): Update.
15373 * minsyms.c (find_solib_trampoline_target): Update.
15374 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15375 * coffread.c (coff_symfile_read): Update.
15376 * ada-lang.c (ada_lookup_simple_minsym)
15377 (ada_collect_symbol_completion_matches): Update.
15378
15379 2019-01-16 Tom Tromey <tom@tromey.com>
15380
15381 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15382 type. Remove no-argument constructor.
15383 <iterator::operator++>: Simplify.
15384 <begin>: Update.
15385 <end>: Use minimal_symbol_count.
15386
15387 2019-01-16 Tom Tromey <tom@tromey.com>
15388
15389 * objfiles.h (struct objfile) <psymtabs>: New method.
15390 (class objfile_psymtabs): Remove.
15391 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15392 typedef.
15393 <range>: New method.
15394 (require_partial_symbols): Change return type.
15395 * psymtab.c (require_partial_symbols)
15396 (psym_expand_symtabs_matching): Update.
15397 * mdebugread.c (parse_partial_symbols): Update.
15398 * dbxread.c (dbx_end_psymtab): Update.
15399
15400 2019-01-15 Tom Tromey <tom@tromey.com>
15401
15402 * symtab.c (lookup_objfile_from_block)
15403 (lookup_symbol_in_objfile_symtabs)
15404 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15405 (find_line_symtab, info_sources_command)
15406 (default_collect_symbol_completion_matches_break_on)
15407 (make_source_files_completion_list): Update.
15408 * symmisc.c (print_objfile_statistics, dump_objfile)
15409 (maintenance_print_symbols, maintenance_info_symtabs)
15410 (maintenance_check_symtabs, maintenance_info_line_tables):
15411 Update.
15412 * source.c (select_source_symtab)
15413 (forget_cached_source_info_for_objfile): Update.
15414 * objfiles.h (class objfile_compunits): Remove.
15415 (struct objfile) <compunits_range>: New typedef.
15416 (compunits): New method.
15417 * objfiles.c (objfile_relocate1): Update.
15418 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15419 * maint.c (count_symtabs_and_blocks): Update.
15420 * linespec.c (iterate_over_all_matching_symtabs): Update.
15421 * cp-support.c (add_symbol_overload_list_qualified): Update.
15422 * coffread.c (coff_symtab_read): Update.
15423 * ada-lang.c (add_nonlocal_symbols)
15424 (ada_collect_symbol_completion_matches)
15425 (ada_add_global_exceptions): Update.
15426
15427 2019-01-15 Tom Tromey <tom@tromey.com>
15428
15429 * progspace.h (program_space) <objfiles_safe_range>: New
15430 typedef.
15431 <objfiles_safe>: New method.
15432 * objfiles.h (class all_objfiles_safe): Remove.
15433 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15434 * jit.c (jit_inferior_exit_hook): Update.
15435
15436 2019-01-17 Tom Tromey <tom@tromey.com>
15437
15438 * progspace.h (program_space) <objfiles_range>: New typedef.
15439 <objfiles>: New method.
15440 <objfiles_head>: Rename from objfiles.
15441 (object_files): Update.
15442 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15443 * guile/scm-pretty-print.c
15444 (ppscm_find_pretty_printer_from_objfiles): Update.
15445 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15446 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15447 Update.
15448 * python/py-progspace.c (pspy_get_objfiles): Update.
15449 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15450 Update.
15451 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15452 (objfpy_lookup_objfile_by_build_id): Update.
15453 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15454 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15455 Update.
15456 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15457 (expand_symtab_containing_pc, lookup_objfile_from_block)
15458 (lookup_static_symbol, basic_lookup_transparent_type)
15459 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15460 (find_line_symtab, info_sources_command)
15461 (default_collect_symbol_completion_matches_break_on)
15462 (make_source_files_completion_list, find_main_name): Update.
15463 * symmisc.c (print_symbol_bcache_statistics)
15464 (print_objfile_statistics, maintenance_print_symbols)
15465 (maintenance_print_msymbols, maintenance_print_objfiles)
15466 (maintenance_info_symtabs, maintenance_check_symtabs)
15467 (maintenance_expand_symtabs, maintenance_info_line_tables):
15468 Update.
15469 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15470 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15471 (map_overlay_command, unmap_overlay_command)
15472 (simple_overlay_update, expand_symtabs_matching)
15473 (map_symbol_filenames): Update.
15474 * symfile-debug.c (set_debug_symfile): Update.
15475 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15476 Update.
15477 * source.c (select_source_symtab, forget_cached_source_info):
15478 Update.
15479 * solib.c (solib_read_symbols): Update.
15480 * solib-spu.c (append_ocl_sos): Update.
15481 * psymtab.c (maintenance_print_psymbols)
15482 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15483 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15484 * printcmd.c (info_symbol_command): Update.
15485 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15486 Update.
15487 * objfiles.h (class all_objfiles): Remove.
15488 * objfiles.c (have_partial_symbols, have_full_symbols)
15489 (have_minimal_symbols, qsort_cmp, update_section_map)
15490 (shared_objfile_contains_address_p)
15491 (default_iterate_over_objfiles_in_search_order): Update.
15492 * objc-lang.c (info_selectors_command, info_classes_command)
15493 (find_methods): Update.
15494 * minsyms.c (find_solib_trampoline_target): Update.
15495 * maint.c (maintenance_info_sections)
15496 (maintenance_translate_address, count_symtabs_and_blocks):
15497 Update.
15498 * main.c (captured_main_1): Update.
15499 * linux-thread-db.c (try_thread_db_load_from_pdir)
15500 (has_libpthread): Update.
15501 * linespec.c (iterate_over_all_matching_symtabs)
15502 (search_minsyms_for_name): Update.
15503 * jit.c (jit_find_objf_with_entry_addr): Update.
15504 * hppa-tdep.c (find_unwind_entry)
15505 (hppa_lookup_stub_minimal_symbol): Update.
15506 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15507 Update.
15508 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15509 (elf_gnu_ifunc_resolve_by_got): Update.
15510 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15511 * dwarf-index-write.c (save_gdb_index_command): Update.
15512 * cp-support.c (add_symbol_overload_list_qualified): Update.
15513 * breakpoint.c (create_overlay_event_breakpoint)
15514 (create_longjmp_master_breakpoint)
15515 (create_std_terminate_master_breakpoint)
15516 (create_exception_master_breakpoint): Update.
15517 * blockframe.c (find_pc_partial_function): Update.
15518 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15519 (ada_collect_symbol_completion_matches)
15520 (ada_add_global_exceptions): Update.
15521
15522 2019-01-17 Tom Tromey <tom@tromey.com>
15523
15524 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15525 declare VEC.
15526 (solib_target_parse_libraries): Change return type.
15527 (library_list_start_segment, library_list_start_section)
15528 (library_list_end_library, library_list_start_library); Update.
15529 (solib_target_free_library_list): Remove.
15530 (solib_target_parse_libraries): Remove cleanup. Change return
15531 type.
15532 (solib_target_current_sos): Update.
15533
15534 2019-01-17 Tom Tromey <tromey@bapiya>
15535
15536 * valprint.c: Replace "the the" with "the".
15537 * symtab.c: Replace "the the" with "the".
15538 * solib.c: Replace "the the" with "the".
15539 * solib-dsbt.c: Replace "the the" with "the".
15540 * linespec.c: Replace "the the" with "the".
15541 * dwarf2loc.h: Replace "the the" with "the".
15542 * amd64-windows-tdep.c: Replace "the the" with "the".
15543 * aarch64-tdep.c: Replace "the the" with "the".
15544
15545 2019-01-16 Keith Seitz <keiths@redhat.com>
15546
15547 PR gdb/23773
15548 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15549 <builder>: Rename to ..
15550 <m_builder>: ... this and make private.
15551 (dwarf2_cu::get_builder): New method. Change all users of
15552 `builder' to use this method.
15553 (dwarf2_start_symtab): Move to ...
15554 (dwarf2_cu::start_symtab): ... here. Update all callers
15555 (setup_type_unit_groups): Move to ...
15556 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15557 callers.
15558 (dwarf2_cu::reset_builder): New method.
15559 (process_full_compunit, process_full_type_unit): Use
15560 dwarf2_cu::reset_builder.
15561 (follow_die_offset): Record the ancestor CU if it is different
15562 from the followed DIE's CU.
15563 (follow_die_sig_1): Likewise.
15564
15565 2019-01-15 Tom Tromey <tom@tromey.com>
15566
15567 * remote.c (class remote_state) <buf>: Now a char_vector.
15568 <buf_size>: Remove.
15569 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15570 parameter.
15571 (remote_target::getpkt_or_notif_sane_1)
15572 (remote_target::getpkt_sane)
15573 (remote_target::getpkt_or_notif_sane): Likewise.
15574 (class remote_target) <putpkt>: New overload.
15575 (remote_target::read_frame): Change type of "buf_p". Remove
15576 sizeof_p parameter.
15577 (packet_ok): New overload.
15578 (packet_check_result): New overload.
15579 Update all uses.
15580
15581 2019-01-14 Tom Tromey <tom@tromey.com>
15582
15583 * remote-notif.c (handle_notification, remote_notif_ack)
15584 (remote_notif_parse): Make "buf" const.
15585 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15586 const.
15587 (remote_notif_parse, remote_notif_ack, handle_notification):
15588 Likewise.
15589 * remote.c (remote_notif_stop_parse): Make "buf" const.
15590 (remote_target::remote_parse_stop_reply): Make "buf" const.
15591 (remote_notif_stop_ack): Make "buf" const.
15592
15593 2019-01-14 Tom Tromey <tom@tromey.com>
15594
15595 * remote.c (remote_console_output): Make parameter const.
15596
15597 2019-01-14 Tom Tromey <tom@tromey.com>
15598
15599 * target-debug.h (target_debug_print_signals): Constify.
15600 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15601 * procfs.c (procfs_target::pass_signals): Update.
15602 * linux-nat.c (linux_nat_target::pass_signals): Update.
15603 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15604 * target-delegates.c: Rebuild.
15605 * remote.c (remote_target::program_signals): Update.
15606 (remote_target::pass_signals): Update.
15607 * target.c (target_pass_signals): Constify argument.
15608 (target_program_signals): Likewise.
15609 * target.h (struct target_ops) <pass_signals, program_signals>:
15610 Constify argument.
15611 (target_pass_signals, target_program_signals): Constify argument.
15612
15613 2019-01-14 Tom Tromey <tom@tromey.com>
15614
15615 PR tui/28819:
15616 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15617
15618 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15619
15620 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15621 field.
15622 * rs6000-tdep.c: Include reggroups.h.
15623 (IS_V_ALIAS_PSEUDOREG): Define.
15624 (rs6000_register_name): Return names for the "vX" aliases.
15625 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15626 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15627 aliases. Call default_register_reggroup_p for all other
15628 pseudo-registers.
15629 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15630 New functions.
15631 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15632 Handle "vX" aliases.
15633 (v_alias_pseudo_register_collect): New function.
15634 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15635 (rs6000_gdbarch_init): Initialize "vX" aliases as
15636 pseudo-registers. Restore registration of
15637 rs6000_pseudo_register_reggroup_p with
15638 set_tdesc_pseudo_register_reggroup_p.
15639
15640 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15641
15642 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15643 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15644 set_gdbarch_num_pseudo_regs.
15645
15646 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15647
15648 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15649 Remove arg prefixname, add do_set and do_show.
15650 Add member functions set_list and show_list.
15651 * cli/cli-style.c (class cli_style_option): Update accordingly.
15652 (style_set_list): Move to file scope.
15653 (style_show_list): Likewise.
15654 (set_style): Call help_list.
15655 (show_style): Call cmd_show_list.
15656 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15657 Update to use the new macro.
15658
15659 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15660
15661 * ada-lang.c (_initialize_ada_language): Expand the help text
15662 for the "catch exception" command.
15663
15664 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15665
15666 * symtab.c (matching_obj_sections): Initialize obj,
15667 declare it closer to its usage.
15668
15669 2019-01-10 Tom Tromey <tom@tromey.com>
15670
15671 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15672 (basic_inf_threads_range): Remove.
15673 (inf_threads_range, inf_non_exited_threads_range)
15674 (safe_inf_threads_range): Use next_adapter.
15675
15676 2019-01-10 Keith Seitz <keiths@redhat.com>
15677
15678 PR gdb/23712
15679 PR symtab/23010
15680 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15681 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15682
15683 2019-01-10 Keith Seitz <keiths@redhat.com>
15684
15685 PR gdb/23712
15686 PR symtab/23010
15687 * dictionary.c (pending_to_vector): Remove.
15688 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15689 Remove _1 suffix, replacing functions of the same name. Update
15690 all callers.
15691 (dict_create_hashed, dict_create_hashed_expandable)
15692 (dict_create_linear, dict_create_linear_expandable, dict_free)
15693 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15694 Make functions static.
15695
15696 2019-01-10 Keith Seitz <keiths@redhat.com>
15697
15698 PR gdb/23712
15699 PR symtab/23010
15700 * dictionary.h (struct dictionary): Replace declaration with
15701 multidictionary.
15702 (dict_create_hashed, dict_create_hashed_expandable)
15703 (dict_create_linear, dict_create_linear_expandable)
15704 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15705 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15706 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15707 taking multidictionary argument.
15708 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15709 * block.h (struct block) <dict>: Change to multidictionary
15710 and rename `multidict'.
15711 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15712 symmisc.c: Update all dictionary references to multidictionary.
15713
15714 2019-01-10 Keith Seitz <keiths@redhat.com>
15715
15716 PR gdb/23712
15717 PR symtab/23010
15718 * dictionary.c: Include unordered_map.
15719 (pending_to_vector): New function.
15720 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15721 Rewrite the non-"_1" functions to take vector instead
15722 of linked list.
15723 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15724 "new" _1 versions of the same name.
15725 (multidictionary): Define.
15726 (std::hash<enum language): New definition.
15727 (collate_pending_symbols_by_language, mdict_create_hashed)
15728 (mdict_create_hashed_expandable, mdict_create_linear)
15729 (mdict_create_linear_expandable, mdict_free)
15730 (find_language_dictionary, create_new_language_dictionary)
15731 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15732 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15733 (mdict_size, mdict_empty): New functions.
15734 * dictionary.h (mdict_iterator): Define.
15735
15736 2019-01-10 Pedro Alves <palves@redhat.com>
15737
15738 * breakpoint.c (read_uploaded_action)
15739 (create_tracepoint_from_upload): Adjust to use
15740 gdb::unique_xmalloc_ptr.
15741 * ctf.c (ctf_write_uploaded_tp):
15742 (SET_ARRAY_FIELD): Use emplace_back.
15743 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15744 * tracefile-tfile.c (tfile_write_uploaded_tp):
15745 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15746 gdb::unique_xmalloc_ptr.
15747 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15748 at_string, cond_string, cmd_strings>: Replace char pointers
15749 with gdb::unique_xmalloc_ptr.
15750
15751 2019-01-10 Pedro Alves <palves@redhat.com>
15752
15753 * solib-target.c (library_list_start_library): Don't xstrdup name.
15754
15755 2019-01-10 Pedro Alves <palves@redhat.com>
15756
15757 * mdebugread.c (parse_partial_symbols): Use
15758 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15759
15760 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15761
15762 * linux-fork.c (scoped_switch_fork_info)
15763 <~scoped_switch_fork_info>: Fix incorrect variable name.
15764
15765 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15766
15767 * linux-fork.c (scoped_switch_fork_info)
15768 <scoped_switch_fork_info>: Make explicit.
15769 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15770
15771 2019-01-10 Tom Tromey <tom@tromey.com>
15772
15773 * objfiles.h (objfile::reset_psymtabs): Update.
15774 * objfiles.c (objfile::objfile): Update.
15775 * psymtab.h (psymtab_storage::obstack): Update.
15776 (psymtab_storage::m_obstack): Use gdb::optional.
15777 (class psymtab_storage): Update comment. Remove objfile
15778 parameter.
15779 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15780
15781 2019-01-10 Tom Tromey <tom@tromey.com>
15782
15783 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15784 <free_psymtabs>: Now private.
15785 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15786 (allocate_psymtab): Use new method.
15787
15788 2019-01-10 Tom Tromey <tom@tromey.com>
15789
15790 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15791 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15792 * mdebugread.c (parse_partial_symbols): Use
15793 allocate_dependencies.
15794 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15795 allocate_dependencies.
15796 (process_psymtab_comp_unit_reader)
15797 (build_type_psymtab_dependencies): Likewise.
15798 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15799
15800 2019-01-10 Tom Tromey <tom@tromey.com>
15801
15802 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15803 PSYMBOL_SET_LANGUAGE.
15804 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15805
15806 2019-01-10 Tom Tromey <tom@tromey.com>
15807
15808 * psymtab.h (psymtab_storage::obstack): New method.
15809 <m_obstack>: Rename from obstack; now private.
15810 * psymtab.c (psymtab_storage): Update.
15811 * dwarf2read.c (create_addrmap_from_index)
15812 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15813 Update.
15814
15815 2019-01-10 Tom Tromey <tom@tromey.com>
15816
15817 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15818 * objfiles.h (objfile::reset_psymtabs): New method.
15819
15820 2019-01-10 Tom Tromey <tom@tromey.com>
15821
15822 * symmisc.c (print_symbol_bcache_statistics): Update.
15823 (print_objfile_statistics): Update.
15824 * symfile.c (reread_symbols): Update.
15825 * psymtab.h (class psymtab_storage): New.
15826 * psymtab.c (psymtab_storage): New constructor.
15827 (~psymtab_storage): New destructor.
15828 (require_partial_symbols): Update.
15829 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15830 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15831 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15832 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15833 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15834 (start_psymtab_common, end_psymtab_common)
15835 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15836 (allocate_psymtab): Update.
15837 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15838 Update.
15839 (dump_psymtab_addrmap, maintenance_print_psymbols)
15840 (maintenance_check_psymtabs): Update.
15841 (class objfile_psymtabs): Move to objfiles.h.
15842 * psympriv.h (discard_psymtab): Now inline.
15843 (psymtab_discarder::psymtab_discarder): Update.
15844 (psymtab_discarder::~psymtab_discarder): Update.
15845 (ALL_OBJFILE_PSYMTABS): Rewrite.
15846 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15847 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15848 Remove fields.
15849 <partial_symtabs>: New field.
15850 (class objfile_psymtabs): Move from psymtab.h. Update.
15851 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15852 psymbol_cache.
15853 (objfile::~objfile): Don't destroy psymbol_cache.
15854 * mdebugread.c (parse_partial_symbols): Update.
15855 * dwarf2read.c (create_addrmap_from_index)
15856 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15857 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15858 (add_partial_subprogram, dwarf2_ranges_read): Update.
15859 * dwarf-index-write.c (write_address_map)
15860 (write_one_signatured_type, recursively_write_psymbols)
15861 (class debug_names, class debug_names, write_psymtabs_to_index):
15862 Update.
15863
15864 2019-01-10 Tom Tromey <tom@tromey.com>
15865
15866 * symtab.h (SYMBOL_SET_NAMES): Update.
15867 (symbol_set_names): Update.
15868 (MSYMBOL_SET_NAMES): Update.
15869 * symtab.c (symbol_set_names): Change argument to be an
15870 objfile_per_bfd_storage.
15871 * psymtab.c (add_psymbol_to_bcache): Update.
15872 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15873
15874 2019-01-10 Tom Tromey <tom@tromey.com>
15875
15876 * symtab.c (create_demangled_names_hash): Change argument to be an
15877 objfile_per_bfd_storage.
15878 (symbol_set_names): Update.
15879
15880 2019-01-10 Tom Tromey <tom@tromey.com>
15881
15882 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15883 init_psymbol_list.
15884 * psymtab.c (init_psymbol_list): Do nothing if already called.
15885 * psympriv.h (init_psymbol_list): Add comment.
15886 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15887 init_psymbol_list.
15888 * dbxread.c (dbx_symfile_read): Unconditionally call
15889 init_psymbol_list.
15890
15891 2019-01-10 Tom Tromey <tom@tromey.com>
15892
15893 * xcoffread.c (scan_xcoff_symtab): Update.
15894 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15895 "where".
15896 * mdebugread.c (parse_partial_symbols)
15897 (handle_psymbol_enumerators): Update.
15898 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15899 * dbxread.c (read_dbx_symtab): Update.
15900 * psympriv.h (psymbol_placement): New enum.
15901 (add_psymbol_to_list): Update.
15902
15903 2019-01-10 Tom Tromey <tom@tromey.com>
15904
15905 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15906 static_psymbols parameters.
15907 (scan_xcoff_symtab): Update.
15908 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15909 static_psymbols parameters.
15910 * psympriv.h (start_psymtab_common): Update.
15911 * mdebugread.c (parse_partial_symbols): Update.
15912 * dwarf2read.c (create_partial_symtab): Update.
15913 * dbxread.c (read_dbx_symtab): Update.
15914 (start_psymtab): Remove global_psymbols and static_psymbols
15915 parameters.
15916
15917 2019-01-10 Tom Tromey <tom@tromey.com>
15918
15919 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15920 * psymtab.c (allocate_psymtab): Add comment.
15921 * psympriv.h (allocate_psymtab): Add comment.
15922 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15923 initializations.
15924 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15925
15926 2019-01-10 Tom Tromey <tom@tromey.com>
15927
15928 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15929 Don't declare.
15930 * mipsread.c: Include mdebugread.h.
15931 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15932 Declare.
15933 * elfread.c: Include mdebugread.h.
15934
15935 2019-01-09 Tom Tromey <tom@tromey.com>
15936
15937 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15938 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15939 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15940 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15941 (psym_lookup_symbol, psym_find_last_source_symtab)
15942 (psym_forget_cached_source_info, psym_print_stats)
15943 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15944 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15945 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15946 (psym_find_compunit_symtab_by_address)
15947 (maintenance_print_psymbols, maintenance_info_psymtabs)
15948 (maintenance_check_psymtabs): Use ranged for.
15949 * psymtab.h (class objfile_psymtabs): New.
15950 (require_partial_symbols): Return objfile_psymtabs.
15951 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15952
15953 2019-01-09 Tom Tromey <tom@tromey.com>
15954
15955 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15956 (find_pc_mapped_section, list_overlays_command)
15957 (map_overlay_command, unmap_overlay_command)
15958 (simple_overlay_update): Use all_objfiles.
15959 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15960 * printcmd.c (info_symbol_command): Use all_objfiles.
15961 * objfiles.h (ALL_OBJSECTIONS): Remove.
15962 * maint.c (maintenance_translate_address): Use all_objfiles.
15963 * gcore.c (gcore_create_callback): Use all_objfiles.
15964 (objfile_find_memory_regions): Likewise.
15965
15966 2019-01-09 Tom Tromey <tom@tromey.com>
15967
15968 * symtab.c (find_line_symtab, info_sources_command)
15969 (make_source_files_completion_list): Use objfile_compunits.
15970 * source.c (select_source_symtab): Use objfile_compunits.
15971 * objfiles.h (struct objfile): Update comment.
15972 (ALL_OBJFILES): Remove.
15973 (ALL_FILETABS): Remove.
15974 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15975 objfile_compunits.
15976
15977 2019-01-09 Tom Tromey <tom@tromey.com>
15978
15979 * symmisc.c (print_objfile_statistics, dump_objfile)
15980 (maintenance_print_symbols): Use compunit_filetabs.
15981 * source.c (forget_cached_source_info_for_objfile): Use
15982 compunit_filetabs.
15983 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15984 (ALL_FILETABS): Use compunit_filetabs.
15985 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15986 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15987
15988 2019-01-09 Tom Tromey <tom@tromey.com>
15989
15990 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15991 (compunit_filetabs): New.
15992 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15993 compunit_filetabs.
15994 (info_sources_command, make_source_files_completion_list): Remove
15995 declaration.
15996 * symmisc.c (print_objfile_statistics, dump_objfile)
15997 (maintenance_print_symbols): Remove declaration.
15998 (maintenance_info_symtabs): Use compunit_filetabs.
15999 (maintenance_info_line_tables): Likewise.
16000 * source.c (select_source_symtab): Change local variable name.
16001 (forget_cached_source_info_for_objfile): Remove declaration.
16002 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16003 * objfiles.c (objfile_relocate1): Remove declaration.
16004 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16005 declaration.
16006 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16007 * coffread.c (coff_symtab_read): Remove declaration.
16008 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16009 compunit_filetabs.
16010
16011 2019-01-09 Tom Tromey <tom@tromey.com>
16012
16013 * symtab.c (lookup_objfile_from_block)
16014 (find_pc_sect_compunit_symtab, search_symbols)
16015 (default_collect_symbol_completion_matches_break_on): Use
16016 objfile_compunits.
16017 * objfiles.h (ALL_COMPUNITS): Remove.
16018 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16019 * cp-support.c (add_symbol_overload_list_qualified): Use
16020 objfile_compunits.
16021 * ada-lang.c (ada_collect_symbol_completion_matches)
16022 (ada_add_global_exceptions): Use objfile_compunits.
16023
16024 2019-01-09 Tom Tromey <tom@tromey.com>
16025
16026 * source.c (select_source_symtab)
16027 (forget_cached_source_info_for_objfile): Remove declaration.
16028 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16029 declaration.
16030 * maint.c (count_symtabs_and_blocks): Remove declaration.
16031 * cp-support.c (add_symbol_overload_list_qualified): Remove
16032 declaration.
16033 * coffread.c (coff_symtab_read): Remove declaration.
16034 * symtab.c (lookup_symbol_in_objfile_symtabs)
16035 (basic_lookup_transparent_type_1): Use objfile_compunits.
16036 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16037 (info_sources_command, search_symbols)
16038 (default_collect_symbol_completion_matches_break_on)
16039 (make_source_files_completion_list): Remove declaration.
16040 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16041 (ada_collect_symbol_completion_matches)
16042 (ada_add_global_exceptions): Remove declaration.
16043 * linespec.c (iterate_over_all_matching_symtabs): Use
16044 objfile_compunits.
16045 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16046 (class objfile_compunits): New.
16047 (ALL_COMPUNITS): Use objfile_compunits.
16048 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16049 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16050 objfile_compunits.
16051 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16052
16053 2019-01-09 Tom Tromey <tom@tromey.com>
16054
16055 * symtab.c (search_symbols)
16056 (default_collect_symbol_completion_matches_break_on): Use
16057 objfile_msymbols.
16058 * ada-lang.c (ada_lookup_simple_minsym)
16059 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16060 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16061 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16062 objfile_msymbols.
16063 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16064 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16065 * objc-lang.c (find_methods): Use objfile_msymbols.
16066 (info_selectors_command, info_classes_command): Likewise.
16067 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16068 * objfiles.h (class objfile_msymbols): New.
16069 (ALL_OBJFILE_MSYMBOLS): Remove.
16070 (ALL_MSYMBOLS): Remove.
16071
16072 2019-01-09 Tom Tromey <tom@tromey.com>
16073
16074 * common/next-iterator.h (next_adapter): Add Iterator template
16075 parameter.
16076 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16077 (class all_objfiles_safe): New.
16078 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16079 * objfiles.c (put_objfile_before): Update comment.
16080 (add_separate_debug_objfile): Likewise.
16081 (free_all_objfiles): Use all_objfiles_safe.
16082 (objfile_purge_solibs): Likewise.
16083
16084 2019-01-09 Tom Tromey <tom@tromey.com>
16085
16086 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16087 (expand_symtab_containing_pc, lookup_static_symbol)
16088 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16089 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16090 all_objfiles.
16091 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16092 * breakpoint.c (create_overlay_event_breakpoint)
16093 (create_longjmp_master_breakpoint)
16094 (create_std_terminate_master_breakpoint)
16095 (create_exception_master_breakpoint): Use all_objfiles.
16096 * linux-thread-db.c (try_thread_db_load_from_pdir)
16097 (has_libpthread): Use all_objfiles.
16098 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16099 * linespec.c (iterate_over_all_matching_symtabs)
16100 (search_minsyms_for_name): Use all_objfiles.
16101 * maint.c (maintenance_info_sections): Use all_objfiles.
16102 * main.c (captured_main_1): Use all_objfiles.
16103 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16104 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16105 * guile/scm-pretty-print.c
16106 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16107 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16108 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16109 (maintenance_print_msymbols): Use all_objfiles.
16110 * source.c (select_source_symtab): Use all_objfiles.
16111 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16112 * symfile.c (remove_symbol_file_command)
16113 (expand_symtabs_matching, map_symbol_filenames): Use
16114 all_objfiles.
16115 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16116 all_objfiles.
16117 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16118 * objc-lang.c (find_methods): Use all_objfiles.
16119 * objfiles.c (have_partial_symbols, have_full_symbols)
16120 (have_minimal_symbols, qsort_cmp)
16121 (default_iterate_over_objfiles_in_search_order): Use
16122 all_objfiles.
16123 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16124 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16125 (maintenance_check_psymtabs): Use all_objfiles.
16126 (ALL_PSYMTABS): Remove.
16127 * compile/compile-object-run.c (do_module_cleanup): Use
16128 all_objfiles.
16129 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16130 * cp-support.c (add_symbol_overload_list_qualified): Use
16131 all_objfiles.
16132 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16133 Use all_objfiles.
16134 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16135 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16136 all_objfiles.
16137 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16138 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16139 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16140 Uses all_objfiles.
16141 * solib.c (solib_read_symbols): Use all_objfiles
16142
16143 2019-01-09 Tom Tromey <tom@tromey.com>
16144
16145 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16146 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16147 all_objfiles.
16148 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16149 * symmisc.c (print_symbol_bcache_statistics)
16150 (print_objfile_statistics, maintenance_print_objfiles)
16151 (maintenance_info_symtabs, maintenance_check_symtabs)
16152 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16153 all_objfiles.
16154 * source.c (forget_cached_source_info): Use all_objfiles.
16155 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16156 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16157 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16158 * objfiles.c (update_section_map): Use all_objfiles.
16159 (shared_objfile_contains_address_p): Likewise.
16160 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16161 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16162
16163 2019-01-09 Tom Tromey <tom@tromey.com>
16164
16165 * common/next-iterator.h: New file.
16166 * objfiles.h (class all_objfiles): New.
16167 (struct objfile_iterator): New.
16168
16169 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16170
16171 * NEWS: Move the description of the changed "frame", "select-frame",
16172 and "info frame" commands to the Changed commands section.
16173
16174 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16175
16176 * gdbtypes.c (check_stub_method_group): Remove handling of old
16177 mangling schemes.
16178 * linespec.c (find_methods): Likewise.
16179 * stabsread.c (read_member_functions): Likewise.
16180 * valops.c (search_struct_method): Likewise.
16181 (value_struct_elt_for_reference): Likewise.
16182 * NEWS: Mention this change.
16183
16184 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16185
16186 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16187 print_source_lines.
16188 * source.c (print_source_lines_base): Update line number check.
16189 (print_source_lines): New function.
16190 (source_lines_range::source_lines_range): New function.
16191 * source.h (class source_lines_range): New class.
16192 (print_source_lines): New declaration.
16193
16194 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16195
16196 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16197
16198 2019-01-08 Tom Tromey <tom@tromey.com>
16199 Simon Marchi <simon.marchi@ericsson.com>
16200
16201 PR gdb/24060
16202 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16203 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16204 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16205 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16206 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16207 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16208
16209 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16210
16211 * source.c (select_source_symtab): Move header comment to
16212 declaration in source.h.
16213 (forget_cached_source_info_for_objfile): Likewise.
16214 (forget_cached_source_info): Likewise.
16215 (identify_source_line): Likewise.
16216 * source.h (identify_source_line): Move declaration from symtab.h
16217 and add comment from source.c
16218 (print_source_lines): Likewise.
16219 (forget_cached_source_info_for_objfile): Likewise.
16220 (forget_cached_source_info): Likewise.
16221 (select_source_symtab): Likewise.
16222 (enum print_source_lines_flag): Move definition from symtab.h.
16223 * symtab.h (identify_source_line): Move declaration to source.h.
16224 (print_source_lines): Likewise.
16225 (forget_cached_source_info_for_objfile): Likewise.
16226 (forget_cached_source_info): Likewise.
16227 (select_source_symtab): Likewise.
16228 (enum print_source_lines_flag): Move definition to source.h.
16229 * tui/tui-hooks.c: Add 'source.h' include.
16230
16231 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16232
16233 * source.c (print_source_lines_base): Handle requests to print
16234 reverse line number sequences, and guard against empty lines
16235 string.
16236
16237 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16238
16239 * source.c (print_source_lines_base): Fix skip of '\r' if next
16240 character is '\n'.
16241
16242 2019-01-06 Tom Tromey <tom@tromey.com>
16243
16244 * c-exp.y (struct c_parse_state) <macro_original_text,
16245 expansion_obstack>: New member.
16246 (macro_original_text, expansion_obstack): Remove globals.
16247 (scan_macro_expansion, scanning_macro_expansion)
16248 (finished_macro_expansion): Update.
16249 (scan_macro_cleanup): Remove.
16250 (yylex, c_parse): Update.
16251
16252 2019-01-06 Tom Tromey <tom@tromey.com>
16253
16254 * c-exp.y (struct c_parse_state) <strings>: New member.
16255 (operator_stoken): Update.
16256
16257 2019-01-06 Tom Tromey <tom@tromey.com>
16258
16259 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16260 (union type_stack_elt) <typelist_val>: Now a pointer to
16261 std::vector.
16262 (type_stack_cleanup): Don't declare.
16263 (push_typelist): Update.
16264 * parse.c (pop_typelist): Return a std::vector.
16265 (push_typelist): Take a std::vector.
16266 (follow_types): Update. Do not free args.
16267 (type_stack_cleanup): Remove.
16268 * c-exp.y (struct c_parse_state): New.
16269 (cpstate): New global.
16270 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16271 (nonempty_typelist): Update.
16272 (func_mod): Create a new vector.
16273 (c_parse): Create a c_parse_state.
16274 (check_parameter_typelist): Do not delete params.
16275 (function_method): Update. Do not delete type_list.
16276
16277 2019-01-06 Tom Tromey <tom@tromey.com>
16278
16279 PR gdb/28155:
16280 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16281 check_typedef.
16282 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16283 (print_return_value): Likewise.
16284
16285 2019-01-05 Tom Tromey <tom@tromey.com>
16286
16287 * contrib/cleanup_check.py: Remove.
16288 * contrib/gcc-with-excheck: Remove.
16289 * contrib/exsummary.py: Remove.
16290 * contrib/excheck.py: Remove.
16291
16292 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16293
16294 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16295 NULL. Initialize tpprev to NULL instead of assigning it
16296 to NULL on the next statement.
16297 * windows-nat.c (windows_delete_thread): Remove check for
16298 main_thread_id before printing thread exit notifications.
16299 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16300 Remove thread ID check against main_thread_id.
16301 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16302 windows_delete_thread.
16303 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16304
16305 2019-01-04 Tom Tromey <tom@tromey.com>
16306
16307 * compile/compile.c (_initialize_compile): Use upper case for
16308 metasyntactic variables.
16309 * symmisc.c (_initialize_symmisc): Use upper case for
16310 metasyntactic variables.
16311 * psymtab.c (_initialize_psymtab): Use upper case for
16312 metasyntactic variables.
16313 * demangle.c (demangle_command): Use upper case for metasyntactic
16314 variables.
16315 (_initialize_demangler): Likewise.
16316 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16317 variables.
16318
16319 2019-01-03 Tom Tromey <tom@tromey.com>
16320
16321 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16322
16323 2019-01-03 Tom Tromey <tom@tromey.com>
16324
16325 * python/py-symtab.c (salpy_str): Update.
16326 (struct salpy_sal_object) <symtab>: Now a PyObject.
16327 (salpy_dealloc): Update.
16328 (del_objfile_sal): Use gdbpy_ref.
16329
16330 2019-01-03 Tom Tromey <tom@tromey.com>
16331
16332 * python/py-type.c (convert_field): Use new_reference. Return
16333 gdbpy_ref.
16334 (make_fielditem): Return gdbpy_ref.
16335 (typy_fields): Update.
16336 (typy_getitem): Update.
16337 (field_name): Return gdbpy_ref. Use new_reference.
16338 (typy_iterator_iternext): Update.
16339
16340 2019-01-03 Tom Tromey <tom@tromey.com>
16341
16342 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16343
16344 2019-01-03 Tom Tromey <tom@tromey.com>
16345
16346 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16347 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16348 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16349 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16350 (pspy_set_type_printers): Likewise.
16351 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16352 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16353 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16354 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16355 (objfpy_set_type_printers): Likewise.
16356
16357 2019-01-03 Tom Tromey <tom@tromey.com>
16358
16359 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16360 (gdbpy_print_stack): Use gdbpy_err_fetch.
16361 * python/python-internal.h (class gdbpy_err_fetch): New class.
16362 (class gdbpy_enter) <m_error_type, m_error_value,
16363 m_error_traceback>: Remove.
16364 <m_error>: New member.
16365 (gdbpy_exception_to_string): Don't declare.
16366 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16367 * python/py-value.c (convert_value_from_python): Use
16368 gdbpy_err_fetch.
16369 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16370 gdbpy_exception_to_string.
16371 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16372 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16373 gdbpy_err_fetch.
16374
16375 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16376
16377 * linux-nat.c (delete_lwp_cleanup): Delete.
16378 (struct lwp_deleter): New struct.
16379 (lwp_info_up): New typedef.
16380 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16381 lwp_info_up.
16382
16383 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16384
16385 * linux-fork.c (class scoped_switch_fork_info): New class.
16386 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16387
16388 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16389
16390 * valops.c (find_overload_match): Remove use of null_cleanup, and
16391 calls to do_cleanups.
16392
16393 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16394
16395 * compile/compile-cplus-types.c
16396 (compile_cplus_instance::decl_name): Handle changes to
16397 cp_func_name.
16398 * cp-support.c (cp_func_name): Update header comment, update
16399 return type.
16400 * cp-support.h (cp_func_name): Update return type in declaration.
16401 * valops.c (find_overload_match): Move temp_func local to top
16402 level of function and change its type. Use temp_func to hold and
16403 delete temporary string obtained from cp_func_name.
16404
16405 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16406
16407 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16408 gdb::char_vector, remove cleanup, and update uses of `msg`.
16409
16410 2019-01-03 Jim Wilson <jimw@sifive.com>
16411
16412 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16413
16414 2019-01-02 Tom Tromey <tom@tromey.com>
16415
16416 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16417 (tdesc_parse_xml): Remove cleanups.
16418 * target-descriptions.h (make_cleanup_free_target_description):
16419 Don't declare.
16420 (target_desc_deleter): New struct.
16421 (target_desc_up): New typedef.
16422 * target-descriptions.c (target_desc_deleter::operator()): Rename
16423 from free_target_description.
16424 (make_cleanup_free_target_description): Remove.
16425
16426 2019-01-02 Tom Tromey <tom@tromey.com>
16427
16428 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16429 constructor, destructor.
16430 (linespec_parser): Remove typedef.
16431 (~linespec_parser): Rename from linespec_parser_delete.
16432 (linespec_lex_to_end, linespec_complete_label)
16433 (linespec_complete): Update.
16434 (decode_line_full): Remove cleanups.
16435 (decode_line_1): Update.
16436
16437 2019-01-02 Tom Tromey <tom@tromey.com>
16438
16439 * python/python-internal.h (inferior_to_inferior_object): Change
16440 return type.
16441 * python/py-exitedevent.c (create_exited_event_object): Update.
16442 * python/py-inferior.c (inferior_to_inferior_object): Return
16443 gdbpy_ref.
16444 (python_new_inferior, python_inferior_deleted)
16445 (thread_to_thread_object, delete_thread_object)
16446 (build_inferior_list, gdbpy_selected_inferior): Update.
16447 * python/py-infthread.c (create_thread_object): Update. Also fail
16448 if inferior_to_inferior_object fails.
16449
16450 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16451
16452 * inferior.h (class inferior) <displaced_step_state>: New field.
16453 * infrun.h (struct displaced_step_state): Move here from
16454 infrun.c. Initialize fields, add constructor.
16455 <inf>: Remove field.
16456 <reset>: New method.
16457 * infrun.c (struct displaced_step_inferior_state): Move to
16458 infrun.h.
16459 (displaced_step_inferior_states): Remove.
16460 (get_displaced_stepping_state): Adust.
16461 (displaced_step_in_progress_any_inferior): Adjust.
16462 (displaced_step_in_progress_thread): Adjust.
16463 (displaced_step_in_progress): Adjust.
16464 (add_displaced_stepping_state): Remove.
16465 (get_displaced_step_closure_by_addr): Adjust.
16466 (remove_displaced_stepping_state): Remove.
16467 (infrun_inferior_exit): Call displaced_step_state.reset.
16468 (use_displaced_stepping): Don't check for NULL.
16469 (displaced_step_prepare_throw): Call
16470 get_displaced_stepping_state.
16471 (displaced_step_fixup): Don't check for NULL.
16472 (prepare_for_detach): Don't check for NULL.
16473
16474 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16475
16476 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16477 in case of call that did not complete.
16478
16479 2019-01-02 Andrey Utkin <autkin@undo.io>
16480
16481 * symfile.c (find_separate_debug_file): Fix search of debug files for
16482 remote debuggee.
16483
16484 2019-01-02 Tom Tromey <tom@tromey.com>
16485
16486 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16487 indentation.
16488 * python/py-frame.c (frapy_older): Remove cast.
16489 (frapy_newer): Likewise.
16490 * python/py-breakpoint.c (local_setattro): Remove cast.
16491 * python/py-arch.c (archpy_name): Remove local variable.
16492 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16493
16494 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16495
16496 * unittests/basic_string_view/element_access/char/empty.cc:
16497 Fix year range in copyright header.
16498
16499 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16500
16501 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16502 Delete.
16503 <operator==>: Update with for removed field.
16504 <hash>: Likewise.
16505 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16506 <isa_features>: ...this.
16507 <abi_features>: New field.
16508 (riscv_isa_flen): Update comment.
16509 (riscv_abi_xlen): New declaration.
16510 (riscv_abi_flen): New declaration.
16511 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16512 isa_features.
16513 (riscv_abi_xlen): New function.
16514 (riscv_isa_flen): Update to get answer from isa_features.
16515 (riscv_abi_flen): New function.
16516 (riscv_has_fp_abi): Update to get answer from abi_features.
16517 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16518 xlen and flen.
16519 (riscv_call_info) <xlen, flen>: Update comment.
16520 (riscv_call_arg_struct): Remove invalid assertions
16521 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16522 is removed.
16523 (riscv_gdbarch_init): Gather isa features and abi features
16524 separately, ensure both match on the gdbarch when reusing an old
16525 gdbarch. Relax an error check to allow 32-bit abi float to run on
16526 a target with 64-bit float hardware.
16527
16528 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16529
16530 * source.c (search_command_helper): Stop reverse search
16531 when line 1 has been searched.
16532
16533 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16534
16535 * record-full.c (record_full_base_target::close): Rewrite
16536 record_full_core_buf_list free logic.
16537
16538 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16539
16540 * break-catch-syscall.c (print_one_catch_syscall): xfree
16541 the last text.
16542
16543 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16544
16545 * top.c (print_gdb_version): Update Copyright year in version
16546 message.
16547
16548 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16549
16550 Update copyright year range in all GDB files.
16551
16552 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16553
16554 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16555
16556 For older changes see ChangeLog-2018.
16557 \f
16558 Local Variables:
16559 mode: change-log
16560 left-margin: 8
16561 fill-column: 74
16562 version-control: never
16563 coding: utf-8
16564 End:
16565
This page took 0.436965 seconds and 5 git commands to generate.