1 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-link.c (ctf_link_one_input_archive_member): Check
4 CTF_LINK_OMIT_VARIABLES_SECTION.
6 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
8 * ctf-impl.h (ctf_type_id_key): New, the key in the
10 (ctf_dedup): New, core deduplicator state.
11 (ctf_file_t) <ctf_dedup>: New.
12 <ctf_dedup_atoms>: New.
13 <ctf_dedup_atoms_alloc>: New.
14 (ctf_hash_type_id_key): New prototype.
15 (ctf_hash_eq_type_id_key): Likewise.
16 (ctf_dedup_atoms_init): Likewise.
17 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
18 (ctf_dedup_atoms_init): Likewise.
19 * ctf-create.c (ctf_serialize): Adjusted.
20 (ctf_add_encoded): No longer static.
21 (ctf_add_reftype): Likewise.
22 * ctf-open.c (ctf_file_close): Destroy the
23 ctf_dedup_atoms_alloc.
24 * ctf-dedup.c: New file.
25 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
26 * configure.ac: Check for stpcpy.
27 * Makefile.am: Add it.
28 * Makefile.in: Regenerate.
29 * config.h.in: Regenerate.
30 * configure: Regenerate.
32 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
34 * configure.ac: Add --enable-libctf-hash-debugging.
35 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
36 * Makefile.in: Regenerated.
37 * configure: Likewise.
38 * config.h.in: Likewise.
39 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
40 (ctf_assert): Define to assert.
42 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
44 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
46 * ctf-impl.h: Include it.
48 (ctf_sha1_add): Likewise.
49 (ctf_sha1_fini): Likewise.
50 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
52 * Makefile.am: Add file.
53 * Makefile.in: Regenerate.
55 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
57 * libctf.ver (ctf_link_set_variable_filter): Add.
58 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
59 <ctf_link_variable_filter_arg>: Likewise.
60 * ctf-create.c (ctf_serialize): Adjust.
61 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
62 (ctf_link_one_variable): Call it if set.
64 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
66 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
67 conflicts, not the source type.
69 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
71 * ctf-impl.h (ctf_file_t): Improve comments.
72 <ctf_link_cu_mapping>: Split into...
73 <ctf_link_in_cu_mapping>: ... this...
74 <ctf_link_out_cu_mapping>: ... and this.
75 * ctf-create.c (ctf_serialize): Adjust.
76 * ctf-open.c (ctf_file_close): Likewise.
77 * ctf-link.c (ctf_create_per_cu): Look things up in the
78 in_cu_mapping instead of the cu_mapping.
79 (ctf_link_add_cu_mapping): The deduplicating link will define
80 what happens if many FROMs share a TO.
81 (ctf_link_add_cu_mapping): Create in_cu_mapping and
82 out_cu_mapping. Do not create ctf_link_outputs here any more, or
83 create per-CU dicts here: they are already created when needed.
84 (ctf_link_one_variable): Log a debug message if we skip a
85 variable due to its type being concealed in a CU-mapped link.
86 (This is probably too common a case to make into a warning.)
87 (ctf_link): Create empty per-CU dicts if requested.
89 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
91 * ctf-link.c (ctf_link_write): Close the fd.
93 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
95 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
96 * Makefile.in: Regenerated.
97 * ctf-impl.h (ctf_link_input_name): New.
98 (ctf_file_t) <ctf_link_flags>: New.
99 * ctf-create.c (ctf_serialize): Adjust accordingly.
100 * ctf-link.c: Define ctf_open as weak when PIC.
101 (ctf_arc_close_thunk): Remove unnecessary thunk.
102 (ctf_file_close_thunk): Likewise.
103 (ctf_link_input_name): New.
104 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
105 (ctf_link_input_close): Adjust accordingly.
106 (ctf_link_add_ctf_internal): New, split from...
107 (ctf_link_add_ctf): ... here. Return error if lazy loading of
108 CTF is not possible. Change to just call...
109 (ctf_link_add): ... this new function.
110 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
111 ctf_file_close_thunk.
112 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
113 <in_file_name>: ... this.
115 <share_mode>: Likewise (migrated to ctf_link_flags).
116 <done_main_member>: Rename to...
117 <done_parent>: ... this.
118 <main_input_fp>: Rename to...
119 <in_fp_parent>: ... this.
121 (ctf_link_one_type): Adjuwt accordingly. Transition to
122 ctf_err_warn, removing a TODO.
123 (ctf_link_one_variable): Note a case too common to warn about.
124 Report in the debug stream if a cu-mapped link prevents addition
125 of a conflicting variable.
126 (ctf_link_one_input_archive_member): Adjust.
127 (ctf_link_lazy_open): New, open a CTF archive for linking when
129 (ctf_link_close_one_input_archive): New, close it again.
130 (ctf_link_one_input_archive): Adjust for lazy opening, member
131 renames, and ctf_err_warn transition. Move the
132 empty_link_type_mapping call to...
133 (ctf_link): ... here. Adjut for renamings and thunk removal.
134 Don't spuriously fail if some input contains no CTF data.
135 (ctf_link_write): ctf_err_warn transition.
136 * libctf.ver: Remove not-yet-stable comment.
138 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
140 * ctf-impl.h (ctf_strerror): Delete.
141 * ctf-subr.c (ctf_strerror): Likewise.
142 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
145 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
147 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
148 (ctf_import_unref): New.
149 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
150 zero. Don't recurse back in if the refcount is already zero.
151 (ctf_import): Check ctf_parent_unreffed before deciding whether
152 to close a pre-existing parent. Set it to zero.
153 (ctf_import_unreffed): New, as above, setting
154 ctf_parent_unreffed to 1.
155 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
156 child: use direct assignment, and set unreffed on the new and
158 * ctf-link.c (ctf_create_per_cu): Import the parent using
161 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
163 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
164 (ctf_link_type_key): ... this, adjusting member prefixes to
166 (ctf_hash_type_mapping_key): Rename to...
167 (ctf_hash_type_key): ... this.
168 (ctf_hash_eq_type_mapping_key): Rename to...
169 (ctf_hash_eq_type_key): ... this.
170 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
171 (ctf_hash_type_key): ... this, and adjust for member name
173 (ctf_hash_eq_type_mapping_key): Rename to...
174 (ctf_hash_eq_type_key): ... this, and adjust for member name
176 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
177 need for out-of-memory checking in this code.
178 (ctf_type_mapping): Adjust.
180 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
182 configure.ac: Check for vasprintf.
183 configure: Regenerated.
184 config.h.in: Likewise.
186 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
188 * ctf-archive.c (ctf_arc_bufopen): Fix message.
190 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
192 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
194 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
195 if the input has no symtab, rather than dividing by
196 zero. Arrange to free it later via ctfi_free_ctfsect.
197 * ctf-archive.c (ctf_new_archive_internal): Do not
198 ctfi_free_strsect by default.
199 (ctf_arc_close): Possibly free it here.
201 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
203 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
204 (ctf_dump_format_type): improve slice formatting. Always print
205 the type size, even of slices.
206 (ctf_dump_member): Print slices (-> bitfields) differently from
207 non-slices. Failure to format a type is not an OOM.
209 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
211 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
212 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
213 (ctf_dump_objts): Likewise.
214 (ctf_dump_var): Likewise.
215 (ctf_dump_type): Do not emit a duplicate message. Move to
216 ctf_err_warning, and swallow all errors.
218 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
220 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
221 (ctf_decl_buf): Once it escapes, don't try to free it later.
223 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
225 * ctf-types.c (ctf_type_aname): Print arg types here...
226 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
227 in the type name here.
229 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
231 * ctf-impl.h (ctf_assert): New.
232 (ctf_err_warning_t): Likewise.
233 (ctf_file_t) <ctf_errs_warnings>: Likewise.
234 (ctf_err_warn): New prototype.
235 (ctf_assert_fail_internal): Likewise.
236 * ctf-inlines.h (ctf_assert_internal): Likewise.
237 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
238 * ctf-create.c (ctf_serialize): Copy it on serialization.
239 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
240 (ctf_errwarning_next): New iterator, free and pass back
241 errors/warnings in succession.
242 * libctf.ver (ctf_errwarning_next): Add.
244 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
246 * ctf-types.c (ctf_variable_iter): Fix error return.
248 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
250 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
252 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
254 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
256 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
258 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
260 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
261 ctf_dynhash_next_sorted.
262 <cu.ctn_h>: New, pointer to the dynhash under iteration.
263 <cu.ctn_s>: New, pointer to the dynset under iteration.
264 (ctf_hash_sort_f): Sorting function passed to...
265 (ctf_dynhash_next_sorted): ... this new function.
266 (ctf_dynhash_next): New.
267 (ctf_dynset_next): New.
268 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
269 (ctf_dynhash_cnext): New.
270 (ctf_dynset_cnext): New.
271 * ctf-hash.c (ctf_dynhash_next_sorted): New.
272 (ctf_dynhash_next): New.
273 (ctf_dynset_next): New.
274 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
276 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
278 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
280 * ctf-impl.h (ctf_next): New.
281 (ctf_get_dict): New prototype.
282 * ctf-lookup.c (ctf_get_dict): New, split out of...
283 (ctf_lookup_by_id): ... here.
284 * ctf-util.c (ctf_next_create): New.
285 (ctf_next_destroy): New.
286 (ctf_next_copy): New.
287 * ctf-types.c (includes): Add <assert.h>.
288 (ctf_member_next): New.
289 (ctf_enum_next): New.
290 (ctf_type_iter): Document the lack of iteration over parent
292 (ctf_type_next): New.
293 (ctf_variable_next): New.
294 * ctf-archive.c (ctf_archive_next): New.
295 * libctf.ver: Add new public functions.
297 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
299 * libctf.ver (ctf_ref): New.
300 * ctf-open.c (ctf_ref): Implement it.
302 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
304 * ctf-inlines.h (ctf_forwardable_kind): New.
305 * ctf-create.c (ctf_add_forward): Use it.
307 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
309 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
310 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
312 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
314 * ctf-hash.c (ctf_dynset_eq_string): New.
315 (ctf_dynset_create): New.
316 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
317 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
318 (key_to_internal): New.
319 (internal_to_key): New.
320 (ctf_dynset_insert): New.
321 (ctf_dynset_remove): New.
322 (ctf_dynset_destroy): New.
323 (ctf_dynset_lookup): New.
324 (ctf_dynset_exists): New.
325 (ctf_dynset_lookup_any): New.
326 (ctf_hash_insert_type): Coding style.
327 (ctf_hash_define_type): Likewise.
328 * ctf-impl.h (ctf_dynset_t): New.
329 (ctf_dynset_eq_string): New.
330 (ctf_dynset_create): New.
331 (ctf_dynset_insert): New.
332 (ctf_dynset_remove): New.
333 (ctf_dynset_destroy): New.
334 (ctf_dynset_lookup): New.
335 (ctf_dynset_exists): New.
336 (ctf_dynset_lookup_any): New.
337 * ctf-inlines.h (ctf_dynset_cinsert): New.
339 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
341 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
342 <value_free>: Likewise.
344 (ctf_dynhash_item_free): Indirect through the owner.
345 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
346 allocate space for the key_free and value_free fields fields
348 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
349 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
350 value_free if they will exist. Set the slot's owner, but only
352 (ctf_dynhash_remove): Adjust.
354 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
356 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
357 there is a key-freeing function and the key already exists.
359 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
361 * ctf-inlines.h: New file.
362 * ctf-impl.h: Include it.
363 (ctf_hash_iter_find_f): New typedef.
364 (ctf_dynhash_elements): New.
365 (ctf_dynhash_lookup_kv): New.
366 (ctf_dynhash_iter_find): New.
367 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
368 (ctf_traverse_find_cb_arg_t): New.
369 (ctf_hashtab_traverse_find): New.
370 (ctf_dynhash_iter_find): New.
371 (ctf_dynhash_elements): New.
373 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
375 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
377 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
379 * ctf-archive.c (ctf_archive_count): New.
380 * libctf.ver: New public function.
382 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
384 * ctf-types.c (ctf_member_count): New.
385 * libctf.ver: New public function.
387 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
389 * ctf-types.c (ctf_type_kind_forwarded): New.
391 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
393 * ctf-types.c (ctf_type_name_raw): New.
394 (ctf_type_aname_raw): Reimplement accordingly.
396 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
398 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
400 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
402 * ctf-impl.h (struct ctf_archive_internal)
403 <ctfi_unmap_on_close>: New.
404 (ctf_new_archive_internal): Adjust.
405 * ctf-archive.c (ctf_new_archive_internal): Likewise.
406 Initialize ctfi_unmap_on_close. Adjust error path.
407 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
408 (unmap_on_close is 0).
409 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
410 * ctf-open-bfd.c (ctf_fdopen): Adjust.
412 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
414 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
415 ints, floats or typedefs have no name. Fix comment typo.
417 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
419 * ctf-create.c (ctf_add_slice): Support slices of any kind that
420 resolves to an integral type.
421 * ctf-types.c (ctf_type_encoding): Resolve the type before
422 fishing its encoding out.
424 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
426 * ctf-create.c (ctf_create): Mark dirty.
428 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
430 * ctf-create.c (membcmp) Skip nameless members.
432 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
434 * ctf-create.c (ctf_add_member_offset): Support names of ""
435 as if they were the null pointer.
437 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
439 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
442 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
444 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
446 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
448 * ctf-create.c (ctf_serialize): Add cast.
449 (ctf_add_slice): Likewise.
451 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
453 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
454 * ctf-create.c (ctf_add_function): Check for unimplemented type
455 and populate at the same time. Populate one-by-one, not via
457 (ctf_serialize): Remove unnecessary cast.
458 * ctf-types.c (ctf_func_type_info): Likewise.
459 (ctf_func_type_args): Likewise. Fix comment typo.
461 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
463 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
464 (ctf_add_array): Support array contents of type zero.
465 (ctf_add_function): Support arguments and return types of
467 (ctf_add_typedef): Support typedefs to type zero.
468 (ctf_add_member_offset): Support members of type zero,
469 unless added at unspecified (naturally-aligned) offset.
471 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
473 * ctf-error.c: Include <stddef.h>, for offsetof.
474 (_ctf_errlist): Migrate to...
475 (_ctf_errlist_t): ... this.
476 (_ctf_erridx): New, indexes into _ctf_errlist_t.
478 (ctf_errmsg): Adjust accordingly.
479 * Makefile.am (BUILT_SOURCES): Note...
480 (ctf-error.h): ... this new rule.
481 * Makefile.in: Regenerate.
482 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
483 * .gitignore: New, ignore ctf-error.h.
485 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
487 * ctf-impl.h: Fix typos in comments.
489 2020-07-22 Nick Clifton <nickc@redhat.com>
491 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
492 same file descriptor.
494 2020-07-04 Nick Clifton <nickc@redhat.com>
496 Binutils 2.35 branch created.
498 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
500 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
502 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
503 * config.h.in: Regenerated.
504 * Makefile.in: Likewise.
505 * configure: Likewise.
507 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
509 * ctf-create.c: Include <unistd.h>.
510 * ctf-open-bfd.c: Likewise.
512 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
515 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
516 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
517 means this is declared.
518 (bswap_32): Likewise.
519 (bswap_64): Likewise.
520 (bswap_identity_64): Remove, unused.
521 * configure: Regenerated.
522 * config.h.in: Likewise.
524 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
527 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
528 (_libctf_unlikely_): Likewise.
529 (_libctf_unused): Likewise.
530 (_libctf_malloc_): Likewise.
532 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
535 * ctf-archive.c (search_nametbl): No longer global: declare...
536 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
537 (search_modent_by_name): Take and use ARG for the nametbl.
539 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
541 * ctf-impl.h (ctf_new_archive_internal): Declare.
542 (ctf_arc_bufopen): Remove.
543 (ctf_archive_internal) <ctfi_free_symsect>: New.
544 * ctf-archive.c (ctf_arc_close): Use it.
545 (ctf_arc_bufopen): Fuse into...
546 (ctf_new_archive_internal): ... this, moved across from...
547 * ctf-open-bfd.c: ... here.
548 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
549 * libctf.ver: Add it.
551 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
553 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
554 (ctf_dtd_delete): Remove correspondingly.
555 (ctf_rollback): Likewise.
557 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
559 * ctf-create.c (ctf_add_type_internal): Hand back existing types
562 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
564 * ctf-create.c (ctf_add_forward): Don't add forwards to
565 types that already exist.
567 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
569 * ctf-open.c (init_types): Only intern root-visible types.
570 * ctf-create.c (ctf_dtd_insert): Likewise.
571 (ctf_dtd_delete): Only remove root-visible types.
572 (ctf_rollback): Likewise.
573 (ctf_add_generic): Adjust.
574 (ctf_add_struct_sized): Adjust comment.
575 (ctf_add_union_sized): Likewise.
576 (ctf_add_enum): Likewise.
577 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
579 2020-03-11 John Baldwin <jhb@FreeBSD.org>
581 * swap.h (bswap_identity_64): Make static.
583 2020-01-18 Nick Clifton <nickc@redhat.com>
585 Binutils 2.34 branch created.
587 2020-01-05 Joel Brobecker <brobecker@adacore.com>
590 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
591 * configure, config.h.in: Regenerate.
593 2020-01-01 Alan Modra <amodra@gmail.com>
595 Update year range in copyright notice of all files.
597 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
599 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
601 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
603 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
604 * ctf-types.c (ctf_type_lname): Likewise.
606 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
608 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
609 ctf_import after the first for a given file.
611 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
613 * ctf-impl.h (ctf_str_append_noerr): Declare.
614 * ctf-util.c (ctf_str_append_noerr): Define in terms of
616 * ctf-dump.c (str_append): New, call it.
617 (ctf_dump_format_type): Use str_append, not ctf_str_append.
618 (ctf_dump_label): Likewise.
619 (ctf_dump_objts): Likewise.
620 (ctf_dump_funcs): Likewise.
621 (ctf_dump_var): Likewise.
622 (ctf_dump_member): Likewise.
623 (ctf_dump_type): Likewise.
624 (ctf_dump): Likewise.
626 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
628 * ctf-impl.h (ctf_alloc): Remove.
629 (ctf_free): Likewise.
630 (ctf_strdup): Likewise.
631 * ctf-subr.c (ctf_alloc): Remove.
632 (ctf_free): Likewise.
633 * ctf-util.c (ctf_strdup): Remove.
635 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
636 ctf_free; strdup, not ctf_strdup.
637 (ctf_dtd_delete): Likewise.
638 (ctf_dvd_delete): Likewise.
639 (ctf_add_generic): Likewise.
640 (ctf_add_function): Likewise.
641 (ctf_add_enumerator): Likewise.
642 (ctf_add_member_offset): Likewise.
643 (ctf_add_variable): Likewise.
645 (ctf_compress_write): Likewise.
646 (ctf_write_mem): Likewise.
647 * ctf-decl.c (ctf_decl_push): Likewise.
648 (ctf_decl_fini): Likewise.
649 (ctf_decl_sprintf): Likewise. Check for OOM.
650 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
651 ctf_free; strdup, not ctf_strdup.
652 (ctf_dump_free): Likewise.
653 (ctf_dump): Likewise.
654 * ctf-open.c (upgrade_types_v1): Likewise.
655 (init_types): Likewise.
656 (ctf_file_close): Likewise.
657 (ctf_bufopen_internal): Likewise. Check for OOM.
658 (ctf_parent_name_set): Likewise: report the OOM to the caller.
659 (ctf_cuname_set): Likewise.
660 (ctf_import): Likewise.
661 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
662 free, not ctf_free; strdup, not ctf_strdup.
663 (ctf_str_free_atom): Likewise.
664 (ctf_str_create_atoms): Likewise.
665 (ctf_str_add_ref_internal): Likewise.
666 (ctf_str_remove_ref): Likewise.
667 (ctf_str_write_strtab): Likewise.
669 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
671 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
672 work right for non-int/fps.
674 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
676 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
679 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
681 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
682 * ctf-open.c (ctf_file_close): Free it.
683 * ctf-create.c (ctf_serialize): Adjust.
684 (membcmp): When reporting a conflict due to an error, report the
686 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
687 (ctf_add_type_internal): ... this. Hand back types we are already
688 in the middle of adding immediately. Hand back structs/unions with
689 the same number of members immediately. Do not walk the dynamic
690 list. Call ctf_add_type_internal, not ctf_add_type. Handle
691 forwards promoted to other types and the inverse case identically.
692 Add structs to the mapping as soon as we intern them, before they
695 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
697 * ctf-impl.h (ctf_names_t): New.
698 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
699 (ctf_file_t) <ctf_structs>: Likewise.
700 <ctf_unions>: Likewise.
701 <ctf_enums>: Likewise.
702 <ctf_names>: Likewise.
703 <ctf_lookups>: Improve comment.
704 <ctf_ptrtab_len>: New.
705 <ctf_prov_strtab>: New.
706 <ctf_str_prov_offset>: New.
707 <ctf_dtbyname>: Remove, redundant to the names hashes.
708 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
709 (ctf_dtdef_t) <dtd_name>: Remove.
710 <dtd_data>: Note that the ctt_name is now populated.
711 (ctf_str_atom_t) <csa_offset>: This is now the strtab
712 offset for internal strings too.
713 <csa_external_offset>: New, the external strtab offset.
714 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
715 (ctf_name_table): New declaration.
716 (ctf_lookup_by_rawname): Likewise.
717 (ctf_lookup_by_rawhash): Likewise.
718 (ctf_set_ctl_hashes): Likewise.
719 (ctf_serialize): Likewise.
720 (ctf_dtd_insert): Adjust.
721 (ctf_simple_open_internal): Likewise.
722 (ctf_bufopen_internal): Likewise.
723 (ctf_list_empty_p): Likewise.
724 (ctf_str_remove_ref): Likewise.
725 (ctf_str_add): Returns uint32_t now.
726 (ctf_str_add_ref): Likewise.
727 (ctf_str_add_external): Now returns a boolean (int).
728 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
729 for strings in the appropriate range.
730 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
731 when adding the null string to the new strtab.
732 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
733 (ctf_str_add_ref_internal): Add make_provisional argument. If
734 make_provisional, populate the offset and fill in the
735 ctf_prov_strtab accordingly.
736 (ctf_str_add): Return the offset, not the string.
737 (ctf_str_add_ref): Likewise.
738 (ctf_str_add_external): Return a success integer.
739 (ctf_str_remove_ref): New, remove a single ref.
740 (ctf_str_count_strtab): Do not count the initial null string's
741 length or the existence or length of any unreferenced internal
743 (ctf_str_populate_sorttab): Skip atoms with no refs.
744 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
745 to the cts_len for the null string, since it is no longer done
746 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
747 Populate the csa_offset for both internal and external cases.
748 Flush the ctf_prov_strtab afterwards, and reset the
750 * ctf-create.c (ctf_grow_ptrtab): New.
751 (ctf_create): Call it. Initialize new fields rather than old
752 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
753 Set the ctl hashes and data model.
754 (ctf_update): Rename to...
755 (ctf_serialize): ... this. Leave a compatibility function behind.
756 Tell ctf_simple_open_internal that this is a writable dictionary.
757 Pass the new fields along from the old dictionary. Drop
758 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
759 Do not zero out the DTD's ctt_name.
760 (ctf_prefixed_name): Rename to...
761 (ctf_name_table): ... this. No longer return a prefixed name: return
762 the applicable name table instead.
763 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
764 kind we're adding. Migrate away from dtd_name.
765 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
767 (ctf_dtd_lookup_type_by_name): Remove.
768 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
769 No longer check ctf_dtnextid: check ctf_typemax instead.
770 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
771 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
772 ctf_name_table and the right name table, and migrate away from
773 dtd_name as in ctf_dtd_delete.
774 (ctf_add_generic): Pass in the kind explicitly and pass it to
775 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
776 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
777 Grow the ptrtab if needed.
778 (ctf_add_encoded): Pass in the kind.
779 (ctf_add_slice): Likewise.
780 (ctf_add_array): Likewise.
781 (ctf_add_function): Likewise.
782 (ctf_add_typedef): Likewise.
783 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
784 ctt_name rather than dtd_name.
785 (ctf_add_struct_sized): Pass in the kind. Use
786 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
787 ctf_dtd_lookup_type_by_name.
788 (ctf_add_union_sized): Likewise.
789 (ctf_add_enum): Likewise.
790 (ctf_add_enum_encoded): Likewise.
791 (ctf_add_forward): Likewise.
792 (ctf_add_type): Likewise.
793 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
794 being initialized until after the call.
795 (ctf_write_mem): Likewise.
796 (ctf_write): Likewise.
797 * ctf-archive.c (arc_write_one_ctf): Likewise.
798 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
799 ctf_hash_lookup_type.
800 (ctf_lookup_by_id): No longer check the readonly types if the
801 dictionary is writable.
802 * ctf-open.c (init_types): Assert that this dictionary is not
803 writable. Adjust to use the new name hashes, ctf_name_table,
804 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
805 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
806 if set. Drop out early when dictionary is writable. Split the
807 ctf_lookups initialization into...
808 (ctf_set_cth_hashes): ... this new function.
809 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
810 (ctf_simple_open): Adjust accordingly.
811 (ctf_bufopen): Likewise.
812 (ctf_file_close): Destroy the appropriate name hashes. No longer
813 destroy ctf_dtbyname, which is gone.
814 (ctf_getdatasect): Remove spurious "extern".
815 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
816 specified name table, given a kind.
817 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
818 (ctf_member_iter): Add support for iterating over the
820 (ctf_enum_iter): Likewise.
821 (ctf_variable_iter): Likewise.
822 (ctf_type_rvisit): Likewise.
823 (ctf_member_info): Add support for types in the dynamic type list.
824 (ctf_enum_name): Likewise.
825 (ctf_enum_value): Likewise.
826 (ctf_func_type_info): Likewise.
827 (ctf_func_type_args): Likewise.
828 * ctf-link.c (ctf_accumulate_archive_names): No longer call
830 (ctf_link_write): Likewise.
831 (ctf_link_intern_extern_string): Adjust for new
832 ctf_str_add_external return value.
833 (ctf_link_add_strtab): Likewise.
834 * ctf-util.c (ctf_list_empty_p): New.
836 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
838 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
840 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
842 (ctf_add_variable): Likewise for variables pointing to them.
843 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
844 type link failure, but do warn for others.
845 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
847 (ctf_dump_member): Likewise.
848 (ctf_dump_type): Likewise.
849 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
850 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
851 (ctf_dump_header): Likewise.
852 (ctf_dump_label): likewise.
853 (ctf_dump_objts): likewise.
854 (ctf_dump_funcs): likewise.
855 (ctf_dump_var): likewise.
856 (ctf_dump_str): Likewise.
858 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
860 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
862 (AM_INSTALL_LIBBFD): Likewise.
863 (dlopen): Note why this is necessary in a comment.
864 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
866 (SHARED_LDFLAGS): Likewise.
867 (BFD_LIBADD): Likewise, for libbfd.
868 (BFD_DEPENDENCIES): Likewise.
869 (VERSION_FLAGS): Initialize, using a version script if ld supports
870 one, or libtool -export-symbols-regex otherwise.
871 (AC_CONFIG_MACRO_DIR): Add ../BFD.
872 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
874 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
875 (noinst_LIBRARIES): Replace with...
876 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
877 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
878 libctf-nobfd.la as well.
879 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
880 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
881 (libctf_a_SOURCES): Rename to...
882 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
884 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
885 with ctf-open-bfd.c added.
886 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
887 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
888 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
889 * Makefile.am [INSTALL_LIBCTF]: Use it.
890 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
892 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
893 the unstable components).
894 * Makefile.in: Regenerated.
895 * config.h.in: Likewise.
896 * configure: Likewise.
898 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
900 * configure.ac (INSTALL_LIBCTF): New, controlled by
901 --enable-install-libctf.
902 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
903 * Makefile.in: Regenerated.
904 * configure: Regenerated.
906 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
908 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
909 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
911 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
913 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
915 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
917 * ctf-impl.h (includes): Include <sys/param.h> here.
919 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
921 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
922 (flip_objts): Likewise.
923 (flip_vars): Likewise.
924 (flip_types): Likewise.
926 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
928 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
929 freeing functions: if set, free the key and value if the slot
930 already exists. Always reassign the key.
931 (ctf_dynhash_insert): Adjust call appropriately.
932 (ctf_hash_insert_type): Likewise.
934 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
936 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
937 type kind. Allow forwards to unify with pre-existing structs/
940 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
942 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
943 <ctf_link_memb_name_changer>: Likewise.
944 <ctf_link_memb_name_changer_arg>: Likewise.
945 * ctf-create.c (ctf_update): Update accordingly.
946 * ctf-open.c (ctf_file_close): Likewise.
947 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
948 (ctf_link_add_cu_mapping): New.
949 (ctf_link_set_memb_name_changer): Likewise.
950 (ctf_change_parent_name): New.
951 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
952 allocated by the caller's ctf_link_memb_name_changer.
953 <ndynames>: Likewise.
954 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
955 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
956 ctf_change_parent_name. Free any resulting names.
958 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
960 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
961 (ctf_link_one_type): ... here, with parent-name setting added.
962 (check_variable): New.
963 (ctf_link_one_variable): Likewise.
964 (ctf_link_one_input_archive_member): Call it.
965 * ctf-error.c (_ctf_errlist): Updated with new errors.
967 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
969 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
970 (struct ctf_link_type_mapping_key): New.
971 (ctf_hash_type_mapping_key): Likewise.
972 (ctf_hash_eq_type_mapping_key): Likewise.
973 (ctf_add_type_mapping): Likewise.
974 (ctf_type_mapping): Likewise.
975 (ctf_dynhash_empty): Likewise.
976 * ctf-open.c (ctf_file_close): Update accordingly.
977 * ctf-create.c (ctf_update): Likewise.
978 (ctf_add_type): Populate the mapping.
979 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
980 (ctf_hash_eq_type_mapping_key): Check the key for equality.
981 (ctf_dynhash_insert): Fix comment typo.
982 (ctf_dynhash_empty): New.
983 * ctf-link.c (ctf_add_type_mapping): New.
984 (ctf_type_mapping): Likewise.
985 (empty_link_type_mapping): New.
986 (ctf_link_one_input_archive): Call it.
988 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
990 * ctf-link.c: New file, linking of the string and type sections.
991 * Makefile.am (libctf_a_SOURCES): Add it.
992 * Makefile.in: Regenerate.
994 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
996 * ctf-create.c (ctf_update): Update accordingly.
997 * ctf-open.c (ctf_file_close): Likewise.
998 * ctf-error.c (_ctf_errlist): Updated with new errors.
1000 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1002 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1004 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1006 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1008 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1009 (ctf_dump_format_type): Add non-root-type { } notation.
1010 Add root flag to prototype.
1011 (ctf_dump_label): Adjust accordingly.
1012 (ctf_dump_objts): Likewise.
1013 (ctf_dump_var): Likewise.
1015 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1017 * ctf-create.c (ctf_compress_write): Fix double-free.
1019 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1021 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1023 (ctf_arc_write_fd): ... this new function.
1024 * ctf-create.c (ctf_write_mem): New.
1026 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1028 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1029 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1030 (ctf_str_add_ref): Name the last arg.
1031 (ctf_str_add_external) New.
1032 (ctf_str_add_strraw_explicit): Likewise.
1033 (ctf_simple_open_internal): Likewise.
1034 (ctf_bufopen_internal): Likewise.
1036 * ctf-string.c (ctf_strraw_explicit): Split from...
1037 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1038 (ctf_str_add_ref_internal): Return the atom, not the
1040 (ctf_str_add): Adjust accordingly.
1041 (ctf_str_add_ref): Likewise. Move up in the file.
1042 (ctf_str_add_external): New: update the csa_offset.
1043 (ctf_str_count_strtab): Only account for strings with no csa_offset
1044 in the internal strtab length.
1045 (ctf_str_write_strtab): If the csa_offset is set, update the
1046 string's refs without writing the string out, and update the
1047 ctf_syn_ext_strtab. Make OOM handling less ugly.
1048 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1049 (ctf_update): Handle failure to populate the strtab. Pass in the
1050 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1051 Call ctf_simple_open_internal, not ctf_simple_open.
1052 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1054 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1055 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1056 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1057 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1058 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1059 (ctf_simple_open_internal): ... this new function, which calls
1060 ctf_bufopen_internal.
1061 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1062 (ctf_bufopen_internal): ... this new function, which sets
1065 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1067 * ctf_types.c (ctf_type_iter_all): New.
1069 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1071 * ctf-open.c (init_symtab): Check for overflow against the right
1073 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1074 (upgrade_types_v1): Note that these sections are not checked.
1075 (flip_header): Endian-swap the header fields.
1076 (flip_ctf): Endian-swap the sections.
1077 (flip_objts): Update comment.
1078 (ctf_bufopen): Check header offsets and alignment for validity.
1080 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1082 * ctf-open-bfd.c: Add <assert.h>.
1083 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1084 techniques borrowed from bfd_elf_sym_name.
1085 (ctf_new_archive_internal): Improve comment.
1086 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1087 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1088 no symbol section, but not vice versa.
1090 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1092 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1093 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1094 * ctf-dump.c (dump_header): New function, dump the CTF header.
1095 (ctf_dump): Call it.
1096 (ctf_dump_header_strfield): New function.
1097 (ctf_dump_header_sectfield): Likewise.
1099 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1101 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1102 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1103 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1104 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1105 Print out ctf_cuname: only print out ctf_parname if set.
1106 (ctf_free_base): Removed, ctf_base is no longer freed: free
1107 ctf_dynbase instead.
1108 (ctf_set_version): Fix spacing.
1109 (upgrade_header): New, in-place header upgrading.
1110 (upgrade_types): Rename to...
1111 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1112 longer track old and new headers separately. No longer allow for
1113 header sizes explicitly: squeeze the headers out on upgrade (they
1114 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1115 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1116 (upgrade_types): New, also handle ctf_parmax updating.
1117 (flip_header): Flip ctf_cuname.
1118 (flip_types): Flip BUF explicitly rather than deriving BUF from
1120 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1121 required alignment of objtoff and funcoff. No longer store it in
1122 the ctf_buf unless that buf is derived unmodified from the input.
1123 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1124 that duplicate fields in ctf_file: move allocation of ctf_file
1125 further up instead. Call upgrade_header as needed. Move
1126 version-specific ctf_parmax initialization into upgrade_types. More
1127 concise error handling.
1128 (ctf_file_close): No longer test for null pointers before freeing.
1129 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1132 (ctf_cuname_set): New.
1133 * ctf-create.c (ctf_update): Populate ctf_cuname.
1134 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1136 (ctf_write): Likewise.
1137 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1138 Fix the compression length: fp->ctf_size never counted the CTF
1139 header. Simplify the compress call accordingly.
1141 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1143 * ctf-endian.h: Don't assume htole64 and le64toh are always
1144 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1145 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1146 not bswap_identity_64.
1148 2019-09-18 Alan Modra <amodra@gmail.com>
1150 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1152 2019-09-09 Phil Blundell <pb@pbcl.net>
1154 binutils 2.33 branch created.
1156 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1158 * ctf-types.c (ctf_type_aname_raw): New.
1159 (ctf_func_type_info): Likewise.
1160 (ctf_func_type_args): Likewise.
1161 * ctf-error.c (_ctf_errlist): Fix description.
1162 * ctf-lookup.c: Fix file description.
1164 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1166 * ctf-create.c (ctf_create): Fix off-by-one error.
1168 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1170 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1172 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1173 (struct ctf_str_atom): New, disambiguated single string.
1174 (struct ctf_str_atom_ref): New, points to some other location that
1175 references this string's offset.
1176 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1177 Remove member ctf_dtvstrlen: we no longer track the total strlen
1179 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1180 (ctf_str_free_atoms): Likewise.
1181 (ctf_str_add): Likewise.
1182 (ctf_str_add_ref): Likewise.
1183 (ctf_str_rollback): Likewise.
1184 (ctf_str_purge_refs): Likewise.
1185 (ctf_str_write_strtab): Likewise.
1186 (ctf_realloc): Declare new function in ctf-util.c.
1188 * ctf-open.c (ctf_bufopen): Create the atoms table.
1189 (ctf_file_close): Destroy it.
1190 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1191 special-case the position of the parname string. Construct the
1192 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1193 rest of each buffer element is constructed, not via open-coding:
1194 realloc the CTF buffer and append the strtab to it. No longer
1195 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1196 strtab construction.
1197 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1198 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1199 after buffer element construction instead.
1200 (ctf_copy_lmembers): Likewise.
1201 (ctf_copy_emembers): Likewise.
1202 (ctf_create): No longer maintain the ctf_dtvstrlen.
1203 (ctf_dtd_delete): Likewise.
1204 (ctf_dvd_delete): Likewise.
1205 (ctf_add_generic): Likewise.
1206 (ctf_add_enumerator): Likewise.
1207 (ctf_add_member_offset): Likewise.
1208 (ctf_add_variable): Likewise.
1209 (membadd): Likewise.
1210 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1211 if there are active ctf_str_num_refs.
1212 (ctf_strraw): Move to ctf-string.c.
1213 (ctf_strptr): Likewise.
1214 * ctf-string.c: New file, strtab manipulation.
1216 * Makefile.am (libctf_a_SOURCES): Add it.
1217 * Makefile.in: Regenerate.
1219 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1221 * ctf-impl.h (ctf_hash_iter_f): New.
1222 (ctf_dynhash_iter): New declaration.
1223 (ctf_dynhash_iter_remove): New declaration.
1224 * ctf-hash.c (ctf_dynhash_iter): Define.
1225 (ctf_dynhash_iter_remove): Likewise.
1226 (ctf_hashtab_traverse): New.
1227 (ctf_hashtab_traverse_remove): Likewise.
1228 (struct ctf_traverse_cb_arg): Likewise.
1229 (struct ctf_traverse_remove_cb_arg): Likewise.
1231 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1233 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1235 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1237 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1238 (ctf_dump_funcs): Likewise.
1240 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1242 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1243 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1244 little-endian CTF archive magic. Do not check the CTF version:
1245 ctf_simple_open does that in endian-safe ways. Do not dereference
1246 null pointers on open failure.
1248 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1250 * ctf-open.c (get_vbytes_common): Return the new slice size.
1251 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1252 Remember to copy in the CTF data when opening an uncompressed
1253 foreign-endian CTF file. Prune useless variable manipulation.
1255 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1257 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1260 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1262 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1265 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1267 * ctf-subr.c (_PAGESIZE): Remove.
1268 (ctf_data_alloc): Likewise.
1269 (ctf_data_free): Likewise.
1270 (ctf_data_protect): Likewise.
1271 * ctf-impl.h: Remove declarations.
1272 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1273 ctf_free, not ctf_data_free.
1274 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1275 the buffer again on compression error.
1276 * ctf-open.c (ctf_set_base): No longer track the size: call
1277 ctf_free, not ctf_data_free.
1278 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1279 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1281 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1283 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1285 (ctf_dvd_insert): Likewise.
1286 (ctf_add_generic): Likewise.
1287 (ctf_add_variable): Likewise.
1288 * ctf-impl.h: Adjust declarations.
1290 2019-06-14 Alan Modra <amodra@gmail.com>
1292 * configure: Regenerate.
1294 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1296 * ctf-decls.h: Include <libiberty.h>.
1297 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1299 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1301 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1302 (ctf_dump_objts): Likewise.
1303 (ctf_dump_funcs): Likewise.
1304 (ctf_dump_member): Likewise.
1305 (ctf_dump_str): Likewise.
1307 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1309 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1310 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1312 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1314 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1315 (ctf_arc_open_by_offset): Likewise.
1316 * ctf-create.c (ctf_add_type): Likewise.
1318 2019-06-04 Tom Tromey <tromey@adacore.com>
1320 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1321 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1323 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1325 * configure.ac: Check for O_CLOEXEC.
1326 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1327 * config.h.in: Regenerate.
1328 * configure: Likewise.
1330 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1332 * qsort_r.c: Rename to...
1333 * ctf-qsort_r.c: ... this.
1334 (_quicksort): Define to ctf_qsort_r.
1335 * ctf-decls.h (qsort_r): Remove.
1337 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1338 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1339 * Makefile.am (libctf_a_LIBADD): Remove.
1340 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1341 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1342 * ctf-create.c (ctf_update): Likewise.
1343 * configure.ac: Check for BSD versus GNU qsort_r signature.
1344 * Makefile.in: Regenerate.
1345 * config.h.in: Likewise.
1346 * configure: Likewise.
1348 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1350 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1352 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1354 * Makefile.am (ZLIB): New.
1355 (ZLIBINC): Likewise.
1356 (AM_CFLAGS): Use them.
1357 (libctf_a_LIBADD): New, for LIBOBJS.
1358 * configure.ac: Check for zlib, endian.h, and qsort_r.
1359 * ctf-endian.h: New, providing htole64 and le64toh.
1360 * swap.h: Code style fixes.
1361 (bswap_identity_64): New.
1362 * qsort_r.c: New, from gnulib (with one added #include).
1363 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1364 and unconditional definitions of MIN and MAX.
1365 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1366 (ctf_set_errno): Now returns unsigned long.
1367 * ctf-util.c (ctf_set_errno): Adjust here too.
1368 * ctf-archive.c: Use ctf-endian.h.
1369 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1370 cts_flags and cts_offset.
1371 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1372 * ctf-create.c: Provide a definition of roundup if not defined.
1373 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1374 (ctf_add_reftype): Do not check if type IDs are below zero.
1375 (ctf_add_slice): Likewise.
1376 (ctf_add_typedef): Likewise.
1377 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1378 when known error-free. Drop CTF_ERR usage for functions returning
1380 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1382 (ctf_add_variable): Likewise.
1383 (enumcmp): Likewise.
1384 (enumadd): Likewise.
1385 (membcmp): Likewise.
1386 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1387 when known error-free.
1388 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1389 returning int: use CTF_ERR for functions returning ctf_type_id.
1390 (ctf_dump_label): Likewise.
1391 (ctf_dump_objts): Likewise.
1392 * ctf-labels.c (ctf_label_topmost): Likewise.
1393 (ctf_label_iter): Likewise.
1394 (ctf_label_info): Likewise.
1395 * ctf-lookup.c (ctf_func_args): Likewise.
1396 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1397 (ctf_bufopen): Likewise. Use zlib types as needed.
1398 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1400 (ctf_enum_iter): Likewise.
1401 (ctf_type_size): Likewise.
1402 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1403 (ctf_type_kind_unsliced): Likewise.
1404 (ctf_type_kind): Likewise.
1405 (ctf_type_encoding): Likewise.
1406 (ctf_member_info): Likewise.
1407 (ctf_array_info): Likewise.
1408 (ctf_enum_value): Likewise.
1409 (ctf_type_rvisit): Likewise.
1410 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1412 (ctf_simple_open): Likewise.
1413 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1414 * Makefile.in: Regenerate.
1415 * aclocal.m4: Likewise.
1416 * config.h: Likewise.
1417 * configure: Likewise.
1419 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1421 * configure.in: Check for bfd_section_from_elf_index.
1422 * configure: Regenerate.
1423 * config.h.in [HAVE_BFD_ELF]: Likewise.
1424 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1425 abfd is potentially unused now.
1427 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1430 * Makefile.in: Regenerated.
1431 * config.h.in: Likewise.
1432 * aclocal.m4: Likewise.
1433 * configure: Likewise.
1435 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1439 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1441 * ctf-labels.c: New.
1443 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1445 * ctf-impl.h (_libctf_version): New declaration.
1446 * ctf-subr.c (_libctf_version): Define it.
1449 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1451 * ctf-create.c (enumcmp): New.
1452 (enumadd): Likewise.
1453 (membcmp): Likewise.
1454 (membadd): Likewise.
1455 (ctf_add_type): Likewise.
1457 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1459 * ctf-lookup.c (isqualifier): New.
1460 (ctf_lookup_by_name): Likewise.
1461 (struct ctf_lookup_var_key): Likewise.
1462 (ctf_lookup_var): Likewise.
1463 (ctf_lookup_variable): Likewise.
1464 (ctf_lookup_symbol_name): Likewise.
1465 (ctf_lookup_by_symbol): Likewise.
1466 (ctf_func_info): Likewise.
1467 (ctf_func_args): Likewise.
1469 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1471 * ctf-decl.c: New file.
1472 * ctf-types.c: Likewise.
1473 * ctf-impl.h: New declarations.
1475 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1477 * ctf-open-bfd.c: New file.
1478 * ctf-open.c (ctf_close): New.
1479 * ctf-impl.h: Include bfd.h.
1480 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1481 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1483 (ctf_bfdopen_ctfsect): New declaration.
1484 (_CTF_SECTION): likewise.
1486 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1488 * ctf-archive.c: New.
1489 * ctf-impl.h (ctf_archive_internal): New type.
1490 (ctf_arc_open_internal): New declaration.
1491 (ctf_arc_bufopen): Likewise.
1492 (ctf_arc_close_internal): Likewise.
1494 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1496 * ctf-open.c: New file.
1499 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1501 * ctf-create.c: New file.
1502 * ctf-lookup.c: New file.
1504 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1506 * ctf-impl.h: New definitions and declarations for type creation
1509 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1511 * ctf-hash.c: New file.
1512 * ctf-impl.h: New declarations.
1514 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1516 * ctf-error.c: New file.
1518 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1520 * ctf-util.c: New file.
1522 * ctf-impl.h: Include it, and add declarations.
1524 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1526 * ctf-impl.h: New file.
1527 * ctf-subr.c: New file.
1534 version-control: never