libctf/ChangeLog

   1 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
   4         null pointer.
   5
   6 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
   7
   8         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
   9         * ctf-open.c (ctf_file_close): Free it.
  10         * ctf-create.c (ctf_serialize): Adjust.
  11         (membcmp): When reporting a conflict due to an error, report the
  12         error.
  13         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
  14         (ctf_add_type_internal): ... this.  Hand back types we are already
  15         in the middle of adding immediately.  Hand back structs/unions with
  16         the same number of members immediately.  Do not walk the dynamic
  17         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
  18         forwards promoted to other types and the inverse case identically.
  19         Add structs to the mapping as soon as we intern them, before they
  20         gain any members.
  21
  22 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  23
  24         * ctf-impl.h (ctf_names_t): New.
  25         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
  26         (ctf_file_t) <ctf_structs>: Likewise.
  27         <ctf_unions>: Likewise.
  28         <ctf_enums>: Likewise.
  29         <ctf_names>: Likewise.
  30         <ctf_lookups>: Improve comment.
  31         <ctf_ptrtab_len>: New.
  32         <ctf_prov_strtab>: New.
  33         <ctf_str_prov_offset>: New.
  34         <ctf_dtbyname>: Remove, redundant to the names hashes.
  35         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
  36         (ctf_dtdef_t) <dtd_name>: Remove.
  37         <dtd_data>: Note that the ctt_name is now populated.
  38         (ctf_str_atom_t) <csa_offset>: This is now the strtab
  39         offset for internal strings too.
  40         <csa_external_offset>: New, the external strtab offset.
  41         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
  42         (ctf_name_table): New declaration.
  43         (ctf_lookup_by_rawname): Likewise.
  44         (ctf_lookup_by_rawhash): Likewise.
  45         (ctf_set_ctl_hashes): Likewise.
  46         (ctf_serialize): Likewise.
  47         (ctf_dtd_insert): Adjust.
  48         (ctf_simple_open_internal): Likewise.
  49         (ctf_bufopen_internal): Likewise.
  50         (ctf_list_empty_p): Likewise.
  51         (ctf_str_remove_ref): Likewise.
  52         (ctf_str_add): Returns uint32_t now.
  53         (ctf_str_add_ref): Likewise.
  54         (ctf_str_add_external): Now returns a boolean (int).
  55         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
  56         for strings in the appropriate range.
  57         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
  58         when adding the null string to the new strtab.
  59         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
  60         (ctf_str_add_ref_internal): Add make_provisional argument.  If
  61         make_provisional, populate the offset and fill in the
  62         ctf_prov_strtab accordingly.
  63         (ctf_str_add): Return the offset, not the string.
  64         (ctf_str_add_ref): Likewise.
  65         (ctf_str_add_external): Return a success integer.
  66         (ctf_str_remove_ref): New, remove a single ref.
  67         (ctf_str_count_strtab): Do not count the initial null string's
  68         length or the existence or length of any unreferenced internal
  69         atoms.
  70         (ctf_str_populate_sorttab): Skip atoms with no refs.
  71         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
  72         to the cts_len for the null string, since it is no longer done
  73         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
  74         Populate the csa_offset for both internal and external cases.
  75         Flush the ctf_prov_strtab afterwards, and reset the
  76         ctf_str_prov_offset.
  77         * ctf-create.c (ctf_grow_ptrtab): New.
  78         (ctf_create): Call it.  Initialize new fields rather than old
  79         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
  80         Set the ctl hashes and data model.
  81         (ctf_update): Rename to...
  82         (ctf_serialize): ... this.  Leave a compatibility function behind.
  83         Tell ctf_simple_open_internal that this is a writable dictionary.
  84         Pass the new fields along from the old dictionary.  Drop
  85         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
  86         Do not zero out the DTD's ctt_name.
  87         (ctf_prefixed_name): Rename to...
  88         (ctf_name_table): ... this.  No longer return a prefixed name: return
  89         the applicable name table instead.
  90         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
  91         kind we're adding.  Migrate away from dtd_name.
  92         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
  93         deleted ctt_name.
  94         (ctf_dtd_lookup_type_by_name): Remove.
  95         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
  96         No longer check ctf_dtnextid: check ctf_typemax instead.
  97         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
  98         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
  99         ctf_name_table and the right name table, and migrate away from
 100         dtd_name as in ctf_dtd_delete.
 101         (ctf_add_generic): Pass in the kind explicitly and pass it to
 102         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 103         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 104         Grow the ptrtab if needed.
 105         (ctf_add_encoded): Pass in the kind.
 106         (ctf_add_slice): Likewise.
 107         (ctf_add_array): Likewise.
 108         (ctf_add_function): Likewise.
 109         (ctf_add_typedef): Likewise.
 110         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 111         ctt_name rather than dtd_name.
 112         (ctf_add_struct_sized): Pass in the kind.  Use
 113         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 114         ctf_dtd_lookup_type_by_name.
 115         (ctf_add_union_sized): Likewise.
 116         (ctf_add_enum): Likewise.
 117         (ctf_add_enum_encoded): Likewise.
 118         (ctf_add_forward): Likewise.
 119         (ctf_add_type): Likewise.
 120         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 121         being initialized until after the call.
 122         (ctf_write_mem): Likewise.
 123         (ctf_write): Likewise.
 124         * ctf-archive.c (arc_write_one_ctf): Likewise.
 125         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 126         ctf_hash_lookup_type.
 127         (ctf_lookup_by_id): No longer check the readonly types if the
 128         dictionary is writable.
 129         * ctf-open.c (init_types): Assert that this dictionary is not
 130         writable.  Adjust to use the new name hashes, ctf_name_table,
 131         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 132         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 133         if set.  Drop out early when dictionary is writable.  Split the
 134         ctf_lookups initialization into...
 135         (ctf_set_cth_hashes): ... this new function.
 136         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 137         (ctf_simple_open): Adjust accordingly.
 138         (ctf_bufopen): Likewise.
 139         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 140         destroy ctf_dtbyname, which is gone.
 141         (ctf_getdatasect): Remove spurious "extern".
 142         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 143         specified name table, given a kind.
 144         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 145         (ctf_member_iter): Add support for iterating over the
 146         dynamic type list.
 147         (ctf_enum_iter): Likewise.
 148         (ctf_variable_iter): Likewise.
 149         (ctf_type_rvisit): Likewise.
 150         (ctf_member_info): Add support for types in the dynamic type list.
 151         (ctf_enum_name): Likewise.
 152         (ctf_enum_value): Likewise.
 153         (ctf_func_type_info): Likewise.
 154         (ctf_func_type_args): Likewise.
 155         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 156         ctf_update.
 157         (ctf_link_write): Likewise.
 158         (ctf_link_intern_extern_string): Adjust for new
 159         ctf_str_add_external return value.
 160         (ctf_link_add_strtab): Likewise.
 161         * ctf-util.c (ctf_list_empty_p): New.
 162
 163 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 164
 165         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 166         type zero.
 167         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 168         members and types.
 169         (ctf_add_variable): Likewise for variables pointing to them.
 170         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 171         type link failure, but do warn for others.
 172         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 173         errors to be ENOMEM.
 174         (ctf_dump_member): Likewise.
 175         (ctf_dump_type): Likewise.
 176         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 177         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 178         (ctf_dump_header): Likewise.
 179         (ctf_dump_label): likewise.
 180         (ctf_dump_objts): likewise.
 181         (ctf_dump_funcs): likewise.
 182         (ctf_dump_var): likewise.
 183         (ctf_dump_str): Likewise.
 184
 185 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 186
 187         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 188         (LT_INIT): Likewise.
 189         (AM_INSTALL_LIBBFD): Likewise.
 190         (dlopen): Note why this is necessary in a comment.
 191         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 192         opcodes/.
 193         (SHARED_LDFLAGS): Likewise.
 194         (BFD_LIBADD): Likewise, for libbfd.
 195         (BFD_DEPENDENCIES): Likewise.
 196         (VERSION_FLAGS): Initialize, using a version script if ld supports
 197         one, or libtool -export-symbols-regex otherwise.
 198         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 199         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 200         (INCDIR): New.
 201         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 202         (noinst_LIBRARIES): Replace with...
 203         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 204         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 205         libctf-nobfd.la as well.
 206         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 207         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 208         (libctf_a_SOURCES): Rename to...
 209         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 210         ctf-open-bfd.c.
 211         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 212         with ctf-open-bfd.c added.
 213         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 214         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 215         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 216         * Makefile.am [INSTALL_LIBCTF]: Use it.
 217         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 218         libtool macros.
 219         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 220         the unstable components).
 221         * Makefile.in: Regenerated.
 222         * config.h.in: Likewise.
 223         * configure: Likewise.
 224
 225 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 226
 227         * configure.ac (INSTALL_LIBCTF): New, controlled by
 228         --enable-install-libctf.
 229         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 230         * Makefile.in: Regenerated.
 231         * configure: Regenerated.
 232
 233 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 234
 235         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 236         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 237
 238 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 239
 240         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 241
 242 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 243
 244         * ctf-impl.h (includes): Include <sys/param.h> here.
 245
 246 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 247
 248         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 249         (flip_objts): Likewise.
 250         (flip_vars): Likewise.
 251         (flip_types): Likewise.
 252
 253 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 254
 255         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 256         freeing functions: if set, free the key and value if the slot
 257         already exists.  Always reassign the key.
 258         (ctf_dynhash_insert): Adjust call appropriately.
 259         (ctf_hash_insert_type): Likewise.
 260
 261 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 262
 263         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 264         type kind.  Allow forwards to unify with pre-existing structs/
 265         unions/enums.
 266
 267 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 268
 269         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 270         <ctf_link_memb_name_changer>: Likewise.
 271         <ctf_link_memb_name_changer_arg>: Likewise.
 272         * ctf-create.c (ctf_update): Update accordingly.
 273         * ctf-open.c (ctf_file_close): Likewise.
 274         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 275         (ctf_link_add_cu_mapping): New.
 276         (ctf_link_set_memb_name_changer): Likewise.
 277         (ctf_change_parent_name): New.
 278         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 279         allocated by the caller's ctf_link_memb_name_changer.
 280         <ndynames>: Likewise.
 281         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 282         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 283         ctf_change_parent_name.  Free any resulting names.
 284
 285 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 286
 287         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 288         (ctf_link_one_type): ... here, with parent-name setting added.
 289         (check_variable): New.
 290         (ctf_link_one_variable): Likewise.
 291         (ctf_link_one_input_archive_member): Call it.
 292         * ctf-error.c (_ctf_errlist): Updated with new errors.
 293
 294 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 295
 296         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 297         (struct ctf_link_type_mapping_key): New.
 298         (ctf_hash_type_mapping_key): Likewise.
 299         (ctf_hash_eq_type_mapping_key): Likewise.
 300         (ctf_add_type_mapping): Likewise.
 301         (ctf_type_mapping): Likewise.
 302         (ctf_dynhash_empty): Likewise.
 303         * ctf-open.c (ctf_file_close): Update accordingly.
 304         * ctf-create.c (ctf_update): Likewise.
 305         (ctf_add_type): Populate the mapping.
 306         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 307         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 308         (ctf_dynhash_insert): Fix comment typo.
 309         (ctf_dynhash_empty): New.
 310         * ctf-link.c (ctf_add_type_mapping): New.
 311         (ctf_type_mapping): Likewise.
 312         (empty_link_type_mapping): New.
 313         (ctf_link_one_input_archive): Call it.
 314
 315 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 316
 317         * ctf-link.c: New file, linking of the string and type sections.
 318         * Makefile.am (libctf_a_SOURCES): Add it.
 319         * Makefile.in: Regenerate.
 320
 321         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 322         ctf_link_outputs.
 323         * ctf-create.c (ctf_update): Update accordingly.
 324         * ctf-open.c (ctf_file_close): Likewise.
 325         * ctf-error.c (_ctf_errlist): Updated with new errors.
 326
 327 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 328
 329         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 330
 331 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 332
 333         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 334         ctf_type_iter.
 335         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 336         (ctf_dump_format_type): Add non-root-type { } notation.
 337         Add root flag to prototype.
 338         (ctf_dump_label): Adjust accordingly.
 339         (ctf_dump_objts): Likewise.
 340         (ctf_dump_var): Likewise.
 341
 342 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 343
 344         * ctf-create.c (ctf_compress_write): Fix double-free.
 345
 346 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 347
 348         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 349         of...
 350         (ctf_arc_write_fd): ... this new function.
 351         * ctf-create.c (ctf_write_mem): New.
 352
 353 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 354
 355         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 356         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 357         (ctf_str_add_ref): Name the last arg.
 358         (ctf_str_add_external) New.
 359         (ctf_str_add_strraw_explicit): Likewise.
 360         (ctf_simple_open_internal): Likewise.
 361         (ctf_bufopen_internal): Likewise.
 362
 363         * ctf-string.c (ctf_strraw_explicit): Split from...
 364         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 365         (ctf_str_add_ref_internal): Return the atom, not the
 366         string.
 367         (ctf_str_add): Adjust accordingly.
 368         (ctf_str_add_ref): Likewise.  Move up in the file.
 369         (ctf_str_add_external): New: update the csa_offset.
 370         (ctf_str_count_strtab): Only account for strings with no csa_offset
 371         in the internal strtab length.
 372         (ctf_str_write_strtab): If the csa_offset is set, update the
 373         string's refs without writing the string out, and update the
 374         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 375         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 376         (ctf_update): Handle failure to populate the strtab.  Pass in the
 377         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 378         Call ctf_simple_open_internal, not ctf_simple_open.
 379         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 380         strings by hand.
 381         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 382         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 383         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 384         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 385         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 386         (ctf_simple_open_internal): ... this new function, which calls
 387         ctf_bufopen_internal.
 388         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 389         (ctf_bufopen_internal): ... this new function, which sets
 390         ctf_syn_ext_strtab.
 391
 392 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 393
 394         * ctf_types.c (ctf_type_iter_all): New.
 395
 396 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 397
 398         * ctf-open.c (init_symtab): Check for overflow against the right
 399         section.
 400         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 401         (upgrade_types_v1): Note that these sections are not checked.
 402         (flip_header): Endian-swap the header fields.
 403         (flip_ctf): Endian-swap the sections.
 404         (flip_objts): Update comment.
 405         (ctf_bufopen): Check header offsets and alignment for validity.
 406
 407 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 408
 409         * ctf-open-bfd.c: Add <assert.h>.
 410         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 411         techniques borrowed from bfd_elf_sym_name.
 412         (ctf_new_archive_internal): Improve comment.
 413         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 414         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 415         no symbol section, but not vice versa.
 416
 417 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 418
 419         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 420         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 421         * ctf-dump.c (dump_header): New function, dump the CTF header.
 422         (ctf_dump): Call it.
 423         (ctf_dump_header_strfield): New function.
 424         (ctf_dump_header_sectfield): Likewise.
 425
 426 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 427
 428         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 429         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 430         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 431         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 432         Print out ctf_cuname: only print out ctf_parname if set.
 433         (ctf_free_base): Removed, ctf_base is no longer freed: free
 434         ctf_dynbase instead.
 435         (ctf_set_version): Fix spacing.
 436         (upgrade_header): New, in-place header upgrading.
 437         (upgrade_types): Rename to...
 438         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 439         longer track old and new headers separately.  No longer allow for
 440         header sizes explicitly: squeeze the headers out on upgrade (they
 441         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 442         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 443         (upgrade_types): New, also handle ctf_parmax updating.
 444         (flip_header): Flip ctf_cuname.
 445         (flip_types): Flip BUF explicitly rather than deriving BUF from
 446         BASE.
 447         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 448         required alignment of objtoff and funcoff.  No longer store it in
 449         the ctf_buf unless that buf is derived unmodified from the input.
 450         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 451         that duplicate fields in ctf_file: move allocation of ctf_file
 452         further up instead.  Call upgrade_header as needed.  Move
 453         version-specific ctf_parmax initialization into upgrade_types.  More
 454         concise error handling.
 455         (ctf_file_close): No longer test for null pointers before freeing.
 456         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 457         ctf_free_base.
 458         (ctf_cuname): New.
 459         (ctf_cuname_set): New.
 460         * ctf-create.c (ctf_update): Populate ctf_cuname.
 461         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 462         comment.
 463         (ctf_write): Likewise.
 464         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 465         Fix the compression length: fp->ctf_size never counted the CTF
 466         header.  Simplify the compress call accordingly.
 467
 468 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 469
 470         * ctf-endian.h: Don't assume htole64 and le64toh are always
 471         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 472         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 473         not bswap_identity_64.
 474
 475 2019-09-18  Alan Modra  <amodra@gmail.com>
 476
 477         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 478
 479 2019-09-09  Phil Blundell  <pb@pbcl.net>
 480
 481         binutils 2.33 branch created.
 482
 483 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 484
 485         * ctf-types.c (ctf_type_aname_raw): New.
 486         (ctf_func_type_info): Likewise.
 487         (ctf_func_type_args): Likewise.
 488         * ctf-error.c (_ctf_errlist): Fix description.
 489         * ctf-lookup.c: Fix file description.
 490
 491 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 492
 493         * ctf-create.c (ctf_create): Fix off-by-one error.
 494
 495 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 496
 497         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 498         struct ctf_strs.
 499         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 500         (struct ctf_str_atom): New, disambiguated single string.
 501         (struct ctf_str_atom_ref): New, points to some other location that
 502         references this string's offset.
 503         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 504         Remove member ctf_dtvstrlen: we no longer track the total strlen
 505         as we add strings.
 506         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 507         (ctf_str_free_atoms): Likewise.
 508         (ctf_str_add): Likewise.
 509         (ctf_str_add_ref): Likewise.
 510         (ctf_str_rollback): Likewise.
 511         (ctf_str_purge_refs): Likewise.
 512         (ctf_str_write_strtab): Likewise.
 513         (ctf_realloc): Declare new function in ctf-util.c.
 514
 515         * ctf-open.c (ctf_bufopen): Create the atoms table.
 516         (ctf_file_close): Destroy it.
 517         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 518         special-case the position of the parname string.  Construct the
 519         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 520         rest of each buffer element is constructed, not via open-coding:
 521         realloc the CTF buffer and append the strtab to it.  No longer
 522         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 523         strtab construction.
 524         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 525         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 526         after buffer element construction instead.
 527         (ctf_copy_lmembers): Likewise.
 528         (ctf_copy_emembers): Likewise.
 529         (ctf_create): No longer maintain the ctf_dtvstrlen.
 530         (ctf_dtd_delete): Likewise.
 531         (ctf_dvd_delete): Likewise.
 532         (ctf_add_generic): Likewise.
 533         (ctf_add_enumerator): Likewise.
 534         (ctf_add_member_offset): Likewise.
 535         (ctf_add_variable): Likewise.
 536         (membadd): Likewise.
 537         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 538         if there are active ctf_str_num_refs.
 539         (ctf_strraw): Move to ctf-string.c.
 540         (ctf_strptr): Likewise.
 541         * ctf-string.c: New file, strtab manipulation.
 542
 543         * Makefile.am (libctf_a_SOURCES): Add it.
 544         * Makefile.in: Regenerate.
 545
 546 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 547
 548         * ctf-impl.h (ctf_hash_iter_f): New.
 549         (ctf_dynhash_iter): New declaration.
 550         (ctf_dynhash_iter_remove): New declaration.
 551         * ctf-hash.c (ctf_dynhash_iter): Define.
 552         (ctf_dynhash_iter_remove): Likewise.
 553         (ctf_hashtab_traverse): New.
 554         (ctf_hashtab_traverse_remove): Likewise.
 555         (struct ctf_traverse_cb_arg): Likewise.
 556         (struct ctf_traverse_remove_cb_arg): Likewise.
 557
 558 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 559
 560         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 561
 562 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 563
 564         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 565         (ctf_dump_funcs): Likewise.
 566
 567 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 568
 569         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 570         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 571         little-endian CTF archive magic.  Do not check the CTF version:
 572         ctf_simple_open does that in endian-safe ways.  Do not dereference
 573         null pointers on open failure.
 574
 575 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 576
 577         * ctf-open.c (get_vbytes_common): Return the new slice size.
 578         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 579         Remember to copy in the CTF data when opening an uncompressed
 580         foreign-endian CTF file.  Prune useless variable manipulation.
 581
 582 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 583
 584         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 585         seen.
 586
 587 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 588
 589         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 590         output.
 591
 592 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 593
 594         * ctf-subr.c (_PAGESIZE): Remove.
 595         (ctf_data_alloc): Likewise.
 596         (ctf_data_free): Likewise.
 597         (ctf_data_protect): Likewise.
 598         * ctf-impl.h: Remove declarations.
 599         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 600         ctf_free, not ctf_data_free.
 601         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 602         the buffer again on compression error.
 603         * ctf-open.c (ctf_set_base): No longer track the size: call
 604         ctf_free, not ctf_data_free.
 605         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 606         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 607
 608 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 609
 610         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 611         ctf_dynhash_insert.
 612         (ctf_dvd_insert): Likewise.
 613         (ctf_add_generic): Likewise.
 614         (ctf_add_variable): Likewise.
 615         * ctf-impl.h: Adjust declarations.
 616
 617 2019-06-14  Alan Modra  <amodra@gmail.com>
 618
 619         * configure: Regenerate.
 620
 621 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 622
 623         * ctf-decls.h: Include <libiberty.h>.
 624         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 625
 626 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 627
 628         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 629         (ctf_dump_objts): Likewise.
 630         (ctf_dump_funcs): Likewise.
 631         (ctf_dump_member): Likewise.
 632         (ctf_dump_str): Likewise.
 633
 634 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 635
 636         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 637         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 638
 639 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 640
 641         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 642         (ctf_arc_open_by_offset): Likewise.
 643         * ctf-create.c (ctf_add_type): Likewise.
 644
 645 2019-06-04  Tom Tromey  <tromey@adacore.com>
 646
 647         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 648         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 649
 650 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 651
 652         * configure.ac: Check for O_CLOEXEC.
 653         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 654         * config.h.in: Regenerate.
 655         * configure: Likewise.
 656
 657 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 658
 659         * qsort_r.c: Rename to...
 660         * ctf-qsort_r.c: ... this.
 661         (_quicksort): Define to ctf_qsort_r.
 662         * ctf-decls.h (qsort_r): Remove.
 663         (ctf_qsort_r): Add.
 664         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 665         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 666         * Makefile.am (libctf_a_LIBADD): Remove.
 667         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 668         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 669         * ctf-create.c (ctf_update): Likewise.
 670         * configure.ac: Check for BSD versus GNU qsort_r signature.
 671         * Makefile.in: Regenerate.
 672         * config.h.in: Likewise.
 673         * configure: Likewise.
 674
 675 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 676
 677         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 678
 679 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 680
 681         * Makefile.am (ZLIB): New.
 682         (ZLIBINC): Likewise.
 683         (AM_CFLAGS): Use them.
 684         (libctf_a_LIBADD): New, for LIBOBJS.
 685         * configure.ac: Check for zlib, endian.h, and qsort_r.
 686         * ctf-endian.h: New, providing htole64 and le64toh.
 687         * swap.h: Code style fixes.
 688         (bswap_identity_64): New.
 689         * qsort_r.c: New, from gnulib (with one added #include).
 690         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 691         and unconditional definitions of MIN and MAX.
 692         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 693         (ctf_set_errno): Now returns unsigned long.
 694         * ctf-util.c (ctf_set_errno): Adjust here too.
 695         * ctf-archive.c: Use ctf-endian.h.
 696         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 697         cts_flags and cts_offset.
 698         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 699         * ctf-create.c: Provide a definition of roundup if not defined.
 700         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 701         (ctf_add_reftype): Do not check if type IDs are below zero.
 702         (ctf_add_slice): Likewise.
 703         (ctf_add_typedef): Likewise.
 704         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 705         when known error-free.  Drop CTF_ERR usage for functions returning
 706         int.
 707         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 708         int.
 709         (ctf_add_variable): Likewise.
 710         (enumcmp): Likewise.
 711         (enumadd): Likewise.
 712         (membcmp): Likewise.
 713         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 714         when known error-free.
 715         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 716         returning int: use CTF_ERR for functions returning ctf_type_id.
 717         (ctf_dump_label): Likewise.
 718         (ctf_dump_objts): Likewise.
 719         * ctf-labels.c (ctf_label_topmost): Likewise.
 720         (ctf_label_iter): Likewise.
 721         (ctf_label_info): Likewise.
 722         * ctf-lookup.c (ctf_func_args): Likewise.
 723         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 724         (ctf_bufopen): Likewise.  Use zlib types as needed.
 725         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 726         returning int.
 727         (ctf_enum_iter): Likewise.
 728         (ctf_type_size): Likewise.
 729         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 730         (ctf_type_kind_unsliced): Likewise.
 731         (ctf_type_kind): Likewise.
 732         (ctf_type_encoding): Likewise.
 733         (ctf_member_info): Likewise.
 734         (ctf_array_info): Likewise.
 735         (ctf_enum_value): Likewise.
 736         (ctf_type_rvisit): Likewise.
 737         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 738         cts_offset.
 739         (ctf_simple_open): Likewise.
 740         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 741         * Makefile.in: Regenerate.
 742         * aclocal.m4: Likewise.
 743         * config.h: Likewise.
 744         * configure: Likewise.
 745
 746 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 747
 748         * configure.in: Check for bfd_section_from_elf_index.
 749         * configure: Regenerate.
 750         * config.h.in [HAVE_BFD_ELF]: Likewise.
 751         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 752         abfd is potentially unused now.
 753
 754 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 755
 756         * Makefile.am: New.
 757         * Makefile.in: Regenerated.
 758         * config.h.in: Likewise.
 759         * aclocal.m4: Likewise.
 760         * configure: Likewise.
 761
 762 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 763
 764         * ctf-dump.c: New.
 765
 766 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 767
 768         * ctf-labels.c: New.
 769
 770 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 771
 772         * ctf-impl.h (_libctf_version): New declaration.
 773         * ctf-subr.c (_libctf_version): Define it.
 774         (ctf_version): New.
 775
 776 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 777
 778         * ctf-create.c (enumcmp): New.
 779         (enumadd): Likewise.
 780         (membcmp): Likewise.
 781         (membadd): Likewise.
 782         (ctf_add_type): Likewise.
 783
 784 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 785
 786         * ctf-lookup.c (isqualifier): New.
 787         (ctf_lookup_by_name): Likewise.
 788         (struct ctf_lookup_var_key): Likewise.
 789         (ctf_lookup_var): Likewise.
 790         (ctf_lookup_variable): Likewise.
 791         (ctf_lookup_symbol_name): Likewise.
 792         (ctf_lookup_by_symbol): Likewise.
 793         (ctf_func_info): Likewise.
 794         (ctf_func_args): Likewise.
 795
 796 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 797
 798         * ctf-decl.c: New file.
 799         * ctf-types.c: Likewise.
 800         * ctf-impl.h: New declarations.
 801
 802 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 803
 804         * ctf-open-bfd.c: New file.
 805         * ctf-open.c (ctf_close): New.
 806         * ctf-impl.h: Include bfd.h.
 807         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 808         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 809         ctfi_bfd_close.
 810         (ctf_bfdopen_ctfsect): New declaration.
 811         (_CTF_SECTION): likewise.
 812
 813 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 814
 815         * ctf-archive.c: New.
 816         * ctf-impl.h (ctf_archive_internal): New type.
 817         (ctf_arc_open_internal): New declaration.
 818         (ctf_arc_bufopen): Likewise.
 819         (ctf_arc_close_internal): Likewise.
 820
 821 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 822
 823         * ctf-open.c: New file.
 824         * swap.h: Likewise.
 825
 826 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 827
 828         * ctf-create.c: New file.
 829         * ctf-lookup.c: New file.
 830
 831 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 832
 833         * ctf-impl.h: New definitions and declarations for type creation
 834         and lookup.
 835
 836 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 837
 838         * ctf-hash.c: New file.
 839         * ctf-impl.h: New declarations.
 840
 841 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 842
 843         * ctf-error.c: New file.
 844
 845 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 846
 847         * ctf-util.c: New file.
 848         * elf.h: Likewise.
 849         * ctf-impl.h: Include it, and add declarations.
 850
 851 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 852
 853         * ctf-impl.h: New file.
 854         * ctf-subr.c: New file.
 855
 856 \f
 857 Local Variables:
 858 mode: change-log
 859 left-margin: 8
 860 fill-column: 76
 861 version-control: never
 862 End: