libctf/ChangeLog

   1 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-impl.h (struct ctf_archive_internal) <ctfi_dicts>: New, dicts
   4         the archive machinery has opened and cached.
   5         <ctfi_symdicts>: New, cache of dicts containing symbols looked up.
   6         <ctfi_syms>: New, cache of types of symbols looked up.
   7         * ctf-archive.c (ctf_arc_close): Free them on close.
   8         (enosym): New, flag entry for 'symbol not present'.
   9         (ctf_arc_import_parent): New, automatically import the parent from
  10         ".ctf" if this is a child in an archive and ".ctf" is present.
  11         (ctf_dict_open_sections): Use it.
  12         (ctf_archive_iter_internal): Likewise.
  13         (ctf_cached_dict_close): New, thunk around ctf_dict_close.
  14         (ctf_dict_open_cached): New, open and cache a dict.
  15         (ctf_arc_flush_caches): New, flush the caches.
  16         (ctf_arc_lookup_symbol): New, look up a symbol in (all members of)
  17         an archive, and cache the lookup.
  18         (ctf_archive_iter): Note the new caching behaviour.
  19         (ctf_archive_next): Use ctf_dict_open_cached.
  20         * libctf.ver: Add ctf_arc_lookup_symbol and ctf_arc_flush_caches.
  21
  22 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  23
  24         * ctf-dedup.c (ctf_dedup_rhash_type): Null out the names of nameless
  25         type kinds, just in case the input has named them.
  26
  27 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  28
  29         * ctf-dump.c (ctf_dump_header): Dump the new flags bits and the index
  30         section lengths.
  31         (ctf_dump_objts): Report indexed sections.  Also dump functions.  Use
  32         ctf_symbol_next, not manual looping.
  33         (ctf_dump_funcs): Delete.
  34         (ctf_dump): Use ctf_dump_objts, not ctf_dump_funcs.
  35
  36 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  37
  38         * ctf-impl.h (CTF_INDEX_PAD_THRESHOLD): New.
  39         (_libctf_nonnull_): Likewise.
  40         (ctf_in_flight_dynsym_t): New.
  41         (ctf_dict_t) <ctf_funcidx_names>: Likewise.
  42         <ctf_objtidx_names>: Likewise.
  43         <ctf_nfuncidx>: Likewise.
  44         <ctf_nobjtidx>: Likewise.
  45         <ctf_funcidx_sxlate>: Likewise.
  46         <ctf_objtidx_sxlate>: Likewise.
  47         <ctf_objthash>: Likewise.
  48         <ctf_funchash>: Likewise.
  49         <ctf_dynsyms>: Likewise.
  50         <ctf_dynsymidx>: Likewise.
  51         <ctf_dynsymmax>: Likewise.
  52         <ctf_in_flight_dynsym>: Likewise.
  53         (struct ctf_next) <u.ctn_next>: Likewise.
  54         (ctf_symtab_skippable): New prototype.
  55         (ctf_add_funcobjt_sym): Likewise.
  56         (ctf_dynhash_sort_by_name): Likewise.
  57         (ctf_sym_to_elf64): Rename to...
  58         (ctf_elf32_to_link_sym): ... this, and...
  59         (ctf_elf64_to_link_sym): ... this.
  60         * ctf-open.c (init_symtab): Check for lack of CTF_F_NEWFUNCINFO
  61         flag, and presence of index sections.  Refactor out
  62         ctf_symtab_skippable and ctf_elf*_to_link_sym, and use them.  Use
  63         ctf_link_sym_t, not Elf64_Sym.  Skip initializing objt or func
  64         sxlate sections if corresponding index section is present.  Adjust
  65         for new func info section format.
  66         (ctf_bufopen_internal): Add ctf_err_warn to corrupt-file error
  67         handling.  Report incorrect-length index sections.  Always do an
  68         init_symtab, even if there is no symtab section (there may be index
  69         sections still).
  70         (flip_objts): Adjust comment: func and objt sections are actually
  71         identical in structure now, no need to caveat.
  72         (ctf_dict_close):  Free newly-added data structures.
  73         * ctf-create.c (ctf_create): Initialize them.
  74         (ctf_symtab_skippable): New, refactored out of
  75         init_symtab, with st_nameidx_set check added.
  76         (ctf_add_funcobjt_sym): New, add a function or object symbol to the
  77         ctf_objthash or ctf_funchash, by name.
  78         (ctf_add_objt_sym): Call it.
  79         (ctf_add_func_sym): Likewise.
  80         (symtypetab_delete_nonstatic_vars): New, delete vars also present as
  81         data objects.
  82         (CTF_SYMTYPETAB_EMIT_FUNCTION): New flag to symtypetab emitters:
  83         this is a function emission, not a data object emission.
  84         (CTF_SYMTYPETAB_EMIT_PAD): New flag to symtypetab emitters: emit
  85         pads for symbols with no type (only set for unindexed sections).
  86         (CTF_SYMTYPETAB_FORCE_INDEXED): New flag to symtypetab emitters:
  87         always emit indexed.
  88         (symtypetab_density): New, figure out section sizes.
  89         (emit_symtypetab): New, emit a symtypetab.
  90         (emit_symtypetab_index): New, emit a symtypetab index.
  91         (ctf_serialize): Call them, emitting suitably sorted symtypetab
  92         sections and indexes.  Set suitable header flags.  Copy over new
  93         fields.
  94         * ctf-hash.c (ctf_dynhash_sort_by_name): New, used to impose an
  95         order on symtypetab index sections.
  96         * ctf-link.c (ctf_add_type_mapping): Delete erroneous comment
  97         relating to code that was never committed.
  98         (ctf_link_one_variable): Improve variable name.
  99         (check_sym): New, symtypetab analogue of check_variable.
 100         (ctf_link_deduplicating_one_symtypetab): New.
 101         (ctf_link_deduplicating_syms): Likewise.
 102         (ctf_link_deduplicating): Call them.
 103         (ctf_link_deduplicating_per_cu): Note that we don't call them in
 104         this case (yet).
 105         (ctf_link_add_strtab): Set the error on the fp correctly.
 106         (ctf_link_add_linker_symbol): New (no longer a do-nothing stub), add
 107         a linker symbol to the in-flight list.
 108         (ctf_link_shuffle_syms): New (no longer a do-nothing stub), turn the
 109         in-flight list into a mapping we can use, now its names are
 110         resolvable in the external strtab.
 111         * ctf-string.c (ctf_str_rollback_atom): Don't roll back atoms with
 112         external strtab offsets.
 113         (ctf_str_rollback): Adjust comment.
 114         (ctf_str_write_strtab): Migrate ctf_syn_ext_strtab population from
 115         writeout time...
 116         (ctf_str_add_external): ... to string addition time.
 117         * ctf-lookup.c (ctf_lookup_var_key_t): Rename to...
 118         (ctf_lookup_idx_key_t): ... this, now we use it for syms too.
 119         <clik_names>: New member, a name table.
 120         (ctf_lookup_var): Adjust accordingly.
 121         (ctf_lookup_variable): Likewise.
 122         (ctf_lookup_by_id): Shuffle further up in the file.
 123         (ctf_symidx_sort_arg_cb): New, callback for...
 124         (sort_symidx_by_name): ... this new function to sort a symidx
 125         found to be unsorted (likely originating from the compiler).
 126         (ctf_symidx_sort): New, sort a symidx.
 127         (ctf_lookup_symbol_name): Support dynamic symbols with indexes
 128         provided by the linker.  Use ctf_link_sym_t, not Elf64_Sym.
 129         Check the parent if a child lookup fails.
 130         (ctf_lookup_by_symbol): Likewise.  Work for function symbols too.
 131         (ctf_symbol_next): New, iterate over symbols with types (without
 132         sorting).
 133         (ctf_lookup_idx_name): New, bsearch for symbol names in indexes.
 134         (ctf_try_lookup_indexed): New, attempt an indexed lookup.
 135         (ctf_func_info): Reimplement in terms of ctf_lookup_by_symbol.
 136         (ctf_func_args): Likewise.
 137         (ctf_get_dict): Move...
 138         * ctf-types.c (ctf_get_dict): ... here.
 139         * ctf-util.c (ctf_sym_to_elf64): Re-express as...
 140         (ctf_elf64_to_link_sym): ... this.  Add new st_symidx field, and
 141         st_nameidx_set (always 0, so st_nameidx can be ignored).  Look in
 142         the ELF strtab for names.
 143         (ctf_elf32_to_link_sym): Likewise, for Elf32_Sym.
 144         (ctf_next_destroy): Destroy ctf_next_t.u.ctn_next if need be.
 145         * libctf.ver: Add ctf_symbol_next, ctf_add_objt_sym and
 146         ctf_add_func_sym.
 147
 148 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 149
 150         * ctf-link.c (ctf_link_shuffle_syms): Adjust.
 151         (ctf_link_add_linker_symbol): New, unimplemented stub.
 152         * libctf.ver: Add it.
 153         * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
 154         dicts.
 155         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
 156         symtab/strtab if not present, dynsym/dynstr otherwise.
 157         * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
 158         some arbitrary member of a CTF archive.
 159         * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
 160
 161 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 162
 163         * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
 164         (ctf_dict_open_by_offset): ... this.  Adjust callers.
 165         (ctf_arc_open_by_name_internal): Rename to...
 166         (ctf_dict_open_internal): ... this.  Adjust callers.
 167         (ctf_arc_open_by_name_sections): Rename to...
 168         (ctf_dict_open_sections): ... this, keeping compatibility function.
 169         (ctf_arc_open_by_name): Rename to...
 170         (ctf_dict_open): ... this, keeping compatibility function.
 171         * libctf.ver: New functions added.
 172         * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
 173         (ctf_link_deduplicating_open_inputs): Likewise.
 174
 175 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 176
 177         * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
 178         adjusted.
 179         (ctf_fileops): Rename to...
 180         (ctf_dictops): ... this.
 181         (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
 182         <cd_id_to_dict_t>: ... this.
 183         (ctf_file_t): Fix outdated comment.
 184         <ctf_fileops>: Rename to...
 185         <ctf_dictops>: ... this.
 186         (struct ctf_archive_internal) <ctfi_file>: Rename to...
 187         <ctfi_dict>: ... this.
 188         * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
 189         Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
 190         Rename ctf_file_close to ctf_dict_close.  All users adjusted.
 191         * ctf-create.c: Likewise.  Refer to CTF dicts, not CTF containers.
 192         (ctf_bundle_t) <ctb_file>: Rename to...
 193         <ctb_dict): ... this.
 194         * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
 195         * ctf-dedup.c: Likewise.  Rename ctf_file_close to
 196         ctf_dict_close. Refer to CTF dicts, not CTF containers.
 197         * ctf-dump.c: Likewise.
 198         * ctf-error.c: Likewise.
 199         * ctf-hash.c: Likewise.
 200         * ctf-inlines.h: Likewise.
 201         * ctf-labels.c: Likewise.
 202         * ctf-link.c: Likewise.
 203         * ctf-lookup.c: Likewise.
 204         * ctf-open-bfd.c: Likewise.
 205         * ctf-string.c: Likewise.
 206         * ctf-subr.c: Likewise.
 207         * ctf-types.c: Likewise.
 208         * ctf-util.c: Likewise.
 209         * ctf-open.c: Likewise.
 210         (ctf_file_close): Rename to...
 211         (ctf_dict_close): ...this.
 212         (ctf_file_close): New trivial wrapper around ctf_dict_close, for
 213         compatibility.
 214         (ctf_parent_file): Rename to...
 215         (ctf_parent_dict): ... this.
 216         (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
 217         compatibility.
 218         * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
 219
 220 2020-10-21  Tom Tromey  <tromey@adacore.com>
 221
 222         * mkerrors.sed: Remove.
 223         * ctf-error.c (_CTF_FIRST): New define.
 224         (_CTF_ITEM): Define this, not _CTF_STR.
 225         (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
 226         (ERRSTRFIELD): Rewrite.
 227         (ERRSTRFIELD1): Remove.
 228         * Makefile.in: Rebuild.
 229         * Makefile.am (BUILT_SOURCES): Remove.
 230         (ctf-error.h): Remove.
 231
 232 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 233
 234         * ctf-subr.c (open_errors): New list.
 235         (ctf_err_warn): Calls with NULL fp append to open_errors.  Add err
 236         parameter, and use it to decorate the debug stream with errmsgs.
 237         (ctf_err_warn_to_open): Splice errors from a CTF dict into the
 238         open_errors.
 239         (ctf_errwarning_next): Calls with NULL fp report from open_errors.
 240         New err param to report iteration errors (including end-of-iteration)
 241         when fp is NULL.
 242         (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
 243         parameter: gettextize.
 244         * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
 245         (LCTF_VBYTES): Adjust.
 246         (ctf_err_warn_to_open): New.
 247         (ctf_err_warn): Adjust.
 248         (ctf_bundle): Used in only one place: move...
 249         * ctf-create.c: ... here.
 250         (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
 251         down as needed.  Don't emit the errmsg.  Gettextize.
 252         (membcmp): Likewise.
 253         (ctf_add_type_internal): Likewise.
 254         (ctf_write_mem): Likewise.
 255         (ctf_compress_write): Likewise.  Report errors writing the header or
 256         body.
 257         (ctf_write): Likewise.
 258         * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
 259         ctf_dprintf, and gettextize, as above.
 260         (ctf_arc_write): Likewise.
 261         (ctf_arc_bufopen): Likewise.
 262         (ctf_arc_open_internal): Likewise.
 263         * ctf-labels.c (ctf_label_iter): Likewise.
 264         * ctf-open-bfd.c (ctf_bfdclose): Likewise.
 265         (ctf_bfdopen): Likewise.
 266         (ctf_bfdopen_ctfsect): Likewise.
 267         (ctf_fdopen): Likewise.
 268         * ctf-string.c (ctf_str_write_strtab): Likewise.
 269         * ctf-types.c (ctf_type_resolve): Likewise.
 270         * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
 271         (get_vbytes_v1): Pass down the ctf dict.
 272         (get_vbytes_v2): Likewise.
 273         (flip_ctf): Likewise.
 274         (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
 275         gettextize, as above.
 276         (upgrade_types_v1): Adjust calls.
 277         (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
 278         (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
 279         emitted into individual dicts into the open errors if this turns
 280         out to be a failed open in the end.
 281         * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
 282         argument.  Gettextize.  Don't emit the errmsg.
 283         (ctf_dump_funcs): Likewise.  Collapse err label into its only case.
 284         (ctf_dump_type): Likewise.
 285         * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
 286         argument.  Gettextize.  Don't emit the errmsg.
 287         (ctf_link_one_type): Likewise.
 288         (ctf_link_lazy_open): Likewise.
 289         (ctf_link_one_input_archive): Likewise.
 290         (ctf_link_deduplicating_count_inputs): Likewise.
 291         (ctf_link_deduplicating_open_inputs): Likewise.
 292         (ctf_link_deduplicating_close_inputs): Likewise.
 293         (ctf_link_deduplicating): Likewise.
 294         (ctf_link): Likewise.
 295         (ctf_link_deduplicating_per_cu): Likewise. Add some missed
 296         ctf_set_errnos to obscure error cases.
 297         * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
 298         err argument.  Gettextize.  Don't emit the errmsg.
 299         (ctf_dedup_populate_mappings): Likewise.
 300         (ctf_dedup_detect_name_ambiguity): Likewise.
 301         (ctf_dedup_init): Likewise.
 302         (ctf_dedup_multiple_input_dicts): Likewise.
 303         (ctf_dedup_conflictify_unshared): Likewise.
 304         (ctf_dedup): Likewise.
 305         (ctf_dedup_rwalk_one_output_mapping): Likewise.
 306         (ctf_dedup_id_to_target): Likewise.
 307         (ctf_dedup_emit_type): Likewise.
 308         (ctf_dedup_emit_struct_members): Likewise.
 309         (ctf_dedup_populate_type_mapping): Likewise.
 310         (ctf_dedup_populate_type_mappings): Likewise.
 311         (ctf_dedup_emit): Likewise.
 312         (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
 313         status setting.
 314         (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
 315         unknown-type-kind messages (which signify file corruption).
 316
 317 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 318
 319         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
 320         declare this to be version 1.2.0.
 321         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
 322         * Makefile.in: Regenerated.
 323         * configure: Regenerated.
 324         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
 325         * ctf-impl.h: Include it.
 326         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
 327         (ctf_errmsg): Actually translate them.
 328
 329 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 330
 331         PR binutils/25155:
 332         * ctf-create.c (EOVERFLOW): If not defined by system header,
 333         redirect to ERANGE as a poor man's substitute.
 334         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
 335
 336 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 337
 338         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
 339         (ctf_dtd_delete): Likewise.
 340         (ctf_dtd_lookup): Likewise.
 341         (ctf_rollback): Likewise.
 342         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
 343         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
 344
 345 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 346
 347         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
 348
 349 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 350
 351         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
 352         number if needed.
 353
 354 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 355
 356         * ctf-impl.h (ctf_list_splice): New.
 357         * ctf-util.h (ctf_list_splice): Likewise.
 358         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
 359         (ctf_link_sort_inputs): Likewise.
 360         (ctf_link_deduplicating_count_inputs): Likewise.
 361         (ctf_link_deduplicating_open_inputs): Likewise.
 362         (ctf_link_deduplicating_close_inputs): Likewise.
 363         (ctf_link_deduplicating_variables): Likewise.
 364         (ctf_link_deduplicating_per_cu): Likewise.
 365         (ctf_link_deduplicating): Likewise.
 366         (ctf_link): Call it.
 367
 368 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 369
 370         * ctf-link.c (ctf_link_one_input_archive_member): Check
 371         CTF_LINK_OMIT_VARIABLES_SECTION.
 372
 373 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 374
 375         * ctf-impl.h (ctf_type_id_key): New, the key in the
 376         cd_id_to_file_t.
 377         (ctf_dedup): New, core deduplicator state.
 378         (ctf_file_t) <ctf_dedup>: New.
 379         <ctf_dedup_atoms>: New.
 380         <ctf_dedup_atoms_alloc>: New.
 381         (ctf_hash_type_id_key): New prototype.
 382         (ctf_hash_eq_type_id_key): Likewise.
 383         (ctf_dedup_atoms_init): Likewise.
 384         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
 385         (ctf_dedup_atoms_init): Likewise.
 386         * ctf-create.c (ctf_serialize): Adjusted.
 387         (ctf_add_encoded): No longer static.
 388         (ctf_add_reftype): Likewise.
 389         * ctf-open.c (ctf_file_close): Destroy the
 390         ctf_dedup_atoms_alloc.
 391         * ctf-dedup.c: New file.
 392         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
 393         * configure.ac: Check for stpcpy.
 394         * Makefile.am: Add it.
 395         * Makefile.in: Regenerate.
 396         * config.h.in: Regenerate.
 397         * configure: Regenerate.
 398
 399 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 400
 401         * configure.ac: Add --enable-libctf-hash-debugging.
 402         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
 403         * Makefile.in: Regenerated.
 404         * configure: Likewise.
 405         * config.h.in: Likewise.
 406         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
 407         (ctf_assert): Define to assert.
 408
 409 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 410
 411         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
 412         sha1_process_bytes.
 413         * ctf-impl.h: Include it.
 414         (ctf_sha1_init): New.
 415         (ctf_sha1_add): Likewise.
 416         (ctf_sha1_fini): Likewise.
 417         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 418         producing strings.
 419         * Makefile.am: Add file.
 420         * Makefile.in: Regenerate.
 421
 422 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 423
 424         * libctf.ver (ctf_link_set_variable_filter): Add.
 425         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 426         <ctf_link_variable_filter_arg>: Likewise.
 427         * ctf-create.c (ctf_serialize): Adjust.
 428         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 429         (ctf_link_one_variable): Call it if set.
 430
 431 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 432
 433         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 434         conflicts, not the source type.
 435
 436 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 437
 438         * ctf-impl.h (ctf_file_t): Improve comments.
 439         <ctf_link_cu_mapping>: Split into...
 440         <ctf_link_in_cu_mapping>: ... this...
 441         <ctf_link_out_cu_mapping>: ... and this.
 442         * ctf-create.c (ctf_serialize): Adjust.
 443         * ctf-open.c (ctf_file_close): Likewise.
 444         * ctf-link.c (ctf_create_per_cu): Look things up in the
 445         in_cu_mapping instead of the cu_mapping.
 446         (ctf_link_add_cu_mapping): The deduplicating link will define
 447         what happens if many FROMs share a TO.
 448         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 449         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 450         create per-CU dicts here: they are already created when needed.
 451         (ctf_link_one_variable): Log a debug message if we skip a
 452         variable due to its type being concealed in a CU-mapped link.
 453         (This is probably too common a case to make into a warning.)
 454         (ctf_link): Create empty per-CU dicts if requested.
 455
 456 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 457
 458         * ctf-link.c (ctf_link_write): Close the fd.
 459
 460 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 461
 462         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 463         * Makefile.in: Regenerated.
 464         * ctf-impl.h (ctf_link_input_name): New.
 465         (ctf_file_t) <ctf_link_flags>: New.
 466         * ctf-create.c (ctf_serialize): Adjust accordingly.
 467         * ctf-link.c: Define ctf_open as weak when PIC.
 468         (ctf_arc_close_thunk): Remove unnecessary thunk.
 469         (ctf_file_close_thunk): Likewise.
 470         (ctf_link_input_name): New.
 471         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 472         (ctf_link_input_close): Adjust accordingly.
 473         (ctf_link_add_ctf_internal): New, split from...
 474         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 475         CTF is not possible.  Change to just call...
 476         (ctf_link_add): ... this new function.
 477         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 478         ctf_file_close_thunk.
 479         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 480         <in_file_name>: ... this.
 481         <arcname>: Drop.
 482         <share_mode>: Likewise (migrated to ctf_link_flags).
 483         <done_main_member>: Rename to...
 484         <done_parent>: ... this.
 485         <main_input_fp>: Rename to...
 486         <in_fp_parent>: ... this.
 487         <cu_mapped>: New.
 488         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 489         ctf_err_warn, removing a TODO.
 490         (ctf_link_one_variable): Note a case too common to warn about.
 491         Report in the debug stream if a cu-mapped link prevents addition
 492         of a conflicting variable.
 493         (ctf_link_one_input_archive_member): Adjust.
 494         (ctf_link_lazy_open): New, open a CTF archive for linking when
 495         needed.
 496         (ctf_link_close_one_input_archive): New, close it again.
 497         (ctf_link_one_input_archive): Adjust for lazy opening, member
 498         renames, and ctf_err_warn transition.  Move the
 499         empty_link_type_mapping call to...
 500         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 501         Don't spuriously fail if some input contains no CTF data.
 502         (ctf_link_write): ctf_err_warn transition.
 503         * libctf.ver: Remove not-yet-stable comment.
 504
 505 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 506
 507         * ctf-impl.h (ctf_strerror): Delete.
 508         * ctf-subr.c (ctf_strerror): Likewise.
 509         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 510         strerror directly.
 511
 512 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 513
 514         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 515         (ctf_import_unref): New.
 516         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 517         zero.  Don't recurse back in if the refcount is already zero.
 518         (ctf_import): Check ctf_parent_unreffed before deciding whether
 519         to close a pre-existing parent.  Set it to zero.
 520         (ctf_import_unreffed): New, as above, setting
 521         ctf_parent_unreffed to 1.
 522         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 523         child: use direct assignment, and set unreffed on the new and
 524         old children.
 525         * ctf-link.c (ctf_create_per_cu): Import the parent using
 526         ctf_import_unreffed.
 527
 528 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 529
 530         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 531         (ctf_link_type_key): ... this, adjusting member prefixes to
 532         match.
 533         (ctf_hash_type_mapping_key): Rename to...
 534         (ctf_hash_type_key): ... this.
 535         (ctf_hash_eq_type_mapping_key): Rename to...
 536         (ctf_hash_eq_type_key): ... this.
 537         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 538         (ctf_hash_type_key): ... this, and adjust for member name
 539         changes.
 540         (ctf_hash_eq_type_mapping_key): Rename to...
 541         (ctf_hash_eq_type_key): ... this, and adjust for member name
 542         changes.
 543         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 544         need for out-of-memory checking in this code.
 545         (ctf_type_mapping): Adjust.
 546
 547 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 548
 549         configure.ac: Check for vasprintf.
 550         configure: Regenerated.
 551         config.h.in: Likewise.
 552
 553 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 554
 555         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 556
 557 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 558
 559         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 560         New.
 561         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 562         if the input has no symtab, rather than dividing by
 563         zero. Arrange to free it later via ctfi_free_ctfsect.
 564         * ctf-archive.c (ctf_new_archive_internal): Do not
 565         ctfi_free_strsect by default.
 566         (ctf_arc_close): Possibly free it here.
 567
 568 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 569
 570         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 571         (ctf_dump_format_type): improve slice formatting.  Always print
 572         the type size, even of slices.
 573         (ctf_dump_member): Print slices (-> bitfields) differently from
 574         non-slices.  Failure to format a type is not an OOM.
 575
 576 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 577
 578         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 579         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 580         (ctf_dump_objts): Likewise.
 581         (ctf_dump_var): Likewise.
 582         (ctf_dump_type): Do not emit a duplicate message.  Move to
 583         ctf_err_warning, and swallow all errors.
 584
 585 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 586
 587         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 588         (ctf_decl_buf): Once it escapes, don't try to free it later.
 589
 590 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 591
 592         * ctf-types.c (ctf_type_aname): Print arg types here...
 593         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 594         in the type name here.
 595
 596 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 597
 598         * ctf-impl.h (ctf_assert): New.
 599         (ctf_err_warning_t): Likewise.
 600         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 601         (ctf_err_warn): New prototype.
 602         (ctf_assert_fail_internal): Likewise.
 603         * ctf-inlines.h (ctf_assert_internal): Likewise.
 604         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 605         * ctf-create.c (ctf_serialize): Copy it on serialization.
 606         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 607         (ctf_errwarning_next): New iterator, free and pass back
 608         errors/warnings in succession.
 609         * libctf.ver (ctf_errwarning_next): Add.
 610
 611 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 612
 613         * ctf-types.c (ctf_variable_iter): Fix error return.
 614
 615 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 616
 617         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 618
 619 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 620
 621         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 622
 623 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 624
 625         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 626         sorting functions.
 627         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 628         ctf_dynhash_next_sorted.
 629         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 630         <cu.ctn_s>: New, pointer to the dynset under iteration.
 631         (ctf_hash_sort_f): Sorting function passed to...
 632         (ctf_dynhash_next_sorted): ... this new function.
 633         (ctf_dynhash_next): New.
 634         (ctf_dynset_next): New.
 635         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 636         (ctf_dynhash_cnext): New.
 637         (ctf_dynset_cnext): New.
 638         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 639         (ctf_dynhash_next): New.
 640         (ctf_dynset_next): New.
 641         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 642         needed.
 643         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 644
 645 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 646
 647         * ctf-impl.h (ctf_next): New.
 648         (ctf_get_dict): New prototype.
 649         * ctf-lookup.c (ctf_get_dict): New, split out of...
 650         (ctf_lookup_by_id): ... here.
 651         * ctf-util.c (ctf_next_create): New.
 652         (ctf_next_destroy): New.
 653         (ctf_next_copy): New.
 654         * ctf-types.c (includes): Add <assert.h>.
 655         (ctf_member_next): New.
 656         (ctf_enum_next): New.
 657         (ctf_type_iter): Document the lack of iteration over parent
 658         types.
 659         (ctf_type_next): New.
 660         (ctf_variable_next): New.
 661         * ctf-archive.c (ctf_archive_next): New.
 662         * libctf.ver: Add new public functions.
 663
 664 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 665
 666         * libctf.ver (ctf_ref): New.
 667         * ctf-open.c (ctf_ref): Implement it.
 668
 669 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 670
 671         * ctf-inlines.h (ctf_forwardable_kind): New.
 672         * ctf-create.c (ctf_add_forward): Use it.
 673
 674 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 675
 676         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 677         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 678
 679 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 680
 681         * ctf-hash.c (ctf_dynset_eq_string): New.
 682         (ctf_dynset_create): New.
 683         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 684         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 685         (key_to_internal): New.
 686         (internal_to_key): New.
 687         (ctf_dynset_insert): New.
 688         (ctf_dynset_remove): New.
 689         (ctf_dynset_destroy): New.
 690         (ctf_dynset_lookup): New.
 691         (ctf_dynset_exists): New.
 692         (ctf_dynset_lookup_any): New.
 693         (ctf_hash_insert_type): Coding style.
 694         (ctf_hash_define_type): Likewise.
 695         * ctf-impl.h (ctf_dynset_t): New.
 696         (ctf_dynset_eq_string): New.
 697         (ctf_dynset_create): New.
 698         (ctf_dynset_insert): New.
 699         (ctf_dynset_remove): New.
 700         (ctf_dynset_destroy): New.
 701         (ctf_dynset_lookup): New.
 702         (ctf_dynset_exists): New.
 703         (ctf_dynset_lookup_any): New.
 704         * ctf-inlines.h (ctf_dynset_cinsert): New.
 705
 706 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 707
 708         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 709         <value_free>: Likewise.
 710         <owner>: New.
 711         (ctf_dynhash_item_free): Indirect through the owner.
 712         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 713         allocate space for the key_free and value_free fields fields
 714         if necessary.
 715         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 716         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 717         value_free if they will exist.  Set the slot's owner, but only
 718         if it exists.
 719         (ctf_dynhash_remove): Adjust.
 720
 721 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 722
 723         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 724         there is a key-freeing function and the key already exists.
 725
 726 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 727
 728         * ctf-inlines.h: New file.
 729         * ctf-impl.h: Include it.
 730         (ctf_hash_iter_find_f): New typedef.
 731         (ctf_dynhash_elements): New.
 732         (ctf_dynhash_lookup_kv): New.
 733         (ctf_dynhash_iter_find): New.
 734         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 735         (ctf_traverse_find_cb_arg_t): New.
 736         (ctf_hashtab_traverse_find): New.
 737         (ctf_dynhash_iter_find): New.
 738         (ctf_dynhash_elements): New.
 739
 740 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 741
 742         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 743
 744 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 745
 746         * ctf-archive.c (ctf_archive_count): New.
 747         * libctf.ver: New public function.
 748
 749 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 750
 751         * ctf-types.c (ctf_member_count): New.
 752         * libctf.ver: New public function.
 753
 754 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 755
 756         * ctf-types.c (ctf_type_kind_forwarded): New.
 757
 758 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 759
 760         * ctf-types.c (ctf_type_name_raw): New.
 761         (ctf_type_aname_raw): Reimplement accordingly.
 762
 763 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 764
 765         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 766
 767 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 768
 769         * ctf-impl.h (struct ctf_archive_internal)
 770         <ctfi_unmap_on_close>: New.
 771         (ctf_new_archive_internal): Adjust.
 772         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 773         Initialize ctfi_unmap_on_close.  Adjust error path.
 774         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 775         (unmap_on_close is 0).
 776         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 777         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 778
 779 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 780
 781         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 782         ints, floats or typedefs have no name.  Fix comment typo.
 783
 784 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 785
 786         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 787         resolves to an integral type.
 788         * ctf-types.c (ctf_type_encoding): Resolve the type before
 789         fishing its encoding out.
 790
 791 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 792
 793         * ctf-create.c (ctf_create): Mark dirty.
 794
 795 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 796
 797         * ctf-create.c (membcmp)  Skip nameless members.
 798
 799 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 800
 801         * ctf-create.c (ctf_add_member_offset): Support names of ""
 802         as if they were the null pointer.
 803
 804 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 805
 806         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 807         special-casing.
 808
 809 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 810
 811         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 812
 813 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 814
 815         * ctf-create.c (ctf_serialize): Add cast.
 816         (ctf_add_slice): Likewise.
 817
 818 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 819
 820         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 821         * ctf-create.c (ctf_add_function): Check for unimplemented type
 822         and populate at the same time.  Populate one-by-one, not via
 823         memcpy.
 824         (ctf_serialize): Remove unnecessary cast.
 825         * ctf-types.c (ctf_func_type_info): Likewise.
 826         (ctf_func_type_args): Likewise.  Fix comment typo.
 827
 828 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 829
 830         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 831         (ctf_add_array): Support array contents of type zero.
 832         (ctf_add_function): Support arguments and return types of
 833         type zero.
 834         (ctf_add_typedef): Support typedefs to type zero.
 835         (ctf_add_member_offset): Support members of type zero,
 836         unless added at unspecified (naturally-aligned) offset.
 837
 838 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 839
 840         * ctf-error.c: Include <stddef.h>, for offsetof.
 841         (_ctf_errlist): Migrate to...
 842         (_ctf_errlist_t): ... this.
 843         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 844         (_ctf_nerr): Remove.
 845         (ctf_errmsg): Adjust accordingly.
 846         * Makefile.am (BUILT_SOURCES): Note...
 847         (ctf-error.h): ... this new rule.
 848         * Makefile.in: Regenerate.
 849         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 850         * .gitignore: New, ignore ctf-error.h.
 851
 852 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 853
 854         * ctf-impl.h: Fix typos in comments.
 855
 856 2020-07-22  Nick Clifton  <nickc@redhat.com>
 857
 858         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 859         same file descriptor.
 860
 861 2020-07-04  Nick Clifton  <nickc@redhat.com>
 862
 863         Binutils 2.35 branch created.
 864
 865 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 866
 867         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 868         alphabetical order.
 869         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 870         * config.h.in: Regenerated.
 871         * Makefile.in: Likewise.
 872         * configure: Likewise.
 873
 874 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 875
 876         * ctf-create.c: Include <unistd.h>.
 877         * ctf-open-bfd.c: Likewise.
 878
 879 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 880
 881         PR libctf/25120
 882         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 883         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 884         means this is declared.
 885         (bswap_32): Likewise.
 886         (bswap_64): Likewise.
 887         (bswap_identity_64): Remove, unused.
 888         * configure: Regenerated.
 889         * config.h.in: Likewise.
 890
 891 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 892
 893         PR libctf/25120
 894         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 895         (_libctf_unlikely_): Likewise.
 896         (_libctf_unused): Likewise.
 897         (_libctf_malloc_): Likewise.
 898
 899 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 900
 901         PR libctf/25120
 902         * ctf-archive.c (search_nametbl): No longer global: declare...
 903         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 904         (search_modent_by_name): Take and use ARG for the nametbl.
 905
 906 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 907
 908         * ctf-impl.h (ctf_new_archive_internal): Declare.
 909         (ctf_arc_bufopen): Remove.
 910         (ctf_archive_internal) <ctfi_free_symsect>: New.
 911         * ctf-archive.c (ctf_arc_close): Use it.
 912         (ctf_arc_bufopen): Fuse into...
 913         (ctf_new_archive_internal): ... this, moved across from...
 914         * ctf-open-bfd.c: ... here.
 915         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 916         * libctf.ver: Add it.
 917
 918 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 919
 920         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 921         (ctf_dtd_delete): Remove correspondingly.
 922         (ctf_rollback): Likewise.
 923
 924 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 925
 926         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 927         unchanged.
 928
 929 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 930
 931         * ctf-create.c (ctf_add_forward): Don't add forwards to
 932         types that already exist.
 933
 934 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 935
 936         * ctf-open.c (init_types): Only intern root-visible types.
 937         * ctf-create.c (ctf_dtd_insert): Likewise.
 938         (ctf_dtd_delete): Only remove root-visible types.
 939         (ctf_rollback): Likewise.
 940         (ctf_add_generic): Adjust.
 941         (ctf_add_struct_sized): Adjust comment.
 942         (ctf_add_union_sized): Likewise.
 943         (ctf_add_enum): Likewise.
 944         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 945
 946 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 947
 948         * swap.h (bswap_identity_64): Make static.
 949
 950 2020-01-18  Nick Clifton  <nickc@redhat.com>
 951
 952         Binutils 2.34 branch created.
 953
 954 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 955
 956         PR binutils/25155:
 957         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 958         * configure, config.h.in: Regenerate.
 959
 960 2020-01-01  Alan Modra  <amodra@gmail.com>
 961
 962         Update year range in copyright notice of all files.
 963
 964 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 965
 966         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 967
 968 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 969
 970         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 971         * ctf-types.c (ctf_type_lname): Likewise.
 972
 973 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 974
 975         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 976         ctf_import after the first for a given file.
 977
 978 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 979
 980         * ctf-impl.h (ctf_str_append_noerr): Declare.
 981         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 982         ctf_str_append.
 983         * ctf-dump.c (str_append): New, call it.
 984         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 985         (ctf_dump_label): Likewise.
 986         (ctf_dump_objts): Likewise.
 987         (ctf_dump_funcs): Likewise.
 988         (ctf_dump_var): Likewise.
 989         (ctf_dump_member): Likewise.
 990         (ctf_dump_type): Likewise.
 991         (ctf_dump): Likewise.
 992
 993 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 994
 995         * ctf-impl.h (ctf_alloc): Remove.
 996         (ctf_free): Likewise.
 997         (ctf_strdup): Likewise.
 998         * ctf-subr.c (ctf_alloc): Remove.
 999         (ctf_free): Likewise.
1000         * ctf-util.c (ctf_strdup): Remove.
1001
1002         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
1003         ctf_free; strdup, not ctf_strdup.
1004         (ctf_dtd_delete): Likewise.
1005         (ctf_dvd_delete): Likewise.
1006         (ctf_add_generic): Likewise.
1007         (ctf_add_function): Likewise.
1008         (ctf_add_enumerator): Likewise.
1009         (ctf_add_member_offset): Likewise.
1010         (ctf_add_variable): Likewise.
1011         (membadd): Likewise.
1012         (ctf_compress_write): Likewise.
1013         (ctf_write_mem): Likewise.
1014         * ctf-decl.c (ctf_decl_push): Likewise.
1015         (ctf_decl_fini): Likewise.
1016         (ctf_decl_sprintf): Likewise.  Check for OOM.
1017         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
1018         ctf_free; strdup, not ctf_strdup.
1019         (ctf_dump_free): Likewise.
1020         (ctf_dump): Likewise.
1021         * ctf-open.c (upgrade_types_v1): Likewise.
1022         (init_types): Likewise.
1023         (ctf_file_close): Likewise.
1024         (ctf_bufopen_internal): Likewise.  Check for OOM.
1025         (ctf_parent_name_set): Likewise: report the OOM to the caller.
1026         (ctf_cuname_set): Likewise.
1027         (ctf_import): Likewise.
1028         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
1029         free, not ctf_free; strdup, not ctf_strdup.
1030         (ctf_str_free_atom): Likewise.
1031         (ctf_str_create_atoms): Likewise.
1032         (ctf_str_add_ref_internal): Likewise.
1033         (ctf_str_remove_ref): Likewise.
1034         (ctf_str_write_strtab): Likewise.
1035
1036 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
1037
1038         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
1039         work right for non-int/fps.
1040
1041 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
1042
1043         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
1044         null pointer.
1045
1046 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
1047
1048         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
1049         * ctf-open.c (ctf_file_close): Free it.
1050         * ctf-create.c (ctf_serialize): Adjust.
1051         (membcmp): When reporting a conflict due to an error, report the
1052         error.
1053         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
1054         (ctf_add_type_internal): ... this.  Hand back types we are already
1055         in the middle of adding immediately.  Hand back structs/unions with
1056         the same number of members immediately.  Do not walk the dynamic
1057         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
1058         forwards promoted to other types and the inverse case identically.
1059         Add structs to the mapping as soon as we intern them, before they
1060         gain any members.
1061
1062 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
1063
1064         * ctf-impl.h (ctf_names_t): New.
1065         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
1066         (ctf_file_t) <ctf_structs>: Likewise.
1067         <ctf_unions>: Likewise.
1068         <ctf_enums>: Likewise.
1069         <ctf_names>: Likewise.
1070         <ctf_lookups>: Improve comment.
1071         <ctf_ptrtab_len>: New.
1072         <ctf_prov_strtab>: New.
1073         <ctf_str_prov_offset>: New.
1074         <ctf_dtbyname>: Remove, redundant to the names hashes.
1075         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
1076         (ctf_dtdef_t) <dtd_name>: Remove.
1077         <dtd_data>: Note that the ctt_name is now populated.
1078         (ctf_str_atom_t) <csa_offset>: This is now the strtab
1079         offset for internal strings too.
1080         <csa_external_offset>: New, the external strtab offset.
1081         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
1082         (ctf_name_table): New declaration.
1083         (ctf_lookup_by_rawname): Likewise.
1084         (ctf_lookup_by_rawhash): Likewise.
1085         (ctf_set_ctl_hashes): Likewise.
1086         (ctf_serialize): Likewise.
1087         (ctf_dtd_insert): Adjust.
1088         (ctf_simple_open_internal): Likewise.
1089         (ctf_bufopen_internal): Likewise.
1090         (ctf_list_empty_p): Likewise.
1091         (ctf_str_remove_ref): Likewise.
1092         (ctf_str_add): Returns uint32_t now.
1093         (ctf_str_add_ref): Likewise.
1094         (ctf_str_add_external): Now returns a boolean (int).
1095         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
1096         for strings in the appropriate range.
1097         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
1098         when adding the null string to the new strtab.
1099         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
1100         (ctf_str_add_ref_internal): Add make_provisional argument.  If
1101         make_provisional, populate the offset and fill in the
1102         ctf_prov_strtab accordingly.
1103         (ctf_str_add): Return the offset, not the string.
1104         (ctf_str_add_ref): Likewise.
1105         (ctf_str_add_external): Return a success integer.
1106         (ctf_str_remove_ref): New, remove a single ref.
1107         (ctf_str_count_strtab): Do not count the initial null string's
1108         length or the existence or length of any unreferenced internal
1109         atoms.
1110         (ctf_str_populate_sorttab): Skip atoms with no refs.
1111         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
1112         to the cts_len for the null string, since it is no longer done
1113         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
1114         Populate the csa_offset for both internal and external cases.
1115         Flush the ctf_prov_strtab afterwards, and reset the
1116         ctf_str_prov_offset.
1117         * ctf-create.c (ctf_grow_ptrtab): New.
1118         (ctf_create): Call it.  Initialize new fields rather than old
1119         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
1120         Set the ctl hashes and data model.
1121         (ctf_update): Rename to...
1122         (ctf_serialize): ... this.  Leave a compatibility function behind.
1123         Tell ctf_simple_open_internal that this is a writable dictionary.
1124         Pass the new fields along from the old dictionary.  Drop
1125         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
1126         Do not zero out the DTD's ctt_name.
1127         (ctf_prefixed_name): Rename to...
1128         (ctf_name_table): ... this.  No longer return a prefixed name: return
1129         the applicable name table instead.
1130         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
1131         kind we're adding.  Migrate away from dtd_name.
1132         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
1133         deleted ctt_name.
1134         (ctf_dtd_lookup_type_by_name): Remove.
1135         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
1136         No longer check ctf_dtnextid: check ctf_typemax instead.
1137         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
1138         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
1139         ctf_name_table and the right name table, and migrate away from
1140         dtd_name as in ctf_dtd_delete.
1141         (ctf_add_generic): Pass in the kind explicitly and pass it to
1142         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
1143         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
1144         Grow the ptrtab if needed.
1145         (ctf_add_encoded): Pass in the kind.
1146         (ctf_add_slice): Likewise.
1147         (ctf_add_array): Likewise.
1148         (ctf_add_function): Likewise.
1149         (ctf_add_typedef): Likewise.
1150         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1151         ctt_name rather than dtd_name.
1152         (ctf_add_struct_sized): Pass in the kind.  Use
1153         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1154         ctf_dtd_lookup_type_by_name.
1155         (ctf_add_union_sized): Likewise.
1156         (ctf_add_enum): Likewise.
1157         (ctf_add_enum_encoded): Likewise.
1158         (ctf_add_forward): Likewise.
1159         (ctf_add_type): Likewise.
1160         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1161         being initialized until after the call.
1162         (ctf_write_mem): Likewise.
1163         (ctf_write): Likewise.
1164         * ctf-archive.c (arc_write_one_ctf): Likewise.
1165         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1166         ctf_hash_lookup_type.
1167         (ctf_lookup_by_id): No longer check the readonly types if the
1168         dictionary is writable.
1169         * ctf-open.c (init_types): Assert that this dictionary is not
1170         writable.  Adjust to use the new name hashes, ctf_name_table,
1171         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
1172         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
1173         if set.  Drop out early when dictionary is writable.  Split the
1174         ctf_lookups initialization into...
1175         (ctf_set_cth_hashes): ... this new function.
1176         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
1177         (ctf_simple_open): Adjust accordingly.
1178         (ctf_bufopen): Likewise.
1179         (ctf_file_close): Destroy the appropriate name hashes.  No longer
1180         destroy ctf_dtbyname, which is gone.
1181         (ctf_getdatasect): Remove spurious "extern".
1182         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1183         specified name table, given a kind.
1184         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1185         (ctf_member_iter): Add support for iterating over the
1186         dynamic type list.
1187         (ctf_enum_iter): Likewise.
1188         (ctf_variable_iter): Likewise.
1189         (ctf_type_rvisit): Likewise.
1190         (ctf_member_info): Add support for types in the dynamic type list.
1191         (ctf_enum_name): Likewise.
1192         (ctf_enum_value): Likewise.
1193         (ctf_func_type_info): Likewise.
1194         (ctf_func_type_args): Likewise.
1195         * ctf-link.c (ctf_accumulate_archive_names): No longer call
1196         ctf_update.
1197         (ctf_link_write): Likewise.
1198         (ctf_link_intern_extern_string): Adjust for new
1199         ctf_str_add_external return value.
1200         (ctf_link_add_strtab): Likewise.
1201         * ctf-util.c (ctf_list_empty_p): New.
1202
1203 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
1204
1205         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1206         type zero.
1207         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1208         members and types.
1209         (ctf_add_variable): Likewise for variables pointing to them.
1210         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1211         type link failure, but do warn for others.
1212         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
1213         errors to be ENOMEM.
1214         (ctf_dump_member): Likewise.
1215         (ctf_dump_type): Likewise.
1216         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1217         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1218         (ctf_dump_header): Likewise.
1219         (ctf_dump_label): likewise.
1220         (ctf_dump_objts): likewise.
1221         (ctf_dump_funcs): likewise.
1222         (ctf_dump_var): likewise.
1223         (ctf_dump_str): Likewise.
1224
1225 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
1226
1227         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1228         (LT_INIT): Likewise.
1229         (AM_INSTALL_LIBBFD): Likewise.
1230         (dlopen): Note why this is necessary in a comment.
1231         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1232         opcodes/.
1233         (SHARED_LDFLAGS): Likewise.
1234         (BFD_LIBADD): Likewise, for libbfd.
1235         (BFD_DEPENDENCIES): Likewise.
1236         (VERSION_FLAGS): Initialize, using a version script if ld supports
1237         one, or libtool -export-symbols-regex otherwise.
1238         (AC_CONFIG_MACRO_DIR): Add ../BFD.
1239         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1240         (INCDIR): New.
1241         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1242         (noinst_LIBRARIES): Replace with...
1243         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1244         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1245         libctf-nobfd.la as well.
1246         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1247         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1248         (libctf_a_SOURCES): Rename to...
1249         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1250         ctf-open-bfd.c.
1251         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1252         with ctf-open-bfd.c added.
1253         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1254         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1255         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1256         * Makefile.am [INSTALL_LIBCTF]: Use it.
1257         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1258         libtool macros.
1259         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1260         the unstable components).
1261         * Makefile.in: Regenerated.
1262         * config.h.in: Likewise.
1263         * configure: Likewise.
1264
1265 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1266
1267         * configure.ac (INSTALL_LIBCTF): New, controlled by
1268         --enable-install-libctf.
1269         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1270         * Makefile.in: Regenerated.
1271         * configure: Regenerated.
1272
1273 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1274
1275         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1276         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1277
1278 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1279
1280         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1281
1282 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1283
1284         * ctf-impl.h (includes): Include <sys/param.h> here.
1285
1286 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1287
1288         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1289         (flip_objts): Likewise.
1290         (flip_vars): Likewise.
1291         (flip_types): Likewise.
1292
1293 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1294
1295         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1296         freeing functions: if set, free the key and value if the slot
1297         already exists.  Always reassign the key.
1298         (ctf_dynhash_insert): Adjust call appropriately.
1299         (ctf_hash_insert_type): Likewise.
1300
1301 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
1302
1303         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1304         type kind.  Allow forwards to unify with pre-existing structs/
1305         unions/enums.
1306
1307 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1308
1309         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1310         <ctf_link_memb_name_changer>: Likewise.
1311         <ctf_link_memb_name_changer_arg>: Likewise.
1312         * ctf-create.c (ctf_update): Update accordingly.
1313         * ctf-open.c (ctf_file_close): Likewise.
1314         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1315         (ctf_link_add_cu_mapping): New.
1316         (ctf_link_set_memb_name_changer): Likewise.
1317         (ctf_change_parent_name): New.
1318         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1319         allocated by the caller's ctf_link_memb_name_changer.
1320         <ndynames>: Likewise.
1321         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1322         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1323         ctf_change_parent_name.  Free any resulting names.
1324
1325 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1326
1327         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1328         (ctf_link_one_type): ... here, with parent-name setting added.
1329         (check_variable): New.
1330         (ctf_link_one_variable): Likewise.
1331         (ctf_link_one_input_archive_member): Call it.
1332         * ctf-error.c (_ctf_errlist): Updated with new errors.
1333
1334 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1335
1336         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1337         (struct ctf_link_type_mapping_key): New.
1338         (ctf_hash_type_mapping_key): Likewise.
1339         (ctf_hash_eq_type_mapping_key): Likewise.
1340         (ctf_add_type_mapping): Likewise.
1341         (ctf_type_mapping): Likewise.
1342         (ctf_dynhash_empty): Likewise.
1343         * ctf-open.c (ctf_file_close): Update accordingly.
1344         * ctf-create.c (ctf_update): Likewise.
1345         (ctf_add_type): Populate the mapping.
1346         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1347         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1348         (ctf_dynhash_insert): Fix comment typo.
1349         (ctf_dynhash_empty): New.
1350         * ctf-link.c (ctf_add_type_mapping): New.
1351         (ctf_type_mapping): Likewise.
1352         (empty_link_type_mapping): New.
1353         (ctf_link_one_input_archive): Call it.
1354
1355 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1356
1357         * ctf-link.c: New file, linking of the string and type sections.
1358         * Makefile.am (libctf_a_SOURCES): Add it.
1359         * Makefile.in: Regenerate.
1360
1361         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1362         ctf_link_outputs.
1363         * ctf-create.c (ctf_update): Update accordingly.
1364         * ctf-open.c (ctf_file_close): Likewise.
1365         * ctf-error.c (_ctf_errlist): Updated with new errors.
1366
1367 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1368
1369         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1370
1371 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1372
1373         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1374         ctf_type_iter.
1375         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1376         (ctf_dump_format_type): Add non-root-type { } notation.
1377         Add root flag to prototype.
1378         (ctf_dump_label): Adjust accordingly.
1379         (ctf_dump_objts): Likewise.
1380         (ctf_dump_var): Likewise.
1381
1382 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1383
1384         * ctf-create.c (ctf_compress_write): Fix double-free.
1385
1386 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1387
1388         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1389         of...
1390         (ctf_arc_write_fd): ... this new function.
1391         * ctf-create.c (ctf_write_mem): New.
1392
1393 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1394
1395         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1396         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1397         (ctf_str_add_ref): Name the last arg.
1398         (ctf_str_add_external) New.
1399         (ctf_str_add_strraw_explicit): Likewise.
1400         (ctf_simple_open_internal): Likewise.
1401         (ctf_bufopen_internal): Likewise.
1402
1403         * ctf-string.c (ctf_strraw_explicit): Split from...
1404         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1405         (ctf_str_add_ref_internal): Return the atom, not the
1406         string.
1407         (ctf_str_add): Adjust accordingly.
1408         (ctf_str_add_ref): Likewise.  Move up in the file.
1409         (ctf_str_add_external): New: update the csa_offset.
1410         (ctf_str_count_strtab): Only account for strings with no csa_offset
1411         in the internal strtab length.
1412         (ctf_str_write_strtab): If the csa_offset is set, update the
1413         string's refs without writing the string out, and update the
1414         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1415         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1416         (ctf_update): Handle failure to populate the strtab.  Pass in the
1417         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1418         Call ctf_simple_open_internal, not ctf_simple_open.
1419         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1420         strings by hand.
1421         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1422         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1423         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1424         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1425         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1426         (ctf_simple_open_internal): ... this new function, which calls
1427         ctf_bufopen_internal.
1428         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1429         (ctf_bufopen_internal): ... this new function, which sets
1430         ctf_syn_ext_strtab.
1431
1432 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1433
1434         * ctf_types.c (ctf_type_iter_all): New.
1435
1436 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1437
1438         * ctf-open.c (init_symtab): Check for overflow against the right
1439         section.
1440         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1441         (upgrade_types_v1): Note that these sections are not checked.
1442         (flip_header): Endian-swap the header fields.
1443         (flip_ctf): Endian-swap the sections.
1444         (flip_objts): Update comment.
1445         (ctf_bufopen): Check header offsets and alignment for validity.
1446
1447 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1448
1449         * ctf-open-bfd.c: Add <assert.h>.
1450         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1451         techniques borrowed from bfd_elf_sym_name.
1452         (ctf_new_archive_internal): Improve comment.
1453         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1454         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1455         no symbol section, but not vice versa.
1456
1457 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1458
1459         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1460         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1461         * ctf-dump.c (dump_header): New function, dump the CTF header.
1462         (ctf_dump): Call it.
1463         (ctf_dump_header_strfield): New function.
1464         (ctf_dump_header_sectfield): Likewise.
1465
1466 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1467
1468         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1469         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1470         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1471         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1472         Print out ctf_cuname: only print out ctf_parname if set.
1473         (ctf_free_base): Removed, ctf_base is no longer freed: free
1474         ctf_dynbase instead.
1475         (ctf_set_version): Fix spacing.
1476         (upgrade_header): New, in-place header upgrading.
1477         (upgrade_types): Rename to...
1478         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1479         longer track old and new headers separately.  No longer allow for
1480         header sizes explicitly: squeeze the headers out on upgrade (they
1481         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1482         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1483         (upgrade_types): New, also handle ctf_parmax updating.
1484         (flip_header): Flip ctf_cuname.
1485         (flip_types): Flip BUF explicitly rather than deriving BUF from
1486         BASE.
1487         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1488         required alignment of objtoff and funcoff.  No longer store it in
1489         the ctf_buf unless that buf is derived unmodified from the input.
1490         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1491         that duplicate fields in ctf_file: move allocation of ctf_file
1492         further up instead.  Call upgrade_header as needed.  Move
1493         version-specific ctf_parmax initialization into upgrade_types.  More
1494         concise error handling.
1495         (ctf_file_close): No longer test for null pointers before freeing.
1496         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1497         ctf_free_base.
1498         (ctf_cuname): New.
1499         (ctf_cuname_set): New.
1500         * ctf-create.c (ctf_update): Populate ctf_cuname.
1501         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1502         comment.
1503         (ctf_write): Likewise.
1504         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1505         Fix the compression length: fp->ctf_size never counted the CTF
1506         header.  Simplify the compress call accordingly.
1507
1508 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1509
1510         * ctf-endian.h: Don't assume htole64 and le64toh are always
1511         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1512         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1513         not bswap_identity_64.
1514
1515 2019-09-18  Alan Modra  <amodra@gmail.com>
1516
1517         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1518
1519 2019-09-09  Phil Blundell  <pb@pbcl.net>
1520
1521         binutils 2.33 branch created.
1522
1523 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1524
1525         * ctf-types.c (ctf_type_aname_raw): New.
1526         (ctf_func_type_info): Likewise.
1527         (ctf_func_type_args): Likewise.
1528         * ctf-error.c (_ctf_errlist): Fix description.
1529         * ctf-lookup.c: Fix file description.
1530
1531 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1532
1533         * ctf-create.c (ctf_create): Fix off-by-one error.
1534
1535 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1536
1537         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1538         struct ctf_strs.
1539         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1540         (struct ctf_str_atom): New, disambiguated single string.
1541         (struct ctf_str_atom_ref): New, points to some other location that
1542         references this string's offset.
1543         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1544         Remove member ctf_dtvstrlen: we no longer track the total strlen
1545         as we add strings.
1546         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1547         (ctf_str_free_atoms): Likewise.
1548         (ctf_str_add): Likewise.
1549         (ctf_str_add_ref): Likewise.
1550         (ctf_str_rollback): Likewise.
1551         (ctf_str_purge_refs): Likewise.
1552         (ctf_str_write_strtab): Likewise.
1553         (ctf_realloc): Declare new function in ctf-util.c.
1554
1555         * ctf-open.c (ctf_bufopen): Create the atoms table.
1556         (ctf_file_close): Destroy it.
1557         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1558         special-case the position of the parname string.  Construct the
1559         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1560         rest of each buffer element is constructed, not via open-coding:
1561         realloc the CTF buffer and append the strtab to it.  No longer
1562         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1563         strtab construction.
1564         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1565         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1566         after buffer element construction instead.
1567         (ctf_copy_lmembers): Likewise.
1568         (ctf_copy_emembers): Likewise.
1569         (ctf_create): No longer maintain the ctf_dtvstrlen.
1570         (ctf_dtd_delete): Likewise.
1571         (ctf_dvd_delete): Likewise.
1572         (ctf_add_generic): Likewise.
1573         (ctf_add_enumerator): Likewise.
1574         (ctf_add_member_offset): Likewise.
1575         (ctf_add_variable): Likewise.
1576         (membadd): Likewise.
1577         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1578         if there are active ctf_str_num_refs.
1579         (ctf_strraw): Move to ctf-string.c.
1580         (ctf_strptr): Likewise.
1581         * ctf-string.c: New file, strtab manipulation.
1582
1583         * Makefile.am (libctf_a_SOURCES): Add it.
1584         * Makefile.in: Regenerate.
1585
1586 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1587
1588         * ctf-impl.h (ctf_hash_iter_f): New.
1589         (ctf_dynhash_iter): New declaration.
1590         (ctf_dynhash_iter_remove): New declaration.
1591         * ctf-hash.c (ctf_dynhash_iter): Define.
1592         (ctf_dynhash_iter_remove): Likewise.
1593         (ctf_hashtab_traverse): New.
1594         (ctf_hashtab_traverse_remove): Likewise.
1595         (struct ctf_traverse_cb_arg): Likewise.
1596         (struct ctf_traverse_remove_cb_arg): Likewise.
1597
1598 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1599
1600         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1601
1602 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1603
1604         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1605         (ctf_dump_funcs): Likewise.
1606
1607 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1608
1609         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1610         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1611         little-endian CTF archive magic.  Do not check the CTF version:
1612         ctf_simple_open does that in endian-safe ways.  Do not dereference
1613         null pointers on open failure.
1614
1615 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1616
1617         * ctf-open.c (get_vbytes_common): Return the new slice size.
1618         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1619         Remember to copy in the CTF data when opening an uncompressed
1620         foreign-endian CTF file.  Prune useless variable manipulation.
1621
1622 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1623
1624         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1625         seen.
1626
1627 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1628
1629         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1630         output.
1631
1632 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1633
1634         * ctf-subr.c (_PAGESIZE): Remove.
1635         (ctf_data_alloc): Likewise.
1636         (ctf_data_free): Likewise.
1637         (ctf_data_protect): Likewise.
1638         * ctf-impl.h: Remove declarations.
1639         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1640         ctf_free, not ctf_data_free.
1641         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1642         the buffer again on compression error.
1643         * ctf-open.c (ctf_set_base): No longer track the size: call
1644         ctf_free, not ctf_data_free.
1645         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1646         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1647
1648 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1649
1650         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1651         ctf_dynhash_insert.
1652         (ctf_dvd_insert): Likewise.
1653         (ctf_add_generic): Likewise.
1654         (ctf_add_variable): Likewise.
1655         * ctf-impl.h: Adjust declarations.
1656
1657 2019-06-14  Alan Modra  <amodra@gmail.com>
1658
1659         * configure: Regenerate.
1660
1661 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1662
1663         * ctf-decls.h: Include <libiberty.h>.
1664         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1665
1666 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1667
1668         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1669         (ctf_dump_objts): Likewise.
1670         (ctf_dump_funcs): Likewise.
1671         (ctf_dump_member): Likewise.
1672         (ctf_dump_str): Likewise.
1673
1674 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1675
1676         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1677         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1678
1679 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1680
1681         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1682         (ctf_arc_open_by_offset): Likewise.
1683         * ctf-create.c (ctf_add_type): Likewise.
1684
1685 2019-06-04  Tom Tromey  <tromey@adacore.com>
1686
1687         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1688         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1689
1690 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1691
1692         * configure.ac: Check for O_CLOEXEC.
1693         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1694         * config.h.in: Regenerate.
1695         * configure: Likewise.
1696
1697 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1698
1699         * qsort_r.c: Rename to...
1700         * ctf-qsort_r.c: ... this.
1701         (_quicksort): Define to ctf_qsort_r.
1702         * ctf-decls.h (qsort_r): Remove.
1703         (ctf_qsort_r): Add.
1704         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1705         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1706         * Makefile.am (libctf_a_LIBADD): Remove.
1707         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1708         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1709         * ctf-create.c (ctf_update): Likewise.
1710         * configure.ac: Check for BSD versus GNU qsort_r signature.
1711         * Makefile.in: Regenerate.
1712         * config.h.in: Likewise.
1713         * configure: Likewise.
1714
1715 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1716
1717         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1718
1719 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1720
1721         * Makefile.am (ZLIB): New.
1722         (ZLIBINC): Likewise.
1723         (AM_CFLAGS): Use them.
1724         (libctf_a_LIBADD): New, for LIBOBJS.
1725         * configure.ac: Check for zlib, endian.h, and qsort_r.
1726         * ctf-endian.h: New, providing htole64 and le64toh.
1727         * swap.h: Code style fixes.
1728         (bswap_identity_64): New.
1729         * qsort_r.c: New, from gnulib (with one added #include).
1730         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1731         and unconditional definitions of MIN and MAX.
1732         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1733         (ctf_set_errno): Now returns unsigned long.
1734         * ctf-util.c (ctf_set_errno): Adjust here too.
1735         * ctf-archive.c: Use ctf-endian.h.
1736         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1737         cts_flags and cts_offset.
1738         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1739         * ctf-create.c: Provide a definition of roundup if not defined.
1740         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1741         (ctf_add_reftype): Do not check if type IDs are below zero.
1742         (ctf_add_slice): Likewise.
1743         (ctf_add_typedef): Likewise.
1744         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1745         when known error-free.  Drop CTF_ERR usage for functions returning
1746         int.
1747         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1748         int.
1749         (ctf_add_variable): Likewise.
1750         (enumcmp): Likewise.
1751         (enumadd): Likewise.
1752         (membcmp): Likewise.
1753         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1754         when known error-free.
1755         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1756         returning int: use CTF_ERR for functions returning ctf_type_id.
1757         (ctf_dump_label): Likewise.
1758         (ctf_dump_objts): Likewise.
1759         * ctf-labels.c (ctf_label_topmost): Likewise.
1760         (ctf_label_iter): Likewise.
1761         (ctf_label_info): Likewise.
1762         * ctf-lookup.c (ctf_func_args): Likewise.
1763         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1764         (ctf_bufopen): Likewise.  Use zlib types as needed.
1765         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1766         returning int.
1767         (ctf_enum_iter): Likewise.
1768         (ctf_type_size): Likewise.
1769         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1770         (ctf_type_kind_unsliced): Likewise.
1771         (ctf_type_kind): Likewise.
1772         (ctf_type_encoding): Likewise.
1773         (ctf_member_info): Likewise.
1774         (ctf_array_info): Likewise.
1775         (ctf_enum_value): Likewise.
1776         (ctf_type_rvisit): Likewise.
1777         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1778         cts_offset.
1779         (ctf_simple_open): Likewise.
1780         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1781         * Makefile.in: Regenerate.
1782         * aclocal.m4: Likewise.
1783         * config.h: Likewise.
1784         * configure: Likewise.
1785
1786 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1787
1788         * configure.in: Check for bfd_section_from_elf_index.
1789         * configure: Regenerate.
1790         * config.h.in [HAVE_BFD_ELF]: Likewise.
1791         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1792         abfd is potentially unused now.
1793
1794 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1795
1796         * Makefile.am: New.
1797         * Makefile.in: Regenerated.
1798         * config.h.in: Likewise.
1799         * aclocal.m4: Likewise.
1800         * configure: Likewise.
1801
1802 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1803
1804         * ctf-dump.c: New.
1805
1806 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1807
1808         * ctf-labels.c: New.
1809
1810 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1811
1812         * ctf-impl.h (_libctf_version): New declaration.
1813         * ctf-subr.c (_libctf_version): Define it.
1814         (ctf_version): New.
1815
1816 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1817
1818         * ctf-create.c (enumcmp): New.
1819         (enumadd): Likewise.
1820         (membcmp): Likewise.
1821         (membadd): Likewise.
1822         (ctf_add_type): Likewise.
1823
1824 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1825
1826         * ctf-lookup.c (isqualifier): New.
1827         (ctf_lookup_by_name): Likewise.
1828         (struct ctf_lookup_var_key): Likewise.
1829         (ctf_lookup_var): Likewise.
1830         (ctf_lookup_variable): Likewise.
1831         (ctf_lookup_symbol_name): Likewise.
1832         (ctf_lookup_by_symbol): Likewise.
1833         (ctf_func_info): Likewise.
1834         (ctf_func_args): Likewise.
1835
1836 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1837
1838         * ctf-decl.c: New file.
1839         * ctf-types.c: Likewise.
1840         * ctf-impl.h: New declarations.
1841
1842 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1843
1844         * ctf-open-bfd.c: New file.
1845         * ctf-open.c (ctf_close): New.
1846         * ctf-impl.h: Include bfd.h.
1847         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1848         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1849         ctfi_bfd_close.
1850         (ctf_bfdopen_ctfsect): New declaration.
1851         (_CTF_SECTION): likewise.
1852
1853 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1854
1855         * ctf-archive.c: New.
1856         * ctf-impl.h (ctf_archive_internal): New type.
1857         (ctf_arc_open_internal): New declaration.
1858         (ctf_arc_bufopen): Likewise.
1859         (ctf_arc_close_internal): Likewise.
1860
1861 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1862
1863         * ctf-open.c: New file.
1864         * swap.h: Likewise.
1865
1866 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1867
1868         * ctf-create.c: New file.
1869         * ctf-lookup.c: New file.
1870
1871 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1872
1873         * ctf-impl.h: New definitions and declarations for type creation
1874         and lookup.
1875
1876 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1877
1878         * ctf-hash.c: New file.
1879         * ctf-impl.h: New declarations.
1880
1881 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1882
1883         * ctf-error.c: New file.
1884
1885 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1886
1887         * ctf-util.c: New file.
1888         * elf.h: Likewise.
1889         * ctf-impl.h: Include it, and add declarations.
1890
1891 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1892
1893         * ctf-impl.h: New file.
1894         * ctf-subr.c: New file.
1895
1896 \f
1897 Local Variables:
1898 mode: change-log
1899 left-margin: 8
1900 fill-column: 76
1901 version-control: never
1902 End: