1 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-dedup.c (ctf_dedup_rhash_type): Null out the names of nameless
4 type kinds, just in case the input has named them.
6 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
8 * ctf-dump.c (ctf_dump_header): Dump the new flags bits and the index
10 (ctf_dump_objts): Report indexed sections. Also dump functions. Use
11 ctf_symbol_next, not manual looping.
12 (ctf_dump_funcs): Delete.
13 (ctf_dump): Use ctf_dump_objts, not ctf_dump_funcs.
15 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
17 * ctf-impl.h (CTF_INDEX_PAD_THRESHOLD): New.
18 (_libctf_nonnull_): Likewise.
19 (ctf_in_flight_dynsym_t): New.
20 (ctf_dict_t) <ctf_funcidx_names>: Likewise.
21 <ctf_objtidx_names>: Likewise.
22 <ctf_nfuncidx>: Likewise.
23 <ctf_nobjtidx>: Likewise.
24 <ctf_funcidx_sxlate>: Likewise.
25 <ctf_objtidx_sxlate>: Likewise.
26 <ctf_objthash>: Likewise.
27 <ctf_funchash>: Likewise.
28 <ctf_dynsyms>: Likewise.
29 <ctf_dynsymidx>: Likewise.
30 <ctf_dynsymmax>: Likewise.
31 <ctf_in_flight_dynsym>: Likewise.
32 (struct ctf_next) <u.ctn_next>: Likewise.
33 (ctf_symtab_skippable): New prototype.
34 (ctf_add_funcobjt_sym): Likewise.
35 (ctf_dynhash_sort_by_name): Likewise.
36 (ctf_sym_to_elf64): Rename to...
37 (ctf_elf32_to_link_sym): ... this, and...
38 (ctf_elf64_to_link_sym): ... this.
39 * ctf-open.c (init_symtab): Check for lack of CTF_F_NEWFUNCINFO
40 flag, and presence of index sections. Refactor out
41 ctf_symtab_skippable and ctf_elf*_to_link_sym, and use them. Use
42 ctf_link_sym_t, not Elf64_Sym. Skip initializing objt or func
43 sxlate sections if corresponding index section is present. Adjust
44 for new func info section format.
45 (ctf_bufopen_internal): Add ctf_err_warn to corrupt-file error
46 handling. Report incorrect-length index sections. Always do an
47 init_symtab, even if there is no symtab section (there may be index
49 (flip_objts): Adjust comment: func and objt sections are actually
50 identical in structure now, no need to caveat.
51 (ctf_dict_close): Free newly-added data structures.
52 * ctf-create.c (ctf_create): Initialize them.
53 (ctf_symtab_skippable): New, refactored out of
54 init_symtab, with st_nameidx_set check added.
55 (ctf_add_funcobjt_sym): New, add a function or object symbol to the
56 ctf_objthash or ctf_funchash, by name.
57 (ctf_add_objt_sym): Call it.
58 (ctf_add_func_sym): Likewise.
59 (symtypetab_delete_nonstatic_vars): New, delete vars also present as
61 (CTF_SYMTYPETAB_EMIT_FUNCTION): New flag to symtypetab emitters:
62 this is a function emission, not a data object emission.
63 (CTF_SYMTYPETAB_EMIT_PAD): New flag to symtypetab emitters: emit
64 pads for symbols with no type (only set for unindexed sections).
65 (CTF_SYMTYPETAB_FORCE_INDEXED): New flag to symtypetab emitters:
67 (symtypetab_density): New, figure out section sizes.
68 (emit_symtypetab): New, emit a symtypetab.
69 (emit_symtypetab_index): New, emit a symtypetab index.
70 (ctf_serialize): Call them, emitting suitably sorted symtypetab
71 sections and indexes. Set suitable header flags. Copy over new
73 * ctf-hash.c (ctf_dynhash_sort_by_name): New, used to impose an
74 order on symtypetab index sections.
75 * ctf-link.c (ctf_add_type_mapping): Delete erroneous comment
76 relating to code that was never committed.
77 (ctf_link_one_variable): Improve variable name.
78 (check_sym): New, symtypetab analogue of check_variable.
79 (ctf_link_deduplicating_one_symtypetab): New.
80 (ctf_link_deduplicating_syms): Likewise.
81 (ctf_link_deduplicating): Call them.
82 (ctf_link_deduplicating_per_cu): Note that we don't call them in
84 (ctf_link_add_strtab): Set the error on the fp correctly.
85 (ctf_link_add_linker_symbol): New (no longer a do-nothing stub), add
86 a linker symbol to the in-flight list.
87 (ctf_link_shuffle_syms): New (no longer a do-nothing stub), turn the
88 in-flight list into a mapping we can use, now its names are
89 resolvable in the external strtab.
90 * ctf-string.c (ctf_str_rollback_atom): Don't roll back atoms with
91 external strtab offsets.
92 (ctf_str_rollback): Adjust comment.
93 (ctf_str_write_strtab): Migrate ctf_syn_ext_strtab population from
95 (ctf_str_add_external): ... to string addition time.
96 * ctf-lookup.c (ctf_lookup_var_key_t): Rename to...
97 (ctf_lookup_idx_key_t): ... this, now we use it for syms too.
98 <clik_names>: New member, a name table.
99 (ctf_lookup_var): Adjust accordingly.
100 (ctf_lookup_variable): Likewise.
101 (ctf_lookup_by_id): Shuffle further up in the file.
102 (ctf_symidx_sort_arg_cb): New, callback for...
103 (sort_symidx_by_name): ... this new function to sort a symidx
104 found to be unsorted (likely originating from the compiler).
105 (ctf_symidx_sort): New, sort a symidx.
106 (ctf_lookup_symbol_name): Support dynamic symbols with indexes
107 provided by the linker. Use ctf_link_sym_t, not Elf64_Sym.
108 Check the parent if a child lookup fails.
109 (ctf_lookup_by_symbol): Likewise. Work for function symbols too.
110 (ctf_symbol_next): New, iterate over symbols with types (without
112 (ctf_lookup_idx_name): New, bsearch for symbol names in indexes.
113 (ctf_try_lookup_indexed): New, attempt an indexed lookup.
114 (ctf_func_info): Reimplement in terms of ctf_lookup_by_symbol.
115 (ctf_func_args): Likewise.
116 (ctf_get_dict): Move...
117 * ctf-types.c (ctf_get_dict): ... here.
118 * ctf-util.c (ctf_sym_to_elf64): Re-express as...
119 (ctf_elf64_to_link_sym): ... this. Add new st_symidx field, and
120 st_nameidx_set (always 0, so st_nameidx can be ignored). Look in
121 the ELF strtab for names.
122 (ctf_elf32_to_link_sym): Likewise, for Elf32_Sym.
123 (ctf_next_destroy): Destroy ctf_next_t.u.ctn_next if need be.
124 * libctf.ver: Add ctf_symbol_next, ctf_add_objt_sym and
127 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
129 * ctf-link.c (ctf_link_shuffle_syms): Adjust.
130 (ctf_link_add_linker_symbol): New, unimplemented stub.
131 * libctf.ver: Add it.
132 * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
134 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
135 symtab/strtab if not present, dynsym/dynstr otherwise.
136 * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
137 some arbitrary member of a CTF archive.
138 * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
140 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
142 * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
143 (ctf_dict_open_by_offset): ... this. Adjust callers.
144 (ctf_arc_open_by_name_internal): Rename to...
145 (ctf_dict_open_internal): ... this. Adjust callers.
146 (ctf_arc_open_by_name_sections): Rename to...
147 (ctf_dict_open_sections): ... this, keeping compatibility function.
148 (ctf_arc_open_by_name): Rename to...
149 (ctf_dict_open): ... this, keeping compatibility function.
150 * libctf.ver: New functions added.
151 * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
152 (ctf_link_deduplicating_open_inputs): Likewise.
154 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
156 * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
158 (ctf_fileops): Rename to...
159 (ctf_dictops): ... this.
160 (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
161 <cd_id_to_dict_t>: ... this.
162 (ctf_file_t): Fix outdated comment.
163 <ctf_fileops>: Rename to...
164 <ctf_dictops>: ... this.
165 (struct ctf_archive_internal) <ctfi_file>: Rename to...
166 <ctfi_dict>: ... this.
167 * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
168 Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
169 Rename ctf_file_close to ctf_dict_close. All users adjusted.
170 * ctf-create.c: Likewise. Refer to CTF dicts, not CTF containers.
171 (ctf_bundle_t) <ctb_file>: Rename to...
172 <ctb_dict): ... this.
173 * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
174 * ctf-dedup.c: Likewise. Rename ctf_file_close to
175 ctf_dict_close. Refer to CTF dicts, not CTF containers.
176 * ctf-dump.c: Likewise.
177 * ctf-error.c: Likewise.
178 * ctf-hash.c: Likewise.
179 * ctf-inlines.h: Likewise.
180 * ctf-labels.c: Likewise.
181 * ctf-link.c: Likewise.
182 * ctf-lookup.c: Likewise.
183 * ctf-open-bfd.c: Likewise.
184 * ctf-string.c: Likewise.
185 * ctf-subr.c: Likewise.
186 * ctf-types.c: Likewise.
187 * ctf-util.c: Likewise.
188 * ctf-open.c: Likewise.
189 (ctf_file_close): Rename to...
190 (ctf_dict_close): ...this.
191 (ctf_file_close): New trivial wrapper around ctf_dict_close, for
193 (ctf_parent_file): Rename to...
194 (ctf_parent_dict): ... this.
195 (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
197 * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
199 2020-10-21 Tom Tromey <tromey@adacore.com>
201 * mkerrors.sed: Remove.
202 * ctf-error.c (_CTF_FIRST): New define.
203 (_CTF_ITEM): Define this, not _CTF_STR.
204 (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
205 (ERRSTRFIELD): Rewrite.
206 (ERRSTRFIELD1): Remove.
207 * Makefile.in: Rebuild.
208 * Makefile.am (BUILT_SOURCES): Remove.
209 (ctf-error.h): Remove.
211 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
213 * ctf-subr.c (open_errors): New list.
214 (ctf_err_warn): Calls with NULL fp append to open_errors. Add err
215 parameter, and use it to decorate the debug stream with errmsgs.
216 (ctf_err_warn_to_open): Splice errors from a CTF dict into the
218 (ctf_errwarning_next): Calls with NULL fp report from open_errors.
219 New err param to report iteration errors (including end-of-iteration)
221 (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
222 parameter: gettextize.
223 * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
224 (LCTF_VBYTES): Adjust.
225 (ctf_err_warn_to_open): New.
226 (ctf_err_warn): Adjust.
227 (ctf_bundle): Used in only one place: move...
228 * ctf-create.c: ... here.
229 (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
230 down as needed. Don't emit the errmsg. Gettextize.
232 (ctf_add_type_internal): Likewise.
233 (ctf_write_mem): Likewise.
234 (ctf_compress_write): Likewise. Report errors writing the header or
236 (ctf_write): Likewise.
237 * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
238 ctf_dprintf, and gettextize, as above.
239 (ctf_arc_write): Likewise.
240 (ctf_arc_bufopen): Likewise.
241 (ctf_arc_open_internal): Likewise.
242 * ctf-labels.c (ctf_label_iter): Likewise.
243 * ctf-open-bfd.c (ctf_bfdclose): Likewise.
244 (ctf_bfdopen): Likewise.
245 (ctf_bfdopen_ctfsect): Likewise.
246 (ctf_fdopen): Likewise.
247 * ctf-string.c (ctf_str_write_strtab): Likewise.
248 * ctf-types.c (ctf_type_resolve): Likewise.
249 * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
250 (get_vbytes_v1): Pass down the ctf dict.
251 (get_vbytes_v2): Likewise.
252 (flip_ctf): Likewise.
253 (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
254 gettextize, as above.
255 (upgrade_types_v1): Adjust calls.
256 (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
257 (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
258 emitted into individual dicts into the open errors if this turns
259 out to be a failed open in the end.
260 * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
261 argument. Gettextize. Don't emit the errmsg.
262 (ctf_dump_funcs): Likewise. Collapse err label into its only case.
263 (ctf_dump_type): Likewise.
264 * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
265 argument. Gettextize. Don't emit the errmsg.
266 (ctf_link_one_type): Likewise.
267 (ctf_link_lazy_open): Likewise.
268 (ctf_link_one_input_archive): Likewise.
269 (ctf_link_deduplicating_count_inputs): Likewise.
270 (ctf_link_deduplicating_open_inputs): Likewise.
271 (ctf_link_deduplicating_close_inputs): Likewise.
272 (ctf_link_deduplicating): Likewise.
273 (ctf_link): Likewise.
274 (ctf_link_deduplicating_per_cu): Likewise. Add some missed
275 ctf_set_errnos to obscure error cases.
276 * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
277 err argument. Gettextize. Don't emit the errmsg.
278 (ctf_dedup_populate_mappings): Likewise.
279 (ctf_dedup_detect_name_ambiguity): Likewise.
280 (ctf_dedup_init): Likewise.
281 (ctf_dedup_multiple_input_dicts): Likewise.
282 (ctf_dedup_conflictify_unshared): Likewise.
283 (ctf_dedup): Likewise.
284 (ctf_dedup_rwalk_one_output_mapping): Likewise.
285 (ctf_dedup_id_to_target): Likewise.
286 (ctf_dedup_emit_type): Likewise.
287 (ctf_dedup_emit_struct_members): Likewise.
288 (ctf_dedup_populate_type_mapping): Likewise.
289 (ctf_dedup_populate_type_mappings): Likewise.
290 (ctf_dedup_emit): Likewise.
291 (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
293 (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
294 unknown-type-kind messages (which signify file corruption).
296 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
298 * configure.ac: Adjust package name to simply 'libctf': arbitrarily
299 declare this to be version 1.2.0.
300 * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
301 * Makefile.in: Regenerated.
302 * configure: Regenerated.
303 * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
304 * ctf-impl.h: Include it.
305 * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
306 (ctf_errmsg): Actually translate them.
308 2020-07-26 Eli Zaretskii <eliz@gnu.org>
311 * ctf-create.c (EOVERFLOW): If not defined by system header,
312 redirect to ERANGE as a poor man's substitute.
313 * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
315 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
317 * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
318 (ctf_dtd_delete): Likewise.
319 (ctf_dtd_lookup): Likewise.
320 (ctf_rollback): Likewise.
321 * ctf-hash.c (ctf_hash_lookup_type): Likewise.
322 * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
324 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
326 * ctf-lookup.c (ctf_lookup_by_name): Adjust.
328 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
330 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
333 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
335 * ctf-impl.h (ctf_list_splice): New.
336 * ctf-util.h (ctf_list_splice): Likewise.
337 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
338 (ctf_link_sort_inputs): Likewise.
339 (ctf_link_deduplicating_count_inputs): Likewise.
340 (ctf_link_deduplicating_open_inputs): Likewise.
341 (ctf_link_deduplicating_close_inputs): Likewise.
342 (ctf_link_deduplicating_variables): Likewise.
343 (ctf_link_deduplicating_per_cu): Likewise.
344 (ctf_link_deduplicating): Likewise.
347 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
349 * ctf-link.c (ctf_link_one_input_archive_member): Check
350 CTF_LINK_OMIT_VARIABLES_SECTION.
352 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
354 * ctf-impl.h (ctf_type_id_key): New, the key in the
356 (ctf_dedup): New, core deduplicator state.
357 (ctf_file_t) <ctf_dedup>: New.
358 <ctf_dedup_atoms>: New.
359 <ctf_dedup_atoms_alloc>: New.
360 (ctf_hash_type_id_key): New prototype.
361 (ctf_hash_eq_type_id_key): Likewise.
362 (ctf_dedup_atoms_init): Likewise.
363 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
364 (ctf_dedup_atoms_init): Likewise.
365 * ctf-create.c (ctf_serialize): Adjusted.
366 (ctf_add_encoded): No longer static.
367 (ctf_add_reftype): Likewise.
368 * ctf-open.c (ctf_file_close): Destroy the
369 ctf_dedup_atoms_alloc.
370 * ctf-dedup.c: New file.
371 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
372 * configure.ac: Check for stpcpy.
373 * Makefile.am: Add it.
374 * Makefile.in: Regenerate.
375 * config.h.in: Regenerate.
376 * configure: Regenerate.
378 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
380 * configure.ac: Add --enable-libctf-hash-debugging.
381 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
382 * Makefile.in: Regenerated.
383 * configure: Likewise.
384 * config.h.in: Likewise.
385 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
386 (ctf_assert): Define to assert.
388 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
390 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
392 * ctf-impl.h: Include it.
393 (ctf_sha1_init): New.
394 (ctf_sha1_add): Likewise.
395 (ctf_sha1_fini): Likewise.
396 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
398 * Makefile.am: Add file.
399 * Makefile.in: Regenerate.
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * libctf.ver (ctf_link_set_variable_filter): Add.
404 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
405 <ctf_link_variable_filter_arg>: Likewise.
406 * ctf-create.c (ctf_serialize): Adjust.
407 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
408 (ctf_link_one_variable): Call it if set.
410 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
412 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
413 conflicts, not the source type.
415 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
417 * ctf-impl.h (ctf_file_t): Improve comments.
418 <ctf_link_cu_mapping>: Split into...
419 <ctf_link_in_cu_mapping>: ... this...
420 <ctf_link_out_cu_mapping>: ... and this.
421 * ctf-create.c (ctf_serialize): Adjust.
422 * ctf-open.c (ctf_file_close): Likewise.
423 * ctf-link.c (ctf_create_per_cu): Look things up in the
424 in_cu_mapping instead of the cu_mapping.
425 (ctf_link_add_cu_mapping): The deduplicating link will define
426 what happens if many FROMs share a TO.
427 (ctf_link_add_cu_mapping): Create in_cu_mapping and
428 out_cu_mapping. Do not create ctf_link_outputs here any more, or
429 create per-CU dicts here: they are already created when needed.
430 (ctf_link_one_variable): Log a debug message if we skip a
431 variable due to its type being concealed in a CU-mapped link.
432 (This is probably too common a case to make into a warning.)
433 (ctf_link): Create empty per-CU dicts if requested.
435 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
437 * ctf-link.c (ctf_link_write): Close the fd.
439 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
441 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
442 * Makefile.in: Regenerated.
443 * ctf-impl.h (ctf_link_input_name): New.
444 (ctf_file_t) <ctf_link_flags>: New.
445 * ctf-create.c (ctf_serialize): Adjust accordingly.
446 * ctf-link.c: Define ctf_open as weak when PIC.
447 (ctf_arc_close_thunk): Remove unnecessary thunk.
448 (ctf_file_close_thunk): Likewise.
449 (ctf_link_input_name): New.
450 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
451 (ctf_link_input_close): Adjust accordingly.
452 (ctf_link_add_ctf_internal): New, split from...
453 (ctf_link_add_ctf): ... here. Return error if lazy loading of
454 CTF is not possible. Change to just call...
455 (ctf_link_add): ... this new function.
456 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
457 ctf_file_close_thunk.
458 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
459 <in_file_name>: ... this.
461 <share_mode>: Likewise (migrated to ctf_link_flags).
462 <done_main_member>: Rename to...
463 <done_parent>: ... this.
464 <main_input_fp>: Rename to...
465 <in_fp_parent>: ... this.
467 (ctf_link_one_type): Adjuwt accordingly. Transition to
468 ctf_err_warn, removing a TODO.
469 (ctf_link_one_variable): Note a case too common to warn about.
470 Report in the debug stream if a cu-mapped link prevents addition
471 of a conflicting variable.
472 (ctf_link_one_input_archive_member): Adjust.
473 (ctf_link_lazy_open): New, open a CTF archive for linking when
475 (ctf_link_close_one_input_archive): New, close it again.
476 (ctf_link_one_input_archive): Adjust for lazy opening, member
477 renames, and ctf_err_warn transition. Move the
478 empty_link_type_mapping call to...
479 (ctf_link): ... here. Adjut for renamings and thunk removal.
480 Don't spuriously fail if some input contains no CTF data.
481 (ctf_link_write): ctf_err_warn transition.
482 * libctf.ver: Remove not-yet-stable comment.
484 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
486 * ctf-impl.h (ctf_strerror): Delete.
487 * ctf-subr.c (ctf_strerror): Likewise.
488 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
491 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
493 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
494 (ctf_import_unref): New.
495 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
496 zero. Don't recurse back in if the refcount is already zero.
497 (ctf_import): Check ctf_parent_unreffed before deciding whether
498 to close a pre-existing parent. Set it to zero.
499 (ctf_import_unreffed): New, as above, setting
500 ctf_parent_unreffed to 1.
501 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
502 child: use direct assignment, and set unreffed on the new and
504 * ctf-link.c (ctf_create_per_cu): Import the parent using
507 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
509 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
510 (ctf_link_type_key): ... this, adjusting member prefixes to
512 (ctf_hash_type_mapping_key): Rename to...
513 (ctf_hash_type_key): ... this.
514 (ctf_hash_eq_type_mapping_key): Rename to...
515 (ctf_hash_eq_type_key): ... this.
516 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
517 (ctf_hash_type_key): ... this, and adjust for member name
519 (ctf_hash_eq_type_mapping_key): Rename to...
520 (ctf_hash_eq_type_key): ... this, and adjust for member name
522 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
523 need for out-of-memory checking in this code.
524 (ctf_type_mapping): Adjust.
526 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
528 configure.ac: Check for vasprintf.
529 configure: Regenerated.
530 config.h.in: Likewise.
532 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
534 * ctf-archive.c (ctf_arc_bufopen): Fix message.
536 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
538 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
540 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
541 if the input has no symtab, rather than dividing by
542 zero. Arrange to free it later via ctfi_free_ctfsect.
543 * ctf-archive.c (ctf_new_archive_internal): Do not
544 ctfi_free_strsect by default.
545 (ctf_arc_close): Possibly free it here.
547 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
549 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
550 (ctf_dump_format_type): improve slice formatting. Always print
551 the type size, even of slices.
552 (ctf_dump_member): Print slices (-> bitfields) differently from
553 non-slices. Failure to format a type is not an OOM.
555 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
557 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
558 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
559 (ctf_dump_objts): Likewise.
560 (ctf_dump_var): Likewise.
561 (ctf_dump_type): Do not emit a duplicate message. Move to
562 ctf_err_warning, and swallow all errors.
564 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
566 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
567 (ctf_decl_buf): Once it escapes, don't try to free it later.
569 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
571 * ctf-types.c (ctf_type_aname): Print arg types here...
572 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
573 in the type name here.
575 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
577 * ctf-impl.h (ctf_assert): New.
578 (ctf_err_warning_t): Likewise.
579 (ctf_file_t) <ctf_errs_warnings>: Likewise.
580 (ctf_err_warn): New prototype.
581 (ctf_assert_fail_internal): Likewise.
582 * ctf-inlines.h (ctf_assert_internal): Likewise.
583 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
584 * ctf-create.c (ctf_serialize): Copy it on serialization.
585 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
586 (ctf_errwarning_next): New iterator, free and pass back
587 errors/warnings in succession.
588 * libctf.ver (ctf_errwarning_next): Add.
590 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
592 * ctf-types.c (ctf_variable_iter): Fix error return.
594 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
596 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
598 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
600 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
602 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
604 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
606 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
607 ctf_dynhash_next_sorted.
608 <cu.ctn_h>: New, pointer to the dynhash under iteration.
609 <cu.ctn_s>: New, pointer to the dynset under iteration.
610 (ctf_hash_sort_f): Sorting function passed to...
611 (ctf_dynhash_next_sorted): ... this new function.
612 (ctf_dynhash_next): New.
613 (ctf_dynset_next): New.
614 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
615 (ctf_dynhash_cnext): New.
616 (ctf_dynset_cnext): New.
617 * ctf-hash.c (ctf_dynhash_next_sorted): New.
618 (ctf_dynhash_next): New.
619 (ctf_dynset_next): New.
620 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
622 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
624 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
626 * ctf-impl.h (ctf_next): New.
627 (ctf_get_dict): New prototype.
628 * ctf-lookup.c (ctf_get_dict): New, split out of...
629 (ctf_lookup_by_id): ... here.
630 * ctf-util.c (ctf_next_create): New.
631 (ctf_next_destroy): New.
632 (ctf_next_copy): New.
633 * ctf-types.c (includes): Add <assert.h>.
634 (ctf_member_next): New.
635 (ctf_enum_next): New.
636 (ctf_type_iter): Document the lack of iteration over parent
638 (ctf_type_next): New.
639 (ctf_variable_next): New.
640 * ctf-archive.c (ctf_archive_next): New.
641 * libctf.ver: Add new public functions.
643 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
645 * libctf.ver (ctf_ref): New.
646 * ctf-open.c (ctf_ref): Implement it.
648 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
650 * ctf-inlines.h (ctf_forwardable_kind): New.
651 * ctf-create.c (ctf_add_forward): Use it.
653 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
655 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
656 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
658 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
660 * ctf-hash.c (ctf_dynset_eq_string): New.
661 (ctf_dynset_create): New.
662 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
663 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
664 (key_to_internal): New.
665 (internal_to_key): New.
666 (ctf_dynset_insert): New.
667 (ctf_dynset_remove): New.
668 (ctf_dynset_destroy): New.
669 (ctf_dynset_lookup): New.
670 (ctf_dynset_exists): New.
671 (ctf_dynset_lookup_any): New.
672 (ctf_hash_insert_type): Coding style.
673 (ctf_hash_define_type): Likewise.
674 * ctf-impl.h (ctf_dynset_t): New.
675 (ctf_dynset_eq_string): New.
676 (ctf_dynset_create): New.
677 (ctf_dynset_insert): New.
678 (ctf_dynset_remove): New.
679 (ctf_dynset_destroy): New.
680 (ctf_dynset_lookup): New.
681 (ctf_dynset_exists): New.
682 (ctf_dynset_lookup_any): New.
683 * ctf-inlines.h (ctf_dynset_cinsert): New.
685 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
687 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
688 <value_free>: Likewise.
690 (ctf_dynhash_item_free): Indirect through the owner.
691 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
692 allocate space for the key_free and value_free fields fields
694 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
695 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
696 value_free if they will exist. Set the slot's owner, but only
698 (ctf_dynhash_remove): Adjust.
700 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
702 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
703 there is a key-freeing function and the key already exists.
705 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
707 * ctf-inlines.h: New file.
708 * ctf-impl.h: Include it.
709 (ctf_hash_iter_find_f): New typedef.
710 (ctf_dynhash_elements): New.
711 (ctf_dynhash_lookup_kv): New.
712 (ctf_dynhash_iter_find): New.
713 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
714 (ctf_traverse_find_cb_arg_t): New.
715 (ctf_hashtab_traverse_find): New.
716 (ctf_dynhash_iter_find): New.
717 (ctf_dynhash_elements): New.
719 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
721 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
723 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
725 * ctf-archive.c (ctf_archive_count): New.
726 * libctf.ver: New public function.
728 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
730 * ctf-types.c (ctf_member_count): New.
731 * libctf.ver: New public function.
733 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
735 * ctf-types.c (ctf_type_kind_forwarded): New.
737 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
739 * ctf-types.c (ctf_type_name_raw): New.
740 (ctf_type_aname_raw): Reimplement accordingly.
742 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
744 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
746 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
748 * ctf-impl.h (struct ctf_archive_internal)
749 <ctfi_unmap_on_close>: New.
750 (ctf_new_archive_internal): Adjust.
751 * ctf-archive.c (ctf_new_archive_internal): Likewise.
752 Initialize ctfi_unmap_on_close. Adjust error path.
753 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
754 (unmap_on_close is 0).
755 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
756 * ctf-open-bfd.c (ctf_fdopen): Adjust.
758 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
760 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
761 ints, floats or typedefs have no name. Fix comment typo.
763 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
765 * ctf-create.c (ctf_add_slice): Support slices of any kind that
766 resolves to an integral type.
767 * ctf-types.c (ctf_type_encoding): Resolve the type before
768 fishing its encoding out.
770 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
772 * ctf-create.c (ctf_create): Mark dirty.
774 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
776 * ctf-create.c (membcmp) Skip nameless members.
778 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
780 * ctf-create.c (ctf_add_member_offset): Support names of ""
781 as if they were the null pointer.
783 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
785 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
788 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
790 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
792 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
794 * ctf-create.c (ctf_serialize): Add cast.
795 (ctf_add_slice): Likewise.
797 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
799 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
800 * ctf-create.c (ctf_add_function): Check for unimplemented type
801 and populate at the same time. Populate one-by-one, not via
803 (ctf_serialize): Remove unnecessary cast.
804 * ctf-types.c (ctf_func_type_info): Likewise.
805 (ctf_func_type_args): Likewise. Fix comment typo.
807 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
809 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
810 (ctf_add_array): Support array contents of type zero.
811 (ctf_add_function): Support arguments and return types of
813 (ctf_add_typedef): Support typedefs to type zero.
814 (ctf_add_member_offset): Support members of type zero,
815 unless added at unspecified (naturally-aligned) offset.
817 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
819 * ctf-error.c: Include <stddef.h>, for offsetof.
820 (_ctf_errlist): Migrate to...
821 (_ctf_errlist_t): ... this.
822 (_ctf_erridx): New, indexes into _ctf_errlist_t.
824 (ctf_errmsg): Adjust accordingly.
825 * Makefile.am (BUILT_SOURCES): Note...
826 (ctf-error.h): ... this new rule.
827 * Makefile.in: Regenerate.
828 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
829 * .gitignore: New, ignore ctf-error.h.
831 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
833 * ctf-impl.h: Fix typos in comments.
835 2020-07-22 Nick Clifton <nickc@redhat.com>
837 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
838 same file descriptor.
840 2020-07-04 Nick Clifton <nickc@redhat.com>
842 Binutils 2.35 branch created.
844 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
846 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
848 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
849 * config.h.in: Regenerated.
850 * Makefile.in: Likewise.
851 * configure: Likewise.
853 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
855 * ctf-create.c: Include <unistd.h>.
856 * ctf-open-bfd.c: Likewise.
858 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
861 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
862 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
863 means this is declared.
864 (bswap_32): Likewise.
865 (bswap_64): Likewise.
866 (bswap_identity_64): Remove, unused.
867 * configure: Regenerated.
868 * config.h.in: Likewise.
870 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
873 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
874 (_libctf_unlikely_): Likewise.
875 (_libctf_unused): Likewise.
876 (_libctf_malloc_): Likewise.
878 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
881 * ctf-archive.c (search_nametbl): No longer global: declare...
882 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
883 (search_modent_by_name): Take and use ARG for the nametbl.
885 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
887 * ctf-impl.h (ctf_new_archive_internal): Declare.
888 (ctf_arc_bufopen): Remove.
889 (ctf_archive_internal) <ctfi_free_symsect>: New.
890 * ctf-archive.c (ctf_arc_close): Use it.
891 (ctf_arc_bufopen): Fuse into...
892 (ctf_new_archive_internal): ... this, moved across from...
893 * ctf-open-bfd.c: ... here.
894 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
895 * libctf.ver: Add it.
897 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
899 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
900 (ctf_dtd_delete): Remove correspondingly.
901 (ctf_rollback): Likewise.
903 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
905 * ctf-create.c (ctf_add_type_internal): Hand back existing types
908 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
910 * ctf-create.c (ctf_add_forward): Don't add forwards to
911 types that already exist.
913 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
915 * ctf-open.c (init_types): Only intern root-visible types.
916 * ctf-create.c (ctf_dtd_insert): Likewise.
917 (ctf_dtd_delete): Only remove root-visible types.
918 (ctf_rollback): Likewise.
919 (ctf_add_generic): Adjust.
920 (ctf_add_struct_sized): Adjust comment.
921 (ctf_add_union_sized): Likewise.
922 (ctf_add_enum): Likewise.
923 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
925 2020-03-11 John Baldwin <jhb@FreeBSD.org>
927 * swap.h (bswap_identity_64): Make static.
929 2020-01-18 Nick Clifton <nickc@redhat.com>
931 Binutils 2.34 branch created.
933 2020-01-05 Joel Brobecker <brobecker@adacore.com>
936 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
937 * configure, config.h.in: Regenerate.
939 2020-01-01 Alan Modra <amodra@gmail.com>
941 Update year range in copyright notice of all files.
943 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
945 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
947 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
949 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
950 * ctf-types.c (ctf_type_lname): Likewise.
952 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
954 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
955 ctf_import after the first for a given file.
957 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
959 * ctf-impl.h (ctf_str_append_noerr): Declare.
960 * ctf-util.c (ctf_str_append_noerr): Define in terms of
962 * ctf-dump.c (str_append): New, call it.
963 (ctf_dump_format_type): Use str_append, not ctf_str_append.
964 (ctf_dump_label): Likewise.
965 (ctf_dump_objts): Likewise.
966 (ctf_dump_funcs): Likewise.
967 (ctf_dump_var): Likewise.
968 (ctf_dump_member): Likewise.
969 (ctf_dump_type): Likewise.
970 (ctf_dump): Likewise.
972 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
974 * ctf-impl.h (ctf_alloc): Remove.
975 (ctf_free): Likewise.
976 (ctf_strdup): Likewise.
977 * ctf-subr.c (ctf_alloc): Remove.
978 (ctf_free): Likewise.
979 * ctf-util.c (ctf_strdup): Remove.
981 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
982 ctf_free; strdup, not ctf_strdup.
983 (ctf_dtd_delete): Likewise.
984 (ctf_dvd_delete): Likewise.
985 (ctf_add_generic): Likewise.
986 (ctf_add_function): Likewise.
987 (ctf_add_enumerator): Likewise.
988 (ctf_add_member_offset): Likewise.
989 (ctf_add_variable): Likewise.
991 (ctf_compress_write): Likewise.
992 (ctf_write_mem): Likewise.
993 * ctf-decl.c (ctf_decl_push): Likewise.
994 (ctf_decl_fini): Likewise.
995 (ctf_decl_sprintf): Likewise. Check for OOM.
996 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
997 ctf_free; strdup, not ctf_strdup.
998 (ctf_dump_free): Likewise.
999 (ctf_dump): Likewise.
1000 * ctf-open.c (upgrade_types_v1): Likewise.
1001 (init_types): Likewise.
1002 (ctf_file_close): Likewise.
1003 (ctf_bufopen_internal): Likewise. Check for OOM.
1004 (ctf_parent_name_set): Likewise: report the OOM to the caller.
1005 (ctf_cuname_set): Likewise.
1006 (ctf_import): Likewise.
1007 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
1008 free, not ctf_free; strdup, not ctf_strdup.
1009 (ctf_str_free_atom): Likewise.
1010 (ctf_str_create_atoms): Likewise.
1011 (ctf_str_add_ref_internal): Likewise.
1012 (ctf_str_remove_ref): Likewise.
1013 (ctf_str_write_strtab): Likewise.
1015 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1017 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
1018 work right for non-int/fps.
1020 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
1022 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
1025 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
1027 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
1028 * ctf-open.c (ctf_file_close): Free it.
1029 * ctf-create.c (ctf_serialize): Adjust.
1030 (membcmp): When reporting a conflict due to an error, report the
1032 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
1033 (ctf_add_type_internal): ... this. Hand back types we are already
1034 in the middle of adding immediately. Hand back structs/unions with
1035 the same number of members immediately. Do not walk the dynamic
1036 list. Call ctf_add_type_internal, not ctf_add_type. Handle
1037 forwards promoted to other types and the inverse case identically.
1038 Add structs to the mapping as soon as we intern them, before they
1041 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1043 * ctf-impl.h (ctf_names_t): New.
1044 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
1045 (ctf_file_t) <ctf_structs>: Likewise.
1046 <ctf_unions>: Likewise.
1047 <ctf_enums>: Likewise.
1048 <ctf_names>: Likewise.
1049 <ctf_lookups>: Improve comment.
1050 <ctf_ptrtab_len>: New.
1051 <ctf_prov_strtab>: New.
1052 <ctf_str_prov_offset>: New.
1053 <ctf_dtbyname>: Remove, redundant to the names hashes.
1054 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
1055 (ctf_dtdef_t) <dtd_name>: Remove.
1056 <dtd_data>: Note that the ctt_name is now populated.
1057 (ctf_str_atom_t) <csa_offset>: This is now the strtab
1058 offset for internal strings too.
1059 <csa_external_offset>: New, the external strtab offset.
1060 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
1061 (ctf_name_table): New declaration.
1062 (ctf_lookup_by_rawname): Likewise.
1063 (ctf_lookup_by_rawhash): Likewise.
1064 (ctf_set_ctl_hashes): Likewise.
1065 (ctf_serialize): Likewise.
1066 (ctf_dtd_insert): Adjust.
1067 (ctf_simple_open_internal): Likewise.
1068 (ctf_bufopen_internal): Likewise.
1069 (ctf_list_empty_p): Likewise.
1070 (ctf_str_remove_ref): Likewise.
1071 (ctf_str_add): Returns uint32_t now.
1072 (ctf_str_add_ref): Likewise.
1073 (ctf_str_add_external): Now returns a boolean (int).
1074 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
1075 for strings in the appropriate range.
1076 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
1077 when adding the null string to the new strtab.
1078 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
1079 (ctf_str_add_ref_internal): Add make_provisional argument. If
1080 make_provisional, populate the offset and fill in the
1081 ctf_prov_strtab accordingly.
1082 (ctf_str_add): Return the offset, not the string.
1083 (ctf_str_add_ref): Likewise.
1084 (ctf_str_add_external): Return a success integer.
1085 (ctf_str_remove_ref): New, remove a single ref.
1086 (ctf_str_count_strtab): Do not count the initial null string's
1087 length or the existence or length of any unreferenced internal
1089 (ctf_str_populate_sorttab): Skip atoms with no refs.
1090 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
1091 to the cts_len for the null string, since it is no longer done
1092 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
1093 Populate the csa_offset for both internal and external cases.
1094 Flush the ctf_prov_strtab afterwards, and reset the
1095 ctf_str_prov_offset.
1096 * ctf-create.c (ctf_grow_ptrtab): New.
1097 (ctf_create): Call it. Initialize new fields rather than old
1098 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
1099 Set the ctl hashes and data model.
1100 (ctf_update): Rename to...
1101 (ctf_serialize): ... this. Leave a compatibility function behind.
1102 Tell ctf_simple_open_internal that this is a writable dictionary.
1103 Pass the new fields along from the old dictionary. Drop
1104 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
1105 Do not zero out the DTD's ctt_name.
1106 (ctf_prefixed_name): Rename to...
1107 (ctf_name_table): ... this. No longer return a prefixed name: return
1108 the applicable name table instead.
1109 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
1110 kind we're adding. Migrate away from dtd_name.
1111 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
1113 (ctf_dtd_lookup_type_by_name): Remove.
1114 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
1115 No longer check ctf_dtnextid: check ctf_typemax instead.
1116 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
1117 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
1118 ctf_name_table and the right name table, and migrate away from
1119 dtd_name as in ctf_dtd_delete.
1120 (ctf_add_generic): Pass in the kind explicitly and pass it to
1121 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
1122 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
1123 Grow the ptrtab if needed.
1124 (ctf_add_encoded): Pass in the kind.
1125 (ctf_add_slice): Likewise.
1126 (ctf_add_array): Likewise.
1127 (ctf_add_function): Likewise.
1128 (ctf_add_typedef): Likewise.
1129 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1130 ctt_name rather than dtd_name.
1131 (ctf_add_struct_sized): Pass in the kind. Use
1132 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1133 ctf_dtd_lookup_type_by_name.
1134 (ctf_add_union_sized): Likewise.
1135 (ctf_add_enum): Likewise.
1136 (ctf_add_enum_encoded): Likewise.
1137 (ctf_add_forward): Likewise.
1138 (ctf_add_type): Likewise.
1139 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1140 being initialized until after the call.
1141 (ctf_write_mem): Likewise.
1142 (ctf_write): Likewise.
1143 * ctf-archive.c (arc_write_one_ctf): Likewise.
1144 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1145 ctf_hash_lookup_type.
1146 (ctf_lookup_by_id): No longer check the readonly types if the
1147 dictionary is writable.
1148 * ctf-open.c (init_types): Assert that this dictionary is not
1149 writable. Adjust to use the new name hashes, ctf_name_table,
1150 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
1151 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
1152 if set. Drop out early when dictionary is writable. Split the
1153 ctf_lookups initialization into...
1154 (ctf_set_cth_hashes): ... this new function.
1155 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
1156 (ctf_simple_open): Adjust accordingly.
1157 (ctf_bufopen): Likewise.
1158 (ctf_file_close): Destroy the appropriate name hashes. No longer
1159 destroy ctf_dtbyname, which is gone.
1160 (ctf_getdatasect): Remove spurious "extern".
1161 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1162 specified name table, given a kind.
1163 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1164 (ctf_member_iter): Add support for iterating over the
1166 (ctf_enum_iter): Likewise.
1167 (ctf_variable_iter): Likewise.
1168 (ctf_type_rvisit): Likewise.
1169 (ctf_member_info): Add support for types in the dynamic type list.
1170 (ctf_enum_name): Likewise.
1171 (ctf_enum_value): Likewise.
1172 (ctf_func_type_info): Likewise.
1173 (ctf_func_type_args): Likewise.
1174 * ctf-link.c (ctf_accumulate_archive_names): No longer call
1176 (ctf_link_write): Likewise.
1177 (ctf_link_intern_extern_string): Adjust for new
1178 ctf_str_add_external return value.
1179 (ctf_link_add_strtab): Likewise.
1180 * ctf-util.c (ctf_list_empty_p): New.
1182 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
1184 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1186 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1188 (ctf_add_variable): Likewise for variables pointing to them.
1189 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1190 type link failure, but do warn for others.
1191 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
1192 errors to be ENOMEM.
1193 (ctf_dump_member): Likewise.
1194 (ctf_dump_type): Likewise.
1195 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1196 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1197 (ctf_dump_header): Likewise.
1198 (ctf_dump_label): likewise.
1199 (ctf_dump_objts): likewise.
1200 (ctf_dump_funcs): likewise.
1201 (ctf_dump_var): likewise.
1202 (ctf_dump_str): Likewise.
1204 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
1206 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1207 (LT_INIT): Likewise.
1208 (AM_INSTALL_LIBBFD): Likewise.
1209 (dlopen): Note why this is necessary in a comment.
1210 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1212 (SHARED_LDFLAGS): Likewise.
1213 (BFD_LIBADD): Likewise, for libbfd.
1214 (BFD_DEPENDENCIES): Likewise.
1215 (VERSION_FLAGS): Initialize, using a version script if ld supports
1216 one, or libtool -export-symbols-regex otherwise.
1217 (AC_CONFIG_MACRO_DIR): Add ../BFD.
1218 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1220 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1221 (noinst_LIBRARIES): Replace with...
1222 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1223 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1224 libctf-nobfd.la as well.
1225 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1226 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1227 (libctf_a_SOURCES): Rename to...
1228 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1230 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1231 with ctf-open-bfd.c added.
1232 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1233 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1234 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1235 * Makefile.am [INSTALL_LIBCTF]: Use it.
1236 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1238 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1239 the unstable components).
1240 * Makefile.in: Regenerated.
1241 * config.h.in: Likewise.
1242 * configure: Likewise.
1244 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1246 * configure.ac (INSTALL_LIBCTF): New, controlled by
1247 --enable-install-libctf.
1248 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1249 * Makefile.in: Regenerated.
1250 * configure: Regenerated.
1252 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1254 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1255 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1257 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1259 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1261 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1263 * ctf-impl.h (includes): Include <sys/param.h> here.
1265 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1267 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1268 (flip_objts): Likewise.
1269 (flip_vars): Likewise.
1270 (flip_types): Likewise.
1272 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1274 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1275 freeing functions: if set, free the key and value if the slot
1276 already exists. Always reassign the key.
1277 (ctf_dynhash_insert): Adjust call appropriately.
1278 (ctf_hash_insert_type): Likewise.
1280 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
1282 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1283 type kind. Allow forwards to unify with pre-existing structs/
1286 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1288 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1289 <ctf_link_memb_name_changer>: Likewise.
1290 <ctf_link_memb_name_changer_arg>: Likewise.
1291 * ctf-create.c (ctf_update): Update accordingly.
1292 * ctf-open.c (ctf_file_close): Likewise.
1293 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1294 (ctf_link_add_cu_mapping): New.
1295 (ctf_link_set_memb_name_changer): Likewise.
1296 (ctf_change_parent_name): New.
1297 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1298 allocated by the caller's ctf_link_memb_name_changer.
1299 <ndynames>: Likewise.
1300 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1301 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1302 ctf_change_parent_name. Free any resulting names.
1304 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1306 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1307 (ctf_link_one_type): ... here, with parent-name setting added.
1308 (check_variable): New.
1309 (ctf_link_one_variable): Likewise.
1310 (ctf_link_one_input_archive_member): Call it.
1311 * ctf-error.c (_ctf_errlist): Updated with new errors.
1313 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1315 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1316 (struct ctf_link_type_mapping_key): New.
1317 (ctf_hash_type_mapping_key): Likewise.
1318 (ctf_hash_eq_type_mapping_key): Likewise.
1319 (ctf_add_type_mapping): Likewise.
1320 (ctf_type_mapping): Likewise.
1321 (ctf_dynhash_empty): Likewise.
1322 * ctf-open.c (ctf_file_close): Update accordingly.
1323 * ctf-create.c (ctf_update): Likewise.
1324 (ctf_add_type): Populate the mapping.
1325 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1326 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1327 (ctf_dynhash_insert): Fix comment typo.
1328 (ctf_dynhash_empty): New.
1329 * ctf-link.c (ctf_add_type_mapping): New.
1330 (ctf_type_mapping): Likewise.
1331 (empty_link_type_mapping): New.
1332 (ctf_link_one_input_archive): Call it.
1334 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1336 * ctf-link.c: New file, linking of the string and type sections.
1337 * Makefile.am (libctf_a_SOURCES): Add it.
1338 * Makefile.in: Regenerate.
1340 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1342 * ctf-create.c (ctf_update): Update accordingly.
1343 * ctf-open.c (ctf_file_close): Likewise.
1344 * ctf-error.c (_ctf_errlist): Updated with new errors.
1346 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1348 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1350 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1352 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1354 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1355 (ctf_dump_format_type): Add non-root-type { } notation.
1356 Add root flag to prototype.
1357 (ctf_dump_label): Adjust accordingly.
1358 (ctf_dump_objts): Likewise.
1359 (ctf_dump_var): Likewise.
1361 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1363 * ctf-create.c (ctf_compress_write): Fix double-free.
1365 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1367 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1369 (ctf_arc_write_fd): ... this new function.
1370 * ctf-create.c (ctf_write_mem): New.
1372 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1374 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1375 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1376 (ctf_str_add_ref): Name the last arg.
1377 (ctf_str_add_external) New.
1378 (ctf_str_add_strraw_explicit): Likewise.
1379 (ctf_simple_open_internal): Likewise.
1380 (ctf_bufopen_internal): Likewise.
1382 * ctf-string.c (ctf_strraw_explicit): Split from...
1383 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1384 (ctf_str_add_ref_internal): Return the atom, not the
1386 (ctf_str_add): Adjust accordingly.
1387 (ctf_str_add_ref): Likewise. Move up in the file.
1388 (ctf_str_add_external): New: update the csa_offset.
1389 (ctf_str_count_strtab): Only account for strings with no csa_offset
1390 in the internal strtab length.
1391 (ctf_str_write_strtab): If the csa_offset is set, update the
1392 string's refs without writing the string out, and update the
1393 ctf_syn_ext_strtab. Make OOM handling less ugly.
1394 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1395 (ctf_update): Handle failure to populate the strtab. Pass in the
1396 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1397 Call ctf_simple_open_internal, not ctf_simple_open.
1398 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1400 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1401 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1402 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1403 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1404 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1405 (ctf_simple_open_internal): ... this new function, which calls
1406 ctf_bufopen_internal.
1407 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1408 (ctf_bufopen_internal): ... this new function, which sets
1411 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1413 * ctf_types.c (ctf_type_iter_all): New.
1415 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1417 * ctf-open.c (init_symtab): Check for overflow against the right
1419 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1420 (upgrade_types_v1): Note that these sections are not checked.
1421 (flip_header): Endian-swap the header fields.
1422 (flip_ctf): Endian-swap the sections.
1423 (flip_objts): Update comment.
1424 (ctf_bufopen): Check header offsets and alignment for validity.
1426 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1428 * ctf-open-bfd.c: Add <assert.h>.
1429 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1430 techniques borrowed from bfd_elf_sym_name.
1431 (ctf_new_archive_internal): Improve comment.
1432 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1433 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1434 no symbol section, but not vice versa.
1436 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1438 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1439 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1440 * ctf-dump.c (dump_header): New function, dump the CTF header.
1441 (ctf_dump): Call it.
1442 (ctf_dump_header_strfield): New function.
1443 (ctf_dump_header_sectfield): Likewise.
1445 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1447 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1448 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1449 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1450 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1451 Print out ctf_cuname: only print out ctf_parname if set.
1452 (ctf_free_base): Removed, ctf_base is no longer freed: free
1453 ctf_dynbase instead.
1454 (ctf_set_version): Fix spacing.
1455 (upgrade_header): New, in-place header upgrading.
1456 (upgrade_types): Rename to...
1457 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1458 longer track old and new headers separately. No longer allow for
1459 header sizes explicitly: squeeze the headers out on upgrade (they
1460 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1461 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1462 (upgrade_types): New, also handle ctf_parmax updating.
1463 (flip_header): Flip ctf_cuname.
1464 (flip_types): Flip BUF explicitly rather than deriving BUF from
1466 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1467 required alignment of objtoff and funcoff. No longer store it in
1468 the ctf_buf unless that buf is derived unmodified from the input.
1469 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1470 that duplicate fields in ctf_file: move allocation of ctf_file
1471 further up instead. Call upgrade_header as needed. Move
1472 version-specific ctf_parmax initialization into upgrade_types. More
1473 concise error handling.
1474 (ctf_file_close): No longer test for null pointers before freeing.
1475 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1478 (ctf_cuname_set): New.
1479 * ctf-create.c (ctf_update): Populate ctf_cuname.
1480 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1482 (ctf_write): Likewise.
1483 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1484 Fix the compression length: fp->ctf_size never counted the CTF
1485 header. Simplify the compress call accordingly.
1487 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1489 * ctf-endian.h: Don't assume htole64 and le64toh are always
1490 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1491 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1492 not bswap_identity_64.
1494 2019-09-18 Alan Modra <amodra@gmail.com>
1496 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1498 2019-09-09 Phil Blundell <pb@pbcl.net>
1500 binutils 2.33 branch created.
1502 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1504 * ctf-types.c (ctf_type_aname_raw): New.
1505 (ctf_func_type_info): Likewise.
1506 (ctf_func_type_args): Likewise.
1507 * ctf-error.c (_ctf_errlist): Fix description.
1508 * ctf-lookup.c: Fix file description.
1510 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1512 * ctf-create.c (ctf_create): Fix off-by-one error.
1514 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1516 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1518 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1519 (struct ctf_str_atom): New, disambiguated single string.
1520 (struct ctf_str_atom_ref): New, points to some other location that
1521 references this string's offset.
1522 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1523 Remove member ctf_dtvstrlen: we no longer track the total strlen
1525 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1526 (ctf_str_free_atoms): Likewise.
1527 (ctf_str_add): Likewise.
1528 (ctf_str_add_ref): Likewise.
1529 (ctf_str_rollback): Likewise.
1530 (ctf_str_purge_refs): Likewise.
1531 (ctf_str_write_strtab): Likewise.
1532 (ctf_realloc): Declare new function in ctf-util.c.
1534 * ctf-open.c (ctf_bufopen): Create the atoms table.
1535 (ctf_file_close): Destroy it.
1536 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1537 special-case the position of the parname string. Construct the
1538 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1539 rest of each buffer element is constructed, not via open-coding:
1540 realloc the CTF buffer and append the strtab to it. No longer
1541 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1542 strtab construction.
1543 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1544 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1545 after buffer element construction instead.
1546 (ctf_copy_lmembers): Likewise.
1547 (ctf_copy_emembers): Likewise.
1548 (ctf_create): No longer maintain the ctf_dtvstrlen.
1549 (ctf_dtd_delete): Likewise.
1550 (ctf_dvd_delete): Likewise.
1551 (ctf_add_generic): Likewise.
1552 (ctf_add_enumerator): Likewise.
1553 (ctf_add_member_offset): Likewise.
1554 (ctf_add_variable): Likewise.
1555 (membadd): Likewise.
1556 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1557 if there are active ctf_str_num_refs.
1558 (ctf_strraw): Move to ctf-string.c.
1559 (ctf_strptr): Likewise.
1560 * ctf-string.c: New file, strtab manipulation.
1562 * Makefile.am (libctf_a_SOURCES): Add it.
1563 * Makefile.in: Regenerate.
1565 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1567 * ctf-impl.h (ctf_hash_iter_f): New.
1568 (ctf_dynhash_iter): New declaration.
1569 (ctf_dynhash_iter_remove): New declaration.
1570 * ctf-hash.c (ctf_dynhash_iter): Define.
1571 (ctf_dynhash_iter_remove): Likewise.
1572 (ctf_hashtab_traverse): New.
1573 (ctf_hashtab_traverse_remove): Likewise.
1574 (struct ctf_traverse_cb_arg): Likewise.
1575 (struct ctf_traverse_remove_cb_arg): Likewise.
1577 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1579 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1581 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1583 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1584 (ctf_dump_funcs): Likewise.
1586 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1588 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1589 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1590 little-endian CTF archive magic. Do not check the CTF version:
1591 ctf_simple_open does that in endian-safe ways. Do not dereference
1592 null pointers on open failure.
1594 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1596 * ctf-open.c (get_vbytes_common): Return the new slice size.
1597 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1598 Remember to copy in the CTF data when opening an uncompressed
1599 foreign-endian CTF file. Prune useless variable manipulation.
1601 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1603 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1606 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1608 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1611 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1613 * ctf-subr.c (_PAGESIZE): Remove.
1614 (ctf_data_alloc): Likewise.
1615 (ctf_data_free): Likewise.
1616 (ctf_data_protect): Likewise.
1617 * ctf-impl.h: Remove declarations.
1618 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1619 ctf_free, not ctf_data_free.
1620 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1621 the buffer again on compression error.
1622 * ctf-open.c (ctf_set_base): No longer track the size: call
1623 ctf_free, not ctf_data_free.
1624 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1625 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1627 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1629 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1631 (ctf_dvd_insert): Likewise.
1632 (ctf_add_generic): Likewise.
1633 (ctf_add_variable): Likewise.
1634 * ctf-impl.h: Adjust declarations.
1636 2019-06-14 Alan Modra <amodra@gmail.com>
1638 * configure: Regenerate.
1640 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1642 * ctf-decls.h: Include <libiberty.h>.
1643 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1645 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1647 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1648 (ctf_dump_objts): Likewise.
1649 (ctf_dump_funcs): Likewise.
1650 (ctf_dump_member): Likewise.
1651 (ctf_dump_str): Likewise.
1653 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1655 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1656 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1658 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1660 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1661 (ctf_arc_open_by_offset): Likewise.
1662 * ctf-create.c (ctf_add_type): Likewise.
1664 2019-06-04 Tom Tromey <tromey@adacore.com>
1666 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1667 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1669 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1671 * configure.ac: Check for O_CLOEXEC.
1672 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1673 * config.h.in: Regenerate.
1674 * configure: Likewise.
1676 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1678 * qsort_r.c: Rename to...
1679 * ctf-qsort_r.c: ... this.
1680 (_quicksort): Define to ctf_qsort_r.
1681 * ctf-decls.h (qsort_r): Remove.
1683 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1684 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1685 * Makefile.am (libctf_a_LIBADD): Remove.
1686 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1687 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1688 * ctf-create.c (ctf_update): Likewise.
1689 * configure.ac: Check for BSD versus GNU qsort_r signature.
1690 * Makefile.in: Regenerate.
1691 * config.h.in: Likewise.
1692 * configure: Likewise.
1694 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1696 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1698 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1700 * Makefile.am (ZLIB): New.
1701 (ZLIBINC): Likewise.
1702 (AM_CFLAGS): Use them.
1703 (libctf_a_LIBADD): New, for LIBOBJS.
1704 * configure.ac: Check for zlib, endian.h, and qsort_r.
1705 * ctf-endian.h: New, providing htole64 and le64toh.
1706 * swap.h: Code style fixes.
1707 (bswap_identity_64): New.
1708 * qsort_r.c: New, from gnulib (with one added #include).
1709 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1710 and unconditional definitions of MIN and MAX.
1711 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1712 (ctf_set_errno): Now returns unsigned long.
1713 * ctf-util.c (ctf_set_errno): Adjust here too.
1714 * ctf-archive.c: Use ctf-endian.h.
1715 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1716 cts_flags and cts_offset.
1717 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1718 * ctf-create.c: Provide a definition of roundup if not defined.
1719 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1720 (ctf_add_reftype): Do not check if type IDs are below zero.
1721 (ctf_add_slice): Likewise.
1722 (ctf_add_typedef): Likewise.
1723 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1724 when known error-free. Drop CTF_ERR usage for functions returning
1726 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1728 (ctf_add_variable): Likewise.
1729 (enumcmp): Likewise.
1730 (enumadd): Likewise.
1731 (membcmp): Likewise.
1732 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1733 when known error-free.
1734 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1735 returning int: use CTF_ERR for functions returning ctf_type_id.
1736 (ctf_dump_label): Likewise.
1737 (ctf_dump_objts): Likewise.
1738 * ctf-labels.c (ctf_label_topmost): Likewise.
1739 (ctf_label_iter): Likewise.
1740 (ctf_label_info): Likewise.
1741 * ctf-lookup.c (ctf_func_args): Likewise.
1742 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1743 (ctf_bufopen): Likewise. Use zlib types as needed.
1744 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1746 (ctf_enum_iter): Likewise.
1747 (ctf_type_size): Likewise.
1748 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1749 (ctf_type_kind_unsliced): Likewise.
1750 (ctf_type_kind): Likewise.
1751 (ctf_type_encoding): Likewise.
1752 (ctf_member_info): Likewise.
1753 (ctf_array_info): Likewise.
1754 (ctf_enum_value): Likewise.
1755 (ctf_type_rvisit): Likewise.
1756 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1758 (ctf_simple_open): Likewise.
1759 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1760 * Makefile.in: Regenerate.
1761 * aclocal.m4: Likewise.
1762 * config.h: Likewise.
1763 * configure: Likewise.
1765 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1767 * configure.in: Check for bfd_section_from_elf_index.
1768 * configure: Regenerate.
1769 * config.h.in [HAVE_BFD_ELF]: Likewise.
1770 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1771 abfd is potentially unused now.
1773 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1776 * Makefile.in: Regenerated.
1777 * config.h.in: Likewise.
1778 * aclocal.m4: Likewise.
1779 * configure: Likewise.
1781 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1785 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1787 * ctf-labels.c: New.
1789 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1791 * ctf-impl.h (_libctf_version): New declaration.
1792 * ctf-subr.c (_libctf_version): Define it.
1795 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1797 * ctf-create.c (enumcmp): New.
1798 (enumadd): Likewise.
1799 (membcmp): Likewise.
1800 (membadd): Likewise.
1801 (ctf_add_type): Likewise.
1803 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1805 * ctf-lookup.c (isqualifier): New.
1806 (ctf_lookup_by_name): Likewise.
1807 (struct ctf_lookup_var_key): Likewise.
1808 (ctf_lookup_var): Likewise.
1809 (ctf_lookup_variable): Likewise.
1810 (ctf_lookup_symbol_name): Likewise.
1811 (ctf_lookup_by_symbol): Likewise.
1812 (ctf_func_info): Likewise.
1813 (ctf_func_args): Likewise.
1815 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1817 * ctf-decl.c: New file.
1818 * ctf-types.c: Likewise.
1819 * ctf-impl.h: New declarations.
1821 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1823 * ctf-open-bfd.c: New file.
1824 * ctf-open.c (ctf_close): New.
1825 * ctf-impl.h: Include bfd.h.
1826 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1827 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1829 (ctf_bfdopen_ctfsect): New declaration.
1830 (_CTF_SECTION): likewise.
1832 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1834 * ctf-archive.c: New.
1835 * ctf-impl.h (ctf_archive_internal): New type.
1836 (ctf_arc_open_internal): New declaration.
1837 (ctf_arc_bufopen): Likewise.
1838 (ctf_arc_close_internal): Likewise.
1840 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1842 * ctf-open.c: New file.
1845 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1847 * ctf-create.c: New file.
1848 * ctf-lookup.c: New file.
1850 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1852 * ctf-impl.h: New definitions and declarations for type creation
1855 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1857 * ctf-hash.c: New file.
1858 * ctf-impl.h: New declarations.
1860 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1862 * ctf-error.c: New file.
1864 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1866 * ctf-util.c: New file.
1868 * ctf-impl.h: Include it, and add declarations.
1870 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1872 * ctf-impl.h: New file.
1873 * ctf-subr.c: New file.
1880 version-control: never