libctf/ChangeLog

   1 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
   4         adjusted.
   5         (ctf_fileops): Rename to...
   6         (ctf_dictops): ... this.
   7         (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
   8         <cd_id_to_dict_t>: ... this.
   9         (ctf_file_t): Fix outdated comment.
  10         <ctf_fileops>: Rename to...
  11         <ctf_dictops>: ... this.
  12         (struct ctf_archive_internal) <ctfi_file>: Rename to...
  13         <ctfi_dict>: ... this.
  14         * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
  15         Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
  16         Rename ctf_file_close to ctf_dict_close.  All users adjusted.
  17         * ctf-create.c: Likewise.  Refer to CTF dicts, not CTF containers.
  18         (ctf_bundle_t) <ctb_file>: Rename to...
  19         <ctb_dict): ... this.
  20         * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
  21         * ctf-dedup.c: Likewise.  Rename ctf_file_close to
  22         ctf_dict_close. Refer to CTF dicts, not CTF containers.
  23         * ctf-dump.c: Likewise.
  24         * ctf-error.c: Likewise.
  25         * ctf-hash.c: Likewise.
  26         * ctf-inlines.h: Likewise.
  27         * ctf-labels.c: Likewise.
  28         * ctf-link.c: Likewise.
  29         * ctf-lookup.c: Likewise.
  30         * ctf-open-bfd.c: Likewise.
  31         * ctf-string.c: Likewise.
  32         * ctf-subr.c: Likewise.
  33         * ctf-types.c: Likewise.
  34         * ctf-util.c: Likewise.
  35         * ctf-open.c: Likewise.
  36         (ctf_file_close): Rename to...
  37         (ctf_dict_close): ...this.
  38         (ctf_file_close): New trivial wrapper around ctf_dict_close, for
  39         compatibility.
  40         (ctf_parent_file): Rename to...
  41         (ctf_parent_dict): ... this.
  42         (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
  43         compatibility.
  44         * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
  45
  46 2020-10-21  Tom Tromey  <tromey@adacore.com>
  47
  48         * mkerrors.sed: Remove.
  49         * ctf-error.c (_CTF_FIRST): New define.
  50         (_CTF_ITEM): Define this, not _CTF_STR.
  51         (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
  52         (ERRSTRFIELD): Rewrite.
  53         (ERRSTRFIELD1): Remove.
  54         * Makefile.in: Rebuild.
  55         * Makefile.am (BUILT_SOURCES): Remove.
  56         (ctf-error.h): Remove.
  57
  58 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
  59
  60         * ctf-subr.c (open_errors): New list.
  61         (ctf_err_warn): Calls with NULL fp append to open_errors.  Add err
  62         parameter, and use it to decorate the debug stream with errmsgs.
  63         (ctf_err_warn_to_open): Splice errors from a CTF dict into the
  64         open_errors.
  65         (ctf_errwarning_next): Calls with NULL fp report from open_errors.
  66         New err param to report iteration errors (including end-of-iteration)
  67         when fp is NULL.
  68         (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
  69         parameter: gettextize.
  70         * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
  71         (LCTF_VBYTES): Adjust.
  72         (ctf_err_warn_to_open): New.
  73         (ctf_err_warn): Adjust.
  74         (ctf_bundle): Used in only one place: move...
  75         * ctf-create.c: ... here.
  76         (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
  77         down as needed.  Don't emit the errmsg.  Gettextize.
  78         (membcmp): Likewise.
  79         (ctf_add_type_internal): Likewise.
  80         (ctf_write_mem): Likewise.
  81         (ctf_compress_write): Likewise.  Report errors writing the header or
  82         body.
  83         (ctf_write): Likewise.
  84         * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
  85         ctf_dprintf, and gettextize, as above.
  86         (ctf_arc_write): Likewise.
  87         (ctf_arc_bufopen): Likewise.
  88         (ctf_arc_open_internal): Likewise.
  89         * ctf-labels.c (ctf_label_iter): Likewise.
  90         * ctf-open-bfd.c (ctf_bfdclose): Likewise.
  91         (ctf_bfdopen): Likewise.
  92         (ctf_bfdopen_ctfsect): Likewise.
  93         (ctf_fdopen): Likewise.
  94         * ctf-string.c (ctf_str_write_strtab): Likewise.
  95         * ctf-types.c (ctf_type_resolve): Likewise.
  96         * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
  97         (get_vbytes_v1): Pass down the ctf dict.
  98         (get_vbytes_v2): Likewise.
  99         (flip_ctf): Likewise.
 100         (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
 101         gettextize, as above.
 102         (upgrade_types_v1): Adjust calls.
 103         (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
 104         (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
 105         emitted into individual dicts into the open errors if this turns
 106         out to be a failed open in the end.
 107         * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
 108         argument.  Gettextize.  Don't emit the errmsg.
 109         (ctf_dump_funcs): Likewise.  Collapse err label into its only case.
 110         (ctf_dump_type): Likewise.
 111         * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
 112         argument.  Gettextize.  Don't emit the errmsg.
 113         (ctf_link_one_type): Likewise.
 114         (ctf_link_lazy_open): Likewise.
 115         (ctf_link_one_input_archive): Likewise.
 116         (ctf_link_deduplicating_count_inputs): Likewise.
 117         (ctf_link_deduplicating_open_inputs): Likewise.
 118         (ctf_link_deduplicating_close_inputs): Likewise.
 119         (ctf_link_deduplicating): Likewise.
 120         (ctf_link): Likewise.
 121         (ctf_link_deduplicating_per_cu): Likewise. Add some missed
 122         ctf_set_errnos to obscure error cases.
 123         * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
 124         err argument.  Gettextize.  Don't emit the errmsg.
 125         (ctf_dedup_populate_mappings): Likewise.
 126         (ctf_dedup_detect_name_ambiguity): Likewise.
 127         (ctf_dedup_init): Likewise.
 128         (ctf_dedup_multiple_input_dicts): Likewise.
 129         (ctf_dedup_conflictify_unshared): Likewise.
 130         (ctf_dedup): Likewise.
 131         (ctf_dedup_rwalk_one_output_mapping): Likewise.
 132         (ctf_dedup_id_to_target): Likewise.
 133         (ctf_dedup_emit_type): Likewise.
 134         (ctf_dedup_emit_struct_members): Likewise.
 135         (ctf_dedup_populate_type_mapping): Likewise.
 136         (ctf_dedup_populate_type_mappings): Likewise.
 137         (ctf_dedup_emit): Likewise.
 138         (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
 139         status setting.
 140         (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
 141         unknown-type-kind messages (which signify file corruption).
 142
 143 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 144
 145         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
 146         declare this to be version 1.2.0.
 147         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
 148         * Makefile.in: Regenerated.
 149         * configure: Regenerated.
 150         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
 151         * ctf-impl.h: Include it.
 152         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
 153         (ctf_errmsg): Actually translate them.
 154
 155 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 156
 157         PR binutils/25155:
 158         * ctf-create.c (EOVERFLOW): If not defined by system header,
 159         redirect to ERANGE as a poor man's substitute.
 160         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
 161
 162 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 163
 164         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
 165         (ctf_dtd_delete): Likewise.
 166         (ctf_dtd_lookup): Likewise.
 167         (ctf_rollback): Likewise.
 168         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
 169         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
 170
 171 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 172
 173         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
 174
 175 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 176
 177         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
 178         number if needed.
 179
 180 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 181
 182         * ctf-impl.h (ctf_list_splice): New.
 183         * ctf-util.h (ctf_list_splice): Likewise.
 184         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
 185         (ctf_link_sort_inputs): Likewise.
 186         (ctf_link_deduplicating_count_inputs): Likewise.
 187         (ctf_link_deduplicating_open_inputs): Likewise.
 188         (ctf_link_deduplicating_close_inputs): Likewise.
 189         (ctf_link_deduplicating_variables): Likewise.
 190         (ctf_link_deduplicating_per_cu): Likewise.
 191         (ctf_link_deduplicating): Likewise.
 192         (ctf_link): Call it.
 193
 194 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 195
 196         * ctf-link.c (ctf_link_one_input_archive_member): Check
 197         CTF_LINK_OMIT_VARIABLES_SECTION.
 198
 199 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 200
 201         * ctf-impl.h (ctf_type_id_key): New, the key in the
 202         cd_id_to_file_t.
 203         (ctf_dedup): New, core deduplicator state.
 204         (ctf_file_t) <ctf_dedup>: New.
 205         <ctf_dedup_atoms>: New.
 206         <ctf_dedup_atoms_alloc>: New.
 207         (ctf_hash_type_id_key): New prototype.
 208         (ctf_hash_eq_type_id_key): Likewise.
 209         (ctf_dedup_atoms_init): Likewise.
 210         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
 211         (ctf_dedup_atoms_init): Likewise.
 212         * ctf-create.c (ctf_serialize): Adjusted.
 213         (ctf_add_encoded): No longer static.
 214         (ctf_add_reftype): Likewise.
 215         * ctf-open.c (ctf_file_close): Destroy the
 216         ctf_dedup_atoms_alloc.
 217         * ctf-dedup.c: New file.
 218         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
 219         * configure.ac: Check for stpcpy.
 220         * Makefile.am: Add it.
 221         * Makefile.in: Regenerate.
 222         * config.h.in: Regenerate.
 223         * configure: Regenerate.
 224
 225 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 226
 227         * configure.ac: Add --enable-libctf-hash-debugging.
 228         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
 229         * Makefile.in: Regenerated.
 230         * configure: Likewise.
 231         * config.h.in: Likewise.
 232         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
 233         (ctf_assert): Define to assert.
 234
 235 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 236
 237         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
 238         sha1_process_bytes.
 239         * ctf-impl.h: Include it.
 240         (ctf_sha1_init): New.
 241         (ctf_sha1_add): Likewise.
 242         (ctf_sha1_fini): Likewise.
 243         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 244         producing strings.
 245         * Makefile.am: Add file.
 246         * Makefile.in: Regenerate.
 247
 248 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 249
 250         * libctf.ver (ctf_link_set_variable_filter): Add.
 251         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 252         <ctf_link_variable_filter_arg>: Likewise.
 253         * ctf-create.c (ctf_serialize): Adjust.
 254         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 255         (ctf_link_one_variable): Call it if set.
 256
 257 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 258
 259         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 260         conflicts, not the source type.
 261
 262 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 263
 264         * ctf-impl.h (ctf_file_t): Improve comments.
 265         <ctf_link_cu_mapping>: Split into...
 266         <ctf_link_in_cu_mapping>: ... this...
 267         <ctf_link_out_cu_mapping>: ... and this.
 268         * ctf-create.c (ctf_serialize): Adjust.
 269         * ctf-open.c (ctf_file_close): Likewise.
 270         * ctf-link.c (ctf_create_per_cu): Look things up in the
 271         in_cu_mapping instead of the cu_mapping.
 272         (ctf_link_add_cu_mapping): The deduplicating link will define
 273         what happens if many FROMs share a TO.
 274         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 275         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 276         create per-CU dicts here: they are already created when needed.
 277         (ctf_link_one_variable): Log a debug message if we skip a
 278         variable due to its type being concealed in a CU-mapped link.
 279         (This is probably too common a case to make into a warning.)
 280         (ctf_link): Create empty per-CU dicts if requested.
 281
 282 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 283
 284         * ctf-link.c (ctf_link_write): Close the fd.
 285
 286 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 287
 288         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 289         * Makefile.in: Regenerated.
 290         * ctf-impl.h (ctf_link_input_name): New.
 291         (ctf_file_t) <ctf_link_flags>: New.
 292         * ctf-create.c (ctf_serialize): Adjust accordingly.
 293         * ctf-link.c: Define ctf_open as weak when PIC.
 294         (ctf_arc_close_thunk): Remove unnecessary thunk.
 295         (ctf_file_close_thunk): Likewise.
 296         (ctf_link_input_name): New.
 297         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 298         (ctf_link_input_close): Adjust accordingly.
 299         (ctf_link_add_ctf_internal): New, split from...
 300         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 301         CTF is not possible.  Change to just call...
 302         (ctf_link_add): ... this new function.
 303         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 304         ctf_file_close_thunk.
 305         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 306         <in_file_name>: ... this.
 307         <arcname>: Drop.
 308         <share_mode>: Likewise (migrated to ctf_link_flags).
 309         <done_main_member>: Rename to...
 310         <done_parent>: ... this.
 311         <main_input_fp>: Rename to...
 312         <in_fp_parent>: ... this.
 313         <cu_mapped>: New.
 314         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 315         ctf_err_warn, removing a TODO.
 316         (ctf_link_one_variable): Note a case too common to warn about.
 317         Report in the debug stream if a cu-mapped link prevents addition
 318         of a conflicting variable.
 319         (ctf_link_one_input_archive_member): Adjust.
 320         (ctf_link_lazy_open): New, open a CTF archive for linking when
 321         needed.
 322         (ctf_link_close_one_input_archive): New, close it again.
 323         (ctf_link_one_input_archive): Adjust for lazy opening, member
 324         renames, and ctf_err_warn transition.  Move the
 325         empty_link_type_mapping call to...
 326         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 327         Don't spuriously fail if some input contains no CTF data.
 328         (ctf_link_write): ctf_err_warn transition.
 329         * libctf.ver: Remove not-yet-stable comment.
 330
 331 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 332
 333         * ctf-impl.h (ctf_strerror): Delete.
 334         * ctf-subr.c (ctf_strerror): Likewise.
 335         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 336         strerror directly.
 337
 338 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 339
 340         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 341         (ctf_import_unref): New.
 342         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 343         zero.  Don't recurse back in if the refcount is already zero.
 344         (ctf_import): Check ctf_parent_unreffed before deciding whether
 345         to close a pre-existing parent.  Set it to zero.
 346         (ctf_import_unreffed): New, as above, setting
 347         ctf_parent_unreffed to 1.
 348         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 349         child: use direct assignment, and set unreffed on the new and
 350         old children.
 351         * ctf-link.c (ctf_create_per_cu): Import the parent using
 352         ctf_import_unreffed.
 353
 354 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 355
 356         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 357         (ctf_link_type_key): ... this, adjusting member prefixes to
 358         match.
 359         (ctf_hash_type_mapping_key): Rename to...
 360         (ctf_hash_type_key): ... this.
 361         (ctf_hash_eq_type_mapping_key): Rename to...
 362         (ctf_hash_eq_type_key): ... this.
 363         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 364         (ctf_hash_type_key): ... this, and adjust for member name
 365         changes.
 366         (ctf_hash_eq_type_mapping_key): Rename to...
 367         (ctf_hash_eq_type_key): ... this, and adjust for member name
 368         changes.
 369         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 370         need for out-of-memory checking in this code.
 371         (ctf_type_mapping): Adjust.
 372
 373 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 374
 375         configure.ac: Check for vasprintf.
 376         configure: Regenerated.
 377         config.h.in: Likewise.
 378
 379 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 380
 381         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 382
 383 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 384
 385         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 386         New.
 387         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 388         if the input has no symtab, rather than dividing by
 389         zero. Arrange to free it later via ctfi_free_ctfsect.
 390         * ctf-archive.c (ctf_new_archive_internal): Do not
 391         ctfi_free_strsect by default.
 392         (ctf_arc_close): Possibly free it here.
 393
 394 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 395
 396         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 397         (ctf_dump_format_type): improve slice formatting.  Always print
 398         the type size, even of slices.
 399         (ctf_dump_member): Print slices (-> bitfields) differently from
 400         non-slices.  Failure to format a type is not an OOM.
 401
 402 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 403
 404         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 405         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 406         (ctf_dump_objts): Likewise.
 407         (ctf_dump_var): Likewise.
 408         (ctf_dump_type): Do not emit a duplicate message.  Move to
 409         ctf_err_warning, and swallow all errors.
 410
 411 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 412
 413         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 414         (ctf_decl_buf): Once it escapes, don't try to free it later.
 415
 416 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 417
 418         * ctf-types.c (ctf_type_aname): Print arg types here...
 419         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 420         in the type name here.
 421
 422 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 423
 424         * ctf-impl.h (ctf_assert): New.
 425         (ctf_err_warning_t): Likewise.
 426         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 427         (ctf_err_warn): New prototype.
 428         (ctf_assert_fail_internal): Likewise.
 429         * ctf-inlines.h (ctf_assert_internal): Likewise.
 430         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 431         * ctf-create.c (ctf_serialize): Copy it on serialization.
 432         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 433         (ctf_errwarning_next): New iterator, free and pass back
 434         errors/warnings in succession.
 435         * libctf.ver (ctf_errwarning_next): Add.
 436
 437 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 438
 439         * ctf-types.c (ctf_variable_iter): Fix error return.
 440
 441 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 442
 443         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 444
 445 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 446
 447         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 448
 449 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 450
 451         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 452         sorting functions.
 453         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 454         ctf_dynhash_next_sorted.
 455         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 456         <cu.ctn_s>: New, pointer to the dynset under iteration.
 457         (ctf_hash_sort_f): Sorting function passed to...
 458         (ctf_dynhash_next_sorted): ... this new function.
 459         (ctf_dynhash_next): New.
 460         (ctf_dynset_next): New.
 461         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 462         (ctf_dynhash_cnext): New.
 463         (ctf_dynset_cnext): New.
 464         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 465         (ctf_dynhash_next): New.
 466         (ctf_dynset_next): New.
 467         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 468         needed.
 469         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 470
 471 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 472
 473         * ctf-impl.h (ctf_next): New.
 474         (ctf_get_dict): New prototype.
 475         * ctf-lookup.c (ctf_get_dict): New, split out of...
 476         (ctf_lookup_by_id): ... here.
 477         * ctf-util.c (ctf_next_create): New.
 478         (ctf_next_destroy): New.
 479         (ctf_next_copy): New.
 480         * ctf-types.c (includes): Add <assert.h>.
 481         (ctf_member_next): New.
 482         (ctf_enum_next): New.
 483         (ctf_type_iter): Document the lack of iteration over parent
 484         types.
 485         (ctf_type_next): New.
 486         (ctf_variable_next): New.
 487         * ctf-archive.c (ctf_archive_next): New.
 488         * libctf.ver: Add new public functions.
 489
 490 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 491
 492         * libctf.ver (ctf_ref): New.
 493         * ctf-open.c (ctf_ref): Implement it.
 494
 495 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 496
 497         * ctf-inlines.h (ctf_forwardable_kind): New.
 498         * ctf-create.c (ctf_add_forward): Use it.
 499
 500 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 501
 502         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 503         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 504
 505 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 506
 507         * ctf-hash.c (ctf_dynset_eq_string): New.
 508         (ctf_dynset_create): New.
 509         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 510         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 511         (key_to_internal): New.
 512         (internal_to_key): New.
 513         (ctf_dynset_insert): New.
 514         (ctf_dynset_remove): New.
 515         (ctf_dynset_destroy): New.
 516         (ctf_dynset_lookup): New.
 517         (ctf_dynset_exists): New.
 518         (ctf_dynset_lookup_any): New.
 519         (ctf_hash_insert_type): Coding style.
 520         (ctf_hash_define_type): Likewise.
 521         * ctf-impl.h (ctf_dynset_t): New.
 522         (ctf_dynset_eq_string): New.
 523         (ctf_dynset_create): New.
 524         (ctf_dynset_insert): New.
 525         (ctf_dynset_remove): New.
 526         (ctf_dynset_destroy): New.
 527         (ctf_dynset_lookup): New.
 528         (ctf_dynset_exists): New.
 529         (ctf_dynset_lookup_any): New.
 530         * ctf-inlines.h (ctf_dynset_cinsert): New.
 531
 532 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 533
 534         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 535         <value_free>: Likewise.
 536         <owner>: New.
 537         (ctf_dynhash_item_free): Indirect through the owner.
 538         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 539         allocate space for the key_free and value_free fields fields
 540         if necessary.
 541         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 542         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 543         value_free if they will exist.  Set the slot's owner, but only
 544         if it exists.
 545         (ctf_dynhash_remove): Adjust.
 546
 547 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 548
 549         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 550         there is a key-freeing function and the key already exists.
 551
 552 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 553
 554         * ctf-inlines.h: New file.
 555         * ctf-impl.h: Include it.
 556         (ctf_hash_iter_find_f): New typedef.
 557         (ctf_dynhash_elements): New.
 558         (ctf_dynhash_lookup_kv): New.
 559         (ctf_dynhash_iter_find): New.
 560         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 561         (ctf_traverse_find_cb_arg_t): New.
 562         (ctf_hashtab_traverse_find): New.
 563         (ctf_dynhash_iter_find): New.
 564         (ctf_dynhash_elements): New.
 565
 566 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 567
 568         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 569
 570 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 571
 572         * ctf-archive.c (ctf_archive_count): New.
 573         * libctf.ver: New public function.
 574
 575 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 576
 577         * ctf-types.c (ctf_member_count): New.
 578         * libctf.ver: New public function.
 579
 580 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 581
 582         * ctf-types.c (ctf_type_kind_forwarded): New.
 583
 584 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 585
 586         * ctf-types.c (ctf_type_name_raw): New.
 587         (ctf_type_aname_raw): Reimplement accordingly.
 588
 589 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 590
 591         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 592
 593 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 594
 595         * ctf-impl.h (struct ctf_archive_internal)
 596         <ctfi_unmap_on_close>: New.
 597         (ctf_new_archive_internal): Adjust.
 598         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 599         Initialize ctfi_unmap_on_close.  Adjust error path.
 600         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 601         (unmap_on_close is 0).
 602         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 603         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 604
 605 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 606
 607         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 608         ints, floats or typedefs have no name.  Fix comment typo.
 609
 610 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 611
 612         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 613         resolves to an integral type.
 614         * ctf-types.c (ctf_type_encoding): Resolve the type before
 615         fishing its encoding out.
 616
 617 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 618
 619         * ctf-create.c (ctf_create): Mark dirty.
 620
 621 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 622
 623         * ctf-create.c (membcmp)  Skip nameless members.
 624
 625 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 626
 627         * ctf-create.c (ctf_add_member_offset): Support names of ""
 628         as if they were the null pointer.
 629
 630 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 631
 632         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 633         special-casing.
 634
 635 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 636
 637         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 638
 639 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 640
 641         * ctf-create.c (ctf_serialize): Add cast.
 642         (ctf_add_slice): Likewise.
 643
 644 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 645
 646         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 647         * ctf-create.c (ctf_add_function): Check for unimplemented type
 648         and populate at the same time.  Populate one-by-one, not via
 649         memcpy.
 650         (ctf_serialize): Remove unnecessary cast.
 651         * ctf-types.c (ctf_func_type_info): Likewise.
 652         (ctf_func_type_args): Likewise.  Fix comment typo.
 653
 654 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 655
 656         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 657         (ctf_add_array): Support array contents of type zero.
 658         (ctf_add_function): Support arguments and return types of
 659         type zero.
 660         (ctf_add_typedef): Support typedefs to type zero.
 661         (ctf_add_member_offset): Support members of type zero,
 662         unless added at unspecified (naturally-aligned) offset.
 663
 664 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 665
 666         * ctf-error.c: Include <stddef.h>, for offsetof.
 667         (_ctf_errlist): Migrate to...
 668         (_ctf_errlist_t): ... this.
 669         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 670         (_ctf_nerr): Remove.
 671         (ctf_errmsg): Adjust accordingly.
 672         * Makefile.am (BUILT_SOURCES): Note...
 673         (ctf-error.h): ... this new rule.
 674         * Makefile.in: Regenerate.
 675         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 676         * .gitignore: New, ignore ctf-error.h.
 677
 678 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 679
 680         * ctf-impl.h: Fix typos in comments.
 681
 682 2020-07-22  Nick Clifton  <nickc@redhat.com>
 683
 684         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 685         same file descriptor.
 686
 687 2020-07-04  Nick Clifton  <nickc@redhat.com>
 688
 689         Binutils 2.35 branch created.
 690
 691 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 692
 693         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 694         alphabetical order.
 695         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 696         * config.h.in: Regenerated.
 697         * Makefile.in: Likewise.
 698         * configure: Likewise.
 699
 700 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 701
 702         * ctf-create.c: Include <unistd.h>.
 703         * ctf-open-bfd.c: Likewise.
 704
 705 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 706
 707         PR libctf/25120
 708         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 709         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 710         means this is declared.
 711         (bswap_32): Likewise.
 712         (bswap_64): Likewise.
 713         (bswap_identity_64): Remove, unused.
 714         * configure: Regenerated.
 715         * config.h.in: Likewise.
 716
 717 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 718
 719         PR libctf/25120
 720         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 721         (_libctf_unlikely_): Likewise.
 722         (_libctf_unused): Likewise.
 723         (_libctf_malloc_): Likewise.
 724
 725 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 726
 727         PR libctf/25120
 728         * ctf-archive.c (search_nametbl): No longer global: declare...
 729         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 730         (search_modent_by_name): Take and use ARG for the nametbl.
 731
 732 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 733
 734         * ctf-impl.h (ctf_new_archive_internal): Declare.
 735         (ctf_arc_bufopen): Remove.
 736         (ctf_archive_internal) <ctfi_free_symsect>: New.
 737         * ctf-archive.c (ctf_arc_close): Use it.
 738         (ctf_arc_bufopen): Fuse into...
 739         (ctf_new_archive_internal): ... this, moved across from...
 740         * ctf-open-bfd.c: ... here.
 741         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 742         * libctf.ver: Add it.
 743
 744 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 745
 746         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 747         (ctf_dtd_delete): Remove correspondingly.
 748         (ctf_rollback): Likewise.
 749
 750 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 751
 752         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 753         unchanged.
 754
 755 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 756
 757         * ctf-create.c (ctf_add_forward): Don't add forwards to
 758         types that already exist.
 759
 760 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 761
 762         * ctf-open.c (init_types): Only intern root-visible types.
 763         * ctf-create.c (ctf_dtd_insert): Likewise.
 764         (ctf_dtd_delete): Only remove root-visible types.
 765         (ctf_rollback): Likewise.
 766         (ctf_add_generic): Adjust.
 767         (ctf_add_struct_sized): Adjust comment.
 768         (ctf_add_union_sized): Likewise.
 769         (ctf_add_enum): Likewise.
 770         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 771
 772 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 773
 774         * swap.h (bswap_identity_64): Make static.
 775
 776 2020-01-18  Nick Clifton  <nickc@redhat.com>
 777
 778         Binutils 2.34 branch created.
 779
 780 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 781
 782         PR binutils/25155:
 783         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 784         * configure, config.h.in: Regenerate.
 785
 786 2020-01-01  Alan Modra  <amodra@gmail.com>
 787
 788         Update year range in copyright notice of all files.
 789
 790 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 791
 792         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 793
 794 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 795
 796         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 797         * ctf-types.c (ctf_type_lname): Likewise.
 798
 799 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 800
 801         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 802         ctf_import after the first for a given file.
 803
 804 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 805
 806         * ctf-impl.h (ctf_str_append_noerr): Declare.
 807         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 808         ctf_str_append.
 809         * ctf-dump.c (str_append): New, call it.
 810         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 811         (ctf_dump_label): Likewise.
 812         (ctf_dump_objts): Likewise.
 813         (ctf_dump_funcs): Likewise.
 814         (ctf_dump_var): Likewise.
 815         (ctf_dump_member): Likewise.
 816         (ctf_dump_type): Likewise.
 817         (ctf_dump): Likewise.
 818
 819 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 820
 821         * ctf-impl.h (ctf_alloc): Remove.
 822         (ctf_free): Likewise.
 823         (ctf_strdup): Likewise.
 824         * ctf-subr.c (ctf_alloc): Remove.
 825         (ctf_free): Likewise.
 826         * ctf-util.c (ctf_strdup): Remove.
 827
 828         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 829         ctf_free; strdup, not ctf_strdup.
 830         (ctf_dtd_delete): Likewise.
 831         (ctf_dvd_delete): Likewise.
 832         (ctf_add_generic): Likewise.
 833         (ctf_add_function): Likewise.
 834         (ctf_add_enumerator): Likewise.
 835         (ctf_add_member_offset): Likewise.
 836         (ctf_add_variable): Likewise.
 837         (membadd): Likewise.
 838         (ctf_compress_write): Likewise.
 839         (ctf_write_mem): Likewise.
 840         * ctf-decl.c (ctf_decl_push): Likewise.
 841         (ctf_decl_fini): Likewise.
 842         (ctf_decl_sprintf): Likewise.  Check for OOM.
 843         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 844         ctf_free; strdup, not ctf_strdup.
 845         (ctf_dump_free): Likewise.
 846         (ctf_dump): Likewise.
 847         * ctf-open.c (upgrade_types_v1): Likewise.
 848         (init_types): Likewise.
 849         (ctf_file_close): Likewise.
 850         (ctf_bufopen_internal): Likewise.  Check for OOM.
 851         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 852         (ctf_cuname_set): Likewise.
 853         (ctf_import): Likewise.
 854         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 855         free, not ctf_free; strdup, not ctf_strdup.
 856         (ctf_str_free_atom): Likewise.
 857         (ctf_str_create_atoms): Likewise.
 858         (ctf_str_add_ref_internal): Likewise.
 859         (ctf_str_remove_ref): Likewise.
 860         (ctf_str_write_strtab): Likewise.
 861
 862 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 863
 864         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 865         work right for non-int/fps.
 866
 867 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 868
 869         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 870         null pointer.
 871
 872 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 873
 874         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 875         * ctf-open.c (ctf_file_close): Free it.
 876         * ctf-create.c (ctf_serialize): Adjust.
 877         (membcmp): When reporting a conflict due to an error, report the
 878         error.
 879         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 880         (ctf_add_type_internal): ... this.  Hand back types we are already
 881         in the middle of adding immediately.  Hand back structs/unions with
 882         the same number of members immediately.  Do not walk the dynamic
 883         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 884         forwards promoted to other types and the inverse case identically.
 885         Add structs to the mapping as soon as we intern them, before they
 886         gain any members.
 887
 888 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 889
 890         * ctf-impl.h (ctf_names_t): New.
 891         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 892         (ctf_file_t) <ctf_structs>: Likewise.
 893         <ctf_unions>: Likewise.
 894         <ctf_enums>: Likewise.
 895         <ctf_names>: Likewise.
 896         <ctf_lookups>: Improve comment.
 897         <ctf_ptrtab_len>: New.
 898         <ctf_prov_strtab>: New.
 899         <ctf_str_prov_offset>: New.
 900         <ctf_dtbyname>: Remove, redundant to the names hashes.
 901         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 902         (ctf_dtdef_t) <dtd_name>: Remove.
 903         <dtd_data>: Note that the ctt_name is now populated.
 904         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 905         offset for internal strings too.
 906         <csa_external_offset>: New, the external strtab offset.
 907         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 908         (ctf_name_table): New declaration.
 909         (ctf_lookup_by_rawname): Likewise.
 910         (ctf_lookup_by_rawhash): Likewise.
 911         (ctf_set_ctl_hashes): Likewise.
 912         (ctf_serialize): Likewise.
 913         (ctf_dtd_insert): Adjust.
 914         (ctf_simple_open_internal): Likewise.
 915         (ctf_bufopen_internal): Likewise.
 916         (ctf_list_empty_p): Likewise.
 917         (ctf_str_remove_ref): Likewise.
 918         (ctf_str_add): Returns uint32_t now.
 919         (ctf_str_add_ref): Likewise.
 920         (ctf_str_add_external): Now returns a boolean (int).
 921         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 922         for strings in the appropriate range.
 923         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 924         when adding the null string to the new strtab.
 925         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 926         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 927         make_provisional, populate the offset and fill in the
 928         ctf_prov_strtab accordingly.
 929         (ctf_str_add): Return the offset, not the string.
 930         (ctf_str_add_ref): Likewise.
 931         (ctf_str_add_external): Return a success integer.
 932         (ctf_str_remove_ref): New, remove a single ref.
 933         (ctf_str_count_strtab): Do not count the initial null string's
 934         length or the existence or length of any unreferenced internal
 935         atoms.
 936         (ctf_str_populate_sorttab): Skip atoms with no refs.
 937         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 938         to the cts_len for the null string, since it is no longer done
 939         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 940         Populate the csa_offset for both internal and external cases.
 941         Flush the ctf_prov_strtab afterwards, and reset the
 942         ctf_str_prov_offset.
 943         * ctf-create.c (ctf_grow_ptrtab): New.
 944         (ctf_create): Call it.  Initialize new fields rather than old
 945         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 946         Set the ctl hashes and data model.
 947         (ctf_update): Rename to...
 948         (ctf_serialize): ... this.  Leave a compatibility function behind.
 949         Tell ctf_simple_open_internal that this is a writable dictionary.
 950         Pass the new fields along from the old dictionary.  Drop
 951         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 952         Do not zero out the DTD's ctt_name.
 953         (ctf_prefixed_name): Rename to...
 954         (ctf_name_table): ... this.  No longer return a prefixed name: return
 955         the applicable name table instead.
 956         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 957         kind we're adding.  Migrate away from dtd_name.
 958         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 959         deleted ctt_name.
 960         (ctf_dtd_lookup_type_by_name): Remove.
 961         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 962         No longer check ctf_dtnextid: check ctf_typemax instead.
 963         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 964         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 965         ctf_name_table and the right name table, and migrate away from
 966         dtd_name as in ctf_dtd_delete.
 967         (ctf_add_generic): Pass in the kind explicitly and pass it to
 968         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 969         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 970         Grow the ptrtab if needed.
 971         (ctf_add_encoded): Pass in the kind.
 972         (ctf_add_slice): Likewise.
 973         (ctf_add_array): Likewise.
 974         (ctf_add_function): Likewise.
 975         (ctf_add_typedef): Likewise.
 976         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 977         ctt_name rather than dtd_name.
 978         (ctf_add_struct_sized): Pass in the kind.  Use
 979         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 980         ctf_dtd_lookup_type_by_name.
 981         (ctf_add_union_sized): Likewise.
 982         (ctf_add_enum): Likewise.
 983         (ctf_add_enum_encoded): Likewise.
 984         (ctf_add_forward): Likewise.
 985         (ctf_add_type): Likewise.
 986         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 987         being initialized until after the call.
 988         (ctf_write_mem): Likewise.
 989         (ctf_write): Likewise.
 990         * ctf-archive.c (arc_write_one_ctf): Likewise.
 991         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 992         ctf_hash_lookup_type.
 993         (ctf_lookup_by_id): No longer check the readonly types if the
 994         dictionary is writable.
 995         * ctf-open.c (init_types): Assert that this dictionary is not
 996         writable.  Adjust to use the new name hashes, ctf_name_table,
 997         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 998         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 999         if set.  Drop out early when dictionary is writable.  Split the
1000         ctf_lookups initialization into...
1001         (ctf_set_cth_hashes): ... this new function.
1002         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
1003         (ctf_simple_open): Adjust accordingly.
1004         (ctf_bufopen): Likewise.
1005         (ctf_file_close): Destroy the appropriate name hashes.  No longer
1006         destroy ctf_dtbyname, which is gone.
1007         (ctf_getdatasect): Remove spurious "extern".
1008         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1009         specified name table, given a kind.
1010         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1011         (ctf_member_iter): Add support for iterating over the
1012         dynamic type list.
1013         (ctf_enum_iter): Likewise.
1014         (ctf_variable_iter): Likewise.
1015         (ctf_type_rvisit): Likewise.
1016         (ctf_member_info): Add support for types in the dynamic type list.
1017         (ctf_enum_name): Likewise.
1018         (ctf_enum_value): Likewise.
1019         (ctf_func_type_info): Likewise.
1020         (ctf_func_type_args): Likewise.
1021         * ctf-link.c (ctf_accumulate_archive_names): No longer call
1022         ctf_update.
1023         (ctf_link_write): Likewise.
1024         (ctf_link_intern_extern_string): Adjust for new
1025         ctf_str_add_external return value.
1026         (ctf_link_add_strtab): Likewise.
1027         * ctf-util.c (ctf_list_empty_p): New.
1028
1029 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
1030
1031         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1032         type zero.
1033         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1034         members and types.
1035         (ctf_add_variable): Likewise for variables pointing to them.
1036         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1037         type link failure, but do warn for others.
1038         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
1039         errors to be ENOMEM.
1040         (ctf_dump_member): Likewise.
1041         (ctf_dump_type): Likewise.
1042         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1043         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1044         (ctf_dump_header): Likewise.
1045         (ctf_dump_label): likewise.
1046         (ctf_dump_objts): likewise.
1047         (ctf_dump_funcs): likewise.
1048         (ctf_dump_var): likewise.
1049         (ctf_dump_str): Likewise.
1050
1051 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
1052
1053         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1054         (LT_INIT): Likewise.
1055         (AM_INSTALL_LIBBFD): Likewise.
1056         (dlopen): Note why this is necessary in a comment.
1057         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1058         opcodes/.
1059         (SHARED_LDFLAGS): Likewise.
1060         (BFD_LIBADD): Likewise, for libbfd.
1061         (BFD_DEPENDENCIES): Likewise.
1062         (VERSION_FLAGS): Initialize, using a version script if ld supports
1063         one, or libtool -export-symbols-regex otherwise.
1064         (AC_CONFIG_MACRO_DIR): Add ../BFD.
1065         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1066         (INCDIR): New.
1067         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1068         (noinst_LIBRARIES): Replace with...
1069         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1070         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1071         libctf-nobfd.la as well.
1072         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1073         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1074         (libctf_a_SOURCES): Rename to...
1075         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1076         ctf-open-bfd.c.
1077         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1078         with ctf-open-bfd.c added.
1079         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1080         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1081         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1082         * Makefile.am [INSTALL_LIBCTF]: Use it.
1083         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1084         libtool macros.
1085         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1086         the unstable components).
1087         * Makefile.in: Regenerated.
1088         * config.h.in: Likewise.
1089         * configure: Likewise.
1090
1091 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1092
1093         * configure.ac (INSTALL_LIBCTF): New, controlled by
1094         --enable-install-libctf.
1095         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1096         * Makefile.in: Regenerated.
1097         * configure: Regenerated.
1098
1099 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1100
1101         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1102         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1103
1104 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1105
1106         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1107
1108 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1109
1110         * ctf-impl.h (includes): Include <sys/param.h> here.
1111
1112 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1113
1114         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1115         (flip_objts): Likewise.
1116         (flip_vars): Likewise.
1117         (flip_types): Likewise.
1118
1119 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1120
1121         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1122         freeing functions: if set, free the key and value if the slot
1123         already exists.  Always reassign the key.
1124         (ctf_dynhash_insert): Adjust call appropriately.
1125         (ctf_hash_insert_type): Likewise.
1126
1127 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
1128
1129         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1130         type kind.  Allow forwards to unify with pre-existing structs/
1131         unions/enums.
1132
1133 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1134
1135         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1136         <ctf_link_memb_name_changer>: Likewise.
1137         <ctf_link_memb_name_changer_arg>: Likewise.
1138         * ctf-create.c (ctf_update): Update accordingly.
1139         * ctf-open.c (ctf_file_close): Likewise.
1140         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1141         (ctf_link_add_cu_mapping): New.
1142         (ctf_link_set_memb_name_changer): Likewise.
1143         (ctf_change_parent_name): New.
1144         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1145         allocated by the caller's ctf_link_memb_name_changer.
1146         <ndynames>: Likewise.
1147         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1148         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1149         ctf_change_parent_name.  Free any resulting names.
1150
1151 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1152
1153         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1154         (ctf_link_one_type): ... here, with parent-name setting added.
1155         (check_variable): New.
1156         (ctf_link_one_variable): Likewise.
1157         (ctf_link_one_input_archive_member): Call it.
1158         * ctf-error.c (_ctf_errlist): Updated with new errors.
1159
1160 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1161
1162         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1163         (struct ctf_link_type_mapping_key): New.
1164         (ctf_hash_type_mapping_key): Likewise.
1165         (ctf_hash_eq_type_mapping_key): Likewise.
1166         (ctf_add_type_mapping): Likewise.
1167         (ctf_type_mapping): Likewise.
1168         (ctf_dynhash_empty): Likewise.
1169         * ctf-open.c (ctf_file_close): Update accordingly.
1170         * ctf-create.c (ctf_update): Likewise.
1171         (ctf_add_type): Populate the mapping.
1172         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1173         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1174         (ctf_dynhash_insert): Fix comment typo.
1175         (ctf_dynhash_empty): New.
1176         * ctf-link.c (ctf_add_type_mapping): New.
1177         (ctf_type_mapping): Likewise.
1178         (empty_link_type_mapping): New.
1179         (ctf_link_one_input_archive): Call it.
1180
1181 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1182
1183         * ctf-link.c: New file, linking of the string and type sections.
1184         * Makefile.am (libctf_a_SOURCES): Add it.
1185         * Makefile.in: Regenerate.
1186
1187         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1188         ctf_link_outputs.
1189         * ctf-create.c (ctf_update): Update accordingly.
1190         * ctf-open.c (ctf_file_close): Likewise.
1191         * ctf-error.c (_ctf_errlist): Updated with new errors.
1192
1193 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1194
1195         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1196
1197 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1198
1199         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1200         ctf_type_iter.
1201         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1202         (ctf_dump_format_type): Add non-root-type { } notation.
1203         Add root flag to prototype.
1204         (ctf_dump_label): Adjust accordingly.
1205         (ctf_dump_objts): Likewise.
1206         (ctf_dump_var): Likewise.
1207
1208 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1209
1210         * ctf-create.c (ctf_compress_write): Fix double-free.
1211
1212 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1213
1214         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1215         of...
1216         (ctf_arc_write_fd): ... this new function.
1217         * ctf-create.c (ctf_write_mem): New.
1218
1219 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1220
1221         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1222         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1223         (ctf_str_add_ref): Name the last arg.
1224         (ctf_str_add_external) New.
1225         (ctf_str_add_strraw_explicit): Likewise.
1226         (ctf_simple_open_internal): Likewise.
1227         (ctf_bufopen_internal): Likewise.
1228
1229         * ctf-string.c (ctf_strraw_explicit): Split from...
1230         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1231         (ctf_str_add_ref_internal): Return the atom, not the
1232         string.
1233         (ctf_str_add): Adjust accordingly.
1234         (ctf_str_add_ref): Likewise.  Move up in the file.
1235         (ctf_str_add_external): New: update the csa_offset.
1236         (ctf_str_count_strtab): Only account for strings with no csa_offset
1237         in the internal strtab length.
1238         (ctf_str_write_strtab): If the csa_offset is set, update the
1239         string's refs without writing the string out, and update the
1240         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1241         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1242         (ctf_update): Handle failure to populate the strtab.  Pass in the
1243         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1244         Call ctf_simple_open_internal, not ctf_simple_open.
1245         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1246         strings by hand.
1247         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1248         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1249         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1250         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1251         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1252         (ctf_simple_open_internal): ... this new function, which calls
1253         ctf_bufopen_internal.
1254         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1255         (ctf_bufopen_internal): ... this new function, which sets
1256         ctf_syn_ext_strtab.
1257
1258 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1259
1260         * ctf_types.c (ctf_type_iter_all): New.
1261
1262 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1263
1264         * ctf-open.c (init_symtab): Check for overflow against the right
1265         section.
1266         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1267         (upgrade_types_v1): Note that these sections are not checked.
1268         (flip_header): Endian-swap the header fields.
1269         (flip_ctf): Endian-swap the sections.
1270         (flip_objts): Update comment.
1271         (ctf_bufopen): Check header offsets and alignment for validity.
1272
1273 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1274
1275         * ctf-open-bfd.c: Add <assert.h>.
1276         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1277         techniques borrowed from bfd_elf_sym_name.
1278         (ctf_new_archive_internal): Improve comment.
1279         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1280         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1281         no symbol section, but not vice versa.
1282
1283 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1284
1285         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1286         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1287         * ctf-dump.c (dump_header): New function, dump the CTF header.
1288         (ctf_dump): Call it.
1289         (ctf_dump_header_strfield): New function.
1290         (ctf_dump_header_sectfield): Likewise.
1291
1292 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1293
1294         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1295         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1296         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1297         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1298         Print out ctf_cuname: only print out ctf_parname if set.
1299         (ctf_free_base): Removed, ctf_base is no longer freed: free
1300         ctf_dynbase instead.
1301         (ctf_set_version): Fix spacing.
1302         (upgrade_header): New, in-place header upgrading.
1303         (upgrade_types): Rename to...
1304         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1305         longer track old and new headers separately.  No longer allow for
1306         header sizes explicitly: squeeze the headers out on upgrade (they
1307         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1308         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1309         (upgrade_types): New, also handle ctf_parmax updating.
1310         (flip_header): Flip ctf_cuname.
1311         (flip_types): Flip BUF explicitly rather than deriving BUF from
1312         BASE.
1313         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1314         required alignment of objtoff and funcoff.  No longer store it in
1315         the ctf_buf unless that buf is derived unmodified from the input.
1316         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1317         that duplicate fields in ctf_file: move allocation of ctf_file
1318         further up instead.  Call upgrade_header as needed.  Move
1319         version-specific ctf_parmax initialization into upgrade_types.  More
1320         concise error handling.
1321         (ctf_file_close): No longer test for null pointers before freeing.
1322         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1323         ctf_free_base.
1324         (ctf_cuname): New.
1325         (ctf_cuname_set): New.
1326         * ctf-create.c (ctf_update): Populate ctf_cuname.
1327         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1328         comment.
1329         (ctf_write): Likewise.
1330         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1331         Fix the compression length: fp->ctf_size never counted the CTF
1332         header.  Simplify the compress call accordingly.
1333
1334 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1335
1336         * ctf-endian.h: Don't assume htole64 and le64toh are always
1337         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1338         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1339         not bswap_identity_64.
1340
1341 2019-09-18  Alan Modra  <amodra@gmail.com>
1342
1343         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1344
1345 2019-09-09  Phil Blundell  <pb@pbcl.net>
1346
1347         binutils 2.33 branch created.
1348
1349 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1350
1351         * ctf-types.c (ctf_type_aname_raw): New.
1352         (ctf_func_type_info): Likewise.
1353         (ctf_func_type_args): Likewise.
1354         * ctf-error.c (_ctf_errlist): Fix description.
1355         * ctf-lookup.c: Fix file description.
1356
1357 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1358
1359         * ctf-create.c (ctf_create): Fix off-by-one error.
1360
1361 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1362
1363         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1364         struct ctf_strs.
1365         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1366         (struct ctf_str_atom): New, disambiguated single string.
1367         (struct ctf_str_atom_ref): New, points to some other location that
1368         references this string's offset.
1369         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1370         Remove member ctf_dtvstrlen: we no longer track the total strlen
1371         as we add strings.
1372         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1373         (ctf_str_free_atoms): Likewise.
1374         (ctf_str_add): Likewise.
1375         (ctf_str_add_ref): Likewise.
1376         (ctf_str_rollback): Likewise.
1377         (ctf_str_purge_refs): Likewise.
1378         (ctf_str_write_strtab): Likewise.
1379         (ctf_realloc): Declare new function in ctf-util.c.
1380
1381         * ctf-open.c (ctf_bufopen): Create the atoms table.
1382         (ctf_file_close): Destroy it.
1383         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1384         special-case the position of the parname string.  Construct the
1385         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1386         rest of each buffer element is constructed, not via open-coding:
1387         realloc the CTF buffer and append the strtab to it.  No longer
1388         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1389         strtab construction.
1390         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1391         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1392         after buffer element construction instead.
1393         (ctf_copy_lmembers): Likewise.
1394         (ctf_copy_emembers): Likewise.
1395         (ctf_create): No longer maintain the ctf_dtvstrlen.
1396         (ctf_dtd_delete): Likewise.
1397         (ctf_dvd_delete): Likewise.
1398         (ctf_add_generic): Likewise.
1399         (ctf_add_enumerator): Likewise.
1400         (ctf_add_member_offset): Likewise.
1401         (ctf_add_variable): Likewise.
1402         (membadd): Likewise.
1403         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1404         if there are active ctf_str_num_refs.
1405         (ctf_strraw): Move to ctf-string.c.
1406         (ctf_strptr): Likewise.
1407         * ctf-string.c: New file, strtab manipulation.
1408
1409         * Makefile.am (libctf_a_SOURCES): Add it.
1410         * Makefile.in: Regenerate.
1411
1412 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1413
1414         * ctf-impl.h (ctf_hash_iter_f): New.
1415         (ctf_dynhash_iter): New declaration.
1416         (ctf_dynhash_iter_remove): New declaration.
1417         * ctf-hash.c (ctf_dynhash_iter): Define.
1418         (ctf_dynhash_iter_remove): Likewise.
1419         (ctf_hashtab_traverse): New.
1420         (ctf_hashtab_traverse_remove): Likewise.
1421         (struct ctf_traverse_cb_arg): Likewise.
1422         (struct ctf_traverse_remove_cb_arg): Likewise.
1423
1424 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1425
1426         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1427
1428 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1429
1430         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1431         (ctf_dump_funcs): Likewise.
1432
1433 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1434
1435         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1436         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1437         little-endian CTF archive magic.  Do not check the CTF version:
1438         ctf_simple_open does that in endian-safe ways.  Do not dereference
1439         null pointers on open failure.
1440
1441 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1442
1443         * ctf-open.c (get_vbytes_common): Return the new slice size.
1444         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1445         Remember to copy in the CTF data when opening an uncompressed
1446         foreign-endian CTF file.  Prune useless variable manipulation.
1447
1448 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1449
1450         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1451         seen.
1452
1453 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1454
1455         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1456         output.
1457
1458 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1459
1460         * ctf-subr.c (_PAGESIZE): Remove.
1461         (ctf_data_alloc): Likewise.
1462         (ctf_data_free): Likewise.
1463         (ctf_data_protect): Likewise.
1464         * ctf-impl.h: Remove declarations.
1465         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1466         ctf_free, not ctf_data_free.
1467         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1468         the buffer again on compression error.
1469         * ctf-open.c (ctf_set_base): No longer track the size: call
1470         ctf_free, not ctf_data_free.
1471         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1472         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1473
1474 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1475
1476         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1477         ctf_dynhash_insert.
1478         (ctf_dvd_insert): Likewise.
1479         (ctf_add_generic): Likewise.
1480         (ctf_add_variable): Likewise.
1481         * ctf-impl.h: Adjust declarations.
1482
1483 2019-06-14  Alan Modra  <amodra@gmail.com>
1484
1485         * configure: Regenerate.
1486
1487 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1488
1489         * ctf-decls.h: Include <libiberty.h>.
1490         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1491
1492 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1493
1494         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1495         (ctf_dump_objts): Likewise.
1496         (ctf_dump_funcs): Likewise.
1497         (ctf_dump_member): Likewise.
1498         (ctf_dump_str): Likewise.
1499
1500 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1501
1502         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1503         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1504
1505 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1506
1507         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1508         (ctf_arc_open_by_offset): Likewise.
1509         * ctf-create.c (ctf_add_type): Likewise.
1510
1511 2019-06-04  Tom Tromey  <tromey@adacore.com>
1512
1513         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1514         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1515
1516 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1517
1518         * configure.ac: Check for O_CLOEXEC.
1519         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1520         * config.h.in: Regenerate.
1521         * configure: Likewise.
1522
1523 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1524
1525         * qsort_r.c: Rename to...
1526         * ctf-qsort_r.c: ... this.
1527         (_quicksort): Define to ctf_qsort_r.
1528         * ctf-decls.h (qsort_r): Remove.
1529         (ctf_qsort_r): Add.
1530         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1531         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1532         * Makefile.am (libctf_a_LIBADD): Remove.
1533         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1534         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1535         * ctf-create.c (ctf_update): Likewise.
1536         * configure.ac: Check for BSD versus GNU qsort_r signature.
1537         * Makefile.in: Regenerate.
1538         * config.h.in: Likewise.
1539         * configure: Likewise.
1540
1541 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1542
1543         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1544
1545 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1546
1547         * Makefile.am (ZLIB): New.
1548         (ZLIBINC): Likewise.
1549         (AM_CFLAGS): Use them.
1550         (libctf_a_LIBADD): New, for LIBOBJS.
1551         * configure.ac: Check for zlib, endian.h, and qsort_r.
1552         * ctf-endian.h: New, providing htole64 and le64toh.
1553         * swap.h: Code style fixes.
1554         (bswap_identity_64): New.
1555         * qsort_r.c: New, from gnulib (with one added #include).
1556         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1557         and unconditional definitions of MIN and MAX.
1558         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1559         (ctf_set_errno): Now returns unsigned long.
1560         * ctf-util.c (ctf_set_errno): Adjust here too.
1561         * ctf-archive.c: Use ctf-endian.h.
1562         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1563         cts_flags and cts_offset.
1564         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1565         * ctf-create.c: Provide a definition of roundup if not defined.
1566         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1567         (ctf_add_reftype): Do not check if type IDs are below zero.
1568         (ctf_add_slice): Likewise.
1569         (ctf_add_typedef): Likewise.
1570         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1571         when known error-free.  Drop CTF_ERR usage for functions returning
1572         int.
1573         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1574         int.
1575         (ctf_add_variable): Likewise.
1576         (enumcmp): Likewise.
1577         (enumadd): Likewise.
1578         (membcmp): Likewise.
1579         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1580         when known error-free.
1581         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1582         returning int: use CTF_ERR for functions returning ctf_type_id.
1583         (ctf_dump_label): Likewise.
1584         (ctf_dump_objts): Likewise.
1585         * ctf-labels.c (ctf_label_topmost): Likewise.
1586         (ctf_label_iter): Likewise.
1587         (ctf_label_info): Likewise.
1588         * ctf-lookup.c (ctf_func_args): Likewise.
1589         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1590         (ctf_bufopen): Likewise.  Use zlib types as needed.
1591         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1592         returning int.
1593         (ctf_enum_iter): Likewise.
1594         (ctf_type_size): Likewise.
1595         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1596         (ctf_type_kind_unsliced): Likewise.
1597         (ctf_type_kind): Likewise.
1598         (ctf_type_encoding): Likewise.
1599         (ctf_member_info): Likewise.
1600         (ctf_array_info): Likewise.
1601         (ctf_enum_value): Likewise.
1602         (ctf_type_rvisit): Likewise.
1603         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1604         cts_offset.
1605         (ctf_simple_open): Likewise.
1606         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1607         * Makefile.in: Regenerate.
1608         * aclocal.m4: Likewise.
1609         * config.h: Likewise.
1610         * configure: Likewise.
1611
1612 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1613
1614         * configure.in: Check for bfd_section_from_elf_index.
1615         * configure: Regenerate.
1616         * config.h.in [HAVE_BFD_ELF]: Likewise.
1617         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1618         abfd is potentially unused now.
1619
1620 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1621
1622         * Makefile.am: New.
1623         * Makefile.in: Regenerated.
1624         * config.h.in: Likewise.
1625         * aclocal.m4: Likewise.
1626         * configure: Likewise.
1627
1628 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1629
1630         * ctf-dump.c: New.
1631
1632 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1633
1634         * ctf-labels.c: New.
1635
1636 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1637
1638         * ctf-impl.h (_libctf_version): New declaration.
1639         * ctf-subr.c (_libctf_version): Define it.
1640         (ctf_version): New.
1641
1642 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1643
1644         * ctf-create.c (enumcmp): New.
1645         (enumadd): Likewise.
1646         (membcmp): Likewise.
1647         (membadd): Likewise.
1648         (ctf_add_type): Likewise.
1649
1650 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1651
1652         * ctf-lookup.c (isqualifier): New.
1653         (ctf_lookup_by_name): Likewise.
1654         (struct ctf_lookup_var_key): Likewise.
1655         (ctf_lookup_var): Likewise.
1656         (ctf_lookup_variable): Likewise.
1657         (ctf_lookup_symbol_name): Likewise.
1658         (ctf_lookup_by_symbol): Likewise.
1659         (ctf_func_info): Likewise.
1660         (ctf_func_args): Likewise.
1661
1662 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1663
1664         * ctf-decl.c: New file.
1665         * ctf-types.c: Likewise.
1666         * ctf-impl.h: New declarations.
1667
1668 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1669
1670         * ctf-open-bfd.c: New file.
1671         * ctf-open.c (ctf_close): New.
1672         * ctf-impl.h: Include bfd.h.
1673         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1674         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1675         ctfi_bfd_close.
1676         (ctf_bfdopen_ctfsect): New declaration.
1677         (_CTF_SECTION): likewise.
1678
1679 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1680
1681         * ctf-archive.c: New.
1682         * ctf-impl.h (ctf_archive_internal): New type.
1683         (ctf_arc_open_internal): New declaration.
1684         (ctf_arc_bufopen): Likewise.
1685         (ctf_arc_close_internal): Likewise.
1686
1687 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1688
1689         * ctf-open.c: New file.
1690         * swap.h: Likewise.
1691
1692 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1693
1694         * ctf-create.c: New file.
1695         * ctf-lookup.c: New file.
1696
1697 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1698
1699         * ctf-impl.h: New definitions and declarations for type creation
1700         and lookup.
1701
1702 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1703
1704         * ctf-hash.c: New file.
1705         * ctf-impl.h: New declarations.
1706
1707 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1708
1709         * ctf-error.c: New file.
1710
1711 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1712
1713         * ctf-util.c: New file.
1714         * elf.h: Likewise.
1715         * ctf-impl.h: Include it, and add declarations.
1716
1717 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1718
1719         * ctf-impl.h: New file.
1720         * ctf-subr.c: New file.
1721
1722 \f
1723 Local Variables:
1724 mode: change-log
1725 left-margin: 8
1726 fill-column: 76
1727 version-control: never
1728 End: