1 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
5 * ctf-impl.h: Include it.
7 (ctf_sha1_add): Likewise.
8 (ctf_sha1_fini): Likewise.
9 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
11 * Makefile.am: Add file.
12 * Makefile.in: Regenerate.
14 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
16 * libctf.ver (ctf_link_set_variable_filter): Add.
17 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
18 <ctf_link_variable_filter_arg>: Likewise.
19 * ctf-create.c (ctf_serialize): Adjust.
20 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
21 (ctf_link_one_variable): Call it if set.
23 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
25 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
26 conflicts, not the source type.
28 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
30 * ctf-impl.h (ctf_file_t): Improve comments.
31 <ctf_link_cu_mapping>: Split into...
32 <ctf_link_in_cu_mapping>: ... this...
33 <ctf_link_out_cu_mapping>: ... and this.
34 * ctf-create.c (ctf_serialize): Adjust.
35 * ctf-open.c (ctf_file_close): Likewise.
36 * ctf-link.c (ctf_create_per_cu): Look things up in the
37 in_cu_mapping instead of the cu_mapping.
38 (ctf_link_add_cu_mapping): The deduplicating link will define
39 what happens if many FROMs share a TO.
40 (ctf_link_add_cu_mapping): Create in_cu_mapping and
41 out_cu_mapping. Do not create ctf_link_outputs here any more, or
42 create per-CU dicts here: they are already created when needed.
43 (ctf_link_one_variable): Log a debug message if we skip a
44 variable due to its type being concealed in a CU-mapped link.
45 (This is probably too common a case to make into a warning.)
46 (ctf_link): Create empty per-CU dicts if requested.
48 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
50 * ctf-link.c (ctf_link_write): Close the fd.
52 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
54 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
55 * Makefile.in: Regenerated.
56 * ctf-impl.h (ctf_link_input_name): New.
57 (ctf_file_t) <ctf_link_flags>: New.
58 * ctf-create.c (ctf_serialize): Adjust accordingly.
59 * ctf-link.c: Define ctf_open as weak when PIC.
60 (ctf_arc_close_thunk): Remove unnecessary thunk.
61 (ctf_file_close_thunk): Likewise.
62 (ctf_link_input_name): New.
63 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
64 (ctf_link_input_close): Adjust accordingly.
65 (ctf_link_add_ctf_internal): New, split from...
66 (ctf_link_add_ctf): ... here. Return error if lazy loading of
67 CTF is not possible. Change to just call...
68 (ctf_link_add): ... this new function.
69 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
71 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
72 <in_file_name>: ... this.
74 <share_mode>: Likewise (migrated to ctf_link_flags).
75 <done_main_member>: Rename to...
76 <done_parent>: ... this.
77 <main_input_fp>: Rename to...
78 <in_fp_parent>: ... this.
80 (ctf_link_one_type): Adjuwt accordingly. Transition to
81 ctf_err_warn, removing a TODO.
82 (ctf_link_one_variable): Note a case too common to warn about.
83 Report in the debug stream if a cu-mapped link prevents addition
84 of a conflicting variable.
85 (ctf_link_one_input_archive_member): Adjust.
86 (ctf_link_lazy_open): New, open a CTF archive for linking when
88 (ctf_link_close_one_input_archive): New, close it again.
89 (ctf_link_one_input_archive): Adjust for lazy opening, member
90 renames, and ctf_err_warn transition. Move the
91 empty_link_type_mapping call to...
92 (ctf_link): ... here. Adjut for renamings and thunk removal.
93 Don't spuriously fail if some input contains no CTF data.
94 (ctf_link_write): ctf_err_warn transition.
95 * libctf.ver: Remove not-yet-stable comment.
97 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
99 * ctf-impl.h (ctf_strerror): Delete.
100 * ctf-subr.c (ctf_strerror): Likewise.
101 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
104 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
106 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
107 (ctf_import_unref): New.
108 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
109 zero. Don't recurse back in if the refcount is already zero.
110 (ctf_import): Check ctf_parent_unreffed before deciding whether
111 to close a pre-existing parent. Set it to zero.
112 (ctf_import_unreffed): New, as above, setting
113 ctf_parent_unreffed to 1.
114 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
115 child: use direct assignment, and set unreffed on the new and
117 * ctf-link.c (ctf_create_per_cu): Import the parent using
120 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
122 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
123 (ctf_link_type_key): ... this, adjusting member prefixes to
125 (ctf_hash_type_mapping_key): Rename to...
126 (ctf_hash_type_key): ... this.
127 (ctf_hash_eq_type_mapping_key): Rename to...
128 (ctf_hash_eq_type_key): ... this.
129 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
130 (ctf_hash_type_key): ... this, and adjust for member name
132 (ctf_hash_eq_type_mapping_key): Rename to...
133 (ctf_hash_eq_type_key): ... this, and adjust for member name
135 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
136 need for out-of-memory checking in this code.
137 (ctf_type_mapping): Adjust.
139 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
141 configure.ac: Check for vasprintf.
142 configure: Regenerated.
143 config.h.in: Likewise.
145 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
147 * ctf-archive.c (ctf_arc_bufopen): Fix message.
149 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
151 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
153 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
154 if the input has no symtab, rather than dividing by
155 zero. Arrange to free it later via ctfi_free_ctfsect.
156 * ctf-archive.c (ctf_new_archive_internal): Do not
157 ctfi_free_strsect by default.
158 (ctf_arc_close): Possibly free it here.
160 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
162 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
163 (ctf_dump_format_type): improve slice formatting. Always print
164 the type size, even of slices.
165 (ctf_dump_member): Print slices (-> bitfields) differently from
166 non-slices. Failure to format a type is not an OOM.
168 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
170 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
171 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
172 (ctf_dump_objts): Likewise.
173 (ctf_dump_var): Likewise.
174 (ctf_dump_type): Do not emit a duplicate message. Move to
175 ctf_err_warning, and swallow all errors.
177 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
179 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
180 (ctf_decl_buf): Once it escapes, don't try to free it later.
182 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
184 * ctf-types.c (ctf_type_aname): Print arg types here...
185 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
186 in the type name here.
188 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
190 * ctf-impl.h (ctf_assert): New.
191 (ctf_err_warning_t): Likewise.
192 (ctf_file_t) <ctf_errs_warnings>: Likewise.
193 (ctf_err_warn): New prototype.
194 (ctf_assert_fail_internal): Likewise.
195 * ctf-inlines.h (ctf_assert_internal): Likewise.
196 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
197 * ctf-create.c (ctf_serialize): Copy it on serialization.
198 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
199 (ctf_errwarning_next): New iterator, free and pass back
200 errors/warnings in succession.
201 * libctf.ver (ctf_errwarning_next): Add.
203 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
205 * ctf-types.c (ctf_variable_iter): Fix error return.
207 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
209 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
211 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
213 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
215 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
217 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
219 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
220 ctf_dynhash_next_sorted.
221 <cu.ctn_h>: New, pointer to the dynhash under iteration.
222 <cu.ctn_s>: New, pointer to the dynset under iteration.
223 (ctf_hash_sort_f): Sorting function passed to...
224 (ctf_dynhash_next_sorted): ... this new function.
225 (ctf_dynhash_next): New.
226 (ctf_dynset_next): New.
227 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
228 (ctf_dynhash_cnext): New.
229 (ctf_dynset_cnext): New.
230 * ctf-hash.c (ctf_dynhash_next_sorted): New.
231 (ctf_dynhash_next): New.
232 (ctf_dynset_next): New.
233 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
235 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
237 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
239 * ctf-impl.h (ctf_next): New.
240 (ctf_get_dict): New prototype.
241 * ctf-lookup.c (ctf_get_dict): New, split out of...
242 (ctf_lookup_by_id): ... here.
243 * ctf-util.c (ctf_next_create): New.
244 (ctf_next_destroy): New.
245 (ctf_next_copy): New.
246 * ctf-types.c (includes): Add <assert.h>.
247 (ctf_member_next): New.
248 (ctf_enum_next): New.
249 (ctf_type_iter): Document the lack of iteration over parent
251 (ctf_type_next): New.
252 (ctf_variable_next): New.
253 * ctf-archive.c (ctf_archive_next): New.
254 * libctf.ver: Add new public functions.
256 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
258 * libctf.ver (ctf_ref): New.
259 * ctf-open.c (ctf_ref): Implement it.
261 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
263 * ctf-inlines.h (ctf_forwardable_kind): New.
264 * ctf-create.c (ctf_add_forward): Use it.
266 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
268 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
269 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
271 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
273 * ctf-hash.c (ctf_dynset_eq_string): New.
274 (ctf_dynset_create): New.
275 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
276 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
277 (key_to_internal): New.
278 (internal_to_key): New.
279 (ctf_dynset_insert): New.
280 (ctf_dynset_remove): New.
281 (ctf_dynset_destroy): New.
282 (ctf_dynset_lookup): New.
283 (ctf_dynset_exists): New.
284 (ctf_dynset_lookup_any): New.
285 (ctf_hash_insert_type): Coding style.
286 (ctf_hash_define_type): Likewise.
287 * ctf-impl.h (ctf_dynset_t): New.
288 (ctf_dynset_eq_string): New.
289 (ctf_dynset_create): New.
290 (ctf_dynset_insert): New.
291 (ctf_dynset_remove): New.
292 (ctf_dynset_destroy): New.
293 (ctf_dynset_lookup): New.
294 (ctf_dynset_exists): New.
295 (ctf_dynset_lookup_any): New.
296 * ctf-inlines.h (ctf_dynset_cinsert): New.
298 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
300 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
301 <value_free>: Likewise.
303 (ctf_dynhash_item_free): Indirect through the owner.
304 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
305 allocate space for the key_free and value_free fields fields
307 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
308 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
309 value_free if they will exist. Set the slot's owner, but only
311 (ctf_dynhash_remove): Adjust.
313 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
315 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
316 there is a key-freeing function and the key already exists.
318 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
320 * ctf-inlines.h: New file.
321 * ctf-impl.h: Include it.
322 (ctf_hash_iter_find_f): New typedef.
323 (ctf_dynhash_elements): New.
324 (ctf_dynhash_lookup_kv): New.
325 (ctf_dynhash_iter_find): New.
326 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
327 (ctf_traverse_find_cb_arg_t): New.
328 (ctf_hashtab_traverse_find): New.
329 (ctf_dynhash_iter_find): New.
330 (ctf_dynhash_elements): New.
332 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
334 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
336 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
338 * ctf-archive.c (ctf_archive_count): New.
339 * libctf.ver: New public function.
341 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
343 * ctf-types.c (ctf_member_count): New.
344 * libctf.ver: New public function.
346 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
348 * ctf-types.c (ctf_type_kind_forwarded): New.
350 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
352 * ctf-types.c (ctf_type_name_raw): New.
353 (ctf_type_aname_raw): Reimplement accordingly.
355 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
357 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
359 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
361 * ctf-impl.h (struct ctf_archive_internal)
362 <ctfi_unmap_on_close>: New.
363 (ctf_new_archive_internal): Adjust.
364 * ctf-archive.c (ctf_new_archive_internal): Likewise.
365 Initialize ctfi_unmap_on_close. Adjust error path.
366 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
367 (unmap_on_close is 0).
368 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
369 * ctf-open-bfd.c (ctf_fdopen): Adjust.
371 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
373 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
374 ints, floats or typedefs have no name. Fix comment typo.
376 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
378 * ctf-create.c (ctf_add_slice): Support slices of any kind that
379 resolves to an integral type.
380 * ctf-types.c (ctf_type_encoding): Resolve the type before
381 fishing its encoding out.
383 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
385 * ctf-create.c (ctf_create): Mark dirty.
387 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
389 * ctf-create.c (membcmp) Skip nameless members.
391 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
393 * ctf-create.c (ctf_add_member_offset): Support names of ""
394 as if they were the null pointer.
396 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
398 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
405 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
407 * ctf-create.c (ctf_serialize): Add cast.
408 (ctf_add_slice): Likewise.
410 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
412 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
413 * ctf-create.c (ctf_add_function): Check for unimplemented type
414 and populate at the same time. Populate one-by-one, not via
416 (ctf_serialize): Remove unnecessary cast.
417 * ctf-types.c (ctf_func_type_info): Likewise.
418 (ctf_func_type_args): Likewise. Fix comment typo.
420 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
422 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
423 (ctf_add_array): Support array contents of type zero.
424 (ctf_add_function): Support arguments and return types of
426 (ctf_add_typedef): Support typedefs to type zero.
427 (ctf_add_member_offset): Support members of type zero,
428 unless added at unspecified (naturally-aligned) offset.
430 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
432 * ctf-error.c: Include <stddef.h>, for offsetof.
433 (_ctf_errlist): Migrate to...
434 (_ctf_errlist_t): ... this.
435 (_ctf_erridx): New, indexes into _ctf_errlist_t.
437 (ctf_errmsg): Adjust accordingly.
438 * Makefile.am (BUILT_SOURCES): Note...
439 (ctf-error.h): ... this new rule.
440 * Makefile.in: Regenerate.
441 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
442 * .gitignore: New, ignore ctf-error.h.
444 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
446 * ctf-impl.h: Fix typos in comments.
448 2020-07-22 Nick Clifton <nickc@redhat.com>
450 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
451 same file descriptor.
453 2020-07-04 Nick Clifton <nickc@redhat.com>
455 Binutils 2.35 branch created.
457 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
459 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
461 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
462 * config.h.in: Regenerated.
463 * Makefile.in: Likewise.
464 * configure: Likewise.
466 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
468 * ctf-create.c: Include <unistd.h>.
469 * ctf-open-bfd.c: Likewise.
471 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
474 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
475 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
476 means this is declared.
477 (bswap_32): Likewise.
478 (bswap_64): Likewise.
479 (bswap_identity_64): Remove, unused.
480 * configure: Regenerated.
481 * config.h.in: Likewise.
483 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
486 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
487 (_libctf_unlikely_): Likewise.
488 (_libctf_unused): Likewise.
489 (_libctf_malloc_): Likewise.
491 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
494 * ctf-archive.c (search_nametbl): No longer global: declare...
495 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
496 (search_modent_by_name): Take and use ARG for the nametbl.
498 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
500 * ctf-impl.h (ctf_new_archive_internal): Declare.
501 (ctf_arc_bufopen): Remove.
502 (ctf_archive_internal) <ctfi_free_symsect>: New.
503 * ctf-archive.c (ctf_arc_close): Use it.
504 (ctf_arc_bufopen): Fuse into...
505 (ctf_new_archive_internal): ... this, moved across from...
506 * ctf-open-bfd.c: ... here.
507 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
508 * libctf.ver: Add it.
510 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
512 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
513 (ctf_dtd_delete): Remove correspondingly.
514 (ctf_rollback): Likewise.
516 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
518 * ctf-create.c (ctf_add_type_internal): Hand back existing types
521 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
523 * ctf-create.c (ctf_add_forward): Don't add forwards to
524 types that already exist.
526 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
528 * ctf-open.c (init_types): Only intern root-visible types.
529 * ctf-create.c (ctf_dtd_insert): Likewise.
530 (ctf_dtd_delete): Only remove root-visible types.
531 (ctf_rollback): Likewise.
532 (ctf_add_generic): Adjust.
533 (ctf_add_struct_sized): Adjust comment.
534 (ctf_add_union_sized): Likewise.
535 (ctf_add_enum): Likewise.
536 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
538 2020-03-11 John Baldwin <jhb@FreeBSD.org>
540 * swap.h (bswap_identity_64): Make static.
542 2020-01-18 Nick Clifton <nickc@redhat.com>
544 Binutils 2.34 branch created.
546 2020-01-05 Joel Brobecker <brobecker@adacore.com>
549 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
550 * configure, config.h.in: Regenerate.
552 2020-01-01 Alan Modra <amodra@gmail.com>
554 Update year range in copyright notice of all files.
556 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
558 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
560 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
562 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
563 * ctf-types.c (ctf_type_lname): Likewise.
565 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
567 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
568 ctf_import after the first for a given file.
570 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
572 * ctf-impl.h (ctf_str_append_noerr): Declare.
573 * ctf-util.c (ctf_str_append_noerr): Define in terms of
575 * ctf-dump.c (str_append): New, call it.
576 (ctf_dump_format_type): Use str_append, not ctf_str_append.
577 (ctf_dump_label): Likewise.
578 (ctf_dump_objts): Likewise.
579 (ctf_dump_funcs): Likewise.
580 (ctf_dump_var): Likewise.
581 (ctf_dump_member): Likewise.
582 (ctf_dump_type): Likewise.
583 (ctf_dump): Likewise.
585 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
587 * ctf-impl.h (ctf_alloc): Remove.
588 (ctf_free): Likewise.
589 (ctf_strdup): Likewise.
590 * ctf-subr.c (ctf_alloc): Remove.
591 (ctf_free): Likewise.
592 * ctf-util.c (ctf_strdup): Remove.
594 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
595 ctf_free; strdup, not ctf_strdup.
596 (ctf_dtd_delete): Likewise.
597 (ctf_dvd_delete): Likewise.
598 (ctf_add_generic): Likewise.
599 (ctf_add_function): Likewise.
600 (ctf_add_enumerator): Likewise.
601 (ctf_add_member_offset): Likewise.
602 (ctf_add_variable): Likewise.
604 (ctf_compress_write): Likewise.
605 (ctf_write_mem): Likewise.
606 * ctf-decl.c (ctf_decl_push): Likewise.
607 (ctf_decl_fini): Likewise.
608 (ctf_decl_sprintf): Likewise. Check for OOM.
609 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
610 ctf_free; strdup, not ctf_strdup.
611 (ctf_dump_free): Likewise.
612 (ctf_dump): Likewise.
613 * ctf-open.c (upgrade_types_v1): Likewise.
614 (init_types): Likewise.
615 (ctf_file_close): Likewise.
616 (ctf_bufopen_internal): Likewise. Check for OOM.
617 (ctf_parent_name_set): Likewise: report the OOM to the caller.
618 (ctf_cuname_set): Likewise.
619 (ctf_import): Likewise.
620 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
621 free, not ctf_free; strdup, not ctf_strdup.
622 (ctf_str_free_atom): Likewise.
623 (ctf_str_create_atoms): Likewise.
624 (ctf_str_add_ref_internal): Likewise.
625 (ctf_str_remove_ref): Likewise.
626 (ctf_str_write_strtab): Likewise.
628 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
630 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
631 work right for non-int/fps.
633 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
635 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
638 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
640 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
641 * ctf-open.c (ctf_file_close): Free it.
642 * ctf-create.c (ctf_serialize): Adjust.
643 (membcmp): When reporting a conflict due to an error, report the
645 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
646 (ctf_add_type_internal): ... this. Hand back types we are already
647 in the middle of adding immediately. Hand back structs/unions with
648 the same number of members immediately. Do not walk the dynamic
649 list. Call ctf_add_type_internal, not ctf_add_type. Handle
650 forwards promoted to other types and the inverse case identically.
651 Add structs to the mapping as soon as we intern them, before they
654 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
656 * ctf-impl.h (ctf_names_t): New.
657 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
658 (ctf_file_t) <ctf_structs>: Likewise.
659 <ctf_unions>: Likewise.
660 <ctf_enums>: Likewise.
661 <ctf_names>: Likewise.
662 <ctf_lookups>: Improve comment.
663 <ctf_ptrtab_len>: New.
664 <ctf_prov_strtab>: New.
665 <ctf_str_prov_offset>: New.
666 <ctf_dtbyname>: Remove, redundant to the names hashes.
667 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
668 (ctf_dtdef_t) <dtd_name>: Remove.
669 <dtd_data>: Note that the ctt_name is now populated.
670 (ctf_str_atom_t) <csa_offset>: This is now the strtab
671 offset for internal strings too.
672 <csa_external_offset>: New, the external strtab offset.
673 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
674 (ctf_name_table): New declaration.
675 (ctf_lookup_by_rawname): Likewise.
676 (ctf_lookup_by_rawhash): Likewise.
677 (ctf_set_ctl_hashes): Likewise.
678 (ctf_serialize): Likewise.
679 (ctf_dtd_insert): Adjust.
680 (ctf_simple_open_internal): Likewise.
681 (ctf_bufopen_internal): Likewise.
682 (ctf_list_empty_p): Likewise.
683 (ctf_str_remove_ref): Likewise.
684 (ctf_str_add): Returns uint32_t now.
685 (ctf_str_add_ref): Likewise.
686 (ctf_str_add_external): Now returns a boolean (int).
687 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
688 for strings in the appropriate range.
689 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
690 when adding the null string to the new strtab.
691 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
692 (ctf_str_add_ref_internal): Add make_provisional argument. If
693 make_provisional, populate the offset and fill in the
694 ctf_prov_strtab accordingly.
695 (ctf_str_add): Return the offset, not the string.
696 (ctf_str_add_ref): Likewise.
697 (ctf_str_add_external): Return a success integer.
698 (ctf_str_remove_ref): New, remove a single ref.
699 (ctf_str_count_strtab): Do not count the initial null string's
700 length or the existence or length of any unreferenced internal
702 (ctf_str_populate_sorttab): Skip atoms with no refs.
703 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
704 to the cts_len for the null string, since it is no longer done
705 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
706 Populate the csa_offset for both internal and external cases.
707 Flush the ctf_prov_strtab afterwards, and reset the
709 * ctf-create.c (ctf_grow_ptrtab): New.
710 (ctf_create): Call it. Initialize new fields rather than old
711 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
712 Set the ctl hashes and data model.
713 (ctf_update): Rename to...
714 (ctf_serialize): ... this. Leave a compatibility function behind.
715 Tell ctf_simple_open_internal that this is a writable dictionary.
716 Pass the new fields along from the old dictionary. Drop
717 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
718 Do not zero out the DTD's ctt_name.
719 (ctf_prefixed_name): Rename to...
720 (ctf_name_table): ... this. No longer return a prefixed name: return
721 the applicable name table instead.
722 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
723 kind we're adding. Migrate away from dtd_name.
724 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
726 (ctf_dtd_lookup_type_by_name): Remove.
727 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
728 No longer check ctf_dtnextid: check ctf_typemax instead.
729 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
730 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
731 ctf_name_table and the right name table, and migrate away from
732 dtd_name as in ctf_dtd_delete.
733 (ctf_add_generic): Pass in the kind explicitly and pass it to
734 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
735 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
736 Grow the ptrtab if needed.
737 (ctf_add_encoded): Pass in the kind.
738 (ctf_add_slice): Likewise.
739 (ctf_add_array): Likewise.
740 (ctf_add_function): Likewise.
741 (ctf_add_typedef): Likewise.
742 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
743 ctt_name rather than dtd_name.
744 (ctf_add_struct_sized): Pass in the kind. Use
745 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
746 ctf_dtd_lookup_type_by_name.
747 (ctf_add_union_sized): Likewise.
748 (ctf_add_enum): Likewise.
749 (ctf_add_enum_encoded): Likewise.
750 (ctf_add_forward): Likewise.
751 (ctf_add_type): Likewise.
752 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
753 being initialized until after the call.
754 (ctf_write_mem): Likewise.
755 (ctf_write): Likewise.
756 * ctf-archive.c (arc_write_one_ctf): Likewise.
757 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
758 ctf_hash_lookup_type.
759 (ctf_lookup_by_id): No longer check the readonly types if the
760 dictionary is writable.
761 * ctf-open.c (init_types): Assert that this dictionary is not
762 writable. Adjust to use the new name hashes, ctf_name_table,
763 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
764 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
765 if set. Drop out early when dictionary is writable. Split the
766 ctf_lookups initialization into...
767 (ctf_set_cth_hashes): ... this new function.
768 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
769 (ctf_simple_open): Adjust accordingly.
770 (ctf_bufopen): Likewise.
771 (ctf_file_close): Destroy the appropriate name hashes. No longer
772 destroy ctf_dtbyname, which is gone.
773 (ctf_getdatasect): Remove spurious "extern".
774 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
775 specified name table, given a kind.
776 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
777 (ctf_member_iter): Add support for iterating over the
779 (ctf_enum_iter): Likewise.
780 (ctf_variable_iter): Likewise.
781 (ctf_type_rvisit): Likewise.
782 (ctf_member_info): Add support for types in the dynamic type list.
783 (ctf_enum_name): Likewise.
784 (ctf_enum_value): Likewise.
785 (ctf_func_type_info): Likewise.
786 (ctf_func_type_args): Likewise.
787 * ctf-link.c (ctf_accumulate_archive_names): No longer call
789 (ctf_link_write): Likewise.
790 (ctf_link_intern_extern_string): Adjust for new
791 ctf_str_add_external return value.
792 (ctf_link_add_strtab): Likewise.
793 * ctf-util.c (ctf_list_empty_p): New.
795 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
797 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
799 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
801 (ctf_add_variable): Likewise for variables pointing to them.
802 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
803 type link failure, but do warn for others.
804 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
806 (ctf_dump_member): Likewise.
807 (ctf_dump_type): Likewise.
808 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
809 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
810 (ctf_dump_header): Likewise.
811 (ctf_dump_label): likewise.
812 (ctf_dump_objts): likewise.
813 (ctf_dump_funcs): likewise.
814 (ctf_dump_var): likewise.
815 (ctf_dump_str): Likewise.
817 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
819 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
821 (AM_INSTALL_LIBBFD): Likewise.
822 (dlopen): Note why this is necessary in a comment.
823 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
825 (SHARED_LDFLAGS): Likewise.
826 (BFD_LIBADD): Likewise, for libbfd.
827 (BFD_DEPENDENCIES): Likewise.
828 (VERSION_FLAGS): Initialize, using a version script if ld supports
829 one, or libtool -export-symbols-regex otherwise.
830 (AC_CONFIG_MACRO_DIR): Add ../BFD.
831 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
833 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
834 (noinst_LIBRARIES): Replace with...
835 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
836 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
837 libctf-nobfd.la as well.
838 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
839 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
840 (libctf_a_SOURCES): Rename to...
841 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
843 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
844 with ctf-open-bfd.c added.
845 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
846 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
847 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
848 * Makefile.am [INSTALL_LIBCTF]: Use it.
849 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
851 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
852 the unstable components).
853 * Makefile.in: Regenerated.
854 * config.h.in: Likewise.
855 * configure: Likewise.
857 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
859 * configure.ac (INSTALL_LIBCTF): New, controlled by
860 --enable-install-libctf.
861 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
862 * Makefile.in: Regenerated.
863 * configure: Regenerated.
865 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
867 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
868 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
870 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
872 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
874 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
876 * ctf-impl.h (includes): Include <sys/param.h> here.
878 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
880 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
881 (flip_objts): Likewise.
882 (flip_vars): Likewise.
883 (flip_types): Likewise.
885 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
887 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
888 freeing functions: if set, free the key and value if the slot
889 already exists. Always reassign the key.
890 (ctf_dynhash_insert): Adjust call appropriately.
891 (ctf_hash_insert_type): Likewise.
893 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
895 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
896 type kind. Allow forwards to unify with pre-existing structs/
899 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
901 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
902 <ctf_link_memb_name_changer>: Likewise.
903 <ctf_link_memb_name_changer_arg>: Likewise.
904 * ctf-create.c (ctf_update): Update accordingly.
905 * ctf-open.c (ctf_file_close): Likewise.
906 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
907 (ctf_link_add_cu_mapping): New.
908 (ctf_link_set_memb_name_changer): Likewise.
909 (ctf_change_parent_name): New.
910 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
911 allocated by the caller's ctf_link_memb_name_changer.
912 <ndynames>: Likewise.
913 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
914 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
915 ctf_change_parent_name. Free any resulting names.
917 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
919 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
920 (ctf_link_one_type): ... here, with parent-name setting added.
921 (check_variable): New.
922 (ctf_link_one_variable): Likewise.
923 (ctf_link_one_input_archive_member): Call it.
924 * ctf-error.c (_ctf_errlist): Updated with new errors.
926 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
928 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
929 (struct ctf_link_type_mapping_key): New.
930 (ctf_hash_type_mapping_key): Likewise.
931 (ctf_hash_eq_type_mapping_key): Likewise.
932 (ctf_add_type_mapping): Likewise.
933 (ctf_type_mapping): Likewise.
934 (ctf_dynhash_empty): Likewise.
935 * ctf-open.c (ctf_file_close): Update accordingly.
936 * ctf-create.c (ctf_update): Likewise.
937 (ctf_add_type): Populate the mapping.
938 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
939 (ctf_hash_eq_type_mapping_key): Check the key for equality.
940 (ctf_dynhash_insert): Fix comment typo.
941 (ctf_dynhash_empty): New.
942 * ctf-link.c (ctf_add_type_mapping): New.
943 (ctf_type_mapping): Likewise.
944 (empty_link_type_mapping): New.
945 (ctf_link_one_input_archive): Call it.
947 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
949 * ctf-link.c: New file, linking of the string and type sections.
950 * Makefile.am (libctf_a_SOURCES): Add it.
951 * Makefile.in: Regenerate.
953 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
955 * ctf-create.c (ctf_update): Update accordingly.
956 * ctf-open.c (ctf_file_close): Likewise.
957 * ctf-error.c (_ctf_errlist): Updated with new errors.
959 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
961 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
963 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
965 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
967 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
968 (ctf_dump_format_type): Add non-root-type { } notation.
969 Add root flag to prototype.
970 (ctf_dump_label): Adjust accordingly.
971 (ctf_dump_objts): Likewise.
972 (ctf_dump_var): Likewise.
974 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
976 * ctf-create.c (ctf_compress_write): Fix double-free.
978 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
980 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
982 (ctf_arc_write_fd): ... this new function.
983 * ctf-create.c (ctf_write_mem): New.
985 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
987 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
988 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
989 (ctf_str_add_ref): Name the last arg.
990 (ctf_str_add_external) New.
991 (ctf_str_add_strraw_explicit): Likewise.
992 (ctf_simple_open_internal): Likewise.
993 (ctf_bufopen_internal): Likewise.
995 * ctf-string.c (ctf_strraw_explicit): Split from...
996 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
997 (ctf_str_add_ref_internal): Return the atom, not the
999 (ctf_str_add): Adjust accordingly.
1000 (ctf_str_add_ref): Likewise. Move up in the file.
1001 (ctf_str_add_external): New: update the csa_offset.
1002 (ctf_str_count_strtab): Only account for strings with no csa_offset
1003 in the internal strtab length.
1004 (ctf_str_write_strtab): If the csa_offset is set, update the
1005 string's refs without writing the string out, and update the
1006 ctf_syn_ext_strtab. Make OOM handling less ugly.
1007 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1008 (ctf_update): Handle failure to populate the strtab. Pass in the
1009 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1010 Call ctf_simple_open_internal, not ctf_simple_open.
1011 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1013 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1014 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1015 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1016 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1017 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1018 (ctf_simple_open_internal): ... this new function, which calls
1019 ctf_bufopen_internal.
1020 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1021 (ctf_bufopen_internal): ... this new function, which sets
1024 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1026 * ctf_types.c (ctf_type_iter_all): New.
1028 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1030 * ctf-open.c (init_symtab): Check for overflow against the right
1032 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1033 (upgrade_types_v1): Note that these sections are not checked.
1034 (flip_header): Endian-swap the header fields.
1035 (flip_ctf): Endian-swap the sections.
1036 (flip_objts): Update comment.
1037 (ctf_bufopen): Check header offsets and alignment for validity.
1039 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1041 * ctf-open-bfd.c: Add <assert.h>.
1042 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1043 techniques borrowed from bfd_elf_sym_name.
1044 (ctf_new_archive_internal): Improve comment.
1045 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1046 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1047 no symbol section, but not vice versa.
1049 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1051 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1052 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1053 * ctf-dump.c (dump_header): New function, dump the CTF header.
1054 (ctf_dump): Call it.
1055 (ctf_dump_header_strfield): New function.
1056 (ctf_dump_header_sectfield): Likewise.
1058 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1060 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1061 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1062 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1063 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1064 Print out ctf_cuname: only print out ctf_parname if set.
1065 (ctf_free_base): Removed, ctf_base is no longer freed: free
1066 ctf_dynbase instead.
1067 (ctf_set_version): Fix spacing.
1068 (upgrade_header): New, in-place header upgrading.
1069 (upgrade_types): Rename to...
1070 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1071 longer track old and new headers separately. No longer allow for
1072 header sizes explicitly: squeeze the headers out on upgrade (they
1073 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1074 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1075 (upgrade_types): New, also handle ctf_parmax updating.
1076 (flip_header): Flip ctf_cuname.
1077 (flip_types): Flip BUF explicitly rather than deriving BUF from
1079 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1080 required alignment of objtoff and funcoff. No longer store it in
1081 the ctf_buf unless that buf is derived unmodified from the input.
1082 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1083 that duplicate fields in ctf_file: move allocation of ctf_file
1084 further up instead. Call upgrade_header as needed. Move
1085 version-specific ctf_parmax initialization into upgrade_types. More
1086 concise error handling.
1087 (ctf_file_close): No longer test for null pointers before freeing.
1088 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1091 (ctf_cuname_set): New.
1092 * ctf-create.c (ctf_update): Populate ctf_cuname.
1093 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1095 (ctf_write): Likewise.
1096 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1097 Fix the compression length: fp->ctf_size never counted the CTF
1098 header. Simplify the compress call accordingly.
1100 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1102 * ctf-endian.h: Don't assume htole64 and le64toh are always
1103 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1104 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1105 not bswap_identity_64.
1107 2019-09-18 Alan Modra <amodra@gmail.com>
1109 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1111 2019-09-09 Phil Blundell <pb@pbcl.net>
1113 binutils 2.33 branch created.
1115 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1117 * ctf-types.c (ctf_type_aname_raw): New.
1118 (ctf_func_type_info): Likewise.
1119 (ctf_func_type_args): Likewise.
1120 * ctf-error.c (_ctf_errlist): Fix description.
1121 * ctf-lookup.c: Fix file description.
1123 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1125 * ctf-create.c (ctf_create): Fix off-by-one error.
1127 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1129 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1131 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1132 (struct ctf_str_atom): New, disambiguated single string.
1133 (struct ctf_str_atom_ref): New, points to some other location that
1134 references this string's offset.
1135 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1136 Remove member ctf_dtvstrlen: we no longer track the total strlen
1138 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1139 (ctf_str_free_atoms): Likewise.
1140 (ctf_str_add): Likewise.
1141 (ctf_str_add_ref): Likewise.
1142 (ctf_str_rollback): Likewise.
1143 (ctf_str_purge_refs): Likewise.
1144 (ctf_str_write_strtab): Likewise.
1145 (ctf_realloc): Declare new function in ctf-util.c.
1147 * ctf-open.c (ctf_bufopen): Create the atoms table.
1148 (ctf_file_close): Destroy it.
1149 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1150 special-case the position of the parname string. Construct the
1151 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1152 rest of each buffer element is constructed, not via open-coding:
1153 realloc the CTF buffer and append the strtab to it. No longer
1154 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1155 strtab construction.
1156 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1157 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1158 after buffer element construction instead.
1159 (ctf_copy_lmembers): Likewise.
1160 (ctf_copy_emembers): Likewise.
1161 (ctf_create): No longer maintain the ctf_dtvstrlen.
1162 (ctf_dtd_delete): Likewise.
1163 (ctf_dvd_delete): Likewise.
1164 (ctf_add_generic): Likewise.
1165 (ctf_add_enumerator): Likewise.
1166 (ctf_add_member_offset): Likewise.
1167 (ctf_add_variable): Likewise.
1168 (membadd): Likewise.
1169 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1170 if there are active ctf_str_num_refs.
1171 (ctf_strraw): Move to ctf-string.c.
1172 (ctf_strptr): Likewise.
1173 * ctf-string.c: New file, strtab manipulation.
1175 * Makefile.am (libctf_a_SOURCES): Add it.
1176 * Makefile.in: Regenerate.
1178 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1180 * ctf-impl.h (ctf_hash_iter_f): New.
1181 (ctf_dynhash_iter): New declaration.
1182 (ctf_dynhash_iter_remove): New declaration.
1183 * ctf-hash.c (ctf_dynhash_iter): Define.
1184 (ctf_dynhash_iter_remove): Likewise.
1185 (ctf_hashtab_traverse): New.
1186 (ctf_hashtab_traverse_remove): Likewise.
1187 (struct ctf_traverse_cb_arg): Likewise.
1188 (struct ctf_traverse_remove_cb_arg): Likewise.
1190 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1192 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1194 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1196 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1197 (ctf_dump_funcs): Likewise.
1199 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1201 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1202 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1203 little-endian CTF archive magic. Do not check the CTF version:
1204 ctf_simple_open does that in endian-safe ways. Do not dereference
1205 null pointers on open failure.
1207 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1209 * ctf-open.c (get_vbytes_common): Return the new slice size.
1210 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1211 Remember to copy in the CTF data when opening an uncompressed
1212 foreign-endian CTF file. Prune useless variable manipulation.
1214 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1216 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1219 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1221 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1224 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1226 * ctf-subr.c (_PAGESIZE): Remove.
1227 (ctf_data_alloc): Likewise.
1228 (ctf_data_free): Likewise.
1229 (ctf_data_protect): Likewise.
1230 * ctf-impl.h: Remove declarations.
1231 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1232 ctf_free, not ctf_data_free.
1233 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1234 the buffer again on compression error.
1235 * ctf-open.c (ctf_set_base): No longer track the size: call
1236 ctf_free, not ctf_data_free.
1237 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1238 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1240 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1242 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1244 (ctf_dvd_insert): Likewise.
1245 (ctf_add_generic): Likewise.
1246 (ctf_add_variable): Likewise.
1247 * ctf-impl.h: Adjust declarations.
1249 2019-06-14 Alan Modra <amodra@gmail.com>
1251 * configure: Regenerate.
1253 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1255 * ctf-decls.h: Include <libiberty.h>.
1256 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1258 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1260 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1261 (ctf_dump_objts): Likewise.
1262 (ctf_dump_funcs): Likewise.
1263 (ctf_dump_member): Likewise.
1264 (ctf_dump_str): Likewise.
1266 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1268 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1269 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1271 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1273 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1274 (ctf_arc_open_by_offset): Likewise.
1275 * ctf-create.c (ctf_add_type): Likewise.
1277 2019-06-04 Tom Tromey <tromey@adacore.com>
1279 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1280 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1282 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1284 * configure.ac: Check for O_CLOEXEC.
1285 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1286 * config.h.in: Regenerate.
1287 * configure: Likewise.
1289 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1291 * qsort_r.c: Rename to...
1292 * ctf-qsort_r.c: ... this.
1293 (_quicksort): Define to ctf_qsort_r.
1294 * ctf-decls.h (qsort_r): Remove.
1296 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1297 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1298 * Makefile.am (libctf_a_LIBADD): Remove.
1299 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1300 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1301 * ctf-create.c (ctf_update): Likewise.
1302 * configure.ac: Check for BSD versus GNU qsort_r signature.
1303 * Makefile.in: Regenerate.
1304 * config.h.in: Likewise.
1305 * configure: Likewise.
1307 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1309 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1311 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1313 * Makefile.am (ZLIB): New.
1314 (ZLIBINC): Likewise.
1315 (AM_CFLAGS): Use them.
1316 (libctf_a_LIBADD): New, for LIBOBJS.
1317 * configure.ac: Check for zlib, endian.h, and qsort_r.
1318 * ctf-endian.h: New, providing htole64 and le64toh.
1319 * swap.h: Code style fixes.
1320 (bswap_identity_64): New.
1321 * qsort_r.c: New, from gnulib (with one added #include).
1322 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1323 and unconditional definitions of MIN and MAX.
1324 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1325 (ctf_set_errno): Now returns unsigned long.
1326 * ctf-util.c (ctf_set_errno): Adjust here too.
1327 * ctf-archive.c: Use ctf-endian.h.
1328 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1329 cts_flags and cts_offset.
1330 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1331 * ctf-create.c: Provide a definition of roundup if not defined.
1332 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1333 (ctf_add_reftype): Do not check if type IDs are below zero.
1334 (ctf_add_slice): Likewise.
1335 (ctf_add_typedef): Likewise.
1336 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1337 when known error-free. Drop CTF_ERR usage for functions returning
1339 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1341 (ctf_add_variable): Likewise.
1342 (enumcmp): Likewise.
1343 (enumadd): Likewise.
1344 (membcmp): Likewise.
1345 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1346 when known error-free.
1347 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1348 returning int: use CTF_ERR for functions returning ctf_type_id.
1349 (ctf_dump_label): Likewise.
1350 (ctf_dump_objts): Likewise.
1351 * ctf-labels.c (ctf_label_topmost): Likewise.
1352 (ctf_label_iter): Likewise.
1353 (ctf_label_info): Likewise.
1354 * ctf-lookup.c (ctf_func_args): Likewise.
1355 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1356 (ctf_bufopen): Likewise. Use zlib types as needed.
1357 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1359 (ctf_enum_iter): Likewise.
1360 (ctf_type_size): Likewise.
1361 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1362 (ctf_type_kind_unsliced): Likewise.
1363 (ctf_type_kind): Likewise.
1364 (ctf_type_encoding): Likewise.
1365 (ctf_member_info): Likewise.
1366 (ctf_array_info): Likewise.
1367 (ctf_enum_value): Likewise.
1368 (ctf_type_rvisit): Likewise.
1369 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1371 (ctf_simple_open): Likewise.
1372 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1373 * Makefile.in: Regenerate.
1374 * aclocal.m4: Likewise.
1375 * config.h: Likewise.
1376 * configure: Likewise.
1378 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1380 * configure.in: Check for bfd_section_from_elf_index.
1381 * configure: Regenerate.
1382 * config.h.in [HAVE_BFD_ELF]: Likewise.
1383 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1384 abfd is potentially unused now.
1386 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1389 * Makefile.in: Regenerated.
1390 * config.h.in: Likewise.
1391 * aclocal.m4: Likewise.
1392 * configure: Likewise.
1394 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1398 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1400 * ctf-labels.c: New.
1402 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1404 * ctf-impl.h (_libctf_version): New declaration.
1405 * ctf-subr.c (_libctf_version): Define it.
1408 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1410 * ctf-create.c (enumcmp): New.
1411 (enumadd): Likewise.
1412 (membcmp): Likewise.
1413 (membadd): Likewise.
1414 (ctf_add_type): Likewise.
1416 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1418 * ctf-lookup.c (isqualifier): New.
1419 (ctf_lookup_by_name): Likewise.
1420 (struct ctf_lookup_var_key): Likewise.
1421 (ctf_lookup_var): Likewise.
1422 (ctf_lookup_variable): Likewise.
1423 (ctf_lookup_symbol_name): Likewise.
1424 (ctf_lookup_by_symbol): Likewise.
1425 (ctf_func_info): Likewise.
1426 (ctf_func_args): Likewise.
1428 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1430 * ctf-decl.c: New file.
1431 * ctf-types.c: Likewise.
1432 * ctf-impl.h: New declarations.
1434 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1436 * ctf-open-bfd.c: New file.
1437 * ctf-open.c (ctf_close): New.
1438 * ctf-impl.h: Include bfd.h.
1439 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1440 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1442 (ctf_bfdopen_ctfsect): New declaration.
1443 (_CTF_SECTION): likewise.
1445 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1447 * ctf-archive.c: New.
1448 * ctf-impl.h (ctf_archive_internal): New type.
1449 (ctf_arc_open_internal): New declaration.
1450 (ctf_arc_bufopen): Likewise.
1451 (ctf_arc_close_internal): Likewise.
1453 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1455 * ctf-open.c: New file.
1458 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1460 * ctf-create.c: New file.
1461 * ctf-lookup.c: New file.
1463 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1465 * ctf-impl.h: New definitions and declarations for type creation
1468 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1470 * ctf-hash.c: New file.
1471 * ctf-impl.h: New declarations.
1473 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1475 * ctf-error.c: New file.
1477 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1479 * ctf-util.c: New file.
1481 * ctf-impl.h: Include it, and add declarations.
1483 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1485 * ctf-impl.h: New file.
1486 * ctf-subr.c: New file.
1493 version-control: never