libctf/ChangeLog

   1 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-link.c (ctf_link_shuffle_syms): Adjust.
   4         (ctf_link_add_linker_symbol): New, unimplemented stub.
   5         * libctf.ver: Add it.
   6         * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
   7         dicts.
   8         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
   9         symtab/strtab if not present, dynsym/dynstr otherwise.
  10         * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
  11         some arbitrary member of a CTF archive.
  12         * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
  13
  14 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  15
  16         * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
  17         (ctf_dict_open_by_offset): ... this.  Adjust callers.
  18         (ctf_arc_open_by_name_internal): Rename to...
  19         (ctf_dict_open_internal): ... this.  Adjust callers.
  20         (ctf_arc_open_by_name_sections): Rename to...
  21         (ctf_dict_open_sections): ... this, keeping compatibility function.
  22         (ctf_arc_open_by_name): Rename to...
  23         (ctf_dict_open): ... this, keeping compatibility function.
  24         * libctf.ver: New functions added.
  25         * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
  26         (ctf_link_deduplicating_open_inputs): Likewise.
  27
  28 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  29
  30         * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
  31         adjusted.
  32         (ctf_fileops): Rename to...
  33         (ctf_dictops): ... this.
  34         (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
  35         <cd_id_to_dict_t>: ... this.
  36         (ctf_file_t): Fix outdated comment.
  37         <ctf_fileops>: Rename to...
  38         <ctf_dictops>: ... this.
  39         (struct ctf_archive_internal) <ctfi_file>: Rename to...
  40         <ctfi_dict>: ... this.
  41         * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
  42         Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
  43         Rename ctf_file_close to ctf_dict_close.  All users adjusted.
  44         * ctf-create.c: Likewise.  Refer to CTF dicts, not CTF containers.
  45         (ctf_bundle_t) <ctb_file>: Rename to...
  46         <ctb_dict): ... this.
  47         * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
  48         * ctf-dedup.c: Likewise.  Rename ctf_file_close to
  49         ctf_dict_close. Refer to CTF dicts, not CTF containers.
  50         * ctf-dump.c: Likewise.
  51         * ctf-error.c: Likewise.
  52         * ctf-hash.c: Likewise.
  53         * ctf-inlines.h: Likewise.
  54         * ctf-labels.c: Likewise.
  55         * ctf-link.c: Likewise.
  56         * ctf-lookup.c: Likewise.
  57         * ctf-open-bfd.c: Likewise.
  58         * ctf-string.c: Likewise.
  59         * ctf-subr.c: Likewise.
  60         * ctf-types.c: Likewise.
  61         * ctf-util.c: Likewise.
  62         * ctf-open.c: Likewise.
  63         (ctf_file_close): Rename to...
  64         (ctf_dict_close): ...this.
  65         (ctf_file_close): New trivial wrapper around ctf_dict_close, for
  66         compatibility.
  67         (ctf_parent_file): Rename to...
  68         (ctf_parent_dict): ... this.
  69         (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
  70         compatibility.
  71         * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
  72
  73 2020-10-21  Tom Tromey  <tromey@adacore.com>
  74
  75         * mkerrors.sed: Remove.
  76         * ctf-error.c (_CTF_FIRST): New define.
  77         (_CTF_ITEM): Define this, not _CTF_STR.
  78         (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
  79         (ERRSTRFIELD): Rewrite.
  80         (ERRSTRFIELD1): Remove.
  81         * Makefile.in: Rebuild.
  82         * Makefile.am (BUILT_SOURCES): Remove.
  83         (ctf-error.h): Remove.
  84
  85 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
  86
  87         * ctf-subr.c (open_errors): New list.
  88         (ctf_err_warn): Calls with NULL fp append to open_errors.  Add err
  89         parameter, and use it to decorate the debug stream with errmsgs.
  90         (ctf_err_warn_to_open): Splice errors from a CTF dict into the
  91         open_errors.
  92         (ctf_errwarning_next): Calls with NULL fp report from open_errors.
  93         New err param to report iteration errors (including end-of-iteration)
  94         when fp is NULL.
  95         (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
  96         parameter: gettextize.
  97         * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
  98         (LCTF_VBYTES): Adjust.
  99         (ctf_err_warn_to_open): New.
 100         (ctf_err_warn): Adjust.
 101         (ctf_bundle): Used in only one place: move...
 102         * ctf-create.c: ... here.
 103         (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
 104         down as needed.  Don't emit the errmsg.  Gettextize.
 105         (membcmp): Likewise.
 106         (ctf_add_type_internal): Likewise.
 107         (ctf_write_mem): Likewise.
 108         (ctf_compress_write): Likewise.  Report errors writing the header or
 109         body.
 110         (ctf_write): Likewise.
 111         * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
 112         ctf_dprintf, and gettextize, as above.
 113         (ctf_arc_write): Likewise.
 114         (ctf_arc_bufopen): Likewise.
 115         (ctf_arc_open_internal): Likewise.
 116         * ctf-labels.c (ctf_label_iter): Likewise.
 117         * ctf-open-bfd.c (ctf_bfdclose): Likewise.
 118         (ctf_bfdopen): Likewise.
 119         (ctf_bfdopen_ctfsect): Likewise.
 120         (ctf_fdopen): Likewise.
 121         * ctf-string.c (ctf_str_write_strtab): Likewise.
 122         * ctf-types.c (ctf_type_resolve): Likewise.
 123         * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
 124         (get_vbytes_v1): Pass down the ctf dict.
 125         (get_vbytes_v2): Likewise.
 126         (flip_ctf): Likewise.
 127         (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
 128         gettextize, as above.
 129         (upgrade_types_v1): Adjust calls.
 130         (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
 131         (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
 132         emitted into individual dicts into the open errors if this turns
 133         out to be a failed open in the end.
 134         * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
 135         argument.  Gettextize.  Don't emit the errmsg.
 136         (ctf_dump_funcs): Likewise.  Collapse err label into its only case.
 137         (ctf_dump_type): Likewise.
 138         * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
 139         argument.  Gettextize.  Don't emit the errmsg.
 140         (ctf_link_one_type): Likewise.
 141         (ctf_link_lazy_open): Likewise.
 142         (ctf_link_one_input_archive): Likewise.
 143         (ctf_link_deduplicating_count_inputs): Likewise.
 144         (ctf_link_deduplicating_open_inputs): Likewise.
 145         (ctf_link_deduplicating_close_inputs): Likewise.
 146         (ctf_link_deduplicating): Likewise.
 147         (ctf_link): Likewise.
 148         (ctf_link_deduplicating_per_cu): Likewise. Add some missed
 149         ctf_set_errnos to obscure error cases.
 150         * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
 151         err argument.  Gettextize.  Don't emit the errmsg.
 152         (ctf_dedup_populate_mappings): Likewise.
 153         (ctf_dedup_detect_name_ambiguity): Likewise.
 154         (ctf_dedup_init): Likewise.
 155         (ctf_dedup_multiple_input_dicts): Likewise.
 156         (ctf_dedup_conflictify_unshared): Likewise.
 157         (ctf_dedup): Likewise.
 158         (ctf_dedup_rwalk_one_output_mapping): Likewise.
 159         (ctf_dedup_id_to_target): Likewise.
 160         (ctf_dedup_emit_type): Likewise.
 161         (ctf_dedup_emit_struct_members): Likewise.
 162         (ctf_dedup_populate_type_mapping): Likewise.
 163         (ctf_dedup_populate_type_mappings): Likewise.
 164         (ctf_dedup_emit): Likewise.
 165         (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
 166         status setting.
 167         (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
 168         unknown-type-kind messages (which signify file corruption).
 169
 170 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 171
 172         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
 173         declare this to be version 1.2.0.
 174         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
 175         * Makefile.in: Regenerated.
 176         * configure: Regenerated.
 177         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
 178         * ctf-impl.h: Include it.
 179         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
 180         (ctf_errmsg): Actually translate them.
 181
 182 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 183
 184         PR binutils/25155:
 185         * ctf-create.c (EOVERFLOW): If not defined by system header,
 186         redirect to ERANGE as a poor man's substitute.
 187         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
 188
 189 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 190
 191         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
 192         (ctf_dtd_delete): Likewise.
 193         (ctf_dtd_lookup): Likewise.
 194         (ctf_rollback): Likewise.
 195         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
 196         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
 197
 198 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 199
 200         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
 201
 202 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 203
 204         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
 205         number if needed.
 206
 207 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 208
 209         * ctf-impl.h (ctf_list_splice): New.
 210         * ctf-util.h (ctf_list_splice): Likewise.
 211         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
 212         (ctf_link_sort_inputs): Likewise.
 213         (ctf_link_deduplicating_count_inputs): Likewise.
 214         (ctf_link_deduplicating_open_inputs): Likewise.
 215         (ctf_link_deduplicating_close_inputs): Likewise.
 216         (ctf_link_deduplicating_variables): Likewise.
 217         (ctf_link_deduplicating_per_cu): Likewise.
 218         (ctf_link_deduplicating): Likewise.
 219         (ctf_link): Call it.
 220
 221 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 222
 223         * ctf-link.c (ctf_link_one_input_archive_member): Check
 224         CTF_LINK_OMIT_VARIABLES_SECTION.
 225
 226 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 227
 228         * ctf-impl.h (ctf_type_id_key): New, the key in the
 229         cd_id_to_file_t.
 230         (ctf_dedup): New, core deduplicator state.
 231         (ctf_file_t) <ctf_dedup>: New.
 232         <ctf_dedup_atoms>: New.
 233         <ctf_dedup_atoms_alloc>: New.
 234         (ctf_hash_type_id_key): New prototype.
 235         (ctf_hash_eq_type_id_key): Likewise.
 236         (ctf_dedup_atoms_init): Likewise.
 237         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
 238         (ctf_dedup_atoms_init): Likewise.
 239         * ctf-create.c (ctf_serialize): Adjusted.
 240         (ctf_add_encoded): No longer static.
 241         (ctf_add_reftype): Likewise.
 242         * ctf-open.c (ctf_file_close): Destroy the
 243         ctf_dedup_atoms_alloc.
 244         * ctf-dedup.c: New file.
 245         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
 246         * configure.ac: Check for stpcpy.
 247         * Makefile.am: Add it.
 248         * Makefile.in: Regenerate.
 249         * config.h.in: Regenerate.
 250         * configure: Regenerate.
 251
 252 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 253
 254         * configure.ac: Add --enable-libctf-hash-debugging.
 255         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
 256         * Makefile.in: Regenerated.
 257         * configure: Likewise.
 258         * config.h.in: Likewise.
 259         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
 260         (ctf_assert): Define to assert.
 261
 262 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 263
 264         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
 265         sha1_process_bytes.
 266         * ctf-impl.h: Include it.
 267         (ctf_sha1_init): New.
 268         (ctf_sha1_add): Likewise.
 269         (ctf_sha1_fini): Likewise.
 270         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 271         producing strings.
 272         * Makefile.am: Add file.
 273         * Makefile.in: Regenerate.
 274
 275 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 276
 277         * libctf.ver (ctf_link_set_variable_filter): Add.
 278         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 279         <ctf_link_variable_filter_arg>: Likewise.
 280         * ctf-create.c (ctf_serialize): Adjust.
 281         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 282         (ctf_link_one_variable): Call it if set.
 283
 284 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 285
 286         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 287         conflicts, not the source type.
 288
 289 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 290
 291         * ctf-impl.h (ctf_file_t): Improve comments.
 292         <ctf_link_cu_mapping>: Split into...
 293         <ctf_link_in_cu_mapping>: ... this...
 294         <ctf_link_out_cu_mapping>: ... and this.
 295         * ctf-create.c (ctf_serialize): Adjust.
 296         * ctf-open.c (ctf_file_close): Likewise.
 297         * ctf-link.c (ctf_create_per_cu): Look things up in the
 298         in_cu_mapping instead of the cu_mapping.
 299         (ctf_link_add_cu_mapping): The deduplicating link will define
 300         what happens if many FROMs share a TO.
 301         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 302         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 303         create per-CU dicts here: they are already created when needed.
 304         (ctf_link_one_variable): Log a debug message if we skip a
 305         variable due to its type being concealed in a CU-mapped link.
 306         (This is probably too common a case to make into a warning.)
 307         (ctf_link): Create empty per-CU dicts if requested.
 308
 309 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 310
 311         * ctf-link.c (ctf_link_write): Close the fd.
 312
 313 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 314
 315         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 316         * Makefile.in: Regenerated.
 317         * ctf-impl.h (ctf_link_input_name): New.
 318         (ctf_file_t) <ctf_link_flags>: New.
 319         * ctf-create.c (ctf_serialize): Adjust accordingly.
 320         * ctf-link.c: Define ctf_open as weak when PIC.
 321         (ctf_arc_close_thunk): Remove unnecessary thunk.
 322         (ctf_file_close_thunk): Likewise.
 323         (ctf_link_input_name): New.
 324         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 325         (ctf_link_input_close): Adjust accordingly.
 326         (ctf_link_add_ctf_internal): New, split from...
 327         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 328         CTF is not possible.  Change to just call...
 329         (ctf_link_add): ... this new function.
 330         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 331         ctf_file_close_thunk.
 332         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 333         <in_file_name>: ... this.
 334         <arcname>: Drop.
 335         <share_mode>: Likewise (migrated to ctf_link_flags).
 336         <done_main_member>: Rename to...
 337         <done_parent>: ... this.
 338         <main_input_fp>: Rename to...
 339         <in_fp_parent>: ... this.
 340         <cu_mapped>: New.
 341         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 342         ctf_err_warn, removing a TODO.
 343         (ctf_link_one_variable): Note a case too common to warn about.
 344         Report in the debug stream if a cu-mapped link prevents addition
 345         of a conflicting variable.
 346         (ctf_link_one_input_archive_member): Adjust.
 347         (ctf_link_lazy_open): New, open a CTF archive for linking when
 348         needed.
 349         (ctf_link_close_one_input_archive): New, close it again.
 350         (ctf_link_one_input_archive): Adjust for lazy opening, member
 351         renames, and ctf_err_warn transition.  Move the
 352         empty_link_type_mapping call to...
 353         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 354         Don't spuriously fail if some input contains no CTF data.
 355         (ctf_link_write): ctf_err_warn transition.
 356         * libctf.ver: Remove not-yet-stable comment.
 357
 358 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 359
 360         * ctf-impl.h (ctf_strerror): Delete.
 361         * ctf-subr.c (ctf_strerror): Likewise.
 362         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 363         strerror directly.
 364
 365 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 366
 367         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 368         (ctf_import_unref): New.
 369         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 370         zero.  Don't recurse back in if the refcount is already zero.
 371         (ctf_import): Check ctf_parent_unreffed before deciding whether
 372         to close a pre-existing parent.  Set it to zero.
 373         (ctf_import_unreffed): New, as above, setting
 374         ctf_parent_unreffed to 1.
 375         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 376         child: use direct assignment, and set unreffed on the new and
 377         old children.
 378         * ctf-link.c (ctf_create_per_cu): Import the parent using
 379         ctf_import_unreffed.
 380
 381 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 382
 383         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 384         (ctf_link_type_key): ... this, adjusting member prefixes to
 385         match.
 386         (ctf_hash_type_mapping_key): Rename to...
 387         (ctf_hash_type_key): ... this.
 388         (ctf_hash_eq_type_mapping_key): Rename to...
 389         (ctf_hash_eq_type_key): ... this.
 390         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 391         (ctf_hash_type_key): ... this, and adjust for member name
 392         changes.
 393         (ctf_hash_eq_type_mapping_key): Rename to...
 394         (ctf_hash_eq_type_key): ... this, and adjust for member name
 395         changes.
 396         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 397         need for out-of-memory checking in this code.
 398         (ctf_type_mapping): Adjust.
 399
 400 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 401
 402         configure.ac: Check for vasprintf.
 403         configure: Regenerated.
 404         config.h.in: Likewise.
 405
 406 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 407
 408         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 409
 410 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 411
 412         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 413         New.
 414         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 415         if the input has no symtab, rather than dividing by
 416         zero. Arrange to free it later via ctfi_free_ctfsect.
 417         * ctf-archive.c (ctf_new_archive_internal): Do not
 418         ctfi_free_strsect by default.
 419         (ctf_arc_close): Possibly free it here.
 420
 421 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 422
 423         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 424         (ctf_dump_format_type): improve slice formatting.  Always print
 425         the type size, even of slices.
 426         (ctf_dump_member): Print slices (-> bitfields) differently from
 427         non-slices.  Failure to format a type is not an OOM.
 428
 429 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 430
 431         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 432         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 433         (ctf_dump_objts): Likewise.
 434         (ctf_dump_var): Likewise.
 435         (ctf_dump_type): Do not emit a duplicate message.  Move to
 436         ctf_err_warning, and swallow all errors.
 437
 438 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 439
 440         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 441         (ctf_decl_buf): Once it escapes, don't try to free it later.
 442
 443 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 444
 445         * ctf-types.c (ctf_type_aname): Print arg types here...
 446         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 447         in the type name here.
 448
 449 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 450
 451         * ctf-impl.h (ctf_assert): New.
 452         (ctf_err_warning_t): Likewise.
 453         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 454         (ctf_err_warn): New prototype.
 455         (ctf_assert_fail_internal): Likewise.
 456         * ctf-inlines.h (ctf_assert_internal): Likewise.
 457         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 458         * ctf-create.c (ctf_serialize): Copy it on serialization.
 459         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 460         (ctf_errwarning_next): New iterator, free and pass back
 461         errors/warnings in succession.
 462         * libctf.ver (ctf_errwarning_next): Add.
 463
 464 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 465
 466         * ctf-types.c (ctf_variable_iter): Fix error return.
 467
 468 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 469
 470         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 471
 472 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 473
 474         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 475
 476 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 477
 478         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 479         sorting functions.
 480         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 481         ctf_dynhash_next_sorted.
 482         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 483         <cu.ctn_s>: New, pointer to the dynset under iteration.
 484         (ctf_hash_sort_f): Sorting function passed to...
 485         (ctf_dynhash_next_sorted): ... this new function.
 486         (ctf_dynhash_next): New.
 487         (ctf_dynset_next): New.
 488         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 489         (ctf_dynhash_cnext): New.
 490         (ctf_dynset_cnext): New.
 491         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 492         (ctf_dynhash_next): New.
 493         (ctf_dynset_next): New.
 494         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 495         needed.
 496         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 497
 498 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 499
 500         * ctf-impl.h (ctf_next): New.
 501         (ctf_get_dict): New prototype.
 502         * ctf-lookup.c (ctf_get_dict): New, split out of...
 503         (ctf_lookup_by_id): ... here.
 504         * ctf-util.c (ctf_next_create): New.
 505         (ctf_next_destroy): New.
 506         (ctf_next_copy): New.
 507         * ctf-types.c (includes): Add <assert.h>.
 508         (ctf_member_next): New.
 509         (ctf_enum_next): New.
 510         (ctf_type_iter): Document the lack of iteration over parent
 511         types.
 512         (ctf_type_next): New.
 513         (ctf_variable_next): New.
 514         * ctf-archive.c (ctf_archive_next): New.
 515         * libctf.ver: Add new public functions.
 516
 517 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 518
 519         * libctf.ver (ctf_ref): New.
 520         * ctf-open.c (ctf_ref): Implement it.
 521
 522 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 523
 524         * ctf-inlines.h (ctf_forwardable_kind): New.
 525         * ctf-create.c (ctf_add_forward): Use it.
 526
 527 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 528
 529         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 530         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 531
 532 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 533
 534         * ctf-hash.c (ctf_dynset_eq_string): New.
 535         (ctf_dynset_create): New.
 536         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 537         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 538         (key_to_internal): New.
 539         (internal_to_key): New.
 540         (ctf_dynset_insert): New.
 541         (ctf_dynset_remove): New.
 542         (ctf_dynset_destroy): New.
 543         (ctf_dynset_lookup): New.
 544         (ctf_dynset_exists): New.
 545         (ctf_dynset_lookup_any): New.
 546         (ctf_hash_insert_type): Coding style.
 547         (ctf_hash_define_type): Likewise.
 548         * ctf-impl.h (ctf_dynset_t): New.
 549         (ctf_dynset_eq_string): New.
 550         (ctf_dynset_create): New.
 551         (ctf_dynset_insert): New.
 552         (ctf_dynset_remove): New.
 553         (ctf_dynset_destroy): New.
 554         (ctf_dynset_lookup): New.
 555         (ctf_dynset_exists): New.
 556         (ctf_dynset_lookup_any): New.
 557         * ctf-inlines.h (ctf_dynset_cinsert): New.
 558
 559 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 560
 561         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 562         <value_free>: Likewise.
 563         <owner>: New.
 564         (ctf_dynhash_item_free): Indirect through the owner.
 565         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 566         allocate space for the key_free and value_free fields fields
 567         if necessary.
 568         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 569         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 570         value_free if they will exist.  Set the slot's owner, but only
 571         if it exists.
 572         (ctf_dynhash_remove): Adjust.
 573
 574 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 575
 576         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 577         there is a key-freeing function and the key already exists.
 578
 579 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 580
 581         * ctf-inlines.h: New file.
 582         * ctf-impl.h: Include it.
 583         (ctf_hash_iter_find_f): New typedef.
 584         (ctf_dynhash_elements): New.
 585         (ctf_dynhash_lookup_kv): New.
 586         (ctf_dynhash_iter_find): New.
 587         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 588         (ctf_traverse_find_cb_arg_t): New.
 589         (ctf_hashtab_traverse_find): New.
 590         (ctf_dynhash_iter_find): New.
 591         (ctf_dynhash_elements): New.
 592
 593 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 594
 595         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 596
 597 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 598
 599         * ctf-archive.c (ctf_archive_count): New.
 600         * libctf.ver: New public function.
 601
 602 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 603
 604         * ctf-types.c (ctf_member_count): New.
 605         * libctf.ver: New public function.
 606
 607 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 608
 609         * ctf-types.c (ctf_type_kind_forwarded): New.
 610
 611 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 612
 613         * ctf-types.c (ctf_type_name_raw): New.
 614         (ctf_type_aname_raw): Reimplement accordingly.
 615
 616 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 617
 618         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 619
 620 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 621
 622         * ctf-impl.h (struct ctf_archive_internal)
 623         <ctfi_unmap_on_close>: New.
 624         (ctf_new_archive_internal): Adjust.
 625         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 626         Initialize ctfi_unmap_on_close.  Adjust error path.
 627         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 628         (unmap_on_close is 0).
 629         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 630         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 631
 632 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 633
 634         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 635         ints, floats or typedefs have no name.  Fix comment typo.
 636
 637 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 638
 639         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 640         resolves to an integral type.
 641         * ctf-types.c (ctf_type_encoding): Resolve the type before
 642         fishing its encoding out.
 643
 644 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 645
 646         * ctf-create.c (ctf_create): Mark dirty.
 647
 648 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 649
 650         * ctf-create.c (membcmp)  Skip nameless members.
 651
 652 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 653
 654         * ctf-create.c (ctf_add_member_offset): Support names of ""
 655         as if they were the null pointer.
 656
 657 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 658
 659         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 660         special-casing.
 661
 662 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 663
 664         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 665
 666 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 667
 668         * ctf-create.c (ctf_serialize): Add cast.
 669         (ctf_add_slice): Likewise.
 670
 671 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 672
 673         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 674         * ctf-create.c (ctf_add_function): Check for unimplemented type
 675         and populate at the same time.  Populate one-by-one, not via
 676         memcpy.
 677         (ctf_serialize): Remove unnecessary cast.
 678         * ctf-types.c (ctf_func_type_info): Likewise.
 679         (ctf_func_type_args): Likewise.  Fix comment typo.
 680
 681 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 682
 683         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 684         (ctf_add_array): Support array contents of type zero.
 685         (ctf_add_function): Support arguments and return types of
 686         type zero.
 687         (ctf_add_typedef): Support typedefs to type zero.
 688         (ctf_add_member_offset): Support members of type zero,
 689         unless added at unspecified (naturally-aligned) offset.
 690
 691 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 692
 693         * ctf-error.c: Include <stddef.h>, for offsetof.
 694         (_ctf_errlist): Migrate to...
 695         (_ctf_errlist_t): ... this.
 696         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 697         (_ctf_nerr): Remove.
 698         (ctf_errmsg): Adjust accordingly.
 699         * Makefile.am (BUILT_SOURCES): Note...
 700         (ctf-error.h): ... this new rule.
 701         * Makefile.in: Regenerate.
 702         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 703         * .gitignore: New, ignore ctf-error.h.
 704
 705 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 706
 707         * ctf-impl.h: Fix typos in comments.
 708
 709 2020-07-22  Nick Clifton  <nickc@redhat.com>
 710
 711         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 712         same file descriptor.
 713
 714 2020-07-04  Nick Clifton  <nickc@redhat.com>
 715
 716         Binutils 2.35 branch created.
 717
 718 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 719
 720         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 721         alphabetical order.
 722         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 723         * config.h.in: Regenerated.
 724         * Makefile.in: Likewise.
 725         * configure: Likewise.
 726
 727 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 728
 729         * ctf-create.c: Include <unistd.h>.
 730         * ctf-open-bfd.c: Likewise.
 731
 732 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 733
 734         PR libctf/25120
 735         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 736         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 737         means this is declared.
 738         (bswap_32): Likewise.
 739         (bswap_64): Likewise.
 740         (bswap_identity_64): Remove, unused.
 741         * configure: Regenerated.
 742         * config.h.in: Likewise.
 743
 744 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 745
 746         PR libctf/25120
 747         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 748         (_libctf_unlikely_): Likewise.
 749         (_libctf_unused): Likewise.
 750         (_libctf_malloc_): Likewise.
 751
 752 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 753
 754         PR libctf/25120
 755         * ctf-archive.c (search_nametbl): No longer global: declare...
 756         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 757         (search_modent_by_name): Take and use ARG for the nametbl.
 758
 759 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 760
 761         * ctf-impl.h (ctf_new_archive_internal): Declare.
 762         (ctf_arc_bufopen): Remove.
 763         (ctf_archive_internal) <ctfi_free_symsect>: New.
 764         * ctf-archive.c (ctf_arc_close): Use it.
 765         (ctf_arc_bufopen): Fuse into...
 766         (ctf_new_archive_internal): ... this, moved across from...
 767         * ctf-open-bfd.c: ... here.
 768         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 769         * libctf.ver: Add it.
 770
 771 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 772
 773         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 774         (ctf_dtd_delete): Remove correspondingly.
 775         (ctf_rollback): Likewise.
 776
 777 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 778
 779         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 780         unchanged.
 781
 782 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 783
 784         * ctf-create.c (ctf_add_forward): Don't add forwards to
 785         types that already exist.
 786
 787 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 788
 789         * ctf-open.c (init_types): Only intern root-visible types.
 790         * ctf-create.c (ctf_dtd_insert): Likewise.
 791         (ctf_dtd_delete): Only remove root-visible types.
 792         (ctf_rollback): Likewise.
 793         (ctf_add_generic): Adjust.
 794         (ctf_add_struct_sized): Adjust comment.
 795         (ctf_add_union_sized): Likewise.
 796         (ctf_add_enum): Likewise.
 797         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 798
 799 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 800
 801         * swap.h (bswap_identity_64): Make static.
 802
 803 2020-01-18  Nick Clifton  <nickc@redhat.com>
 804
 805         Binutils 2.34 branch created.
 806
 807 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 808
 809         PR binutils/25155:
 810         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 811         * configure, config.h.in: Regenerate.
 812
 813 2020-01-01  Alan Modra  <amodra@gmail.com>
 814
 815         Update year range in copyright notice of all files.
 816
 817 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 818
 819         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 820
 821 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 822
 823         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 824         * ctf-types.c (ctf_type_lname): Likewise.
 825
 826 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 827
 828         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 829         ctf_import after the first for a given file.
 830
 831 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 832
 833         * ctf-impl.h (ctf_str_append_noerr): Declare.
 834         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 835         ctf_str_append.
 836         * ctf-dump.c (str_append): New, call it.
 837         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 838         (ctf_dump_label): Likewise.
 839         (ctf_dump_objts): Likewise.
 840         (ctf_dump_funcs): Likewise.
 841         (ctf_dump_var): Likewise.
 842         (ctf_dump_member): Likewise.
 843         (ctf_dump_type): Likewise.
 844         (ctf_dump): Likewise.
 845
 846 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 847
 848         * ctf-impl.h (ctf_alloc): Remove.
 849         (ctf_free): Likewise.
 850         (ctf_strdup): Likewise.
 851         * ctf-subr.c (ctf_alloc): Remove.
 852         (ctf_free): Likewise.
 853         * ctf-util.c (ctf_strdup): Remove.
 854
 855         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 856         ctf_free; strdup, not ctf_strdup.
 857         (ctf_dtd_delete): Likewise.
 858         (ctf_dvd_delete): Likewise.
 859         (ctf_add_generic): Likewise.
 860         (ctf_add_function): Likewise.
 861         (ctf_add_enumerator): Likewise.
 862         (ctf_add_member_offset): Likewise.
 863         (ctf_add_variable): Likewise.
 864         (membadd): Likewise.
 865         (ctf_compress_write): Likewise.
 866         (ctf_write_mem): Likewise.
 867         * ctf-decl.c (ctf_decl_push): Likewise.
 868         (ctf_decl_fini): Likewise.
 869         (ctf_decl_sprintf): Likewise.  Check for OOM.
 870         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 871         ctf_free; strdup, not ctf_strdup.
 872         (ctf_dump_free): Likewise.
 873         (ctf_dump): Likewise.
 874         * ctf-open.c (upgrade_types_v1): Likewise.
 875         (init_types): Likewise.
 876         (ctf_file_close): Likewise.
 877         (ctf_bufopen_internal): Likewise.  Check for OOM.
 878         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 879         (ctf_cuname_set): Likewise.
 880         (ctf_import): Likewise.
 881         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 882         free, not ctf_free; strdup, not ctf_strdup.
 883         (ctf_str_free_atom): Likewise.
 884         (ctf_str_create_atoms): Likewise.
 885         (ctf_str_add_ref_internal): Likewise.
 886         (ctf_str_remove_ref): Likewise.
 887         (ctf_str_write_strtab): Likewise.
 888
 889 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 890
 891         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 892         work right for non-int/fps.
 893
 894 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 895
 896         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 897         null pointer.
 898
 899 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 900
 901         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 902         * ctf-open.c (ctf_file_close): Free it.
 903         * ctf-create.c (ctf_serialize): Adjust.
 904         (membcmp): When reporting a conflict due to an error, report the
 905         error.
 906         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 907         (ctf_add_type_internal): ... this.  Hand back types we are already
 908         in the middle of adding immediately.  Hand back structs/unions with
 909         the same number of members immediately.  Do not walk the dynamic
 910         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 911         forwards promoted to other types and the inverse case identically.
 912         Add structs to the mapping as soon as we intern them, before they
 913         gain any members.
 914
 915 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 916
 917         * ctf-impl.h (ctf_names_t): New.
 918         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 919         (ctf_file_t) <ctf_structs>: Likewise.
 920         <ctf_unions>: Likewise.
 921         <ctf_enums>: Likewise.
 922         <ctf_names>: Likewise.
 923         <ctf_lookups>: Improve comment.
 924         <ctf_ptrtab_len>: New.
 925         <ctf_prov_strtab>: New.
 926         <ctf_str_prov_offset>: New.
 927         <ctf_dtbyname>: Remove, redundant to the names hashes.
 928         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 929         (ctf_dtdef_t) <dtd_name>: Remove.
 930         <dtd_data>: Note that the ctt_name is now populated.
 931         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 932         offset for internal strings too.
 933         <csa_external_offset>: New, the external strtab offset.
 934         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 935         (ctf_name_table): New declaration.
 936         (ctf_lookup_by_rawname): Likewise.
 937         (ctf_lookup_by_rawhash): Likewise.
 938         (ctf_set_ctl_hashes): Likewise.
 939         (ctf_serialize): Likewise.
 940         (ctf_dtd_insert): Adjust.
 941         (ctf_simple_open_internal): Likewise.
 942         (ctf_bufopen_internal): Likewise.
 943         (ctf_list_empty_p): Likewise.
 944         (ctf_str_remove_ref): Likewise.
 945         (ctf_str_add): Returns uint32_t now.
 946         (ctf_str_add_ref): Likewise.
 947         (ctf_str_add_external): Now returns a boolean (int).
 948         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 949         for strings in the appropriate range.
 950         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 951         when adding the null string to the new strtab.
 952         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 953         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 954         make_provisional, populate the offset and fill in the
 955         ctf_prov_strtab accordingly.
 956         (ctf_str_add): Return the offset, not the string.
 957         (ctf_str_add_ref): Likewise.
 958         (ctf_str_add_external): Return a success integer.
 959         (ctf_str_remove_ref): New, remove a single ref.
 960         (ctf_str_count_strtab): Do not count the initial null string's
 961         length or the existence or length of any unreferenced internal
 962         atoms.
 963         (ctf_str_populate_sorttab): Skip atoms with no refs.
 964         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 965         to the cts_len for the null string, since it is no longer done
 966         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 967         Populate the csa_offset for both internal and external cases.
 968         Flush the ctf_prov_strtab afterwards, and reset the
 969         ctf_str_prov_offset.
 970         * ctf-create.c (ctf_grow_ptrtab): New.
 971         (ctf_create): Call it.  Initialize new fields rather than old
 972         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 973         Set the ctl hashes and data model.
 974         (ctf_update): Rename to...
 975         (ctf_serialize): ... this.  Leave a compatibility function behind.
 976         Tell ctf_simple_open_internal that this is a writable dictionary.
 977         Pass the new fields along from the old dictionary.  Drop
 978         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 979         Do not zero out the DTD's ctt_name.
 980         (ctf_prefixed_name): Rename to...
 981         (ctf_name_table): ... this.  No longer return a prefixed name: return
 982         the applicable name table instead.
 983         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 984         kind we're adding.  Migrate away from dtd_name.
 985         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 986         deleted ctt_name.
 987         (ctf_dtd_lookup_type_by_name): Remove.
 988         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 989         No longer check ctf_dtnextid: check ctf_typemax instead.
 990         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 991         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 992         ctf_name_table and the right name table, and migrate away from
 993         dtd_name as in ctf_dtd_delete.
 994         (ctf_add_generic): Pass in the kind explicitly and pass it to
 995         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 996         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 997         Grow the ptrtab if needed.
 998         (ctf_add_encoded): Pass in the kind.
 999         (ctf_add_slice): Likewise.
1000         (ctf_add_array): Likewise.
1001         (ctf_add_function): Likewise.
1002         (ctf_add_typedef): Likewise.
1003         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1004         ctt_name rather than dtd_name.
1005         (ctf_add_struct_sized): Pass in the kind.  Use
1006         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1007         ctf_dtd_lookup_type_by_name.
1008         (ctf_add_union_sized): Likewise.
1009         (ctf_add_enum): Likewise.
1010         (ctf_add_enum_encoded): Likewise.
1011         (ctf_add_forward): Likewise.
1012         (ctf_add_type): Likewise.
1013         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1014         being initialized until after the call.
1015         (ctf_write_mem): Likewise.
1016         (ctf_write): Likewise.
1017         * ctf-archive.c (arc_write_one_ctf): Likewise.
1018         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1019         ctf_hash_lookup_type.
1020         (ctf_lookup_by_id): No longer check the readonly types if the
1021         dictionary is writable.
1022         * ctf-open.c (init_types): Assert that this dictionary is not
1023         writable.  Adjust to use the new name hashes, ctf_name_table,
1024         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
1025         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
1026         if set.  Drop out early when dictionary is writable.  Split the
1027         ctf_lookups initialization into...
1028         (ctf_set_cth_hashes): ... this new function.
1029         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
1030         (ctf_simple_open): Adjust accordingly.
1031         (ctf_bufopen): Likewise.
1032         (ctf_file_close): Destroy the appropriate name hashes.  No longer
1033         destroy ctf_dtbyname, which is gone.
1034         (ctf_getdatasect): Remove spurious "extern".
1035         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1036         specified name table, given a kind.
1037         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1038         (ctf_member_iter): Add support for iterating over the
1039         dynamic type list.
1040         (ctf_enum_iter): Likewise.
1041         (ctf_variable_iter): Likewise.
1042         (ctf_type_rvisit): Likewise.
1043         (ctf_member_info): Add support for types in the dynamic type list.
1044         (ctf_enum_name): Likewise.
1045         (ctf_enum_value): Likewise.
1046         (ctf_func_type_info): Likewise.
1047         (ctf_func_type_args): Likewise.
1048         * ctf-link.c (ctf_accumulate_archive_names): No longer call
1049         ctf_update.
1050         (ctf_link_write): Likewise.
1051         (ctf_link_intern_extern_string): Adjust for new
1052         ctf_str_add_external return value.
1053         (ctf_link_add_strtab): Likewise.
1054         * ctf-util.c (ctf_list_empty_p): New.
1055
1056 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
1057
1058         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1059         type zero.
1060         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1061         members and types.
1062         (ctf_add_variable): Likewise for variables pointing to them.
1063         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1064         type link failure, but do warn for others.
1065         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
1066         errors to be ENOMEM.
1067         (ctf_dump_member): Likewise.
1068         (ctf_dump_type): Likewise.
1069         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1070         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1071         (ctf_dump_header): Likewise.
1072         (ctf_dump_label): likewise.
1073         (ctf_dump_objts): likewise.
1074         (ctf_dump_funcs): likewise.
1075         (ctf_dump_var): likewise.
1076         (ctf_dump_str): Likewise.
1077
1078 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
1079
1080         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1081         (LT_INIT): Likewise.
1082         (AM_INSTALL_LIBBFD): Likewise.
1083         (dlopen): Note why this is necessary in a comment.
1084         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1085         opcodes/.
1086         (SHARED_LDFLAGS): Likewise.
1087         (BFD_LIBADD): Likewise, for libbfd.
1088         (BFD_DEPENDENCIES): Likewise.
1089         (VERSION_FLAGS): Initialize, using a version script if ld supports
1090         one, or libtool -export-symbols-regex otherwise.
1091         (AC_CONFIG_MACRO_DIR): Add ../BFD.
1092         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1093         (INCDIR): New.
1094         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1095         (noinst_LIBRARIES): Replace with...
1096         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1097         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1098         libctf-nobfd.la as well.
1099         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1100         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1101         (libctf_a_SOURCES): Rename to...
1102         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1103         ctf-open-bfd.c.
1104         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1105         with ctf-open-bfd.c added.
1106         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1107         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1108         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1109         * Makefile.am [INSTALL_LIBCTF]: Use it.
1110         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1111         libtool macros.
1112         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1113         the unstable components).
1114         * Makefile.in: Regenerated.
1115         * config.h.in: Likewise.
1116         * configure: Likewise.
1117
1118 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1119
1120         * configure.ac (INSTALL_LIBCTF): New, controlled by
1121         --enable-install-libctf.
1122         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1123         * Makefile.in: Regenerated.
1124         * configure: Regenerated.
1125
1126 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1127
1128         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1129         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1130
1131 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1132
1133         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1134
1135 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1136
1137         * ctf-impl.h (includes): Include <sys/param.h> here.
1138
1139 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1140
1141         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1142         (flip_objts): Likewise.
1143         (flip_vars): Likewise.
1144         (flip_types): Likewise.
1145
1146 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1147
1148         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1149         freeing functions: if set, free the key and value if the slot
1150         already exists.  Always reassign the key.
1151         (ctf_dynhash_insert): Adjust call appropriately.
1152         (ctf_hash_insert_type): Likewise.
1153
1154 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
1155
1156         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1157         type kind.  Allow forwards to unify with pre-existing structs/
1158         unions/enums.
1159
1160 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1161
1162         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1163         <ctf_link_memb_name_changer>: Likewise.
1164         <ctf_link_memb_name_changer_arg>: Likewise.
1165         * ctf-create.c (ctf_update): Update accordingly.
1166         * ctf-open.c (ctf_file_close): Likewise.
1167         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1168         (ctf_link_add_cu_mapping): New.
1169         (ctf_link_set_memb_name_changer): Likewise.
1170         (ctf_change_parent_name): New.
1171         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1172         allocated by the caller's ctf_link_memb_name_changer.
1173         <ndynames>: Likewise.
1174         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1175         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1176         ctf_change_parent_name.  Free any resulting names.
1177
1178 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1179
1180         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1181         (ctf_link_one_type): ... here, with parent-name setting added.
1182         (check_variable): New.
1183         (ctf_link_one_variable): Likewise.
1184         (ctf_link_one_input_archive_member): Call it.
1185         * ctf-error.c (_ctf_errlist): Updated with new errors.
1186
1187 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1188
1189         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1190         (struct ctf_link_type_mapping_key): New.
1191         (ctf_hash_type_mapping_key): Likewise.
1192         (ctf_hash_eq_type_mapping_key): Likewise.
1193         (ctf_add_type_mapping): Likewise.
1194         (ctf_type_mapping): Likewise.
1195         (ctf_dynhash_empty): Likewise.
1196         * ctf-open.c (ctf_file_close): Update accordingly.
1197         * ctf-create.c (ctf_update): Likewise.
1198         (ctf_add_type): Populate the mapping.
1199         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1200         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1201         (ctf_dynhash_insert): Fix comment typo.
1202         (ctf_dynhash_empty): New.
1203         * ctf-link.c (ctf_add_type_mapping): New.
1204         (ctf_type_mapping): Likewise.
1205         (empty_link_type_mapping): New.
1206         (ctf_link_one_input_archive): Call it.
1207
1208 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1209
1210         * ctf-link.c: New file, linking of the string and type sections.
1211         * Makefile.am (libctf_a_SOURCES): Add it.
1212         * Makefile.in: Regenerate.
1213
1214         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1215         ctf_link_outputs.
1216         * ctf-create.c (ctf_update): Update accordingly.
1217         * ctf-open.c (ctf_file_close): Likewise.
1218         * ctf-error.c (_ctf_errlist): Updated with new errors.
1219
1220 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1221
1222         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1223
1224 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1225
1226         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1227         ctf_type_iter.
1228         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1229         (ctf_dump_format_type): Add non-root-type { } notation.
1230         Add root flag to prototype.
1231         (ctf_dump_label): Adjust accordingly.
1232         (ctf_dump_objts): Likewise.
1233         (ctf_dump_var): Likewise.
1234
1235 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1236
1237         * ctf-create.c (ctf_compress_write): Fix double-free.
1238
1239 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1240
1241         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1242         of...
1243         (ctf_arc_write_fd): ... this new function.
1244         * ctf-create.c (ctf_write_mem): New.
1245
1246 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1247
1248         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1249         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1250         (ctf_str_add_ref): Name the last arg.
1251         (ctf_str_add_external) New.
1252         (ctf_str_add_strraw_explicit): Likewise.
1253         (ctf_simple_open_internal): Likewise.
1254         (ctf_bufopen_internal): Likewise.
1255
1256         * ctf-string.c (ctf_strraw_explicit): Split from...
1257         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1258         (ctf_str_add_ref_internal): Return the atom, not the
1259         string.
1260         (ctf_str_add): Adjust accordingly.
1261         (ctf_str_add_ref): Likewise.  Move up in the file.
1262         (ctf_str_add_external): New: update the csa_offset.
1263         (ctf_str_count_strtab): Only account for strings with no csa_offset
1264         in the internal strtab length.
1265         (ctf_str_write_strtab): If the csa_offset is set, update the
1266         string's refs without writing the string out, and update the
1267         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1268         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1269         (ctf_update): Handle failure to populate the strtab.  Pass in the
1270         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1271         Call ctf_simple_open_internal, not ctf_simple_open.
1272         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1273         strings by hand.
1274         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1275         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1276         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1277         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1278         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1279         (ctf_simple_open_internal): ... this new function, which calls
1280         ctf_bufopen_internal.
1281         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1282         (ctf_bufopen_internal): ... this new function, which sets
1283         ctf_syn_ext_strtab.
1284
1285 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1286
1287         * ctf_types.c (ctf_type_iter_all): New.
1288
1289 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1290
1291         * ctf-open.c (init_symtab): Check for overflow against the right
1292         section.
1293         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1294         (upgrade_types_v1): Note that these sections are not checked.
1295         (flip_header): Endian-swap the header fields.
1296         (flip_ctf): Endian-swap the sections.
1297         (flip_objts): Update comment.
1298         (ctf_bufopen): Check header offsets and alignment for validity.
1299
1300 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1301
1302         * ctf-open-bfd.c: Add <assert.h>.
1303         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1304         techniques borrowed from bfd_elf_sym_name.
1305         (ctf_new_archive_internal): Improve comment.
1306         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1307         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1308         no symbol section, but not vice versa.
1309
1310 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1311
1312         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1313         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1314         * ctf-dump.c (dump_header): New function, dump the CTF header.
1315         (ctf_dump): Call it.
1316         (ctf_dump_header_strfield): New function.
1317         (ctf_dump_header_sectfield): Likewise.
1318
1319 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1320
1321         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1322         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1323         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1324         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1325         Print out ctf_cuname: only print out ctf_parname if set.
1326         (ctf_free_base): Removed, ctf_base is no longer freed: free
1327         ctf_dynbase instead.
1328         (ctf_set_version): Fix spacing.
1329         (upgrade_header): New, in-place header upgrading.
1330         (upgrade_types): Rename to...
1331         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1332         longer track old and new headers separately.  No longer allow for
1333         header sizes explicitly: squeeze the headers out on upgrade (they
1334         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1335         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1336         (upgrade_types): New, also handle ctf_parmax updating.
1337         (flip_header): Flip ctf_cuname.
1338         (flip_types): Flip BUF explicitly rather than deriving BUF from
1339         BASE.
1340         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1341         required alignment of objtoff and funcoff.  No longer store it in
1342         the ctf_buf unless that buf is derived unmodified from the input.
1343         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1344         that duplicate fields in ctf_file: move allocation of ctf_file
1345         further up instead.  Call upgrade_header as needed.  Move
1346         version-specific ctf_parmax initialization into upgrade_types.  More
1347         concise error handling.
1348         (ctf_file_close): No longer test for null pointers before freeing.
1349         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1350         ctf_free_base.
1351         (ctf_cuname): New.
1352         (ctf_cuname_set): New.
1353         * ctf-create.c (ctf_update): Populate ctf_cuname.
1354         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1355         comment.
1356         (ctf_write): Likewise.
1357         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1358         Fix the compression length: fp->ctf_size never counted the CTF
1359         header.  Simplify the compress call accordingly.
1360
1361 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1362
1363         * ctf-endian.h: Don't assume htole64 and le64toh are always
1364         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1365         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1366         not bswap_identity_64.
1367
1368 2019-09-18  Alan Modra  <amodra@gmail.com>
1369
1370         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1371
1372 2019-09-09  Phil Blundell  <pb@pbcl.net>
1373
1374         binutils 2.33 branch created.
1375
1376 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1377
1378         * ctf-types.c (ctf_type_aname_raw): New.
1379         (ctf_func_type_info): Likewise.
1380         (ctf_func_type_args): Likewise.
1381         * ctf-error.c (_ctf_errlist): Fix description.
1382         * ctf-lookup.c: Fix file description.
1383
1384 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1385
1386         * ctf-create.c (ctf_create): Fix off-by-one error.
1387
1388 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1389
1390         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1391         struct ctf_strs.
1392         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1393         (struct ctf_str_atom): New, disambiguated single string.
1394         (struct ctf_str_atom_ref): New, points to some other location that
1395         references this string's offset.
1396         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1397         Remove member ctf_dtvstrlen: we no longer track the total strlen
1398         as we add strings.
1399         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1400         (ctf_str_free_atoms): Likewise.
1401         (ctf_str_add): Likewise.
1402         (ctf_str_add_ref): Likewise.
1403         (ctf_str_rollback): Likewise.
1404         (ctf_str_purge_refs): Likewise.
1405         (ctf_str_write_strtab): Likewise.
1406         (ctf_realloc): Declare new function in ctf-util.c.
1407
1408         * ctf-open.c (ctf_bufopen): Create the atoms table.
1409         (ctf_file_close): Destroy it.
1410         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1411         special-case the position of the parname string.  Construct the
1412         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1413         rest of each buffer element is constructed, not via open-coding:
1414         realloc the CTF buffer and append the strtab to it.  No longer
1415         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1416         strtab construction.
1417         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1418         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1419         after buffer element construction instead.
1420         (ctf_copy_lmembers): Likewise.
1421         (ctf_copy_emembers): Likewise.
1422         (ctf_create): No longer maintain the ctf_dtvstrlen.
1423         (ctf_dtd_delete): Likewise.
1424         (ctf_dvd_delete): Likewise.
1425         (ctf_add_generic): Likewise.
1426         (ctf_add_enumerator): Likewise.
1427         (ctf_add_member_offset): Likewise.
1428         (ctf_add_variable): Likewise.
1429         (membadd): Likewise.
1430         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1431         if there are active ctf_str_num_refs.
1432         (ctf_strraw): Move to ctf-string.c.
1433         (ctf_strptr): Likewise.
1434         * ctf-string.c: New file, strtab manipulation.
1435
1436         * Makefile.am (libctf_a_SOURCES): Add it.
1437         * Makefile.in: Regenerate.
1438
1439 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1440
1441         * ctf-impl.h (ctf_hash_iter_f): New.
1442         (ctf_dynhash_iter): New declaration.
1443         (ctf_dynhash_iter_remove): New declaration.
1444         * ctf-hash.c (ctf_dynhash_iter): Define.
1445         (ctf_dynhash_iter_remove): Likewise.
1446         (ctf_hashtab_traverse): New.
1447         (ctf_hashtab_traverse_remove): Likewise.
1448         (struct ctf_traverse_cb_arg): Likewise.
1449         (struct ctf_traverse_remove_cb_arg): Likewise.
1450
1451 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1452
1453         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1454
1455 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1456
1457         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1458         (ctf_dump_funcs): Likewise.
1459
1460 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1461
1462         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1463         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1464         little-endian CTF archive magic.  Do not check the CTF version:
1465         ctf_simple_open does that in endian-safe ways.  Do not dereference
1466         null pointers on open failure.
1467
1468 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1469
1470         * ctf-open.c (get_vbytes_common): Return the new slice size.
1471         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1472         Remember to copy in the CTF data when opening an uncompressed
1473         foreign-endian CTF file.  Prune useless variable manipulation.
1474
1475 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1476
1477         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1478         seen.
1479
1480 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1481
1482         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1483         output.
1484
1485 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1486
1487         * ctf-subr.c (_PAGESIZE): Remove.
1488         (ctf_data_alloc): Likewise.
1489         (ctf_data_free): Likewise.
1490         (ctf_data_protect): Likewise.
1491         * ctf-impl.h: Remove declarations.
1492         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1493         ctf_free, not ctf_data_free.
1494         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1495         the buffer again on compression error.
1496         * ctf-open.c (ctf_set_base): No longer track the size: call
1497         ctf_free, not ctf_data_free.
1498         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1499         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1500
1501 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1502
1503         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1504         ctf_dynhash_insert.
1505         (ctf_dvd_insert): Likewise.
1506         (ctf_add_generic): Likewise.
1507         (ctf_add_variable): Likewise.
1508         * ctf-impl.h: Adjust declarations.
1509
1510 2019-06-14  Alan Modra  <amodra@gmail.com>
1511
1512         * configure: Regenerate.
1513
1514 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1515
1516         * ctf-decls.h: Include <libiberty.h>.
1517         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1518
1519 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1520
1521         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1522         (ctf_dump_objts): Likewise.
1523         (ctf_dump_funcs): Likewise.
1524         (ctf_dump_member): Likewise.
1525         (ctf_dump_str): Likewise.
1526
1527 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1528
1529         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1530         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1531
1532 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1533
1534         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1535         (ctf_arc_open_by_offset): Likewise.
1536         * ctf-create.c (ctf_add_type): Likewise.
1537
1538 2019-06-04  Tom Tromey  <tromey@adacore.com>
1539
1540         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1541         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1542
1543 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1544
1545         * configure.ac: Check for O_CLOEXEC.
1546         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1547         * config.h.in: Regenerate.
1548         * configure: Likewise.
1549
1550 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1551
1552         * qsort_r.c: Rename to...
1553         * ctf-qsort_r.c: ... this.
1554         (_quicksort): Define to ctf_qsort_r.
1555         * ctf-decls.h (qsort_r): Remove.
1556         (ctf_qsort_r): Add.
1557         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1558         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1559         * Makefile.am (libctf_a_LIBADD): Remove.
1560         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1561         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1562         * ctf-create.c (ctf_update): Likewise.
1563         * configure.ac: Check for BSD versus GNU qsort_r signature.
1564         * Makefile.in: Regenerate.
1565         * config.h.in: Likewise.
1566         * configure: Likewise.
1567
1568 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1569
1570         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1571
1572 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1573
1574         * Makefile.am (ZLIB): New.
1575         (ZLIBINC): Likewise.
1576         (AM_CFLAGS): Use them.
1577         (libctf_a_LIBADD): New, for LIBOBJS.
1578         * configure.ac: Check for zlib, endian.h, and qsort_r.
1579         * ctf-endian.h: New, providing htole64 and le64toh.
1580         * swap.h: Code style fixes.
1581         (bswap_identity_64): New.
1582         * qsort_r.c: New, from gnulib (with one added #include).
1583         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1584         and unconditional definitions of MIN and MAX.
1585         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1586         (ctf_set_errno): Now returns unsigned long.
1587         * ctf-util.c (ctf_set_errno): Adjust here too.
1588         * ctf-archive.c: Use ctf-endian.h.
1589         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1590         cts_flags and cts_offset.
1591         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1592         * ctf-create.c: Provide a definition of roundup if not defined.
1593         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1594         (ctf_add_reftype): Do not check if type IDs are below zero.
1595         (ctf_add_slice): Likewise.
1596         (ctf_add_typedef): Likewise.
1597         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1598         when known error-free.  Drop CTF_ERR usage for functions returning
1599         int.
1600         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1601         int.
1602         (ctf_add_variable): Likewise.
1603         (enumcmp): Likewise.
1604         (enumadd): Likewise.
1605         (membcmp): Likewise.
1606         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1607         when known error-free.
1608         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1609         returning int: use CTF_ERR for functions returning ctf_type_id.
1610         (ctf_dump_label): Likewise.
1611         (ctf_dump_objts): Likewise.
1612         * ctf-labels.c (ctf_label_topmost): Likewise.
1613         (ctf_label_iter): Likewise.
1614         (ctf_label_info): Likewise.
1615         * ctf-lookup.c (ctf_func_args): Likewise.
1616         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1617         (ctf_bufopen): Likewise.  Use zlib types as needed.
1618         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1619         returning int.
1620         (ctf_enum_iter): Likewise.
1621         (ctf_type_size): Likewise.
1622         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1623         (ctf_type_kind_unsliced): Likewise.
1624         (ctf_type_kind): Likewise.
1625         (ctf_type_encoding): Likewise.
1626         (ctf_member_info): Likewise.
1627         (ctf_array_info): Likewise.
1628         (ctf_enum_value): Likewise.
1629         (ctf_type_rvisit): Likewise.
1630         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1631         cts_offset.
1632         (ctf_simple_open): Likewise.
1633         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1634         * Makefile.in: Regenerate.
1635         * aclocal.m4: Likewise.
1636         * config.h: Likewise.
1637         * configure: Likewise.
1638
1639 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1640
1641         * configure.in: Check for bfd_section_from_elf_index.
1642         * configure: Regenerate.
1643         * config.h.in [HAVE_BFD_ELF]: Likewise.
1644         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1645         abfd is potentially unused now.
1646
1647 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1648
1649         * Makefile.am: New.
1650         * Makefile.in: Regenerated.
1651         * config.h.in: Likewise.
1652         * aclocal.m4: Likewise.
1653         * configure: Likewise.
1654
1655 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1656
1657         * ctf-dump.c: New.
1658
1659 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1660
1661         * ctf-labels.c: New.
1662
1663 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1664
1665         * ctf-impl.h (_libctf_version): New declaration.
1666         * ctf-subr.c (_libctf_version): Define it.
1667         (ctf_version): New.
1668
1669 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1670
1671         * ctf-create.c (enumcmp): New.
1672         (enumadd): Likewise.
1673         (membcmp): Likewise.
1674         (membadd): Likewise.
1675         (ctf_add_type): Likewise.
1676
1677 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1678
1679         * ctf-lookup.c (isqualifier): New.
1680         (ctf_lookup_by_name): Likewise.
1681         (struct ctf_lookup_var_key): Likewise.
1682         (ctf_lookup_var): Likewise.
1683         (ctf_lookup_variable): Likewise.
1684         (ctf_lookup_symbol_name): Likewise.
1685         (ctf_lookup_by_symbol): Likewise.
1686         (ctf_func_info): Likewise.
1687         (ctf_func_args): Likewise.
1688
1689 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1690
1691         * ctf-decl.c: New file.
1692         * ctf-types.c: Likewise.
1693         * ctf-impl.h: New declarations.
1694
1695 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1696
1697         * ctf-open-bfd.c: New file.
1698         * ctf-open.c (ctf_close): New.
1699         * ctf-impl.h: Include bfd.h.
1700         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1701         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1702         ctfi_bfd_close.
1703         (ctf_bfdopen_ctfsect): New declaration.
1704         (_CTF_SECTION): likewise.
1705
1706 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1707
1708         * ctf-archive.c: New.
1709         * ctf-impl.h (ctf_archive_internal): New type.
1710         (ctf_arc_open_internal): New declaration.
1711         (ctf_arc_bufopen): Likewise.
1712         (ctf_arc_close_internal): Likewise.
1713
1714 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1715
1716         * ctf-open.c: New file.
1717         * swap.h: Likewise.
1718
1719 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1720
1721         * ctf-create.c: New file.
1722         * ctf-lookup.c: New file.
1723
1724 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1725
1726         * ctf-impl.h: New definitions and declarations for type creation
1727         and lookup.
1728
1729 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1730
1731         * ctf-hash.c: New file.
1732         * ctf-impl.h: New declarations.
1733
1734 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1735
1736         * ctf-error.c: New file.
1737
1738 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1739
1740         * ctf-util.c: New file.
1741         * elf.h: Likewise.
1742         * ctf-impl.h: Include it, and add declarations.
1743
1744 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1745
1746         * ctf-impl.h: New file.
1747         * ctf-subr.c: New file.
1748
1749 \f
1750 Local Variables:
1751 mode: change-log
1752 left-margin: 8
1753 fill-column: 76
1754 version-control: never
1755 End: