libctf/ChangeLog

   1 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
   4         declare this to be version 1.2.0.
   5         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
   6         * Makefile.in: Regenerated.
   7         * configure: Regenerated.
   8         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
   9         * ctf-impl.h: Include it.
  10         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
  11         (ctf_errmsg): Actually translate them.
  12
  13 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
  14
  15         PR binutils/25155:
  16         * ctf-create.c (EOVERFLOW): If not defined by system header,
  17         redirect to ERANGE as a poor man's substitute.
  18         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
  19
  20 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  21
  22         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
  23         (ctf_dtd_delete): Likewise.
  24         (ctf_dtd_lookup): Likewise.
  25         (ctf_rollback): Likewise.
  26         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
  27         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
  28
  29 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  30
  31         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
  32
  33 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  34
  35         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
  36         number if needed.
  37
  38 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  39
  40         * ctf-impl.h (ctf_list_splice): New.
  41         * ctf-util.h (ctf_list_splice): Likewise.
  42         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
  43         (ctf_link_sort_inputs): Likewise.
  44         (ctf_link_deduplicating_count_inputs): Likewise.
  45         (ctf_link_deduplicating_open_inputs): Likewise.
  46         (ctf_link_deduplicating_close_inputs): Likewise.
  47         (ctf_link_deduplicating_variables): Likewise.
  48         (ctf_link_deduplicating_per_cu): Likewise.
  49         (ctf_link_deduplicating): Likewise.
  50         (ctf_link): Call it.
  51
  52 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  53
  54         * ctf-link.c (ctf_link_one_input_archive_member): Check
  55         CTF_LINK_OMIT_VARIABLES_SECTION.
  56
  57 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  58
  59         * ctf-impl.h (ctf_type_id_key): New, the key in the
  60         cd_id_to_file_t.
  61         (ctf_dedup): New, core deduplicator state.
  62         (ctf_file_t) <ctf_dedup>: New.
  63         <ctf_dedup_atoms>: New.
  64         <ctf_dedup_atoms_alloc>: New.
  65         (ctf_hash_type_id_key): New prototype.
  66         (ctf_hash_eq_type_id_key): Likewise.
  67         (ctf_dedup_atoms_init): Likewise.
  68         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
  69         (ctf_dedup_atoms_init): Likewise.
  70         * ctf-create.c (ctf_serialize): Adjusted.
  71         (ctf_add_encoded): No longer static.
  72         (ctf_add_reftype): Likewise.
  73         * ctf-open.c (ctf_file_close): Destroy the
  74         ctf_dedup_atoms_alloc.
  75         * ctf-dedup.c: New file.
  76         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
  77         * configure.ac: Check for stpcpy.
  78         * Makefile.am: Add it.
  79         * Makefile.in: Regenerate.
  80         * config.h.in: Regenerate.
  81         * configure: Regenerate.
  82
  83 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  84
  85         * configure.ac: Add --enable-libctf-hash-debugging.
  86         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
  87         * Makefile.in: Regenerated.
  88         * configure: Likewise.
  89         * config.h.in: Likewise.
  90         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
  91         (ctf_assert): Define to assert.
  92
  93 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  94
  95         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
  96         sha1_process_bytes.
  97         * ctf-impl.h: Include it.
  98         (ctf_sha1_init): New.
  99         (ctf_sha1_add): Likewise.
 100         (ctf_sha1_fini): Likewise.
 101         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 102         producing strings.
 103         * Makefile.am: Add file.
 104         * Makefile.in: Regenerate.
 105
 106 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 107
 108         * libctf.ver (ctf_link_set_variable_filter): Add.
 109         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 110         <ctf_link_variable_filter_arg>: Likewise.
 111         * ctf-create.c (ctf_serialize): Adjust.
 112         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 113         (ctf_link_one_variable): Call it if set.
 114
 115 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 116
 117         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 118         conflicts, not the source type.
 119
 120 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 121
 122         * ctf-impl.h (ctf_file_t): Improve comments.
 123         <ctf_link_cu_mapping>: Split into...
 124         <ctf_link_in_cu_mapping>: ... this...
 125         <ctf_link_out_cu_mapping>: ... and this.
 126         * ctf-create.c (ctf_serialize): Adjust.
 127         * ctf-open.c (ctf_file_close): Likewise.
 128         * ctf-link.c (ctf_create_per_cu): Look things up in the
 129         in_cu_mapping instead of the cu_mapping.
 130         (ctf_link_add_cu_mapping): The deduplicating link will define
 131         what happens if many FROMs share a TO.
 132         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 133         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 134         create per-CU dicts here: they are already created when needed.
 135         (ctf_link_one_variable): Log a debug message if we skip a
 136         variable due to its type being concealed in a CU-mapped link.
 137         (This is probably too common a case to make into a warning.)
 138         (ctf_link): Create empty per-CU dicts if requested.
 139
 140 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 141
 142         * ctf-link.c (ctf_link_write): Close the fd.
 143
 144 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 145
 146         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 147         * Makefile.in: Regenerated.
 148         * ctf-impl.h (ctf_link_input_name): New.
 149         (ctf_file_t) <ctf_link_flags>: New.
 150         * ctf-create.c (ctf_serialize): Adjust accordingly.
 151         * ctf-link.c: Define ctf_open as weak when PIC.
 152         (ctf_arc_close_thunk): Remove unnecessary thunk.
 153         (ctf_file_close_thunk): Likewise.
 154         (ctf_link_input_name): New.
 155         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 156         (ctf_link_input_close): Adjust accordingly.
 157         (ctf_link_add_ctf_internal): New, split from...
 158         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 159         CTF is not possible.  Change to just call...
 160         (ctf_link_add): ... this new function.
 161         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 162         ctf_file_close_thunk.
 163         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 164         <in_file_name>: ... this.
 165         <arcname>: Drop.
 166         <share_mode>: Likewise (migrated to ctf_link_flags).
 167         <done_main_member>: Rename to...
 168         <done_parent>: ... this.
 169         <main_input_fp>: Rename to...
 170         <in_fp_parent>: ... this.
 171         <cu_mapped>: New.
 172         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 173         ctf_err_warn, removing a TODO.
 174         (ctf_link_one_variable): Note a case too common to warn about.
 175         Report in the debug stream if a cu-mapped link prevents addition
 176         of a conflicting variable.
 177         (ctf_link_one_input_archive_member): Adjust.
 178         (ctf_link_lazy_open): New, open a CTF archive for linking when
 179         needed.
 180         (ctf_link_close_one_input_archive): New, close it again.
 181         (ctf_link_one_input_archive): Adjust for lazy opening, member
 182         renames, and ctf_err_warn transition.  Move the
 183         empty_link_type_mapping call to...
 184         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 185         Don't spuriously fail if some input contains no CTF data.
 186         (ctf_link_write): ctf_err_warn transition.
 187         * libctf.ver: Remove not-yet-stable comment.
 188
 189 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 190
 191         * ctf-impl.h (ctf_strerror): Delete.
 192         * ctf-subr.c (ctf_strerror): Likewise.
 193         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 194         strerror directly.
 195
 196 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 197
 198         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 199         (ctf_import_unref): New.
 200         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 201         zero.  Don't recurse back in if the refcount is already zero.
 202         (ctf_import): Check ctf_parent_unreffed before deciding whether
 203         to close a pre-existing parent.  Set it to zero.
 204         (ctf_import_unreffed): New, as above, setting
 205         ctf_parent_unreffed to 1.
 206         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 207         child: use direct assignment, and set unreffed on the new and
 208         old children.
 209         * ctf-link.c (ctf_create_per_cu): Import the parent using
 210         ctf_import_unreffed.
 211
 212 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 213
 214         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 215         (ctf_link_type_key): ... this, adjusting member prefixes to
 216         match.
 217         (ctf_hash_type_mapping_key): Rename to...
 218         (ctf_hash_type_key): ... this.
 219         (ctf_hash_eq_type_mapping_key): Rename to...
 220         (ctf_hash_eq_type_key): ... this.
 221         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 222         (ctf_hash_type_key): ... this, and adjust for member name
 223         changes.
 224         (ctf_hash_eq_type_mapping_key): Rename to...
 225         (ctf_hash_eq_type_key): ... this, and adjust for member name
 226         changes.
 227         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 228         need for out-of-memory checking in this code.
 229         (ctf_type_mapping): Adjust.
 230
 231 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 232
 233         configure.ac: Check for vasprintf.
 234         configure: Regenerated.
 235         config.h.in: Likewise.
 236
 237 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 238
 239         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 240
 241 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 242
 243         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 244         New.
 245         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 246         if the input has no symtab, rather than dividing by
 247         zero. Arrange to free it later via ctfi_free_ctfsect.
 248         * ctf-archive.c (ctf_new_archive_internal): Do not
 249         ctfi_free_strsect by default.
 250         (ctf_arc_close): Possibly free it here.
 251
 252 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 253
 254         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 255         (ctf_dump_format_type): improve slice formatting.  Always print
 256         the type size, even of slices.
 257         (ctf_dump_member): Print slices (-> bitfields) differently from
 258         non-slices.  Failure to format a type is not an OOM.
 259
 260 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 261
 262         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 263         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 264         (ctf_dump_objts): Likewise.
 265         (ctf_dump_var): Likewise.
 266         (ctf_dump_type): Do not emit a duplicate message.  Move to
 267         ctf_err_warning, and swallow all errors.
 268
 269 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 270
 271         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 272         (ctf_decl_buf): Once it escapes, don't try to free it later.
 273
 274 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 275
 276         * ctf-types.c (ctf_type_aname): Print arg types here...
 277         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 278         in the type name here.
 279
 280 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 281
 282         * ctf-impl.h (ctf_assert): New.
 283         (ctf_err_warning_t): Likewise.
 284         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 285         (ctf_err_warn): New prototype.
 286         (ctf_assert_fail_internal): Likewise.
 287         * ctf-inlines.h (ctf_assert_internal): Likewise.
 288         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 289         * ctf-create.c (ctf_serialize): Copy it on serialization.
 290         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 291         (ctf_errwarning_next): New iterator, free and pass back
 292         errors/warnings in succession.
 293         * libctf.ver (ctf_errwarning_next): Add.
 294
 295 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 296
 297         * ctf-types.c (ctf_variable_iter): Fix error return.
 298
 299 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 300
 301         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 302
 303 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 304
 305         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 306
 307 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 308
 309         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 310         sorting functions.
 311         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 312         ctf_dynhash_next_sorted.
 313         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 314         <cu.ctn_s>: New, pointer to the dynset under iteration.
 315         (ctf_hash_sort_f): Sorting function passed to...
 316         (ctf_dynhash_next_sorted): ... this new function.
 317         (ctf_dynhash_next): New.
 318         (ctf_dynset_next): New.
 319         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 320         (ctf_dynhash_cnext): New.
 321         (ctf_dynset_cnext): New.
 322         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 323         (ctf_dynhash_next): New.
 324         (ctf_dynset_next): New.
 325         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 326         needed.
 327         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 328
 329 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 330
 331         * ctf-impl.h (ctf_next): New.
 332         (ctf_get_dict): New prototype.
 333         * ctf-lookup.c (ctf_get_dict): New, split out of...
 334         (ctf_lookup_by_id): ... here.
 335         * ctf-util.c (ctf_next_create): New.
 336         (ctf_next_destroy): New.
 337         (ctf_next_copy): New.
 338         * ctf-types.c (includes): Add <assert.h>.
 339         (ctf_member_next): New.
 340         (ctf_enum_next): New.
 341         (ctf_type_iter): Document the lack of iteration over parent
 342         types.
 343         (ctf_type_next): New.
 344         (ctf_variable_next): New.
 345         * ctf-archive.c (ctf_archive_next): New.
 346         * libctf.ver: Add new public functions.
 347
 348 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 349
 350         * libctf.ver (ctf_ref): New.
 351         * ctf-open.c (ctf_ref): Implement it.
 352
 353 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 354
 355         * ctf-inlines.h (ctf_forwardable_kind): New.
 356         * ctf-create.c (ctf_add_forward): Use it.
 357
 358 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 359
 360         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 361         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 362
 363 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 364
 365         * ctf-hash.c (ctf_dynset_eq_string): New.
 366         (ctf_dynset_create): New.
 367         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 368         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 369         (key_to_internal): New.
 370         (internal_to_key): New.
 371         (ctf_dynset_insert): New.
 372         (ctf_dynset_remove): New.
 373         (ctf_dynset_destroy): New.
 374         (ctf_dynset_lookup): New.
 375         (ctf_dynset_exists): New.
 376         (ctf_dynset_lookup_any): New.
 377         (ctf_hash_insert_type): Coding style.
 378         (ctf_hash_define_type): Likewise.
 379         * ctf-impl.h (ctf_dynset_t): New.
 380         (ctf_dynset_eq_string): New.
 381         (ctf_dynset_create): New.
 382         (ctf_dynset_insert): New.
 383         (ctf_dynset_remove): New.
 384         (ctf_dynset_destroy): New.
 385         (ctf_dynset_lookup): New.
 386         (ctf_dynset_exists): New.
 387         (ctf_dynset_lookup_any): New.
 388         * ctf-inlines.h (ctf_dynset_cinsert): New.
 389
 390 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 391
 392         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 393         <value_free>: Likewise.
 394         <owner>: New.
 395         (ctf_dynhash_item_free): Indirect through the owner.
 396         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 397         allocate space for the key_free and value_free fields fields
 398         if necessary.
 399         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 400         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 401         value_free if they will exist.  Set the slot's owner, but only
 402         if it exists.
 403         (ctf_dynhash_remove): Adjust.
 404
 405 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 406
 407         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 408         there is a key-freeing function and the key already exists.
 409
 410 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 411
 412         * ctf-inlines.h: New file.
 413         * ctf-impl.h: Include it.
 414         (ctf_hash_iter_find_f): New typedef.
 415         (ctf_dynhash_elements): New.
 416         (ctf_dynhash_lookup_kv): New.
 417         (ctf_dynhash_iter_find): New.
 418         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 419         (ctf_traverse_find_cb_arg_t): New.
 420         (ctf_hashtab_traverse_find): New.
 421         (ctf_dynhash_iter_find): New.
 422         (ctf_dynhash_elements): New.
 423
 424 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 425
 426         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 427
 428 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 429
 430         * ctf-archive.c (ctf_archive_count): New.
 431         * libctf.ver: New public function.
 432
 433 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 434
 435         * ctf-types.c (ctf_member_count): New.
 436         * libctf.ver: New public function.
 437
 438 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 439
 440         * ctf-types.c (ctf_type_kind_forwarded): New.
 441
 442 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 443
 444         * ctf-types.c (ctf_type_name_raw): New.
 445         (ctf_type_aname_raw): Reimplement accordingly.
 446
 447 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 448
 449         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 450
 451 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 452
 453         * ctf-impl.h (struct ctf_archive_internal)
 454         <ctfi_unmap_on_close>: New.
 455         (ctf_new_archive_internal): Adjust.
 456         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 457         Initialize ctfi_unmap_on_close.  Adjust error path.
 458         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 459         (unmap_on_close is 0).
 460         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 461         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 462
 463 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 464
 465         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 466         ints, floats or typedefs have no name.  Fix comment typo.
 467
 468 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 469
 470         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 471         resolves to an integral type.
 472         * ctf-types.c (ctf_type_encoding): Resolve the type before
 473         fishing its encoding out.
 474
 475 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 476
 477         * ctf-create.c (ctf_create): Mark dirty.
 478
 479 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 480
 481         * ctf-create.c (membcmp)  Skip nameless members.
 482
 483 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 484
 485         * ctf-create.c (ctf_add_member_offset): Support names of ""
 486         as if they were the null pointer.
 487
 488 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 489
 490         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 491         special-casing.
 492
 493 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 494
 495         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 496
 497 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 498
 499         * ctf-create.c (ctf_serialize): Add cast.
 500         (ctf_add_slice): Likewise.
 501
 502 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 503
 504         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 505         * ctf-create.c (ctf_add_function): Check for unimplemented type
 506         and populate at the same time.  Populate one-by-one, not via
 507         memcpy.
 508         (ctf_serialize): Remove unnecessary cast.
 509         * ctf-types.c (ctf_func_type_info): Likewise.
 510         (ctf_func_type_args): Likewise.  Fix comment typo.
 511
 512 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 513
 514         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 515         (ctf_add_array): Support array contents of type zero.
 516         (ctf_add_function): Support arguments and return types of
 517         type zero.
 518         (ctf_add_typedef): Support typedefs to type zero.
 519         (ctf_add_member_offset): Support members of type zero,
 520         unless added at unspecified (naturally-aligned) offset.
 521
 522 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 523
 524         * ctf-error.c: Include <stddef.h>, for offsetof.
 525         (_ctf_errlist): Migrate to...
 526         (_ctf_errlist_t): ... this.
 527         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 528         (_ctf_nerr): Remove.
 529         (ctf_errmsg): Adjust accordingly.
 530         * Makefile.am (BUILT_SOURCES): Note...
 531         (ctf-error.h): ... this new rule.
 532         * Makefile.in: Regenerate.
 533         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 534         * .gitignore: New, ignore ctf-error.h.
 535
 536 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 537
 538         * ctf-impl.h: Fix typos in comments.
 539
 540 2020-07-22  Nick Clifton  <nickc@redhat.com>
 541
 542         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 543         same file descriptor.
 544
 545 2020-07-04  Nick Clifton  <nickc@redhat.com>
 546
 547         Binutils 2.35 branch created.
 548
 549 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 550
 551         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 552         alphabetical order.
 553         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 554         * config.h.in: Regenerated.
 555         * Makefile.in: Likewise.
 556         * configure: Likewise.
 557
 558 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 559
 560         * ctf-create.c: Include <unistd.h>.
 561         * ctf-open-bfd.c: Likewise.
 562
 563 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 564
 565         PR libctf/25120
 566         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 567         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 568         means this is declared.
 569         (bswap_32): Likewise.
 570         (bswap_64): Likewise.
 571         (bswap_identity_64): Remove, unused.
 572         * configure: Regenerated.
 573         * config.h.in: Likewise.
 574
 575 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 576
 577         PR libctf/25120
 578         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 579         (_libctf_unlikely_): Likewise.
 580         (_libctf_unused): Likewise.
 581         (_libctf_malloc_): Likewise.
 582
 583 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 584
 585         PR libctf/25120
 586         * ctf-archive.c (search_nametbl): No longer global: declare...
 587         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 588         (search_modent_by_name): Take and use ARG for the nametbl.
 589
 590 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 591
 592         * ctf-impl.h (ctf_new_archive_internal): Declare.
 593         (ctf_arc_bufopen): Remove.
 594         (ctf_archive_internal) <ctfi_free_symsect>: New.
 595         * ctf-archive.c (ctf_arc_close): Use it.
 596         (ctf_arc_bufopen): Fuse into...
 597         (ctf_new_archive_internal): ... this, moved across from...
 598         * ctf-open-bfd.c: ... here.
 599         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 600         * libctf.ver: Add it.
 601
 602 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 603
 604         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 605         (ctf_dtd_delete): Remove correspondingly.
 606         (ctf_rollback): Likewise.
 607
 608 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 609
 610         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 611         unchanged.
 612
 613 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 614
 615         * ctf-create.c (ctf_add_forward): Don't add forwards to
 616         types that already exist.
 617
 618 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 619
 620         * ctf-open.c (init_types): Only intern root-visible types.
 621         * ctf-create.c (ctf_dtd_insert): Likewise.
 622         (ctf_dtd_delete): Only remove root-visible types.
 623         (ctf_rollback): Likewise.
 624         (ctf_add_generic): Adjust.
 625         (ctf_add_struct_sized): Adjust comment.
 626         (ctf_add_union_sized): Likewise.
 627         (ctf_add_enum): Likewise.
 628         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 629
 630 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 631
 632         * swap.h (bswap_identity_64): Make static.
 633
 634 2020-01-18  Nick Clifton  <nickc@redhat.com>
 635
 636         Binutils 2.34 branch created.
 637
 638 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 639
 640         PR binutils/25155:
 641         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 642         * configure, config.h.in: Regenerate.
 643
 644 2020-01-01  Alan Modra  <amodra@gmail.com>
 645
 646         Update year range in copyright notice of all files.
 647
 648 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 649
 650         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 651
 652 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 653
 654         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 655         * ctf-types.c (ctf_type_lname): Likewise.
 656
 657 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 658
 659         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 660         ctf_import after the first for a given file.
 661
 662 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 663
 664         * ctf-impl.h (ctf_str_append_noerr): Declare.
 665         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 666         ctf_str_append.
 667         * ctf-dump.c (str_append): New, call it.
 668         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 669         (ctf_dump_label): Likewise.
 670         (ctf_dump_objts): Likewise.
 671         (ctf_dump_funcs): Likewise.
 672         (ctf_dump_var): Likewise.
 673         (ctf_dump_member): Likewise.
 674         (ctf_dump_type): Likewise.
 675         (ctf_dump): Likewise.
 676
 677 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 678
 679         * ctf-impl.h (ctf_alloc): Remove.
 680         (ctf_free): Likewise.
 681         (ctf_strdup): Likewise.
 682         * ctf-subr.c (ctf_alloc): Remove.
 683         (ctf_free): Likewise.
 684         * ctf-util.c (ctf_strdup): Remove.
 685
 686         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 687         ctf_free; strdup, not ctf_strdup.
 688         (ctf_dtd_delete): Likewise.
 689         (ctf_dvd_delete): Likewise.
 690         (ctf_add_generic): Likewise.
 691         (ctf_add_function): Likewise.
 692         (ctf_add_enumerator): Likewise.
 693         (ctf_add_member_offset): Likewise.
 694         (ctf_add_variable): Likewise.
 695         (membadd): Likewise.
 696         (ctf_compress_write): Likewise.
 697         (ctf_write_mem): Likewise.
 698         * ctf-decl.c (ctf_decl_push): Likewise.
 699         (ctf_decl_fini): Likewise.
 700         (ctf_decl_sprintf): Likewise.  Check for OOM.
 701         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 702         ctf_free; strdup, not ctf_strdup.
 703         (ctf_dump_free): Likewise.
 704         (ctf_dump): Likewise.
 705         * ctf-open.c (upgrade_types_v1): Likewise.
 706         (init_types): Likewise.
 707         (ctf_file_close): Likewise.
 708         (ctf_bufopen_internal): Likewise.  Check for OOM.
 709         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 710         (ctf_cuname_set): Likewise.
 711         (ctf_import): Likewise.
 712         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 713         free, not ctf_free; strdup, not ctf_strdup.
 714         (ctf_str_free_atom): Likewise.
 715         (ctf_str_create_atoms): Likewise.
 716         (ctf_str_add_ref_internal): Likewise.
 717         (ctf_str_remove_ref): Likewise.
 718         (ctf_str_write_strtab): Likewise.
 719
 720 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 721
 722         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 723         work right for non-int/fps.
 724
 725 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 726
 727         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 728         null pointer.
 729
 730 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 731
 732         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 733         * ctf-open.c (ctf_file_close): Free it.
 734         * ctf-create.c (ctf_serialize): Adjust.
 735         (membcmp): When reporting a conflict due to an error, report the
 736         error.
 737         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 738         (ctf_add_type_internal): ... this.  Hand back types we are already
 739         in the middle of adding immediately.  Hand back structs/unions with
 740         the same number of members immediately.  Do not walk the dynamic
 741         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 742         forwards promoted to other types and the inverse case identically.
 743         Add structs to the mapping as soon as we intern them, before they
 744         gain any members.
 745
 746 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 747
 748         * ctf-impl.h (ctf_names_t): New.
 749         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 750         (ctf_file_t) <ctf_structs>: Likewise.
 751         <ctf_unions>: Likewise.
 752         <ctf_enums>: Likewise.
 753         <ctf_names>: Likewise.
 754         <ctf_lookups>: Improve comment.
 755         <ctf_ptrtab_len>: New.
 756         <ctf_prov_strtab>: New.
 757         <ctf_str_prov_offset>: New.
 758         <ctf_dtbyname>: Remove, redundant to the names hashes.
 759         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 760         (ctf_dtdef_t) <dtd_name>: Remove.
 761         <dtd_data>: Note that the ctt_name is now populated.
 762         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 763         offset for internal strings too.
 764         <csa_external_offset>: New, the external strtab offset.
 765         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 766         (ctf_name_table): New declaration.
 767         (ctf_lookup_by_rawname): Likewise.
 768         (ctf_lookup_by_rawhash): Likewise.
 769         (ctf_set_ctl_hashes): Likewise.
 770         (ctf_serialize): Likewise.
 771         (ctf_dtd_insert): Adjust.
 772         (ctf_simple_open_internal): Likewise.
 773         (ctf_bufopen_internal): Likewise.
 774         (ctf_list_empty_p): Likewise.
 775         (ctf_str_remove_ref): Likewise.
 776         (ctf_str_add): Returns uint32_t now.
 777         (ctf_str_add_ref): Likewise.
 778         (ctf_str_add_external): Now returns a boolean (int).
 779         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 780         for strings in the appropriate range.
 781         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 782         when adding the null string to the new strtab.
 783         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 784         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 785         make_provisional, populate the offset and fill in the
 786         ctf_prov_strtab accordingly.
 787         (ctf_str_add): Return the offset, not the string.
 788         (ctf_str_add_ref): Likewise.
 789         (ctf_str_add_external): Return a success integer.
 790         (ctf_str_remove_ref): New, remove a single ref.
 791         (ctf_str_count_strtab): Do not count the initial null string's
 792         length or the existence or length of any unreferenced internal
 793         atoms.
 794         (ctf_str_populate_sorttab): Skip atoms with no refs.
 795         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 796         to the cts_len for the null string, since it is no longer done
 797         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 798         Populate the csa_offset for both internal and external cases.
 799         Flush the ctf_prov_strtab afterwards, and reset the
 800         ctf_str_prov_offset.
 801         * ctf-create.c (ctf_grow_ptrtab): New.
 802         (ctf_create): Call it.  Initialize new fields rather than old
 803         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 804         Set the ctl hashes and data model.
 805         (ctf_update): Rename to...
 806         (ctf_serialize): ... this.  Leave a compatibility function behind.
 807         Tell ctf_simple_open_internal that this is a writable dictionary.
 808         Pass the new fields along from the old dictionary.  Drop
 809         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 810         Do not zero out the DTD's ctt_name.
 811         (ctf_prefixed_name): Rename to...
 812         (ctf_name_table): ... this.  No longer return a prefixed name: return
 813         the applicable name table instead.
 814         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 815         kind we're adding.  Migrate away from dtd_name.
 816         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 817         deleted ctt_name.
 818         (ctf_dtd_lookup_type_by_name): Remove.
 819         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 820         No longer check ctf_dtnextid: check ctf_typemax instead.
 821         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 822         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 823         ctf_name_table and the right name table, and migrate away from
 824         dtd_name as in ctf_dtd_delete.
 825         (ctf_add_generic): Pass in the kind explicitly and pass it to
 826         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 827         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 828         Grow the ptrtab if needed.
 829         (ctf_add_encoded): Pass in the kind.
 830         (ctf_add_slice): Likewise.
 831         (ctf_add_array): Likewise.
 832         (ctf_add_function): Likewise.
 833         (ctf_add_typedef): Likewise.
 834         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 835         ctt_name rather than dtd_name.
 836         (ctf_add_struct_sized): Pass in the kind.  Use
 837         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 838         ctf_dtd_lookup_type_by_name.
 839         (ctf_add_union_sized): Likewise.
 840         (ctf_add_enum): Likewise.
 841         (ctf_add_enum_encoded): Likewise.
 842         (ctf_add_forward): Likewise.
 843         (ctf_add_type): Likewise.
 844         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 845         being initialized until after the call.
 846         (ctf_write_mem): Likewise.
 847         (ctf_write): Likewise.
 848         * ctf-archive.c (arc_write_one_ctf): Likewise.
 849         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 850         ctf_hash_lookup_type.
 851         (ctf_lookup_by_id): No longer check the readonly types if the
 852         dictionary is writable.
 853         * ctf-open.c (init_types): Assert that this dictionary is not
 854         writable.  Adjust to use the new name hashes, ctf_name_table,
 855         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 856         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 857         if set.  Drop out early when dictionary is writable.  Split the
 858         ctf_lookups initialization into...
 859         (ctf_set_cth_hashes): ... this new function.
 860         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 861         (ctf_simple_open): Adjust accordingly.
 862         (ctf_bufopen): Likewise.
 863         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 864         destroy ctf_dtbyname, which is gone.
 865         (ctf_getdatasect): Remove spurious "extern".
 866         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 867         specified name table, given a kind.
 868         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 869         (ctf_member_iter): Add support for iterating over the
 870         dynamic type list.
 871         (ctf_enum_iter): Likewise.
 872         (ctf_variable_iter): Likewise.
 873         (ctf_type_rvisit): Likewise.
 874         (ctf_member_info): Add support for types in the dynamic type list.
 875         (ctf_enum_name): Likewise.
 876         (ctf_enum_value): Likewise.
 877         (ctf_func_type_info): Likewise.
 878         (ctf_func_type_args): Likewise.
 879         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 880         ctf_update.
 881         (ctf_link_write): Likewise.
 882         (ctf_link_intern_extern_string): Adjust for new
 883         ctf_str_add_external return value.
 884         (ctf_link_add_strtab): Likewise.
 885         * ctf-util.c (ctf_list_empty_p): New.
 886
 887 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 888
 889         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 890         type zero.
 891         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 892         members and types.
 893         (ctf_add_variable): Likewise for variables pointing to them.
 894         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 895         type link failure, but do warn for others.
 896         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 897         errors to be ENOMEM.
 898         (ctf_dump_member): Likewise.
 899         (ctf_dump_type): Likewise.
 900         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 901         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 902         (ctf_dump_header): Likewise.
 903         (ctf_dump_label): likewise.
 904         (ctf_dump_objts): likewise.
 905         (ctf_dump_funcs): likewise.
 906         (ctf_dump_var): likewise.
 907         (ctf_dump_str): Likewise.
 908
 909 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 910
 911         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 912         (LT_INIT): Likewise.
 913         (AM_INSTALL_LIBBFD): Likewise.
 914         (dlopen): Note why this is necessary in a comment.
 915         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 916         opcodes/.
 917         (SHARED_LDFLAGS): Likewise.
 918         (BFD_LIBADD): Likewise, for libbfd.
 919         (BFD_DEPENDENCIES): Likewise.
 920         (VERSION_FLAGS): Initialize, using a version script if ld supports
 921         one, or libtool -export-symbols-regex otherwise.
 922         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 923         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 924         (INCDIR): New.
 925         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 926         (noinst_LIBRARIES): Replace with...
 927         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 928         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 929         libctf-nobfd.la as well.
 930         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 931         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 932         (libctf_a_SOURCES): Rename to...
 933         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 934         ctf-open-bfd.c.
 935         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 936         with ctf-open-bfd.c added.
 937         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 938         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 939         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 940         * Makefile.am [INSTALL_LIBCTF]: Use it.
 941         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 942         libtool macros.
 943         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 944         the unstable components).
 945         * Makefile.in: Regenerated.
 946         * config.h.in: Likewise.
 947         * configure: Likewise.
 948
 949 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 950
 951         * configure.ac (INSTALL_LIBCTF): New, controlled by
 952         --enable-install-libctf.
 953         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 954         * Makefile.in: Regenerated.
 955         * configure: Regenerated.
 956
 957 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 958
 959         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 960         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 961
 962 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 963
 964         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 965
 966 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 967
 968         * ctf-impl.h (includes): Include <sys/param.h> here.
 969
 970 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 971
 972         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 973         (flip_objts): Likewise.
 974         (flip_vars): Likewise.
 975         (flip_types): Likewise.
 976
 977 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 978
 979         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 980         freeing functions: if set, free the key and value if the slot
 981         already exists.  Always reassign the key.
 982         (ctf_dynhash_insert): Adjust call appropriately.
 983         (ctf_hash_insert_type): Likewise.
 984
 985 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 986
 987         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 988         type kind.  Allow forwards to unify with pre-existing structs/
 989         unions/enums.
 990
 991 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 992
 993         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 994         <ctf_link_memb_name_changer>: Likewise.
 995         <ctf_link_memb_name_changer_arg>: Likewise.
 996         * ctf-create.c (ctf_update): Update accordingly.
 997         * ctf-open.c (ctf_file_close): Likewise.
 998         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 999         (ctf_link_add_cu_mapping): New.
1000         (ctf_link_set_memb_name_changer): Likewise.
1001         (ctf_change_parent_name): New.
1002         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1003         allocated by the caller's ctf_link_memb_name_changer.
1004         <ndynames>: Likewise.
1005         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1006         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1007         ctf_change_parent_name.  Free any resulting names.
1008
1009 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1010
1011         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1012         (ctf_link_one_type): ... here, with parent-name setting added.
1013         (check_variable): New.
1014         (ctf_link_one_variable): Likewise.
1015         (ctf_link_one_input_archive_member): Call it.
1016         * ctf-error.c (_ctf_errlist): Updated with new errors.
1017
1018 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1019
1020         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1021         (struct ctf_link_type_mapping_key): New.
1022         (ctf_hash_type_mapping_key): Likewise.
1023         (ctf_hash_eq_type_mapping_key): Likewise.
1024         (ctf_add_type_mapping): Likewise.
1025         (ctf_type_mapping): Likewise.
1026         (ctf_dynhash_empty): Likewise.
1027         * ctf-open.c (ctf_file_close): Update accordingly.
1028         * ctf-create.c (ctf_update): Likewise.
1029         (ctf_add_type): Populate the mapping.
1030         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1031         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1032         (ctf_dynhash_insert): Fix comment typo.
1033         (ctf_dynhash_empty): New.
1034         * ctf-link.c (ctf_add_type_mapping): New.
1035         (ctf_type_mapping): Likewise.
1036         (empty_link_type_mapping): New.
1037         (ctf_link_one_input_archive): Call it.
1038
1039 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1040
1041         * ctf-link.c: New file, linking of the string and type sections.
1042         * Makefile.am (libctf_a_SOURCES): Add it.
1043         * Makefile.in: Regenerate.
1044
1045         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1046         ctf_link_outputs.
1047         * ctf-create.c (ctf_update): Update accordingly.
1048         * ctf-open.c (ctf_file_close): Likewise.
1049         * ctf-error.c (_ctf_errlist): Updated with new errors.
1050
1051 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1052
1053         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1054
1055 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1056
1057         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1058         ctf_type_iter.
1059         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1060         (ctf_dump_format_type): Add non-root-type { } notation.
1061         Add root flag to prototype.
1062         (ctf_dump_label): Adjust accordingly.
1063         (ctf_dump_objts): Likewise.
1064         (ctf_dump_var): Likewise.
1065
1066 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1067
1068         * ctf-create.c (ctf_compress_write): Fix double-free.
1069
1070 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1071
1072         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1073         of...
1074         (ctf_arc_write_fd): ... this new function.
1075         * ctf-create.c (ctf_write_mem): New.
1076
1077 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1078
1079         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1080         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1081         (ctf_str_add_ref): Name the last arg.
1082         (ctf_str_add_external) New.
1083         (ctf_str_add_strraw_explicit): Likewise.
1084         (ctf_simple_open_internal): Likewise.
1085         (ctf_bufopen_internal): Likewise.
1086
1087         * ctf-string.c (ctf_strraw_explicit): Split from...
1088         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1089         (ctf_str_add_ref_internal): Return the atom, not the
1090         string.
1091         (ctf_str_add): Adjust accordingly.
1092         (ctf_str_add_ref): Likewise.  Move up in the file.
1093         (ctf_str_add_external): New: update the csa_offset.
1094         (ctf_str_count_strtab): Only account for strings with no csa_offset
1095         in the internal strtab length.
1096         (ctf_str_write_strtab): If the csa_offset is set, update the
1097         string's refs without writing the string out, and update the
1098         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1099         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1100         (ctf_update): Handle failure to populate the strtab.  Pass in the
1101         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1102         Call ctf_simple_open_internal, not ctf_simple_open.
1103         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1104         strings by hand.
1105         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1106         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1107         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1108         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1109         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1110         (ctf_simple_open_internal): ... this new function, which calls
1111         ctf_bufopen_internal.
1112         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1113         (ctf_bufopen_internal): ... this new function, which sets
1114         ctf_syn_ext_strtab.
1115
1116 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1117
1118         * ctf_types.c (ctf_type_iter_all): New.
1119
1120 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1121
1122         * ctf-open.c (init_symtab): Check for overflow against the right
1123         section.
1124         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1125         (upgrade_types_v1): Note that these sections are not checked.
1126         (flip_header): Endian-swap the header fields.
1127         (flip_ctf): Endian-swap the sections.
1128         (flip_objts): Update comment.
1129         (ctf_bufopen): Check header offsets and alignment for validity.
1130
1131 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1132
1133         * ctf-open-bfd.c: Add <assert.h>.
1134         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1135         techniques borrowed from bfd_elf_sym_name.
1136         (ctf_new_archive_internal): Improve comment.
1137         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1138         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1139         no symbol section, but not vice versa.
1140
1141 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1142
1143         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1144         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1145         * ctf-dump.c (dump_header): New function, dump the CTF header.
1146         (ctf_dump): Call it.
1147         (ctf_dump_header_strfield): New function.
1148         (ctf_dump_header_sectfield): Likewise.
1149
1150 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1151
1152         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1153         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1154         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1155         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1156         Print out ctf_cuname: only print out ctf_parname if set.
1157         (ctf_free_base): Removed, ctf_base is no longer freed: free
1158         ctf_dynbase instead.
1159         (ctf_set_version): Fix spacing.
1160         (upgrade_header): New, in-place header upgrading.
1161         (upgrade_types): Rename to...
1162         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1163         longer track old and new headers separately.  No longer allow for
1164         header sizes explicitly: squeeze the headers out on upgrade (they
1165         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1166         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1167         (upgrade_types): New, also handle ctf_parmax updating.
1168         (flip_header): Flip ctf_cuname.
1169         (flip_types): Flip BUF explicitly rather than deriving BUF from
1170         BASE.
1171         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1172         required alignment of objtoff and funcoff.  No longer store it in
1173         the ctf_buf unless that buf is derived unmodified from the input.
1174         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1175         that duplicate fields in ctf_file: move allocation of ctf_file
1176         further up instead.  Call upgrade_header as needed.  Move
1177         version-specific ctf_parmax initialization into upgrade_types.  More
1178         concise error handling.
1179         (ctf_file_close): No longer test for null pointers before freeing.
1180         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1181         ctf_free_base.
1182         (ctf_cuname): New.
1183         (ctf_cuname_set): New.
1184         * ctf-create.c (ctf_update): Populate ctf_cuname.
1185         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1186         comment.
1187         (ctf_write): Likewise.
1188         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1189         Fix the compression length: fp->ctf_size never counted the CTF
1190         header.  Simplify the compress call accordingly.
1191
1192 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1193
1194         * ctf-endian.h: Don't assume htole64 and le64toh are always
1195         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1196         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1197         not bswap_identity_64.
1198
1199 2019-09-18  Alan Modra  <amodra@gmail.com>
1200
1201         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1202
1203 2019-09-09  Phil Blundell  <pb@pbcl.net>
1204
1205         binutils 2.33 branch created.
1206
1207 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1208
1209         * ctf-types.c (ctf_type_aname_raw): New.
1210         (ctf_func_type_info): Likewise.
1211         (ctf_func_type_args): Likewise.
1212         * ctf-error.c (_ctf_errlist): Fix description.
1213         * ctf-lookup.c: Fix file description.
1214
1215 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1216
1217         * ctf-create.c (ctf_create): Fix off-by-one error.
1218
1219 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1220
1221         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1222         struct ctf_strs.
1223         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1224         (struct ctf_str_atom): New, disambiguated single string.
1225         (struct ctf_str_atom_ref): New, points to some other location that
1226         references this string's offset.
1227         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1228         Remove member ctf_dtvstrlen: we no longer track the total strlen
1229         as we add strings.
1230         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1231         (ctf_str_free_atoms): Likewise.
1232         (ctf_str_add): Likewise.
1233         (ctf_str_add_ref): Likewise.
1234         (ctf_str_rollback): Likewise.
1235         (ctf_str_purge_refs): Likewise.
1236         (ctf_str_write_strtab): Likewise.
1237         (ctf_realloc): Declare new function in ctf-util.c.
1238
1239         * ctf-open.c (ctf_bufopen): Create the atoms table.
1240         (ctf_file_close): Destroy it.
1241         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1242         special-case the position of the parname string.  Construct the
1243         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1244         rest of each buffer element is constructed, not via open-coding:
1245         realloc the CTF buffer and append the strtab to it.  No longer
1246         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1247         strtab construction.
1248         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1249         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1250         after buffer element construction instead.
1251         (ctf_copy_lmembers): Likewise.
1252         (ctf_copy_emembers): Likewise.
1253         (ctf_create): No longer maintain the ctf_dtvstrlen.
1254         (ctf_dtd_delete): Likewise.
1255         (ctf_dvd_delete): Likewise.
1256         (ctf_add_generic): Likewise.
1257         (ctf_add_enumerator): Likewise.
1258         (ctf_add_member_offset): Likewise.
1259         (ctf_add_variable): Likewise.
1260         (membadd): Likewise.
1261         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1262         if there are active ctf_str_num_refs.
1263         (ctf_strraw): Move to ctf-string.c.
1264         (ctf_strptr): Likewise.
1265         * ctf-string.c: New file, strtab manipulation.
1266
1267         * Makefile.am (libctf_a_SOURCES): Add it.
1268         * Makefile.in: Regenerate.
1269
1270 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1271
1272         * ctf-impl.h (ctf_hash_iter_f): New.
1273         (ctf_dynhash_iter): New declaration.
1274         (ctf_dynhash_iter_remove): New declaration.
1275         * ctf-hash.c (ctf_dynhash_iter): Define.
1276         (ctf_dynhash_iter_remove): Likewise.
1277         (ctf_hashtab_traverse): New.
1278         (ctf_hashtab_traverse_remove): Likewise.
1279         (struct ctf_traverse_cb_arg): Likewise.
1280         (struct ctf_traverse_remove_cb_arg): Likewise.
1281
1282 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1283
1284         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1285
1286 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1287
1288         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1289         (ctf_dump_funcs): Likewise.
1290
1291 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1292
1293         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1294         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1295         little-endian CTF archive magic.  Do not check the CTF version:
1296         ctf_simple_open does that in endian-safe ways.  Do not dereference
1297         null pointers on open failure.
1298
1299 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1300
1301         * ctf-open.c (get_vbytes_common): Return the new slice size.
1302         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1303         Remember to copy in the CTF data when opening an uncompressed
1304         foreign-endian CTF file.  Prune useless variable manipulation.
1305
1306 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1307
1308         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1309         seen.
1310
1311 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1312
1313         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1314         output.
1315
1316 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1317
1318         * ctf-subr.c (_PAGESIZE): Remove.
1319         (ctf_data_alloc): Likewise.
1320         (ctf_data_free): Likewise.
1321         (ctf_data_protect): Likewise.
1322         * ctf-impl.h: Remove declarations.
1323         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1324         ctf_free, not ctf_data_free.
1325         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1326         the buffer again on compression error.
1327         * ctf-open.c (ctf_set_base): No longer track the size: call
1328         ctf_free, not ctf_data_free.
1329         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1330         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1331
1332 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1333
1334         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1335         ctf_dynhash_insert.
1336         (ctf_dvd_insert): Likewise.
1337         (ctf_add_generic): Likewise.
1338         (ctf_add_variable): Likewise.
1339         * ctf-impl.h: Adjust declarations.
1340
1341 2019-06-14  Alan Modra  <amodra@gmail.com>
1342
1343         * configure: Regenerate.
1344
1345 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1346
1347         * ctf-decls.h: Include <libiberty.h>.
1348         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1349
1350 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1351
1352         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1353         (ctf_dump_objts): Likewise.
1354         (ctf_dump_funcs): Likewise.
1355         (ctf_dump_member): Likewise.
1356         (ctf_dump_str): Likewise.
1357
1358 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1359
1360         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1361         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1362
1363 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1364
1365         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1366         (ctf_arc_open_by_offset): Likewise.
1367         * ctf-create.c (ctf_add_type): Likewise.
1368
1369 2019-06-04  Tom Tromey  <tromey@adacore.com>
1370
1371         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1372         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1373
1374 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1375
1376         * configure.ac: Check for O_CLOEXEC.
1377         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1378         * config.h.in: Regenerate.
1379         * configure: Likewise.
1380
1381 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1382
1383         * qsort_r.c: Rename to...
1384         * ctf-qsort_r.c: ... this.
1385         (_quicksort): Define to ctf_qsort_r.
1386         * ctf-decls.h (qsort_r): Remove.
1387         (ctf_qsort_r): Add.
1388         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1389         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1390         * Makefile.am (libctf_a_LIBADD): Remove.
1391         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1392         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1393         * ctf-create.c (ctf_update): Likewise.
1394         * configure.ac: Check for BSD versus GNU qsort_r signature.
1395         * Makefile.in: Regenerate.
1396         * config.h.in: Likewise.
1397         * configure: Likewise.
1398
1399 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1400
1401         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1402
1403 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1404
1405         * Makefile.am (ZLIB): New.
1406         (ZLIBINC): Likewise.
1407         (AM_CFLAGS): Use them.
1408         (libctf_a_LIBADD): New, for LIBOBJS.
1409         * configure.ac: Check for zlib, endian.h, and qsort_r.
1410         * ctf-endian.h: New, providing htole64 and le64toh.
1411         * swap.h: Code style fixes.
1412         (bswap_identity_64): New.
1413         * qsort_r.c: New, from gnulib (with one added #include).
1414         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1415         and unconditional definitions of MIN and MAX.
1416         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1417         (ctf_set_errno): Now returns unsigned long.
1418         * ctf-util.c (ctf_set_errno): Adjust here too.
1419         * ctf-archive.c: Use ctf-endian.h.
1420         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1421         cts_flags and cts_offset.
1422         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1423         * ctf-create.c: Provide a definition of roundup if not defined.
1424         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1425         (ctf_add_reftype): Do not check if type IDs are below zero.
1426         (ctf_add_slice): Likewise.
1427         (ctf_add_typedef): Likewise.
1428         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1429         when known error-free.  Drop CTF_ERR usage for functions returning
1430         int.
1431         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1432         int.
1433         (ctf_add_variable): Likewise.
1434         (enumcmp): Likewise.
1435         (enumadd): Likewise.
1436         (membcmp): Likewise.
1437         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1438         when known error-free.
1439         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1440         returning int: use CTF_ERR for functions returning ctf_type_id.
1441         (ctf_dump_label): Likewise.
1442         (ctf_dump_objts): Likewise.
1443         * ctf-labels.c (ctf_label_topmost): Likewise.
1444         (ctf_label_iter): Likewise.
1445         (ctf_label_info): Likewise.
1446         * ctf-lookup.c (ctf_func_args): Likewise.
1447         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1448         (ctf_bufopen): Likewise.  Use zlib types as needed.
1449         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1450         returning int.
1451         (ctf_enum_iter): Likewise.
1452         (ctf_type_size): Likewise.
1453         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1454         (ctf_type_kind_unsliced): Likewise.
1455         (ctf_type_kind): Likewise.
1456         (ctf_type_encoding): Likewise.
1457         (ctf_member_info): Likewise.
1458         (ctf_array_info): Likewise.
1459         (ctf_enum_value): Likewise.
1460         (ctf_type_rvisit): Likewise.
1461         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1462         cts_offset.
1463         (ctf_simple_open): Likewise.
1464         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1465         * Makefile.in: Regenerate.
1466         * aclocal.m4: Likewise.
1467         * config.h: Likewise.
1468         * configure: Likewise.
1469
1470 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1471
1472         * configure.in: Check for bfd_section_from_elf_index.
1473         * configure: Regenerate.
1474         * config.h.in [HAVE_BFD_ELF]: Likewise.
1475         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1476         abfd is potentially unused now.
1477
1478 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1479
1480         * Makefile.am: New.
1481         * Makefile.in: Regenerated.
1482         * config.h.in: Likewise.
1483         * aclocal.m4: Likewise.
1484         * configure: Likewise.
1485
1486 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1487
1488         * ctf-dump.c: New.
1489
1490 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1491
1492         * ctf-labels.c: New.
1493
1494 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1495
1496         * ctf-impl.h (_libctf_version): New declaration.
1497         * ctf-subr.c (_libctf_version): Define it.
1498         (ctf_version): New.
1499
1500 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1501
1502         * ctf-create.c (enumcmp): New.
1503         (enumadd): Likewise.
1504         (membcmp): Likewise.
1505         (membadd): Likewise.
1506         (ctf_add_type): Likewise.
1507
1508 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1509
1510         * ctf-lookup.c (isqualifier): New.
1511         (ctf_lookup_by_name): Likewise.
1512         (struct ctf_lookup_var_key): Likewise.
1513         (ctf_lookup_var): Likewise.
1514         (ctf_lookup_variable): Likewise.
1515         (ctf_lookup_symbol_name): Likewise.
1516         (ctf_lookup_by_symbol): Likewise.
1517         (ctf_func_info): Likewise.
1518         (ctf_func_args): Likewise.
1519
1520 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1521
1522         * ctf-decl.c: New file.
1523         * ctf-types.c: Likewise.
1524         * ctf-impl.h: New declarations.
1525
1526 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1527
1528         * ctf-open-bfd.c: New file.
1529         * ctf-open.c (ctf_close): New.
1530         * ctf-impl.h: Include bfd.h.
1531         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1532         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1533         ctfi_bfd_close.
1534         (ctf_bfdopen_ctfsect): New declaration.
1535         (_CTF_SECTION): likewise.
1536
1537 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1538
1539         * ctf-archive.c: New.
1540         * ctf-impl.h (ctf_archive_internal): New type.
1541         (ctf_arc_open_internal): New declaration.
1542         (ctf_arc_bufopen): Likewise.
1543         (ctf_arc_close_internal): Likewise.
1544
1545 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1546
1547         * ctf-open.c: New file.
1548         * swap.h: Likewise.
1549
1550 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1551
1552         * ctf-create.c: New file.
1553         * ctf-lookup.c: New file.
1554
1555 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1556
1557         * ctf-impl.h: New definitions and declarations for type creation
1558         and lookup.
1559
1560 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1561
1562         * ctf-hash.c: New file.
1563         * ctf-impl.h: New declarations.
1564
1565 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1566
1567         * ctf-error.c: New file.
1568
1569 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1570
1571         * ctf-util.c: New file.
1572         * elf.h: Likewise.
1573         * ctf-impl.h: Include it, and add declarations.
1574
1575 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1576
1577         * ctf-impl.h: New file.
1578         * ctf-subr.c: New file.
1579
1580 \f
1581 Local Variables:
1582 mode: change-log
1583 left-margin: 8
1584 fill-column: 76
1585 version-control: never
1586 End: