libctf/ChangeLog

   1 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
   4         work right for non-int/fps.
   5
   6 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
   7
   8         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
   9         null pointer.
  10
  11 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
  12
  13         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
  14         * ctf-open.c (ctf_file_close): Free it.
  15         * ctf-create.c (ctf_serialize): Adjust.
  16         (membcmp): When reporting a conflict due to an error, report the
  17         error.
  18         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
  19         (ctf_add_type_internal): ... this.  Hand back types we are already
  20         in the middle of adding immediately.  Hand back structs/unions with
  21         the same number of members immediately.  Do not walk the dynamic
  22         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
  23         forwards promoted to other types and the inverse case identically.
  24         Add structs to the mapping as soon as we intern them, before they
  25         gain any members.
  26
  27 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  28
  29         * ctf-impl.h (ctf_names_t): New.
  30         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
  31         (ctf_file_t) <ctf_structs>: Likewise.
  32         <ctf_unions>: Likewise.
  33         <ctf_enums>: Likewise.
  34         <ctf_names>: Likewise.
  35         <ctf_lookups>: Improve comment.
  36         <ctf_ptrtab_len>: New.
  37         <ctf_prov_strtab>: New.
  38         <ctf_str_prov_offset>: New.
  39         <ctf_dtbyname>: Remove, redundant to the names hashes.
  40         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
  41         (ctf_dtdef_t) <dtd_name>: Remove.
  42         <dtd_data>: Note that the ctt_name is now populated.
  43         (ctf_str_atom_t) <csa_offset>: This is now the strtab
  44         offset for internal strings too.
  45         <csa_external_offset>: New, the external strtab offset.
  46         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
  47         (ctf_name_table): New declaration.
  48         (ctf_lookup_by_rawname): Likewise.
  49         (ctf_lookup_by_rawhash): Likewise.
  50         (ctf_set_ctl_hashes): Likewise.
  51         (ctf_serialize): Likewise.
  52         (ctf_dtd_insert): Adjust.
  53         (ctf_simple_open_internal): Likewise.
  54         (ctf_bufopen_internal): Likewise.
  55         (ctf_list_empty_p): Likewise.
  56         (ctf_str_remove_ref): Likewise.
  57         (ctf_str_add): Returns uint32_t now.
  58         (ctf_str_add_ref): Likewise.
  59         (ctf_str_add_external): Now returns a boolean (int).
  60         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
  61         for strings in the appropriate range.
  62         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
  63         when adding the null string to the new strtab.
  64         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
  65         (ctf_str_add_ref_internal): Add make_provisional argument.  If
  66         make_provisional, populate the offset and fill in the
  67         ctf_prov_strtab accordingly.
  68         (ctf_str_add): Return the offset, not the string.
  69         (ctf_str_add_ref): Likewise.
  70         (ctf_str_add_external): Return a success integer.
  71         (ctf_str_remove_ref): New, remove a single ref.
  72         (ctf_str_count_strtab): Do not count the initial null string's
  73         length or the existence or length of any unreferenced internal
  74         atoms.
  75         (ctf_str_populate_sorttab): Skip atoms with no refs.
  76         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
  77         to the cts_len for the null string, since it is no longer done
  78         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
  79         Populate the csa_offset for both internal and external cases.
  80         Flush the ctf_prov_strtab afterwards, and reset the
  81         ctf_str_prov_offset.
  82         * ctf-create.c (ctf_grow_ptrtab): New.
  83         (ctf_create): Call it.  Initialize new fields rather than old
  84         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
  85         Set the ctl hashes and data model.
  86         (ctf_update): Rename to...
  87         (ctf_serialize): ... this.  Leave a compatibility function behind.
  88         Tell ctf_simple_open_internal that this is a writable dictionary.
  89         Pass the new fields along from the old dictionary.  Drop
  90         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
  91         Do not zero out the DTD's ctt_name.
  92         (ctf_prefixed_name): Rename to...
  93         (ctf_name_table): ... this.  No longer return a prefixed name: return
  94         the applicable name table instead.
  95         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
  96         kind we're adding.  Migrate away from dtd_name.
  97         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
  98         deleted ctt_name.
  99         (ctf_dtd_lookup_type_by_name): Remove.
 100         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 101         No longer check ctf_dtnextid: check ctf_typemax instead.
 102         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 103         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 104         ctf_name_table and the right name table, and migrate away from
 105         dtd_name as in ctf_dtd_delete.
 106         (ctf_add_generic): Pass in the kind explicitly and pass it to
 107         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 108         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 109         Grow the ptrtab if needed.
 110         (ctf_add_encoded): Pass in the kind.
 111         (ctf_add_slice): Likewise.
 112         (ctf_add_array): Likewise.
 113         (ctf_add_function): Likewise.
 114         (ctf_add_typedef): Likewise.
 115         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 116         ctt_name rather than dtd_name.
 117         (ctf_add_struct_sized): Pass in the kind.  Use
 118         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 119         ctf_dtd_lookup_type_by_name.
 120         (ctf_add_union_sized): Likewise.
 121         (ctf_add_enum): Likewise.
 122         (ctf_add_enum_encoded): Likewise.
 123         (ctf_add_forward): Likewise.
 124         (ctf_add_type): Likewise.
 125         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 126         being initialized until after the call.
 127         (ctf_write_mem): Likewise.
 128         (ctf_write): Likewise.
 129         * ctf-archive.c (arc_write_one_ctf): Likewise.
 130         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 131         ctf_hash_lookup_type.
 132         (ctf_lookup_by_id): No longer check the readonly types if the
 133         dictionary is writable.
 134         * ctf-open.c (init_types): Assert that this dictionary is not
 135         writable.  Adjust to use the new name hashes, ctf_name_table,
 136         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 137         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 138         if set.  Drop out early when dictionary is writable.  Split the
 139         ctf_lookups initialization into...
 140         (ctf_set_cth_hashes): ... this new function.
 141         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 142         (ctf_simple_open): Adjust accordingly.
 143         (ctf_bufopen): Likewise.
 144         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 145         destroy ctf_dtbyname, which is gone.
 146         (ctf_getdatasect): Remove spurious "extern".
 147         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 148         specified name table, given a kind.
 149         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 150         (ctf_member_iter): Add support for iterating over the
 151         dynamic type list.
 152         (ctf_enum_iter): Likewise.
 153         (ctf_variable_iter): Likewise.
 154         (ctf_type_rvisit): Likewise.
 155         (ctf_member_info): Add support for types in the dynamic type list.
 156         (ctf_enum_name): Likewise.
 157         (ctf_enum_value): Likewise.
 158         (ctf_func_type_info): Likewise.
 159         (ctf_func_type_args): Likewise.
 160         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 161         ctf_update.
 162         (ctf_link_write): Likewise.
 163         (ctf_link_intern_extern_string): Adjust for new
 164         ctf_str_add_external return value.
 165         (ctf_link_add_strtab): Likewise.
 166         * ctf-util.c (ctf_list_empty_p): New.
 167
 168 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 169
 170         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 171         type zero.
 172         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 173         members and types.
 174         (ctf_add_variable): Likewise for variables pointing to them.
 175         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 176         type link failure, but do warn for others.
 177         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 178         errors to be ENOMEM.
 179         (ctf_dump_member): Likewise.
 180         (ctf_dump_type): Likewise.
 181         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 182         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 183         (ctf_dump_header): Likewise.
 184         (ctf_dump_label): likewise.
 185         (ctf_dump_objts): likewise.
 186         (ctf_dump_funcs): likewise.
 187         (ctf_dump_var): likewise.
 188         (ctf_dump_str): Likewise.
 189
 190 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 191
 192         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 193         (LT_INIT): Likewise.
 194         (AM_INSTALL_LIBBFD): Likewise.
 195         (dlopen): Note why this is necessary in a comment.
 196         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 197         opcodes/.
 198         (SHARED_LDFLAGS): Likewise.
 199         (BFD_LIBADD): Likewise, for libbfd.
 200         (BFD_DEPENDENCIES): Likewise.
 201         (VERSION_FLAGS): Initialize, using a version script if ld supports
 202         one, or libtool -export-symbols-regex otherwise.
 203         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 204         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 205         (INCDIR): New.
 206         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 207         (noinst_LIBRARIES): Replace with...
 208         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 209         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 210         libctf-nobfd.la as well.
 211         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 212         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 213         (libctf_a_SOURCES): Rename to...
 214         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 215         ctf-open-bfd.c.
 216         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 217         with ctf-open-bfd.c added.
 218         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 219         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 220         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 221         * Makefile.am [INSTALL_LIBCTF]: Use it.
 222         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 223         libtool macros.
 224         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 225         the unstable components).
 226         * Makefile.in: Regenerated.
 227         * config.h.in: Likewise.
 228         * configure: Likewise.
 229
 230 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 231
 232         * configure.ac (INSTALL_LIBCTF): New, controlled by
 233         --enable-install-libctf.
 234         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 235         * Makefile.in: Regenerated.
 236         * configure: Regenerated.
 237
 238 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 239
 240         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 241         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 242
 243 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 244
 245         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 246
 247 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 248
 249         * ctf-impl.h (includes): Include <sys/param.h> here.
 250
 251 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 252
 253         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 254         (flip_objts): Likewise.
 255         (flip_vars): Likewise.
 256         (flip_types): Likewise.
 257
 258 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 259
 260         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 261         freeing functions: if set, free the key and value if the slot
 262         already exists.  Always reassign the key.
 263         (ctf_dynhash_insert): Adjust call appropriately.
 264         (ctf_hash_insert_type): Likewise.
 265
 266 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 267
 268         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 269         type kind.  Allow forwards to unify with pre-existing structs/
 270         unions/enums.
 271
 272 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 273
 274         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 275         <ctf_link_memb_name_changer>: Likewise.
 276         <ctf_link_memb_name_changer_arg>: Likewise.
 277         * ctf-create.c (ctf_update): Update accordingly.
 278         * ctf-open.c (ctf_file_close): Likewise.
 279         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 280         (ctf_link_add_cu_mapping): New.
 281         (ctf_link_set_memb_name_changer): Likewise.
 282         (ctf_change_parent_name): New.
 283         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 284         allocated by the caller's ctf_link_memb_name_changer.
 285         <ndynames>: Likewise.
 286         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 287         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 288         ctf_change_parent_name.  Free any resulting names.
 289
 290 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 291
 292         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 293         (ctf_link_one_type): ... here, with parent-name setting added.
 294         (check_variable): New.
 295         (ctf_link_one_variable): Likewise.
 296         (ctf_link_one_input_archive_member): Call it.
 297         * ctf-error.c (_ctf_errlist): Updated with new errors.
 298
 299 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 300
 301         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 302         (struct ctf_link_type_mapping_key): New.
 303         (ctf_hash_type_mapping_key): Likewise.
 304         (ctf_hash_eq_type_mapping_key): Likewise.
 305         (ctf_add_type_mapping): Likewise.
 306         (ctf_type_mapping): Likewise.
 307         (ctf_dynhash_empty): Likewise.
 308         * ctf-open.c (ctf_file_close): Update accordingly.
 309         * ctf-create.c (ctf_update): Likewise.
 310         (ctf_add_type): Populate the mapping.
 311         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 312         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 313         (ctf_dynhash_insert): Fix comment typo.
 314         (ctf_dynhash_empty): New.
 315         * ctf-link.c (ctf_add_type_mapping): New.
 316         (ctf_type_mapping): Likewise.
 317         (empty_link_type_mapping): New.
 318         (ctf_link_one_input_archive): Call it.
 319
 320 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 321
 322         * ctf-link.c: New file, linking of the string and type sections.
 323         * Makefile.am (libctf_a_SOURCES): Add it.
 324         * Makefile.in: Regenerate.
 325
 326         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 327         ctf_link_outputs.
 328         * ctf-create.c (ctf_update): Update accordingly.
 329         * ctf-open.c (ctf_file_close): Likewise.
 330         * ctf-error.c (_ctf_errlist): Updated with new errors.
 331
 332 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 333
 334         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 335
 336 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 337
 338         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 339         ctf_type_iter.
 340         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 341         (ctf_dump_format_type): Add non-root-type { } notation.
 342         Add root flag to prototype.
 343         (ctf_dump_label): Adjust accordingly.
 344         (ctf_dump_objts): Likewise.
 345         (ctf_dump_var): Likewise.
 346
 347 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 348
 349         * ctf-create.c (ctf_compress_write): Fix double-free.
 350
 351 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 352
 353         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 354         of...
 355         (ctf_arc_write_fd): ... this new function.
 356         * ctf-create.c (ctf_write_mem): New.
 357
 358 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 359
 360         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 361         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 362         (ctf_str_add_ref): Name the last arg.
 363         (ctf_str_add_external) New.
 364         (ctf_str_add_strraw_explicit): Likewise.
 365         (ctf_simple_open_internal): Likewise.
 366         (ctf_bufopen_internal): Likewise.
 367
 368         * ctf-string.c (ctf_strraw_explicit): Split from...
 369         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 370         (ctf_str_add_ref_internal): Return the atom, not the
 371         string.
 372         (ctf_str_add): Adjust accordingly.
 373         (ctf_str_add_ref): Likewise.  Move up in the file.
 374         (ctf_str_add_external): New: update the csa_offset.
 375         (ctf_str_count_strtab): Only account for strings with no csa_offset
 376         in the internal strtab length.
 377         (ctf_str_write_strtab): If the csa_offset is set, update the
 378         string's refs without writing the string out, and update the
 379         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 380         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 381         (ctf_update): Handle failure to populate the strtab.  Pass in the
 382         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 383         Call ctf_simple_open_internal, not ctf_simple_open.
 384         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 385         strings by hand.
 386         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 387         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 388         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 389         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 390         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 391         (ctf_simple_open_internal): ... this new function, which calls
 392         ctf_bufopen_internal.
 393         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 394         (ctf_bufopen_internal): ... this new function, which sets
 395         ctf_syn_ext_strtab.
 396
 397 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 398
 399         * ctf_types.c (ctf_type_iter_all): New.
 400
 401 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 402
 403         * ctf-open.c (init_symtab): Check for overflow against the right
 404         section.
 405         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 406         (upgrade_types_v1): Note that these sections are not checked.
 407         (flip_header): Endian-swap the header fields.
 408         (flip_ctf): Endian-swap the sections.
 409         (flip_objts): Update comment.
 410         (ctf_bufopen): Check header offsets and alignment for validity.
 411
 412 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 413
 414         * ctf-open-bfd.c: Add <assert.h>.
 415         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 416         techniques borrowed from bfd_elf_sym_name.
 417         (ctf_new_archive_internal): Improve comment.
 418         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 419         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 420         no symbol section, but not vice versa.
 421
 422 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 423
 424         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 425         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 426         * ctf-dump.c (dump_header): New function, dump the CTF header.
 427         (ctf_dump): Call it.
 428         (ctf_dump_header_strfield): New function.
 429         (ctf_dump_header_sectfield): Likewise.
 430
 431 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 432
 433         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 434         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 435         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 436         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 437         Print out ctf_cuname: only print out ctf_parname if set.
 438         (ctf_free_base): Removed, ctf_base is no longer freed: free
 439         ctf_dynbase instead.
 440         (ctf_set_version): Fix spacing.
 441         (upgrade_header): New, in-place header upgrading.
 442         (upgrade_types): Rename to...
 443         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 444         longer track old and new headers separately.  No longer allow for
 445         header sizes explicitly: squeeze the headers out on upgrade (they
 446         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 447         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 448         (upgrade_types): New, also handle ctf_parmax updating.
 449         (flip_header): Flip ctf_cuname.
 450         (flip_types): Flip BUF explicitly rather than deriving BUF from
 451         BASE.
 452         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 453         required alignment of objtoff and funcoff.  No longer store it in
 454         the ctf_buf unless that buf is derived unmodified from the input.
 455         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 456         that duplicate fields in ctf_file: move allocation of ctf_file
 457         further up instead.  Call upgrade_header as needed.  Move
 458         version-specific ctf_parmax initialization into upgrade_types.  More
 459         concise error handling.
 460         (ctf_file_close): No longer test for null pointers before freeing.
 461         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 462         ctf_free_base.
 463         (ctf_cuname): New.
 464         (ctf_cuname_set): New.
 465         * ctf-create.c (ctf_update): Populate ctf_cuname.
 466         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 467         comment.
 468         (ctf_write): Likewise.
 469         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 470         Fix the compression length: fp->ctf_size never counted the CTF
 471         header.  Simplify the compress call accordingly.
 472
 473 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 474
 475         * ctf-endian.h: Don't assume htole64 and le64toh are always
 476         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 477         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 478         not bswap_identity_64.
 479
 480 2019-09-18  Alan Modra  <amodra@gmail.com>
 481
 482         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 483
 484 2019-09-09  Phil Blundell  <pb@pbcl.net>
 485
 486         binutils 2.33 branch created.
 487
 488 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 489
 490         * ctf-types.c (ctf_type_aname_raw): New.
 491         (ctf_func_type_info): Likewise.
 492         (ctf_func_type_args): Likewise.
 493         * ctf-error.c (_ctf_errlist): Fix description.
 494         * ctf-lookup.c: Fix file description.
 495
 496 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 497
 498         * ctf-create.c (ctf_create): Fix off-by-one error.
 499
 500 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 501
 502         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 503         struct ctf_strs.
 504         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 505         (struct ctf_str_atom): New, disambiguated single string.
 506         (struct ctf_str_atom_ref): New, points to some other location that
 507         references this string's offset.
 508         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 509         Remove member ctf_dtvstrlen: we no longer track the total strlen
 510         as we add strings.
 511         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 512         (ctf_str_free_atoms): Likewise.
 513         (ctf_str_add): Likewise.
 514         (ctf_str_add_ref): Likewise.
 515         (ctf_str_rollback): Likewise.
 516         (ctf_str_purge_refs): Likewise.
 517         (ctf_str_write_strtab): Likewise.
 518         (ctf_realloc): Declare new function in ctf-util.c.
 519
 520         * ctf-open.c (ctf_bufopen): Create the atoms table.
 521         (ctf_file_close): Destroy it.
 522         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 523         special-case the position of the parname string.  Construct the
 524         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 525         rest of each buffer element is constructed, not via open-coding:
 526         realloc the CTF buffer and append the strtab to it.  No longer
 527         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 528         strtab construction.
 529         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 530         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 531         after buffer element construction instead.
 532         (ctf_copy_lmembers): Likewise.
 533         (ctf_copy_emembers): Likewise.
 534         (ctf_create): No longer maintain the ctf_dtvstrlen.
 535         (ctf_dtd_delete): Likewise.
 536         (ctf_dvd_delete): Likewise.
 537         (ctf_add_generic): Likewise.
 538         (ctf_add_enumerator): Likewise.
 539         (ctf_add_member_offset): Likewise.
 540         (ctf_add_variable): Likewise.
 541         (membadd): Likewise.
 542         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 543         if there are active ctf_str_num_refs.
 544         (ctf_strraw): Move to ctf-string.c.
 545         (ctf_strptr): Likewise.
 546         * ctf-string.c: New file, strtab manipulation.
 547
 548         * Makefile.am (libctf_a_SOURCES): Add it.
 549         * Makefile.in: Regenerate.
 550
 551 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 552
 553         * ctf-impl.h (ctf_hash_iter_f): New.
 554         (ctf_dynhash_iter): New declaration.
 555         (ctf_dynhash_iter_remove): New declaration.
 556         * ctf-hash.c (ctf_dynhash_iter): Define.
 557         (ctf_dynhash_iter_remove): Likewise.
 558         (ctf_hashtab_traverse): New.
 559         (ctf_hashtab_traverse_remove): Likewise.
 560         (struct ctf_traverse_cb_arg): Likewise.
 561         (struct ctf_traverse_remove_cb_arg): Likewise.
 562
 563 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 564
 565         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 566
 567 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 568
 569         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 570         (ctf_dump_funcs): Likewise.
 571
 572 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 573
 574         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 575         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 576         little-endian CTF archive magic.  Do not check the CTF version:
 577         ctf_simple_open does that in endian-safe ways.  Do not dereference
 578         null pointers on open failure.
 579
 580 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 581
 582         * ctf-open.c (get_vbytes_common): Return the new slice size.
 583         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 584         Remember to copy in the CTF data when opening an uncompressed
 585         foreign-endian CTF file.  Prune useless variable manipulation.
 586
 587 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 588
 589         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 590         seen.
 591
 592 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 593
 594         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 595         output.
 596
 597 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 598
 599         * ctf-subr.c (_PAGESIZE): Remove.
 600         (ctf_data_alloc): Likewise.
 601         (ctf_data_free): Likewise.
 602         (ctf_data_protect): Likewise.
 603         * ctf-impl.h: Remove declarations.
 604         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 605         ctf_free, not ctf_data_free.
 606         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 607         the buffer again on compression error.
 608         * ctf-open.c (ctf_set_base): No longer track the size: call
 609         ctf_free, not ctf_data_free.
 610         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 611         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 612
 613 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 614
 615         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 616         ctf_dynhash_insert.
 617         (ctf_dvd_insert): Likewise.
 618         (ctf_add_generic): Likewise.
 619         (ctf_add_variable): Likewise.
 620         * ctf-impl.h: Adjust declarations.
 621
 622 2019-06-14  Alan Modra  <amodra@gmail.com>
 623
 624         * configure: Regenerate.
 625
 626 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 627
 628         * ctf-decls.h: Include <libiberty.h>.
 629         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 630
 631 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 632
 633         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 634         (ctf_dump_objts): Likewise.
 635         (ctf_dump_funcs): Likewise.
 636         (ctf_dump_member): Likewise.
 637         (ctf_dump_str): Likewise.
 638
 639 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 640
 641         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 642         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 643
 644 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 645
 646         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 647         (ctf_arc_open_by_offset): Likewise.
 648         * ctf-create.c (ctf_add_type): Likewise.
 649
 650 2019-06-04  Tom Tromey  <tromey@adacore.com>
 651
 652         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 653         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 654
 655 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 656
 657         * configure.ac: Check for O_CLOEXEC.
 658         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 659         * config.h.in: Regenerate.
 660         * configure: Likewise.
 661
 662 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 663
 664         * qsort_r.c: Rename to...
 665         * ctf-qsort_r.c: ... this.
 666         (_quicksort): Define to ctf_qsort_r.
 667         * ctf-decls.h (qsort_r): Remove.
 668         (ctf_qsort_r): Add.
 669         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 670         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 671         * Makefile.am (libctf_a_LIBADD): Remove.
 672         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 673         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 674         * ctf-create.c (ctf_update): Likewise.
 675         * configure.ac: Check for BSD versus GNU qsort_r signature.
 676         * Makefile.in: Regenerate.
 677         * config.h.in: Likewise.
 678         * configure: Likewise.
 679
 680 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 681
 682         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 683
 684 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 685
 686         * Makefile.am (ZLIB): New.
 687         (ZLIBINC): Likewise.
 688         (AM_CFLAGS): Use them.
 689         (libctf_a_LIBADD): New, for LIBOBJS.
 690         * configure.ac: Check for zlib, endian.h, and qsort_r.
 691         * ctf-endian.h: New, providing htole64 and le64toh.
 692         * swap.h: Code style fixes.
 693         (bswap_identity_64): New.
 694         * qsort_r.c: New, from gnulib (with one added #include).
 695         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 696         and unconditional definitions of MIN and MAX.
 697         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 698         (ctf_set_errno): Now returns unsigned long.
 699         * ctf-util.c (ctf_set_errno): Adjust here too.
 700         * ctf-archive.c: Use ctf-endian.h.
 701         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 702         cts_flags and cts_offset.
 703         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 704         * ctf-create.c: Provide a definition of roundup if not defined.
 705         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 706         (ctf_add_reftype): Do not check if type IDs are below zero.
 707         (ctf_add_slice): Likewise.
 708         (ctf_add_typedef): Likewise.
 709         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 710         when known error-free.  Drop CTF_ERR usage for functions returning
 711         int.
 712         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 713         int.
 714         (ctf_add_variable): Likewise.
 715         (enumcmp): Likewise.
 716         (enumadd): Likewise.
 717         (membcmp): Likewise.
 718         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 719         when known error-free.
 720         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 721         returning int: use CTF_ERR for functions returning ctf_type_id.
 722         (ctf_dump_label): Likewise.
 723         (ctf_dump_objts): Likewise.
 724         * ctf-labels.c (ctf_label_topmost): Likewise.
 725         (ctf_label_iter): Likewise.
 726         (ctf_label_info): Likewise.
 727         * ctf-lookup.c (ctf_func_args): Likewise.
 728         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 729         (ctf_bufopen): Likewise.  Use zlib types as needed.
 730         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 731         returning int.
 732         (ctf_enum_iter): Likewise.
 733         (ctf_type_size): Likewise.
 734         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 735         (ctf_type_kind_unsliced): Likewise.
 736         (ctf_type_kind): Likewise.
 737         (ctf_type_encoding): Likewise.
 738         (ctf_member_info): Likewise.
 739         (ctf_array_info): Likewise.
 740         (ctf_enum_value): Likewise.
 741         (ctf_type_rvisit): Likewise.
 742         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 743         cts_offset.
 744         (ctf_simple_open): Likewise.
 745         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 746         * Makefile.in: Regenerate.
 747         * aclocal.m4: Likewise.
 748         * config.h: Likewise.
 749         * configure: Likewise.
 750
 751 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 752
 753         * configure.in: Check for bfd_section_from_elf_index.
 754         * configure: Regenerate.
 755         * config.h.in [HAVE_BFD_ELF]: Likewise.
 756         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 757         abfd is potentially unused now.
 758
 759 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 760
 761         * Makefile.am: New.
 762         * Makefile.in: Regenerated.
 763         * config.h.in: Likewise.
 764         * aclocal.m4: Likewise.
 765         * configure: Likewise.
 766
 767 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 768
 769         * ctf-dump.c: New.
 770
 771 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 772
 773         * ctf-labels.c: New.
 774
 775 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 776
 777         * ctf-impl.h (_libctf_version): New declaration.
 778         * ctf-subr.c (_libctf_version): Define it.
 779         (ctf_version): New.
 780
 781 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 782
 783         * ctf-create.c (enumcmp): New.
 784         (enumadd): Likewise.
 785         (membcmp): Likewise.
 786         (membadd): Likewise.
 787         (ctf_add_type): Likewise.
 788
 789 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 790
 791         * ctf-lookup.c (isqualifier): New.
 792         (ctf_lookup_by_name): Likewise.
 793         (struct ctf_lookup_var_key): Likewise.
 794         (ctf_lookup_var): Likewise.
 795         (ctf_lookup_variable): Likewise.
 796         (ctf_lookup_symbol_name): Likewise.
 797         (ctf_lookup_by_symbol): Likewise.
 798         (ctf_func_info): Likewise.
 799         (ctf_func_args): Likewise.
 800
 801 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 802
 803         * ctf-decl.c: New file.
 804         * ctf-types.c: Likewise.
 805         * ctf-impl.h: New declarations.
 806
 807 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 808
 809         * ctf-open-bfd.c: New file.
 810         * ctf-open.c (ctf_close): New.
 811         * ctf-impl.h: Include bfd.h.
 812         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 813         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 814         ctfi_bfd_close.
 815         (ctf_bfdopen_ctfsect): New declaration.
 816         (_CTF_SECTION): likewise.
 817
 818 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 819
 820         * ctf-archive.c: New.
 821         * ctf-impl.h (ctf_archive_internal): New type.
 822         (ctf_arc_open_internal): New declaration.
 823         (ctf_arc_bufopen): Likewise.
 824         (ctf_arc_close_internal): Likewise.
 825
 826 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 827
 828         * ctf-open.c: New file.
 829         * swap.h: Likewise.
 830
 831 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 832
 833         * ctf-create.c: New file.
 834         * ctf-lookup.c: New file.
 835
 836 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 837
 838         * ctf-impl.h: New definitions and declarations for type creation
 839         and lookup.
 840
 841 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 842
 843         * ctf-hash.c: New file.
 844         * ctf-impl.h: New declarations.
 845
 846 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 847
 848         * ctf-error.c: New file.
 849
 850 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 851
 852         * ctf-util.c: New file.
 853         * elf.h: Likewise.
 854         * ctf-impl.h: Include it, and add declarations.
 855
 856 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 857
 858         * ctf-impl.h: New file.
 859         * ctf-subr.c: New file.
 860
 861 \f
 862 Local Variables:
 863 mode: change-log
 864 left-margin: 8
 865 fill-column: 76
 866 version-control: never
 867 End: