libctf/ChangeLog

   1 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
   4         ctf_import after the first for a given file.
   5
   6 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
   7
   8         * ctf-impl.h (ctf_str_append_noerr): Declare.
   9         * ctf-util.c (ctf_str_append_noerr): Define in terms of
  10         ctf_str_append.
  11         * ctf-dump.c (str_append): New, call it.
  12         (ctf_dump_format_type): Use str_append, not ctf_str_append.
  13         (ctf_dump_label): Likewise.
  14         (ctf_dump_objts): Likewise.
  15         (ctf_dump_funcs): Likewise.
  16         (ctf_dump_var): Likewise.
  17         (ctf_dump_member): Likewise.
  18         (ctf_dump_type): Likewise.
  19         (ctf_dump): Likewise.
  20
  21 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  22
  23         * ctf-impl.h (ctf_alloc): Remove.
  24         (ctf_free): Likewise.
  25         (ctf_strdup): Likewise.
  26         * ctf-subr.c (ctf_alloc): Remove.
  27         (ctf_free): Likewise.
  28         * ctf-util.c (ctf_strdup): Remove.
  29
  30         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
  31         ctf_free; strdup, not ctf_strdup.
  32         (ctf_dtd_delete): Likewise.
  33         (ctf_dvd_delete): Likewise.
  34         (ctf_add_generic): Likewise.
  35         (ctf_add_function): Likewise.
  36         (ctf_add_enumerator): Likewise.
  37         (ctf_add_member_offset): Likewise.
  38         (ctf_add_variable): Likewise.
  39         (membadd): Likewise.
  40         (ctf_compress_write): Likewise.
  41         (ctf_write_mem): Likewise.
  42         * ctf-decl.c (ctf_decl_push): Likewise.
  43         (ctf_decl_fini): Likewise.
  44         (ctf_decl_sprintf): Likewise.  Check for OOM.
  45         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
  46         ctf_free; strdup, not ctf_strdup.
  47         (ctf_dump_free): Likewise.
  48         (ctf_dump): Likewise.
  49         * ctf-open.c (upgrade_types_v1): Likewise.
  50         (init_types): Likewise.
  51         (ctf_file_close): Likewise.
  52         (ctf_bufopen_internal): Likewise.  Check for OOM.
  53         (ctf_parent_name_set): Likewise: report the OOM to the caller.
  54         (ctf_cuname_set): Likewise.
  55         (ctf_import): Likewise.
  56         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
  57         free, not ctf_free; strdup, not ctf_strdup.
  58         (ctf_str_free_atom): Likewise.
  59         (ctf_str_create_atoms): Likewise.
  60         (ctf_str_add_ref_internal): Likewise.
  61         (ctf_str_remove_ref): Likewise.
  62         (ctf_str_write_strtab): Likewise.
  63
  64 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  65
  66         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
  67         work right for non-int/fps.
  68
  69 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
  70
  71         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
  72         null pointer.
  73
  74 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
  75
  76         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
  77         * ctf-open.c (ctf_file_close): Free it.
  78         * ctf-create.c (ctf_serialize): Adjust.
  79         (membcmp): When reporting a conflict due to an error, report the
  80         error.
  81         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
  82         (ctf_add_type_internal): ... this.  Hand back types we are already
  83         in the middle of adding immediately.  Hand back structs/unions with
  84         the same number of members immediately.  Do not walk the dynamic
  85         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
  86         forwards promoted to other types and the inverse case identically.
  87         Add structs to the mapping as soon as we intern them, before they
  88         gain any members.
  89
  90 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  91
  92         * ctf-impl.h (ctf_names_t): New.
  93         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
  94         (ctf_file_t) <ctf_structs>: Likewise.
  95         <ctf_unions>: Likewise.
  96         <ctf_enums>: Likewise.
  97         <ctf_names>: Likewise.
  98         <ctf_lookups>: Improve comment.
  99         <ctf_ptrtab_len>: New.
 100         <ctf_prov_strtab>: New.
 101         <ctf_str_prov_offset>: New.
 102         <ctf_dtbyname>: Remove, redundant to the names hashes.
 103         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 104         (ctf_dtdef_t) <dtd_name>: Remove.
 105         <dtd_data>: Note that the ctt_name is now populated.
 106         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 107         offset for internal strings too.
 108         <csa_external_offset>: New, the external strtab offset.
 109         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 110         (ctf_name_table): New declaration.
 111         (ctf_lookup_by_rawname): Likewise.
 112         (ctf_lookup_by_rawhash): Likewise.
 113         (ctf_set_ctl_hashes): Likewise.
 114         (ctf_serialize): Likewise.
 115         (ctf_dtd_insert): Adjust.
 116         (ctf_simple_open_internal): Likewise.
 117         (ctf_bufopen_internal): Likewise.
 118         (ctf_list_empty_p): Likewise.
 119         (ctf_str_remove_ref): Likewise.
 120         (ctf_str_add): Returns uint32_t now.
 121         (ctf_str_add_ref): Likewise.
 122         (ctf_str_add_external): Now returns a boolean (int).
 123         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 124         for strings in the appropriate range.
 125         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 126         when adding the null string to the new strtab.
 127         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 128         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 129         make_provisional, populate the offset and fill in the
 130         ctf_prov_strtab accordingly.
 131         (ctf_str_add): Return the offset, not the string.
 132         (ctf_str_add_ref): Likewise.
 133         (ctf_str_add_external): Return a success integer.
 134         (ctf_str_remove_ref): New, remove a single ref.
 135         (ctf_str_count_strtab): Do not count the initial null string's
 136         length or the existence or length of any unreferenced internal
 137         atoms.
 138         (ctf_str_populate_sorttab): Skip atoms with no refs.
 139         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 140         to the cts_len for the null string, since it is no longer done
 141         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 142         Populate the csa_offset for both internal and external cases.
 143         Flush the ctf_prov_strtab afterwards, and reset the
 144         ctf_str_prov_offset.
 145         * ctf-create.c (ctf_grow_ptrtab): New.
 146         (ctf_create): Call it.  Initialize new fields rather than old
 147         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 148         Set the ctl hashes and data model.
 149         (ctf_update): Rename to...
 150         (ctf_serialize): ... this.  Leave a compatibility function behind.
 151         Tell ctf_simple_open_internal that this is a writable dictionary.
 152         Pass the new fields along from the old dictionary.  Drop
 153         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 154         Do not zero out the DTD's ctt_name.
 155         (ctf_prefixed_name): Rename to...
 156         (ctf_name_table): ... this.  No longer return a prefixed name: return
 157         the applicable name table instead.
 158         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 159         kind we're adding.  Migrate away from dtd_name.
 160         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 161         deleted ctt_name.
 162         (ctf_dtd_lookup_type_by_name): Remove.
 163         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 164         No longer check ctf_dtnextid: check ctf_typemax instead.
 165         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 166         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 167         ctf_name_table and the right name table, and migrate away from
 168         dtd_name as in ctf_dtd_delete.
 169         (ctf_add_generic): Pass in the kind explicitly and pass it to
 170         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 171         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 172         Grow the ptrtab if needed.
 173         (ctf_add_encoded): Pass in the kind.
 174         (ctf_add_slice): Likewise.
 175         (ctf_add_array): Likewise.
 176         (ctf_add_function): Likewise.
 177         (ctf_add_typedef): Likewise.
 178         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 179         ctt_name rather than dtd_name.
 180         (ctf_add_struct_sized): Pass in the kind.  Use
 181         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 182         ctf_dtd_lookup_type_by_name.
 183         (ctf_add_union_sized): Likewise.
 184         (ctf_add_enum): Likewise.
 185         (ctf_add_enum_encoded): Likewise.
 186         (ctf_add_forward): Likewise.
 187         (ctf_add_type): Likewise.
 188         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 189         being initialized until after the call.
 190         (ctf_write_mem): Likewise.
 191         (ctf_write): Likewise.
 192         * ctf-archive.c (arc_write_one_ctf): Likewise.
 193         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 194         ctf_hash_lookup_type.
 195         (ctf_lookup_by_id): No longer check the readonly types if the
 196         dictionary is writable.
 197         * ctf-open.c (init_types): Assert that this dictionary is not
 198         writable.  Adjust to use the new name hashes, ctf_name_table,
 199         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 200         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 201         if set.  Drop out early when dictionary is writable.  Split the
 202         ctf_lookups initialization into...
 203         (ctf_set_cth_hashes): ... this new function.
 204         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 205         (ctf_simple_open): Adjust accordingly.
 206         (ctf_bufopen): Likewise.
 207         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 208         destroy ctf_dtbyname, which is gone.
 209         (ctf_getdatasect): Remove spurious "extern".
 210         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 211         specified name table, given a kind.
 212         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 213         (ctf_member_iter): Add support for iterating over the
 214         dynamic type list.
 215         (ctf_enum_iter): Likewise.
 216         (ctf_variable_iter): Likewise.
 217         (ctf_type_rvisit): Likewise.
 218         (ctf_member_info): Add support for types in the dynamic type list.
 219         (ctf_enum_name): Likewise.
 220         (ctf_enum_value): Likewise.
 221         (ctf_func_type_info): Likewise.
 222         (ctf_func_type_args): Likewise.
 223         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 224         ctf_update.
 225         (ctf_link_write): Likewise.
 226         (ctf_link_intern_extern_string): Adjust for new
 227         ctf_str_add_external return value.
 228         (ctf_link_add_strtab): Likewise.
 229         * ctf-util.c (ctf_list_empty_p): New.
 230
 231 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 232
 233         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 234         type zero.
 235         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 236         members and types.
 237         (ctf_add_variable): Likewise for variables pointing to them.
 238         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 239         type link failure, but do warn for others.
 240         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 241         errors to be ENOMEM.
 242         (ctf_dump_member): Likewise.
 243         (ctf_dump_type): Likewise.
 244         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 245         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 246         (ctf_dump_header): Likewise.
 247         (ctf_dump_label): likewise.
 248         (ctf_dump_objts): likewise.
 249         (ctf_dump_funcs): likewise.
 250         (ctf_dump_var): likewise.
 251         (ctf_dump_str): Likewise.
 252
 253 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 254
 255         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 256         (LT_INIT): Likewise.
 257         (AM_INSTALL_LIBBFD): Likewise.
 258         (dlopen): Note why this is necessary in a comment.
 259         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 260         opcodes/.
 261         (SHARED_LDFLAGS): Likewise.
 262         (BFD_LIBADD): Likewise, for libbfd.
 263         (BFD_DEPENDENCIES): Likewise.
 264         (VERSION_FLAGS): Initialize, using a version script if ld supports
 265         one, or libtool -export-symbols-regex otherwise.
 266         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 267         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 268         (INCDIR): New.
 269         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 270         (noinst_LIBRARIES): Replace with...
 271         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 272         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 273         libctf-nobfd.la as well.
 274         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 275         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 276         (libctf_a_SOURCES): Rename to...
 277         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 278         ctf-open-bfd.c.
 279         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 280         with ctf-open-bfd.c added.
 281         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 282         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 283         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 284         * Makefile.am [INSTALL_LIBCTF]: Use it.
 285         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 286         libtool macros.
 287         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 288         the unstable components).
 289         * Makefile.in: Regenerated.
 290         * config.h.in: Likewise.
 291         * configure: Likewise.
 292
 293 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 294
 295         * configure.ac (INSTALL_LIBCTF): New, controlled by
 296         --enable-install-libctf.
 297         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 298         * Makefile.in: Regenerated.
 299         * configure: Regenerated.
 300
 301 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 302
 303         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 304         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 305
 306 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 307
 308         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 309
 310 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 311
 312         * ctf-impl.h (includes): Include <sys/param.h> here.
 313
 314 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 315
 316         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 317         (flip_objts): Likewise.
 318         (flip_vars): Likewise.
 319         (flip_types): Likewise.
 320
 321 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 322
 323         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 324         freeing functions: if set, free the key and value if the slot
 325         already exists.  Always reassign the key.
 326         (ctf_dynhash_insert): Adjust call appropriately.
 327         (ctf_hash_insert_type): Likewise.
 328
 329 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 330
 331         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 332         type kind.  Allow forwards to unify with pre-existing structs/
 333         unions/enums.
 334
 335 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 336
 337         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 338         <ctf_link_memb_name_changer>: Likewise.
 339         <ctf_link_memb_name_changer_arg>: Likewise.
 340         * ctf-create.c (ctf_update): Update accordingly.
 341         * ctf-open.c (ctf_file_close): Likewise.
 342         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 343         (ctf_link_add_cu_mapping): New.
 344         (ctf_link_set_memb_name_changer): Likewise.
 345         (ctf_change_parent_name): New.
 346         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 347         allocated by the caller's ctf_link_memb_name_changer.
 348         <ndynames>: Likewise.
 349         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 350         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 351         ctf_change_parent_name.  Free any resulting names.
 352
 353 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 354
 355         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 356         (ctf_link_one_type): ... here, with parent-name setting added.
 357         (check_variable): New.
 358         (ctf_link_one_variable): Likewise.
 359         (ctf_link_one_input_archive_member): Call it.
 360         * ctf-error.c (_ctf_errlist): Updated with new errors.
 361
 362 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 363
 364         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 365         (struct ctf_link_type_mapping_key): New.
 366         (ctf_hash_type_mapping_key): Likewise.
 367         (ctf_hash_eq_type_mapping_key): Likewise.
 368         (ctf_add_type_mapping): Likewise.
 369         (ctf_type_mapping): Likewise.
 370         (ctf_dynhash_empty): Likewise.
 371         * ctf-open.c (ctf_file_close): Update accordingly.
 372         * ctf-create.c (ctf_update): Likewise.
 373         (ctf_add_type): Populate the mapping.
 374         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 375         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 376         (ctf_dynhash_insert): Fix comment typo.
 377         (ctf_dynhash_empty): New.
 378         * ctf-link.c (ctf_add_type_mapping): New.
 379         (ctf_type_mapping): Likewise.
 380         (empty_link_type_mapping): New.
 381         (ctf_link_one_input_archive): Call it.
 382
 383 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 384
 385         * ctf-link.c: New file, linking of the string and type sections.
 386         * Makefile.am (libctf_a_SOURCES): Add it.
 387         * Makefile.in: Regenerate.
 388
 389         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 390         ctf_link_outputs.
 391         * ctf-create.c (ctf_update): Update accordingly.
 392         * ctf-open.c (ctf_file_close): Likewise.
 393         * ctf-error.c (_ctf_errlist): Updated with new errors.
 394
 395 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 396
 397         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 398
 399 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 400
 401         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 402         ctf_type_iter.
 403         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 404         (ctf_dump_format_type): Add non-root-type { } notation.
 405         Add root flag to prototype.
 406         (ctf_dump_label): Adjust accordingly.
 407         (ctf_dump_objts): Likewise.
 408         (ctf_dump_var): Likewise.
 409
 410 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 411
 412         * ctf-create.c (ctf_compress_write): Fix double-free.
 413
 414 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 415
 416         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 417         of...
 418         (ctf_arc_write_fd): ... this new function.
 419         * ctf-create.c (ctf_write_mem): New.
 420
 421 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 422
 423         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 424         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 425         (ctf_str_add_ref): Name the last arg.
 426         (ctf_str_add_external) New.
 427         (ctf_str_add_strraw_explicit): Likewise.
 428         (ctf_simple_open_internal): Likewise.
 429         (ctf_bufopen_internal): Likewise.
 430
 431         * ctf-string.c (ctf_strraw_explicit): Split from...
 432         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 433         (ctf_str_add_ref_internal): Return the atom, not the
 434         string.
 435         (ctf_str_add): Adjust accordingly.
 436         (ctf_str_add_ref): Likewise.  Move up in the file.
 437         (ctf_str_add_external): New: update the csa_offset.
 438         (ctf_str_count_strtab): Only account for strings with no csa_offset
 439         in the internal strtab length.
 440         (ctf_str_write_strtab): If the csa_offset is set, update the
 441         string's refs without writing the string out, and update the
 442         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 443         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 444         (ctf_update): Handle failure to populate the strtab.  Pass in the
 445         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 446         Call ctf_simple_open_internal, not ctf_simple_open.
 447         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 448         strings by hand.
 449         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 450         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 451         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 452         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 453         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 454         (ctf_simple_open_internal): ... this new function, which calls
 455         ctf_bufopen_internal.
 456         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 457         (ctf_bufopen_internal): ... this new function, which sets
 458         ctf_syn_ext_strtab.
 459
 460 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 461
 462         * ctf_types.c (ctf_type_iter_all): New.
 463
 464 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 465
 466         * ctf-open.c (init_symtab): Check for overflow against the right
 467         section.
 468         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 469         (upgrade_types_v1): Note that these sections are not checked.
 470         (flip_header): Endian-swap the header fields.
 471         (flip_ctf): Endian-swap the sections.
 472         (flip_objts): Update comment.
 473         (ctf_bufopen): Check header offsets and alignment for validity.
 474
 475 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 476
 477         * ctf-open-bfd.c: Add <assert.h>.
 478         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 479         techniques borrowed from bfd_elf_sym_name.
 480         (ctf_new_archive_internal): Improve comment.
 481         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 482         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 483         no symbol section, but not vice versa.
 484
 485 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 486
 487         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 488         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 489         * ctf-dump.c (dump_header): New function, dump the CTF header.
 490         (ctf_dump): Call it.
 491         (ctf_dump_header_strfield): New function.
 492         (ctf_dump_header_sectfield): Likewise.
 493
 494 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 495
 496         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 497         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 498         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 499         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 500         Print out ctf_cuname: only print out ctf_parname if set.
 501         (ctf_free_base): Removed, ctf_base is no longer freed: free
 502         ctf_dynbase instead.
 503         (ctf_set_version): Fix spacing.
 504         (upgrade_header): New, in-place header upgrading.
 505         (upgrade_types): Rename to...
 506         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 507         longer track old and new headers separately.  No longer allow for
 508         header sizes explicitly: squeeze the headers out on upgrade (they
 509         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 510         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 511         (upgrade_types): New, also handle ctf_parmax updating.
 512         (flip_header): Flip ctf_cuname.
 513         (flip_types): Flip BUF explicitly rather than deriving BUF from
 514         BASE.
 515         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 516         required alignment of objtoff and funcoff.  No longer store it in
 517         the ctf_buf unless that buf is derived unmodified from the input.
 518         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 519         that duplicate fields in ctf_file: move allocation of ctf_file
 520         further up instead.  Call upgrade_header as needed.  Move
 521         version-specific ctf_parmax initialization into upgrade_types.  More
 522         concise error handling.
 523         (ctf_file_close): No longer test for null pointers before freeing.
 524         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 525         ctf_free_base.
 526         (ctf_cuname): New.
 527         (ctf_cuname_set): New.
 528         * ctf-create.c (ctf_update): Populate ctf_cuname.
 529         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 530         comment.
 531         (ctf_write): Likewise.
 532         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 533         Fix the compression length: fp->ctf_size never counted the CTF
 534         header.  Simplify the compress call accordingly.
 535
 536 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 537
 538         * ctf-endian.h: Don't assume htole64 and le64toh are always
 539         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 540         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 541         not bswap_identity_64.
 542
 543 2019-09-18  Alan Modra  <amodra@gmail.com>
 544
 545         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 546
 547 2019-09-09  Phil Blundell  <pb@pbcl.net>
 548
 549         binutils 2.33 branch created.
 550
 551 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 552
 553         * ctf-types.c (ctf_type_aname_raw): New.
 554         (ctf_func_type_info): Likewise.
 555         (ctf_func_type_args): Likewise.
 556         * ctf-error.c (_ctf_errlist): Fix description.
 557         * ctf-lookup.c: Fix file description.
 558
 559 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 560
 561         * ctf-create.c (ctf_create): Fix off-by-one error.
 562
 563 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 564
 565         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 566         struct ctf_strs.
 567         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 568         (struct ctf_str_atom): New, disambiguated single string.
 569         (struct ctf_str_atom_ref): New, points to some other location that
 570         references this string's offset.
 571         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 572         Remove member ctf_dtvstrlen: we no longer track the total strlen
 573         as we add strings.
 574         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 575         (ctf_str_free_atoms): Likewise.
 576         (ctf_str_add): Likewise.
 577         (ctf_str_add_ref): Likewise.
 578         (ctf_str_rollback): Likewise.
 579         (ctf_str_purge_refs): Likewise.
 580         (ctf_str_write_strtab): Likewise.
 581         (ctf_realloc): Declare new function in ctf-util.c.
 582
 583         * ctf-open.c (ctf_bufopen): Create the atoms table.
 584         (ctf_file_close): Destroy it.
 585         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 586         special-case the position of the parname string.  Construct the
 587         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 588         rest of each buffer element is constructed, not via open-coding:
 589         realloc the CTF buffer and append the strtab to it.  No longer
 590         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 591         strtab construction.
 592         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 593         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 594         after buffer element construction instead.
 595         (ctf_copy_lmembers): Likewise.
 596         (ctf_copy_emembers): Likewise.
 597         (ctf_create): No longer maintain the ctf_dtvstrlen.
 598         (ctf_dtd_delete): Likewise.
 599         (ctf_dvd_delete): Likewise.
 600         (ctf_add_generic): Likewise.
 601         (ctf_add_enumerator): Likewise.
 602         (ctf_add_member_offset): Likewise.
 603         (ctf_add_variable): Likewise.
 604         (membadd): Likewise.
 605         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 606         if there are active ctf_str_num_refs.
 607         (ctf_strraw): Move to ctf-string.c.
 608         (ctf_strptr): Likewise.
 609         * ctf-string.c: New file, strtab manipulation.
 610
 611         * Makefile.am (libctf_a_SOURCES): Add it.
 612         * Makefile.in: Regenerate.
 613
 614 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 615
 616         * ctf-impl.h (ctf_hash_iter_f): New.
 617         (ctf_dynhash_iter): New declaration.
 618         (ctf_dynhash_iter_remove): New declaration.
 619         * ctf-hash.c (ctf_dynhash_iter): Define.
 620         (ctf_dynhash_iter_remove): Likewise.
 621         (ctf_hashtab_traverse): New.
 622         (ctf_hashtab_traverse_remove): Likewise.
 623         (struct ctf_traverse_cb_arg): Likewise.
 624         (struct ctf_traverse_remove_cb_arg): Likewise.
 625
 626 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 627
 628         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 629
 630 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 631
 632         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 633         (ctf_dump_funcs): Likewise.
 634
 635 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 636
 637         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 638         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 639         little-endian CTF archive magic.  Do not check the CTF version:
 640         ctf_simple_open does that in endian-safe ways.  Do not dereference
 641         null pointers on open failure.
 642
 643 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 644
 645         * ctf-open.c (get_vbytes_common): Return the new slice size.
 646         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 647         Remember to copy in the CTF data when opening an uncompressed
 648         foreign-endian CTF file.  Prune useless variable manipulation.
 649
 650 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 651
 652         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 653         seen.
 654
 655 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 656
 657         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 658         output.
 659
 660 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 661
 662         * ctf-subr.c (_PAGESIZE): Remove.
 663         (ctf_data_alloc): Likewise.
 664         (ctf_data_free): Likewise.
 665         (ctf_data_protect): Likewise.
 666         * ctf-impl.h: Remove declarations.
 667         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 668         ctf_free, not ctf_data_free.
 669         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 670         the buffer again on compression error.
 671         * ctf-open.c (ctf_set_base): No longer track the size: call
 672         ctf_free, not ctf_data_free.
 673         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 674         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 675
 676 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 677
 678         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 679         ctf_dynhash_insert.
 680         (ctf_dvd_insert): Likewise.
 681         (ctf_add_generic): Likewise.
 682         (ctf_add_variable): Likewise.
 683         * ctf-impl.h: Adjust declarations.
 684
 685 2019-06-14  Alan Modra  <amodra@gmail.com>
 686
 687         * configure: Regenerate.
 688
 689 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 690
 691         * ctf-decls.h: Include <libiberty.h>.
 692         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 693
 694 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 695
 696         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 697         (ctf_dump_objts): Likewise.
 698         (ctf_dump_funcs): Likewise.
 699         (ctf_dump_member): Likewise.
 700         (ctf_dump_str): Likewise.
 701
 702 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 703
 704         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 705         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 706
 707 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 708
 709         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 710         (ctf_arc_open_by_offset): Likewise.
 711         * ctf-create.c (ctf_add_type): Likewise.
 712
 713 2019-06-04  Tom Tromey  <tromey@adacore.com>
 714
 715         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 716         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 717
 718 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 719
 720         * configure.ac: Check for O_CLOEXEC.
 721         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 722         * config.h.in: Regenerate.
 723         * configure: Likewise.
 724
 725 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 726
 727         * qsort_r.c: Rename to...
 728         * ctf-qsort_r.c: ... this.
 729         (_quicksort): Define to ctf_qsort_r.
 730         * ctf-decls.h (qsort_r): Remove.
 731         (ctf_qsort_r): Add.
 732         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 733         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 734         * Makefile.am (libctf_a_LIBADD): Remove.
 735         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 736         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 737         * ctf-create.c (ctf_update): Likewise.
 738         * configure.ac: Check for BSD versus GNU qsort_r signature.
 739         * Makefile.in: Regenerate.
 740         * config.h.in: Likewise.
 741         * configure: Likewise.
 742
 743 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 744
 745         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 746
 747 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 748
 749         * Makefile.am (ZLIB): New.
 750         (ZLIBINC): Likewise.
 751         (AM_CFLAGS): Use them.
 752         (libctf_a_LIBADD): New, for LIBOBJS.
 753         * configure.ac: Check for zlib, endian.h, and qsort_r.
 754         * ctf-endian.h: New, providing htole64 and le64toh.
 755         * swap.h: Code style fixes.
 756         (bswap_identity_64): New.
 757         * qsort_r.c: New, from gnulib (with one added #include).
 758         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 759         and unconditional definitions of MIN and MAX.
 760         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 761         (ctf_set_errno): Now returns unsigned long.
 762         * ctf-util.c (ctf_set_errno): Adjust here too.
 763         * ctf-archive.c: Use ctf-endian.h.
 764         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 765         cts_flags and cts_offset.
 766         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 767         * ctf-create.c: Provide a definition of roundup if not defined.
 768         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 769         (ctf_add_reftype): Do not check if type IDs are below zero.
 770         (ctf_add_slice): Likewise.
 771         (ctf_add_typedef): Likewise.
 772         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 773         when known error-free.  Drop CTF_ERR usage for functions returning
 774         int.
 775         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 776         int.
 777         (ctf_add_variable): Likewise.
 778         (enumcmp): Likewise.
 779         (enumadd): Likewise.
 780         (membcmp): Likewise.
 781         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 782         when known error-free.
 783         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 784         returning int: use CTF_ERR for functions returning ctf_type_id.
 785         (ctf_dump_label): Likewise.
 786         (ctf_dump_objts): Likewise.
 787         * ctf-labels.c (ctf_label_topmost): Likewise.
 788         (ctf_label_iter): Likewise.
 789         (ctf_label_info): Likewise.
 790         * ctf-lookup.c (ctf_func_args): Likewise.
 791         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 792         (ctf_bufopen): Likewise.  Use zlib types as needed.
 793         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 794         returning int.
 795         (ctf_enum_iter): Likewise.
 796         (ctf_type_size): Likewise.
 797         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 798         (ctf_type_kind_unsliced): Likewise.
 799         (ctf_type_kind): Likewise.
 800         (ctf_type_encoding): Likewise.
 801         (ctf_member_info): Likewise.
 802         (ctf_array_info): Likewise.
 803         (ctf_enum_value): Likewise.
 804         (ctf_type_rvisit): Likewise.
 805         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 806         cts_offset.
 807         (ctf_simple_open): Likewise.
 808         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 809         * Makefile.in: Regenerate.
 810         * aclocal.m4: Likewise.
 811         * config.h: Likewise.
 812         * configure: Likewise.
 813
 814 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 815
 816         * configure.in: Check for bfd_section_from_elf_index.
 817         * configure: Regenerate.
 818         * config.h.in [HAVE_BFD_ELF]: Likewise.
 819         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 820         abfd is potentially unused now.
 821
 822 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 823
 824         * Makefile.am: New.
 825         * Makefile.in: Regenerated.
 826         * config.h.in: Likewise.
 827         * aclocal.m4: Likewise.
 828         * configure: Likewise.
 829
 830 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 831
 832         * ctf-dump.c: New.
 833
 834 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 835
 836         * ctf-labels.c: New.
 837
 838 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 839
 840         * ctf-impl.h (_libctf_version): New declaration.
 841         * ctf-subr.c (_libctf_version): Define it.
 842         (ctf_version): New.
 843
 844 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 845
 846         * ctf-create.c (enumcmp): New.
 847         (enumadd): Likewise.
 848         (membcmp): Likewise.
 849         (membadd): Likewise.
 850         (ctf_add_type): Likewise.
 851
 852 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 853
 854         * ctf-lookup.c (isqualifier): New.
 855         (ctf_lookup_by_name): Likewise.
 856         (struct ctf_lookup_var_key): Likewise.
 857         (ctf_lookup_var): Likewise.
 858         (ctf_lookup_variable): Likewise.
 859         (ctf_lookup_symbol_name): Likewise.
 860         (ctf_lookup_by_symbol): Likewise.
 861         (ctf_func_info): Likewise.
 862         (ctf_func_args): Likewise.
 863
 864 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 865
 866         * ctf-decl.c: New file.
 867         * ctf-types.c: Likewise.
 868         * ctf-impl.h: New declarations.
 869
 870 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 871
 872         * ctf-open-bfd.c: New file.
 873         * ctf-open.c (ctf_close): New.
 874         * ctf-impl.h: Include bfd.h.
 875         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 876         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 877         ctfi_bfd_close.
 878         (ctf_bfdopen_ctfsect): New declaration.
 879         (_CTF_SECTION): likewise.
 880
 881 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 882
 883         * ctf-archive.c: New.
 884         * ctf-impl.h (ctf_archive_internal): New type.
 885         (ctf_arc_open_internal): New declaration.
 886         (ctf_arc_bufopen): Likewise.
 887         (ctf_arc_close_internal): Likewise.
 888
 889 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 890
 891         * ctf-open.c: New file.
 892         * swap.h: Likewise.
 893
 894 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 895
 896         * ctf-create.c: New file.
 897         * ctf-lookup.c: New file.
 898
 899 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 900
 901         * ctf-impl.h: New definitions and declarations for type creation
 902         and lookup.
 903
 904 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 905
 906         * ctf-hash.c: New file.
 907         * ctf-impl.h: New declarations.
 908
 909 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 910
 911         * ctf-error.c: New file.
 912
 913 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 914
 915         * ctf-util.c: New file.
 916         * elf.h: Likewise.
 917         * ctf-impl.h: Include it, and add declarations.
 918
 919 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 920
 921         * ctf-impl.h: New file.
 922         * ctf-subr.c: New file.
 923
 924 \f
 925 Local Variables:
 926 mode: change-log
 927 left-margin: 8
 928 fill-column: 76
 929 version-control: never
 930 End: