libctf/ChangeLog

   1 2020-01-18  Nick Clifton  <nickc@redhat.com>
   2
   3         Binutils 2.34 branch created.
   4
   5 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
   6
   7         PR binutils/25155:
   8         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
   9         * configure, config.h.in: Regenerate.
  10
  11 2020-01-01  Alan Modra  <amodra@gmail.com>
  12
  13         Update year range in copyright notice of all files.
  14
  15 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
  16
  17         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
  18
  19 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
  20
  21         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
  22         * ctf-types.c (ctf_type_lname): Likewise.
  23
  24 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  25
  26         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
  27         ctf_import after the first for a given file.
  28
  29 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  30
  31         * ctf-impl.h (ctf_str_append_noerr): Declare.
  32         * ctf-util.c (ctf_str_append_noerr): Define in terms of
  33         ctf_str_append.
  34         * ctf-dump.c (str_append): New, call it.
  35         (ctf_dump_format_type): Use str_append, not ctf_str_append.
  36         (ctf_dump_label): Likewise.
  37         (ctf_dump_objts): Likewise.
  38         (ctf_dump_funcs): Likewise.
  39         (ctf_dump_var): Likewise.
  40         (ctf_dump_member): Likewise.
  41         (ctf_dump_type): Likewise.
  42         (ctf_dump): Likewise.
  43
  44 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  45
  46         * ctf-impl.h (ctf_alloc): Remove.
  47         (ctf_free): Likewise.
  48         (ctf_strdup): Likewise.
  49         * ctf-subr.c (ctf_alloc): Remove.
  50         (ctf_free): Likewise.
  51         * ctf-util.c (ctf_strdup): Remove.
  52
  53         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
  54         ctf_free; strdup, not ctf_strdup.
  55         (ctf_dtd_delete): Likewise.
  56         (ctf_dvd_delete): Likewise.
  57         (ctf_add_generic): Likewise.
  58         (ctf_add_function): Likewise.
  59         (ctf_add_enumerator): Likewise.
  60         (ctf_add_member_offset): Likewise.
  61         (ctf_add_variable): Likewise.
  62         (membadd): Likewise.
  63         (ctf_compress_write): Likewise.
  64         (ctf_write_mem): Likewise.
  65         * ctf-decl.c (ctf_decl_push): Likewise.
  66         (ctf_decl_fini): Likewise.
  67         (ctf_decl_sprintf): Likewise.  Check for OOM.
  68         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
  69         ctf_free; strdup, not ctf_strdup.
  70         (ctf_dump_free): Likewise.
  71         (ctf_dump): Likewise.
  72         * ctf-open.c (upgrade_types_v1): Likewise.
  73         (init_types): Likewise.
  74         (ctf_file_close): Likewise.
  75         (ctf_bufopen_internal): Likewise.  Check for OOM.
  76         (ctf_parent_name_set): Likewise: report the OOM to the caller.
  77         (ctf_cuname_set): Likewise.
  78         (ctf_import): Likewise.
  79         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
  80         free, not ctf_free; strdup, not ctf_strdup.
  81         (ctf_str_free_atom): Likewise.
  82         (ctf_str_create_atoms): Likewise.
  83         (ctf_str_add_ref_internal): Likewise.
  84         (ctf_str_remove_ref): Likewise.
  85         (ctf_str_write_strtab): Likewise.
  86
  87 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  88
  89         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
  90         work right for non-int/fps.
  91
  92 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
  93
  94         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
  95         null pointer.
  96
  97 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
  98
  99         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 100         * ctf-open.c (ctf_file_close): Free it.
 101         * ctf-create.c (ctf_serialize): Adjust.
 102         (membcmp): When reporting a conflict due to an error, report the
 103         error.
 104         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 105         (ctf_add_type_internal): ... this.  Hand back types we are already
 106         in the middle of adding immediately.  Hand back structs/unions with
 107         the same number of members immediately.  Do not walk the dynamic
 108         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 109         forwards promoted to other types and the inverse case identically.
 110         Add structs to the mapping as soon as we intern them, before they
 111         gain any members.
 112
 113 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 114
 115         * ctf-impl.h (ctf_names_t): New.
 116         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 117         (ctf_file_t) <ctf_structs>: Likewise.
 118         <ctf_unions>: Likewise.
 119         <ctf_enums>: Likewise.
 120         <ctf_names>: Likewise.
 121         <ctf_lookups>: Improve comment.
 122         <ctf_ptrtab_len>: New.
 123         <ctf_prov_strtab>: New.
 124         <ctf_str_prov_offset>: New.
 125         <ctf_dtbyname>: Remove, redundant to the names hashes.
 126         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 127         (ctf_dtdef_t) <dtd_name>: Remove.
 128         <dtd_data>: Note that the ctt_name is now populated.
 129         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 130         offset for internal strings too.
 131         <csa_external_offset>: New, the external strtab offset.
 132         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 133         (ctf_name_table): New declaration.
 134         (ctf_lookup_by_rawname): Likewise.
 135         (ctf_lookup_by_rawhash): Likewise.
 136         (ctf_set_ctl_hashes): Likewise.
 137         (ctf_serialize): Likewise.
 138         (ctf_dtd_insert): Adjust.
 139         (ctf_simple_open_internal): Likewise.
 140         (ctf_bufopen_internal): Likewise.
 141         (ctf_list_empty_p): Likewise.
 142         (ctf_str_remove_ref): Likewise.
 143         (ctf_str_add): Returns uint32_t now.
 144         (ctf_str_add_ref): Likewise.
 145         (ctf_str_add_external): Now returns a boolean (int).
 146         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 147         for strings in the appropriate range.
 148         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 149         when adding the null string to the new strtab.
 150         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 151         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 152         make_provisional, populate the offset and fill in the
 153         ctf_prov_strtab accordingly.
 154         (ctf_str_add): Return the offset, not the string.
 155         (ctf_str_add_ref): Likewise.
 156         (ctf_str_add_external): Return a success integer.
 157         (ctf_str_remove_ref): New, remove a single ref.
 158         (ctf_str_count_strtab): Do not count the initial null string's
 159         length or the existence or length of any unreferenced internal
 160         atoms.
 161         (ctf_str_populate_sorttab): Skip atoms with no refs.
 162         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 163         to the cts_len for the null string, since it is no longer done
 164         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 165         Populate the csa_offset for both internal and external cases.
 166         Flush the ctf_prov_strtab afterwards, and reset the
 167         ctf_str_prov_offset.
 168         * ctf-create.c (ctf_grow_ptrtab): New.
 169         (ctf_create): Call it.  Initialize new fields rather than old
 170         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 171         Set the ctl hashes and data model.
 172         (ctf_update): Rename to...
 173         (ctf_serialize): ... this.  Leave a compatibility function behind.
 174         Tell ctf_simple_open_internal that this is a writable dictionary.
 175         Pass the new fields along from the old dictionary.  Drop
 176         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 177         Do not zero out the DTD's ctt_name.
 178         (ctf_prefixed_name): Rename to...
 179         (ctf_name_table): ... this.  No longer return a prefixed name: return
 180         the applicable name table instead.
 181         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 182         kind we're adding.  Migrate away from dtd_name.
 183         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 184         deleted ctt_name.
 185         (ctf_dtd_lookup_type_by_name): Remove.
 186         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 187         No longer check ctf_dtnextid: check ctf_typemax instead.
 188         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 189         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 190         ctf_name_table and the right name table, and migrate away from
 191         dtd_name as in ctf_dtd_delete.
 192         (ctf_add_generic): Pass in the kind explicitly and pass it to
 193         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 194         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 195         Grow the ptrtab if needed.
 196         (ctf_add_encoded): Pass in the kind.
 197         (ctf_add_slice): Likewise.
 198         (ctf_add_array): Likewise.
 199         (ctf_add_function): Likewise.
 200         (ctf_add_typedef): Likewise.
 201         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 202         ctt_name rather than dtd_name.
 203         (ctf_add_struct_sized): Pass in the kind.  Use
 204         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 205         ctf_dtd_lookup_type_by_name.
 206         (ctf_add_union_sized): Likewise.
 207         (ctf_add_enum): Likewise.
 208         (ctf_add_enum_encoded): Likewise.
 209         (ctf_add_forward): Likewise.
 210         (ctf_add_type): Likewise.
 211         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 212         being initialized until after the call.
 213         (ctf_write_mem): Likewise.
 214         (ctf_write): Likewise.
 215         * ctf-archive.c (arc_write_one_ctf): Likewise.
 216         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 217         ctf_hash_lookup_type.
 218         (ctf_lookup_by_id): No longer check the readonly types if the
 219         dictionary is writable.
 220         * ctf-open.c (init_types): Assert that this dictionary is not
 221         writable.  Adjust to use the new name hashes, ctf_name_table,
 222         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 223         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 224         if set.  Drop out early when dictionary is writable.  Split the
 225         ctf_lookups initialization into...
 226         (ctf_set_cth_hashes): ... this new function.
 227         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 228         (ctf_simple_open): Adjust accordingly.
 229         (ctf_bufopen): Likewise.
 230         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 231         destroy ctf_dtbyname, which is gone.
 232         (ctf_getdatasect): Remove spurious "extern".
 233         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 234         specified name table, given a kind.
 235         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 236         (ctf_member_iter): Add support for iterating over the
 237         dynamic type list.
 238         (ctf_enum_iter): Likewise.
 239         (ctf_variable_iter): Likewise.
 240         (ctf_type_rvisit): Likewise.
 241         (ctf_member_info): Add support for types in the dynamic type list.
 242         (ctf_enum_name): Likewise.
 243         (ctf_enum_value): Likewise.
 244         (ctf_func_type_info): Likewise.
 245         (ctf_func_type_args): Likewise.
 246         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 247         ctf_update.
 248         (ctf_link_write): Likewise.
 249         (ctf_link_intern_extern_string): Adjust for new
 250         ctf_str_add_external return value.
 251         (ctf_link_add_strtab): Likewise.
 252         * ctf-util.c (ctf_list_empty_p): New.
 253
 254 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 255
 256         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 257         type zero.
 258         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 259         members and types.
 260         (ctf_add_variable): Likewise for variables pointing to them.
 261         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 262         type link failure, but do warn for others.
 263         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 264         errors to be ENOMEM.
 265         (ctf_dump_member): Likewise.
 266         (ctf_dump_type): Likewise.
 267         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 268         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 269         (ctf_dump_header): Likewise.
 270         (ctf_dump_label): likewise.
 271         (ctf_dump_objts): likewise.
 272         (ctf_dump_funcs): likewise.
 273         (ctf_dump_var): likewise.
 274         (ctf_dump_str): Likewise.
 275
 276 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 277
 278         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 279         (LT_INIT): Likewise.
 280         (AM_INSTALL_LIBBFD): Likewise.
 281         (dlopen): Note why this is necessary in a comment.
 282         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 283         opcodes/.
 284         (SHARED_LDFLAGS): Likewise.
 285         (BFD_LIBADD): Likewise, for libbfd.
 286         (BFD_DEPENDENCIES): Likewise.
 287         (VERSION_FLAGS): Initialize, using a version script if ld supports
 288         one, or libtool -export-symbols-regex otherwise.
 289         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 290         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 291         (INCDIR): New.
 292         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 293         (noinst_LIBRARIES): Replace with...
 294         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 295         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 296         libctf-nobfd.la as well.
 297         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 298         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 299         (libctf_a_SOURCES): Rename to...
 300         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 301         ctf-open-bfd.c.
 302         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 303         with ctf-open-bfd.c added.
 304         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 305         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 306         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 307         * Makefile.am [INSTALL_LIBCTF]: Use it.
 308         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 309         libtool macros.
 310         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 311         the unstable components).
 312         * Makefile.in: Regenerated.
 313         * config.h.in: Likewise.
 314         * configure: Likewise.
 315
 316 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 317
 318         * configure.ac (INSTALL_LIBCTF): New, controlled by
 319         --enable-install-libctf.
 320         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 321         * Makefile.in: Regenerated.
 322         * configure: Regenerated.
 323
 324 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 325
 326         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 327         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 328
 329 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 330
 331         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 332
 333 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 334
 335         * ctf-impl.h (includes): Include <sys/param.h> here.
 336
 337 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 338
 339         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 340         (flip_objts): Likewise.
 341         (flip_vars): Likewise.
 342         (flip_types): Likewise.
 343
 344 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 345
 346         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 347         freeing functions: if set, free the key and value if the slot
 348         already exists.  Always reassign the key.
 349         (ctf_dynhash_insert): Adjust call appropriately.
 350         (ctf_hash_insert_type): Likewise.
 351
 352 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 353
 354         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 355         type kind.  Allow forwards to unify with pre-existing structs/
 356         unions/enums.
 357
 358 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 359
 360         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 361         <ctf_link_memb_name_changer>: Likewise.
 362         <ctf_link_memb_name_changer_arg>: Likewise.
 363         * ctf-create.c (ctf_update): Update accordingly.
 364         * ctf-open.c (ctf_file_close): Likewise.
 365         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 366         (ctf_link_add_cu_mapping): New.
 367         (ctf_link_set_memb_name_changer): Likewise.
 368         (ctf_change_parent_name): New.
 369         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 370         allocated by the caller's ctf_link_memb_name_changer.
 371         <ndynames>: Likewise.
 372         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 373         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 374         ctf_change_parent_name.  Free any resulting names.
 375
 376 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 377
 378         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 379         (ctf_link_one_type): ... here, with parent-name setting added.
 380         (check_variable): New.
 381         (ctf_link_one_variable): Likewise.
 382         (ctf_link_one_input_archive_member): Call it.
 383         * ctf-error.c (_ctf_errlist): Updated with new errors.
 384
 385 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 386
 387         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 388         (struct ctf_link_type_mapping_key): New.
 389         (ctf_hash_type_mapping_key): Likewise.
 390         (ctf_hash_eq_type_mapping_key): Likewise.
 391         (ctf_add_type_mapping): Likewise.
 392         (ctf_type_mapping): Likewise.
 393         (ctf_dynhash_empty): Likewise.
 394         * ctf-open.c (ctf_file_close): Update accordingly.
 395         * ctf-create.c (ctf_update): Likewise.
 396         (ctf_add_type): Populate the mapping.
 397         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 398         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 399         (ctf_dynhash_insert): Fix comment typo.
 400         (ctf_dynhash_empty): New.
 401         * ctf-link.c (ctf_add_type_mapping): New.
 402         (ctf_type_mapping): Likewise.
 403         (empty_link_type_mapping): New.
 404         (ctf_link_one_input_archive): Call it.
 405
 406 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 407
 408         * ctf-link.c: New file, linking of the string and type sections.
 409         * Makefile.am (libctf_a_SOURCES): Add it.
 410         * Makefile.in: Regenerate.
 411
 412         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 413         ctf_link_outputs.
 414         * ctf-create.c (ctf_update): Update accordingly.
 415         * ctf-open.c (ctf_file_close): Likewise.
 416         * ctf-error.c (_ctf_errlist): Updated with new errors.
 417
 418 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 419
 420         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 421
 422 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 423
 424         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 425         ctf_type_iter.
 426         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 427         (ctf_dump_format_type): Add non-root-type { } notation.
 428         Add root flag to prototype.
 429         (ctf_dump_label): Adjust accordingly.
 430         (ctf_dump_objts): Likewise.
 431         (ctf_dump_var): Likewise.
 432
 433 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 434
 435         * ctf-create.c (ctf_compress_write): Fix double-free.
 436
 437 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 438
 439         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 440         of...
 441         (ctf_arc_write_fd): ... this new function.
 442         * ctf-create.c (ctf_write_mem): New.
 443
 444 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 445
 446         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 447         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 448         (ctf_str_add_ref): Name the last arg.
 449         (ctf_str_add_external) New.
 450         (ctf_str_add_strraw_explicit): Likewise.
 451         (ctf_simple_open_internal): Likewise.
 452         (ctf_bufopen_internal): Likewise.
 453
 454         * ctf-string.c (ctf_strraw_explicit): Split from...
 455         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 456         (ctf_str_add_ref_internal): Return the atom, not the
 457         string.
 458         (ctf_str_add): Adjust accordingly.
 459         (ctf_str_add_ref): Likewise.  Move up in the file.
 460         (ctf_str_add_external): New: update the csa_offset.
 461         (ctf_str_count_strtab): Only account for strings with no csa_offset
 462         in the internal strtab length.
 463         (ctf_str_write_strtab): If the csa_offset is set, update the
 464         string's refs without writing the string out, and update the
 465         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 466         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 467         (ctf_update): Handle failure to populate the strtab.  Pass in the
 468         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 469         Call ctf_simple_open_internal, not ctf_simple_open.
 470         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 471         strings by hand.
 472         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 473         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 474         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 475         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 476         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 477         (ctf_simple_open_internal): ... this new function, which calls
 478         ctf_bufopen_internal.
 479         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 480         (ctf_bufopen_internal): ... this new function, which sets
 481         ctf_syn_ext_strtab.
 482
 483 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 484
 485         * ctf_types.c (ctf_type_iter_all): New.
 486
 487 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 488
 489         * ctf-open.c (init_symtab): Check for overflow against the right
 490         section.
 491         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 492         (upgrade_types_v1): Note that these sections are not checked.
 493         (flip_header): Endian-swap the header fields.
 494         (flip_ctf): Endian-swap the sections.
 495         (flip_objts): Update comment.
 496         (ctf_bufopen): Check header offsets and alignment for validity.
 497
 498 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 499
 500         * ctf-open-bfd.c: Add <assert.h>.
 501         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 502         techniques borrowed from bfd_elf_sym_name.
 503         (ctf_new_archive_internal): Improve comment.
 504         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 505         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 506         no symbol section, but not vice versa.
 507
 508 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 509
 510         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 511         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 512         * ctf-dump.c (dump_header): New function, dump the CTF header.
 513         (ctf_dump): Call it.
 514         (ctf_dump_header_strfield): New function.
 515         (ctf_dump_header_sectfield): Likewise.
 516
 517 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 518
 519         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 520         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 521         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 522         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 523         Print out ctf_cuname: only print out ctf_parname if set.
 524         (ctf_free_base): Removed, ctf_base is no longer freed: free
 525         ctf_dynbase instead.
 526         (ctf_set_version): Fix spacing.
 527         (upgrade_header): New, in-place header upgrading.
 528         (upgrade_types): Rename to...
 529         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 530         longer track old and new headers separately.  No longer allow for
 531         header sizes explicitly: squeeze the headers out on upgrade (they
 532         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 533         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 534         (upgrade_types): New, also handle ctf_parmax updating.
 535         (flip_header): Flip ctf_cuname.
 536         (flip_types): Flip BUF explicitly rather than deriving BUF from
 537         BASE.
 538         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 539         required alignment of objtoff and funcoff.  No longer store it in
 540         the ctf_buf unless that buf is derived unmodified from the input.
 541         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 542         that duplicate fields in ctf_file: move allocation of ctf_file
 543         further up instead.  Call upgrade_header as needed.  Move
 544         version-specific ctf_parmax initialization into upgrade_types.  More
 545         concise error handling.
 546         (ctf_file_close): No longer test for null pointers before freeing.
 547         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 548         ctf_free_base.
 549         (ctf_cuname): New.
 550         (ctf_cuname_set): New.
 551         * ctf-create.c (ctf_update): Populate ctf_cuname.
 552         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 553         comment.
 554         (ctf_write): Likewise.
 555         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 556         Fix the compression length: fp->ctf_size never counted the CTF
 557         header.  Simplify the compress call accordingly.
 558
 559 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 560
 561         * ctf-endian.h: Don't assume htole64 and le64toh are always
 562         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 563         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 564         not bswap_identity_64.
 565
 566 2019-09-18  Alan Modra  <amodra@gmail.com>
 567
 568         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 569
 570 2019-09-09  Phil Blundell  <pb@pbcl.net>
 571
 572         binutils 2.33 branch created.
 573
 574 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 575
 576         * ctf-types.c (ctf_type_aname_raw): New.
 577         (ctf_func_type_info): Likewise.
 578         (ctf_func_type_args): Likewise.
 579         * ctf-error.c (_ctf_errlist): Fix description.
 580         * ctf-lookup.c: Fix file description.
 581
 582 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 583
 584         * ctf-create.c (ctf_create): Fix off-by-one error.
 585
 586 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 587
 588         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 589         struct ctf_strs.
 590         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 591         (struct ctf_str_atom): New, disambiguated single string.
 592         (struct ctf_str_atom_ref): New, points to some other location that
 593         references this string's offset.
 594         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 595         Remove member ctf_dtvstrlen: we no longer track the total strlen
 596         as we add strings.
 597         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 598         (ctf_str_free_atoms): Likewise.
 599         (ctf_str_add): Likewise.
 600         (ctf_str_add_ref): Likewise.
 601         (ctf_str_rollback): Likewise.
 602         (ctf_str_purge_refs): Likewise.
 603         (ctf_str_write_strtab): Likewise.
 604         (ctf_realloc): Declare new function in ctf-util.c.
 605
 606         * ctf-open.c (ctf_bufopen): Create the atoms table.
 607         (ctf_file_close): Destroy it.
 608         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 609         special-case the position of the parname string.  Construct the
 610         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 611         rest of each buffer element is constructed, not via open-coding:
 612         realloc the CTF buffer and append the strtab to it.  No longer
 613         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 614         strtab construction.
 615         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 616         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 617         after buffer element construction instead.
 618         (ctf_copy_lmembers): Likewise.
 619         (ctf_copy_emembers): Likewise.
 620         (ctf_create): No longer maintain the ctf_dtvstrlen.
 621         (ctf_dtd_delete): Likewise.
 622         (ctf_dvd_delete): Likewise.
 623         (ctf_add_generic): Likewise.
 624         (ctf_add_enumerator): Likewise.
 625         (ctf_add_member_offset): Likewise.
 626         (ctf_add_variable): Likewise.
 627         (membadd): Likewise.
 628         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 629         if there are active ctf_str_num_refs.
 630         (ctf_strraw): Move to ctf-string.c.
 631         (ctf_strptr): Likewise.
 632         * ctf-string.c: New file, strtab manipulation.
 633
 634         * Makefile.am (libctf_a_SOURCES): Add it.
 635         * Makefile.in: Regenerate.
 636
 637 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 638
 639         * ctf-impl.h (ctf_hash_iter_f): New.
 640         (ctf_dynhash_iter): New declaration.
 641         (ctf_dynhash_iter_remove): New declaration.
 642         * ctf-hash.c (ctf_dynhash_iter): Define.
 643         (ctf_dynhash_iter_remove): Likewise.
 644         (ctf_hashtab_traverse): New.
 645         (ctf_hashtab_traverse_remove): Likewise.
 646         (struct ctf_traverse_cb_arg): Likewise.
 647         (struct ctf_traverse_remove_cb_arg): Likewise.
 648
 649 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 650
 651         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 652
 653 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 654
 655         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 656         (ctf_dump_funcs): Likewise.
 657
 658 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 659
 660         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 661         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 662         little-endian CTF archive magic.  Do not check the CTF version:
 663         ctf_simple_open does that in endian-safe ways.  Do not dereference
 664         null pointers on open failure.
 665
 666 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 667
 668         * ctf-open.c (get_vbytes_common): Return the new slice size.
 669         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 670         Remember to copy in the CTF data when opening an uncompressed
 671         foreign-endian CTF file.  Prune useless variable manipulation.
 672
 673 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 674
 675         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 676         seen.
 677
 678 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 679
 680         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 681         output.
 682
 683 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 684
 685         * ctf-subr.c (_PAGESIZE): Remove.
 686         (ctf_data_alloc): Likewise.
 687         (ctf_data_free): Likewise.
 688         (ctf_data_protect): Likewise.
 689         * ctf-impl.h: Remove declarations.
 690         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 691         ctf_free, not ctf_data_free.
 692         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 693         the buffer again on compression error.
 694         * ctf-open.c (ctf_set_base): No longer track the size: call
 695         ctf_free, not ctf_data_free.
 696         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 697         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 698
 699 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 700
 701         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 702         ctf_dynhash_insert.
 703         (ctf_dvd_insert): Likewise.
 704         (ctf_add_generic): Likewise.
 705         (ctf_add_variable): Likewise.
 706         * ctf-impl.h: Adjust declarations.
 707
 708 2019-06-14  Alan Modra  <amodra@gmail.com>
 709
 710         * configure: Regenerate.
 711
 712 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 713
 714         * ctf-decls.h: Include <libiberty.h>.
 715         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 716
 717 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 718
 719         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 720         (ctf_dump_objts): Likewise.
 721         (ctf_dump_funcs): Likewise.
 722         (ctf_dump_member): Likewise.
 723         (ctf_dump_str): Likewise.
 724
 725 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 726
 727         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 728         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 729
 730 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 731
 732         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 733         (ctf_arc_open_by_offset): Likewise.
 734         * ctf-create.c (ctf_add_type): Likewise.
 735
 736 2019-06-04  Tom Tromey  <tromey@adacore.com>
 737
 738         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 739         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 740
 741 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 742
 743         * configure.ac: Check for O_CLOEXEC.
 744         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 745         * config.h.in: Regenerate.
 746         * configure: Likewise.
 747
 748 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 749
 750         * qsort_r.c: Rename to...
 751         * ctf-qsort_r.c: ... this.
 752         (_quicksort): Define to ctf_qsort_r.
 753         * ctf-decls.h (qsort_r): Remove.
 754         (ctf_qsort_r): Add.
 755         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 756         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 757         * Makefile.am (libctf_a_LIBADD): Remove.
 758         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 759         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 760         * ctf-create.c (ctf_update): Likewise.
 761         * configure.ac: Check for BSD versus GNU qsort_r signature.
 762         * Makefile.in: Regenerate.
 763         * config.h.in: Likewise.
 764         * configure: Likewise.
 765
 766 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 767
 768         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 769
 770 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 771
 772         * Makefile.am (ZLIB): New.
 773         (ZLIBINC): Likewise.
 774         (AM_CFLAGS): Use them.
 775         (libctf_a_LIBADD): New, for LIBOBJS.
 776         * configure.ac: Check for zlib, endian.h, and qsort_r.
 777         * ctf-endian.h: New, providing htole64 and le64toh.
 778         * swap.h: Code style fixes.
 779         (bswap_identity_64): New.
 780         * qsort_r.c: New, from gnulib (with one added #include).
 781         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 782         and unconditional definitions of MIN and MAX.
 783         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 784         (ctf_set_errno): Now returns unsigned long.
 785         * ctf-util.c (ctf_set_errno): Adjust here too.
 786         * ctf-archive.c: Use ctf-endian.h.
 787         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 788         cts_flags and cts_offset.
 789         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 790         * ctf-create.c: Provide a definition of roundup if not defined.
 791         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 792         (ctf_add_reftype): Do not check if type IDs are below zero.
 793         (ctf_add_slice): Likewise.
 794         (ctf_add_typedef): Likewise.
 795         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 796         when known error-free.  Drop CTF_ERR usage for functions returning
 797         int.
 798         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 799         int.
 800         (ctf_add_variable): Likewise.
 801         (enumcmp): Likewise.
 802         (enumadd): Likewise.
 803         (membcmp): Likewise.
 804         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 805         when known error-free.
 806         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 807         returning int: use CTF_ERR for functions returning ctf_type_id.
 808         (ctf_dump_label): Likewise.
 809         (ctf_dump_objts): Likewise.
 810         * ctf-labels.c (ctf_label_topmost): Likewise.
 811         (ctf_label_iter): Likewise.
 812         (ctf_label_info): Likewise.
 813         * ctf-lookup.c (ctf_func_args): Likewise.
 814         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 815         (ctf_bufopen): Likewise.  Use zlib types as needed.
 816         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 817         returning int.
 818         (ctf_enum_iter): Likewise.
 819         (ctf_type_size): Likewise.
 820         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 821         (ctf_type_kind_unsliced): Likewise.
 822         (ctf_type_kind): Likewise.
 823         (ctf_type_encoding): Likewise.
 824         (ctf_member_info): Likewise.
 825         (ctf_array_info): Likewise.
 826         (ctf_enum_value): Likewise.
 827         (ctf_type_rvisit): Likewise.
 828         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 829         cts_offset.
 830         (ctf_simple_open): Likewise.
 831         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 832         * Makefile.in: Regenerate.
 833         * aclocal.m4: Likewise.
 834         * config.h: Likewise.
 835         * configure: Likewise.
 836
 837 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 838
 839         * configure.in: Check for bfd_section_from_elf_index.
 840         * configure: Regenerate.
 841         * config.h.in [HAVE_BFD_ELF]: Likewise.
 842         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 843         abfd is potentially unused now.
 844
 845 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 846
 847         * Makefile.am: New.
 848         * Makefile.in: Regenerated.
 849         * config.h.in: Likewise.
 850         * aclocal.m4: Likewise.
 851         * configure: Likewise.
 852
 853 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 854
 855         * ctf-dump.c: New.
 856
 857 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 858
 859         * ctf-labels.c: New.
 860
 861 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 862
 863         * ctf-impl.h (_libctf_version): New declaration.
 864         * ctf-subr.c (_libctf_version): Define it.
 865         (ctf_version): New.
 866
 867 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 868
 869         * ctf-create.c (enumcmp): New.
 870         (enumadd): Likewise.
 871         (membcmp): Likewise.
 872         (membadd): Likewise.
 873         (ctf_add_type): Likewise.
 874
 875 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 876
 877         * ctf-lookup.c (isqualifier): New.
 878         (ctf_lookup_by_name): Likewise.
 879         (struct ctf_lookup_var_key): Likewise.
 880         (ctf_lookup_var): Likewise.
 881         (ctf_lookup_variable): Likewise.
 882         (ctf_lookup_symbol_name): Likewise.
 883         (ctf_lookup_by_symbol): Likewise.
 884         (ctf_func_info): Likewise.
 885         (ctf_func_args): Likewise.
 886
 887 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 888
 889         * ctf-decl.c: New file.
 890         * ctf-types.c: Likewise.
 891         * ctf-impl.h: New declarations.
 892
 893 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 894
 895         * ctf-open-bfd.c: New file.
 896         * ctf-open.c (ctf_close): New.
 897         * ctf-impl.h: Include bfd.h.
 898         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 899         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 900         ctfi_bfd_close.
 901         (ctf_bfdopen_ctfsect): New declaration.
 902         (_CTF_SECTION): likewise.
 903
 904 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 905
 906         * ctf-archive.c: New.
 907         * ctf-impl.h (ctf_archive_internal): New type.
 908         (ctf_arc_open_internal): New declaration.
 909         (ctf_arc_bufopen): Likewise.
 910         (ctf_arc_close_internal): Likewise.
 911
 912 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 913
 914         * ctf-open.c: New file.
 915         * swap.h: Likewise.
 916
 917 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 918
 919         * ctf-create.c: New file.
 920         * ctf-lookup.c: New file.
 921
 922 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 923
 924         * ctf-impl.h: New definitions and declarations for type creation
 925         and lookup.
 926
 927 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 928
 929         * ctf-hash.c: New file.
 930         * ctf-impl.h: New declarations.
 931
 932 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 933
 934         * ctf-error.c: New file.
 935
 936 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 937
 938         * ctf-util.c: New file.
 939         * elf.h: Likewise.
 940         * ctf-impl.h: Include it, and add declarations.
 941
 942 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 943
 944         * ctf-impl.h: New file.
 945         * ctf-subr.c: New file.
 946
 947 \f
 948 Local Variables:
 949 mode: change-log
 950 left-margin: 8
 951 fill-column: 76
 952 version-control: never
 953 End: