Values API: standardize parameters and return values
[babeltrace.git] / cli / babeltrace.c
index ce12900a0e97929b43a32574419fa531acbb15a7..efc883e2d4f18a2c3e361d84636ecc8dd69ec97f 100644 (file)
@@ -31,7 +31,6 @@
 
 #include <babeltrace/babeltrace.h>
 #include <babeltrace/common-internal.h>
-#include <babeltrace/values-internal.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <popt.h>
@@ -139,7 +138,7 @@ void set_signal_handler(void)
 static
 void init_static_data(void)
 {
-       loaded_plugins = g_ptr_array_new_with_free_func(bt_put);
+       loaded_plugins = g_ptr_array_new_with_free_func(bt_object_put_ref);
 }
 
 static
@@ -165,7 +164,7 @@ int create_the_query_executor(void)
 static
 void destroy_the_query_executor(void)
 {
-       BT_PUT(the_query_executor);
+       BT_OBJECT_PUT_REF_AND_RESET(the_query_executor);
 }
 
 static
@@ -254,7 +253,7 @@ error:
 
 end:
        destroy_the_query_executor();
-       bt_put(result);
+       bt_object_put_ref(result);
        return ret;
 }
 
@@ -285,7 +284,7 @@ struct bt_plugin *find_plugin(const char *name)
                }
        }
 
-       return bt_get(plugin);
+       return bt_object_get_ref(plugin);
 }
 
 static
@@ -308,7 +307,7 @@ struct bt_component_class *find_component_class(const char *plugin_name,
 
        comp_class = bt_plugin_get_component_class_by_name_and_type(plugin,
                        comp_class_name, comp_class_type);
-       BT_PUT(plugin);
+       BT_OBJECT_PUT_REF_AND_RESET(plugin);
 
 end:
        if (BT_LOG_ON_DEBUG) {
@@ -439,7 +438,6 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
        const char *str_val;
        int size;
        int i;
-       enum bt_value_status status;
 
        if (!value) {
                return;
@@ -451,43 +449,31 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
                        bt_common_color_reset());
                break;
        case BT_VALUE_TYPE_BOOL:
-               status = bt_value_bool_get(value, &bool_val);
-               if (status != BT_VALUE_STATUS_OK) {
-                       goto error;
-               }
+               bool_val = bt_value_bool_get(value);
                fprintf(fp, "%s%s%s%s\n", bt_common_color_bold(),
                        bt_common_color_fg_cyan(), bool_val ? "yes" : "no",
                        bt_common_color_reset());
                break;
        case BT_VALUE_TYPE_INTEGER:
-               status = bt_value_integer_get(value, &int_val);
-               if (status != BT_VALUE_STATUS_OK) {
-                       goto error;
-               }
+               int_val = bt_value_integer_get(value);
                fprintf(fp, "%s%s%" PRId64 "%s\n", bt_common_color_bold(),
                        bt_common_color_fg_red(), int_val,
                        bt_common_color_reset());
                break;
-       case BT_VALUE_TYPE_FLOAT:
-               status = bt_value_float_get(value, &dbl_val);
-               if (status != BT_VALUE_STATUS_OK) {
-                       goto error;
-               }
+       case BT_VALUE_TYPE_REAL:
+               dbl_val = bt_value_real_get(value);
                fprintf(fp, "%s%s%lf%s\n", bt_common_color_bold(),
                        bt_common_color_fg_red(), dbl_val,
                        bt_common_color_reset());
                break;
        case BT_VALUE_TYPE_STRING:
-               status = bt_value_string_get(value, &str_val);
-               if (status != BT_VALUE_STATUS_OK) {
-                       goto error;
-               }
+               str_val = bt_value_string_get(value);
                fprintf(fp, "%s%s%s%s\n", bt_common_color_bold(),
                        bt_common_color_fg_green(), str_val,
                        bt_common_color_reset());
                break;
        case BT_VALUE_TYPE_ARRAY:
-               size = bt_value_array_size(value);
+               size = bt_value_array_get_size(value);
                if (size < 0) {
                        goto error;
                }
@@ -500,7 +486,8 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
 
                for (i = 0; i < size; i++) {
                        struct bt_value *element =
-                                       bt_value_array_get(value, i);
+                               bt_value_array_borrow_element_by_index(
+                                       value, i);
 
                        if (!element) {
                                goto error;
@@ -526,7 +513,6 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
                        }
 
                        print_value_rec(fp, element, indent + 2);
-                       BT_PUT(element);
                }
                break;
        case BT_VALUE_TYPE_MAP:
@@ -542,7 +528,7 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
                        break;
                }
 
-               bt_value_map_foreach(value, print_map_value, &data);
+               bt_value_map_foreach_entry(value, print_map_value, &data);
                break;
        }
        default:
@@ -552,7 +538,7 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
 
 error:
        BT_LOGE("Error printing value of type %s.",
-               bt_value_type_string(bt_value_get_type(value)));
+               bt_common_value_type_string(bt_value_get_type(value)));
 }
 
 static
@@ -580,7 +566,8 @@ void print_bt_config_component(struct bt_config_component *bt_config_component)
        }
 
        fprintf(stderr, "      Parameters:\n");
-       print_value(stderr, bt_config_component->params, 8);
+       print_value(stderr,
+               bt_value_borrow_from_private(bt_config_component->params), 8);
 }
 
 static
@@ -592,7 +579,7 @@ void print_bt_config_components(GPtrArray *array)
                struct bt_config_component *cfg_component =
                                bt_config_get_component(array, i);
                print_bt_config_component(cfg_component);
-               BT_PUT(cfg_component);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg_component);
        }
 }
 
@@ -608,7 +595,7 @@ void print_cfg_run(struct bt_config *cfg)
 {
        size_t i;
 
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  Source component instances:\n");
        print_bt_config_components(cfg->cmd_data.run.sources);
 
@@ -639,19 +626,19 @@ void print_cfg_run(struct bt_config *cfg)
 static
 void print_cfg_list_plugins(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
 }
 
 static
 void print_cfg_help(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
 }
 
 static
 void print_cfg_print_ctf_metadata(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  Path: %s\n",
                cfg->cmd_data.print_ctf_metadata.path->str);
 }
@@ -659,7 +646,7 @@ void print_cfg_print_ctf_metadata(struct bt_config *cfg)
 static
 void print_cfg_print_lttng_live_sessions(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  URL: %s\n",
                cfg->cmd_data.print_lttng_live_sessions.url->str);
 }
@@ -667,7 +654,7 @@ void print_cfg_print_lttng_live_sessions(struct bt_config *cfg)
 static
 void print_cfg_query(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  Object: `%s`\n", cfg->cmd_data.query.object->str);
        fprintf(stderr, "  Component class:\n");
        print_bt_config_component(cfg->cmd_data.query.cfg_component);
@@ -732,15 +719,15 @@ void add_to_loaded_plugins(struct bt_plugin_set *plugin_set)
                                bt_plugin_get_name(plugin),
                                bt_plugin_get_path(plugin),
                                bt_plugin_get_path(loaded_plugin));
-                       bt_put(loaded_plugin);
+                       bt_object_put_ref(loaded_plugin);
                } else {
                        /* Add to global array. */
                        BT_LOGD("Adding plugin to loaded plugins: plugin-path=\"%s\"",
                                bt_plugin_get_name(plugin));
-                       g_ptr_array_add(loaded_plugins, bt_get(plugin));
+                       g_ptr_array_add(loaded_plugins, bt_object_get_ref(plugin));
                }
 
-               bt_put(plugin);
+               bt_object_put_ref(plugin);
        }
 }
 
@@ -749,7 +736,7 @@ int load_dynamic_plugins(struct bt_value *plugin_paths)
 {
        int nr_paths, i, ret = 0;
 
-       nr_paths = bt_value_array_size(plugin_paths);
+       nr_paths = bt_value_array_get_size(plugin_paths);
        if (nr_paths < 0) {
                BT_LOGE_STR("Cannot load dynamic plugins: no plugin path.");
                ret = -1;
@@ -762,15 +749,10 @@ int load_dynamic_plugins(struct bt_value *plugin_paths)
                struct bt_value *plugin_path_value = NULL;
                const char *plugin_path;
                struct bt_plugin_set *plugin_set;
-               enum bt_value_status status;
 
-               plugin_path_value = bt_value_array_get(plugin_paths, i);
-               status = bt_value_string_get(plugin_path_value, &plugin_path);
-               if (status != BT_VALUE_STATUS_OK) {
-                       BT_LOGD_STR("Cannot get plugin path string.");
-                       BT_PUT(plugin_path_value);
-                       continue;
-               }
+               plugin_path_value = bt_value_array_borrow_element_by_index(
+                       plugin_paths, i);
+               plugin_path = bt_value_string_get(plugin_path_value);
 
                /*
                 * Skip this if the directory does not exist because
@@ -780,7 +762,6 @@ int load_dynamic_plugins(struct bt_value *plugin_paths)
                if (!g_file_test(plugin_path, G_FILE_TEST_IS_DIR)) {
                        BT_LOGV("Skipping nonexistent directory path: "
                                "path=\"%s\"", plugin_path);
-                       BT_PUT(plugin_path_value);
                        continue;
                }
 
@@ -788,13 +769,11 @@ int load_dynamic_plugins(struct bt_value *plugin_paths)
                if (!plugin_set) {
                        BT_LOGD("Unable to load dynamic plugins: path=\"%s\"",
                                plugin_path);
-                       BT_PUT(plugin_path_value);
                        continue;
                }
 
                add_to_loaded_plugins(plugin_set);
-               bt_put(plugin_set);
-               BT_PUT(plugin_path_value);
+               bt_object_put_ref(plugin_set);
        }
 end:
        return ret;
@@ -815,7 +794,7 @@ int load_static_plugins(void)
        }
 
        add_to_loaded_plugins(plugin_set);
-       bt_put(plugin_set);
+       bt_object_put_ref(plugin_set);
 end:
        return ret;
 }
@@ -923,8 +902,8 @@ int cmd_query(struct bt_config *cfg)
        }
 
        ret = query(comp_cls, cfg->cmd_data.query.object->str,
-               cfg->cmd_data.query.cfg_component->params, &results,
-               &fail_reason);
+               bt_value_borrow_from_private(cfg->cmd_data.query.cfg_component->params),
+               &results, &fail_reason);
        if (ret) {
                goto failed;
        }
@@ -957,8 +936,8 @@ failed:
        ret = -1;
 
 end:
-       bt_put(comp_cls);
-       bt_put(results);
+       bt_object_put_ref(comp_cls);
+       bt_object_put_ref(results);
        return ret;
 }
 
@@ -1016,7 +995,7 @@ int cmd_help(struct bt_config *cfg)
                        goto end;
                }
 
-               bt_put(needed_comp_cls);
+               bt_object_put_ref(needed_comp_cls);
        }
 
        for (i = 0; i < bt_plugin_get_component_class_count(plugin); i++) {
@@ -1038,7 +1017,7 @@ int cmd_help(struct bt_config *cfg)
                        if (strcmp(cfg->cmd_data.help.cfg_component->comp_cls_name->str,
                                        comp_class_name) != 0 ||
                                        type != cfg->cmd_data.help.cfg_component->type) {
-                               bt_put(comp_cls);
+                               bt_object_put_ref(comp_cls);
                                continue;
                        }
                }
@@ -1057,11 +1036,11 @@ int cmd_help(struct bt_config *cfg)
                        printf("\n%s\n", comp_class_help);
                }
 
-               bt_put(comp_cls);
+               bt_object_put_ref(comp_cls);
        }
 
 end:
-       bt_put(plugin);
+       bt_object_put_ref(plugin);
        return ret;
 }
 
@@ -1072,7 +1051,7 @@ int cmd_list_plugins(struct bt_config *cfg)
        int plugins_count, component_classes_count = 0, i;
 
        printf("From the following plugin paths:\n\n");
-       print_value(stdout, cfg->plugin_paths, 2);
+       print_value(stdout, bt_value_borrow_from_private(cfg->plugin_paths), 2);
        printf("\n");
        plugins_count = loaded_plugins->len;
        if (plugins_count == 0) {
@@ -1134,7 +1113,7 @@ int cmd_list_plugins(struct bt_config *cfg)
                        }
 
                        printf("\n");
-                       bt_put(comp_class);
+                       bt_object_put_ref(comp_class);
                }
        }
 
@@ -1148,7 +1127,7 @@ int cmd_print_lttng_live_sessions(struct bt_config *cfg)
        int ret = 0;
        struct bt_component_class *comp_cls = NULL;
        struct bt_value *results = NULL;
-       struct bt_value *params = NULL;
+       struct bt_private_value *params = NULL;
        struct bt_value *map = NULL;
        struct bt_value *v = NULL;
        static const char * const plugin_name = "ctf";
@@ -1177,18 +1156,19 @@ int cmd_print_lttng_live_sessions(struct bt_config *cfg)
                goto error;
        }
 
-       params = bt_value_map_create();
+       params = bt_private_value_map_create();
        if (!params) {
                goto error;
        }
 
-       ret = bt_value_map_insert_string(params, "url",
+       ret = bt_private_value_map_insert_string_entry(params, "url",
                cfg->cmd_data.print_lttng_live_sessions.url->str);
        if (ret) {
                goto error;
        }
 
-       ret = query(comp_cls, "sessions", params, &results, &fail_reason);
+       ret = query(comp_cls, "sessions", bt_value_borrow_from_private(params),
+               &results, &fail_reason);
        if (ret) {
                goto failed;
        }
@@ -1217,12 +1197,12 @@ int cmd_print_lttng_live_sessions(struct bt_config *cfg)
                }
        }
 
-       array_size = bt_value_array_size(results);
+       array_size = bt_value_array_get_size(results);
        for (i = 0; i < array_size; i++) {
                const char *url_text;
                int64_t timer_us, streams, clients;
 
-               map = bt_value_array_get(results, i);
+               map = bt_value_array_borrow_element_by_index(results, i);
                if (!map) {
                        BT_LOGE_STR("Unexpected empty array entry.");
                        goto error;
@@ -1232,47 +1212,34 @@ int cmd_print_lttng_live_sessions(struct bt_config *cfg)
                        goto error;
                }
 
-               v = bt_value_map_get(map, "url");
+               v = bt_value_map_borrow_entry_value(map, "url");
                if (!v) {
                        BT_LOGE_STR("Unexpected empty array \"url\" entry.");
                        goto error;
                }
-               ret = bt_value_string_get(v, &url_text);
-               BT_ASSERT(ret == 0);
+               url_text = bt_value_string_get(v);
                fprintf(out_stream, "%s", url_text);
-               BT_PUT(v);
-
-               v = bt_value_map_get(map, "timer-us");
+               v = bt_value_map_borrow_entry_value(map, "timer-us");
                if (!v) {
                        BT_LOGE_STR("Unexpected empty array \"timer-us\" entry.");
                        goto error;
                }
-               ret = bt_value_integer_get(v, &timer_us);
-               BT_ASSERT(ret == 0);
+               timer_us = bt_value_integer_get(v);
                fprintf(out_stream, " (timer = %" PRIu64 ", ", timer_us);
-               BT_PUT(v);
-
-               v = bt_value_map_get(map, "stream-count");
+               v = bt_value_map_borrow_entry_value(map, "stream-count");
                if (!v) {
                        BT_LOGE_STR("Unexpected empty array \"stream-count\" entry.");
                        goto error;
                }
-               ret = bt_value_integer_get(v, &streams);
-               BT_ASSERT(ret == 0);
+               streams = bt_value_integer_get(v);
                fprintf(out_stream, "%" PRIu64 " stream(s), ", streams);
-               BT_PUT(v);
-
-               v = bt_value_map_get(map, "client-count");
+               v = bt_value_map_borrow_entry_value(map, "client-count");
                if (!v) {
                        BT_LOGE_STR("Unexpected empty array \"client-count\" entry.");
                        goto error;
                }
-               ret = bt_value_integer_get(v, &clients);
-               BT_ASSERT(ret == 0);
+               clients = bt_value_integer_get(v);
                fprintf(out_stream, "%" PRIu64 " client(s) connected)\n", clients);
-               BT_PUT(v);
-
-               BT_PUT(map);
        }
 
        goto end;
@@ -1289,11 +1256,9 @@ error:
        ret = -1;
 
 end:
-       bt_put(v);
-       bt_put(map);
-       bt_put(results);
-       bt_put(params);
-       bt_put(comp_cls);
+       bt_object_put_ref(results);
+       bt_object_put_ref(params);
+       bt_object_put_ref(comp_cls);
 
        if (out_stream && out_stream != stdout) {
                int fclose_ret = fclose(out_stream);
@@ -1314,7 +1279,7 @@ int cmd_print_ctf_metadata(struct bt_config *cfg)
        int ret = 0;
        struct bt_component_class *comp_cls = NULL;
        struct bt_value *results = NULL;
-       struct bt_value *params = NULL;
+       struct bt_private_value *params = NULL;
        struct bt_value *metadata_text_value = NULL;
        const char *metadata_text = NULL;
        static const char * const plugin_name = "ctf";
@@ -1343,33 +1308,33 @@ int cmd_print_ctf_metadata(struct bt_config *cfg)
                goto end;
        }
 
-       params = bt_value_map_create();
+       params = bt_private_value_map_create();
        if (!params) {
                ret = -1;
                goto end;
        }
 
-       ret = bt_value_map_insert_string(params, "path",
+       ret = bt_private_value_map_insert_string_entry(params, "path",
                cfg->cmd_data.print_ctf_metadata.path->str);
        if (ret) {
                ret = -1;
                goto end;
        }
 
-       ret = query(comp_cls, "metadata-info", params, &results, &fail_reason);
+       ret = query(comp_cls, "metadata-info",
+               bt_value_borrow_from_private(params), &results, &fail_reason);
        if (ret) {
                goto failed;
        }
 
-       metadata_text_value = bt_value_map_get(results, "text");
+       metadata_text_value = bt_value_map_borrow_entry_value(results, "text");
        if (!metadata_text_value) {
                BT_LOGE_STR("Cannot find `text` string value in the resulting metadata info object.");
                ret = -1;
                goto end;
        }
 
-       ret = bt_value_string_get(metadata_text_value, &metadata_text);
-       BT_ASSERT(ret == 0);
+       metadata_text = bt_value_string_get(metadata_text_value);
 
        if (cfg->cmd_data.print_ctf_metadata.output_path->len > 0) {
                out_stream =
@@ -1403,10 +1368,9 @@ failed:
 
 end:
        destroy_the_query_executor();
-       bt_put(results);
-       bt_put(params);
-       bt_put(metadata_text_value);
-       bt_put(comp_cls);
+       bt_object_put_ref(results);
+       bt_object_put_ref(params);
+       bt_object_put_ref(comp_cls);
 
        if (out_stream && out_stream != stdout) {
                int fclose_ret = fclose(out_stream);
@@ -1548,7 +1512,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
        struct bt_port *(*port_by_index_fn)(struct bt_component *, uint64_t);
        enum bt_graph_status status = BT_GRAPH_STATUS_ERROR;
        bool insert_trimmer = false;
-       struct bt_value *trimmer_params = NULL;
+       struct bt_private_value *trimmer_params = NULL;
        char *intersection_begin = NULL;
        char *intersection_end = NULL;
        struct bt_component *trimmer = NULL;
@@ -1584,17 +1548,18 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                        }
 
                        insert_trimmer = true;
-                       trimmer_params = bt_value_map_create();
+                       trimmer_params = bt_private_value_map_create();
                        if (!trimmer_params) {
                                goto error;
                        }
 
-                       status = bt_value_map_insert_string(trimmer_params,
-                               "begin", intersection_begin);
+                       status = bt_private_value_map_insert_string_entry(
+                               trimmer_params, "begin", intersection_begin);
                        if (status != BT_VALUE_STATUS_OK) {
                                goto error;
                        }
-                       status = bt_value_map_insert_string(trimmer_params,
+                       status = bt_private_value_map_insert_string_entry(
+                               trimmer_params,
                                "end", intersection_end);
                        if (status != BT_VALUE_STATUS_OK) {
                                goto error;
@@ -1657,7 +1622,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
 
                /* Skip port if it's already connected. */
                if (bt_port_is_connected(downstream_port)) {
-                       bt_put(downstream_port);
+                       bt_object_put_ref(downstream_port);
                        BT_LOGD("Skipping downstream port: already connected: "
                                "port-addr=%p, port-name=\"%s\"",
                                downstream_port,
@@ -1673,7 +1638,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                if (!bt_common_star_glob_match(
                                cfg_conn->downstream_port_glob->str, SIZE_MAX,
                                downstream_port_name, SIZE_MAX)) {
-                       bt_put(downstream_port);
+                       bt_object_put_ref(downstream_port);
                        continue;
                }
 
@@ -1704,7 +1669,8 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
 
                        ctx->connect_ports = false;
                        graph_status = bt_graph_add_component(ctx->graph,
-                               trimmer_class, trimmer_name, trimmer_params,
+                               trimmer_class, trimmer_name,
+                               bt_value_borrow_from_private(trimmer_params),
                                &trimmer);
                        free(trimmer_name);
                        if (graph_status != BT_GRAPH_STATUS_OK) {
@@ -1729,7 +1695,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                         * Replace the current downstream port by the trimmer's
                         * upstream port.
                         */
-                       BT_MOVE(downstream_port, trimmer_input);
+                       BT_OBJECT_MOVE_REF(downstream_port, trimmer_input);
                        downstream_port_name = bt_port_get_name(
                                downstream_port);
                        if (!downstream_port_name) {
@@ -1740,7 +1706,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                /* We have a winner! */
                status = bt_graph_connect_ports(ctx->graph,
                        upstream_port, downstream_port, NULL);
-               BT_PUT(downstream_port);
+               BT_OBJECT_PUT_REF_AND_RESET(downstream_port);
                switch (status) {
                case BT_GRAPH_STATUS_OK:
                        break;
@@ -1836,11 +1802,11 @@ error:
 end:
        free(intersection_begin);
        free(intersection_end);
-       BT_PUT(trimmer_params);
-       BT_PUT(trimmer_class);
-       BT_PUT(trimmer);
-       BT_PUT(trimmer_input);
-       BT_PUT(trimmer_output);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_params);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_class);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_input);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_output);
        return ret;
 }
 
@@ -1918,7 +1884,7 @@ error:
        ret = -1;
 
 end:
-       bt_put(upstream_comp);
+       bt_object_put_ref(upstream_comp);
        return ret;
 }
 
@@ -1960,7 +1926,7 @@ void graph_port_added_listener(struct bt_port *port, void *data)
        }
 
 end:
-       bt_put(comp);
+       bt_object_put_ref(comp);
        return;
 }
 
@@ -1992,8 +1958,8 @@ void graph_ports_connected_listener(struct bt_port *upstream_port,
                upstream_port, bt_port_get_name(upstream_port),
                downstream_comp, bt_component_get_name(downstream_comp),
                downstream_port, bt_port_get_name(downstream_port));
-       bt_put(upstream_comp);
-       bt_put(downstream_comp);
+       bt_object_put_ref(upstream_comp);
+       bt_object_put_ref(downstream_comp);
 }
 
 static
@@ -2027,7 +1993,7 @@ void cmd_run_ctx_destroy(struct cmd_run_ctx *ctx)
                ctx->intersections = NULL;
        }
 
-       BT_PUT(ctx->graph);
+       BT_OBJECT_PUT_REF_AND_RESET(ctx->graph);
        the_graph = NULL;
        ctx->cfg = NULL;
 }
@@ -2040,7 +2006,7 @@ int cmd_run_ctx_init(struct cmd_run_ctx *ctx, struct bt_config *cfg)
        ctx->cfg = cfg;
        ctx->connect_ports = false;
        ctx->components = g_hash_table_new_full(g_direct_hash, g_direct_equal,
-               NULL, bt_put);
+               NULL, bt_object_put_ref);
        if (!ctx->components) {
                goto error;
        }
@@ -2109,7 +2075,7 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
        enum bt_value_status value_status;
        const char *path = NULL;
        struct bt_value *component_path_value = NULL;
-       struct bt_value *query_params = NULL;
+       struct bt_private_value *query_params = NULL;
        struct bt_value *query_result = NULL;
        struct bt_value *trace_info = NULL;
        struct bt_value *intersection_range = NULL;
@@ -2123,7 +2089,9 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
        struct trace_range *trace_range = NULL;
        const char *fail_reason = NULL;
 
-       component_path_value = bt_value_map_get(cfg_comp->params, "path");
+       component_path_value = bt_value_map_borrow_entry_value(
+               bt_value_borrow_from_private(cfg_comp->params),
+               "path");
        if (component_path_value && !bt_value_is_string(component_path_value)) {
                BT_LOGD("Cannot get path parameter: component-name=%s",
                        cfg_comp->instance_name->str);
@@ -2131,29 +2099,24 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                goto error;
        }
 
-       value_status = bt_value_string_get(component_path_value, &path);
-       if (value_status != BT_VALUE_STATUS_OK) {
-               BT_LOGD("Cannot get path string value: component-name=%s",
-                       cfg_comp->instance_name->str);
-               ret = -1;
-               goto error;
-       }
-
-       query_params = bt_value_map_create();
+       path = bt_value_string_get(component_path_value);
+       query_params = bt_private_value_map_create();
        if (!query_params) {
                BT_LOGE_STR("Cannot create query parameters.");
                ret = -1;
                goto error;
        }
 
-       value_status = bt_value_map_insert(query_params, "path", component_path_value);
+       value_status = bt_private_value_map_insert_entry(query_params, "path",
+               component_path_value);
        if (value_status != BT_VALUE_STATUS_OK) {
                BT_LOGE_STR("Cannot insert path parameter in query parameter map.");
                ret = -1;
                goto error;
        }
 
-       ret = query(comp_cls, "trace-info", query_params, &query_result,
+       ret = query(comp_cls, "trace-info",
+               bt_value_borrow_from_private(query_params), &query_result,
                &fail_reason);
        if (ret) {
                BT_LOGD("Component class does not support the `trace-info` query: %s: "
@@ -2173,7 +2136,7 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                goto error;
        }
 
-       trace_count = bt_value_array_size(query_result);
+       trace_count = bt_value_array_get_size(query_result);
        if (trace_count < 0) {
                ret = -1;
                goto error;
@@ -2184,14 +2147,15 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                uint64_t stream_idx;
                int64_t stream_count;
 
-               trace_info = bt_value_array_get(query_result, trace_idx);
+               trace_info = bt_value_array_borrow_element_by_index(
+                       query_result, trace_idx);
                if (!trace_info || !bt_value_is_map(trace_info)) {
                        ret = -1;
                        BT_LOGD_STR("Cannot retrieve trace from query result.");
                        goto error;
                }
 
-               intersection_range = bt_value_map_get(trace_info,
+               intersection_range = bt_value_map_borrow_entry_value(trace_info,
                        "intersection-range-ns");
                if (!intersection_range) {
                        ret = -1;
@@ -2199,35 +2163,24 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                        goto error;
                }
 
-               intersection_begin = bt_value_map_get(intersection_range,
-                       "begin");
+               intersection_begin = bt_value_map_borrow_entry_value(
+                       intersection_range, "begin");
                if (!intersection_begin) {
                        ret = -1;
                        BT_LOGD_STR("Cannot retrieve intersection-range-ns \'begin\' field from query result.");
                        goto error;
                }
 
-               intersection_end = bt_value_map_get(intersection_range,
-                       "end");
+               intersection_end = bt_value_map_borrow_entry_value(
+                       intersection_range, "end");
                if (!intersection_end) {
                        ret = -1;
                        BT_LOGD_STR("Cannot retrieve intersection-range-ns \'end\' field from query result.");
                        goto error;
                }
 
-               value_status = bt_value_integer_get(intersection_begin, &begin);
-               if (value_status != BT_VALUE_STATUS_OK) {
-                       ret = -1;
-                       BT_LOGD_STR("Cannot retrieve value of intersection-range-ns \'begin\' field from query result.");
-                       goto error;
-               }
-
-               value_status = bt_value_integer_get(intersection_end, &end);
-               if (value_status != BT_VALUE_STATUS_OK) {
-                       ret = -1;
-                       BT_LOGD_STR("Cannot retrieve value of intersection-range-ns \'end\' field from query result.");
-                       goto error;
-               }
+               begin = bt_value_integer_get(intersection_begin);
+               end = bt_value_integer_get(intersection_end);
 
                if (begin < 0 || end < 0 || end < begin) {
                        BT_LOGW("Invalid trace stream intersection values: "
@@ -2238,14 +2191,15 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                        goto error;
                }
 
-               stream_infos = bt_value_map_get(trace_info, "streams");
+               stream_infos = bt_value_map_borrow_entry_value(trace_info,
+                       "streams");
                if (!stream_infos || !bt_value_is_array(stream_infos)) {
                        ret = -1;
                        BT_LOGD_STR("Cannot retrieve stream information from trace in query result.");
                        goto error;
                }
 
-               stream_count = bt_value_array_size(stream_infos);
+               stream_count = bt_value_array_get_size(stream_infos);
                if (stream_count < 0) {
                        ret = -1;
                        goto error;
@@ -2288,22 +2242,25 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                        trace_range->intersection_range_begin_ns = begin;
                        trace_range->intersection_range_end_ns = end;
 
-                       stream_info = bt_value_array_get(stream_infos,
-                               stream_idx);
+                       stream_info = bt_value_array_borrow_element_by_index(
+                               stream_infos, stream_idx);
                        if (!stream_info || !bt_value_is_map(stream_info)) {
                                ret = -1;
                                BT_LOGD_STR("Cannot retrieve stream informations from trace in query result.");
                                goto error;
                        }
 
-                       stream_paths = bt_value_map_get(stream_info, "paths");
+                       stream_paths = bt_value_map_borrow_entry_value(
+                               stream_info, "paths");
                        if (!stream_paths || !bt_value_is_array(stream_paths)) {
                                ret = -1;
                                BT_LOGD_STR("Cannot retrieve stream paths from trace in query result.");
                                goto error;
                        }
 
-                       stream_path_value = bt_value_array_get(stream_paths, 0);
+                       stream_path_value =
+                               bt_value_array_borrow_element_by_index(
+                                       stream_paths, 0);
                        if (!stream_path_value ||
                                !bt_value_is_string(stream_path_value)) {
                                ret = -1;
@@ -2311,13 +2268,7 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                                goto error;
                        }
 
-                       value_status = bt_value_string_get(stream_path_value,
-                               &stream_path);
-                       if (value_status != BT_VALUE_STATUS_OK) {
-                               ret = -1;
-                               goto error;
-                       }
-
+                       stream_path = bt_value_string_get(stream_path_value);
                        port_id->port_name = strdup(stream_path);
                        if (!port_id->port_name) {
                                ret = -1;
@@ -2331,19 +2282,7 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
 
                        port_id = NULL;
                        trace_range = NULL;
-                       BT_PUT(stream_info);
-                       BT_PUT(stream_paths);
-                       BT_PUT(stream_path_value);
                }
-
-               BT_PUT(trace_info);
-               BT_PUT(stream_paths);
-               BT_PUT(stream_path_value);
-               BT_PUT(intersection_range);
-               BT_PUT(intersection_begin);
-               BT_PUT(intersection_end);
-               BT_PUT(stream_paths);
-               BT_PUT(stream_path_value);
        }
 
        goto end;
@@ -2355,17 +2294,8 @@ error:
                path ? path : "(unknown)",
                bt_common_color_reset());
 end:
-       bt_put(component_path_value);
-       bt_put(query_params);
-       bt_put(query_result);
-       bt_put(trace_info);
-       bt_put(intersection_range);
-       bt_put(intersection_begin);
-       bt_put(intersection_end);
-       bt_put(stream_infos);
-       bt_put(stream_info);
-       bt_put(stream_paths);
-       bt_put(stream_path_value);
+       bt_object_put_ref(query_params);
+       bt_object_put_ref(query_result);
        g_free(port_id);
        g_free(trace_range);
        return ret;
@@ -2406,7 +2336,8 @@ int cmd_run_ctx_create_components_from_config_components(
                }
 
                ret = bt_graph_add_component(ctx->graph, comp_cls,
-                       cfg_comp->instance_name->str, cfg_comp->params, &comp);
+                       cfg_comp->instance_name->str,
+                       bt_value_borrow_from_private(cfg_comp->params), &comp);
                if (ret) {
                        BT_LOGE("Cannot create component: plugin-name=\"%s\", "
                                "comp-cls-name=\"%s\", comp-cls-type=%d, "
@@ -2437,7 +2368,7 @@ int cmd_run_ctx_create_components_from_config_components(
                g_hash_table_insert(ctx->components,
                        GUINT_TO_POINTER(quark), comp);
                comp = NULL;
-               BT_PUT(comp_cls);
+               BT_OBJECT_PUT_REF_AND_RESET(comp_cls);
        }
 
        goto end;
@@ -2446,8 +2377,8 @@ error:
        ret = -1;
 
 end:
-       bt_put(comp);
-       bt_put(comp_cls);
+       bt_object_put_ref(comp);
+       bt_object_put_ref(comp_cls);
        return ret;
 }
 
@@ -2507,7 +2438,7 @@ int cmd_run_ctx_connect_comp_ports(struct cmd_run_ctx *ctx,
 
                BT_ASSERT(upstream_port);
                ret = cmd_run_ctx_connect_upstream_port(ctx, upstream_port);
-               bt_put(upstream_port);
+               bt_object_put_ref(upstream_port);
                if (ret) {
                        goto end;
                }
@@ -2881,7 +2812,8 @@ int main(int argc, const char **argv)
        print_cfg(cfg);
 
        if (cfg->command_needs_plugins) {
-               ret = load_all_plugins(cfg->plugin_paths);
+               ret = load_all_plugins(
+                       bt_value_borrow_from_private(cfg->plugin_paths));
                if (ret) {
                        BT_LOGE("Failed to load plugins: ret=%d", ret);
                        retcode = 1;
@@ -2922,7 +2854,7 @@ int main(int argc, const char **argv)
        retcode = ret ? 1 : 0;
 
 end:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
        fini_static_data();
        return retcode;
 }
This page took 0.043417 seconds and 4 git commands to generate.