/* Core dump and executable file functions below target vector, for GDB.
- Copyright (C) 1986-2018 Free Software Foundation, Inc.
+ Copyright (C) 1986-2020 Free Software Foundation, Inc.
This file is part of GDB.
#include "arch-utils.h"
#include <signal.h>
#include <fcntl.h>
-#ifdef HAVE_SYS_FILE_H
-#include <sys/file.h> /* needed for F_OK and friends */
-#endif
#include "frame.h" /* required by inferior.h */
#include "inferior.h"
#include "infrun.h"
#include "command.h"
#include "bfd.h"
#include "target.h"
+#include "process-stratum-target.h"
#include "gdbcore.h"
#include "gdbthread.h"
#include "regcache.h"
#include "regset.h"
#include "symfile.h"
#include "exec.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "solib.h"
#include "filenames.h"
#include "progspace.h"
#include "objfiles.h"
#include "gdb_bfd.h"
#include "completer.h"
-#include "filestuff.h"
+#include "gdbsupport/filestuff.h"
+#include "build-id.h"
+#include "gdbsupport/pathstuff.h"
#ifndef O_LARGEFILE
#define O_LARGEFILE 0
#endif
+static core_fns *sniff_core_bfd (gdbarch *core_gdbarch,
+ bfd *abfd);
+
/* The core file target. */
static const target_info core_target_info = {
"core",
N_("Local core dump file"),
- N_("Use a core file as a target. Specify the filename of the core file.")
+ N_("Use a core file as a target.\n\
+Specify the filename of the core file.")
};
-class core_target final : public target_ops
+class core_target final : public process_stratum_target
{
public:
- core_target ()
- { to_stratum = process_stratum; }
+ core_target ();
+ ~core_target () override;
const target_info &info () const override
{ return core_target_info; }
bool thread_alive (ptid_t ptid) override;
const struct target_desc *read_description () override;
- const char *pid_to_str (ptid_t) override;
+ std::string pid_to_str (ptid_t) override;
const char *thread_name (struct thread_info *) override;
+ bool has_all_memory () override { return false; }
bool has_memory () override;
bool has_stack () override;
bool has_registers () override;
+ bool has_execution (inferior *inf) override { return false; }
+
bool info_proc (const char *, enum info_proc_what) override;
+
+ /* A few helpers. */
+
+ /* Getter, see variable definition. */
+ struct gdbarch *core_gdbarch ()
+ {
+ return m_core_gdbarch;
+ }
+
+ /* See definition. */
+ void get_core_register_section (struct regcache *regcache,
+ const struct regset *regset,
+ const char *name,
+ int section_min_size,
+ int which,
+ const char *human_name,
+ bool required);
+
+private: /* per-core data */
+
+ /* The core's section table. Note that these target sections are
+ *not* mapped in the current address spaces' set of target
+ sections --- those should come only from pure executable or
+ shared library bfds. The core bfd sections are an implementation
+ detail of the core target, just like ptrace is for unix child
+ targets. */
+ target_section_table m_core_section_table {};
+
+ /* The core_fns for a core file handler that is prepared to read the
+ core file currently open on core_bfd. */
+ core_fns *m_core_vec = NULL;
+
+ /* FIXME: kettenis/20031023: Eventually this field should
+ disappear. */
+ struct gdbarch *m_core_gdbarch = NULL;
};
-/* See gdbcore.h. */
-struct target_ops *the_core_target;
+core_target::core_target ()
+{
+ m_core_gdbarch = gdbarch_from_bfd (core_bfd);
+
+ /* Find a suitable core file handler to munch on core_bfd */
+ m_core_vec = sniff_core_bfd (m_core_gdbarch, core_bfd);
+
+ /* Find the data section */
+ if (build_section_table (core_bfd,
+ &m_core_section_table.sections,
+ &m_core_section_table.sections_end))
+ error (_("\"%s\": Can't find sections: %s"),
+ bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ()));
+}
+
+core_target::~core_target ()
+{
+ xfree (m_core_section_table.sections);
+}
/* List of all available core_fns. On gdb startup, each core file
register reader calls deprecated_add_core_fns() to register
static struct core_fns *core_file_fns = NULL;
-/* The core_fns for a core file handler that is prepared to read the
- core file currently open on core_bfd. */
-
-static struct core_fns *core_vec = NULL;
-
-/* FIXME: kettenis/20031023: Eventually this variable should
- disappear. */
-
-static struct gdbarch *core_gdbarch = NULL;
-
-/* Per-core data. Currently, only the section table. Note that these
- target sections are *not* mapped in the current address spaces' set
- of target sections --- those should come only from pure executable
- or shared library bfds. The core bfd sections are an
- implementation detail of the core target, just like ptrace is for
- unix child targets. */
-static struct target_section_table *core_data;
-
-static struct core_fns *sniff_core_bfd (bfd *);
-
static int gdb_check_format (bfd *);
-static void core_close_cleanup (void *ignore);
-
static void add_to_thread_list (bfd *, asection *, void *);
-static core_target core_ops;
-
/* An arbitrary identifier for the core inferior. */
#define CORELOW_PID 1
selected. */
static struct core_fns *
-sniff_core_bfd (bfd *abfd)
+sniff_core_bfd (struct gdbarch *core_gdbarch, bfd *abfd)
{
struct core_fns *cf;
struct core_fns *yummy = NULL;
return (0);
}
-/* Discard all vestiges of any previous core file and mark data and
- stack spaces as empty. */
+/* Close the core target. */
-static void
-core_close ()
+void
+core_target::close ()
{
if (core_bfd)
{
- int pid = ptid_get_pid (inferior_ptid);
inferior_ptid = null_ptid; /* Avoid confusion from thread
stuff. */
- if (pid != 0)
- exit_inferior_silent (pid);
+ exit_inferior_silent (current_inferior ());
/* Clear out solib state while the bfd is still open. See
comments in clear_solib in solib.c. */
clear_solib ();
- if (core_data)
- {
- xfree (core_data->sections);
- xfree (core_data);
- core_data = NULL;
- }
-
- gdb_bfd_unref (core_bfd);
- core_bfd = NULL;
+ current_program_space->cbfd.reset (nullptr);
}
- core_vec = NULL;
- core_gdbarch = NULL;
-}
-
-static void
-core_close_cleanup (void *ignore)
-{
- core_close ();
-}
-void
-core_target::close ()
-{
- core_close ();
+ /* Core targets are heap-allocated (see core_target_open), so here
+ we delete ourselves. */
+ delete this;
}
/* Look for sections whose names start with `.reg/' so that we can
int core_tid;
int pid, lwpid;
asection *reg_sect = (asection *) reg_sect_arg;
- int fake_pid_p = 0;
+ bool fake_pid_p = false;
struct inferior *inf;
- if (!startswith (bfd_section_name (abfd, asect), ".reg/"))
+ if (!startswith (bfd_section_name (asect), ".reg/"))
return;
- core_tid = atoi (bfd_section_name (abfd, asect) + 5);
+ core_tid = atoi (bfd_section_name (asect) + 5);
pid = bfd_core_file_pid (core_bfd);
if (pid == 0)
{
- fake_pid_p = 1;
+ fake_pid_p = true;
pid = CORELOW_PID;
}
inf->fake_pid_p = fake_pid_p;
}
- ptid = ptid_build (pid, lwpid, 0);
+ ptid = ptid_t (pid, lwpid, 0);
add_thread (ptid);
inferior_ptid = ptid; /* Yes, make it current. */
}
+/* Issue a message saying we have no core to debug, if FROM_TTY. */
+
+static void
+maybe_say_no_core_file_now (int from_tty)
+{
+ if (from_tty)
+ printf_filtered (_("No core file now.\n"));
+}
+
+/* Backward compatibility with old way of specifying core files. */
+
+void
+core_file_command (const char *filename, int from_tty)
+{
+ dont_repeat (); /* Either way, seems bogus. */
+
+ if (filename == NULL)
+ {
+ if (core_bfd != NULL)
+ {
+ target_detach (current_inferior (), from_tty);
+ gdb_assert (core_bfd == NULL);
+ }
+ else
+ maybe_say_no_core_file_now (from_tty);
+ }
+ else
+ core_target_open (filename, from_tty);
+}
+
+/* Locate (and load) an executable file (and symbols) given the core file
+ BFD ABFD. */
+
+static void
+locate_exec_from_corefile_build_id (bfd *abfd, int from_tty)
+{
+ const bfd_build_id *build_id = build_id_bfd_get (abfd);
+ if (build_id == nullptr)
+ return;
+
+ gdb_bfd_ref_ptr execbfd
+ = build_id_to_exec_bfd (build_id->size, build_id->data);
+
+ if (execbfd != nullptr)
+ {
+ exec_file_attach (bfd_get_filename (execbfd.get ()), from_tty);
+ symbol_file_add_main (bfd_get_filename (execbfd.get ()),
+ symfile_add_flag (from_tty ? SYMFILE_VERBOSE : 0));
+ }
+}
+
/* See gdbcore.h. */
void
{
const char *p;
int siggy;
- struct cleanup *old_chain;
int scratch_chan;
int flags;
gdb::unique_xmalloc_ptr<char> filename (tilde_expand (arg));
if (!IS_ABSOLUTE_PATH (filename.get ()))
- filename.reset (concat (current_directory, "/",
- filename.get (), (char *) NULL));
+ filename = gdb_abspath (filename.get ());
flags = O_BINARY | O_LARGEFILE;
if (write_files)
filename.get (), bfd_errmsg (bfd_get_error ()));
}
- /* Looks semi-reasonable. Toss the old core file and work on the
- new. */
+ current_program_space->cbfd = std::move (temp_bfd);
- unpush_target (&core_ops);
- core_bfd = temp_bfd.release ();
- old_chain = make_cleanup (core_close_cleanup, 0 /*ignore*/);
+ core_target *target = new core_target ();
- core_gdbarch = gdbarch_from_bfd (core_bfd);
-
- /* Find a suitable core file handler to munch on core_bfd */
- core_vec = sniff_core_bfd (core_bfd);
+ /* Own the target until it is successfully pushed. */
+ target_ops_up target_holder (target);
validate_files ();
- core_data = XCNEW (struct target_section_table);
-
- /* Find the data section */
- if (build_section_table (core_bfd,
- &core_data->sections,
- &core_data->sections_end))
- error (_("\"%s\": Can't find sections: %s"),
- bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ()));
-
/* If we have no exec file, try to set the architecture from the
core file. We don't do this unconditionally since an exec file
typically contains more information that helps us determine the
if (!exec_bfd)
set_gdbarch_from_file (core_bfd);
- push_target (&core_ops);
- discard_cleanups (old_chain);
-
- /* Do this before acknowledging the inferior, so if
- post_create_inferior throws (can happen easilly if you're loading
- a core file with the wrong exec), we aren't left with threads
- from the previous inferior. */
- init_thread_list ();
+ push_target (std::move (target_holder));
inferior_ptid = null_ptid;
bfd_map_over_sections (core_bfd, add_to_thread_list,
bfd_get_section_by_name (core_bfd, ".reg"));
- if (ptid_equal (inferior_ptid, null_ptid))
+ if (inferior_ptid == null_ptid)
{
/* Either we found no .reg/NN section, and hence we have a
non-threaded core (single-threaded, from gdb's perspective),
which was the "main" thread. The latter case shouldn't
usually happen, but we're dealing with input here, which can
always be broken in different ways. */
- struct thread_info *thread = first_thread_of_process (-1);
+ thread_info *thread = first_thread_of_inferior (current_inferior ());
if (thread == NULL)
{
inferior_appeared (current_inferior (), CORELOW_PID);
- inferior_ptid = pid_to_ptid (CORELOW_PID);
+ inferior_ptid = ptid_t (CORELOW_PID);
add_thread_silent (inferior_ptid);
}
else
- switch_to_thread (thread->ptid);
+ switch_to_thread (thread);
}
- post_create_inferior (&core_ops, from_tty);
+ if (exec_bfd == nullptr)
+ locate_exec_from_corefile_build_id (core_bfd, from_tty);
+
+ post_create_inferior (target, from_tty);
/* Now go through the target stack looking for threads since there
may be a thread_stratum target loaded on top of target core by
now. The layer above should claim threads found in the BFD
sections. */
- TRY
+ try
{
target_update_thread_list ();
}
- CATCH (except, RETURN_MASK_ERROR)
+ catch (const gdb_exception_error &except)
{
exception_print (gdb_stderr, except);
}
- END_CATCH
p = bfd_core_file_failing_command (core_bfd);
if (p)
siggy = bfd_core_file_failing_signal (core_bfd);
if (siggy > 0)
{
+ gdbarch *core_gdbarch = target->core_gdbarch ();
+
/* If we don't have a CORE_GDBARCH to work with, assume a native
core (map gdb_signal from host signals). If we do have
CORE_GDBARCH to work with, but no gdb_signal_from_target
anything about threads. That is why the test is >= 2. */
if (thread_count () >= 2)
{
- TRY
+ try
{
thread_command (NULL, from_tty);
}
- CATCH (except, RETURN_MASK_ERROR)
+ catch (const gdb_exception_error &except)
{
exception_print (gdb_stderr, except);
}
- END_CATCH
}
}
void
core_target::detach (inferior *inf, int from_tty)
{
+ /* Note that 'this' is dangling after this call. unpush_target
+ closes the target, and our close implementation deletes
+ 'this'. */
unpush_target (this);
+
+ /* Clear the register cache and the frame cache. */
+ registers_changed ();
reinit_frame_cache ();
- if (from_tty)
- printf_filtered (_("No core file now.\n"));
+ maybe_say_no_core_file_now (from_tty);
}
/* Try to retrieve registers from a section in core_bfd, and supply
- them to core_vec->core_read_registers, as the register set numbered
- WHICH.
+ them to m_core_vec->core_read_registers, as the register set
+ numbered WHICH.
If ptid's lwp member is zero, do the single-threaded
thing: look for a section named NAME. If ptid's lwp
HUMAN_NAME is a human-readable name for the kind of registers the
NAME section contains, for use in error messages.
- If REQUIRED is non-zero, print an error if the core file doesn't
- have a section by the appropriate name. Otherwise, just do
- nothing. */
+ If REQUIRED is true, print an error if the core file doesn't have a
+ section by the appropriate name. Otherwise, just do nothing. */
-static void
-get_core_register_section (struct regcache *regcache,
- const struct regset *regset,
- const char *name,
- int min_size,
- int which,
- const char *human_name,
- int required)
+void
+core_target::get_core_register_section (struct regcache *regcache,
+ const struct regset *regset,
+ const char *name,
+ int section_min_size,
+ int which,
+ const char *human_name,
+ bool required)
{
struct bfd_section *section;
bfd_size_type size;
return;
}
- size = bfd_section_size (core_bfd, section);
- if (size < min_size)
+ size = bfd_section_size (section);
+ if (size < section_min_size)
{
warning (_("Section `%s' in core file too small."),
section_name.c_str ());
return;
}
- if (size != min_size && !variable_size_section)
+ if (size != section_min_size && !variable_size_section)
{
warning (_("Unexpected size of section `%s' in core file."),
section_name.c_str ());
return;
}
- gdb_assert (core_vec);
- core_vec->core_read_registers (regcache, contents, size, which,
- ((CORE_ADDR)
- bfd_section_vma (core_bfd, section)));
+ gdb_assert (m_core_vec != nullptr);
+ m_core_vec->core_read_registers (regcache, contents, size, which,
+ (CORE_ADDR) bfd_section_vma (section));
}
+/* Data passed to gdbarch_iterate_over_regset_sections's callback. */
+struct get_core_registers_cb_data
+{
+ core_target *target;
+ struct regcache *regcache;
+};
+
/* Callback for get_core_registers that handles a single core file
register note section. */
static void
-get_core_registers_cb (const char *sect_name, int size,
+get_core_registers_cb (const char *sect_name, int supply_size, int collect_size,
const struct regset *regset,
const char *human_name, void *cb_data)
{
- struct regcache *regcache = (struct regcache *) cb_data;
- int required = 0;
+ auto *data = (get_core_registers_cb_data *) cb_data;
+ bool required = false;
+ bool variable_size_section = (regset != NULL
+ && regset->flags & REGSET_VARIABLE_SIZE);
+
+ if (!variable_size_section)
+ gdb_assert (supply_size == collect_size);
if (strcmp (sect_name, ".reg") == 0)
{
- required = 1;
+ required = true;
if (human_name == NULL)
human_name = "general-purpose";
}
/* The 'which' parameter is only used when no regset is provided.
Thus we just set it to -1. */
- get_core_register_section (regcache, regset, sect_name,
- size, -1, human_name, required);
+ data->target->get_core_register_section (data->regcache, regset, sect_name,
+ supply_size, -1, human_name,
+ required);
}
/* Get the registers out of a core file. This is the machine-
int i;
struct gdbarch *gdbarch;
- if (!(core_gdbarch && gdbarch_iterate_over_regset_sections_p (core_gdbarch))
- && (core_vec == NULL || core_vec->core_read_registers == NULL))
+ if (!(m_core_gdbarch != nullptr
+ && gdbarch_iterate_over_regset_sections_p (m_core_gdbarch))
+ && (m_core_vec == NULL || m_core_vec->core_read_registers == NULL))
{
fprintf_filtered (gdb_stderr,
"Can't fetch registers from this type of core file\n");
gdbarch = regcache->arch ();
if (gdbarch_iterate_over_regset_sections_p (gdbarch))
- gdbarch_iterate_over_regset_sections (gdbarch,
- get_core_registers_cb,
- (void *) regcache, NULL);
+ {
+ get_core_registers_cb_data data = { this, regcache };
+ gdbarch_iterate_over_regset_sections (gdbarch,
+ get_core_registers_cb,
+ (void *) &data, NULL);
+ }
else
{
get_core_register_section (regcache, NULL,
/* Mark all registers not found in the core as unavailable. */
for (i = 0; i < gdbarch_num_regs (regcache->arch ()); i++)
- if (regcache_register_status (regcache, i) == REG_UNKNOWN)
- regcache_raw_supply (regcache, i, NULL);
+ if (regcache->get_register_status (i) == REG_UNKNOWN)
+ regcache->raw_supply (i, NULL);
}
void
core_target::files_info ()
{
- print_section_info (core_data, core_bfd);
+ print_section_info (&m_core_section_table, core_bfd);
}
\f
-struct spuid_list
-{
- gdb_byte *buf;
- ULONGEST offset;
- LONGEST len;
- ULONGEST pos;
- ULONGEST written;
-};
-
-static void
-add_to_spuid_list (bfd *abfd, asection *asect, void *list_p)
-{
- struct spuid_list *list = (struct spuid_list *) list_p;
- enum bfd_endian byte_order
- = bfd_big_endian (abfd) ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE;
- int fd, pos = 0;
-
- sscanf (bfd_section_name (abfd, asect), "SPU/%d/regs%n", &fd, &pos);
- if (pos == 0)
- return;
-
- if (list->pos >= list->offset && list->pos + 4 <= list->offset + list->len)
- {
- store_unsigned_integer (list->buf + list->pos - list->offset,
- 4, byte_order, fd);
- list->written += 4;
- }
- list->pos += 4;
-}
-
enum target_xfer_status
core_target::xfer_partial (enum target_object object, const char *annex,
gdb_byte *readbuf, const gdb_byte *writebuf,
switch (object)
{
case TARGET_OBJECT_MEMORY:
- return section_table_xfer_memory_partial (readbuf, writebuf,
- offset, len, xfered_len,
- core_data->sections,
- core_data->sections_end,
- NULL);
+ return (section_table_xfer_memory_partial
+ (readbuf, writebuf,
+ offset, len, xfered_len,
+ m_core_section_table.sections,
+ m_core_section_table.sections_end,
+ NULL));
case TARGET_OBJECT_AUXV:
if (readbuf)
if (section == NULL)
return TARGET_XFER_E_IO;
- size = bfd_section_size (core_bfd, section);
+ size = bfd_section_size (section);
if (offset >= size)
return TARGET_XFER_EOF;
size -= offset;
if (section == NULL)
return TARGET_XFER_E_IO;
- size = bfd_section_size (core_bfd, section);
+ size = bfd_section_size (section);
if (offset >= size)
return TARGET_XFER_EOF;
size -= offset;
return TARGET_XFER_E_IO;
case TARGET_OBJECT_LIBRARIES:
- if (core_gdbarch
- && gdbarch_core_xfer_shared_libraries_p (core_gdbarch))
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_xfer_shared_libraries_p (m_core_gdbarch))
{
if (writebuf)
return TARGET_XFER_E_IO;
else
{
- *xfered_len = gdbarch_core_xfer_shared_libraries (core_gdbarch,
+ *xfered_len = gdbarch_core_xfer_shared_libraries (m_core_gdbarch,
readbuf,
offset, len);
/* FALL THROUGH */
case TARGET_OBJECT_LIBRARIES_AIX:
- if (core_gdbarch
- && gdbarch_core_xfer_shared_libraries_aix_p (core_gdbarch))
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_xfer_shared_libraries_aix_p (m_core_gdbarch))
{
if (writebuf)
return TARGET_XFER_E_IO;
else
{
*xfered_len
- = gdbarch_core_xfer_shared_libraries_aix (core_gdbarch,
+ = gdbarch_core_xfer_shared_libraries_aix (m_core_gdbarch,
readbuf, offset,
len);
}
/* FALL THROUGH */
- case TARGET_OBJECT_SPU:
- if (readbuf && annex)
- {
- /* When the SPU contexts are stored in a core file, BFD
- represents this with a fake section called
- "SPU/<annex>". */
-
- struct bfd_section *section;
- bfd_size_type size;
- char sectionstr[100];
-
- xsnprintf (sectionstr, sizeof sectionstr, "SPU/%s", annex);
-
- section = bfd_get_section_by_name (core_bfd, sectionstr);
- if (section == NULL)
- return TARGET_XFER_E_IO;
-
- size = bfd_section_size (core_bfd, section);
- if (offset >= size)
- return TARGET_XFER_EOF;
- size -= offset;
- if (size > len)
- size = len;
-
- if (size == 0)
- return TARGET_XFER_EOF;
- if (!bfd_get_section_contents (core_bfd, section, readbuf,
- (file_ptr) offset, size))
- {
- warning (_("Couldn't read SPU section in core file."));
- return TARGET_XFER_E_IO;
- }
-
- *xfered_len = (ULONGEST) size;
- return TARGET_XFER_OK;
- }
- else if (readbuf)
- {
- /* NULL annex requests list of all present spuids. */
- struct spuid_list list;
-
- list.buf = readbuf;
- list.offset = offset;
- list.len = len;
- list.pos = 0;
- list.written = 0;
- bfd_map_over_sections (core_bfd, add_to_spuid_list, &list);
-
- if (list.written == 0)
- return TARGET_XFER_EOF;
- else
- {
- *xfered_len = (ULONGEST) list.written;
- return TARGET_XFER_OK;
- }
- }
- return TARGET_XFER_E_IO;
-
case TARGET_OBJECT_SIGNAL_INFO:
if (readbuf)
{
- if (core_gdbarch
- && gdbarch_core_xfer_siginfo_p (core_gdbarch))
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_xfer_siginfo_p (m_core_gdbarch))
{
- LONGEST l = gdbarch_core_xfer_siginfo (core_gdbarch, readbuf,
+ LONGEST l = gdbarch_core_xfer_siginfo (m_core_gdbarch, readbuf,
offset, len);
if (l >= 0)
return TARGET_XFER_E_IO;
default:
- return this->beneath->xfer_partial (object, annex, readbuf,
- writebuf, offset, len,
- xfered_len);
+ return this->beneath ()->xfer_partial (object, annex, readbuf,
+ writebuf, offset, len,
+ xfered_len);
}
}
/* Ask the current architecture what it knows about this core file.
That will be used, in turn, to pick a better architecture. This
wrapper could be avoided if targets got a chance to specialize
- core_ops. */
+ core_target. */
const struct target_desc *
core_target::read_description ()
{
- if (core_gdbarch && gdbarch_core_read_description_p (core_gdbarch))
+ if (m_core_gdbarch && gdbarch_core_read_description_p (m_core_gdbarch))
{
const struct target_desc *result;
- result = gdbarch_core_read_description (core_gdbarch, this, core_bfd);
+ result = gdbarch_core_read_description (m_core_gdbarch, this, core_bfd);
if (result != NULL)
return result;
}
- return this->beneath->read_description ();
+ return this->beneath ()->read_description ();
}
-const char *
+std::string
core_target::pid_to_str (ptid_t ptid)
{
- static char buf[64];
struct inferior *inf;
int pid;
/* The preferred way is to have a gdbarch/OS specific
implementation. */
- if (core_gdbarch
- && gdbarch_core_pid_to_str_p (core_gdbarch))
- return gdbarch_core_pid_to_str (core_gdbarch, ptid);
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_pid_to_str_p (m_core_gdbarch))
+ return gdbarch_core_pid_to_str (m_core_gdbarch, ptid);
/* Otherwise, if we don't have one, we'll just fallback to
"process", with normal_pid_to_str. */
/* Try the LWPID field first. */
- pid = ptid_get_lwp (ptid);
+ pid = ptid.lwp ();
if (pid != 0)
- return normal_pid_to_str (pid_to_ptid (pid));
+ return normal_pid_to_str (ptid_t (pid));
/* Otherwise, this isn't a "threaded" core -- use the PID field, but
only if it isn't a fake PID. */
return normal_pid_to_str (ptid);
/* No luck. We simply don't have a valid PID to print. */
- xsnprintf (buf, sizeof buf, "<main task>");
- return buf;
+ return "<main task>";
}
const char *
core_target::thread_name (struct thread_info *thr)
{
- if (core_gdbarch
- && gdbarch_core_thread_name_p (core_gdbarch))
- return gdbarch_core_thread_name (core_gdbarch, thr);
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_thread_name_p (m_core_gdbarch))
+ return gdbarch_core_thread_name (m_core_gdbarch, thr);
return NULL;
}
void
_initialize_corelow (void)
{
- if (the_core_target != NULL)
- internal_error (__FILE__, __LINE__,
- _("core target already exists (\"%s\")."),
- the_core_target->longname ());
- the_core_target = &core_ops;
-
add_target (core_target_info, core_target_open, filename_completer);
}
projects / deliverable / binutils-gdb.git / blobdiff