/* Functions that provide the mechanism to parse a syscall XML file
and get its values.
- Copyright (C) 2009-2017 Free Software Foundation, Inc.
+ Copyright (C) 2009-2020 Free Software Foundation, Inc.
This file is part of GDB.
s->name = NULL;
}
-void
-get_syscall_by_name (struct gdbarch *gdbarch, const char *syscall_name,
- struct syscall *s)
+bool
+get_syscalls_by_name (struct gdbarch *gdbarch, const char *syscall_name,
+ std::vector<int> *syscall_numbers)
{
syscall_warn_user ();
- s->number = UNKNOWN_SYSCALL;
- s->name = syscall_name;
+ return false;
}
const char **
return NULL;
}
-struct syscall *
-get_syscalls_by_group (struct gdbarch *gdbarch, const char *group)
+bool
+get_syscalls_by_group (struct gdbarch *gdbarch, const char *group,
+ std::vector<int> *syscall_numbers)
{
syscall_warn_user ();
- return NULL;
+ return false;
}
const char **
#else /* ! HAVE_LIBEXPAT */
/* Structure which describes a syscall. */
-typedef struct syscall_desc
+struct syscall_desc
{
+ syscall_desc (int number_, std::string name_, std::string alias_)
+ : number (number_), name (name_), alias (alias_)
+ {}
+
/* The syscall number. */
int number;
/* The syscall name. */
- char *name;
-} *syscall_desc_p;
-DEF_VEC_P(syscall_desc_p);
+ std::string name;
+
+ /* An optional alias. */
+
+ std::string alias;
+};
+
+typedef std::unique_ptr<syscall_desc> syscall_desc_up;
/* Structure of a syscall group. */
-typedef struct syscall_group_desc
+struct syscall_group_desc
{
+ syscall_group_desc (const std::string &name_)
+ : name (name_)
+ {}
+
/* The group name. */
- char *name;
+ std::string name;
- /* The syscalls that are part of the group. */
+ /* The syscalls that are part of the group. This is a non-owning
+ reference. */
+
+ std::vector<syscall_desc *> syscalls;
+};
- VEC(syscall_desc_p) *syscalls;
-} *syscall_group_desc_p;
-DEF_VEC_P(syscall_group_desc_p);
+typedef std::unique_ptr<syscall_group_desc> syscall_group_desc_up;
/* Structure that represents syscalls information. */
struct syscalls_info
{
/* The syscalls. */
- VEC(syscall_desc_p) *syscalls;
+ std::vector<syscall_desc_up> syscalls;
/* The syscall groups. */
- VEC(syscall_group_desc_p) *groups;
+ std::vector<syscall_group_desc_up> groups;
/* Variable that will hold the last known data-directory. This is
useful to know whether we should re-read the XML info for the
target. */
- char *my_gdb_datadir;
+ std::string my_gdb_datadir;
};
+typedef std::unique_ptr<syscalls_info> syscalls_info_up;
+
/* Callback data for syscall information parsing. */
struct syscall_parsing_data
{
struct syscalls_info *syscalls_info;
};
-static struct syscalls_info *
-allocate_syscalls_info (void)
-{
- return XCNEW (struct syscalls_info);
-}
-
-static void
-syscalls_info_free_syscalls_desc (struct syscall_desc *sd)
-{
- xfree (sd->name);
-}
-
-/* Free syscall_group_desc members but not the structure itself. */
-
-static void
-syscalls_info_free_syscall_group_desc (struct syscall_group_desc *sd)
-{
- VEC_free (syscall_desc_p, sd->syscalls);
- xfree (sd->name);
-}
-
-static void
-free_syscalls_info (void *arg)
-{
- struct syscalls_info *syscalls_info = (struct syscalls_info *) arg;
- struct syscall_desc *sysdesc;
- struct syscall_group_desc *groupdesc;
- int i;
-
- xfree (syscalls_info->my_gdb_datadir);
-
- if (syscalls_info->syscalls != NULL)
- {
- for (i = 0;
- VEC_iterate (syscall_desc_p, syscalls_info->syscalls, i, sysdesc);
- i++)
- syscalls_info_free_syscalls_desc (sysdesc);
- VEC_free (syscall_desc_p, syscalls_info->syscalls);
- }
-
- if (syscalls_info->groups != NULL)
- {
- for (i = 0;
- VEC_iterate (syscall_group_desc_p,
- syscalls_info->groups, i, groupdesc);
- i++)
- syscalls_info_free_syscall_group_desc (groupdesc);
-
- VEC_free (syscall_group_desc_p, syscalls_info->groups);
- }
-
- xfree (syscalls_info);
-}
-
-static struct cleanup *
-make_cleanup_free_syscalls_info (struct syscalls_info *syscalls_info)
-{
- return make_cleanup (free_syscalls_info, syscalls_info);
-}
-
/* Create a new syscall group. Return pointer to the
syscall_group_desc structure that represents the new group. */
syscall_group_create_syscall_group_desc (struct syscalls_info *syscalls_info,
const char *group)
{
- struct syscall_group_desc *groupdesc = XCNEW (struct syscall_group_desc);
+ syscall_group_desc *groupdesc = new syscall_group_desc (group);
- groupdesc->name = xstrdup (group);
-
- VEC_safe_push (syscall_group_desc_p, syscalls_info->groups, groupdesc);
+ syscalls_info->groups.emplace_back (groupdesc);
return groupdesc;
}
struct syscall_desc *syscall,
const char *group)
{
- struct syscall_group_desc *groupdesc = NULL;
- int i;
-
/* Search for an existing group. */
- for (i = 0;
- VEC_iterate (syscall_group_desc_p, syscalls_info->groups, i, groupdesc);
- i++)
+ std::vector<syscall_group_desc_up>::iterator it
+ = syscalls_info->groups.begin ();
+
+ for (; it != syscalls_info->groups.end (); it++)
{
- if (strcmp (groupdesc->name, group) == 0)
+ if ((*it)->name == group)
break;
}
- if (groupdesc == NULL)
+ syscall_group_desc *groupdesc;
+
+ if (it != syscalls_info->groups.end ())
+ groupdesc = it->get ();
+ else
{
/* No group was found with this name. We must create a new
one. */
group);
}
- VEC_safe_push (syscall_desc_p, groupdesc->syscalls, syscall);
+ groupdesc->syscalls.push_back (syscall);
}
static void
syscall_create_syscall_desc (struct syscalls_info *syscalls_info,
- const char *name, int number,
+ const char *name, int number, const char *alias,
char *groups)
{
- struct syscall_desc *sysdesc = XCNEW (struct syscall_desc);
- char *group;
+ syscall_desc *sysdesc = new syscall_desc (number, name,
+ alias != NULL ? alias : "");
- sysdesc->name = xstrdup (name);
- sysdesc->number = number;
-
- VEC_safe_push (syscall_desc_p, syscalls_info->syscalls, sysdesc);
+ syscalls_info->syscalls.emplace_back (sysdesc);
/* Add syscall to its groups. */
if (groups != NULL)
{
- for (group = strtok (groups, ",");
+ char *saveptr;
+ for (char *group = strtok_r (groups, ",", &saveptr);
group != NULL;
- group = strtok (NULL, ","))
+ group = strtok_r (NULL, ",", &saveptr))
syscall_group_add_syscall (syscalls_info, sysdesc, group);
}
}
static void
syscall_start_syscall (struct gdb_xml_parser *parser,
const struct gdb_xml_element *element,
- void *user_data, VEC(gdb_xml_value_s) *attributes)
+ void *user_data,
+ std::vector<gdb_xml_value> &attributes)
{
struct syscall_parsing_data *data = (struct syscall_parsing_data *) user_data;
- struct gdb_xml_value *attrs = VEC_address (gdb_xml_value_s, attributes);
- int len, i;
/* syscall info. */
char *name = NULL;
int number = 0;
+ char *alias = NULL;
char *groups = NULL;
- len = VEC_length (gdb_xml_value_s, attributes);
-
- for (i = 0; i < len; i++)
+ for (const gdb_xml_value &attr : attributes)
{
- if (strcmp (attrs[i].name, "name") == 0)
- name = (char *) attrs[i].value;
- else if (strcmp (attrs[i].name, "number") == 0)
- number = * (ULONGEST *) attrs[i].value;
- else if (strcmp (attrs[i].name, "groups") == 0)
- groups = (char *) attrs[i].value;
+ if (strcmp (attr.name, "name") == 0)
+ name = (char *) attr.value.get ();
+ else if (strcmp (attr.name, "number") == 0)
+ number = * (ULONGEST *) attr.value.get ();
+ else if (strcmp (attr.name, "alias") == 0)
+ alias = (char *) attr.value.get ();
+ else if (strcmp (attr.name, "groups") == 0)
+ groups = (char *) attr.value.get ();
else
internal_error (__FILE__, __LINE__,
- _("Unknown attribute name '%s'."), attrs[i].name);
+ _("Unknown attribute name '%s'."), attr.name);
}
gdb_assert (name);
- syscall_create_syscall_desc (data->syscalls_info, name, number, groups);
+ syscall_create_syscall_desc (data->syscalls_info, name, number, alias,
+ groups);
}
static const struct gdb_xml_attribute syscall_attr[] = {
{ "number", GDB_XML_AF_NONE, gdb_xml_parse_attr_ulongest, NULL },
{ "name", GDB_XML_AF_NONE, NULL, NULL },
+ { "alias", GDB_XML_AF_OPTIONAL, NULL, NULL },
{ "groups", GDB_XML_AF_OPTIONAL, NULL, NULL },
{ NULL, GDB_XML_AF_NONE, NULL, NULL }
};
syscall_parse_xml (const char *document, xml_fetch_another fetcher,
void *fetcher_baton)
{
- struct cleanup *result_cleanup;
struct syscall_parsing_data data;
+ syscalls_info_up sysinfo (new syscalls_info ());
- data.syscalls_info = allocate_syscalls_info ();
- result_cleanup = make_cleanup_free_syscalls_info (data.syscalls_info);
+ data.syscalls_info = sysinfo.get ();
if (gdb_xml_parse_quick (_("syscalls info"), NULL,
syselements, document, &data) == 0)
{
/* Parsed successfully. */
- discard_cleanups (result_cleanup);
- return data.syscalls_info;
+ return sysinfo.release ();
}
else
{
warning (_("Could not load XML syscalls info; ignoring"));
- do_cleanups (result_cleanup);
return NULL;
}
}
static struct syscalls_info *
xml_init_syscalls_info (const char *filename)
{
- char *full_file;
- struct syscalls_info *syscalls_info;
- struct cleanup *back_to;
-
- full_file = xml_fetch_content_from_file (filename, gdb_datadir);
- if (full_file == NULL)
+ gdb::optional<gdb::char_vector> full_file
+ = xml_fetch_content_from_file (filename,
+ const_cast<char *>(gdb_datadir.c_str ()));
+ if (!full_file)
return NULL;
- back_to = make_cleanup (xfree, full_file);
-
- syscalls_info = syscall_parse_xml (full_file,
- xml_fetch_content_from_file,
- (void *) ldirname (filename).c_str ());
- do_cleanups (back_to);
-
- return syscalls_info;
+ return syscall_parse_xml (full_file->data (),
+ xml_fetch_content_from_file,
+ (void *) ldirname (filename).c_str ());
}
/* Initializes the syscalls_info structure according to the
const char *xml_syscall_file = gdbarch_xml_syscall_file (gdbarch);
/* Should we re-read the XML info for this target? */
- if (syscalls_info != NULL && syscalls_info->my_gdb_datadir != NULL
- && filename_cmp (syscalls_info->my_gdb_datadir, gdb_datadir) != 0)
+ if (syscalls_info != NULL && !syscalls_info->my_gdb_datadir.empty ()
+ && filename_cmp (syscalls_info->my_gdb_datadir.c_str (),
+ gdb_datadir.c_str ()) != 0)
{
/* The data-directory changed from the last time we used it.
It means that we have to re-read the XML info. */
- free_syscalls_info (syscalls_info);
+ delete syscalls_info;
syscalls_info = NULL;
set_gdbarch_syscalls_info (gdbarch, NULL);
}
gdbarch->syscalls_info anyway, in order to store information
about our attempt. */
if (syscalls_info == NULL)
- syscalls_info = allocate_syscalls_info ();
+ syscalls_info = new struct syscalls_info ();
- if (syscalls_info->syscalls == NULL)
+ if (syscalls_info->syscalls.empty ())
{
if (xml_syscall_file != NULL)
warning (_("Could not load the syscall XML file `%s/%s'."),
- gdb_datadir, xml_syscall_file);
+ gdb_datadir.c_str (), xml_syscall_file);
else
warning (_("There is no XML file to open."));
}
/* Saving the data-directory used to read this XML info. */
- syscalls_info->my_gdb_datadir = xstrdup (gdb_datadir);
+ syscalls_info->my_gdb_datadir.assign (gdb_datadir);
set_gdbarch_syscalls_info (gdbarch, syscalls_info);
}
syscall_group_get_group_by_name (const struct syscalls_info *syscalls_info,
const char *group)
{
- struct syscall_group_desc *groupdesc;
- int i;
-
if (syscalls_info == NULL)
return NULL;
if (group == NULL)
return NULL;
- /* Search for existing group. */
- for (i = 0;
- VEC_iterate (syscall_group_desc_p, syscalls_info->groups, i, groupdesc);
- i++)
+ /* Search for existing group. */
+ for (const syscall_group_desc_up &groupdesc : syscalls_info->groups)
{
- if (strcmp (groupdesc->name, group) == 0)
- return groupdesc;
+ if (groupdesc->name == group)
+ return groupdesc.get ();
}
return NULL;
}
-static int
-xml_get_syscall_number (struct gdbarch *gdbarch,
- const char *syscall_name)
+static bool
+xml_get_syscalls_by_name (struct gdbarch *gdbarch, const char *syscall_name,
+ std::vector<int> *syscall_numbers)
{
struct syscalls_info *syscalls_info = gdbarch_syscalls_info (gdbarch);
- struct syscall_desc *sysdesc;
- int i;
-
- if (syscalls_info == NULL
- || syscall_name == NULL)
- return UNKNOWN_SYSCALL;
- for (i = 0;
- VEC_iterate(syscall_desc_p, syscalls_info->syscalls, i, sysdesc);
- i++)
- if (strcmp (sysdesc->name, syscall_name) == 0)
- return sysdesc->number;
+ bool found = false;
+ if (syscalls_info != NULL && syscall_name != NULL && syscall_numbers != NULL)
+ for (const syscall_desc_up &sysdesc : syscalls_info->syscalls)
+ if (sysdesc->name == syscall_name || sysdesc->alias == syscall_name)
+ {
+ syscall_numbers->push_back (sysdesc->number);
+ found = true;
+ }
- return UNKNOWN_SYSCALL;
+ return found;
}
static const char *
int syscall_number)
{
struct syscalls_info *syscalls_info = gdbarch_syscalls_info (gdbarch);
- struct syscall_desc *sysdesc;
- int i;
if (syscalls_info == NULL
|| syscall_number < 0)
return NULL;
- for (i = 0;
- VEC_iterate(syscall_desc_p, syscalls_info->syscalls, i, sysdesc);
- i++)
+ for (const syscall_desc_up &sysdesc : syscalls_info->syscalls)
if (sysdesc->number == syscall_number)
- return sysdesc->name;
+ return sysdesc->name.c_str ();
return NULL;
}
xml_list_of_syscalls (struct gdbarch *gdbarch)
{
struct syscalls_info *syscalls_info = gdbarch_syscalls_info (gdbarch);
- struct syscall_desc *sysdesc;
- const char **names = NULL;
- int nsyscalls;
- int i;
if (syscalls_info == NULL)
return NULL;
- nsyscalls = VEC_length (syscall_desc_p, syscalls_info->syscalls);
- names = XNEWVEC (const char *, nsyscalls + 1);
+ int nsyscalls = syscalls_info->syscalls.size ();
+ const char **names = XNEWVEC (const char *, nsyscalls + 1);
- for (i = 0;
- VEC_iterate (syscall_desc_p, syscalls_info->syscalls, i, sysdesc);
- i++)
- names[i] = sysdesc->name;
+ int i;
+ for (i = 0; i < syscalls_info->syscalls.size (); i++)
+ names[i] = syscalls_info->syscalls[i]->name.c_str ();
names[i] = NULL;
}
/* Iterate over the syscall_group_desc element to return a list of
- syscalls that are part of the given group, terminated by an empty
- element. If the syscall group doesn't exist, return NULL. */
+ syscalls that are part of the given group. If the syscall group
+ doesn't exist, return false. */
-static struct syscall *
-xml_list_syscalls_by_group (struct gdbarch *gdbarch, const char *group)
+static bool
+xml_list_syscalls_by_group (struct gdbarch *gdbarch, const char *group,
+ std::vector<int> *syscalls)
{
struct syscalls_info *syscalls_info = gdbarch_syscalls_info (gdbarch);
struct syscall_group_desc *groupdesc;
- struct syscall_desc *sysdesc;
- struct syscall *syscalls = NULL;
- int nsyscalls;
- int i;
- if (syscalls_info == NULL)
- return NULL;
+ if (syscalls_info == NULL || syscalls == NULL)
+ return false;
groupdesc = syscall_group_get_group_by_name (syscalls_info, group);
if (groupdesc == NULL)
- return NULL;
-
- nsyscalls = VEC_length (syscall_desc_p, groupdesc->syscalls);
- syscalls = (struct syscall*) xmalloc ((nsyscalls + 1)
- * sizeof (struct syscall));
-
- for (i = 0;
- VEC_iterate (syscall_desc_p, groupdesc->syscalls, i, sysdesc);
- i++)
- {
- syscalls[i].name = sysdesc->name;
- syscalls[i].number = sysdesc->number;
- }
+ return false;
- /* Add final element marker. */
- syscalls[i].name = NULL;
- syscalls[i].number = 0;
+ for (const syscall_desc *sysdesc : groupdesc->syscalls)
+ syscalls->push_back (sysdesc->number);
- return syscalls;
+ return true;
}
/* Return a NULL terminated list of syscall groups or an empty list, if
xml_list_of_groups (struct gdbarch *gdbarch)
{
struct syscalls_info *syscalls_info = gdbarch_syscalls_info (gdbarch);
- struct syscall_group_desc *groupdesc;
const char **names = NULL;
- int i;
int ngroups;
+ int i;
if (syscalls_info == NULL)
return NULL;
- ngroups = VEC_length (syscall_group_desc_p, syscalls_info->groups);
+ ngroups = syscalls_info->groups.size ();
names = (const char**) xmalloc ((ngroups + 1) * sizeof (char *));
- for (i = 0;
- VEC_iterate (syscall_group_desc_p, syscalls_info->groups, i, groupdesc);
- i++)
- names[i] = groupdesc->name;
+ for (i = 0; i < syscalls_info->groups.size (); i++)
+ names[i] = syscalls_info->groups[i]->name.c_str ();
names[i] = NULL;
s->name = xml_get_syscall_name (gdbarch, syscall_number);
}
-void
-get_syscall_by_name (struct gdbarch *gdbarch,
- const char *syscall_name, struct syscall *s)
+bool
+get_syscalls_by_name (struct gdbarch *gdbarch, const char *syscall_name,
+ std::vector<int> *syscall_numbers)
{
init_syscalls_info (gdbarch);
- s->number = xml_get_syscall_number (gdbarch, syscall_name);
- s->name = syscall_name;
+ return xml_get_syscalls_by_name (gdbarch, syscall_name, syscall_numbers);
}
const char **
/* See comment in xml-syscall.h. */
-struct syscall *
-get_syscalls_by_group (struct gdbarch *gdbarch, const char *group)
+bool
+get_syscalls_by_group (struct gdbarch *gdbarch, const char *group,
+ std::vector<int> *syscall_numbers)
{
init_syscalls_info (gdbarch);
- return xml_list_syscalls_by_group (gdbarch, group);
+ return xml_list_syscalls_by_group (gdbarch, group, syscall_numbers);
}
/* See comment in xml-syscall.h. */
projects / deliverable / binutils-gdb.git / blobdiff