lib: remove unused _NO_SINK graph status

[babeltrace.git] / lib / graph / graph.c

diff --git a/lib/graph/graph.c b/lib/graph/graph.c
index 29ebee34d545a49f7bfacb52c558233c05c375ce..219ca277ae6a197ea4d2e604cd9730db35745ac4 100644 (file)
--- a/lib/graph/graph.c
+++ b/lib/graph/graph.c
@@ -82,6 +82,9 @@ struct bt_graph_listener_ports_connected {
        do {                                                            \
                size_t i;                                               \
                                                                        \
+               if (!_listeners) {                                      \
+                       break;                                          \
+               }                                                       \
                for (i = 0; i < (_listeners)->len; i++) {               \
                        _type *listener =                               \
                                &g_array_index((_listeners), _type, i); \
@@ -688,7 +691,7 @@ enum bt_graph_status bt_graph_consume(struct bt_graph *graph)
                "Graph is in a faulty state: %!+g", graph);
        bt_graph_set_can_consume(graph, false);
        status = bt_graph_configure(graph);
-       if (status) {
+       if (unlikely(status)) {
                /* bt_graph_configure() logs errors */
                goto end;
        }
@@ -712,7 +715,7 @@ enum bt_graph_status bt_graph_run(struct bt_graph *graph)
                "Graph is in a faulty state: %!+g", graph);
        bt_graph_set_can_consume(graph, false);
        status = bt_graph_configure(graph);
-       if (status) {
+       if (unlikely(status)) {
                /* bt_graph_configure() logs errors */
                goto end;
        }
@@ -749,8 +752,6 @@ enum bt_graph_status bt_graph_run(struct bt_graph *graph)
                        if (graph->sinks_to_consume->length > 1) {
                                status = BT_GRAPH_STATUS_OK;
                        }
-               } else if (status == BT_GRAPH_STATUS_NO_SINK) {
-                       goto end;
                }
        } while (status == BT_GRAPH_STATUS_OK);
 
@@ -1295,6 +1296,7 @@ enum bt_graph_status add_component_with_init_method_data(
         */
        g_ptr_array_add(graph->components, component);
        bt_component_set_graph(component, graph);
+       bt_value_freeze(params);
 
        if (init_method) {
                BT_LOGD_STR("Calling user's initialization method.");