Fix: add missing goto end on error

[babeltrace.git] / plugins / lttng-utils / plugin.c

diff --git a/plugins/lttng-utils/plugin.c b/plugins/lttng-utils/plugin.c
index 9436ee34f7a2edd2fb2572b0a889cb726961c19b..58956981c8ef6450ff8f29a3b35cc8ca3453ed3a 100644 (file)
--- a/plugins/lttng-utils/plugin.c
+++ b/plugins/lttng-utils/plugin.c
@@ -26,6 +26,9 @@
  * SOFTWARE.
  */
 
+#define BT_LOG_TAG "PLUGIN-CTF-LTTNG-UTILS-DEBUG-INFO-FLT"
+#include "logging.h"
+
 #include <babeltrace/graph/notification-iterator.h>
 #include <babeltrace/graph/private-notification-iterator.h>
 #include <babeltrace/graph/connection.h>
@@ -219,14 +222,10 @@ struct bt_notification *handle_notification(FILE *err,
                bt_put(writer_stream);
                break;
        }
-       case BT_NOTIFICATION_TYPE_INACTIVITY:
-       {
+       default:
                new_notification = bt_get(notification);
                break;
        }
-       default:
-               puts("Unhandled notification type");
-       }
 
 end:
        return new_notification;
@@ -292,14 +291,6 @@ enum bt_notification_iterator_status debug_info_iterator_init(
                bt_private_notification_iterator_get_private_component(iterator);
        struct debug_info_iterator *it_data = g_new0(struct debug_info_iterator, 1);
        struct bt_private_port *input_port;
-       static const enum bt_notification_type notif_types[] = {
-               BT_NOTIFICATION_TYPE_EVENT,
-               BT_NOTIFICATION_TYPE_STREAM_BEGIN,
-               BT_NOTIFICATION_TYPE_STREAM_END,
-               BT_NOTIFICATION_TYPE_PACKET_BEGIN,
-               BT_NOTIFICATION_TYPE_PACKET_END,
-               BT_NOTIFICATION_TYPE_SENTINEL,
-       };
 
        if (!it_data) {
                ret = BT_NOTIFICATION_ITERATOR_STATUS_NOMEM;
@@ -321,7 +312,7 @@ enum bt_notification_iterator_status debug_info_iterator_init(
        }
 
        conn_status = bt_private_connection_create_notification_iterator(
-                       connection, notif_types, &it_data->input_iterator);
+                       connection, NULL, &it_data->input_iterator);
        if (conn_status != BT_CONNECTION_STATUS_OK) {
                ret = BT_NOTIFICATION_ITERATOR_STATUS_ERROR;
                goto end;
@@ -362,8 +353,8 @@ enum bt_component_status init_from_params(
                value_ret = bt_value_string_get(value, &tmp);
                if (value_ret) {
                        ret = BT_COMPONENT_STATUS_INVALID;
-                       printf_error("Failed to retrieve debug-info-field-name value. "
-                                       "Expecting a string");
+                       BT_LOGE_STR("Failed to retrieve debug-info-field-name value. "
+                                       "Expecting a string.");
                }
                strcpy(debug_info_component->arg_debug_info_field_name, tmp);
                bt_put(value);
@@ -372,7 +363,8 @@ enum bt_component_status init_from_params(
                        malloc(strlen("debug_info") + 1);
                if (!debug_info_component->arg_debug_info_field_name) {
                        ret = BT_COMPONENT_STATUS_NOMEM;
-                       printf_error();
+                       BT_LOGE_STR("Missing field name.");
+                       goto end;
                }
                sprintf(debug_info_component->arg_debug_info_field_name,
                                "debug_info");
@@ -389,8 +381,8 @@ enum bt_component_status init_from_params(
                                &debug_info_component->arg_debug_dir);
                if (value_ret) {
                        ret = BT_COMPONENT_STATUS_INVALID;
-                       printf_error("Failed to retrieve debug-dir value. "
-                                       "Expecting a string");
+                       BT_LOGE_STR("Failed to retrieve debug-dir value. "
+                                       "Expecting a string.");
                }
        }
        bt_put(value);
@@ -406,8 +398,8 @@ enum bt_component_status init_from_params(
                                &debug_info_component->arg_target_prefix);
                if (value_ret) {
                        ret = BT_COMPONENT_STATUS_INVALID;
-                       printf_error("Failed to retrieve target-prefix value. "
-                                       "Expecting a string");
+                       BT_LOGE_STR("Failed to retrieve target-prefix value. "
+                                       "Expecting a string.");
                }
        }
        bt_put(value);
@@ -424,8 +416,8 @@ enum bt_component_status init_from_params(
                                &bool_val);
                if (value_ret) {
                        ret = BT_COMPONENT_STATUS_INVALID;
-                       printf_error("Failed to retrieve full-path value. "
-                                       "Expecting a boolean");
+                       BT_LOGE_STR("Failed to retrieve full-path value. "
+                                       "Expecting a boolean.");
                }
 
                debug_info_component->arg_full_path = bool_val;
@@ -476,6 +468,10 @@ error:
        return ret;
 }
 
+#ifndef BT_BUILT_IN_PLUGINS
+BT_PLUGIN_MODULE();
+#endif
+
 /* Initialize plug-in entry points. */
 BT_PLUGIN_WITH_ID(lttng_utils, "lttng-utils");
 BT_PLUGIN_DESCRIPTION_WITH_ID(lttng_utils, "LTTng utilities");