uint64_t i, sc_count;
const bt_clock_class *cc = NULL;
const bt_stream_class *sc;
- bool ret = true;
sc_count = bt_trace_class_get_stream_class_count(tc);
for (i = 0; i < sc_count; i++) {
cc = bt_stream_class_borrow_default_clock_class_const(sc);
if (!cc) {
- ret = false;
BT_CPPLOGE_APPEND_CAUSE_SPEC(logger,
"Stream class doesn't have a default clock class: "
"sc-id={}, sc-name=\"{}\"",
bt_stream_class_get_id(sc), bt_stream_class_get_name(sc));
- goto end;
+ return false;
}
}
-end:
- return ret;
+ return true;
}
/*
* Iterate over the stream classes and returns the first clock class
cc = bt_stream_class_borrow_default_clock_class_const(sc);
if (cc) {
- goto end;
+ return cc;
}
}
-end:
- BT_ASSERT_DBG(cc);
- return cc;
+
+ bt_common_abort();
}
enum lttng_live_iterator_status lttng_live_metadata_update(struct lttng_live_trace *trace)
bool keep_receiving;
bt2c::FileUP fp;
enum ctf_metadata_decoder_status decoder_status;
- enum lttng_live_iterator_status status = LTTNG_LIVE_ITERATOR_STATUS_OK;
enum lttng_live_get_one_metadata_status metadata_status;
BT_CPPLOGD_SPEC(metadata->logger, "Updating metadata for trace: session-id={}, trace-id={}",
* metadata this indicates that we will never receive
* any metadata.
*/
- status = LTTNG_LIVE_ITERATOR_STATUS_END;
+ return LTTNG_LIVE_ITERATOR_STATUS_END;
} else if (session->new_streams_needed) {
- status = LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
+ return LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
} else {
session->new_streams_needed = true;
- status = LTTNG_LIVE_ITERATOR_STATUS_CONTINUE;
+ return LTTNG_LIVE_ITERATOR_STATUS_CONTINUE;
}
- goto end;
}
if (trace->metadata_stream_state != LTTNG_LIVE_METADATA_STREAM_STATE_NEEDED) {
- goto end;
+ return LTTNG_LIVE_ITERATOR_STATUS_OK;
}
keep_receiving = true;
BT_CPPLOGE_APPEND_CAUSE_SPEC(metadata->logger,
"Error getting one trace metadata packet: trace-id={}",
trace->id);
- goto error;
+ return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
default:
bt_common_abort();
}
if (metadataBuf.empty()) {
if (!trace->trace) {
- status = LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
- goto end;
+ return LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
}
/* The relay sent zero bytes of metadata. */
trace->metadata_stream_state = LTTNG_LIVE_METADATA_STREAM_STATE_NOT_NEEDED;
- goto end;
+ return LTTNG_LIVE_ITERATOR_STATUS_OK;
}
/*
if (!fp) {
if (errno == EINTR && lttng_live_graph_is_canceled(session->lttng_live_msg_iter)) {
session->lttng_live_msg_iter->was_interrupted = true;
- status = LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
+ return LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
} else {
BT_CPPLOGE_ERRNO_APPEND_CAUSE_SPEC(metadata->logger,
"Cannot memory-open metadata buffer", ".");
- status = LTTNG_LIVE_ITERATOR_STATUS_ERROR;
+ return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
}
- goto end;
}
/*
trace->trace = trace->trace_class->instantiate();
if (!trace->trace) {
BT_CPPLOGE_APPEND_CAUSE_SPEC(metadata->logger, "Failed to create bt_trace");
- goto error;
+ return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
}
ctf_trace_class_configure_ir_trace(tc, *trace->trace);
if (!stream_classes_all_have_default_clock_class(trace->trace_class->libObjPtr(),
metadata->logger)) {
/* Error logged in function. */
- goto error;
+ return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
}
trace->clock_class = borrow_any_clock_class(trace->trace_class->libObjPtr());
}
/* The metadata was updated successfully. */
trace->metadata_stream_state = LTTNG_LIVE_METADATA_STREAM_STATE_NOT_NEEDED;
- break;
+ return LTTNG_LIVE_ITERATOR_STATUS_OK;
default:
- goto error;
+ return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
}
-
- goto end;
-
-error:
- status = LTTNG_LIVE_ITERATOR_STATUS_ERROR;
-end:
- return status;
}
int lttng_live_metadata_create_stream(struct lttng_live_session *session, uint64_t ctf_trace_id,