tmf: Enable address mapping config action for all traces
[deliverable/tracecompass.git] / tmf / org.eclipse.tracecompass.tmf.ui / src / org / eclipse / tracecompass / tmf / ui / views / callstack / CallStackView.java
index f218d32a574977ca05d8e33b8be594c831a28d45..3bd838adef6391b17c84fbe2292a4e5584411115 100644 (file)
@@ -21,6 +21,7 @@ import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.function.Consumer;
 
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jdt.annotation.NonNull;
@@ -65,8 +66,8 @@ import org.eclipse.tracecompass.tmf.core.signal.TmfTraceSelectedSignal;
 import org.eclipse.tracecompass.tmf.core.signal.TmfWindowRangeUpdatedSignal;
 import org.eclipse.tracecompass.tmf.core.timestamp.ITmfTimestamp;
 import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimeRange;
-import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestampDelta;
 import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestamp;
+import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestampDelta;
 import org.eclipse.tracecompass.tmf.core.trace.ITmfTrace;
 import org.eclipse.tracecompass.tmf.core.trace.TmfTraceUtils;
 import org.eclipse.tracecompass.tmf.ui.editors.ITmfTraceEditor;
@@ -121,6 +122,7 @@ public class CallStackView extends AbstractTimeGraphView {
     // Fraction of a function duration to be added as spacing
     private static final double SPACING_RATIO = 0.01;
 
+    private static final Image PROCESS_IMAGE = Activator.getDefault().getImageFromPath("icons/obj16/process_obj.gif"); //$NON-NLS-1$
     private static final Image THREAD_IMAGE = Activator.getDefault().getImageFromPath("icons/obj16/thread_obj.gif"); //$NON-NLS-1$
     private static final Image STACKFRAME_IMAGE = Activator.getDefault().getImageFromPath("icons/obj16/stckframe_obj.gif"); //$NON-NLS-1$
 
@@ -172,6 +174,10 @@ public class CallStackView extends AbstractTimeGraphView {
     // a view
     private TmfWindowRangeUpdatedSignal fSavedRangeSyncSignal;
 
+    // When set to true, syncToTime() will select the first call stack entry
+    // whose current state start time exactly matches the sync time.
+    private boolean fSyncSelection = false;
+
     // ------------------------------------------------------------------------
     // Classes
     // ------------------------------------------------------------------------
@@ -196,10 +202,6 @@ public class CallStackView extends AbstractTimeGraphView {
             fProcessId = processId;
         }
 
-        public int getProcessId() {
-            return fProcessId;
-        }
-
         @Override
         public boolean hasTimeEvents() {
             return false;
@@ -207,18 +209,12 @@ public class CallStackView extends AbstractTimeGraphView {
     }
 
     private static class ThreadEntry extends TimeGraphEntry {
-        // The call stack quark
-        private final int fCallStackQuark;
-        // The state system from which this entry comes
-        private final ITmfStateSystem fSS;
         // The thread id
         private final long fThreadId;
 
-        public ThreadEntry(ITmfStateSystem ss, String name, long threadId, int callStackQuark, long startTime, long endTime) {
+        public ThreadEntry(String name, long threadId, long startTime, long endTime) {
             super(name, startTime, endTime);
-            fCallStackQuark = callStackQuark;
             fThreadId = threadId;
-            fSS = ss;
         }
 
         @Override
@@ -226,18 +222,9 @@ public class CallStackView extends AbstractTimeGraphView {
             return false;
         }
 
-        public int getCallStackQuark() {
-            return fCallStackQuark;
-        }
-
         public long getThreadId() {
             return fThreadId;
         }
-
-        @Nullable
-        public ITmfStateSystem getStateSystem() {
-            return fSS;
-        }
     }
 
     private class CallStackComparator implements Comparator<ITimeGraphEntry> {
@@ -275,10 +262,13 @@ public class CallStackView extends AbstractTimeGraphView {
 
         @Override
         public int compare(ITimeGraphEntry o1, ITimeGraphEntry o2) {
-            ThreadEntry t1 = (ThreadEntry) o1;
-            ThreadEntry t2 = (ThreadEntry) o2;
-            return reverse ? Long.compare(t2.getThreadId(), t1.getThreadId()) :
+            if (o1 instanceof ThreadEntry && o2 instanceof ThreadEntry) {
+                ThreadEntry t1 = (ThreadEntry) o1;
+                ThreadEntry t2 = (ThreadEntry) o2;
+                return reverse ? Long.compare(t2.getThreadId(), t1.getThreadId()) :
                     Long.compare(t1.getThreadId(), t2.getThreadId());
+            }
+            return 0;
         }
     }
 
@@ -301,7 +291,9 @@ public class CallStackView extends AbstractTimeGraphView {
         @Override
         public Image getColumnImage(Object element, int columnIndex) {
             if (columnIndex == 0) {
-                if (element instanceof ThreadEntry) {
+                if (element instanceof ProcessEntry) {
+                    return PROCESS_IMAGE;
+                } else if (element instanceof ThreadEntry) {
                     return THREAD_IMAGE;
                 } else if (element instanceof CallStackEntry) {
                     CallStackEntry entry = (CallStackEntry) element;
@@ -478,37 +470,10 @@ public class CallStackView extends AbstractTimeGraphView {
                 } else {
                     getTimeGraphViewer().setSelectionRange(beginTime, endTime, true);
                 }
+                fSyncSelection = true;
                 synchingToTime(beginTime);
+                fSyncSelection = false;
                 startZoomThread(getTimeGraphViewer().getTime0(), getTimeGraphViewer().getTime1());
-                List<TimeGraphEntry> traceEntries = getEntryList(getTrace());
-                if (traceEntries == null) {
-                    return;
-                }
-                TimeGraphViewer viewer = getTimeGraphViewer();
-                for (TimeGraphEntry traceEntry : traceEntries) {
-                    for (ITimeGraphEntry processEntry : traceEntry.getChildren()) {
-                        for (ITimeGraphEntry aThreadEntry : processEntry.getChildren()) {
-                            ThreadEntry threadEntry = (ThreadEntry) aThreadEntry;
-                            ITmfStateSystem ss = threadEntry.getStateSystem();
-                            if (ss == null || beginTime < ss.getStartTime() || beginTime > ss.getCurrentEndTime()) {
-                                continue;
-                            }
-                            try {
-                                int quark = threadEntry.getCallStackQuark();
-                                ITmfStateInterval stackInterval = ss.querySingleState(beginTime, quark);
-                                if (beginTime == stackInterval.getStartTime()) {
-                                    int stackLevel = stackInterval.getStateValue().unboxInt();
-                                    ITimeGraphEntry selectedEntry = threadEntry.getChildren().get(Math.max(0, stackLevel - 1));
-                                    getTimeGraphCombo().setSelection(selectedEntry);
-                                    viewer.getTimeGraphControl().fireSelectionChanged();
-                                    break;
-                                }
-                            } catch (AttributeNotFoundException | TimeRangeException | StateSystemDisposedException | StateValueTypeException e) {
-                                Activator.getDefault().logError("Error querying state system", e); //$NON-NLS-1$
-                            }
-                        }
-                    }
-                }
             }
         });
 
@@ -561,6 +526,20 @@ public class CallStackView extends AbstractTimeGraphView {
         if (monitor.isCanceled()) {
             return;
         }
+
+        /*
+         * Load the symbol provider for the current trace, even if it does not
+         * provide a call stack analysis module. See
+         * https://bugs.eclipse.org/bugs/show_bug.cgi?id=494212
+         */
+        ISymbolProvider provider = fSymbolProviders.get(trace);
+        if (provider == null) {
+            provider = SymbolProviderManager.getInstance().getSymbolProvider(trace);
+            provider.loadConfiguration(null);
+            fSymbolProviders.put(trace, provider);
+        }
+
+        /* Continue with the call stack view specific operations */
         AbstractCallStackAnalysis module = getCallStackModule(trace);
         if (module == null) {
             addUnavailableEntry(trace, parentTrace);
@@ -592,16 +571,6 @@ public class CallStackView extends AbstractTimeGraphView {
                 continue;
             }
 
-            ISymbolProvider provider = fSymbolProviders.get(trace);
-            if (provider == null) {
-                provider = SymbolProviderManager.getInstance().getSymbolProvider(trace);
-                provider.loadConfiguration(monitor);
-                fSymbolProviders.put(trace, provider);
-            }
-
-            getConfigureSymbolsAction().setEnabled(true);
-
-
             TraceEntry traceEntry = traceEntryMap.get(trace);
             if (traceEntry == null) {
                 traceEntry = new TraceEntry(trace.getName(), start, end + 1);
@@ -612,38 +581,55 @@ public class CallStackView extends AbstractTimeGraphView {
                 traceEntry.updateEndTime(end);
             }
 
-            List<Integer> processQuarks = ss.getQuarks(module.getProcessesPattern());
-            for (Integer processQuark : processQuarks) {
-
-                /* Create the entry for the process */
-                ProcessEntry processEntry = processEntryMap.get(processQuark);
-                if (processEntry == null) {
-                    String name = ss.getAttributeName(processQuark.intValue());
-                    /* The attribute name should already be parseable to integer */
-                    int processId = Integer.parseInt(name);
-                    processEntry = new ProcessEntry(name, processId, start, end);
-                    processEntryMap.put(processQuark, processEntry);
-                    traceEntry.addChild(processEntry);
-                } else {
-                    processEntry.updateEndTime(end);
-                  }
+            try {
+                List<ITmfStateInterval> endStates = ss.queryFullState(ss.getCurrentEndTime());
 
-                /* Create the threads under the process */
-                try {
-                    List<Integer> threadQuarks = ss.getSubAttributes(processQuark, false, module.getThreadsForProcessPattern());
+                List<Integer> processQuarks = ss.getQuarks(module.getProcessesPattern());
+                for (int processQuark : processQuarks) {
+
+                    /*
+                     * Default to trace entry, overwrite if a process entry exists.
+                     */
+                    TimeGraphEntry threadParent = traceEntry;
+                    int processId = -1;
+                    if (processQuark != ITmfStateSystem.ROOT_ATTRIBUTE) {
+                        /* Create the entry for the process */
+                        ProcessEntry processEntry = processEntryMap.get(processQuark);
+                        if (processEntry == null) {
+                            String processName = ss.getAttributeName(processQuark);
+                            ITmfStateValue processStateValue = endStates.get(processQuark).getStateValue();
+                            if (processStateValue.getType() == Type.INTEGER) {
+                                processId = processStateValue.unboxInt();
+                            } else {
+                                try {
+                                    processId = Integer.parseInt(processName);
+                                } catch (NumberFormatException e) {
+                                    /* use default processId */
+                                }
+                            }
+                            processEntry = new ProcessEntry(processName, processId, start, end);
+                            processEntryMap.put(processQuark, processEntry);
+                            traceEntry.addChild(processEntry);
+                        } else {
+                            processEntry.updateEndTime(end);
+                        }
+                        /* The parent of the thread entries will be a process */
+                        threadParent = processEntry;
+                    }
+
+                    /* Create the threads under the process */
+                    List<Integer> threadQuarks = ss.getQuarks(processQuark, module.getThreadsPattern());
 
                     /*
                      * Only query startStates if necessary (threadEntry == null)
                      */
                     List<ITmfStateInterval> startStates = null;
-                    List<ITmfStateInterval> endStates = ss.queryFullState(ss.getCurrentEndTime());
-                    for (int i = 0; i < threadQuarks.size(); i++) {
+                    for (int threadQuark : threadQuarks) {
                         if (monitor.isCanceled()) {
                             return;
                         }
-                        int threadQuark = threadQuarks.get(i);
 
-                        String[] callStackPath = module.getCallStackPathForThread();
+                        String[] callStackPath = module.getCallStackPath();
                         int callStackQuark = ss.getQuarkRelative(threadQuark, callStackPath);
                         String threadName = ss.getAttributeName(threadQuark);
                         long threadEnd = end + 1;
@@ -651,38 +637,55 @@ public class CallStackView extends AbstractTimeGraphView {
                         if (endInterval.getStateValue().isNull() && endInterval.getStartTime() != ss.getStartTime()) {
                             threadEnd = endInterval.getStartTime();
                         }
-                        ThreadEntry threadEntry = threadEntryMap.get(threadQuark);
-                        if (threadEntry == null) {
-                            if (startStates == null) {
-                                startStates = ss.queryFullState(ss.getStartTime());
-                            }
-                            long threadId = endInterval.getStateValue().unboxLong();
-                            long threadStart = start;
-                            ITmfStateInterval startInterval = startStates.get(callStackQuark);
-                            if (startInterval.getStateValue().isNull()) {
-                                threadStart = Math.min(startInterval.getEndTime() + 1, end + 1);
+                        /*
+                         * Default to process/trace entry, overwrite if a thread entry exists.
+                         */
+                        TimeGraphEntry callStackParent = threadParent;
+                        if (threadQuark != processQuark) {
+                            ThreadEntry threadEntry = threadEntryMap.get(threadQuark);
+                            if (threadEntry == null) {
+                                if (startStates == null) {
+                                    startStates = ss.queryFullState(ss.getStartTime());
+                                }
+                                long threadId = -1;
+                                ITmfStateValue threadStateValue = endStates.get(threadQuark).getStateValue();
+                                if (threadStateValue.getType() == Type.LONG || threadStateValue.getType() == Type.INTEGER) {
+                                    threadId = threadStateValue.unboxLong();
+                                } else {
+                                    try {
+                                        threadId = Long.parseLong(threadName);
+                                    } catch (NumberFormatException e) {
+                                        /* use default threadId */
+                                    }
+                                }
+                                long threadStart = start;
+                                ITmfStateInterval startInterval = startStates.get(callStackQuark);
+                                if (startInterval.getStateValue().isNull()) {
+                                    threadStart = Math.min(startInterval.getEndTime() + 1, end + 1);
+                                }
+                                threadEntry = new ThreadEntry(threadName, threadId, threadStart, threadEnd);
+                                threadEntryMap.put(threadQuark, threadEntry);
+                                threadParent.addChild(threadEntry);
+                            } else {
+                                threadEntry.updateEndTime(threadEnd);
                             }
-                            threadEntry = new ThreadEntry(ss, threadName, threadId, callStackQuark, threadStart, threadEnd);
-                            threadEntryMap.put(threadQuark, threadEntry);
-                            processEntry.addChild(threadEntry);
-                        } else {
-                            threadEntry.updateEndTime(threadEnd);
+                            /* The parent of the call stack entries will be a thread */
+                            callStackParent = threadEntry;
                         }
                         int level = 1;
                         for (int stackLevelQuark : ss.getSubAttributes(callStackQuark, false)) {
-                            if (level > threadEntry.getChildren().size()) {
-                                int processId = processEntry.getProcessId();
+                            if (level > callStackParent.getChildren().size()) {
                                 CallStackEntry callStackEntry = new CallStackEntry(threadName, stackLevelQuark, level, processId, trace, ss);
-                                threadEntry.addChild(callStackEntry);
+                                callStackParent.addChild(callStackEntry);
                             }
                             level++;
                         }
                     }
-                } catch (AttributeNotFoundException e) {
-                    Activator.getDefault().logError("Error querying state system", e); //$NON-NLS-1$
-                } catch (StateSystemDisposedException e) {
-                    /* Ignored */
                 }
+            } catch (AttributeNotFoundException e) {
+                Activator.getDefault().logError("Error querying state system", e); //$NON-NLS-1$
+            } catch (StateSystemDisposedException e) {
+                /* Ignored */
             }
 
             if (parentTrace == getTrace()) {
@@ -694,16 +697,21 @@ public class CallStackView extends AbstractTimeGraphView {
                 refresh();
             }
 
-            for (ITimeGraphEntry processEntry : traceEntry.getChildren()) {
-                for (ITimeGraphEntry threadEntry : processEntry.getChildren()) {
-                    for (ITimeGraphEntry callStackEntry : threadEntry.getChildren()) {
-                        if (monitor.isCanceled()) {
-                            return;
-                        }
-                        buildStatusEvents(parentTrace, (CallStackEntry) callStackEntry, monitor, ss.getStartTime(), end);
+            Consumer<TimeGraphEntry> consumer = new Consumer<TimeGraphEntry>() {
+                @Override
+                public void accept(TimeGraphEntry entry) {
+                    if (monitor.isCanceled()) {
+                        return;
+                    }
+                    if (entry instanceof CallStackEntry) {
+                        buildStatusEvents(parentTrace, (CallStackEntry) entry, monitor, ss.getStartTime(), end);
+                        return;
                     }
+                    entry.getChildren().forEach(this);
                 }
-            }
+            };
+            traceEntry.getChildren().forEach(consumer);
+
             start = end;
         }
     }
@@ -730,7 +738,7 @@ public class CallStackView extends AbstractTimeGraphView {
     }
 
     /**
-     * @since 2.0
+     * @since 1.2
      */
     @Override
     protected final List<ITimeEvent> getEventList(TimeGraphEntry tgentry, long startTime, long endTime, long resolution, IProgressMonitor monitor) {
@@ -750,7 +758,7 @@ public class CallStackView extends AbstractTimeGraphView {
             List<ITmfStateInterval> stackIntervals = StateSystemUtils.queryHistoryRange(ss, entry.getQuark(), start, end - 1, resolution, monitor);
             eventList = new ArrayList<>(stackIntervals.size());
             long lastEndTime = -1;
-            boolean lastIsNull = true;
+            boolean lastIsNull = false;
             for (ITmfStateInterval statusInterval : stackIntervals) {
                 if (monitor.isCanceled()) {
                     return null;
@@ -791,52 +799,68 @@ public class CallStackView extends AbstractTimeGraphView {
     }
 
     /**
-     * @since 2.0
+     * @since 1.2
      */
     @Override
-    protected void synchingToTime(long time) {
-        List<TimeGraphEntry> entryList = getEntryList(getTrace());
-        if (entryList == null) {
+    protected void synchingToTime(final long time) {
+        List<TimeGraphEntry> traceEntries = getEntryList(getTrace());
+        Map<ITmfStateSystem, List<ITmfStateInterval>> fullStateMap = new HashMap<>();
+        if (traceEntries == null) {
             return;
         }
-        for (TimeGraphEntry traceEntry : entryList) {
-            for (ITimeGraphEntry processEntry : traceEntry.getChildren()) {
-                /* The entries should all be parseable to an integer. */
-                int pid = Integer.parseInt(processEntry.getName());
-
-                for (ITimeGraphEntry threadEntry : processEntry.getChildren()) {
-                    ITmfStateSystem ss = ((ThreadEntry) threadEntry).getStateSystem();
-                    if (ss == null) {
-                        continue;
-                    }
-                    if (ss.isCancelled()) {
-                        continue;
-                    }
+        Consumer<TimeGraphEntry> consumer = new Consumer<TimeGraphEntry>() {
+            @Override
+            public void accept(TimeGraphEntry entry) {
+                if (entry instanceof CallStackEntry) {
+                    CallStackEntry callStackEntry = (CallStackEntry) entry;
+                    ITmfStateSystem ss = callStackEntry.getStateSystem();
                     if (time < ss.getStartTime() || time > ss.getCurrentEndTime()) {
-                        continue;
+                        return;
                     }
-                    for (ITimeGraphEntry child : threadEntry.getChildren()) {
-                        CallStackEntry callStackEntry = (CallStackEntry) child;
-                        ITmfTrace trace = callStackEntry.getTrace();
-                        try {
-                            ITmfStateInterval stackLevelInterval = ss.querySingleState(time, callStackEntry.getQuark());
-                            ITmfStateValue nameValue = stackLevelInterval.getStateValue();
-
-                            String name = getFunctionName(trace, pid, time, nameValue);
-                            callStackEntry.setFunctionName(name);
-                            if (name.length() > 0) {
-                                callStackEntry.setFunctionEntryTime(stackLevelInterval.getStartTime());
-                                callStackEntry.setFunctionExitTime(stackLevelInterval.getEndTime() + 1);
+                    ITmfTrace trace = callStackEntry.getTrace();
+                    try {
+                        List<ITmfStateInterval> fullState = getFullState(ss);
+                        ITmfStateInterval stackLevelInterval = fullState.get(callStackEntry.getQuark());
+                        ITmfStateValue nameValue = stackLevelInterval.getStateValue();
+
+                        String name = getFunctionName(trace, callStackEntry.getProcessId(), time, nameValue);
+                        callStackEntry.setFunctionName(name);
+                        if (!name.isEmpty()) {
+                            callStackEntry.setFunctionEntryTime(stackLevelInterval.getStartTime());
+                            callStackEntry.setFunctionExitTime(stackLevelInterval.getEndTime() + 1);
+                        }
+                        if (fSyncSelection) {
+                            int callStackQuark = ss.getParentAttributeQuark(callStackEntry.getQuark());
+                            ITmfStateInterval stackInterval = fullState.get(callStackQuark);
+                            if (time == stackInterval.getStartTime()) {
+                                ITmfStateValue stackLevelState = stackInterval.getStateValue();
+                                if (stackLevelState.unboxInt() == callStackEntry.getStackLevel() || stackLevelState.isNull()) {
+                                    Display.getDefault().asyncExec(() -> {
+                                        getTimeGraphCombo().setSelection(callStackEntry);
+                                        getTimeGraphViewer().getTimeGraphControl().fireSelectionChanged();
+                                        fSyncSelection = false;
+                                    });
+                                }
                             }
-                        } catch (AttributeNotFoundException e) {
-                            Activator.getDefault().logError("Error querying state system", e); //$NON-NLS-1$
-                        } catch (StateSystemDisposedException e) {
-                            /* Ignored */
                         }
+                    } catch (StateSystemDisposedException e) {
+                        /* Ignored */
                     }
+                    return;
                 }
+                entry.getChildren().forEach(this);
             }
-        }
+
+            private List<ITmfStateInterval> getFullState(ITmfStateSystem ss) throws StateSystemDisposedException {
+                List<ITmfStateInterval> fullState = fullStateMap.get(ss);
+                if (fullState == null) {
+                    fullState = ss.queryFullState(time);
+                    fullStateMap.put(ss, fullState);
+                }
+                return fullState;
+            }
+        };
+        traceEntries.forEach(consumer);
         if (Display.getCurrent() != null) {
             getTimeGraphCombo().refresh();
         }
@@ -854,10 +878,10 @@ public class CallStackView extends AbstractTimeGraphView {
                     // ignore
                 }
             } else if (nameValue.getType() == Type.INTEGER) {
-                name = "0x" + Integer.toHexString(nameValue.unboxInt()); //$NON-NLS-1$
+                name = "0x" + Integer.toUnsignedString(nameValue.unboxInt(), 16); //$NON-NLS-1$
                 address = nameValue.unboxInt();
             } else if (nameValue.getType() == Type.LONG) {
-                name = "0x" + Long.toHexString(nameValue.unboxLong()); //$NON-NLS-1$
+                name = "0x" + Long.toUnsignedString(nameValue.unboxLong(), 16); //$NON-NLS-1$
                 address = nameValue.unboxLong();
             }
         } catch (StateValueTypeException e) {
@@ -905,7 +929,7 @@ public class CallStackView extends AbstractTimeGraphView {
     }
 
     /**
-     * @since 2.0
+     * @since 1.2
      */
     @Override
     protected void fillLocalToolBar(IToolBarManager manager) {
@@ -972,7 +996,7 @@ public class CallStackView extends AbstractTimeGraphView {
                             viewer.getTimeGraphControl().fireSelectionChanged();
                             startZoomThread(viewer.getTime0(), viewer.getTime1());
 
-                        } catch (AttributeNotFoundException | TimeRangeException | StateSystemDisposedException | StateValueTypeException e) {
+                        } catch (TimeRangeException | StateSystemDisposedException | StateValueTypeException e) {
                             Activator.getDefault().logError("Error querying state system", e); //$NON-NLS-1$
                         }
                     }
@@ -1017,7 +1041,7 @@ public class CallStackView extends AbstractTimeGraphView {
                             viewer.getTimeGraphControl().fireSelectionChanged();
                             startZoomThread(viewer.getTime0(), viewer.getTime1());
 
-                        } catch (AttributeNotFoundException | TimeRangeException | StateSystemDisposedException | StateValueTypeException e) {
+                        } catch (TimeRangeException | StateSystemDisposedException | StateValueTypeException e) {
                             Activator.getDefault().logError("Error querying state system", e); //$NON-NLS-1$
                         }
                     }
@@ -1203,6 +1227,12 @@ public class CallStackView extends AbstractTimeGraphView {
 
         fConfigureSymbolsAction.setToolTipText(Messages.CallStackView_ConfigureSymbolProvidersTooltip);
         fConfigureSymbolsAction.setImageDescriptor(Activator.getDefault().getImageDescripterFromPath(IMPORT_BINARY_ICON_PATH));
+
+        /*
+         * The updateConfigureSymbolsAction() method (called by refresh()) will
+         * set the action to true if applicable after the symbol provider has
+         * been properly loaded.
+         */
         fConfigureSymbolsAction.setEnabled(false);
 
         return fConfigureSymbolsAction;
This page took 0.033926 seconds and 5 git commands to generate.