X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=configure.ac;h=70c0a93698a3ac7393f6d34008c2df0dc4c134bf;hb=090eb20a8731fc7369568df30706cbd3b05ddb37;hp=7db8d1c835a635a1c90266ef0ebd27ef6c0a7b68;hpb=0f3224e9b4b9de7ccdca674038b6ed0f50cbe5b9;p=babeltrace.git diff --git a/configure.ac b/configure.ac index 7db8d1c8..70c0a936 100644 --- a/configure.ac +++ b/configure.ac @@ -1,24 +1,8 @@ -dnl Process this file with autoconf to produce a configure script. -dnl -dnl Copyright (c) 2017 EfficiOS, Inc. -dnl -dnl Permission is hereby granted, free of charge, to any person obtaining a copy -dnl of this software and associated documentation files (the "Software"), to deal -dnl in the Software without restriction, including without limitation the rights -dnl to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -dnl copies of the Software, and to permit persons to whom the Software is -dnl furnished to do so, subject to the following conditions: +dnl SPDX-License-Identifier: MIT dnl -dnl The above copyright notice and this permission notice shall be included in -dnl all copies or substantial portions of the Software. +dnl Copyright (C) 2017 EfficiOS, Inc. dnl -dnl THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -dnl IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -dnl FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -dnl AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -dnl LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -dnl OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -dnl SOFTWARE. +dnl Process this file with autoconf to produce a configure script. ## ## ## Autoconf base setup ## @@ -361,8 +345,9 @@ AS_IF([test "x$BABELTRACE_DEBUG_MODE" = x1], [ # Python bindings # Disabled by default AC_ARG_ENABLE([python-bindings], - [AC_HELP_STRING([--enable-python-bindings], [build the Python bindings])] - dnl AC_ARG_ENABLE will fill enable_python_bindings with the user choice + [AC_HELP_STRING([--enable-python-bindings], [build the Python bindings])], + [], dnl AC_ARG_ENABLE will fill enable_python_bindings with the user choice + [enable_python_bindings=unspecified] ) # Python plugins @@ -446,6 +431,29 @@ AS_IF([test "x$enable_debug_info" = xyes], AC_SUBST([ENABLE_DEBUG_INFO_VAL]) +# Check for conflicting Python related features user choices. +AS_IF([test "x$enable_python_plugins" = xyes], + [ + AS_IF([test "x$enable_python_bindings" = xunspecified], + [ + # --enable-python-plugins was provided but --enable-python-bindings was + # omitted. Turn the Python bindings ON anyway because it's needed to + # use the Python plugins. + enable_python_bindings=yes + ], + [ + AS_IF([test "x$enable_python_bindings" = xno], + [ + # --enable-python-plugins _and_ --disable-python-bindings were + # used. This is invalid because Python plugins need the Python + # bindings to be useful. + AC_MSG_ERROR(--enable-python-bindings must be used to support Python plugins) + ] + ) + ] + ) + ] +) # Check for conflicting optional features user choices @@ -636,25 +644,36 @@ target. CFLAGS=${save_CFLAGS} # Detect C and LD warning flags supported by the compiler. -AX_COMPILER_FLAGS( - [WARN_CFLAGS], dnl CFLAGS variable name - [WARN_LDFLAGS], dnl LDFLAGS variable name (unused for now) - [], dnl is-release - [], dnl Extra base CFLAGS - [ dnl Extra "yes" CFLAGS - dnl Disable these flags, either because we don't want them - dnl or because we want them but are not ready to enable them - dnl yet. - -Wno-sign-compare dnl - -Wno-inline dnl - -Wno-declaration-after-statement dnl - -Wno-switch-enum dnl - -Wno-switch-default dnl - -Wno-packed dnl - -Wno-pointer-arith dnl + +# Detect warning flags supported by the compiler, append them to WARN_CFLAGS. +# +# Pass -Werror as an extra flag during the test: this is needed to make the +# -Wunknown-warning-option diagnostic fatal with clang. +AX_APPEND_COMPILE_FLAGS([ dnl + -Wall dnl + -Wextra dnl + -Wstrict-prototypes dnl + -Wmissing-prototypes dnl + -Wmissing-declarations dnl + -Wnull-dereference dnl + -Wundef dnl + -Wredundant-decls dnl + -Wshadow dnl + -Wjump-misses-init dnl + -Wsuggest-attribute=format dnl + -Wtautological-constant-out-of-range-compare dnl + -Wnested-externs dnl + -Wwrite-strings dnl + -Wformat=2 dnl -Wno-format-nonliteral dnl - -Wno-double-promotion dnl - -Wno-cast-align dnl + -Wstrict-aliasing dnl + -Wmissing-noreturn dnl + -Winit-self dnl + -Wduplicated-cond dnl + -Wduplicated-branches dnl + -Wlogical-op dnl + -Wno-unused-parameter dnl + -Wno-sign-compare dnl dnl dnl Some versions of SWIG (like 3.0.12) generate code that produces dnl -Wcast-function-type warnings. This warning is present in gcc >= 8. This @@ -668,24 +687,32 @@ AX_COMPILER_FLAGS( dnl dnl Ref: https://github.com/swig/swig/issues/1259 -Wno-cast-function-type dnl - ]) - -# CFLAGS from AX_COMPILER_FLAGS. -AM_CFLAGS="${AM_CFLAGS} ${WARN_CFLAGS}" + -Wno-missing-field-initializers dnl + ], + [WARN_CFLAGS], + [-Werror]) + +# When given, add -Werror to WARN_CFLAGS. +AC_ARG_ENABLE([Werror], + [AS_HELP_STRING([--enable-Werror], [Treat compiler warnings as errors.])] +) +AS_IF([test "x$enable_Werror" = "xyes"], + [WARN_CFLAGS="${WARN_CFLAGS} -Werror"] +) -# The test used in AX_COMPILER_FLAGS, generated using AC_LANG_PROGRAM, is +# The test used in AX_APPEND_COMPILE_FLAGS, generated using AC_LANG_PROGRAM, is # written in such a way that it triggers a -Wold-style-definition warning. So -# if the user has -Werror in their CFLAGS, that warning flag will end up -# disabled, because the test program will not build. +# this warning always ends up disabled if we put it there, because the test +# program does not build. # # Enable it here unconditionally. It is supported by GCC >= 4.8 and by Clang # (it is accepted for compatibility although it has no effect), and there is # not reason to not want it. -AM_CFLAGS="${AM_CFLAGS} -Wold-style-definition" +WARN_CFLAGS="${WARN_CFLAGS} -Wold-style-definition" -# We want this one to always be an error. -AM_CFLAGS="${AM_CFLAGS} -Werror=implicit-function-declaration" +# CFLAGS from AX_APPEND_COMPILE_FLAGS. +AM_CFLAGS="${AM_CFLAGS} ${WARN_CFLAGS}" # Done for AM_CFLAGS. AC_SUBST(AM_CFLAGS)