X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=formats%2Fctf%2Ftypes%2Fstring.c;h=3b54a2df680ea5acffbba3c6f932aff1f2da096c;hb=c34ea0fad3f9900c3b97efa229d221927422dacf;hp=2e6a25ec005d433713ec89cfcef6d19cd435502d;hpb=ccd7e1c86f36342b0b06651cc52df86bb663c271;p=babeltrace.git

diff --git a/formats/ctf/types/string.c b/formats/ctf/types/string.c
index 2e6a25ec..3b54a2df 100644
--- a/formats/ctf/types/string.c
+++ b/formats/ctf/types/string.c
@@ -3,7 +3,9 @@
  *
  * Strings read/write functions.
  *
- * Copyright 2010 - Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
+ * Copyright 2010-2011 EfficiOS Inc. and Linux Foundation
+ *
+ * Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -16,63 +18,71 @@
  * all copies or substantial portions of the Software.
  */
 
+#include <babeltrace/babeltrace-internal.h>
 #include <babeltrace/ctf/types.h>
 #include <limits.h>		/* C99 limits */
 #include <string.h>
 
-void ctf_string_copy(struct stream_pos *dest, struct stream_pos *src,
-		     const struct type_class_string *string_class)
+int ctf_string_read(struct stream_pos *ppos, struct definition *definition)
 {
+	struct definition_string *string_definition =
+		container_of(definition, struct definition_string, p);
+	const struct declaration_string *string_declaration =
+		string_definition->declaration;
+	struct ctf_stream_pos *pos = ctf_pos(ppos);
 	size_t len;
-	unsigned char *destaddr, *srcaddr;
+	ssize_t max_len;
+	char *srcaddr;
 
-	align_pos(src, string_class->p.alignment);
-	srcaddr = get_pos_addr(src);
-	len = strlen(srcaddr) + 1;
-	if (dest->dummy)
-		goto end;
-	align_pos(dest, string_class->p.alignment);
-	destaddr = get_pos_addr(dest);
-	strcpy(destaddr, srcaddr);
-end:
-	move_pos(dest, len);
-	move_pos(src, len);
-}
+	ctf_align_pos(pos, string_declaration->p.alignment);
 
-void ctf_string_read(unsigned char **dest, struct stream_pos *src,
-		     const struct type_class_string *string_class)
-{
-	size_t len;
-	unsigned char *srcaddr;
+	srcaddr = ctf_get_pos_addr(pos);
+	if (pos->offset == EOF)
+		return -EFAULT;
+	/* Not counting \0 */
+	max_len = pos->packet_size - pos->offset - 1;
+	if (max_len < 0)
+		return -EFAULT;
+	len = strnlen(srcaddr, max_len) + 1;	/* Add \0 */
+	/* Truncated string, unexpected. Trace probably corrupted. */
+	if (srcaddr[len - 1] != '\0')
+		return -EFAULT;
 
-	align_pos(src, string_class->p.alignment);
-	srcaddr = get_pos_addr(src);
-	len = strlen(srcaddr) + 1;
-	if (dest->dummy)
-		goto end;
-	*dest = g_realloc(*dest, len);
-	strcpy(dest, srcaddr);
-end:
-	move_pos(src, len);
+	if (string_definition->alloc_len < len) {
+		string_definition->value =
+			g_realloc(string_definition->value, len);
+		string_definition->alloc_len = len;
+	}
+	printf_debug("CTF string read %s\n", srcaddr);
+	memcpy(string_definition->value, srcaddr, len);
+	string_definition->len = len;
+	ctf_move_pos(pos, len * CHAR_BIT);
+	return 0;
 }
 
-void ctf_string_write(struct stream_pos *dest, const unsigned char *src,
-		      const struct type_class_string *string_class)
+int ctf_string_write(struct stream_pos *ppos,
+		      struct definition *definition)
 {
+	struct definition_string *string_definition =
+		container_of(definition, struct definition_string, p);
+	const struct declaration_string *string_declaration =
+		string_definition->declaration;
+	struct ctf_stream_pos *pos = ctf_pos(ppos);
 	size_t len;
-	unsigned char *destaddr;
+	char *destaddr;
+
+	ctf_align_pos(pos, string_declaration->p.alignment);
+	assert(string_definition->value != NULL);
+	len = string_definition->len;
+
+	if (!ctf_pos_access_ok(pos, len))
+		return -EFAULT;
 
-	align_pos(dest, string_class->p.alignment);
-	len = strlen(src) + 1;
-	if (dest->dummy)
+	if (pos->dummy)
 		goto end;
-	destaddr = get_pos_addr(dest);
-	strcpy(destaddr, src);
+	destaddr = ctf_get_pos_addr(pos);
+	memcpy(destaddr, string_definition->value, len);
 end:
-	move_pos(dest, len);
-}
-
-void ctf_string_free_temp(unsigned char *string)
-{
-	g_free(string);
+	ctf_move_pos(pos, len * CHAR_BIT);
+	return 0;
 }