X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fust-app.c;h=397a2dfab29b5f2106f1a235a4ce1a7bfb7f0a7b;hb=030a66fa43d2f6666afa9e4a90ca755eb5670555;hp=8f7db8f2ccbda06e5584a93f332576b70a62b9a9;hpb=4f3ab6ee347964379eefc57f41f8a381965b4316;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/ust-app.c b/src/bin/lttng-sessiond/ust-app.c
index 8f7db8f2c..397a2dfab 100644
--- a/src/bin/lttng-sessiond/ust-app.c
+++ b/src/bin/lttng-sessiond/ust-app.c
@@ -155,7 +155,7 @@ void delete_ust_app_event(int sock, struct ust_app_event *ua_event)
  * this function.
  */
 static
-void delete_ust_app_stream(int sock, struct ltt_ust_stream *stream)
+void delete_ust_app_stream(int sock, struct ust_app_stream *stream)
 {
 	if (stream->obj) {
 		ustctl_release_object(sock, stream->obj);
@@ -176,7 +176,7 @@ void delete_ust_app_channel(int sock, struct ust_app_channel *ua_chan)
 	struct lttng_ht_iter iter;
 	struct ust_app_event *ua_event;
 	struct ust_app_ctx *ua_ctx;
-	struct ltt_ust_stream *stream, *stmp;
+	struct ust_app_stream *stream, *stmp;
 
 	/* Wipe stream */
 	cds_list_for_each_entry_safe(stream, stmp, &ua_chan->streams.head, list) {
@@ -739,6 +739,7 @@ static int create_ust_metadata_stream(struct ust_app *app,
 	ret = ustctl_create_stream(app->sock, ua_sess->metadata->obj,
 			&ua_sess->metadata->stream_obj);
 	if (ret < 0) {
+		lttng_fd_put(LTTNG_FD_APPS, 2);
 		ERR("UST create metadata stream failed");
 		goto error;
 	}
@@ -756,7 +757,7 @@ error:
  * On error, return a negative value.
  */
 static int create_ust_stream(struct ust_app *app,
-		struct ust_app_channel *ua_chan, struct ltt_ust_stream *stream)
+		struct ust_app_channel *ua_chan, struct ust_app_stream *stream)
 {
 	int ret;
 
@@ -776,11 +777,25 @@ static int create_ust_stream(struct ust_app *app,
 		goto error;
 	}
 
+	/*
+	 * Set the stream name before creating it. On error, we don't have to
+	 * delete it on the tracer side.
+	 */
+	ret = snprintf(stream->name, sizeof(stream->name), "%s_%u",
+			ua_chan->name, ua_chan->streams.count);
+	if (ret < 0) {
+		/* Without the stream name we can't continue using it. */
+		PERROR("snprintf UST create stream");
+		/* Just to make sure we never return -ENOENT. */
+		ret = -1;
+		goto error;
+	}
+
 	ret = ustctl_create_stream(app->sock, ua_chan->obj, &stream->obj);
 	if (ret < 0) {
 		lttng_fd_put(LTTNG_FD_APPS, 2);
 		/* Indicates that there is no more stream for that channel. */
-		if (ret != -ENOENT) {
+		if (ret != -LTTNG_UST_ERR_NOENT) {
 			ERR("UST create metadata stream failed (ret: %d)", ret);
 		}
 		goto error;
@@ -2299,7 +2314,7 @@ int ust_app_start_trace(struct ltt_ust_session *usess, struct ust_app *app)
 	struct lttng_ht_iter iter;
 	struct ust_app_session *ua_sess;
 	struct ust_app_channel *ua_chan;
-	struct ltt_ust_stream *ustream;
+	struct ust_app_stream *ustream;
 	struct consumer_socket *socket;
 
 	DBG("Starting tracing for ust app pid %d", app->pid);
@@ -2359,7 +2374,7 @@ int ust_app_start_trace(struct ltt_ust_session *usess, struct ust_app *app)
 			if (ret < 0) {
 				/* Free unused memory after this point. */
 				free(ustream);
-				if (ret == -ENOENT) {
+				if (ret == -LTTNG_UST_ERR_NOENT) {
 					/* Got all streams. Continue normal execution. */
 					break;
 				}
@@ -2370,19 +2385,10 @@ int ust_app_start_trace(struct ltt_ust_session *usess, struct ust_app *app)
 
 			health_code_update(&health_thread_cmd);
 
-			/* Order is important */
+			/* Order is important this is why a list is used. */
 			cds_list_add_tail(&ustream->list, &ua_chan->streams.head);
-			ret = snprintf(ustream->name, sizeof(ustream->name), "%s_%u",
-					ua_chan->name, ua_chan->streams.count);
 			ua_chan->streams.count++;
-			if (ret < 0) {
-				PERROR("asprintf UST create stream");
-				/*
-				 * XXX what should we do here with the
-				 * stream ?
-				 */
-				continue;
-			}
+
 			DBG2("UST stream %d ready (handle: %d)", ua_chan->streams.count,
 					ustream->handle);
 		}