X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=src%2Fplugins%2Fctf%2Flttng-live%2Fdata-stream.cpp;h=8f4ae873d234d7415b8c737c081d88209898dc5b;hb=HEAD;hp=4cfc7e0e4f3f91a5226f3b2efc36d0798c7c82dd;hpb=e28ca55892c07d6c463a88d61881424c3610d650;p=babeltrace.git diff --git a/src/plugins/ctf/lttng-live/data-stream.cpp b/src/plugins/ctf/lttng-live/data-stream.cpp index 4cfc7e0e..8f4ae873 100644 --- a/src/plugins/ctf/lttng-live/data-stream.cpp +++ b/src/plugins/ctf/lttng-live/data-stream.cpp @@ -17,6 +17,7 @@ #include "common/assert.h" #include "compat/mman.h" /* IWYU pragma: keep */ +#include "cpp-common/bt2s/make-unique.hpp" #include "cpp-common/vendor/fmt/format.h" #include "../common/src/msg-iter/msg-iter.hpp" @@ -27,7 +28,6 @@ static enum ctf_msg_iter_medium_status medop_request_bytes(size_t request_sz, uint8_t **buffer_addr, size_t *buffer_sz, void *data) { - enum ctf_msg_iter_medium_status status = CTF_MSG_ITER_MEDIUM_STATUS_OK; lttng_live_stream_iterator *stream = (lttng_live_stream_iterator *) data; struct lttng_live_trace *trace = stream->trace; struct lttng_live_session *session = trace->session; @@ -39,26 +39,30 @@ static enum ctf_msg_iter_medium_status medop_request_bytes(size_t request_sz, ui BT_ASSERT(request_sz); if (stream->has_stream_hung_up) { - status = CTF_MSG_ITER_MEDIUM_STATUS_EOF; - goto end; + return CTF_MSG_ITER_MEDIUM_STATUS_EOF; } len_left = stream->base_offset + stream->len - stream->offset; if (!len_left) { lttng_live_stream_iterator_set_state(stream, LTTNG_LIVE_STREAM_ACTIVE_NO_DATA); - status = CTF_MSG_ITER_MEDIUM_STATUS_AGAIN; - goto end; + return CTF_MSG_ITER_MEDIUM_STATUS_AGAIN; } read_len = MIN(request_sz, stream->buf.size()); read_len = MIN(read_len, len_left); - status = lttng_live_get_stream_bytes(live_msg_iter, stream, stream->buf.data(), stream->offset, - read_len, &recv_len); + + const auto status = lttng_live_get_stream_bytes(live_msg_iter, stream, stream->buf.data(), + stream->offset, read_len, &recv_len); + + if (status != CTF_MSG_ITER_MEDIUM_STATUS_OK) { + return status; + } + *buffer_addr = stream->buf.data(); *buffer_sz = recv_len; stream->offset += recv_len; -end: - return status; + + return CTF_MSG_ITER_MEDIUM_STATUS_OK; } static bt_stream *medop_borrow_stream(bt_stream_class *stream_class, int64_t stream_id, void *data) @@ -116,7 +120,6 @@ enum lttng_live_iterator_status lttng_live_lazy_msg_init(struct lttng_live_sessi bt_self_message_iterator *self_msg_iter) { struct lttng_live_component *lttng_live = session->lttng_live_msg_iter->lttng_live_comp; - uint64_t trace_idx, stream_iter_idx; if (!session->lazy_stream_msg_init) { return LTTNG_LIVE_ITERATOR_STATUS_OK; @@ -127,20 +130,14 @@ enum lttng_live_iterator_status lttng_live_lazy_msg_init(struct lttng_live_sessi "session-id={}, self-msg-iter-addr={}", session->id, fmt::ptr(self_msg_iter)); - for (trace_idx = 0; trace_idx < session->traces->len; trace_idx++) { - struct lttng_live_trace *trace = - (lttng_live_trace *) g_ptr_array_index(session->traces, trace_idx); - - for (stream_iter_idx = 0; stream_iter_idx < trace->stream_iterators->len; - stream_iter_idx++) { + for (lttng_live_trace::UP& trace : session->traces) { + for (lttng_live_stream_iterator::UP& stream_iter : trace->stream_iterators) { struct ctf_trace_class *ctf_tc; - struct lttng_live_stream_iterator *stream_iter = - (lttng_live_stream_iterator *) g_ptr_array_index(trace->stream_iterators, - stream_iter_idx); if (stream_iter->msg_iter) { continue; } + ctf_tc = ctf_metadata_decoder_borrow_ctf_trace_class(trace->metadata->decoder.get()); BT_CPPLOGD_SPEC(stream_iter->logger, "Creating CTF message iterator: session-id={}, ctf-tc-addr={}, " @@ -148,12 +145,12 @@ enum lttng_live_iterator_status lttng_live_lazy_msg_init(struct lttng_live_sessi session->id, fmt::ptr(ctf_tc), stream_iter->name, fmt::ptr(self_msg_iter)); stream_iter->msg_iter = - ctf_msg_iter_create(ctf_tc, lttng_live->max_query_size, medops, stream_iter, + ctf_msg_iter_create(ctf_tc, lttng_live->max_query_size, medops, stream_iter.get(), self_msg_iter, stream_iter->logger); if (!stream_iter->msg_iter) { BT_CPPLOGE_APPEND_CAUSE_SPEC(stream_iter->logger, "Failed to create CTF message iterator"); - goto error; + return LTTNG_LIVE_ITERATOR_STATUS_ERROR; } } } @@ -161,16 +158,12 @@ enum lttng_live_iterator_status lttng_live_lazy_msg_init(struct lttng_live_sessi session->lazy_stream_msg_init = false; return LTTNG_LIVE_ITERATOR_STATUS_OK; - -error: - return LTTNG_LIVE_ITERATOR_STATUS_ERROR; } struct lttng_live_stream_iterator * lttng_live_stream_iterator_create(struct lttng_live_session *session, uint64_t ctf_trace_id, uint64_t stream_id, bt_self_message_iterator *self_msg_iter) { - lttng_live_stream_iterator *stream_iter = nullptr; std::stringstream nameSs; BT_ASSERT(session); @@ -182,10 +175,11 @@ lttng_live_stream_iterator_create(struct lttng_live_session *session, uint64_t c lttng_live_session_borrow_or_create_trace_by_id(session, ctf_trace_id); if (!trace) { BT_CPPLOGE_APPEND_CAUSE_SPEC(session->logger, "Failed to borrow CTF trace."); - goto error; + return nullptr; } - stream_iter = new lttng_live_stream_iterator {session->logger}; + auto stream_iter = bt2s::make_unique(session->logger); + stream_iter->trace = trace; stream_iter->state = LTTNG_LIVE_STREAM_ACTIVE_NO_DATA; stream_iter->viewer_stream_id = stream_id; @@ -201,41 +195,30 @@ lttng_live_stream_iterator_create(struct lttng_live_session *session, uint64_t c ctf_metadata_decoder_borrow_ctf_trace_class(trace->metadata->decoder.get()); BT_ASSERT(!stream_iter->msg_iter); stream_iter->msg_iter = - ctf_msg_iter_create(ctf_tc, lttng_live->max_query_size, medops, stream_iter, + ctf_msg_iter_create(ctf_tc, lttng_live->max_query_size, medops, stream_iter.get(), self_msg_iter, stream_iter->logger); if (!stream_iter->msg_iter) { BT_CPPLOGE_APPEND_CAUSE_SPEC(stream_iter->logger, "Failed to create CTF message iterator"); - goto error; + return nullptr; } } stream_iter->buf.resize(lttng_live->max_query_size); nameSs << STREAM_NAME_PREFIX << stream_iter->viewer_stream_id; stream_iter->name = nameSs.str(); - g_ptr_array_add(trace->stream_iterators, stream_iter); + + const auto ret = stream_iter.get(); + trace->stream_iterators.emplace_back(std::move(stream_iter)); /* Track the number of active stream iterator. */ session->lttng_live_msg_iter->active_stream_iter++; - goto end; -error: - lttng_live_stream_iterator_destroy(stream_iter); - stream_iter = NULL; -end: - return stream_iter; + return ret; } -void lttng_live_stream_iterator_destroy(struct lttng_live_stream_iterator *stream_iter) +lttng_live_stream_iterator::~lttng_live_stream_iterator() { - if (!stream_iter) { - return; - } - - bt_message_put_ref(stream_iter->current_msg); - /* Track the number of active stream iterator. */ - stream_iter->trace->session->lttng_live_msg_iter->active_stream_iter--; - - delete stream_iter; + this->trace->session->lttng_live_msg_iter->active_stream_iter--; }