X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=types%2Fstring.c;h=1999cffdb0b4ff188c706bd16a5cc96cab15e8dc;hb=9cc28abaa76a7243e796dbe5ea508bab8f8b9480;hp=6e5c6f472b41d115181e05c57962a3c9f8676476;hpb=dc48ecad637fc7fb8479da563ef2dfd3948cee73;p=babeltrace.git

diff --git a/types/string.c b/types/string.c
index 6e5c6f47..1999cffd 100644
--- a/types/string.c
+++ b/types/string.c
@@ -23,25 +23,11 @@
 static
 struct definition *_string_definition_new(struct declaration *declaration,
 				struct definition_scope *parent_scope,
-				GQuark field_name, int index);
+				GQuark field_name, int index,
+				const char *root_name);
 static
 void _string_definition_free(struct definition *definition);
 
-void string_copy(struct stream_pos *dest, const struct format *fdest, 
-		 struct stream_pos *src, const struct format *fsrc,
-		 struct definition *definition)
-{
-	struct definition_string *string =
-		container_of(definition, struct definition_string, p);
-	struct declaration_string *string_declaration = string->declaration;
-
-	g_free(string->value);
-	string->value = NULL;
-	fsrc->string_read(&string->value, src, string_declaration);
-	if (fdest)
-		fdest->string_write(dest, string->value, string_declaration);
-}
-
 static
 void _string_declaration_free(struct declaration *declaration)
 {
@@ -58,7 +44,6 @@ struct declaration_string *
 	string_declaration = g_new(struct declaration_string, 1);
 	string_declaration->p.id = CTF_TYPE_STRING;
 	string_declaration->p.alignment = CHAR_BIT;
-	string_declaration->p.copy = string_copy;
 	string_declaration->p.declaration_free = _string_declaration_free;
 	string_declaration->p.definition_new = _string_definition_new;
 	string_declaration->p.definition_free = _string_definition_free;
@@ -71,19 +56,34 @@ static
 struct definition *
 	_string_definition_new(struct declaration *declaration,
 			       struct definition_scope *parent_scope,
-			       GQuark field_name, int index)
+			       GQuark field_name, int index,
+			       const char *root_name)
 {
 	struct declaration_string *string_declaration =
 		container_of(declaration, struct declaration_string, p);
 	struct definition_string *string;
+	int ret;
 
 	string = g_new(struct definition_string, 1);
 	declaration_ref(&string_declaration->p);
 	string->p.declaration = declaration;
 	string->declaration = string_declaration;
 	string->p.ref = 1;
-	string->p.index = index;
+	/*
+	 * Use INT_MAX order to ensure that all fields of the parent
+	 * scope are seen as being prior to this scope.
+	 */
+	string->p.index = root_name ? INT_MAX : index;
+	string->p.name = field_name;
+	string->p.path = new_definition_path(parent_scope, field_name,
+					root_name);
+	string->p.scope = NULL;
 	string->value = NULL;
+	string->len = 0;
+	string->alloc_len = 0;
+	ret = register_field_definition(field_name, &string->p,
+					parent_scope);
+	assert(!ret);
 	return &string->p;
 }