PR ld/21334: Always call `_bfd_elf_link_renumber_dynsyms' if required
authorMaciej W. Rozycki <macro@imgtec.com>
Mon, 24 Apr 2017 19:15:31 +0000 (20:15 +0100)
committerMaciej W. Rozycki <macro@imgtec.com>
Wed, 26 Apr 2017 12:17:07 +0000 (13:17 +0100)
commit23ec1e32b1ab714649a7c25e49b5d721fe3bd3db
tree86f02a16d136cb6895ca179e1ba5d9e8dda7ccc7
parentc46cec3a8cfe02fbe0f6c67ba53abc5369c5c659
PR ld/21334: Always call `_bfd_elf_link_renumber_dynsyms' if required

Complement commit e17b0c351f0b ("MIPS/BFD: Respect the ELF gABI dynamic
symbol table sort requirement") and correct an inconsistency in dynamic
symbol accounting data causing an assertion failure in the MIPS backend:

ld: BFD (GNU Binutils) 2.28.51.20170330 assertion fail
../../binutils-gdb/bfd/elfxx-mips.c:3860

in the course of making a GOT entry in a static binary to satisfy a GOT
relocation present in input, due to the local dynamic symbol count not
having been established.

To do so let backends request `_bfd_elf_link_renumber_dynsyms' to be
always called, rather than where a dynamic binary is linked only, and
then make this request in the MIPS backend.

bfd/
PR ld/21334
* elf-bfd.h (elf_backend_data): Add `always_renumber_dynsyms'
member.
* elfxx-target.h [!elf_backend_always_renumber_dynsyms]
(elf_backend_always_renumber_dynsyms): Define.
(elfNN_bed): Initialize `always_renumber_dynsyms' member.
* elfxx-mips.h (elf_backend_always_renumber_dynsyms): Define.
* elflink.c (bfd_elf_size_dynamic_sections): Also call
`_bfd_elf_link_renumber_dynsyms' if the backend has requested
it.
(bfd_elf_size_dynsym_hash_dynstr): Likewise.

ld/
PR ld/21334
* testsuite/ld-mips-elf/pr21334.dd: New test.
* testsuite/ld-mips-elf/pr21334.gd: New test.
* testsuite/ld-mips-elf/pr21334.ld: New test linker script.
* testsuite/ld-mips-elf/pr21334.s: New test source.
* testsuite/ld-mips-elf/mips-elf.exp: Run the new tests.
bfd/ChangeLog
bfd/elf-bfd.h
bfd/elflink.c
bfd/elfxx-mips.h
bfd/elfxx-target.h
ld/ChangeLog
ld/testsuite/ld-mips-elf/mips-elf.exp
ld/testsuite/ld-mips-elf/pr21334.dd [new file with mode: 0644]
ld/testsuite/ld-mips-elf/pr21334.gd [new file with mode: 0644]
ld/testsuite/ld-mips-elf/pr21334.ld [new file with mode: 0644]
ld/testsuite/ld-mips-elf/pr21334.s [new file with mode: 0644]
This page took 0.042764 seconds and 4 git commands to generate.