drm/i915: WARN is the DP aux read or write is too big
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Tue, 17 Sep 2013 14:14:10 +0000 (11:14 -0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 17 Sep 2013 15:22:44 +0000 (17:22 +0200)
commit46a5ae9f82719aa6e3c9c0d344772f475a335161
treeac180b912b9e63a0c058a0d4a49eef93ceb8b471
parent4926cb76bd8c4fb18066862bf9e00c840db4b3d8
drm/i915: WARN is the DP aux read or write is too big

So far we control everything and nothing exceeds the current limits,
but (i) we never think about these limits when reviewing patches, (ii)
not all the callers check the return values and (iii) if we ever hit
any of these messages, we'll have to fix the code that added the bad
message.

The current limit for these messages is 20 since we only have 5 data
registers on all the current gens.

The checks inside intel_dp_aux_native_{write,read} are to prevent
buffer overflows. The check inside intel_dp_aux_ch is to prevent
writing past our 5 data registers.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c
This page took 0.025025 seconds and 5 git commands to generate.