nfsd4: fix leak of inode reference on delegation failure
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 15 Aug 2013 20:55:26 +0000 (16:55 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 30 Aug 2013 21:30:52 +0000 (17:30 -0400)
commitbf7bd3e98be5c74813bee6ad496139fb0a011b3b
tree9106fb2a3bdb88298db7aa90235ba28766c64361
parent3477565e6a73da7bb50fce6ac718b31eddb37fbb
nfsd4: fix leak of inode reference on delegation failure

This fixes a regression from 68a3396178e6688ad7367202cdf0af8ed03c8727
"nfsd4: shut down more of delegation earlier".

After that commit, nfs4_set_delegation() failures result in
nfs4_put_delegation being called, but nfs4_put_delegation doesn't free
the nfs4_file that has already been set by alloc_init_deleg().

This can result in an oops on later unmounting the exported filesystem.

Note also delaying the fi_had_conflict check we're able to return a
better error (hence give 4.1 clients a better idea why the delegation
failed; though note CONFLICT isn't an exact match here, as that's
supposed to indicate a current conflict, but all we know here is that
there was one recently).

Reported-by: Toralf Förster <toralf.foerster@gmx.de>
Tested-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c
This page took 0.025433 seconds and 5 git commands to generate.