This patch fixes a bug in the AArch64 assembler where an incorrect structural load...
authorBarnaby Wilks <barnaby.wilks@arm.com>
Tue, 2 Jul 2019 13:09:52 +0000 (14:09 +0100)
committerNick Clifton <nickc@redhat.com>
Tue, 2 Jul 2019 13:11:14 +0000 (14:11 +0100)
commit163b2c58bdbf0cba9a085574ae88d4c757c6567d
tree45a745b466ef6e57cb5a5248894702324852fe58
parent4d83e8d97e3b15dcd7b5c58f4199e9f5bd6fca3d
This patch fixes a bug in the AArch64 assembler where an incorrect structural load/store by element instruction would generate the wrong error message.

For example, when provided with the (incorrect) instruction

st4 {v0.16b-v3.16b}[4],[x0]

currently assembler provides the following error message
"Error: comma expected between operands at operand 2 -- `st4 {v0.16b-v3.16b}[4],[x0]'".

This was due to the assembler consuming the {v0.16b-v3.16b} as the first operand leaving
[4],[x0] as what it believed to be the second operand.

The actual error is that the first operand should be of element type and not
vector type (as provided). The new diagnostic for this error is
"Error: expected element type rather than vector type at operand 1 -- `st4 {v0.16b-v3.16b}[4],[x0]'.

Added testcases to check for the correct diagnostic message as well as checking that
variations of the structural load/store by element instruction also generate the error
when they have the same problem.

* config/tc-aarch64.c (parse_operands): Add error check.
* testsuite/gas/aarch64/diagnostic.l: New test.
* testsuite/gas/aarch64/diagnostic.s: New test.
* testsuite/gas/aarch64/illegal.l: New tests.
* testsuite/gas/aarch64/illegal.s: New tests.
gas/ChangeLog
gas/config/tc-aarch64.c
gas/testsuite/gas/aarch64/diagnostic.l
gas/testsuite/gas/aarch64/diagnostic.s
gas/testsuite/gas/aarch64/illegal.l
gas/testsuite/gas/aarch64/illegal.s
This page took 0.04331 seconds and 4 git commands to generate.