.gdb_index prod perf regression: find before insert in unordered_map
authorPedro Alves <palves@redhat.com>
Sun, 11 Jun 2017 23:49:51 +0000 (00:49 +0100)
committerPedro Alves <palves@redhat.com>
Mon, 12 Jun 2017 16:06:25 +0000 (17:06 +0100)
commit70a1152bee7cb959ab0c6c13bada03190125022f
tree3fc5d2bbb01ea32fbdf97502b2f7cd5ef7953c14
parentc2f134ac418eafca850e7095d789a01ec1142fc4
.gdb_index prod perf regression: find before insert in unordered_map

"perf" shows the unordered_map::emplace call in write_hash_table a bit
high up on profiles.  Fix this using the find + insert idiom instead
of going straight to insert.

I tried doing the same to the other unordered_maps::emplace calls in
the file, but saw no performance improvement, so left them be.

With a '-g3 -O2' build of gdb, and:

  $ cat save-index.cmd
  set $i = 0
  while $i < 100
    save gdb-index .
    set $i = $i + 1
  end
  $ time ./gdb -data-directory=data-directory -nx --batch -q -x save-index.cmd  ./gdb.pristine

I get an improvement of ~7%:

  ~7.0s => ~6.5s (average of 5 runs).

gdb/ChangeLog:
2017-06-12  Pedro Alves  <palves@redhat.com>

* dwarf2read.c (write_hash_table): Check if key already exists
before emplacing.
gdb/ChangeLog
gdb/dwarf2read.c
This page took 0.026647 seconds and 4 git commands to generate.