Make compare-sections work against all targets; add compare-sections [-r] tests.
authorPedro Alves <palves@redhat.com>
Tue, 20 May 2014 18:11:39 +0000 (19:11 +0100)
committerPedro Alves <palves@redhat.com>
Tue, 20 May 2014 18:11:39 +0000 (19:11 +0100)
commit936d299246c2be32cfc92e0ad824f31d5b8cec73
treeb177ec4c4f4bc0061c5abc62169cb40878599d2c
parent9440a9045928d3d4624b8dbcfbd98587a49d35e7
Make compare-sections work against all targets; add compare-sections [-r] tests.

This does two things:

1. Adds a test.

Recently compare-sections got a new "-r" switch, but given no test
existed for compare-sections, the patch was allowed in with no
testsuite addition.  This now adds a test for both compare-sections
and compare-sections -r.

2. Makes the compare-sections command work against all targets.

Currently, compare-sections only works with remote targets, and only
those that support the qCRC packet.  The patch makes it so that if the
target doesn't support accelerating memory verification, then GDB
falls back to comparing memory itself.  This is of course slower, but
it's better than nothing, IMO.  While testing against extended-remote
GDBserver I noticed that we send the qCRC request to the target if
we're connected, but not yet running a program.  That can't work of
course -- the patch fixes that.  This all also goes in the direction
of bridging the local/remote parity gap.

I didn't decouple 1. from 2., because that would mean that the test
would need to handle the case of the target not supporting the
command.

Tested on x86_64 Fedora 17, native, remote GDBserver, and
extended-remote GDBserver.  I also hack-disabled qCRC support to make
sure the fallback paths in remote.c work.

gdb/doc/
2014-05-20  Pedro Alves  <palves@redhat.com>

* gdb.texinfo (Memory) <compare-sections>: Generalize comments to
not be remote specific.  Add cross reference to the qCRC packet.
(Separate Debug Files): Update cross reference to the qCRC packet.
(General Query Packets) <qCRC packet>: Add anchor.

gdb/
2014-05-20  Pedro Alves  <palves@redhat.com>

* NEWS: Mention that compare-sections now works with all targets.

* remote.c (PACKET_qCRC): New enum value.
(remote_verify_memory): Don't send qCRC if the target has no
execution.  Use packet_support/packet_ok.  If the target doesn't
support the qCRC packet, fallback to a deep memory copy.
(compare_sections_command): Say "target image" instead of "remote
executable".
(_initialize_remote): Add PACKET_qCRC to the list of config
packets that have no associated command.  Extend comment.
* target.c (simple_verify_memory, default_verify_memory): New
function.
* target.h (struct target_ops) <to_verify_memory>: Default to
default_verify_memory.
(simple_verify_memory): New declaration.
* target-delegates.c: Regenerate.

gdb/testsuite/
2014-05-20  Pedro Alves  <palves@redhat.com>

* gdb.base/compare-sections.c: New file.
* gdb.base/compare-sections.exp: New file.
gdb/ChangeLog
gdb/NEWS
gdb/doc/ChangeLog
gdb/doc/gdb.texinfo
gdb/remote.c
gdb/target-delegates.c
gdb/target.c
gdb/target.h
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/compare-sections.c [new file with mode: 0644]
gdb/testsuite/gdb.base/compare-sections.exp [new file with mode: 0644]
This page took 0.038425 seconds and 4 git commands to generate.