ld: Allow EXCLUDE_FILE to be used outside of the section list
authorAndrew Burgess <andrew.burgess@embecosm.com>
Tue, 20 Sep 2016 13:21:05 +0000 (14:21 +0100)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Fri, 4 Nov 2016 12:04:11 +0000 (12:04 +0000)
commit8f1732fc2a11dc2dbece0800d4ed6f011590d3ad
treeacc377f4e67f75cfa0b0add266c83e79486aa4a3
parent88bd15396002102beedf49c87adee7b16c2bb409
ld: Allow EXCLUDE_FILE to be used outside of the section list

Currently the EXCLUDE_FILE linker script construct can only be used
within the input section list, and applied only to the section pattern
immediately following the EXCLUDE_FILE.  For example:

    *.o (EXCLUDE_FILE (a.o) .text .rodata)

In this case all sections matching '.text' are included from all files
matching '*.o' but not from the file 'a.o'.  All sections matching
'.rodata' are also included from all files matching '*.o' (incluing from
'a.o').

If the user wants to restrict the inclusion of section '.rodata' so that
this too is not taken from the file 'a.o' then the above example must be
extended like this:

    *.o (EXCLUDE_FILE (a.o) .text EXCLUDE_FILE (a.o) .rodata)

However, due to the internal grammar of the linker script language the
snippet 'EXCLUDE_FILE (a.o) .text' is parsed by a pattern called
'wildcard_spec'.  The same 'wildcard_spec' pattern is also used to parse
the input file name snippet '*.o' in the above examples.  As a result of
this pattern reuse within the linker script grammar then the following
is also a valid linker script construct:

    EXCLUDE_FILE (a.o) *.o (.text .rodata)

However, though the linker accepts this without complaint the
EXCLUDE_FILE part is silently ignored and has no effect.

This commit takes this last example and makes it a useful, valid,
construct.  The last example now means to include sections '.text' and
'.rodata' from all files matching '*.o' except for the file 'a.o'.

If the list of input sections is long, and the user knows that the file
exclusion applies across the list then the second form might be a
clearer alternative to replicating the EXCLUDE_FILE construct.

I've added a set of tests for EXCLUDE_FILE to the linker, including
tests for the new functionality.

ld/ChangeLog:

* ldlang.h (struct lang_wild_statement_struct): Add
exclude_name_list field.
* ldlang.c (walk_wild_file_in_exclude_list): New function.
(walk_wild_consider_section): Use new
walk_wild_file_in_exclude_list function.
(walk_wild_file): Add call to walk_wild_file_in_exclude_list.
(print_wild_statement): Print new exclude_name_list field.
(lang_add_wild): Initialise new exclude_name_list field.
* testsuite/ld-scripts/exclude-file-1.d: New file.
* testsuite/ld-scripts/exclude-file-1.map: New file.
* testsuite/ld-scripts/exclude-file-1.t: New file.
* testsuite/ld-scripts/exclude-file-2.d: New file.
* testsuite/ld-scripts/exclude-file-2.map: New file.
* testsuite/ld-scripts/exclude-file-2.t: New file.
* testsuite/ld-scripts/exclude-file-3.d: New file.
* testsuite/ld-scripts/exclude-file-3.map: New file.
* testsuite/ld-scripts/exclude-file-3.t: New file.
* testsuite/ld-scripts/exclude-file-4.d: New file.
* testsuite/ld-scripts/exclude-file-4.map: New file.
* testsuite/ld-scripts/exclude-file-4.t: New file.
* testsuite/ld-scripts/exclude-file-a.s: New file.
* testsuite/ld-scripts/exclude-file-b.s: New file.
* testsuite/ld-scripts/exclude-file.exp: New file.
* ld.texinfo (Input Section Basics): Update description of
EXCLUDE_FILE to cover the new features.
* NEWS: Mention new EXCLUDE_FILE usage.
20 files changed:
ld/ChangeLog
ld/NEWS
ld/ld.texinfo
ld/ldlang.c
ld/ldlang.h
ld/testsuite/ld-scripts/exclude-file-1.d [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-1.map [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-1.t [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-2.d [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-2.map [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-2.t [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-3.d [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-3.map [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-3.t [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-4.d [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-4.map [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-4.t [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-a.s [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file-b.s [new file with mode: 0644]
ld/testsuite/ld-scripts/exclude-file.exp [new file with mode: 0644]
This page took 0.026668 seconds and 4 git commands to generate.