tipc: fix link attribute propagation bug
authorRichard Alpe <richard.alpe@ericsson.com>
Mon, 1 Feb 2016 07:19:56 +0000 (08:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Feb 2016 07:45:27 +0000 (02:45 -0500)
commitd01332f1acacc0cb43a61f4244dd2b846d4cd585
tree5be9acc08fdcae39457755390df34ae915538e16
parent6247fd9f6a08029003c00633ac67a848077153d2
tipc: fix link attribute propagation bug

Changing certain link attributes (link tolerance and link priority)
from the TIPC management tool is supposed to automatically take
effect at both endpoints of the affected link.

Currently the media address is not instantiated for the link and is
used uninstantiated when crafting protocol messages designated for the
peer endpoint. This means that changing a link property currently
results in the property being changed on the local machine but the
protocol message designated for the peer gets lost. Resulting in
property discrepancy between the endpoints.

In this patch we resolve this by using the media address from the
link entry and using the bearer transmit function to send it. Hence,
we can now eliminate the redundant function tipc_link_prot_xmit() and
the redundant field tipc_link::media_addr.

Fixes: 2af5ae372a4b (tipc: clean up unused code and structures)
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Reported-by: Jason Hu <huzhijiang@gmail.com>
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/link.c
net/tipc/link.h
net/tipc/node.c
This page took 0.025939 seconds and 5 git commands to generate.