Return -1 on memory error in print_insn_msp430
authorYao Qi <yao.qi@linaro.org>
Thu, 12 Jan 2017 09:40:41 +0000 (09:40 +0000)
committerYao Qi <yao.qi@linaro.org>
Thu, 12 Jan 2017 09:40:41 +0000 (09:40 +0000)
commitd95014a2ef6e9aee927c13960fa37e509d46eb32
treef9233ec24b070c2d11888d2cd3f7c1dccc28b5cc
parenteed0b5b26320bfcdb858a6b889dffe4f037f814d
Return -1 on memory error in print_insn_msp430

Disassemblers in opcodes return -1 on memory error, but msp430 doesn't
follow this convention.  If I change GDB not to throw exception in
disassemble_info.memory_error_func and rely on the return value of
disassembler, I'll get the following output.

(gdb) disassemble 0x0,+8
Dump of assembler code from 0x0 to 0x8:
   0x00000000:  .word   0xffff; ????
   0x00000002:  .word   0xffff; ????
   0x00000004:  .word   0xffff; ????
   0x00000006:  .word   0xffff; ????
End of assembler dump.

This patch teaches print_insn_msp430 and its callees to return -1
on memory error.

opcodes:

2017-01-12  Yao Qi  <yao.qi@linaro.org>

* msp430-dis.c (msp430_singleoperand): Return -1 if
msp430dis_opcode_signed returns false.
(msp430_doubleoperand): Likewise.
(msp430_branchinstr): Return -1 if
msp430dis_opcode_unsigned returns false.
(msp430x_calla_instr): Likewise.
(print_insn_msp430): Likewise.
opcodes/ChangeLog
opcodes/msp430-dis.c
This page took 0.025068 seconds and 4 git commands to generate.