tmf: fix concurrency issue in analyses modules (bug 447434)
authorBernd Hufmann <Bernd.Hufmann@ericsson.com>
Wed, 15 Oct 2014 18:26:36 +0000 (14:26 -0400)
committerBernd Hufmann <bernd.hufmann@ericsson.com>
Thu, 23 Oct 2014 01:10:19 +0000 (21:10 -0400)
commite1c415b3ecefb3d43194147b1ab204bc2a4e9c96
treeef888d89ee28a77b7a2c34bef51b526e8d133a54
parent9ad3c628b57fc433d6190abed89283b2183234cc
tmf: fix concurrency issue in analyses modules (bug 447434)

The access of member fTrace in class TmfAbstractAnalysesModule was
not thread-safe. The attribute was set to null when cancelling
the analyses (e.g. in the UI thread).

With this patch this attribute will be accessed (read and write)
using a synchronization lock and it will be checked for null
references before using it.

Additionally, this patch takes care of count down initialization
latches in case of cancellation.

Change-Id: Id632f128242ce85b04b7acdb79264ea466497947
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35347
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
org.eclipse.tracecompass.lttng2.ust.ui/src/org/eclipse/tracecompass/internal/lttng2/ust/ui/views/memusage/MemoryUsageViewer.java
org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/xychart/XmlXYViewer.java
org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/tmf/analysis/xml/ui/views/timegraph/XmlTimeGraphView.java
org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/analysis/TmfAbstractAnalysisModule.java
org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/statesystem/TmfStateSystemAnalysisModule.java
org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/statistics/TmfStatisticsModule.java
org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/analysis/StreamListAnalysis.java
This page took 0.031501 seconds and 5 git commands to generate.