packet: fix match_fanout_group()
authorEric Dumazet <edumazet@google.com>
Fri, 9 Oct 2015 18:29:32 +0000 (11:29 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Oct 2015 02:42:38 +0000 (19:42 -0700)
commit161642e24fee40fba2c5bc2ceacc00d118a22d65
tree41342a8fa391439d545b19145c23b33af9416a6d
parent991659674288dba28c2f5a3d1a0133ef4d20824a
packet: fix match_fanout_group()

Recent TCP listener patches exposed a prior af_packet bug :
match_fanout_group() blindly assumes it is always safe
to cast sk to a packet socket to compare fanout with af_packet_priv

But SYNACK packets can be sent while attached to request_sock, which
are smaller than a "struct sock".

We can read non existent memory and crash.

Fixes: c0de08d04215 ("af_packet: don't emit packet on orig fanout group")
Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Eric Leblond <eric@regit.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c
This page took 0.02671 seconds and 5 git commands to generate.