x86/mm/mtrr: Fix alignment determination in range_to_mtrr()
authorJan Beulich <JBeulich@suse.com>
Fri, 6 Jul 2012 14:07:48 +0000 (15:07 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 10 Jul 2012 08:38:14 +0000 (10:38 +0200)
commit1ba9a294141b106b7247649a5c3372d8284eca80
treecc99056968f74fb5ceaaae380548da3a72cd4f96
parent954e482bde20b0e208fd4d34ef26e10afd194600
x86/mm/mtrr: Fix alignment determination in range_to_mtrr()

With the variable operated on being of "unsigned long" type,
neither ffs() nor fls() are suitable to use on them, as those
truncate their arguments to 32 bits. Using __ffs() and __fls()
respectively at once eliminates the need to subtract 1 from their
results.

Additionally, with the alignment value subsequently used as a
shift count, it must be enforced to be less than BITS_PER_LONG
(and on 64-bit there's no need for it to be any smaller).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Yinghai Lu <yinghai@kernel.org>
Link: http://lkml.kernel.org/r/4FF70D54020000780008E179@nat28.tlf.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/mtrr/cleanup.c
This page took 0.027144 seconds and 5 git commands to generate.