scsi: wd7000: print sector number as 64-bit
authorArnd Bergmann <arnd@arndb.de>
Tue, 21 Jun 2016 09:02:39 +0000 (11:02 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 13 Jul 2016 03:16:31 +0000 (23:16 -0400)
commit40e4c0a4e1d5414ed33e5bc846a832dc868fa65d
tree4078790c1bd3daa1b5855267291bdb7fbb6eed16
parent540eb1eef0aba8bd10b7ebb3dc56cdb9e480164f
scsi: wd7000: print sector number as 64-bit

Enabling format checking in dprintk() shows that wd7000_biosparam uses
an incorrect format string for sector_t:

drivers/scsi/wd7000.c: In function 'wd7000_biosparam':
drivers/scsi/wd7000.c:1594:21: error: format '%d' expects argument of type 'int', but argument 3 has type 'sector_t {aka long long unsigned int}' [-Werror=format=]

As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints
that with the correct format. The change to use no_printk() generally
helps with finding this kind of hidden format string bug, and I found
that when building with "-Wextra", which warned about an empty else
clause in

       } else
              dprintk("ok!\n");

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/wd7000.c
This page took 0.024638 seconds and 5 git commands to generate.