Bluetooth: 6lowpan: Fix kernel NULL pointer dereferences
authorGlenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
Wed, 13 Jan 2016 15:41:42 +0000 (16:41 +0100)
committerJohan Hedberg <johan.hedberg@intel.com>
Sat, 23 Jan 2016 12:21:47 +0000 (12:21 +0000)
commit4c58f3282e3de43d34f8955f8eca676294380bf9
treedbb0b1fe7cf4ebe4fe1496bc0d2e0e969ae3eb16
parent00ae40e71d85ea3fed1b906951ffd80e0321a96d
Bluetooth: 6lowpan: Fix kernel NULL pointer dereferences

The fixes provided in this patch assigns a valid net_device structure to
skb before dispatching it for further processing.

Scenario #1:
============

Bluetooth 6lowpan receives an uncompressed IPv6 header, and dispatches it
to netif. The following error occurs:

Null pointer dereference error #1 crash log:

[  845.854013] BUG: unable to handle kernel NULL pointer dereference at
               0000000000000048
[  845.855785] IP: [<ffffffff816e3d36>] enqueue_to_backlog+0x56/0x240
...
[  845.909459] Call Trace:
[  845.911678]  [<ffffffff816e3f64>] netif_rx_internal+0x44/0xf0

The first modification fixes the NULL pointer dereference error by
assigning dev to the local_skb in order to set a valid net_device before
processing the skb by netif_rx_ni().

Scenario #2:
============

Bluetooth 6lowpan receives an UDP compressed message which needs further
decompression by nhc_udp. The following error occurs:

Null pointer dereference error #2 crash log:

[   63.295149] BUG: unable to handle kernel NULL pointer dereference at
               0000000000000840
[   63.295931] IP: [<ffffffffc0559540>] udp_uncompress+0x320/0x626
               [nhc_udp]

The second modification fixes the NULL pointer dereference error by
assigning dev to the local_skb in the case of a udp compressed packet.
The 6lowpan udp_uncompress function expects that the net_device is set in
the skb when checking lltype.

Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
Signed-off-by: Lukasz Duda <lukasz.duda@nordicsemi.no>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Cc: stable@vger.kernel.org # 4.4+
net/bluetooth/6lowpan.c
This page took 0.025756 seconds and 5 git commands to generate.