i2c: imx: init bus recovery info before adding i2c adapter
authorGao Pan <b54642@freescale.com>
Wed, 9 Dec 2015 03:08:22 +0000 (11:08 +0800)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 9 Dec 2015 10:15:41 +0000 (11:15 +0100)
commit5212f9ae519a3e108205f27eb22929266e688e3e
tree8f947569ad080b363120ef13ac09cae35e362a6e
parenta07f0ad7895303ec37155655229ca2a07080d135
i2c: imx: init bus recovery info before adding i2c adapter

During driver probe, i2c_imx_init_recovery_info() must come before
i2c_add_numbered_adapter(), because the get/set_scl() functions
are assigned in i2c_register_adapter() under the conditon that bus
recover_info are initialized. Otherwise, get/set_scl() function
pointers never get assigned.

In such case, when i2c_generic_gpio_recovery() is used for bus recovery,
there will be kernel crash because bri->set_scl is NULL.

The solution to this bug is moving i2c_imx_init_recovery_info() before
i2c_register_adapter().

Signed-off-by: Gao Pan <b54642@freescale.com>
Signed-off-by: Fugang Duan <B38611@freescale.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
drivers/i2c/busses/i2c-imx.c
This page took 0.026922 seconds and 5 git commands to generate.