target: Fix target_release_cmd_kref shutdown comp leak
authorHimanshu Madhani <himanshu.madhani@qlogic.com>
Tue, 15 Mar 2016 05:47:37 +0000 (22:47 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 22 Mar 2016 07:23:08 +0000 (00:23 -0700)
commit5e47f1985d7107331c3f64fb3ec83d66fd73577e
tree474a8c19f19580200ace94002d8d2ced2a8c4a2d
parent4347ab5a086efcba449e7a6f0a14d1474060006b
target: Fix target_release_cmd_kref shutdown comp leak

This patch fixes an active I/O shutdown bug for fabric
drivers using target_wait_for_sess_cmds(), where se_cmd
descriptor shutdown would result in hung tasks waiting
indefinitely for se_cmd->cmd_wait_comp to complete().

To address this bug, drop the incorrect list_del_init()
usage in target_wait_for_sess_cmds() and always complete()
during se_cmd target_release_cmd_kref() put, in order to
let caller invoke the final fabric release callback
into se_cmd->se_tfo->release_cmd() code.

Reported-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Tested-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c
This page took 0.034714 seconds and 5 git commands to generate.