sched/deadline: Fix wrap-around in DL heap
authorTommaso Cucinotta <tommaso.cucinotta@sssup.it>
Tue, 19 Jul 2016 09:44:50 +0000 (11:44 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 10 Aug 2016 11:32:55 +0000 (13:32 +0200)
commita23eadfae2fd45536a355b785d5a1533e1955c22
treef100911b6c15a24ba247eb94ef477bc5c323fd47
parenta0cba2179ea4c1820fce2ee046b6ed90ecc56196
sched/deadline: Fix wrap-around in DL heap

Current code in cpudeadline.c has a bug in re-heapifying when adding a
new element at the end of the heap, because a deadline value of 0 is
temporarily set in the new elem, then cpudl_change_key() is called
with the actual elem deadline as param.

However, the function compares the new deadline to set with the one
previously in the elem, which is 0.  So, if current absolute deadlines
grew so much to have negative values as s64, the comparison in
cpudl_change_key() makes the wrong decision.  Instead, as from
dl_time_before(), the kernel should handle correctly abs deadlines
wrap-arounds.

This patch fixes the problem with a minimally invasive change that
forces cpudl_change_key() to heapify up in this case.

Signed-off-by: Tommaso Cucinotta <tommaso.cucinotta@sssup.it>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Luca Abeni <luca.abeni@unitn.it>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Juri Lelli <juri.lelli@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1468921493-10054-2-git-send-email-tommaso.cucinotta@sssup.it
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/cpudeadline.c
This page took 0.028704 seconds and 5 git commands to generate.