arc/nps400: Validate address type operands correctly
authorAndrew Burgess <andrew.burgess@embecosm.com>
Tue, 27 Sep 2016 11:06:01 +0000 (12:06 +0100)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Fri, 4 Nov 2016 22:46:51 +0000 (22:46 +0000)
commitb437d035ddf4e4c0c566c577ee059790ed28ad9b
tree54da51c86dd768e89abcbb808a9a9c614fe87a6f
parent848ac659685fba46ce8816400db705f60c8040f7
arc/nps400: Validate address type operands correctly

When we match against an address type operand within an instruction it
is important that we match exactly the right address type operand early
on, during the opcode selection phase.  If we wait until the operand
insertion phase to check that we have the correct address operand, then
it is too late to select an alternative opcode.  This becomes important
only when we have multiple opcodes with the same mnemonic, and operand
lists that differ only in the type of the address operands.

This commit fixes this issue, and adds some example instructions that
require this issue to be fixed (the instructions are identical except
for the address type operand).

gas/ChangeLog:

* config/tc-arc.c (find_opcode_match): Use insert function to
validate matching address type operands.
* testsuite/gas/arc/nps400-10.d: New file.
* testsuite/gas/arc/nps400-10.s: New file.

opcodes/ChangeLog:

* arc-opc.c (arc_flag_operands): Add F_DI14.
(arc_flag_classes): Add C_DI14.
* arc-nps400-tbl.h: Add new exc instructions.
gas/ChangeLog
gas/config/tc-arc.c
gas/testsuite/gas/arc/nps400-10.d [new file with mode: 0644]
gas/testsuite/gas/arc/nps400-10.s [new file with mode: 0644]
opcodes/ChangeLog
opcodes/arc-nps400-tbl.h
opcodes/arc-opc.c
This page took 0.036125 seconds and 4 git commands to generate.