lttng: Do not throw exception if callsite binary is missing

If a trace with debug information is opened on a different machine
than the one where it was taken, it's very possible for the referred
binary files to not be present. In such a case it should not throw
an exception, but simply return that no source callsite information
is available.

The (upcoming) "binary callsite" information should still be available
in such cases though.

Change-Id: I5c3c77d9086b1445b8a1b11e8bb312929321d7f3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/58883
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

diff --git a/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java b/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java
index 724bf56af868a92907dcf5fa50d4d201cc2f8090..fb91b4a6a26295e29d2aab67a67c2fab3a6ddc19 100644 (file)
--- a/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java
@@ -52,7 +52,7 @@ public final class FileOffsetMapper {
      */
     public static @Nullable Iterable<TmfCallsite> getCallsiteFromOffset(File file, long offset) {
         if (!Files.exists((file.toPath()))) {
      */
     public static @Nullable Iterable<TmfCallsite> getCallsiteFromOffset(File file, long offset) {
         if (!Files.exists((file.toPath()))) {

-            throw new IllegalArgumentException();
+            return null;

         }
         return getCallsiteFromOffsetWithAddr2line(file, offset);
     }
         }
         return getCallsiteFromOffsetWithAddr2line(file, offset);
     }