These classes are inner classes, but they do not use its embedded
reference to the object which created them. This reference makes
the instances of the class larger, and may keep the reference to
the creator object alive longer than necessary.
The classes should be static.
Change-Id: I76982a42e10fa89ea7e18524914605d60016fbf3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65036
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
- private class EntityPropertySource implements IPropertySource {
+ private static class EntityPropertySource implements IPropertySource {
private final String fName;
private final String fInstance;
private final String fName;
private final String fInstance;
- private class TypePropertySource implements IPropertySource {
+ private static class TypePropertySource implements IPropertySource {
private final String fType;
private final String fDescr;
private final String fType;
private final String fDescr;
- private class EventPropertySource implements IPropertySource {
+ private static class EventPropertySource implements IPropertySource {
private final ITmfEventField fEventField;
public EventPropertySource(ITmfEventField eventField) {
private final ITmfEventField fEventField;
public EventPropertySource(ITmfEventField eventField) {
private ITmfEvent fEvent;
private ITmfEvent fEvent;
- private class TimestampPropertySource implements IPropertySource {
+ private static class TimestampPropertySource implements IPropertySource {
private static final String ID_TIMESTAMP_VALUE = "timestamp_value"; //$NON-NLS-1$
private static final String ID_TIMESTAMP_SCALE = "timestamp_scale"; //$NON-NLS-1$
private static final String NAME_TIMESTAMP_VALUE = "value"; //$NON-NLS-1$
private static final String ID_TIMESTAMP_VALUE = "timestamp_value"; //$NON-NLS-1$
private static final String ID_TIMESTAMP_SCALE = "timestamp_scale"; //$NON-NLS-1$
private static final String NAME_TIMESTAMP_VALUE = "value"; //$NON-NLS-1$
- private class ContentPropertySource implements IPropertySource {
+ private static class ContentPropertySource implements IPropertySource {
private ITmfEventField fContent;
public ContentPropertySource(ITmfEventField content) {
private ITmfEventField fContent;
public ContentPropertySource(ITmfEventField content) {
- private class SourceLookupPropertySource implements IPropertySource {
+ private static class SourceLookupPropertySource implements IPropertySource {
private static final String ID_FILE_NAME = "callsite_file"; //$NON-NLS-1$
private static final String ID_FUNCTION_NAME = "callsite_function"; //$NON-NLS-1$
private static final String ID_FILE_NAME = "callsite_file"; //$NON-NLS-1$
private static final String ID_FUNCTION_NAME = "callsite_function"; //$NON-NLS-1$
- private final class PainItemListener implements Listener {
+ private static final class PainItemListener implements Listener {
@Override
public void handleEvent(Event event) {
TableItem item = (TableItem) event.item;
@Override
public void handleEvent(Event event) {
TableItem item = (TableItem) event.item;
- private final class EraseItemListener implements Listener {
+ private static final class EraseItemListener implements Listener {
@Override
public void handleEvent(Event event) {
TableItem item = (TableItem) event.item;
@Override
public void handleEvent(Event event) {
TableItem item = (TableItem) event.item;
// Classes
// ------------------------------------------------------------------------
// Classes
// ------------------------------------------------------------------------
- private class TraceEntry extends TimeGraphEntry {
+ private static class TraceEntry extends TimeGraphEntry {
public TraceEntry(String name, long startTime, long endTime) {
super(name, startTime, endTime);
}
public TraceEntry(String name, long startTime, long endTime) {
super(name, startTime, endTime);
}
- private class ThreadEntry extends TimeGraphEntry {
+ private static class ThreadEntry extends TimeGraphEntry {
// The call stack quark
private final int fCallStackQuark;
// The state system from which this entry comes
// The call stack quark
private final int fCallStackQuark;
// The state system from which this entry comes
- private class ThreadNameComparator implements Comparator<ITimeGraphEntry> {
+ private static class ThreadNameComparator implements Comparator<ITimeGraphEntry> {
private boolean reverse;
public ThreadNameComparator(boolean reverse) {
private boolean reverse;
public ThreadNameComparator(boolean reverse) {
- private class ThreadIdComparator implements Comparator<ITimeGraphEntry> {
+ private static class ThreadIdComparator implements Comparator<ITimeGraphEntry> {
private boolean reverse;
public ThreadIdComparator(boolean reverse) {
private boolean reverse;
public ThreadIdComparator(boolean reverse) {
- private class ThreadTimeComparator implements Comparator<ITimeGraphEntry> {
+ private static class ThreadTimeComparator implements Comparator<ITimeGraphEntry> {
private boolean reverse;
public ThreadTimeComparator(boolean reverse) {
private boolean reverse;
public ThreadTimeComparator(boolean reverse) {
- private class CallStackTreeLabelProvider extends TreeLabelProvider {
+ private static class CallStackTreeLabelProvider extends TreeLabelProvider {
@Override
public Image getColumnImage(Object element, int columnIndex) {
@Override
public Image getColumnImage(Object element, int columnIndex) {
* The TreeLabelProviderWrapper is used to intercept the filler items
* from the calls to the tree's real label provider.
*/
* The TreeLabelProviderWrapper is used to intercept the filler items
* from the calls to the tree's real label provider.
*/
- private class TreeLabelProviderWrapper implements ITableLabelProvider {
+ private static class TreeLabelProviderWrapper implements ITableLabelProvider {
private final ITableLabelProvider labelProvider;
public TreeLabelProviderWrapper(ITableLabelProvider labelProvider) {
private final ITableLabelProvider labelProvider;
public TreeLabelProviderWrapper(ITableLabelProvider labelProvider) {
* the time graph combo's real ViewerFilters. These filler items should
* always be visible.
*/
* the time graph combo's real ViewerFilters. These filler items should
* always be visible.
*/
- private class ViewerFilterWrapper extends ViewerFilter {
+ private static class ViewerFilterWrapper extends ViewerFilter {
private ViewerFilter fWrappedFilter;
private ViewerFilter fWrappedFilter;