Since the `event_get_payload_build_id_length()` and
`event_get_payload_build_id_value()` functions, can't fail, make them
return void.
Scan-build report:
Value stored to 'ret' is never read
Reported-by: Scan-Build - Dead assignment
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I950d0d327c19578d9b715e67417afd05f2ac2645
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2201
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Simon Marchi <simon.marchi@efficios.com>
-int event_get_payload_build_id_length(const bt_event *event,
+void event_get_payload_build_id_length(const bt_event *event,
const char *field_name, uint64_t *build_id_len)
{
const bt_field *build_id_field;
const char *field_name, uint64_t *build_id_len)
{
const bt_field *build_id_field;
BT_FIELD_CLASS_TYPE_UNSIGNED_INTEGER);
*build_id_len = bt_field_array_get_length(build_id_field);
BT_FIELD_CLASS_TYPE_UNSIGNED_INTEGER);
*build_id_len = bt_field_array_get_length(build_id_field);
-int event_get_payload_build_id_value(const bt_event *event,
+void event_get_payload_build_id_value(const bt_event *event,
const char *field_name, uint8_t *build_id)
{
const bt_field *curr_field, *build_id_field;
const bt_field_class *build_id_field_class;
uint64_t i, build_id_len;
const char *field_name, uint8_t *build_id)
{
const bt_field *curr_field, *build_id_field;
const bt_field_class *build_id_field_class;
uint64_t i, build_id_len;
build_id_field = event_borrow_payload_field(event, field_name);
build_id_field_class = bt_field_borrow_class_const(build_id_field);
build_id_field = event_borrow_payload_field(event, field_name);
build_id_field_class = bt_field_borrow_class_const(build_id_field);
for (i = 0; i < build_id_len; i++) {
curr_field = bt_field_array_borrow_element_field_by_index_const(
for (i = 0; i < build_id_len; i++) {
curr_field = bt_field_array_borrow_element_field_by_index_const(
build_id[i] = bt_field_integer_unsigned_get_value(curr_field);
}
build_id[i] = bt_field_integer_unsigned_get_value(curr_field);
}
- ret = event_get_payload_build_id_length(event, BUILD_ID_FIELD_NAME,
+
+ event_get_payload_build_id_length(event, BUILD_ID_FIELD_NAME,
&build_id_len);
build_id = g_new0(uint8_t, build_id_len);
&build_id_len);
build_id = g_new0(uint8_t, build_id_len);
- ret = event_get_payload_build_id_value(event, BUILD_ID_FIELD_NAME,
- build_id);
- if (ret) {
- goto end;
- }
+ event_get_payload_build_id_value(event, BUILD_ID_FIELD_NAME, build_id);
ret = bin_info_set_build_id(bin, build_id, build_id_len);
if (ret) {
ret = bin_info_set_build_id(bin, build_id, build_id_len);
if (ret) {